gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.h (is_ada_exception_catchpoint): Declare.
   4         * breakpoint.c (init_ada_exception_breakpoint): Register as
   5         bp_catchpoint.
   6         (print_one_breakpoint_location, print_one_breakpoint): Use
   7         is_ada_exception_catchpoint.
   8         * ada-lang.c (class ada_catchpoint_location): Pass
   9         bp_loc_software_breakpoint to bp_location constructor.
  10         (is_ada_exception_catchpoint): New function.
  11
  12 2019-07-10  Tom Tromey  <tromey@adacore.com>
  13
  14         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
  15         VEC.
  16         (struct arm_exidx_entry): New method operator<.
  17         (struct arm_exidx_data) <section_maps>: Change type.
  18         (arm_exidx_data_free): Remove.
  19         (arm_exidx_data_key): Change type.  Move lower.
  20         (arm_exidx_new_objfile): Update.
  21         (arm_compare_exidx_entries): Remove.
  22         (arm_find_exidx_entry, _initialize_arm_tdep)
  23
  24 2019-07-10  Tom Tromey  <tromey@adacore.com>
  25
  26         * solib-spu.c (ocl_program_data_key): Change type.
  27         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
  28         Update.
  29
  30 2019-07-10  Tom Tromey  <tromey@adacore.com>
  31
  32         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
  33         (struct solib_aix_inferior_data) <library_list>: Change type.
  34         (solib_aix_inferior_data_handle): Change type.
  35         (get_solib_aix_inferior_data): Update.
  36         (solib_aix_free_library_list): Remove.
  37         (library_list_start_library): Update.
  38         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
  39         return type.
  40         (solib_aix_get_library_list)
  41         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
  42         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
  43
  44 2019-07-10  Tom Tromey  <tromey@adacore.com>
  45
  46         * solib-dsbt.c (struct dsbt_info): Add initializers.
  47         (solib_dsbt_pspace_data): Change type.
  48         (dsbt_pspace_data_cleanup): Remove.
  49         (get_dsbt_info, _initialize_dsbt_solib): Update.
  50
  51 2019-07-10  Tom Tromey  <tromey@adacore.com>
  52
  53         * spu-tdep.c (spu_overlay_data): Change type.
  54         (spu_get_overlay_table, spu_overlay_new_objfile)
  55         (_initialize_spu_tdep): Update.
  56
  57 2019-07-10  Tom Tromey  <tromey@adacore.com>
  58
  59         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  60         destructor.
  61         (dbx_objfile_data_key): Change type and declare later.
  62         (DBX_SYMFILE_INFO): Rewrite.
  63         * dbxread.c (dbx_objfile_data_key): Change type.
  64         (dbx_symfile_init): Update.
  65         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  66         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  67         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  68
  69 2019-07-10  Tom Tromey  <tromey@adacore.com>
  70
  71         * jit.c (jit_program_space_key): Change type.  Move lower.
  72         (get_jit_program_space_data): Update.
  73         (jit_program_space_data_cleanup): Remove.
  74         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  75         Update.
  76         (struct jit_program_space_data): Add initializers.
  77
  78 2019-07-10  Tom Tromey  <tromey@adacore.com>
  79
  80         * solib-darwin.c (struct darwin_info): Add initializers.
  81         (solib_darwin_pspace_data): Change type.
  82         (darwin_pspace_data_cleanup): Remove.
  83         (get_darwin_info, _initialize_darwin_solib): Update.
  84
  85 2019-07-10  Tom Tromey  <tromey@adacore.com>
  86
  87         * remote-sim.c (struct sim_inferior_data): Add initializers,
  88         constructor, and destructor.
  89         (sim_inferior_data_key): Change type.  Move lower.
  90         (check_for_duplicate_sim_descriptor): Update.
  91         (get_sim_inferior_data): Use new.  Update.
  92         (~sim_inferior_data_cleanup): Rename from
  93         sim_inferior_data_cleanup.  Simplify.
  94         (gdbsim_close_inferior, simulator_command)
  95         (sim_command_completer, _initialize_remote_sim): Update.
  96         (next_pid, INITIAL_PID): Move earlier.
  97
  98 2019-07-10  Tom Tromey  <tromey@adacore.com>
  99
 100         * python/python-internal.h (create_thread_object): Return
 101         gdbpy_ref.
 102         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 103         * python/py-inferior.c (struct threadlist_entry): Add
 104         constructor.
 105         <thread_obj>: Now a gdbpy_ref.
 106         (thread_to_thread_object): Update.
 107         (add_thread_object): Use new.
 108         (delete_thread_object): Use delete.
 109         (infpy_threads): Update.
 110         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 111         GIL.
 112
 113 2019-07-10  Tom Tromey  <tromey@adacore.com>
 114
 115         * valops.c (value_cast): Specialize error message for Ada.
 116
 117 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 120
 121 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 122
 123         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 124         bpstat_should_step): Return bool, adjust comments.
 125         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 126         bpstat_should_step): Likewise.
 127
 128 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * features/Makefile: Use feature target descriptions for Arm.
 131         * features/arm/arm-core.c: Generate new file.
 132         * features/arm/arm-fpa.c: Likewise.
 133         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 134         * features/arm/arm-m-profile.c: Likewise.
 135         * features/arm/arm-vfpv2.c: Likewise.
 136         * features/arm/arm-vfpv3.c: Likewise.
 137         * features/arm/xscale-iwmmxt.c: Likewise.
 138         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 139
 140 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 141
 142         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 143         ptrace earlier.
 144
 145 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 146
 147         * features/aarch64-pauth.c: Regenerate.
 148
 149 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 150
 151         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 152         bool.
 153         (bpstat_what): Use false instead of 0.
 154
 155 2019-07-09  Pedro Alves  <palves@redhat.com>
 156
 157         * break-catch-throw.c (is_exception_catchpoint): New.
 158         * breakpoint.c (print_one_breakpoint_location): New parameter
 159         'raw_loc'.  Handle it.  Use
 160         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 161         looking at the breakpoint's type.
 162         (print_one_breakpoint): If handling "maint info breakpoints", also
 163         print locations of exception catchpoints.
 164         * breakpoint.h (is_exception_catchpoint): Declare.
 165
 166 2019-07-09  Pedro Alves  <palves@redhat.com>
 167
 168         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 169         "addr" field.
 170         (allocate_location_exception_catchpoint): New.
 171         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 172         (initialize_throw_catchpoint_ops): Install
 173         allocate_location_exception_catchpoint as allocate_location
 174         method.
 175         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 176         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 177         bp_loc_other.
 178         (breakpoint_address_is_meaningful): Delete.
 179         (bl_address_is_meaningful): New.
 180         (breakpoint_locations_match): Adjust comment.
 181         (bp_location_from_bp_type): New, factored out of...
 182         (bp_location::bp_location(breakpoint *)): ... this.
 183         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 184         factored out of...
 185         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 186         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 187         breakpoint_address_is_meaningful.
 188         (bp_locations_compare): Adjust comment.
 189         (update_global_location_list): Use bl_address_is_meaningful
 190         instead of breakpoint_address_is_meaningful.
 191         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 192         explicit.
 193         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 194         * python/py-breakpoint.c (bppy_get_location): No longer check
 195         whether location is null.
 196
 197 2019-07-09  Pedro Alves  <palves@redhat.com>
 198
 199         PR c++/15468
 200         * breakpoint.c (print_one_breakpoint_location): Remove
 201         single-location assert.
 202
 203 2019-07-09  Tom Tromey  <tom@tromey.com>
 204
 205         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 206         * configure: Rebuild.
 207         * configure.ac: Change common to gdbsupport.
 208         * gdbsupport: Rename from common.
 209         * acinclude.m4: Change common to gdbsupport.
 210         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 211         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 212         gdbsupport.
 213         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 214         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 215         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 216         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 217         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 218         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 219         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 220         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 221         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 222         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 223         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 224         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 225         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 226         coff-pe-read.c, command.h, compile/compile-c-support.c,
 227         compile/compile-c.h, compile/compile-cplus-symbols.c,
 228         compile/compile-cplus-types.c, compile/compile-cplus.h,
 229         compile/compile-loc2c.c, compile/compile.c, completer.c,
 230         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 231         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 232         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 233         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 234         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 235         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 236         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 237         features/aarch64-core.c, features/aarch64-fpu.c,
 238         features/aarch64-pauth.c, features/aarch64-sve.c,
 239         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 240         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 241         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 242         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 243         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 244         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 245         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 246         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 247         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 248         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 249         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 250         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 251         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 252         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 253         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 254         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 255         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 256         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 257         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 258         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 259         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 260         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 261         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 262         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 263         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 264         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 265         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 266         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 267         minsyms.c, mips-linux-tdep.c, namespace.h,
 268         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 269         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 270         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 271         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 272         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 273         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 274         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 275         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 276         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 277         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 278         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 279         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 280         procfs.c, producer.c, progspace.h, psymtab.h,
 281         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 282         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 283         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 284         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 285         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 286         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 287         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 288         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 289         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 290         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 291         target-memory.c, target.c, target.h, target/waitstatus.c,
 292         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 293         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 294         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 295         unittests/array-view-selftests.c,
 296         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 297         unittests/common-utils-selftests.c,
 298         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 299         unittests/format_pieces-selftests.c,
 300         unittests/function-view-selftests.c,
 301         unittests/lookup_name_info-selftests.c,
 302         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 303         unittests/mkdir-recursive-selftests.c,
 304         unittests/observable-selftests.c,
 305         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 306         unittests/parse-connection-spec-selftests.c,
 307         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 308         unittests/scoped_fd-selftests.c,
 309         unittests/scoped_mmap-selftests.c,
 310         unittests/scoped_restore-selftests.c,
 311         unittests/string_view-selftests.c, unittests/style-selftests.c,
 312         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 313         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 314         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 315         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 316         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 317         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 318
 319 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 320
 321         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 322         bool value.
 323         (decode_digits_ordinary): Set explicit_line field in sal.
 324         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 325         symtab_and_line that was set on an explicit line number in
 326         assembler code.  Do always update the recorded symtab and line if
 327         we do skip the prologue.
 328
 329 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 330
 331         * breakpoint.c (set_breakpoint_location_function): Remove
 332         explicit_loc parameter.
 333         (momentary_breakpoint_from_master): Update call to
 334         set_breakpoint_location_function.
 335         (add_location_to_breakpoint): Likewise.
 336
 337 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 340         required features based on default bfd type when no specific bfd
 341         is present.
 342
 343 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 344
 345         * NEWS: Mention that GDB printf and eval commands can now print
 346         C-style and Ada-style convenience var strings without
 347         calling the inferior.
 348         * printcmd.c (printf_c_string): Locally print GDB internal var
 349         instead of transiting via the inferior.
 350         (printf_wide_c_string): Likewise.
 351
 352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 353
 354         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 355
 356 2019-07-04  Tom Tromey  <tom@tromey.com>
 357
 358         PR tui/24724:
 359         * tui/tui-winsource.c (tui_clear_source_content): Update.
 360         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 361         (tui_update_breakpoint_info): Update.
 362         (tui_set_exec_info_content): Update.
 363         * tui/tui-source.c (tui_set_source_content_nil): Update.
 364         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 365         has_break.
 366         * tui/tui-data.h (enum tui_bp_flag): New.
 367         (tui_bp_flags): New enum flags type.
 368         (struct tui_source_element) <break_mode>: Change type.  Rename
 369         from has_break.
 370         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 371         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 372         constants.
 373         * tui/tui-winsource.h: Fix comment.
 374
 375 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 376
 377         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 378         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 379         (store_fpregs_to_thread)
 380         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 381         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 382         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 383         (IWMMXT_REGS_SIZE): Add define.
 384         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 385         (fetch_vfp_regs, store_vfp_regs)
 386         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 387         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 388
 389 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 390
 391         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 392         defines.
 393         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 394         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 395         (ARM_INT_REGISTER_SIZE): ...to this.
 396         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 397         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 398         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 399         (arm_linux_collect_gregset, supply_nwfpe_register)
 400         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 401         defines.
 402         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 403         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 404         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 405         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 406         (arm_return_in_memory, arm_store_return_value)
 407         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 408         (arm_record_ld_st_multiple): Likewise.
 409         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 410         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 411
 412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 413
 414         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 415         AARCH64_DISPLACED_MODIFIED_INSNS.
 416         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 417         (aarch64_displaced_step_copy_insn): Likewise.
 418         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 419         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 420         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 421         ARM_DISPLACED_MODIFIED_INSNS.
 422         * arm-tdep.c (arm_gdbarch_init): Likewise.
 423         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 424         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 425         (struct arm_displaced_step_closure): Use
 426         ARM_DISPLACED_MODIFIED_INSNS.
 427
 428 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 429
 430         * features/Makefile: Remove unused xml files.
 431         * features/aarch64.xml: Remove.
 432         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 433         * features/i386/amd64-avx-avx512.xml: Remove.
 434         * features/i386/amd64-avx-linux.xml: Remove.
 435         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 436         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 437         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 438         * features/i386/amd64-avx-mpx.xml: Remove.
 439         * features/i386/amd64-avx.xml: Remove.
 440         * features/i386/amd64-linux.xml: Remove.
 441         * features/i386/amd64-mpx-linux.xml: Remove.
 442         * features/i386/amd64-mpx.xml: Remove.
 443         * features/i386/amd64.xml: Remove.
 444         * features/i386/i386-avx-avx512-linux.xml: Remove.
 445         * features/i386/i386-avx-avx512.xml: Remove.
 446         * features/i386/i386-avx-linux.xml: Remove.
 447         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 448         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 449         * features/i386/i386-avx-mpx-linux.xml: Remove.
 450         * features/i386/i386-avx-mpx.xml: Remove.
 451         * features/i386/i386-avx.xml: Remove.
 452         * features/i386/i386-linux.xml: Remove.
 453         * features/i386/i386-mmx-linux.xml: Remove.
 454         * features/i386/i386-mmx.xml: Remove.
 455         * features/i386/i386-mpx-linux.xml: Remove.
 456         * features/i386/i386-mpx.xml: Remove.
 457         * features/i386/i386.xml: Remove.
 458         * features/i386/x32-avx-avx512-linux.xml: Remove.
 459         * features/i386/x32-avx-linux.xml: Remove.
 460         * features/i386/x32-linux.xml: Remove.
 461
 462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 463
 464         * regformats/aarch64.dat: Remove.
 465         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 466         * regformats/i386/amd64-avx-linux.dat: Remove.
 467         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 468         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 469         * regformats/i386/amd64-linux.dat: Remove.
 470         * regformats/i386/amd64-mpx-linux.dat: Remove.
 471         * regformats/i386/amd64.dat: Remove.
 472         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 473         * regformats/i386/i386-avx-linux.dat: Remove.
 474         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 475         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 476         * regformats/i386/i386-linux.dat: Remove.
 477         * regformats/i386/i386-mmx-linux.dat: Remove.
 478         * regformats/i386/i386-mpx-linux.dat: Remove.
 479         * regformats/i386/i386.dat: Remove.
 480         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 481         * regformats/i386/x32-avx-linux.dat: Remove.
 482         * regformats/i386/x32-linux.dat: Remove.
 483
 484 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 485
 486         * aarch64-tdep.c: Remove xml self tests.
 487         * amd64-linux-tdep.c: Likewise.
 488         * amd64-tdep.c: Likewise.
 489         * i386-linux-tdep.c: Likewise.
 490         * i386-tdep.c: Likewise.
 491
 492 2019-07-03  Pedro Alves  <palves@redhat.com>
 493
 494         PR cli/24732
 495         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 496         (pipe_cmd_option_defs): New.
 497         (make_pipe_cmd_options_def_group): New.
 498         (pipe_command): Use gdb::option::process_options.
 499         (pipe_command_completer): New function.
 500         (_initialize_cli_cmds): Install completer for "pipe" command.
 501
 502 2019-07-03  Pedro Alves  <palves@redhat.com>
 503
 504         * cli/cli-option.c (union option_value) <string>: New field.
 505         (struct option_def_and_value): Add ctor, move ctor, dtor and
 506         use DISABLE_COPY_AND_ASSIGN.
 507         (option_def_and_value::clear_value): New.
 508         (parse_option, save_option_value_in_ctx, get_val_type_str)
 509         (add_setshow_cmds_for_options): Handle var_string.
 510         * cli-option.h (union option_def::var_address) <string>: New
 511         field.
 512         (struct string_option_def): New.
 513         * maint-test-options.c (struct test_options_opts): Add default
 514         ctor and use DISABLE_COPY_AND_ASSIGN.
 515         <string_opt>: New field.
 516         (test_options_opts::~test_options_opts): New.
 517         (test_options_opts::dump): Also dump "-string".
 518         (test_options_option_defs): Install "string.
 519
 520 2019-07-03  Pedro Alves  <palves@redhat.com>
 521
 522         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 523         option_value with a null enumeration.
 524         (complete_options): Save the option values in the context.
 525         (save_option_value_in_ctx): New, factored out from ...
 526         (process_options): ... here.
 527         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 528         of the function.
 529         * maint-test-options.c (test_options_opts::dump): New, factored
 530         out from ...
 531         (maintenance_test_options_command_mode): ... here.
 532         (maintenance_test_options_command_completion_result): Delete.
 533         (maintenance_test_options_command_completion_text): Update
 534         comment.
 535         (maintenance_show_test_options_completion_result): Change
 536         prototype.  Just print
 537         maintenance_test_options_command_completion_text.
 538         (save_completion_result): New.
 539         (maintenance_test_options_completer_mode): Pass options context to
 540         complete_options, and then save a dump.
 541         (_initialize_maint_test_options): Use add_cmd to install "maint
 542         show test-options-completion-result".
 543
 544 2019-07-03  Pedro Alves  <palves@redhat.com>
 545
 546         * NEWS (New commands): Mention "with" and "maint with".
 547         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 548         (with_command, with_command_completer): New.
 549         (pipe_command): Adjust to new repeat_previous
 550         interface.
 551         (_initialize_cli_cmds): Install the "with" command and its "w"
 552         alias.
 553         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 554         declarations.
 555         * cli/cli-setshow.c (parse_cli_var_uinteger)
 556         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 557         argument strings for all var_types.
 558         (get_setshow_command_value_string): New, factored out from ...
 559         (do_show_command): ... this.
 560         * cli/cli-setshow.h: Include <string>.
 561         (get_setshow_command_value_string): Declare.
 562         * command.h (repeat_previous): Now returns const char *.  Adjust
 563         comment.
 564         * maint.c: Include "cli/cli-cmds.h".
 565         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 566         (_initialize_maint_cmds): Register the "maintenance with" command.
 567         * top.c (repeat_previous): Move bits from pipe_command here:
 568         Return the saved command line, if any; error out if there's no
 569         command to relaunch.
 570
 571 2019-07-03  Pedro Alves  <palves@redhat.com>
 572
 573         * NEWS (New commands): Mention "maint set/show test-settings"
 574         instead of "maint test-settings".
 575         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 576         (maintenance_test_settings_set_list): Rename to ...
 577         (maintenance_set_test_settings_list): ... this.
 578         (maintenance_test_settings_show_list): Rename to  ...
 579         (maintenance_show_test_settings_list): ... this.
 580         (maintenance_test_settings_cmd): Delete.
 581         (maintenance_test_settings_set_cmd): ...
 582         (maintenance_set_test_settings_cmd): ... this.
 583         (maintenance_test_settings_show_cmd): ...
 584         (maintenance_show_test_settings_cmd): ... this.
 585         (maintenance_test_settings_show_value_cmd):
 586         (maintenance_show_test_settings_value_cmd): ... this.
 587         (_initialize_maint_test_settings): No longer install the "maint
 588         test-settings" prefix command.  Rename "maint test-settings set"
 589         to "maint set test-settings", and "maint test-settings show" to
 590         "maint show test-settings".  Adjust all subcommands.
 591
 592 2019-07-03  Pedro Alves  <palves@redhat.com>
 593
 594         * maint-test-settings.c: Fix file's intro comment.  Replace all
 595         references to "test-options" with references to "test-settings",
 596         in comments.
 597
 598 2019-07-03  Pedro Alves  <palves@redhat.com>
 599
 600         * maint-test-settings.c (maintenance_test_settings_xxx)
 601         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 602         New.
 603         (maintenance_test_settings_enums): Use them.
 604         (maintenance_test_settings_enum): Default to
 605         maintenance_test_settings_xxx.
 606         (_initialize_maint_test_settings): Initialize
 607         MAINTENANCE_TEST_SETTINGS_FILENAME.
 608
 609 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 610
 611         * breakpoint.h (remove_breakpoints_inf): Change return type to
 612         void, move function documentation here.
 613         * breakpoint.c (remove_breakpoints_inf): Change return type to
 614         void, move function documentation to header.
 615
 616 2019-07-02  Pedro Alves  <palves@redhat.com>
 617
 618         * NEWS (Completion improvements): Mention "info threads".
 619         * thread.c (struct info_threads_opts, info_threads_option_defs)
 620         (make_info_threads_options_def_group): New.
 621         (info_threads_command): Use gdb::option::process_options.
 622         (info_threads_command_completer): New.
 623         (_initialize_thread): Use gdb::option::build_help to build the
 624         help text for "info threads".
 625
 626 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 627
 628         * defs.h (generic_load): Move from here...
 629         * symfile.h (generic_load): ... to here.  Rename name parameter
 630         to args.
 631         * symfile.c (generic_load): Add comment.
 632
 633 2019-07-01  Tom Tromey  <tromey@adacore.com>
 634
 635         * dwarf2read.c
 636         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 637         declaration of without_params.  Fix formatting.
 638
 639 2019-07-01  Tom Tromey  <tromey@adacore.com>
 640
 641         * ada-exp.y (find_primitive_type): Update.
 642         * ada-lang.h (ada_lookup_symbol): Update.
 643         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 644         parameter.
 645         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 646
 647 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 648
 649         PR breakpoints/24541
 650         * gdbarch.c: Regenerate.
 651         * gdbarch.h: Regenerate.
 652         * gdbarch.sh: Add 'stap_adjust_register'.
 653         * i386-tdep.c: Include '<unordered_set>'.
 654         (i386_stap_adjust_register): New function.
 655         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 656         * stap-probe.c (stap_parse_register_operand): Call
 657         'gdbarch_stap_adjust_register'.
 658
 659 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 660
 661         PR python/24742
 662         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 663         * python/python.c (do_start_initialization): Use 'xmalloc'
 664         instead of 'PyMem_Malloc'.
 665
 666 2019-06-28  Tom Tromey  <tromey@adacore.com>
 667
 668         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 669         for Ada.
 670
 671 2019-06-27  Tom Tromey  <tromey@adacore.com>
 672
 673         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 674         objfile_key.
 675         (arm_find_mapping_symbol, arm_record_special_symbol)
 676         (_initialize_arm_tdep): Update.
 677         (arm_objfile_data_free): Remove.
 678
 679 2019-06-27  Tom Tromey  <tromey@adacore.com>
 680
 681         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 682         to cp_print_static_field.
 683
 684 2019-06-26  Tom Tromey  <tromey@adacore.com>
 685
 686         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 687         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 688         declare.
 689
 690 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * features/aarch64-core.c (create_feature_aarch64_core):
 693         Regenerate.
 694         * features/aarch64-core.xml: Add cpsr flags.
 695
 696 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 697
 698         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 699         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 700
 701 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 702
 703         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 704         field.
 705         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 706         use.
 707         (arm_record_special_symbol): Don't insert new symbol in sorted
 708         position, push it at the end.
 709
 710 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 711
 712         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 713         (arm_mapping_symbol_s): Remove.
 714         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 715         (arm_mapping_symbol_vec): New typedef.
 716         (struct arm_per_objfile): Add constructor.
 717         <section_maps>: Change type to
 718         std::unique_ptr<arm_mapping_symbol_vec[]>.
 719         (arm_compare_mapping_symbols): Remove.
 720         (arm_find_mapping_symbol): Adjust to section_maps type change.
 721         (arm_objfile_data_free): Call delete on arm_per_objfile.
 722         (arm_record_special_symbol): Adjust to section_maps type change.
 723         Allocate arm_per_objfile with new.
 724
 725 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 726
 727         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 728         with the command prefix.
 729
 730 2019-06-25  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 733         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 734
 735 2019-06-25  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 738         type.
 739         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 740         protected.
 741
 742 2019-06-25  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-winsource.c
 745         (tui_source_window_base::set_is_exec_point_at): Add check against
 746         LOA_ADDRESS.
 747
 748 2019-06-25  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-source.c (tui_set_source_content): Don't check before
 751         xfree.
 752         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 753
 754 2019-06-25  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-winsource.h (tui_update_source_window_as_is)
 757         (tui_alloc_source_buffer, tui_line_is_displayed)
 758         (tui_addr_is_displayed): Change type of win_info.
 759         * tui/tui-winsource.c (tui_update_source_window_as_is)
 760         (tui_clear_source_content, tui_show_source_line)
 761         (tui_show_source_content, tui_source_window_base::refill)
 762         (tui_source_window_base::set_is_exec_point_at)
 763         (tui_source_window_base::set_is_exec_point_at)
 764         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 765         (tui_alloc_source_buffer, tui_line_is_displayed)
 766         (tui_addr_is_displayed): Change type of win_info.  Update.
 767         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 768         (tui_source_window_base::do_make_visible_with_new_height):
 769         Update.
 770         * tui/tui-source.c (tui_set_source_content)
 771         (tui_set_source_content_nil)
 772         (tui_source_window::do_scroll_vertical): Update.
 773         * tui/tui-layout.c (show_layout): Update.
 774         * tui/tui-disasm.c (tui_set_disassem_content)
 775         (tui_disasm_window::do_scroll_vertical): Update.
 776         * tui/tui-data.h (tui_win_content): Remove.
 777         (struct tui_gen_win_info) <content, content_size>: Remove.
 778         (struct tui_source_element): Add initializers and destructor.
 779         (union tui_which_element, struct tui_win_element): Remove.
 780         (struct tui_source_window_base) <content>: New field.
 781         (struct tui_data_window): Remove destructor.
 782         (tui_alloc_content, tui_free_win_content)
 783         (tui_free_all_source_wins_content): Don't declare.
 784         * tui/tui-data.c (tui_initialize_static_data): Update.
 785         (init_content_element, tui_alloc_content): Remove.
 786         (~tui_gen_win_info): Update.
 787         (~tui_data_window, tui_free_all_source_wins_content)
 788         (tui_free_win_content, free_content, free_content_elements):
 789         Remove.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-winsource.h (tui_clear_source_content)
 794         (tui_erase_source_content, tui_show_source_content): Change type
 795         of win_info.
 796         * tui/tui-winsource.c (tui_clear_source_content)
 797         (tui_erase_source_content, tui_show_source_content): Change type
 798         of win_info.
 799         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 800         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 801         win_info.
 802         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 803         win_info.
 804         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 805
 806 2019-06-25  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-winsource.c (tui_clear_source_content)
 809         (tui_source_window_base::set_is_exec_point_at): Update.
 810         * tui/tui-source.c (tui_set_source_content_nil): Update.
 811         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 812         a bool.
 813         * tui/tui-data.c (init_content_element): Update.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 818         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 819         * tui/tui-layout.c (init_and_make_win): Update.
 820         * tui/tui.h (enum tui_win_type): Update.
 821         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 822         tui_win_is_auxillary.
 823         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 824         tui_win_is_auxillary.
 825
 826 2019-06-25  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 829         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 830         (tui_delete_data_content_windows, tui_display_all_data)
 831         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 832         Update.
 833         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 834         * tui/tui-regs.c (tui_last_regs_line_no)
 835         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 836         (tui_show_registers): Update.
 837         (tui_show_register_group): Return void.  Update.
 838         (tui_display_registers_from, tui_display_reg_element_at_line)
 839         (tui_display_registers_from_line, tui_check_register_values):
 840         Update.
 841         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 842         member.
 843         (struct tui_data_window) <regs_content>: Now a std::vector.
 844         <regs_content_count>: Remove.
 845         (tui_add_content_elements, tui_free_data_content): Don't declare.
 846         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 847         (init_content_element): Remove DATA_WIN case.  Add assert.
 848         (tui_add_content_elements): Remove.
 849         (tui_data_window): Update.
 850         (tui_free_data_content): Remove.
 851         (free_content_elements): Remove DATA_WIN case.
 852
 853 2019-06-25  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-data.c (tui_data_item_window): Update.
 856         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 857         * tui/tui-windata.c (tui_display_all_data)
 858         (tui_display_data_from_line): Update.
 859         (tui_check_data_values): Remove.
 860         * tui/tui-regs.c (tui_show_register_group)
 861         (tui_display_reg_element_at_line): Update.
 862         * tui/tui-hooks.c (tui_register_changed)
 863         (tui_refresh_frame_and_register_information): Call
 864         tui_check_register_values.
 865         * tui/tui-data.h (struct tui_data_window) <data_content,
 866         data_content_count, data_type>: Remove.
 867         (enum tui_data_type): Remove.
 868
 869         * tui/tui-data.c (tui_data_window::clear_detail)
 870         (~tui_data_window): Update.
 871
 872 2019-06-25  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 875         declare.
 876         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 877         Rename from tui_first_data_item_displayed.  Update.
 878         (tui_data_window::refresh_all)
 879         (tui_data_window::do_scroll_vertical): Update.
 880         * tui/tui-data.h (struct tui_data_window)
 881         <first_data_item_displayed>: Declare new method.
 882
 883 2019-06-25  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 886         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 887         contents...
 888         (tui_initialize_static_data): ...here.
 889
 890 2019-06-25  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 893         (tui_display_registers_from, tui_check_register_values): Update.
 894         (tui_display_register): Remove win_info parameter; update.
 895         (tui_get_register): Change type of parameters.
 896         * tui/tui-data.h (struct tui_data_element): Remove.
 897         (union tui_which_element) <data>: Remove.
 898         <data_window>: Change type.
 899         (struct tui_data_item_window): New.
 900         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 901         case.  Add assert.
 902         (~tui_data_item_window): New destructor.
 903         (free_content_elements): Remove DATA_ITEM_WIN case.
 904
 905 2019-06-25  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 908         Remove.
 909
 910 2019-06-25  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-data.h (struct tui_command_element): Remove.
 913         (union tui_which_element) <command>: Remove.
 914         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 915         assert.
 916         (free_content_elements): Remove CMD_WIN case.
 917
 918 2019-06-25  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-layout.c (tui_set_layout): Update.
 921         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 922         * tui/tui-data.c (layout_def): Update.
 923
 924 2019-06-25  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 927         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 928         (tui_source_window_base::set_new_height): Update.
 929         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 930         Update.
 931         (tui_set_locator_fullname, tui_set_locator_info)
 932         (tui_show_frame_info): Update.
 933         * tui/tui-source.c (tui_set_source_content)
 934         (tui_source_is_displayed): Update.
 935         * tui/tui-layout.c (show_source_disasm_command, show_data)
 936         (show_source_or_disasm_and_command): Update.
 937         * tui/tui-disasm.c (tui_set_disassem_content)
 938         (tui_get_begin_asm_address): Update.
 939         * tui/tui-data.h (struct tui_locator_element): Remove.
 940         (union tui_which_element) <locator>: Remove.
 941         (struct tui_locator_window): New.
 942         (tui_locator_win_info_ptr): Change return type.
 943         * tui/tui-data.c (_locator): Change type.
 944         (tui_locator_win_info_ptr): Change return type.
 945         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 946         (tui_alloc_content): Add assert.
 947
 948 2019-06-25  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-winsource.c
 951         (tui_exec_info_window::maybe_allocate_content): New method.
 952         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 953         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 954         (make_source_or_disasm_window): Add cast.
 955         * tui/tui-data.h (union tui_which_element) <simple_string>:
 956         Remove.
 957         (struct tui_source_info): New.
 958         (struct tui_source_window_base) <execution_info>: Change type.
 959         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 960         case, and add assert.
 961         (tui_alloc_content): Add assert.
 962
 963 2019-06-25  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 966         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 967         * tui/tui-data.c (tui_alloc_win_info): Remove.
 968
 969 2019-06-25  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 972         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 973         can_highlight.
 974
 975 2019-06-25  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 978         make_visible_with_new_height method.
 979         (tui_win_info::make_visible_with_new_height): New method.
 980         (tui_source_window_base::do_make_visible_with_new_height)
 981         (tui_data_window::do_make_visible_with_new_height)
 982         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 983         (make_visible_with_new_height): Remove.
 984         (tui_resize_all, tui_adjust_win_heights): Use
 985         make_visible_with_new_height method.
 986         * tui/tui-data.h (struct tui_win_info)
 987         <do_make_visible_with_new_height, make_visible_with_new_height>:
 988         New methods.
 989         (struct tui_source_window_base, struct tui_data_window)
 990         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 991         methods.
 992
 993 2019-06-25  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 996         method.
 997         (update_tab_width): Call update_tab_width method.
 998         * tui/tui-data.h (struct tui_win_info)
 999         (struct tui_source_window_base) <update_tab_width>: New methods.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1004         parameter.
1005         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1006         parameter.
1007         (tui_gen_win_info::make_visible): Update.
1008         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1009         parameter.
1010         * tui/tui-data.h (enum tui_box): New enum.
1011         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1016         init_and_make_win for EXEC_INFO_WIN.
1017         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1018         longer inline.
1019         (struct tui_win_info) <~tui_win_info>: Inline.
1020         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1021         Don't declare.
1022         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1023         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1024         Remove.
1025         (tui_initialize_static_data): Update.
1026         (~tui_gen_win_info): Handle more cleanup here.
1027         (~tui_source_window_base): Delete "execution_info".
1028         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1029
1030 2019-06-25  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui-layout.c (make_command_window): Don't set
1033         can_highlight.
1034         (show_source_disasm_command): Call the reset method.
1035         (show_data): Don't set can_highlight.  Call the reset method.
1036         (tui_gen_win_info::reset): Rename from init_gen_win_info
1037         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1038         (show_source_or_disasm_and_command): Call the reset method.
1039         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1040         (struct tui_cmd_window): Set can_highlight.
1041
1042 2019-06-25  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1045         from make_visible.
1046         (tui_make_visible, tui_make_invisible): Rewrite.
1047         (tui_win_info::make_visible): Remove.
1048         (tui_source_window_base::make_visible): Update.
1049         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1050         method.  Moved from...
1051         (struct tui_win_info) <make_visible>: ...here.
1052
1053 2019-06-25  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-winsource.c
1056         (tui_source_window_base::do_scroll_horizontal): Remove direction
1057         parameter.
1058         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1059         direction parameter.
1060         * tui/tui-win.c (tui_win_info::forward_scroll)
1061         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1062         (tui_win_info::right_scroll): Update.
1063         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1064         direction parameter.
1065         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1066         direction parameter.
1067         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1068         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1069         Remove direction parameter.
1070         (struct tui_source_window_base, struct tui_source_window)
1071         (struct tui_disasm_window, struct tui_data_window)
1072         (struct tui_cmd_window): Update.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-winsource.h (tui_set_exec_info_content)
1077         (tui_show_exec_info_content, tui_erase_exec_info_content)
1078         (tui_clear_exec_info_content, tui_update_exec_info): Change
1079         argument to tui_source_window_base.
1080         * tui/tui-winsource.c (tui_set_exec_info_content)
1081         (tui_show_exec_info_content, tui_erase_exec_info_content)
1082         (tui_clear_exec_info_content, tui_update_exec_info): Change
1083         argument to tui_source_window_base.
1084
1085 2019-06-25  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1088         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1089
1090 2019-06-25  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1093         check.
1094
1095 2019-06-25  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1098         type to void.
1099         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1100         type to void.
1101         * tui/tui-source.c (tui_set_source_content): Update.
1102         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1103
1104 2019-06-25  Tom Tromey  <tom@tromey.com>
1105
1106         * tui/tui-win.c (window_name_completer, tui_set_focus)
1107         (tui_all_windows_info): Use name method.
1108         * tui/tui-data.h (struct tui_gen_win_info)
1109         (struct tui_source_window, struct tui_disasm_window)
1110         (struct tui_data_window, struct tui_cmd_window) <name>: New
1111         method.
1112         (tui_win_name): Don't declare.
1113         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1114         (tui_win_name): Remove.
1115
1116 2019-06-25  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-winsource.h (tui_update_source_window)
1119         (tui_update_source_window_as_is): Change parameter type.
1120         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1121         to be a tui_source_window_base.
1122         (tui_update_source_window_as_is): Likewise.
1123         * tui/tui-win.c (make_visible_with_new_height): Update.
1124
1125 2019-06-25  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-winsource.c (tui_erase_source_content)
1128         (tui_show_source_content, tui_show_exec_info_content)
1129         (tui_erase_exec_info_content): Use refresh_window method.
1130         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1131         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1132         from tui_refresh_win.
1133         (tui_data_window::refresh_window): New method.
1134         (tui_win_info::refresh, tui_source_window_base::refresh)
1135         (tui_refresh_all): Use refresh_window method.
1136         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1137         method.
1138         * tui/tui-regs.c (tui_display_register): Call refresh_window
1139         method.
1140         * tui/tui-layout.c (show_source_disasm_command)
1141         (show_source_or_disasm_and_command): Call refresh_window method.
1142         * tui/tui-data.h (struct tui_gen_win_info)
1143         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1144         New method.
1145
1146 2019-06-25  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui.c (tui_rl_other_window, tui_enable)
1149         (tui_is_window_visible, tui_get_command_dimension): Update.
1150         * tui/tui-winsource.c (tui_update_source_window_as_is)
1151         (tui_clear_source_content, tui_erase_source_content)
1152         (tui_show_source_line, tui_source_window_base::refill)
1153         (tui_source_window_base::do_scroll_horizontal)
1154         (tui_source_window_base::set_is_exec_point_at)
1155         (tui_update_breakpoint_info, tui_set_exec_info_content)
1156         (tui_alloc_source_buffer, tui_line_is_displayed)
1157         (tui_addr_is_displayed): Update.
1158         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1159         (tui_check_and_display_highlight_if_needed)
1160         (tui_win_info::make_visible, tui_win_info::refresh)
1161         (tui_refresh_all): Update.
1162         * tui/tui-windata.c (tui_first_data_item_displayed)
1163         (tui_delete_data_content_windows, tui_erase_data_content)
1164         (tui_display_all_data, tui_data_window::refresh_all)
1165         (tui_check_data_values): Update.
1166         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1167         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1168         (tui_win_info::backward_scroll, tui_refresh_all_win)
1169         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1170         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1171         (tui_source_window_base::set_new_height)
1172         (tui_data_window::set_new_height)
1173         (make_invisible_and_set_new_height)
1174         (make_visible_with_new_height, new_height_ok)
1175         (parse_scrolling_args): Update.
1176         * tui/tui-stack.c (tui_show_frame_info): Update.
1177         * tui/tui-source.c (tui_set_source_content)
1178         (tui_set_source_content_nil, tui_source_is_displayed)
1179         (tui_source_window::do_scroll_vertical): Update.
1180         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1181         (tui_display_registers_from, tui_display_reg_element_at_line)
1182         (tui_check_register_values, tui_reg_command): Update.
1183         * tui/tui-layout.c (tui_default_win_height)
1184         (show_source_disasm_command, show_data, init_and_make_win)
1185         (show_source_or_disasm_and_command): Update.
1186         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1187         (tui_redisplay_readline, tui_mld_flush)
1188         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1189         (tui_getc): Update.
1190         * tui/tui-disasm.c (tui_set_disassem_content)
1191         (tui_disasm_window::do_scroll_vertical): Update.
1192         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1193         Now virtual.
1194         (struct tui_win_info): Derive from tui_gen_win_info.
1195         <~tui_win_info>: Mark as override.
1196         <generic>: Remove member.
1197         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1198         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1199         (~tui_data_window, ~tui_win_info)
1200         (tui_free_all_source_wins_content): Update.
1201         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-layout.c (init_and_make_win): Use new.
1206         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1207         destructor, initializers.
1208         (tui_alloc_generic_win_info): Don't declare.
1209         * tui/tui-data.c (_locator): Add argument to constructor.
1210         (source_win, disasm_win): New globals.
1211         (exec_info): Remove.
1212         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1213         Update.
1214         (tui_alloc_generic_win_info): Remove.
1215         (init_content_element): Use new.
1216         (tui_win_info::tui_win_info): Update.
1217         (free_content_elements) <case DATA_WIN>: Use delete.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1222         * tui/tui-windata.c (tui_first_data_item_displayed)
1223         (tui_delete_data_content_windows): Update.
1224         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1225         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1226         (tui_display_registers_from, tui_check_register_values): Update.
1227         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1228         pointer.
1229         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1230         window.
1231         (tui_free_data_content): Update.
1232         (free_content_elements) <case DATA_WIN>: Free the window.
1233
1234 2019-06-25  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1237         Update.
1238         * tui/tui-layout.c (make_command_window)
1239         (show_source_disasm_command, show_data, init_and_make_win)
1240         (show_source_or_disasm_and_command): Update.
1241         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1242         method.
1243         <can_highight, is_highlighted>: Now bool.
1244         (tui_set_win_highlight): Don't declare.
1245         * tui/tui-data.c (tui_set_win_highlight): Remove.
1246
1247 2019-06-25  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-wingeneral.c (make_visible): Remove check of window
1250         type.
1251
1252 2019-06-25  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-win.c (tui_win_info::max_height)
1255         (tui_cmd_window::max_height): New methods.
1256         (new_height_ok): Call max_height.
1257         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1258         <max_height>: New method.
1259
1260 2019-06-25  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-win.c (tui_source_window_base::set_new_height)
1263         (tui_data_window::set_new_height): New methods.
1264         (make_invisible_and_set_new_height): Call set_new_height method.
1265         * tui/tui-data.h (struct tui_win_info)
1266         (struct tui_source_window_base, struct tui_data_window)
1267         <set_new_height>: New method.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1272         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1273         tui_refresh_data_win.
1274         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1275         method.
1276         (tui_refresh_all_win): Call the refresh_all method.
1277         (tui_set_focus): Likewise.
1278         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1279         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1280         Likewise.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-winsource.h (tui_refill_source_window)
1285         (tui_set_is_exec_point_at): Don't declare.
1286         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1287         (tui_source_window_base::refill): Rename from
1288         tui_refill_source_window.
1289         (tui_source_window_base::do_scroll_horizontal): Update.
1290         (tui_source_window_base::set_is_exec_point_at): Rename from
1291         tui_set_is_exec_point_at.
1292         (tui_update_all_breakpoint_info): Update.
1293         * tui/tui-stack.c (tui_show_frame_info): Update.
1294         * tui/tui-layout.c (show_data): Add cast.
1295         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1296         * tui/tui-data.h (struct tui_source_window_base) <refill,
1297         set_is_exec_point_at>: New methods.
1298         (tui_source_windows, tui_add_to_source_windows): Update types.
1299         (tui_add_to_source_windows): Remove redundant declaration.
1300         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1301         (tui_source_windows): Change return type.
1302         (tui_clear_source_windows_detail): Update.
1303         (tui_add_to_source_windows): Change type of parameter.
1304         (tui_free_all_source_wins_content): Update.
1305
1306 2019-06-25  Tom Tromey  <tom@tromey.com>
1307
1308         * tui/tui-wingeneral.c (tui_win_info::refresh)
1309         (tui_source_window_base::refresh): New methods.
1310         (tui_refresh_all): Call the refresh method.
1311         * tui/tui-data.h (struct tui_win_info)
1312         (struct tui_source_window_base) <refresh>: New method.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui.h (tui_is_window_visible): Return bool.
1317         * tui/tui.c (tui_is_window_visible): Return bool.
1318         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1319         (tui_make_visible, tui_make_invisible)
1320         (tui_win_info::make_visible)
1321         (tui_source_window_base::make_visible, make_all_visible)
1322         (tui_make_all_visible, tui_make_all_invisible): Update.
1323         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1324         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1325         bool.
1326         (struct tui_win_info, struct tui_source_window_base)
1327         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1328         * tui/tui-data.c (tui_init_generic_part): Update.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1333         (tui_source_window_base::make_visible): New methods.
1334         (make_all_visible): Make method call.
1335         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1336         (struct tui_source_window_base, struct tui_cmd_window): Override
1337         make_visible.
1338         (tui_win_is_source_type): Don't declare.
1339         * tui/tui-data.c (tui_win_is_source_type): Remove.
1340
1341 2019-06-25  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1344         NULL check.
1345
1346 2019-06-25  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1349         Inline constructor.  Add initializers for members.
1350         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1351         constructors; now inline in class.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-regs.c (tui_show_registers): Update.
1356         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1357         bool.
1358         * tui/tui-data.c (tui_data_window::clear_detail)
1359         (tui_data_window): Update.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-windata.c (tui_display_all_data)
1364         (tui_display_data_from_line, tui_display_data_from)
1365         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1366         Update.
1367         * tui/tui-regs.c (tui_last_regs_line_no)
1368         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1369         (tui_show_registers, tui_show_register_group)
1370         (tui_display_registers_from, tui_display_reg_element_at_line)
1371         (tui_display_registers_from_line, tui_check_register_values)
1372         (tui_reg_next, tui_reg_prev): Update.
1373         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1374         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1375         tui_data_window.
1376         (struct tui_win_info) <detail>: Remove.  Add new fields from
1377         tui_data_info.
1378         (TUI_DATA_WIN): Add cast.
1379         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1380         (~tui_data_window): Simplify.
1381
1382 2019-06-25  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-layout.c (show_source_disasm_command)
1385         (show_source_or_disasm_and_command): Update.
1386         * tui/tui-io.c (update_cmdwin_start_line)
1387         (tui_redisplay_readline): Update.
1388         * tui/tui-data.h (struct tui_command_info): Remove.
1389         (struct tui_win_info) <detail>: Remove command_info member.
1390         (struct tui_data_window) <start_line>: New member, from
1391         tui_command_info.
1392         (TUI_CMD_WIN): Add casts.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-winsource.c (tui_update_source_window)
1397         (tui_refill_source_window)
1398         (tui_source_window_base::do_scroll_horizontal)
1399         (tui_update_breakpoint_info, tui_set_exec_info_content)
1400         (tui_show_exec_info_content, tui_erase_exec_info_content)
1401         (tui_clear_exec_info_content): Update.
1402         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1403         Update.
1404         * tui/tui-win.c (make_invisible_and_set_new_height)
1405         (make_visible_with_new_height): Update.
1406         * tui/tui-source.c (tui_set_source_content)
1407         (tui_show_symtab_source): Update.
1408         * tui/tui-layout.c (extract_display_start_addr)
1409         (show_source_disasm_command, show_data)
1410         (make_source_or_disasm_window)
1411         (show_source_or_disasm_and_command): Update.
1412         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1413         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1414         "gdbarch".
1415         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1416         to tui_source_window_base.
1417         (struct tui_win_info) <detail>: Remove source_info member.
1418         (struct tui_source_window_base) <has_locator>: Inline.
1419         Move contents from tui_source_info; rename has_locator member to
1420         m_has_locator.
1421         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1422         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1423         header file.
1424         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1425         Simplify.
1426         (tui_free_all_source_wins_content): Cast to
1427         tui_source_window_base.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-win.c (make_invisible_and_set_new_height)
1432         (make_visible_with_new_height): Call has_locator method.
1433         * tui/tui-layout.c (show_source_disasm_command, show_data)
1434         (show_source_or_disasm_and_command): Update for bool change.
1435         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1436         (tui_win_info) <has_locator>: New method.
1437         (struct tui_source_window_base) <has_locator>: New method.
1438         (tui_win_has_locator): Don't declare.
1439         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1440         from tui_win_has_locator.
1441         (tui_source_window_base): Use false, not FALSE.
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1446         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1447         clear_detail method directly.
1448         (tui_clear_win_detail): Remove.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1453         "this", not TUI_DISASM_WIN.
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1458         declare.
1459         * tui/tui-winsource.c
1460         (tui_source_window_base::do_scroll_horizontal): Rename from
1461         tui_horizontal_source_scroll.
1462         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1463         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1464         from tui_vertical_data_scroll.
1465         * tui/tui-win.h (tui_scroll): Don't declare.
1466         * tui/tui-win.c (tui_win_info::forward_scroll)
1467         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1468         (tui_win_info::right_scroll): Rename and update.
1469         (tui_scroll_forward_command, tui_scroll_backward_command)
1470         (tui_scroll_left_command, tui_scroll_right_command): Update.
1471         (tui_scroll): Remove.
1472         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1473         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1474         from tui_vertical_source_scroll.
1475         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1476         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1477         from tui_vertical_disassem_scroll.
1478         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1479         do_scroll_horizontal>: New methods.
1480         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1481         Likewise.
1482         (struct tui_source_window_base): Add do_scroll_horizontal.
1483         (struct tui_source_window, struct tui_disasm_window): Add
1484         do_scroll_vertical.
1485         (struct tui_data_window, struct tui_cmd_window): Add
1486         do_scroll_horizontal and do_scroll_vertical.
1487         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-data.h (struct tui_source_window_base): New struct.
1492         (struct tui_source_window): Derive from tui_source_window_base.
1493         (struct tui_disasm_window): New struct.
1494         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1495         from tui_source_window::clear_detail.
1496         (tui_source_window_base): Rename from tui_source_window.
1497         (~tui_source_window_base): Rename from ~tui_source_window.
1498         (tui_alloc_win_info): Create a tui_disasm_window.
1499
1500 2019-06-25  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-data.h (struct tui_source_window)
1503         (struct tui_data_window): Declare destructors.
1504         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1505         destructors.
1506         (tui_win_info): Simplify.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-winsource.c (tui_display_main)
1511         (tui_update_source_windows_with_addr)
1512         (tui_update_all_breakpoint_info): Update.
1513         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1514         (new_height_ok, parse_scrolling_args): Update.
1515         * tui/tui-stack.c (tui_show_frame_info): Update.
1516         * tui/tui-data.h (struct tui_list): Remove.
1517         (tui_source_windows): Return a reference to a std::vector.
1518         * tui/tui-data.c (source_windows): Now a std::vector.
1519         (tui_source_windows): Change return type.
1520         (tui_clear_source_windows): Rewrite.
1521         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1522         (tui_free_all_source_wins_content): Rewrite.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1527         (struct tui_data_window, struct tui_cmd_window): Declare
1528         clear_detail method.
1529         * tui/tui-data.c (tui_source_window::clear_detail)
1530         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1531         methods.
1532         (tui_clear_win_detail): Simplify.
1533
1534 2019-06-25  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-layout.c (make_source_window, make_disasm_window)
1537         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1538         Return the new window.
1539         (show_source_disasm_command, show_data)
1540         (show_source_or_disasm_and_command): Update.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1545         parameter.  Return the new window.
1546         (show_source_disasm_command): Update and remove NULL check.
1547         (show_source_or_disasm_and_command): Update.
1548
1549 2019-06-25  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-data.h (struct tui_win_info): Make constructor
1556         protected.  Make destructor virtual.  Add initializers.
1557         (tui_source_window, tui_data_window, tui_cmd_window): New
1558         classes.
1559         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1560         constructor.  Add "type" parameter.
1561         (tui_source_window, tui_data_window, tui_cmd_window): New
1562         constructors.
1563         (tui_alloc_win_info): Instantiate the appropriate subclass.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-win.c (tui_resize_all): Use delete.
1568         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1569         destructor.
1570         (tui_free_window): Don't declare.
1571         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1572         Update.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-data.h (struct tui_win_info): Add constructor.
1577         * tui/tui-data.c (tui_alloc_win_info): Use new.
1578         (tui_free_window): Use delete.
1579
1580 2019-06-22  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1583         declare.
1584         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1585
1586 2019-06-22  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1589         declare.
1590         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1591
1592 2019-06-22  Tom de Vries  <tdevries@suse.de>
1593
1594         * dwarf2read.c (create_addrmap_from_aranges)
1595         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1596         instead of '%zu'.
1597
1598 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1599
1600         * dwarf2read.h (dwarf2_section_info_def): Remove.
1601         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1602         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1603         std::vector<dwarf2_section_info>.
1604         (struct dwo_file) <~dwo_file>: Remove.
1605         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1606         types field.
1607         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1608         (dwarf2_read_debug_names): Likewise.
1609         (create_debug_types_hash_table): Change parameter type to
1610         array_view, adjust code accordingly.
1611         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1612         (partial_die_info::fixup): Likewise.
1613         (determine_prefix): Likewise.
1614         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1615
1616 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1617
1618         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1619         gdb_bfd_ref_ptr.
1620         <~dwo_file>: Remove call to gdb_bfd_unref.
1621         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1622         gdb_bfd_ref_ptr::get.
1623
1624 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1625
1626         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1627         type to htab_up.
1628         * dwarf2read.c (struct dwo_file): Initialize fields.
1629         <~dwo_file>: New.
1630         (free_dwo_file): Remove, move content to ~dwo_file.
1631         (struct dwo_file_deleter): Remove.
1632         (dwo_file_up>: Remove custom deleter.
1633         (free_dwo_files): Remove.
1634         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1635         dwo_files.
1636         (process_skeletonless_type_units): Call unique_ptr::get.
1637         (allocate_dwo_file_hash_table): Add deleter to created hash
1638         table.  Change return type to htab_up.
1639         (lookup_dwo_file_slot): Don't memset dwo_file, call
1640         unique_ptr::get.
1641         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1642         (create_dwo_unit_in_dwp_v2): Likewise.
1643         (open_and_init_dwo_file): Likewise.
1644         (free_dwo_file_from_slot): Remove.
1645
1646 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * dwarf2read.h (struct dwarf2_section_info) <readin,
1649         is_virtual>: Change type to bool.
1650         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1651         true instead of 1.
1652
1653 2019-06-19  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-data.h (tui_init_content_element): Don't declare.
1656
1657 2019-06-19  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-data.h (tui_init_win_info): Don't declare.
1660
1661 2019-06-19  Tom de Vries  <tdevries@suse.de>
1662
1663         * dwarf2read.h (abstract_to_concrete): Change type to
1664         std::unordered_map<sect_offset, std::vector<sect_offset>,
1665         gdb::hash_enum<sect_offset>>.
1666
1667 2019-06-19  Tom Tromey  <tromey@adacore.com>
1668
1669         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1670         EVAL_AVOID_SIDE_EFFECTS specially.
1671
1672 2019-06-19  Tom Tromey  <tromey@adacore.com>
1673
1674         * source-cache.c (highlighter): New global.
1675         (source_cache::get_source_lines): Create a highlighter on demand.
1676
1677 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * defs.h (deprecated_interactive_hook): Delete declaration.
1680         * interps.c (clear_interpreter_hooks): Remove use of
1681         deprecated_interactive_hook.
1682         * top.c (deprecated_interactive_hook): Delete definition.
1683         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1684
1685 2019-06-18  Tom de Vries  <tdevries@suse.de>
1686
1687         PR gdb/24515
1688         * dwarf2read.h (abstract_to_concrete): Change type from
1689         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1690         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1691         * dwarf2read.c (read_variable): Update.
1692         (dwarf2_fetch_die_loc_sect_off): Update.
1693
1694 2019-06-17  Tom de Vries  <tdevries@suse.de>
1695
1696         PR gdb/24617
1697         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1698         accessing parent[parent_len - 1].
1699
1700 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1701
1702         PR gdb/24364
1703         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1704         call dtrace_process_dof with NULL dof.
1705
1706 2019-06-16  Tom de Vries  <tdevries@suse.de>
1707
1708         PR gdb/24445
1709         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1710
1711 2019-06-16  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1714         (make_all_visible): Use address of member.
1715
1716 2019-06-16  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1719         (tui_free_window, free_content, free_content_elements): Remove
1720         unnecessary cast.
1721         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1722         cast.
1723         * tui/tui-regs.c (tui_show_register_group)
1724         (tui_display_registers_from, tui_display_reg_element_at_line):
1725         Remove unnecessary cast.
1726
1727 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * linux-nat.c (normal_mask): Delete.
1730         (_initialize_linux_nat): Don't initialise normal_mask.
1731
1732 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1733
1734         PR gdb/24445
1735         * dwarf-index-write.h (write_psymtabs_to_index): Add
1736         dwz_basename parameter.
1737         * dwarf-index-write.c (write_gdbindex): Move file writing to
1738         write_gdbindex_1.  Change return type void.
1739         (assert_file_size): Move up, remove filename parameter.
1740         (write_gdbindex_1): New function.
1741         (write_debug_names): Change return type to void, call
1742         assert_file_size.
1743         (struct index_wip_file): New struct.
1744         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1745         file logic to index_wip_file.  Write index for dwz file if
1746         needed.
1747         (save_gdb_index_command): Pass basename of dwz file, if present.
1748         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1749         build-id of dwz file, if present.
1750         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1751         (dwarf2_get_dwz_file): Likewise.
1752         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1753         (dwarf2_get_dwz_file): Likewise.
1754
1755 2019-06-16  Tom Tromey  <tom@tromey.com>
1756
1757         * coffread.c (process_coff_symbol): Use xstrdup.
1758         * value.c (create_internalvar): Use xstrdup.
1759
1760 2019-06-16  Tom Tromey  <tom@tromey.com>
1761
1762         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1763         * breakpoint.c (stopin_command, stopat_command)
1764         (until_break_command, decode_location_default): Remove unnecessary
1765         cast.
1766         * utils.c (subset_compare): Remove unnecessary cast.
1767         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1768         cast.
1769         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1770         cast.
1771         * infcmd.c (path_command): Remove unnecessary cast.
1772         * coffread.c (decode_type): Remove unnecessary cast.
1773         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1774         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1775         * tui/tui-stack.c (tui_show_locator_content)
1776         (tui_show_frame_info): Remove unnecessary cast.
1777         * tui/tui-win.c (tui_scroll_forward_command)
1778         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1779         (parse_scrolling_args): Remove unnecessary cast.
1780         * tui/tui-data.c (init_win_info, tui_del_window)
1781         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1782         (free_content_elements): Remove unnecessary cast.
1783         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1784         unnecessary cast.
1785         * tui/tui-source.c (tui_set_source_content)
1786         (tui_vertical_source_scroll): Remove unnecessary cast.
1787         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1788         cast.
1789         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1790         * tui/tui-regs.c (tui_display_registers_from)
1791         (tui_display_register): Remove unnecessary cast.
1792         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1793         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1794         (make_visible): Remove unnecessary cast.
1795         * tui/tui-winsource.c (tui_erase_source_content)
1796         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1797         unnecessary cast.
1798         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1799         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1800         * stabsread.c (read_type, read_array_type, read_range_type):
1801         Remove unnecessary cast.
1802         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1803         (parse_symbol, parse_type, upgrade_type, parse_external)
1804         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1805         unnecessary cast.
1806         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1807
1808 2019-06-16  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-data.c (tui_alloc_generic_win_info)
1811         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1812         checks.
1813
1814 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1815             Andrew Burgess  <andrew.burgess@embecosm.com>
1816
1817         * f-typeprint.c (f_print_type): Don't return early for not
1818         associated or not allocated types.
1819         (f_type_print_varspec_suffix): Add print_rank parameter and print
1820         ranks of array types in case they dangling.
1821         (f_type_print_base): Add print_rank parameter.
1822
1823 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * NEWS: Mention new MI commands.
1826         * break-catch-throw.c (enum exception_event_kind): Move to
1827         breakpoint.h.
1828         (print_mention_exception_catchpoint): Output text as a single
1829         message.
1830         (catch_exception_command_1): Rename to...
1831         (catch_exception_event): ...this, make non-static, update header
1832         command, and change some parameter types.
1833         (catch_catch_command): Update for changes to
1834         catch_exception_command_1.
1835         (catch_throw_command): Likewise.
1836         (catch_rethrow_command): Likewise.
1837         * breakpoint.c (enum exception_event_kind): Delete.
1838         * breakpoint.h (enum exception_event_kind): Moved here from
1839         break-catch-throw.c.
1840         (catch_exception_event): Declare.
1841         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1842         (mi_cmd_catch_throw): New function.
1843         (mi_cmd_catch_rethrow): New function.
1844         (mi_cmd_catch_catch): New function.
1845         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1846         'catch-catch' entries.
1847         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1848         (mi_cmd_catch_rethrow): Declare.
1849         (mi_cmd_catch_catch): Declare.
1850
1851 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * annotate.c (annotate_source_line): Change return type to void,
1854         update implementation to match.
1855         * annotate.h (annotate_source_line): Change return type to void,
1856         update header comment.
1857         * stack.c (print_frame_info): Don't change what frame information
1858         is printed based on whether annotations are on or not.
1859
1860 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1863         (annotate_source): Make static.
1864         (annotate_source_line): Moved from source.c and renamed from
1865         identify_source_line.  Update the return type.
1866         * annotate.h (annotate_source): Delete declaration.
1867         (annotate_source_line): Declaration moved from source.h, and
1868         renamed from identify_source_line.  Return type updated.
1869         * source.c (identify_source_line): Moved to annotate.c and renamed
1870         to annotate_source_line.
1871         (info_line_command): Remove check of annotation_level.
1872         * source.h (identify_source_line): Move declaration to annotate.h
1873         and rename to annotate_source_line.
1874         * stack.c: Add 'annotate.h' include.
1875         (print_frame_info): Remove check of annotation_level before
1876         calling annotate_source_line.
1877
1878 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * source-cache.c (source_cache::get_plain_source_lines): Use
1881         open_source_file_with_line_charpos instead of just
1882         open_source_file, remove call to find_source_lines.
1883         (source_cache::get_source_lines): Likewise.
1884         * source.c (find_source_lines): Make static.
1885         (get_filename_and_charpos): Renamed into...
1886         (open_source_file_with_line_charpos): ..this along with changes to
1887         return a scoped_fd, and some other minor clean ups.
1888         (identify_source_line): Use open_source_file_with_line_charpos.
1889         (search_command_helper): Use open_source_file_with_line_charpos
1890         instead of just open_source_file, remove call to
1891         find_source_lines.
1892         * source.h (open_source_file_with_line_charpos): Declare new
1893         function.
1894         (find_source_lines): Delete declaration.
1895
1896 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * source.c (get_filename_and_charpos): Remove fullname
1899         parameter.
1900         (identify_source_line): Update call to get_filename_and_charpos.
1901
1902 2019-06-14  Tom Tromey  <tromey@adacore.com>
1903
1904         PR gdb/24502:
1905         * ui-style.h (skip_ansi_escape): Update comment.
1906         * ui-file.h (class no_terminal_escape_file): New class.
1907         * ui-file.c (no_terminal_escape_file::write)
1908         (no_terminal_escape_file::puts): New methods.
1909         * cli/cli-logging.c (handle_redirections): Use
1910         no_terminal_escape_file.
1911
1912 2019-06-14  Tom Tromey  <tromey@adacore.com>
1913
1914         * NEWS: Move convenience variable news above Python news.
1915
1916 2019-06-14  Tom Tromey  <tom@tromey.com>
1917
1918         * gnulib: Move directory to top-level.
1919         * configure.ac: Don't configure gnulib.
1920         * configure: Rebuild.
1921         * common/common-defs.h: Use new path to gnulib.
1922         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1923         (GNULIB_H): Remove.
1924         (INCGNU): Look in new gnulib location.
1925         (HFILES_NO_SRCDIR): Remove gnulib files.
1926         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1927         (generated_files): Remove GNULIB_H.
1928         ($(LIBGNU), all-lib): Remove targets.
1929         (distclean): Don't mention GNULIB_BUILDDIR.
1930         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1931
1932 2019-06-14  Tom Tromey  <tromey@adacore.com>
1933
1934         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1935         Warn if symbol file does not provide any symbols.
1936
1937 2019-06-14  Tom Tromey  <tromey@adacore.com>
1938
1939         * source.c (find_and_open_source): Respect basenames_may_differ.
1940
1941 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1942
1943         * annotate.c (annotate_breakpoints_invalid): Make use of
1944         scoped_restore_terminal_state.
1945         (annotate_frames_invalid): Likewise.
1946
1947 2019-06-14  Tom Tromey  <tromey@adacore.com>
1948
1949         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1950         allow assignment to an internalvar.
1951
1952 2019-06-14  Tom Tromey  <tromey@adacore.com>
1953
1954         * ada-lex.l: Allow "_" in attribute names.
1955
1956 2019-06-14  Tom Tromey  <tromey@adacore.com>
1957
1958         PR gdb/24653:
1959         * regcache.c (registers_changed): Don't call alloca.
1960         * top.c (execute_command): Don't call alloca.
1961
1962 2019-06-13  Pedro Alves  <palves@redhat.com>
1963
1964         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1965         'expression'.  When parsing an expression, error out if there's
1966         junk after "unlimited".
1967         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1968         (do_set_command): Adjust calls to is_unlimited_literal.
1969
1970 2019-06-13  Pedro Alves  <palves@redhat.com>
1971
1972         * compile/compile.c (make_compile_options_def_group): Add braces
1973         around array_view initializer.
1974         * thread.c (make_thread_apply_all_options_def_group)
1975         (make_thread_apply_all_options_def_group): Likewise.
1976
1977 2019-06-13  Pedro Alves  <palves@redhat.com>
1978
1979         * NEWS (New commands): Mention "maint test-options
1980         require-delimiter", "maint test-options unknown-is-error", "maint
1981         test-options unknown-is-operand" and "maint show
1982         test-options-completion-result".
1983         (New command options, command completion): New section.
1984         (Completion improvements): New section.
1985         Mention that you can abbreviate "unlimited".
1986
1987 2019-06-13  Pedro Alves  <palves@redhat.com>
1988
1989         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1990         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1991         * unittests/cli-utils-selftests.c (test_parse_flags)
1992         (test_parse_flags_qcs): Delete.
1993         (test_cli_utils): Don't call deleted functions.
1994
1995 2019-06-13  Pedro Alves  <palves@redhat.com>
1996
1997         * thread.c: Include "cli/cli-option.h".
1998         (tp_array_compar_ascending): Global.
1999         (tp_array_compar): Delete function.
2000         (tp_array_compar_ascending, tp_array_compar_descending): New
2001         functions.
2002         (ascending_option_def, qcs_flag_option_def)
2003         (thr_qcs_flags_option_defs)
2004         (make_thread_apply_all_options_def_group)
2005         (make_thread_apply_options_def_group): New.
2006         (thread_apply_all_command): Use gdb::option::process_options.
2007         (thread_apply_command_completer)
2008         (thread_apply_all_command_completer): New.
2009         (thread_apply_command): Use gdb::option::process_options.
2010         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2011         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2012         to generate help text of "thread apply".  Adjust "taas"'s help.
2013         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2014         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2015
2016 2019-06-13  Pedro Alves  <palves@redhat.com>
2017
2018         * thread.c (thread_apply_command): Check for invalid TID with
2019         isdigit instead of !isalpha.
2020
2021 2019-06-13  Pedro Alves  <palves@redhat.com>
2022
2023         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2024         (validate_flags_qcs): New.
2025         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2026         (validate_flags_qcs): Declare.
2027         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2028         (make_frame_apply_options_def_group): New.
2029         (frame_apply_command_count): Process options with
2030         gdb::option::process_options.
2031         (frame_apply_completer): New.
2032         (frame_apply_level_completer, frame_apply_all_completer)
2033         (frame_apply_completer): New.
2034         (_initialize_stack): Update help of "frame apply", "frame apply
2035         level", "frame apply all" and "faas" to mention supported options
2036         and install command completers.
2037         * stack.h (frame_apply_all_completer): Declare.
2038         * thread.c: Include "stack.h".
2039         (tfaas_command): Add "--".
2040         (_initialize_thread): Update help "tfaas" to mention supported
2041         options and install command completer.
2042
2043 2019-06-13  Pedro Alves  <palves@redhat.com>
2044
2045         * completer.c (complete_nested_command_line): New.
2046         (gdb_completion_word_break_characters_throw): Add assertion.
2047         * completer.h (complete_nested_command_line): Declare.
2048
2049 2019-06-13  Pedro Alves  <palves@redhat.com>
2050
2051         * stack.c (parse_backtrace_qualifiers): New.
2052         (backtrace_command): Use it.
2053         (backtrace_command_completer): Complete on qualifiers.
2054
2055 2019-06-13  Pedro Alves  <palves@redhat.com>
2056
2057         * frame.c: Include "cli/cli-option.h.
2058         (user_set_backtrace_options): New.
2059         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2060         Delete.
2061         (get_prev_frame): Adjust.
2062         (boolean_option_def, uinteger_option_def)
2063         (set_backtrace_option_defs): New.
2064         (_initialize_frame): Adjust and use
2065         gdb::option::add_setshow_cmds_for_options to install "set
2066         backtrace past-main" and "set backtrace past-entry".
2067         * frame.h: Include "cli/cli-option.h".
2068         (struct frame_print_options): Forward declare.
2069         (print_frame_arguments_all, print_frame_arguments_scalars)
2070         (print_frame_arguments_none): Declare.
2071         (print_entry_values): Delete declaration.
2072         (struct frame_print_options, user_frame_print_options): New.
2073         (struct set_backtrace_options): New.
2074         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2075         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2076         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2077         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2078         (list_args_or_locals): Add frame_print_options parameter.
2079         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2080         * python/py-framefilter.c (enumerate_args): Pass down
2081         USER_FRAME_PRINT_OPTIONS.
2082         * stack.c: Include "cli/cli-option.h".
2083         (print_frame_arguments_all, print_frame_arguments_scalars)
2084         (print_frame_arguments_none): Declare.
2085         (print_raw_frame_arguments, print_entry_values): Delete.
2086         (user_frame_print_options): New.
2087         (boolean_option_def, enum_option_def, frame_print_option_defs):
2088         New.
2089         (struct backtrace_cmd_options): New.
2090         (bt_flag_option_def): New.
2091         (backtrace_command_option_defs): New.
2092         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2093         (print_frame_arg, read_frame_arg, print_frame_args)
2094         (print_frame_info, print_frame): Add frame_print_options parameter
2095         and use it.
2096         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2097         (backtrace_command_1): Add frame_print_options and
2098         backtrace_cmd_options parameters and use them.
2099         (make_backtrace_options_def_group): New.
2100         (backtrace_command): Process command options with
2101         gdb::option::process_options.
2102         (backtrace_command_completer): New.
2103         (_initialize_stack): Extend "backtrace"'s help to mention
2104         supported options.  Install completer for "backtrace".
2105         Install some settings commands with add_setshow_cmds_for_options.
2106
2107 2019-06-13  Pedro Alves  <palves@redhat.com>
2108
2109         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2110         and that "set/show print raw frame-arguments" are now deprecated.
2111
2112         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2113         command.
2114         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2115         * stack.c (_initialize_stack): Install "set/show print
2116         raw-frame-arguments", and deprecate "set/show print raw
2117         frame-arguments".
2118         * valprint.c (_initialize_valprint): Deprecate "set/show print
2119         raw".
2120
2121 2019-06-13  Pedro Alves  <palves@redhat.com>
2122
2123         * compile/compile.c (struct compile_options): New.
2124         (compile_flag_option_def, compile_command_option_defs)
2125         (make_compile_options_def_group): New.
2126         (compile_file_command): Handle options with
2127         gdb::option::process_options.
2128         (compile_file_command_completer): New function.
2129         (compile_code_command): Handle options with
2130         gdb::option::process_options.
2131         (compile_code_command_completer): New function.
2132         (_initialize_compiler): Install completers for "compile code" and
2133         "compile file".  Mention available options in "compile code" and
2134         "compile code"'s help.
2135         * completer.c (advance_to_completion_word): New, factored out from
2136         ...
2137         (advance_to_expression_complete_word_point): ... this.
2138         (advance_to_filename_complete_word_point): New.
2139         * completer.h (advance_to_filename_complete_word_point): New
2140         declaration.
2141
2142 2019-06-13  Pedro Alves  <palves@redhat.com>
2143
2144         * compile/compile.c: Include "cli/cli-option.h".
2145         (compile_print_value): Scope data pointer is now a
2146         value_print_options pointer; adjust.
2147         (compile_print_command): Process options.  Scope data pointer is
2148         now a value_print_options pointer; adjust.
2149         (_initialize_compile): Update "compile print"'s help to include
2150         supported options.  Install a completer for "compile print".
2151         * cp-valprint.c (show_vtblprint, show_objectprint)
2152         (show_static_field_print): Delete.
2153         (_initialize_cp_valprint): Don't install "set print
2154         static-members", "set print vtbl", "set print object" here.
2155         * printcmd.c: Include "cli/cli-option.h" and
2156         "common/gdb_optional.h".
2157         (print_command_parse_format): Rework to fill in a
2158         value_print_options instead of a format_data.
2159         (print_value): Change parameter type from format_data pointer to
2160         value_print_options reference.  Adjust.
2161         (print_command_1): Process options.  Adjust to pass down a
2162         value_print_options.
2163         (print_command_completer): New.
2164         (_initialize_printcmd): Install print_command_completer as
2165         handle_brkchars completer for the "print" command.  Update
2166         "print"'s help to include supported options.
2167         * valprint.c: Include "cli/cli-option.h".
2168         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2169         here from cp-valprint.c.
2170         (boolean_option_def, uinteger_option_def)
2171         (value_print_option_defs, make_value_print_options_def_group):
2172         New.  Use gdb::option::add_setshow_cmds_for_options to install
2173         "set print elements", "set print null-stop", "set print repeats",
2174         "set print pretty", "set print union", "set print array", "set
2175         print address", "set print symbol", "set print array-indexes".
2176         * valprint.h: Include <string> and "cli/cli-option.h".
2177         (make_value_print_options_def_group): Declare.
2178         (print_value): Change parameter type from format_data pointer to
2179         value_print_options reference.
2180         (print_command_completer): Declare.
2181
2182 2019-06-13  Pedro Alves  <palves@redhat.com>
2183
2184         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2185         (COMMON_SFILES): Add maint-test-settings.c.
2186         * cli/cli-decode.c (boolean_enums): New global, factored out from
2187         ...
2188         (add_setshow_boolean_cmd): ... here.
2189         * cli/cli-decode.h (boolean_enums): Declare.
2190         * cli/cli-option.c: New file.
2191         * cli/cli-option.h: New file.
2192         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2193         factored out from ...
2194         (parse_cli_boolean_value(const char *)): ... this.
2195         (is_unlimited_literal): Change parameter type to pointer to
2196         pointer.  Adjust and advance ARG pointer.
2197         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2198         (parse_cli_var_enum): New, factored out from ...
2199         (do_set_command): ... this.  Adjust.
2200         * cli/cli-setshow.h (parse_cli_boolean_value)
2201         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2202         (parse_cli_var_enum): Declare.
2203         * cli/cli-utils.c: Include "cli/cli-option.h".
2204         (get_ulongest): New.
2205         * cli/cli-utils.h (get_ulongest): Declare.
2206         (check_for_argument): New overloads.
2207         * maint-test-options.c: New file.
2208
2209 2019-06-13  Pedro Alves  <palves@redhat.com>
2210
2211         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2212         parse a range if "-" is at the end of the string.
2213
2214 2019-06-13  Pedro Alves  <palves@redhat.com>
2215
2216         * cli/cli-setshow.c (parse_auto_binary_operation)
2217         (parse_cli_boolean_value): Don't allow "o".
2218
2219 2019-06-13  Pedro Alves  <palves@redhat.com>
2220
2221         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2222         * NEWS: Mention maint test-settings KIND.
2223         * maint-test-settings.c: New file.
2224
2225 2019-06-13  Pedro Alves  <palves@redhat.com>
2226
2227         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2228         completer.
2229         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2230         "set" completers.
2231
2232 2019-06-13  Pedro Alves  <palves@redhat.com>
2233
2234         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2235         after item.
2236
2237 2019-06-13  Pedro Alves  <palves@redhat.com>
2238
2239         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2240
2241 2019-06-13  Pedro Alves <palves@redhat.com>
2242
2243         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2244         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2245         call.
2246         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2247         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2248         calls.
2249         (check_for_argument): Skip spaces after argument.
2250
2251 2019-06-13  Pedro Alves  <palves@redhat.com>
2252
2253         * thread.c (thread_apply_command): Adjust TID parsing.
2254         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2255         detected before end of string.
2256         (tid_is_in_list): Error out if LIST is invalid.
2257
2258 2019-06-13  Pedro Alves  <palves@redhat.com>
2259
2260         * completer.c (complete_line_internal_1): Rewind completion word
2261         point.
2262         (completion_tracker::advance_custom_word_point_by): Change
2263         parameter type to int.
2264         * completer.h (completion_tracker::advance_custom_word_point_by):
2265         Likewise.
2266
2267 2019-06-13  Pedro Alves  <palves@redhat.com>
2268
2269         * completer.c (advance_to_completion_word): Handle delimiters.
2270
2271 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2272
2273         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2274
2275 2019-06-11  Tom Tromey  <tom@tromey.com>
2276
2277         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2278         (xmalloc_failed): Move to alloc.c.
2279         * alloc.c: New file.
2280         * Makefile.in (COMMON_SFILES): Add alloc.c.
2281
2282 2019-06-11  Tom Tromey  <tom@tromey.com>
2283
2284         * nat/linux-waitpid.c: Don't include server.h.
2285         (linux_debug): Remove.
2286         (my_waitpid): Update.
2287
2288 2019-06-11  Tom Tromey  <tromey@adacore.com>
2289
2290         * infcall.c (_initialize_infcall): Remove trailing newline from
2291         help.
2292         * user-regs.c (_initialize_user_regs): Remove trailing newline
2293         from help.
2294         * typeprint.c (_initialize_typeprint): Remove trailing newline
2295         from help.
2296         * reverse.c (_initialize_reverse): Remove trailing newlines from
2297         help.
2298         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2299         from help.
2300         * language.c (add_set_language_command): Remove trailing newline
2301         from help.
2302         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2303         help.
2304         * disasm.c (_initialize_disasm): Remove trailing newline from
2305         help.
2306         * top.c (init_main): Remove trailing newline from help.
2307         * interps.c (_initialize_interpreter): Remove trailing newline
2308         from help.
2309         * btrace.c (_initialize_btrace): Remove trailing newlines from
2310         help.
2311         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2312         from help.
2313         * python/python.c (_initialize_python): Remove trailing newline
2314         from help.
2315         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2316         help.
2317         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2318         from help.  Reformat some text.
2319         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2320         from help.
2321         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2322         newline from help.
2323
2324 2019-06-11  Tom Tromey  <tromey@adacore.com>
2325
2326         * darwin-nat.c (darwin_decode_exception_message)
2327         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2328
2329 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * valops.c (value_slice): Check for not allocated or not
2332         associated values.
2333
2334 2019-06-10  Tom de Vries  <tdevries@suse.de>
2335
2336         PR gdb/24618
2337         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2338         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2339         invalid.
2340
2341 2019-06-10  Tom de Vries  <tdevries@suse.de>
2342
2343         PR gdb/24611
2344         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2345         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2346
2347 2019-06-10  Tom de Vries  <tdevries@suse.de>
2348
2349         PR symtab/24545
2350         * symtab.c (struct demangled_name_entry): Add language field.
2351         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2352         static minimal symbol".  Set and use language field.
2353
2354 2019-06-10  Tom Tromey  <tromey@adacore.com>
2355
2356         * ada-lang.c (_initialize_ada_language): Update help text.
2357
2358 2019-06-10  Tom Tromey  <tromey@adacore.com>
2359
2360         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2361         with a newline.
2362         * guile/guile.c (handle_boot_error): Don't end warning with a
2363         newline.
2364         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2365         warning with a newline.
2366         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2367         newline.
2368         (s12z_frame_cache): Likewise.
2369         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2370         a newline.
2371         * solib-svr4.c (disable_probes_interface): Don't end warning with
2372         a newline.
2373         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2374         newline.
2375         * python/python.c (do_finish_initialization): Don't end warning
2376         with a newline.
2377
2378 2019-06-10  Tom Tromey  <tom@tromey.com>
2379
2380         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2381         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2382         gdbpy_enter.
2383
2384 2019-06-10  Tom Tromey  <tromey@adacore.com>
2385
2386         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2387         data.
2388         (elf_new_init): Don't call stabsread_new_init.
2389         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2390         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2391         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2392
2393 2019-06-10  Tom de Vries  <tdevries@suse.de>
2394
2395         PR symtab/16264
2396         PR symtab/24517
2397         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2398
2399 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2400
2401         * source.c (find_and_open_source): Also rewrite relative file
2402         names.
2403
2404 2019-04-26  Amos Bird  <amosbird@gmail.com>
2405
2406         * annotate.c (annotate_thread_exited): Add "thread-exited"
2407         annotation.
2408
2409 2019-06-06  Tom Tromey  <tromey@adacore.com>
2410
2411         * maint.h (class scoped_command_stats): Use
2412         DISABLE_COPY_AND_ASSIGN.
2413         <print_time>: New method.
2414         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2415         print_time.
2416         (scoped_command_stats::print_time): New method.
2417
2418 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2421         instructions of lengths 6 or 8 bytes.
2422
2423 2019-06-04  Pedro Alves  <palves@redhat.com>
2424
2425         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2426
2427         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2428         * breakpoint.c (condition_completer): Likewise.
2429         * cli/cli-dump.c (scan_expression): Likewise.
2430         * common/filestuff.c (mkdir_recursive): Likewise.
2431         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2432         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2433         (gdb_abspath): Likewise.
2434         * compile/compile-cplus-types.c
2435         (compile_cplus_instance::decl_name): Likewise.
2436         * completer.c (complete_explicit_location):
2437         (signal_completer, reg_or_group_completer_1): Likewise.
2438         * cp-support.c (cp_remove_params_if_any): Likewise.
2439         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2440         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2441         * infcmd.c (strip_bg_char): Likewise.
2442         * linespec.c (copy_token_string): Likewise.
2443         * mi/mi-main.c (output_cores): Likewise.
2444         * psymtab.c (psymtab_search_name):
2445         * symfile.c (test_set_ext_lang_command): Likewise.
2446         * target.c (target_fileio_read_stralloc): Likewise.
2447         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2448         * value.c (complete_internalvar): Likewise.
2449
2450 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2451
2452         Add objfile property to gdb.Type.
2453         * NEWS: Mention Python API addition.
2454         * python/py-type.c (typy_get_objfile): New method.
2455
2456 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2457
2458         * NEWS: Mention the new set|show style [title|highlight].
2459         Mention changes to "show style", "help" and "apropos".
2460
2461 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2462
2463         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2464         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2465         instead of print_help_for_command.
2466         (print_doc_of_command): New function.
2467         (help_list): Add 'apropos -v word' suggestion.
2468         (print_help_for_command): Style the command name using title style.
2469         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2470         (_initialize_cli_cmds): Describe -v in apropos_command help.
2471
2472 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2473
2474         * cli/cli-style.h (cli_style_option): Add name in constructor,
2475         add m_name class member, add constructor with intensity,
2476         add name class function.
2477         (cli_style_option::add_setshow_commands): Remove name argument.
2478         (highlight_style, title_style): New styles.
2479         * cli/cli-style.c (do_show): New function that shows a style
2480         characteristic styling the style name with itself.
2481         (set_style_name): New function.
2482         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2483         Update all callers according to the changes in cli/cli-style.h.
2484         * utils.h (fputs_highlighted): New function.
2485         * utils.c (fputs_highlighted): Likewise.
2486
2487 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2488
2489         * NEWS: Mention new pipe command and new convenience variables.
2490
2491 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2492
2493         * cli/cli-cmds.c (pipe_command): New function.
2494         (_initialize_cli_cmds): Call add_com for pipe_command.
2495         Define | as an alias for pipe.
2496         (exit_status_set_internal_vars): New function.
2497         (shell_escape): Call exit_status_set_internal_vars.
2498         cli/cli-decode.c (find_command_name_length): Recognize | as
2499         a single character command.
2500
2501 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2502
2503         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2504         top.c (execute_command_to_ui_file): New function, mostly a copy
2505         of execute_command_to_string.
2506         (execute_command_to_string): Implement by calling
2507         execute_command_to_ui_file.
2508
2509 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2510
2511         * top.h (saved_command_line): Remove declaration.
2512         * top.c (previous_saved_command_line, previous_repeat_arguments):
2513         New variables.
2514         (saved_command_line): Make static, define together with other
2515         'repeat variables'.
2516         (dont_repeat): Clear repeat_arguments.
2517         (repeat_previous, get_saved_command_line, save_command_line):
2518         New functions.
2519         (gdb_init): Initialize saved_command_line
2520         and previous_saved_command_line.
2521         * main.c (captured_main_1): Remove saved_command_line initialization.
2522         * event-top.c (handle_line_of_input): Update to use
2523         the new 'repeat' related functions instead of direct access to
2524         saved_command_line.
2525         * command.h (repeat_previous, get_saved_command_line,
2526         save_command_line): New declarations.
2527         (dont_repeat): Add comment.
2528
2529 2019-05-30  Tom Tromey  <tromey@adacore.com>
2530
2531         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2532         Fix comment.
2533         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2534
2535 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2536
2537         PR cli/24587
2538         * completer.c (complete): Initialize variable word.
2539
2540 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2541
2542         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2543         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2544         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2545         'body' is NULL to the outter 'if', protecting the '!is_define'
2546         situation as well.
2547
2548 2019-05-29  Tom Tromey  <tromey@adacore.com>
2549
2550         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2551         (dwarf_unknown): New function.
2552         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2553         (dwarf_type_encoding_name): Use dwarf_unknown.
2554
2555 2019-05-29  Tom Tromey  <tromey@adacore.com>
2556
2557         PR c++/20020:
2558         * cp-valprint.c (cp_print_value_fields): Call
2559         cp_print_static_field inside "try".
2560
2561 2019-05-29  Tom Tromey  <tromey@adacore.com>
2562
2563         * inflow.c (struct terminal_info): Add default operator=.
2564         * configure: Rebuild.
2565         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2566         -Wdeprecated-copy-dtor, -Wredundant-move.
2567
2568 2019-05-29  Tom Tromey  <tromey@adacore.com>
2569
2570         * NEWS: Add entry.
2571         * infcmd.c (print_return_value_1): Handle finish_print
2572         option.
2573         (show_print_finish): New function.
2574         (_initialize_infcmd): Add "set/show print finish" commands.
2575         * valprint.c (user_print_options): Initialize new member.
2576         * valprint.h (struct value_print_options) <finish_print>: New
2577         member.
2578
2579 2019-05-28  Tom Tromey  <tromey@adacore.com>
2580
2581         * ada-lang.c (ada_remove_Xbn_suffix)
2582         (find_old_style_renaming_symbol)
2583         (parse_old_style_renaming): Remove.
2584         (ada_find_renaming_symbol): Don't call
2585         find_old_style_renaming_symbol.
2586         (ada_is_renaming_symbol): Rename from
2587         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2588         bool.  Now static.
2589         (ada_read_var_value): Update and simplify.
2590         * ada-exp.y (write_var_or_type): Remove old code.
2591
2592 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2593
2594         * event-top.c: Remove include comment.
2595         * inflow.c (class scoped_ignore_sigttou): Move from here...
2596         * inflow.h (class scoped_ignore_sigttou): ...to here.
2597         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2598         * top.c:  Remove include comment.
2599
2600 2019-05-27  Tom Tromey  <tom@tromey.com>
2601
2602         * NEWS: Fix typo.
2603
2604 2019-05-22  Tom Tromey  <tromey@adacore.com>
2605
2606         * target.c (target_follow_exec): Constify parameter.
2607         * target-delegates.c: Rebuild.
2608         * remote.c (remote_target::follow_exec): Constify parameter.
2609         * infrun.c (follow_exec): Constify parameter.
2610         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2611         (target_follow_exec): Likewise.
2612
2613 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2614
2615         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2616         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2617
2618 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2619
2620         * NEWS: Add debugredirect and testsuite sections.
2621
2622 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2623
2624         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2625         target descriptions using exclusively floating point register name
2626         aliases.
2627
2628 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         PR gdb/18644:
2631         * f-lang.c (build_fortran_types): Handle the case where
2632         gdbarch_floatformat_for_type returns a nullptr.
2633
2634 2019-05-21  Tom de Vries  <tdevries@suse.de>
2635
2636         PR cli/24587
2637         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2638
2639 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         PR gdb/18644:
2642         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2643         16-byte floats.
2644         * i386-tdep.c (i386_floatformat_for_type): Use
2645         floatformats_ia64_quad for the 16-byte floating point component
2646         within a fortran 32-byte complex number.
2647
2648 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2651         delete default constructor.
2652         (find_partial_die): Update to return const struct.
2653         (partial_die_parent_scope): Move variable declaration into scope
2654         of its use and change its type to auto.
2655         (guess_partial_die_structure_name): Likewise.
2656         (partial_die_info::fixup): Likewise.
2657
2658 2019-05-17  Tom Tromey  <tromey@adacore.com>
2659
2660         * source.c (find_and_open_source): Remove cast.
2661
2662 2019-05-17  Tom Tromey  <tromey@adacore.com>
2663
2664         * annotate.c (annotate_source): Make "filename" const.
2665         * annotate.h (annotate_source): Use const.
2666
2667 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2668
2669         * disasm.c (set_disassembler_options): Send errors to stderr.
2670
2671 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2672
2673         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2674         (cli_interp_base::set_logging): Check debug_redirect.
2675         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2676         * cli/cli-logging.c (debug_redirect): Add static variable.
2677         (pop_output_files): Add default param.
2678         (handle_redirections): Print debug setting.
2679         (show_logging_command): Likewise.
2680         (_initialize_cli_logging): Add debugredirect command.
2681         * interps.c (current_interp_set_logging): Add debug_redirect
2682         parameter.
2683         * interps.h (set_logging): Add debug_redirect parameter.
2684         (current_interp_set_logging): Likewise.
2685         * mi/mi-common.h: Likewise.
2686         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2687
2688 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2689             Tom Tromey  <tromey@adacore.com>
2690
2691         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2692         directly.
2693         * cli/cli-interp.h (make_logging_output): Remove declaration.
2694         * cli/cli-logging.c (make_logging_output): Remove function.
2695         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2696         directly.
2697         * ui-file.c (tee_file::tee_file): Remove bools.
2698         (tee_file::~tee_file): Remove deletes.
2699         * ui-file.h (tee_file): Remove bools.
2700
2701 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2702
2703         * mi/mi-cmds.h (mi_cmd_complete): New function.
2704         * mi/mi-main.c (mi_cmd_complete): Likewise.
2705         * mi/mi-cmds.c: Define new MI command -complete.
2706         * NEWS: Mention new -complete command.
2707
2708 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2709
2710         * completer.h (complete): New function.
2711         * completer.c (complete): Likewise.
2712         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2713         function defined in completer.h.
2714
2715 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2716
2717         * MAINTAINERS (Write After Approval): Add myself.
2718
2719 2019-05-17  Tom de Vries  <tdevries@suse.de>
2720
2721         PR gdb/24094
2722         * dwarf2read.c (struct cu_partial_die_info): New struct.
2723         (find_partial_die): Return cu_partial_die_info.
2724         (partial_die_parent_scope, guess_partial_die_structure_name)
2725         (partial_die_info::fixup): Handle new return type of find_partial_die.
2726
2727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2728
2729         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2730         "std::string", simplifying the algorithm.
2731
2732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2733
2734         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2735         (stap_static_probe_ops::get_probes): Likewise.
2736
2737 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2738
2739         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2740         '-')" and "else if".
2741         (stap_parse_single_operand): Join checks for
2742         "gdbarch_stap_parse_special_token_p" and
2743         "gdbarch_stap_parse_special_token" in the same "if" statement.
2744         Invert check when verifying for operation on register
2745         displacement.
2746
2747 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2748
2749         * stap-probe.c (stap_get_opcode): Update comment.
2750         (stap_get_expected_argument_type): Likewise.
2751         (handle_stap_probe): Likewise.
2752
2753 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2754
2755         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2756         return type to 'bool'.  Adjust comment.  Use 'bool' when
2757         appropriate.
2758         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2759         * stap-probe.c (stap_parse_argument_1): Likewise.
2760         (stap_is_operator): Likewise.
2761         (stap_is_generic_prefix): Likewise.
2762         (stap_is_register_prefix): Likewise.
2763         (stap_is_register_indirection_prefix): Likewise.
2764         (stap_is_integer_prefix): Likewise.
2765         (stap_generic_check_suffix): Likewise.
2766         (stap_check_integer_suffix): Likewise.
2767         (stap_check_register_suffix): Likewise.
2768         (stap_check_register_indirection_suffix): Likewise.
2769         (stap_parse_register_operand): Likewise.
2770         (stap_parse_single_operand): Likewise.
2771         (stap_parse_argument_1): Likewise.
2772         (stap_probe::get_argument_count): Likewise.
2773         (stap_is_operator): Likewise.
2774
2775 2019-05-16  Tom Tromey  <tromey@adacore.com>
2776
2777         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2778         keyword to foreach.
2779
2780 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2781
2782         * linux-thread-db.c (try_thread_db_load_1): Change return type
2783         to bool.
2784         (try_thread_db_load): Likewise.
2785         (try_thread_db_load_from_pdir_1): Likewise.
2786         (try_thread_db_load_from_pdir): Likewise.
2787         (try_thread_db_load_from_sdir): Likewise.
2788         (try_thread_db_load_from_dir): Likewise.
2789         (thread_db_load_search): Likewise.
2790         (has_libpthread): Likewise.
2791         (thread_db_load): Likewise.
2792
2793 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2794
2795         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2796         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2797         NULL, and complain/return if that's the case.
2798
2799 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2800
2801         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2802         (advance, posn, abstract_read_memory): New functions.
2803         [struct mem_read_abstraction]: New struct.
2804         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2805
2806 2019-05-14  Tom Tromey  <tromey@adacore.com>
2807
2808         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2809         value is not lval_memory.
2810
2811 2019-05-14  Tom Tromey  <tromey@adacore.com>
2812
2813         * solib.c (info_sharedlibrary_command): Style the file name.
2814
2815 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2816
2817         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2818         (aarch64_vnv_type): Likewise.
2819         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2820         * common/tdesc.c: Likewise.
2821         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2822         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2823         * features/aarch64-fpu.xml: Add ieee half view.
2824         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2825         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2826         * gdbtypes.h (struct builtin_type): Likewise.
2827         (struct objfile_type): Likewise.
2828
2829 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2830
2831         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2832         typo.
2833         * location.h (string_to_event_location): Likewise.
2834
2835 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2836
2837         GDB 8.3 released.
2838
2839 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2840
2841         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2842         New variable declaration.
2843         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2844         New variable.
2845         (print_one_breakpoint): Use ui_out::test_flags and new global
2846         variable to compute use_fixed_output.
2847         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2848         Remove.
2849         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2850         (mi_multi_location_breakpoint_output_fixed): Remove.
2851         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2852         new variable.
2853         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2854         fix_multi_location_breakpoint_output flag if version >= 3.
2855         * ui-out.h (enum ui_out_flag)
2856         <fix_multi_location_breakpoint_output>: New enumerator.
2857
2858 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2859
2860         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2861
2862 2019-05-10  Tom Tromey  <tromey@adacore.com>
2863
2864         * ada-lang.c (catch_ada_completer): New function.
2865         (_initialize_ada_language): Use it.
2866
2867 2019-05-10  Tom Tromey  <tromey@adacore.com>
2868
2869         * thread.c (print_thread_info): Make "requested_threads" const.
2870         * gdbthread.h (print_thread_info): Make "requested_threads"
2871         const.
2872         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2873         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2874
2875 2019-05-08  Tom Tromey  <tom@tromey.com>
2876
2877         * gdbtypes.c (objfile_type_data): Change type.
2878         (objfile_type, _initialize_gdbtypes): Update.
2879
2880 2019-05-08  Tom Tromey  <tom@tromey.com>
2881
2882         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2883         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2884         (_initialize_dwarf2_frame): Update.
2885
2886 2019-05-08  Tom Tromey  <tom@tromey.com>
2887
2888         * objc-lang.c (objc_objfile_data): Change type.
2889         (find_methods): Update.
2890         (_initialize_objc_lang): Remove.
2891
2892 2019-05-08  Tom Tromey  <tom@tromey.com>
2893
2894         * stabsread.c (rs6000_builtin_type_data): Change type.
2895         (rs6000_builtin_type, _initialize_stabsread): Update.
2896
2897 2019-05-08  Tom Tromey  <tom@tromey.com>
2898
2899         * mips-tdep.c (mips_pdr_data): Remove.
2900         (_initialize_mips_tdep): Update.
2901
2902 2019-05-08  Tom Tromey  <tom@tromey.com>
2903
2904         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2905         (hppa_init_objfile_priv_data, read_unwind_info)
2906         (find_unwind_entry, _initialize_hppa_tdep): Update.
2907
2908 2019-05-08  Tom Tromey  <tom@tromey.com>
2909
2910         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2911         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2912         on obstack.
2913         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2914
2915 2019-05-08  Tom Tromey  <tom@tromey.com>
2916
2917         * mdebugread.c (basic_type_data): Change type.
2918         (basic_type, _initialize_mdebugread): Update.
2919
2920 2019-05-08  Tom Tromey  <tom@tromey.com>
2921
2922         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2923
2924 2019-05-08  Tom Tromey  <tom@tromey.com>
2925
2926         * nto-tdep.c (nto_inferior_data_reg): Change type.
2927         (nto_inferior_data): Update.
2928         (nto_inferior_data_cleanup, nto_new_inferior_data)
2929         (_initialize_nto_tdep): Remove.
2930         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2931
2932 2019-05-08  Tom Tromey  <tom@tromey.com>
2933
2934         * ada-lang.c (struct ada_inferior_data): Add initializers.
2935         (ada_inferior_data): Change type.
2936         (ada_inferior_data_cleanup): Remove.
2937         (get_ada_inferior_data, ada_inferior_exit)
2938         (struct ada_pspace_data): Add initializers, destructor.
2939         (ada_pspace_data_handle): Change type.
2940         (get_ada_pspace_data): Update.
2941         (ada_pspace_data_cleanup): Remove.
2942
2943 2019-05-08  Tom Tromey  <tom@tromey.com>
2944
2945         * coffread.c (struct coff_symfile_info): Add initializers.
2946         (coff_objfile_data_key): Move lower.  Change type.
2947         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2948         Update.
2949         (coff_free_info): Remove.
2950
2951 2019-05-08  Tom Tromey  <tom@tromey.com>
2952
2953         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2954         (fbsd_pspace_data_handle): Move lower.  Change type.
2955         (get_fbsd_pspace_data): Update.
2956         (fbsd_pspace_data_cleanup): Remove.
2957         (_initialize_fbsd_tdep): Update.
2958
2959 2019-05-08  Tom Tromey  <tom@tromey.com>
2960
2961         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2962         (get_ada_tasks_pspace_data): Update.
2963         (ada_tasks_pspace_data_cleanup): Remove.
2964         (_initialize_tasks): Update.
2965         (ada_tasks_inferior_data_handle): Change type.
2966         (get_ada_tasks_inferior_data): Update.
2967         (ada_tasks_inferior_data_cleanup): Remove.
2968         (struct ada_tasks_pspace_data): Add initializers.
2969
2970 2019-05-08  Tom Tromey  <tom@tromey.com>
2971
2972         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2973         * symfile-debug.c (debug_sym_get_probes): Change type.
2974         * stap-probe.c (handle_stap_probe):
2975         (stap_static_probe_ops::get_probes): Change type.
2976         * probe.h (class static_probe_ops) <get_probes>: Change type.
2977         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2978         (parse_probes_in_pspace): Update.
2979         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2980         Update.
2981         (any_static_probe_ops::get_probes): Change type.
2982         * elfread.c (elfread_data): New typedef.
2983         (probe_key): Change type.
2984         (elf_get_probes): Likewise.  Update.
2985         (probe_key_free): Remove.
2986         (_initialize_elfread): Update.
2987         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2988         Change type.
2989         (dtrace_process_dof_probe, dtrace_process_dof)
2990         (dtrace_static_probe_ops::get_probe): Change type.
2991
2992 2019-05-08  Tom Tromey  <tom@tromey.com>
2993
2994         * xcoffread.c (struct xcoff_symfile_info): Rename from
2995         coff_symfile_info.  Add initializers.
2996         (xcoff_objfile_data_key): Move lower.  Change type.
2997         (XCOFF_DATA): Rewrite.
2998         (xcoff_free_info): Remove.
2999         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3000         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3001         (xcoff_initial_scan): Update.
3002
3003 2019-05-08  Tom Tromey  <tom@tromey.com>
3004
3005         * solib-svr4.c (struct svr4_info): Add initializers and
3006         destructor.
3007         <probes_table>: Now an htab_up.
3008         (solib_svr4_pspace_data): Change type.
3009         (free_probes_table): Simplify.
3010         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3011         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3012         (probes_table_remove_objfile_probes, register_solib_event_probe)
3013         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3014         (_initialize_svr4_solib): Update.
3015
3016 2019-05-08  Tom Tromey  <tom@tromey.com>
3017
3018         * remote.c (remote_pspace_data): Change type.
3019         (remote_pspace_data_cleanup): Remove.
3020         (get_remote_exec_file, set_pspace_remote_exec_file)
3021         (_initialize_remote): Update.
3022
3023 2019-05-08  Tom Tromey  <tom@tromey.com>
3024
3025         * breakpoint.c (breakpoint_objfile_key): Change type.
3026         (get_breakpoint_objfile_data): Update.
3027         (free_breakpoint_objfile_data): Remove.
3028         (_initialize_breakpoint): Update.
3029
3030 2019-05-08  Tom Tromey  <tom@tromey.com>
3031
3032         * linux-tdep.c (struct linux_info): Add initializers.
3033         (linux_inferior_data): Move.  Change type.
3034         (invalidate_linux_cache_inf): Update.
3035         (linux_inferior_data_cleanup): Remove.
3036         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3037
3038 2019-05-08  Tom Tromey  <tom@tromey.com>
3039
3040         * auxv.c (auxv_inferior_data): Move.  Change type.
3041         (auxv_inferior_data_cleanup): Remove.
3042         (invalidate_auxv_cache_inf): Rewrite.
3043         (get_auxv_inferior_data, _initialize_auxv): Update.
3044
3045 2019-05-08  Tom Tromey  <tom@tromey.com>
3046
3047         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3048         (symfile_debug_objfile_data_key): Change type.
3049         (symfile_debug_installed, debug_qf_has_symbols)
3050         (debug_qf_find_last_source_symtab)
3051         (debug_qf_forget_cached_source_info)
3052         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3053         (debug_qf_print_stats, debug_qf_dump)
3054         (debug_qf_expand_symtabs_for_function)
3055         (debug_qf_expand_all_symtabs)
3056         (debug_qf_expand_symtabs_with_fullname)
3057         (debug_qf_map_matching_symbols)
3058         (debug_qf_expand_symtabs_matching)
3059         (debug_qf_find_pc_sect_compunit_symtab)
3060         (debug_qf_map_symbol_filenames)
3061         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3062         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3063         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3064         (debug_sym_read_linetable, debug_sym_relocate): Update.
3065         (symfile_debug_free_objfile): Remove.
3066         (install_symfile_debug_logging, _initialize_symfile_debug):
3067         Update.
3068
3069 2019-05-08  Tom Tromey  <tom@tromey.com>
3070
3071         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3072         allocate_on_obstack.
3073         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3074         (get_dwarf2_per_objfile): Update.
3075         (set_dwarf2_per_objfile): Remove.
3076         (dwarf2_has_info, dwarf2_get_section_info): Update.
3077         (dwarf2_free_objfile): Remove.
3078         (_initialize_dwarf2_read): Update.
3079
3080 2019-05-08  Tom Tromey  <tom@tromey.com>
3081
3082         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3083         initializers.
3084         <unsupported_script_warning_printed,
3085         script_not_found_warning_printed>: Now bool.
3086         (auto_load_pspace_data): Change type.
3087         (~auto_load_pspace_info): Rename from
3088         auto_load_pspace_data_cleanup.
3089         (get_auto_load_pspace_data, init_loaded_scripts_info)
3090         (clear_section_scripts, maybe_print_unsupported_script_warning)
3091         (maybe_print_script_not_found_warning, _initialize_auto_load):
3092         Update.
3093
3094 2019-05-08  Tom Tromey  <tom@tromey.com>
3095
3096         * objfiles.c (objfile_pspace_info): Add destructor and
3097         initializers.
3098         (objfiles_pspace_data): Change type.
3099         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3100         (get_objfile_pspace_data): Update.
3101         (objfiles_bfd_data): Change type.
3102         (get_objfile_bfd_data): Update.
3103         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3104
3105 2019-05-08  Tom Tromey  <tom@tromey.com>
3106
3107         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3108         Change type.
3109         (get_catch_syscall_inferior_data): Update.
3110         (catch_syscall_inferior_data_cleanup): Remove.
3111         (_initialize_break_catch_syscall): Update.
3112
3113 2019-05-08  Tom Tromey  <tom@tromey.com>
3114
3115         * inflow.c (struct terminal_info): Add destructor and
3116         initializers.
3117         (inflow_inferior_data): Change type.
3118         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3119         (get_inflow_inferior_data, inflow_inferior_exit)
3120         (swap_terminal_info, _initialize_inflow): Update.
3121
3122 2019-05-08  Tom Tromey  <tom@tromey.com>
3123
3124         * target-dcache.c (target_dcache_cleanup): Remove.
3125         (target_dcache_aspace_key): Change type.
3126         (target_dcache_init_p, target_dcache_invalidate)
3127         (target_dcache_get, target_dcache_get_or_init)
3128         (_initialize_target_dcache): Update.
3129         * dcache.h (struct dcache_deleter): New.
3130
3131 2019-05-08  Tom Tromey  <tom@tromey.com>
3132
3133         * symtab.c (struct symbol_cache): Add destructor and
3134         initializers.
3135         (symbol_cache_key): Move.  Change type.
3136         (make_symbol_cache, free_symbol_cache): Remove.
3137         (get_symbol_cache): Update.
3138         (symbol_cache_cleanup): Remove.
3139         (ALL_PSPACES, symbol_cache_flush)
3140         (maintenance_print_symbol_cache)
3141         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3142         Update.
3143
3144 2019-05-08  Tom Tromey  <tom@tromey.com>
3145
3146         * symtab.c (struct main_info): Add destructor and initializers.
3147         (main_progspace_key): Move.  Change type.
3148         (get_main_info): Update.
3149         (main_info_cleanup): Remove.
3150         (_initialize_symtab): Update.
3151
3152 2019-05-08  Tom Tromey  <tom@tromey.com>
3153
3154         * registry.h (DECLARE_REGISTRY): Define the _key class.
3155
3156 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * NEWS: Merge two 'New commands' sections.
3159
3160 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3161
3162         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3163         parameter and use Ada language definition instead.
3164         (ada_val_print_ptr): Remove unused language parameter.
3165         (ada_val_print_num): Remove language parameter and use Ada language
3166         definition instead.
3167         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3168         parameter.
3169         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3170         parameter and use Ada language definition instead.
3171         (ada_val_print_1): Update all ada_val_print_xxx calls.
3172         Remove language parameter.
3173         (ada_val_print): Update ada_val_print_1 call.
3174
3175 2019-05-08  Tom Tromey  <tromey@adacore.com>
3176
3177         * remote.c (remote_hw_watchpoint_limit)
3178         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3179         Now static.
3180
3181 2019-05-08  Tom Tromey  <tromey@adacore.com>
3182
3183         * maint.c (_initialize_maint_cmds): Move initialization code to
3184         remote.c.
3185         (watchdog, show_watchdog): Move to remote.c.
3186         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3187         "watchdog" static.
3188         (_initialize_remote): Move initialization code from maint.c.
3189         * defs.h (watchdog): Don't declare.
3190
3191 2019-05-08  Tom Tromey  <tromey@adacore.com>
3192
3193         * tui/tui-interp.c: Include main.h.
3194         * interps.c: Include main.h.
3195         * main.h (interpreter_p): Declare.
3196         * defs.h (interpreter_p): Don't declare.
3197
3198 2019-05-08  Tom Tromey  <tromey@adacore.com>
3199
3200         * dwarf2loc.c: Include dwarf2read.h.
3201         * defs.h (read_unsigned_leb128): Don't declare.
3202         * dwarf2read.h (read_unsigned_leb128): Declare.
3203
3204 2019-05-08  Tom Tromey  <tromey@adacore.com>
3205
3206         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3207         method.
3208
3209 2019-05-08  Tom Tromey  <tromey@adacore.com>
3210
3211         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3212         when no wrap column is set.
3213
3214 2019-05-08  Tom Tromey  <tromey@adacore.com>
3215
3216         * c-lang.c (c_get_string): Handle non-C-style arrays.
3217
3218 2019-05-08  Tom Tromey  <tromey@adacore.com>
3219
3220         * typeprint.c (print_offset_data::update): Print the bit offset,
3221         not the number of bits remaining.
3222
3223 2019-05-08  Tom Tromey  <tromey@adacore.com>
3224
3225         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3226         padding at end of comment.
3227
3228 2019-05-08  Tom Tromey  <tromey@adacore.com>
3229
3230         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3231         Compare main types.
3232
3233 2019-05-06  Tom Tromey  <tom@tromey.com>
3234
3235         * common/scoped_mmap.c: Include common-defs.h.
3236         * common/scoped_mmap.h: Don't include config.h.
3237
3238 2019-05-04  Tom Tromey  <tom@tromey.com>
3239
3240         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3241         (struct aarch64_call_info): Add initializers.
3242         <si>: Now a std::vector.
3243         (pass_on_stack, aarch64_push_dummy_call): Update.
3244
3245 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3246             Tom Tromey  <tom@tromey.com>
3247
3248         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3249         (ppc_threads): Now a std::vector.  Now static.
3250         (hwdebug_find_thread_points_by_tid)
3251         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3252         Update.
3253
3254 2019-05-04  Tom Tromey  <tom@tromey.com>
3255
3256         * arc-tdep.c (arc_tdesc_init): Return bool.
3257
3258 2019-05-04  Tom Tromey  <tom@tromey.com>
3259
3260         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3261         Use gdb_assert_not_reached.
3262
3263 2019-05-04  Tom Tromey  <tom@tromey.com>
3264
3265         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3266         "false".
3267
3268 2019-05-04  Tom Tromey  <tom@tromey.com>
3269
3270         * arc-tdep.c (arc_tdesc_init): Use bool.
3271
3272 2019-05-04  Tom Tromey  <tom@tromey.com>
3273
3274         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3275
3276 2019-05-04  Tom Tromey  <tom@tromey.com>
3277
3278         * cli/cli-cmds.c (valid_command_p): Return bool.
3279
3280 2019-05-04  Tom Tromey  <tom@tromey.com>
3281
3282         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3283         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3284
3285 2019-05-04  Raul Tambre  <raul@tambre.ee>
3286
3287         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3288         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3289         operator for comparison.
3290
3291 2019-05-04  Tom Tromey  <tom@tromey.com>
3292
3293         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3294         (lookup_partial_symbol, print_partial_symbols)
3295         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3296         (psymbol_compare): Update.
3297         (add_psymbol_to_bcache): Clear the entire psymbol.
3298         (maintenance_check_psymtabs): Update.
3299         * psympriv.h (struct partial_symbol): Don't derive from
3300         general_symbol_info.
3301         <obj_section, unrelocated_address, address,
3302         set_unrelocated_address>: Update.
3303         <ginfo>: New member.
3304         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3305         (debug_names::write_psymbols): Update.
3306
3307 2019-05-04  Tom de Vries  <tdevries@suse.de>
3308
3309         * contrib/cc-with-tweaks.sh: Support -n arg.
3310
3311 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3312
3313         * corelow.c (core_target::detach): Ensure frame cache and
3314         register caches are cleared.
3315         inferior.c (exit_inferior_1): Likewise.
3316
3317 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3318             Tom Tromey  <tom@tromey.com>
3319
3320         * dictionary.c (collate_pending_symbols_by_language): Remove
3321         "struct" from foreach.
3322         * symtab.c (lookup_global_symbol_from_objfile)
3323         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3324         foreach.
3325         * ser-tcp.c (net_open): Remove "struct" from foreach.
3326         * objfiles.c (objfile_relocate, objfile_rebase)
3327         (objfile_has_symbols): Remove "struct" from foreach.
3328         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3329         from foreach.
3330         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3331         foreach.
3332         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3333         "struct" from foreach.
3334         * ada-lang.c (create_excep_cond_exprs)
3335         (ada_exception_catchpoint_cond_string): Remove "struct" from
3336         foreach.
3337
3338 2019-05-03  Tom Tromey  <tromey@adacore.com>
3339
3340         * ada-exp.y (convert_char_literal): Check suffix of each
3341         enumerator.
3342
3343 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3344
3345         PR ada/21406:
3346         * ada-exp.y (yywrap): Don't define.
3347         * ada-lex.l (%option): Add noyywrap
3348         (yywrap): Remove.
3349
3350 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3351
3352         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3353         _WIN32_WINNT to the XP level, unless already defined to a higher
3354         level.
3355
3356         * unittests/parse-connection-spec-selftests.c:
3357         * ser-tcp.c:
3358         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3359         override.
3360
3361         * symfile.c (find_separate_debug_file): Remove colon from the
3362         drive spec of DOS/Windows file names of the target, so that the
3363         file name produced from DEBUGDIR and the target's directory will
3364         be valid on DOS/Windows systems.
3365
3366 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * rust-lang.c (val_print_struct): Handle printing structures
3369         containing strings.
3370
3371 2019-05-02  Tom Tromey  <tromey@adacore.com>
3372
3373         * valarith.c (_initialize_valarith): Remove.
3374
3375 2019-05-01  Tom Tromey  <tromey@adacore.com>
3376
3377         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3378         bitfields.
3379
3380 2019-05-01  Tom Tromey  <tromey@adacore.com>
3381
3382         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3383         for big-endian copies.
3384
3385 2019-04-30  Ali Tamur  <tamur@google.com>
3386         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3387         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3388         (read_3_bytes): New function.
3389
3390 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3391
3392         * windows-nat.c (main_thread_id): Delete.
3393         (handle_output_debug_string): Replace main_thread_id by
3394         current_event.dwThreadId.
3395         (fake_create_process): Likewise.
3396         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3397         Do not set main_thread_id.
3398         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3399         current_event.dwThreadId.
3400         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3401
3402 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3403
3404         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3405         Use current_event.dwThreadId instead of main_thread_id.
3406
3407 2019-04-30  Tom Tromey  <tromey@adacore.com>
3408
3409         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3410         (create_excep_cond_exprs): Iterate over program spaces.
3411         (ada_exception_catchpoint_cond_string): Examine all minimal
3412         symbols for exception types.
3413
3414 2019-04-30  Tom Tromey  <tromey@adacore.com>
3415
3416         PR c++/24470:
3417         * dwarf2read.c (process_structure_scope): Handle case where type
3418         has template parameters but no symbol was created.
3419
3420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3421             Chris January  <chris.january@arm.com>
3422
3423         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3424         qualifier.
3425         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3426
3427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * f-typeprint.c (f_print_type): Update rules for printing
3430         whitespace.
3431         (f_type_print_varspec_suffix): Likewise.
3432
3433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3434             Chris January  <chris.january@arm.com>
3435
3436         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3437         function arguments.
3438
3439 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * f-lang.c (build_fortran_types): Change name of void type to
3442         lower case.
3443         * f-typeprint.c (f_type_print_base): Print the name of the void
3444         type, rather than a fixed string.
3445         * f-valprint.c (f_decorations): Use lower case void string.
3446
3447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3448             Chris January  <chris.january@arm.com>
3449
3450         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3451         types for Fortran.
3452
3453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3454             Chris January  <chris.january@arm.com>
3455             David Lecomber  <david.lecomber@arm.com>
3456
3457         * f-exp.y (BINOP_INTRINSIC): New token.
3458         (exp): New parser rule handling BINOP_INTRINSIC.
3459         (f77_keywords): Add new builtin procedures.
3460         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3461         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3462         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3463         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3464         (print_unop_subexp_f): New function.
3465         (print_binop_subexp_f): New function.
3466         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3467         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3468         (dump_subexp_body_f): Likewise.
3469         (operator_check_f): Likewise.
3470         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3471         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3472
3473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3476         UNOP_KIND.
3477         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3478         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3479         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3480         (operator_length_f): New fuction.
3481         (print_subexp_f): New function.
3482         (op_name_f): New function.
3483         (dump_subexp_body_f): New function.
3484         (operator_check_f): New function.
3485         (exp_descriptor_f): Replace standard expression handling functions
3486         with new functions.
3487         * gdb/fortran-operator.def: New file.
3488         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3489         * gdb/std-operator.def: Remove UNOP_KIND.
3490
3491 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * std-operator.def: Remove unbalanced, stray double quote
3494         character.
3495
3496 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3497             Chris January  <chris.january@arm.com>
3498             Daniel Everett  <daniel.everett@arm.com>
3499             Nick Forrington  <nick.forrington@arm.com>
3500             Richard Bunt  <richard.bunt@arm.com>
3501
3502         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3503         of depth when printing anonymous structs or unions.
3504         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3505         Don't print either the top-level value, or the children if the
3506         max-depth is exceeded.
3507         (ppscm_print_children): When printing the key of a map, allow one
3508         extra level of depth.
3509         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3510         print either the top-level value, or the children if the max-depth
3511         is exceeded.
3512         (print_children): When printing the key of a map, allow one extra
3513         level of depth.
3514         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3515         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3516         (user_print_options): Initialise max_depth field.
3517         (val_print_scalar_or_string_type_p): New function.
3518         (val_print): Check to see if the max depth has been reached.
3519         (val_print_check_max_depth): Define new function.
3520         (show_print_max_depth): New function.
3521         (_initialize_valprint): Add 'print max-depth' option.
3522         * valprint.h (struct value_print_options) <max_depth>: New field.
3523         (val_print_check_max_depth): Declare new function.
3524         * NEWS: Document new feature.
3525
3526 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3527
3528         * ada-lang.c (ada_language_defn): Initialise new field.
3529         * c-lang.c (c_is_string_type_p): New function.
3530         (c_language_defn): Initialise new field.
3531         (cplus_language_defn): Initialise new field.
3532         (asm_language_defn): Initialise new field.
3533         (minimal_language_defn): Initialise new field.
3534         * c-lang.h (c_is_string_type_p): Declare new function.
3535         * d-lang.c (d_language_defn): Initialise new field.
3536         * f-lang.c (f_is_string_type_p): New function.
3537         (f_language_defn): Initialise new field.
3538         * go-lang.c (go_is_string_type_p): New function.
3539         (go_language_defn): Initialise new field.
3540         * language.c (default_is_string_type_p): New function.
3541         (unknown_language_defn): Initialise new field.
3542         (auto_language_defn): Initialise new field.
3543         * language.h (struct language_defn) <la_is_string_type_p>: New
3544         member variable.
3545         (default_is_string_type_p): Declare new function.
3546         * m2-lang.c (m2_language_defn): Initialise new field.
3547         * objc-lang.c (objc_language_defn): Initialise new field.
3548         * opencl-lang.c (opencl_language_defn): Initialise new field.
3549         * p-lang.c (pascal_is_string_type_p): New function.
3550         (pascal_language_defn): Initialise new field.
3551         * rust-lang.c (rust_is_string_type_p): New function.
3552         (rust_language_defn): Initialise new field.
3553
3554 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3557         New field.
3558         * ada-lang.c (ada_language_defn): Initialise new field.
3559         * c-lang.c (c_language_defn): Likewise.
3560         (cplus_language_defn): Likewise.
3561         (asm_language_defn): Likewise.
3562         (minimal_language_defn): Likewise.
3563         * d-lang.c (d_language_defn): Likewise.
3564         * f-lang.c (f_language_defn): Likewise.
3565         * go-lang.c (go_language_defn): Likewise.
3566         * language.c (unknown_language_defn): Likewise.
3567         (auto_language_defn): Likewise.
3568         * m2-lang.c (m2_language_defn): Likewise.
3569         * objc-lang.c (objc_language_defn): Likewise.
3570         * opencl-lang.c (opencl_language_defn): Likewise.
3571         * p-lang.c (pascal_language_defn): Likewise.
3572         * rust-lang.c (rust_language_defn): Likewise.
3573
3574 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * ada-lang.c (ada_is_character_type): Change return type to bool.
3577         (ada_is_string_type): Likewise.
3578         * ada-lang.h (ada_is_character_type): Update declaration
3579         (ada_is_string_type): Likewise.
3580
3581 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3582
3583         Support style in 'frame|thread apply'
3584
3585         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3586         * record.c (record_start, record_stop): Update callers of
3587         execute_command_to_string with false.
3588         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3589         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3590         methods.
3591         (class string_file): New constructor with term_out parameter.
3592         Override methods term_out and can_emit_style_escape.  New member
3593         term_out.
3594         (class stdio_file): Override can_emit_style_escape.
3595         (class tee_file): Override term_out and can_emit_style_escape.
3596         * utils.h (can_emit_style_escape): Remove.
3597         * utils.c (can_emit_style_escape): Likewise.
3598         Update all callers of can_emit_style_escape (SOMESTREAM) to
3599         SOMESTREAM->can_emit_style_escape.
3600         * source-cache.c (source_cache::get_source_lines): Likewise.
3601         * stack.c (frame_apply_command_count): Call execute_command_to_string
3602         passing the term_out characteristic of the current gdb_stdout.
3603         * thread.c (thr_try_catch_cmd): Likewise.
3604         * top.c (execute_command_to_string): pass term_out parameter
3605         to construct the string_file for the command output.
3606         * ui-file.c (term_cli_styling): New function (most code moved
3607         from utils.c can_emit_style_escape).
3608         (string_file::string_file, string_file::can_emit_style_escape,
3609         stdio_file::can_emit_style_escape, tee_file::term_out,
3610         tee_file::can_emit_style_escape): New functions.
3611
3612 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3613
3614         * NEWS: Mention the new set|show may-call-functions.
3615         * infcall.c (may_call_functions_p): New variable.
3616         (show_may_call_functions_p): New function.
3617         (call_function_by_hand_dummy): Throws an error if not
3618         may-call-functions.
3619         (_initialize_infcall): Call add_setshow_boolean_cmd for
3620         may-call-functions.
3621
3622 2019-04-25  Keith Seitz  <keiths@redhat.com>
3623
3624         PR c++/24367
3625         * cp-support.c (inspect_type): Don't attempt substitutions
3626         of symbol with the same name.
3627
3628 2019-04-25  Tom Tromey  <tromey@adacore.com>
3629
3630         PR gdb/24475:
3631         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3632         static.
3633
3634 2019-04-25  Tom Tromey  <tromey@adacore.com>
3635
3636         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3637         rvalue reference.
3638         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3639         (gdb_xml_parser::parse): Use std::move.
3640         * python/python-internal.h (gdbpy_convert_exception): Take a const
3641         reference.
3642         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3643         std::move.
3644         * python/py-utils.c (gdbpy_convert_exception): Take a const
3645         reference.
3646         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3647         Use std::move.
3648         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3649         Use std::move.
3650         * mi/mi-main.c (mi_print_exception): Take a const reference.
3651         * main.c (handle_command_errors): Take a const reference.
3652         * linespec.c (parse_linespec): Use std::move.
3653         * infcall.c (run_inferior_call): Use std::move.
3654         (call_function_by_hand_dummy): Use std::move.
3655         * exec.c (try_open_exec_file): Use std::move.
3656         * exceptions.h (exception_print, exception_fprintf)
3657         (exception_print_same): Update.
3658         * exceptions.c (print_exception, exception_print)
3659         (exception_fprintf, exception_print_same): Change parameters to
3660         const reference.
3661         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3662         * common/new-op.c: Use std::move.
3663         * common/common-exceptions.h (struct gdb_exception): Add move
3664         constructor.
3665         (struct gdb_exception_error, struct gdb_exception_quit, struct
3666         gdb_quit_bad_alloc): Change constructor to move constructor.
3667         (throw_exception): Change parameter to rvalue reference.
3668         * common/common-exceptions.c (throw_exception): Take rvalue
3669         reference.
3670         * cli/cli-interp.c (safe_execute_command): Use std::move.
3671         * breakpoint.c (insert_bp_location, location_to_sals): Use
3672         std::move.
3673
3674 2019-04-25  Tom Tromey  <tromey@adacore.com>
3675
3676         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3677         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3678         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3679         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3680         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3681         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3682         guile/scm-value.c: Use unpack.
3683         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3684         gdbscm_gdb_exception.
3685         (gdbscm_throw_gdb_exception): Likewise.
3686         (struct gdbscm_gdb_exception): New.
3687         (unpack): New function.
3688         (gdbscm_wrap): Use unpack.
3689
3690 2019-04-25  Tom Tromey  <tromey@adacore.com>
3691
3692         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3693         (gdb_rl_callback_handler): Use std::move.
3694         * common/common-exceptions.h (struct gdb_exception): Add move
3695         assignment operator.
3696         (throw_exception_sjlj): Change "exception" to const reference.
3697         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3698         (throw_exception_sjlj): Change "exception" to const reference.
3699
3700 2019-04-25  Tom Tromey  <tromey@adacore.com>
3701
3702         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3703         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3704         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3705         Update.
3706         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3707         Update.
3708         * mi/mi-interp.c (mi_interp::exec): Update.
3709         * linespec.c (parse_linespec): Update.
3710         * infcall.c (run_inferior_call): Update.
3711         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3712         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3713         (gdbscm_lookup_global_symbol): Update.
3714         * guile/scm-param.c (gdbscm_parameter_value): Update.
3715         * guile/scm-frame.c (gdbscm_frame_read_register)
3716         (gdbscm_frame_read_var): Update.
3717         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3718         * exec.c (try_open_exec_file): Update.
3719         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3720         (gdb_rl_callback_handler): Update.
3721         * common/common-exceptions.h (exception_none): Don't declare.
3722         * common/common-exceptions.c (exception_none): Don't define.
3723         (struct catcher) <exception>: Update.
3724         * cli/cli-interp.c (safe_execute_command): Update.
3725         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3726
3727 2019-04-25  Ali Tamur  <tamur@google.com>
3728
3729         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3730         (read_attribute_value): Likewise.
3731         (dwarf2_read_addr_index): Update comment.
3732         (read_str_index): Add DW_FORM_strx.
3733         (dwarf2_string_attr): Likewise.
3734         (dwarf2_const_value_attr): Likewise.
3735         (dump_die_shallow): Likewise.
3736         (dwarf2_fetch_constant_bytes): Likewise.
3737         (skip_form_bytes): Likewise.
3738         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3739
3740 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3741
3742         PR corefiles/11608
3743         PR corefiles/18187
3744         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3745         OFFSET.  Verify if current mapping contains an ELF header.
3746         (linux_find_memory_regions_full): Adjust call to
3747         dump_mapping_p.
3748
3749 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3750             Kang Li <kanglictf@gmail.com>
3751
3752         PR gdb/21600
3753
3754         * dwarf2-frame.c (read_initial_length): Be consistent about using
3755         unsigned representation of length.
3756         (decode_frame_entry_1): Likewise.  Check for wraparound of
3757         end pointer as well as buffer overflow.
3758
3759 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3760
3761         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3762         "vq".
3763
3764 2019-04-24  Tom Tromey  <tromey@adacore.com>
3765
3766         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3767
3768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * s12z-tdep.c (s12z_unwind_pc): Delete.
3771         (s12z_unwind_sp): Delete.
3772         (s12z_gdbarch_init): Don't register deleted functions with
3773         gdbarch.
3774
3775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * rl78-tdep.c (rl78_unwind_sp): Delete.
3778         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3779
3780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3781
3782         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3783         (xstormy16_unwind_pc): Delete.
3784         (xstormy16_dummy_id): Delete.
3785         (xstormy16_gdbarch_init): Don't register deleted functions with
3786         gdbarch.
3787
3788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * vax-tdep.c (vax_unwind_pc): Delete.
3791         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3792
3793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * v850-tdep.c (v850_unwind_sp): Delete.
3796         (v850_unwind_pc): Delete.
3797         (v850_dummy_id): Delete.
3798         (v850_gdbarch_init): Don't register deleted functions with
3799         gdbarch.
3800
3801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3802
3803         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3804         (tilegx_unwind_pc): Delete.
3805         (tilegx_unwind_dummy_id): Delete.
3806         (tilegx_gdbarch_init): Don't register deleted functions with
3807         gdbarch.
3808
3809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3812         (tic6x_dummy_id): Delete.
3813         (tic6x_gdbarch_init): Don't register deleted functions with
3814         gdbarch.
3815
3816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * sparc-tdep.c (sparc_unwind_pc): Delete.
3819         (sparc32_gdbarch_init): Don't register deleted function with
3820         gdbarch.
3821
3822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * sh-tdep.c (sh_unwind_sp): Delete.
3825         (sh_unwind_pc): Delete.
3826         (sh_dummy_id): Delete.
3827         (sh_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * score-tdep.c (score_unwind_sp): Delete.
3833         (score_unwind_pc): Delete.
3834         (score_dummy_id): Delete.
3835         (score_gdbarch_init): Don't register deleted functions with
3836         gdbarch.
3837
3838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * rx-tdep.c (rx_unwind_pc): Delete.
3841         (rx_unwind_sp): Delete.
3842         (rx_dummy_id): Delete.
3843         (rx_gdbarch_init): Don't register deleted functions with
3844         gdbarch.  Update comment.
3845
3846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3849         (rs6000_dummy_id): Delete.
3850         (rs6000_gdbarch_init): Don't register deleted functions with
3851         gdbarch.
3852
3853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * or1k-tdep.c (or1k_dummy_id): Delete.
3856         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3857
3858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * nios2-tdep.c (nios2_dummy_id): Delete.
3861         (nios2_unwind_sp): Delete.
3862         (nios2_gdbarch_init): Don't register deleted functions with
3863         gdbarch.
3864
3865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * nds32-tdep.c (nds32_dummy_id): Delete.
3868         (nds32_unwind_pc): Delete.
3869         (nds32_unwind_sp): Delete.
3870         (nds32_gdbarch_init): Don't register deleted functions with
3871         gdbarch.
3872
3873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * msp430-tdep.c (msp430_unwind_pc): Delete.
3876         (msp430_unwind_sp): Delete.
3877         (msp430_dummy_id): Delete.
3878         (msp430_gdbarch_init): Don't register deleted functions with
3879         gdbarch.
3880
3881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * moxie-tdep.c (moxie_unwind_sp): Delete.
3884         (moxie_unwind_pc): Delete.
3885         (moxie_dummy_id): Delete.
3886         (moxie_gdbarch_init): Don't register deleted functions with
3887         gdbarch.
3888
3889 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3892         (mn10300_unwind_pc): Delete.
3893         (mn10300_unwind_sp): Delete.
3894         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3895         mn10300_unwind_sp.
3896         (mn10300_frame_unwind_init): Don't register deleted functions with
3897         gdbarch.
3898
3899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * mep-tdep.c (mep_unwind_pc): Delete.
3902         (mep_unwind_sp): Delete.
3903         (mep_dummy_id): Delete.
3904         (mep_gdbarch_init): Don't register deleted functions with
3905         gdbarch.
3906
3907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3910         (m68hc11_unwind_sp): Delete.
3911         (m68hc11_gdbarch_init): Don't register deleted functions with
3912         gdbarch.
3913
3914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * m32r-tdep.c (m32r_unwind_sp): Delete.
3917         (m32r_unwind_pc): Delete.
3918         (m32r_dummy_id): Delete.
3919         (m32r_gdbarch_init): Don't register deleted functions with
3920         gdbarch.
3921
3922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3923
3924         * m32c-tdep.c (m32c_unwind_pc): Delete.
3925         (m32c_unwind_sp): Delete.
3926         (m32c_dummy_id): Delete.
3927         (m32c_gdbarch_init): Don't register deleted functions with
3928         gdbarch.
3929
3930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3933         (lm32_unwind_pc): Delete.
3934         (lm32_dummy_id): Delete.
3935         (lm32_gdbarch_init): Don't register deleted functions with
3936         gdbarch.
3937
3938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3941         (iq2000_unwind_pc): Delete.
3942         (iq2000_dummy_id): Delete.
3943         (iq2000_gdbarch_init): Don't register deleted functions with
3944         gdbarch.
3945
3946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * nds32-tdep.c (nds32_type_align): Delete.
3949         (nds32_push_dummy_call): Use type_align instead.
3950
3951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * arm-tdep.c (arm_type_align): Only handle vector override case.
3954         (arm_push_dummy_call): Use type_align.
3955         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3956
3957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3958
3959         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3960         case.
3961         (pass_on_stack): Use type_align.
3962         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3963         function.
3964
3965 2019-04-23  Tom Tromey  <tromey@adacore.com>
3966
3967         * dwarf2read.c (line_header::file_name_at): Remove unused
3968         overload.
3969
3970 2019-04-23  Tom de Vries  <tdevries@suse.de>
3971
3972         PR gdb/24438
3973         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3974         invocation.
3975
3976
3977 2019-03-27  Ali Tamur  <tamur@google.com>
3978
3979         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3980         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3981         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3982         (dwarf_expr_context::get_addr_index): Likewise
3983         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3984         (symbol_needs_eval_context::get_addr_index): Likewise
3985         (disassemble_dwarf_expression): Add DW_OP_addrx
3986         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3987         (read_cutu_die_from_dwo): Update comment
3988         (skip_one_die): Add DW_FORM_addrx
3989         (read_attribute_value): Likewise
3990         (var_decode_location): Add DW_OP_addrx
3991         (dwarf2_const_value_attr): Add DW_FORM_addrx
3992         (dump_die_shallow): Likewise
3993         (dwarf2_fetch_constant_bytes): Likewise
3994         (decode_locdesc): Add DW_OP_addrx
3995         (skip_form_bytes): Add DW_FORM_addrx
3996
3997 2019-04-22  Ali Tamur  <tamur@google.com>
3998
3999         * MAINTAINERS (Write After Approval): Add self.
4000
4001 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4002
4003         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4004         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4005         (open_symbol_file_object): Likewise.
4006         (svr4_default_sos): Add info parameter.
4007         (svr4_read_so_list): Likewise.
4008         (svr4_current_sos_direct): Adjust functions calls to pass down
4009         info.
4010         (svr4_current_sos_1): Add info parameter.
4011         (svr4_current_sos): Call get_svr4_info, pass info down to
4012         svr4_current_sos_1.
4013         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4014         get_svr4_info.
4015         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4016         get_svr4_info.
4017         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4018         to get_svr4_info.
4019         (probes_table_remove_objfile_probes): Likewise.
4020         (register_solib_event_probe): Add info parameter.
4021         (solist_update_incremental): Pass info parameter down to
4022         svr4_read_so_list.
4023         (disable_probes_interface): Add info parameter.
4024         (svr4_handle_solib_event): Pass current_program_space to
4025         get_svr4_info.  Adjust disable_probes_interface cleanup.
4026         (svr4_create_probe_breakpoints): Add info parameter, pass it
4027         down to register_solib_event_probe.
4028         (svr4_create_solib_event_breakpoints): Add info parameter,
4029         pass it down to svr4_create_probe_breakpoints.
4030         (enable_break): Pass info down to
4031         svr4_create_solib_event_breakpoints.
4032         (svr4_solib_create_inferior_hook): Pass current_program_space to
4033         get_svr4_info.
4034         (svr4_clear_solib): Likewise.
4035
4036 2019-04-22  Pedro Alves  <palves@redhat.com>
4037
4038         * solib-svr4.c (svr4_free_objfile_observer): New.
4039         (probe_and_action::objfile): New field.
4040         (probes_table_htab_remove_objfile_probes)
4041         (probes_table_remove_objfile_probes): New functions.
4042         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4043         in the new probe_and_action.  Don't store the probe in 'lookup'.
4044         (svr4_create_probe_breakpoints): Pass objfile to
4045         register_solib_event_probe.
4046         (_initialize_svr4_solib): Register a free_objfile observer.
4047
4048 2019-04-19  Tom Tromey  <tom@tromey.com>
4049
4050         * common/queue.h: Remove.
4051
4052 2019-04-19  Tom Tromey  <tom@tromey.com>
4053
4054         * event-loop.c: Don't include "common/queue.h".
4055
4056 2019-04-19  Tom Tromey  <tom@tromey.com>
4057
4058         * remote.c (remote_target): Use delete.
4059         * remote-notif.h: Include <list>, not "common/queue.h".
4060         (notif_client_p): Remove typedef.
4061         (remote_notif_state): Add constructor, destructor, initializer.
4062         <notif_queue>: Now a std::list.
4063         (remote_notif_state_xfree): Don't declare.
4064         * remote-notif.c (remote_notif_process, handle_notification)
4065         (remote_notif_state_allocate): Update.
4066         (~remote_notif_state): Rename from remote_notif_state_xfree.
4067
4068 2019-04-19  Tom Tromey  <tom@tromey.com>
4069
4070         * symfile.c (reread_symbols): Update.
4071         * objfiles.c (objfile_register_static_link)
4072         (objfile_lookup_static_link): Update
4073         (~objfile) Don't delete static_links.
4074         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4075
4076 2019-04-19  Tom Tromey  <tom@tromey.com>
4077
4078         * type-stack.h (struct type_stack) <insert>: Constify string.
4079         * type-stack.c (type_stack::insert): Constify string.
4080         * gdbtypes.h (lookup_template_type): Update.
4081         (address_space_name_to_int): Update.
4082         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4083         const.
4084         (lookup_template_type): Make name const.
4085         * c-exp.y: Update rules.
4086         (lex_one_token, classify_name, classify_inner_name)
4087         (c_print_token): Update.
4088         * p-exp.y: Update rules.
4089         (yylex): Update.
4090         * f-exp.y: Update rules.
4091         (yylex): Update.
4092         * d-exp.y: Update rules.
4093         (lex_one_token, classify_name, classify_inner_name): Update.
4094         * parse.c (write_dollar_variable, copy_name): Return std::string.
4095         * parser-defs.h (copy_name): Change return type.
4096         * m2-exp.y: Update rules.
4097         (yylex): Update.
4098         * go-exp.y (lex_one_token): Update.
4099         Update rules.
4100         (classify_unsafe_function, classify_packaged_name)
4101         (classify_name, yylex): Update.
4102
4103 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4104
4105         * configure.ac: add --enable-source-highlight switch.
4106         * configure: Regenerate.
4107         * top.c (print_gdb_version): plumb --enable-source-highlight
4108         status to "show configuration".
4109
4110 2019-04-19  Tom Tromey  <tromey@adacore.com>
4111
4112         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4113         Check ADA_TYPE_P.
4114         (empty_record, ada_template_to_fixed_record_type_1)
4115         (template_to_static_fixed_type)
4116         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4117         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4118         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4119         macros.
4120
4121 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4122
4123         PR symtab/24423:
4124         * source.c (print_source_lines_base): Advance "iter" when a
4125         control character is seen.
4126
4127 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4128
4129         * inferior.h (struct infcall_suspend_state_deleter):
4130         Catch exception in destructor to avoid crash.
4131
4132 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4133
4134         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4135         close to the add_com "shell".
4136
4137 2019-04-18  Tom Tromey  <tromey@adacore.com>
4138
4139         * process-stratum-target.h (class process_stratum_target)
4140         <stratum>: Add "final".
4141
4142 2019-04-17  Tom Tromey  <tromey@adacore.com>
4143
4144         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4145         against nullptr before use.
4146
4147 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4148
4149         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4150
4151 2019-04-17  Jim Wilson  <jimw@sifive.com>
4152             Andrew Burgess  <andrew.burgess@embecosm.com>
4153
4154         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4155         code read might fail, assume 4-byte breakpoint in that case.
4156
4157 2019-04-15  Leszek Swirski  <leszeks@google.com>
4158
4159         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4160         rather than a hand-rolled POD check when checking for forced MEMORY
4161         classification.
4162
4163 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4164
4165         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4166         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4167         function.
4168         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4169         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4170         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4171         declaration.
4172
4173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4174
4175         * aarch64-linux-nat.c
4176         (aarch64_linux_nat_target::thread_architecture): Add override.
4177         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4178         each VQ.
4179
4180 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4181
4182         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4183
4184 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4187         target types of size 96-bits, add some additional comments, and
4188         check that the builtin type we found was the correct size.
4189
4190 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4191
4192         * utils.c (prompt_for_continue): Don't restore the styling at the
4193         end, as applied_style has the wrong value.  This fixes styling in
4194         long lists of file names that are interrupted by the "Continue?"
4195         prompt.
4196
4197 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4200         * c-lang.c (c_language_defn): Likewise.
4201         (cplus_language_defn): Likewise.
4202         (asm_language_defn): Likewise.
4203         (minimal_language_defn): Likewise.
4204         * d-lang.c (d_language_defn): Likewise.
4205         * f-lang.c (f_language_defn): Likewise.
4206         * go-lang.c (go_language_defn): Likewise.
4207         * language.c (unknown_language_defn): Likewise.
4208         (auto_language_defn): Likewise.
4209         * language.h (struct language_defn): Remove la_magic field.
4210         (LANG_MAGIC): Delete.
4211         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4212         * objc-lang.c (objc_language_defn): Likewise.
4213         * opencl-lang.c (opencl_language_defn): Likewise.
4214         * p-lang.c (pascal_language_defn): Likewise.
4215         * rust-lang.c (rust_language_defn): Likewise.
4216
4217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * riscv-tdep.c (riscv_type_align): New function.
4220         (riscv_type_alignment): Delete.
4221         (riscv_arg_location): Use 'type_align'.
4222         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4223
4224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * gdbtypes.c (type_align): A struct with no non-static fields also
4227         has alignment of 1.
4228
4229 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4232         component to 0.
4233         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4234         member.
4235         (riscv_struct_info::analyse): New implementation using new
4236         analyse_inner member function.
4237         (riscv_struct_info::field_offset): New member function.
4238         (riscv_struct_info::m_offsets): New member variable.
4239         (riscv_struct_info::analyse_inner): New private member function,
4240         takes the old implementation of riscv_struct_info::analyse but
4241         extended to track field offsets.
4242         (riscv_call_arg_struct): Update the struct folding special cases
4243         to handle cases where empty C++ structs, which are non-zero
4244         length, are found.
4245         (riscv_arg_location): Initialise the length of each location, a
4246         non-zero length now indicates the location is in use.
4247         (riscv_push_dummy_call): Allow for the first location having a
4248         non-zero offset when setting up arguments.
4249         (riscv_return_value): Likewise, but for return values.
4250
4251 2019-04-11  Tom Tromey  <tromey@adacore.com>
4252
4253         * utils.c (internal_vproblem): Make "msg" const.
4254
4255 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4256
4257         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4258         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4259         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4260         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4261
4262 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4263
4264         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4265         function.
4266         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4267         of amd64_collect_native_gregset.
4268         (amd64_linux_nat_target::store_registers): Likewise.
4269
4270 2019-04-10  Tom Tromey  <tom@tromey.com>
4271
4272         * symtab.c (lookup_global_symbol_from_objfile)
4273         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4274         * objfiles.h (class separate_debug_iterator): New.
4275         (class separate_debug_range): New.
4276         (struct objfile) <separate_debug_objfiles>: New method.
4277         (objfile_separate_debug_iterate): Don't declare.
4278         * objfiles.c (separate_debug_iterator::operator++): Rename from
4279         objfile_separate_debug_iterate.
4280         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4281         iterator.
4282         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4283         iterator.
4284
4285 2019-04-10  Tom Tromey  <tom@tromey.com>
4286
4287         * symfile.c (reread_symbols): Remove old comment.
4288         * objfiles.c (free_all_objfiles): Fix a typo.
4289
4290 2019-04-10  Tom Tromey  <tom@tromey.com>
4291
4292         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4293         * minsyms.c (lookup_minimal_symbol): Use foreach.
4294         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4295         (lookup_minimal_symbol_solib_trampoline): Likewise.
4296         * symfile.c (reread_symbols): Use foreach.
4297
4298 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4299             Tom Tromey  <tromey@adacore.com>
4300
4301         PR rust/24414:
4302         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4303         (rust_lex_int_test): Change "value" to be LONGEST.
4304         (rust_lex_tests): Add test for long integer literal.
4305
4306 2019-04-09  Tom Tromey  <tromey@adacore.com>
4307
4308         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4309         to bool.
4310         (extended_remote_target::attach): Update.
4311         (remote_target::remote_notice_new_inferior): Update.
4312         (remote_target::add_current_inferior_and_thread): Update.
4313         * inferior.c (exit_inferior_1): Use "false".
4314         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4315
4316 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4317
4318         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4319         the "start" command.
4320
4321 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4322
4323         * python/py-inferior.c (infpy_thread_from_thread_handle):
4324         Adjust comments to reflect renaming of thread_from_thread_handle
4325         to thread_from_handle.  Adjust keywords.  Fix type error message.
4326         (inferior_object_methods): Add thread_from_handle.  Retain
4327         thread_from_thread_handle, but mark it as deprecated.
4328
4329 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4330
4331         * gdbthread.h (find_thread_by_handle): Revise declaration.
4332         * thread.c (find_thread_by_handle): Likewise.  Adjust
4333         implementation too.
4334         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4335         support for buffer objects as handles.
4336
4337 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4338
4339         * python/py-infthread.c (thpy_thread_handle): New function.
4340         (thread_object_methods): Register thpy_thread_handle.
4341
4342 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4343
4344         * gdbthread.h (thread_to_thread_handle): Declare.
4345         * thread.c (gdbtypes.h): Include.
4346         (thread_to_thread_handle): New function.
4347
4348         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4349         (target_thread_info_to_thread_handle): Declare.
4350         * target.c (target_thread_info_to_thread_handle): New function.
4351         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4352         * target-delegates.c: Regenerate.
4353
4354         * linux-thread-db.c (class thread_db_target): Add method
4355         thread_info_to_thread_handle.
4356         (thread_db_target::thread_info_to_thread_handle): Define.
4357         * remote.c (class remote_target): Add new method
4358         thread_info_to_thread_handle.
4359         (remote_target::thread_info_to_thread_handle): Define.
4360
4361 2019-04-08  Pedro Alves  <palves@redhat.com>
4362
4363         * common/common-exceptions.c (throw_exception): Don't create
4364         named object to throw; throw directly.
4365         (throw_it): Likewise.  Don't initialize gdb_exception::message
4366         here, with new; pass FMT and AP to the ctor instead.
4367         * common/common-exceptions.h: Include <string>.
4368         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4369         const char *, va_list)): New ctor.  Use std::make_shared.
4370         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4371         errors)): Delete.
4372         (gdb_exception_error::gdb_exception_error(enum errors, const char
4373         *, va_list)): New.
4374         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4375         Add assertion.
4376         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4377         errors)): Delete.
4378         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4379         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4380         Add assertion.
4381
4382 2019-04-08  Tom Tromey  <tom@tromey.com>
4383
4384         * valops.c (value_rtti_indirect_type): Replace throw_exception
4385         with throw.
4386         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4387         with throw.
4388         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4389         throw.
4390         * target.c (target_translate_tls_address): Replace throw_exception
4391         with throw.
4392         * stack.c (frame_apply_command_count): Replace throw_exception
4393         with throw.
4394         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4395         throw.
4396         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4397         with throw.
4398         * rs6000-tdep.c (rs6000_frame_cache)
4399         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4400         * remote.c: Replace throw_exception with throw.
4401         * record-full.c (record_full_message, record_full_wait_1)
4402         (record_full_restore): Replace throw_exception with throw.
4403         * record-btrace.c:
4404         (get_thread_current_frame_id, record_btrace_start_replaying)
4405         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4406         (cmd_record_btrace_start): Replace throw_exception with throw.
4407         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4408         throw.
4409         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4410         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4411         * linespec.c:
4412         (find_linespec_symbols): Replace throw_exception with throw.
4413         * infrun.c (displaced_step_prepare, resume): Replace
4414         throw_exception with throw.
4415         * infcmd.c (post_create_inferior): Replace throw_exception with
4416         throw.
4417         * inf-loop.c (inferior_event_handler): Replace throw_exception
4418         with throw.
4419         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4420         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4421         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4422         (get_prev_frame_always, get_frame_pc_if_available)
4423         (get_frame_address_in_block_if_available, get_frame_language):
4424         Replace throw_exception with throw.
4425         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4426         throw_exception with throw.
4427         * eval.c (fetch_subexp_value, evaluate_var_value)
4428         (evaluate_funcall, evaluate_subexp_standard): Replace
4429         throw_exception with throw.
4430         * dwarf2loc.c (call_site_find_chain)
4431         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4432         Replace throw_exception with throw.
4433         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4434         with throw.
4435         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4436         throw.
4437         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4438         * completer.c (complete_line_internal): Replace throw_exception
4439         with throw.
4440         * compile/compile-object-run.c (compile_object_run): Replace
4441         throw_exception with throw.
4442         * cli/cli-script.c (process_next_line): Replace throw_exception
4443         with throw.
4444         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4445         (btrace_enable, btrace_maint_update_pt_packets): Replace
4446         throw_exception with throw.
4447         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4448         throw_exception with throw.
4449         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4450         throw_exception with throw.
4451         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4452         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4453         * aarch64-tdep.c (aarch64_make_prologue_cache)
4454         (aarch64_make_stub_cache): Replace throw_exception with throw.
4455
4456 2019-04-08  Tom Tromey  <tom@tromey.com>
4457
4458         * common/common-exceptions.c (throw_exception): Rename from
4459         throw_exception_cxx.  Remove old copy.  Make argument const.
4460         (throw_it): Create and throw exception objects directly.
4461         * common/common-exceptions.h (throw_exception): Make argument
4462         const.
4463         (struct gdb_exception_error): Add constructor.
4464         (struct gdb_exception_quit): Add constructor.
4465
4466 2019-04-08  Tom Tromey  <tom@tromey.com>
4467
4468         * common/common-exceptions.h (exception_rethrow): Don't declare.
4469         (TRY_SJLJ): Update comment.
4470         (TRY, CATCH, END_CATCH): Remove.
4471         * common/common-exceptions.c (exception_rethrow): Remove.
4472
4473 2019-04-08  Tom Tromey  <tom@tromey.com>
4474
4475         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4476         Remove.
4477         (gdb_exception_error): Rename from
4478         gdb_exception_RETURN_MASK_ERROR.
4479         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4480         (gdb_quit_bad_alloc): Update.
4481         * aarch64-tdep.c: Update.
4482         * ada-lang.c: Update.
4483         * ada-typeprint.c: Update.
4484         * ada-valprint.c: Update.
4485         * amd64-tdep.c: Update.
4486         * arch-utils.c: Update.
4487         * break-catch-throw.c: Update.
4488         * breakpoint.c: Update.
4489         * btrace.c: Update.
4490         * c-varobj.c: Update.
4491         * cli/cli-cmds.c: Update.
4492         * cli/cli-interp.c: Update.
4493         * cli/cli-script.c: Update.
4494         * common/common-exceptions.c: Update.
4495         * common/new-op.c: Update.
4496         * common/selftest.c: Update.
4497         * compile/compile-c-symbols.c: Update.
4498         * compile/compile-cplus-symbols.c: Update.
4499         * compile/compile-object-load.c: Update.
4500         * compile/compile-object-run.c: Update.
4501         * completer.c: Update.
4502         * corelow.c: Update.
4503         * cp-abi.c: Update.
4504         * cp-support.c: Update.
4505         * cp-valprint.c: Update.
4506         * darwin-nat.c: Update.
4507         * disasm-selftests.c: Update.
4508         * dtrace-probe.c: Update.
4509         * dwarf-index-cache.c: Update.
4510         * dwarf-index-write.c: Update.
4511         * dwarf2-frame-tailcall.c: Update.
4512         * dwarf2-frame.c: Update.
4513         * dwarf2loc.c: Update.
4514         * dwarf2read.c: Update.
4515         * eval.c: Update.
4516         * event-loop.c: Update.
4517         * event-top.c: Update.
4518         * exec.c: Update.
4519         * f-valprint.c: Update.
4520         * fbsd-tdep.c: Update.
4521         * frame-unwind.c: Update.
4522         * frame.c: Update.
4523         * gdbtypes.c: Update.
4524         * gnu-v3-abi.c: Update.
4525         * guile/guile-internal.h: Update.
4526         * guile/scm-block.c: Update.
4527         * guile/scm-breakpoint.c: Update.
4528         * guile/scm-cmd.c: Update.
4529         * guile/scm-disasm.c: Update.
4530         * guile/scm-frame.c: Update.
4531         * guile/scm-lazy-string.c: Update.
4532         * guile/scm-math.c: Update.
4533         * guile/scm-param.c: Update.
4534         * guile/scm-ports.c: Update.
4535         * guile/scm-pretty-print.c: Update.
4536         * guile/scm-symbol.c: Update.
4537         * guile/scm-symtab.c: Update.
4538         * guile/scm-type.c: Update.
4539         * guile/scm-value.c: Update.
4540         * i386-linux-tdep.c: Update.
4541         * i386-tdep.c: Update.
4542         * inf-loop.c: Update.
4543         * infcall.c: Update.
4544         * infcmd.c: Update.
4545         * infrun.c: Update.
4546         * jit.c: Update.
4547         * language.c: Update.
4548         * linespec.c: Update.
4549         * linux-fork.c: Update.
4550         * linux-nat.c: Update.
4551         * linux-tdep.c: Update.
4552         * linux-thread-db.c: Update.
4553         * main.c: Update.
4554         * mi/mi-cmd-break.c: Update.
4555         * mi/mi-cmd-stack.c: Update.
4556         * mi/mi-interp.c: Update.
4557         * mi/mi-main.c: Update.
4558         * objc-lang.c: Update.
4559         * p-valprint.c: Update.
4560         * parse.c: Update.
4561         * ppc-linux-tdep.c: Update.
4562         * printcmd.c: Update.
4563         * python/py-arch.c: Update.
4564         * python/py-breakpoint.c: Update.
4565         * python/py-cmd.c: Update.
4566         * python/py-finishbreakpoint.c: Update.
4567         * python/py-frame.c: Update.
4568         * python/py-framefilter.c: Update.
4569         * python/py-gdb-readline.c: Update.
4570         * python/py-inferior.c: Update.
4571         * python/py-infthread.c: Update.
4572         * python/py-lazy-string.c: Update.
4573         * python/py-linetable.c: Update.
4574         * python/py-objfile.c: Update.
4575         * python/py-param.c: Update.
4576         * python/py-prettyprint.c: Update.
4577         * python/py-progspace.c: Update.
4578         * python/py-record-btrace.c: Update.
4579         * python/py-record.c: Update.
4580         * python/py-symbol.c: Update.
4581         * python/py-type.c: Update.
4582         * python/py-unwind.c: Update.
4583         * python/py-utils.c: Update.
4584         * python/py-value.c: Update.
4585         * python/python.c: Update.
4586         * record-btrace.c: Update.
4587         * record-full.c: Update.
4588         * remote-fileio.c: Update.
4589         * remote.c: Update.
4590         * riscv-tdep.c: Update.
4591         * rs6000-aix-tdep.c: Update.
4592         * rs6000-tdep.c: Update.
4593         * rust-exp.y: Update.
4594         * rust-lang.c: Update.
4595         * s390-tdep.c: Update.
4596         * selftest-arch.c: Update.
4597         * solib-dsbt.c: Update.
4598         * solib-frv.c: Update.
4599         * solib-spu.c: Update.
4600         * solib-svr4.c: Update.
4601         * solib.c: Update.
4602         * sparc64-linux-tdep.c: Update.
4603         * stack.c: Update.
4604         * symfile-mem.c: Update.
4605         * symmisc.c: Update.
4606         * target.c: Update.
4607         * thread.c: Update.
4608         * top.c: Update.
4609         * tracefile-tfile.c: Update.
4610         * tui/tui.c: Update.
4611         * typeprint.c: Update.
4612         * unittests/cli-utils-selftests.c: Update.
4613         * unittests/parse-connection-spec-selftests.c: Update.
4614         * valops.c: Update.
4615         * valprint.c: Update.
4616         * value.c: Update.
4617         * varobj.c: Update.
4618         * windows-nat.c: Update.
4619         * x86-linux-nat.c: Update.
4620         * xml-support.c: Update.
4621
4622 2019-04-08  Tom Tromey  <tom@tromey.com>
4623
4624         * xml-support.c: Use C++ exception handling.
4625         * x86-linux-nat.c: Use C++ exception handling.
4626         * windows-nat.c: Use C++ exception handling.
4627         * varobj.c: Use C++ exception handling.
4628         * value.c: Use C++ exception handling.
4629         * valprint.c: Use C++ exception handling.
4630         * valops.c: Use C++ exception handling.
4631         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4632         handling.
4633         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4634         * typeprint.c: Use C++ exception handling.
4635         * tui/tui.c: Use C++ exception handling.
4636         * tracefile-tfile.c: Use C++ exception handling.
4637         * top.c: Use C++ exception handling.
4638         * thread.c: Use C++ exception handling.
4639         * target.c: Use C++ exception handling.
4640         * symmisc.c: Use C++ exception handling.
4641         * symfile-mem.c: Use C++ exception handling.
4642         * stack.c: Use C++ exception handling.
4643         * sparc64-linux-tdep.c: Use C++ exception handling.
4644         * solib.c: Use C++ exception handling.
4645         * solib-svr4.c: Use C++ exception handling.
4646         * solib-spu.c: Use C++ exception handling.
4647         * solib-frv.c: Use C++ exception handling.
4648         * solib-dsbt.c: Use C++ exception handling.
4649         * selftest-arch.c: Use C++ exception handling.
4650         * s390-tdep.c: Use C++ exception handling.
4651         * rust-lang.c: Use C++ exception handling.
4652         * rust-exp.y: Use C++ exception handling.
4653         * rs6000-tdep.c: Use C++ exception handling.
4654         * rs6000-aix-tdep.c: Use C++ exception handling.
4655         * riscv-tdep.c: Use C++ exception handling.
4656         * remote.c: Use C++ exception handling.
4657         * remote-fileio.c: Use C++ exception handling.
4658         * record-full.c: Use C++ exception handling.
4659         * record-btrace.c: Use C++ exception handling.
4660         * python/python.c: Use C++ exception handling.
4661         * python/py-value.c: Use C++ exception handling.
4662         * python/py-utils.c: Use C++ exception handling.
4663         * python/py-unwind.c: Use C++ exception handling.
4664         * python/py-type.c: Use C++ exception handling.
4665         * python/py-symbol.c: Use C++ exception handling.
4666         * python/py-record.c: Use C++ exception handling.
4667         * python/py-record-btrace.c: Use C++ exception handling.
4668         * python/py-progspace.c: Use C++ exception handling.
4669         * python/py-prettyprint.c: Use C++ exception handling.
4670         * python/py-param.c: Use C++ exception handling.
4671         * python/py-objfile.c: Use C++ exception handling.
4672         * python/py-linetable.c: Use C++ exception handling.
4673         * python/py-lazy-string.c: Use C++ exception handling.
4674         * python/py-infthread.c: Use C++ exception handling.
4675         * python/py-inferior.c: Use C++ exception handling.
4676         * python/py-gdb-readline.c: Use C++ exception handling.
4677         * python/py-framefilter.c: Use C++ exception handling.
4678         * python/py-frame.c: Use C++ exception handling.
4679         * python/py-finishbreakpoint.c: Use C++ exception handling.
4680         * python/py-cmd.c: Use C++ exception handling.
4681         * python/py-breakpoint.c: Use C++ exception handling.
4682         * python/py-arch.c: Use C++ exception handling.
4683         * printcmd.c: Use C++ exception handling.
4684         * ppc-linux-tdep.c: Use C++ exception handling.
4685         * parse.c: Use C++ exception handling.
4686         * p-valprint.c: Use C++ exception handling.
4687         * objc-lang.c: Use C++ exception handling.
4688         * mi/mi-main.c: Use C++ exception handling.
4689         * mi/mi-interp.c: Use C++ exception handling.
4690         * mi/mi-cmd-stack.c: Use C++ exception handling.
4691         * mi/mi-cmd-break.c: Use C++ exception handling.
4692         * main.c: Use C++ exception handling.
4693         * linux-thread-db.c: Use C++ exception handling.
4694         * linux-tdep.c: Use C++ exception handling.
4695         * linux-nat.c: Use C++ exception handling.
4696         * linux-fork.c: Use C++ exception handling.
4697         * linespec.c: Use C++ exception handling.
4698         * language.c: Use C++ exception handling.
4699         * jit.c: Use C++ exception handling.
4700         * infrun.c: Use C++ exception handling.
4701         * infcmd.c: Use C++ exception handling.
4702         * infcall.c: Use C++ exception handling.
4703         * inf-loop.c: Use C++ exception handling.
4704         * i386-tdep.c: Use C++ exception handling.
4705         * i386-linux-tdep.c: Use C++ exception handling.
4706         * guile/scm-value.c: Use C++ exception handling.
4707         * guile/scm-type.c: Use C++ exception handling.
4708         * guile/scm-symtab.c: Use C++ exception handling.
4709         * guile/scm-symbol.c: Use C++ exception handling.
4710         * guile/scm-pretty-print.c: Use C++ exception handling.
4711         * guile/scm-ports.c: Use C++ exception handling.
4712         * guile/scm-param.c: Use C++ exception handling.
4713         * guile/scm-math.c: Use C++ exception handling.
4714         * guile/scm-lazy-string.c: Use C++ exception handling.
4715         * guile/scm-frame.c: Use C++ exception handling.
4716         * guile/scm-disasm.c: Use C++ exception handling.
4717         * guile/scm-cmd.c: Use C++ exception handling.
4718         * guile/scm-breakpoint.c: Use C++ exception handling.
4719         * guile/scm-block.c: Use C++ exception handling.
4720         * guile/guile-internal.h: Use C++ exception handling.
4721         * gnu-v3-abi.c: Use C++ exception handling.
4722         * gdbtypes.c: Use C++ exception handling.
4723         * frame.c: Use C++ exception handling.
4724         * frame-unwind.c: Use C++ exception handling.
4725         * fbsd-tdep.c: Use C++ exception handling.
4726         * f-valprint.c: Use C++ exception handling.
4727         * exec.c: Use C++ exception handling.
4728         * event-top.c: Use C++ exception handling.
4729         * event-loop.c: Use C++ exception handling.
4730         * eval.c: Use C++ exception handling.
4731         * dwarf2read.c: Use C++ exception handling.
4732         * dwarf2loc.c: Use C++ exception handling.
4733         * dwarf2-frame.c: Use C++ exception handling.
4734         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4735         * dwarf-index-write.c: Use C++ exception handling.
4736         * dwarf-index-cache.c: Use C++ exception handling.
4737         * dtrace-probe.c: Use C++ exception handling.
4738         * disasm-selftests.c: Use C++ exception handling.
4739         * darwin-nat.c: Use C++ exception handling.
4740         * cp-valprint.c: Use C++ exception handling.
4741         * cp-support.c: Use C++ exception handling.
4742         * cp-abi.c: Use C++ exception handling.
4743         * corelow.c: Use C++ exception handling.
4744         * completer.c: Use C++ exception handling.
4745         * compile/compile-object-run.c: Use C++ exception handling.
4746         * compile/compile-object-load.c: Use C++ exception handling.
4747         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4748         * compile/compile-c-symbols.c: Use C++ exception handling.
4749         * common/selftest.c: Use C++ exception handling.
4750         * common/new-op.c: Use C++ exception handling.
4751         * cli/cli-script.c: Use C++ exception handling.
4752         * cli/cli-interp.c: Use C++ exception handling.
4753         * cli/cli-cmds.c: Use C++ exception handling.
4754         * c-varobj.c: Use C++ exception handling.
4755         * btrace.c: Use C++ exception handling.
4756         * breakpoint.c: Use C++ exception handling.
4757         * break-catch-throw.c: Use C++ exception handling.
4758         * arch-utils.c: Use C++ exception handling.
4759         * amd64-tdep.c: Use C++ exception handling.
4760         * ada-valprint.c: Use C++ exception handling.
4761         * ada-typeprint.c: Use C++ exception handling.
4762         * ada-lang.c: Use C++ exception handling.
4763         * aarch64-tdep.c: Use C++ exception handling.
4764
4765 2019-04-08  Tom Tromey  <tom@tromey.com>
4766
4767         * xml-support.c (gdb_xml_parser::parse): Update.
4768         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4769         * value.c (show_convenience): Update.
4770         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4771         (test_parse_flags_qcs): Update.
4772         * thread.c (thr_try_catch_cmd): Update.
4773         * target.c (target_translate_tls_address): Update.
4774         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4775         (info_frame_command_core, frame_apply_command_count): Update.
4776         * rust-exp.y (rust_lex_exception_test): Update.
4777         * riscv-tdep.c (riscv_print_one_register_info): Update.
4778         * remote.c (remote_target::enable_btrace): Update.
4779         * record-btrace.c (record_btrace_enable_warn): Update.
4780         * python/py-utils.c (gdbpy_convert_exception): Update.
4781         * printcmd.c (do_one_display, print_variable_and_value): Update.
4782         * mi/mi-main.c (mi_print_exception): Update.
4783         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4784         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4785         * linux-nat.c (linux_nat_target::attach): Update.
4786         * linux-fork.c (class scoped_switch_fork_info): Update.
4787         * infrun.c (displaced_step_prepare): Update.
4788         * infcall.c (call_function_by_hand_dummy): Update.
4789         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4790         * gnu-v3-abi.c (print_one_vtable): Update.
4791         * frame.c (get_prev_frame_always): Update.
4792         * f-valprint.c (info_common_command_for_block): Update.
4793         * exec.c (try_open_exec_file): Update.
4794         * exceptions.c (print_exception, exception_print)
4795         (exception_fprintf, exception_print_same): Update.
4796         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4797         * dwarf-index-cache.c (index_cache::store)
4798         (index_cache::lookup_gdb_index): Update.
4799         * darwin-nat.c (maybe_cache_shell): Update.
4800         * cp-valprint.c (cp_print_value_fields): Update.
4801         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4802         (gcc_cplus_symbol_address): Update.
4803         * compile/compile-c-symbols.c (gcc_convert_symbol)
4804         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4805         * common/selftest.c: Update.
4806         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4807         a std::string.
4808         (exception_try_scope_entry, exception_try_scope_exit): Don't
4809         declare.
4810         (struct exception_try_scope): Remove.
4811         (TRY): Don't use exception_try_scope.
4812         (struct gdb_exception): Add constructor, operator=.
4813         <what>: New method.
4814         (struct gdb_exception_RETURN_MASK_ALL)
4815         (struct gdb_exception_RETURN_MASK_ERROR)
4816         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4817         (struct gdb_quit_bad_alloc): Update.
4818         * common/common-exceptions.c (exception_none): Change
4819         initializer.
4820         (struct catcher) <state, exception>: Initialize inline.
4821         <prev>: Remove member.
4822         (current_catcher): Remove.
4823         (catchers): New global.
4824         (exceptions_state_mc_init): Simplify.
4825         (catcher_pop): Remove.
4826         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4827         (try_scope_depth, exception_try_scope_entry)
4828         (exception_try_scope_exit): Remove.
4829         (throw_exception_sjlj): Update.
4830         (exception_messages, exception_messages_size): Remove.
4831         (throw_it): Simplify.
4832         (gdb_exception_sliced_copy): Remove.
4833         (throw_exception_cxx): Update.
4834         * cli/cli-script.c (script_from_file): Update.
4835         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4836         Update.
4837         * ada-valprint.c (ada_val_print): Update.
4838         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4839         (create_excep_cond_exprs): Update.
4840
4841 2019-04-08  Tom Tromey  <tom@tromey.com>
4842
4843         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4844         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4845         (TRY, CATCH, END_CATCH): Remove some definitions.
4846         * common/common-exceptions.c: Don't use GDB_XCPT.
4847         (catcher_list_size): Remove.
4848         (throw_exception, throw_it): Simplify.
4849
4850 2019-04-05  Tom Tromey  <tom@tromey.com>
4851
4852         Revert the header-sorting patch.
4853         * ft32-tdep.c: Revert.
4854         * frv-tdep.c: Revert.
4855         * frv-linux-tdep.c: Revert.
4856         * frame.c: Revert.
4857         * frame-unwind.c: Revert.
4858         * frame-base.c: Revert.
4859         * fork-child.c: Revert.
4860         * findvar.c: Revert.
4861         * findcmd.c: Revert.
4862         * filesystem.c: Revert.
4863         * filename-seen-cache.h: Revert.
4864         * filename-seen-cache.c: Revert.
4865         * fbsd-tdep.c: Revert.
4866         * fbsd-nat.h: Revert.
4867         * fbsd-nat.c: Revert.
4868         * f-valprint.c: Revert.
4869         * f-typeprint.c: Revert.
4870         * f-lang.c: Revert.
4871         * extension.h: Revert.
4872         * extension.c: Revert.
4873         * extension-priv.h: Revert.
4874         * expprint.c: Revert.
4875         * exec.h: Revert.
4876         * exec.c: Revert.
4877         * exceptions.c: Revert.
4878         * event-top.c: Revert.
4879         * event-loop.c: Revert.
4880         * eval.c: Revert.
4881         * elfread.c: Revert.
4882         * dwarf2read.h: Revert.
4883         * dwarf2read.c: Revert.
4884         * dwarf2loc.c: Revert.
4885         * dwarf2expr.h: Revert.
4886         * dwarf2expr.c: Revert.
4887         * dwarf2-frame.c: Revert.
4888         * dwarf2-frame-tailcall.c: Revert.
4889         * dwarf-index-write.h: Revert.
4890         * dwarf-index-write.c: Revert.
4891         * dwarf-index-common.c: Revert.
4892         * dwarf-index-cache.h: Revert.
4893         * dwarf-index-cache.c: Revert.
4894         * dummy-frame.c: Revert.
4895         * dtrace-probe.c: Revert.
4896         * disasm.h: Revert.
4897         * disasm.c: Revert.
4898         * disasm-selftests.c: Revert.
4899         * dictionary.c: Revert.
4900         * dicos-tdep.c: Revert.
4901         * demangle.c: Revert.
4902         * dcache.h: Revert.
4903         * dcache.c: Revert.
4904         * darwin-nat.h: Revert.
4905         * darwin-nat.c: Revert.
4906         * darwin-nat-info.c: Revert.
4907         * d-valprint.c: Revert.
4908         * d-namespace.c: Revert.
4909         * d-lang.c: Revert.
4910         * ctf.c: Revert.
4911         * csky-tdep.c: Revert.
4912         * csky-linux-tdep.c: Revert.
4913         * cris-tdep.c: Revert.
4914         * cris-linux-tdep.c: Revert.
4915         * cp-valprint.c: Revert.
4916         * cp-support.c: Revert.
4917         * cp-namespace.c: Revert.
4918         * cp-abi.c: Revert.
4919         * corelow.c: Revert.
4920         * corefile.c: Revert.
4921         * continuations.c: Revert.
4922         * completer.h: Revert.
4923         * completer.c: Revert.
4924         * complaints.c: Revert.
4925         * coffread.c: Revert.
4926         * coff-pe-read.c: Revert.
4927         * cli-out.h: Revert.
4928         * cli-out.c: Revert.
4929         * charset.c: Revert.
4930         * c-varobj.c: Revert.
4931         * c-valprint.c: Revert.
4932         * c-typeprint.c: Revert.
4933         * c-lang.c: Revert.
4934         * buildsym.c: Revert.
4935         * buildsym-legacy.c: Revert.
4936         * build-id.h: Revert.
4937         * build-id.c: Revert.
4938         * btrace.c: Revert.
4939         * bsd-uthread.c: Revert.
4940         * breakpoint.h: Revert.
4941         * breakpoint.c: Revert.
4942         * break-catch-throw.c: Revert.
4943         * break-catch-syscall.c: Revert.
4944         * break-catch-sig.c: Revert.
4945         * blockframe.c: Revert.
4946         * block.c: Revert.
4947         * bfin-tdep.c: Revert.
4948         * bfin-linux-tdep.c: Revert.
4949         * bfd-target.c: Revert.
4950         * bcache.c: Revert.
4951         * ax-general.c: Revert.
4952         * ax-gdb.h: Revert.
4953         * ax-gdb.c: Revert.
4954         * avr-tdep.c: Revert.
4955         * auxv.c: Revert.
4956         * auto-load.c: Revert.
4957         * arm-wince-tdep.c: Revert.
4958         * arm-tdep.c: Revert.
4959         * arm-symbian-tdep.c: Revert.
4960         * arm-pikeos-tdep.c: Revert.
4961         * arm-obsd-tdep.c: Revert.
4962         * arm-nbsd-tdep.c: Revert.
4963         * arm-nbsd-nat.c: Revert.
4964         * arm-linux-tdep.c: Revert.
4965         * arm-linux-nat.c: Revert.
4966         * arm-fbsd-tdep.c: Revert.
4967         * arm-fbsd-nat.c: Revert.
4968         * arm-bsd-tdep.c: Revert.
4969         * arch-utils.c: Revert.
4970         * arc-tdep.c: Revert.
4971         * arc-newlib-tdep.c: Revert.
4972         * annotate.h: Revert.
4973         * annotate.c: Revert.
4974         * amd64-windows-tdep.c: Revert.
4975         * amd64-windows-nat.c: Revert.
4976         * amd64-tdep.c: Revert.
4977         * amd64-sol2-tdep.c: Revert.
4978         * amd64-obsd-tdep.c: Revert.
4979         * amd64-obsd-nat.c: Revert.
4980         * amd64-nbsd-tdep.c: Revert.
4981         * amd64-nbsd-nat.c: Revert.
4982         * amd64-nat.c: Revert.
4983         * amd64-linux-tdep.c: Revert.
4984         * amd64-linux-nat.c: Revert.
4985         * amd64-fbsd-tdep.c: Revert.
4986         * amd64-fbsd-nat.c: Revert.
4987         * amd64-dicos-tdep.c: Revert.
4988         * amd64-darwin-tdep.c: Revert.
4989         * amd64-bsd-nat.c: Revert.
4990         * alpha-tdep.c: Revert.
4991         * alpha-obsd-tdep.c: Revert.
4992         * alpha-nbsd-tdep.c: Revert.
4993         * alpha-mdebug-tdep.c: Revert.
4994         * alpha-linux-tdep.c: Revert.
4995         * alpha-linux-nat.c: Revert.
4996         * alpha-bsd-tdep.c: Revert.
4997         * alpha-bsd-nat.c: Revert.
4998         * aix-thread.c: Revert.
4999         * agent.c: Revert.
5000         * addrmap.c: Revert.
5001         * ada-varobj.c: Revert.
5002         * ada-valprint.c: Revert.
5003         * ada-typeprint.c: Revert.
5004         * ada-tasks.c: Revert.
5005         * ada-lang.c: Revert.
5006         * aarch64-tdep.c: Revert.
5007         * aarch64-ravenscar-thread.c: Revert.
5008         * aarch64-newlib-tdep.c: Revert.
5009         * aarch64-linux-tdep.c: Revert.
5010         * aarch64-linux-nat.c: Revert.
5011         * aarch64-fbsd-tdep.c: Revert.
5012         * aarch64-fbsd-nat.c: Revert.
5013         * aarch32-linux-nat.c: Revert.
5014
5015 2019-04-05  Tom Tromey  <tom@tromey.com>
5016
5017         * ft32-tdep.c: Sort headers.
5018         * frv-tdep.c: Sort headers.
5019         * frv-linux-tdep.c: Sort headers.
5020         * frame.c: Sort headers.
5021         * frame-unwind.c: Sort headers.
5022         * frame-base.c: Sort headers.
5023         * fork-child.c: Sort headers.
5024         * findvar.c: Sort headers.
5025         * findcmd.c: Sort headers.
5026         * filesystem.c: Sort headers.
5027         * filename-seen-cache.h: Sort headers.
5028         * filename-seen-cache.c: Sort headers.
5029         * fbsd-tdep.c: Sort headers.
5030         * fbsd-nat.h: Sort headers.
5031         * fbsd-nat.c: Sort headers.
5032         * f-valprint.c: Sort headers.
5033         * f-typeprint.c: Sort headers.
5034         * f-lang.c: Sort headers.
5035         * extension.h: Sort headers.
5036         * extension.c: Sort headers.
5037         * extension-priv.h: Sort headers.
5038         * expprint.c: Sort headers.
5039         * exec.h: Sort headers.
5040         * exec.c: Sort headers.
5041         * exceptions.c: Sort headers.
5042         * event-top.c: Sort headers.
5043         * event-loop.c: Sort headers.
5044         * eval.c: Sort headers.
5045         * elfread.c: Sort headers.
5046         * dwarf2read.h: Sort headers.
5047         * dwarf2read.c: Sort headers.
5048         * dwarf2loc.c: Sort headers.
5049         * dwarf2expr.h: Sort headers.
5050         * dwarf2expr.c: Sort headers.
5051         * dwarf2-frame.c: Sort headers.
5052         * dwarf2-frame-tailcall.c: Sort headers.
5053         * dwarf-index-write.h: Sort headers.
5054         * dwarf-index-write.c: Sort headers.
5055         * dwarf-index-common.c: Sort headers.
5056         * dwarf-index-cache.h: Sort headers.
5057         * dwarf-index-cache.c: Sort headers.
5058         * dummy-frame.c: Sort headers.
5059         * dtrace-probe.c: Sort headers.
5060         * disasm.h: Sort headers.
5061         * disasm.c: Sort headers.
5062         * disasm-selftests.c: Sort headers.
5063         * dictionary.c: Sort headers.
5064         * dicos-tdep.c: Sort headers.
5065         * demangle.c: Sort headers.
5066         * dcache.h: Sort headers.
5067         * dcache.c: Sort headers.
5068         * darwin-nat.h: Sort headers.
5069         * darwin-nat.c: Sort headers.
5070         * darwin-nat-info.c: Sort headers.
5071         * d-valprint.c: Sort headers.
5072         * d-namespace.c: Sort headers.
5073         * d-lang.c: Sort headers.
5074         * ctf.c: Sort headers.
5075         * csky-tdep.c: Sort headers.
5076         * csky-linux-tdep.c: Sort headers.
5077         * cris-tdep.c: Sort headers.
5078         * cris-linux-tdep.c: Sort headers.
5079         * cp-valprint.c: Sort headers.
5080         * cp-support.c: Sort headers.
5081         * cp-namespace.c: Sort headers.
5082         * cp-abi.c: Sort headers.
5083         * corelow.c: Sort headers.
5084         * corefile.c: Sort headers.
5085         * continuations.c: Sort headers.
5086         * completer.h: Sort headers.
5087         * completer.c: Sort headers.
5088         * complaints.c: Sort headers.
5089         * coffread.c: Sort headers.
5090         * coff-pe-read.c: Sort headers.
5091         * cli-out.h: Sort headers.
5092         * cli-out.c: Sort headers.
5093         * charset.c: Sort headers.
5094         * c-varobj.c: Sort headers.
5095         * c-valprint.c: Sort headers.
5096         * c-typeprint.c: Sort headers.
5097         * c-lang.c: Sort headers.
5098         * buildsym.c: Sort headers.
5099         * buildsym-legacy.c: Sort headers.
5100         * build-id.h: Sort headers.
5101         * build-id.c: Sort headers.
5102         * btrace.c: Sort headers.
5103         * bsd-uthread.c: Sort headers.
5104         * breakpoint.h: Sort headers.
5105         * breakpoint.c: Sort headers.
5106         * break-catch-throw.c: Sort headers.
5107         * break-catch-syscall.c: Sort headers.
5108         * break-catch-sig.c: Sort headers.
5109         * blockframe.c: Sort headers.
5110         * block.c: Sort headers.
5111         * bfin-tdep.c: Sort headers.
5112         * bfin-linux-tdep.c: Sort headers.
5113         * bfd-target.c: Sort headers.
5114         * bcache.c: Sort headers.
5115         * ax-general.c: Sort headers.
5116         * ax-gdb.h: Sort headers.
5117         * ax-gdb.c: Sort headers.
5118         * avr-tdep.c: Sort headers.
5119         * auxv.c: Sort headers.
5120         * auto-load.c: Sort headers.
5121         * arm-wince-tdep.c: Sort headers.
5122         * arm-tdep.c: Sort headers.
5123         * arm-symbian-tdep.c: Sort headers.
5124         * arm-pikeos-tdep.c: Sort headers.
5125         * arm-obsd-tdep.c: Sort headers.
5126         * arm-nbsd-tdep.c: Sort headers.
5127         * arm-nbsd-nat.c: Sort headers.
5128         * arm-linux-tdep.c: Sort headers.
5129         * arm-linux-nat.c: Sort headers.
5130         * arm-fbsd-tdep.c: Sort headers.
5131         * arm-fbsd-nat.c: Sort headers.
5132         * arm-bsd-tdep.c: Sort headers.
5133         * arch-utils.c: Sort headers.
5134         * arc-tdep.c: Sort headers.
5135         * arc-newlib-tdep.c: Sort headers.
5136         * annotate.h: Sort headers.
5137         * annotate.c: Sort headers.
5138         * amd64-windows-tdep.c: Sort headers.
5139         * amd64-windows-nat.c: Sort headers.
5140         * amd64-tdep.c: Sort headers.
5141         * amd64-sol2-tdep.c: Sort headers.
5142         * amd64-obsd-tdep.c: Sort headers.
5143         * amd64-obsd-nat.c: Sort headers.
5144         * amd64-nbsd-tdep.c: Sort headers.
5145         * amd64-nbsd-nat.c: Sort headers.
5146         * amd64-nat.c: Sort headers.
5147         * amd64-linux-tdep.c: Sort headers.
5148         * amd64-linux-nat.c: Sort headers.
5149         * amd64-fbsd-tdep.c: Sort headers.
5150         * amd64-fbsd-nat.c: Sort headers.
5151         * amd64-dicos-tdep.c: Sort headers.
5152         * amd64-darwin-tdep.c: Sort headers.
5153         * amd64-bsd-nat.c: Sort headers.
5154         * alpha-tdep.c: Sort headers.
5155         * alpha-obsd-tdep.c: Sort headers.
5156         * alpha-nbsd-tdep.c: Sort headers.
5157         * alpha-mdebug-tdep.c: Sort headers.
5158         * alpha-linux-tdep.c: Sort headers.
5159         * alpha-linux-nat.c: Sort headers.
5160         * alpha-bsd-tdep.c: Sort headers.
5161         * alpha-bsd-nat.c: Sort headers.
5162         * aix-thread.c: Sort headers.
5163         * agent.c: Sort headers.
5164         * addrmap.c: Sort headers.
5165         * ada-varobj.c: Sort headers.
5166         * ada-valprint.c: Sort headers.
5167         * ada-typeprint.c: Sort headers.
5168         * ada-tasks.c: Sort headers.
5169         * ada-lang.c: Sort headers.
5170         * aarch64-tdep.c: Sort headers.
5171         * aarch64-ravenscar-thread.c: Sort headers.
5172         * aarch64-newlib-tdep.c: Sort headers.
5173         * aarch64-linux-tdep.c: Sort headers.
5174         * aarch64-linux-nat.c: Sort headers.
5175         * aarch64-fbsd-tdep.c: Sort headers.
5176         * aarch64-fbsd-nat.c: Sort headers.
5177         * aarch32-linux-nat.c: Sort headers.
5178
5179 2019-04-04  Tom Tromey  <tom@tromey.com>
5180
5181         * varobj.c (varobj_create): Update.
5182         * rust-exp.y (struct rust_parser) <update_innermost_block,
5183         lookup_symbol>: New methods.
5184         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5185         Rename.
5186         (rust_parser::rust_lookup_type)
5187         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5188         * printcmd.c (display_command, do_one_display): Update.
5189         * parser-defs.h (struct parser_state) <parser_state>: Add
5190         "tracker" parameter.
5191         (block_tracker): New member.
5192         (class innermost_block_tracker) <innermost_block_tracker>: Add
5193         "types" parameter.
5194         <reset>: Remove method.
5195         (innermost_block): Don't declare.
5196         (null_post_parser): Update.
5197         * parse.c (innermost_block): Remove global.
5198         (write_dollar_variable): Update.
5199         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5200         Remove "tracker_types" parameter.
5201         (parse_expression): Add "tracker" parameter.
5202         (parse_expression_for_completion): Update.
5203         (null_post_parser): Add "tracker" parameter.
5204         * p-exp.y: Update rules.
5205         * m2-exp.y: Update rules.
5206         * language.h (struct language_defn) <la_post_parser>: Add
5207         "tracker" parameter.
5208         * go-exp.y: Update rules.
5209         * f-exp.y: Update rules.
5210         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5211         parameter.
5212         * d-exp.y: Update rules.
5213         * c-exp.y: Update rules.
5214         * breakpoint.c (set_breakpoint_condition): Create an
5215         innermost_block_tracker.
5216         (watch_command_1): Likewise.
5217         * ada-lang.c (resolve): Add "tracker" parameter.
5218         (resolve_subexp): Likewise.
5219         * ada-exp.y (write_var_from_sym): Update.
5220
5221 2019-04-04  Tom Tromey  <tom@tromey.com>
5222
5223         * type-stack.h: New file.
5224         * type-stack.c: New file.
5225         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5226         type-stack.h.
5227         (insert_into_type_stack, insert_type, push_type, push_type_int)
5228         (insert_type_address_space, pop_type, pop_type_int)
5229         (pop_typelist, pop_type_stack, append_type_stack)
5230         (push_type_stack, get_type_stack, push_typelist)
5231         (follow_type_instance_flags, follow_types): Don't declare.
5232         * parse.c (type_stack): Remove global.
5233         (parse_exp_in_context): Update.
5234         (insert_into_type_stack, insert_type, push_type, push_type_int)
5235         (insert_type_address_space, pop_type, pop_type_int)
5236         (pop_typelist, pop_type_stack, append_type_stack)
5237         (push_type_stack, get_type_stack, push_typelist)
5238         (follow_type_instance_flags, follow_types): Remove (moved to
5239         type-stack.c).
5240         * f-exp.y (type_stack): New global.
5241         Update rules.
5242         (push_kind_type, f_parse): Update.
5243         * d-exp.y (type_stack): New global.
5244         Update rules.
5245         (d_parse): Update.
5246         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5247         Update rules.
5248         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5249         (HFILES_NO_SRCDIR): Add type-stack.h.
5250
5251 2019-04-04  Tom Tromey  <tom@tromey.com>
5252
5253         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5254         (rust_parser::convert_ast_to_expression, rust_parse)
5255         (rust_lex_test_completion, rust_lex_tests): Update.
5256         * parser-defs.h (struct expr_completion_state): New.
5257         (struct parser_state) <parser_state>: Add completion parameter.
5258         <mark_struct_expression, mark_completion_tag>: New methods.
5259         <parse_completion, m_completion_state>: New members.
5260         (prefixify_expression, null_post_parser): Update.
5261         (mark_struct_expression, mark_completion_tag): Don't declare.
5262         * parse.c (parse_completion, expout_last_struct)
5263         (expout_tag_completion_type, expout_completion_name): Remove
5264         globals.
5265         (parser_state::mark_struct_expression)
5266         (parser_state::mark_completion_tag): Now methods.
5267         (prefixify_expression): Add last_struct parameter.
5268         (prefixify_subexp): Likewise.
5269         (parse_exp_1): Update.
5270         (parse_exp_in_context): Add cstate parameter.  Update.
5271         (parse_expression_for_completion): Create an
5272         expr_completion_state.
5273         (null_post_parser): Add "completion" parameter.
5274         * p-exp.y: Update rules.
5275         (yylex): Update.
5276         * language.h (struct language_defn) <la_post_parser>: Add
5277         "completing" parameter.
5278         * go-exp.y: Update rules.
5279         (lex_one_token): Update.
5280         * expression.h (parse_completion): Don't declare.
5281         * d-exp.y: Update rules.
5282         (lex_one_token): Update rules.
5283         * c-exp.y: Update rules.
5284         (lex_one_token): Update.
5285         * ada-lang.c (resolve): Add "parse_completion" parameter.
5286         (resolve_subexp): Likewise.
5287         (ada_resolve_function): Likewise.
5288
5289 2019-04-04  Tom Tromey  <tom@tromey.com>
5290
5291         * parser-defs.h (struct parser_state) <start_arglist,
5292         end_arglist>: New methods.
5293         <arglist_len, m_funcall_chain>: New members.
5294         (arglist_len, start_arglist, end_arglist): Don't declare.
5295         * parse.c (arglist_len, funcall_chain): Remove global.
5296         (start_arglist, end_arglist): Remove functions.
5297         (parse_exp_in_context): Update.
5298         * p-exp.y: Update rules.
5299         * m2-exp.y: Update rules.
5300         * go-exp.y: Update rules.
5301         * f-exp.y: Update rules.
5302         * d-exp.y: Update rules.
5303         * c-exp.y: Update rules.
5304
5305 2019-04-04  Tom Tromey  <tom@tromey.com>
5306
5307         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5308         lex_operator, push_back>: New methods.
5309         Update all rules.
5310         (rust_parser::lex_hex, lex_escape): Rename and update.
5311         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5312         (rust_parser::lex_operator): Rename and update.
5313         (rust_parser::lex_number, rustyylex, rustyyerror)
5314         (rust_lex_test_init, rust_lex_test_sequence)
5315         (rust_lex_test_push_back, rust_lex_tests): Update.
5316         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5317         parameter.
5318         <lexptr, prev_lexptr>: New members.
5319         (lexptr, prev_lexptr): Don't declare.
5320         * parse.c (lexptr, prev_lexptr): Remove globals.
5321         (parse_exp_in_context): Update.
5322         * p-exp.y (yylex, yyerror): Update.
5323         * m2-exp.y (parse_number, yylex, yyerror): Update.
5324         * go-exp.y (lex_one_token, yyerror): Update.
5325         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5326         * d-exp.y (lex_one_token, yyerror): Update.
5327         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5328         (lex_one_token, yyerror): Update.
5329         * ada-lex.l (YY_INPUT): Update.
5330         (rewind_to_char): Update.
5331         * ada-exp.y (yyerror): Update.
5332
5333 2019-04-04  Tom Tromey  <tom@tromey.com>
5334
5335         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5336         * parser-defs.h (struct parser_state) <parser_state>: Add new
5337         parameter.
5338         <comma_terminates>: New member.
5339         (comma_terminates): Don't declare global.
5340         * parse.c (comma_terminates): Remove global.
5341         (parse_exp_in_context): Update.
5342         * p-exp.y (yylex): Update.
5343         * m2-exp.y (yylex): Update.
5344         * go-exp.y (lex_one_token): Update.
5345         * f-exp.y (yylex): Update.
5346         * d-exp.y (lex_one_token): Update.
5347         * c-exp.y (lex_one_token): Update.
5348         * ada-lex.l: Update.
5349
5350 2019-04-04  Tom Tromey  <tom@tromey.com>
5351
5352         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5353         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5354         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5355         * parser-defs.h (paren_depth): Don't declare.
5356         * parse.c (paren_depth): Remove global.
5357         (parse_exp_in_context): Update.
5358         * p-exp.y (paren_depth): New global.
5359         (pascal_parse): Initialize it.
5360         * m2-exp.y (paren_depth): New global.
5361         (m2_parse): Initialize it.
5362         * go-exp.y (paren_depth): New global.
5363         (go_parse): Initialize it.
5364         * f-exp.y (paren_depth): New global.
5365         (f_parse): Initialize it.
5366         * d-exp.y (paren_depth): New global.
5367         (d_parse): Initialize it.
5368         * c-exp.y (paren_depth): New global.
5369         (c_parse): Initialize it.
5370         * ada-lex.l (paren_depth): New global.
5371         (lexer_init): Initialize it.
5372
5373 2019-04-04  Tom Tromey  <tom@tromey.com>
5374
5375         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5376         (rust_parser::convert_ast_to_type)
5377         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5378         * parser-defs.h (struct parser_state) <parser_state>: Add
5379         parameters.  Initialize new members.
5380         <expression_context_block, expression_context_pc>: New members.
5381         * parse.c (expression_context_block, expression_context_pc):
5382         Remove globals.
5383         (parse_exp_in_context): Update.
5384         * p-exp.y: Update all rules.
5385         (yylex): Update.
5386         * m2-exp.y: Update all rules.
5387         (yylex): Update.
5388         * go-exp.y (yylex): Update.
5389         * f-exp.y (yylex): Update.
5390         * d-exp.y: Update all rules.
5391         (yylex): Update.
5392         * c-exp.y: Update all rules.
5393         (lex_one_token, classify_name, yylex, c_parse): Update.
5394         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5395
5396 2019-04-04  Tom Tromey  <tom@tromey.com>
5397
5398         * gdbarch.h, gdbarch.c: Rebuild.
5399         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5400         * stap-probe.h:
5401         (struct stap_parse_info): Replace "parser_state" with
5402         "expr_builder".
5403         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5404         (parser_state): New class.
5405         * parse.c (expr_builder): Rename.
5406         (expr_builder::release): Rename.
5407         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5408         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5409         (write_exp_elt_longcst, write_exp_elt_floatcst)
5410         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5411         (write_exp_string_vector, write_exp_bitstring)
5412         (write_exp_msymbol, mark_struct_expression)
5413         (write_dollar_variable)
5414         (insert_type_address_space, increase_expout_size): Replace
5415         "parser_state" with "expr_builder".
5416         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5417         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5418         "parser_state" with "expr_builder".
5419
5420 2019-04-04  Tom Tromey  <tom@tromey.com>
5421
5422         * rust-exp.y: Replace "parse_language" with method call.
5423         * p-exp.y:
5424         (yylex): Replace "parse_language" with method call.
5425         * m2-exp.y:
5426         (yylex): Replace "parse_language" with method call.
5427         * go-exp.y (classify_name): Replace "parse_language" with method
5428         call.
5429         * f-exp.y (yylex): Replace "parse_language" with method call.
5430         * d-exp.y (lex_one_token): Replace "parse_language" with method
5431         call.
5432         * c-exp.y:
5433         (lex_one_token, classify_name, yylex): Replace "parse_language"
5434         with method call.
5435         * ada-exp.y (find_primitive_type, type_char)
5436         (type_system_address): Replace "parse_language" with method call.
5437
5438 2019-04-04  Tom Tromey  <tom@tromey.com>
5439
5440         * rust-exp.y: Replace "parse_gdbarch" with method call.
5441         * parse.c (write_dollar_variable, insert_type_address_space):
5442         Replace "parse_gdbarch" with method call.
5443         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5444         call.
5445         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5446         call.
5447         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5448         "parse_gdbarch" with method call.
5449         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5450         with method call.
5451         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5452         "parse_gdbarch" with method call.
5453         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5454         "parse_gdbarch" with method call.
5455         * c-exp.y (parse_type, parse_number, classify_name): Replace
5456         "parse_gdbarch" with method call.
5457         * ada-lex.l: Replace "parse_gdbarch" with method call.
5458         * ada-exp.y (parse_type, find_primitive_type, type_char)
5459         (type_system_address): Replace "parse_gdbarch" with method call.
5460
5461 2019-04-04  Tom Tromey  <tom@tromey.com>
5462
5463         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5464         * stap-probe.c (stap_parse_argument): Update.
5465         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5466         initial_size parameter.
5467         * rust-exp.y (rust_lex_tests): Update.
5468         * parse.c (parser_state): Update.
5469         (parse_exp_in_context): Update.
5470         * parser-defs.h (struct parser_state) <parser_state>: Remove
5471         "initial_size" parameter.
5472
5473 2019-04-04  Tom Tromey  <tom@tromey.com>
5474
5475         * parser-defs.h (increase_expout_size): Don't declare.
5476         * parse.c (increase_expout_size): Now static.
5477
5478 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5479
5480         * gnu-nat.c (gnu_nat_target::wait): Fix
5481         target_waitstatus_to_string call.
5482
5483 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * eval.c (evaluate_subexp_standard): Handle internal functions
5486         during Fortran function call handling.
5487
5488 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5489
5490         * NEWS: Mention new internal functions.
5491         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5492         (read_base_type): Use dwarf2_init_complex_target_type.
5493         * value.c (creal_internal_fn): New function.
5494         (cimag_internal_fn): New function.
5495         (_initialize_values): Register new internal functions.
5496
5497 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5498
5499         * infrun.c (stop_all_threads): If debug_infrun, always
5500         trace the wait status after wait_one, using
5501         target_waitstatus_to_string and target_pid_to_str.
5502         (handle_inferior_event): Replace various trace of
5503         wait status kind by a single trace.
5504         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5505         wait status kind image by target_waitstatus_to_string.
5506         * target/waitstatus.c (target_waitstatus_to_string): Fix
5507         obsolete comment.
5508
5509 2019-04-01  Tom Tromey  <tromey@adacore.com>
5510
5511         PR symtab/23331:
5512         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5513
5514 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5515             Pedro Alves  <palves@redhat.com>
5516
5517         * top.c (quit_force): Call 'finalize_values'.
5518         * value.c (finalize_values): New function.
5519         * value.h (finalize_values): Declare.
5520
5521 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5522
5523         * NEWS: Announce $_gdb_major and $_gdb_minor.
5524
5525         * top.c (init_gdb_version_vars): New function.
5526         (gdb_init): Call init_gdb_version_vars.
5527
5528 2019-03-29  Tom Tromey  <tromey@adacore.com>
5529
5530         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5531         help text.  Remove dead code.
5532
5533 2019-03-29  Keith Seitz  <keiths@redhat.com>
5534
5535         From Siddhesh Poyarekar:
5536         * f-lang.h (f77_get_upperbound): Return LONGEST.
5537         (f77_get_lowerbound): Likewise.
5538         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5539         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5540         print them.
5541         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5542         plongest to format print it.
5543         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5544         (f77_get_upperbound): Likewise.
5545         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5546         LOWER_BOUND to LONGEST.
5547         (f77_create_arrayprint_offset_tbl): Likewise.
5548
5549 2019-03-29  Keith Seitz  <keiths@redhat.com>
5550
5551         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5552         %s/pulongest for TYPE_LENGTH instead of %d in format
5553         strings.
5554         * ada-typerint.c (ada_print_type): Likewise.
5555         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5556         * compile/compile-c-support.c (generate_register_struct): Likewise.
5557         * gdbtypes.c (recursive_dump_type): Likewise.
5558         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5559         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5560         instead of %d in format strings.
5561         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5562         to std::min to ULONGEST.
5563         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5564         instead of %d in format strings.
5565         * tracepoint.c (info_scope_command): Likewise.
5566         * typeprint.c (print_offset_data::update)
5567         (print_offset_data::finish): Likewise.
5568         * xtensa-tdep.c (xtensa_store_return_value)
5569         (xtensa_push_dummy_call): Likewise.
5570
5571 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5572
5573         * windows-nat.c (display_selector): Fixed format specifications
5574         for 64-bit Cygwin.
5575
5576 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5577
5578         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5579
5580 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5581
5582         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5583         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5584         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5585         (nios2_linux_init_abi): Install it.
5586
5587 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5588
5589         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5590
5591 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5592
5593         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5594
5595 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5596             Tom Tromey  <tromey@adacore.com>
5597
5598         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5599
5600 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5601
5602         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5603         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5604         method to compute the bounds of range types. Also print "[evaluated]"
5605         if the bounds' values come from a dynamic evaluation.
5606
5607 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5610         whitespace when pretty printing is on.
5611
5612 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5613
5614         * ppc-linux-nat.c: Add include.
5615
5616 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * NEWS: Mention AArch64 Pointer Authentication.
5619
5620 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5621
5622         * arm-linux-nat.c: Add include.
5623
5624 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5625
5626         * source-cache.c (source_cache::get_source_lines): Re-read
5627         fullname after calling open_source_file.
5628
5629 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5630
5631         * NEWS: Mention TLS support for FreeBSD.
5632
5633 2019-03-25  Tom Tromey  <tromey@adacore.com>
5634
5635         * minsyms.c (BUNCH_SIZE): Update comment.
5636         (~minimal_symbol_reader): Remove old comment.
5637         (compact_minimal_symbols): Update comment.
5638         (minimal_symbol_reader::install): Remove old comment.  Update
5639         other comments.
5640
5641 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5642
5643         * s390-linux-nat.c: Add include.
5644
5645 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5646
5647         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5648         Call linux_get_hwcap.
5649         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5650         Likewise.
5651         (aarch64_linux_get_hwcap): Remove function.
5652         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5653         declaration.
5654         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5655         linux_get_hwcap.
5656         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5657         * linux-tdep.c (linux_get_hwcap): Add function.
5658         (linux_get_hwcap2): Likewise.
5659         * linux-tdep.h (linux_get_hwcap): Add declaration.
5660         (linux_get_hwcap2): Likewise.
5661         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5662         (ppc_linux_get_hwcap2): Likewise.
5663         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5664         linux_get_hwcap.
5665         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5666         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5667         (ppc_linux_nat_target::read_description): Likewise.
5668         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5669         * s390-linux-nat.c: Likewise.
5670         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5671
5672 2019-03-24  Tom Tromey  <tom@tromey.com>
5673
5674         * ada-lang.c (standard_lookup): Simplify initialization.
5675         (ada_lookup_symbol_nonlocal): Simplify return.
5676         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5677         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5678         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5679         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5680         initialization.
5681         * solib.c (solib_global_lookup): Simplify.
5682         * symtab.c (null_block_symbol): Remove.
5683         (symbol_cache_lookup): Simplify returns.
5684         (lookup_language_this): Simplify returns.
5685         (lookup_symbol_aux): Simplify return.
5686         (lookup_local_symbol): Simplify returns.
5687         (lookup_global_symbol_from_objfile): Simplify return.
5688         (lookup_symbol_in_objfile_symtabs)
5689         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5690         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5691         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5692         * cp-namespace.c (cp_lookup_bare_symbol)
5693         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5694         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5695         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5696         (cp_lookup_symbol_via_imports): Simplify initialization.
5697         (find_symbol_in_baseclass): Likewise.
5698         * symtab.h (null_block_symbol): Remove.
5699         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5700         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5701         (d_lookup_symbol_module): Likewise.
5702         (find_symbol_in_baseclass): Simplify initialization.
5703
5704 2019-03-24  Tom Tromey  <tom@tromey.com>
5705
5706         * expression.h: Don't include symtab.h.
5707         (struct block): Forward declare.
5708
5709 2019-03-24  Tom Tromey  <tom@tromey.com>
5710
5711         * c-exp.y (typebase): Remove casts.
5712         * gdbtypes.c (lookup_unsigned_typename, )
5713         (lookup_signed_typename): Remove cast.
5714         * eval.c (parse_to_comma_and_eval): Remove cast.
5715         * parse.c (write_dollar_variable): Remove cast.
5716         * block.h (struct block) <superblock>: Now const.
5717         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5718         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5719         (map_block): Make "block" const.
5720         * symfile.h (struct quick_symbol_functions)
5721         <map_matching_symbols>: Constify block argument to "callback".
5722         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5723         const.
5724         (find_pc_sect_compunit_symtab): Make "b" const.
5725         (find_symbol_at_address): Likewise.
5726         (search_symbols): Likewise.
5727         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5728         (dw2_debug_names_lookup_symbol): Likewise.
5729         (dw2_map_matching_symbols): Update.
5730         * p-valprint.c (pascal_val_print): Remove "block".
5731         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5732         (aux_add_nonlocal_symbols): Make "block" const.
5733         (resolve_subexp): Remove cast.
5734         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5735         const.
5736         (iterate_over_file_blocks): Likewise.
5737         * f-exp.y (%union) <bval>: Remove.
5738         * coffread.c (patch_opaque_types): Make "b" const.
5739         * spu-tdep.c (spu_catch_start): Make "block" const.
5740         * c-valprint.c (print_unpacked_pointer): Remove "block".
5741         * symmisc.c (dump_symtab_1): Make "b" const.
5742         (block_depth): Make "block" const.
5743         * d-exp.y (%union) <bval>: Remove.
5744         * cp-support.h (cp_lookup_rtti_type): Update.
5745         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5746         * psymtab.c (psym_lookup_symbol): Make "block" const.
5747         (maintenance_check_psymtabs): Make "b" const.
5748         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5749         (enumerate_locals, enumerate_args): Update.
5750         * python/py-symtab.c (stpy_global_block): Make "block" const.
5751         (stpy_static_block): Likewise.
5752         * inline-frame.c (block_starting_point_at): Make "new_block"
5753         const.
5754         * block.c (find_block_in_blockvector): Make return type const.
5755         (blockvector_for_pc_sect): Make "b" const.
5756         (find_block_in_blockvector): Make "b" const.
5757
5758 2019-03-23  Tom Tromey  <tom@tromey.com>
5759
5760         * varobj.c (varobj_create): Update.
5761         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5762         * printcmd.c (display_command, do_one_display): Don't reset
5763         innermost_block.
5764         * parser-defs.h (enum innermost_block_tracker_type): Move to
5765         expression.h.
5766         (innermost_block): Update comment.
5767         * parse.c (parse_exp_1): Add tracker_types parameter.
5768         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5769         tracker_types parameter.  Reset innermost_block.
5770         (parse_exp_in_context): Remove.
5771         (parse_expression_for_completion): Update.
5772         * objfiles.c (~objfile): Don't reset expression_context_block or
5773         innermost_block.
5774         * expression.h (enum innermost_block_tracker_type): Move from
5775         parser-defs.h.
5776         (parse_exp_1): Add tracker_types parameter.
5777         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5778         reset innermost_block.
5779
5780 2019-03-23  Tom Tromey  <tom@tromey.com>
5781
5782         * objfiles.h: Include bcache.h.
5783
5784 2019-03-23  Tom Tromey  <tom@tromey.com>
5785
5786         * linespec.c (get_current_search_block): Use
5787         scoped_restore_current_language.
5788         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5789
5790 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5791             Jiong Wang  <jiong.wang@arm.com>
5792
5793         * aarch64-linux-tdep.c
5794         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5795         section.
5796         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5797
5798 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5799             Jiong Wang  <jiong.wang@arm.com>
5800
5801         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5802         instructions.
5803         (aarch64_analyze_prologue_test): Add PACIASP test.
5804         (aarch64_prologue_prev_register): Unmask PC value.
5805
5806 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5807             Jiong Wang  <jiong.wang@arm.com>
5808
5809         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5810         (aarch64_dwarf2_prev_register): Unmask PC value.
5811         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5812         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5813         DW_CFA_AARCH64_negate_ra_state.
5814         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5815
5816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5817             Jiong Wang  <jiong.wang@arm.com>
5818
5819         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5820         registers.
5821         (aarch64_pseudo_register_name): Likewise.
5822         (aarch64_pseudo_register_type): Likewise.
5823         (aarch64_pseudo_register_reggroup_p): Likewise.
5824         (aarch64_gdbarch_init): Add pauth registers.
5825         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5826         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5827         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5828         (struct gdbarch_tdep): Add regnum for ra_state.
5829
5830 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5831             Jiong Wang  <jiong.wang@arm.com>
5832
5833         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5834
5835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5836             Jiong Wang  <jiong.wang@arm.com>
5837
5838         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5839         function.
5840         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5841         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5842         (aarch64_gdbarch_init): Add puth registers.
5843         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5844         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5845         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5846
5847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5848             Jiong Wang  <jiong.wang@arm.com>
5849
5850         * aarch64-linux-nat.c
5851         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5852         * aarch64-linux-tdep.c
5853         (aarch64_linux_core_read_description): Likewise.
5854         (aarch64_linux_get_hwcap): New function.
5855         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5856         (aarch64_linux_get_hwcap): New declaration.
5857
5858 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5859             Jiong Wang  <jiong.wang@arm.com>
5860
5861         * aarch64-linux-nat.c
5862         (aarch64_linux_nat_target::read_description): Add pauth param.
5863         * aarch64-linux-tdep.c
5864         (aarch64_linux_core_read_description): Likewise.
5865         * aarch64-tdep.c (struct target_desc): Add in pauth.
5866         (aarch64_read_description): Add pauth param.
5867         (aarch64_gdbarch_init): Likewise.
5868         * aarch64-tdep.h (aarch64_read_description): Likewise.
5869         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5870         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5871         * features/Makefile: Add new files.
5872         * features/aarch64-pauth.c: New file.
5873         * features/aarch64-pauth.xml: New file.
5874
5875 2019-03-20  Tom Tromey  <tromey@adacore.com>
5876
5877         * infrun.c (handle_inferior_event): Rename from
5878         handle_inferior_event_1.  Create a scoped_value_mark.
5879         (handle_inferior_event): Remove.
5880
5881 2019-03-19  Tom Tromey  <tromey@adacore.com>
5882
5883         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5884         * infrun.h (print_stop_event): Add "displays" parameter.
5885         * infrun.c (print_stop_event): Add "displays" parameter.
5886
5887 2019-03-19  Pedro Alves  <palves@redhat.com>
5888
5889         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5890         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5891         to -1.  Fix TABs vs spaces.
5892         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5893         * tui/tui-out.h (tui_ui_out) Add intro comments.
5894         <m_line, m_start_of_line>: In-class initialize, and add describing
5895         comment.
5896
5897 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5898
5899         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5900         variable names.
5901         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5902
5903 2019-03-18  Pedro Alves  <palves@redhat.com>
5904             Eli Zaretskii <eliz@gnu.org>
5905
5906         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5907         m_line and m_start_of_line.
5908
5909 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5910
5911         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5912         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5913         it returns a newline.  This fixes a regression in TU mode, whereby
5914         the next line is output on the same screen line as the user input.
5915
5916 2019-03-18  Tom Tromey  <tromey@adacore.com>
5917
5918         * minsyms.c (minimal_symbol_reader::install): Remove call to
5919         obstack_blank.
5920
5921 2019-03-18  Pedro Alves  <palves@redhat.com>
5922
5923         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5924         New globals.
5925         (apply_style): New, factored out from ...
5926         (apply_ansi_escape): ... this.  Handle reverse video mode.
5927         (tui_set_reverse_mode): New function.
5928         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5929         * tui/tui-winsource.c (tui_show_source_line): Use
5930         tui_set_reverse_mode instead of setting A_STANDOUT.
5931         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5932         New setter methods.
5933
5934 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5935
5936         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5937         Handle tabs.
5938
5939 2019-03-18  Tom Tromey  <tromey@adacore.com>
5940
5941         * ada-lang.c (empty_array): Add "high" parameter.
5942         (ada_evaluate_subexp): Update.
5943
5944 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5945
5946         * unittests/string_view-selftests.c: Define
5947         _initialize_string_view_selftests unconditionally.
5948
5949 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5950
5951         PR gdb/24350
5952         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5953
5954 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5955
5956         PR gdb/24351
5957         * windows-nat.c (display_selector): Fix format specifiers.
5958
5959 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5960
5961         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5962         tui_refill_source_window instead of tui_refresh_win, to update the
5963         current execution line.  This fixes redisplay of the current line
5964         when stepping through the code with "next" or "step".
5965
5966 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5967
5968         * source-cache.c (source_cache::get_source_lines): Call
5969         find_source_lines to initialize s->nlines.  This fixes vertical
5970         scrolling of TUI source window when the DOWN arrow is pressed.
5971
5972 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5975         linux-thread-db.c (_initialize_thread_db): Likewise.
5976
5977 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5978
5979         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5980         wclrtoeol in tui_show_source_line".  This reverts changes made in
5981         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5982
5983 2019-03-15  Tom Tromey  <tom@tromey.com>
5984
5985         * symtab.h (struct minimal_symbol): Derive from
5986         general_symbol_info.
5987         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5988         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5989         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5990         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5991         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5992         (MSYMBOL_SEARCH_NAME): Update.
5993         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5994         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5995         * minsyms.c (minimal_symbol_reader::record_full): Update.
5996
5997 2019-03-15  Tom Tromey  <tom@tromey.com>
5998
5999         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6000
6001 2019-03-15  Tom Tromey  <tom@tromey.com>
6002
6003         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6004         unique_xmalloc_ptr.
6005         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6006         Update.
6007         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6008         (build_minimal_symbol_hash_tables)
6009         (minimal_symbol_reader::install): Update.
6010
6011 2019-03-15  Tom Tromey  <tom@tromey.com>
6012
6013         * symtab.c (create_demangled_names_hash): Update.
6014         (symbol_set_names): Update.
6015         * objfiles.h (struct objfile_per_bfd_storage)
6016         <demangled_names_hash>: Now an htab_up.
6017         * objfiles.c (objfile_per_bfd_storage): Simplify.
6018
6019 2019-03-15  Tom Tromey  <tom@tromey.com>
6020
6021         * objfiles.h (struct objfile_per_bfd_storage): Declare
6022         destructor.
6023         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6024         New.
6025         (get_objfile_bfd_data): Use new.  Don't initialize
6026         language_of_main.
6027         (free_objfile_per_bfd_storage): Remove.
6028         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6029
6030 2019-03-15  Tom Tromey  <tom@tromey.com>
6031
6032         * symfile.c (reread_symbols): Update.
6033         * objfiles.c (objfile::objfile): Update.
6034         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6035         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6036         comment.
6037         (minimal_symbol_reader::install): Update.
6038         (terminate_minimal_symbol_table): Remove.
6039         * jit.c (jit_object_close_impl): Update.
6040
6041 2019-03-15  Tom Tromey  <tom@tromey.com>
6042
6043         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6044         initializations.
6045
6046 2019-03-15  Tom Tromey  <tom@tromey.com>
6047
6048         * objfiles.h (struct objfile_per_bfd_storage)
6049         <demangled_hash_languages>: Now a bitset.
6050         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6051         (lookup_minimal_symbol): Update.
6052
6053 2019-03-15  Tom Tromey  <tom@tromey.com>
6054
6055         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6056         Don't return the symbol.
6057         * coffread.c (record_minimal_symbol): Use record_full.
6058
6059 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6060
6061         The MS-Windows port of ncurses fails to switch to a color pair if
6062         one or both of the colors are the implicit default colors.  This
6063         change records the default colors when TUI is initialized, and
6064         then specifies them explicitly when a color pair uses the default
6065         colors.  This allows color styling in TUI mode on MS-Windows.
6066
6067         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6068         ncurses_norm_attr.
6069         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6070         colors in ncurses_norm_attr.
6071         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6072         "none", replace it with the default color recorded in
6073         ncurses_norm_attr.
6074
6075 2019-03-14  Tom Tromey  <tromey@adacore.com>
6076
6077         * source-cache.h (class source_cache) <get_source_lines>: Return
6078         std::string.
6079         * source-cache.c (source_cache::extract_lines): Handle case where
6080         first_pos==npos.  Return std::string.
6081         (source_cache::get_source_lines): Update.
6082
6083 2019-03-14  Tom Tromey  <tromey@adacore.com>
6084
6085         * NEWS: Add item for "style sources" commands.
6086         * source-cache.c (source_cache::get_source_lines): Check
6087         source_styling.
6088         * cli/cli-style.c (source_styling): New global.
6089         (_initialize_cli_style): Add "style sources" commands.
6090         (show_style_sources): New function.
6091         * cli/cli-style.h (source_styling): Declare.
6092
6093 2019-03-14  Pedro Alves  <palves@redhat.com>
6094             Tom Tromey  <tromey@adacore.com>
6095
6096         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6097         * tui/tui-winsource.c (tui_refill_source_window): New function,
6098         from...
6099         (tui_horizontal_source_scroll): ... here.  Move some logic.
6100         * cli/cli-style.c (set_style_enabled): Notify new observable.
6101         * tui/tui-hooks.c (tui_redisplay_source): New function.
6102         (tui_attach_detach_observers): Attach or detach
6103         tui_redisplay_source.
6104         * observable.h (source_styling_changed): New observable.
6105         * observable.c: Define source_styling_changed observable.
6106
6107 2019-03-13  Tom Tromey  <tromey@adacore.com>
6108
6109         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6110         (i386_gnu_nat_target::store_registers): Update.
6111         * target-debug.h (target_debug_print_std_string): New macro.
6112         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6113         * windows-tdep.c (display_one_tib): Update.
6114         * tui/tui-stack.c (tui_make_status_line): Update.
6115         * top.c (print_inferior_quit_action): Update.
6116         * thread.c (thr_try_catch_cmd): Update.
6117         (add_thread_with_info): Update.
6118         (thread_target_id_str): Update.
6119         (thr_try_catch_cmd): Update.
6120         (thread_command): Update.
6121         (thread_find_command): Update.
6122         * record-btrace.c (record_btrace_target::info_record)
6123         (record_btrace_resume_thread, record_btrace_target::resume)
6124         (record_btrace_cancel_resume, record_btrace_step_thread)
6125         (record_btrace_target::wait, record_btrace_target::wait)
6126         (record_btrace_target::wait, record_btrace_target::stop): Update.
6127         * progspace.c (print_program_space): Update.
6128         * process-stratum-target.c
6129         (process_stratum_target::thread_address_space): Update.
6130         * linux-fork.c (linux_fork_mourn_inferior)
6131         (detach_checkpoint_command, info_checkpoints_command)
6132         (linux_fork_context): Update.
6133         (linux_fork_detach): Update.
6134         (class scoped_switch_fork_info): Update.
6135         (delete_checkpoint_command): Update.
6136         * infrun.c (follow_fork_inferior): Update.
6137         (follow_fork_inferior): Update.
6138         (proceed_after_vfork_done): Update.
6139         (handle_vfork_child_exec_or_exit): Update.
6140         (follow_exec): Update.
6141         (displaced_step_prepare_throw): Update.
6142         (displaced_step_restore): Update.
6143         (start_step_over): Update.
6144         (resume_1): Update.
6145         (clear_proceed_status_thread): Update.
6146         (proceed): Update.
6147         (print_target_wait_results): Update.
6148         (do_target_wait): Update.
6149         (context_switch): Update.
6150         (stop_all_threads): Update.
6151         (restart_threads): Update.
6152         (finish_step_over): Update.
6153         (handle_signal_stop): Update.
6154         (switch_back_to_stepped_thread): Update.
6155         (keep_going_pass_signal): Update.
6156         (print_exited_reason): Update.
6157         (normal_stop): Update.
6158         * inferior.c (inferior_pid_to_str): Change return type.
6159         (print_selected_inferior): Update.
6160         (add_inferior): Update.
6161         (detach_inferior): Update.
6162         * dummy-frame.c (fprint_dummy_frames): Update.
6163         * dcache.c (dcache_info_1): Update.
6164         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6165         (btrace_fetch, btrace_clear): Update.
6166         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6167         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6168         type.
6169         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6170         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6171         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6172         * gdbarch.c, gdbarch.h: Rebuild.
6173         * gdbarch.sh (core_pid_to_str): Change return type.
6174         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6175         return type.
6176         (windows_nat_target::pid_to_str): Change return type.
6177         (windows_delete_thread): Update.
6178         (windows_nat_target::attach): Update.
6179         (windows_nat_target::files_info): Update.
6180         * target-delegates.c: Rebuild.
6181         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6182         return type.
6183         (sol_thread_target::pid_to_str): Change return type.
6184         * remote.c (class remote_target) <pid_to_str>: Change return
6185         type.
6186         (remote_target::pid_to_str): Change return type.
6187         (extended_remote_target::attach, remote_target::remote_stop_ns)
6188         (remote_target::remote_notif_remove_queued_reply)
6189         (remote_target::push_stop_reply, remote_target::disable_btrace):
6190         Update.
6191         (extended_remote_target::attach): Update.
6192         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6193         type.
6194         (gdbsim_target::pid_to_str): Change return type.
6195         * ravenscar-thread.c (struct ravenscar_thread_target)
6196         <pid_to_str>: Change return type.
6197         (ravenscar_thread_target::pid_to_str): Change return type.
6198         * procfs.c (class procfs_target) <pid_to_str>: Change return
6199         type.
6200         (procfs_target::pid_to_str): Change return type.
6201         (procfs_target::attach): Update.
6202         (procfs_target::detach): Update.
6203         (procfs_target::fetch_registers): Update.
6204         (procfs_target::store_registers): Update.
6205         (procfs_target::wait): Update.
6206         (procfs_target::files_info): Update.
6207         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6208         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6209         return type.
6210         (nto_procfs_target::pid_to_str): Change return type.
6211         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6212         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6213         return type.
6214         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6215         (exit_lwp): Update.
6216         (attach_proc_task_lwp_callback, get_detach_signal)
6217         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6218         (linux_nat_target::resume, wait_lwp, stop_callback)
6219         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6220         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6221         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6222         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6223         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6224         type.
6225         (inf_ptrace_target::attach): Update.
6226         (inf_ptrace_target::files_info): Update.
6227         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6228         type.
6229         (go32_nat_target::pid_to_str): Change return type.
6230         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6231         (gnu_nat_target::wait): Update.
6232         (gnu_nat_target::wait): Update.
6233         (gnu_nat_target::resume): Update.
6234         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6235         (fbsd_nat_target::wait): Update.
6236         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6237         type.
6238         (darwin_nat_target::attach): Update.
6239         * corelow.c (class core_target) <pid_to_str>: Change return type.
6240         (core_target::pid_to_str): Change return type.
6241         * target.c (normal_pid_to_str): Change return type.
6242         (default_pid_to_str): Likewise.
6243         (target_pid_to_str): Change return type.
6244         (target_translate_tls_address): Update.
6245         (target_announce_detach): Update.
6246         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6247         return type.
6248         (bsd_uthread_target::pid_to_str): Change return type.
6249         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6250         type.
6251         (bsd_kvm_target::pid_to_str): Change return type.
6252         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6253         return type.
6254         (aix_thread_target::pid_to_str): Change return type.
6255         * target.h (struct target_ops) <pid_to_str>: Change return type.
6256         (target_pid_to_str, normal_pid_to_str): Likewise.
6257         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6258         type.
6259         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6260         type.
6261         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6262         return type.
6263         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6264         type.
6265         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6266         type.
6267         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6268         return type.
6269
6270 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6271
6272         * NEWS: Mention that the new default MI version is 3.  Mention
6273         changes to the output of commands and events that deal with
6274         multi-location breakpoints.
6275         * breakpoint.c: Include "mi/mi-out.h".
6276         (print_one_breakpoint): Change output syntax if using MI version
6277         >= 3.
6278         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6279         New.
6280         (mi_multi_location_breakpoint_output_fixed): New.
6281         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6282         (mi_cmd_fix_multi_location_breakpoint_output): New.
6283         (mi_multi_location_breakpoint_output_fixed): New.
6284         * mi/mi-cmds.c (mi_cmds): Register command
6285         -fix-multi-location-breakpoint-output.
6286         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6287         interpreter "mi".
6288
6289 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6290
6291         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6292         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6293         instantiate mi_ui_out based on interpreter name.
6294         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6295         * mi/mi-main.c (mi_load_progress): Likewise.
6296
6297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6298
6299         * NEWS: Combine separate "New targets" sections for 8.3.
6300
6301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6302
6303         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6304         (ppcfbsd_init_abi): Install gdbarch
6305         "fetch_tls_load_module_address" and "get_thread_local_address"
6306         methods.
6307
6308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6309
6310         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6311         (riscv_fbsd_init_abi): Install gdbarch
6312         "fetch_tls_load_module_address" and "get_thread_local_address"
6313         methods.
6314
6315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6316
6317         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6318         (i386fbsd_init_abi): Install gdbarch
6319         "fetch_tls_load_module_address" and "get_thread_local_address"
6320         methods.
6321
6322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6323
6324         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6325         (amd64fbsd_init_abi): Install gdbarch
6326         "fetch_tls_load_module_address" and "get_thread_local_address"
6327         methods.
6328
6329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6330
6331         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6332         (struct fbsd_pspace_data): New type.
6333         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6334         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6335         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6336         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6337         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6338
6339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6340
6341         * gdbtypes.c (lookup_struct_elt): New function.
6342         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6343         * gdbtypes.h (struct struct_elt): New type.
6344         (lookup_struct_elt): New prototype.
6345
6346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6347
6348         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6349         remove disabled code block.
6350
6351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6352
6353         * gdbarch.sh (get_thread_local_address): New method.
6354         * gdbarch.h, gdbarch.c: Regenerate.
6355         * target.c (target_translate_tls_address): Use
6356         gdbarch_get_thread_local_address if present instead of
6357         target::get_thread_local_address.
6358
6359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6360
6361         * target.h (target::get_thread_local_address): Update comment.
6362
6363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6364
6365         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6366         objfile->separate_debug_objfile_backlink if not NULL.
6367
6368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6369
6370         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6371         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6372         (amd64bsd_store_inferior_registers): Likewise.
6373         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6374         Enable segment base registers.
6375         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6376         PT_GETFSBASE and PT_GETGSBASE.
6377         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6378         PT_SETGSBASE.
6379         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6380         segment base registers.
6381         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6382
6383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6384
6385         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6386         Update calls to i386_target_description to add 'segments'
6387         parameter.
6388         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6389         add segment base registers.
6390         * arch/i386.c (i386_create_target_description): Add 'segments'
6391         parameter to enable segment base registers.
6392         * arch/i386.h (i386_create_target_description): Likewise.
6393         * features/i386/32bit-segments.xml: New file.
6394         * features/i386/32bit-segments.c: Generate.
6395         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6396         call to i386_target_description to add 'segments' parameter.
6397         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6398         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6399         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6400         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6401         if feature is present.
6402         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6403         Add 'segments' parameter to call to i386_target_description.
6404         (i386_target_description): Add 'segments' parameter to enable
6405         segment base registers.
6406         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6407         to call to i386_target_description.
6408         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6409         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6410         Define I386_NUM_REGS.
6411         (i386_target_description): Add 'segments' parameter to enable
6412         segment base registers.
6413
6414 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6415
6416         PR/24325
6417         * source-cache.c: #undef open and close, to avoid unresolved
6418         externals during linking.
6419
6420 2019-03-12  Tom Tromey  <tromey@adacore.com>
6421
6422         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6423         const.  Add initializers.
6424         (_initialize_remote): Don't initialize ptid globals.
6425
6426 2019-03-12  Pedro Alves  <palves@redhat.com>
6427
6428         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6429
6430 2019-03-12  Pedro Alves  <palves@redhat.com>
6431
6432         * cp-name-parser.y (main): Remove unused 'len' variable.
6433
6434 2019-03-12  Tom Tromey  <tromey@adacore.com>
6435
6436         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6437         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6438
6439 2019-03-12  Tom Tromey  <tromey@adacore.com>
6440
6441         * linux-nat.c (iterate_over_lwps): Update.
6442         (stop_callback): Remove parameter.
6443         (stop_wait_callback, detach_callback, resume_set_callback)
6444         (select_singlestep_lwp_callback, set_ignore_sigint)
6445         (status_callback, resumed_callback, resume_clear_callback)
6446         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6447         data parameter.
6448         (linux_nat_target::detach, linux_nat_target::resume)
6449         (linux_stop_and_wait_all_lwps, select_event_lwp)
6450         (linux_nat_filter_event, linux_nat_wait_1)
6451         (linux_nat_target::kill, linux_nat_target::stop)
6452         (linux_nat_target::stop): Update.
6453         (linux_nat_resume_callback): Change type.
6454         (resume_stopped_resumed_lwps, count_events_callback)
6455         (select_event_lwp_callback): Likewise.
6456         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6457         * arm-linux-nat.c (struct update_registers_data): Remove.
6458         (update_registers_callback): Change type.
6459         (arm_linux_insert_hw_breakpoint1): Update.
6460         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6461         parameter.
6462         (x86_linux_dr_set_addr): Update.
6463         (x86_linux_dr_set_control): Update.
6464         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6465         (iterate_over_lwps): Use gdb::function_view.
6466         * nat/aarch64-linux-hw-point.c (struct
6467         aarch64_dr_update_callback_param): Remove.
6468         (debug_reg_change_callback): Change type.
6469         (aarch64_notify_debug_reg_change): Update.
6470         * s390-linux-nat.c (s390_refresh_per_info): Update.
6471
6472 2019-03-11  Tom Tromey  <tromey@adacore.com>
6473
6474         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6475         redundant assignment to "this_cu".
6476
6477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6478
6479         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6480
6481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6482
6483         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6484         from...
6485         (rank_one_type): ... this.
6486
6487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6488
6489         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6490         from...
6491         (rank_one_type): ... this.
6492
6493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6494
6495         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6496         from...
6497         (rank_one_type): ... this.
6498
6499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6500
6501         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6502         from...
6503         (rank_one_type): ... this.
6504
6505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6506
6507         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6508         from...
6509         (rank_one_type): ... this.
6510
6511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6512
6513         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6514         from...
6515         (rank_one_type): ... this.
6516
6517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6518
6519         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6520         from...
6521         (rank_one_type): ... this.
6522
6523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6524
6525         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6526         from...
6527         (rank_one_type): ... this.
6528
6529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6530
6531         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6532         from...
6533         (rank_one_type): ... this.
6534
6535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6536
6537         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6538         from...
6539         (rank_one_type): ... this.
6540
6541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6542
6543         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6544         from...
6545         (rank_one_type): ... this.
6546
6547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6548
6549         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6550         from...
6551         (rank_one_type): ... this.
6552
6553 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6554
6555         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6556         inferior-events' shows the example events.
6557
6558 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6559
6560         Support styling on native MS-Windows console
6561
6562         PR/24315
6563         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6564         on MS-Windows if $TERM is not defined.
6565
6566         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6567
6568         * posix-hdep.c (gdb_console_fputs):
6569         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6570         functions.
6571         * ui-file.h (gdb_console_fputs): Add prototype.
6572
6573         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6574         back to fputs only if the former returns zero.
6575
6576 2019-03-07  Tom Tromey  <tom@tromey.com>
6577
6578         * symmisc.c (print_symbol_bcache_statistics): Update.
6579         (print_objfile_statistics): Update.
6580         * symfile.c (allocate_symtab): Update.
6581         * stabsread.c: Don't include bcache.h.
6582         * psymtab.h (struct psymbol_bcache): Don't declare.
6583         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6584         (psymbol_bcache_init, psymbol_bcache_free)
6585         (psymbol_bcache_get_bcache): Don't declare.
6586         * psymtab.c (struct psymbol_bcache): Remove.
6587         (psymtab_storage::psymtab_storage): Update.
6588         (psymtab_storage::~psymtab_storage): Update.
6589         (psymbol_bcache_init, psymbol_bcache_free)
6590         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6591         (add_psymbol_to_bcache): Update.
6592         (allocate_psymtab): Update.
6593         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6594         macro_cache>: No longer pointers.
6595         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6596         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6597         * macrotab.c (macro_bcache): Update.
6598         * macroexp.c: Don't include bcache.h.
6599         * gdbtypes.c (check_types_worklist): Update.
6600         (types_deeply_equal): Remove TRY/CATCH.  Update.
6601         * elfread.c (elf_symtab_read): Update.
6602         * dwarf2read.c: Don't include bcache.h.
6603         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6604         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6605         (print_bcache_statistics, bcache_memory_used): Don't declare.
6606         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6607         methods.  Rename all data members.
6608         * bcache.c (struct bcache): Move to bcache.h.
6609         (bcache::expand_hash_table): Rename from expand_hash_table.
6610         (bcache): Remove.
6611         (bcache::insert): Rename from bcache_full.
6612         (bcache::compare): Rename from bcache_compare.
6613         (bcache_xmalloc): Remove.
6614         (bcache::~bcache): Rename from bcache_xfree.
6615         (bcache::print_statistics): Rename from print_bcache_statistics.
6616         (bcache::memory_used): Rename from bcache_memory_used.
6617
6618 2019-03-07  Pedro Alves  <palves@redhat.com>
6619
6620         * infrun.c (normal_stop): Also check for
6621         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6622
6623 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * f-lang.c (value_from_host_double): Moved to...
6626         * value.c (value_from_host_double): ...here.
6627         * value.h (value_from_host_double): Declare.
6628         * guile/scm-math.c (vlscm_convert_typed_number): Use
6629         value_from_host_double.
6630         (vlscm_convert_number): Likewise.
6631         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6632         * python/py-value.c (convert_value_from_python): Likewise.
6633
6634 2019-03-06  Tom Tromey  <tom@tromey.com>
6635
6636         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6637
6638 2019-03-06  Tom Tromey  <tom@tromey.com>
6639
6640         * utils.h (free_current_contents): Don't declare.
6641         * utils.c (free_current_contents): Remove.
6642
6643 2019-03-06  Tom Tromey  <tom@tromey.com>
6644
6645         * top.c (quit_force): Update.
6646         * main.c (captured_command_loop): Update.
6647         * common/new-op.c (operator new): Update.
6648         * common/common-exceptions.c (struct catcher)
6649         <save_cleanup_chain>: Remove member.
6650         (exceptions_state_mc_init): Update.
6651         (exception_try_scope_entry): Return nullptr.
6652         (exception_try_scope_exit, exception_rethrow)
6653         (throw_exception_sjlj, throw_exception_cxx): Update.
6654         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6655         (all_cleanups, do_cleanups, discard_cleanups)
6656         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6657         (restore_cleanups, restore_final_cleanups): Don't declare.
6658         (do_final_cleanups): Remove parameter.
6659         * common/cleanups.c (cleanup_chain, make_cleanup)
6660         (make_cleanup_dtor, all_cleanups, do_cleanups)
6661         (discard_my_cleanups, discard_cleanups)
6662         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6663         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6664         (null_cleanup): Remove.
6665         (do_final_cleanups): Remove parameter.
6666
6667 2019-03-06  Tom Tromey  <tom@tromey.com>
6668
6669         * remote.c (remote_target::remote_parse_stop_reply): Use
6670         unique_xmalloc_ptr.
6671
6672 2019-03-06  Tom Tromey  <tom@tromey.com>
6673
6674         * stabsread.c (struct stabs_field_info): Rename from field_info.
6675         <list, fnlist>: Add initializers.
6676         <obstack>: New member.
6677         (read_member_functions, read_struct_fields, read_baseclasses):
6678         Allocate on obstack.  Don't use cleanups.
6679         (read_one_struct_field, read_member_functions, read_struct_fields)
6680         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6681         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6682         (read_struct_type): Update.
6683
6684 2019-03-06  Tom Tromey  <tom@tromey.com>
6685
6686         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6687         * common/filestuff.h (make_cleanup_close): Don't declare.
6688         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6689         Remove.
6690
6691 2019-03-06  Tom Tromey  <tom@tromey.com>
6692
6693         * solib-aix.c: Use make_scope_exit.
6694
6695 2019-03-06  Tom Tromey  <tom@tromey.com>
6696
6697         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6698         Use make_scope_exit.
6699
6700 2019-03-06  Tom Tromey  <tom@tromey.com>
6701
6702         * solib-svr4.c (disable_probes_interface): Remove parameter.
6703         (svr4_handle_solib_event): Use make_scope_exit.
6704
6705 2019-03-06  Tom Tromey  <tom@tromey.com>
6706
6707         * remote.c (struct stop_reply_deleter): Remove.
6708         (stop_reply_up): Update.
6709         (struct stop_reply): Derive from notif_event.  Don't typedef.
6710         <regcache>: Now a std::vector.
6711         (stop_reply_xfree): Remove.
6712         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6713         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6714         (remote_target::discard_pending_stop_replies): Use delete.
6715         (remote_target::remote_parse_stop_reply): Update.
6716         (remote_target::process_stop_reply): Update.
6717         * remote-notif.h (struct notif_event): Add virtual destructor.
6718         Remove "dtr" member.
6719         (struct notif_client) <alloc_event>: Return a unique_ptr.
6720         (notif_event_xfree): Don't declare.
6721         (notif_event_up): New typedef.
6722         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6723         (notif_event_xfree, do_notif_event_xfree): Remove.
6724         (remote_notif_state_xfree): Update.
6725
6726 2019-03-06  Tom Tromey  <tom@tromey.com>
6727
6728         * infrun.c (displaced_step_clear_cleanup): Now a
6729         forward_scope_exit type.
6730         (displaced_step_prepare_throw): Update.
6731         (displaced_step_fixup): Update.
6732
6733 2019-03-06  Tom Tromey  <tom@tromey.com>
6734
6735         * inferior.h (class inferior): Update comment.
6736         * gdbthread.h (class thread_info): Update comment.
6737
6738 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6739             Tom Tromey  <tom@tromey.com>
6740
6741         * stabsread.h (struct stab_section_list): Remove.
6742         (coffstab_build_psymtabs): Update.
6743         * dbxread.c (symbuf_sections): Now a std::vector.
6744         (sect_idx): New global.
6745         (fill_symbuf): Update.
6746         (coffstab_build_psymtabs): Change type of stabsects parameter.
6747         Update.
6748         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6749         std::vector.
6750         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6751         (coff_locate_sections): Update.
6752         (coff_symfile_read): Remove cleanups.  Update.
6753         (init_stringtab): Add storage parameter.
6754         (free_stringtab, free_stringtab_cleanup): Remove.
6755         (init_lineno): Add storage parameter.
6756         (free_linetab, free_linetab_cleanup): Remove.
6757
6758 2019-03-06  Pedro Alves  <palves@redhat.com>
6759
6760         * linux-fork.c (fork_info::clobber_regs): Delete.
6761         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6762         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6763         comment.  Adjust.
6764         (scoped_switch_fork_info::scoped_switch_fork_info)
6765         (checkpoint_command, linux_fork_context): Adjust
6766         fork_save_infrun_state calls.
6767
6768 2019-03-06  Pedro Alves  <palves@redhat.com>
6769
6770         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6771         (inf_has_multiple_threads): Return 'bool' and rewrite using
6772         inferior_info::threads().
6773
6774 2019-03-06  Pedro Alves  <palves@redhat.com>
6775
6776         * linux-fork.c: Include <list>.
6777         (fork_list): Now a std::list instance.
6778         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6779         (forks_exist_p, find_last_fork): Adjust.
6780         (new_fork): Delete.
6781         (one_fork_p): New.
6782         (add_fork): Adjust.
6783         (free_fork): Delete, folded into fork_info::~fork_info().
6784         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6785         Adjust.
6786         (init_fork_list): Delete.
6787         (linux_fork_killall, linux_fork_mourn_inferior)
6788         (linux_fork_detach, info_checkpoints_command): Adjust.
6789         (_initialize_linux_fork): No longer call init_fork_list.
6790
6791 2019-03-06  Pedro Alves  <palves@redhat.com>
6792
6793         * linux-fork.c (new_fork): New, split out of ...
6794         (add_fork): ... this.  Return void.  Move "first fork" special
6795         case from here, to ...
6796         (checkpoint_command): ... here.
6797         * linux-linux.h (add_fork): Return void.
6798
6799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6802
6803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6804             Chris January  <chris.january@arm.com>
6805             David Lecomber  <david.lecomber@arm.com>
6806
6807         * f-exp.y: New token, UNOP_INTRINSIC.
6808         (exp): New pattern using UNOP_INTRINSIC token.
6809         (f77_keywords): Add 'abs' keyword.
6810         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6811         (value_from_host_double): New function.
6812         (evaluate_subexp_f): Support UNOP_ABS.
6813
6814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6815
6816         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6817         types.
6818
6819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6820
6821         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6822         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6823         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6824
6825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6828
6829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6830             Chris January  <chris.january@arm.com>
6831
6832         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6833         * f-exp.y: Define 'KIND' token.
6834         (exp): New pattern for KIND expressions.
6835         (ptype): Handle types with a kind extension.
6836         (direct_abs_decl): Extend to spot kind extensions.
6837         (f77_keywords): Add 'kind' to the list.
6838         (push_kind_type): New function.
6839         (convert_to_kind_type): New function.
6840         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6841         * parse.c (operator_length_standard): Likewise.
6842         * parser-defs.h (enum type_pieces): Add tp_kind.
6843         * std-operator.def: Add UNOP_KIND.
6844
6845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * f-exp.y (f_parse): Set yydebug.
6848
6849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6850
6851         * f-lang.c (evaluate_subexp_f): New function.
6852         (exp_descriptor_f): New global.
6853         (f_language_defn): Use exp_descriptor_f instead of
6854         exp_descriptor_standard.
6855
6856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6857
6858         * f-exp.y (struct token): Add comments.
6859         (dot_ops): Remove uppercase versions and the end marker.
6860         (f77_keywords): Likewise.
6861         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6862         entries in the dot_ops array are case insensitive, and use
6863         strncasecmp to compare strings.  Also some whitespace cleanup in
6864         this area.  Similar for the f77_keywords array, except entries in
6865         this list might be case sensitive.
6866
6867 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6868
6869         * f-exp.y (struct f77_boolean_val): Add comments.
6870         (boolean_values): Remove uppercase versions, and end marker.
6871         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6872         and use strncasecmp to achieve case insensitivity.  Additionally,
6873         perform whitespace cleanup around this code.
6874
6875 2019-03-06  Tom Tromey  <tromey@adacore.com>
6876
6877         * remote-sim.c (gdbsim_target_open): Use result of
6878         gdb_argv::release.
6879
6880 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6881         Dirk Schubert  <dirk.schubert@arm.com>
6882         Chris January  <chris.january@arm.com>
6883
6884         * eval.c (evaluate_subexp_standard): Call Fortran argument
6885         wrapping logic.
6886         * f-lang.c (struct value): A value which can be passed into a
6887         Fortran function call.
6888         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6889         where appropriate.
6890         (struct type): Value ready for a Fortran function call.
6891         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6892         is needed.
6893         * f-lang.h (fortran_argument_convert): Declaration.
6894         (fortran_preserve_arg_pointer): Declaration.
6895         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6896
6897 2019-03-05  Tom Tromey  <tromey@adacore.com>
6898
6899         * python/py-prettyprint.c (print_string_repr): Remove #if.
6900         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6901
6902 2019-03-05  Tom Tromey  <tromey@adacore.com>
6903
6904         * target.c (the_dummy_target): Move later.  Change type to
6905         "dummy_target".
6906         (initialize_targets): Don't initialize the_dummy_target.
6907
6908 2019-03-05  Tom Tromey  <tromey@adacore.com>
6909
6910         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6911         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6912
6913 2019-03-05  Tom Tromey  <tromey@adacore.com>
6914
6915         * windows-nat.c (windows_nat_target::attach)
6916         (windows_nat_target::detach): Don't call gdb_flush.
6917         * valprint.c (generic_val_print, val_print, val_print_string):
6918         Don't call gdb_flush.
6919         * utils.c (defaulted_query): Don't call gdb_flush.
6920         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6921         * target.c (target_announce_detach): Don't call gdb_flush.
6922         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6923         * remote.c (extended_remote_target::attach): Don't call
6924         gdb_flush.
6925         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6926         * printcmd.c (do_examine): Don't call gdb_flush.
6927         (info_display_command): Don't call gdb_flush.
6928         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6929         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6930         * memattr.c (info_mem_command): Don't call gdb_flush.
6931         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6932         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6933         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6934         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6935         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6936         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6937         (gnu_nat_target::detach): Don't call gdb_flush.
6938         * f-valprint.c (f_val_print): Don't call gdb_flush.
6939         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6940         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6941         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6942         gdb_flush.
6943         * c-valprint.c (c_val_print): Don't call gdb_flush.
6944         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6945
6946 2019-03-05  Tom Tromey  <tromey@adacore.com>
6947
6948         * varobj.c (update_dynamic_varobj_children): Update.
6949         (install_default_visualizer): Use reset, not release.
6950         * value.c (set_internalvar): Update.
6951         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6952         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6953         ATTRIBUTE_UNUSED_RESULT.
6954
6955 2019-03-05  Tom Tromey  <tromey@adacore.com>
6956
6957         * remote.c (class scoped_remote_fd) <release>: Add
6958         ATTRIBUTE_UNUSED_RESULT.
6959
6960 2019-03-05  Tom Tromey  <tromey@adacore.com>
6961
6962         * macroexp.c (struct macro_buffer) <release>: Add
6963         ATTRIBUTE_UNUSED_RESULT.
6964
6965 2019-03-05  Tom Tromey  <tromey@adacore.com>
6966
6967         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6968         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6969         ATTRIBUTE_UNUSED_RESULT.
6970
6971 2019-03-05  Tom Tromey  <tromey@adacore.com>
6972
6973         * common/scoped_fd.h (class scoped_fd) <release>: Add
6974         ATTRIBUTE_UNUSED_RESULT.
6975
6976 2019-03-05  Tom Tromey  <tromey@adacore.com>
6977
6978         * parser-defs.h (struct parser_state) <release>: Add
6979         ATTRIBUTE_UNUSED_RESULT.
6980
6981 2019-03-05  Tom Tromey  <tromey@adacore.com>
6982
6983         * utils.h (class gdb_argv) <release>: Add
6984         ATTRIBUTE_UNUSED_RESULT.
6985         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6986
6987 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6988
6989         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6990         for-loop range, to avoid compiler warnings.
6991
6992         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6993         avoid compiler warnings about unused variables.
6994
6995         * NEWS: Mention end of support for native debugging on MS-Windows
6996         before XP.
6997
6998         PR gdb/24292
6999         * common/netstuff.c:
7000         * gdbserver/gdbreplay.c
7001         * gdbserver/remote-utils.c:
7002         * ser-tcp.c:
7003         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7004         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7005         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7006         'getaddrinfo' and 'freeaddrinfo' were not available before
7007         Windows XP, and mingw.org's MinGW headers by default define
7008         _WIN32_WINNT to 0x500.
7009
7010 2019-03-01  Gary Benson <gbenson@redhat.com>
7011
7012         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7013
7014 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7015             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7016
7017         PR gdb/8527
7018         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7019         set_sigint_trap, clear_sigint_trap.
7020
7021 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7022
7023         * target.c (target_detach): Clear the regcache and the
7024         frame cache.
7025
7026 2019-02-27  Pedro Alves  <palves@redhat.com>
7027
7028         * utils.c (set_screen_size): When we cap the height/width sizes,
7029         tweak the corresponding command variable to show "unlimited":
7030
7031 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7032             Pedro Alves  <palves@redhat.com>
7033
7034         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7035         before calling rl_set_screen_size.
7036
7037 2019-02-27  Tom Tromey  <tromey@adacore.com>
7038
7039         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7040         define.
7041         * python/py-value.c: Remove Python 2.4 workaround.
7042         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7043         workaround.
7044         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7045         Python 2.4 workaround.
7046         * python/python-internal.h: Remove Python 2.4 comment.
7047         (Py_ssize_t): Don't define.
7048         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7049         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7050         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7051         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7052         * python/python.c (do_start_initialization): Remove Python 2.4
7053         workaround.
7054         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7055         (print_children): Remove Python 2.4 workaround.
7056         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7057         workaround.
7058         (CHARBUFFERPROC_NAME): Remove.
7059         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7060         Python 2.4 workaround.
7061
7062 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7063
7064         * NEWS: Note minimum Python version.
7065
7066 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7067
7068         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7069         code from these functions.  Remove corresponding ifdefs.  Use
7070         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7071         Remove gotos and target of gotos.
7072         (infpy_search_memory): Likewise.
7073
7074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7075
7076         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7077         (hppa_gdbarch_init): Don't register deleted functions with
7078         gdbarch.
7079
7080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7083         (h8300_unwind_sp): Delete.
7084         (h8300_dummy_id): Delete.
7085         (h8300_gdbarch_init): Don't register deleted functions with
7086         gdbarch.
7087
7088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7089
7090         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7091         (ft32_unwind_pc): Delete.
7092         (ft32_unwind_sp): Delete.
7093         (ft32_gdbarch_init): Don't register deleted functions with
7094         gdbarch.
7095
7096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7097
7098         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7099         (frv_unwind_pc): Delete.
7100         (frv_unwind_sp): Delete.
7101         (frv_gdbarch_init): Don't register deleted functions with
7102         gdbarch.
7103
7104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7107         (riscv_unwind_pc): Delete.
7108         (riscv_unwind_sp): Delete.
7109         (riscv_gdbarch_init): Don't register deleted functions with
7110         gdbarch.
7111
7112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7115         (csky_unwind_pc): Delete.
7116         (csky_unwind_sp): Delete.
7117         (csky_gdbarch_init): Don't register deleted functions with
7118         gdbarch.
7119
7120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7123         (cris_unwind_pc): Delete.
7124         (cris_unwind_sp): Delete.
7125         (cris_gdbarch_init): Don't register deleted functions with
7126         gdbarch.
7127
7128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7129
7130         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7131         (bfin_unwind_pc): Delete.
7132         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7133
7134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7135
7136         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7137         (arm_unwind_pc): Delete.
7138         (arm_unwind_sp): Delete.
7139         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7140
7141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7144         (arc_unwind_pc): Delete.
7145         (arc_unwind_sp): Delete.
7146         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7147
7148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7149
7150         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7151         (alpha_unwind_pc): Delete.
7152         (alpha_gdbarch_init): Don't register deleted functions with
7153         gdbarch.
7154
7155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7156
7157         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7158         (aarch64_unwind_pc): Delete.
7159         (aarch64_unwind_sp): Delete.
7160         (aarch64_gdbarch_init): Don't register deleted functions with
7161         gdbarch.
7162
7163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * gdbtypes.c (type_align): Don't consider static members when
7166         computing structure alignment.
7167
7168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7169
7170         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7171         return 0 for other types.
7172         * arch-utils.c (default_type_align): Always return 0.
7173         * gdbarch.h: Regenerate.
7174         * gdbarch.sh (type_align): Extend comment.
7175         * gdbtypes.c (type_align): Add additional comments, always call
7176         gdbarch_type_align before applying the default rules.
7177         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7178         generic code will then apply a suitable default.
7179         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7180         types, return 0 for other types.
7181
7182 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7183
7184         * NEWS: Create a new section for the next release branch.
7185         Rename the section of the current branch, now that it has
7186         been cut.
7187
7188 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7189
7190         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7191         * version.in: Bump version to 8.3.50.DATE-git.
7192
7193 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7194
7195         * aix-thread.c (ptid_cmp): Remove unused variable.
7196         (get_signaled_thread): Likewise.
7197         (store_regs_user_thread): Likewise.
7198         (store_regs_kernel_thread): Likewise.
7199         (fetch_regs_kernel_thread): Remove shadowed variable.
7200
7201 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * features/riscv/32bit-cpu.xml: Add register numbers.
7204         * features/riscv/32bit-fpu.c: Regenerate.
7205         * features/riscv/32bit-fpu.xml: Add register numbers.
7206         * features/riscv/64bit-cpu.xml: Add register numbers.
7207         * features/riscv/64bit-fpu.c: Regenerate.
7208         * features/riscv/64bit-fpu.xml: Add register numbers.
7209
7210 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7211
7212         * NEWS: Mention two argument form of gdb.Value constructor.
7213         * python/py-value.c (convert_buffer_and_type_to_value): New
7214         function.
7215         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7216         Add support for handling an optional second argument.  Call
7217         convert_buffer_and_type_to_value as appropriate.
7218         * python/python-internal.h (Py_buffer_deleter): New struct.
7219         (Py_buffer_up): New typedef.
7220
7221 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7222
7223         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7224         instead of releasing ownership.
7225
7226 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7227
7228         * dwarf2read.c (open_and_init_dwp_file): Call
7229         elf_numsections instead of bfd_count_sections to initialize
7230         dwp_file->num_sections.
7231
7232 2019-02-25  Tom Tromey  <tromey@adacore.com>
7233
7234         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7235
7236 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7237
7238         * gcore.in: Add '--readnever' option when invoking GDB.
7239
7240 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7241
7242         * MAINTAINERS: Update my email address.
7243
7244 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7245
7246         * build-id.c (build_id_to_debug_bfd_1): New function.
7247         (build_id_to_debug_bfd): Look for separate debug file in
7248         sysroot.
7249
7250 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7251
7252         * gdbarch.sh: Update the copyright year range that is placed into
7253         generated files.
7254
7255 2019-02-22  Keith Seitz  <keiths@redhat.com>
7256
7257         PR symtab/23853
7258         * linespec.c (create_sals_line_offset): Search for the default
7259         symtab's filename instead of its fullname.
7260
7261 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7262
7263         * NEWS: Update style defaults.
7264
7265 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7266
7267         * main.c (captured_main_1): Disable styling in batch mode.
7268
7269 2019-02-20  Tom Tromey  <tom@tromey.com>
7270
7271         * symtab.c (symtab_symbol_info): Fix typos.
7272
7273 2019-02-20  Tom Tromey  <tromey@adacore.com>
7274
7275         * findcmd.c (_initialize_mem_search): Use upper case for
7276         metasyntactic variables.
7277
7278 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7279
7280         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7281         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7282
7283 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7284
7285         * top.h (source_file_name): Change to std::string.
7286         * top.c (source_file_name): Likewise.
7287         (command_line_input): Adjust.
7288         * cli/cli-script.c (script_from_file): Adjust.
7289
7290 2019-02-19  Tom Tromey  <tromey@adacore.com>
7291
7292         * ravenscar-thread.c
7293         (ravenscar_thread_target::update_thread_list): Don't call
7294         ada_build_task_list.
7295         * ada-lang.h (ada_build_task_list): Don't declare.
7296         * ada-tasks.c (struct ada_tasks_inferior_data)
7297         <task_list_valid_p>: Now bool.
7298         (read_known_tasks, ada_task_list_changed)
7299         (ada_tasks_invalidate_inferior_data): Update.
7300         (read_known_tasks_array): Return bool.
7301         (read_known_tasks_list): Likewise.
7302         (read_known_tasks): Return void.
7303         (ada_build_task_list): Now static.
7304
7305 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7308         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7309
7310 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7311
7312         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7313         variant for ada_tasks_pspace_data_handle and
7314         ada_tasks_inferior_data_handle.
7315         (ada_tasks_pspace_data_cleanup): New function.
7316         (ada_tasks_inferior_data_cleanup): New function.
7317
7318 2019-02-17  Tom Tromey  <tom@tromey.com>
7319
7320         * macrotab.h (macro_source_fullname): Return a std::string.
7321         * macrotab.c (macro_include, check_for_redefinition)
7322         (macro_undef, macro_lookup_definition, foreach_macro)
7323         (foreach_macro_in_scope): Update.
7324         (macro_source_fullname): Return a std::string.
7325         * macrocmd.c (show_pp_source_pos): Update.
7326
7327 2019-02-17  Tom Tromey  <tom@tromey.com>
7328
7329         * macrocmd.c (show_pp_source_pos): Style the file names.
7330
7331 2019-02-17  Tom Tromey  <tom@tromey.com>
7332
7333         PR tui/24197:
7334         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7335
7336 2019-02-17  Tom Tromey  <tom@tromey.com>
7337
7338         * ada-lang.c (user_select_syms): Use filtered printing.
7339         * utils.c (wrap_style): New global.
7340         (desired_style): Remove.
7341         (emit_style_escape): Add stream parameter.
7342         (set_output_style, reset_terminal_style, prompt_for_continue):
7343         Update.
7344         (flush_wrap_buffer): Only flush gdb_stdout.
7345         (wrap_here): Set wrap_style.
7346         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7347         treat escape sequences as a character.  Change when wrap buffer is
7348         flushed.
7349         (fputs_styled): Do not set the output style when the default is
7350         requested.
7351         * ui-style.h (struct ui_file_style) <is_default>: New method.
7352         * source.c (print_source_lines_base): Emit escape sequences in one
7353         piece.
7354
7355 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7356
7357         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7358         integers and enumeration types.
7359
7360 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7361
7362         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7363         instead of lookup_symbol_in_language
7364         (do_exact_match): New function.
7365         (ada_get_symbol_name_matcher): Return do_exact_match when
7366         doing a verbatim match.
7367
7368 2019-02-15  Tom Tromey  <tromey@adacore.com>
7369
7370         * ravenscar-thread.c (ravenscar_thread_target::resume)
7371         (ravenscar_thread_target::wait): Special case wildcard requests.
7372
7373 2019-02-15  Tom Tromey  <tromey@adacore.com>
7374
7375         * ravenscar-thread.c (base_ptid): Remove.
7376         (struct ravenscar_thread_target) <close>: New method.
7377         <m_base_ptid>: New member.
7378         <update_inferior_ptid, active_task, task_is_currently_active,
7379         runtime_initialized>: Declare methods.
7380         <ravenscar_thread_target>: Add constructor.
7381         (ravenscar_thread_target::task_is_currently_active)
7382         (ravenscar_thread_target::update_inferior_ptid)
7383         (ravenscar_runtime_initialized): Rename.  Now methods.
7384         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7385         (ravenscar_thread_target::update_thread_list): Update.
7386         (ravenscar_thread_target::active_task): Now method.
7387         (ravenscar_thread_target::store_registers)
7388         (ravenscar_thread_target::prepare_to_store)
7389         (ravenscar_thread_target::prepare_to_store)
7390         (ravenscar_thread_target::mourn_inferior): Update.
7391         (ravenscar_inferior_created): Use "new" to create target.
7392         (ravenscar_thread_target::get_ada_task_ptid): Update.
7393         (_initialize_ravenscar): Don't initialize base_ptid.
7394         (ravenscar_ops): Remove global.
7395
7396 2019-02-15  Tom Tromey  <tromey@adacore.com>
7397
7398         * target.h (push_target): Declare new overload.
7399         * target.c (push_target): New overload, taking an rvalue reference.
7400         * remote.c (remote_target::open_1): Use push_target overload.
7401         * corelow.c (core_target_open): Use push_target overload.
7402
7403 2019-02-15  Tom Tromey  <tromey@adacore.com>
7404
7405         * ravenscar-thread.c (is_ravenscar_task)
7406         (ravenscar_task_is_currently_active): Return bool.
7407         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7408         (_initialize_ravenscar): Remove "(void)".
7409         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7410         Return bool.
7411
7412 2019-02-15  Tom Tromey  <tromey@adacore.com>
7413
7414         * ravenscar-thread.c (ravenscar_runtime_initializer)
7415         (has_ravenscar_runtime, get_running_thread_id)
7416         (ravenscar_thread_target::resume): Fix indentation.
7417
7418 2019-02-15  Tom Tromey  <tromey@adacore.com>
7419
7420         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7421         from ravenscar_arch_ops.
7422         (sparc_ravenscar_ops::fetch_registers)
7423         (sparc_ravenscar_ops::store_registers): Now methods.
7424         (sparc_ravenscar_prepare_to_store): Remove.
7425         (sparc_ravenscar_ops): Redefine.
7426         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7427         methods and destructor.  Remove members.
7428         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7429         (ravenscar_thread_target::store_registers)
7430         (ravenscar_thread_target::prepare_to_store): Update.
7431         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7432         Remove.
7433         (struct ppc_ravenscar_powerpc_ops): Derive from
7434         ravenscar_arch_ops.
7435         (ppc_ravenscar_powerpc_ops::fetch_registers)
7436         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7437         (ppc_ravenscar_powerpc_ops): Redefine.
7438         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7439         (ppc_ravenscar_e500_ops::fetch_registers)
7440         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7441         (ppc_ravenscar_e500_ops): Redefine.
7442         * aarch64-ravenscar-thread.c
7443         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7444         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7445         (aarch64_ravenscar_fetch_registers)
7446         (aarch64_ravenscar_store_registers): Now methods.
7447         (aarch64_ravenscar_ops): Redefine.
7448
7449 2019-02-15  Tom Tromey  <tromey@adacore.com>
7450
7451         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7452         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7453         (ravenscar_thread_target::stopped_by_watchpoint)
7454         (ravenscar_thread_target::stopped_data_address)
7455         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7456
7457 2019-02-15  Tom Tromey  <tromey@adacore.com>
7458
7459         * ravenscar-thread.c: Fix some typos.
7460
7461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7462             Tom Tromey  <tromey@adacore.com>
7463
7464         * ada-lang.c (ada_exception_sal): Change addr_string to a
7465         std::string.
7466         (create_ada_exception_catchpoint): Update.
7467
7468 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7469             Tom Tromey  <tromey@adacore.com>
7470
7471         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7472         (bp_location_ops): Remove.
7473         (base_breakpoint_allocate_location): Update.
7474         (free_bp_location): Update.
7475         * ada-lang.c (class ada_catchpoint_location)
7476         <ada_catchpoint_location>: Remove ops parameter.
7477         (ada_catchpoint_location_dtor): Remove.
7478         (ada_catchpoint_location_ops): Remove.
7479         (allocate_location_exception): Update.
7480         * breakpoint.h (struct bp_location_ops): Remove.
7481         (class bp_location) <bp_location>: Remove bp_location_ops
7482         parameter.
7483         <~bp_location>: Add destructor.
7484         <ops>: Remove.
7485
7486 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7487             Pedro Alves  <palves@redhat.com>
7488
7489         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7490         'PATH_MAX'.
7491
7492 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7493             Samuel Thibault  <samuel.thibault@gnu.org>
7494             Thomas Schwinge  <thomas@codesourcery.com>
7495
7496         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7497         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7498
7499 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7500
7501         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7502         (check_empty): Use "const char *".
7503
7504         * gnu-nat.c (gnu_nat_target::detach): Instead of
7505         'detach_inferior (pid)' call
7506         'detach_inferior (find_inferior_pid (pid))'.
7507
7508         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7509         'nat/fork-inferior.o'.
7510         * gnu-nat.c: #include "nat/fork-inferior.h".
7511
7512         * gnu-nat.c (gnu_nat_target::detach): Instead of
7513         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7514         * gnu-nat.h: #include "inf-child.h".
7515         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7516         'i386_gnu_nat_target::fetch_registers'.
7517         (gnu_store_registers): Rename/move to
7518         'i386_gnu_nat_target::store_registers'.
7519
7520         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7521         * gnu-nat.h (mach_thread_info): New function.
7522         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7523
7524         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7525
7526 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7527
7528         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7529
7530 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7531
7532         * windows-nat.c (windows_add_thread): Add new parameter
7533         "main_thread_p" with default value set to false.  Update
7534         function documentation as well as all callers.
7535         (windows_delete_thread): Likewise.
7536         (fake_create_process): Update call to windows_add_thread.
7537         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7538         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7539         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7540         call to windows_delete_thread.
7541
7542 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7543
7544         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7545
7546 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7547
7548         * symfile.c (find_separate_debug_file): Use canonical path of
7549         sysroot with child_path instead of gdb_sysroot if it is valid.
7550
7551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7552
7553         * symfile.c (find_separate_debug_file): Use child_path to
7554         determine if an object file is under a sysroot.
7555
7556 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7557
7558         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7559         unittests/child-path-selftests.c.
7560         * common/pathstuff.c (child_path): New function.
7561         * common/pathstuff.h (child_path): New prototype.
7562         * unittests/child-path-selftests.c: New file.
7563
7564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7565
7566         * symfile.c (find_separate_debug_file): Look for separate debug
7567         files in debug directories under the sysroot.
7568
7569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7570
7571         * symtab.h (struct minimal_symbol data_p): New const method.
7572         (struct minimal_symbol text_p): Likewise.
7573         * symtab.c (output_source_filename): Use file name style
7574         to print file name.
7575         (print_symbol_info): Likewise.
7576         (print_msymbol_info): Use address style to print addresses.
7577         Use function name style to print executable text symbols.
7578         (expand_symtab_containing_pc): Use data_p.
7579         (find_pc_sect_compunit_symtab): Likewise.
7580
7581 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7582
7583         * breakpoint.c (describe_other_breakpoints): Use address style
7584         to print addresses.
7585         (say_where): Likewise.
7586
7587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7588
7589         * ada-typeprint.c (print_func_type): Print function name
7590         style to print function name.
7591         * c-typeprint.c (c_print_type_1): Likewise.
7592
7593 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7594
7595         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7596         for execve.
7597
7598 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7599
7600         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7601         type_stack.
7602
7603 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7604
7605         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7606         TYPE_CODE_REF types.
7607
7608 2019-02-08  Jim Wilson  <jimw@sifive.com>
7609
7610         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7611         (riscv_linux_fregset): New.
7612         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7613
7614 2019-02-07  Tom Tromey  <tom@tromey.com>
7615
7616         * thread.c (thread_cancel_execution_command): Update.
7617         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7618         methods.
7619         (struct thread_fsm_ops): Remove.
7620         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7621         (thread_fsm_should_stop, thread_fsm_return_value)
7622         (thread_fsm_set_finished, thread_fsm_finished_p)
7623         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7624         Don't declare.
7625         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7626         * infrun.c (clear_proceed_status_thread)
7627         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7628         (print_stop_event): Update.
7629         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7630         Add constructor.
7631         (step_command_fsm_ops): Remove.
7632         (new_step_command_fsm): Remove.
7633         (step_1): Update.
7634         (step_command_fsm::should_stop): Rename from
7635         step_command_fsm_should_stop.
7636         (step_command_fsm::clean_up): Rename from
7637         step_command_fsm_clean_up.
7638         (step_command_fsm::do_async_reply_reason): Rename from
7639         step_command_fsm_async_reply_reason.
7640         (struct until_next_fsm): Inherit from thread_fsm.  Add
7641         constructor.
7642         (until_next_fsm_ops): Remove.
7643         (new_until_next_fsm): Remove.
7644         (until_next_fsm::should_stop): Rename from
7645         until_next_fsm_should_stop.
7646         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7647         (until_next_fsm::do_async_reply_reason): Rename from
7648         until_next_fsm_async_reply_reason.
7649         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7650         constructor.  Change type of breakpoint.
7651         (finish_command_fsm_ops): Remove.
7652         (new_finish_command_fsm): Remove.
7653         (finish_command_fsm::should_stop): Rename from
7654         finish_command_fsm_should_stop.
7655         (finish_command_fsm::clean_up): Rename from
7656         finish_command_fsm_clean_up.
7657         (finish_command_fsm::return_value): Rename from
7658         finish_command_fsm_return_value.
7659         (finish_command_fsm::do_async_reply_reason): Rename from
7660         finish_command_fsm_async_reply_reason.
7661         (finish_command): Update.
7662         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7663         Add constructor.
7664         (call_thread_fsm_ops): Remove.
7665         (call_thread_fsm::call_thread_fsm): Rename from
7666         new_call_thread_fsm.
7667         (call_thread_fsm::should_stop): Rename from
7668         call_thread_fsm_should_stop.
7669         (call_thread_fsm::should_notify_stop): Rename from
7670         call_thread_fsm_should_notify_stop.
7671         (run_inferior_call, call_function_by_hand_dummy): Update.
7672         * cli/cli-interp.c (should_print_stop_to_console): Update.
7673         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7674         Add constructor.  Change type of location_breakpoint,
7675         caller_breakpoint.
7676         (until_break_fsm_ops): Remove.
7677         (new_until_break_fsm): Remove.
7678         (until_break_fsm::should_stop): Rename from
7679         until_break_fsm_should_stop.
7680         (until_break_fsm::clean_up): Rename from
7681         until_break_fsm_clean_up.
7682         (until_break_fsm::do_async_reply_reason): Rename from
7683         until_break_fsm_async_reply_reason.
7684         (until_break_command): Update.
7685         * thread-fsm.c: Remove.
7686         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7687
7688 2019-02-07  Tom Tromey  <tom@tromey.com>
7689
7690         * yy-remap.h: Add include guard.
7691         * xtensa-tdep.h: Add include guard.
7692         * xcoffread.h: Rename include guard.
7693         * varobj-iter.h: Add include guard.
7694         * tui/tui.h: Rename include guard.
7695         * tui/tui-winsource.h: Rename include guard.
7696         * tui/tui-wingeneral.h: Rename include guard.
7697         * tui/tui-windata.h: Rename include guard.
7698         * tui/tui-win.h: Rename include guard.
7699         * tui/tui-stack.h: Rename include guard.
7700         * tui/tui-source.h: Rename include guard.
7701         * tui/tui-regs.h: Rename include guard.
7702         * tui/tui-out.h: Rename include guard.
7703         * tui/tui-layout.h: Rename include guard.
7704         * tui/tui-io.h: Rename include guard.
7705         * tui/tui-hooks.h: Rename include guard.
7706         * tui/tui-file.h: Rename include guard.
7707         * tui/tui-disasm.h: Rename include guard.
7708         * tui/tui-data.h: Rename include guard.
7709         * tui/tui-command.h: Rename include guard.
7710         * tic6x-tdep.h: Add include guard.
7711         * target/waitstatus.h: Rename include guard.
7712         * target/wait.h: Rename include guard.
7713         * target/target.h: Rename include guard.
7714         * target/resume.h: Rename include guard.
7715         * target-float.h: Rename include guard.
7716         * stabsread.h: Add include guard.
7717         * rs6000-tdep.h: Add include guard.
7718         * riscv-fbsd-tdep.h: Add include guard.
7719         * regformats/regdef.h: Rename include guard.
7720         * record.h: Rename include guard.
7721         * python/python.h: Rename include guard.
7722         * python/python-internal.h: Rename include guard.
7723         * python/py-stopevent.h: Rename include guard.
7724         * python/py-ref.h: Rename include guard.
7725         * python/py-record.h: Rename include guard.
7726         * python/py-record-full.h: Rename include guard.
7727         * python/py-record-btrace.h: Rename include guard.
7728         * python/py-instruction.h: Rename include guard.
7729         * python/py-events.h: Rename include guard.
7730         * python/py-event.h: Rename include guard.
7731         * procfs.h: Add include guard.
7732         * proc-utils.h: Add include guard.
7733         * p-lang.h: Add include guard.
7734         * or1k-tdep.h: Rename include guard.
7735         * observable.h: Rename include guard.
7736         * nto-tdep.h: Rename include guard.
7737         * nat/x86-linux.h: Rename include guard.
7738         * nat/x86-linux-dregs.h: Rename include guard.
7739         * nat/x86-gcc-cpuid.h: Add include guard.
7740         * nat/x86-dregs.h: Rename include guard.
7741         * nat/x86-cpuid.h: Rename include guard.
7742         * nat/ppc-linux.h: Rename include guard.
7743         * nat/mips-linux-watch.h: Rename include guard.
7744         * nat/linux-waitpid.h: Rename include guard.
7745         * nat/linux-ptrace.h: Rename include guard.
7746         * nat/linux-procfs.h: Rename include guard.
7747         * nat/linux-osdata.h: Rename include guard.
7748         * nat/linux-nat.h: Rename include guard.
7749         * nat/linux-namespaces.h: Rename include guard.
7750         * nat/linux-btrace.h: Rename include guard.
7751         * nat/glibc_thread_db.h: Rename include guard.
7752         * nat/gdb_thread_db.h: Rename include guard.
7753         * nat/gdb_ptrace.h: Rename include guard.
7754         * nat/fork-inferior.h: Rename include guard.
7755         * nat/amd64-linux-siginfo.h: Rename include guard.
7756         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7757         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7758         * nat/aarch64-linux.h: Rename include guard.
7759         * nat/aarch64-linux-hw-point.h: Rename include guard.
7760         * mn10300-tdep.h: Add include guard.
7761         * mips-linux-tdep.h: Add include guard.
7762         * mi/mi-parse.h: Rename include guard.
7763         * mi/mi-out.h: Rename include guard.
7764         * mi/mi-main.h: Rename include guard.
7765         * mi/mi-interp.h: Rename include guard.
7766         * mi/mi-getopt.h: Rename include guard.
7767         * mi/mi-console.h: Rename include guard.
7768         * mi/mi-common.h: Rename include guard.
7769         * mi/mi-cmds.h: Rename include guard.
7770         * mi/mi-cmd-break.h: Rename include guard.
7771         * m2-lang.h: Add include guard.
7772         * location.h: Rename include guard.
7773         * linux-record.h: Rename include guard.
7774         * linux-nat.h: Add include guard.
7775         * linux-fork.h: Add include guard.
7776         * i386-darwin-tdep.h: Rename include guard.
7777         * hppa-linux-offsets.h: Add include guard.
7778         * guile/guile.h: Rename include guard.
7779         * guile/guile-internal.h: Rename include guard.
7780         * gnu-nat.h: Rename include guard.
7781         * gdb-stabs.h: Rename include guard.
7782         * frv-tdep.h: Add include guard.
7783         * f-lang.h: Add include guard.
7784         * event-loop.h: Add include guard.
7785         * darwin-nat.h: Rename include guard.
7786         * cp-abi.h: Rename include guard.
7787         * config/sparc/nm-sol2.h: Rename include guard.
7788         * config/nm-nto.h: Rename include guard.
7789         * config/nm-linux.h: Add include guard.
7790         * config/i386/nm-i386gnu.h: Rename include guard.
7791         * config/djgpp/nl_types.h: Rename include guard.
7792         * config/djgpp/langinfo.h: Rename include guard.
7793         * compile/gcc-cp-plugin.h: Add include guard.
7794         * compile/gcc-c-plugin.h: Add include guard.
7795         * compile/compile.h: Rename include guard.
7796         * compile/compile-object-run.h: Rename include guard.
7797         * compile/compile-object-load.h: Rename include guard.
7798         * compile/compile-internal.h: Rename include guard.
7799         * compile/compile-cplus.h: Rename include guard.
7800         * compile/compile-c.h: Rename include guard.
7801         * common/xml-utils.h: Rename include guard.
7802         * common/x86-xstate.h: Rename include guard.
7803         * common/version.h: Rename include guard.
7804         * common/vec.h: Rename include guard.
7805         * common/tdesc.h: Rename include guard.
7806         * common/selftest.h: Rename include guard.
7807         * common/scoped_restore.h: Rename include guard.
7808         * common/scoped_mmap.h: Rename include guard.
7809         * common/scoped_fd.h: Rename include guard.
7810         * common/safe-iterator.h: Rename include guard.
7811         * common/run-time-clock.h: Rename include guard.
7812         * common/refcounted-object.h: Rename include guard.
7813         * common/queue.h: Rename include guard.
7814         * common/ptid.h: Rename include guard.
7815         * common/print-utils.h: Rename include guard.
7816         * common/preprocessor.h: Rename include guard.
7817         * common/pathstuff.h: Rename include guard.
7818         * common/observable.h: Rename include guard.
7819         * common/netstuff.h: Rename include guard.
7820         * common/job-control.h: Rename include guard.
7821         * common/host-defs.h: Rename include guard.
7822         * common/gdb_wait.h: Rename include guard.
7823         * common/gdb_vecs.h: Rename include guard.
7824         * common/gdb_unlinker.h: Rename include guard.
7825         * common/gdb_unique_ptr.h: Rename include guard.
7826         * common/gdb_tilde_expand.h: Rename include guard.
7827         * common/gdb_sys_time.h: Rename include guard.
7828         * common/gdb_string_view.h: Rename include guard.
7829         * common/gdb_splay_tree.h: Rename include guard.
7830         * common/gdb_setjmp.h: Rename include guard.
7831         * common/gdb_ref_ptr.h: Rename include guard.
7832         * common/gdb_optional.h: Rename include guard.
7833         * common/gdb_locale.h: Rename include guard.
7834         * common/gdb_assert.h: Rename include guard.
7835         * common/filtered-iterator.h: Rename include guard.
7836         * common/filestuff.h: Rename include guard.
7837         * common/fileio.h: Rename include guard.
7838         * common/environ.h: Rename include guard.
7839         * common/common-utils.h: Rename include guard.
7840         * common/common-types.h: Rename include guard.
7841         * common/common-regcache.h: Rename include guard.
7842         * common/common-inferior.h: Rename include guard.
7843         * common/common-gdbthread.h: Rename include guard.
7844         * common/common-exceptions.h: Rename include guard.
7845         * common/common-defs.h: Rename include guard.
7846         * common/common-debug.h: Rename include guard.
7847         * common/cleanups.h: Rename include guard.
7848         * common/buffer.h: Rename include guard.
7849         * common/btrace-common.h: Rename include guard.
7850         * common/break-common.h: Rename include guard.
7851         * cli/cli-utils.h: Rename include guard.
7852         * cli/cli-style.h: Rename include guard.
7853         * cli/cli-setshow.h: Rename include guard.
7854         * cli/cli-script.h: Rename include guard.
7855         * cli/cli-interp.h: Rename include guard.
7856         * cli/cli-decode.h: Rename include guard.
7857         * cli/cli-cmds.h: Rename include guard.
7858         * charset-list.h: Add include guard.
7859         * buildsym-legacy.h: Rename include guard.
7860         * bfin-tdep.h: Add include guard.
7861         * ax.h: Rename include guard.
7862         * arm-linux-tdep.h: Add include guard.
7863         * arm-fbsd-tdep.h: Add include guard.
7864         * arch/xtensa.h: Rename include guard.
7865         * arch/tic6x.h: Add include guard.
7866         * arch/i386.h: Add include guard.
7867         * arch/arm.h: Rename include guard.
7868         * arch/arm-linux.h: Rename include guard.
7869         * arch/arm-get-next-pcs.h: Rename include guard.
7870         * arch/amd64.h: Add include guard.
7871         * arch/aarch64-insn.h: Rename include guard.
7872         * arch-utils.h: Rename include guard.
7873         * annotate.h: Add include guard.
7874         * amd64-darwin-tdep.h: Rename include guard.
7875         * aarch64-linux-tdep.h: Add include guard.
7876         * aarch64-fbsd-tdep.h: Add include guard.
7877         * aarch32-linux-nat.h: Add include guard.
7878
7879 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7880
7881         * macrotab.c (macro_define_internal): New function that
7882         factorizes macro_define_object_internal and macro_define_function
7883         code.
7884         (macro_define_object_internal): Use macro_define_internal.
7885         (macro_define_function): Likewise.
7886
7887 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7888
7889         * macrocmd.c (extract_identifier): Return
7890         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7891         callers.
7892
7893 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7894
7895         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7896
7897 2019-02-05  Tom Tromey  <tom@tromey.com>
7898
7899         * target.c (target_stack::unpush): Move assertion earlier.
7900
7901 2019-01-30  Tom Tromey  <tom@tromey.com>
7902
7903         PR python/23615:
7904         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7905         (gdbpy_parse_and_eval): Likewise.
7906         * python/python-internal.h (gdbpy_allow_threads): New class.
7907
7908 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7909
7910         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7911         (aarch64_fbsd_fpregmap): Move earlier.
7912         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7913         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7914         instead of individual calls to trad_frame_set_reg_addr.
7915         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7916         earlier.
7917         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7918         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7919         instead of individual calls to trad_frame_set_reg_addr.
7920
7921 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7922
7923         * CONTRIBUTE: Replace contribution list with wiki link.
7924
7925 2019-01-25  Tom Tromey  <tom@tromey.com>
7926
7927         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7928
7929 2019-01-25  Tom Tromey  <tom@tromey.com>
7930
7931         * xtensa-linux-nat.c: Fix common/ includes.
7932         * xml-support.h: Fix common/ includes.
7933         * xml-support.c: Fix common/ includes.
7934         * x86-linux-nat.c: Fix common/ includes.
7935         * windows-nat.c: Fix common/ includes.
7936         * varobj.h: Fix common/ includes.
7937         * varobj.c: Fix common/ includes.
7938         * value.c: Fix common/ includes.
7939         * valops.c: Fix common/ includes.
7940         * utils.c: Fix common/ includes.
7941         * unittests/xml-utils-selftests.c: Fix common/ includes.
7942         * unittests/utils-selftests.c: Fix common/ includes.
7943         * unittests/unpack-selftests.c: Fix common/ includes.
7944         * unittests/tracepoint-selftests.c: Fix common/ includes.
7945         * unittests/style-selftests.c: Fix common/ includes.
7946         * unittests/string_view-selftests.c: Fix common/ includes.
7947         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7948         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7949         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7950         * unittests/rsp-low-selftests.c: Fix common/ includes.
7951         * unittests/parse-connection-spec-selftests.c: Fix common/
7952         includes.
7953         * unittests/optional-selftests.c: Fix common/ includes.
7954         * unittests/offset-type-selftests.c: Fix common/ includes.
7955         * unittests/observable-selftests.c: Fix common/ includes.
7956         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7957         * unittests/memrange-selftests.c: Fix common/ includes.
7958         * unittests/memory-map-selftests.c: Fix common/ includes.
7959         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7960         * unittests/function-view-selftests.c: Fix common/ includes.
7961         * unittests/environ-selftests.c: Fix common/ includes.
7962         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7963         * unittests/common-utils-selftests.c: Fix common/ includes.
7964         * unittests/cli-utils-selftests.c: Fix common/ includes.
7965         * unittests/array-view-selftests.c: Fix common/ includes.
7966         * ui-file.c: Fix common/ includes.
7967         * tui/tui-io.c: Fix common/ includes.
7968         * tracepoint.h: Fix common/ includes.
7969         * tracepoint.c: Fix common/ includes.
7970         * tracefile-tfile.c: Fix common/ includes.
7971         * top.h: Fix common/ includes.
7972         * top.c: Fix common/ includes.
7973         * thread.c: Fix common/ includes.
7974         * target/waitstatus.h: Fix common/ includes.
7975         * target/waitstatus.c: Fix common/ includes.
7976         * target.h: Fix common/ includes.
7977         * target.c: Fix common/ includes.
7978         * target-memory.c: Fix common/ includes.
7979         * target-descriptions.c: Fix common/ includes.
7980         * symtab.h: Fix common/ includes.
7981         * symfile.c: Fix common/ includes.
7982         * stap-probe.c: Fix common/ includes.
7983         * spu-linux-nat.c: Fix common/ includes.
7984         * sparc-nat.c: Fix common/ includes.
7985         * source.c: Fix common/ includes.
7986         * solib.c: Fix common/ includes.
7987         * solib-target.c: Fix common/ includes.
7988         * ser-unix.c: Fix common/ includes.
7989         * ser-tcp.c: Fix common/ includes.
7990         * ser-pipe.c: Fix common/ includes.
7991         * ser-base.c: Fix common/ includes.
7992         * selftest-arch.c: Fix common/ includes.
7993         * s12z-tdep.c: Fix common/ includes.
7994         * rust-exp.y: Fix common/ includes.
7995         * rs6000-aix-tdep.c: Fix common/ includes.
7996         * riscv-tdep.c: Fix common/ includes.
7997         * remote.c: Fix common/ includes.
7998         * remote-notif.h: Fix common/ includes.
7999         * remote-fileio.h: Fix common/ includes.
8000         * remote-fileio.c: Fix common/ includes.
8001         * regcache.h: Fix common/ includes.
8002         * regcache.c: Fix common/ includes.
8003         * record-btrace.c: Fix common/ includes.
8004         * python/python.c: Fix common/ includes.
8005         * python/py-type.c: Fix common/ includes.
8006         * python/py-inferior.c: Fix common/ includes.
8007         * progspace.h: Fix common/ includes.
8008         * producer.c: Fix common/ includes.
8009         * procfs.c: Fix common/ includes.
8010         * proc-api.c: Fix common/ includes.
8011         * printcmd.c: Fix common/ includes.
8012         * ppc-linux-nat.c: Fix common/ includes.
8013         * parser-defs.h: Fix common/ includes.
8014         * osdata.c: Fix common/ includes.
8015         * obsd-nat.c: Fix common/ includes.
8016         * nat/x86-linux.c: Fix common/ includes.
8017         * nat/x86-linux-dregs.c: Fix common/ includes.
8018         * nat/x86-dregs.h: Fix common/ includes.
8019         * nat/x86-dregs.c: Fix common/ includes.
8020         * nat/ppc-linux.c: Fix common/ includes.
8021         * nat/mips-linux-watch.h: Fix common/ includes.
8022         * nat/mips-linux-watch.c: Fix common/ includes.
8023         * nat/linux-waitpid.c: Fix common/ includes.
8024         * nat/linux-ptrace.h: Fix common/ includes.
8025         * nat/linux-ptrace.c: Fix common/ includes.
8026         * nat/linux-procfs.c: Fix common/ includes.
8027         * nat/linux-personality.c: Fix common/ includes.
8028         * nat/linux-osdata.c: Fix common/ includes.
8029         * nat/linux-namespaces.c: Fix common/ includes.
8030         * nat/linux-btrace.h: Fix common/ includes.
8031         * nat/linux-btrace.c: Fix common/ includes.
8032         * nat/fork-inferior.c: Fix common/ includes.
8033         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8034         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8035         * nat/aarch64-linux.c: Fix common/ includes.
8036         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8037         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8038         * namespace.h: Fix common/ includes.
8039         * mips-linux-tdep.c: Fix common/ includes.
8040         * minsyms.c: Fix common/ includes.
8041         * mi/mi-parse.h: Fix common/ includes.
8042         * mi/mi-main.c: Fix common/ includes.
8043         * mi/mi-cmd-env.c: Fix common/ includes.
8044         * memrange.h: Fix common/ includes.
8045         * memattr.c: Fix common/ includes.
8046         * maint.h: Fix common/ includes.
8047         * maint.c: Fix common/ includes.
8048         * main.c: Fix common/ includes.
8049         * machoread.c: Fix common/ includes.
8050         * location.c: Fix common/ includes.
8051         * linux-thread-db.c: Fix common/ includes.
8052         * linux-nat.c: Fix common/ includes.
8053         * linux-fork.c: Fix common/ includes.
8054         * inline-frame.c: Fix common/ includes.
8055         * infrun.c: Fix common/ includes.
8056         * inflow.c: Fix common/ includes.
8057         * inferior.h: Fix common/ includes.
8058         * inferior.c: Fix common/ includes.
8059         * infcmd.c: Fix common/ includes.
8060         * inf-ptrace.c: Fix common/ includes.
8061         * inf-child.c: Fix common/ includes.
8062         * ia64-linux-nat.c: Fix common/ includes.
8063         * i387-tdep.c: Fix common/ includes.
8064         * i386-tdep.c: Fix common/ includes.
8065         * i386-linux-tdep.c: Fix common/ includes.
8066         * i386-linux-nat.c: Fix common/ includes.
8067         * i386-go32-tdep.c: Fix common/ includes.
8068         * i386-fbsd-tdep.c: Fix common/ includes.
8069         * i386-fbsd-nat.c: Fix common/ includes.
8070         * guile/scm-type.c: Fix common/ includes.
8071         * guile/guile.c: Fix common/ includes.
8072         * go32-nat.c: Fix common/ includes.
8073         * gnu-nat.c: Fix common/ includes.
8074         * gdbthread.h: Fix common/ includes.
8075         * gdbarch-selftests.c: Fix common/ includes.
8076         * gdb_usleep.c: Fix common/ includes.
8077         * gdb_select.h: Fix common/ includes.
8078         * gdb_bfd.c: Fix common/ includes.
8079         * gcore.c: Fix common/ includes.
8080         * fork-child.c: Fix common/ includes.
8081         * findvar.c: Fix common/ includes.
8082         * fbsd-nat.c: Fix common/ includes.
8083         * event-top.c: Fix common/ includes.
8084         * event-loop.c: Fix common/ includes.
8085         * dwarf2read.c: Fix common/ includes.
8086         * dwarf2loc.c: Fix common/ includes.
8087         * dwarf2-frame.c: Fix common/ includes.
8088         * dwarf-index-cache.c: Fix common/ includes.
8089         * dtrace-probe.c: Fix common/ includes.
8090         * disasm-selftests.c: Fix common/ includes.
8091         * defs.h: Fix common/ includes.
8092         * csky-tdep.c: Fix common/ includes.
8093         * cp-valprint.c: Fix common/ includes.
8094         * cp-support.h: Fix common/ includes.
8095         * cp-support.c: Fix common/ includes.
8096         * corelow.c: Fix common/ includes.
8097         * completer.h: Fix common/ includes.
8098         * completer.c: Fix common/ includes.
8099         * compile/compile.c: Fix common/ includes.
8100         * compile/compile-loc2c.c: Fix common/ includes.
8101         * compile/compile-cplus-types.c: Fix common/ includes.
8102         * compile/compile-cplus-symbols.c: Fix common/ includes.
8103         * command.h: Fix common/ includes.
8104         * cli/cli-dump.c: Fix common/ includes.
8105         * cli/cli-cmds.c: Fix common/ includes.
8106         * charset.c: Fix common/ includes.
8107         * build-id.c: Fix common/ includes.
8108         * btrace.h: Fix common/ includes.
8109         * btrace.c: Fix common/ includes.
8110         * breakpoint.h: Fix common/ includes.
8111         * breakpoint.c: Fix common/ includes.
8112         * ax.h:
8113         (enum agent_op): Fix common/ includes.
8114         * ax-general.c (struct aop_map): Fix common/ includes.
8115         * ax-gdb.c: Fix common/ includes.
8116         * auxv.c: Fix common/ includes.
8117         * auto-load.c: Fix common/ includes.
8118         * arm-tdep.c: Fix common/ includes.
8119         * arch/riscv.c: Fix common/ includes.
8120         * arch/ppc-linux-common.c: Fix common/ includes.
8121         * arch/i386.c: Fix common/ includes.
8122         * arch/arm.c: Fix common/ includes.
8123         * arch/arm-linux.c: Fix common/ includes.
8124         * arch/arm-get-next-pcs.c: Fix common/ includes.
8125         * arch/amd64.c: Fix common/ includes.
8126         * arch/aarch64.c: Fix common/ includes.
8127         * arch/aarch64-insn.c: Fix common/ includes.
8128         * arch-utils.c: Fix common/ includes.
8129         * amd64-windows-tdep.c: Fix common/ includes.
8130         * amd64-tdep.c: Fix common/ includes.
8131         * amd64-sol2-tdep.c: Fix common/ includes.
8132         * amd64-obsd-tdep.c: Fix common/ includes.
8133         * amd64-nbsd-tdep.c: Fix common/ includes.
8134         * amd64-linux-tdep.c: Fix common/ includes.
8135         * amd64-linux-nat.c: Fix common/ includes.
8136         * amd64-fbsd-tdep.c: Fix common/ includes.
8137         * amd64-fbsd-nat.c: Fix common/ includes.
8138         * amd64-dicos-tdep.c: Fix common/ includes.
8139         * amd64-darwin-tdep.c: Fix common/ includes.
8140         * agent.c: Fix common/ includes.
8141         * ada-lang.h: Fix common/ includes.
8142         * ada-lang.c: Fix common/ includes.
8143         * aarch64-tdep.c: Fix common/ includes.
8144
8145 2019-01-25  Tom Tromey  <tom@tromey.com>
8146
8147         * common/create-version.sh: Use common/version.h.
8148
8149 2019-01-24  Pedro Alves  <palves@redhat.com>
8150
8151         * infrun.c (signal_stop, signal_print, signal_program)
8152         (signal_catch, signal_pass): Now arrays instead of pointers.
8153         (update_signals_program_target, do_target_resume)
8154         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8155         * linux-nat.c (linux_nat_target::pass_signals)
8156         (linux_nat_target::create_inferior, linux_nat_target::attach):
8157         Adjust.
8158         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8159         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8160         * procfs.c (procfs_target::pass_signals): Adjust.
8161         * record-full.c (record_full_target::resume): Adjust.
8162         * remote.c (remote_target::pass_signals)
8163         (remote_target::program_signals): Adjust.
8164         * target-debug.h (target_debug_print_signals): Now takes a
8165         gdb::array_view as parameter.  Adjust.
8166         * target.h (target_ops) <pass_signals, program_signals>: Replace
8167         pointer and length parameters with gdb::array_view.
8168         (target_pass_signals, target_program_signals): Likewise.
8169         * target-delegates.c: Regenerate.
8170
8171 2019-01-24  Pedro Alves  <palves@redhat.com>
8172
8173         * common/forward-scope-exit.h
8174         (forward_scope_exit::forward_scope_exit): Pass arguments to
8175         m_bind_function directly, instead of creating a std::bind and
8176         copying that.
8177
8178 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8179
8180         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8181         for static members.
8182         (pass_in_v_vfp_candidate): Likewise.
8183
8184 2019-01-23  Tom Tromey  <tom@tromey.com>
8185             Pedro Alves  <palves@redhat.com>
8186
8187         * regcache.c (class regcache_invalidator): Remove.
8188         (regcache::raw_write): Use make_scope_exit.
8189
8190 2019-01-23  Tom Tromey  <tom@tromey.com>
8191
8192         * ui-out.h (class ui_out_emit_type): Update comment.
8193
8194 2019-01-23  Tom Tromey  <tom@tromey.com>
8195
8196         * infrun.c (fetch_inferior_event): Update comment.
8197
8198 2019-01-23  Tom Tromey  <tom@tromey.com>
8199             Pedro Alves  <palves@redhat.com>
8200
8201         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8202         parameter.
8203         (fetch_inferior_event): Use SCOPE_EXIT.
8204
8205
8206 2019-01-23  Tom Tromey  <tom@tromey.com>
8207             Pedro Alves  <palves@redhat.com>
8208
8209         * infrun.c (disable_thread_events): Delete.
8210         (stop_all_threads): Use SCOPE_EXIT.
8211
8212 2019-01-23  Tom Tromey  <tom@tromey.com>
8213             Pedro Alves  <palves@redhat.com>
8214
8215         * symfile.c: Include forward-scope-exit.h.
8216         (clear_symtab_users_cleanup): Replace forward declaration with
8217         a FORWARD_SCOPE_EXIT.
8218         (syms_from_objfile_1): Use the forward_scope_exit and
8219         gdb::optional instead of cleanup_function.
8220         (reread_symbols): Use the forward_scope_exit instead of
8221         cleanup_function.
8222         (clear_symtab_users_cleanup): Remove function.
8223
8224 2019-01-23  Tom Tromey  <tom@tromey.com>
8225             Pedro Alves  <palves@redhat.com>
8226
8227         * linux-nat.c: Include scope-exit.h.
8228         (cleanup_target_stop): Remove.
8229         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8230         SCOPE_EXIT.
8231
8232 2019-01-23  Tom Tromey  <tom@tromey.com>
8233             Pedro Alves  <palves@redhat.com>
8234
8235         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8236         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8237
8238 2019-01-23  Tom Tromey  <tom@tromey.com>
8239             Andrew Burgess  <andrew.burgess@embecosm.com>
8240             Pedro Alves  <palves@redhat.com>
8241
8242         * infrun.c (fetch_inferior_event): Use scope_exit.
8243         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8244         * top.c (execute_command): Use scope_exit.
8245         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8246         * utils.c (do_bpstat_clear_actions_cleanup)
8247         (make_bpstat_clear_actions_cleanup): Remove.
8248
8249 2019-01-23  Tom Tromey  <tom@tromey.com>
8250             Pedro Alves  <palves@redhat.com>
8251
8252         * infrun.c: Include "common/scope-exit.h"
8253         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8254         (wait_for_inferior): Use SCOPE_EXIT.
8255         (fetch_inferior_event): Use scope_exit.
8256
8257 2019-01-23  Tom Tromey  <tom@tromey.com>
8258             Pedro Alves  <palves@redhat.com>
8259
8260         * breakpoint.c (create_breakpoint): Remove cleanup.
8261
8262 2019-01-23  Tom Tromey  <tom@tromey.com>
8263             Andrew Burgess  <andrew.burgess@embecosm.com>
8264             Pedro Alves  <palves@redhat.com>
8265
8266 2019-01-23  Pedro Alves  <palves@redhat.com>
8267
8268         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8269
8270 2019-01-23  Pedro Alves  <palves@redhat.com>
8271             Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * gdbthread.h: Include "common/forward-scope-exit.h".
8274         (scoped_finish_thread_state): Redefine custom class in terms of
8275         forward_scope_exit.
8276
8277 2019-01-23  Pedro Alves  <palves@redhat.com>
8278             Andrew Burgess  <andrew.burgess@embecosm.com>
8279
8280         * common/forward-scope-exit.h: New file.
8281
8282 2019-01-23  Pedro Alves  <palves@redhat.com>
8283             Andrew Burgess  <andrew.burgess@embecosm.com>
8284             Tom Tromey  <tom@tromey.com>
8285
8286         * common/scope-exit.h: New file.
8287
8288 2019-01-23  Pedro Alves  <palves@redhat.com>
8289
8290         * common/preprocessor.h (ESC): Rename to ...
8291         (ESC_PARENS): ... this.
8292         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8293         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8294
8295 2019-01-23  Tom Tromey  <tom@tromey.com>
8296
8297         * language.h (class scoped_switch_to_sym_language_if_auto):
8298         Initialize m_lang in both cases.
8299
8300 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8301
8302         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8303         with XCNEW.
8304
8305 2019-01-22  Tom Tromey  <tom@tromey.com>
8306
8307         * corelow.c: Do not include sys/file.h.
8308
8309 2019-01-22  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-wingeneral.h: Include gdb_curses.h.
8312
8313 2019-01-22  Tom Tromey  <tom@tromey.com>
8314
8315         * source-cache.h (class source_cache) <get_source_lines,
8316         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8317
8318 2019-01-22  Tom Tromey  <tom@tromey.com>
8319
8320         * remote-fileio.h (struct remote_target): Declare.
8321
8322 2019-01-22  Tom Tromey  <tom@tromey.com>
8323
8324         * python/py-arch.c: Do not include py-ref.h.
8325         * python/py-bpevent.c: Do not include py-ref.h.
8326         * python/py-cmd.c: Do not include py-ref.h.
8327         * python/py-continueevent.c: Do not include py-ref.h.
8328         * python/py-event.h: Do not include py-ref.h.
8329         * python/py-evtregistry.c: Do not include py-ref.h.
8330         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8331         * python/py-frame.c: Do not include py-ref.h.
8332         * python/py-framefilter.c: Do not include py-ref.h.
8333         * python/py-function.c: Do not include py-ref.h.
8334         * python/py-infevents.c: Do not include py-ref.h.
8335         * python/py-linetable.c: Do not include py-ref.h.
8336         * python/py-objfile.c: Do not include py-ref.h.
8337         * python/py-param.c: Do not include py-ref.h.
8338         * python/py-prettyprint.c: Do not include py-ref.h.
8339         * python/py-progspace.c: Do not include py-ref.h.
8340         * python/py-symbol.c: Do not include py-ref.h.
8341         * python/py-symtab.c: Do not include py-ref.h.
8342         * python/py-type.c: Do not include py-ref.h.
8343         * python/py-unwind.c: Do not include py-ref.h.
8344         * python/py-utils.c: Do not include py-ref.h.
8345         * python/py-value.c: Do not include py-ref.h.
8346         * python/py-varobj.c: Do not include py-ref.h.
8347         * python/py-xmethods.c: Do not include py-ref.h.
8348         * python/python.c: Do not include py-ref.h.
8349         * varobj.c: Do not include py-ref.h.
8350
8351 2019-01-22  Tom Tromey  <tom@tromey.com>
8352
8353         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8354         keyword for bcache.
8355
8356 2019-01-22  Tom Tromey  <tom@tromey.com>
8357
8358         * compile/compile-cplus-types.c: Remove a comment by #include.
8359
8360 2019-01-22  Tom Tromey  <tom@tromey.com>
8361
8362         * compile/gcc-c-plugin.h: Include compile-internal.h.
8363
8364 2019-01-22  Tom Tromey  <tom@tromey.com>
8365
8366         * stabsread.c (EXTERN): Do not define.
8367         (symnum, next_symbol_text_func, processing_gcc_compilation)
8368         (within_function, global_sym_chain, global_stabs)
8369         (previous_stab_code, this_object_header_files)
8370         (n_this_object_header_files)
8371         (n_allocated_this_object_header_files): Define.
8372         * stabsread.h (EXTERN): Never define.  Use "extern".
8373
8374 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8375
8376         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8377         history_value.
8378
8379 2019-01-21  Tom Tromey  <tom@tromey.com>
8380
8381         * ui-out.c: Fix includes.
8382         * tui/tui-source.c: Fix includes.
8383         * target.c: Fix includes.
8384         * remote.c: Fix includes.
8385         * regcache.c: Fix includes.
8386         * python/py-block.c: Fix includes.
8387         * printcmd.c: Fix includes.
8388         * or1k-tdep.c: Fix includes.
8389         * mi/mi-main.c: Fix includes.
8390         * m32r-tdep.c: Fix includes.
8391         * csky-tdep.c: Fix includes.
8392         * compile/compile-cplus-types.c: Fix includes.
8393         * cli/cli-interp.c: Fix includes.
8394
8395 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8396
8397         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8398         for padding.
8399
8400 2019-01-16  Tom Tromey  <tom@tromey.com>
8401
8402         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8403         earlier.
8404         (struct objfile) <msymbols_range>: Move from top level.
8405         <msymbols>: New method.
8406         (class objfile_msymbols): Remove.
8407         * symtab.c (default_collect_symbol_completion_matches_break_on):
8408         Update.
8409         * symmisc.c (dump_msymbols): Update.
8410         * stabsread.c (scan_file_globals): Update.
8411         * objc-lang.c (info_selectors_command, info_classes_command)
8412         (find_methods): Update.
8413         * minsyms.c (find_solib_trampoline_target): Update.
8414         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8415         * coffread.c (coff_symfile_read): Update.
8416         * ada-lang.c (ada_lookup_simple_minsym)
8417         (ada_collect_symbol_completion_matches): Update.
8418
8419 2019-01-16  Tom Tromey  <tom@tromey.com>
8420
8421         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8422         type.  Remove no-argument constructor.
8423         <iterator::operator++>: Simplify.
8424         <begin>: Update.
8425         <end>: Use minimal_symbol_count.
8426
8427 2019-01-16  Tom Tromey  <tom@tromey.com>
8428
8429         * objfiles.h (struct objfile) <psymtabs>: New method.
8430         (class objfile_psymtabs): Remove.
8431         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8432         typedef.
8433         <range>: New method.
8434         (require_partial_symbols): Change return type.
8435         * psymtab.c (require_partial_symbols)
8436         (psym_expand_symtabs_matching): Update.
8437         * mdebugread.c (parse_partial_symbols): Update.
8438         * dbxread.c (dbx_end_psymtab): Update.
8439
8440 2019-01-15  Tom Tromey  <tom@tromey.com>
8441
8442         * symtab.c (lookup_objfile_from_block)
8443         (lookup_symbol_in_objfile_symtabs)
8444         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8445         (find_line_symtab, info_sources_command)
8446         (default_collect_symbol_completion_matches_break_on)
8447         (make_source_files_completion_list): Update.
8448         * symmisc.c (print_objfile_statistics, dump_objfile)
8449         (maintenance_print_symbols, maintenance_info_symtabs)
8450         (maintenance_check_symtabs, maintenance_info_line_tables):
8451         Update.
8452         * source.c (select_source_symtab)
8453         (forget_cached_source_info_for_objfile): Update.
8454         * objfiles.h (class objfile_compunits): Remove.
8455         (struct objfile) <compunits_range>: New typedef.
8456         (compunits): New method.
8457         * objfiles.c (objfile_relocate1): Update.
8458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8459         * maint.c (count_symtabs_and_blocks): Update.
8460         * linespec.c (iterate_over_all_matching_symtabs): Update.
8461         * cp-support.c (add_symbol_overload_list_qualified): Update.
8462         * coffread.c (coff_symtab_read): Update.
8463         * ada-lang.c (add_nonlocal_symbols)
8464         (ada_collect_symbol_completion_matches)
8465         (ada_add_global_exceptions): Update.
8466
8467 2019-01-15  Tom Tromey  <tom@tromey.com>
8468
8469         * progspace.h (program_space) <objfiles_safe_range>: New
8470         typedef.
8471         <objfiles_safe>: New method.
8472         * objfiles.h (class all_objfiles_safe): Remove.
8473         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8474         * jit.c (jit_inferior_exit_hook): Update.
8475
8476 2019-01-17  Tom Tromey  <tom@tromey.com>
8477
8478         * progspace.h (program_space) <objfiles_range>: New typedef.
8479         <objfiles>: New method.
8480         <objfiles_head>: Rename from objfiles.
8481         (object_files): Update.
8482         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8483         * guile/scm-pretty-print.c
8484         (ppscm_find_pretty_printer_from_objfiles): Update.
8485         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8486         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8487         Update.
8488         * python/py-progspace.c (pspy_get_objfiles): Update.
8489         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8490         Update.
8491         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8492         (objfpy_lookup_objfile_by_build_id): Update.
8493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8494         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8495         Update.
8496         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8497         (expand_symtab_containing_pc, lookup_objfile_from_block)
8498         (lookup_static_symbol, basic_lookup_transparent_type)
8499         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8500         (find_line_symtab, info_sources_command)
8501         (default_collect_symbol_completion_matches_break_on)
8502         (make_source_files_completion_list, find_main_name): Update.
8503         * symmisc.c (print_symbol_bcache_statistics)
8504         (print_objfile_statistics, maintenance_print_symbols)
8505         (maintenance_print_msymbols, maintenance_print_objfiles)
8506         (maintenance_info_symtabs, maintenance_check_symtabs)
8507         (maintenance_expand_symtabs, maintenance_info_line_tables):
8508         Update.
8509         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8510         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8511         (map_overlay_command, unmap_overlay_command)
8512         (simple_overlay_update, expand_symtabs_matching)
8513         (map_symbol_filenames): Update.
8514         * symfile-debug.c (set_debug_symfile): Update.
8515         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8516         Update.
8517         * source.c (select_source_symtab, forget_cached_source_info):
8518         Update.
8519         * solib.c (solib_read_symbols): Update.
8520         * solib-spu.c (append_ocl_sos): Update.
8521         * psymtab.c (maintenance_print_psymbols)
8522         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8523         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8524         * printcmd.c (info_symbol_command): Update.
8525         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8526         Update.
8527         * objfiles.h (class all_objfiles): Remove.
8528         * objfiles.c (have_partial_symbols, have_full_symbols)
8529         (have_minimal_symbols, qsort_cmp, update_section_map)
8530         (shared_objfile_contains_address_p)
8531         (default_iterate_over_objfiles_in_search_order): Update.
8532         * objc-lang.c (info_selectors_command, info_classes_command)
8533         (find_methods): Update.
8534         * minsyms.c (find_solib_trampoline_target): Update.
8535         * maint.c (maintenance_info_sections)
8536         (maintenance_translate_address, count_symtabs_and_blocks):
8537         Update.
8538         * main.c (captured_main_1): Update.
8539         * linux-thread-db.c (try_thread_db_load_from_pdir)
8540         (has_libpthread): Update.
8541         * linespec.c (iterate_over_all_matching_symtabs)
8542         (search_minsyms_for_name): Update.
8543         * jit.c (jit_find_objf_with_entry_addr): Update.
8544         * hppa-tdep.c (find_unwind_entry)
8545         (hppa_lookup_stub_minimal_symbol): Update.
8546         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8547         Update.
8548         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8549         (elf_gnu_ifunc_resolve_by_got): Update.
8550         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8551         * dwarf-index-write.c (save_gdb_index_command): Update.
8552         * cp-support.c (add_symbol_overload_list_qualified): Update.
8553         * breakpoint.c (create_overlay_event_breakpoint)
8554         (create_longjmp_master_breakpoint)
8555         (create_std_terminate_master_breakpoint)
8556         (create_exception_master_breakpoint): Update.
8557         * blockframe.c (find_pc_partial_function): Update.
8558         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8559         (ada_collect_symbol_completion_matches)
8560         (ada_add_global_exceptions): Update.
8561
8562 2019-01-17  Tom Tromey  <tom@tromey.com>
8563
8564         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8565         declare VEC.
8566         (solib_target_parse_libraries): Change return type.
8567         (library_list_start_segment, library_list_start_section)
8568         (library_list_end_library, library_list_start_library); Update.
8569         (solib_target_free_library_list): Remove.
8570         (solib_target_parse_libraries): Remove cleanup.  Change return
8571         type.
8572         (solib_target_current_sos): Update.
8573
8574 2019-01-17  Tom Tromey  <tromey@bapiya>
8575
8576         * valprint.c: Replace "the the" with "the".
8577         * symtab.c: Replace "the the" with "the".
8578         * solib.c: Replace "the the" with "the".
8579         * solib-dsbt.c: Replace "the the" with "the".
8580         * linespec.c: Replace "the the" with "the".
8581         * dwarf2loc.h: Replace "the the" with "the".
8582         * amd64-windows-tdep.c: Replace "the the" with "the".
8583         * aarch64-tdep.c: Replace "the the" with "the".
8584
8585 2019-01-16  Keith Seitz  <keiths@redhat.com>
8586
8587         PR gdb/23773
8588         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8589         <builder>: Rename to ..
8590         <m_builder>: ... this and make private.
8591         (dwarf2_cu::get_builder): New method.  Change all users of
8592         `builder' to use this method.
8593         (dwarf2_start_symtab): Move to ...
8594         (dwarf2_cu::start_symtab): ... here.  Update all callers
8595         (setup_type_unit_groups): Move to ...
8596         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8597         callers.
8598         (dwarf2_cu::reset_builder): New method.
8599         (process_full_compunit, process_full_type_unit): Use
8600         dwarf2_cu::reset_builder.
8601         (follow_die_offset): Record the ancestor CU if it is different
8602         from the followed DIE's CU.
8603         (follow_die_sig_1): Likewise.
8604
8605 2019-01-15  Tom Tromey  <tom@tromey.com>
8606
8607         * remote.c (class remote_state) <buf>: Now a char_vector.
8608         <buf_size>: Remove.
8609         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8610         parameter.
8611         (remote_target::getpkt_or_notif_sane_1)
8612         (remote_target::getpkt_sane)
8613         (remote_target::getpkt_or_notif_sane): Likewise.
8614         (class remote_target) <putpkt>: New overload.
8615         (remote_target::read_frame): Change type of "buf_p".  Remove
8616         sizeof_p parameter.
8617         (packet_ok): New overload.
8618         (packet_check_result): New overload.
8619         Update all uses.
8620
8621 2019-01-14  Tom Tromey  <tom@tromey.com>
8622
8623         * remote-notif.c (handle_notification, remote_notif_ack)
8624         (remote_notif_parse): Make "buf" const.
8625         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8626         const.
8627         (remote_notif_parse, remote_notif_ack, handle_notification):
8628         Likewise.
8629         * remote.c (remote_notif_stop_parse): Make "buf" const.
8630         (remote_target::remote_parse_stop_reply): Make "buf" const.
8631         (remote_notif_stop_ack): Make "buf" const.
8632
8633 2019-01-14  Tom Tromey  <tom@tromey.com>
8634
8635         * remote.c (remote_console_output): Make parameter const.
8636
8637 2019-01-14  Tom Tromey  <tom@tromey.com>
8638
8639         * target-debug.h (target_debug_print_signals): Constify.
8640         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8641         * procfs.c (procfs_target::pass_signals): Update.
8642         * linux-nat.c (linux_nat_target::pass_signals): Update.
8643         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8644         * target-delegates.c: Rebuild.
8645         * remote.c (remote_target::program_signals): Update.
8646         (remote_target::pass_signals): Update.
8647         * target.c (target_pass_signals): Constify argument.
8648         (target_program_signals): Likewise.
8649         * target.h (struct target_ops) <pass_signals, program_signals>:
8650         Constify argument.
8651         (target_pass_signals, target_program_signals): Constify argument.
8652
8653 2019-01-14  Tom Tromey  <tom@tromey.com>
8654
8655         PR tui/28819:
8656         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8657
8658 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8659
8660         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8661         field.
8662         * rs6000-tdep.c: Include reggroups.h.
8663         (IS_V_ALIAS_PSEUDOREG): Define.
8664         (rs6000_register_name): Return names for the "vX" aliases.
8665         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8666         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8667         aliases.  Call default_register_reggroup_p for all other
8668         pseudo-registers.
8669         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8670         New functions.
8671         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8672         Handle "vX" aliases.
8673         (v_alias_pseudo_register_collect): New function.
8674         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8675         (rs6000_gdbarch_init): Initialize "vX" aliases as
8676         pseudo-registers.  Restore registration of
8677         rs6000_pseudo_register_reggroup_p with
8678         set_tdesc_pseudo_register_reggroup_p.
8679
8680 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8681
8682         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8683         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8684         set_gdbarch_num_pseudo_regs.
8685
8686 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8687
8688         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8689         Remove arg prefixname, add do_set and do_show.
8690         Add member functions set_list and show_list.
8691         * cli/cli-style.c (class cli_style_option): Update accordingly.
8692         (style_set_list): Move to file scope.
8693         (style_show_list): Likewise.
8694         (set_style): Call help_list.
8695         (show_style): Call cmd_show_list.
8696         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8697         Update to use the new macro.
8698
8699 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8700
8701         * ada-lang.c (_initialize_ada_language): Expand the help text
8702         for the "catch exception" command.
8703
8704 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8705
8706         * symtab.c (matching_obj_sections): Initialize obj,
8707         declare it closer to its usage.
8708
8709 2019-01-10  Tom Tromey  <tom@tromey.com>
8710
8711         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8712         (basic_inf_threads_range): Remove.
8713         (inf_threads_range, inf_non_exited_threads_range)
8714         (safe_inf_threads_range): Use next_adapter.
8715
8716 2019-01-10  Keith Seitz  <keiths@redhat.com>
8717
8718         PR gdb/23712
8719         PR symtab/23010
8720         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8721         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8722
8723 2019-01-10  Keith Seitz  <keiths@redhat.com>
8724
8725         PR gdb/23712
8726         PR symtab/23010
8727         * dictionary.c (pending_to_vector): Remove.
8728         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8729         Remove _1 suffix, replacing functions of the same name.  Update
8730         all callers.
8731         (dict_create_hashed, dict_create_hashed_expandable)
8732         (dict_create_linear, dict_create_linear_expandable, dict_free)
8733         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8734         Make functions static.
8735
8736 2019-01-10  Keith Seitz  <keiths@redhat.com>
8737
8738         PR gdb/23712
8739         PR symtab/23010
8740         * dictionary.h (struct dictionary): Replace declaration with
8741         multidictionary.
8742         (dict_create_hashed, dict_create_hashed_expandable)
8743         (dict_create_linear, dict_create_linear_expandable)
8744         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8745         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8746         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8747         taking multidictionary argument.
8748         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8749         * block.h (struct block) <dict>: Change to multidictionary
8750         and rename `multidict'.
8751         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8752         symmisc.c: Update all dictionary references to multidictionary.
8753
8754 2019-01-10  Keith Seitz  <keiths@redhat.com>
8755
8756         PR gdb/23712
8757         PR symtab/23010
8758         * dictionary.c: Include unordered_map.
8759         (pending_to_vector): New function.
8760         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8761         Rewrite the non-"_1" functions to take vector instead
8762         of linked list.
8763         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8764         "new" _1 versions of the same name.
8765         (multidictionary): Define.
8766         (std::hash<enum language): New definition.
8767         (collate_pending_symbols_by_language, mdict_create_hashed)
8768         (mdict_create_hashed_expandable, mdict_create_linear)
8769         (mdict_create_linear_expandable, mdict_free)
8770         (find_language_dictionary, create_new_language_dictionary)
8771         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8772         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8773         (mdict_size, mdict_empty): New functions.
8774         * dictionary.h (mdict_iterator): Define.
8775
8776 2019-01-10  Pedro Alves  <palves@redhat.com>
8777
8778         * breakpoint.c (read_uploaded_action)
8779         (create_tracepoint_from_upload): Adjust to use
8780         gdb::unique_xmalloc_ptr.
8781         * ctf.c (ctf_write_uploaded_tp):
8782         (SET_ARRAY_FIELD): Use emplace_back.
8783         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8784         * tracefile-tfile.c (tfile_write_uploaded_tp):
8785         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8786         gdb::unique_xmalloc_ptr.
8787         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8788         at_string, cond_string, cmd_strings>: Replace char pointers
8789         with gdb::unique_xmalloc_ptr.
8790
8791 2019-01-10  Pedro Alves  <palves@redhat.com>
8792
8793         * solib-target.c (library_list_start_library): Don't xstrdup name.
8794
8795 2019-01-10  Pedro Alves  <palves@redhat.com>
8796
8797         * mdebugread.c (parse_partial_symbols): Use
8798         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8799
8800 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8801
8802         * linux-fork.c (scoped_switch_fork_info)
8803         <~scoped_switch_fork_info>: Fix incorrect variable name.
8804
8805 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8806
8807         * linux-fork.c (scoped_switch_fork_info)
8808         <scoped_switch_fork_info>: Make explicit.
8809         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8810
8811 2019-01-10  Tom Tromey  <tom@tromey.com>
8812
8813         * objfiles.h (objfile::reset_psymtabs): Update.
8814         * objfiles.c (objfile::objfile): Update.
8815         * psymtab.h (psymtab_storage::obstack): Update.
8816         (psymtab_storage::m_obstack): Use gdb::optional.
8817         (class psymtab_storage): Update comment.  Remove objfile
8818         parameter.
8819         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8820
8821 2019-01-10  Tom Tromey  <tom@tromey.com>
8822
8823         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8824         <free_psymtabs>: Now private.
8825         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8826         (allocate_psymtab): Use new method.
8827
8828 2019-01-10  Tom Tromey  <tom@tromey.com>
8829
8830         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8831         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8832         * mdebugread.c (parse_partial_symbols): Use
8833         allocate_dependencies.
8834         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8835         allocate_dependencies.
8836         (process_psymtab_comp_unit_reader)
8837         (build_type_psymtab_dependencies): Likewise.
8838         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8839
8840 2019-01-10  Tom Tromey  <tom@tromey.com>
8841
8842         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8843         PSYMBOL_SET_LANGUAGE.
8844         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8845
8846 2019-01-10  Tom Tromey  <tom@tromey.com>
8847
8848         * psymtab.h (psymtab_storage::obstack): New method.
8849         <m_obstack>: Rename from obstack; now private.
8850         * psymtab.c (psymtab_storage): Update.
8851         * dwarf2read.c (create_addrmap_from_index)
8852         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8853         Update.
8854
8855 2019-01-10  Tom Tromey  <tom@tromey.com>
8856
8857         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8858         * objfiles.h (objfile::reset_psymtabs): New method.
8859
8860 2019-01-10  Tom Tromey  <tom@tromey.com>
8861
8862         * symmisc.c (print_symbol_bcache_statistics): Update.
8863         (print_objfile_statistics): Update.
8864         * symfile.c (reread_symbols): Update.
8865         * psymtab.h (class psymtab_storage): New.
8866         * psymtab.c (psymtab_storage): New constructor.
8867         (~psymtab_storage): New destructor.
8868         (require_partial_symbols): Update.
8869         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8870         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8871         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8872         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8873         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8874         (start_psymtab_common, end_psymtab_common)
8875         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8876         (allocate_psymtab): Update.
8877         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8878         Update.
8879         (dump_psymtab_addrmap, maintenance_print_psymbols)
8880         (maintenance_check_psymtabs): Update.
8881         (class objfile_psymtabs): Move to objfiles.h.
8882         * psympriv.h (discard_psymtab): Now inline.
8883         (psymtab_discarder::psymtab_discarder): Update.
8884         (psymtab_discarder::~psymtab_discarder): Update.
8885         (ALL_OBJFILE_PSYMTABS): Rewrite.
8886         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8887         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8888         Remove fields.
8889         <partial_symtabs>: New field.
8890         (class objfile_psymtabs): Move from psymtab.h.  Update.
8891         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8892         psymbol_cache.
8893         (objfile::~objfile): Don't destroy psymbol_cache.
8894         * mdebugread.c (parse_partial_symbols): Update.
8895         * dwarf2read.c (create_addrmap_from_index)
8896         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8897         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8898         (add_partial_subprogram, dwarf2_ranges_read): Update.
8899         * dwarf-index-write.c (write_address_map)
8900         (write_one_signatured_type, recursively_write_psymbols)
8901         (class debug_names, class debug_names, write_psymtabs_to_index):
8902         Update.
8903
8904 2019-01-10  Tom Tromey  <tom@tromey.com>
8905
8906         * symtab.h (SYMBOL_SET_NAMES): Update.
8907         (symbol_set_names): Update.
8908         (MSYMBOL_SET_NAMES): Update.
8909         * symtab.c (symbol_set_names): Change argument to be an
8910         objfile_per_bfd_storage.
8911         * psymtab.c (add_psymbol_to_bcache): Update.
8912         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8913
8914 2019-01-10  Tom Tromey  <tom@tromey.com>
8915
8916         * symtab.c (create_demangled_names_hash): Change argument to be an
8917         objfile_per_bfd_storage.
8918         (symbol_set_names): Update.
8919
8920 2019-01-10  Tom Tromey  <tom@tromey.com>
8921
8922         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8923         init_psymbol_list.
8924         * psymtab.c (init_psymbol_list): Do nothing if already called.
8925         * psympriv.h (init_psymbol_list): Add comment.
8926         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8927         init_psymbol_list.
8928         * dbxread.c (dbx_symfile_read): Unconditionally call
8929         init_psymbol_list.
8930
8931 2019-01-10  Tom Tromey  <tom@tromey.com>
8932
8933         * xcoffread.c (scan_xcoff_symtab): Update.
8934         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8935         "where".
8936         * mdebugread.c (parse_partial_symbols)
8937         (handle_psymbol_enumerators): Update.
8938         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8939         * dbxread.c (read_dbx_symtab): Update.
8940         * psympriv.h (psymbol_placement): New enum.
8941         (add_psymbol_to_list): Update.
8942
8943 2019-01-10  Tom Tromey  <tom@tromey.com>
8944
8945         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8946         static_psymbols parameters.
8947         (scan_xcoff_symtab): Update.
8948         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8949         static_psymbols parameters.
8950         * psympriv.h (start_psymtab_common): Update.
8951         * mdebugread.c (parse_partial_symbols): Update.
8952         * dwarf2read.c (create_partial_symtab): Update.
8953         * dbxread.c (read_dbx_symtab): Update.
8954         (start_psymtab): Remove global_psymbols and static_psymbols
8955         parameters.
8956
8957 2019-01-10  Tom Tromey  <tom@tromey.com>
8958
8959         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8960         * psymtab.c (allocate_psymtab): Add comment.
8961         * psympriv.h (allocate_psymtab): Add comment.
8962         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8963         initializations.
8964         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8965
8966 2019-01-10  Tom Tromey  <tom@tromey.com>
8967
8968         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8969         Don't declare.
8970         * mipsread.c: Include mdebugread.h.
8971         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8972         Declare.
8973         * elfread.c: Include mdebugread.h.
8974
8975 2019-01-09  Tom Tromey  <tom@tromey.com>
8976
8977         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8978         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8979         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8980         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8981         (psym_lookup_symbol, psym_find_last_source_symtab)
8982         (psym_forget_cached_source_info, psym_print_stats)
8983         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8984         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8985         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8986         (psym_find_compunit_symtab_by_address)
8987         (maintenance_print_psymbols, maintenance_info_psymtabs)
8988         (maintenance_check_psymtabs): Use ranged for.
8989         * psymtab.h (class objfile_psymtabs): New.
8990         (require_partial_symbols): Return objfile_psymtabs.
8991         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8992
8993 2019-01-09  Tom Tromey  <tom@tromey.com>
8994
8995         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8996         (find_pc_mapped_section, list_overlays_command)
8997         (map_overlay_command, unmap_overlay_command)
8998         (simple_overlay_update): Use all_objfiles.
8999         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9000         * printcmd.c (info_symbol_command): Use all_objfiles.
9001         * objfiles.h (ALL_OBJSECTIONS): Remove.
9002         * maint.c (maintenance_translate_address): Use all_objfiles.
9003         * gcore.c (gcore_create_callback): Use all_objfiles.
9004         (objfile_find_memory_regions): Likewise.
9005
9006 2019-01-09  Tom Tromey  <tom@tromey.com>
9007
9008         * symtab.c (find_line_symtab, info_sources_command)
9009         (make_source_files_completion_list): Use objfile_compunits.
9010         * source.c (select_source_symtab): Use objfile_compunits.
9011         * objfiles.h (struct objfile): Update comment.
9012         (ALL_OBJFILES): Remove.
9013         (ALL_FILETABS): Remove.
9014         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9015         objfile_compunits.
9016
9017 2019-01-09  Tom Tromey  <tom@tromey.com>
9018
9019         * symmisc.c (print_objfile_statistics, dump_objfile)
9020         (maintenance_print_symbols): Use compunit_filetabs.
9021         * source.c (forget_cached_source_info_for_objfile): Use
9022         compunit_filetabs.
9023         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9024         (ALL_FILETABS): Use compunit_filetabs.
9025         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9026         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9027
9028 2019-01-09  Tom Tromey  <tom@tromey.com>
9029
9030         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9031         (compunit_filetabs): New.
9032         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9033         compunit_filetabs.
9034         (info_sources_command, make_source_files_completion_list): Remove
9035         declaration.
9036         * symmisc.c (print_objfile_statistics, dump_objfile)
9037         (maintenance_print_symbols): Remove declaration.
9038         (maintenance_info_symtabs): Use compunit_filetabs.
9039         (maintenance_info_line_tables): Likewise.
9040         * source.c (select_source_symtab): Change local variable name.
9041         (forget_cached_source_info_for_objfile): Remove declaration.
9042         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9043         * objfiles.c (objfile_relocate1): Remove declaration.
9044         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9045         declaration.
9046         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9047         * coffread.c (coff_symtab_read): Remove declaration.
9048         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9049         compunit_filetabs.
9050
9051 2019-01-09  Tom Tromey  <tom@tromey.com>
9052
9053         * symtab.c (lookup_objfile_from_block)
9054         (find_pc_sect_compunit_symtab, search_symbols)
9055         (default_collect_symbol_completion_matches_break_on): Use
9056         objfile_compunits.
9057         * objfiles.h (ALL_COMPUNITS): Remove.
9058         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9059         * cp-support.c (add_symbol_overload_list_qualified): Use
9060         objfile_compunits.
9061         * ada-lang.c (ada_collect_symbol_completion_matches)
9062         (ada_add_global_exceptions): Use objfile_compunits.
9063
9064 2019-01-09  Tom Tromey  <tom@tromey.com>
9065
9066         * source.c (select_source_symtab)
9067         (forget_cached_source_info_for_objfile): Remove declaration.
9068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9069         declaration.
9070         * maint.c (count_symtabs_and_blocks): Remove declaration.
9071         * cp-support.c (add_symbol_overload_list_qualified): Remove
9072         declaration.
9073         * coffread.c (coff_symtab_read): Remove declaration.
9074         * symtab.c (lookup_symbol_in_objfile_symtabs)
9075         (basic_lookup_transparent_type_1): Use objfile_compunits.
9076         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9077         (info_sources_command, search_symbols)
9078         (default_collect_symbol_completion_matches_break_on)
9079         (make_source_files_completion_list): Remove declaration.
9080         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9081         (ada_collect_symbol_completion_matches)
9082         (ada_add_global_exceptions): Remove declaration.
9083         * linespec.c (iterate_over_all_matching_symtabs): Use
9084         objfile_compunits.
9085         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9086         (class objfile_compunits): New.
9087         (ALL_COMPUNITS): Use objfile_compunits.
9088         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9089         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9090         objfile_compunits.
9091         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9092
9093 2019-01-09  Tom Tromey  <tom@tromey.com>
9094
9095         * symtab.c (search_symbols)
9096         (default_collect_symbol_completion_matches_break_on): Use
9097         objfile_msymbols.
9098         * ada-lang.c (ada_lookup_simple_minsym)
9099         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9100         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9101         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9102         objfile_msymbols.
9103         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9104         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9105         * objc-lang.c (find_methods): Use objfile_msymbols.
9106         (info_selectors_command, info_classes_command): Likewise.
9107         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9108         * objfiles.h (class objfile_msymbols): New.
9109         (ALL_OBJFILE_MSYMBOLS): Remove.
9110         (ALL_MSYMBOLS): Remove.
9111
9112 2019-01-09  Tom Tromey  <tom@tromey.com>
9113
9114         * common/next-iterator.h (next_adapter): Add Iterator template
9115         parameter.
9116         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9117         (class all_objfiles_safe): New.
9118         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9119         * objfiles.c (put_objfile_before): Update comment.
9120         (add_separate_debug_objfile): Likewise.
9121         (free_all_objfiles): Use all_objfiles_safe.
9122         (objfile_purge_solibs): Likewise.
9123
9124 2019-01-09  Tom Tromey  <tom@tromey.com>
9125
9126         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9127         (expand_symtab_containing_pc, lookup_static_symbol)
9128         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9129         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9130         all_objfiles.
9131         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9132         * breakpoint.c (create_overlay_event_breakpoint)
9133         (create_longjmp_master_breakpoint)
9134         (create_std_terminate_master_breakpoint)
9135         (create_exception_master_breakpoint): Use all_objfiles.
9136         * linux-thread-db.c (try_thread_db_load_from_pdir)
9137         (has_libpthread): Use all_objfiles.
9138         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9139         * linespec.c (iterate_over_all_matching_symtabs)
9140         (search_minsyms_for_name): Use all_objfiles.
9141         * maint.c (maintenance_info_sections): Use all_objfiles.
9142         * main.c (captured_main_1): Use all_objfiles.
9143         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9144         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9145         * guile/scm-pretty-print.c
9146         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9147         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9148         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9149         (maintenance_print_msymbols): Use all_objfiles.
9150         * source.c (select_source_symtab): Use all_objfiles.
9151         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9152         * symfile.c (remove_symbol_file_command)
9153         (expand_symtabs_matching, map_symbol_filenames): Use
9154         all_objfiles.
9155         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9156         all_objfiles.
9157         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9158         * objc-lang.c (find_methods): Use all_objfiles.
9159         * objfiles.c (have_partial_symbols, have_full_symbols)
9160         (have_minimal_symbols, qsort_cmp)
9161         (default_iterate_over_objfiles_in_search_order): Use
9162         all_objfiles.
9163         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9164         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9165         (maintenance_check_psymtabs): Use all_objfiles.
9166         (ALL_PSYMTABS): Remove.
9167         * compile/compile-object-run.c (do_module_cleanup): Use
9168         all_objfiles.
9169         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9170         * cp-support.c (add_symbol_overload_list_qualified): Use
9171         all_objfiles.
9172         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9173         Use all_objfiles.
9174         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9175         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9176         all_objfiles.
9177         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9178         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9179         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9180         Uses all_objfiles.
9181         * solib.c (solib_read_symbols): Use all_objfiles
9182
9183 2019-01-09  Tom Tromey  <tom@tromey.com>
9184
9185         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9186         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9187         all_objfiles.
9188         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9189         * symmisc.c (print_symbol_bcache_statistics)
9190         (print_objfile_statistics, maintenance_print_objfiles)
9191         (maintenance_info_symtabs, maintenance_check_symtabs)
9192         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9193         all_objfiles.
9194         * source.c (forget_cached_source_info): Use all_objfiles.
9195         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9196         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9197         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9198         * objfiles.c (update_section_map): Use all_objfiles.
9199         (shared_objfile_contains_address_p): Likewise.
9200         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9201         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9202
9203 2019-01-09  Tom Tromey  <tom@tromey.com>
9204
9205         * common/next-iterator.h: New file.
9206         * objfiles.h (class all_objfiles): New.
9207         (struct objfile_iterator): New.
9208
9209 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9210
9211         * NEWS: Move the description of the changed "frame", "select-frame",
9212          and "info frame" commands to the Changed commands section.
9213
9214 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9215
9216         * gdbtypes.c (check_stub_method_group): Remove handling of old
9217         mangling schemes.
9218         * linespec.c (find_methods): Likewise.
9219         * stabsread.c (read_member_functions): Likewise.
9220         * valops.c (search_struct_method): Likewise.
9221         (value_struct_elt_for_reference): Likewise.
9222         * NEWS: Mention this change.
9223
9224 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9227         print_source_lines.
9228         * source.c (print_source_lines_base): Update line number check.
9229         (print_source_lines): New function.
9230         (source_lines_range::source_lines_range): New function.
9231         * source.h (class source_lines_range): New class.
9232         (print_source_lines): New declaration.
9233
9234 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9235
9236         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9237
9238 2019-01-08  Tom Tromey  <tom@tromey.com>
9239             Simon Marchi  <simon.marchi@ericsson.com>
9240
9241         PR gdb/24060
9242         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9243         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9244         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9245         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9246         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9247         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9248
9249 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * source.c (select_source_symtab): Move header comment to
9252         declaration in source.h.
9253         (forget_cached_source_info_for_objfile): Likewise.
9254         (forget_cached_source_info): Likewise.
9255         (identify_source_line): Likewise.
9256         * source.h (identify_source_line): Move declaration from symtab.h
9257         and add comment from source.c
9258         (print_source_lines): Likewise.
9259         (forget_cached_source_info_for_objfile): Likewise.
9260         (forget_cached_source_info): Likewise.
9261         (select_source_symtab): Likewise.
9262         (enum print_source_lines_flag): Move definition from symtab.h.
9263         * symtab.h (identify_source_line): Move declaration to source.h.
9264         (print_source_lines): Likewise.
9265         (forget_cached_source_info_for_objfile): Likewise.
9266         (forget_cached_source_info): Likewise.
9267         (select_source_symtab): Likewise.
9268         (enum print_source_lines_flag): Move definition to source.h.
9269         * tui/tui-hooks.c: Add 'source.h' include.
9270
9271 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * source.c (print_source_lines_base): Handle requests to print
9274         reverse line number sequences, and guard against empty lines
9275         string.
9276
9277 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9278
9279         * source.c (print_source_lines_base): Fix skip of '\r' if next
9280         character is '\n'.
9281
9282 2019-01-06  Tom Tromey  <tom@tromey.com>
9283
9284         * c-exp.y (struct c_parse_state) <macro_original_text,
9285         expansion_obstack>: New member.
9286         (macro_original_text, expansion_obstack): Remove globals.
9287         (scan_macro_expansion, scanning_macro_expansion)
9288         (finished_macro_expansion): Update.
9289         (scan_macro_cleanup): Remove.
9290         (yylex, c_parse): Update.
9291
9292 2019-01-06  Tom Tromey  <tom@tromey.com>
9293
9294         * c-exp.y (struct c_parse_state) <strings>: New member.
9295         (operator_stoken): Update.
9296
9297 2019-01-06  Tom Tromey  <tom@tromey.com>
9298
9299         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9300         (union type_stack_elt) <typelist_val>: Now a pointer to
9301         std::vector.
9302         (type_stack_cleanup): Don't declare.
9303         (push_typelist): Update.
9304         * parse.c (pop_typelist): Return a std::vector.
9305         (push_typelist): Take a std::vector.
9306         (follow_types): Update.  Do not free args.
9307         (type_stack_cleanup): Remove.
9308         * c-exp.y (struct c_parse_state): New.
9309         (cpstate): New global.
9310         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9311         (nonempty_typelist): Update.
9312         (func_mod): Create a new vector.
9313         (c_parse): Create a c_parse_state.
9314         (check_parameter_typelist): Do not delete params.
9315         (function_method): Update.  Do not delete type_list.
9316
9317 2019-01-06  Tom Tromey  <tom@tromey.com>
9318
9319         PR gdb/28155:
9320         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9321         check_typedef.
9322         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9323         (print_return_value): Likewise.
9324
9325 2019-01-05  Tom Tromey  <tom@tromey.com>
9326
9327         * contrib/cleanup_check.py: Remove.
9328         * contrib/gcc-with-excheck: Remove.
9329         * contrib/exsummary.py: Remove.
9330         * contrib/excheck.py: Remove.
9331
9332 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9333
9334         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9335         NULL. Initialize tpprev to NULL instead of assigning it
9336         to NULL on the next statement.
9337         * windows-nat.c (windows_delete_thread): Remove check for
9338         main_thread_id before printing thread exit notifications.
9339         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9340         Remove thread ID check against main_thread_id.
9341         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9342         windows_delete_thread.
9343         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9344
9345 2019-01-04  Tom Tromey  <tom@tromey.com>
9346
9347         * compile/compile.c (_initialize_compile): Use upper case for
9348         metasyntactic variables.
9349         * symmisc.c (_initialize_symmisc): Use upper case for
9350         metasyntactic variables.
9351         * psymtab.c (_initialize_psymtab): Use upper case for
9352         metasyntactic variables.
9353         * demangle.c (demangle_command): Use upper case for metasyntactic
9354         variables.
9355         (_initialize_demangler): Likewise.
9356         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9357         variables.
9358
9359 2019-01-03  Tom Tromey  <tom@tromey.com>
9360
9361         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9362
9363 2019-01-03  Tom Tromey  <tom@tromey.com>
9364
9365         * python/py-symtab.c (salpy_str): Update.
9366         (struct salpy_sal_object) <symtab>: Now a PyObject.
9367         (salpy_dealloc): Update.
9368         (del_objfile_sal): Use gdbpy_ref.
9369
9370 2019-01-03  Tom Tromey  <tom@tromey.com>
9371
9372         * python/py-type.c (convert_field): Use new_reference.  Return
9373         gdbpy_ref.
9374         (make_fielditem): Return gdbpy_ref.
9375         (typy_fields): Update.
9376         (typy_getitem): Update.
9377         (field_name): Return gdbpy_ref.  Use new_reference.
9378         (typy_iterator_iternext): Update.
9379
9380 2019-01-03  Tom Tromey  <tom@tromey.com>
9381
9382         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9383
9384 2019-01-03  Tom Tromey  <tom@tromey.com>
9385
9386         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9387         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9388         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9389         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9390         (pspy_set_type_printers): Likewise.
9391         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9392         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9393         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9394         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9395         (objfpy_set_type_printers): Likewise.
9396
9397 2019-01-03  Tom Tromey  <tom@tromey.com>
9398
9399         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9400         (gdbpy_print_stack): Use gdbpy_err_fetch.
9401         * python/python-internal.h (class gdbpy_err_fetch): New class.
9402         (class gdbpy_enter) <m_error_type, m_error_value,
9403         m_error_traceback>: Remove.
9404         <m_error>: New member.
9405         (gdbpy_exception_to_string): Don't declare.
9406         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9407         * python/py-value.c (convert_value_from_python): Use
9408         gdbpy_err_fetch.
9409         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9410         gdbpy_exception_to_string.
9411         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9412         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9413         gdbpy_err_fetch.
9414
9415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9416
9417         * linux-nat.c (delete_lwp_cleanup): Delete.
9418         (struct lwp_deleter): New struct.
9419         (lwp_info_up): New typedef.
9420         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9421         lwp_info_up.
9422
9423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9424
9425         * linux-fork.c (class scoped_switch_fork_info): New class.
9426         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9427
9428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9429
9430         * valops.c (find_overload_match): Remove use of null_cleanup, and
9431         calls to do_cleanups.
9432
9433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9434
9435         * compile/compile-cplus-types.c
9436         (compile_cplus_instance::decl_name): Handle changes to
9437         cp_func_name.
9438         * cp-support.c (cp_func_name): Update header comment, update
9439         return type.
9440         * cp-support.h (cp_func_name): Update return type in declaration.
9441         * valops.c (find_overload_match): Move temp_func local to top
9442         level of function and change its type.  Use temp_func to hold and
9443         delete temporary string obtained from cp_func_name.
9444
9445 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9446
9447         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9448         gdb::char_vector, remove cleanup, and update uses of `msg`.
9449
9450 2019-01-03  Jim Wilson  <jimw@sifive.com>
9451
9452         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9453
9454 2019-01-02  Tom Tromey  <tom@tromey.com>
9455
9456         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9457         (tdesc_parse_xml): Remove cleanups.
9458         * target-descriptions.h (make_cleanup_free_target_description):
9459         Don't declare.
9460         (target_desc_deleter): New struct.
9461         (target_desc_up): New typedef.
9462         * target-descriptions.c (target_desc_deleter::operator()): Rename
9463         from free_target_description.
9464         (make_cleanup_free_target_description): Remove.
9465
9466 2019-01-02  Tom Tromey  <tom@tromey.com>
9467
9468         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9469         constructor, destructor.
9470         (linespec_parser): Remove typedef.
9471         (~linespec_parser): Rename from linespec_parser_delete.
9472         (linespec_lex_to_end, linespec_complete_label)
9473         (linespec_complete): Update.
9474         (decode_line_full): Remove cleanups.
9475         (decode_line_1): Update.
9476
9477 2019-01-02  Tom Tromey  <tom@tromey.com>
9478
9479         * python/python-internal.h (inferior_to_inferior_object): Change
9480         return type.
9481         * python/py-exitedevent.c (create_exited_event_object): Update.
9482         * python/py-inferior.c (inferior_to_inferior_object): Return
9483         gdbpy_ref.
9484         (python_new_inferior, python_inferior_deleted)
9485         (thread_to_thread_object, delete_thread_object)
9486         (build_inferior_list, gdbpy_selected_inferior): Update.
9487         * python/py-infthread.c (create_thread_object): Update.  Also fail
9488         if inferior_to_inferior_object fails.
9489
9490 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9491
9492         * inferior.h (class inferior) <displaced_step_state>: New field.
9493         * infrun.h (struct displaced_step_state): Move here from
9494         infrun.c.  Initialize fields, add constructor.
9495         <inf>: Remove field.
9496         <reset>: New method.
9497         * infrun.c (struct displaced_step_inferior_state): Move to
9498         infrun.h.
9499         (displaced_step_inferior_states): Remove.
9500         (get_displaced_stepping_state): Adust.
9501         (displaced_step_in_progress_any_inferior): Adjust.
9502         (displaced_step_in_progress_thread): Adjust.
9503         (displaced_step_in_progress): Adjust.
9504         (add_displaced_stepping_state): Remove.
9505         (get_displaced_step_closure_by_addr): Adjust.
9506         (remove_displaced_stepping_state): Remove.
9507         (infrun_inferior_exit): Call displaced_step_state.reset.
9508         (use_displaced_stepping): Don't check for NULL.
9509         (displaced_step_prepare_throw): Call
9510         get_displaced_stepping_state.
9511         (displaced_step_fixup): Don't check for NULL.
9512         (prepare_for_detach): Don't check for NULL.
9513
9514 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9515
9516         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9517          in case of call that did not complete.
9518
9519 2019-01-02  Andrey Utkin  <autkin@undo.io>
9520
9521         * symfile.c (find_separate_debug_file): Fix search of debug files for
9522         remote debuggee.
9523
9524 2019-01-02  Tom Tromey  <tom@tromey.com>
9525
9526         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9527         indentation.
9528         * python/py-frame.c (frapy_older): Remove cast.
9529         (frapy_newer): Likewise.
9530         * python/py-breakpoint.c (local_setattro): Remove cast.
9531         * python/py-arch.c (archpy_name): Remove local variable.
9532         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9533
9534 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9535
9536         * unittests/basic_string_view/element_access/char/empty.cc:
9537         Fix year range in copyright header.
9538
9539 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9540
9541         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9542         Delete.
9543         <operator==>: Update with for removed field.
9544         <hash>: Likewise.
9545         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9546         <isa_features>: ...this.
9547         <abi_features>: New field.
9548         (riscv_isa_flen): Update comment.
9549         (riscv_abi_xlen): New declaration.
9550         (riscv_abi_flen): New declaration.
9551         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9552         isa_features.
9553         (riscv_abi_xlen): New function.
9554         (riscv_isa_flen): Update to get answer from isa_features.
9555         (riscv_abi_flen): New function.
9556         (riscv_has_fp_abi): Update to get answer from abi_features.
9557         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9558         xlen and flen.
9559         (riscv_call_info) <xlen, flen>: Update comment.
9560         (riscv_call_arg_struct): Remove invalid assertions
9561         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9562         is removed.
9563         (riscv_gdbarch_init): Gather isa features and abi features
9564         separately, ensure both match on the gdbarch when reusing an old
9565         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9566         a target with 64-bit float hardware.
9567
9568 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9569
9570         * source.c (search_command_helper): Stop reverse search
9571         when line 1 has been searched.
9572
9573 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9574
9575         * record-full.c (record_full_base_target::close): Rewrite
9576         record_full_core_buf_list free logic.
9577
9578 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9579
9580         * break-catch-syscall.c (print_one_catch_syscall): xfree
9581         the last text.
9582
9583 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9584
9585         * top.c (print_gdb_version): Update Copyright year in version
9586         message.
9587
9588 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9589
9590         Update copyright year range in all GDB files.
9591
9592 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9593
9594         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9595
9596 For older changes see ChangeLog-2018.
9597 \f
9598 Local Variables:
9599 mode: change-log
9600 left-margin: 8
9601 fill-column: 74
9602 version-control: never
9603 coding: utf-8
9604 End:
9605