gdb/ChangeLog

   1 2019-09-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-source.c (tui_source_window::set_contents): Use
   4         make_unique_xstrdup.
   5         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
   6         make_unique_xstrdup.
   7
   8 2019-09-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-data.c: Remove separator comments.
  11         * tui/tui-layout.c: Remove separator comments.
  12         * tui/tui-win.c: Remove separator comments.
  13         * tui/tui-wingeneral.c: Remove separator comments.
  14
  15 2019-09-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui.h (strcat_to_buf): Don't declare.
  18         * tui/tui.c (strcat_to_buf): Remove.
  19
  20 2019-09-20  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
  23         from "fullname".
  24         * tui/tui-source.c (tui_source_window::set_contents)
  25         (tui_source_window::location_matches_p)
  26         (tui_source_window::maybe_update): Update.
  27
  28 2019-09-20  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
  31         Update.
  32         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
  33         prefix.
  34         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  35         (tui_data_window::line_from_reg_element_no)
  36         (tui_data_window::first_reg_element_no_inline)
  37         (tui_data_window::show_registers)
  38         (tui_data_window::show_register_group)
  39         (tui_data_window::display_registers_from)
  40         (tui_data_window::display_registers_from_line)
  41         (tui_data_window::first_data_item_displayed)
  42         (tui_data_window::delete_data_content_windows)
  43         (tui_data_window::erase_data_content)
  44         (tui_data_window::do_scroll_vertical)
  45         (tui_data_window::refresh_window)
  46         (tui_data_window::check_register_values): Update.
  47
  48 2019-09-20  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
  51         (struct tui_locator_window) <full_name, proc_name>: Now
  52         std::string.
  53         * tui/tui-stack.c (tui_locator_window::make_status_line)
  54         (tui_locator_window::set_locator_fullname)
  55         (tui_locator_window::set_locator_info): Update.
  56         * tui/tui-source.c (tui_source_window::set_contents)
  57         (tui_source_window::showing_source_p): Update.
  58
  59 2019-09-20  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  62         Don't call tui_locator_win_info_ptr.
  63
  64 2019-09-20  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-win.c (tui_resize_all): Don't call refresh.
  67
  68 2019-09-20  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
  71         height for locator.
  72         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
  73         * tui/tui-layout.c (show_source_disasm_command, show_data)
  74         (show_source_or_disasm_and_command): Use 1 as height for locator.
  75
  76 2019-09-20  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui.c (tui_enable): Update.
  79         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
  80         Update.
  81         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
  82         Update.
  83         * tui/tui-data.c (win_resized): Now bool.
  84         (tui_win_resized): Return bool.
  85         (tui_set_win_resized_to): Accept a bool.
  86
  87 2019-09-20  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
  90         Change type of "refresh_values_only".
  91         * tui/tui-regs.c (tui_data_window::show_register_group): Change
  92         type of "refresh_values_only".
  93
  94 2019-09-20  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
  97         std::string.
  98         (tui_disassemble): Add "pos" parameter.
  99         (tui_disasm_window::set_contents): Simplify.
 100
 101 2019-09-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-winsource.h (struct tui_source_window_base)
 104         <show_source_content>: Now private.
 105         * tui/tui-winsource.c
 106         (tui_source_window_base::show_source_content): Don't handle empty
 107         content case.
 108
 109 2019-09-20  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-layout.c (show_source_disasm_command)
 112         (show_source_or_disasm_and_command): Don't call
 113         show_source_content.
 114
 115 2019-09-20  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 118         Declare.
 119         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 120         from tui_make_status_line.
 121         (tui_locator_window::rerender): Update.
 122
 123 2019-09-20  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 126         (tui_locator_window::rerender): Update.
 127
 128 2019-09-20  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.h (struct tui_source_window_base)
 131         <~tui_source_window_base>: Don't declare.
 132         <fullname>: Remove.
 133         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 134         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 135         member.
 136         * tui/tui-source.c (tui_source_window::set_contents): Update.
 137         (tui_source_window::location_matches_p)
 138         (tui_source_window::maybe_update): Update.
 139
 140 2019-09-20  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-winsource.h (~tui_source_element): Remove.
 143         (tui_source_element): Update.
 144         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 145         * tui/tui-winsource.c (tui_show_source_line): Update.
 146         * tui/tui-source.c (tui_source_window::set_contents): Update.
 147         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 148
 149 2019-09-20  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 152         declare.
 153         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 154         tui_clear_source_windows_detail.
 155         * tui/tui-winsource.h (struct tui_source_window_base)
 156         <clear_detail>: Don't declare.
 157         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 158         Remove.
 159         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 160
 161 2019-09-20  Tom Tromey  <tromey@adacore.com>
 162
 163         PR ada/24919:
 164         * block.c (contained_in): Fix final return value.
 165
 166 2019-09-20  Alan Modra  <amodra@gmail.com>
 167
 168         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 169         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 170         (read_indirect_string_from_dwz): Use bfd accessor.
 171         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 172         * machoread.c (macho_symfile_read_all_oso): Likewise.
 173         * solib.c (solib_bfd_open): Likewise.
 174
 175 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * eval.c: Move declaration of overload_resolution to...
 178         * value.h: ...here.
 179
 180 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 181
 182         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 183         * arm-linux-tdep.c: Likewise.
 184         * arm-nbsd-nat.c: Likewise.
 185         * arm-tdep.h: Declare arm_apcs_32.
 186         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 187
 188 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 191         * dwarf2read.h: Declare dwarf_always_disassemble.
 192
 193 2019-09-19  Tom de Vries  <tdevries@suse.de>
 194
 195         PR gdb/25009
 196         * source-cache.c (source_cache::ensure): Catch exception thrown during
 197         construction of the highlighter.
 198
 199 2019-09-18  Alan Modra  <amodra@gmail.com>
 200
 201         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 202         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 203         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 204         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 205         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 206         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 207         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 208         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 209         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 210         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 211         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 212         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 213         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 214         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 215         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 216         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 217         * mi/mi-interp.c: Update throughout for bfd section macro and
 218         function changes.
 219         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 220         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 221
 222 2019-09-18  Tom Tromey  <tom@tromey.com>
 223
 224         * NEWS: Add entry.
 225         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 226         call rl_initialize.
 227         (tui_enable): Do not call rl_initialize.
 228
 229 2019-09-18  Christian Groessler  <chris@groessler.org>
 230
 231         * alpha-linux-nat.c: Include gdbarch.h.
 232
 233 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 234
 235         * ui-file.c: Include cli/cli-style.h.
 236         (term_cli_styling): Remove cli_styling declaration.
 237
 238 2019-09-18  Alan Modra  <amodra@gmail.com>
 239
 240         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 241         to bfd_asymbol_section.
 242
 243 2019-09-18  Alan Modra  <amodra@gmail.com>
 244
 245         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 246         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 247         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 248
 249 2019-09-18  Alan Modra  <amodra@gmail.com>
 250
 251         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 252         * spu-linux-nat.c (spu_bfd_open): Likewise.
 253
 254 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 255
 256         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 257         to bool to match definition in dwarf2read.c.
 258
 259 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 260
 261         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 262         (print_signatures): Likewise.
 263         (trust_pad_over_xvs): Likewise.
 264         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 265         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 266         * arm-linux-nat.c (arm_apcs_32): Likewise.
 267         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 268         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 269         * arm-tdep.c (arm_debug): Likewise.
 270         (arm_apcs_32): Likewise.
 271         * auto-load.c (debug_auto_load): Likewise.
 272         (auto_load_gdb_scripts): Likewise.
 273         (global_auto_load): Likewise.
 274         (auto_load_local_gdbinit): Likewise.
 275         (auto_load_local_gdbinit_loaded): Likewise.
 276         * auto-load.h (global_auto_load): Likewise.
 277         (auto_load_local_gdbinit): Likewise.
 278         (auto_load_local_gdbinit_loaded): Likewise.
 279         * breakpoint.c (disconnected_dprintf): Likewise.
 280         (breakpoint_proceeded): Likewise.
 281         (automatic_hardware_breakpoints): Likewise.
 282         (always_inserted_mode): Likewise.
 283         (target_exact_watchpoints): Likewise.
 284         (_initialize_breakpoint): Update.
 285         * breakpoint.h (target_exact_watchpoints): Change to bool.
 286         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 287         * cli/cli-cmds.c (trace_commands): Likewise.
 288         * cli/cli-cmds.h (trace_commands): Likewise.
 289         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 290         to bool*.
 291         * cli/cli-logging.c (logging_overwrite): Change to bool.
 292         (logging_redirect): Likewise.
 293         (debug_redirect): Likewise.
 294         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 295         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 296         to bool.
 297         <boolean_option_def>: Update.
 298         (struct flag_option_def): Change default type of Context to bool
 299         from int.
 300         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 301         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 302         (get_setshow_command_value_string): Likewise.
 303         * cli/cli-style.c (cli_styling): Change to bool.
 304         (source_styling): Likewise.
 305         * cli/cli-style.h (source_styling): Likewise.
 306         (cli_styling): Likewise.
 307         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 308         to bool.
 309         * command.h (var_types): Update comment.
 310         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 311         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 312         bool.
 313         (debug_compile_cplus_scopes): Likewise.
 314         * compile/compile-internal.h (compile_debug): Likewise.
 315         * compile/compile.c (compile_debug): Likewise.
 316         (struct compile_options) <raw>: Likewise.
 317         * cp-support.c (catch_demangler_crashes): Likewise.
 318         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 319         (usr_cmd_cris_dwarf2_cfi): Likewise.
 320         * csky-tdep.c (csky_debug): Likewise.
 321         * darwin-nat.c (enable_mach_exceptions): Likewise.
 322         * dcache.c (dcache_enabled_p): Likewise.
 323         * defs.h (info_verbose): Likewise.
 324         * demangle.c (demangle): Likewise.
 325         (asm_demangle): Likewise.
 326         * dwarf-index-cache.c (debug_index_cache): Likewise.
 327         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 328         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 329         * dwarf2read.c (check_physname): Likewise.
 330         (use_deprecated_index_sections): Likewise.
 331         (dwarf_always_disassemble): Likewise.
 332         * eval.c (overload_resolution): Likewise.
 333         * event-top.c (set_editing_cmd_var): Likewise.
 334         (exec_done_display_p): Likewise.
 335         * event-top.h (set_editing_cmd_var): Likewise.
 336         (exec_done_display_p): Likewise.
 337         * exec.c (write_files): Likewise.
 338         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 339         (debug_fbsd_nat): Likewise.
 340         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 341         Likewise.
 342         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 343         <backtrace_past_entry> Likewise.
 344         * gdb-demangle.h (demangle): Likewise.
 345         (asm_demangle): Likewise.
 346         * gdb_bfd.c (bfd_sharing): Likewise.
 347         * gdbcore.h (write_files): Likewise.
 348         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 349         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 350         * gdbthread.h (print_thread_events): Likewise.
 351         * gdbtypes.c (opaque_type_resolution): Likewise.
 352         (strict_type_checking): Likewise.
 353         * gnu-nat.c (gnu_debug_flag): Likewise.
 354         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 355         * guile/scm-param.c (pascm_variable): Add boolval.
 356         (add_setshow_generic): Update.
 357         (pascm_param_value): Update.
 358         (pascm_set_param_value_x): Update.
 359         * hppa-tdep.c (hppa_debug): Change to bool..
 360         * infcall.c (may_call_functions_p): Likewise.
 361         (coerce_float_to_double_p): Likewise.
 362         (unwind_on_signal_p): Likewise.
 363         (unwind_on_terminating_exception_p): Likewise.
 364         * infcmd.c (startup_with_shell): Likewise.
 365         * inferior.c (print_inferior_events): Likewise.
 366         * inferior.h (startup_with_shell): Likewise.
 367         (print_inferior_events): Likewise.
 368         * infrun.c (step_stop_if_no_debug): Likewise.
 369         (detach_fork): Likewise.
 370         (debug_displaced): Likewise.
 371         (disable_randomization): Likewise.
 372         (non_stop): Likewise.
 373         (non_stop_1): Likewise.
 374         (observer_mode): Likewise.
 375         (observer_mode_1): Likewise.
 376         (set_observer_mode): Update.
 377         (sched_multi): Change to bool.
 378         * infrun.h (debug_displaced): Likewise.
 379         (sched_multi): Likewise.
 380         (step_stop_if_no_debug): Likewise.
 381         (non_stop): Likewise.
 382         (disable_randomization): Likewise.
 383         * linux-tdep.c (use_coredump_filter): Likewise.
 384         (dump_excluded_mappings): Likewise.
 385         * linux-thread-db.c (auto_load_thread_db): Likewise.
 386         (check_thread_db_on_load): Likewise.
 387         * main.c (captured_main_1): Update.
 388         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 389         xx2_opt, boolean_opt>: Change to bool.
 390         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 391         * maint.c (maintenance_profile_p): Likewise.
 392         (per_command_time): Likewise.
 393         (per_command_space): Likewise.
 394         (per_command_symtab): Likewise.
 395         * memattr.c (inaccessible_by_default): Likewise.
 396         * mi/mi-main.c (mi_async): Likewise.
 397         (mi_async_1): Likewise.
 398         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 399         * nat/fork-inferior.h (startup_with_shell): Likewise.
 400         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 401         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 402         * nios2-tdep.c (nios2_debug): Likewise.
 403         * or1k-tdep.c (or1k_debug): Likewise.
 404         * parse.c (parser_debug): Likewise.
 405         * parser-defs.h (parser_debug): Likewise.
 406         * printcmd.c (print_symbol_filename): Likewise.
 407         * proc-api.c (procfs_trace): Likewise.
 408         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 409         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 410         (set_parameter_value): Update.
 411         (add_setshow_generic): Update.
 412         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 413         to bool*.
 414         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 415         int*.
 416         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 417         * record-btrace.c (record_btrace_target::store_registers): Update.
 418         * record-full.c (record_full_memory_query): Change to bool.
 419         (record_full_stop_at_limit): Likewise.
 420         * record-full.h (record_full_memory_query): Likewise.
 421         * remote-notif.c (notif_debug): Likewise.
 422         * remote-notif.h (notif_debug): Likewise.
 423         * remote.c (use_range_stepping): Likewise.
 424         (interrupt_on_connect): Likewise.
 425         (remote_break): Likewise.
 426         * ser-tcp.c (tcp_auto_retry): Likewise.
 427         * ser-unix.c (serial_hwflow): Likewise.
 428         * skip.c (debug_skip): Likewise.
 429         * solib-aix.c (solib_aix_debug): Likewise.
 430         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 431         (spu_auto_flush_cache_p): Likewise.
 432         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 433         Likewise.
 434         (struct info_print_options) <quiet>: Likewise.
 435         * symfile-debug.c (debug_symfile): Likewise.
 436         * symfile.c (auto_solib_add): Likewise.
 437         (separate_debug_file_debug): Likewise.
 438         * symfile.h (auto_solib_add): Likewise.
 439         (separate_debug_file_debug): Likewise.
 440         * symtab.c (basenames_may_differ): Likewise.
 441         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 442         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 443         (struct info_types_options) <quiet>: Likewise.
 444         * symtab.h (demangle): Likewise.
 445         (basenames_may_differ): Likewise.
 446         * target-dcache.c (stack_cache_enabled_1): Likewise.
 447         (code_cache_enabled_1): Likewise.
 448         * target.c (trust_readonly): Likewise.
 449         (may_write_registers): Likewise.
 450         (may_write_memory): Likewise.
 451         (may_insert_breakpoints): Likewise.
 452         (may_insert_tracepoints): Likewise.
 453         (may_insert_fast_tracepoints): Likewise.
 454         (may_stop): Likewise.
 455         (auto_connect_native_target): Likewise.
 456         (target_stop_and_wait): Update.
 457         (target_async_permitted): Change to bool.
 458         (target_async_permitted_1): Likewise.
 459         (may_write_registers_1): Likewise.
 460         (may_write_memory_1): Likewise.
 461         (may_insert_breakpoints_1): Likewise.
 462         (may_insert_tracepoints_1): Likewise.
 463         (may_insert_fast_tracepoints_1): Likewise.
 464         (may_stop_1): Likewise.
 465         * target.h (target_async_permitted): Likewise.
 466         (may_write_registers): Likewise.
 467         (may_write_memory): Likewise.
 468         (may_insert_breakpoints): Likewise.
 469         (may_insert_tracepoints): Likewise.
 470         (may_insert_fast_tracepoints): Likewise.
 471         (may_stop): Likewise.
 472         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 473         (make_thread_apply_all_options_def_group): Change argument from int*
 474         to bool*.
 475         (thread_apply_all_command): Update.
 476         (print_thread_events): Change to bool.
 477         * top.c (confirm): Likewise.
 478         (command_editing_p): Likewise.
 479         (history_expansion_p): Likewise.
 480         (write_history_p): Likewise.
 481         (info_verbose): Likewise.
 482         * top.h (confirm): Likewise.
 483         (history_expansion_p): Likewise.
 484         * tracepoint.c (disconnected_tracing): Likewise.
 485         (circular_trace_buffer): Likewise.
 486         * typeprint.c (print_methods): Likewise.
 487         (print_typedefs): Likewise.
 488         * utils.c (debug_timestamp): Likewise.
 489         (sevenbit_strings): Likewise.
 490         (pagination_enabled): Likewise.
 491         * utils.h (sevenbit_strings): Likewise.
 492         (pagination_enabled): Likewise.
 493         * valops.c (overload_resolution): Likewise.
 494         * valprint.h (struct value_print_options) <prettyformat_arrays,
 495         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 496         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 497         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 498         Likewise.
 499         * windows-nat.c (new_console): Likewise.
 500         (cygwin_exceptions): Likewise.
 501         (new_group): Likewise.
 502         (debug_exec): Likewise.
 503         (debug_events): Likewise.
 504         (debug_memory): Likewise.
 505         (debug_exceptions): Likewise.
 506         (useshell): Likewise.
 507         * windows-tdep.c (maint_display_all_tib): Likewise.
 508         * xml-support.c (debug_xml): Likewise.
 509
 510 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 511
 512         * source.c (prepare_path_for_appending): New function.
 513         (openp): Make use of new function.
 514         (find_and_open_source): Search for the compilation directory and
 515         source file as a relative path beneath the directory search path.
 516
 517 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * source-cache.c (source_cache::get_line_charpos): Catch
 520         exceptions and return false, this matches the behaviour documented
 521         in the header file.
 522
 523 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 524
 525         * ada-tasks.c (info_task): Remove quoting of the task's name.
 526
 527 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 528
 529         * symfile.c (auto_solib_add): Replace comment with a reference
 530         to the header file.
 531
 532 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 533
 534         * NEWS: Mention that gdb can now be compiled with Python 3
 535         on Windows.
 536
 537 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 538
 539         * maint.c (maint_print_section_data::maint_print_section_data):
 540         Force use of 'float log10 (float)' by casting the argument to
 541         float.
 542
 543 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 544
 545         * maint.c: Add 'cmath' include.
 546         (struct maint_print_section_data): New structure.
 547         (print_section_index): New function.
 548         (print_bfd_section_info): Add header comment, small whitespace
 549         cleanup, and update to call new print_section_index function.
 550         (print_objfile_section_info): Likewise.
 551         (maint_obj_section_from_bfd_section): New function.
 552         (print_bfd_section_info_maybe_relocated): New function.
 553         (maintenance_info_sections): Add header comment, always use
 554         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 555
 556 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 559         inner scope, add check that the objfile has psymtabs before
 560         checking psymtabs_addrmap.
 561         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 562
 563 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 564
 565         * NEWS: Announce that Ada task names are now shown at more places,
 566         and between quotes (except in info task output).
 567         * gdb/ada-tasks.c (task_to_str): New function.
 568         (display_current_task_id): Call task_to_str.
 569         (task_command_1): Likewise.
 570         (print_ada_task_info): In non-mi mode, Properly align headers and data
 571         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 572
 573 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 574
 575         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 576         prstatus.pr_lwp.pr_info instead of making it up.
 577
 578 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * auto-load.c (auto_load_expand_dir_vars): Update.
 581         * defs.h (gdb_datadir): Change to std::string.
 582         (python_libdir): Likewise.
 583         (relocate_gdb_directory): Change return type to std::string.
 584         * guile/guile.c (gdbscm_data_directory): Update.
 585         (initialize_scheme_side): Update.
 586         * jit.c (jit_reader_dir): Change to std::string.
 587         (jit_reader_load_command): Update.
 588         * main.c (gdb_datadir): Change to std::string.
 589         (python_libdir): Likewise.
 590         (set_gdb_data_directory): Update.
 591         (relocate_path): Change to return std::string.
 592         (relocate_gdb_directory): Change to return std::string.
 593         (relocate_gdbinit_path_maybe_in_datadir): Update.
 594         (captured_main_1): Update.
 595         * python/python.c (do_start_initialization): Update.
 596         * top.c (show_gdb_datadir): Update.
 597         * xml-syscall.c (xml_init_syscalls_info): Update.
 598         (init_syscalls_info): Update.
 599
 600 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 603         out of get_init_files.
 604         (get_init_files): Update.
 605
 606 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 607
 608         * main.c (get_init_files): Change to use std::string.
 609         (captured_main_1): Update.
 610         (print_gdb_help): Update.
 611
 612 2019-09-11  Ali Tamur  <tamur@google.com>
 613
 614         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 615         implementation.
 616
 617 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 618
 619         * dbxread.c (read_dbx_symtab): Update.
 620         * dwarf2read.c (load_partial_dies): Update.
 621         * mdebugread.c (parse_partial_symbols): Update.
 622         (handle_psymbol_enumerators): Update.
 623         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 624         * psymtab.c (add_psymbol_to_bcache): Likewise.
 625         (add_psymbol_to_list): Likewise.
 626         * symtab.c (symbol_set_names): Likewise.
 627         * symtab.h (symbol_set_names): Likewise.
 628         * xcoffread.c (scan_xcoff_symtab): Update.
 629
 630 2019-09-11  Tom Tromey  <tom@tromey.com>
 631
 632         * symfile-mem.c (symbol_file_add_from_memory): Use
 633         bfd_set_filename.
 634         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 635         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 636
 637 2019-09-10  Tom Tromey  <tromey@adacore.com>
 638
 639         * dwarf-index-write.c (write_psymbols): Extend error message.
 640         (debug_names::insert): Add Ada code.
 641         (debug_names::write_psymbols): Remove Ada check.
 642         (debug_names) <m_string_obstack>: New member.
 643         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 644         (gdb_index_symbol_name_matcher::matches): Remove.
 645         (mapped_index_base::find_name_components_bounds): Add "lang"
 646         parameter.
 647         (mapped_index_base::build_name_components): Also split names
 648         according to Ada syntax.
 649         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 650         type of "match_callback".
 651         (check_match, check_find_bounds_finds)
 652         (dw2_expand_symtabs_matching): Update.
 653         (dw2_debug_names_iterator): Add new constructor.
 654         (dw2_debug_names_map_matching_symbols): New function.
 655         (dw2_debug_names_expand_symtabs_matching): Update.
 656         (dwarf2_debug_names_functions): Use
 657         dw2_debug_names_map_matching_symbols.
 658
 659 2019-09-10  Tom Tromey  <tromey@adacore.com>
 660
 661         * dwarf2read.c (dw2_get_file_names_reader): Add the
 662         CU's file name to the results.
 663
 664 2019-09-10  Tom Tromey  <tromey@adacore.com>
 665
 666         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 667         map_matching_symbols.  Update.
 668         * dwarf2read.c (dw2_map_matching_symbols): Update.
 669         * psymtab.c (match_partial_symbol): Change type; update.
 670         (psym_map_matching_symbols): Likewise.
 671         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 672         type; update.
 673         * symfile.h (struct quick_symbol_functions)
 674         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 675         Remove "match".
 676
 677 2019-09-10  Tom Tromey  <tromey@adacore.com>
 678
 679         * psymtab.c (map_block): Remove.
 680         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 681         * symtab.c (iterate_over_symbols_terminated): New function.
 682         * symtab.c (iterate_over_symbols_terminated): Declare.
 683
 684 2019-09-10  Tom Tromey  <tromey@adacore.com>
 685
 686         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 687         * language.h (struct language_defn) <la_iterate_over_symbols>:
 688         Return bool.
 689         * symtab.c (iterate_over_symbols): Return bool.
 690         * symtab.h (iterate_over_symbols): Return bool.
 691
 692 2019-09-10  Tom Tromey  <tromey@adacore.com>
 693
 694         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 695         (add_nonlocal_symbols): Update.
 696         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 697         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 698         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 699         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 700         Change type of "callback".  Remove "data".
 701
 702
 703 2019-09-09  Ali Tamur  <tamur@google.com>
 704
 705         * dwarf2read.c (comp_unit_head): Update comment.
 706         (dwarf2_dwo_name): New function declaration.
 707         (dwarf_unit_type_name): New function declaration.
 708         (read_comp_unit_head): Add support for new compilation units,
 709         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 710         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 711         (currently named as "signature") in their header. Also clarify error
 712         messages.
 713         (lookup_dwo_id): New function. Returns the dwo id of the given
 714         compile unit.
 715         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 716         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 717         functions.
 718         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 719         (dwarf2_dwo_name): Get the dwo name if present.
 720         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 721         purposes.
 722
 723 2019-09-09  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 726
 727 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 728
 729         * python/python.c (do_start_initialization): Make progname_copy static,
 730         to avoid a leak report.
 731
 732 2019-09-08  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 735
 736 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 737
 738         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 739         Change type to gdb::optional<block_enum>.
 740         (dw2_symtab_iter_init): Change block_index parameter type
 741         to gdb::optional<block_enum>.
 742         (dw2_lookup_symbol): Change block_index parameter
 743         type to block_enum.c
 744         (dw2_debug_names_lookup_symbol): Likewise.
 745         * psymtab.c (psym_lookup_symbol): Likewise.
 746         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 747         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 748         Likewise.
 749
 750 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 751
 752         * defs.h (relocate_gdb_directory): Change int to bool in
 753         signature and rename flag to relocatable.
 754         * main.c (relocate_path): Likewise.
 755         (relocate_gdb_directory): Likewise.
 756
 757 2019-09-06  Alan Modra  <amodra@gmail.com>
 758
 759         * coffread.c (coff_symfile_read): Constify filename variable.
 760         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 761         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 762         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 763         * solib.c (reload_shared_libraries_1): Likewise.
 764         * symfile.c (reread_symbols): Likewise.
 765         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 766         * solib-darwin.c (darwin_bfd_open): Likewise.
 767         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 768
 769 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 772         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 773
 774 2019-09-03  Tom Tromey  <tromey@adacore.com>
 775
 776         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 777         types.
 778         (has_negatives): Unbias a range type bound.
 779         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 780         * gdbtypes.c (operator==): Handle new field.
 781         (create_range_type): Add "bias" parameter.
 782         (create_static_range_type, resolve_dynamic_range): Update.
 783         * gdbtypes.h (struct range_bounds) <bias>: New member.
 784         (create_range_type): Add bias parameter.
 785         * printcmd.c (print_scalar_formatted): Unbias range types.
 786         * value.c (unpack_long): Unbias range types.
 787         (pack_long): Bias range types.
 788
 789 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 790
 791         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 792         probe arguments.
 793
 794 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 795
 796         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 797         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 798         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 799         (compile_probe_arg): Likewise.
 800         * probe.h (get_argument_count): Likewise.
 801         * solib-svr4.c (solib_event_probe_action): Likewise.
 802         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 803
 804 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 805
 806         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 807         code to here...
 808         (svr4_create_solib_event_breakpoints): ...from here.
 809
 810 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 811
 812         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 813         suffix from warning message.
 814
 815 2019-08-30  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-winsource.h (struct tui_source_window_base)
 818         <refresh_all>: Don't declare.
 819         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 820         Remove.
 821         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 822         tui_show_locator_content.
 823         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 824         declare.
 825         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 826         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 827         declare.
 828
 829 2019-08-30  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 832
 833 2019-08-30  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 836         Remove unnecessary forward declarations.
 837
 838 2019-08-30  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 841         rerender.
 842         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 843         tui_show_locator_content.
 844
 845 2019-08-30  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 848         (tui_locator_window::rerender): Rewrite using body of previous
 849         tui_show_locator_content.
 850
 851 2019-08-30  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 854         set_locator_fullname>: New methods.
 855         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 856         Rename from tui_set_locator_fullname.
 857         (tui_locator_window::set_locator_info): Rename from
 858         tui_set_locator_info.  Return bool.
 859         (tui_update_locator_fullname, tui_show_frame_info): Update.
 860
 861 2019-08-30  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 864
 865 2019-08-30  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 868         call touchwin.
 869
 870 2019-08-30  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-wingeneral.c (box_win): Assume win_info and
 873         win_info->handle cannot be NULL.
 874
 875 2019-08-30  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 878         refresh_window>: Declare.
 879         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 880         resize.
 881         (tui_data_item_window::rerender): Rename from
 882         tui_display_register.
 883         (tui_data_item_window::refresh_window): New method.
 884         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 885         no-op.
 886
 887 2019-08-30  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 890         regs_column_count, current_group>: Move later.  Now private.
 891         <get_current_group>: New method.
 892         * tui/tui-regs.c (tui_reg_command): Update.
 893         * tui/tui-layout.c (tui_set_layout): Update.
 894
 895 2019-08-30  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 898         (tui_data_window::rerender): Don't call
 899         check_and_display_highlight_if_needed.
 900         (tui_data_window::refresh_all): Remove call to
 901         erase_data_content.
 902
 903 2019-08-30  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 906         (tui_data_window::display_registers_from)
 907         (tui_data_window::display_reg_element_at_line)
 908         (tui_data_window::display_registers_from_line): Remove checks of
 909         "empty".
 910
 911 2019-08-30  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 914         Don't declare.
 915         * tui/tui-regs.c (tui_data_window::show_registers): Call
 916         rerender.
 917         (tui_data_window::rerender): Rename from display_all_data.
 918         (tui_data_window::rerender): Remove old implementation.
 919
 920 2019-08-30  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 923         text.
 924         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 925
 926 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 927             Sergio Durigan Junior  <sergiodj@redhat.com>
 928
 929         PR win32/24284
 930         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 931
 932 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 933
 934         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 935         when searching for types.
 936
 937 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * f-lang.c (f_language_defn): Use f_print_typedef.
 940         * f-lang.h (f_print_typedef): Declare.
 941         * f-typeprint.c (f_print_typedef): Define.
 942
 943 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 944
 945         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 946
 947 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * cli/cli-utils.c (info_print_options_defs): Delete.
 950         (make_info_print_options_def_group): Delete.
 951         (extract_info_print_options): Delete.
 952         (info_print_command_completer): Delete.
 953         (info_print_args_help): Add extra parameter, and optionally
 954         include text about -n flag.
 955         * cli/cli-utils.h (struct info_print_options): Delete.
 956         (extract_info_print_options): Delete declaration.
 957         (info_print_command_completer): Delete declaration.
 958         (info_print_args_help): Add extra parameter, extend header
 959         comment.
 960         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 961         search_symbols.
 962         * stack.c (struct info_print_options): New type.
 963         (info_print_options_defs): New file scoped variable.
 964         (make_info_print_options_def_group): New static function.
 965         (info_print_command_completer): New static function.
 966         (info_locals_command): Update to use new local functions.
 967         (info_args_command): Likewise.
 968         (_initialize_stack): Add extra parameter to calls to
 969         info_print_args_help.
 970         * symtab.c (search_symbols): Add extra parameter, use this to
 971         possibly excluse non-debug symbols.
 972         (symtab_symbol_info): Add extra parameter, which is passed on to
 973         search_symbols.
 974         (struct info_print_options): New type.
 975         (info_print_options_defs): New file scoped variable.
 976         (make_info_print_options_def_group): New static function.
 977         (info_print_command_completer): New static function.
 978         (info_variables_command): Update to use local functions, and pass
 979         extra parameter through to symtab_symbol_info.
 980         (info_functions_command): Likewise.
 981         (info_types_command): Pass additional argument through to
 982         symtab_symbol_info.
 983         (rbreak_command): Pass extra argument to search_symbols.
 984         (_initialize_symtab): Add extra arguments for calls to
 985         info_print_args_help, and update help text for 'info variables',
 986         'whereis', and 'info functions' commands.
 987         * symtab.h (search_symbols): Add extra argument to declaration.
 988         * NEWS: Mention new flags.
 989
 990 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 991
 992         * symtab.c (lookup_static_symbol): Call the new function (and move
 993         it down to be next to lookup_global_symbol).
 994         (struct global_sym_lookup_data): Add block_enum member and rename to...
 995         (struct global_or_static_sym_lookup_data): ...this.
 996         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 997         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 998         (lookup_symbol_global_or_static_iterator_cb): ...this.
 999         (lookup_global_or_static_symbol): New function.
1000         (lookup_global_symbol): Call new function.
1001
1002 2019-08-26  Tom de Vries  <tdevries@suse.de>
1003
1004         PR c++/24852
1005         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1006         when pc_probe.prob == NULL.
1007
1008 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1009
1010         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1011         variable symbol_linkage to symbol_linkage_.
1012
1013 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1014
1015         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1016         represent whether the symbol is static, dynamic, or we don't
1017         know.
1018
1019 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1020
1021         * gdb/rx-tdep.c (rx_register_names): New.
1022         (rx_register_name): Delete.
1023         (rx_psw_type): Delete.
1024         (rx_fpsw_type): Delete.
1025         (rx_register_type): Delete.
1026         (rx_gdbarch_init): Convert target-descriptions.
1027         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1028         * gdb/features/Makefile: Add rx.xml.
1029         * gdb/features/rx.xml: New.
1030         * gdb/features/rx.c: Generated.
1031         * gdb/NEWS: Mention target description support.
1032
1033 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1034
1035         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1036         *slot_ptr.
1037
1038 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1039
1040         * configure.ac: Don't check for 'dlfcn.h' (moved to
1041         gdbsupport/common.m4).
1042         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1043         'gdbsupport/'.
1044         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1045         * compile/compile-c-support.c: Include
1046         'gdbsupport/gdb-dlfcn.h'.
1047         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1048         * gdb-dlfcn.c: Move to...
1049         * gdbsupport/gdb-dlfcn.c: ... here.
1050         * gdb-dlfcn.h: Move to...
1051         * gdbsupport/gdb-dlfcn.h: ... here.
1052
1053 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1054
1055         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1056         the offset field signed.
1057
1058 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1059
1060         * python/lib/gdb/__init__.py (_execute_file): New function.
1061         * python/python.c (python_run_simple_file): Call gdb._execute_file
1062         on Windows.
1063
1064 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1067         all uses as this was never set to anything but a zero value.
1068
1069 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1070
1071         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1072
1073 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1074
1075         * tui/tui-data.h (tui_gen_win_info): Add an =default
1076         move constructor, required by some GCC versions.
1077
1078 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1079
1080         * go32-nat.c (go32_sysinfo): Add hygon_p.
1081
1082 2019-08-20  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1085         line_from_reg_element_no, first_reg_element_no_inline,
1086         display_all_data, delete_data_content_windows,
1087         erase_data_content>: Now private.
1088
1089 2019-08-20  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1092         (tui_unhighlight_win, tui_highlight_win)
1093         (tui_win_info::make_window): Update.
1094         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1095
1096 2019-08-20  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1099         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1100         (MAX_PID_WIDTH): Move to tui-stack.c.
1101         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1102         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1103         (MAX_PID_WIDTH): Move from tui-data.h.
1104
1105 2019-08-20  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1108         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1109         (box_win): Update.
1110         (tui_gen_win_info::make_window): Rename from tui_make_window.
1111         (tui_win_info::make_window): New method.
1112         (tui_gen_win_info::make_visible): Update.
1113         * tui/tui-source.c (tui_source_window::set_contents): Update.
1114         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1115         (tui_data_window::display_registers_from): Update.
1116         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1117         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1118         Declare.
1119         <can_box>: Remove.
1120         <title>: Remove.
1121         (struct tui_win_info) <make_window>: Declare.
1122         <can_box>: Now virtual.
1123         <title>: New member.
1124         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1125         * tui/tui-command.c (tui_cmd_window::resize): Update.
1126
1127 2019-08-20  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1130         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1131         (tui_data_window::check_register_values): Update.
1132
1133 2019-08-20  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-regs.h (struct tui_data_window): Use
1136         DISABLE_COPY_AND_ASSIGN.
1137         <regs_content>: Change type, removing unique_ptr.
1138         <tui_data_window>: Add move constructor.
1139         * tui/tui-regs.c (tui_data_window::show_registers)
1140         (tui_data_window::show_register_group)
1141         (tui_data_window::display_registers_from)
1142         (tui_data_window::display_registers_from)
1143         (tui_data_window::first_data_item_displayed)
1144         (tui_data_window::delete_data_content_windows)
1145         (tui_data_window::rerender, tui_data_window::refresh_window)
1146         (tui_data_window::check_register_values): Update.
1147
1148 2019-08-20  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1151         show_register_group>: Declare.
1152         (tui_show_register_group): Don't declare.
1153         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1154         tui_show_registers.
1155         (tui_data_window::show_register_group): Rename from
1156         tui_show_register_group.
1157         (tui_data_window::check_register_values, tui_reg_command):
1158         Update.
1159         * tui/tui-layout.c (tui_set_layout): Update.
1160
1161 2019-08-20  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1164         Declare.
1165         (tui_check_register_values): Don't declare.
1166         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1167         from tui_check_register_values.
1168         * tui/tui-hooks.c (tui_register_changed): Update.
1169
1170 2019-08-20  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-regs.c (tui_reg_layout): Move later.
1173         (tui_show_registers): Don't enable TUI mode or change layout.
1174
1175 2019-08-20  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-regs.h (struct tui_data_item_window)
1178         <~tui_data_item_window>: Remove.
1179         <content>: Now a unique_xmalloc_ptr.
1180         * tui/tui-regs.c (tui_register_format): Return a
1181         unique_xmalloc_ptr.
1182         (tui_get_register): Update.
1183         (~tui_data_item_window): Remove.
1184         (tui_data_window::display_registers_from, tui_display_register):
1185         Update.
1186         * tui/tui-io.h (tui_expand_tabs): Update.
1187         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1188         Remove "col" parameter.
1189
1190 2019-08-20  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1193         field.
1194         * tui/tui-regs.c (~tui_data_item_window): Update.
1195
1196 2019-08-20  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1199         earlier.
1200
1201 2019-08-20  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1204
1205 2019-08-20  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-source.h (struct tui_source_window): Update.
1208         * tui/tui-regs.c (tui_show_registers): Update.
1209         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1210         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1211         (NO_REGS_STRING): Remove defines.
1212
1213 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1214
1215         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1216         unnecessary thread walk if remote doesn't support the packet.
1217
1218 2019-08-19  Tom Tromey  <tromey@adacore.com>
1219
1220         * python/py-value.c (value_has_field): Fix indentation.
1221
1222 2019-08-19  Tom Tromey  <tromey@adacore.com>
1223
1224         * printcmd.c (do_one_display, info_display_command): Update.
1225         * block.h (contained_in): Return bool.  Add allow_nested
1226         parameter.
1227         * block.c (contained_in): Return bool.  Add allow_nested
1228         parameter.
1229
1230 2019-08-19  Tom Tromey  <tom@tromey.com>
1231
1232         * configure: Rebuild.
1233         * configure.ac: Disallow the combination of -static-libstdc++ and
1234         source highlight.
1235         * source-cache.c (get_language_name): Handle rust.
1236         (source_cache::get_source_lines): Ignore highlighting exceptions.
1237
1238 2019-08-16  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1241         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1242         (struct tui_source_window_base) <make_visible, refresh_window,
1243         resize>: Remove methods.
1244         <execution_info>: Remove field.
1245         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1246         (tui_show_source_line, tui_source_window_base)
1247         (~tui_source_window_base): Update.
1248         (tui_source_window_base::resize)
1249         (tui_source_window_base::make_visible)
1250         (tui_source_window_base::refresh_window): Remove.
1251         (tui_source_window_base::update_exec_info): Update.
1252         * tui/tui-source.c (tui_source_window::set_contents): Update.
1253         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1254
1255 2019-08-16  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1258         deprecated_query_hook.
1259
1260 2019-08-16  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1263         (tui_update_source_windows_with_line): Update.
1264         * tui/tui-source.h (struct tui_source_window)
1265         <show_symtab_source>: Declare.
1266         (tui_show_symtab_source): Don't declare.
1267         * tui/tui-source.c (tui_show_symtab_source): Rename from
1268         tui_show_symtab_source.
1269
1270 2019-08-16  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-winsource.h (struct tui_source_window_base)
1273         <set_contents>: Declare.
1274         * tui/tui-winsource.c
1275         (tui_source_window_base::update_source_window_as_is): Update.
1276         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1277         Declare.
1278         (tui_set_source_content): Don't declare.
1279         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1280         tui_set_source_content.
1281         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1282         Declare.
1283         (tui_set_disassem_content): Don't declare.
1284         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1285         tui_set_disassem_content.
1286
1287 2019-08-16  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-winsource.h (struct tui_source_window_base)
1290         <update_breakpoint_info>: Declare.
1291         (tui_update_breakpoint_info): Don't declare.
1292         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1293         (tui_update_all_breakpoint_info): Update.
1294         (tui_source_window_base::update_breakpoint_info): Rename from
1295         tui_update_breakpoint_info.
1296         (tui_source_window_base::update_exec_info): Update.
1297
1298 2019-08-16  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-winsource.h (struct tui_source_window_base)
1301         <update_source_window>: Declare.
1302         (tui_update_source_window): Don't declare.
1303         * tui/tui-winsource.c
1304         (tui_source_window_base::update_source_window): Rename from
1305         tui_update_source_window.
1306         (tui_source_window_base::rerender): Update.
1307         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1308         * tui/tui-disasm.c (tui_show_disassem)
1309         (tui_show_disassem_and_update_source)
1310         (tui_disasm_window::maybe_update): Update.
1311
1312 2019-08-16  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-winsource.h (struct tui_source_window_base)
1315         <update_source_window_as_is>: Declare.
1316         (tui_update_source_window_as_is): Don't declare.
1317         * tui/tui-winsource.c (tui_update_source_window): Update
1318         (tui_source_window_base::update_source_window_as_is): Rename from
1319         tui_update_source_window_as_is.
1320         (tui_source_window_base::refill): Update.
1321         * tui/tui-source.c (tui_show_symtab_source): Update.
1322         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1323         Update.
1324
1325 2019-08-16  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-winsource.h (tui_update_source_window)
1328         (tui_update_source_window_as_is): Remove "noerror" parameter.
1329         * tui/tui-winsource.c (tui_update_source_window)
1330         (tui_update_source_window_as_is): Remove "noerror" parameter.
1331         (tui_update_source_windows_with_addr)
1332         (tui_update_source_windows_with_line)
1333         (tui_source_window_base::rerender)
1334         (tui_source_window_base::refill): Update.
1335         * tui/tui-source.h (tui_set_source_content)
1336         (tui_show_symtab_source): Remove "noerror" parameter.
1337         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1338         parameter.
1339         (tui_show_symtab_source): Likewise.
1340         (tui_source_window::maybe_update): Update.
1341         * tui/tui-disasm.c (tui_show_disassem)
1342         (tui_show_disassem_and_update_source)
1343         (tui_disasm_window::do_scroll_vertical)
1344         (tui_disasm_window::maybe_update): Update.
1345
1346 2019-08-16  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui.c (tui_is_window_visible): Update.
1349         * tui/tui-wingeneral.c (tui_make_window)
1350         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1351         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1352         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1353         (tui_set_win_height_command, parse_scrolling_args): Update.
1354         * tui/tui-source.c (tui_source_window::style_changed): Update.
1355         * tui/tui-regs.c (tui_show_registers)
1356         (tui_data_window::first_data_item_displayed)
1357         (tui_data_window::delete_data_content_windows)
1358         (tui_check_register_values, tui_reg_command): Update.
1359         * tui/tui-disasm.c (tui_show_disassem): Update.
1360         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1361         method.
1362         <is_visible>: Remove field.
1363         * tui/tui-data.c (tui_next_win, tui_prev_win)
1364         (tui_delete_invisible_windows): Update.
1365
1366 2019-08-16  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-winsource.h (struct tui_source_window_base)
1369         <m_has_locator>: Remove.
1370         * tui/tui-layout.c (show_source_disasm_command, show_data)
1371         (show_source_or_disasm_and_command): Update.
1372
1373 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1374
1375         * NEWS (Other MI changes): New subsection.
1376         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1377         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1378         * arch-utils.c (default_get_pc_address_flags): New function.
1379         * arch-utils.h (default_get_pc_address_flags): New declaration.
1380         * gdbarch.sh: Add get_pc_address_flags.
1381         * gdbarch.c: Regenerate.
1382         * gdbarch.h: Likewise.
1383         * stack.c (print_pc): New function.
1384         (print_frame_info) (print_frame): Call print_pc.
1385
1386 2019-08-16  Tom de Vries  <tdevries@suse.de>
1387
1388         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1389         print_objfile_section_info.
1390
1391 2019-08-15  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1394         calling update_cmdwin_start_line.
1395         * tui/tui-winsource.h (struct tui_source_window_base)
1396         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1397         <rerender>: Declare.
1398         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1399         Call rerender.
1400         (tui_source_window_base::set_new_height): Remove.
1401         (tui_source_window_base::rerender): Rename from
1402         do_make_visible_with_new_height.
1403         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1404         resize method.
1405         (tui_win_info::make_invisible_and_set_new_height)
1406         (tui_win_info::make_visible_with_new_height): Remove.
1407         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1408         Declare.
1409         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1410         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1411         do_make_visible_with_new_height>: Don't declare.
1412         <rerender>: Declare.
1413         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1414         set_new_height.
1415         (tui_data_window::do_make_visible_with_new_height): Remove.
1416         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1417         call tui_show_locator_content.
1418         (tui_gen_win_info::resize): Call rerender.
1419         (show_source_or_disasm_and_command): Don't call
1420         tui_show_locator_content.
1421         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1422         method.
1423         (struct tui_win_info) <rerender>: Declare.
1424         <set_new_height, make_invisible_and_set_new_height,
1425         make_visible_with_new_height>: Don't declare.
1426         * tui/tui-data.c (tui_win_list::rerender): New method.
1427         * tui/tui-command.h (struct tui_cmd_window)
1428         <do_make_visible_with_new_height>: Don't declare.
1429         * tui/tui-command.c
1430         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1431
1432 2019-08-15  Tom Tromey  <tromey@adacore.com>
1433
1434         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1435         * ada-lang.c (ada_enum_name): Likewise.
1436
1437 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1438
1439         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1440         leading underscore.
1441         (GdbOutputErrorFile): Likewise.
1442         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1443         accordingly.
1444         (execute_unwinders): Rename to have a leading underscore.
1445         (auto_load_packages): Likewise.
1446         (global scope): Adjust call to auto_load_packages accordingly.
1447         (GdbSetPythonDirectory): Likewise.
1448         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1449         instead of execute_unwinders.
1450
1451 2019-08-15  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1454         (show_data): Don't change window visibility.
1455         (tui_gen_win_info::resize): Remove special case for command
1456         window.  Use wresize, when available.
1457         (show_source_or_disasm_and_command): Don't change window
1458         visibility.
1459         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1460         <make_visible>: New method.
1461         * tui/tui-command.c (tui_cmd_window::resize): New method.
1462
1463 2019-08-15  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1466         (struct tui_source_windows): New.
1467         * tui/tui-winsource.c (tui_display_main): Update.
1468         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1469         (new_height_ok, parse_scrolling_args): Update.
1470         * tui/tui-layout.c (show_layout, show_data): Update.
1471         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1472         (tui_add_to_source_windows): Don't declare.
1473         * tui/tui-data.c (source_windows, tui_source_windows)
1474         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1475
1476 2019-08-15  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1479         Rename from reset.
1480         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1481         * tui/tui-layout.c (show_source_disasm_command, show_data):
1482         Update.
1483         (tui_gen_win_info::resize): Rename.
1484         (show_source_or_disasm_and_command): Update.
1485         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1486         reset.
1487
1488 2019-08-15  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1491         * tui/tui-interp.c (tui_interp::init): Don't call
1492         tui_initialize_static_data.
1493         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1494
1495 2019-08-15  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1498         examine tui_win_list.
1499
1500 2019-08-15  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1503         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1504         tui_clear_source_content.
1505         (tui_clear_source_content): Remove.
1506         (tui_source_window_base::do_erase_source_content): Hoist call to
1507         content.clear().
1508         * tui/tui-stack.c (tui_show_frame_info): Don't call
1509         tui_clear_source_content.
1510
1511 2019-08-15  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.h (struct tui_source_window_base)
1514         <do_erase_source_content>: New method.
1515         <erase_source_content>: New method.
1516         (tui_erase_source_content): Don't declare.
1517         * tui/tui-winsource.c (tui_clear_source_content): Update.
1518         (tui_source_window_base::do_erase_source_content): Rename from
1519         tui_erase_source_content.
1520         (tui_source_window_base::show_source_content): Update.
1521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1522         * tui/tui-source.h (struct tui_source_window)
1523         <erase_source_content>: New method.
1524         * tui/tui-disasm.h (struct tui_disasm_window)
1525         <erase_source_content>: New method.
1526
1527 2019-08-15  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1530         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1531         constructor.
1532         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1533         * tui/tui-source.c (tui_set_source_content): Update.
1534         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1535
1536 2019-08-15  Tom Tromey  <tom@tromey.com>
1537
1538         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1539         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1540         tui-source.c.
1541         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1542         Declare.
1543         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1544         method.
1545         (tui_source_window::maybe_update): Update.
1546
1547 2019-08-15  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1550         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1551         tui-disasm.c.
1552         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1553         Declare.
1554         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1555         method.
1556         (tui_disasm_window::maybe_update): Update.
1557
1558 2019-08-15  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.h (struct tui_source_window_base)
1561         <maybe_update>: Declare.
1562         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1563         method.
1564         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1565         Declare.
1566         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1567         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1568         Declare.
1569         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1570
1571 2019-08-15  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1574
1575 2019-08-15  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-wingeneral.c: Include tui-stack.h.
1578         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1579         (struct tui_locator_window): Move from tui-data.h.
1580         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1581         (tui_initialize_static_data): Move from tui-data.c.
1582         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1583         (struct tui_locator_window): Move to tui-stack.c.
1584         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1585         (tui_initialize_static_data): Move to tui-stack.c.
1586
1587 2019-08-15  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-layout.c (show_source_disasm_command)
1590         (show_source_or_disasm_and_command): Use make_visible method, not
1591         tui_make_window.
1592         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1593         Remove.
1594
1595 2019-08-15  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-wingeneral.h (tui_make_window): Update.
1598         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1599         parameter.
1600         (tui_gen_win_info::make_visible): Update.
1601         * tui/tui-regs.c (tui_data_window::display_registers_from):
1602         Update.
1603         * tui/tui-layout.c (show_source_disasm_command)
1604         (show_source_or_disasm_and_command): Update.
1605         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1606         (enum tui_box): Remove.
1607         (struct tui_win_info) <can_box>: New method.
1608         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1609         method.
1610
1611 2019-08-15  Tom de Vries  <tdevries@suse.de>
1612
1613         * linux-nat-trad.c: Include gdbarch.h.
1614
1615 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1616
1617         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1618         register sizes.
1619
1620 2019-08-14  Tom Tromey  <tromey@adacore.com>
1621
1622         * darwin-nat.c: Include gdbarch.h.
1623         * darwin-nat-info.c: Include gdbarch.h.
1624
1625 2019-08-13  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1628         Remove.
1629         * tui/tui-data.c (tui_initialize_static_data): Update.
1630
1631 2019-08-13  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-winsource.h (struct tui_exec_info_window)
1634         <~tui_exec_info_window, maybe_allocate_content, get_content,
1635         m_content>: Remove.
1636         (struct tui_source_window_base) <set_exec_info_content,
1637         show_exec_info_content>: Don't declare.
1638         * tui/tui-winsource.c
1639         (tui_exec_info_window::maybe_allocate_content): Remove.
1640         (tui_source_window_base::update_exec_info): Rename from
1641         set_exec_info_content.
1642         (tui_source_window_base::show_exec_info_content)
1643         (tui_source_window_base::update_exec_info): Remove.
1644
1645 2019-08-13  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1648         declare.
1649         * tui/tui-winsource.c (tui_update_source_window_as_is)
1650         (tui_update_source_windows_with_addr, tui_erase_source_content):
1651         Update.
1652         (tui_clear_exec_info_content): Remove.
1653
1654 2019-08-13  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1657         declare.
1658         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1659         call tui_erase_exec_info_content.
1660         (tui_clear_exec_info_content): Rename from
1661         tui_erase_exec_info_content.
1662         (tui_clear_exec_info_content): Delete.
1663
1664 2019-08-13  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-winsource.h (struct tui_source_window_base)
1667         <show_exec_info_content>: Declare.
1668         (tui_show_exec_info_content): Don't declare.
1669         * tui/tui-winsource.c
1670         (tui_source_window_base::show_exec_info_content): Rename from
1671         tui_show_exec_info_content.
1672         (tui_source_window_base::update_exec_info): Update.
1673
1674 2019-08-13  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1677         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1678         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1679         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1680         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1681         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1682         ... here.
1683
1684 2019-08-13  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-winsource.h (struct tui_source_window_base)
1687         <update_exec_info>: Declare.
1688         (tui_update_exec_info): Don't declare.
1689         * tui/tui-winsource.c (tui_update_source_window_as_is)
1690         (tui_source_window_base::refresh_all)
1691         (tui_update_all_breakpoint_info): Update.
1692         (tui_source_window_base::update_exec_info): Rename from
1693         tui_update_exec_info.
1694         * tui/tui-stack.c (tui_show_frame_info): Update.
1695
1696 2019-08-13  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.h (struct tui_source_window_base)
1699         <set_exec_info_content>: Declare.
1700         (tui_set_exec_info_content): Don't declare.
1701         * tui/tui-winsource.c
1702         (tui_source_window_base::set_exec_info_content): Rename from
1703         tui_set_exec_info_content.
1704         (tui_update_exec_info): Update.
1705
1706 2019-08-13  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-winsource.h (struct tui_source_window_base)
1709         <show_source_content>: Declare.
1710         (tui_show_source_content): Don't declare.
1711         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1712         (tui_source_window_base::show_source_content): Rename from
1713         tui_show_source_content.
1714         (tui_source_window_base::refresh_all): Update.
1715         * tui/tui-layout.c (show_source_disasm_command)
1716         (show_source_or_disasm_and_command): Update.
1717
1718 2019-08-13  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-winsource.c (tui_erase_source_content)
1721         (tui_show_source_content, tui_source_window_base::refresh_all):
1722         Update.
1723         * tui/tui-wingeneral.h
1724         (tui_check_and_display_highlight_if_needed): Don't declare.
1725         * tui/tui-wingeneral.c
1726         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1727         check_and_display_highlight_if_needed.
1728         * tui/tui-win.c (tui_rehighlight_all)
1729         (tui_win_info::make_visible_with_new_height): Update.
1730         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1731         (tui_data_window::erase_data_content)
1732         (tui_data_window::display_all_data): Update.
1733         * tui/tui-data.h (struct tui_win_info)
1734         <check_and_display_highlight_if_needed>: Declare.
1735
1736 2019-08-13  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-win.c (tui_resize_all): Call
1739         tui_delete_invisible_windows.
1740         * tui/tui-layout.c (show_layout): Call
1741         tui_delete_invisible_windows.
1742         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1743         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1744
1745 2019-08-13  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1748         tui_add_win_to_layout.
1749
1750 2019-08-13  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1753         * tui/tui-layout.c (tui_default_win_height): Now static.
1754
1755 2019-08-13  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1758         single switch.
1759         (show_source_disasm_command, show_source_or_disasm_and_command):
1760         Don't check current layout.
1761
1762 2019-08-13  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-wingeneral.c (make_all_visible): Remove.
1765         (tui_make_all_invisible): Simplify.
1766         * tui/tui-layout.c (tui_make_all_invisible): Move from
1767         tui-wingeneral.c; simplify.
1768         (show_layout): Hoist call to tui_make_all_invisible.
1769         (show_data): Don't call tui_make_all_invisible.
1770
1771 2019-08-13  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1774         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1775
1776 2019-08-13  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1779         tui-data.c.
1780         (show_source_disasm_command, show_data)
1781         (show_source_or_disasm_and_command): Don't use
1782         tui_set_current_layout_to.
1783         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1784         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1785         tui-layout.c.
1786         (tui_set_current_layout_to): Remove.
1787
1788 2019-08-13  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-layout.c (tui_set_layout): Update.
1791         * tui/tui-data.h (struct tui_layout_def): Remove.
1792         (tui_layout_def): Don't declare.
1793         * tui/tui-data.c (layout_def): Remove.
1794         (tui_layout_def): Remove.
1795
1796 2019-08-13  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-winsource.h (struct tui_source_window_base)
1799         <clear_detail>: No longer "override".
1800         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1801         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1802         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1803         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1804         Remove.
1805         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1806
1807 2019-08-13  Tom Tromey  <tromey@adacore.com>
1808
1809         * tracepoint.c: Don't include readline.h or history.h.
1810
1811 2019-08-12  Tom Tromey  <tom@tromey.com>
1812
1813         * configure: Rebuild.
1814         * configure.ac: Check for readline 7.
1815         * NEWS: Mention readline 7 requirement.
1816         * README: Update.
1817
1818 2019-08-12  Tom Tromey  <tom@tromey.com>
1819
1820         * mingw-hdep.c (gdb_select): Remove readline hack.
1821
1822 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1823
1824         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1825         when the function fails.
1826
1827 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1828
1829         * s390-tdep.c (s390_type_align): New function.
1830         (s390_gdbarch_init): Set it as type_align gdbarch method.
1831
1832 2019-08-09  Tom de Vries  <tdevries@suse.de>
1833
1834         PR gdb/24591
1835         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1836         pc_low with relocation offset.
1837
1838 2019-08-07  Tom Tromey  <tromey@adacore.com>
1839
1840         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1841         (print_frame_args): Update.
1842         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1843         Update.
1844         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1845         * frame.h (struct frame_arg): Add initializers.
1846         <error>: Now a unique_xmalloc_ptr.
1847
1848 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1849
1850         * NEWS: Expand the Pointer Authentication entry.
1851         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1852         (aarch64_frame_unmask_lr): ... to this.
1853         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1854         Call aarch64_frame_unmask_lr.
1855         * frame.c (struct frame_info): Add "masked" variable.
1856         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1857         (fprint_frame): Check for masked pc.
1858         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1859         declarations.
1860         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1861         * stack.c (print_frame): Check for masked pc.
1862
1863 2019-08-06  Tom Tromey  <tom@tromey.com>
1864
1865         * stabsread.c (patch_block_stabs, read_one_struct_field)
1866         (read_enum_type): Use obstack_strndup.
1867         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1868         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1869         * dwarf2read.c (guess_full_die_structure_name)
1870         (anonymous_struct_prefix): Use obstack_strndup.
1871         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1872         * c-exp.y (yylex): Use obstack_strndup.
1873         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1874         (write_var_or_type): Use obstack_strndup.
1875
1876 2019-08-06  Tom Tromey  <tom@tromey.com>
1877
1878         * symfile.c (reread_symbols): Use obstack_strdup.
1879         * stabsread.c (read_type): Use obstack_strdup.
1880         * gdb_obstack.h (obstack_strdup): New overload.
1881         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1882         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1883         (dwarf2_canonicalize_name): Use obstack_strdup.
1884         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1885         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1886         Use obstack_strdup.
1887
1888 2019-08-06  Tom Tromey  <tom@tromey.com>
1889
1890         * gdb_obstack.h (obstack_strdup): Define.
1891         * gdb_obstack.c (obstack_strdup): Don't define.
1892
1893 2019-08-06  Tom Tromey  <tom@tromey.com>
1894
1895         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1896         obstack_strdup.
1897         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1898         obstack_strdup.
1899         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1900         * stabsread.c (common_block_start): Use obstack_strdup.
1901         * objfiles.c (set_objfile_main_name, objfile): Use
1902         obstack_strdup.
1903         * namespace.c (add_using_directive): Use obstack_strdup.
1904         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1905         * jit.c (finalize_symtab): Use obstack_strdup.
1906         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1907         (guess_partial_die_structure_name, partial_die_info::fixup)
1908         (dwarf2_name): Use obstack_strdup.
1909         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1910         obstack_strdup.
1911         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1912         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1913         obstack_strdup.
1914         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1915
1916 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1917
1918         * unittests/help-doc-selftests.c: New file.
1919         * Makefile.in: Add the new file.
1920
1921 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1922
1923         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1924         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1925         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1926         the trailing '.' is not output, and the first character is uppercased.
1927         (print_help_for_command): Update call to print_doc_line.
1928         (print_doc_of_command): Likewise.
1929         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1930         * cli/cli-option.c (append_indented_doc): Do not append newline.
1931         (build_help_option): Append newline after first appended_indented_doc
1932         only if a second call is done.
1933         (build_help): Append 2 new lines before each option, except the first
1934         one.
1935         * compile/compile.c (_initialize_compile): Add new lines after
1936         %OPTIONS%, when not at the end of the help.
1937         Change help doc or code
1938         producing the help doc to respect the invariants.
1939         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1940         Also removed the new line after 'Options:', as all other commands
1941         do not put an empty line between 'Options:' and the first option.
1942         * printcmd.c (_initialize_printcmd): Likewise.
1943         * stack.c (_initialize_stack): Likewise.
1944         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1945         incorrectly telling COMMAND is optional.
1946         * ada-lang.c (_initialize_ada_language): Change help doc or code
1947         producing the help doc to respect the invariants.
1948         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1949         * breakpoint.c (_initialize_breakpoint): Likewise.
1950         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1951         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1952         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1953         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1954         _initialize_cli_style): Likewise.
1955         * corelow.c (core_target_info): Likewise.
1956         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1957         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1958         * filesystem.c (_initialize_filesystem): Likewise.
1959         * frame.c (_initialize_frame): Likewise.
1960         * gnu-nat.c (add_task_commands): Likewise.
1961         * infcall.c (_initialize_infcall): Likewise.
1962         * infcmd.c (_initialize_infcmd): Likewise.
1963         * interps.c (_initialize_interpreter): Likewise.
1964         * language.c (_initialize_language): Likewise.
1965         * linux-fork.c (_initialize_linux_fork): Likewise.
1966         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1967         * maint.c (_initialize_maint_cmds): Likewise.
1968         * memattr.c (_initialize_mem): Likewise.
1969         * printcmd.c (_initialize_printcmd): Likewise.
1970         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1971         _RegEx): Likewise.
1972         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1973         * record-btrace.c (_initialize_record_btrace): Likewise.
1974         * record-full.c (_initialize_record_full): Likewise.
1975         * record.c (_initialize_record): Likewise.
1976         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1977         * regcache.c (_initialize_regcache): Likewise.
1978         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1979         _initialize_remote): Likewise.
1980         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1981         * serial.c (_initialize_serial): Likewise.
1982         * skip.c (_initialize_step_skip): Likewise.
1983         * source.c (_initialize_source): Likewise.
1984         * stack.c (_initialize_stack): Likewise.
1985         * symfile.c (_initialize_symfile): Likewise.
1986         * symtab.c (_initialize_symtab): Likewise.
1987         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1988         * top.c (init_main): Likewise.
1989         * tracefile-tfile.c (tfile_target_info): Likewise.
1990         * tracepoint.c (_initialize_tracepoint): Likewise.
1991         * tui/tui-win.c (_initialize_tui_win): Likewise.
1992         * utils.c (add_internal_problem_command): Likewise.
1993         * valprint.c (value_print_option_defs): Likewise.
1994
1995 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1996
1997         PR build/24886
1998         * configure.ac: Drop enable-libmcheck support.
1999         * configure, config.in: Rebuild.
2000         * libmcheck.m4: Remove.
2001         * acinclude.m4: Don't include it.
2002         * Makefile.in: Don't distribute it.
2003         * top.c (print_gdb_configuration): Don't mention it.
2004
2005 2019-08-06  Tom Tromey  <tom@tromey.com>
2006
2007         * utils.c (set_output_style): Sometimes pass stream to
2008         emit_style_escape.
2009         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2010         * record-btrace.c (btrace_insn_history): Update.
2011         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2012         method.
2013         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2014         Update initializers.
2015         <m_uiout>: New field.
2016         <m_di>: Move lower.
2017         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2018         Remove "uiout" parameter.
2019         (dump_insns): Update.
2020         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2021         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2022
2023 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2024
2025         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2026         (error_in_psymtab_expansion): Likewise.
2027         (lookup_symbol_via_quick_fns): Likewise.
2028         (basic_lookup_transparent_type_quick): Likewise.
2029         (basic_lookup_transparent_type_1): Likewise.
2030
2031 2019-08-06  Tom Tromey  <tromey@adacore.com>
2032
2033         * source.c (last_source_error): Now bool.
2034         (print_source_lines_base): Make "noprint" bool.  Only open
2035         source file when last_source_visited changes.
2036
2037 2019-08-06  Tom Tromey  <tromey@adacore.com>
2038
2039         * annotate.c (annotate_source_line): Use g_source_cache.
2040         * source-cache.c (source_cache::get_plain_source_lines): Change
2041         parameters.  Populate m_offset_cache.
2042         (source_cache::ensure): New method.
2043         (source_cache::get_line_charpos): New method.
2044         (extract_lines): Move lower.  Change parameters.
2045         (source_cache::get_source_lines): Move lower.
2046         * source-cache.h (class source_cache): Update comment.
2047         <get_line_charpos>: New method.
2048         <get_source_lines>: Update comment.
2049         <clear>: Clear m_offset_cache.
2050         <get_plain_source_lines>: Change parameters.
2051         <ensure>: New method
2052         <m_offset_cache>: New member.
2053         * source.c (forget_cached_source_info_for_objfile): Update.
2054         (info_source_command): Use g_source_cache.
2055         (find_source_lines, open_source_file_with_line_charpos): Remove.
2056         (print_source_lines_base, search_command_helper): Use g_source_cache.
2057         * source.h (open_source_file_with_line_charpos): Don't declare.
2058         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2059         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2060         Use g_source_cache.
2061
2062 2019-08-06  Tom Tromey  <tromey@adacore.com>
2063
2064         * source-cache.c (source_cache::get_plain_source_lines):
2065         Remove "first_line" and "last_line" parameters.
2066         (source_cache::get_source_lines): Cache plain text.
2067         * source-cache.h (class source_cache)
2068         <get_plain_source_lines>: Update.
2069
2070 2019-08-06  Tom Tromey  <tromey@adacore.com>
2071
2072         * source-cache.c (extract_lines): No longer a method.
2073         Changed type of parameter.  Include final newline.
2074         (selftests::extract_lines_test): New function.
2075         (_initialize_source_cache): Likewise.
2076         * source-cache.h (class source_cache)
2077         <extract_lines>: Don't declare.
2078
2079 2019-08-06  Tom Tromey  <tromey@adacore.com>
2080
2081         * breakpoint.c (init_breakpoint_sal): Update.
2082         (breakpoint): Update.
2083         * breakpoint.h (struct breakpoint) <filter>: Now a
2084         unique_xmalloc_ptr.
2085
2086 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2087
2088         * NEWS: Mention dictionary access on blocks.
2089         * python/py-block.c (blpy_getitem): New function.
2090         (block_object_as_mapping): New struct.
2091         (block_object_type): Use new struct for tp_as_mapping field.
2092
2093 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2094
2095         * objfiles.h (objfile): Add a comment describing partial symbols.
2096
2097 2019-08-05  Tom Tromey  <tromey@adacore.com>
2098
2099         * compile/compile.c (_initialize_compile): Use _(), not N_().
2100         * thread.c (_initialize_thread): Use _(), not N_().
2101         * stack.c (_initialize_stack): Use _(), not N_().
2102         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2103
2104 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2105
2106         * dwarf2read.c (struct dw2_symtab_iterator):
2107         <want_specific_block>: Remove.
2108         <block_index>: Change type to gdb::optional.
2109         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2110         change type of BLOCK_INDEX parameter to gdb::optional.
2111         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2112         (dw2_lookup_symbol): Don't pass argument for
2113         WANT_SPECIFIC_BLOCK.
2114         (dw2_expand_symtabs_for_function): Don't pass argument for
2115         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2116         (class dw2_debug_names_iterator)
2117         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2118         parameter, change BLOCK_INDEX type to gdb::optional.
2119         <m_want_specific_block>: Remove.
2120         <m_block_index>: Change type to gdb::optional.
2121         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2122         gdb::optional.  Re-write in function of gdb::optional.
2123         (dw2_debug_names_lookup_symbol): Don't pass argument for
2124         WANT_SPECIFIC_BLOCK.
2125         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2126         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2127         BLOCK_INDEX.
2128
2129 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2130
2131         * NEWS: Mention changes to "info sources" command.
2132
2133 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2134
2135         * symtab.c (filename_partial_match_opts): New struct type.
2136         (struct output_source_filename_data): New members
2137         regexp, c_regexp, partial_match.
2138         (output_source_filename): Use new members to decide to print file.
2139         (info_sources_option_defs): New variable.
2140         (make_info_sources_options_def_group, print_info_sources_header,
2141         info_sources_command_completer):
2142         New functions.
2143         (info_sources_command): Read new optional arguments.
2144         (_initialize_symtab): Update info sources help.
2145
2146 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2147
2148         * ada-lang.c (exception_support_info_v0): Renamed from...
2149         (default_exception_support_info): ... this.  Create new
2150         definition for v1.
2151         (ada_has_this_exception_support): Look up catch_handlers_sym.
2152         (ada_exception_support_info_sniffer): Try v0 after default.
2153
2154 2019-08-01  Tom Tromey  <tromey@adacore.com>
2155
2156         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2157         gdbarch.h.
2158
2159 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2160
2161         * s12z-tdep.c: Fix include path for s12z-opc.h.
2162
2163 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2164
2165         * NEWS: Require GNU make 3.82.
2166
2167 2019-07-16  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2170         declare.
2171
2172 2019-07-30  Tom Tromey  <tromey@adacore.com>
2173
2174         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2175
2176 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2177
2178         * printcmd.c (print_address_symbolic): Print negative offsets.
2179         (build_address_symbolic): Force signed arithmetic when computing
2180         offset.
2181
2182 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2183
2184         PR/24474: Add a function to lookup static variables.
2185         * NEWS: Mention this new function.
2186         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2187         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2188         * python/python.c (python_GdbMethods): Add new function.
2189
2190 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2191
2192         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2193         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2194         (objfpy_lookup_static_symbol): New function.
2195         (objfile_object_methods): Add new functions.
2196
2197 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2198
2199         * NEWS: Mention 'set|show print frame-info'.  Mention new
2200         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2201         backtrace argument.  Mention that python frame filtering code
2202         is now consistent with what 'backtrace' command prints.
2203
2204 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2205
2206         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2207         comments.
2208         (print_frame_info_auto, print_frame_info_source_line,
2209         print_frame_info_location, print_frame_info_source_and_location,
2210         print_frame_info_location_and_address, print_frame_info_short_location):
2211         New declarations.
2212         (struct frame_print_options): New member print_frame_info.
2213         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2214         * stack.h (get_user_print_what_frame_info): New declaration.
2215         (frame_show_address): New declaration.
2216         * stack.c (print_frame_arguments_choices): New value 'presence'.
2217         (print_frame_info_auto, print_frame_info_source_line,
2218         print_frame_info_location, print_frame_info_source_and_location,
2219         print_frame_info_location_and_address, print_frame_info_short_location,
2220         print_frame_info_choices, print_frame_info_print_what): New definitions.
2221         (print_frame_args): Only print dots for args if print frame-arguments
2222         is 'presence'.
2223         (frame_print_option_defs): New element for "frame-info".
2224         (get_user_print_what_frame_info): New function.
2225         (frame_show_address): Make non static.  Move comment to stack.h.
2226         (print_frame_info_to_print_what): New function.
2227         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2228         to decide what to print.
2229         (backtrace_command_1): Handle the new print_frame_arguments_presence
2230         value.
2231         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2232         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2233         (py_print_frame): In non-mi mode, use LOCATION as default for
2234         print_what, similarly to frame information printed directly by
2235         backtrace command. Handle frame-info user option in non MI mode.
2236
2237 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2238
2239         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2240         Add case for debugging 32-bit target on 64-bit host.  Revise
2241         comment.
2242
2243 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2244
2245         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2246         instead of find_function_entry_range_from_pc.
2247
2248 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2249
2250         * stack.c (find_frame_funname): Remove code which preferred
2251         minsym over symtab sym in "certain pathological cases".
2252
2253         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2254         parameter.  Change type of "do_demangle" to bool.
2255         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2256         Pass suitable "prefer_sym_over_minsym" flag to
2257         build_address_symbolic().  Don't output "+" for negative offsets.
2258         * printcmd.c (print_address_symbolic): Update invocation of
2259         build_address_symbolic to include a "prefer_sym_over_minsym"
2260         flag.
2261         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2262         Restrict cases in which use of minimal symbol is preferred to that
2263         of a found symbol.  Update comments.
2264
2265         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2266         for entry pc when entry pc is out of range for that FDE.
2267
2268 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2269
2270         PR gdb/24839:
2271         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2272         type.
2273
2274 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2275
2276         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2277         this function's Python signature.
2278
2279
2280 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2281
2282         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2283         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2284         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2285         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2286         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2287
2288
2289 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2290
2291         * h8300-tdep.c (h8300_register_name_common): New.
2292         h8300_register_name): Use h8300_register_name_common.
2293         (h8300s_register_name): Likewise.
2294         (h8300sx_register_name): Likewise.
2295         (h8300h_register_nam): New.
2296         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2297
2298
2299 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2300
2301         * arm-tdep.c (arm_skip_cmse_entry): New function.
2302         (arm_is_sgstubs_section): New function.
2303         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2304
2305 2019-07-22  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2308         Don't self-assign.
2309
2310 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2311
2312         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2313         type_print.
2314
2315 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2318         so that GDB doesn't match any msymbols when searching in the
2319         TYPES_DOMAIN.
2320         (print_symbol_info): Print using typedef_print or type_print based
2321         on the type of the symbol.  Add updated FIXME comment moved from...
2322         (_initialize_symtab): ... move and update FIXME comment to above.
2323
2324 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * NEWS: Mention adding -q option to "info types".
2327         * symtab.c (struct info_types_options): New struct.
2328         (info_types_options_defs): New variable.
2329         (make_info_types_options_def_group): New function.
2330         (info_types_command): Use gdb::option framework to parse options.
2331         (info_types_command_completer): New function.
2332         (_initialize_symtab): Extend the help text on "info types" and
2333         register command completer.
2334
2335 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2336
2337         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2338         (lookup_symbol_in_objfile): Change int to block_enum and add a
2339         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2340
2341 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2342
2343         * MAINTAINERS (Write After Approval): Add self.
2344
2345 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2348         instruction to the dummy code region.
2349
2350 2019-07-19  Tom Tromey  <tromey@adacore.com>
2351
2352         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2353         (ARGSUSED, PARAMS, __func__): Remove rules.
2354
2355 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2356
2357         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2358         * features/arm/arm-with-iwmmxt.c: Remove.
2359         * features/arm/arm-with-iwmmxt.xml: Remove.
2360         * features/arm/arm-with-m-fpa-layout.c: Remove.
2361         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2362         * features/arm/arm-with-m-vfp-d16.c: Remove.
2363         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2364         * features/arm/arm-with-m.c: Remove.
2365         * features/arm/arm-with-m.xml: Remove.
2366         * features/arm/arm-with-neon.c: Remove.
2367         * features/arm/arm-with-neon.xml: Remove.
2368         * features/arm/arm-with-vfpv2.c: Remove.
2369         * features/arm/arm-with-vfpv2.xml: Remove.
2370         * features/arm/arm-with-vfpv3.c: Remove.
2371         * features/arm/arm-with-vfpv3.xml: Remove.
2372
2373 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2374
2375         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2376
2377 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2378
2379         * arch/aarch32.c (aarch32_create_target_description): Create
2380         target descriptions using features.
2381         * arch/arm.c (arm_create_target_description)
2382         (arm_create_mprofile_target_description): Likewise.
2383         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2384
2385 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2386
2387         * Makefile.in: Add new files.
2388         * aarch32-tdep.c: New file.
2389         * aarch32-tdep.h: New file.
2390         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2391         Call aarch32_read_description.
2392         * arch/aarch32.c: New file.
2393         * arch/aarch32.h: New file.
2394         * arch/arm.c (arm_create_target_description)
2395         (arm_create_mprofile_target_description): New function.
2396         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2397         (arm_create_target_description)
2398         (arm_create_mprofile_target_description): New declaration.
2399         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2400         read_description functions.
2401         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2402         Likewise.
2403         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2404         * arm-tdep.c (tdesc_arm_list): New variable.
2405         (arm_register_g_packet_guesses): Call create description functions.
2406         (arm_read_description) (arm_read_mprofile_description): New
2407         function.
2408         * arm-tdep.h (arm_read_description)
2409         (arm_read_mprofile_description): Add declaration.
2410         * configure.tgt: Add new files.
2411
2412 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2413
2414         * top.c (new_ui_command): Open specified terminal just once.
2415
2416 2019-07-18  Tom Tromey  <tromey@adacore.com>
2417
2418         * symtab.c (main_name): Constify return type.
2419         * symfile.c (set_initial_language): Update.
2420         * symtab.h (main_name): Constify return type.
2421
2422 2019-07-17  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-winsource.c (tui_update_source_window)
2425         (tui_update_source_window_as_is)
2426         (tui_update_source_windows_with_line): Remove return.
2427         * tui/tui-disasm.c (tui_show_disassem)
2428         (tui_show_disassem_and_update_source): Remove return.
2429         * tui/tui.c (tui_reset): Remove return.
2430         * tui/tui-wingeneral.c
2431         (tui_check_and_display_highlight_if_needed): Remove return.
2432
2433 2019-07-17  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2436
2437 2019-07-17  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-winsource.h (struct tui_exec_info_window)
2440         (struct tui_source_window_base): Move from tui-data.h.
2441         * tui/tui-winsource.c: Move many method definitions from
2442         elsewhere.  Remove "structuring" comments.
2443         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2444         (tui_source_window_base::refresh_window): Move to
2445         tui-winsource.c.
2446         * tui/tui-win.c (tui_source_window_base::refresh_all)
2447         (tui_source_window_base::update_tab_width)
2448         (tui_source_window_base::set_new_height)
2449         (tui_source_window_base::do_make_visible_with_new_height): Move to
2450         tui-winsource.c.
2451         * tui/tui-source.h: Update.
2452         * tui/tui-source.c (tui_source_window_base::reset): Move to
2453         tui-winsource.c.
2454         * tui/tui-disasm.h: Update.
2455         * tui/tui-data.h (struct tui_exec_info_window): Move to
2456         tui-winsource.h.
2457         (struct tui_source_window_base): Likewise.
2458         * tui/tui-data.c (tui_source_window_base::clear_detail)
2459         (tui_source_window_base, ~tui_source_window_base): Move to
2460         tui-winsource.c.
2461
2462 2019-07-17  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-win.c (tui_resize_all)
2465         (tui_source_window_base::update_tab_width)
2466         (tui_adjust_win_heights): Update.
2467         (tui_win_info::make_invisible_and_set_new_height): Rename from
2468         make_invisible_and_set_new_height.
2469         * tui/tui-data.h (struct tui_win_info)
2470         <make_invisible_and_set_new_height>: New method.
2471
2472 2019-07-17  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui.c: Update.
2475         * tui/tui-source.h (struct tui_source_window): Move from
2476         tui-data.h.
2477         * tui/tui-layout.c: Update.
2478         * tui/tui-disasm.c: Update.
2479         * tui/tui-data.h (struct tui_source_window): Move to
2480         tui-source.h.
2481
2482 2019-07-17  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2485         tui-data.h.
2486         * tui/tui-data.h (struct tui_disasm_window): Move to
2487         tui-disasm.h.
2488
2489 2019-07-17  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-regs.h (struct tui_data_item_window): Move from
2492         tui-data.h.
2493         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2494         * tui/tui-data.h (struct tui_data_item_window): Move to
2495         tui-regs.h.
2496         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2497
2498 2019-07-17  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui.c: Update.
2501         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2502         (tui_cmd_window::max_height): Move to tui-command.c.
2503         * tui/tui-layout.c: Update.
2504         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2505         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2506         tui-command.c.
2507         * tui/tui-command.h (struct tui_cmd_window): Move from
2508         tui-data.h.
2509         * tui/tui-command.c: Remove "structuring" comments.
2510         (tui_cmd_window::clear_detail)
2511         (tui_cmd_window::do_make_visible_with_new_height)
2512         (tui_cmd_window::max_height): Move from elsewhere.
2513
2514 2019-07-17  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2517         Now static.
2518         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2519         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2520
2521 2019-07-17  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui.c: Update.
2524         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2525         tui-regs.c.
2526         * tui/tui-windata.h: Remove file.
2527         * tui/tui-windata.c: Remove file.
2528         * tui/tui-win.c (tui_data_window::set_new_height)
2529         (tui_data_window::do_make_visible_with_new_height): Move to
2530         tui-regs.c.
2531         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2532         * tui/tui-regs.c: Remove "structuring" comments.
2533         (tui_data_window::first_data_item_displayed)
2534         (tui_data_window::delete_data_content_windows)
2535         (tui_data_window::erase_data_content)
2536         (tui_data_window::display_all_data)
2537         (tui_data_window::refresh_all)
2538         (tui_data_window::do_scroll_vertical)
2539         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2540         (tui_data_window::do_make_visible_with_new_height)
2541         (tui_data_window::refresh_window): Move from elsewhere.
2542         (_initialize_tui_regs): Move to end of file.
2543         * tui/tui-layout.c: Update.
2544         * tui/tui-hooks.c: Update.
2545         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2546         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2547         tui-regs.c.
2548         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2549
2550 2019-07-17  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2553         seen.
2554
2555 2019-07-17  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-win.c (tui_source_window_base::set_new_height)
2558         (tui_source_window_base::do_make_visible_with_new_height): Use
2559         m_has_locator field directly.
2560         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2561         method.
2562         (struct tui_source_window_base) <has_locator>: Likewise.
2563
2564 2019-07-17  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2567         Don't declare.
2568         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2569         Remove.
2570         * tui/tui-win.c (tui_source_window_base::set_new_height)
2571         (tui_source_window_base::set_new_height)
2572         (make_invisible_and_set_new_height)
2573         (tui_source_window_base::do_make_visible_with_new_height)
2574         (tui_source_window_base::do_make_visible_with_new_height):
2575         Update.
2576         * tui/tui-layout.c (show_source_disasm_command, show_data)
2577         (show_source_or_disasm_and_command): Update.
2578         * tui/tui-layout.c (show_layout): Update.
2579
2580 2019-07-17  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-layout.c (make_data_window): Remove.
2583         (show_data): Unify creation and re-initialization cases.
2584
2585 2019-07-17  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-layout.c (make_source_window, make_disasm_window):
2588         Remove.
2589         (show_data): Unify creation and re-initialization cases.
2590
2591 2019-07-17  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-layout.c (make_command_window): Remove.
2594         (show_source_disasm_command, show_source_or_disasm_and_command):
2595         Unify creation and re-initialization cases.
2596
2597 2019-07-17  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2600         creation and re-initialization cases.
2601
2602 2019-07-17  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-regs.c (tui_get_register): Return void.
2605
2606 2019-07-17  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2609         Simplify.
2610
2611 2019-07-17  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2614         resetting.
2615
2616 2019-07-17  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2619         * tui/tui-regs.c (tui_reg_layout): New function.
2620         (tui_show_registers, tui_reg_command): Use it.
2621         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2622         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2623         parameters.
2624         (tui_layout_command): Remove.
2625
2626 2019-07-17  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-layout.h (tui/tui-layout): Return void.
2629         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2630
2631 2019-07-17  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-layout.c (show_source_disasm_command, show_data):
2634         Update.
2635         (reset_locator): Remove.
2636         (show_source_or_disasm_and_command): Update.
2637
2638 2019-07-17  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-source.c (tui_source_window_base::reset): Remove
2641         win_type parameter.
2642         * tui/tui-layout.c (make_command_window, make_source_window)
2643         (make_disasm_window, make_data_window)
2644         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2645         (reset_locator, show_source_or_disasm_and_command): Update.
2646         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2647         win_type parameter.
2648         (struct tui_source_window_base) <reset>: Likewise.
2649
2650 2019-07-17  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-layout.c (show_source_disasm_command): Use
2653         reset_locator.
2654         (reset_locator): New function.
2655         (init_and_make_win): Remove.
2656         (show_source_or_disasm_and_command): Use reset_locator.
2657
2658 2019-07-17  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2661         condition.
2662         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2663         Remove condition.
2664         * tui/tui-source.c (tui_source_window_base::reset): New method.
2665         * tui/tui-layout.c (make_command_window): Don't call
2666         init_and_make_win.
2667         (make_source_window, make_disasm_window): Don't call
2668         make_source_or_disasm_window.
2669         (make_data_window): Don't call init_and_make_win.  Change calling
2670         convention.
2671         (show_source_disasm_command, show_data): Simplify.
2672         (make_source_or_disasm_window): Remove.
2673         (show_source_or_disasm_and_command): Simplify.
2674         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2675         (struct tui_source_window_base) <reset>: Likewise.
2676         <execution_info>: Remove initializer.
2677         * tui/tui-data.c (tui_source_window_base): Initialize
2678         execution_info.
2679
2680 2019-07-17  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2683         variable.
2684
2685 2019-07-17  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui.c (tui_rl_other_window): Update.
2688         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2689         superclass method first.  Always iterate over regs_content.
2690         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2691         method.
2692         * tui/tui-win.c (tui_set_focus_command): Update.
2693
2694 2019-07-17  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-win.c (tui_set_focus_command): Rename from
2697         tui_set_focus.  Call tui_enable.
2698         (tui_set_focus_command): Remove.
2699
2700 2019-07-17  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2703         refresh_window.
2704         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2705         touchwin.
2706         (tui_data_window::refresh_window): Call refresh_window on data
2707         items.  Always call superclass refresh_window.
2708         (tui_win_info::refresh): Remove.
2709         (tui_source_window_base::refresh_window): Update.
2710         (tui_refresh_all): Update.
2711         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2712         refresh_window.
2713         (show_source_or_disasm_and_command): Likewise.
2714         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2715         (struct tui_source_window_base) <refresh>: Likewise.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-winsource.c (tui_clear_source_content)
2720         (tui_show_source_content): Update.
2721         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2722         whether content is empty.
2723         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2724         Remove.
2725
2726 2019-07-17  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2729         window's contents.
2730         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2731         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2732
2733 2019-07-17  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2736         (struct tui_data_item_window): Update.
2737
2738 2019-07-17  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2741         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2742         defines.
2743
2744 2019-07-17  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-winsource.h (tui_erase_source_content)
2747         (tui_clear_source_content): Remove "display_prompt" parameter.
2748         * tui/tui-winsource.c (tui_update_source_window_as_is)
2749         (tui_update_source_windows_with_addr): Update.
2750         (tui_clear_source_content): Remove "display_prompt" parameter.
2751         (tui_erase_source_content): Likewise.  Simplify.
2752         (tui_show_source_content): Update.
2753         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2754         * tui/tui-stack.c (tui_show_frame_info): Update.
2755         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2756         Remove defines.
2757
2758 2019-07-17  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2761         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2762         parameter.
2763         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2764         parameter.
2765
2766 2019-07-17  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-winsource.c (tui_clear_source_content)
2769         (tui_show_source_content, tui_show_exec_info_content)
2770         (tui_clear_exec_info_content): Update.
2771         * tui/tui-stack.c (tui_show_locator_content): Update.
2772         (tui_show_frame_info): Update.
2773         * tui/tui-source.h (tui_source_window): Don't declare.
2774         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2775         from tui_source_is_displayed.
2776         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2777         Remove field.
2778         (struct tui_source_window_base) <content_in_use>: New field.  Now
2779         bool.
2780         (struct tui_source_window) <showing_source_p>: New method.
2781         (TUI_SRC_WIN): Change cast.
2782         * tui/tui-data.c (tui_initialize_static_data): Update.
2783
2784 2019-07-17  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2787         location_matches_p.
2788         * tui/tui-source.c (tui_source_window::location_matches_p): New
2789         method.
2790         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2791         method.
2792         * tui/tui-data.h (struct tui_source_window_base)
2793         <location_matches_p>: New method.
2794         (struct tui_source_window, struct tui_disasm_window)
2795         <location_matches_p>: Likewise.
2796
2797 2019-07-17  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-win.c (tui_set_win_height_command): Rename from
2800         tui_set_win_height.
2801         (tui_set_win_height_command): Remove.
2802
2803 2019-07-17  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-source.c (tui_source_window): New constructor.  Add
2806         observer.
2807         (~tui_source_window): New destructor.
2808         (tui_source_window::style_changed): New method.
2809         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2810         (tui_attach_detach_observers): Update.
2811         * tui/tui-data.h (struct tui_source_window): Make constructor not
2812         inline.  Add destructor.
2813         (struct tui_source_window) <style_changed>: New method.
2814         <m_observable>: New member.
2815
2816 2019-07-17  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2819         * tui/tui-win.c (tui_resize_all): Fix typo.
2820
2821 2019-07-17  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2824         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2825         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2826         * tui/tui-win.c (window_name_completer): Use foreach.
2827         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2828         (update_tab_width): Likewise.
2829         * tui/tui-layout.c (show_layout): Update.
2830         * tui/tui-data.h (class tui_window_iterator): New.
2831         (struct all_tui_windows): New.
2832         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2833
2834 2019-07-17  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2837         parameter.  Don't reference globals.
2838         (tui_reg_command): Update.
2839
2840 2019-07-17  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-regs.c (tui_show_registers): Simplify.
2843
2844 2019-07-17  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-regs.c (tui_show_registers): Update.
2847         (tui_show_register_group): Add win_info parameter.
2848
2849 2019-07-17  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2852         Rename from tui_display_reg_element_at_line.
2853         (tui_data_window::display_registers_from_line): Update.
2854         * tui/tui-data.h (struct tui_data_window)
2855         <display_reg_element_at_line>: New method.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-regs.h (tui_display_registers_from)
2860         (tui_display_registers_from_line): Don't declare.
2861         * tui/tui-windata.c (tui_data_window::display_all_data)
2862         (tui_data_window::refresh_all)
2863         (tui_data_window::do_scroll_vertical): Update.
2864         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2865         from tui_display_registers_from.
2866         (tui_display_reg_element_at_line): Update.
2867         (tui_data_window::display_registers_from_line): Rename from
2868         tui_display_registers_from_line.
2869         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2870         display_registers_from_line>: New methods.
2871
2872 2019-07-17  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2875         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2876         from tui_erase_data_content.
2877         (tui_data_window::display_all_data)
2878         (tui_data_window::refresh_all)
2879         (tui_data_window::do_scroll_vertical): Update.
2880         * tui/tui-regs.c (tui_show_registers): Update.
2881         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2882         New method.
2883
2884 2019-07-17  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2887         declare.
2888         * tui/tui-windata.c
2889         (tui_data_window::delete_data_content_windows): Rename from
2890         tui_delete_data_content_windows.
2891         (tui_data_window::display_all_data)
2892         (tui_data_window::do_scroll_vertical): Update.
2893         * tui/tui-data.h (struct tui_data_window)
2894         <delete_data_content_windows>: New method.
2895
2896 2019-07-17  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2899         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2900
2901 2019-07-17  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2904         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2905         from tui_display_all_data.
2906         * tui/tui-win.c
2907         (tui_data_window::do_make_visible_with_new_height): Update.
2908         * tui/tui-regs.c (tui_show_registers): Update.
2909         * tui/tui-layout.c (tui_set_layout): Update.
2910         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2911         method.
2912
2913 2019-07-17  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2916         * tui/tui-windata.c (tui_display_data_from): Remove.
2917         (tui_data_window::refresh_all): Update.
2918
2919 2019-07-17  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2922         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2923         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2924         tui_display_registers_from_line.
2925         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2926         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2927         "force_display" parameter.
2928
2929 2019-07-17  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2932         declare.
2933         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2934         Rename from tui_first_reg_element_no_inline.
2935         (tui_display_reg_element_at_line)
2936         (tui_display_registers_from_line): Update.
2937         * tui/tui-data.h (struct tui_data_window)
2938         <first_reg_element_no_inline>: New method.
2939
2940 2019-07-17  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-windata.c (tui_display_data_from)
2943         (tui_data_window::do_scroll_vertical): Update.
2944         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2945         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2946         Rename from tui_line_from_reg_element_no.
2947         (tui_display_registers_from_line): Update.
2948         * tui/tui-data.h (struct tui_data_window)
2949         <line_from_reg_element_no>: New method.
2950
2951 2019-07-17  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2954         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2955         tui_last_regs_line_no.
2956         (tui_display_reg_element_at_line)
2957         (tui_display_registers_from_line): Update.
2958         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2959         method.
2960
2961 2019-07-17  Tom Tromey  <tom@tromey.com>
2962
2963         PR tui/24722:
2964         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2965         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2966         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2967         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2968         (tui_update_breakpoint_info): Likewise.
2969         * tui/tui-hooks.c (tui_event_create_breakpoint)
2970         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2971         Update.
2972
2973 2019-07-17  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2976
2977 2019-07-17  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-winsource.c (tui_update_source_window_as_is)
2980         (tui_update_source_windows_with_addr): Update.
2981         * tui/tui-source.h (tui_set_source_content)
2982         (tui_show_symtab_source): Add "win_info" parameter.
2983         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2984         parameter.
2985         (tui_show_symtab_source): Likewise.
2986
2987 2019-07-17  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-wingeneral.c
2990         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2991
2992 2019-07-17  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2995         (struct tui_cmd_window) <can_scroll>: New method.
2996         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2997         method.
2998
2999 2019-07-17  Tom Tromey  <tromey@adacore.com>
3000
3001         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3002         do_field_signed>: Rename.  Change type of "value".
3003         * ui-out.c (ui_out::field_signed): Rename from field_int.
3004         Change type of "value".
3005         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3006         type of "value".
3007         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3008         do_field_int.  Change type of "value".
3009         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3010         do_field_int.  Change type of "value".
3011         * tracepoint.c (trace_status_mi, tfind_1)
3012         (print_one_static_tracepoint_marker): Update.
3013         * thread.c (print_thread_info_1, print_selected_thread_frame):
3014         Update.
3015         * stack.c (print_frame, print_frame_info): Update.
3016         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3017         Update.
3018         * source.c (print_source_lines_base): Update.
3019         * skip.c (info_skip_command): Update.
3020         * record-btrace.c (btrace_ui_out_decode_error)
3021         (btrace_call_history_src_line): Update.
3022         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3023         Update.
3024         * progspace.c (print_program_space): Update.
3025         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3026         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3027         do_field_int.  Change type of "value".
3028         * mi/mi-out.c (mi_ui_out::do_table_begin)
3029         (mi_ui_out::do_table_header): Update.
3030         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3031         type of "value".
3032         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3033         (mi_cmd_data_list_changed_registers, output_register)
3034         (mi_cmd_data_read_memory, mi_load_progress)
3035         (mi_cmd_trace_frame_collected): Update.
3036         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3037         Update.
3038         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3039         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3040         (mi_cmd_var_list_children, varobj_update_one): Update.
3041         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3042         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3043         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3044         * inferior.c (print_inferior): Update.
3045         * gdb_bfd.c (print_one_bfd): Update.
3046         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3047         Update.
3048         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3049         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3050         do_field_int.  Change type of "value".
3051         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3052         do_field_int.  Change type of "value".
3053         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3054         (print_one_breakpoint_location, print_it_catch_fork)
3055         (print_one_catch_fork, print_it_catch_vfork)
3056         (print_one_catch_vfork, print_it_catch_solib)
3057         (print_it_catch_exec, print_it_ranged_breakpoint)
3058         (print_mention_watchpoint, print_mention_masked_watchpoint)
3059         (bkpt_print_it, update_static_tracepoint): Update.
3060         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3061         * break-catch-syscall.c (print_it_catch_syscall): Update.
3062         * ada-tasks.c (print_ada_task_info): Update.
3063         * ada-lang.c (print_it_exception, print_mention_exception):
3064         Update.
3065
3066 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         PR breakpoints/24541
3069         * gdbarch.c: Regenerate.
3070         * gdbarch.h: Regenerate.
3071         * gdbarch.sh: Adjust return type and parameter types for
3072         'stap_adjust_register'.
3073         (i386_stap_adjust_register): Adjust signature and return new
3074         register name.
3075         * stap-probe.c (stap_parse_register_operand): Adjust use of
3076         'gdbarch_stap_adjust_register'.
3077
3078 2019-07-17  Tom Tromey  <tromey@adacore.com>
3079
3080         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3081         declare VEC.
3082         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3083         std::vector.
3084         (struct s390_process_info): Add initializers.
3085         (s390_add_process): Use new.
3086         (s390_linux_nat_target::low_forget_process): Use delete.
3087         (s390_linux_nat_target::low_new_fork)
3088         (s390_linux_nat_target::stopped_by_watchpoint)
3089         (s390_linux_nat_target::low_prepare_to_resume)
3090         (s390_linux_nat_target::insert_watchpoint)
3091         (s390_linux_nat_target::insert_hw_breakpoint)
3092         (s390_linux_nat_target::remove_watchpoint)
3093         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3094
3095 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3096
3097         * aarch64-fbsd-nat.c: Include regcache.h.
3098         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3099         argument.
3100         (aarch64_fbsd_nat_target::fetch_registers)
3101         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3102         variable.
3103         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3104
3105 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3106
3107         * fbsd-nat.c: Include gdbarch.h.
3108
3109 2019-07-15  Tom Tromey  <tromey@adacore.com>
3110
3111         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3112
3113 2019-07-15  Tom Tromey  <tromey@adacore.com>
3114
3115         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3116         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3117         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3118         * cli-out.c (cli_ui_out::do_field_int): New method.
3119         * ui-out.c (ui_out::field_unsigned): New method.
3120         * symfile.c (generic_load): Use field_unsigned.
3121         (print_transfer_performance): Likewise.
3122         * record-btrace.c (ui_out_field_uint): Remove.
3123         (btrace_call_history_insn_range, btrace_call_history): Use
3124         field_unsigned.
3125         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3126         field_unsigned.
3127         * ui-out.h (class ui_out) <field_unsigned>: New method.
3128         <do_field_unsigned>: Likewise.
3129
3130 2019-07-15  Tom Tromey  <tromey@adacore.com>
3131
3132         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3133         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3134         * target.c (flash_erase_command): Use field_string.
3135         * infrun.c (print_signal_received_reason): Use field_string.
3136         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3137         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3138         field_string.
3139         * ada-tasks.c (print_ada_task_info): Use field_string.
3140
3141 2019-07-15  Tom Tromey  <tromey@adacore.com>
3142
3143         * target.c (flash_erase_command): Use field_core_addr.
3144         * symfile.c (generic_load): Use field_core_addr.
3145         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3146         Use field_core_addr.
3147         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3148         field_core_addr.
3149
3150 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3153         value if its desired type is smaller than a CORE_ADDR and signed.
3154
3155 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3158         of changes to field names, and use new is_reference field to
3159         decide if a property is a reference or not.
3160         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3161         field.
3162         (struct dwarf2_property_baton): Update header comment, rename
3163         'referenced_type' to 'property_type' and update comments.
3164         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3165         default property type, store in property baton, update to take
3166         accound of renamed field.
3167         (read_func_scope): Update call to attr_to_dynamic_prop.
3168         (read_array_type): Likewise.
3169         (dwarf2_per_cu_addr_sized_int_type): New function.
3170         (read_subrange_index_type): Move type finding code to
3171         dwarf2_per_cu_addr_sized_int_type.
3172         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3173         (dwarf2_per_cu_addr_type): New function.
3174         (set_die_type): Update calls to attr_to_dynamic_prop.
3175
3176 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * dwarf2read.c (read_subrange_index_type): New function.
3179         (read_subrange_type): Move code into new function and call it.
3180         * gdbtypes.c (create_range_type): Add some asserts.
3181
3182 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3183
3184         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3185         update return statements.
3186         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3187         declaration, and update comment to match.
3188         * gdbtypes.c (resolve_dynamic_array): Update call to
3189         dwarf2_evaluate_property to match new return type.
3190
3191 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * valarith.c (value_subscripted_rvalue): Change lowerbound
3194         parameter type from int to LONGEST.
3195         * value.h (value_subscripted_rvalue): Likewise in declaration.
3196
3197 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * cli/cli-utils.c (info_print_command_completer): New function.
3200         * cli/cli-utils.h: Add 'completer.h' include, and forward
3201         declaration for 'struct cmd_list_element'.
3202         (info_print_command_completer): Declare.
3203         * stack.c (_initialize_stack): Add completer for 'info locals' and
3204         'info args'.
3205         * symtab.c (_initialize_symtab): Add completer for 'info
3206         variables' and 'info functions'.
3207         * NEWS: Mention completion for additional info commands.
3208
3209 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * cli/cli-utils.c (extract_info_print_args): Delete.
3212         (extract_arg_maybe_quoted): Delete.
3213         (info_print_options_defs): New variable.
3214         (make_info_print_options_def_group): New function.
3215         (extract_info_print_options): Define new function.
3216         * cli/cli-utils.h (extract_info_print_args): Delete.
3217         (struct info_print_options): New structure.
3218         (extract_info_print_options): Declare new function.
3219         * stack.c (info_locals_command): Update to use new
3220         extract_info_print_options, also add a header comment.
3221         (info_args_command): Likewise.
3222         * symtab.c (info_variables_command): Likewise.
3223         (info_functions_command): Likewise.
3224
3225 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3228         to extract string arguments.
3229         * common/common-utils.c (extract_string_maybe_quoted): New function.
3230         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3231
3232 2019-07-11  Tom Tromey  <tromey@adacore.com>
3233
3234         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3235         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3236         * top.h (gdbinit): Don't declare.
3237         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3238         into...
3239         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3240         * top.c (gdb_init): Don't call init_cli_cmds.
3241         (gdbinit): Remove.
3242         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3243
3244 2019-07-11  Tom Tromey  <tromey@adacore.com>
3245
3246         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3247         after it has been moved.
3248
3249 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3250
3251         * valops.c (value_must_coerce_to_target): Change return type to
3252         bool.
3253         * value.h (value_must_coerce_to_target): Likewise.
3254
3255 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * breakpoint.c (is_hardware_watchpoint): Remove
3258         forward-declaration.
3259         (is_masked_watchpoint): Change return type to bool.
3260         (is_tracepoint): Likewise.
3261         (is_breakpoint): Likewise.
3262         (is_hardware_watchpoint): Likewise.
3263         (is_watchpoint): Likewise.
3264         (is_no_memory_software_watchpoint): Likewise.
3265         (is_catchpoint): Likewise.
3266         (breakpoint_1): Make FILTER parameter's return type bool.
3267         is_masked_watchpoint): Change return type to bool.
3268         (save_breakpoints): Make FILTER parameter's return type bool.
3269         * breakpoint.h (is_breakpoint): Change return type to bool.
3270         (is_watchpoint): Likewise.
3271         (is_catchpoint): Likewise.
3272         (is_tracepoint): Likewise.
3273
3274 2019-07-10  Tom Tromey  <tom@tromey.com>
3275
3276         * defs.h: Don't include gdbarch.h.
3277         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3278         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3279         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3280         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3281         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3282         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3283         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3284         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3285         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3286         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3287         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3288         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3289         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3290         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3291         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3292         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3293         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3294         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3295         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3296         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3297         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3298         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3299         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3300         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3301         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3302         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3303         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3304
3305 2019-07-10  Tom Tromey  <tromey@adacore.com>
3306
3307         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3308         * breakpoint.c (init_ada_exception_breakpoint): Register as
3309         bp_catchpoint.
3310         (print_one_breakpoint_location, print_one_breakpoint): Use
3311         is_ada_exception_catchpoint.
3312         * ada-lang.c (class ada_catchpoint_location): Pass
3313         bp_loc_software_breakpoint to bp_location constructor.
3314         (is_ada_exception_catchpoint): New function.
3315
3316 2019-07-10  Tom Tromey  <tromey@adacore.com>
3317
3318         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3319         VEC.
3320         (struct arm_exidx_entry): New method operator<.
3321         (struct arm_exidx_data) <section_maps>: Change type.
3322         (arm_exidx_data_free): Remove.
3323         (arm_exidx_data_key): Change type.  Move lower.
3324         (arm_exidx_new_objfile): Update.
3325         (arm_compare_exidx_entries): Remove.
3326         (arm_find_exidx_entry, _initialize_arm_tdep)
3327
3328 2019-07-10  Tom Tromey  <tromey@adacore.com>
3329
3330         * solib-spu.c (ocl_program_data_key): Change type.
3331         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3332         Update.
3333
3334 2019-07-10  Tom Tromey  <tromey@adacore.com>
3335
3336         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3337         (struct solib_aix_inferior_data) <library_list>: Change type.
3338         (solib_aix_inferior_data_handle): Change type.
3339         (get_solib_aix_inferior_data): Update.
3340         (solib_aix_free_library_list): Remove.
3341         (library_list_start_library): Update.
3342         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3343         return type.
3344         (solib_aix_get_library_list)
3345         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3346         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3347
3348 2019-07-10  Tom Tromey  <tromey@adacore.com>
3349
3350         * solib-dsbt.c (struct dsbt_info): Add initializers.
3351         (solib_dsbt_pspace_data): Change type.
3352         (dsbt_pspace_data_cleanup): Remove.
3353         (get_dsbt_info, _initialize_dsbt_solib): Update.
3354
3355 2019-07-10  Tom Tromey  <tromey@adacore.com>
3356
3357         * spu-tdep.c (spu_overlay_data): Change type.
3358         (spu_get_overlay_table, spu_overlay_new_objfile)
3359         (_initialize_spu_tdep): Update.
3360
3361 2019-07-10  Tom Tromey  <tromey@adacore.com>
3362
3363         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3364         destructor.
3365         (dbx_objfile_data_key): Change type and declare later.
3366         (DBX_SYMFILE_INFO): Rewrite.
3367         * dbxread.c (dbx_objfile_data_key): Change type.
3368         (dbx_symfile_init): Update.
3369         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3370         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3371         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3372
3373 2019-07-10  Tom Tromey  <tromey@adacore.com>
3374
3375         * jit.c (jit_program_space_key): Change type.  Move lower.
3376         (get_jit_program_space_data): Update.
3377         (jit_program_space_data_cleanup): Remove.
3378         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3379         Update.
3380         (struct jit_program_space_data): Add initializers.
3381
3382 2019-07-10  Tom Tromey  <tromey@adacore.com>
3383
3384         * solib-darwin.c (struct darwin_info): Add initializers.
3385         (solib_darwin_pspace_data): Change type.
3386         (darwin_pspace_data_cleanup): Remove.
3387         (get_darwin_info, _initialize_darwin_solib): Update.
3388
3389 2019-07-10  Tom Tromey  <tromey@adacore.com>
3390
3391         * remote-sim.c (struct sim_inferior_data): Add initializers,
3392         constructor, and destructor.
3393         (sim_inferior_data_key): Change type.  Move lower.
3394         (check_for_duplicate_sim_descriptor): Update.
3395         (get_sim_inferior_data): Use new.  Update.
3396         (~sim_inferior_data_cleanup): Rename from
3397         sim_inferior_data_cleanup.  Simplify.
3398         (gdbsim_close_inferior, simulator_command)
3399         (sim_command_completer, _initialize_remote_sim): Update.
3400         (next_pid, INITIAL_PID): Move earlier.
3401
3402 2019-07-10  Tom Tromey  <tromey@adacore.com>
3403
3404         * python/python-internal.h (create_thread_object): Return
3405         gdbpy_ref.
3406         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3407         * python/py-inferior.c (struct threadlist_entry): Add
3408         constructor.
3409         <thread_obj>: Now a gdbpy_ref.
3410         (thread_to_thread_object): Update.
3411         (add_thread_object): Use new.
3412         (delete_thread_object): Use delete.
3413         (infpy_threads): Update.
3414         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3415         GIL.
3416
3417 2019-07-10  Tom Tromey  <tromey@adacore.com>
3418
3419         * valops.c (value_cast): Specialize error message for Ada.
3420
3421 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3422
3423         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3424
3425 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3426
3427         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3428         bpstat_should_step): Return bool, adjust comments.
3429         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3430         bpstat_should_step): Likewise.
3431
3432 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3433
3434         * features/Makefile: Use feature target descriptions for Arm.
3435         * features/arm/arm-core.c: Generate new file.
3436         * features/arm/arm-fpa.c: Likewise.
3437         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3438         * features/arm/arm-m-profile.c: Likewise.
3439         * features/arm/arm-vfpv2.c: Likewise.
3440         * features/arm/arm-vfpv3.c: Likewise.
3441         * features/arm/xscale-iwmmxt.c: Likewise.
3442         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3443
3444 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3445
3446         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3447         ptrace earlier.
3448
3449 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3450
3451         * features/aarch64-pauth.c: Regenerate.
3452
3453 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3454
3455         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3456         bool.
3457         (bpstat_what): Use false instead of 0.
3458
3459 2019-07-09  Pedro Alves  <palves@redhat.com>
3460
3461         * break-catch-throw.c (is_exception_catchpoint): New.
3462         * breakpoint.c (print_one_breakpoint_location): New parameter
3463         'raw_loc'.  Handle it.  Use
3464         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3465         looking at the breakpoint's type.
3466         (print_one_breakpoint): If handling "maint info breakpoints", also
3467         print locations of exception catchpoints.
3468         * breakpoint.h (is_exception_catchpoint): Declare.
3469
3470 2019-07-09  Pedro Alves  <palves@redhat.com>
3471
3472         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3473         "addr" field.
3474         (allocate_location_exception_catchpoint): New.
3475         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3476         (initialize_throw_catchpoint_ops): Install
3477         allocate_location_exception_catchpoint as allocate_location
3478         method.
3479         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3480         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3481         bp_loc_other.
3482         (breakpoint_address_is_meaningful): Delete.
3483         (bl_address_is_meaningful): New.
3484         (breakpoint_locations_match): Adjust comment.
3485         (bp_location_from_bp_type): New, factored out of...
3486         (bp_location::bp_location(breakpoint *)): ... this.
3487         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3488         factored out of...
3489         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3490         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3491         breakpoint_address_is_meaningful.
3492         (bp_locations_compare): Adjust comment.
3493         (update_global_location_list): Use bl_address_is_meaningful
3494         instead of breakpoint_address_is_meaningful.
3495         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3496         explicit.
3497         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3498         * python/py-breakpoint.c (bppy_get_location): No longer check
3499         whether location is null.
3500
3501 2019-07-09  Pedro Alves  <palves@redhat.com>
3502
3503         PR c++/15468
3504         * breakpoint.c (print_one_breakpoint_location): Remove
3505         single-location assert.
3506
3507 2019-07-09  Tom Tromey  <tom@tromey.com>
3508
3509         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3510         * configure: Rebuild.
3511         * configure.ac: Change common to gdbsupport.
3512         * gdbsupport: Rename from common.
3513         * acinclude.m4: Change common to gdbsupport.
3514         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3515         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3516         gdbsupport.
3517         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3518         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3519         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3520         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3521         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3522         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3523         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3524         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3525         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3526         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3527         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3528         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3529         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3530         coff-pe-read.c, command.h, compile/compile-c-support.c,
3531         compile/compile-c.h, compile/compile-cplus-symbols.c,
3532         compile/compile-cplus-types.c, compile/compile-cplus.h,
3533         compile/compile-loc2c.c, compile/compile.c, completer.c,
3534         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3535         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3536         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3537         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3538         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3539         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3540         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3541         features/aarch64-core.c, features/aarch64-fpu.c,
3542         features/aarch64-pauth.c, features/aarch64-sve.c,
3543         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3544         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3545         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3546         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3547         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3548         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3549         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3550         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3551         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3552         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3553         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3554         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3555         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3556         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3557         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3558         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3559         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3560         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3561         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3562         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3563         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3564         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3565         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3566         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3567         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3568         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3569         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3570         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3571         minsyms.c, mips-linux-tdep.c, namespace.h,
3572         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3573         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3574         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3575         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3576         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3577         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3578         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3579         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3580         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3581         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3582         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3583         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3584         procfs.c, producer.c, progspace.h, psymtab.h,
3585         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3586         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3587         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3588         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3589         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3590         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3591         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3592         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3593         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3594         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3595         target-memory.c, target.c, target.h, target/waitstatus.c,
3596         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3597         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3598         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3599         unittests/array-view-selftests.c,
3600         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3601         unittests/common-utils-selftests.c,
3602         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3603         unittests/format_pieces-selftests.c,
3604         unittests/function-view-selftests.c,
3605         unittests/lookup_name_info-selftests.c,
3606         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3607         unittests/mkdir-recursive-selftests.c,
3608         unittests/observable-selftests.c,
3609         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3610         unittests/parse-connection-spec-selftests.c,
3611         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3612         unittests/scoped_fd-selftests.c,
3613         unittests/scoped_mmap-selftests.c,
3614         unittests/scoped_restore-selftests.c,
3615         unittests/string_view-selftests.c, unittests/style-selftests.c,
3616         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3617         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3618         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3619         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3620         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3621         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3622
3623 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3626         bool value.
3627         (decode_digits_ordinary): Set explicit_line field in sal.
3628         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3629         symtab_and_line that was set on an explicit line number in
3630         assembler code.  Do always update the recorded symtab and line if
3631         we do skip the prologue.
3632
3633 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3634
3635         * breakpoint.c (set_breakpoint_location_function): Remove
3636         explicit_loc parameter.
3637         (momentary_breakpoint_from_master): Update call to
3638         set_breakpoint_location_function.
3639         (add_location_to_breakpoint): Likewise.
3640
3641 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3644         required features based on default bfd type when no specific bfd
3645         is present.
3646
3647 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3648
3649         * NEWS: Mention that GDB printf and eval commands can now print
3650         C-style and Ada-style convenience var strings without
3651         calling the inferior.
3652         * printcmd.c (printf_c_string): Locally print GDB internal var
3653         instead of transiting via the inferior.
3654         (printf_wide_c_string): Likewise.
3655
3656 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3657
3658         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3659
3660 2019-07-04  Tom Tromey  <tom@tromey.com>
3661
3662         PR tui/24724:
3663         * tui/tui-winsource.c (tui_clear_source_content): Update.
3664         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3665         (tui_update_breakpoint_info): Update.
3666         (tui_set_exec_info_content): Update.
3667         * tui/tui-source.c (tui_set_source_content_nil): Update.
3668         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3669         has_break.
3670         * tui/tui-data.h (enum tui_bp_flag): New.
3671         (tui_bp_flags): New enum flags type.
3672         (struct tui_source_element) <break_mode>: Change type.  Rename
3673         from has_break.
3674         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3675         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3676         constants.
3677         * tui/tui-winsource.h: Fix comment.
3678
3679 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3682         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3683         (store_fpregs_to_thread)
3684         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3685         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3686         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3687         (IWMMXT_REGS_SIZE): Add define.
3688         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3689         (fetch_vfp_regs, store_vfp_regs)
3690         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3691         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3692
3693 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3694
3695         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3696         defines.
3697         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3698         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3699         (ARM_INT_REGISTER_SIZE): ...to this.
3700         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3701         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3702         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3703         (arm_linux_collect_gregset, supply_nwfpe_register)
3704         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3705         defines.
3706         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3707         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3708         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3709         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3710         (arm_return_in_memory, arm_store_return_value)
3711         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3712         (arm_record_ld_st_multiple): Likewise.
3713         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3714         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3715
3716 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3717
3718         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3719         AARCH64_DISPLACED_MODIFIED_INSNS.
3720         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3721         (aarch64_displaced_step_copy_insn): Likewise.
3722         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3723         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3724         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3725         ARM_DISPLACED_MODIFIED_INSNS.
3726         * arm-tdep.c (arm_gdbarch_init): Likewise.
3727         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3728         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3729         (struct arm_displaced_step_closure): Use
3730         ARM_DISPLACED_MODIFIED_INSNS.
3731
3732 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3733
3734         * features/Makefile: Remove unused xml files.
3735         * features/aarch64.xml: Remove.
3736         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3737         * features/i386/amd64-avx-avx512.xml: Remove.
3738         * features/i386/amd64-avx-linux.xml: Remove.
3739         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3740         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3741         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3742         * features/i386/amd64-avx-mpx.xml: Remove.
3743         * features/i386/amd64-avx.xml: Remove.
3744         * features/i386/amd64-linux.xml: Remove.
3745         * features/i386/amd64-mpx-linux.xml: Remove.
3746         * features/i386/amd64-mpx.xml: Remove.
3747         * features/i386/amd64.xml: Remove.
3748         * features/i386/i386-avx-avx512-linux.xml: Remove.
3749         * features/i386/i386-avx-avx512.xml: Remove.
3750         * features/i386/i386-avx-linux.xml: Remove.
3751         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3752         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3753         * features/i386/i386-avx-mpx-linux.xml: Remove.
3754         * features/i386/i386-avx-mpx.xml: Remove.
3755         * features/i386/i386-avx.xml: Remove.
3756         * features/i386/i386-linux.xml: Remove.
3757         * features/i386/i386-mmx-linux.xml: Remove.
3758         * features/i386/i386-mmx.xml: Remove.
3759         * features/i386/i386-mpx-linux.xml: Remove.
3760         * features/i386/i386-mpx.xml: Remove.
3761         * features/i386/i386.xml: Remove.
3762         * features/i386/x32-avx-avx512-linux.xml: Remove.
3763         * features/i386/x32-avx-linux.xml: Remove.
3764         * features/i386/x32-linux.xml: Remove.
3765
3766 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3767
3768         * regformats/aarch64.dat: Remove.
3769         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3770         * regformats/i386/amd64-avx-linux.dat: Remove.
3771         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3772         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3773         * regformats/i386/amd64-linux.dat: Remove.
3774         * regformats/i386/amd64-mpx-linux.dat: Remove.
3775         * regformats/i386/amd64.dat: Remove.
3776         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3777         * regformats/i386/i386-avx-linux.dat: Remove.
3778         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3779         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3780         * regformats/i386/i386-linux.dat: Remove.
3781         * regformats/i386/i386-mmx-linux.dat: Remove.
3782         * regformats/i386/i386-mpx-linux.dat: Remove.
3783         * regformats/i386/i386.dat: Remove.
3784         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3785         * regformats/i386/x32-avx-linux.dat: Remove.
3786         * regformats/i386/x32-linux.dat: Remove.
3787
3788 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3789
3790         * aarch64-tdep.c: Remove xml self tests.
3791         * amd64-linux-tdep.c: Likewise.
3792         * amd64-tdep.c: Likewise.
3793         * i386-linux-tdep.c: Likewise.
3794         * i386-tdep.c: Likewise.
3795
3796 2019-07-03  Pedro Alves  <palves@redhat.com>
3797
3798         PR cli/24732
3799         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3800         (pipe_cmd_option_defs): New.
3801         (make_pipe_cmd_options_def_group): New.
3802         (pipe_command): Use gdb::option::process_options.
3803         (pipe_command_completer): New function.
3804         (_initialize_cli_cmds): Install completer for "pipe" command.
3805
3806 2019-07-03  Pedro Alves  <palves@redhat.com>
3807
3808         * cli/cli-option.c (union option_value) <string>: New field.
3809         (struct option_def_and_value): Add ctor, move ctor, dtor and
3810         use DISABLE_COPY_AND_ASSIGN.
3811         (option_def_and_value::clear_value): New.
3812         (parse_option, save_option_value_in_ctx, get_val_type_str)
3813         (add_setshow_cmds_for_options): Handle var_string.
3814         * cli-option.h (union option_def::var_address) <string>: New
3815         field.
3816         (struct string_option_def): New.
3817         * maint-test-options.c (struct test_options_opts): Add default
3818         ctor and use DISABLE_COPY_AND_ASSIGN.
3819         <string_opt>: New field.
3820         (test_options_opts::~test_options_opts): New.
3821         (test_options_opts::dump): Also dump "-string".
3822         (test_options_option_defs): Install "string.
3823
3824 2019-07-03  Pedro Alves  <palves@redhat.com>
3825
3826         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3827         option_value with a null enumeration.
3828         (complete_options): Save the option values in the context.
3829         (save_option_value_in_ctx): New, factored out from ...
3830         (process_options): ... here.
3831         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3832         of the function.
3833         * maint-test-options.c (test_options_opts::dump): New, factored
3834         out from ...
3835         (maintenance_test_options_command_mode): ... here.
3836         (maintenance_test_options_command_completion_result): Delete.
3837         (maintenance_test_options_command_completion_text): Update
3838         comment.
3839         (maintenance_show_test_options_completion_result): Change
3840         prototype.  Just print
3841         maintenance_test_options_command_completion_text.
3842         (save_completion_result): New.
3843         (maintenance_test_options_completer_mode): Pass options context to
3844         complete_options, and then save a dump.
3845         (_initialize_maint_test_options): Use add_cmd to install "maint
3846         show test-options-completion-result".
3847
3848 2019-07-03  Pedro Alves  <palves@redhat.com>
3849
3850         * NEWS (New commands): Mention "with" and "maint with".
3851         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3852         (with_command, with_command_completer): New.
3853         (pipe_command): Adjust to new repeat_previous
3854         interface.
3855         (_initialize_cli_cmds): Install the "with" command and its "w"
3856         alias.
3857         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3858         declarations.
3859         * cli/cli-setshow.c (parse_cli_var_uinteger)
3860         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3861         argument strings for all var_types.
3862         (get_setshow_command_value_string): New, factored out from ...
3863         (do_show_command): ... this.
3864         * cli/cli-setshow.h: Include <string>.
3865         (get_setshow_command_value_string): Declare.
3866         * command.h (repeat_previous): Now returns const char *.  Adjust
3867         comment.
3868         * maint.c: Include "cli/cli-cmds.h".
3869         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3870         (_initialize_maint_cmds): Register the "maintenance with" command.
3871         * top.c (repeat_previous): Move bits from pipe_command here:
3872         Return the saved command line, if any; error out if there's no
3873         command to relaunch.
3874
3875 2019-07-03  Pedro Alves  <palves@redhat.com>
3876
3877         * NEWS (New commands): Mention "maint set/show test-settings"
3878         instead of "maint test-settings".
3879         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3880         (maintenance_test_settings_set_list): Rename to ...
3881         (maintenance_set_test_settings_list): ... this.
3882         (maintenance_test_settings_show_list): Rename to  ...
3883         (maintenance_show_test_settings_list): ... this.
3884         (maintenance_test_settings_cmd): Delete.
3885         (maintenance_test_settings_set_cmd): ...
3886         (maintenance_set_test_settings_cmd): ... this.
3887         (maintenance_test_settings_show_cmd): ...
3888         (maintenance_show_test_settings_cmd): ... this.
3889         (maintenance_test_settings_show_value_cmd):
3890         (maintenance_show_test_settings_value_cmd): ... this.
3891         (_initialize_maint_test_settings): No longer install the "maint
3892         test-settings" prefix command.  Rename "maint test-settings set"
3893         to "maint set test-settings", and "maint test-settings show" to
3894         "maint show test-settings".  Adjust all subcommands.
3895
3896 2019-07-03  Pedro Alves  <palves@redhat.com>
3897
3898         * maint-test-settings.c: Fix file's intro comment.  Replace all
3899         references to "test-options" with references to "test-settings",
3900         in comments.
3901
3902 2019-07-03  Pedro Alves  <palves@redhat.com>
3903
3904         * maint-test-settings.c (maintenance_test_settings_xxx)
3905         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3906         New.
3907         (maintenance_test_settings_enums): Use them.
3908         (maintenance_test_settings_enum): Default to
3909         maintenance_test_settings_xxx.
3910         (_initialize_maint_test_settings): Initialize
3911         MAINTENANCE_TEST_SETTINGS_FILENAME.
3912
3913 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3914
3915         * breakpoint.h (remove_breakpoints_inf): Change return type to
3916         void, move function documentation here.
3917         * breakpoint.c (remove_breakpoints_inf): Change return type to
3918         void, move function documentation to header.
3919
3920 2019-07-02  Pedro Alves  <palves@redhat.com>
3921
3922         * NEWS (Completion improvements): Mention "info threads".
3923         * thread.c (struct info_threads_opts, info_threads_option_defs)
3924         (make_info_threads_options_def_group): New.
3925         (info_threads_command): Use gdb::option::process_options.
3926         (info_threads_command_completer): New.
3927         (_initialize_thread): Use gdb::option::build_help to build the
3928         help text for "info threads".
3929
3930 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3931
3932         * defs.h (generic_load): Move from here...
3933         * symfile.h (generic_load): ... to here.  Rename name parameter
3934         to args.
3935         * symfile.c (generic_load): Add comment.
3936
3937 2019-07-01  Tom Tromey  <tromey@adacore.com>
3938
3939         * dwarf2read.c
3940         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3941         declaration of without_params.  Fix formatting.
3942
3943 2019-07-01  Tom Tromey  <tromey@adacore.com>
3944
3945         * ada-exp.y (find_primitive_type): Update.
3946         * ada-lang.h (ada_lookup_symbol): Update.
3947         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3948         parameter.
3949         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3950
3951 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3952
3953         PR breakpoints/24541
3954         * gdbarch.c: Regenerate.
3955         * gdbarch.h: Regenerate.
3956         * gdbarch.sh: Add 'stap_adjust_register'.
3957         * i386-tdep.c: Include '<unordered_set>'.
3958         (i386_stap_adjust_register): New function.
3959         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3960         * stap-probe.c (stap_parse_register_operand): Call
3961         'gdbarch_stap_adjust_register'.
3962
3963 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3964
3965         PR python/24742
3966         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3967         * python/python.c (do_start_initialization): Use 'xmalloc'
3968         instead of 'PyMem_Malloc'.
3969
3970 2019-06-28  Tom Tromey  <tromey@adacore.com>
3971
3972         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3973         for Ada.
3974
3975 2019-06-27  Tom Tromey  <tromey@adacore.com>
3976
3977         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3978         objfile_key.
3979         (arm_find_mapping_symbol, arm_record_special_symbol)
3980         (_initialize_arm_tdep): Update.
3981         (arm_objfile_data_free): Remove.
3982
3983 2019-06-27  Tom Tromey  <tromey@adacore.com>
3984
3985         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3986         to cp_print_static_field.
3987
3988 2019-06-26  Tom Tromey  <tromey@adacore.com>
3989
3990         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3991         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3992         declare.
3993
3994 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * features/aarch64-core.c (create_feature_aarch64_core):
3997         Regenerate.
3998         * features/aarch64-core.xml: Add cpsr flags.
3999
4000 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4001
4002         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4003         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4004
4005 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4006
4007         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4008         field.
4009         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4010         use.
4011         (arm_record_special_symbol): Don't insert new symbol in sorted
4012         position, push it at the end.
4013
4014 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4015
4016         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4017         (arm_mapping_symbol_s): Remove.
4018         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4019         (arm_mapping_symbol_vec): New typedef.
4020         (struct arm_per_objfile): Add constructor.
4021         <section_maps>: Change type to
4022         std::unique_ptr<arm_mapping_symbol_vec[]>.
4023         (arm_compare_mapping_symbols): Remove.
4024         (arm_find_mapping_symbol): Adjust to section_maps type change.
4025         (arm_objfile_data_free): Call delete on arm_per_objfile.
4026         (arm_record_special_symbol): Adjust to section_maps type change.
4027         Allocate arm_per_objfile with new.
4028
4029 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4030
4031         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4032         with the command prefix.
4033
4034 2019-06-25  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4037         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4042         type.
4043         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4044         protected.
4045
4046 2019-06-25  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-winsource.c
4049         (tui_source_window_base::set_is_exec_point_at): Add check against
4050         LOA_ADDRESS.
4051
4052 2019-06-25  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-source.c (tui_set_source_content): Don't check before
4055         xfree.
4056         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4057
4058 2019-06-25  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-winsource.h (tui_update_source_window_as_is)
4061         (tui_alloc_source_buffer, tui_line_is_displayed)
4062         (tui_addr_is_displayed): Change type of win_info.
4063         * tui/tui-winsource.c (tui_update_source_window_as_is)
4064         (tui_clear_source_content, tui_show_source_line)
4065         (tui_show_source_content, tui_source_window_base::refill)
4066         (tui_source_window_base::set_is_exec_point_at)
4067         (tui_source_window_base::set_is_exec_point_at)
4068         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4069         (tui_alloc_source_buffer, tui_line_is_displayed)
4070         (tui_addr_is_displayed): Change type of win_info.  Update.
4071         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4072         (tui_source_window_base::do_make_visible_with_new_height):
4073         Update.
4074         * tui/tui-source.c (tui_set_source_content)
4075         (tui_set_source_content_nil)
4076         (tui_source_window::do_scroll_vertical): Update.
4077         * tui/tui-layout.c (show_layout): Update.
4078         * tui/tui-disasm.c (tui_set_disassem_content)
4079         (tui_disasm_window::do_scroll_vertical): Update.
4080         * tui/tui-data.h (tui_win_content): Remove.
4081         (struct tui_gen_win_info) <content, content_size>: Remove.
4082         (struct tui_source_element): Add initializers and destructor.
4083         (union tui_which_element, struct tui_win_element): Remove.
4084         (struct tui_source_window_base) <content>: New field.
4085         (struct tui_data_window): Remove destructor.
4086         (tui_alloc_content, tui_free_win_content)
4087         (tui_free_all_source_wins_content): Don't declare.
4088         * tui/tui-data.c (tui_initialize_static_data): Update.
4089         (init_content_element, tui_alloc_content): Remove.
4090         (~tui_gen_win_info): Update.
4091         (~tui_data_window, tui_free_all_source_wins_content)
4092         (tui_free_win_content, free_content, free_content_elements):
4093         Remove.
4094
4095 2019-06-25  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui-winsource.h (tui_clear_source_content)
4098         (tui_erase_source_content, tui_show_source_content): Change type
4099         of win_info.
4100         * tui/tui-winsource.c (tui_clear_source_content)
4101         (tui_erase_source_content, tui_show_source_content): Change type
4102         of win_info.
4103         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4104         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4105         win_info.
4106         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4107         win_info.
4108         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4109
4110 2019-06-25  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-winsource.c (tui_clear_source_content)
4113         (tui_source_window_base::set_is_exec_point_at): Update.
4114         * tui/tui-source.c (tui_set_source_content_nil): Update.
4115         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4116         a bool.
4117         * tui/tui-data.c (init_content_element): Update.
4118
4119 2019-06-25  Tom Tromey  <tom@tromey.com>
4120
4121         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4122         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4123         * tui/tui-layout.c (init_and_make_win): Update.
4124         * tui/tui.h (enum tui_win_type): Update.
4125         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4126         tui_win_is_auxillary.
4127         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4128         tui_win_is_auxillary.
4129
4130 2019-06-25  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4133         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4134         (tui_delete_data_content_windows, tui_display_all_data)
4135         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4136         Update.
4137         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4138         * tui/tui-regs.c (tui_last_regs_line_no)
4139         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4140         (tui_show_registers): Update.
4141         (tui_show_register_group): Return void.  Update.
4142         (tui_display_registers_from, tui_display_reg_element_at_line)
4143         (tui_display_registers_from_line, tui_check_register_values):
4144         Update.
4145         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4146         member.
4147         (struct tui_data_window) <regs_content>: Now a std::vector.
4148         <regs_content_count>: Remove.
4149         (tui_add_content_elements, tui_free_data_content): Don't declare.
4150         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4151         (init_content_element): Remove DATA_WIN case.  Add assert.
4152         (tui_add_content_elements): Remove.
4153         (tui_data_window): Update.
4154         (tui_free_data_content): Remove.
4155         (free_content_elements): Remove DATA_WIN case.
4156
4157 2019-06-25  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-data.c (tui_data_item_window): Update.
4160         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4161         * tui/tui-windata.c (tui_display_all_data)
4162         (tui_display_data_from_line): Update.
4163         (tui_check_data_values): Remove.
4164         * tui/tui-regs.c (tui_show_register_group)
4165         (tui_display_reg_element_at_line): Update.
4166         * tui/tui-hooks.c (tui_register_changed)
4167         (tui_refresh_frame_and_register_information): Call
4168         tui_check_register_values.
4169         * tui/tui-data.h (struct tui_data_window) <data_content,
4170         data_content_count, data_type>: Remove.
4171         (enum tui_data_type): Remove.
4172
4173         * tui/tui-data.c (tui_data_window::clear_detail)
4174         (~tui_data_window): Update.
4175
4176 2019-06-25  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4179         declare.
4180         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4181         Rename from tui_first_data_item_displayed.  Update.
4182         (tui_data_window::refresh_all)
4183         (tui_data_window::do_scroll_vertical): Update.
4184         * tui/tui-data.h (struct tui_data_window)
4185         <first_data_item_displayed>: Declare new method.
4186
4187 2019-06-25  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4190         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4191         contents...
4192         (tui_initialize_static_data): ...here.
4193
4194 2019-06-25  Tom Tromey  <tom@tromey.com>
4195
4196         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4197         (tui_display_registers_from, tui_check_register_values): Update.
4198         (tui_display_register): Remove win_info parameter; update.
4199         (tui_get_register): Change type of parameters.
4200         * tui/tui-data.h (struct tui_data_element): Remove.
4201         (union tui_which_element) <data>: Remove.
4202         <data_window>: Change type.
4203         (struct tui_data_item_window): New.
4204         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4205         case.  Add assert.
4206         (~tui_data_item_window): New destructor.
4207         (free_content_elements): Remove DATA_ITEM_WIN case.
4208
4209 2019-06-25  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4212         Remove.
4213
4214 2019-06-25  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui-data.h (struct tui_command_element): Remove.
4217         (union tui_which_element) <command>: Remove.
4218         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4219         assert.
4220         (free_content_elements): Remove CMD_WIN case.
4221
4222 2019-06-25  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-layout.c (tui_set_layout): Update.
4225         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4226         * tui/tui-data.c (layout_def): Update.
4227
4228 2019-06-25  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4231         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4232         (tui_source_window_base::set_new_height): Update.
4233         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4234         Update.
4235         (tui_set_locator_fullname, tui_set_locator_info)
4236         (tui_show_frame_info): Update.
4237         * tui/tui-source.c (tui_set_source_content)
4238         (tui_source_is_displayed): Update.
4239         * tui/tui-layout.c (show_source_disasm_command, show_data)
4240         (show_source_or_disasm_and_command): Update.
4241         * tui/tui-disasm.c (tui_set_disassem_content)
4242         (tui_get_begin_asm_address): Update.
4243         * tui/tui-data.h (struct tui_locator_element): Remove.
4244         (union tui_which_element) <locator>: Remove.
4245         (struct tui_locator_window): New.
4246         (tui_locator_win_info_ptr): Change return type.
4247         * tui/tui-data.c (_locator): Change type.
4248         (tui_locator_win_info_ptr): Change return type.
4249         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4250         (tui_alloc_content): Add assert.
4251
4252 2019-06-25  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-winsource.c
4255         (tui_exec_info_window::maybe_allocate_content): New method.
4256         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4257         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4258         (make_source_or_disasm_window): Add cast.
4259         * tui/tui-data.h (union tui_which_element) <simple_string>:
4260         Remove.
4261         (struct tui_source_info): New.
4262         (struct tui_source_window_base) <execution_info>: Change type.
4263         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4264         case, and add assert.
4265         (tui_alloc_content): Add assert.
4266
4267 2019-06-25  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4270         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4271         * tui/tui-data.c (tui_alloc_win_info): Remove.
4272
4273 2019-06-25  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4276         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4277         can_highlight.
4278
4279 2019-06-25  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4282         make_visible_with_new_height method.
4283         (tui_win_info::make_visible_with_new_height): New method.
4284         (tui_source_window_base::do_make_visible_with_new_height)
4285         (tui_data_window::do_make_visible_with_new_height)
4286         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4287         (make_visible_with_new_height): Remove.
4288         (tui_resize_all, tui_adjust_win_heights): Use
4289         make_visible_with_new_height method.
4290         * tui/tui-data.h (struct tui_win_info)
4291         <do_make_visible_with_new_height, make_visible_with_new_height>:
4292         New methods.
4293         (struct tui_source_window_base, struct tui_data_window)
4294         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4295         methods.
4296
4297 2019-06-25  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4300         method.
4301         (update_tab_width): Call update_tab_width method.
4302         * tui/tui-data.h (struct tui_win_info)
4303         (struct tui_source_window_base) <update_tab_width>: New methods.
4304
4305 2019-06-25  Tom Tromey  <tom@tromey.com>
4306
4307         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4308         parameter.
4309         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4310         parameter.
4311         (tui_gen_win_info::make_visible): Update.
4312         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4313         parameter.
4314         * tui/tui-data.h (enum tui_box): New enum.
4315         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4316
4317 2019-06-25  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4320         init_and_make_win for EXEC_INFO_WIN.
4321         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4322         longer inline.
4323         (struct tui_win_info) <~tui_win_info>: Inline.
4324         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4325         Don't declare.
4326         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4327         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4328         Remove.
4329         (tui_initialize_static_data): Update.
4330         (~tui_gen_win_info): Handle more cleanup here.
4331         (~tui_source_window_base): Delete "execution_info".
4332         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4333
4334 2019-06-25  Tom Tromey  <tom@tromey.com>
4335
4336         * tui/tui-layout.c (make_command_window): Don't set
4337         can_highlight.
4338         (show_source_disasm_command): Call the reset method.
4339         (show_data): Don't set can_highlight.  Call the reset method.
4340         (tui_gen_win_info::reset): Rename from init_gen_win_info
4341         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4342         (show_source_or_disasm_and_command): Call the reset method.
4343         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4344         (struct tui_cmd_window): Set can_highlight.
4345
4346 2019-06-25  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4349         from make_visible.
4350         (tui_make_visible, tui_make_invisible): Rewrite.
4351         (tui_win_info::make_visible): Remove.
4352         (tui_source_window_base::make_visible): Update.
4353         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4354         method.  Moved from...
4355         (struct tui_win_info) <make_visible>: ...here.
4356
4357 2019-06-25  Tom Tromey  <tom@tromey.com>
4358
4359         * tui/tui-winsource.c
4360         (tui_source_window_base::do_scroll_horizontal): Remove direction
4361         parameter.
4362         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4363         direction parameter.
4364         * tui/tui-win.c (tui_win_info::forward_scroll)
4365         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4366         (tui_win_info::right_scroll): Update.
4367         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4368         direction parameter.
4369         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4370         direction parameter.
4371         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4372         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4373         Remove direction parameter.
4374         (struct tui_source_window_base, struct tui_source_window)
4375         (struct tui_disasm_window, struct tui_data_window)
4376         (struct tui_cmd_window): Update.
4377
4378 2019-06-25  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui-winsource.h (tui_set_exec_info_content)
4381         (tui_show_exec_info_content, tui_erase_exec_info_content)
4382         (tui_clear_exec_info_content, tui_update_exec_info): Change
4383         argument to tui_source_window_base.
4384         * tui/tui-winsource.c (tui_set_exec_info_content)
4385         (tui_show_exec_info_content, tui_erase_exec_info_content)
4386         (tui_clear_exec_info_content, tui_update_exec_info): Change
4387         argument to tui_source_window_base.
4388
4389 2019-06-25  Tom Tromey  <tom@tromey.com>
4390
4391         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4392         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4393
4394 2019-06-25  Tom Tromey  <tom@tromey.com>
4395
4396         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4397         check.
4398
4399 2019-06-25  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4402         type to void.
4403         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4404         type to void.
4405         * tui/tui-source.c (tui_set_source_content): Update.
4406         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4407
4408 2019-06-25  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-win.c (window_name_completer, tui_set_focus)
4411         (tui_all_windows_info): Use name method.
4412         * tui/tui-data.h (struct tui_gen_win_info)
4413         (struct tui_source_window, struct tui_disasm_window)
4414         (struct tui_data_window, struct tui_cmd_window) <name>: New
4415         method.
4416         (tui_win_name): Don't declare.
4417         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4418         (tui_win_name): Remove.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-winsource.h (tui_update_source_window)
4423         (tui_update_source_window_as_is): Change parameter type.
4424         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4425         to be a tui_source_window_base.
4426         (tui_update_source_window_as_is): Likewise.
4427         * tui/tui-win.c (make_visible_with_new_height): Update.
4428
4429 2019-06-25  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-winsource.c (tui_erase_source_content)
4432         (tui_show_source_content, tui_show_exec_info_content)
4433         (tui_erase_exec_info_content): Use refresh_window method.
4434         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4435         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4436         from tui_refresh_win.
4437         (tui_data_window::refresh_window): New method.
4438         (tui_win_info::refresh, tui_source_window_base::refresh)
4439         (tui_refresh_all): Use refresh_window method.
4440         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4441         method.
4442         * tui/tui-regs.c (tui_display_register): Call refresh_window
4443         method.
4444         * tui/tui-layout.c (show_source_disasm_command)
4445         (show_source_or_disasm_and_command): Call refresh_window method.
4446         * tui/tui-data.h (struct tui_gen_win_info)
4447         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4448         New method.
4449
4450 2019-06-25  Tom Tromey  <tom@tromey.com>
4451
4452         * tui/tui.c (tui_rl_other_window, tui_enable)
4453         (tui_is_window_visible, tui_get_command_dimension): Update.
4454         * tui/tui-winsource.c (tui_update_source_window_as_is)
4455         (tui_clear_source_content, tui_erase_source_content)
4456         (tui_show_source_line, tui_source_window_base::refill)
4457         (tui_source_window_base::do_scroll_horizontal)
4458         (tui_source_window_base::set_is_exec_point_at)
4459         (tui_update_breakpoint_info, tui_set_exec_info_content)
4460         (tui_alloc_source_buffer, tui_line_is_displayed)
4461         (tui_addr_is_displayed): Update.
4462         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4463         (tui_check_and_display_highlight_if_needed)
4464         (tui_win_info::make_visible, tui_win_info::refresh)
4465         (tui_refresh_all): Update.
4466         * tui/tui-windata.c (tui_first_data_item_displayed)
4467         (tui_delete_data_content_windows, tui_erase_data_content)
4468         (tui_display_all_data, tui_data_window::refresh_all)
4469         (tui_check_data_values): Update.
4470         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4471         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4472         (tui_win_info::backward_scroll, tui_refresh_all_win)
4473         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4474         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4475         (tui_source_window_base::set_new_height)
4476         (tui_data_window::set_new_height)
4477         (make_invisible_and_set_new_height)
4478         (make_visible_with_new_height, new_height_ok)
4479         (parse_scrolling_args): Update.
4480         * tui/tui-stack.c (tui_show_frame_info): Update.
4481         * tui/tui-source.c (tui_set_source_content)
4482         (tui_set_source_content_nil, tui_source_is_displayed)
4483         (tui_source_window::do_scroll_vertical): Update.
4484         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4485         (tui_display_registers_from, tui_display_reg_element_at_line)
4486         (tui_check_register_values, tui_reg_command): Update.
4487         * tui/tui-layout.c (tui_default_win_height)
4488         (show_source_disasm_command, show_data, init_and_make_win)
4489         (show_source_or_disasm_and_command): Update.
4490         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4491         (tui_redisplay_readline, tui_mld_flush)
4492         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4493         (tui_getc): Update.
4494         * tui/tui-disasm.c (tui_set_disassem_content)
4495         (tui_disasm_window::do_scroll_vertical): Update.
4496         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4497         Now virtual.
4498         (struct tui_win_info): Derive from tui_gen_win_info.
4499         <~tui_win_info>: Mark as override.
4500         <generic>: Remove member.
4501         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4502         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4503         (~tui_data_window, ~tui_win_info)
4504         (tui_free_all_source_wins_content): Update.
4505         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4506
4507 2019-06-25  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-layout.c (init_and_make_win): Use new.
4510         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4511         destructor, initializers.
4512         (tui_alloc_generic_win_info): Don't declare.
4513         * tui/tui-data.c (_locator): Add argument to constructor.
4514         (source_win, disasm_win): New globals.
4515         (exec_info): Remove.
4516         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4517         Update.
4518         (tui_alloc_generic_win_info): Remove.
4519         (init_content_element): Use new.
4520         (tui_win_info::tui_win_info): Update.
4521         (free_content_elements) <case DATA_WIN>: Use delete.
4522
4523 2019-06-25  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4526         * tui/tui-windata.c (tui_first_data_item_displayed)
4527         (tui_delete_data_content_windows): Update.
4528         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4529         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4530         (tui_display_registers_from, tui_check_register_values): Update.
4531         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4532         pointer.
4533         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4534         window.
4535         (tui_free_data_content): Update.
4536         (free_content_elements) <case DATA_WIN>: Free the window.
4537
4538 2019-06-25  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4541         Update.
4542         * tui/tui-layout.c (make_command_window)
4543         (show_source_disasm_command, show_data, init_and_make_win)
4544         (show_source_or_disasm_and_command): Update.
4545         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4546         method.
4547         <can_highight, is_highlighted>: Now bool.
4548         (tui_set_win_highlight): Don't declare.
4549         * tui/tui-data.c (tui_set_win_highlight): Remove.
4550
4551 2019-06-25  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-wingeneral.c (make_visible): Remove check of window
4554         type.
4555
4556 2019-06-25  Tom Tromey  <tom@tromey.com>
4557
4558         * tui/tui-win.c (tui_win_info::max_height)
4559         (tui_cmd_window::max_height): New methods.
4560         (new_height_ok): Call max_height.
4561         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4562         <max_height>: New method.
4563
4564 2019-06-25  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-win.c (tui_source_window_base::set_new_height)
4567         (tui_data_window::set_new_height): New methods.
4568         (make_invisible_and_set_new_height): Call set_new_height method.
4569         * tui/tui-data.h (struct tui_win_info)
4570         (struct tui_source_window_base, struct tui_data_window)
4571         <set_new_height>: New method.
4572
4573 2019-06-25  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4576         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4577         tui_refresh_data_win.
4578         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4579         method.
4580         (tui_refresh_all_win): Call the refresh_all method.
4581         (tui_set_focus): Likewise.
4582         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4583         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4584         Likewise.
4585
4586 2019-06-25  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-winsource.h (tui_refill_source_window)
4589         (tui_set_is_exec_point_at): Don't declare.
4590         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4591         (tui_source_window_base::refill): Rename from
4592         tui_refill_source_window.
4593         (tui_source_window_base::do_scroll_horizontal): Update.
4594         (tui_source_window_base::set_is_exec_point_at): Rename from
4595         tui_set_is_exec_point_at.
4596         (tui_update_all_breakpoint_info): Update.
4597         * tui/tui-stack.c (tui_show_frame_info): Update.
4598         * tui/tui-layout.c (show_data): Add cast.
4599         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4600         * tui/tui-data.h (struct tui_source_window_base) <refill,
4601         set_is_exec_point_at>: New methods.
4602         (tui_source_windows, tui_add_to_source_windows): Update types.
4603         (tui_add_to_source_windows): Remove redundant declaration.
4604         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4605         (tui_source_windows): Change return type.
4606         (tui_clear_source_windows_detail): Update.
4607         (tui_add_to_source_windows): Change type of parameter.
4608         (tui_free_all_source_wins_content): Update.
4609
4610 2019-06-25  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-wingeneral.c (tui_win_info::refresh)
4613         (tui_source_window_base::refresh): New methods.
4614         (tui_refresh_all): Call the refresh method.
4615         * tui/tui-data.h (struct tui_win_info)
4616         (struct tui_source_window_base) <refresh>: New method.
4617
4618 2019-06-25  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui.h (tui_is_window_visible): Return bool.
4621         * tui/tui.c (tui_is_window_visible): Return bool.
4622         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4623         (tui_make_visible, tui_make_invisible)
4624         (tui_win_info::make_visible)
4625         (tui_source_window_base::make_visible, make_all_visible)
4626         (tui_make_all_visible, tui_make_all_invisible): Update.
4627         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4628         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4629         bool.
4630         (struct tui_win_info, struct tui_source_window_base)
4631         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4632         * tui/tui-data.c (tui_init_generic_part): Update.
4633
4634 2019-06-25  Tom Tromey  <tom@tromey.com>
4635
4636         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4637         (tui_source_window_base::make_visible): New methods.
4638         (make_all_visible): Make method call.
4639         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4640         (struct tui_source_window_base, struct tui_cmd_window): Override
4641         make_visible.
4642         (tui_win_is_source_type): Don't declare.
4643         * tui/tui-data.c (tui_win_is_source_type): Remove.
4644
4645 2019-06-25  Tom Tromey  <tom@tromey.com>
4646
4647         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4648         NULL check.
4649
4650 2019-06-25  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4653         Inline constructor.  Add initializers for members.
4654         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4655         constructors; now inline in class.
4656
4657 2019-06-25  Tom Tromey  <tom@tromey.com>
4658
4659         * tui/tui-regs.c (tui_show_registers): Update.
4660         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4661         bool.
4662         * tui/tui-data.c (tui_data_window::clear_detail)
4663         (tui_data_window): Update.
4664
4665 2019-06-25  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-windata.c (tui_display_all_data)
4668         (tui_display_data_from_line, tui_display_data_from)
4669         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4670         Update.
4671         * tui/tui-regs.c (tui_last_regs_line_no)
4672         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4673         (tui_show_registers, tui_show_register_group)
4674         (tui_display_registers_from, tui_display_reg_element_at_line)
4675         (tui_display_registers_from_line, tui_check_register_values)
4676         (tui_reg_next, tui_reg_prev): Update.
4677         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4678         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4679         tui_data_window.
4680         (struct tui_win_info) <detail>: Remove.  Add new fields from
4681         tui_data_info.
4682         (TUI_DATA_WIN): Add cast.
4683         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4684         (~tui_data_window): Simplify.
4685
4686 2019-06-25  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-layout.c (show_source_disasm_command)
4689         (show_source_or_disasm_and_command): Update.
4690         * tui/tui-io.c (update_cmdwin_start_line)
4691         (tui_redisplay_readline): Update.
4692         * tui/tui-data.h (struct tui_command_info): Remove.
4693         (struct tui_win_info) <detail>: Remove command_info member.
4694         (struct tui_data_window) <start_line>: New member, from
4695         tui_command_info.
4696         (TUI_CMD_WIN): Add casts.
4697
4698 2019-06-25  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-winsource.c (tui_update_source_window)
4701         (tui_refill_source_window)
4702         (tui_source_window_base::do_scroll_horizontal)
4703         (tui_update_breakpoint_info, tui_set_exec_info_content)
4704         (tui_show_exec_info_content, tui_erase_exec_info_content)
4705         (tui_clear_exec_info_content): Update.
4706         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4707         Update.
4708         * tui/tui-win.c (make_invisible_and_set_new_height)
4709         (make_visible_with_new_height): Update.
4710         * tui/tui-source.c (tui_set_source_content)
4711         (tui_show_symtab_source): Update.
4712         * tui/tui-layout.c (extract_display_start_addr)
4713         (show_source_disasm_command, show_data)
4714         (make_source_or_disasm_window)
4715         (show_source_or_disasm_and_command): Update.
4716         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4717         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4718         "gdbarch".
4719         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4720         to tui_source_window_base.
4721         (struct tui_win_info) <detail>: Remove source_info member.
4722         (struct tui_source_window_base) <has_locator>: Inline.
4723         Move contents from tui_source_info; rename has_locator member to
4724         m_has_locator.
4725         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4726         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4727         header file.
4728         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4729         Simplify.
4730         (tui_free_all_source_wins_content): Cast to
4731         tui_source_window_base.
4732
4733 2019-06-25  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-win.c (make_invisible_and_set_new_height)
4736         (make_visible_with_new_height): Call has_locator method.
4737         * tui/tui-layout.c (show_source_disasm_command, show_data)
4738         (show_source_or_disasm_and_command): Update for bool change.
4739         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4740         (tui_win_info) <has_locator>: New method.
4741         (struct tui_source_window_base) <has_locator>: New method.
4742         (tui_win_has_locator): Don't declare.
4743         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4744         from tui_win_has_locator.
4745         (tui_source_window_base): Use false, not FALSE.
4746
4747 2019-06-25  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4750         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4751         clear_detail method directly.
4752         (tui_clear_win_detail): Remove.
4753
4754 2019-06-25  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4757         "this", not TUI_DISASM_WIN.
4758
4759 2019-06-25  Tom Tromey  <tom@tromey.com>
4760
4761         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4762         declare.
4763         * tui/tui-winsource.c
4764         (tui_source_window_base::do_scroll_horizontal): Rename from
4765         tui_horizontal_source_scroll.
4766         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4767         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4768         from tui_vertical_data_scroll.
4769         * tui/tui-win.h (tui_scroll): Don't declare.
4770         * tui/tui-win.c (tui_win_info::forward_scroll)
4771         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4772         (tui_win_info::right_scroll): Rename and update.
4773         (tui_scroll_forward_command, tui_scroll_backward_command)
4774         (tui_scroll_left_command, tui_scroll_right_command): Update.
4775         (tui_scroll): Remove.
4776         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4777         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4778         from tui_vertical_source_scroll.
4779         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4780         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4781         from tui_vertical_disassem_scroll.
4782         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4783         do_scroll_horizontal>: New methods.
4784         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4785         Likewise.
4786         (struct tui_source_window_base): Add do_scroll_horizontal.
4787         (struct tui_source_window, struct tui_disasm_window): Add
4788         do_scroll_vertical.
4789         (struct tui_data_window, struct tui_cmd_window): Add
4790         do_scroll_horizontal and do_scroll_vertical.
4791         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4792
4793 2019-06-25  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-data.h (struct tui_source_window_base): New struct.
4796         (struct tui_source_window): Derive from tui_source_window_base.
4797         (struct tui_disasm_window): New struct.
4798         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4799         from tui_source_window::clear_detail.
4800         (tui_source_window_base): Rename from tui_source_window.
4801         (~tui_source_window_base): Rename from ~tui_source_window.
4802         (tui_alloc_win_info): Create a tui_disasm_window.
4803
4804 2019-06-25  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-data.h (struct tui_source_window)
4807         (struct tui_data_window): Declare destructors.
4808         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4809         destructors.
4810         (tui_win_info): Simplify.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-winsource.c (tui_display_main)
4815         (tui_update_source_windows_with_addr)
4816         (tui_update_all_breakpoint_info): Update.
4817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4818         (new_height_ok, parse_scrolling_args): Update.
4819         * tui/tui-stack.c (tui_show_frame_info): Update.
4820         * tui/tui-data.h (struct tui_list): Remove.
4821         (tui_source_windows): Return a reference to a std::vector.
4822         * tui/tui-data.c (source_windows): Now a std::vector.
4823         (tui_source_windows): Change return type.
4824         (tui_clear_source_windows): Rewrite.
4825         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4826         (tui_free_all_source_wins_content): Rewrite.
4827
4828 2019-06-25  Tom Tromey  <tom@tromey.com>
4829
4830         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4831         (struct tui_data_window, struct tui_cmd_window): Declare
4832         clear_detail method.
4833         * tui/tui-data.c (tui_source_window::clear_detail)
4834         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4835         methods.
4836         (tui_clear_win_detail): Simplify.
4837
4838 2019-06-25  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-layout.c (make_source_window, make_disasm_window)
4841         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4842         Return the new window.
4843         (show_source_disasm_command, show_data)
4844         (show_source_or_disasm_and_command): Update.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4849         parameter.  Return the new window.
4850         (show_source_disasm_command): Update and remove NULL check.
4851         (show_source_or_disasm_and_command): Update.
4852
4853 2019-06-25  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4856
4857 2019-06-25  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-data.h (struct tui_win_info): Make constructor
4860         protected.  Make destructor virtual.  Add initializers.
4861         (tui_source_window, tui_data_window, tui_cmd_window): New
4862         classes.
4863         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4864         constructor.  Add "type" parameter.
4865         (tui_source_window, tui_data_window, tui_cmd_window): New
4866         constructors.
4867         (tui_alloc_win_info): Instantiate the appropriate subclass.
4868
4869 2019-06-25  Tom Tromey  <tom@tromey.com>
4870
4871         * tui/tui-win.c (tui_resize_all): Use delete.
4872         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4873         destructor.
4874         (tui_free_window): Don't declare.
4875         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4876         Update.
4877
4878 2019-06-25  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-data.h (struct tui_win_info): Add constructor.
4881         * tui/tui-data.c (tui_alloc_win_info): Use new.
4882         (tui_free_window): Use delete.
4883
4884 2019-06-22  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4887         declare.
4888         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4889
4890 2019-06-22  Tom Tromey  <tom@tromey.com>
4891
4892         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4893         declare.
4894         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4895
4896 2019-06-22  Tom de Vries  <tdevries@suse.de>
4897
4898         * dwarf2read.c (create_addrmap_from_aranges)
4899         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4900         instead of '%zu'.
4901
4902 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4903
4904         * dwarf2read.h (dwarf2_section_info_def): Remove.
4905         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4906         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4907         std::vector<dwarf2_section_info>.
4908         (struct dwo_file) <~dwo_file>: Remove.
4909         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4910         types field.
4911         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4912         (dwarf2_read_debug_names): Likewise.
4913         (create_debug_types_hash_table): Change parameter type to
4914         array_view, adjust code accordingly.
4915         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4916         (partial_die_info::fixup): Likewise.
4917         (determine_prefix): Likewise.
4918         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4919
4920 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4921
4922         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4923         gdb_bfd_ref_ptr.
4924         <~dwo_file>: Remove call to gdb_bfd_unref.
4925         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4926         gdb_bfd_ref_ptr::get.
4927
4928 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4929
4930         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4931         type to htab_up.
4932         * dwarf2read.c (struct dwo_file): Initialize fields.
4933         <~dwo_file>: New.
4934         (free_dwo_file): Remove, move content to ~dwo_file.
4935         (struct dwo_file_deleter): Remove.
4936         (dwo_file_up>: Remove custom deleter.
4937         (free_dwo_files): Remove.
4938         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4939         dwo_files.
4940         (process_skeletonless_type_units): Call unique_ptr::get.
4941         (allocate_dwo_file_hash_table): Add deleter to created hash
4942         table.  Change return type to htab_up.
4943         (lookup_dwo_file_slot): Don't memset dwo_file, call
4944         unique_ptr::get.
4945         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4946         (create_dwo_unit_in_dwp_v2): Likewise.
4947         (open_and_init_dwo_file): Likewise.
4948         (free_dwo_file_from_slot): Remove.
4949
4950 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4951
4952         * dwarf2read.h (struct dwarf2_section_info) <readin,
4953         is_virtual>: Change type to bool.
4954         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4955         true instead of 1.
4956
4957 2019-06-19  Tom Tromey  <tom@tromey.com>
4958
4959         * tui/tui-data.h (tui_init_content_element): Don't declare.
4960
4961 2019-06-19  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-data.h (tui_init_win_info): Don't declare.
4964
4965 2019-06-19  Tom de Vries  <tdevries@suse.de>
4966
4967         * dwarf2read.h (abstract_to_concrete): Change type to
4968         std::unordered_map<sect_offset, std::vector<sect_offset>,
4969         gdb::hash_enum<sect_offset>>.
4970
4971 2019-06-19  Tom Tromey  <tromey@adacore.com>
4972
4973         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4974         EVAL_AVOID_SIDE_EFFECTS specially.
4975
4976 2019-06-19  Tom Tromey  <tromey@adacore.com>
4977
4978         * source-cache.c (highlighter): New global.
4979         (source_cache::get_source_lines): Create a highlighter on demand.
4980
4981 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * defs.h (deprecated_interactive_hook): Delete declaration.
4984         * interps.c (clear_interpreter_hooks): Remove use of
4985         deprecated_interactive_hook.
4986         * top.c (deprecated_interactive_hook): Delete definition.
4987         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4988
4989 2019-06-18  Tom de Vries  <tdevries@suse.de>
4990
4991         PR gdb/24515
4992         * dwarf2read.h (abstract_to_concrete): Change type from
4993         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4994         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4995         * dwarf2read.c (read_variable): Update.
4996         (dwarf2_fetch_die_loc_sect_off): Update.
4997
4998 2019-06-17  Tom de Vries  <tdevries@suse.de>
4999
5000         PR gdb/24617
5001         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5002         accessing parent[parent_len - 1].
5003
5004 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5005
5006         PR gdb/24364
5007         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5008         call dtrace_process_dof with NULL dof.
5009
5010 2019-06-16  Tom de Vries  <tdevries@suse.de>
5011
5012         PR gdb/24445
5013         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5014
5015 2019-06-16  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5018         (make_all_visible): Use address of member.
5019
5020 2019-06-16  Tom Tromey  <tom@tromey.com>
5021
5022         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5023         (tui_free_window, free_content, free_content_elements): Remove
5024         unnecessary cast.
5025         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5026         cast.
5027         * tui/tui-regs.c (tui_show_register_group)
5028         (tui_display_registers_from, tui_display_reg_element_at_line):
5029         Remove unnecessary cast.
5030
5031 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * linux-nat.c (normal_mask): Delete.
5034         (_initialize_linux_nat): Don't initialise normal_mask.
5035
5036 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5037
5038         PR gdb/24445
5039         * dwarf-index-write.h (write_psymtabs_to_index): Add
5040         dwz_basename parameter.
5041         * dwarf-index-write.c (write_gdbindex): Move file writing to
5042         write_gdbindex_1.  Change return type void.
5043         (assert_file_size): Move up, remove filename parameter.
5044         (write_gdbindex_1): New function.
5045         (write_debug_names): Change return type to void, call
5046         assert_file_size.
5047         (struct index_wip_file): New struct.
5048         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5049         file logic to index_wip_file.  Write index for dwz file if
5050         needed.
5051         (save_gdb_index_command): Pass basename of dwz file, if present.
5052         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5053         build-id of dwz file, if present.
5054         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5055         (dwarf2_get_dwz_file): Likewise.
5056         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5057         (dwarf2_get_dwz_file): Likewise.
5058
5059 2019-06-16  Tom Tromey  <tom@tromey.com>
5060
5061         * coffread.c (process_coff_symbol): Use xstrdup.
5062         * value.c (create_internalvar): Use xstrdup.
5063
5064 2019-06-16  Tom Tromey  <tom@tromey.com>
5065
5066         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5067         * breakpoint.c (stopin_command, stopat_command)
5068         (until_break_command, decode_location_default): Remove unnecessary
5069         cast.
5070         * utils.c (subset_compare): Remove unnecessary cast.
5071         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5072         cast.
5073         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5074         cast.
5075         * infcmd.c (path_command): Remove unnecessary cast.
5076         * coffread.c (decode_type): Remove unnecessary cast.
5077         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5078         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5079         * tui/tui-stack.c (tui_show_locator_content)
5080         (tui_show_frame_info): Remove unnecessary cast.
5081         * tui/tui-win.c (tui_scroll_forward_command)
5082         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5083         (parse_scrolling_args): Remove unnecessary cast.
5084         * tui/tui-data.c (init_win_info, tui_del_window)
5085         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5086         (free_content_elements): Remove unnecessary cast.
5087         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5088         unnecessary cast.
5089         * tui/tui-source.c (tui_set_source_content)
5090         (tui_vertical_source_scroll): Remove unnecessary cast.
5091         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5092         cast.
5093         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5094         * tui/tui-regs.c (tui_display_registers_from)
5095         (tui_display_register): Remove unnecessary cast.
5096         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5097         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5098         (make_visible): Remove unnecessary cast.
5099         * tui/tui-winsource.c (tui_erase_source_content)
5100         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5101         unnecessary cast.
5102         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5103         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5104         * stabsread.c (read_type, read_array_type, read_range_type):
5105         Remove unnecessary cast.
5106         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5107         (parse_symbol, parse_type, upgrade_type, parse_external)
5108         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5109         unnecessary cast.
5110         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5111
5112 2019-06-16  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-data.c (tui_alloc_generic_win_info)
5115         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5116         checks.
5117
5118 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5119             Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * f-typeprint.c (f_print_type): Don't return early for not
5122         associated or not allocated types.
5123         (f_type_print_varspec_suffix): Add print_rank parameter and print
5124         ranks of array types in case they dangling.
5125         (f_type_print_base): Add print_rank parameter.
5126
5127 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * NEWS: Mention new MI commands.
5130         * break-catch-throw.c (enum exception_event_kind): Move to
5131         breakpoint.h.
5132         (print_mention_exception_catchpoint): Output text as a single
5133         message.
5134         (catch_exception_command_1): Rename to...
5135         (catch_exception_event): ...this, make non-static, update header
5136         command, and change some parameter types.
5137         (catch_catch_command): Update for changes to
5138         catch_exception_command_1.
5139         (catch_throw_command): Likewise.
5140         (catch_rethrow_command): Likewise.
5141         * breakpoint.c (enum exception_event_kind): Delete.
5142         * breakpoint.h (enum exception_event_kind): Moved here from
5143         break-catch-throw.c.
5144         (catch_exception_event): Declare.
5145         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5146         (mi_cmd_catch_throw): New function.
5147         (mi_cmd_catch_rethrow): New function.
5148         (mi_cmd_catch_catch): New function.
5149         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5150         'catch-catch' entries.
5151         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5152         (mi_cmd_catch_rethrow): Declare.
5153         (mi_cmd_catch_catch): Declare.
5154
5155 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * annotate.c (annotate_source_line): Change return type to void,
5158         update implementation to match.
5159         * annotate.h (annotate_source_line): Change return type to void,
5160         update header comment.
5161         * stack.c (print_frame_info): Don't change what frame information
5162         is printed based on whether annotations are on or not.
5163
5164 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5167         (annotate_source): Make static.
5168         (annotate_source_line): Moved from source.c and renamed from
5169         identify_source_line.  Update the return type.
5170         * annotate.h (annotate_source): Delete declaration.
5171         (annotate_source_line): Declaration moved from source.h, and
5172         renamed from identify_source_line.  Return type updated.
5173         * source.c (identify_source_line): Moved to annotate.c and renamed
5174         to annotate_source_line.
5175         (info_line_command): Remove check of annotation_level.
5176         * source.h (identify_source_line): Move declaration to annotate.h
5177         and rename to annotate_source_line.
5178         * stack.c: Add 'annotate.h' include.
5179         (print_frame_info): Remove check of annotation_level before
5180         calling annotate_source_line.
5181
5182 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5183
5184         * source-cache.c (source_cache::get_plain_source_lines): Use
5185         open_source_file_with_line_charpos instead of just
5186         open_source_file, remove call to find_source_lines.
5187         (source_cache::get_source_lines): Likewise.
5188         * source.c (find_source_lines): Make static.
5189         (get_filename_and_charpos): Renamed into...
5190         (open_source_file_with_line_charpos): ..this along with changes to
5191         return a scoped_fd, and some other minor clean ups.
5192         (identify_source_line): Use open_source_file_with_line_charpos.
5193         (search_command_helper): Use open_source_file_with_line_charpos
5194         instead of just open_source_file, remove call to
5195         find_source_lines.
5196         * source.h (open_source_file_with_line_charpos): Declare new
5197         function.
5198         (find_source_lines): Delete declaration.
5199
5200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * source.c (get_filename_and_charpos): Remove fullname
5203         parameter.
5204         (identify_source_line): Update call to get_filename_and_charpos.
5205
5206 2019-06-14  Tom Tromey  <tromey@adacore.com>
5207
5208         PR gdb/24502:
5209         * ui-style.h (skip_ansi_escape): Update comment.
5210         * ui-file.h (class no_terminal_escape_file): New class.
5211         * ui-file.c (no_terminal_escape_file::write)
5212         (no_terminal_escape_file::puts): New methods.
5213         * cli/cli-logging.c (handle_redirections): Use
5214         no_terminal_escape_file.
5215
5216 2019-06-14  Tom Tromey  <tromey@adacore.com>
5217
5218         * NEWS: Move convenience variable news above Python news.
5219
5220 2019-06-14  Tom Tromey  <tom@tromey.com>
5221
5222         * gnulib: Move directory to top-level.
5223         * configure.ac: Don't configure gnulib.
5224         * configure: Rebuild.
5225         * common/common-defs.h: Use new path to gnulib.
5226         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5227         (GNULIB_H): Remove.
5228         (INCGNU): Look in new gnulib location.
5229         (HFILES_NO_SRCDIR): Remove gnulib files.
5230         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5231         (generated_files): Remove GNULIB_H.
5232         ($(LIBGNU), all-lib): Remove targets.
5233         (distclean): Don't mention GNULIB_BUILDDIR.
5234         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5235
5236 2019-06-14  Tom Tromey  <tromey@adacore.com>
5237
5238         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5239         Warn if symbol file does not provide any symbols.
5240
5241 2019-06-14  Tom Tromey  <tromey@adacore.com>
5242
5243         * source.c (find_and_open_source): Respect basenames_may_differ.
5244
5245 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * annotate.c (annotate_breakpoints_invalid): Make use of
5248         scoped_restore_terminal_state.
5249         (annotate_frames_invalid): Likewise.
5250
5251 2019-06-14  Tom Tromey  <tromey@adacore.com>
5252
5253         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5254         allow assignment to an internalvar.
5255
5256 2019-06-14  Tom Tromey  <tromey@adacore.com>
5257
5258         * ada-lex.l: Allow "_" in attribute names.
5259
5260 2019-06-14  Tom Tromey  <tromey@adacore.com>
5261
5262         PR gdb/24653:
5263         * regcache.c (registers_changed): Don't call alloca.
5264         * top.c (execute_command): Don't call alloca.
5265
5266 2019-06-13  Pedro Alves  <palves@redhat.com>
5267
5268         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5269         'expression'.  When parsing an expression, error out if there's
5270         junk after "unlimited".
5271         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5272         (do_set_command): Adjust calls to is_unlimited_literal.
5273
5274 2019-06-13  Pedro Alves  <palves@redhat.com>
5275
5276         * compile/compile.c (make_compile_options_def_group): Add braces
5277         around array_view initializer.
5278         * thread.c (make_thread_apply_all_options_def_group)
5279         (make_thread_apply_all_options_def_group): Likewise.
5280
5281 2019-06-13  Pedro Alves  <palves@redhat.com>
5282
5283         * NEWS (New commands): Mention "maint test-options
5284         require-delimiter", "maint test-options unknown-is-error", "maint
5285         test-options unknown-is-operand" and "maint show
5286         test-options-completion-result".
5287         (New command options, command completion): New section.
5288         (Completion improvements): New section.
5289         Mention that you can abbreviate "unlimited".
5290
5291 2019-06-13  Pedro Alves  <palves@redhat.com>
5292
5293         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5294         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5295         * unittests/cli-utils-selftests.c (test_parse_flags)
5296         (test_parse_flags_qcs): Delete.
5297         (test_cli_utils): Don't call deleted functions.
5298
5299 2019-06-13  Pedro Alves  <palves@redhat.com>
5300
5301         * thread.c: Include "cli/cli-option.h".
5302         (tp_array_compar_ascending): Global.
5303         (tp_array_compar): Delete function.
5304         (tp_array_compar_ascending, tp_array_compar_descending): New
5305         functions.
5306         (ascending_option_def, qcs_flag_option_def)
5307         (thr_qcs_flags_option_defs)
5308         (make_thread_apply_all_options_def_group)
5309         (make_thread_apply_options_def_group): New.
5310         (thread_apply_all_command): Use gdb::option::process_options.
5311         (thread_apply_command_completer)
5312         (thread_apply_all_command_completer): New.
5313         (thread_apply_command): Use gdb::option::process_options.
5314         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5315         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5316         to generate help text of "thread apply".  Adjust "taas"'s help.
5317         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5318         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5319
5320 2019-06-13  Pedro Alves  <palves@redhat.com>
5321
5322         * thread.c (thread_apply_command): Check for invalid TID with
5323         isdigit instead of !isalpha.
5324
5325 2019-06-13  Pedro Alves  <palves@redhat.com>
5326
5327         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5328         (validate_flags_qcs): New.
5329         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5330         (validate_flags_qcs): Declare.
5331         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5332         (make_frame_apply_options_def_group): New.
5333         (frame_apply_command_count): Process options with
5334         gdb::option::process_options.
5335         (frame_apply_completer): New.
5336         (frame_apply_level_completer, frame_apply_all_completer)
5337         (frame_apply_completer): New.
5338         (_initialize_stack): Update help of "frame apply", "frame apply
5339         level", "frame apply all" and "faas" to mention supported options
5340         and install command completers.
5341         * stack.h (frame_apply_all_completer): Declare.
5342         * thread.c: Include "stack.h".
5343         (tfaas_command): Add "--".
5344         (_initialize_thread): Update help "tfaas" to mention supported
5345         options and install command completer.
5346
5347 2019-06-13  Pedro Alves  <palves@redhat.com>
5348
5349         * completer.c (complete_nested_command_line): New.
5350         (gdb_completion_word_break_characters_throw): Add assertion.
5351         * completer.h (complete_nested_command_line): Declare.
5352
5353 2019-06-13  Pedro Alves  <palves@redhat.com>
5354
5355         * stack.c (parse_backtrace_qualifiers): New.
5356         (backtrace_command): Use it.
5357         (backtrace_command_completer): Complete on qualifiers.
5358
5359 2019-06-13  Pedro Alves  <palves@redhat.com>
5360
5361         * frame.c: Include "cli/cli-option.h.
5362         (user_set_backtrace_options): New.
5363         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5364         Delete.
5365         (get_prev_frame): Adjust.
5366         (boolean_option_def, uinteger_option_def)
5367         (set_backtrace_option_defs): New.
5368         (_initialize_frame): Adjust and use
5369         gdb::option::add_setshow_cmds_for_options to install "set
5370         backtrace past-main" and "set backtrace past-entry".
5371         * frame.h: Include "cli/cli-option.h".
5372         (struct frame_print_options): Forward declare.
5373         (print_frame_arguments_all, print_frame_arguments_scalars)
5374         (print_frame_arguments_none): Declare.
5375         (print_entry_values): Delete declaration.
5376         (struct frame_print_options, user_frame_print_options): New.
5377         (struct set_backtrace_options): New.
5378         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5379         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5380         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5381         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5382         (list_args_or_locals): Add frame_print_options parameter.
5383         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5384         * python/py-framefilter.c (enumerate_args): Pass down
5385         USER_FRAME_PRINT_OPTIONS.
5386         * stack.c: Include "cli/cli-option.h".
5387         (print_frame_arguments_all, print_frame_arguments_scalars)
5388         (print_frame_arguments_none): Declare.
5389         (print_raw_frame_arguments, print_entry_values): Delete.
5390         (user_frame_print_options): New.
5391         (boolean_option_def, enum_option_def, frame_print_option_defs):
5392         New.
5393         (struct backtrace_cmd_options): New.
5394         (bt_flag_option_def): New.
5395         (backtrace_command_option_defs): New.
5396         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5397         (print_frame_arg, read_frame_arg, print_frame_args)
5398         (print_frame_info, print_frame): Add frame_print_options parameter
5399         and use it.
5400         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5401         (backtrace_command_1): Add frame_print_options and
5402         backtrace_cmd_options parameters and use them.
5403         (make_backtrace_options_def_group): New.
5404         (backtrace_command): Process command options with
5405         gdb::option::process_options.
5406         (backtrace_command_completer): New.
5407         (_initialize_stack): Extend "backtrace"'s help to mention
5408         supported options.  Install completer for "backtrace".
5409         Install some settings commands with add_setshow_cmds_for_options.
5410
5411 2019-06-13  Pedro Alves  <palves@redhat.com>
5412
5413         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5414         and that "set/show print raw frame-arguments" are now deprecated.
5415
5416         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5417         command.
5418         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5419         * stack.c (_initialize_stack): Install "set/show print
5420         raw-frame-arguments", and deprecate "set/show print raw
5421         frame-arguments".
5422         * valprint.c (_initialize_valprint): Deprecate "set/show print
5423         raw".
5424
5425 2019-06-13  Pedro Alves  <palves@redhat.com>
5426
5427         * compile/compile.c (struct compile_options): New.
5428         (compile_flag_option_def, compile_command_option_defs)
5429         (make_compile_options_def_group): New.
5430         (compile_file_command): Handle options with
5431         gdb::option::process_options.
5432         (compile_file_command_completer): New function.
5433         (compile_code_command): Handle options with
5434         gdb::option::process_options.
5435         (compile_code_command_completer): New function.
5436         (_initialize_compiler): Install completers for "compile code" and
5437         "compile file".  Mention available options in "compile code" and
5438         "compile code"'s help.
5439         * completer.c (advance_to_completion_word): New, factored out from
5440         ...
5441         (advance_to_expression_complete_word_point): ... this.
5442         (advance_to_filename_complete_word_point): New.
5443         * completer.h (advance_to_filename_complete_word_point): New
5444         declaration.
5445
5446 2019-06-13  Pedro Alves  <palves@redhat.com>
5447
5448         * compile/compile.c: Include "cli/cli-option.h".
5449         (compile_print_value): Scope data pointer is now a
5450         value_print_options pointer; adjust.
5451         (compile_print_command): Process options.  Scope data pointer is
5452         now a value_print_options pointer; adjust.
5453         (_initialize_compile): Update "compile print"'s help to include
5454         supported options.  Install a completer for "compile print".
5455         * cp-valprint.c (show_vtblprint, show_objectprint)
5456         (show_static_field_print): Delete.
5457         (_initialize_cp_valprint): Don't install "set print
5458         static-members", "set print vtbl", "set print object" here.
5459         * printcmd.c: Include "cli/cli-option.h" and
5460         "common/gdb_optional.h".
5461         (print_command_parse_format): Rework to fill in a
5462         value_print_options instead of a format_data.
5463         (print_value): Change parameter type from format_data pointer to
5464         value_print_options reference.  Adjust.
5465         (print_command_1): Process options.  Adjust to pass down a
5466         value_print_options.
5467         (print_command_completer): New.
5468         (_initialize_printcmd): Install print_command_completer as
5469         handle_brkchars completer for the "print" command.  Update
5470         "print"'s help to include supported options.
5471         * valprint.c: Include "cli/cli-option.h".
5472         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5473         here from cp-valprint.c.
5474         (boolean_option_def, uinteger_option_def)
5475         (value_print_option_defs, make_value_print_options_def_group):
5476         New.  Use gdb::option::add_setshow_cmds_for_options to install
5477         "set print elements", "set print null-stop", "set print repeats",
5478         "set print pretty", "set print union", "set print array", "set
5479         print address", "set print symbol", "set print array-indexes".
5480         * valprint.h: Include <string> and "cli/cli-option.h".
5481         (make_value_print_options_def_group): Declare.
5482         (print_value): Change parameter type from format_data pointer to
5483         value_print_options reference.
5484         (print_command_completer): Declare.
5485
5486 2019-06-13  Pedro Alves  <palves@redhat.com>
5487
5488         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5489         (COMMON_SFILES): Add maint-test-settings.c.
5490         * cli/cli-decode.c (boolean_enums): New global, factored out from
5491         ...
5492         (add_setshow_boolean_cmd): ... here.
5493         * cli/cli-decode.h (boolean_enums): Declare.
5494         * cli/cli-option.c: New file.
5495         * cli/cli-option.h: New file.
5496         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5497         factored out from ...
5498         (parse_cli_boolean_value(const char *)): ... this.
5499         (is_unlimited_literal): Change parameter type to pointer to
5500         pointer.  Adjust and advance ARG pointer.
5501         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5502         (parse_cli_var_enum): New, factored out from ...
5503         (do_set_command): ... this.  Adjust.
5504         * cli/cli-setshow.h (parse_cli_boolean_value)
5505         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5506         (parse_cli_var_enum): Declare.
5507         * cli/cli-utils.c: Include "cli/cli-option.h".
5508         (get_ulongest): New.
5509         * cli/cli-utils.h (get_ulongest): Declare.
5510         (check_for_argument): New overloads.
5511         * maint-test-options.c: New file.
5512
5513 2019-06-13  Pedro Alves  <palves@redhat.com>
5514
5515         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5516         parse a range if "-" is at the end of the string.
5517
5518 2019-06-13  Pedro Alves  <palves@redhat.com>
5519
5520         * cli/cli-setshow.c (parse_auto_binary_operation)
5521         (parse_cli_boolean_value): Don't allow "o".
5522
5523 2019-06-13  Pedro Alves  <palves@redhat.com>
5524
5525         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5526         * NEWS: Mention maint test-settings KIND.
5527         * maint-test-settings.c: New file.
5528
5529 2019-06-13  Pedro Alves  <palves@redhat.com>
5530
5531         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5532         completer.
5533         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5534         "set" completers.
5535
5536 2019-06-13  Pedro Alves  <palves@redhat.com>
5537
5538         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5539         after item.
5540
5541 2019-06-13  Pedro Alves  <palves@redhat.com>
5542
5543         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5544
5545 2019-06-13  Pedro Alves <palves@redhat.com>
5546
5547         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5548         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5549         call.
5550         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5551         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5552         calls.
5553         (check_for_argument): Skip spaces after argument.
5554
5555 2019-06-13  Pedro Alves  <palves@redhat.com>
5556
5557         * thread.c (thread_apply_command): Adjust TID parsing.
5558         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5559         detected before end of string.
5560         (tid_is_in_list): Error out if LIST is invalid.
5561
5562 2019-06-13  Pedro Alves  <palves@redhat.com>
5563
5564         * completer.c (complete_line_internal_1): Rewind completion word
5565         point.
5566         (completion_tracker::advance_custom_word_point_by): Change
5567         parameter type to int.
5568         * completer.h (completion_tracker::advance_custom_word_point_by):
5569         Likewise.
5570
5571 2019-06-13  Pedro Alves  <palves@redhat.com>
5572
5573         * completer.c (advance_to_completion_word): Handle delimiters.
5574
5575 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5576
5577         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5578
5579 2019-06-11  Tom Tromey  <tom@tromey.com>
5580
5581         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5582         (xmalloc_failed): Move to alloc.c.
5583         * alloc.c: New file.
5584         * Makefile.in (COMMON_SFILES): Add alloc.c.
5585
5586 2019-06-11  Tom Tromey  <tom@tromey.com>
5587
5588         * nat/linux-waitpid.c: Don't include server.h.
5589         (linux_debug): Remove.
5590         (my_waitpid): Update.
5591
5592 2019-06-11  Tom Tromey  <tromey@adacore.com>
5593
5594         * infcall.c (_initialize_infcall): Remove trailing newline from
5595         help.
5596         * user-regs.c (_initialize_user_regs): Remove trailing newline
5597         from help.
5598         * typeprint.c (_initialize_typeprint): Remove trailing newline
5599         from help.
5600         * reverse.c (_initialize_reverse): Remove trailing newlines from
5601         help.
5602         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5603         from help.
5604         * language.c (add_set_language_command): Remove trailing newline
5605         from help.
5606         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5607         help.
5608         * disasm.c (_initialize_disasm): Remove trailing newline from
5609         help.
5610         * top.c (init_main): Remove trailing newline from help.
5611         * interps.c (_initialize_interpreter): Remove trailing newline
5612         from help.
5613         * btrace.c (_initialize_btrace): Remove trailing newlines from
5614         help.
5615         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5616         from help.
5617         * python/python.c (_initialize_python): Remove trailing newline
5618         from help.
5619         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5620         help.
5621         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5622         from help.  Reformat some text.
5623         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5624         from help.
5625         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5626         newline from help.
5627
5628 2019-06-11  Tom Tromey  <tromey@adacore.com>
5629
5630         * darwin-nat.c (darwin_decode_exception_message)
5631         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5632
5633 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5634
5635         * valops.c (value_slice): Check for not allocated or not
5636         associated values.
5637
5638 2019-06-10  Tom de Vries  <tdevries@suse.de>
5639
5640         PR gdb/24618
5641         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5642         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5643         invalid.
5644
5645 2019-06-10  Tom de Vries  <tdevries@suse.de>
5646
5647         PR gdb/24611
5648         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5649         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5650
5651 2019-06-10  Tom de Vries  <tdevries@suse.de>
5652
5653         PR symtab/24545
5654         * symtab.c (struct demangled_name_entry): Add language field.
5655         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5656         static minimal symbol".  Set and use language field.
5657
5658 2019-06-10  Tom Tromey  <tromey@adacore.com>
5659
5660         * ada-lang.c (_initialize_ada_language): Update help text.
5661
5662 2019-06-10  Tom Tromey  <tromey@adacore.com>
5663
5664         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5665         with a newline.
5666         * guile/guile.c (handle_boot_error): Don't end warning with a
5667         newline.
5668         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5669         warning with a newline.
5670         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5671         newline.
5672         (s12z_frame_cache): Likewise.
5673         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5674         a newline.
5675         * solib-svr4.c (disable_probes_interface): Don't end warning with
5676         a newline.
5677         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5678         newline.
5679         * python/python.c (do_finish_initialization): Don't end warning
5680         with a newline.
5681
5682 2019-06-10  Tom Tromey  <tom@tromey.com>
5683
5684         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5685         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5686         gdbpy_enter.
5687
5688 2019-06-10  Tom Tromey  <tromey@adacore.com>
5689
5690         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5691         data.
5692         (elf_new_init): Don't call stabsread_new_init.
5693         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5694         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5695         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5696
5697 2019-06-10  Tom de Vries  <tdevries@suse.de>
5698
5699         PR symtab/16264
5700         PR symtab/24517
5701         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5702
5703 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5704
5705         * source.c (find_and_open_source): Also rewrite relative file
5706         names.
5707
5708 2019-04-26  Amos Bird  <amosbird@gmail.com>
5709
5710         * annotate.c (annotate_thread_exited): Add "thread-exited"
5711         annotation.
5712
5713 2019-06-06  Tom Tromey  <tromey@adacore.com>
5714
5715         * maint.h (class scoped_command_stats): Use
5716         DISABLE_COPY_AND_ASSIGN.
5717         <print_time>: New method.
5718         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5719         print_time.
5720         (scoped_command_stats::print_time): New method.
5721
5722 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5723
5724         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5725         instructions of lengths 6 or 8 bytes.
5726
5727 2019-06-04  Pedro Alves  <palves@redhat.com>
5728
5729         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5730
5731         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5732         * breakpoint.c (condition_completer): Likewise.
5733         * cli/cli-dump.c (scan_expression): Likewise.
5734         * common/filestuff.c (mkdir_recursive): Likewise.
5735         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5736         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5737         (gdb_abspath): Likewise.
5738         * compile/compile-cplus-types.c
5739         (compile_cplus_instance::decl_name): Likewise.
5740         * completer.c (complete_explicit_location):
5741         (signal_completer, reg_or_group_completer_1): Likewise.
5742         * cp-support.c (cp_remove_params_if_any): Likewise.
5743         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5744         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5745         * infcmd.c (strip_bg_char): Likewise.
5746         * linespec.c (copy_token_string): Likewise.
5747         * mi/mi-main.c (output_cores): Likewise.
5748         * psymtab.c (psymtab_search_name):
5749         * symfile.c (test_set_ext_lang_command): Likewise.
5750         * target.c (target_fileio_read_stralloc): Likewise.
5751         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5752         * value.c (complete_internalvar): Likewise.
5753
5754 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5755
5756         Add objfile property to gdb.Type.
5757         * NEWS: Mention Python API addition.
5758         * python/py-type.c (typy_get_objfile): New method.
5759
5760 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5761
5762         * NEWS: Mention the new set|show style [title|highlight].
5763         Mention changes to "show style", "help" and "apropos".
5764
5765 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5766
5767         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5768         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5769         instead of print_help_for_command.
5770         (print_doc_of_command): New function.
5771         (help_list): Add 'apropos -v word' suggestion.
5772         (print_help_for_command): Style the command name using title style.
5773         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5774         (_initialize_cli_cmds): Describe -v in apropos_command help.
5775
5776 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5777
5778         * cli/cli-style.h (cli_style_option): Add name in constructor,
5779         add m_name class member, add constructor with intensity,
5780         add name class function.
5781         (cli_style_option::add_setshow_commands): Remove name argument.
5782         (highlight_style, title_style): New styles.
5783         * cli/cli-style.c (do_show): New function that shows a style
5784         characteristic styling the style name with itself.
5785         (set_style_name): New function.
5786         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5787         Update all callers according to the changes in cli/cli-style.h.
5788         * utils.h (fputs_highlighted): New function.
5789         * utils.c (fputs_highlighted): Likewise.
5790
5791 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5792
5793         * NEWS: Mention new pipe command and new convenience variables.
5794
5795 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5796
5797         * cli/cli-cmds.c (pipe_command): New function.
5798         (_initialize_cli_cmds): Call add_com for pipe_command.
5799         Define | as an alias for pipe.
5800         (exit_status_set_internal_vars): New function.
5801         (shell_escape): Call exit_status_set_internal_vars.
5802         cli/cli-decode.c (find_command_name_length): Recognize | as
5803         a single character command.
5804
5805 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5806
5807         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5808         top.c (execute_command_to_ui_file): New function, mostly a copy
5809         of execute_command_to_string.
5810         (execute_command_to_string): Implement by calling
5811         execute_command_to_ui_file.
5812
5813 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5814
5815         * top.h (saved_command_line): Remove declaration.
5816         * top.c (previous_saved_command_line, previous_repeat_arguments):
5817         New variables.
5818         (saved_command_line): Make static, define together with other
5819         'repeat variables'.
5820         (dont_repeat): Clear repeat_arguments.
5821         (repeat_previous, get_saved_command_line, save_command_line):
5822         New functions.
5823         (gdb_init): Initialize saved_command_line
5824         and previous_saved_command_line.
5825         * main.c (captured_main_1): Remove saved_command_line initialization.
5826         * event-top.c (handle_line_of_input): Update to use
5827         the new 'repeat' related functions instead of direct access to
5828         saved_command_line.
5829         * command.h (repeat_previous, get_saved_command_line,
5830         save_command_line): New declarations.
5831         (dont_repeat): Add comment.
5832
5833 2019-05-30  Tom Tromey  <tromey@adacore.com>
5834
5835         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5836         Fix comment.
5837         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5838
5839 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5840
5841         PR cli/24587
5842         * completer.c (complete): Initialize variable word.
5843
5844 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5845
5846         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5847         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5848         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5849         'body' is NULL to the outter 'if', protecting the '!is_define'
5850         situation as well.
5851
5852 2019-05-29  Tom Tromey  <tromey@adacore.com>
5853
5854         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5855         (dwarf_unknown): New function.
5856         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5857         (dwarf_type_encoding_name): Use dwarf_unknown.
5858
5859 2019-05-29  Tom Tromey  <tromey@adacore.com>
5860
5861         PR c++/20020:
5862         * cp-valprint.c (cp_print_value_fields): Call
5863         cp_print_static_field inside "try".
5864
5865 2019-05-29  Tom Tromey  <tromey@adacore.com>
5866
5867         * inflow.c (struct terminal_info): Add default operator=.
5868         * configure: Rebuild.
5869         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5870         -Wdeprecated-copy-dtor, -Wredundant-move.
5871
5872 2019-05-29  Tom Tromey  <tromey@adacore.com>
5873
5874         * NEWS: Add entry.
5875         * infcmd.c (print_return_value_1): Handle finish_print
5876         option.
5877         (show_print_finish): New function.
5878         (_initialize_infcmd): Add "set/show print finish" commands.
5879         * valprint.c (user_print_options): Initialize new member.
5880         * valprint.h (struct value_print_options) <finish_print>: New
5881         member.
5882
5883 2019-05-28  Tom Tromey  <tromey@adacore.com>
5884
5885         * ada-lang.c (ada_remove_Xbn_suffix)
5886         (find_old_style_renaming_symbol)
5887         (parse_old_style_renaming): Remove.
5888         (ada_find_renaming_symbol): Don't call
5889         find_old_style_renaming_symbol.
5890         (ada_is_renaming_symbol): Rename from
5891         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5892         bool.  Now static.
5893         (ada_read_var_value): Update and simplify.
5894         * ada-exp.y (write_var_or_type): Remove old code.
5895
5896 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5897
5898         * event-top.c: Remove include comment.
5899         * inflow.c (class scoped_ignore_sigttou): Move from here...
5900         * inflow.h (class scoped_ignore_sigttou): ...to here.
5901         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5902         * top.c:  Remove include comment.
5903
5904 2019-05-27  Tom Tromey  <tom@tromey.com>
5905
5906         * NEWS: Fix typo.
5907
5908 2019-05-22  Tom Tromey  <tromey@adacore.com>
5909
5910         * target.c (target_follow_exec): Constify parameter.
5911         * target-delegates.c: Rebuild.
5912         * remote.c (remote_target::follow_exec): Constify parameter.
5913         * infrun.c (follow_exec): Constify parameter.
5914         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5915         (target_follow_exec): Likewise.
5916
5917 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5918
5919         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5920         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5921
5922 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5923
5924         * NEWS: Add debugredirect and testsuite sections.
5925
5926 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5927
5928         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5929         target descriptions using exclusively floating point register name
5930         aliases.
5931
5932 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         PR gdb/18644:
5935         * f-lang.c (build_fortran_types): Handle the case where
5936         gdbarch_floatformat_for_type returns a nullptr.
5937
5938 2019-05-21  Tom de Vries  <tdevries@suse.de>
5939
5940         PR cli/24587
5941         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5942
5943 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5944
5945         PR gdb/18644:
5946         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5947         16-byte floats.
5948         * i386-tdep.c (i386_floatformat_for_type): Use
5949         floatformats_ia64_quad for the 16-byte floating point component
5950         within a fortran 32-byte complex number.
5951
5952 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5953
5954         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5955         delete default constructor.
5956         (find_partial_die): Update to return const struct.
5957         (partial_die_parent_scope): Move variable declaration into scope
5958         of its use and change its type to auto.
5959         (guess_partial_die_structure_name): Likewise.
5960         (partial_die_info::fixup): Likewise.
5961
5962 2019-05-17  Tom Tromey  <tromey@adacore.com>
5963
5964         * source.c (find_and_open_source): Remove cast.
5965
5966 2019-05-17  Tom Tromey  <tromey@adacore.com>
5967
5968         * annotate.c (annotate_source): Make "filename" const.
5969         * annotate.h (annotate_source): Use const.
5970
5971 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5972
5973         * disasm.c (set_disassembler_options): Send errors to stderr.
5974
5975 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5976
5977         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5978         (cli_interp_base::set_logging): Check debug_redirect.
5979         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5980         * cli/cli-logging.c (debug_redirect): Add static variable.
5981         (pop_output_files): Add default param.
5982         (handle_redirections): Print debug setting.
5983         (show_logging_command): Likewise.
5984         (_initialize_cli_logging): Add debugredirect command.
5985         * interps.c (current_interp_set_logging): Add debug_redirect
5986         parameter.
5987         * interps.h (set_logging): Add debug_redirect parameter.
5988         (current_interp_set_logging): Likewise.
5989         * mi/mi-common.h: Likewise.
5990         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5991
5992 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5993             Tom Tromey  <tromey@adacore.com>
5994
5995         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5996         directly.
5997         * cli/cli-interp.h (make_logging_output): Remove declaration.
5998         * cli/cli-logging.c (make_logging_output): Remove function.
5999         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6000         directly.
6001         * ui-file.c (tee_file::tee_file): Remove bools.
6002         (tee_file::~tee_file): Remove deletes.
6003         * ui-file.h (tee_file): Remove bools.
6004
6005 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6006
6007         * mi/mi-cmds.h (mi_cmd_complete): New function.
6008         * mi/mi-main.c (mi_cmd_complete): Likewise.
6009         * mi/mi-cmds.c: Define new MI command -complete.
6010         * NEWS: Mention new -complete command.
6011
6012 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6013
6014         * completer.h (complete): New function.
6015         * completer.c (complete): Likewise.
6016         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6017         function defined in completer.h.
6018
6019 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6020
6021         * MAINTAINERS (Write After Approval): Add myself.
6022
6023 2019-05-17  Tom de Vries  <tdevries@suse.de>
6024
6025         PR gdb/24094
6026         * dwarf2read.c (struct cu_partial_die_info): New struct.
6027         (find_partial_die): Return cu_partial_die_info.
6028         (partial_die_parent_scope, guess_partial_die_structure_name)
6029         (partial_die_info::fixup): Handle new return type of find_partial_die.
6030
6031 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6032
6033         PR breakpoints/24541
6034         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6035         "std::string", simplifying the algorithm.
6036
6037 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6038
6039         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6040         (stap_static_probe_ops::get_probes): Likewise.
6041
6042 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6043
6044         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6045         '-')" and "else if".
6046         (stap_parse_single_operand): Join checks for
6047         "gdbarch_stap_parse_special_token_p" and
6048         "gdbarch_stap_parse_special_token" in the same "if" statement.
6049         Invert check when verifying for operation on register
6050         displacement.
6051
6052 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6053
6054         * stap-probe.c (stap_get_opcode): Update comment.
6055         (stap_get_expected_argument_type): Likewise.
6056         (handle_stap_probe): Likewise.
6057
6058 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6059
6060         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6061         return type to 'bool'.  Adjust comment.  Use 'bool' when
6062         appropriate.
6063         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6064         * stap-probe.c (stap_parse_argument_1): Likewise.
6065         (stap_is_operator): Likewise.
6066         (stap_is_generic_prefix): Likewise.
6067         (stap_is_register_prefix): Likewise.
6068         (stap_is_register_indirection_prefix): Likewise.
6069         (stap_is_integer_prefix): Likewise.
6070         (stap_generic_check_suffix): Likewise.
6071         (stap_check_integer_suffix): Likewise.
6072         (stap_check_register_suffix): Likewise.
6073         (stap_check_register_indirection_suffix): Likewise.
6074         (stap_parse_register_operand): Likewise.
6075         (stap_parse_single_operand): Likewise.
6076         (stap_parse_argument_1): Likewise.
6077         (stap_probe::get_argument_count): Likewise.
6078         (stap_is_operator): Likewise.
6079
6080 2019-05-16  Tom Tromey  <tromey@adacore.com>
6081
6082         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6083         keyword to foreach.
6084
6085 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6086
6087         * linux-thread-db.c (try_thread_db_load_1): Change return type
6088         to bool.
6089         (try_thread_db_load): Likewise.
6090         (try_thread_db_load_from_pdir_1): Likewise.
6091         (try_thread_db_load_from_pdir): Likewise.
6092         (try_thread_db_load_from_sdir): Likewise.
6093         (try_thread_db_load_from_dir): Likewise.
6094         (thread_db_load_search): Likewise.
6095         (has_libpthread): Likewise.
6096         (thread_db_load): Likewise.
6097
6098 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6099
6100         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6101         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6102         NULL, and complain/return if that's the case.
6103
6104 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6105
6106         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6107         (advance, posn, abstract_read_memory): New functions.
6108         [struct mem_read_abstraction]: New struct.
6109         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6110
6111 2019-05-14  Tom Tromey  <tromey@adacore.com>
6112
6113         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6114         value is not lval_memory.
6115
6116 2019-05-14  Tom Tromey  <tromey@adacore.com>
6117
6118         * solib.c (info_sharedlibrary_command): Style the file name.
6119
6120 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6121
6122         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6123         (aarch64_vnv_type): Likewise.
6124         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6125         * common/tdesc.c: Likewise.
6126         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6127         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6128         * features/aarch64-fpu.xml: Add ieee half view.
6129         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6130         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6131         * gdbtypes.h (struct builtin_type): Likewise.
6132         (struct objfile_type): Likewise.
6133
6134 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6135
6136         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6137         typo.
6138         * location.h (string_to_event_location): Likewise.
6139
6140 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6141
6142         GDB 8.3 released.
6143
6144 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6145
6146         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6147         New variable declaration.
6148         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6149         New variable.
6150         (print_one_breakpoint): Use ui_out::test_flags and new global
6151         variable to compute use_fixed_output.
6152         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6153         Remove.
6154         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6155         (mi_multi_location_breakpoint_output_fixed): Remove.
6156         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6157         new variable.
6158         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6159         fix_multi_location_breakpoint_output flag if version >= 3.
6160         * ui-out.h (enum ui_out_flag)
6161         <fix_multi_location_breakpoint_output>: New enumerator.
6162
6163 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6164
6165         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6166
6167 2019-05-10  Tom Tromey  <tromey@adacore.com>
6168
6169         * ada-lang.c (catch_ada_completer): New function.
6170         (_initialize_ada_language): Use it.
6171
6172 2019-05-10  Tom Tromey  <tromey@adacore.com>
6173
6174         * thread.c (print_thread_info): Make "requested_threads" const.
6175         * gdbthread.h (print_thread_info): Make "requested_threads"
6176         const.
6177         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6178         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6179
6180 2019-05-08  Tom Tromey  <tom@tromey.com>
6181
6182         * gdbtypes.c (objfile_type_data): Change type.
6183         (objfile_type, _initialize_gdbtypes): Update.
6184
6185 2019-05-08  Tom Tromey  <tom@tromey.com>
6186
6187         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6188         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6189         (_initialize_dwarf2_frame): Update.
6190
6191 2019-05-08  Tom Tromey  <tom@tromey.com>
6192
6193         * objc-lang.c (objc_objfile_data): Change type.
6194         (find_methods): Update.
6195         (_initialize_objc_lang): Remove.
6196
6197 2019-05-08  Tom Tromey  <tom@tromey.com>
6198
6199         * stabsread.c (rs6000_builtin_type_data): Change type.
6200         (rs6000_builtin_type, _initialize_stabsread): Update.
6201
6202 2019-05-08  Tom Tromey  <tom@tromey.com>
6203
6204         * mips-tdep.c (mips_pdr_data): Remove.
6205         (_initialize_mips_tdep): Update.
6206
6207 2019-05-08  Tom Tromey  <tom@tromey.com>
6208
6209         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6210         (hppa_init_objfile_priv_data, read_unwind_info)
6211         (find_unwind_entry, _initialize_hppa_tdep): Update.
6212
6213 2019-05-08  Tom Tromey  <tom@tromey.com>
6214
6215         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6216         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6217         on obstack.
6218         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6219
6220 2019-05-08  Tom Tromey  <tom@tromey.com>
6221
6222         * mdebugread.c (basic_type_data): Change type.
6223         (basic_type, _initialize_mdebugread): Update.
6224
6225 2019-05-08  Tom Tromey  <tom@tromey.com>
6226
6227         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6228
6229 2019-05-08  Tom Tromey  <tom@tromey.com>
6230
6231         * nto-tdep.c (nto_inferior_data_reg): Change type.
6232         (nto_inferior_data): Update.
6233         (nto_inferior_data_cleanup, nto_new_inferior_data)
6234         (_initialize_nto_tdep): Remove.
6235         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6236
6237 2019-05-08  Tom Tromey  <tom@tromey.com>
6238
6239         * ada-lang.c (struct ada_inferior_data): Add initializers.
6240         (ada_inferior_data): Change type.
6241         (ada_inferior_data_cleanup): Remove.
6242         (get_ada_inferior_data, ada_inferior_exit)
6243         (struct ada_pspace_data): Add initializers, destructor.
6244         (ada_pspace_data_handle): Change type.
6245         (get_ada_pspace_data): Update.
6246         (ada_pspace_data_cleanup): Remove.
6247
6248 2019-05-08  Tom Tromey  <tom@tromey.com>
6249
6250         * coffread.c (struct coff_symfile_info): Add initializers.
6251         (coff_objfile_data_key): Move lower.  Change type.
6252         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6253         Update.
6254         (coff_free_info): Remove.
6255
6256 2019-05-08  Tom Tromey  <tom@tromey.com>
6257
6258         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6259         (fbsd_pspace_data_handle): Move lower.  Change type.
6260         (get_fbsd_pspace_data): Update.
6261         (fbsd_pspace_data_cleanup): Remove.
6262         (_initialize_fbsd_tdep): Update.
6263
6264 2019-05-08  Tom Tromey  <tom@tromey.com>
6265
6266         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6267         (get_ada_tasks_pspace_data): Update.
6268         (ada_tasks_pspace_data_cleanup): Remove.
6269         (_initialize_tasks): Update.
6270         (ada_tasks_inferior_data_handle): Change type.
6271         (get_ada_tasks_inferior_data): Update.
6272         (ada_tasks_inferior_data_cleanup): Remove.
6273         (struct ada_tasks_pspace_data): Add initializers.
6274
6275 2019-05-08  Tom Tromey  <tom@tromey.com>
6276
6277         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6278         * symfile-debug.c (debug_sym_get_probes): Change type.
6279         * stap-probe.c (handle_stap_probe):
6280         (stap_static_probe_ops::get_probes): Change type.
6281         * probe.h (class static_probe_ops) <get_probes>: Change type.
6282         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6283         (parse_probes_in_pspace): Update.
6284         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6285         Update.
6286         (any_static_probe_ops::get_probes): Change type.
6287         * elfread.c (elfread_data): New typedef.
6288         (probe_key): Change type.
6289         (elf_get_probes): Likewise.  Update.
6290         (probe_key_free): Remove.
6291         (_initialize_elfread): Update.
6292         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6293         Change type.
6294         (dtrace_process_dof_probe, dtrace_process_dof)
6295         (dtrace_static_probe_ops::get_probe): Change type.
6296
6297 2019-05-08  Tom Tromey  <tom@tromey.com>
6298
6299         * xcoffread.c (struct xcoff_symfile_info): Rename from
6300         coff_symfile_info.  Add initializers.
6301         (xcoff_objfile_data_key): Move lower.  Change type.
6302         (XCOFF_DATA): Rewrite.
6303         (xcoff_free_info): Remove.
6304         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6305         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6306         (xcoff_initial_scan): Update.
6307
6308 2019-05-08  Tom Tromey  <tom@tromey.com>
6309
6310         * solib-svr4.c (struct svr4_info): Add initializers and
6311         destructor.
6312         <probes_table>: Now an htab_up.
6313         (solib_svr4_pspace_data): Change type.
6314         (free_probes_table): Simplify.
6315         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6316         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6317         (probes_table_remove_objfile_probes, register_solib_event_probe)
6318         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6319         (_initialize_svr4_solib): Update.
6320
6321 2019-05-08  Tom Tromey  <tom@tromey.com>
6322
6323         * remote.c (remote_pspace_data): Change type.
6324         (remote_pspace_data_cleanup): Remove.
6325         (get_remote_exec_file, set_pspace_remote_exec_file)
6326         (_initialize_remote): Update.
6327
6328 2019-05-08  Tom Tromey  <tom@tromey.com>
6329
6330         * breakpoint.c (breakpoint_objfile_key): Change type.
6331         (get_breakpoint_objfile_data): Update.
6332         (free_breakpoint_objfile_data): Remove.
6333         (_initialize_breakpoint): Update.
6334
6335 2019-05-08  Tom Tromey  <tom@tromey.com>
6336
6337         * linux-tdep.c (struct linux_info): Add initializers.
6338         (linux_inferior_data): Move.  Change type.
6339         (invalidate_linux_cache_inf): Update.
6340         (linux_inferior_data_cleanup): Remove.
6341         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6342
6343 2019-05-08  Tom Tromey  <tom@tromey.com>
6344
6345         * auxv.c (auxv_inferior_data): Move.  Change type.
6346         (auxv_inferior_data_cleanup): Remove.
6347         (invalidate_auxv_cache_inf): Rewrite.
6348         (get_auxv_inferior_data, _initialize_auxv): Update.
6349
6350 2019-05-08  Tom Tromey  <tom@tromey.com>
6351
6352         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6353         (symfile_debug_objfile_data_key): Change type.
6354         (symfile_debug_installed, debug_qf_has_symbols)
6355         (debug_qf_find_last_source_symtab)
6356         (debug_qf_forget_cached_source_info)
6357         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6358         (debug_qf_print_stats, debug_qf_dump)
6359         (debug_qf_expand_symtabs_for_function)
6360         (debug_qf_expand_all_symtabs)
6361         (debug_qf_expand_symtabs_with_fullname)
6362         (debug_qf_map_matching_symbols)
6363         (debug_qf_expand_symtabs_matching)
6364         (debug_qf_find_pc_sect_compunit_symtab)
6365         (debug_qf_map_symbol_filenames)
6366         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6367         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6368         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6369         (debug_sym_read_linetable, debug_sym_relocate): Update.
6370         (symfile_debug_free_objfile): Remove.
6371         (install_symfile_debug_logging, _initialize_symfile_debug):
6372         Update.
6373
6374 2019-05-08  Tom Tromey  <tom@tromey.com>
6375
6376         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6377         allocate_on_obstack.
6378         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6379         (get_dwarf2_per_objfile): Update.
6380         (set_dwarf2_per_objfile): Remove.
6381         (dwarf2_has_info, dwarf2_get_section_info): Update.
6382         (dwarf2_free_objfile): Remove.
6383         (_initialize_dwarf2_read): Update.
6384
6385 2019-05-08  Tom Tromey  <tom@tromey.com>
6386
6387         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6388         initializers.
6389         <unsupported_script_warning_printed,
6390         script_not_found_warning_printed>: Now bool.
6391         (auto_load_pspace_data): Change type.
6392         (~auto_load_pspace_info): Rename from
6393         auto_load_pspace_data_cleanup.
6394         (get_auto_load_pspace_data, init_loaded_scripts_info)
6395         (clear_section_scripts, maybe_print_unsupported_script_warning)
6396         (maybe_print_script_not_found_warning, _initialize_auto_load):
6397         Update.
6398
6399 2019-05-08  Tom Tromey  <tom@tromey.com>
6400
6401         * objfiles.c (objfile_pspace_info): Add destructor and
6402         initializers.
6403         (objfiles_pspace_data): Change type.
6404         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6405         (get_objfile_pspace_data): Update.
6406         (objfiles_bfd_data): Change type.
6407         (get_objfile_bfd_data): Update.
6408         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6409
6410 2019-05-08  Tom Tromey  <tom@tromey.com>
6411
6412         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6413         Change type.
6414         (get_catch_syscall_inferior_data): Update.
6415         (catch_syscall_inferior_data_cleanup): Remove.
6416         (_initialize_break_catch_syscall): Update.
6417
6418 2019-05-08  Tom Tromey  <tom@tromey.com>
6419
6420         * inflow.c (struct terminal_info): Add destructor and
6421         initializers.
6422         (inflow_inferior_data): Change type.
6423         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6424         (get_inflow_inferior_data, inflow_inferior_exit)
6425         (swap_terminal_info, _initialize_inflow): Update.
6426
6427 2019-05-08  Tom Tromey  <tom@tromey.com>
6428
6429         * target-dcache.c (target_dcache_cleanup): Remove.
6430         (target_dcache_aspace_key): Change type.
6431         (target_dcache_init_p, target_dcache_invalidate)
6432         (target_dcache_get, target_dcache_get_or_init)
6433         (_initialize_target_dcache): Update.
6434         * dcache.h (struct dcache_deleter): New.
6435
6436 2019-05-08  Tom Tromey  <tom@tromey.com>
6437
6438         * symtab.c (struct symbol_cache): Add destructor and
6439         initializers.
6440         (symbol_cache_key): Move.  Change type.
6441         (make_symbol_cache, free_symbol_cache): Remove.
6442         (get_symbol_cache): Update.
6443         (symbol_cache_cleanup): Remove.
6444         (ALL_PSPACES, symbol_cache_flush)
6445         (maintenance_print_symbol_cache)
6446         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6447         Update.
6448
6449 2019-05-08  Tom Tromey  <tom@tromey.com>
6450
6451         * symtab.c (struct main_info): Add destructor and initializers.
6452         (main_progspace_key): Move.  Change type.
6453         (get_main_info): Update.
6454         (main_info_cleanup): Remove.
6455         (_initialize_symtab): Update.
6456
6457 2019-05-08  Tom Tromey  <tom@tromey.com>
6458
6459         * registry.h (DECLARE_REGISTRY): Define the _key class.
6460
6461 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * NEWS: Merge two 'New commands' sections.
6464
6465 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6466
6467         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6468         parameter and use Ada language definition instead.
6469         (ada_val_print_ptr): Remove unused language parameter.
6470         (ada_val_print_num): Remove language parameter and use Ada language
6471         definition instead.
6472         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6473         parameter.
6474         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6475         parameter and use Ada language definition instead.
6476         (ada_val_print_1): Update all ada_val_print_xxx calls.
6477         Remove language parameter.
6478         (ada_val_print): Update ada_val_print_1 call.
6479
6480 2019-05-08  Tom Tromey  <tromey@adacore.com>
6481
6482         * remote.c (remote_hw_watchpoint_limit)
6483         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6484         Now static.
6485
6486 2019-05-08  Tom Tromey  <tromey@adacore.com>
6487
6488         * maint.c (_initialize_maint_cmds): Move initialization code to
6489         remote.c.
6490         (watchdog, show_watchdog): Move to remote.c.
6491         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6492         "watchdog" static.
6493         (_initialize_remote): Move initialization code from maint.c.
6494         * defs.h (watchdog): Don't declare.
6495
6496 2019-05-08  Tom Tromey  <tromey@adacore.com>
6497
6498         * tui/tui-interp.c: Include main.h.
6499         * interps.c: Include main.h.
6500         * main.h (interpreter_p): Declare.
6501         * defs.h (interpreter_p): Don't declare.
6502
6503 2019-05-08  Tom Tromey  <tromey@adacore.com>
6504
6505         * dwarf2loc.c: Include dwarf2read.h.
6506         * defs.h (read_unsigned_leb128): Don't declare.
6507         * dwarf2read.h (read_unsigned_leb128): Declare.
6508
6509 2019-05-08  Tom Tromey  <tromey@adacore.com>
6510
6511         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6512         method.
6513
6514 2019-05-08  Tom Tromey  <tromey@adacore.com>
6515
6516         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6517         when no wrap column is set.
6518
6519 2019-05-08  Tom Tromey  <tromey@adacore.com>
6520
6521         * c-lang.c (c_get_string): Handle non-C-style arrays.
6522
6523 2019-05-08  Tom Tromey  <tromey@adacore.com>
6524
6525         * typeprint.c (print_offset_data::update): Print the bit offset,
6526         not the number of bits remaining.
6527
6528 2019-05-08  Tom Tromey  <tromey@adacore.com>
6529
6530         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6531         padding at end of comment.
6532
6533 2019-05-08  Tom Tromey  <tromey@adacore.com>
6534
6535         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6536         Compare main types.
6537
6538 2019-05-06  Tom Tromey  <tom@tromey.com>
6539
6540         * common/scoped_mmap.c: Include common-defs.h.
6541         * common/scoped_mmap.h: Don't include config.h.
6542
6543 2019-05-04  Tom Tromey  <tom@tromey.com>
6544
6545         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6546         (struct aarch64_call_info): Add initializers.
6547         <si>: Now a std::vector.
6548         (pass_on_stack, aarch64_push_dummy_call): Update.
6549
6550 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6551             Tom Tromey  <tom@tromey.com>
6552
6553         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6554         (ppc_threads): Now a std::vector.  Now static.
6555         (hwdebug_find_thread_points_by_tid)
6556         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6557         Update.
6558
6559 2019-05-04  Tom Tromey  <tom@tromey.com>
6560
6561         * arc-tdep.c (arc_tdesc_init): Return bool.
6562
6563 2019-05-04  Tom Tromey  <tom@tromey.com>
6564
6565         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6566         Use gdb_assert_not_reached.
6567
6568 2019-05-04  Tom Tromey  <tom@tromey.com>
6569
6570         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6571         "false".
6572
6573 2019-05-04  Tom Tromey  <tom@tromey.com>
6574
6575         * arc-tdep.c (arc_tdesc_init): Use bool.
6576
6577 2019-05-04  Tom Tromey  <tom@tromey.com>
6578
6579         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6580
6581 2019-05-04  Tom Tromey  <tom@tromey.com>
6582
6583         * cli/cli-cmds.c (valid_command_p): Return bool.
6584
6585 2019-05-04  Tom Tromey  <tom@tromey.com>
6586
6587         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6588         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6589
6590 2019-05-04  Raul Tambre  <raul@tambre.ee>
6591
6592         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6593         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6594         operator for comparison.
6595
6596 2019-05-04  Tom Tromey  <tom@tromey.com>
6597
6598         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6599         (lookup_partial_symbol, print_partial_symbols)
6600         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6601         (psymbol_compare): Update.
6602         (add_psymbol_to_bcache): Clear the entire psymbol.
6603         (maintenance_check_psymtabs): Update.
6604         * psympriv.h (struct partial_symbol): Don't derive from
6605         general_symbol_info.
6606         <obj_section, unrelocated_address, address,
6607         set_unrelocated_address>: Update.
6608         <ginfo>: New member.
6609         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6610         (debug_names::write_psymbols): Update.
6611
6612 2019-05-04  Tom de Vries  <tdevries@suse.de>
6613
6614         * contrib/cc-with-tweaks.sh: Support -n arg.
6615
6616 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6617
6618         * corelow.c (core_target::detach): Ensure frame cache and
6619         register caches are cleared.
6620         inferior.c (exit_inferior_1): Likewise.
6621
6622 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6623             Tom Tromey  <tom@tromey.com>
6624
6625         * dictionary.c (collate_pending_symbols_by_language): Remove
6626         "struct" from foreach.
6627         * symtab.c (lookup_global_symbol_from_objfile)
6628         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6629         foreach.
6630         * ser-tcp.c (net_open): Remove "struct" from foreach.
6631         * objfiles.c (objfile_relocate, objfile_rebase)
6632         (objfile_has_symbols): Remove "struct" from foreach.
6633         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6634         from foreach.
6635         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6636         foreach.
6637         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6638         "struct" from foreach.
6639         * ada-lang.c (create_excep_cond_exprs)
6640         (ada_exception_catchpoint_cond_string): Remove "struct" from
6641         foreach.
6642
6643 2019-05-03  Tom Tromey  <tromey@adacore.com>
6644
6645         * ada-exp.y (convert_char_literal): Check suffix of each
6646         enumerator.
6647
6648 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6649
6650         PR ada/21406:
6651         * ada-exp.y (yywrap): Don't define.
6652         * ada-lex.l (%option): Add noyywrap
6653         (yywrap): Remove.
6654
6655 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6656
6657         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6658         _WIN32_WINNT to the XP level, unless already defined to a higher
6659         level.
6660
6661         * unittests/parse-connection-spec-selftests.c:
6662         * ser-tcp.c:
6663         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6664         override.
6665
6666         * symfile.c (find_separate_debug_file): Remove colon from the
6667         drive spec of DOS/Windows file names of the target, so that the
6668         file name produced from DEBUGDIR and the target's directory will
6669         be valid on DOS/Windows systems.
6670
6671 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6672
6673         * rust-lang.c (val_print_struct): Handle printing structures
6674         containing strings.
6675
6676 2019-05-02  Tom Tromey  <tromey@adacore.com>
6677
6678         * valarith.c (_initialize_valarith): Remove.
6679
6680 2019-05-01  Tom Tromey  <tromey@adacore.com>
6681
6682         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6683         bitfields.
6684
6685 2019-05-01  Tom Tromey  <tromey@adacore.com>
6686
6687         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6688         for big-endian copies.
6689
6690 2019-04-30  Ali Tamur  <tamur@google.com>
6691         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6692         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6693         (read_3_bytes): New function.
6694
6695 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6696
6697         * windows-nat.c (main_thread_id): Delete.
6698         (handle_output_debug_string): Replace main_thread_id by
6699         current_event.dwThreadId.
6700         (fake_create_process): Likewise.
6701         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6702         Do not set main_thread_id.
6703         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6704         current_event.dwThreadId.
6705         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6706
6707 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6708
6709         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6710         Use current_event.dwThreadId instead of main_thread_id.
6711
6712 2019-04-30  Tom Tromey  <tromey@adacore.com>
6713
6714         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6715         (create_excep_cond_exprs): Iterate over program spaces.
6716         (ada_exception_catchpoint_cond_string): Examine all minimal
6717         symbols for exception types.
6718
6719 2019-04-30  Tom Tromey  <tromey@adacore.com>
6720
6721         PR c++/24470:
6722         * dwarf2read.c (process_structure_scope): Handle case where type
6723         has template parameters but no symbol was created.
6724
6725 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6726             Chris January  <chris.january@arm.com>
6727
6728         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6729         qualifier.
6730         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6731
6732 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6733
6734         * f-typeprint.c (f_print_type): Update rules for printing
6735         whitespace.
6736         (f_type_print_varspec_suffix): Likewise.
6737
6738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6739             Chris January  <chris.january@arm.com>
6740
6741         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6742         function arguments.
6743
6744 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6745
6746         * f-lang.c (build_fortran_types): Change name of void type to
6747         lower case.
6748         * f-typeprint.c (f_type_print_base): Print the name of the void
6749         type, rather than a fixed string.
6750         * f-valprint.c (f_decorations): Use lower case void string.
6751
6752 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6753             Chris January  <chris.january@arm.com>
6754
6755         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6756         types for Fortran.
6757
6758 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6759             Chris January  <chris.january@arm.com>
6760             David Lecomber  <david.lecomber@arm.com>
6761
6762         * f-exp.y (BINOP_INTRINSIC): New token.
6763         (exp): New parser rule handling BINOP_INTRINSIC.
6764         (f77_keywords): Add new builtin procedures.
6765         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6766         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6767         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6768         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6769         (print_unop_subexp_f): New function.
6770         (print_binop_subexp_f): New function.
6771         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6772         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6773         (dump_subexp_body_f): Likewise.
6774         (operator_check_f): Likewise.
6775         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6776         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6777
6778 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6781         UNOP_KIND.
6782         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6783         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6784         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6785         (operator_length_f): New fuction.
6786         (print_subexp_f): New function.
6787         (op_name_f): New function.
6788         (dump_subexp_body_f): New function.
6789         (operator_check_f): New function.
6790         (exp_descriptor_f): Replace standard expression handling functions
6791         with new functions.
6792         * gdb/fortran-operator.def: New file.
6793         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6794         * gdb/std-operator.def: Remove UNOP_KIND.
6795
6796 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6797
6798         * std-operator.def: Remove unbalanced, stray double quote
6799         character.
6800
6801 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6802             Chris January  <chris.january@arm.com>
6803             Daniel Everett  <daniel.everett@arm.com>
6804             Nick Forrington  <nick.forrington@arm.com>
6805             Richard Bunt  <richard.bunt@arm.com>
6806
6807         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6808         of depth when printing anonymous structs or unions.
6809         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6810         Don't print either the top-level value, or the children if the
6811         max-depth is exceeded.
6812         (ppscm_print_children): When printing the key of a map, allow one
6813         extra level of depth.
6814         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6815         print either the top-level value, or the children if the max-depth
6816         is exceeded.
6817         (print_children): When printing the key of a map, allow one extra
6818         level of depth.
6819         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6820         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6821         (user_print_options): Initialise max_depth field.
6822         (val_print_scalar_or_string_type_p): New function.
6823         (val_print): Check to see if the max depth has been reached.
6824         (val_print_check_max_depth): Define new function.
6825         (show_print_max_depth): New function.
6826         (_initialize_valprint): Add 'print max-depth' option.
6827         * valprint.h (struct value_print_options) <max_depth>: New field.
6828         (val_print_check_max_depth): Declare new function.
6829         * NEWS: Document new feature.
6830
6831 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6832
6833         * ada-lang.c (ada_language_defn): Initialise new field.
6834         * c-lang.c (c_is_string_type_p): New function.
6835         (c_language_defn): Initialise new field.
6836         (cplus_language_defn): Initialise new field.
6837         (asm_language_defn): Initialise new field.
6838         (minimal_language_defn): Initialise new field.
6839         * c-lang.h (c_is_string_type_p): Declare new function.
6840         * d-lang.c (d_language_defn): Initialise new field.
6841         * f-lang.c (f_is_string_type_p): New function.
6842         (f_language_defn): Initialise new field.
6843         * go-lang.c (go_is_string_type_p): New function.
6844         (go_language_defn): Initialise new field.
6845         * language.c (default_is_string_type_p): New function.
6846         (unknown_language_defn): Initialise new field.
6847         (auto_language_defn): Initialise new field.
6848         * language.h (struct language_defn) <la_is_string_type_p>: New
6849         member variable.
6850         (default_is_string_type_p): Declare new function.
6851         * m2-lang.c (m2_language_defn): Initialise new field.
6852         * objc-lang.c (objc_language_defn): Initialise new field.
6853         * opencl-lang.c (opencl_language_defn): Initialise new field.
6854         * p-lang.c (pascal_is_string_type_p): New function.
6855         (pascal_language_defn): Initialise new field.
6856         * rust-lang.c (rust_is_string_type_p): New function.
6857         (rust_language_defn): Initialise new field.
6858
6859 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6860
6861         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6862         New field.
6863         * ada-lang.c (ada_language_defn): Initialise new field.
6864         * c-lang.c (c_language_defn): Likewise.
6865         (cplus_language_defn): Likewise.
6866         (asm_language_defn): Likewise.
6867         (minimal_language_defn): Likewise.
6868         * d-lang.c (d_language_defn): Likewise.
6869         * f-lang.c (f_language_defn): Likewise.
6870         * go-lang.c (go_language_defn): Likewise.
6871         * language.c (unknown_language_defn): Likewise.
6872         (auto_language_defn): Likewise.
6873         * m2-lang.c (m2_language_defn): Likewise.
6874         * objc-lang.c (objc_language_defn): Likewise.
6875         * opencl-lang.c (opencl_language_defn): Likewise.
6876         * p-lang.c (pascal_language_defn): Likewise.
6877         * rust-lang.c (rust_language_defn): Likewise.
6878
6879 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6880
6881         * ada-lang.c (ada_is_character_type): Change return type to bool.
6882         (ada_is_string_type): Likewise.
6883         * ada-lang.h (ada_is_character_type): Update declaration
6884         (ada_is_string_type): Likewise.
6885
6886 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6887
6888         Support style in 'frame|thread apply'
6889
6890         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6891         * record.c (record_start, record_stop): Update callers of
6892         execute_command_to_string with false.
6893         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6894         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6895         methods.
6896         (class string_file): New constructor with term_out parameter.
6897         Override methods term_out and can_emit_style_escape.  New member
6898         term_out.
6899         (class stdio_file): Override can_emit_style_escape.
6900         (class tee_file): Override term_out and can_emit_style_escape.
6901         * utils.h (can_emit_style_escape): Remove.
6902         * utils.c (can_emit_style_escape): Likewise.
6903         Update all callers of can_emit_style_escape (SOMESTREAM) to
6904         SOMESTREAM->can_emit_style_escape.
6905         * source-cache.c (source_cache::get_source_lines): Likewise.
6906         * stack.c (frame_apply_command_count): Call execute_command_to_string
6907         passing the term_out characteristic of the current gdb_stdout.
6908         * thread.c (thr_try_catch_cmd): Likewise.
6909         * top.c (execute_command_to_string): pass term_out parameter
6910         to construct the string_file for the command output.
6911         * ui-file.c (term_cli_styling): New function (most code moved
6912         from utils.c can_emit_style_escape).
6913         (string_file::string_file, string_file::can_emit_style_escape,
6914         stdio_file::can_emit_style_escape, tee_file::term_out,
6915         tee_file::can_emit_style_escape): New functions.
6916
6917 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6918
6919         * NEWS: Mention the new set|show may-call-functions.
6920         * infcall.c (may_call_functions_p): New variable.
6921         (show_may_call_functions_p): New function.
6922         (call_function_by_hand_dummy): Throws an error if not
6923         may-call-functions.
6924         (_initialize_infcall): Call add_setshow_boolean_cmd for
6925         may-call-functions.
6926
6927 2019-04-25  Keith Seitz  <keiths@redhat.com>
6928
6929         PR c++/24367
6930         * cp-support.c (inspect_type): Don't attempt substitutions
6931         of symbol with the same name.
6932
6933 2019-04-25  Tom Tromey  <tromey@adacore.com>
6934
6935         PR gdb/24475:
6936         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6937         static.
6938
6939 2019-04-25  Tom Tromey  <tromey@adacore.com>
6940
6941         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6942         rvalue reference.
6943         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6944         (gdb_xml_parser::parse): Use std::move.
6945         * python/python-internal.h (gdbpy_convert_exception): Take a const
6946         reference.
6947         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6948         std::move.
6949         * python/py-utils.c (gdbpy_convert_exception): Take a const
6950         reference.
6951         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6952         Use std::move.
6953         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6954         Use std::move.
6955         * mi/mi-main.c (mi_print_exception): Take a const reference.
6956         * main.c (handle_command_errors): Take a const reference.
6957         * linespec.c (parse_linespec): Use std::move.
6958         * infcall.c (run_inferior_call): Use std::move.
6959         (call_function_by_hand_dummy): Use std::move.
6960         * exec.c (try_open_exec_file): Use std::move.
6961         * exceptions.h (exception_print, exception_fprintf)
6962         (exception_print_same): Update.
6963         * exceptions.c (print_exception, exception_print)
6964         (exception_fprintf, exception_print_same): Change parameters to
6965         const reference.
6966         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6967         * common/new-op.c: Use std::move.
6968         * common/common-exceptions.h (struct gdb_exception): Add move
6969         constructor.
6970         (struct gdb_exception_error, struct gdb_exception_quit, struct
6971         gdb_quit_bad_alloc): Change constructor to move constructor.
6972         (throw_exception): Change parameter to rvalue reference.
6973         * common/common-exceptions.c (throw_exception): Take rvalue
6974         reference.
6975         * cli/cli-interp.c (safe_execute_command): Use std::move.
6976         * breakpoint.c (insert_bp_location, location_to_sals): Use
6977         std::move.
6978
6979 2019-04-25  Tom Tromey  <tromey@adacore.com>
6980
6981         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6982         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6983         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6984         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6985         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6986         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6987         guile/scm-value.c: Use unpack.
6988         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6989         gdbscm_gdb_exception.
6990         (gdbscm_throw_gdb_exception): Likewise.
6991         (struct gdbscm_gdb_exception): New.
6992         (unpack): New function.
6993         (gdbscm_wrap): Use unpack.
6994
6995 2019-04-25  Tom Tromey  <tromey@adacore.com>
6996
6997         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6998         (gdb_rl_callback_handler): Use std::move.
6999         * common/common-exceptions.h (struct gdb_exception): Add move
7000         assignment operator.
7001         (throw_exception_sjlj): Change "exception" to const reference.
7002         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7003         (throw_exception_sjlj): Change "exception" to const reference.
7004
7005 2019-04-25  Tom Tromey  <tromey@adacore.com>
7006
7007         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7008         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7009         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7010         Update.
7011         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7012         Update.
7013         * mi/mi-interp.c (mi_interp::exec): Update.
7014         * linespec.c (parse_linespec): Update.
7015         * infcall.c (run_inferior_call): Update.
7016         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7017         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7018         (gdbscm_lookup_global_symbol): Update.
7019         * guile/scm-param.c (gdbscm_parameter_value): Update.
7020         * guile/scm-frame.c (gdbscm_frame_read_register)
7021         (gdbscm_frame_read_var): Update.
7022         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7023         * exec.c (try_open_exec_file): Update.
7024         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7025         (gdb_rl_callback_handler): Update.
7026         * common/common-exceptions.h (exception_none): Don't declare.
7027         * common/common-exceptions.c (exception_none): Don't define.
7028         (struct catcher) <exception>: Update.
7029         * cli/cli-interp.c (safe_execute_command): Update.
7030         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7031
7032 2019-04-25  Ali Tamur  <tamur@google.com>
7033
7034         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7035         (read_attribute_value): Likewise.
7036         (dwarf2_read_addr_index): Update comment.
7037         (read_str_index): Add DW_FORM_strx.
7038         (dwarf2_string_attr): Likewise.
7039         (dwarf2_const_value_attr): Likewise.
7040         (dump_die_shallow): Likewise.
7041         (dwarf2_fetch_constant_bytes): Likewise.
7042         (skip_form_bytes): Likewise.
7043         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7044
7045 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7046
7047         PR corefiles/11608
7048         PR corefiles/18187
7049         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7050         OFFSET.  Verify if current mapping contains an ELF header.
7051         (linux_find_memory_regions_full): Adjust call to
7052         dump_mapping_p.
7053
7054 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7055             Kang Li <kanglictf@gmail.com>
7056
7057         PR gdb/21600
7058
7059         * dwarf2-frame.c (read_initial_length): Be consistent about using
7060         unsigned representation of length.
7061         (decode_frame_entry_1): Likewise.  Check for wraparound of
7062         end pointer as well as buffer overflow.
7063
7064 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7065
7066         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7067         "vq".
7068
7069 2019-04-24  Tom Tromey  <tromey@adacore.com>
7070
7071         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7072
7073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * s12z-tdep.c (s12z_unwind_pc): Delete.
7076         (s12z_unwind_sp): Delete.
7077         (s12z_gdbarch_init): Don't register deleted functions with
7078         gdbarch.
7079
7080 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7081
7082         * rl78-tdep.c (rl78_unwind_sp): Delete.
7083         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7084
7085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7088         (xstormy16_unwind_pc): Delete.
7089         (xstormy16_dummy_id): Delete.
7090         (xstormy16_gdbarch_init): Don't register deleted functions with
7091         gdbarch.
7092
7093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7094
7095         * vax-tdep.c (vax_unwind_pc): Delete.
7096         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7097
7098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7099
7100         * v850-tdep.c (v850_unwind_sp): Delete.
7101         (v850_unwind_pc): Delete.
7102         (v850_dummy_id): Delete.
7103         (v850_gdbarch_init): Don't register deleted functions with
7104         gdbarch.
7105
7106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7107
7108         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7109         (tilegx_unwind_pc): Delete.
7110         (tilegx_unwind_dummy_id): Delete.
7111         (tilegx_gdbarch_init): Don't register deleted functions with
7112         gdbarch.
7113
7114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7115
7116         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7117         (tic6x_dummy_id): Delete.
7118         (tic6x_gdbarch_init): Don't register deleted functions with
7119         gdbarch.
7120
7121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7122
7123         * sparc-tdep.c (sparc_unwind_pc): Delete.
7124         (sparc32_gdbarch_init): Don't register deleted function with
7125         gdbarch.
7126
7127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7128
7129         * sh-tdep.c (sh_unwind_sp): Delete.
7130         (sh_unwind_pc): Delete.
7131         (sh_dummy_id): Delete.
7132         (sh_gdbarch_init): Don't register deleted functions with
7133         gdbarch.
7134
7135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7136
7137         * score-tdep.c (score_unwind_sp): Delete.
7138         (score_unwind_pc): Delete.
7139         (score_dummy_id): Delete.
7140         (score_gdbarch_init): Don't register deleted functions with
7141         gdbarch.
7142
7143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7144
7145         * rx-tdep.c (rx_unwind_pc): Delete.
7146         (rx_unwind_sp): Delete.
7147         (rx_dummy_id): Delete.
7148         (rx_gdbarch_init): Don't register deleted functions with
7149         gdbarch.  Update comment.
7150
7151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7152
7153         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7154         (rs6000_dummy_id): Delete.
7155         (rs6000_gdbarch_init): Don't register deleted functions with
7156         gdbarch.
7157
7158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7159
7160         * or1k-tdep.c (or1k_dummy_id): Delete.
7161         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7162
7163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * nios2-tdep.c (nios2_dummy_id): Delete.
7166         (nios2_unwind_sp): Delete.
7167         (nios2_gdbarch_init): Don't register deleted functions with
7168         gdbarch.
7169
7170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7171
7172         * nds32-tdep.c (nds32_dummy_id): Delete.
7173         (nds32_unwind_pc): Delete.
7174         (nds32_unwind_sp): Delete.
7175         (nds32_gdbarch_init): Don't register deleted functions with
7176         gdbarch.
7177
7178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * msp430-tdep.c (msp430_unwind_pc): Delete.
7181         (msp430_unwind_sp): Delete.
7182         (msp430_dummy_id): Delete.
7183         (msp430_gdbarch_init): Don't register deleted functions with
7184         gdbarch.
7185
7186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7187
7188         * moxie-tdep.c (moxie_unwind_sp): Delete.
7189         (moxie_unwind_pc): Delete.
7190         (moxie_dummy_id): Delete.
7191         (moxie_gdbarch_init): Don't register deleted functions with
7192         gdbarch.
7193
7194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7195
7196         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7197         (mn10300_unwind_pc): Delete.
7198         (mn10300_unwind_sp): Delete.
7199         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7200         mn10300_unwind_sp.
7201         (mn10300_frame_unwind_init): Don't register deleted functions with
7202         gdbarch.
7203
7204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * mep-tdep.c (mep_unwind_pc): Delete.
7207         (mep_unwind_sp): Delete.
7208         (mep_dummy_id): Delete.
7209         (mep_gdbarch_init): Don't register deleted functions with
7210         gdbarch.
7211
7212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7213
7214         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7215         (m68hc11_unwind_sp): Delete.
7216         (m68hc11_gdbarch_init): Don't register deleted functions with
7217         gdbarch.
7218
7219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7220
7221         * m32r-tdep.c (m32r_unwind_sp): Delete.
7222         (m32r_unwind_pc): Delete.
7223         (m32r_dummy_id): Delete.
7224         (m32r_gdbarch_init): Don't register deleted functions with
7225         gdbarch.
7226
7227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7228
7229         * m32c-tdep.c (m32c_unwind_pc): Delete.
7230         (m32c_unwind_sp): Delete.
7231         (m32c_dummy_id): Delete.
7232         (m32c_gdbarch_init): Don't register deleted functions with
7233         gdbarch.
7234
7235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7238         (lm32_unwind_pc): Delete.
7239         (lm32_dummy_id): Delete.
7240         (lm32_gdbarch_init): Don't register deleted functions with
7241         gdbarch.
7242
7243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7246         (iq2000_unwind_pc): Delete.
7247         (iq2000_dummy_id): Delete.
7248         (iq2000_gdbarch_init): Don't register deleted functions with
7249         gdbarch.
7250
7251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * nds32-tdep.c (nds32_type_align): Delete.
7254         (nds32_push_dummy_call): Use type_align instead.
7255
7256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * arm-tdep.c (arm_type_align): Only handle vector override case.
7259         (arm_push_dummy_call): Use type_align.
7260         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7261
7262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7265         case.
7266         (pass_on_stack): Use type_align.
7267         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7268         function.
7269
7270 2019-04-23  Tom Tromey  <tromey@adacore.com>
7271
7272         * dwarf2read.c (line_header::file_name_at): Remove unused
7273         overload.
7274
7275 2019-04-23  Tom de Vries  <tdevries@suse.de>
7276
7277         PR gdb/24438
7278         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7279         invocation.
7280
7281
7282 2019-03-27  Ali Tamur  <tamur@google.com>
7283
7284         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7285         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7286         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7287         (dwarf_expr_context::get_addr_index): Likewise
7288         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7289         (symbol_needs_eval_context::get_addr_index): Likewise
7290         (disassemble_dwarf_expression): Add DW_OP_addrx
7291         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7292         (read_cutu_die_from_dwo): Update comment
7293         (skip_one_die): Add DW_FORM_addrx
7294         (read_attribute_value): Likewise
7295         (var_decode_location): Add DW_OP_addrx
7296         (dwarf2_const_value_attr): Add DW_FORM_addrx
7297         (dump_die_shallow): Likewise
7298         (dwarf2_fetch_constant_bytes): Likewise
7299         (decode_locdesc): Add DW_OP_addrx
7300         (skip_form_bytes): Add DW_FORM_addrx
7301
7302 2019-04-22  Ali Tamur  <tamur@google.com>
7303
7304         * MAINTAINERS (Write After Approval): Add self.
7305
7306 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7307
7308         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7309         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7310         (open_symbol_file_object): Likewise.
7311         (svr4_default_sos): Add info parameter.
7312         (svr4_read_so_list): Likewise.
7313         (svr4_current_sos_direct): Adjust functions calls to pass down
7314         info.
7315         (svr4_current_sos_1): Add info parameter.
7316         (svr4_current_sos): Call get_svr4_info, pass info down to
7317         svr4_current_sos_1.
7318         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7319         get_svr4_info.
7320         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7321         get_svr4_info.
7322         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7323         to get_svr4_info.
7324         (probes_table_remove_objfile_probes): Likewise.
7325         (register_solib_event_probe): Add info parameter.
7326         (solist_update_incremental): Pass info parameter down to
7327         svr4_read_so_list.
7328         (disable_probes_interface): Add info parameter.
7329         (svr4_handle_solib_event): Pass current_program_space to
7330         get_svr4_info.  Adjust disable_probes_interface cleanup.
7331         (svr4_create_probe_breakpoints): Add info parameter, pass it
7332         down to register_solib_event_probe.
7333         (svr4_create_solib_event_breakpoints): Add info parameter,
7334         pass it down to svr4_create_probe_breakpoints.
7335         (enable_break): Pass info down to
7336         svr4_create_solib_event_breakpoints.
7337         (svr4_solib_create_inferior_hook): Pass current_program_space to
7338         get_svr4_info.
7339         (svr4_clear_solib): Likewise.
7340
7341 2019-04-22  Pedro Alves  <palves@redhat.com>
7342
7343         * solib-svr4.c (svr4_free_objfile_observer): New.
7344         (probe_and_action::objfile): New field.
7345         (probes_table_htab_remove_objfile_probes)
7346         (probes_table_remove_objfile_probes): New functions.
7347         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7348         in the new probe_and_action.  Don't store the probe in 'lookup'.
7349         (svr4_create_probe_breakpoints): Pass objfile to
7350         register_solib_event_probe.
7351         (_initialize_svr4_solib): Register a free_objfile observer.
7352
7353 2019-04-19  Tom Tromey  <tom@tromey.com>
7354
7355         * common/queue.h: Remove.
7356
7357 2019-04-19  Tom Tromey  <tom@tromey.com>
7358
7359         * event-loop.c: Don't include "common/queue.h".
7360
7361 2019-04-19  Tom Tromey  <tom@tromey.com>
7362
7363         * remote.c (remote_target): Use delete.
7364         * remote-notif.h: Include <list>, not "common/queue.h".
7365         (notif_client_p): Remove typedef.
7366         (remote_notif_state): Add constructor, destructor, initializer.
7367         <notif_queue>: Now a std::list.
7368         (remote_notif_state_xfree): Don't declare.
7369         * remote-notif.c (remote_notif_process, handle_notification)
7370         (remote_notif_state_allocate): Update.
7371         (~remote_notif_state): Rename from remote_notif_state_xfree.
7372
7373 2019-04-19  Tom Tromey  <tom@tromey.com>
7374
7375         * symfile.c (reread_symbols): Update.
7376         * objfiles.c (objfile_register_static_link)
7377         (objfile_lookup_static_link): Update
7378         (~objfile) Don't delete static_links.
7379         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7380
7381 2019-04-19  Tom Tromey  <tom@tromey.com>
7382
7383         * type-stack.h (struct type_stack) <insert>: Constify string.
7384         * type-stack.c (type_stack::insert): Constify string.
7385         * gdbtypes.h (lookup_template_type): Update.
7386         (address_space_name_to_int): Update.
7387         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7388         const.
7389         (lookup_template_type): Make name const.
7390         * c-exp.y: Update rules.
7391         (lex_one_token, classify_name, classify_inner_name)
7392         (c_print_token): Update.
7393         * p-exp.y: Update rules.
7394         (yylex): Update.
7395         * f-exp.y: Update rules.
7396         (yylex): Update.
7397         * d-exp.y: Update rules.
7398         (lex_one_token, classify_name, classify_inner_name): Update.
7399         * parse.c (write_dollar_variable, copy_name): Return std::string.
7400         * parser-defs.h (copy_name): Change return type.
7401         * m2-exp.y: Update rules.
7402         (yylex): Update.
7403         * go-exp.y (lex_one_token): Update.
7404         Update rules.
7405         (classify_unsafe_function, classify_packaged_name)
7406         (classify_name, yylex): Update.
7407
7408 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7409
7410         * configure.ac: add --enable-source-highlight switch.
7411         * configure: Regenerate.
7412         * top.c (print_gdb_version): plumb --enable-source-highlight
7413         status to "show configuration".
7414
7415 2019-04-19  Tom Tromey  <tromey@adacore.com>
7416
7417         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7418         Check ADA_TYPE_P.
7419         (empty_record, ada_template_to_fixed_record_type_1)
7420         (template_to_static_fixed_type)
7421         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7422         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7423         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7424         macros.
7425
7426 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7427
7428         PR symtab/24423:
7429         * source.c (print_source_lines_base): Advance "iter" when a
7430         control character is seen.
7431
7432 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7433
7434         * inferior.h (struct infcall_suspend_state_deleter):
7435         Catch exception in destructor to avoid crash.
7436
7437 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7438
7439         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7440         close to the add_com "shell".
7441
7442 2019-04-18  Tom Tromey  <tromey@adacore.com>
7443
7444         * process-stratum-target.h (class process_stratum_target)
7445         <stratum>: Add "final".
7446
7447 2019-04-17  Tom Tromey  <tromey@adacore.com>
7448
7449         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7450         against nullptr before use.
7451
7452 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7453
7454         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7455
7456 2019-04-17  Jim Wilson  <jimw@sifive.com>
7457             Andrew Burgess  <andrew.burgess@embecosm.com>
7458
7459         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7460         code read might fail, assume 4-byte breakpoint in that case.
7461
7462 2019-04-15  Leszek Swirski  <leszeks@google.com>
7463
7464         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7465         rather than a hand-rolled POD check when checking for forced MEMORY
7466         classification.
7467
7468 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7469
7470         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7471         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7472         function.
7473         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7474         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7475         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7476         declaration.
7477
7478 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * aarch64-linux-nat.c
7481         (aarch64_linux_nat_target::thread_architecture): Add override.
7482         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7483         each VQ.
7484
7485 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7486
7487         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7488
7489 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7492         target types of size 96-bits, add some additional comments, and
7493         check that the builtin type we found was the correct size.
7494
7495 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7496
7497         * utils.c (prompt_for_continue): Don't restore the styling at the
7498         end, as applied_style has the wrong value.  This fixes styling in
7499         long lists of file names that are interrupted by the "Continue?"
7500         prompt.
7501
7502 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7503
7504         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7505         * c-lang.c (c_language_defn): Likewise.
7506         (cplus_language_defn): Likewise.
7507         (asm_language_defn): Likewise.
7508         (minimal_language_defn): Likewise.
7509         * d-lang.c (d_language_defn): Likewise.
7510         * f-lang.c (f_language_defn): Likewise.
7511         * go-lang.c (go_language_defn): Likewise.
7512         * language.c (unknown_language_defn): Likewise.
7513         (auto_language_defn): Likewise.
7514         * language.h (struct language_defn): Remove la_magic field.
7515         (LANG_MAGIC): Delete.
7516         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7517         * objc-lang.c (objc_language_defn): Likewise.
7518         * opencl-lang.c (opencl_language_defn): Likewise.
7519         * p-lang.c (pascal_language_defn): Likewise.
7520         * rust-lang.c (rust_language_defn): Likewise.
7521
7522 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * riscv-tdep.c (riscv_type_align): New function.
7525         (riscv_type_alignment): Delete.
7526         (riscv_arg_location): Use 'type_align'.
7527         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7528
7529 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7530
7531         * gdbtypes.c (type_align): A struct with no non-static fields also
7532         has alignment of 1.
7533
7534 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7537         component to 0.
7538         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7539         member.
7540         (riscv_struct_info::analyse): New implementation using new
7541         analyse_inner member function.
7542         (riscv_struct_info::field_offset): New member function.
7543         (riscv_struct_info::m_offsets): New member variable.
7544         (riscv_struct_info::analyse_inner): New private member function,
7545         takes the old implementation of riscv_struct_info::analyse but
7546         extended to track field offsets.
7547         (riscv_call_arg_struct): Update the struct folding special cases
7548         to handle cases where empty C++ structs, which are non-zero
7549         length, are found.
7550         (riscv_arg_location): Initialise the length of each location, a
7551         non-zero length now indicates the location is in use.
7552         (riscv_push_dummy_call): Allow for the first location having a
7553         non-zero offset when setting up arguments.
7554         (riscv_return_value): Likewise, but for return values.
7555
7556 2019-04-11  Tom Tromey  <tromey@adacore.com>
7557
7558         * utils.c (internal_vproblem): Make "msg" const.
7559
7560 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7561
7562         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7563         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7564         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7565         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7566
7567 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7568
7569         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7570         function.
7571         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7572         of amd64_collect_native_gregset.
7573         (amd64_linux_nat_target::store_registers): Likewise.
7574
7575 2019-04-10  Tom Tromey  <tom@tromey.com>
7576
7577         * symtab.c (lookup_global_symbol_from_objfile)
7578         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7579         * objfiles.h (class separate_debug_iterator): New.
7580         (class separate_debug_range): New.
7581         (struct objfile) <separate_debug_objfiles>: New method.
7582         (objfile_separate_debug_iterate): Don't declare.
7583         * objfiles.c (separate_debug_iterator::operator++): Rename from
7584         objfile_separate_debug_iterate.
7585         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7586         iterator.
7587         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7588         iterator.
7589
7590 2019-04-10  Tom Tromey  <tom@tromey.com>
7591
7592         * symfile.c (reread_symbols): Remove old comment.
7593         * objfiles.c (free_all_objfiles): Fix a typo.
7594
7595 2019-04-10  Tom Tromey  <tom@tromey.com>
7596
7597         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7598         * minsyms.c (lookup_minimal_symbol): Use foreach.
7599         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7600         (lookup_minimal_symbol_solib_trampoline): Likewise.
7601         * symfile.c (reread_symbols): Use foreach.
7602
7603 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7604             Tom Tromey  <tromey@adacore.com>
7605
7606         PR rust/24414:
7607         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7608         (rust_lex_int_test): Change "value" to be LONGEST.
7609         (rust_lex_tests): Add test for long integer literal.
7610
7611 2019-04-09  Tom Tromey  <tromey@adacore.com>
7612
7613         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7614         to bool.
7615         (extended_remote_target::attach): Update.
7616         (remote_target::remote_notice_new_inferior): Update.
7617         (remote_target::add_current_inferior_and_thread): Update.
7618         * inferior.c (exit_inferior_1): Use "false".
7619         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7620
7621 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7622
7623         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7624         the "start" command.
7625
7626 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7627
7628         * python/py-inferior.c (infpy_thread_from_thread_handle):
7629         Adjust comments to reflect renaming of thread_from_thread_handle
7630         to thread_from_handle.  Adjust keywords.  Fix type error message.
7631         (inferior_object_methods): Add thread_from_handle.  Retain
7632         thread_from_thread_handle, but mark it as deprecated.
7633
7634 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7635
7636         * gdbthread.h (find_thread_by_handle): Revise declaration.
7637         * thread.c (find_thread_by_handle): Likewise.  Adjust
7638         implementation too.
7639         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7640         support for buffer objects as handles.
7641
7642 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7643
7644         * python/py-infthread.c (thpy_thread_handle): New function.
7645         (thread_object_methods): Register thpy_thread_handle.
7646
7647 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7648
7649         * gdbthread.h (thread_to_thread_handle): Declare.
7650         * thread.c (gdbtypes.h): Include.
7651         (thread_to_thread_handle): New function.
7652
7653         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7654         (target_thread_info_to_thread_handle): Declare.
7655         * target.c (target_thread_info_to_thread_handle): New function.
7656         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7657         * target-delegates.c: Regenerate.
7658
7659         * linux-thread-db.c (class thread_db_target): Add method
7660         thread_info_to_thread_handle.
7661         (thread_db_target::thread_info_to_thread_handle): Define.
7662         * remote.c (class remote_target): Add new method
7663         thread_info_to_thread_handle.
7664         (remote_target::thread_info_to_thread_handle): Define.
7665
7666 2019-04-08  Pedro Alves  <palves@redhat.com>
7667
7668         * common/common-exceptions.c (throw_exception): Don't create
7669         named object to throw; throw directly.
7670         (throw_it): Likewise.  Don't initialize gdb_exception::message
7671         here, with new; pass FMT and AP to the ctor instead.
7672         * common/common-exceptions.h: Include <string>.
7673         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7674         const char *, va_list)): New ctor.  Use std::make_shared.
7675         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7676         errors)): Delete.
7677         (gdb_exception_error::gdb_exception_error(enum errors, const char
7678         *, va_list)): New.
7679         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7680         Add assertion.
7681         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7682         errors)): Delete.
7683         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7684         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7685         Add assertion.
7686
7687 2019-04-08  Tom Tromey  <tom@tromey.com>
7688
7689         * valops.c (value_rtti_indirect_type): Replace throw_exception
7690         with throw.
7691         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7692         with throw.
7693         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7694         throw.
7695         * target.c (target_translate_tls_address): Replace throw_exception
7696         with throw.
7697         * stack.c (frame_apply_command_count): Replace throw_exception
7698         with throw.
7699         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7700         throw.
7701         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7702         with throw.
7703         * rs6000-tdep.c (rs6000_frame_cache)
7704         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7705         * remote.c: Replace throw_exception with throw.
7706         * record-full.c (record_full_message, record_full_wait_1)
7707         (record_full_restore): Replace throw_exception with throw.
7708         * record-btrace.c:
7709         (get_thread_current_frame_id, record_btrace_start_replaying)
7710         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7711         (cmd_record_btrace_start): Replace throw_exception with throw.
7712         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7713         throw.
7714         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7715         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7716         * linespec.c:
7717         (find_linespec_symbols): Replace throw_exception with throw.
7718         * infrun.c (displaced_step_prepare, resume): Replace
7719         throw_exception with throw.
7720         * infcmd.c (post_create_inferior): Replace throw_exception with
7721         throw.
7722         * inf-loop.c (inferior_event_handler): Replace throw_exception
7723         with throw.
7724         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7725         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7726         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7727         (get_prev_frame_always, get_frame_pc_if_available)
7728         (get_frame_address_in_block_if_available, get_frame_language):
7729         Replace throw_exception with throw.
7730         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7731         throw_exception with throw.
7732         * eval.c (fetch_subexp_value, evaluate_var_value)
7733         (evaluate_funcall, evaluate_subexp_standard): Replace
7734         throw_exception with throw.
7735         * dwarf2loc.c (call_site_find_chain)
7736         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7737         Replace throw_exception with throw.
7738         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7739         with throw.
7740         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7741         throw.
7742         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7743         * completer.c (complete_line_internal): Replace throw_exception
7744         with throw.
7745         * compile/compile-object-run.c (compile_object_run): Replace
7746         throw_exception with throw.
7747         * cli/cli-script.c (process_next_line): Replace throw_exception
7748         with throw.
7749         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7750         (btrace_enable, btrace_maint_update_pt_packets): Replace
7751         throw_exception with throw.
7752         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7753         throw_exception with throw.
7754         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7755         throw_exception with throw.
7756         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7757         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7758         * aarch64-tdep.c (aarch64_make_prologue_cache)
7759         (aarch64_make_stub_cache): Replace throw_exception with throw.
7760
7761 2019-04-08  Tom Tromey  <tom@tromey.com>
7762
7763         * common/common-exceptions.c (throw_exception): Rename from
7764         throw_exception_cxx.  Remove old copy.  Make argument const.
7765         (throw_it): Create and throw exception objects directly.
7766         * common/common-exceptions.h (throw_exception): Make argument
7767         const.
7768         (struct gdb_exception_error): Add constructor.
7769         (struct gdb_exception_quit): Add constructor.
7770
7771 2019-04-08  Tom Tromey  <tom@tromey.com>
7772
7773         * common/common-exceptions.h (exception_rethrow): Don't declare.
7774         (TRY_SJLJ): Update comment.
7775         (TRY, CATCH, END_CATCH): Remove.
7776         * common/common-exceptions.c (exception_rethrow): Remove.
7777
7778 2019-04-08  Tom Tromey  <tom@tromey.com>
7779
7780         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7781         Remove.
7782         (gdb_exception_error): Rename from
7783         gdb_exception_RETURN_MASK_ERROR.
7784         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7785         (gdb_quit_bad_alloc): Update.
7786         * aarch64-tdep.c: Update.
7787         * ada-lang.c: Update.
7788         * ada-typeprint.c: Update.
7789         * ada-valprint.c: Update.
7790         * amd64-tdep.c: Update.
7791         * arch-utils.c: Update.
7792         * break-catch-throw.c: Update.
7793         * breakpoint.c: Update.
7794         * btrace.c: Update.
7795         * c-varobj.c: Update.
7796         * cli/cli-cmds.c: Update.
7797         * cli/cli-interp.c: Update.
7798         * cli/cli-script.c: Update.
7799         * common/common-exceptions.c: Update.
7800         * common/new-op.c: Update.
7801         * common/selftest.c: Update.
7802         * compile/compile-c-symbols.c: Update.
7803         * compile/compile-cplus-symbols.c: Update.
7804         * compile/compile-object-load.c: Update.
7805         * compile/compile-object-run.c: Update.
7806         * completer.c: Update.
7807         * corelow.c: Update.
7808         * cp-abi.c: Update.
7809         * cp-support.c: Update.
7810         * cp-valprint.c: Update.
7811         * darwin-nat.c: Update.
7812         * disasm-selftests.c: Update.
7813         * dtrace-probe.c: Update.
7814         * dwarf-index-cache.c: Update.
7815         * dwarf-index-write.c: Update.
7816         * dwarf2-frame-tailcall.c: Update.
7817         * dwarf2-frame.c: Update.
7818         * dwarf2loc.c: Update.
7819         * dwarf2read.c: Update.
7820         * eval.c: Update.
7821         * event-loop.c: Update.
7822         * event-top.c: Update.
7823         * exec.c: Update.
7824         * f-valprint.c: Update.
7825         * fbsd-tdep.c: Update.
7826         * frame-unwind.c: Update.
7827         * frame.c: Update.
7828         * gdbtypes.c: Update.
7829         * gnu-v3-abi.c: Update.
7830         * guile/guile-internal.h: Update.
7831         * guile/scm-block.c: Update.
7832         * guile/scm-breakpoint.c: Update.
7833         * guile/scm-cmd.c: Update.
7834         * guile/scm-disasm.c: Update.
7835         * guile/scm-frame.c: Update.
7836         * guile/scm-lazy-string.c: Update.
7837         * guile/scm-math.c: Update.
7838         * guile/scm-param.c: Update.
7839         * guile/scm-ports.c: Update.
7840         * guile/scm-pretty-print.c: Update.
7841         * guile/scm-symbol.c: Update.
7842         * guile/scm-symtab.c: Update.
7843         * guile/scm-type.c: Update.
7844         * guile/scm-value.c: Update.
7845         * i386-linux-tdep.c: Update.
7846         * i386-tdep.c: Update.
7847         * inf-loop.c: Update.
7848         * infcall.c: Update.
7849         * infcmd.c: Update.
7850         * infrun.c: Update.
7851         * jit.c: Update.
7852         * language.c: Update.
7853         * linespec.c: Update.
7854         * linux-fork.c: Update.
7855         * linux-nat.c: Update.
7856         * linux-tdep.c: Update.
7857         * linux-thread-db.c: Update.
7858         * main.c: Update.
7859         * mi/mi-cmd-break.c: Update.
7860         * mi/mi-cmd-stack.c: Update.
7861         * mi/mi-interp.c: Update.
7862         * mi/mi-main.c: Update.
7863         * objc-lang.c: Update.
7864         * p-valprint.c: Update.
7865         * parse.c: Update.
7866         * ppc-linux-tdep.c: Update.
7867         * printcmd.c: Update.
7868         * python/py-arch.c: Update.
7869         * python/py-breakpoint.c: Update.
7870         * python/py-cmd.c: Update.
7871         * python/py-finishbreakpoint.c: Update.
7872         * python/py-frame.c: Update.
7873         * python/py-framefilter.c: Update.
7874         * python/py-gdb-readline.c: Update.
7875         * python/py-inferior.c: Update.
7876         * python/py-infthread.c: Update.
7877         * python/py-lazy-string.c: Update.
7878         * python/py-linetable.c: Update.
7879         * python/py-objfile.c: Update.
7880         * python/py-param.c: Update.
7881         * python/py-prettyprint.c: Update.
7882         * python/py-progspace.c: Update.
7883         * python/py-record-btrace.c: Update.
7884         * python/py-record.c: Update.
7885         * python/py-symbol.c: Update.
7886         * python/py-type.c: Update.
7887         * python/py-unwind.c: Update.
7888         * python/py-utils.c: Update.
7889         * python/py-value.c: Update.
7890         * python/python.c: Update.
7891         * record-btrace.c: Update.
7892         * record-full.c: Update.
7893         * remote-fileio.c: Update.
7894         * remote.c: Update.
7895         * riscv-tdep.c: Update.
7896         * rs6000-aix-tdep.c: Update.
7897         * rs6000-tdep.c: Update.
7898         * rust-exp.y: Update.
7899         * rust-lang.c: Update.
7900         * s390-tdep.c: Update.
7901         * selftest-arch.c: Update.
7902         * solib-dsbt.c: Update.
7903         * solib-frv.c: Update.
7904         * solib-spu.c: Update.
7905         * solib-svr4.c: Update.
7906         * solib.c: Update.
7907         * sparc64-linux-tdep.c: Update.
7908         * stack.c: Update.
7909         * symfile-mem.c: Update.
7910         * symmisc.c: Update.
7911         * target.c: Update.
7912         * thread.c: Update.
7913         * top.c: Update.
7914         * tracefile-tfile.c: Update.
7915         * tui/tui.c: Update.
7916         * typeprint.c: Update.
7917         * unittests/cli-utils-selftests.c: Update.
7918         * unittests/parse-connection-spec-selftests.c: Update.
7919         * valops.c: Update.
7920         * valprint.c: Update.
7921         * value.c: Update.
7922         * varobj.c: Update.
7923         * windows-nat.c: Update.
7924         * x86-linux-nat.c: Update.
7925         * xml-support.c: Update.
7926
7927 2019-04-08  Tom Tromey  <tom@tromey.com>
7928
7929         * xml-support.c: Use C++ exception handling.
7930         * x86-linux-nat.c: Use C++ exception handling.
7931         * windows-nat.c: Use C++ exception handling.
7932         * varobj.c: Use C++ exception handling.
7933         * value.c: Use C++ exception handling.
7934         * valprint.c: Use C++ exception handling.
7935         * valops.c: Use C++ exception handling.
7936         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7937         handling.
7938         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7939         * typeprint.c: Use C++ exception handling.
7940         * tui/tui.c: Use C++ exception handling.
7941         * tracefile-tfile.c: Use C++ exception handling.
7942         * top.c: Use C++ exception handling.
7943         * thread.c: Use C++ exception handling.
7944         * target.c: Use C++ exception handling.
7945         * symmisc.c: Use C++ exception handling.
7946         * symfile-mem.c: Use C++ exception handling.
7947         * stack.c: Use C++ exception handling.
7948         * sparc64-linux-tdep.c: Use C++ exception handling.
7949         * solib.c: Use C++ exception handling.
7950         * solib-svr4.c: Use C++ exception handling.
7951         * solib-spu.c: Use C++ exception handling.
7952         * solib-frv.c: Use C++ exception handling.
7953         * solib-dsbt.c: Use C++ exception handling.
7954         * selftest-arch.c: Use C++ exception handling.
7955         * s390-tdep.c: Use C++ exception handling.
7956         * rust-lang.c: Use C++ exception handling.
7957         * rust-exp.y: Use C++ exception handling.
7958         * rs6000-tdep.c: Use C++ exception handling.
7959         * rs6000-aix-tdep.c: Use C++ exception handling.
7960         * riscv-tdep.c: Use C++ exception handling.
7961         * remote.c: Use C++ exception handling.
7962         * remote-fileio.c: Use C++ exception handling.
7963         * record-full.c: Use C++ exception handling.
7964         * record-btrace.c: Use C++ exception handling.
7965         * python/python.c: Use C++ exception handling.
7966         * python/py-value.c: Use C++ exception handling.
7967         * python/py-utils.c: Use C++ exception handling.
7968         * python/py-unwind.c: Use C++ exception handling.
7969         * python/py-type.c: Use C++ exception handling.
7970         * python/py-symbol.c: Use C++ exception handling.
7971         * python/py-record.c: Use C++ exception handling.
7972         * python/py-record-btrace.c: Use C++ exception handling.
7973         * python/py-progspace.c: Use C++ exception handling.
7974         * python/py-prettyprint.c: Use C++ exception handling.
7975         * python/py-param.c: Use C++ exception handling.
7976         * python/py-objfile.c: Use C++ exception handling.
7977         * python/py-linetable.c: Use C++ exception handling.
7978         * python/py-lazy-string.c: Use C++ exception handling.
7979         * python/py-infthread.c: Use C++ exception handling.
7980         * python/py-inferior.c: Use C++ exception handling.
7981         * python/py-gdb-readline.c: Use C++ exception handling.
7982         * python/py-framefilter.c: Use C++ exception handling.
7983         * python/py-frame.c: Use C++ exception handling.
7984         * python/py-finishbreakpoint.c: Use C++ exception handling.
7985         * python/py-cmd.c: Use C++ exception handling.
7986         * python/py-breakpoint.c: Use C++ exception handling.
7987         * python/py-arch.c: Use C++ exception handling.
7988         * printcmd.c: Use C++ exception handling.
7989         * ppc-linux-tdep.c: Use C++ exception handling.
7990         * parse.c: Use C++ exception handling.
7991         * p-valprint.c: Use C++ exception handling.
7992         * objc-lang.c: Use C++ exception handling.
7993         * mi/mi-main.c: Use C++ exception handling.
7994         * mi/mi-interp.c: Use C++ exception handling.
7995         * mi/mi-cmd-stack.c: Use C++ exception handling.
7996         * mi/mi-cmd-break.c: Use C++ exception handling.
7997         * main.c: Use C++ exception handling.
7998         * linux-thread-db.c: Use C++ exception handling.
7999         * linux-tdep.c: Use C++ exception handling.
8000         * linux-nat.c: Use C++ exception handling.
8001         * linux-fork.c: Use C++ exception handling.
8002         * linespec.c: Use C++ exception handling.
8003         * language.c: Use C++ exception handling.
8004         * jit.c: Use C++ exception handling.
8005         * infrun.c: Use C++ exception handling.
8006         * infcmd.c: Use C++ exception handling.
8007         * infcall.c: Use C++ exception handling.
8008         * inf-loop.c: Use C++ exception handling.
8009         * i386-tdep.c: Use C++ exception handling.
8010         * i386-linux-tdep.c: Use C++ exception handling.
8011         * guile/scm-value.c: Use C++ exception handling.
8012         * guile/scm-type.c: Use C++ exception handling.
8013         * guile/scm-symtab.c: Use C++ exception handling.
8014         * guile/scm-symbol.c: Use C++ exception handling.
8015         * guile/scm-pretty-print.c: Use C++ exception handling.
8016         * guile/scm-ports.c: Use C++ exception handling.
8017         * guile/scm-param.c: Use C++ exception handling.
8018         * guile/scm-math.c: Use C++ exception handling.
8019         * guile/scm-lazy-string.c: Use C++ exception handling.
8020         * guile/scm-frame.c: Use C++ exception handling.
8021         * guile/scm-disasm.c: Use C++ exception handling.
8022         * guile/scm-cmd.c: Use C++ exception handling.
8023         * guile/scm-breakpoint.c: Use C++ exception handling.
8024         * guile/scm-block.c: Use C++ exception handling.
8025         * guile/guile-internal.h: Use C++ exception handling.
8026         * gnu-v3-abi.c: Use C++ exception handling.
8027         * gdbtypes.c: Use C++ exception handling.
8028         * frame.c: Use C++ exception handling.
8029         * frame-unwind.c: Use C++ exception handling.
8030         * fbsd-tdep.c: Use C++ exception handling.
8031         * f-valprint.c: Use C++ exception handling.
8032         * exec.c: Use C++ exception handling.
8033         * event-top.c: Use C++ exception handling.
8034         * event-loop.c: Use C++ exception handling.
8035         * eval.c: Use C++ exception handling.
8036         * dwarf2read.c: Use C++ exception handling.
8037         * dwarf2loc.c: Use C++ exception handling.
8038         * dwarf2-frame.c: Use C++ exception handling.
8039         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8040         * dwarf-index-write.c: Use C++ exception handling.
8041         * dwarf-index-cache.c: Use C++ exception handling.
8042         * dtrace-probe.c: Use C++ exception handling.
8043         * disasm-selftests.c: Use C++ exception handling.
8044         * darwin-nat.c: Use C++ exception handling.
8045         * cp-valprint.c: Use C++ exception handling.
8046         * cp-support.c: Use C++ exception handling.
8047         * cp-abi.c: Use C++ exception handling.
8048         * corelow.c: Use C++ exception handling.
8049         * completer.c: Use C++ exception handling.
8050         * compile/compile-object-run.c: Use C++ exception handling.
8051         * compile/compile-object-load.c: Use C++ exception handling.
8052         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8053         * compile/compile-c-symbols.c: Use C++ exception handling.
8054         * common/selftest.c: Use C++ exception handling.
8055         * common/new-op.c: Use C++ exception handling.
8056         * cli/cli-script.c: Use C++ exception handling.
8057         * cli/cli-interp.c: Use C++ exception handling.
8058         * cli/cli-cmds.c: Use C++ exception handling.
8059         * c-varobj.c: Use C++ exception handling.
8060         * btrace.c: Use C++ exception handling.
8061         * breakpoint.c: Use C++ exception handling.
8062         * break-catch-throw.c: Use C++ exception handling.
8063         * arch-utils.c: Use C++ exception handling.
8064         * amd64-tdep.c: Use C++ exception handling.
8065         * ada-valprint.c: Use C++ exception handling.
8066         * ada-typeprint.c: Use C++ exception handling.
8067         * ada-lang.c: Use C++ exception handling.
8068         * aarch64-tdep.c: Use C++ exception handling.
8069
8070 2019-04-08  Tom Tromey  <tom@tromey.com>
8071
8072         * xml-support.c (gdb_xml_parser::parse): Update.
8073         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8074         * value.c (show_convenience): Update.
8075         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8076         (test_parse_flags_qcs): Update.
8077         * thread.c (thr_try_catch_cmd): Update.
8078         * target.c (target_translate_tls_address): Update.
8079         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8080         (info_frame_command_core, frame_apply_command_count): Update.
8081         * rust-exp.y (rust_lex_exception_test): Update.
8082         * riscv-tdep.c (riscv_print_one_register_info): Update.
8083         * remote.c (remote_target::enable_btrace): Update.
8084         * record-btrace.c (record_btrace_enable_warn): Update.
8085         * python/py-utils.c (gdbpy_convert_exception): Update.
8086         * printcmd.c (do_one_display, print_variable_and_value): Update.
8087         * mi/mi-main.c (mi_print_exception): Update.
8088         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8089         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8090         * linux-nat.c (linux_nat_target::attach): Update.
8091         * linux-fork.c (class scoped_switch_fork_info): Update.
8092         * infrun.c (displaced_step_prepare): Update.
8093         * infcall.c (call_function_by_hand_dummy): Update.
8094         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8095         * gnu-v3-abi.c (print_one_vtable): Update.
8096         * frame.c (get_prev_frame_always): Update.
8097         * f-valprint.c (info_common_command_for_block): Update.
8098         * exec.c (try_open_exec_file): Update.
8099         * exceptions.c (print_exception, exception_print)
8100         (exception_fprintf, exception_print_same): Update.
8101         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8102         * dwarf-index-cache.c (index_cache::store)
8103         (index_cache::lookup_gdb_index): Update.
8104         * darwin-nat.c (maybe_cache_shell): Update.
8105         * cp-valprint.c (cp_print_value_fields): Update.
8106         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8107         (gcc_cplus_symbol_address): Update.
8108         * compile/compile-c-symbols.c (gcc_convert_symbol)
8109         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8110         * common/selftest.c: Update.
8111         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8112         a std::string.
8113         (exception_try_scope_entry, exception_try_scope_exit): Don't
8114         declare.
8115         (struct exception_try_scope): Remove.
8116         (TRY): Don't use exception_try_scope.
8117         (struct gdb_exception): Add constructor, operator=.
8118         <what>: New method.
8119         (struct gdb_exception_RETURN_MASK_ALL)
8120         (struct gdb_exception_RETURN_MASK_ERROR)
8121         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8122         (struct gdb_quit_bad_alloc): Update.
8123         * common/common-exceptions.c (exception_none): Change
8124         initializer.
8125         (struct catcher) <state, exception>: Initialize inline.
8126         <prev>: Remove member.
8127         (current_catcher): Remove.
8128         (catchers): New global.
8129         (exceptions_state_mc_init): Simplify.
8130         (catcher_pop): Remove.
8131         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8132         (try_scope_depth, exception_try_scope_entry)
8133         (exception_try_scope_exit): Remove.
8134         (throw_exception_sjlj): Update.
8135         (exception_messages, exception_messages_size): Remove.
8136         (throw_it): Simplify.
8137         (gdb_exception_sliced_copy): Remove.
8138         (throw_exception_cxx): Update.
8139         * cli/cli-script.c (script_from_file): Update.
8140         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8141         Update.
8142         * ada-valprint.c (ada_val_print): Update.
8143         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8144         (create_excep_cond_exprs): Update.
8145
8146 2019-04-08  Tom Tromey  <tom@tromey.com>
8147
8148         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8149         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8150         (TRY, CATCH, END_CATCH): Remove some definitions.
8151         * common/common-exceptions.c: Don't use GDB_XCPT.
8152         (catcher_list_size): Remove.
8153         (throw_exception, throw_it): Simplify.
8154
8155 2019-04-05  Tom Tromey  <tom@tromey.com>
8156
8157         Revert the header-sorting patch.
8158         * ft32-tdep.c: Revert.
8159         * frv-tdep.c: Revert.
8160         * frv-linux-tdep.c: Revert.
8161         * frame.c: Revert.
8162         * frame-unwind.c: Revert.
8163         * frame-base.c: Revert.
8164         * fork-child.c: Revert.
8165         * findvar.c: Revert.
8166         * findcmd.c: Revert.
8167         * filesystem.c: Revert.
8168         * filename-seen-cache.h: Revert.
8169         * filename-seen-cache.c: Revert.
8170         * fbsd-tdep.c: Revert.
8171         * fbsd-nat.h: Revert.
8172         * fbsd-nat.c: Revert.
8173         * f-valprint.c: Revert.
8174         * f-typeprint.c: Revert.
8175         * f-lang.c: Revert.
8176         * extension.h: Revert.
8177         * extension.c: Revert.
8178         * extension-priv.h: Revert.
8179         * expprint.c: Revert.
8180         * exec.h: Revert.
8181         * exec.c: Revert.
8182         * exceptions.c: Revert.
8183         * event-top.c: Revert.
8184         * event-loop.c: Revert.
8185         * eval.c: Revert.
8186         * elfread.c: Revert.
8187         * dwarf2read.h: Revert.
8188         * dwarf2read.c: Revert.
8189         * dwarf2loc.c: Revert.
8190         * dwarf2expr.h: Revert.
8191         * dwarf2expr.c: Revert.
8192         * dwarf2-frame.c: Revert.
8193         * dwarf2-frame-tailcall.c: Revert.
8194         * dwarf-index-write.h: Revert.
8195         * dwarf-index-write.c: Revert.
8196         * dwarf-index-common.c: Revert.
8197         * dwarf-index-cache.h: Revert.
8198         * dwarf-index-cache.c: Revert.
8199         * dummy-frame.c: Revert.
8200         * dtrace-probe.c: Revert.
8201         * disasm.h: Revert.
8202         * disasm.c: Revert.
8203         * disasm-selftests.c: Revert.
8204         * dictionary.c: Revert.
8205         * dicos-tdep.c: Revert.
8206         * demangle.c: Revert.
8207         * dcache.h: Revert.
8208         * dcache.c: Revert.
8209         * darwin-nat.h: Revert.
8210         * darwin-nat.c: Revert.
8211         * darwin-nat-info.c: Revert.
8212         * d-valprint.c: Revert.
8213         * d-namespace.c: Revert.
8214         * d-lang.c: Revert.
8215         * ctf.c: Revert.
8216         * csky-tdep.c: Revert.
8217         * csky-linux-tdep.c: Revert.
8218         * cris-tdep.c: Revert.
8219         * cris-linux-tdep.c: Revert.
8220         * cp-valprint.c: Revert.
8221         * cp-support.c: Revert.
8222         * cp-namespace.c: Revert.
8223         * cp-abi.c: Revert.
8224         * corelow.c: Revert.
8225         * corefile.c: Revert.
8226         * continuations.c: Revert.
8227         * completer.h: Revert.
8228         * completer.c: Revert.
8229         * complaints.c: Revert.
8230         * coffread.c: Revert.
8231         * coff-pe-read.c: Revert.
8232         * cli-out.h: Revert.
8233         * cli-out.c: Revert.
8234         * charset.c: Revert.
8235         * c-varobj.c: Revert.
8236         * c-valprint.c: Revert.
8237         * c-typeprint.c: Revert.
8238         * c-lang.c: Revert.
8239         * buildsym.c: Revert.
8240         * buildsym-legacy.c: Revert.
8241         * build-id.h: Revert.
8242         * build-id.c: Revert.
8243         * btrace.c: Revert.
8244         * bsd-uthread.c: Revert.
8245         * breakpoint.h: Revert.
8246         * breakpoint.c: Revert.
8247         * break-catch-throw.c: Revert.
8248         * break-catch-syscall.c: Revert.
8249         * break-catch-sig.c: Revert.
8250         * blockframe.c: Revert.
8251         * block.c: Revert.
8252         * bfin-tdep.c: Revert.
8253         * bfin-linux-tdep.c: Revert.
8254         * bfd-target.c: Revert.
8255         * bcache.c: Revert.
8256         * ax-general.c: Revert.
8257         * ax-gdb.h: Revert.
8258         * ax-gdb.c: Revert.
8259         * avr-tdep.c: Revert.
8260         * auxv.c: Revert.
8261         * auto-load.c: Revert.
8262         * arm-wince-tdep.c: Revert.
8263         * arm-tdep.c: Revert.
8264         * arm-symbian-tdep.c: Revert.
8265         * arm-pikeos-tdep.c: Revert.
8266         * arm-obsd-tdep.c: Revert.
8267         * arm-nbsd-tdep.c: Revert.
8268         * arm-nbsd-nat.c: Revert.
8269         * arm-linux-tdep.c: Revert.
8270         * arm-linux-nat.c: Revert.
8271         * arm-fbsd-tdep.c: Revert.
8272         * arm-fbsd-nat.c: Revert.
8273         * arm-bsd-tdep.c: Revert.
8274         * arch-utils.c: Revert.
8275         * arc-tdep.c: Revert.
8276         * arc-newlib-tdep.c: Revert.
8277         * annotate.h: Revert.
8278         * annotate.c: Revert.
8279         * amd64-windows-tdep.c: Revert.
8280         * amd64-windows-nat.c: Revert.
8281         * amd64-tdep.c: Revert.
8282         * amd64-sol2-tdep.c: Revert.
8283         * amd64-obsd-tdep.c: Revert.
8284         * amd64-obsd-nat.c: Revert.
8285         * amd64-nbsd-tdep.c: Revert.
8286         * amd64-nbsd-nat.c: Revert.
8287         * amd64-nat.c: Revert.
8288         * amd64-linux-tdep.c: Revert.
8289         * amd64-linux-nat.c: Revert.
8290         * amd64-fbsd-tdep.c: Revert.
8291         * amd64-fbsd-nat.c: Revert.
8292         * amd64-dicos-tdep.c: Revert.
8293         * amd64-darwin-tdep.c: Revert.
8294         * amd64-bsd-nat.c: Revert.
8295         * alpha-tdep.c: Revert.
8296         * alpha-obsd-tdep.c: Revert.
8297         * alpha-nbsd-tdep.c: Revert.
8298         * alpha-mdebug-tdep.c: Revert.
8299         * alpha-linux-tdep.c: Revert.
8300         * alpha-linux-nat.c: Revert.
8301         * alpha-bsd-tdep.c: Revert.
8302         * alpha-bsd-nat.c: Revert.
8303         * aix-thread.c: Revert.
8304         * agent.c: Revert.
8305         * addrmap.c: Revert.
8306         * ada-varobj.c: Revert.
8307         * ada-valprint.c: Revert.
8308         * ada-typeprint.c: Revert.
8309         * ada-tasks.c: Revert.
8310         * ada-lang.c: Revert.
8311         * aarch64-tdep.c: Revert.
8312         * aarch64-ravenscar-thread.c: Revert.
8313         * aarch64-newlib-tdep.c: Revert.
8314         * aarch64-linux-tdep.c: Revert.
8315         * aarch64-linux-nat.c: Revert.
8316         * aarch64-fbsd-tdep.c: Revert.
8317         * aarch64-fbsd-nat.c: Revert.
8318         * aarch32-linux-nat.c: Revert.
8319
8320 2019-04-05  Tom Tromey  <tom@tromey.com>
8321
8322         * ft32-tdep.c: Sort headers.
8323         * frv-tdep.c: Sort headers.
8324         * frv-linux-tdep.c: Sort headers.
8325         * frame.c: Sort headers.
8326         * frame-unwind.c: Sort headers.
8327         * frame-base.c: Sort headers.
8328         * fork-child.c: Sort headers.
8329         * findvar.c: Sort headers.
8330         * findcmd.c: Sort headers.
8331         * filesystem.c: Sort headers.
8332         * filename-seen-cache.h: Sort headers.
8333         * filename-seen-cache.c: Sort headers.
8334         * fbsd-tdep.c: Sort headers.
8335         * fbsd-nat.h: Sort headers.
8336         * fbsd-nat.c: Sort headers.
8337         * f-valprint.c: Sort headers.
8338         * f-typeprint.c: Sort headers.
8339         * f-lang.c: Sort headers.
8340         * extension.h: Sort headers.
8341         * extension.c: Sort headers.
8342         * extension-priv.h: Sort headers.
8343         * expprint.c: Sort headers.
8344         * exec.h: Sort headers.
8345         * exec.c: Sort headers.
8346         * exceptions.c: Sort headers.
8347         * event-top.c: Sort headers.
8348         * event-loop.c: Sort headers.
8349         * eval.c: Sort headers.
8350         * elfread.c: Sort headers.
8351         * dwarf2read.h: Sort headers.
8352         * dwarf2read.c: Sort headers.
8353         * dwarf2loc.c: Sort headers.
8354         * dwarf2expr.h: Sort headers.
8355         * dwarf2expr.c: Sort headers.
8356         * dwarf2-frame.c: Sort headers.
8357         * dwarf2-frame-tailcall.c: Sort headers.
8358         * dwarf-index-write.h: Sort headers.
8359         * dwarf-index-write.c: Sort headers.
8360         * dwarf-index-common.c: Sort headers.
8361         * dwarf-index-cache.h: Sort headers.
8362         * dwarf-index-cache.c: Sort headers.
8363         * dummy-frame.c: Sort headers.
8364         * dtrace-probe.c: Sort headers.
8365         * disasm.h: Sort headers.
8366         * disasm.c: Sort headers.
8367         * disasm-selftests.c: Sort headers.
8368         * dictionary.c: Sort headers.
8369         * dicos-tdep.c: Sort headers.
8370         * demangle.c: Sort headers.
8371         * dcache.h: Sort headers.
8372         * dcache.c: Sort headers.
8373         * darwin-nat.h: Sort headers.
8374         * darwin-nat.c: Sort headers.
8375         * darwin-nat-info.c: Sort headers.
8376         * d-valprint.c: Sort headers.
8377         * d-namespace.c: Sort headers.
8378         * d-lang.c: Sort headers.
8379         * ctf.c: Sort headers.
8380         * csky-tdep.c: Sort headers.
8381         * csky-linux-tdep.c: Sort headers.
8382         * cris-tdep.c: Sort headers.
8383         * cris-linux-tdep.c: Sort headers.
8384         * cp-valprint.c: Sort headers.
8385         * cp-support.c: Sort headers.
8386         * cp-namespace.c: Sort headers.
8387         * cp-abi.c: Sort headers.
8388         * corelow.c: Sort headers.
8389         * corefile.c: Sort headers.
8390         * continuations.c: Sort headers.
8391         * completer.h: Sort headers.
8392         * completer.c: Sort headers.
8393         * complaints.c: Sort headers.
8394         * coffread.c: Sort headers.
8395         * coff-pe-read.c: Sort headers.
8396         * cli-out.h: Sort headers.
8397         * cli-out.c: Sort headers.
8398         * charset.c: Sort headers.
8399         * c-varobj.c: Sort headers.
8400         * c-valprint.c: Sort headers.
8401         * c-typeprint.c: Sort headers.
8402         * c-lang.c: Sort headers.
8403         * buildsym.c: Sort headers.
8404         * buildsym-legacy.c: Sort headers.
8405         * build-id.h: Sort headers.
8406         * build-id.c: Sort headers.
8407         * btrace.c: Sort headers.
8408         * bsd-uthread.c: Sort headers.
8409         * breakpoint.h: Sort headers.
8410         * breakpoint.c: Sort headers.
8411         * break-catch-throw.c: Sort headers.
8412         * break-catch-syscall.c: Sort headers.
8413         * break-catch-sig.c: Sort headers.
8414         * blockframe.c: Sort headers.
8415         * block.c: Sort headers.
8416         * bfin-tdep.c: Sort headers.
8417         * bfin-linux-tdep.c: Sort headers.
8418         * bfd-target.c: Sort headers.
8419         * bcache.c: Sort headers.
8420         * ax-general.c: Sort headers.
8421         * ax-gdb.h: Sort headers.
8422         * ax-gdb.c: Sort headers.
8423         * avr-tdep.c: Sort headers.
8424         * auxv.c: Sort headers.
8425         * auto-load.c: Sort headers.
8426         * arm-wince-tdep.c: Sort headers.
8427         * arm-tdep.c: Sort headers.
8428         * arm-symbian-tdep.c: Sort headers.
8429         * arm-pikeos-tdep.c: Sort headers.
8430         * arm-obsd-tdep.c: Sort headers.
8431         * arm-nbsd-tdep.c: Sort headers.
8432         * arm-nbsd-nat.c: Sort headers.
8433         * arm-linux-tdep.c: Sort headers.
8434         * arm-linux-nat.c: Sort headers.
8435         * arm-fbsd-tdep.c: Sort headers.
8436         * arm-fbsd-nat.c: Sort headers.
8437         * arm-bsd-tdep.c: Sort headers.
8438         * arch-utils.c: Sort headers.
8439         * arc-tdep.c: Sort headers.
8440         * arc-newlib-tdep.c: Sort headers.
8441         * annotate.h: Sort headers.
8442         * annotate.c: Sort headers.
8443         * amd64-windows-tdep.c: Sort headers.
8444         * amd64-windows-nat.c: Sort headers.
8445         * amd64-tdep.c: Sort headers.
8446         * amd64-sol2-tdep.c: Sort headers.
8447         * amd64-obsd-tdep.c: Sort headers.
8448         * amd64-obsd-nat.c: Sort headers.
8449         * amd64-nbsd-tdep.c: Sort headers.
8450         * amd64-nbsd-nat.c: Sort headers.
8451         * amd64-nat.c: Sort headers.
8452         * amd64-linux-tdep.c: Sort headers.
8453         * amd64-linux-nat.c: Sort headers.
8454         * amd64-fbsd-tdep.c: Sort headers.
8455         * amd64-fbsd-nat.c: Sort headers.
8456         * amd64-dicos-tdep.c: Sort headers.
8457         * amd64-darwin-tdep.c: Sort headers.
8458         * amd64-bsd-nat.c: Sort headers.
8459         * alpha-tdep.c: Sort headers.
8460         * alpha-obsd-tdep.c: Sort headers.
8461         * alpha-nbsd-tdep.c: Sort headers.
8462         * alpha-mdebug-tdep.c: Sort headers.
8463         * alpha-linux-tdep.c: Sort headers.
8464         * alpha-linux-nat.c: Sort headers.
8465         * alpha-bsd-tdep.c: Sort headers.
8466         * alpha-bsd-nat.c: Sort headers.
8467         * aix-thread.c: Sort headers.
8468         * agent.c: Sort headers.
8469         * addrmap.c: Sort headers.
8470         * ada-varobj.c: Sort headers.
8471         * ada-valprint.c: Sort headers.
8472         * ada-typeprint.c: Sort headers.
8473         * ada-tasks.c: Sort headers.
8474         * ada-lang.c: Sort headers.
8475         * aarch64-tdep.c: Sort headers.
8476         * aarch64-ravenscar-thread.c: Sort headers.
8477         * aarch64-newlib-tdep.c: Sort headers.
8478         * aarch64-linux-tdep.c: Sort headers.
8479         * aarch64-linux-nat.c: Sort headers.
8480         * aarch64-fbsd-tdep.c: Sort headers.
8481         * aarch64-fbsd-nat.c: Sort headers.
8482         * aarch32-linux-nat.c: Sort headers.
8483
8484 2019-04-04  Tom Tromey  <tom@tromey.com>
8485
8486         * varobj.c (varobj_create): Update.
8487         * rust-exp.y (struct rust_parser) <update_innermost_block,
8488         lookup_symbol>: New methods.
8489         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8490         Rename.
8491         (rust_parser::rust_lookup_type)
8492         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8493         * printcmd.c (display_command, do_one_display): Update.
8494         * parser-defs.h (struct parser_state) <parser_state>: Add
8495         "tracker" parameter.
8496         (block_tracker): New member.
8497         (class innermost_block_tracker) <innermost_block_tracker>: Add
8498         "types" parameter.
8499         <reset>: Remove method.
8500         (innermost_block): Don't declare.
8501         (null_post_parser): Update.
8502         * parse.c (innermost_block): Remove global.
8503         (write_dollar_variable): Update.
8504         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8505         Remove "tracker_types" parameter.
8506         (parse_expression): Add "tracker" parameter.
8507         (parse_expression_for_completion): Update.
8508         (null_post_parser): Add "tracker" parameter.
8509         * p-exp.y: Update rules.
8510         * m2-exp.y: Update rules.
8511         * language.h (struct language_defn) <la_post_parser>: Add
8512         "tracker" parameter.
8513         * go-exp.y: Update rules.
8514         * f-exp.y: Update rules.
8515         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8516         parameter.
8517         * d-exp.y: Update rules.
8518         * c-exp.y: Update rules.
8519         * breakpoint.c (set_breakpoint_condition): Create an
8520         innermost_block_tracker.
8521         (watch_command_1): Likewise.
8522         * ada-lang.c (resolve): Add "tracker" parameter.
8523         (resolve_subexp): Likewise.
8524         * ada-exp.y (write_var_from_sym): Update.
8525
8526 2019-04-04  Tom Tromey  <tom@tromey.com>
8527
8528         * type-stack.h: New file.
8529         * type-stack.c: New file.
8530         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8531         type-stack.h.
8532         (insert_into_type_stack, insert_type, push_type, push_type_int)
8533         (insert_type_address_space, pop_type, pop_type_int)
8534         (pop_typelist, pop_type_stack, append_type_stack)
8535         (push_type_stack, get_type_stack, push_typelist)
8536         (follow_type_instance_flags, follow_types): Don't declare.
8537         * parse.c (type_stack): Remove global.
8538         (parse_exp_in_context): Update.
8539         (insert_into_type_stack, insert_type, push_type, push_type_int)
8540         (insert_type_address_space, pop_type, pop_type_int)
8541         (pop_typelist, pop_type_stack, append_type_stack)
8542         (push_type_stack, get_type_stack, push_typelist)
8543         (follow_type_instance_flags, follow_types): Remove (moved to
8544         type-stack.c).
8545         * f-exp.y (type_stack): New global.
8546         Update rules.
8547         (push_kind_type, f_parse): Update.
8548         * d-exp.y (type_stack): New global.
8549         Update rules.
8550         (d_parse): Update.
8551         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8552         Update rules.
8553         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8554         (HFILES_NO_SRCDIR): Add type-stack.h.
8555
8556 2019-04-04  Tom Tromey  <tom@tromey.com>
8557
8558         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8559         (rust_parser::convert_ast_to_expression, rust_parse)
8560         (rust_lex_test_completion, rust_lex_tests): Update.
8561         * parser-defs.h (struct expr_completion_state): New.
8562         (struct parser_state) <parser_state>: Add completion parameter.
8563         <mark_struct_expression, mark_completion_tag>: New methods.
8564         <parse_completion, m_completion_state>: New members.
8565         (prefixify_expression, null_post_parser): Update.
8566         (mark_struct_expression, mark_completion_tag): Don't declare.
8567         * parse.c (parse_completion, expout_last_struct)
8568         (expout_tag_completion_type, expout_completion_name): Remove
8569         globals.
8570         (parser_state::mark_struct_expression)
8571         (parser_state::mark_completion_tag): Now methods.
8572         (prefixify_expression): Add last_struct parameter.
8573         (prefixify_subexp): Likewise.
8574         (parse_exp_1): Update.
8575         (parse_exp_in_context): Add cstate parameter.  Update.
8576         (parse_expression_for_completion): Create an
8577         expr_completion_state.
8578         (null_post_parser): Add "completion" parameter.
8579         * p-exp.y: Update rules.
8580         (yylex): Update.
8581         * language.h (struct language_defn) <la_post_parser>: Add
8582         "completing" parameter.
8583         * go-exp.y: Update rules.
8584         (lex_one_token): Update.
8585         * expression.h (parse_completion): Don't declare.
8586         * d-exp.y: Update rules.
8587         (lex_one_token): Update rules.
8588         * c-exp.y: Update rules.
8589         (lex_one_token): Update.
8590         * ada-lang.c (resolve): Add "parse_completion" parameter.
8591         (resolve_subexp): Likewise.
8592         (ada_resolve_function): Likewise.
8593
8594 2019-04-04  Tom Tromey  <tom@tromey.com>
8595
8596         * parser-defs.h (struct parser_state) <start_arglist,
8597         end_arglist>: New methods.
8598         <arglist_len, m_funcall_chain>: New members.
8599         (arglist_len, start_arglist, end_arglist): Don't declare.
8600         * parse.c (arglist_len, funcall_chain): Remove global.
8601         (start_arglist, end_arglist): Remove functions.
8602         (parse_exp_in_context): Update.
8603         * p-exp.y: Update rules.
8604         * m2-exp.y: Update rules.
8605         * go-exp.y: Update rules.
8606         * f-exp.y: Update rules.
8607         * d-exp.y: Update rules.
8608         * c-exp.y: Update rules.
8609
8610 2019-04-04  Tom Tromey  <tom@tromey.com>
8611
8612         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8613         lex_operator, push_back>: New methods.
8614         Update all rules.
8615         (rust_parser::lex_hex, lex_escape): Rename and update.
8616         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8617         (rust_parser::lex_operator): Rename and update.
8618         (rust_parser::lex_number, rustyylex, rustyyerror)
8619         (rust_lex_test_init, rust_lex_test_sequence)
8620         (rust_lex_test_push_back, rust_lex_tests): Update.
8621         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8622         parameter.
8623         <lexptr, prev_lexptr>: New members.
8624         (lexptr, prev_lexptr): Don't declare.
8625         * parse.c (lexptr, prev_lexptr): Remove globals.
8626         (parse_exp_in_context): Update.
8627         * p-exp.y (yylex, yyerror): Update.
8628         * m2-exp.y (parse_number, yylex, yyerror): Update.
8629         * go-exp.y (lex_one_token, yyerror): Update.
8630         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8631         * d-exp.y (lex_one_token, yyerror): Update.
8632         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8633         (lex_one_token, yyerror): Update.
8634         * ada-lex.l (YY_INPUT): Update.
8635         (rewind_to_char): Update.
8636         * ada-exp.y (yyerror): Update.
8637
8638 2019-04-04  Tom Tromey  <tom@tromey.com>
8639
8640         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8641         * parser-defs.h (struct parser_state) <parser_state>: Add new
8642         parameter.
8643         <comma_terminates>: New member.
8644         (comma_terminates): Don't declare global.
8645         * parse.c (comma_terminates): Remove global.
8646         (parse_exp_in_context): Update.
8647         * p-exp.y (yylex): Update.
8648         * m2-exp.y (yylex): Update.
8649         * go-exp.y (lex_one_token): Update.
8650         * f-exp.y (yylex): Update.
8651         * d-exp.y (lex_one_token): Update.
8652         * c-exp.y (lex_one_token): Update.
8653         * ada-lex.l: Update.
8654
8655 2019-04-04  Tom Tromey  <tom@tromey.com>
8656
8657         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8658         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8659         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8660         * parser-defs.h (paren_depth): Don't declare.
8661         * parse.c (paren_depth): Remove global.
8662         (parse_exp_in_context): Update.
8663         * p-exp.y (paren_depth): New global.
8664         (pascal_parse): Initialize it.
8665         * m2-exp.y (paren_depth): New global.
8666         (m2_parse): Initialize it.
8667         * go-exp.y (paren_depth): New global.
8668         (go_parse): Initialize it.
8669         * f-exp.y (paren_depth): New global.
8670         (f_parse): Initialize it.
8671         * d-exp.y (paren_depth): New global.
8672         (d_parse): Initialize it.
8673         * c-exp.y (paren_depth): New global.
8674         (c_parse): Initialize it.
8675         * ada-lex.l (paren_depth): New global.
8676         (lexer_init): Initialize it.
8677
8678 2019-04-04  Tom Tromey  <tom@tromey.com>
8679
8680         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8681         (rust_parser::convert_ast_to_type)
8682         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8683         * parser-defs.h (struct parser_state) <parser_state>: Add
8684         parameters.  Initialize new members.
8685         <expression_context_block, expression_context_pc>: New members.
8686         * parse.c (expression_context_block, expression_context_pc):
8687         Remove globals.
8688         (parse_exp_in_context): Update.
8689         * p-exp.y: Update all rules.
8690         (yylex): Update.
8691         * m2-exp.y: Update all rules.
8692         (yylex): Update.
8693         * go-exp.y (yylex): Update.
8694         * f-exp.y (yylex): Update.
8695         * d-exp.y: Update all rules.
8696         (yylex): Update.
8697         * c-exp.y: Update all rules.
8698         (lex_one_token, classify_name, yylex, c_parse): Update.
8699         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8700
8701 2019-04-04  Tom Tromey  <tom@tromey.com>
8702
8703         * gdbarch.h, gdbarch.c: Rebuild.
8704         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8705         * stap-probe.h:
8706         (struct stap_parse_info): Replace "parser_state" with
8707         "expr_builder".
8708         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8709         (parser_state): New class.
8710         * parse.c (expr_builder): Rename.
8711         (expr_builder::release): Rename.
8712         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8713         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8714         (write_exp_elt_longcst, write_exp_elt_floatcst)
8715         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8716         (write_exp_string_vector, write_exp_bitstring)
8717         (write_exp_msymbol, mark_struct_expression)
8718         (write_dollar_variable)
8719         (insert_type_address_space, increase_expout_size): Replace
8720         "parser_state" with "expr_builder".
8721         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8722         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8723         "parser_state" with "expr_builder".
8724
8725 2019-04-04  Tom Tromey  <tom@tromey.com>
8726
8727         * rust-exp.y: Replace "parse_language" with method call.
8728         * p-exp.y:
8729         (yylex): Replace "parse_language" with method call.
8730         * m2-exp.y:
8731         (yylex): Replace "parse_language" with method call.
8732         * go-exp.y (classify_name): Replace "parse_language" with method
8733         call.
8734         * f-exp.y (yylex): Replace "parse_language" with method call.
8735         * d-exp.y (lex_one_token): Replace "parse_language" with method
8736         call.
8737         * c-exp.y:
8738         (lex_one_token, classify_name, yylex): Replace "parse_language"
8739         with method call.
8740         * ada-exp.y (find_primitive_type, type_char)
8741         (type_system_address): Replace "parse_language" with method call.
8742
8743 2019-04-04  Tom Tromey  <tom@tromey.com>
8744
8745         * rust-exp.y: Replace "parse_gdbarch" with method call.
8746         * parse.c (write_dollar_variable, insert_type_address_space):
8747         Replace "parse_gdbarch" with method call.
8748         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8749         call.
8750         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8751         call.
8752         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8753         "parse_gdbarch" with method call.
8754         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8755         with method call.
8756         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8757         "parse_gdbarch" with method call.
8758         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8759         "parse_gdbarch" with method call.
8760         * c-exp.y (parse_type, parse_number, classify_name): Replace
8761         "parse_gdbarch" with method call.
8762         * ada-lex.l: Replace "parse_gdbarch" with method call.
8763         * ada-exp.y (parse_type, find_primitive_type, type_char)
8764         (type_system_address): Replace "parse_gdbarch" with method call.
8765
8766 2019-04-04  Tom Tromey  <tom@tromey.com>
8767
8768         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8769         * stap-probe.c (stap_parse_argument): Update.
8770         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8771         initial_size parameter.
8772         * rust-exp.y (rust_lex_tests): Update.
8773         * parse.c (parser_state): Update.
8774         (parse_exp_in_context): Update.
8775         * parser-defs.h (struct parser_state) <parser_state>: Remove
8776         "initial_size" parameter.
8777
8778 2019-04-04  Tom Tromey  <tom@tromey.com>
8779
8780         * parser-defs.h (increase_expout_size): Don't declare.
8781         * parse.c (increase_expout_size): Now static.
8782
8783 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8784
8785         * gnu-nat.c (gnu_nat_target::wait): Fix
8786         target_waitstatus_to_string call.
8787
8788 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * eval.c (evaluate_subexp_standard): Handle internal functions
8791         during Fortran function call handling.
8792
8793 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8794
8795         * NEWS: Mention new internal functions.
8796         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8797         (read_base_type): Use dwarf2_init_complex_target_type.
8798         * value.c (creal_internal_fn): New function.
8799         (cimag_internal_fn): New function.
8800         (_initialize_values): Register new internal functions.
8801
8802 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8803
8804         * infrun.c (stop_all_threads): If debug_infrun, always
8805         trace the wait status after wait_one, using
8806         target_waitstatus_to_string and target_pid_to_str.
8807         (handle_inferior_event): Replace various trace of
8808         wait status kind by a single trace.
8809         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8810         wait status kind image by target_waitstatus_to_string.
8811         * target/waitstatus.c (target_waitstatus_to_string): Fix
8812         obsolete comment.
8813
8814 2019-04-01  Tom Tromey  <tromey@adacore.com>
8815
8816         PR symtab/23331:
8817         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8818
8819 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8820             Pedro Alves  <palves@redhat.com>
8821
8822         * top.c (quit_force): Call 'finalize_values'.
8823         * value.c (finalize_values): New function.
8824         * value.h (finalize_values): Declare.
8825
8826 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8827
8828         * NEWS: Announce $_gdb_major and $_gdb_minor.
8829
8830         * top.c (init_gdb_version_vars): New function.
8831         (gdb_init): Call init_gdb_version_vars.
8832
8833 2019-03-29  Tom Tromey  <tromey@adacore.com>
8834
8835         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8836         help text.  Remove dead code.
8837
8838 2019-03-29  Keith Seitz  <keiths@redhat.com>
8839
8840         From Siddhesh Poyarekar:
8841         * f-lang.h (f77_get_upperbound): Return LONGEST.
8842         (f77_get_lowerbound): Likewise.
8843         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8844         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8845         print them.
8846         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8847         plongest to format print it.
8848         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8849         (f77_get_upperbound): Likewise.
8850         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8851         LOWER_BOUND to LONGEST.
8852         (f77_create_arrayprint_offset_tbl): Likewise.
8853
8854 2019-03-29  Keith Seitz  <keiths@redhat.com>
8855
8856         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8857         %s/pulongest for TYPE_LENGTH instead of %d in format
8858         strings.
8859         * ada-typerint.c (ada_print_type): Likewise.
8860         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8861         * compile/compile-c-support.c (generate_register_struct): Likewise.
8862         * gdbtypes.c (recursive_dump_type): Likewise.
8863         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8864         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8865         instead of %d in format strings.
8866         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8867         to std::min to ULONGEST.
8868         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8869         instead of %d in format strings.
8870         * tracepoint.c (info_scope_command): Likewise.
8871         * typeprint.c (print_offset_data::update)
8872         (print_offset_data::finish): Likewise.
8873         * xtensa-tdep.c (xtensa_store_return_value)
8874         (xtensa_push_dummy_call): Likewise.
8875
8876 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8877
8878         * windows-nat.c (display_selector): Fixed format specifications
8879         for 64-bit Cygwin.
8880
8881 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8882
8883         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8884
8885 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8886
8887         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8888         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8889         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8890         (nios2_linux_init_abi): Install it.
8891
8892 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8893
8894         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8895
8896 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8897
8898         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8899
8900 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8901             Tom Tromey  <tromey@adacore.com>
8902
8903         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8904
8905 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8906
8907         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8908         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8909         method to compute the bounds of range types. Also print "[evaluated]"
8910         if the bounds' values come from a dynamic evaluation.
8911
8912 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8915         whitespace when pretty printing is on.
8916
8917 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8918
8919         * ppc-linux-nat.c: Add include.
8920
8921 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8922
8923         * NEWS: Mention AArch64 Pointer Authentication.
8924
8925 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8926
8927         * arm-linux-nat.c: Add include.
8928
8929 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8930
8931         * source-cache.c (source_cache::get_source_lines): Re-read
8932         fullname after calling open_source_file.
8933
8934 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8935
8936         * NEWS: Mention TLS support for FreeBSD.
8937
8938 2019-03-25  Tom Tromey  <tromey@adacore.com>
8939
8940         * minsyms.c (BUNCH_SIZE): Update comment.
8941         (~minimal_symbol_reader): Remove old comment.
8942         (compact_minimal_symbols): Update comment.
8943         (minimal_symbol_reader::install): Remove old comment.  Update
8944         other comments.
8945
8946 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8947
8948         * s390-linux-nat.c: Add include.
8949
8950 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8951
8952         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8953         Call linux_get_hwcap.
8954         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8955         Likewise.
8956         (aarch64_linux_get_hwcap): Remove function.
8957         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8958         declaration.
8959         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8960         linux_get_hwcap.
8961         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8962         * linux-tdep.c (linux_get_hwcap): Add function.
8963         (linux_get_hwcap2): Likewise.
8964         * linux-tdep.h (linux_get_hwcap): Add declaration.
8965         (linux_get_hwcap2): Likewise.
8966         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8967         (ppc_linux_get_hwcap2): Likewise.
8968         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8969         linux_get_hwcap.
8970         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8971         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8972         (ppc_linux_nat_target::read_description): Likewise.
8973         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8974         * s390-linux-nat.c: Likewise.
8975         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8976
8977 2019-03-24  Tom Tromey  <tom@tromey.com>
8978
8979         * ada-lang.c (standard_lookup): Simplify initialization.
8980         (ada_lookup_symbol_nonlocal): Simplify return.
8981         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8982         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8983         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8984         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8985         initialization.
8986         * solib.c (solib_global_lookup): Simplify.
8987         * symtab.c (null_block_symbol): Remove.
8988         (symbol_cache_lookup): Simplify returns.
8989         (lookup_language_this): Simplify returns.
8990         (lookup_symbol_aux): Simplify return.
8991         (lookup_local_symbol): Simplify returns.
8992         (lookup_global_symbol_from_objfile): Simplify return.
8993         (lookup_symbol_in_objfile_symtabs)
8994         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8995         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8996         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8997         * cp-namespace.c (cp_lookup_bare_symbol)
8998         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8999         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9000         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9001         (cp_lookup_symbol_via_imports): Simplify initialization.
9002         (find_symbol_in_baseclass): Likewise.
9003         * symtab.h (null_block_symbol): Remove.
9004         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9005         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9006         (d_lookup_symbol_module): Likewise.
9007         (find_symbol_in_baseclass): Simplify initialization.
9008
9009 2019-03-24  Tom Tromey  <tom@tromey.com>
9010
9011         * expression.h: Don't include symtab.h.
9012         (struct block): Forward declare.
9013
9014 2019-03-24  Tom Tromey  <tom@tromey.com>
9015
9016         * c-exp.y (typebase): Remove casts.
9017         * gdbtypes.c (lookup_unsigned_typename, )
9018         (lookup_signed_typename): Remove cast.
9019         * eval.c (parse_to_comma_and_eval): Remove cast.
9020         * parse.c (write_dollar_variable): Remove cast.
9021         * block.h (struct block) <superblock>: Now const.
9022         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9023         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9024         (map_block): Make "block" const.
9025         * symfile.h (struct quick_symbol_functions)
9026         <map_matching_symbols>: Constify block argument to "callback".
9027         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9028         const.
9029         (find_pc_sect_compunit_symtab): Make "b" const.
9030         (find_symbol_at_address): Likewise.
9031         (search_symbols): Likewise.
9032         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9033         (dw2_debug_names_lookup_symbol): Likewise.
9034         (dw2_map_matching_symbols): Update.
9035         * p-valprint.c (pascal_val_print): Remove "block".
9036         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9037         (aux_add_nonlocal_symbols): Make "block" const.
9038         (resolve_subexp): Remove cast.
9039         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9040         const.
9041         (iterate_over_file_blocks): Likewise.
9042         * f-exp.y (%union) <bval>: Remove.
9043         * coffread.c (patch_opaque_types): Make "b" const.
9044         * spu-tdep.c (spu_catch_start): Make "block" const.
9045         * c-valprint.c (print_unpacked_pointer): Remove "block".
9046         * symmisc.c (dump_symtab_1): Make "b" const.
9047         (block_depth): Make "block" const.
9048         * d-exp.y (%union) <bval>: Remove.
9049         * cp-support.h (cp_lookup_rtti_type): Update.
9050         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9051         * psymtab.c (psym_lookup_symbol): Make "block" const.
9052         (maintenance_check_psymtabs): Make "b" const.
9053         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9054         (enumerate_locals, enumerate_args): Update.
9055         * python/py-symtab.c (stpy_global_block): Make "block" const.
9056         (stpy_static_block): Likewise.
9057         * inline-frame.c (block_starting_point_at): Make "new_block"
9058         const.
9059         * block.c (find_block_in_blockvector): Make return type const.
9060         (blockvector_for_pc_sect): Make "b" const.
9061         (find_block_in_blockvector): Make "b" const.
9062
9063 2019-03-23  Tom Tromey  <tom@tromey.com>
9064
9065         * varobj.c (varobj_create): Update.
9066         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9067         * printcmd.c (display_command, do_one_display): Don't reset
9068         innermost_block.
9069         * parser-defs.h (enum innermost_block_tracker_type): Move to
9070         expression.h.
9071         (innermost_block): Update comment.
9072         * parse.c (parse_exp_1): Add tracker_types parameter.
9073         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9074         tracker_types parameter.  Reset innermost_block.
9075         (parse_exp_in_context): Remove.
9076         (parse_expression_for_completion): Update.
9077         * objfiles.c (~objfile): Don't reset expression_context_block or
9078         innermost_block.
9079         * expression.h (enum innermost_block_tracker_type): Move from
9080         parser-defs.h.
9081         (parse_exp_1): Add tracker_types parameter.
9082         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9083         reset innermost_block.
9084
9085 2019-03-23  Tom Tromey  <tom@tromey.com>
9086
9087         * objfiles.h: Include bcache.h.
9088
9089 2019-03-23  Tom Tromey  <tom@tromey.com>
9090
9091         * linespec.c (get_current_search_block): Use
9092         scoped_restore_current_language.
9093         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9094
9095 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9096             Jiong Wang  <jiong.wang@arm.com>
9097
9098         * aarch64-linux-tdep.c
9099         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9100         section.
9101         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9102
9103 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9104             Jiong Wang  <jiong.wang@arm.com>
9105
9106         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9107         instructions.
9108         (aarch64_analyze_prologue_test): Add PACIASP test.
9109         (aarch64_prologue_prev_register): Unmask PC value.
9110
9111 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9112             Jiong Wang  <jiong.wang@arm.com>
9113
9114         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9115         (aarch64_dwarf2_prev_register): Unmask PC value.
9116         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9117         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9118         DW_CFA_AARCH64_negate_ra_state.
9119         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9120
9121 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9122             Jiong Wang  <jiong.wang@arm.com>
9123
9124         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9125         registers.
9126         (aarch64_pseudo_register_name): Likewise.
9127         (aarch64_pseudo_register_type): Likewise.
9128         (aarch64_pseudo_register_reggroup_p): Likewise.
9129         (aarch64_gdbarch_init): Add pauth registers.
9130         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9131         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9132         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9133         (struct gdbarch_tdep): Add regnum for ra_state.
9134
9135 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9136             Jiong Wang  <jiong.wang@arm.com>
9137
9138         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9139
9140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9141             Jiong Wang  <jiong.wang@arm.com>
9142
9143         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9144         function.
9145         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9146         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9147         (aarch64_gdbarch_init): Add puth registers.
9148         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9149         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9150         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9151
9152 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9153             Jiong Wang  <jiong.wang@arm.com>
9154
9155         * aarch64-linux-nat.c
9156         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9157         * aarch64-linux-tdep.c
9158         (aarch64_linux_core_read_description): Likewise.
9159         (aarch64_linux_get_hwcap): New function.
9160         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9161         (aarch64_linux_get_hwcap): New declaration.
9162
9163 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9164             Jiong Wang  <jiong.wang@arm.com>
9165
9166         * aarch64-linux-nat.c
9167         (aarch64_linux_nat_target::read_description): Add pauth param.
9168         * aarch64-linux-tdep.c
9169         (aarch64_linux_core_read_description): Likewise.
9170         * aarch64-tdep.c (struct target_desc): Add in pauth.
9171         (aarch64_read_description): Add pauth param.
9172         (aarch64_gdbarch_init): Likewise.
9173         * aarch64-tdep.h (aarch64_read_description): Likewise.
9174         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9175         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9176         * features/Makefile: Add new files.
9177         * features/aarch64-pauth.c: New file.
9178         * features/aarch64-pauth.xml: New file.
9179
9180 2019-03-20  Tom Tromey  <tromey@adacore.com>
9181
9182         * infrun.c (handle_inferior_event): Rename from
9183         handle_inferior_event_1.  Create a scoped_value_mark.
9184         (handle_inferior_event): Remove.
9185
9186 2019-03-19  Tom Tromey  <tromey@adacore.com>
9187
9188         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9189         * infrun.h (print_stop_event): Add "displays" parameter.
9190         * infrun.c (print_stop_event): Add "displays" parameter.
9191
9192 2019-03-19  Pedro Alves  <palves@redhat.com>
9193
9194         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9195         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9196         to -1.  Fix TABs vs spaces.
9197         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9198         * tui/tui-out.h (tui_ui_out) Add intro comments.
9199         <m_line, m_start_of_line>: In-class initialize, and add describing
9200         comment.
9201
9202 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9203
9204         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9205         variable names.
9206         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9207
9208 2019-03-18  Pedro Alves  <palves@redhat.com>
9209             Eli Zaretskii <eliz@gnu.org>
9210
9211         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9212         m_line and m_start_of_line.
9213
9214 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9215
9216         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9217         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9218         it returns a newline.  This fixes a regression in TU mode, whereby
9219         the next line is output on the same screen line as the user input.
9220
9221 2019-03-18  Tom Tromey  <tromey@adacore.com>
9222
9223         * minsyms.c (minimal_symbol_reader::install): Remove call to
9224         obstack_blank.
9225
9226 2019-03-18  Pedro Alves  <palves@redhat.com>
9227
9228         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9229         New globals.
9230         (apply_style): New, factored out from ...
9231         (apply_ansi_escape): ... this.  Handle reverse video mode.
9232         (tui_set_reverse_mode): New function.
9233         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9234         * tui/tui-winsource.c (tui_show_source_line): Use
9235         tui_set_reverse_mode instead of setting A_STANDOUT.
9236         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9237         New setter methods.
9238
9239 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9240
9241         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9242         Handle tabs.
9243
9244 2019-03-18  Tom Tromey  <tromey@adacore.com>
9245
9246         * ada-lang.c (empty_array): Add "high" parameter.
9247         (ada_evaluate_subexp): Update.
9248
9249 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9250
9251         * unittests/string_view-selftests.c: Define
9252         _initialize_string_view_selftests unconditionally.
9253
9254 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9255
9256         PR gdb/24350
9257         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9258
9259 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9260
9261         PR gdb/24351
9262         * windows-nat.c (display_selector): Fix format specifiers.
9263
9264 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9265
9266         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9267         tui_refill_source_window instead of tui_refresh_win, to update the
9268         current execution line.  This fixes redisplay of the current line
9269         when stepping through the code with "next" or "step".
9270
9271 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9272
9273         * source-cache.c (source_cache::get_source_lines): Call
9274         find_source_lines to initialize s->nlines.  This fixes vertical
9275         scrolling of TUI source window when the DOWN arrow is pressed.
9276
9277 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9278
9279         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9280         linux-thread-db.c (_initialize_thread_db): Likewise.
9281
9282 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9283
9284         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9285         wclrtoeol in tui_show_source_line".  This reverts changes made in
9286         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9287
9288 2019-03-15  Tom Tromey  <tom@tromey.com>
9289
9290         * symtab.h (struct minimal_symbol): Derive from
9291         general_symbol_info.
9292         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9293         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9294         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9295         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9296         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9297         (MSYMBOL_SEARCH_NAME): Update.
9298         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9299         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9300         * minsyms.c (minimal_symbol_reader::record_full): Update.
9301
9302 2019-03-15  Tom Tromey  <tom@tromey.com>
9303
9304         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9305
9306 2019-03-15  Tom Tromey  <tom@tromey.com>
9307
9308         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9309         unique_xmalloc_ptr.
9310         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9311         Update.
9312         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9313         (build_minimal_symbol_hash_tables)
9314         (minimal_symbol_reader::install): Update.
9315
9316 2019-03-15  Tom Tromey  <tom@tromey.com>
9317
9318         * symtab.c (create_demangled_names_hash): Update.
9319         (symbol_set_names): Update.
9320         * objfiles.h (struct objfile_per_bfd_storage)
9321         <demangled_names_hash>: Now an htab_up.
9322         * objfiles.c (objfile_per_bfd_storage): Simplify.
9323
9324 2019-03-15  Tom Tromey  <tom@tromey.com>
9325
9326         * objfiles.h (struct objfile_per_bfd_storage): Declare
9327         destructor.
9328         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9329         New.
9330         (get_objfile_bfd_data): Use new.  Don't initialize
9331         language_of_main.
9332         (free_objfile_per_bfd_storage): Remove.
9333         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9334
9335 2019-03-15  Tom Tromey  <tom@tromey.com>
9336
9337         * symfile.c (reread_symbols): Update.
9338         * objfiles.c (objfile::objfile): Update.
9339         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9340         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9341         comment.
9342         (minimal_symbol_reader::install): Update.
9343         (terminate_minimal_symbol_table): Remove.
9344         * jit.c (jit_object_close_impl): Update.
9345
9346 2019-03-15  Tom Tromey  <tom@tromey.com>
9347
9348         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9349         initializations.
9350
9351 2019-03-15  Tom Tromey  <tom@tromey.com>
9352
9353         * objfiles.h (struct objfile_per_bfd_storage)
9354         <demangled_hash_languages>: Now a bitset.
9355         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9356         (lookup_minimal_symbol): Update.
9357
9358 2019-03-15  Tom Tromey  <tom@tromey.com>
9359
9360         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9361         Don't return the symbol.
9362         * coffread.c (record_minimal_symbol): Use record_full.
9363
9364 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9365
9366         The MS-Windows port of ncurses fails to switch to a color pair if
9367         one or both of the colors are the implicit default colors.  This
9368         change records the default colors when TUI is initialized, and
9369         then specifies them explicitly when a color pair uses the default
9370         colors.  This allows color styling in TUI mode on MS-Windows.
9371
9372         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9373         ncurses_norm_attr.
9374         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9375         colors in ncurses_norm_attr.
9376         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9377         "none", replace it with the default color recorded in
9378         ncurses_norm_attr.
9379
9380 2019-03-14  Tom Tromey  <tromey@adacore.com>
9381
9382         * source-cache.h (class source_cache) <get_source_lines>: Return
9383         std::string.
9384         * source-cache.c (source_cache::extract_lines): Handle case where
9385         first_pos==npos.  Return std::string.
9386         (source_cache::get_source_lines): Update.
9387
9388 2019-03-14  Tom Tromey  <tromey@adacore.com>
9389
9390         * NEWS: Add item for "style sources" commands.
9391         * source-cache.c (source_cache::get_source_lines): Check
9392         source_styling.
9393         * cli/cli-style.c (source_styling): New global.
9394         (_initialize_cli_style): Add "style sources" commands.
9395         (show_style_sources): New function.
9396         * cli/cli-style.h (source_styling): Declare.
9397
9398 2019-03-14  Pedro Alves  <palves@redhat.com>
9399             Tom Tromey  <tromey@adacore.com>
9400
9401         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9402         * tui/tui-winsource.c (tui_refill_source_window): New function,
9403         from...
9404         (tui_horizontal_source_scroll): ... here.  Move some logic.
9405         * cli/cli-style.c (set_style_enabled): Notify new observable.
9406         * tui/tui-hooks.c (tui_redisplay_source): New function.
9407         (tui_attach_detach_observers): Attach or detach
9408         tui_redisplay_source.
9409         * observable.h (source_styling_changed): New observable.
9410         * observable.c: Define source_styling_changed observable.
9411
9412 2019-03-13  Tom Tromey  <tromey@adacore.com>
9413
9414         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9415         (i386_gnu_nat_target::store_registers): Update.
9416         * target-debug.h (target_debug_print_std_string): New macro.
9417         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9418         * windows-tdep.c (display_one_tib): Update.
9419         * tui/tui-stack.c (tui_make_status_line): Update.
9420         * top.c (print_inferior_quit_action): Update.
9421         * thread.c (thr_try_catch_cmd): Update.
9422         (add_thread_with_info): Update.
9423         (thread_target_id_str): Update.
9424         (thr_try_catch_cmd): Update.
9425         (thread_command): Update.
9426         (thread_find_command): Update.
9427         * record-btrace.c (record_btrace_target::info_record)
9428         (record_btrace_resume_thread, record_btrace_target::resume)
9429         (record_btrace_cancel_resume, record_btrace_step_thread)
9430         (record_btrace_target::wait, record_btrace_target::wait)
9431         (record_btrace_target::wait, record_btrace_target::stop): Update.
9432         * progspace.c (print_program_space): Update.
9433         * process-stratum-target.c
9434         (process_stratum_target::thread_address_space): Update.
9435         * linux-fork.c (linux_fork_mourn_inferior)
9436         (detach_checkpoint_command, info_checkpoints_command)
9437         (linux_fork_context): Update.
9438         (linux_fork_detach): Update.
9439         (class scoped_switch_fork_info): Update.
9440         (delete_checkpoint_command): Update.
9441         * infrun.c (follow_fork_inferior): Update.
9442         (follow_fork_inferior): Update.
9443         (proceed_after_vfork_done): Update.
9444         (handle_vfork_child_exec_or_exit): Update.
9445         (follow_exec): Update.
9446         (displaced_step_prepare_throw): Update.
9447         (displaced_step_restore): Update.
9448         (start_step_over): Update.
9449         (resume_1): Update.
9450         (clear_proceed_status_thread): Update.
9451         (proceed): Update.
9452         (print_target_wait_results): Update.
9453         (do_target_wait): Update.
9454         (context_switch): Update.
9455         (stop_all_threads): Update.
9456         (restart_threads): Update.
9457         (finish_step_over): Update.
9458         (handle_signal_stop): Update.
9459         (switch_back_to_stepped_thread): Update.
9460         (keep_going_pass_signal): Update.
9461         (print_exited_reason): Update.
9462         (normal_stop): Update.
9463         * inferior.c (inferior_pid_to_str): Change return type.
9464         (print_selected_inferior): Update.
9465         (add_inferior): Update.
9466         (detach_inferior): Update.
9467         * dummy-frame.c (fprint_dummy_frames): Update.
9468         * dcache.c (dcache_info_1): Update.
9469         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9470         (btrace_fetch, btrace_clear): Update.
9471         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9472         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9473         type.
9474         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9475         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9476         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9477         * gdbarch.c, gdbarch.h: Rebuild.
9478         * gdbarch.sh (core_pid_to_str): Change return type.
9479         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9480         return type.
9481         (windows_nat_target::pid_to_str): Change return type.
9482         (windows_delete_thread): Update.
9483         (windows_nat_target::attach): Update.
9484         (windows_nat_target::files_info): Update.
9485         * target-delegates.c: Rebuild.
9486         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9487         return type.
9488         (sol_thread_target::pid_to_str): Change return type.
9489         * remote.c (class remote_target) <pid_to_str>: Change return
9490         type.
9491         (remote_target::pid_to_str): Change return type.
9492         (extended_remote_target::attach, remote_target::remote_stop_ns)
9493         (remote_target::remote_notif_remove_queued_reply)
9494         (remote_target::push_stop_reply, remote_target::disable_btrace):
9495         Update.
9496         (extended_remote_target::attach): Update.
9497         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9498         type.
9499         (gdbsim_target::pid_to_str): Change return type.
9500         * ravenscar-thread.c (struct ravenscar_thread_target)
9501         <pid_to_str>: Change return type.
9502         (ravenscar_thread_target::pid_to_str): Change return type.
9503         * procfs.c (class procfs_target) <pid_to_str>: Change return
9504         type.
9505         (procfs_target::pid_to_str): Change return type.
9506         (procfs_target::attach): Update.
9507         (procfs_target::detach): Update.
9508         (procfs_target::fetch_registers): Update.
9509         (procfs_target::store_registers): Update.
9510         (procfs_target::wait): Update.
9511         (procfs_target::files_info): Update.
9512         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9513         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9514         return type.
9515         (nto_procfs_target::pid_to_str): Change return type.
9516         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9517         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9518         return type.
9519         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9520         (exit_lwp): Update.
9521         (attach_proc_task_lwp_callback, get_detach_signal)
9522         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9523         (linux_nat_target::resume, wait_lwp, stop_callback)
9524         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9525         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9526         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9527         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9528         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9529         type.
9530         (inf_ptrace_target::attach): Update.
9531         (inf_ptrace_target::files_info): Update.
9532         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9533         type.
9534         (go32_nat_target::pid_to_str): Change return type.
9535         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9536         (gnu_nat_target::wait): Update.
9537         (gnu_nat_target::wait): Update.
9538         (gnu_nat_target::resume): Update.
9539         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9540         (fbsd_nat_target::wait): Update.
9541         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9542         type.
9543         (darwin_nat_target::attach): Update.
9544         * corelow.c (class core_target) <pid_to_str>: Change return type.
9545         (core_target::pid_to_str): Change return type.
9546         * target.c (normal_pid_to_str): Change return type.
9547         (default_pid_to_str): Likewise.
9548         (target_pid_to_str): Change return type.
9549         (target_translate_tls_address): Update.
9550         (target_announce_detach): Update.
9551         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9552         return type.
9553         (bsd_uthread_target::pid_to_str): Change return type.
9554         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9555         type.
9556         (bsd_kvm_target::pid_to_str): Change return type.
9557         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9558         return type.
9559         (aix_thread_target::pid_to_str): Change return type.
9560         * target.h (struct target_ops) <pid_to_str>: Change return type.
9561         (target_pid_to_str, normal_pid_to_str): Likewise.
9562         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9563         type.
9564         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9565         type.
9566         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9567         return type.
9568         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9569         type.
9570         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9571         type.
9572         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9573         return type.
9574
9575 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9576
9577         * NEWS: Mention that the new default MI version is 3.  Mention
9578         changes to the output of commands and events that deal with
9579         multi-location breakpoints.
9580         * breakpoint.c: Include "mi/mi-out.h".
9581         (print_one_breakpoint): Change output syntax if using MI version
9582         >= 3.
9583         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9584         New.
9585         (mi_multi_location_breakpoint_output_fixed): New.
9586         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9587         (mi_cmd_fix_multi_location_breakpoint_output): New.
9588         (mi_multi_location_breakpoint_output_fixed): New.
9589         * mi/mi-cmds.c (mi_cmds): Register command
9590         -fix-multi-location-breakpoint-output.
9591         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9592         interpreter "mi".
9593
9594 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9595
9596         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9597         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9598         instantiate mi_ui_out based on interpreter name.
9599         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9600         * mi/mi-main.c (mi_load_progress): Likewise.
9601
9602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9603
9604         * NEWS: Combine separate "New targets" sections for 8.3.
9605
9606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9607
9608         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9609         (ppcfbsd_init_abi): Install gdbarch
9610         "fetch_tls_load_module_address" and "get_thread_local_address"
9611         methods.
9612
9613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9614
9615         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9616         (riscv_fbsd_init_abi): Install gdbarch
9617         "fetch_tls_load_module_address" and "get_thread_local_address"
9618         methods.
9619
9620 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9621
9622         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9623         (i386fbsd_init_abi): Install gdbarch
9624         "fetch_tls_load_module_address" and "get_thread_local_address"
9625         methods.
9626
9627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9628
9629         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9630         (amd64fbsd_init_abi): Install gdbarch
9631         "fetch_tls_load_module_address" and "get_thread_local_address"
9632         methods.
9633
9634 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9635
9636         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9637         (struct fbsd_pspace_data): New type.
9638         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9639         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9640         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9641         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9642         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9643
9644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9645
9646         * gdbtypes.c (lookup_struct_elt): New function.
9647         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9648         * gdbtypes.h (struct struct_elt): New type.
9649         (lookup_struct_elt): New prototype.
9650
9651 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9652
9653         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9654         remove disabled code block.
9655
9656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9657
9658         * gdbarch.sh (get_thread_local_address): New method.
9659         * gdbarch.h, gdbarch.c: Regenerate.
9660         * target.c (target_translate_tls_address): Use
9661         gdbarch_get_thread_local_address if present instead of
9662         target::get_thread_local_address.
9663
9664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9665
9666         * target.h (target::get_thread_local_address): Update comment.
9667
9668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9669
9670         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9671         objfile->separate_debug_objfile_backlink if not NULL.
9672
9673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9674
9675         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9676         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9677         (amd64bsd_store_inferior_registers): Likewise.
9678         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9679         Enable segment base registers.
9680         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9681         PT_GETFSBASE and PT_GETGSBASE.
9682         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9683         PT_SETGSBASE.
9684         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9685         segment base registers.
9686         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9687
9688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9689
9690         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9691         Update calls to i386_target_description to add 'segments'
9692         parameter.
9693         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9694         add segment base registers.
9695         * arch/i386.c (i386_create_target_description): Add 'segments'
9696         parameter to enable segment base registers.
9697         * arch/i386.h (i386_create_target_description): Likewise.
9698         * features/i386/32bit-segments.xml: New file.
9699         * features/i386/32bit-segments.c: Generate.
9700         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9701         call to i386_target_description to add 'segments' parameter.
9702         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9703         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9704         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9705         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9706         if feature is present.
9707         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9708         Add 'segments' parameter to call to i386_target_description.
9709         (i386_target_description): Add 'segments' parameter to enable
9710         segment base registers.
9711         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9712         to call to i386_target_description.
9713         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9714         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9715         Define I386_NUM_REGS.
9716         (i386_target_description): Add 'segments' parameter to enable
9717         segment base registers.
9718
9719 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9720
9721         PR/24325
9722         * source-cache.c: #undef open and close, to avoid unresolved
9723         externals during linking.
9724
9725 2019-03-12  Tom Tromey  <tromey@adacore.com>
9726
9727         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9728         const.  Add initializers.
9729         (_initialize_remote): Don't initialize ptid globals.
9730
9731 2019-03-12  Pedro Alves  <palves@redhat.com>
9732
9733         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9734
9735 2019-03-12  Pedro Alves  <palves@redhat.com>
9736
9737         * cp-name-parser.y (main): Remove unused 'len' variable.
9738
9739 2019-03-12  Tom Tromey  <tromey@adacore.com>
9740
9741         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9742         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9743
9744 2019-03-12  Tom Tromey  <tromey@adacore.com>
9745
9746         * linux-nat.c (iterate_over_lwps): Update.
9747         (stop_callback): Remove parameter.
9748         (stop_wait_callback, detach_callback, resume_set_callback)
9749         (select_singlestep_lwp_callback, set_ignore_sigint)
9750         (status_callback, resumed_callback, resume_clear_callback)
9751         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9752         data parameter.
9753         (linux_nat_target::detach, linux_nat_target::resume)
9754         (linux_stop_and_wait_all_lwps, select_event_lwp)
9755         (linux_nat_filter_event, linux_nat_wait_1)
9756         (linux_nat_target::kill, linux_nat_target::stop)
9757         (linux_nat_target::stop): Update.
9758         (linux_nat_resume_callback): Change type.
9759         (resume_stopped_resumed_lwps, count_events_callback)
9760         (select_event_lwp_callback): Likewise.
9761         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9762         * arm-linux-nat.c (struct update_registers_data): Remove.
9763         (update_registers_callback): Change type.
9764         (arm_linux_insert_hw_breakpoint1): Update.
9765         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9766         parameter.
9767         (x86_linux_dr_set_addr): Update.
9768         (x86_linux_dr_set_control): Update.
9769         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9770         (iterate_over_lwps): Use gdb::function_view.
9771         * nat/aarch64-linux-hw-point.c (struct
9772         aarch64_dr_update_callback_param): Remove.
9773         (debug_reg_change_callback): Change type.
9774         (aarch64_notify_debug_reg_change): Update.
9775         * s390-linux-nat.c (s390_refresh_per_info): Update.
9776
9777 2019-03-11  Tom Tromey  <tromey@adacore.com>
9778
9779         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9780         redundant assignment to "this_cu".
9781
9782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9783
9784         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9785
9786 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9787
9788         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9789         from...
9790         (rank_one_type): ... this.
9791
9792 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9793
9794         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9795         from...
9796         (rank_one_type): ... this.
9797
9798 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9799
9800         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9801         from...
9802         (rank_one_type): ... this.
9803
9804 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9805
9806         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9807         from...
9808         (rank_one_type): ... this.
9809
9810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9811
9812         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9813         from...
9814         (rank_one_type): ... this.
9815
9816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9817
9818         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9819         from...
9820         (rank_one_type): ... this.
9821
9822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9823
9824         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9825         from...
9826         (rank_one_type): ... this.
9827
9828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9829
9830         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9831         from...
9832         (rank_one_type): ... this.
9833
9834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9835
9836         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9837         from...
9838         (rank_one_type): ... this.
9839
9840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9841
9842         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9843         from...
9844         (rank_one_type): ... this.
9845
9846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9847
9848         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9849         from...
9850         (rank_one_type): ... this.
9851
9852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9853
9854         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9855         from...
9856         (rank_one_type): ... this.
9857
9858 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9859
9860         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9861         inferior-events' shows the example events.
9862
9863 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9864
9865         Support styling on native MS-Windows console
9866
9867         PR/24315
9868         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9869         on MS-Windows if $TERM is not defined.
9870
9871         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9872
9873         * posix-hdep.c (gdb_console_fputs):
9874         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9875         functions.
9876         * ui-file.h (gdb_console_fputs): Add prototype.
9877
9878         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9879         back to fputs only if the former returns zero.
9880
9881 2019-03-07  Tom Tromey  <tom@tromey.com>
9882
9883         * symmisc.c (print_symbol_bcache_statistics): Update.
9884         (print_objfile_statistics): Update.
9885         * symfile.c (allocate_symtab): Update.
9886         * stabsread.c: Don't include bcache.h.
9887         * psymtab.h (struct psymbol_bcache): Don't declare.
9888         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9889         (psymbol_bcache_init, psymbol_bcache_free)
9890         (psymbol_bcache_get_bcache): Don't declare.
9891         * psymtab.c (struct psymbol_bcache): Remove.
9892         (psymtab_storage::psymtab_storage): Update.
9893         (psymtab_storage::~psymtab_storage): Update.
9894         (psymbol_bcache_init, psymbol_bcache_free)
9895         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9896         (add_psymbol_to_bcache): Update.
9897         (allocate_psymtab): Update.
9898         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9899         macro_cache>: No longer pointers.
9900         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9901         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9902         * macrotab.c (macro_bcache): Update.
9903         * macroexp.c: Don't include bcache.h.
9904         * gdbtypes.c (check_types_worklist): Update.
9905         (types_deeply_equal): Remove TRY/CATCH.  Update.
9906         * elfread.c (elf_symtab_read): Update.
9907         * dwarf2read.c: Don't include bcache.h.
9908         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9909         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9910         (print_bcache_statistics, bcache_memory_used): Don't declare.
9911         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9912         methods.  Rename all data members.
9913         * bcache.c (struct bcache): Move to bcache.h.
9914         (bcache::expand_hash_table): Rename from expand_hash_table.
9915         (bcache): Remove.
9916         (bcache::insert): Rename from bcache_full.
9917         (bcache::compare): Rename from bcache_compare.
9918         (bcache_xmalloc): Remove.
9919         (bcache::~bcache): Rename from bcache_xfree.
9920         (bcache::print_statistics): Rename from print_bcache_statistics.
9921         (bcache::memory_used): Rename from bcache_memory_used.
9922
9923 2019-03-07  Pedro Alves  <palves@redhat.com>
9924
9925         * infrun.c (normal_stop): Also check for
9926         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9927
9928 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9929
9930         * f-lang.c (value_from_host_double): Moved to...
9931         * value.c (value_from_host_double): ...here.
9932         * value.h (value_from_host_double): Declare.
9933         * guile/scm-math.c (vlscm_convert_typed_number): Use
9934         value_from_host_double.
9935         (vlscm_convert_number): Likewise.
9936         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9937         * python/py-value.c (convert_value_from_python): Likewise.
9938
9939 2019-03-06  Tom Tromey  <tom@tromey.com>
9940
9941         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9942
9943 2019-03-06  Tom Tromey  <tom@tromey.com>
9944
9945         * utils.h (free_current_contents): Don't declare.
9946         * utils.c (free_current_contents): Remove.
9947
9948 2019-03-06  Tom Tromey  <tom@tromey.com>
9949
9950         * top.c (quit_force): Update.
9951         * main.c (captured_command_loop): Update.
9952         * common/new-op.c (operator new): Update.
9953         * common/common-exceptions.c (struct catcher)
9954         <save_cleanup_chain>: Remove member.
9955         (exceptions_state_mc_init): Update.
9956         (exception_try_scope_entry): Return nullptr.
9957         (exception_try_scope_exit, exception_rethrow)
9958         (throw_exception_sjlj, throw_exception_cxx): Update.
9959         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9960         (all_cleanups, do_cleanups, discard_cleanups)
9961         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9962         (restore_cleanups, restore_final_cleanups): Don't declare.
9963         (do_final_cleanups): Remove parameter.
9964         * common/cleanups.c (cleanup_chain, make_cleanup)
9965         (make_cleanup_dtor, all_cleanups, do_cleanups)
9966         (discard_my_cleanups, discard_cleanups)
9967         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9968         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9969         (null_cleanup): Remove.
9970         (do_final_cleanups): Remove parameter.
9971
9972 2019-03-06  Tom Tromey  <tom@tromey.com>
9973
9974         * remote.c (remote_target::remote_parse_stop_reply): Use
9975         unique_xmalloc_ptr.
9976
9977 2019-03-06  Tom Tromey  <tom@tromey.com>
9978
9979         * stabsread.c (struct stabs_field_info): Rename from field_info.
9980         <list, fnlist>: Add initializers.
9981         <obstack>: New member.
9982         (read_member_functions, read_struct_fields, read_baseclasses):
9983         Allocate on obstack.  Don't use cleanups.
9984         (read_one_struct_field, read_member_functions, read_struct_fields)
9985         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9986         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9987         (read_struct_type): Update.
9988
9989 2019-03-06  Tom Tromey  <tom@tromey.com>
9990
9991         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9992         * common/filestuff.h (make_cleanup_close): Don't declare.
9993         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9994         Remove.
9995
9996 2019-03-06  Tom Tromey  <tom@tromey.com>
9997
9998         * solib-aix.c: Use make_scope_exit.
9999
10000 2019-03-06  Tom Tromey  <tom@tromey.com>
10001
10002         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10003         Use make_scope_exit.
10004
10005 2019-03-06  Tom Tromey  <tom@tromey.com>
10006
10007         * solib-svr4.c (disable_probes_interface): Remove parameter.
10008         (svr4_handle_solib_event): Use make_scope_exit.
10009
10010 2019-03-06  Tom Tromey  <tom@tromey.com>
10011
10012         * remote.c (struct stop_reply_deleter): Remove.
10013         (stop_reply_up): Update.
10014         (struct stop_reply): Derive from notif_event.  Don't typedef.
10015         <regcache>: Now a std::vector.
10016         (stop_reply_xfree): Remove.
10017         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10018         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10019         (remote_target::discard_pending_stop_replies): Use delete.
10020         (remote_target::remote_parse_stop_reply): Update.
10021         (remote_target::process_stop_reply): Update.
10022         * remote-notif.h (struct notif_event): Add virtual destructor.
10023         Remove "dtr" member.
10024         (struct notif_client) <alloc_event>: Return a unique_ptr.
10025         (notif_event_xfree): Don't declare.
10026         (notif_event_up): New typedef.
10027         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10028         (notif_event_xfree, do_notif_event_xfree): Remove.
10029         (remote_notif_state_xfree): Update.
10030
10031 2019-03-06  Tom Tromey  <tom@tromey.com>
10032
10033         * infrun.c (displaced_step_clear_cleanup): Now a
10034         forward_scope_exit type.
10035         (displaced_step_prepare_throw): Update.
10036         (displaced_step_fixup): Update.
10037
10038 2019-03-06  Tom Tromey  <tom@tromey.com>
10039
10040         * inferior.h (class inferior): Update comment.
10041         * gdbthread.h (class thread_info): Update comment.
10042
10043 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10044             Tom Tromey  <tom@tromey.com>
10045
10046         * stabsread.h (struct stab_section_list): Remove.
10047         (coffstab_build_psymtabs): Update.
10048         * dbxread.c (symbuf_sections): Now a std::vector.
10049         (sect_idx): New global.
10050         (fill_symbuf): Update.
10051         (coffstab_build_psymtabs): Change type of stabsects parameter.
10052         Update.
10053         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10054         std::vector.
10055         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10056         (coff_locate_sections): Update.
10057         (coff_symfile_read): Remove cleanups.  Update.
10058         (init_stringtab): Add storage parameter.
10059         (free_stringtab, free_stringtab_cleanup): Remove.
10060         (init_lineno): Add storage parameter.
10061         (free_linetab, free_linetab_cleanup): Remove.
10062
10063 2019-03-06  Pedro Alves  <palves@redhat.com>
10064
10065         * linux-fork.c (fork_info::clobber_regs): Delete.
10066         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10067         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10068         comment.  Adjust.
10069         (scoped_switch_fork_info::scoped_switch_fork_info)
10070         (checkpoint_command, linux_fork_context): Adjust
10071         fork_save_infrun_state calls.
10072
10073 2019-03-06  Pedro Alves  <palves@redhat.com>
10074
10075         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10076         (inf_has_multiple_threads): Return 'bool' and rewrite using
10077         inferior_info::threads().
10078
10079 2019-03-06  Pedro Alves  <palves@redhat.com>
10080
10081         * linux-fork.c: Include <list>.
10082         (fork_list): Now a std::list instance.
10083         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10084         (forks_exist_p, find_last_fork): Adjust.
10085         (new_fork): Delete.
10086         (one_fork_p): New.
10087         (add_fork): Adjust.
10088         (free_fork): Delete, folded into fork_info::~fork_info().
10089         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10090         Adjust.
10091         (init_fork_list): Delete.
10092         (linux_fork_killall, linux_fork_mourn_inferior)
10093         (linux_fork_detach, info_checkpoints_command): Adjust.
10094         (_initialize_linux_fork): No longer call init_fork_list.
10095
10096 2019-03-06  Pedro Alves  <palves@redhat.com>
10097
10098         * linux-fork.c (new_fork): New, split out of ...
10099         (add_fork): ... this.  Return void.  Move "first fork" special
10100         case from here, to ...
10101         (checkpoint_command): ... here.
10102         * linux-linux.h (add_fork): Return void.
10103
10104 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10105
10106         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10107
10108 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10109             Chris January  <chris.january@arm.com>
10110             David Lecomber  <david.lecomber@arm.com>
10111
10112         * f-exp.y: New token, UNOP_INTRINSIC.
10113         (exp): New pattern using UNOP_INTRINSIC token.
10114         (f77_keywords): Add 'abs' keyword.
10115         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10116         (value_from_host_double): New function.
10117         (evaluate_subexp_f): Support UNOP_ABS.
10118
10119 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10120
10121         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10122         types.
10123
10124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10125
10126         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10127         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10128         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10129
10130 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10131
10132         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10133
10134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10135             Chris January  <chris.january@arm.com>
10136
10137         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10138         * f-exp.y: Define 'KIND' token.
10139         (exp): New pattern for KIND expressions.
10140         (ptype): Handle types with a kind extension.
10141         (direct_abs_decl): Extend to spot kind extensions.
10142         (f77_keywords): Add 'kind' to the list.
10143         (push_kind_type): New function.
10144         (convert_to_kind_type): New function.
10145         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10146         * parse.c (operator_length_standard): Likewise.
10147         * parser-defs.h (enum type_pieces): Add tp_kind.
10148         * std-operator.def: Add UNOP_KIND.
10149
10150 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * f-exp.y (f_parse): Set yydebug.
10153
10154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10155
10156         * f-lang.c (evaluate_subexp_f): New function.
10157         (exp_descriptor_f): New global.
10158         (f_language_defn): Use exp_descriptor_f instead of
10159         exp_descriptor_standard.
10160
10161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10162
10163         * f-exp.y (struct token): Add comments.
10164         (dot_ops): Remove uppercase versions and the end marker.
10165         (f77_keywords): Likewise.
10166         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10167         entries in the dot_ops array are case insensitive, and use
10168         strncasecmp to compare strings.  Also some whitespace cleanup in
10169         this area.  Similar for the f77_keywords array, except entries in
10170         this list might be case sensitive.
10171
10172 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10173
10174         * f-exp.y (struct f77_boolean_val): Add comments.
10175         (boolean_values): Remove uppercase versions, and end marker.
10176         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10177         and use strncasecmp to achieve case insensitivity.  Additionally,
10178         perform whitespace cleanup around this code.
10179
10180 2019-03-06  Tom Tromey  <tromey@adacore.com>
10181
10182         * remote-sim.c (gdbsim_target_open): Use result of
10183         gdb_argv::release.
10184
10185 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10186         Dirk Schubert  <dirk.schubert@arm.com>
10187         Chris January  <chris.january@arm.com>
10188
10189         * eval.c (evaluate_subexp_standard): Call Fortran argument
10190         wrapping logic.
10191         * f-lang.c (struct value): A value which can be passed into a
10192         Fortran function call.
10193         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10194         where appropriate.
10195         (struct type): Value ready for a Fortran function call.
10196         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10197         is needed.
10198         * f-lang.h (fortran_argument_convert): Declaration.
10199         (fortran_preserve_arg_pointer): Declaration.
10200         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10201
10202 2019-03-05  Tom Tromey  <tromey@adacore.com>
10203
10204         * python/py-prettyprint.c (print_string_repr): Remove #if.
10205         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10206
10207 2019-03-05  Tom Tromey  <tromey@adacore.com>
10208
10209         * target.c (the_dummy_target): Move later.  Change type to
10210         "dummy_target".
10211         (initialize_targets): Don't initialize the_dummy_target.
10212
10213 2019-03-05  Tom Tromey  <tromey@adacore.com>
10214
10215         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10216         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10217
10218 2019-03-05  Tom Tromey  <tromey@adacore.com>
10219
10220         * windows-nat.c (windows_nat_target::attach)
10221         (windows_nat_target::detach): Don't call gdb_flush.
10222         * valprint.c (generic_val_print, val_print, val_print_string):
10223         Don't call gdb_flush.
10224         * utils.c (defaulted_query): Don't call gdb_flush.
10225         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10226         * target.c (target_announce_detach): Don't call gdb_flush.
10227         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10228         * remote.c (extended_remote_target::attach): Don't call
10229         gdb_flush.
10230         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10231         * printcmd.c (do_examine): Don't call gdb_flush.
10232         (info_display_command): Don't call gdb_flush.
10233         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10234         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10235         * memattr.c (info_mem_command): Don't call gdb_flush.
10236         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10237         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10238         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10239         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10240         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10241         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10242         (gnu_nat_target::detach): Don't call gdb_flush.
10243         * f-valprint.c (f_val_print): Don't call gdb_flush.
10244         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10245         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10246         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10247         gdb_flush.
10248         * c-valprint.c (c_val_print): Don't call gdb_flush.
10249         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10250
10251 2019-03-05  Tom Tromey  <tromey@adacore.com>
10252
10253         * varobj.c (update_dynamic_varobj_children): Update.
10254         (install_default_visualizer): Use reset, not release.
10255         * value.c (set_internalvar): Update.
10256         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10257         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10258         ATTRIBUTE_UNUSED_RESULT.
10259
10260 2019-03-05  Tom Tromey  <tromey@adacore.com>
10261
10262         * remote.c (class scoped_remote_fd) <release>: Add
10263         ATTRIBUTE_UNUSED_RESULT.
10264
10265 2019-03-05  Tom Tromey  <tromey@adacore.com>
10266
10267         * macroexp.c (struct macro_buffer) <release>: Add
10268         ATTRIBUTE_UNUSED_RESULT.
10269
10270 2019-03-05  Tom Tromey  <tromey@adacore.com>
10271
10272         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10273         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10274         ATTRIBUTE_UNUSED_RESULT.
10275
10276 2019-03-05  Tom Tromey  <tromey@adacore.com>
10277
10278         * common/scoped_fd.h (class scoped_fd) <release>: Add
10279         ATTRIBUTE_UNUSED_RESULT.
10280
10281 2019-03-05  Tom Tromey  <tromey@adacore.com>
10282
10283         * parser-defs.h (struct parser_state) <release>: Add
10284         ATTRIBUTE_UNUSED_RESULT.
10285
10286 2019-03-05  Tom Tromey  <tromey@adacore.com>
10287
10288         * utils.h (class gdb_argv) <release>: Add
10289         ATTRIBUTE_UNUSED_RESULT.
10290         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10291
10292 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10293
10294         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10295         for-loop range, to avoid compiler warnings.
10296
10297         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10298         avoid compiler warnings about unused variables.
10299
10300         * NEWS: Mention end of support for native debugging on MS-Windows
10301         before XP.
10302
10303         PR gdb/24292
10304         * common/netstuff.c:
10305         * gdbserver/gdbreplay.c
10306         * gdbserver/remote-utils.c:
10307         * ser-tcp.c:
10308         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10309         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10310         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10311         'getaddrinfo' and 'freeaddrinfo' were not available before
10312         Windows XP, and mingw.org's MinGW headers by default define
10313         _WIN32_WINNT to 0x500.
10314
10315 2019-03-01  Gary Benson <gbenson@redhat.com>
10316
10317         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10318
10319 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10320             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10321
10322         PR gdb/8527
10323         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10324         set_sigint_trap, clear_sigint_trap.
10325
10326 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10327
10328         * target.c (target_detach): Clear the regcache and the
10329         frame cache.
10330
10331 2019-02-27  Pedro Alves  <palves@redhat.com>
10332
10333         * utils.c (set_screen_size): When we cap the height/width sizes,
10334         tweak the corresponding command variable to show "unlimited":
10335
10336 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10337             Pedro Alves  <palves@redhat.com>
10338
10339         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10340         before calling rl_set_screen_size.
10341
10342 2019-02-27  Tom Tromey  <tromey@adacore.com>
10343
10344         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10345         define.
10346         * python/py-value.c: Remove Python 2.4 workaround.
10347         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10348         workaround.
10349         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10350         Python 2.4 workaround.
10351         * python/python-internal.h: Remove Python 2.4 comment.
10352         (Py_ssize_t): Don't define.
10353         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10354         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10355         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10356         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10357         * python/python.c (do_start_initialization): Remove Python 2.4
10358         workaround.
10359         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10360         (print_children): Remove Python 2.4 workaround.
10361         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10362         workaround.
10363         (CHARBUFFERPROC_NAME): Remove.
10364         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10365         Python 2.4 workaround.
10366
10367 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10368
10369         * NEWS: Note minimum Python version.
10370
10371 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10372
10373         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10374         code from these functions.  Remove corresponding ifdefs.  Use
10375         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10376         Remove gotos and target of gotos.
10377         (infpy_search_memory): Likewise.
10378
10379 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10380
10381         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10382         (hppa_gdbarch_init): Don't register deleted functions with
10383         gdbarch.
10384
10385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10386
10387         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10388         (h8300_unwind_sp): Delete.
10389         (h8300_dummy_id): Delete.
10390         (h8300_gdbarch_init): Don't register deleted functions with
10391         gdbarch.
10392
10393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10394
10395         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10396         (ft32_unwind_pc): Delete.
10397         (ft32_unwind_sp): Delete.
10398         (ft32_gdbarch_init): Don't register deleted functions with
10399         gdbarch.
10400
10401 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10402
10403         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10404         (frv_unwind_pc): Delete.
10405         (frv_unwind_sp): Delete.
10406         (frv_gdbarch_init): Don't register deleted functions with
10407         gdbarch.
10408
10409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10412         (riscv_unwind_pc): Delete.
10413         (riscv_unwind_sp): Delete.
10414         (riscv_gdbarch_init): Don't register deleted functions with
10415         gdbarch.
10416
10417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10420         (csky_unwind_pc): Delete.
10421         (csky_unwind_sp): Delete.
10422         (csky_gdbarch_init): Don't register deleted functions with
10423         gdbarch.
10424
10425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10428         (cris_unwind_pc): Delete.
10429         (cris_unwind_sp): Delete.
10430         (cris_gdbarch_init): Don't register deleted functions with
10431         gdbarch.
10432
10433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10434
10435         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10436         (bfin_unwind_pc): Delete.
10437         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10438
10439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10440
10441         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10442         (arm_unwind_pc): Delete.
10443         (arm_unwind_sp): Delete.
10444         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10445
10446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10449         (arc_unwind_pc): Delete.
10450         (arc_unwind_sp): Delete.
10451         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10452
10453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10454
10455         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10456         (alpha_unwind_pc): Delete.
10457         (alpha_gdbarch_init): Don't register deleted functions with
10458         gdbarch.
10459
10460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10461
10462         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10463         (aarch64_unwind_pc): Delete.
10464         (aarch64_unwind_sp): Delete.
10465         (aarch64_gdbarch_init): Don't register deleted functions with
10466         gdbarch.
10467
10468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10469
10470         * gdbtypes.c (type_align): Don't consider static members when
10471         computing structure alignment.
10472
10473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10474
10475         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10476         return 0 for other types.
10477         * arch-utils.c (default_type_align): Always return 0.
10478         * gdbarch.h: Regenerate.
10479         * gdbarch.sh (type_align): Extend comment.
10480         * gdbtypes.c (type_align): Add additional comments, always call
10481         gdbarch_type_align before applying the default rules.
10482         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10483         generic code will then apply a suitable default.
10484         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10485         types, return 0 for other types.
10486
10487 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10488
10489         * NEWS: Create a new section for the next release branch.
10490         Rename the section of the current branch, now that it has
10491         been cut.
10492
10493 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10494
10495         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10496         * version.in: Bump version to 8.3.50.DATE-git.
10497
10498 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10499
10500         * aix-thread.c (ptid_cmp): Remove unused variable.
10501         (get_signaled_thread): Likewise.
10502         (store_regs_user_thread): Likewise.
10503         (store_regs_kernel_thread): Likewise.
10504         (fetch_regs_kernel_thread): Remove shadowed variable.
10505
10506 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10507
10508         * features/riscv/32bit-cpu.xml: Add register numbers.
10509         * features/riscv/32bit-fpu.c: Regenerate.
10510         * features/riscv/32bit-fpu.xml: Add register numbers.
10511         * features/riscv/64bit-cpu.xml: Add register numbers.
10512         * features/riscv/64bit-fpu.c: Regenerate.
10513         * features/riscv/64bit-fpu.xml: Add register numbers.
10514
10515 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10516
10517         * NEWS: Mention two argument form of gdb.Value constructor.
10518         * python/py-value.c (convert_buffer_and_type_to_value): New
10519         function.
10520         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10521         Add support for handling an optional second argument.  Call
10522         convert_buffer_and_type_to_value as appropriate.
10523         * python/python-internal.h (Py_buffer_deleter): New struct.
10524         (Py_buffer_up): New typedef.
10525
10526 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10527
10528         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10529         instead of releasing ownership.
10530
10531 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10532
10533         * dwarf2read.c (open_and_init_dwp_file): Call
10534         elf_numsections instead of bfd_count_sections to initialize
10535         dwp_file->num_sections.
10536
10537 2019-02-25  Tom Tromey  <tromey@adacore.com>
10538
10539         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10540
10541 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10542
10543         * gcore.in: Add '--readnever' option when invoking GDB.
10544
10545 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10546
10547         * MAINTAINERS: Update my email address.
10548
10549 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10550
10551         * build-id.c (build_id_to_debug_bfd_1): New function.
10552         (build_id_to_debug_bfd): Look for separate debug file in
10553         sysroot.
10554
10555 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * gdbarch.sh: Update the copyright year range that is placed into
10558         generated files.
10559
10560 2019-02-22  Keith Seitz  <keiths@redhat.com>
10561
10562         PR symtab/23853
10563         * linespec.c (create_sals_line_offset): Search for the default
10564         symtab's filename instead of its fullname.
10565
10566 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10567
10568         * NEWS: Update style defaults.
10569
10570 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10571
10572         * main.c (captured_main_1): Disable styling in batch mode.
10573
10574 2019-02-20  Tom Tromey  <tom@tromey.com>
10575
10576         * symtab.c (symtab_symbol_info): Fix typos.
10577
10578 2019-02-20  Tom Tromey  <tromey@adacore.com>
10579
10580         * findcmd.c (_initialize_mem_search): Use upper case for
10581         metasyntactic variables.
10582
10583 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10584
10585         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10586         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10587
10588 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10589
10590         * top.h (source_file_name): Change to std::string.
10591         * top.c (source_file_name): Likewise.
10592         (command_line_input): Adjust.
10593         * cli/cli-script.c (script_from_file): Adjust.
10594
10595 2019-02-19  Tom Tromey  <tromey@adacore.com>
10596
10597         * ravenscar-thread.c
10598         (ravenscar_thread_target::update_thread_list): Don't call
10599         ada_build_task_list.
10600         * ada-lang.h (ada_build_task_list): Don't declare.
10601         * ada-tasks.c (struct ada_tasks_inferior_data)
10602         <task_list_valid_p>: Now bool.
10603         (read_known_tasks, ada_task_list_changed)
10604         (ada_tasks_invalidate_inferior_data): Update.
10605         (read_known_tasks_array): Return bool.
10606         (read_known_tasks_list): Likewise.
10607         (read_known_tasks): Return void.
10608         (ada_build_task_list): Now static.
10609
10610 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10611
10612         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10613         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10614
10615 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10616
10617         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10618         variant for ada_tasks_pspace_data_handle and
10619         ada_tasks_inferior_data_handle.
10620         (ada_tasks_pspace_data_cleanup): New function.
10621         (ada_tasks_inferior_data_cleanup): New function.
10622
10623 2019-02-17  Tom Tromey  <tom@tromey.com>
10624
10625         * macrotab.h (macro_source_fullname): Return a std::string.
10626         * macrotab.c (macro_include, check_for_redefinition)
10627         (macro_undef, macro_lookup_definition, foreach_macro)
10628         (foreach_macro_in_scope): Update.
10629         (macro_source_fullname): Return a std::string.
10630         * macrocmd.c (show_pp_source_pos): Update.
10631
10632 2019-02-17  Tom Tromey  <tom@tromey.com>
10633
10634         * macrocmd.c (show_pp_source_pos): Style the file names.
10635
10636 2019-02-17  Tom Tromey  <tom@tromey.com>
10637
10638         PR tui/24197:
10639         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10640
10641 2019-02-17  Tom Tromey  <tom@tromey.com>
10642
10643         * ada-lang.c (user_select_syms): Use filtered printing.
10644         * utils.c (wrap_style): New global.
10645         (desired_style): Remove.
10646         (emit_style_escape): Add stream parameter.
10647         (set_output_style, reset_terminal_style, prompt_for_continue):
10648         Update.
10649         (flush_wrap_buffer): Only flush gdb_stdout.
10650         (wrap_here): Set wrap_style.
10651         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10652         treat escape sequences as a character.  Change when wrap buffer is
10653         flushed.
10654         (fputs_styled): Do not set the output style when the default is
10655         requested.
10656         * ui-style.h (struct ui_file_style) <is_default>: New method.
10657         * source.c (print_source_lines_base): Emit escape sequences in one
10658         piece.
10659
10660 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10661
10662         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10663         integers and enumeration types.
10664
10665 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10666
10667         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10668         instead of lookup_symbol_in_language
10669         (do_exact_match): New function.
10670         (ada_get_symbol_name_matcher): Return do_exact_match when
10671         doing a verbatim match.
10672
10673 2019-02-15  Tom Tromey  <tromey@adacore.com>
10674
10675         * ravenscar-thread.c (ravenscar_thread_target::resume)
10676         (ravenscar_thread_target::wait): Special case wildcard requests.
10677
10678 2019-02-15  Tom Tromey  <tromey@adacore.com>
10679
10680         * ravenscar-thread.c (base_ptid): Remove.
10681         (struct ravenscar_thread_target) <close>: New method.
10682         <m_base_ptid>: New member.
10683         <update_inferior_ptid, active_task, task_is_currently_active,
10684         runtime_initialized>: Declare methods.
10685         <ravenscar_thread_target>: Add constructor.
10686         (ravenscar_thread_target::task_is_currently_active)
10687         (ravenscar_thread_target::update_inferior_ptid)
10688         (ravenscar_runtime_initialized): Rename.  Now methods.
10689         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10690         (ravenscar_thread_target::update_thread_list): Update.
10691         (ravenscar_thread_target::active_task): Now method.
10692         (ravenscar_thread_target::store_registers)
10693         (ravenscar_thread_target::prepare_to_store)
10694         (ravenscar_thread_target::prepare_to_store)
10695         (ravenscar_thread_target::mourn_inferior): Update.
10696         (ravenscar_inferior_created): Use "new" to create target.
10697         (ravenscar_thread_target::get_ada_task_ptid): Update.
10698         (_initialize_ravenscar): Don't initialize base_ptid.
10699         (ravenscar_ops): Remove global.
10700
10701 2019-02-15  Tom Tromey  <tromey@adacore.com>
10702
10703         * target.h (push_target): Declare new overload.
10704         * target.c (push_target): New overload, taking an rvalue reference.
10705         * remote.c (remote_target::open_1): Use push_target overload.
10706         * corelow.c (core_target_open): Use push_target overload.
10707
10708 2019-02-15  Tom Tromey  <tromey@adacore.com>
10709
10710         * ravenscar-thread.c (is_ravenscar_task)
10711         (ravenscar_task_is_currently_active): Return bool.
10712         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10713         (_initialize_ravenscar): Remove "(void)".
10714         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10715         Return bool.
10716
10717 2019-02-15  Tom Tromey  <tromey@adacore.com>
10718
10719         * ravenscar-thread.c (ravenscar_runtime_initializer)
10720         (has_ravenscar_runtime, get_running_thread_id)
10721         (ravenscar_thread_target::resume): Fix indentation.
10722
10723 2019-02-15  Tom Tromey  <tromey@adacore.com>
10724
10725         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10726         from ravenscar_arch_ops.
10727         (sparc_ravenscar_ops::fetch_registers)
10728         (sparc_ravenscar_ops::store_registers): Now methods.
10729         (sparc_ravenscar_prepare_to_store): Remove.
10730         (sparc_ravenscar_ops): Redefine.
10731         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10732         methods and destructor.  Remove members.
10733         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10734         (ravenscar_thread_target::store_registers)
10735         (ravenscar_thread_target::prepare_to_store): Update.
10736         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10737         Remove.
10738         (struct ppc_ravenscar_powerpc_ops): Derive from
10739         ravenscar_arch_ops.
10740         (ppc_ravenscar_powerpc_ops::fetch_registers)
10741         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10742         (ppc_ravenscar_powerpc_ops): Redefine.
10743         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10744         (ppc_ravenscar_e500_ops::fetch_registers)
10745         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10746         (ppc_ravenscar_e500_ops): Redefine.
10747         * aarch64-ravenscar-thread.c
10748         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10749         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10750         (aarch64_ravenscar_fetch_registers)
10751         (aarch64_ravenscar_store_registers): Now methods.
10752         (aarch64_ravenscar_ops): Redefine.
10753
10754 2019-02-15  Tom Tromey  <tromey@adacore.com>
10755
10756         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10757         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10758         (ravenscar_thread_target::stopped_by_watchpoint)
10759         (ravenscar_thread_target::stopped_data_address)
10760         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10761
10762 2019-02-15  Tom Tromey  <tromey@adacore.com>
10763
10764         * ravenscar-thread.c: Fix some typos.
10765
10766 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10767             Tom Tromey  <tromey@adacore.com>
10768
10769         * ada-lang.c (ada_exception_sal): Change addr_string to a
10770         std::string.
10771         (create_ada_exception_catchpoint): Update.
10772
10773 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10774             Tom Tromey  <tromey@adacore.com>
10775
10776         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10777         (bp_location_ops): Remove.
10778         (base_breakpoint_allocate_location): Update.
10779         (free_bp_location): Update.
10780         * ada-lang.c (class ada_catchpoint_location)
10781         <ada_catchpoint_location>: Remove ops parameter.
10782         (ada_catchpoint_location_dtor): Remove.
10783         (ada_catchpoint_location_ops): Remove.
10784         (allocate_location_exception): Update.
10785         * breakpoint.h (struct bp_location_ops): Remove.
10786         (class bp_location) <bp_location>: Remove bp_location_ops
10787         parameter.
10788         <~bp_location>: Add destructor.
10789         <ops>: Remove.
10790
10791 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10792             Pedro Alves  <palves@redhat.com>
10793
10794         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10795         'PATH_MAX'.
10796
10797 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10798             Samuel Thibault  <samuel.thibault@gnu.org>
10799             Thomas Schwinge  <thomas@codesourcery.com>
10800
10801         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10802         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10803
10804 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10805
10806         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10807         (check_empty): Use "const char *".
10808
10809         * gnu-nat.c (gnu_nat_target::detach): Instead of
10810         'detach_inferior (pid)' call
10811         'detach_inferior (find_inferior_pid (pid))'.
10812
10813         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10814         'nat/fork-inferior.o'.
10815         * gnu-nat.c: #include "nat/fork-inferior.h".
10816
10817         * gnu-nat.c (gnu_nat_target::detach): Instead of
10818         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10819         * gnu-nat.h: #include "inf-child.h".
10820         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10821         'i386_gnu_nat_target::fetch_registers'.
10822         (gnu_store_registers): Rename/move to
10823         'i386_gnu_nat_target::store_registers'.
10824
10825         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10826         * gnu-nat.h (mach_thread_info): New function.
10827         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10828
10829         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10830
10831 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10832
10833         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10834
10835 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10836
10837         * windows-nat.c (windows_add_thread): Add new parameter
10838         "main_thread_p" with default value set to false.  Update
10839         function documentation as well as all callers.
10840         (windows_delete_thread): Likewise.
10841         (fake_create_process): Update call to windows_add_thread.
10842         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10843         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10844         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10845         call to windows_delete_thread.
10846
10847 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10848
10849         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10850
10851 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10852
10853         * symfile.c (find_separate_debug_file): Use canonical path of
10854         sysroot with child_path instead of gdb_sysroot if it is valid.
10855
10856 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10857
10858         * symfile.c (find_separate_debug_file): Use child_path to
10859         determine if an object file is under a sysroot.
10860
10861 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10862
10863         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10864         unittests/child-path-selftests.c.
10865         * common/pathstuff.c (child_path): New function.
10866         * common/pathstuff.h (child_path): New prototype.
10867         * unittests/child-path-selftests.c: New file.
10868
10869 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10870
10871         * symfile.c (find_separate_debug_file): Look for separate debug
10872         files in debug directories under the sysroot.
10873
10874 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10875
10876         * symtab.h (struct minimal_symbol data_p): New const method.
10877         (struct minimal_symbol text_p): Likewise.
10878         * symtab.c (output_source_filename): Use file name style
10879         to print file name.
10880         (print_symbol_info): Likewise.
10881         (print_msymbol_info): Use address style to print addresses.
10882         Use function name style to print executable text symbols.
10883         (expand_symtab_containing_pc): Use data_p.
10884         (find_pc_sect_compunit_symtab): Likewise.
10885
10886 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10887
10888         * breakpoint.c (describe_other_breakpoints): Use address style
10889         to print addresses.
10890         (say_where): Likewise.
10891
10892 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10893
10894         * ada-typeprint.c (print_func_type): Print function name
10895         style to print function name.
10896         * c-typeprint.c (c_print_type_1): Likewise.
10897
10898 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10899
10900         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10901         for execve.
10902
10903 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10904
10905         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10906         type_stack.
10907
10908 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10909
10910         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10911         TYPE_CODE_REF types.
10912
10913 2019-02-08  Jim Wilson  <jimw@sifive.com>
10914
10915         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10916         (riscv_linux_fregset): New.
10917         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10918
10919 2019-02-07  Tom Tromey  <tom@tromey.com>
10920
10921         * thread.c (thread_cancel_execution_command): Update.
10922         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10923         methods.
10924         (struct thread_fsm_ops): Remove.
10925         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10926         (thread_fsm_should_stop, thread_fsm_return_value)
10927         (thread_fsm_set_finished, thread_fsm_finished_p)
10928         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10929         Don't declare.
10930         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10931         * infrun.c (clear_proceed_status_thread)
10932         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10933         (print_stop_event): Update.
10934         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10935         Add constructor.
10936         (step_command_fsm_ops): Remove.
10937         (new_step_command_fsm): Remove.
10938         (step_1): Update.
10939         (step_command_fsm::should_stop): Rename from
10940         step_command_fsm_should_stop.
10941         (step_command_fsm::clean_up): Rename from
10942         step_command_fsm_clean_up.
10943         (step_command_fsm::do_async_reply_reason): Rename from
10944         step_command_fsm_async_reply_reason.
10945         (struct until_next_fsm): Inherit from thread_fsm.  Add
10946         constructor.
10947         (until_next_fsm_ops): Remove.
10948         (new_until_next_fsm): Remove.
10949         (until_next_fsm::should_stop): Rename from
10950         until_next_fsm_should_stop.
10951         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10952         (until_next_fsm::do_async_reply_reason): Rename from
10953         until_next_fsm_async_reply_reason.
10954         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10955         constructor.  Change type of breakpoint.
10956         (finish_command_fsm_ops): Remove.
10957         (new_finish_command_fsm): Remove.
10958         (finish_command_fsm::should_stop): Rename from
10959         finish_command_fsm_should_stop.
10960         (finish_command_fsm::clean_up): Rename from
10961         finish_command_fsm_clean_up.
10962         (finish_command_fsm::return_value): Rename from
10963         finish_command_fsm_return_value.
10964         (finish_command_fsm::do_async_reply_reason): Rename from
10965         finish_command_fsm_async_reply_reason.
10966         (finish_command): Update.
10967         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10968         Add constructor.
10969         (call_thread_fsm_ops): Remove.
10970         (call_thread_fsm::call_thread_fsm): Rename from
10971         new_call_thread_fsm.
10972         (call_thread_fsm::should_stop): Rename from
10973         call_thread_fsm_should_stop.
10974         (call_thread_fsm::should_notify_stop): Rename from
10975         call_thread_fsm_should_notify_stop.
10976         (run_inferior_call, call_function_by_hand_dummy): Update.
10977         * cli/cli-interp.c (should_print_stop_to_console): Update.
10978         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10979         Add constructor.  Change type of location_breakpoint,
10980         caller_breakpoint.
10981         (until_break_fsm_ops): Remove.
10982         (new_until_break_fsm): Remove.
10983         (until_break_fsm::should_stop): Rename from
10984         until_break_fsm_should_stop.
10985         (until_break_fsm::clean_up): Rename from
10986         until_break_fsm_clean_up.
10987         (until_break_fsm::do_async_reply_reason): Rename from
10988         until_break_fsm_async_reply_reason.
10989         (until_break_command): Update.
10990         * thread-fsm.c: Remove.
10991         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10992
10993 2019-02-07  Tom Tromey  <tom@tromey.com>
10994
10995         * yy-remap.h: Add include guard.
10996         * xtensa-tdep.h: Add include guard.
10997         * xcoffread.h: Rename include guard.
10998         * varobj-iter.h: Add include guard.
10999         * tui/tui.h: Rename include guard.
11000         * tui/tui-winsource.h: Rename include guard.
11001         * tui/tui-wingeneral.h: Rename include guard.
11002         * tui/tui-windata.h: Rename include guard.
11003         * tui/tui-win.h: Rename include guard.
11004         * tui/tui-stack.h: Rename include guard.
11005         * tui/tui-source.h: Rename include guard.
11006         * tui/tui-regs.h: Rename include guard.
11007         * tui/tui-out.h: Rename include guard.
11008         * tui/tui-layout.h: Rename include guard.
11009         * tui/tui-io.h: Rename include guard.
11010         * tui/tui-hooks.h: Rename include guard.
11011         * tui/tui-file.h: Rename include guard.
11012         * tui/tui-disasm.h: Rename include guard.
11013         * tui/tui-data.h: Rename include guard.
11014         * tui/tui-command.h: Rename include guard.
11015         * tic6x-tdep.h: Add include guard.
11016         * target/waitstatus.h: Rename include guard.
11017         * target/wait.h: Rename include guard.
11018         * target/target.h: Rename include guard.
11019         * target/resume.h: Rename include guard.
11020         * target-float.h: Rename include guard.
11021         * stabsread.h: Add include guard.
11022         * rs6000-tdep.h: Add include guard.
11023         * riscv-fbsd-tdep.h: Add include guard.
11024         * regformats/regdef.h: Rename include guard.
11025         * record.h: Rename include guard.
11026         * python/python.h: Rename include guard.
11027         * python/python-internal.h: Rename include guard.
11028         * python/py-stopevent.h: Rename include guard.
11029         * python/py-ref.h: Rename include guard.
11030         * python/py-record.h: Rename include guard.
11031         * python/py-record-full.h: Rename include guard.
11032         * python/py-record-btrace.h: Rename include guard.
11033         * python/py-instruction.h: Rename include guard.
11034         * python/py-events.h: Rename include guard.
11035         * python/py-event.h: Rename include guard.
11036         * procfs.h: Add include guard.
11037         * proc-utils.h: Add include guard.
11038         * p-lang.h: Add include guard.
11039         * or1k-tdep.h: Rename include guard.
11040         * observable.h: Rename include guard.
11041         * nto-tdep.h: Rename include guard.
11042         * nat/x86-linux.h: Rename include guard.
11043         * nat/x86-linux-dregs.h: Rename include guard.
11044         * nat/x86-gcc-cpuid.h: Add include guard.
11045         * nat/x86-dregs.h: Rename include guard.
11046         * nat/x86-cpuid.h: Rename include guard.
11047         * nat/ppc-linux.h: Rename include guard.
11048         * nat/mips-linux-watch.h: Rename include guard.
11049         * nat/linux-waitpid.h: Rename include guard.
11050         * nat/linux-ptrace.h: Rename include guard.
11051         * nat/linux-procfs.h: Rename include guard.
11052         * nat/linux-osdata.h: Rename include guard.
11053         * nat/linux-nat.h: Rename include guard.
11054         * nat/linux-namespaces.h: Rename include guard.
11055         * nat/linux-btrace.h: Rename include guard.
11056         * nat/glibc_thread_db.h: Rename include guard.
11057         * nat/gdb_thread_db.h: Rename include guard.
11058         * nat/gdb_ptrace.h: Rename include guard.
11059         * nat/fork-inferior.h: Rename include guard.
11060         * nat/amd64-linux-siginfo.h: Rename include guard.
11061         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11062         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11063         * nat/aarch64-linux.h: Rename include guard.
11064         * nat/aarch64-linux-hw-point.h: Rename include guard.
11065         * mn10300-tdep.h: Add include guard.
11066         * mips-linux-tdep.h: Add include guard.
11067         * mi/mi-parse.h: Rename include guard.
11068         * mi/mi-out.h: Rename include guard.
11069         * mi/mi-main.h: Rename include guard.
11070         * mi/mi-interp.h: Rename include guard.
11071         * mi/mi-getopt.h: Rename include guard.
11072         * mi/mi-console.h: Rename include guard.
11073         * mi/mi-common.h: Rename include guard.
11074         * mi/mi-cmds.h: Rename include guard.
11075         * mi/mi-cmd-break.h: Rename include guard.
11076         * m2-lang.h: Add include guard.
11077         * location.h: Rename include guard.
11078         * linux-record.h: Rename include guard.
11079         * linux-nat.h: Add include guard.
11080         * linux-fork.h: Add include guard.
11081         * i386-darwin-tdep.h: Rename include guard.
11082         * hppa-linux-offsets.h: Add include guard.
11083         * guile/guile.h: Rename include guard.
11084         * guile/guile-internal.h: Rename include guard.
11085         * gnu-nat.h: Rename include guard.
11086         * gdb-stabs.h: Rename include guard.
11087         * frv-tdep.h: Add include guard.
11088         * f-lang.h: Add include guard.
11089         * event-loop.h: Add include guard.
11090         * darwin-nat.h: Rename include guard.
11091         * cp-abi.h: Rename include guard.
11092         * config/sparc/nm-sol2.h: Rename include guard.
11093         * config/nm-nto.h: Rename include guard.
11094         * config/nm-linux.h: Add include guard.
11095         * config/i386/nm-i386gnu.h: Rename include guard.
11096         * config/djgpp/nl_types.h: Rename include guard.
11097         * config/djgpp/langinfo.h: Rename include guard.
11098         * compile/gcc-cp-plugin.h: Add include guard.
11099         * compile/gcc-c-plugin.h: Add include guard.
11100         * compile/compile.h: Rename include guard.
11101         * compile/compile-object-run.h: Rename include guard.
11102         * compile/compile-object-load.h: Rename include guard.
11103         * compile/compile-internal.h: Rename include guard.
11104         * compile/compile-cplus.h: Rename include guard.
11105         * compile/compile-c.h: Rename include guard.
11106         * common/xml-utils.h: Rename include guard.
11107         * common/x86-xstate.h: Rename include guard.
11108         * common/version.h: Rename include guard.
11109         * common/vec.h: Rename include guard.
11110         * common/tdesc.h: Rename include guard.
11111         * common/selftest.h: Rename include guard.
11112         * common/scoped_restore.h: Rename include guard.
11113         * common/scoped_mmap.h: Rename include guard.
11114         * common/scoped_fd.h: Rename include guard.
11115         * common/safe-iterator.h: Rename include guard.
11116         * common/run-time-clock.h: Rename include guard.
11117         * common/refcounted-object.h: Rename include guard.
11118         * common/queue.h: Rename include guard.
11119         * common/ptid.h: Rename include guard.
11120         * common/print-utils.h: Rename include guard.
11121         * common/preprocessor.h: Rename include guard.
11122         * common/pathstuff.h: Rename include guard.
11123         * common/observable.h: Rename include guard.
11124         * common/netstuff.h: Rename include guard.
11125         * common/job-control.h: Rename include guard.
11126         * common/host-defs.h: Rename include guard.
11127         * common/gdb_wait.h: Rename include guard.
11128         * common/gdb_vecs.h: Rename include guard.
11129         * common/gdb_unlinker.h: Rename include guard.
11130         * common/gdb_unique_ptr.h: Rename include guard.
11131         * common/gdb_tilde_expand.h: Rename include guard.
11132         * common/gdb_sys_time.h: Rename include guard.
11133         * common/gdb_string_view.h: Rename include guard.
11134         * common/gdb_splay_tree.h: Rename include guard.
11135         * common/gdb_setjmp.h: Rename include guard.
11136         * common/gdb_ref_ptr.h: Rename include guard.
11137         * common/gdb_optional.h: Rename include guard.
11138         * common/gdb_locale.h: Rename include guard.
11139         * common/gdb_assert.h: Rename include guard.
11140         * common/filtered-iterator.h: Rename include guard.
11141         * common/filestuff.h: Rename include guard.
11142         * common/fileio.h: Rename include guard.
11143         * common/environ.h: Rename include guard.
11144         * common/common-utils.h: Rename include guard.
11145         * common/common-types.h: Rename include guard.
11146         * common/common-regcache.h: Rename include guard.
11147         * common/common-inferior.h: Rename include guard.
11148         * common/common-gdbthread.h: Rename include guard.
11149         * common/common-exceptions.h: Rename include guard.
11150         * common/common-defs.h: Rename include guard.
11151         * common/common-debug.h: Rename include guard.
11152         * common/cleanups.h: Rename include guard.
11153         * common/buffer.h: Rename include guard.
11154         * common/btrace-common.h: Rename include guard.
11155         * common/break-common.h: Rename include guard.
11156         * cli/cli-utils.h: Rename include guard.
11157         * cli/cli-style.h: Rename include guard.
11158         * cli/cli-setshow.h: Rename include guard.
11159         * cli/cli-script.h: Rename include guard.
11160         * cli/cli-interp.h: Rename include guard.
11161         * cli/cli-decode.h: Rename include guard.
11162         * cli/cli-cmds.h: Rename include guard.
11163         * charset-list.h: Add include guard.
11164         * buildsym-legacy.h: Rename include guard.
11165         * bfin-tdep.h: Add include guard.
11166         * ax.h: Rename include guard.
11167         * arm-linux-tdep.h: Add include guard.
11168         * arm-fbsd-tdep.h: Add include guard.
11169         * arch/xtensa.h: Rename include guard.
11170         * arch/tic6x.h: Add include guard.
11171         * arch/i386.h: Add include guard.
11172         * arch/arm.h: Rename include guard.
11173         * arch/arm-linux.h: Rename include guard.
11174         * arch/arm-get-next-pcs.h: Rename include guard.
11175         * arch/amd64.h: Add include guard.
11176         * arch/aarch64-insn.h: Rename include guard.
11177         * arch-utils.h: Rename include guard.
11178         * annotate.h: Add include guard.
11179         * amd64-darwin-tdep.h: Rename include guard.
11180         * aarch64-linux-tdep.h: Add include guard.
11181         * aarch64-fbsd-tdep.h: Add include guard.
11182         * aarch32-linux-nat.h: Add include guard.
11183
11184 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11185
11186         * macrotab.c (macro_define_internal): New function that
11187         factorizes macro_define_object_internal and macro_define_function
11188         code.
11189         (macro_define_object_internal): Use macro_define_internal.
11190         (macro_define_function): Likewise.
11191
11192 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11193
11194         * macrocmd.c (extract_identifier): Return
11195         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11196         callers.
11197
11198 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11199
11200         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11201
11202 2019-02-05  Tom Tromey  <tom@tromey.com>
11203
11204         * target.c (target_stack::unpush): Move assertion earlier.
11205
11206 2019-01-30  Tom Tromey  <tom@tromey.com>
11207
11208         PR python/23615:
11209         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11210         (gdbpy_parse_and_eval): Likewise.
11211         * python/python-internal.h (gdbpy_allow_threads): New class.
11212
11213 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11214
11215         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11216         (aarch64_fbsd_fpregmap): Move earlier.
11217         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11218         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11219         instead of individual calls to trad_frame_set_reg_addr.
11220         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11221         earlier.
11222         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11223         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11224         instead of individual calls to trad_frame_set_reg_addr.
11225
11226 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11227
11228         * CONTRIBUTE: Replace contribution list with wiki link.
11229
11230 2019-01-25  Tom Tromey  <tom@tromey.com>
11231
11232         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11233
11234 2019-01-25  Tom Tromey  <tom@tromey.com>
11235
11236         * xtensa-linux-nat.c: Fix common/ includes.
11237         * xml-support.h: Fix common/ includes.
11238         * xml-support.c: Fix common/ includes.
11239         * x86-linux-nat.c: Fix common/ includes.
11240         * windows-nat.c: Fix common/ includes.
11241         * varobj.h: Fix common/ includes.
11242         * varobj.c: Fix common/ includes.
11243         * value.c: Fix common/ includes.
11244         * valops.c: Fix common/ includes.
11245         * utils.c: Fix common/ includes.
11246         * unittests/xml-utils-selftests.c: Fix common/ includes.
11247         * unittests/utils-selftests.c: Fix common/ includes.
11248         * unittests/unpack-selftests.c: Fix common/ includes.
11249         * unittests/tracepoint-selftests.c: Fix common/ includes.
11250         * unittests/style-selftests.c: Fix common/ includes.
11251         * unittests/string_view-selftests.c: Fix common/ includes.
11252         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11253         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11254         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11255         * unittests/rsp-low-selftests.c: Fix common/ includes.
11256         * unittests/parse-connection-spec-selftests.c: Fix common/
11257         includes.
11258         * unittests/optional-selftests.c: Fix common/ includes.
11259         * unittests/offset-type-selftests.c: Fix common/ includes.
11260         * unittests/observable-selftests.c: Fix common/ includes.
11261         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11262         * unittests/memrange-selftests.c: Fix common/ includes.
11263         * unittests/memory-map-selftests.c: Fix common/ includes.
11264         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11265         * unittests/function-view-selftests.c: Fix common/ includes.
11266         * unittests/environ-selftests.c: Fix common/ includes.
11267         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11268         * unittests/common-utils-selftests.c: Fix common/ includes.
11269         * unittests/cli-utils-selftests.c: Fix common/ includes.
11270         * unittests/array-view-selftests.c: Fix common/ includes.
11271         * ui-file.c: Fix common/ includes.
11272         * tui/tui-io.c: Fix common/ includes.
11273         * tracepoint.h: Fix common/ includes.
11274         * tracepoint.c: Fix common/ includes.
11275         * tracefile-tfile.c: Fix common/ includes.
11276         * top.h: Fix common/ includes.
11277         * top.c: Fix common/ includes.
11278         * thread.c: Fix common/ includes.
11279         * target/waitstatus.h: Fix common/ includes.
11280         * target/waitstatus.c: Fix common/ includes.
11281         * target.h: Fix common/ includes.
11282         * target.c: Fix common/ includes.
11283         * target-memory.c: Fix common/ includes.
11284         * target-descriptions.c: Fix common/ includes.
11285         * symtab.h: Fix common/ includes.
11286         * symfile.c: Fix common/ includes.
11287         * stap-probe.c: Fix common/ includes.
11288         * spu-linux-nat.c: Fix common/ includes.
11289         * sparc-nat.c: Fix common/ includes.
11290         * source.c: Fix common/ includes.
11291         * solib.c: Fix common/ includes.
11292         * solib-target.c: Fix common/ includes.
11293         * ser-unix.c: Fix common/ includes.
11294         * ser-tcp.c: Fix common/ includes.
11295         * ser-pipe.c: Fix common/ includes.
11296         * ser-base.c: Fix common/ includes.
11297         * selftest-arch.c: Fix common/ includes.
11298         * s12z-tdep.c: Fix common/ includes.
11299         * rust-exp.y: Fix common/ includes.
11300         * rs6000-aix-tdep.c: Fix common/ includes.
11301         * riscv-tdep.c: Fix common/ includes.
11302         * remote.c: Fix common/ includes.
11303         * remote-notif.h: Fix common/ includes.
11304         * remote-fileio.h: Fix common/ includes.
11305         * remote-fileio.c: Fix common/ includes.
11306         * regcache.h: Fix common/ includes.
11307         * regcache.c: Fix common/ includes.
11308         * record-btrace.c: Fix common/ includes.
11309         * python/python.c: Fix common/ includes.
11310         * python/py-type.c: Fix common/ includes.
11311         * python/py-inferior.c: Fix common/ includes.
11312         * progspace.h: Fix common/ includes.
11313         * producer.c: Fix common/ includes.
11314         * procfs.c: Fix common/ includes.
11315         * proc-api.c: Fix common/ includes.
11316         * printcmd.c: Fix common/ includes.
11317         * ppc-linux-nat.c: Fix common/ includes.
11318         * parser-defs.h: Fix common/ includes.
11319         * osdata.c: Fix common/ includes.
11320         * obsd-nat.c: Fix common/ includes.
11321         * nat/x86-linux.c: Fix common/ includes.
11322         * nat/x86-linux-dregs.c: Fix common/ includes.
11323         * nat/x86-dregs.h: Fix common/ includes.
11324         * nat/x86-dregs.c: Fix common/ includes.
11325         * nat/ppc-linux.c: Fix common/ includes.
11326         * nat/mips-linux-watch.h: Fix common/ includes.
11327         * nat/mips-linux-watch.c: Fix common/ includes.
11328         * nat/linux-waitpid.c: Fix common/ includes.
11329         * nat/linux-ptrace.h: Fix common/ includes.
11330         * nat/linux-ptrace.c: Fix common/ includes.
11331         * nat/linux-procfs.c: Fix common/ includes.
11332         * nat/linux-personality.c: Fix common/ includes.
11333         * nat/linux-osdata.c: Fix common/ includes.
11334         * nat/linux-namespaces.c: Fix common/ includes.
11335         * nat/linux-btrace.h: Fix common/ includes.
11336         * nat/linux-btrace.c: Fix common/ includes.
11337         * nat/fork-inferior.c: Fix common/ includes.
11338         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11339         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11340         * nat/aarch64-linux.c: Fix common/ includes.
11341         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11342         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11343         * namespace.h: Fix common/ includes.
11344         * mips-linux-tdep.c: Fix common/ includes.
11345         * minsyms.c: Fix common/ includes.
11346         * mi/mi-parse.h: Fix common/ includes.
11347         * mi/mi-main.c: Fix common/ includes.
11348         * mi/mi-cmd-env.c: Fix common/ includes.
11349         * memrange.h: Fix common/ includes.
11350         * memattr.c: Fix common/ includes.
11351         * maint.h: Fix common/ includes.
11352         * maint.c: Fix common/ includes.
11353         * main.c: Fix common/ includes.
11354         * machoread.c: Fix common/ includes.
11355         * location.c: Fix common/ includes.
11356         * linux-thread-db.c: Fix common/ includes.
11357         * linux-nat.c: Fix common/ includes.
11358         * linux-fork.c: Fix common/ includes.
11359         * inline-frame.c: Fix common/ includes.
11360         * infrun.c: Fix common/ includes.
11361         * inflow.c: Fix common/ includes.
11362         * inferior.h: Fix common/ includes.
11363         * inferior.c: Fix common/ includes.
11364         * infcmd.c: Fix common/ includes.
11365         * inf-ptrace.c: Fix common/ includes.
11366         * inf-child.c: Fix common/ includes.
11367         * ia64-linux-nat.c: Fix common/ includes.
11368         * i387-tdep.c: Fix common/ includes.
11369         * i386-tdep.c: Fix common/ includes.
11370         * i386-linux-tdep.c: Fix common/ includes.
11371         * i386-linux-nat.c: Fix common/ includes.
11372         * i386-go32-tdep.c: Fix common/ includes.
11373         * i386-fbsd-tdep.c: Fix common/ includes.
11374         * i386-fbsd-nat.c: Fix common/ includes.
11375         * guile/scm-type.c: Fix common/ includes.
11376         * guile/guile.c: Fix common/ includes.
11377         * go32-nat.c: Fix common/ includes.
11378         * gnu-nat.c: Fix common/ includes.
11379         * gdbthread.h: Fix common/ includes.
11380         * gdbarch-selftests.c: Fix common/ includes.
11381         * gdb_usleep.c: Fix common/ includes.
11382         * gdb_select.h: Fix common/ includes.
11383         * gdb_bfd.c: Fix common/ includes.
11384         * gcore.c: Fix common/ includes.
11385         * fork-child.c: Fix common/ includes.
11386         * findvar.c: Fix common/ includes.
11387         * fbsd-nat.c: Fix common/ includes.
11388         * event-top.c: Fix common/ includes.
11389         * event-loop.c: Fix common/ includes.
11390         * dwarf2read.c: Fix common/ includes.
11391         * dwarf2loc.c: Fix common/ includes.
11392         * dwarf2-frame.c: Fix common/ includes.
11393         * dwarf-index-cache.c: Fix common/ includes.
11394         * dtrace-probe.c: Fix common/ includes.
11395         * disasm-selftests.c: Fix common/ includes.
11396         * defs.h: Fix common/ includes.
11397         * csky-tdep.c: Fix common/ includes.
11398         * cp-valprint.c: Fix common/ includes.
11399         * cp-support.h: Fix common/ includes.
11400         * cp-support.c: Fix common/ includes.
11401         * corelow.c: Fix common/ includes.
11402         * completer.h: Fix common/ includes.
11403         * completer.c: Fix common/ includes.
11404         * compile/compile.c: Fix common/ includes.
11405         * compile/compile-loc2c.c: Fix common/ includes.
11406         * compile/compile-cplus-types.c: Fix common/ includes.
11407         * compile/compile-cplus-symbols.c: Fix common/ includes.
11408         * command.h: Fix common/ includes.
11409         * cli/cli-dump.c: Fix common/ includes.
11410         * cli/cli-cmds.c: Fix common/ includes.
11411         * charset.c: Fix common/ includes.
11412         * build-id.c: Fix common/ includes.
11413         * btrace.h: Fix common/ includes.
11414         * btrace.c: Fix common/ includes.
11415         * breakpoint.h: Fix common/ includes.
11416         * breakpoint.c: Fix common/ includes.
11417         * ax.h:
11418         (enum agent_op): Fix common/ includes.
11419         * ax-general.c (struct aop_map): Fix common/ includes.
11420         * ax-gdb.c: Fix common/ includes.
11421         * auxv.c: Fix common/ includes.
11422         * auto-load.c: Fix common/ includes.
11423         * arm-tdep.c: Fix common/ includes.
11424         * arch/riscv.c: Fix common/ includes.
11425         * arch/ppc-linux-common.c: Fix common/ includes.
11426         * arch/i386.c: Fix common/ includes.
11427         * arch/arm.c: Fix common/ includes.
11428         * arch/arm-linux.c: Fix common/ includes.
11429         * arch/arm-get-next-pcs.c: Fix common/ includes.
11430         * arch/amd64.c: Fix common/ includes.
11431         * arch/aarch64.c: Fix common/ includes.
11432         * arch/aarch64-insn.c: Fix common/ includes.
11433         * arch-utils.c: Fix common/ includes.
11434         * amd64-windows-tdep.c: Fix common/ includes.
11435         * amd64-tdep.c: Fix common/ includes.
11436         * amd64-sol2-tdep.c: Fix common/ includes.
11437         * amd64-obsd-tdep.c: Fix common/ includes.
11438         * amd64-nbsd-tdep.c: Fix common/ includes.
11439         * amd64-linux-tdep.c: Fix common/ includes.
11440         * amd64-linux-nat.c: Fix common/ includes.
11441         * amd64-fbsd-tdep.c: Fix common/ includes.
11442         * amd64-fbsd-nat.c: Fix common/ includes.
11443         * amd64-dicos-tdep.c: Fix common/ includes.
11444         * amd64-darwin-tdep.c: Fix common/ includes.
11445         * agent.c: Fix common/ includes.
11446         * ada-lang.h: Fix common/ includes.
11447         * ada-lang.c: Fix common/ includes.
11448         * aarch64-tdep.c: Fix common/ includes.
11449
11450 2019-01-25  Tom Tromey  <tom@tromey.com>
11451
11452         * common/create-version.sh: Use common/version.h.
11453
11454 2019-01-24  Pedro Alves  <palves@redhat.com>
11455
11456         * infrun.c (signal_stop, signal_print, signal_program)
11457         (signal_catch, signal_pass): Now arrays instead of pointers.
11458         (update_signals_program_target, do_target_resume)
11459         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11460         * linux-nat.c (linux_nat_target::pass_signals)
11461         (linux_nat_target::create_inferior, linux_nat_target::attach):
11462         Adjust.
11463         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11464         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11465         * procfs.c (procfs_target::pass_signals): Adjust.
11466         * record-full.c (record_full_target::resume): Adjust.
11467         * remote.c (remote_target::pass_signals)
11468         (remote_target::program_signals): Adjust.
11469         * target-debug.h (target_debug_print_signals): Now takes a
11470         gdb::array_view as parameter.  Adjust.
11471         * target.h (target_ops) <pass_signals, program_signals>: Replace
11472         pointer and length parameters with gdb::array_view.
11473         (target_pass_signals, target_program_signals): Likewise.
11474         * target-delegates.c: Regenerate.
11475
11476 2019-01-24  Pedro Alves  <palves@redhat.com>
11477
11478         * common/forward-scope-exit.h
11479         (forward_scope_exit::forward_scope_exit): Pass arguments to
11480         m_bind_function directly, instead of creating a std::bind and
11481         copying that.
11482
11483 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11484
11485         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11486         for static members.
11487         (pass_in_v_vfp_candidate): Likewise.
11488
11489 2019-01-23  Tom Tromey  <tom@tromey.com>
11490             Pedro Alves  <palves@redhat.com>
11491
11492         * regcache.c (class regcache_invalidator): Remove.
11493         (regcache::raw_write): Use make_scope_exit.
11494
11495 2019-01-23  Tom Tromey  <tom@tromey.com>
11496
11497         * ui-out.h (class ui_out_emit_type): Update comment.
11498
11499 2019-01-23  Tom Tromey  <tom@tromey.com>
11500
11501         * infrun.c (fetch_inferior_event): Update comment.
11502
11503 2019-01-23  Tom Tromey  <tom@tromey.com>
11504             Pedro Alves  <palves@redhat.com>
11505
11506         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11507         parameter.
11508         (fetch_inferior_event): Use SCOPE_EXIT.
11509
11510
11511 2019-01-23  Tom Tromey  <tom@tromey.com>
11512             Pedro Alves  <palves@redhat.com>
11513
11514         * infrun.c (disable_thread_events): Delete.
11515         (stop_all_threads): Use SCOPE_EXIT.
11516
11517 2019-01-23  Tom Tromey  <tom@tromey.com>
11518             Pedro Alves  <palves@redhat.com>
11519
11520         * symfile.c: Include forward-scope-exit.h.
11521         (clear_symtab_users_cleanup): Replace forward declaration with
11522         a FORWARD_SCOPE_EXIT.
11523         (syms_from_objfile_1): Use the forward_scope_exit and
11524         gdb::optional instead of cleanup_function.
11525         (reread_symbols): Use the forward_scope_exit instead of
11526         cleanup_function.
11527         (clear_symtab_users_cleanup): Remove function.
11528
11529 2019-01-23  Tom Tromey  <tom@tromey.com>
11530             Pedro Alves  <palves@redhat.com>
11531
11532         * linux-nat.c: Include scope-exit.h.
11533         (cleanup_target_stop): Remove.
11534         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11535         SCOPE_EXIT.
11536
11537 2019-01-23  Tom Tromey  <tom@tromey.com>
11538             Pedro Alves  <palves@redhat.com>
11539
11540         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11541         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11542
11543 2019-01-23  Tom Tromey  <tom@tromey.com>
11544             Andrew Burgess  <andrew.burgess@embecosm.com>
11545             Pedro Alves  <palves@redhat.com>
11546
11547         * infrun.c (fetch_inferior_event): Use scope_exit.
11548         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11549         * top.c (execute_command): Use scope_exit.
11550         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11551         * utils.c (do_bpstat_clear_actions_cleanup)
11552         (make_bpstat_clear_actions_cleanup): Remove.
11553
11554 2019-01-23  Tom Tromey  <tom@tromey.com>
11555             Pedro Alves  <palves@redhat.com>
11556
11557         * infrun.c: Include "common/scope-exit.h"
11558         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11559         (wait_for_inferior): Use SCOPE_EXIT.
11560         (fetch_inferior_event): Use scope_exit.
11561
11562 2019-01-23  Tom Tromey  <tom@tromey.com>
11563             Pedro Alves  <palves@redhat.com>
11564
11565         * breakpoint.c (create_breakpoint): Remove cleanup.
11566
11567 2019-01-23  Tom Tromey  <tom@tromey.com>
11568             Andrew Burgess  <andrew.burgess@embecosm.com>
11569             Pedro Alves  <palves@redhat.com>
11570
11571 2019-01-23  Pedro Alves  <palves@redhat.com>
11572
11573         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11574
11575 2019-01-23  Pedro Alves  <palves@redhat.com>
11576             Andrew Burgess  <andrew.burgess@embecosm.com>
11577
11578         * gdbthread.h: Include "common/forward-scope-exit.h".
11579         (scoped_finish_thread_state): Redefine custom class in terms of
11580         forward_scope_exit.
11581
11582 2019-01-23  Pedro Alves  <palves@redhat.com>
11583             Andrew Burgess  <andrew.burgess@embecosm.com>
11584
11585         * common/forward-scope-exit.h: New file.
11586
11587 2019-01-23  Pedro Alves  <palves@redhat.com>
11588             Andrew Burgess  <andrew.burgess@embecosm.com>
11589             Tom Tromey  <tom@tromey.com>
11590
11591         * common/scope-exit.h: New file.
11592
11593 2019-01-23  Pedro Alves  <palves@redhat.com>
11594
11595         * common/preprocessor.h (ESC): Rename to ...
11596         (ESC_PARENS): ... this.
11597         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11598         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11599
11600 2019-01-23  Tom Tromey  <tom@tromey.com>
11601
11602         * language.h (class scoped_switch_to_sym_language_if_auto):
11603         Initialize m_lang in both cases.
11604
11605 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11606
11607         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11608         with XCNEW.
11609
11610 2019-01-22  Tom Tromey  <tom@tromey.com>
11611
11612         * corelow.c: Do not include sys/file.h.
11613
11614 2019-01-22  Tom Tromey  <tom@tromey.com>
11615
11616         * tui/tui-wingeneral.h: Include gdb_curses.h.
11617
11618 2019-01-22  Tom Tromey  <tom@tromey.com>
11619
11620         * source-cache.h (class source_cache) <get_source_lines,
11621         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11622
11623 2019-01-22  Tom Tromey  <tom@tromey.com>
11624
11625         * remote-fileio.h (struct remote_target): Declare.
11626
11627 2019-01-22  Tom Tromey  <tom@tromey.com>
11628
11629         * python/py-arch.c: Do not include py-ref.h.
11630         * python/py-bpevent.c: Do not include py-ref.h.
11631         * python/py-cmd.c: Do not include py-ref.h.
11632         * python/py-continueevent.c: Do not include py-ref.h.
11633         * python/py-event.h: Do not include py-ref.h.
11634         * python/py-evtregistry.c: Do not include py-ref.h.
11635         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11636         * python/py-frame.c: Do not include py-ref.h.
11637         * python/py-framefilter.c: Do not include py-ref.h.
11638         * python/py-function.c: Do not include py-ref.h.
11639         * python/py-infevents.c: Do not include py-ref.h.
11640         * python/py-linetable.c: Do not include py-ref.h.
11641         * python/py-objfile.c: Do not include py-ref.h.
11642         * python/py-param.c: Do not include py-ref.h.
11643         * python/py-prettyprint.c: Do not include py-ref.h.
11644         * python/py-progspace.c: Do not include py-ref.h.
11645         * python/py-symbol.c: Do not include py-ref.h.
11646         * python/py-symtab.c: Do not include py-ref.h.
11647         * python/py-type.c: Do not include py-ref.h.
11648         * python/py-unwind.c: Do not include py-ref.h.
11649         * python/py-utils.c: Do not include py-ref.h.
11650         * python/py-value.c: Do not include py-ref.h.
11651         * python/py-varobj.c: Do not include py-ref.h.
11652         * python/py-xmethods.c: Do not include py-ref.h.
11653         * python/python.c: Do not include py-ref.h.
11654         * varobj.c: Do not include py-ref.h.
11655
11656 2019-01-22  Tom Tromey  <tom@tromey.com>
11657
11658         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11659         keyword for bcache.
11660
11661 2019-01-22  Tom Tromey  <tom@tromey.com>
11662
11663         * compile/compile-cplus-types.c: Remove a comment by #include.
11664
11665 2019-01-22  Tom Tromey  <tom@tromey.com>
11666
11667         * compile/gcc-c-plugin.h: Include compile-internal.h.
11668
11669 2019-01-22  Tom Tromey  <tom@tromey.com>
11670
11671         * stabsread.c (EXTERN): Do not define.
11672         (symnum, next_symbol_text_func, processing_gcc_compilation)
11673         (within_function, global_sym_chain, global_stabs)
11674         (previous_stab_code, this_object_header_files)
11675         (n_this_object_header_files)
11676         (n_allocated_this_object_header_files): Define.
11677         * stabsread.h (EXTERN): Never define.  Use "extern".
11678
11679 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11680
11681         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11682         history_value.
11683
11684 2019-01-21  Tom Tromey  <tom@tromey.com>
11685
11686         * ui-out.c: Fix includes.
11687         * tui/tui-source.c: Fix includes.
11688         * target.c: Fix includes.
11689         * remote.c: Fix includes.
11690         * regcache.c: Fix includes.
11691         * python/py-block.c: Fix includes.
11692         * printcmd.c: Fix includes.
11693         * or1k-tdep.c: Fix includes.
11694         * mi/mi-main.c: Fix includes.
11695         * m32r-tdep.c: Fix includes.
11696         * csky-tdep.c: Fix includes.
11697         * compile/compile-cplus-types.c: Fix includes.
11698         * cli/cli-interp.c: Fix includes.
11699
11700 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11701
11702         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11703         for padding.
11704
11705 2019-01-16  Tom Tromey  <tom@tromey.com>
11706
11707         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11708         earlier.
11709         (struct objfile) <msymbols_range>: Move from top level.
11710         <msymbols>: New method.
11711         (class objfile_msymbols): Remove.
11712         * symtab.c (default_collect_symbol_completion_matches_break_on):
11713         Update.
11714         * symmisc.c (dump_msymbols): Update.
11715         * stabsread.c (scan_file_globals): Update.
11716         * objc-lang.c (info_selectors_command, info_classes_command)
11717         (find_methods): Update.
11718         * minsyms.c (find_solib_trampoline_target): Update.
11719         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11720         * coffread.c (coff_symfile_read): Update.
11721         * ada-lang.c (ada_lookup_simple_minsym)
11722         (ada_collect_symbol_completion_matches): Update.
11723
11724 2019-01-16  Tom Tromey  <tom@tromey.com>
11725
11726         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11727         type.  Remove no-argument constructor.
11728         <iterator::operator++>: Simplify.
11729         <begin>: Update.
11730         <end>: Use minimal_symbol_count.
11731
11732 2019-01-16  Tom Tromey  <tom@tromey.com>
11733
11734         * objfiles.h (struct objfile) <psymtabs>: New method.
11735         (class objfile_psymtabs): Remove.
11736         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11737         typedef.
11738         <range>: New method.
11739         (require_partial_symbols): Change return type.
11740         * psymtab.c (require_partial_symbols)
11741         (psym_expand_symtabs_matching): Update.
11742         * mdebugread.c (parse_partial_symbols): Update.
11743         * dbxread.c (dbx_end_psymtab): Update.
11744
11745 2019-01-15  Tom Tromey  <tom@tromey.com>
11746
11747         * symtab.c (lookup_objfile_from_block)
11748         (lookup_symbol_in_objfile_symtabs)
11749         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11750         (find_line_symtab, info_sources_command)
11751         (default_collect_symbol_completion_matches_break_on)
11752         (make_source_files_completion_list): Update.
11753         * symmisc.c (print_objfile_statistics, dump_objfile)
11754         (maintenance_print_symbols, maintenance_info_symtabs)
11755         (maintenance_check_symtabs, maintenance_info_line_tables):
11756         Update.
11757         * source.c (select_source_symtab)
11758         (forget_cached_source_info_for_objfile): Update.
11759         * objfiles.h (class objfile_compunits): Remove.
11760         (struct objfile) <compunits_range>: New typedef.
11761         (compunits): New method.
11762         * objfiles.c (objfile_relocate1): Update.
11763         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11764         * maint.c (count_symtabs_and_blocks): Update.
11765         * linespec.c (iterate_over_all_matching_symtabs): Update.
11766         * cp-support.c (add_symbol_overload_list_qualified): Update.
11767         * coffread.c (coff_symtab_read): Update.
11768         * ada-lang.c (add_nonlocal_symbols)
11769         (ada_collect_symbol_completion_matches)
11770         (ada_add_global_exceptions): Update.
11771
11772 2019-01-15  Tom Tromey  <tom@tromey.com>
11773
11774         * progspace.h (program_space) <objfiles_safe_range>: New
11775         typedef.
11776         <objfiles_safe>: New method.
11777         * objfiles.h (class all_objfiles_safe): Remove.
11778         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11779         * jit.c (jit_inferior_exit_hook): Update.
11780
11781 2019-01-17  Tom Tromey  <tom@tromey.com>
11782
11783         * progspace.h (program_space) <objfiles_range>: New typedef.
11784         <objfiles>: New method.
11785         <objfiles_head>: Rename from objfiles.
11786         (object_files): Update.
11787         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11788         * guile/scm-pretty-print.c
11789         (ppscm_find_pretty_printer_from_objfiles): Update.
11790         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11791         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11792         Update.
11793         * python/py-progspace.c (pspy_get_objfiles): Update.
11794         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11795         Update.
11796         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11797         (objfpy_lookup_objfile_by_build_id): Update.
11798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11799         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11800         Update.
11801         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11802         (expand_symtab_containing_pc, lookup_objfile_from_block)
11803         (lookup_static_symbol, basic_lookup_transparent_type)
11804         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11805         (find_line_symtab, info_sources_command)
11806         (default_collect_symbol_completion_matches_break_on)
11807         (make_source_files_completion_list, find_main_name): Update.
11808         * symmisc.c (print_symbol_bcache_statistics)
11809         (print_objfile_statistics, maintenance_print_symbols)
11810         (maintenance_print_msymbols, maintenance_print_objfiles)
11811         (maintenance_info_symtabs, maintenance_check_symtabs)
11812         (maintenance_expand_symtabs, maintenance_info_line_tables):
11813         Update.
11814         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11815         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11816         (map_overlay_command, unmap_overlay_command)
11817         (simple_overlay_update, expand_symtabs_matching)
11818         (map_symbol_filenames): Update.
11819         * symfile-debug.c (set_debug_symfile): Update.
11820         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11821         Update.
11822         * source.c (select_source_symtab, forget_cached_source_info):
11823         Update.
11824         * solib.c (solib_read_symbols): Update.
11825         * solib-spu.c (append_ocl_sos): Update.
11826         * psymtab.c (maintenance_print_psymbols)
11827         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11828         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11829         * printcmd.c (info_symbol_command): Update.
11830         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11831         Update.
11832         * objfiles.h (class all_objfiles): Remove.
11833         * objfiles.c (have_partial_symbols, have_full_symbols)
11834         (have_minimal_symbols, qsort_cmp, update_section_map)
11835         (shared_objfile_contains_address_p)
11836         (default_iterate_over_objfiles_in_search_order): Update.
11837         * objc-lang.c (info_selectors_command, info_classes_command)
11838         (find_methods): Update.
11839         * minsyms.c (find_solib_trampoline_target): Update.
11840         * maint.c (maintenance_info_sections)
11841         (maintenance_translate_address, count_symtabs_and_blocks):
11842         Update.
11843         * main.c (captured_main_1): Update.
11844         * linux-thread-db.c (try_thread_db_load_from_pdir)
11845         (has_libpthread): Update.
11846         * linespec.c (iterate_over_all_matching_symtabs)
11847         (search_minsyms_for_name): Update.
11848         * jit.c (jit_find_objf_with_entry_addr): Update.
11849         * hppa-tdep.c (find_unwind_entry)
11850         (hppa_lookup_stub_minimal_symbol): Update.
11851         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11852         Update.
11853         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11854         (elf_gnu_ifunc_resolve_by_got): Update.
11855         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11856         * dwarf-index-write.c (save_gdb_index_command): Update.
11857         * cp-support.c (add_symbol_overload_list_qualified): Update.
11858         * breakpoint.c (create_overlay_event_breakpoint)
11859         (create_longjmp_master_breakpoint)
11860         (create_std_terminate_master_breakpoint)
11861         (create_exception_master_breakpoint): Update.
11862         * blockframe.c (find_pc_partial_function): Update.
11863         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11864         (ada_collect_symbol_completion_matches)
11865         (ada_add_global_exceptions): Update.
11866
11867 2019-01-17  Tom Tromey  <tom@tromey.com>
11868
11869         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11870         declare VEC.
11871         (solib_target_parse_libraries): Change return type.
11872         (library_list_start_segment, library_list_start_section)
11873         (library_list_end_library, library_list_start_library); Update.
11874         (solib_target_free_library_list): Remove.
11875         (solib_target_parse_libraries): Remove cleanup.  Change return
11876         type.
11877         (solib_target_current_sos): Update.
11878
11879 2019-01-17  Tom Tromey  <tromey@bapiya>
11880
11881         * valprint.c: Replace "the the" with "the".
11882         * symtab.c: Replace "the the" with "the".
11883         * solib.c: Replace "the the" with "the".
11884         * solib-dsbt.c: Replace "the the" with "the".
11885         * linespec.c: Replace "the the" with "the".
11886         * dwarf2loc.h: Replace "the the" with "the".
11887         * amd64-windows-tdep.c: Replace "the the" with "the".
11888         * aarch64-tdep.c: Replace "the the" with "the".
11889
11890 2019-01-16  Keith Seitz  <keiths@redhat.com>
11891
11892         PR gdb/23773
11893         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11894         <builder>: Rename to ..
11895         <m_builder>: ... this and make private.
11896         (dwarf2_cu::get_builder): New method.  Change all users of
11897         `builder' to use this method.
11898         (dwarf2_start_symtab): Move to ...
11899         (dwarf2_cu::start_symtab): ... here.  Update all callers
11900         (setup_type_unit_groups): Move to ...
11901         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11902         callers.
11903         (dwarf2_cu::reset_builder): New method.
11904         (process_full_compunit, process_full_type_unit): Use
11905         dwarf2_cu::reset_builder.
11906         (follow_die_offset): Record the ancestor CU if it is different
11907         from the followed DIE's CU.
11908         (follow_die_sig_1): Likewise.
11909
11910 2019-01-15  Tom Tromey  <tom@tromey.com>
11911
11912         * remote.c (class remote_state) <buf>: Now a char_vector.
11913         <buf_size>: Remove.
11914         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11915         parameter.
11916         (remote_target::getpkt_or_notif_sane_1)
11917         (remote_target::getpkt_sane)
11918         (remote_target::getpkt_or_notif_sane): Likewise.
11919         (class remote_target) <putpkt>: New overload.
11920         (remote_target::read_frame): Change type of "buf_p".  Remove
11921         sizeof_p parameter.
11922         (packet_ok): New overload.
11923         (packet_check_result): New overload.
11924         Update all uses.
11925
11926 2019-01-14  Tom Tromey  <tom@tromey.com>
11927
11928         * remote-notif.c (handle_notification, remote_notif_ack)
11929         (remote_notif_parse): Make "buf" const.
11930         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11931         const.
11932         (remote_notif_parse, remote_notif_ack, handle_notification):
11933         Likewise.
11934         * remote.c (remote_notif_stop_parse): Make "buf" const.
11935         (remote_target::remote_parse_stop_reply): Make "buf" const.
11936         (remote_notif_stop_ack): Make "buf" const.
11937
11938 2019-01-14  Tom Tromey  <tom@tromey.com>
11939
11940         * remote.c (remote_console_output): Make parameter const.
11941
11942 2019-01-14  Tom Tromey  <tom@tromey.com>
11943
11944         * target-debug.h (target_debug_print_signals): Constify.
11945         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11946         * procfs.c (procfs_target::pass_signals): Update.
11947         * linux-nat.c (linux_nat_target::pass_signals): Update.
11948         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11949         * target-delegates.c: Rebuild.
11950         * remote.c (remote_target::program_signals): Update.
11951         (remote_target::pass_signals): Update.
11952         * target.c (target_pass_signals): Constify argument.
11953         (target_program_signals): Likewise.
11954         * target.h (struct target_ops) <pass_signals, program_signals>:
11955         Constify argument.
11956         (target_pass_signals, target_program_signals): Constify argument.
11957
11958 2019-01-14  Tom Tromey  <tom@tromey.com>
11959
11960         PR tui/28819:
11961         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11962
11963 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11964
11965         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11966         field.
11967         * rs6000-tdep.c: Include reggroups.h.
11968         (IS_V_ALIAS_PSEUDOREG): Define.
11969         (rs6000_register_name): Return names for the "vX" aliases.
11970         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11971         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11972         aliases.  Call default_register_reggroup_p for all other
11973         pseudo-registers.
11974         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11975         New functions.
11976         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11977         Handle "vX" aliases.
11978         (v_alias_pseudo_register_collect): New function.
11979         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11980         (rs6000_gdbarch_init): Initialize "vX" aliases as
11981         pseudo-registers.  Restore registration of
11982         rs6000_pseudo_register_reggroup_p with
11983         set_tdesc_pseudo_register_reggroup_p.
11984
11985 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11986
11987         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11988         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11989         set_gdbarch_num_pseudo_regs.
11990
11991 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11992
11993         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11994         Remove arg prefixname, add do_set and do_show.
11995         Add member functions set_list and show_list.
11996         * cli/cli-style.c (class cli_style_option): Update accordingly.
11997         (style_set_list): Move to file scope.
11998         (style_show_list): Likewise.
11999         (set_style): Call help_list.
12000         (show_style): Call cmd_show_list.
12001         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12002         Update to use the new macro.
12003
12004 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12005
12006         * ada-lang.c (_initialize_ada_language): Expand the help text
12007         for the "catch exception" command.
12008
12009 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12010
12011         * symtab.c (matching_obj_sections): Initialize obj,
12012         declare it closer to its usage.
12013
12014 2019-01-10  Tom Tromey  <tom@tromey.com>
12015
12016         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12017         (basic_inf_threads_range): Remove.
12018         (inf_threads_range, inf_non_exited_threads_range)
12019         (safe_inf_threads_range): Use next_adapter.
12020
12021 2019-01-10  Keith Seitz  <keiths@redhat.com>
12022
12023         PR gdb/23712
12024         PR symtab/23010
12025         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12026         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12027
12028 2019-01-10  Keith Seitz  <keiths@redhat.com>
12029
12030         PR gdb/23712
12031         PR symtab/23010
12032         * dictionary.c (pending_to_vector): Remove.
12033         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12034         Remove _1 suffix, replacing functions of the same name.  Update
12035         all callers.
12036         (dict_create_hashed, dict_create_hashed_expandable)
12037         (dict_create_linear, dict_create_linear_expandable, dict_free)
12038         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12039         Make functions static.
12040
12041 2019-01-10  Keith Seitz  <keiths@redhat.com>
12042
12043         PR gdb/23712
12044         PR symtab/23010
12045         * dictionary.h (struct dictionary): Replace declaration with
12046         multidictionary.
12047         (dict_create_hashed, dict_create_hashed_expandable)
12048         (dict_create_linear, dict_create_linear_expandable)
12049         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12050         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12051         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12052         taking multidictionary argument.
12053         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12054         * block.h (struct block) <dict>: Change to multidictionary
12055         and rename `multidict'.
12056         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12057         symmisc.c: Update all dictionary references to multidictionary.
12058
12059 2019-01-10  Keith Seitz  <keiths@redhat.com>
12060
12061         PR gdb/23712
12062         PR symtab/23010
12063         * dictionary.c: Include unordered_map.
12064         (pending_to_vector): New function.
12065         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12066         Rewrite the non-"_1" functions to take vector instead
12067         of linked list.
12068         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12069         "new" _1 versions of the same name.
12070         (multidictionary): Define.
12071         (std::hash<enum language): New definition.
12072         (collate_pending_symbols_by_language, mdict_create_hashed)
12073         (mdict_create_hashed_expandable, mdict_create_linear)
12074         (mdict_create_linear_expandable, mdict_free)
12075         (find_language_dictionary, create_new_language_dictionary)
12076         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12077         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12078         (mdict_size, mdict_empty): New functions.
12079         * dictionary.h (mdict_iterator): Define.
12080
12081 2019-01-10  Pedro Alves  <palves@redhat.com>
12082
12083         * breakpoint.c (read_uploaded_action)
12084         (create_tracepoint_from_upload): Adjust to use
12085         gdb::unique_xmalloc_ptr.
12086         * ctf.c (ctf_write_uploaded_tp):
12087         (SET_ARRAY_FIELD): Use emplace_back.
12088         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12089         * tracefile-tfile.c (tfile_write_uploaded_tp):
12090         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12091         gdb::unique_xmalloc_ptr.
12092         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12093         at_string, cond_string, cmd_strings>: Replace char pointers
12094         with gdb::unique_xmalloc_ptr.
12095
12096 2019-01-10  Pedro Alves  <palves@redhat.com>
12097
12098         * solib-target.c (library_list_start_library): Don't xstrdup name.
12099
12100 2019-01-10  Pedro Alves  <palves@redhat.com>
12101
12102         * mdebugread.c (parse_partial_symbols): Use
12103         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12104
12105 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12106
12107         * linux-fork.c (scoped_switch_fork_info)
12108         <~scoped_switch_fork_info>: Fix incorrect variable name.
12109
12110 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12111
12112         * linux-fork.c (scoped_switch_fork_info)
12113         <scoped_switch_fork_info>: Make explicit.
12114         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12115
12116 2019-01-10  Tom Tromey  <tom@tromey.com>
12117
12118         * objfiles.h (objfile::reset_psymtabs): Update.
12119         * objfiles.c (objfile::objfile): Update.
12120         * psymtab.h (psymtab_storage::obstack): Update.
12121         (psymtab_storage::m_obstack): Use gdb::optional.
12122         (class psymtab_storage): Update comment.  Remove objfile
12123         parameter.
12124         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12125
12126 2019-01-10  Tom Tromey  <tom@tromey.com>
12127
12128         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12129         <free_psymtabs>: Now private.
12130         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12131         (allocate_psymtab): Use new method.
12132
12133 2019-01-10  Tom Tromey  <tom@tromey.com>
12134
12135         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12136         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12137         * mdebugread.c (parse_partial_symbols): Use
12138         allocate_dependencies.
12139         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12140         allocate_dependencies.
12141         (process_psymtab_comp_unit_reader)
12142         (build_type_psymtab_dependencies): Likewise.
12143         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12144
12145 2019-01-10  Tom Tromey  <tom@tromey.com>
12146
12147         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12148         PSYMBOL_SET_LANGUAGE.
12149         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12150
12151 2019-01-10  Tom Tromey  <tom@tromey.com>
12152
12153         * psymtab.h (psymtab_storage::obstack): New method.
12154         <m_obstack>: Rename from obstack; now private.
12155         * psymtab.c (psymtab_storage): Update.
12156         * dwarf2read.c (create_addrmap_from_index)
12157         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12158         Update.
12159
12160 2019-01-10  Tom Tromey  <tom@tromey.com>
12161
12162         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12163         * objfiles.h (objfile::reset_psymtabs): New method.
12164
12165 2019-01-10  Tom Tromey  <tom@tromey.com>
12166
12167         * symmisc.c (print_symbol_bcache_statistics): Update.
12168         (print_objfile_statistics): Update.
12169         * symfile.c (reread_symbols): Update.
12170         * psymtab.h (class psymtab_storage): New.
12171         * psymtab.c (psymtab_storage): New constructor.
12172         (~psymtab_storage): New destructor.
12173         (require_partial_symbols): Update.
12174         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12175         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12176         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12177         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12178         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12179         (start_psymtab_common, end_psymtab_common)
12180         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12181         (allocate_psymtab): Update.
12182         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12183         Update.
12184         (dump_psymtab_addrmap, maintenance_print_psymbols)
12185         (maintenance_check_psymtabs): Update.
12186         (class objfile_psymtabs): Move to objfiles.h.
12187         * psympriv.h (discard_psymtab): Now inline.
12188         (psymtab_discarder::psymtab_discarder): Update.
12189         (psymtab_discarder::~psymtab_discarder): Update.
12190         (ALL_OBJFILE_PSYMTABS): Rewrite.
12191         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12192         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12193         Remove fields.
12194         <partial_symtabs>: New field.
12195         (class objfile_psymtabs): Move from psymtab.h.  Update.
12196         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12197         psymbol_cache.
12198         (objfile::~objfile): Don't destroy psymbol_cache.
12199         * mdebugread.c (parse_partial_symbols): Update.
12200         * dwarf2read.c (create_addrmap_from_index)
12201         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12202         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12203         (add_partial_subprogram, dwarf2_ranges_read): Update.
12204         * dwarf-index-write.c (write_address_map)
12205         (write_one_signatured_type, recursively_write_psymbols)
12206         (class debug_names, class debug_names, write_psymtabs_to_index):
12207         Update.
12208
12209 2019-01-10  Tom Tromey  <tom@tromey.com>
12210
12211         * symtab.h (SYMBOL_SET_NAMES): Update.
12212         (symbol_set_names): Update.
12213         (MSYMBOL_SET_NAMES): Update.
12214         * symtab.c (symbol_set_names): Change argument to be an
12215         objfile_per_bfd_storage.
12216         * psymtab.c (add_psymbol_to_bcache): Update.
12217         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12218
12219 2019-01-10  Tom Tromey  <tom@tromey.com>
12220
12221         * symtab.c (create_demangled_names_hash): Change argument to be an
12222         objfile_per_bfd_storage.
12223         (symbol_set_names): Update.
12224
12225 2019-01-10  Tom Tromey  <tom@tromey.com>
12226
12227         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12228         init_psymbol_list.
12229         * psymtab.c (init_psymbol_list): Do nothing if already called.
12230         * psympriv.h (init_psymbol_list): Add comment.
12231         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12232         init_psymbol_list.
12233         * dbxread.c (dbx_symfile_read): Unconditionally call
12234         init_psymbol_list.
12235
12236 2019-01-10  Tom Tromey  <tom@tromey.com>
12237
12238         * xcoffread.c (scan_xcoff_symtab): Update.
12239         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12240         "where".
12241         * mdebugread.c (parse_partial_symbols)
12242         (handle_psymbol_enumerators): Update.
12243         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12244         * dbxread.c (read_dbx_symtab): Update.
12245         * psympriv.h (psymbol_placement): New enum.
12246         (add_psymbol_to_list): Update.
12247
12248 2019-01-10  Tom Tromey  <tom@tromey.com>
12249
12250         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12251         static_psymbols parameters.
12252         (scan_xcoff_symtab): Update.
12253         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12254         static_psymbols parameters.
12255         * psympriv.h (start_psymtab_common): Update.
12256         * mdebugread.c (parse_partial_symbols): Update.
12257         * dwarf2read.c (create_partial_symtab): Update.
12258         * dbxread.c (read_dbx_symtab): Update.
12259         (start_psymtab): Remove global_psymbols and static_psymbols
12260         parameters.
12261
12262 2019-01-10  Tom Tromey  <tom@tromey.com>
12263
12264         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12265         * psymtab.c (allocate_psymtab): Add comment.
12266         * psympriv.h (allocate_psymtab): Add comment.
12267         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12268         initializations.
12269         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12270
12271 2019-01-10  Tom Tromey  <tom@tromey.com>
12272
12273         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12274         Don't declare.
12275         * mipsread.c: Include mdebugread.h.
12276         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12277         Declare.
12278         * elfread.c: Include mdebugread.h.
12279
12280 2019-01-09  Tom Tromey  <tom@tromey.com>
12281
12282         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12283         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12284         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12285         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12286         (psym_lookup_symbol, psym_find_last_source_symtab)
12287         (psym_forget_cached_source_info, psym_print_stats)
12288         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12289         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12290         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12291         (psym_find_compunit_symtab_by_address)
12292         (maintenance_print_psymbols, maintenance_info_psymtabs)
12293         (maintenance_check_psymtabs): Use ranged for.
12294         * psymtab.h (class objfile_psymtabs): New.
12295         (require_partial_symbols): Return objfile_psymtabs.
12296         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12297
12298 2019-01-09  Tom Tromey  <tom@tromey.com>
12299
12300         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12301         (find_pc_mapped_section, list_overlays_command)
12302         (map_overlay_command, unmap_overlay_command)
12303         (simple_overlay_update): Use all_objfiles.
12304         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12305         * printcmd.c (info_symbol_command): Use all_objfiles.
12306         * objfiles.h (ALL_OBJSECTIONS): Remove.
12307         * maint.c (maintenance_translate_address): Use all_objfiles.
12308         * gcore.c (gcore_create_callback): Use all_objfiles.
12309         (objfile_find_memory_regions): Likewise.
12310
12311 2019-01-09  Tom Tromey  <tom@tromey.com>
12312
12313         * symtab.c (find_line_symtab, info_sources_command)
12314         (make_source_files_completion_list): Use objfile_compunits.
12315         * source.c (select_source_symtab): Use objfile_compunits.
12316         * objfiles.h (struct objfile): Update comment.
12317         (ALL_OBJFILES): Remove.
12318         (ALL_FILETABS): Remove.
12319         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12320         objfile_compunits.
12321
12322 2019-01-09  Tom Tromey  <tom@tromey.com>
12323
12324         * symmisc.c (print_objfile_statistics, dump_objfile)
12325         (maintenance_print_symbols): Use compunit_filetabs.
12326         * source.c (forget_cached_source_info_for_objfile): Use
12327         compunit_filetabs.
12328         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12329         (ALL_FILETABS): Use compunit_filetabs.
12330         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12331         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12332
12333 2019-01-09  Tom Tromey  <tom@tromey.com>
12334
12335         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12336         (compunit_filetabs): New.
12337         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12338         compunit_filetabs.
12339         (info_sources_command, make_source_files_completion_list): Remove
12340         declaration.
12341         * symmisc.c (print_objfile_statistics, dump_objfile)
12342         (maintenance_print_symbols): Remove declaration.
12343         (maintenance_info_symtabs): Use compunit_filetabs.
12344         (maintenance_info_line_tables): Likewise.
12345         * source.c (select_source_symtab): Change local variable name.
12346         (forget_cached_source_info_for_objfile): Remove declaration.
12347         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12348         * objfiles.c (objfile_relocate1): Remove declaration.
12349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12350         declaration.
12351         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12352         * coffread.c (coff_symtab_read): Remove declaration.
12353         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12354         compunit_filetabs.
12355
12356 2019-01-09  Tom Tromey  <tom@tromey.com>
12357
12358         * symtab.c (lookup_objfile_from_block)
12359         (find_pc_sect_compunit_symtab, search_symbols)
12360         (default_collect_symbol_completion_matches_break_on): Use
12361         objfile_compunits.
12362         * objfiles.h (ALL_COMPUNITS): Remove.
12363         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12364         * cp-support.c (add_symbol_overload_list_qualified): Use
12365         objfile_compunits.
12366         * ada-lang.c (ada_collect_symbol_completion_matches)
12367         (ada_add_global_exceptions): Use objfile_compunits.
12368
12369 2019-01-09  Tom Tromey  <tom@tromey.com>
12370
12371         * source.c (select_source_symtab)
12372         (forget_cached_source_info_for_objfile): Remove declaration.
12373         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12374         declaration.
12375         * maint.c (count_symtabs_and_blocks): Remove declaration.
12376         * cp-support.c (add_symbol_overload_list_qualified): Remove
12377         declaration.
12378         * coffread.c (coff_symtab_read): Remove declaration.
12379         * symtab.c (lookup_symbol_in_objfile_symtabs)
12380         (basic_lookup_transparent_type_1): Use objfile_compunits.
12381         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12382         (info_sources_command, search_symbols)
12383         (default_collect_symbol_completion_matches_break_on)
12384         (make_source_files_completion_list): Remove declaration.
12385         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12386         (ada_collect_symbol_completion_matches)
12387         (ada_add_global_exceptions): Remove declaration.
12388         * linespec.c (iterate_over_all_matching_symtabs): Use
12389         objfile_compunits.
12390         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12391         (class objfile_compunits): New.
12392         (ALL_COMPUNITS): Use objfile_compunits.
12393         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12394         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12395         objfile_compunits.
12396         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12397
12398 2019-01-09  Tom Tromey  <tom@tromey.com>
12399
12400         * symtab.c (search_symbols)
12401         (default_collect_symbol_completion_matches_break_on): Use
12402         objfile_msymbols.
12403         * ada-lang.c (ada_lookup_simple_minsym)
12404         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12405         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12406         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12407         objfile_msymbols.
12408         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12409         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12410         * objc-lang.c (find_methods): Use objfile_msymbols.
12411         (info_selectors_command, info_classes_command): Likewise.
12412         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12413         * objfiles.h (class objfile_msymbols): New.
12414         (ALL_OBJFILE_MSYMBOLS): Remove.
12415         (ALL_MSYMBOLS): Remove.
12416
12417 2019-01-09  Tom Tromey  <tom@tromey.com>
12418
12419         * common/next-iterator.h (next_adapter): Add Iterator template
12420         parameter.
12421         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12422         (class all_objfiles_safe): New.
12423         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12424         * objfiles.c (put_objfile_before): Update comment.
12425         (add_separate_debug_objfile): Likewise.
12426         (free_all_objfiles): Use all_objfiles_safe.
12427         (objfile_purge_solibs): Likewise.
12428
12429 2019-01-09  Tom Tromey  <tom@tromey.com>
12430
12431         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12432         (expand_symtab_containing_pc, lookup_static_symbol)
12433         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12434         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12435         all_objfiles.
12436         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12437         * breakpoint.c (create_overlay_event_breakpoint)
12438         (create_longjmp_master_breakpoint)
12439         (create_std_terminate_master_breakpoint)
12440         (create_exception_master_breakpoint): Use all_objfiles.
12441         * linux-thread-db.c (try_thread_db_load_from_pdir)
12442         (has_libpthread): Use all_objfiles.
12443         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12444         * linespec.c (iterate_over_all_matching_symtabs)
12445         (search_minsyms_for_name): Use all_objfiles.
12446         * maint.c (maintenance_info_sections): Use all_objfiles.
12447         * main.c (captured_main_1): Use all_objfiles.
12448         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12449         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12450         * guile/scm-pretty-print.c
12451         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12452         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12453         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12454         (maintenance_print_msymbols): Use all_objfiles.
12455         * source.c (select_source_symtab): Use all_objfiles.
12456         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12457         * symfile.c (remove_symbol_file_command)
12458         (expand_symtabs_matching, map_symbol_filenames): Use
12459         all_objfiles.
12460         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12461         all_objfiles.
12462         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12463         * objc-lang.c (find_methods): Use all_objfiles.
12464         * objfiles.c (have_partial_symbols, have_full_symbols)
12465         (have_minimal_symbols, qsort_cmp)
12466         (default_iterate_over_objfiles_in_search_order): Use
12467         all_objfiles.
12468         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12469         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12470         (maintenance_check_psymtabs): Use all_objfiles.
12471         (ALL_PSYMTABS): Remove.
12472         * compile/compile-object-run.c (do_module_cleanup): Use
12473         all_objfiles.
12474         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12475         * cp-support.c (add_symbol_overload_list_qualified): Use
12476         all_objfiles.
12477         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12478         Use all_objfiles.
12479         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12480         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12481         all_objfiles.
12482         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12483         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12484         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12485         Uses all_objfiles.
12486         * solib.c (solib_read_symbols): Use all_objfiles
12487
12488 2019-01-09  Tom Tromey  <tom@tromey.com>
12489
12490         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12491         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12492         all_objfiles.
12493         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12494         * symmisc.c (print_symbol_bcache_statistics)
12495         (print_objfile_statistics, maintenance_print_objfiles)
12496         (maintenance_info_symtabs, maintenance_check_symtabs)
12497         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12498         all_objfiles.
12499         * source.c (forget_cached_source_info): Use all_objfiles.
12500         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12501         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12502         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12503         * objfiles.c (update_section_map): Use all_objfiles.
12504         (shared_objfile_contains_address_p): Likewise.
12505         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12506         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12507
12508 2019-01-09  Tom Tromey  <tom@tromey.com>
12509
12510         * common/next-iterator.h: New file.
12511         * objfiles.h (class all_objfiles): New.
12512         (struct objfile_iterator): New.
12513
12514 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12515
12516         * NEWS: Move the description of the changed "frame", "select-frame",
12517          and "info frame" commands to the Changed commands section.
12518
12519 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12520
12521         * gdbtypes.c (check_stub_method_group): Remove handling of old
12522         mangling schemes.
12523         * linespec.c (find_methods): Likewise.
12524         * stabsread.c (read_member_functions): Likewise.
12525         * valops.c (search_struct_method): Likewise.
12526         (value_struct_elt_for_reference): Likewise.
12527         * NEWS: Mention this change.
12528
12529 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12530
12531         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12532         print_source_lines.
12533         * source.c (print_source_lines_base): Update line number check.
12534         (print_source_lines): New function.
12535         (source_lines_range::source_lines_range): New function.
12536         * source.h (class source_lines_range): New class.
12537         (print_source_lines): New declaration.
12538
12539 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12540
12541         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12542
12543 2019-01-08  Tom Tromey  <tom@tromey.com>
12544             Simon Marchi  <simon.marchi@ericsson.com>
12545
12546         PR gdb/24060
12547         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12548         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12549         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12550         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12551         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12552         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12553
12554 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12555
12556         * source.c (select_source_symtab): Move header comment to
12557         declaration in source.h.
12558         (forget_cached_source_info_for_objfile): Likewise.
12559         (forget_cached_source_info): Likewise.
12560         (identify_source_line): Likewise.
12561         * source.h (identify_source_line): Move declaration from symtab.h
12562         and add comment from source.c
12563         (print_source_lines): Likewise.
12564         (forget_cached_source_info_for_objfile): Likewise.
12565         (forget_cached_source_info): Likewise.
12566         (select_source_symtab): Likewise.
12567         (enum print_source_lines_flag): Move definition from symtab.h.
12568         * symtab.h (identify_source_line): Move declaration to source.h.
12569         (print_source_lines): Likewise.
12570         (forget_cached_source_info_for_objfile): Likewise.
12571         (forget_cached_source_info): Likewise.
12572         (select_source_symtab): Likewise.
12573         (enum print_source_lines_flag): Move definition to source.h.
12574         * tui/tui-hooks.c: Add 'source.h' include.
12575
12576 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12577
12578         * source.c (print_source_lines_base): Handle requests to print
12579         reverse line number sequences, and guard against empty lines
12580         string.
12581
12582 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12583
12584         * source.c (print_source_lines_base): Fix skip of '\r' if next
12585         character is '\n'.
12586
12587 2019-01-06  Tom Tromey  <tom@tromey.com>
12588
12589         * c-exp.y (struct c_parse_state) <macro_original_text,
12590         expansion_obstack>: New member.
12591         (macro_original_text, expansion_obstack): Remove globals.
12592         (scan_macro_expansion, scanning_macro_expansion)
12593         (finished_macro_expansion): Update.
12594         (scan_macro_cleanup): Remove.
12595         (yylex, c_parse): Update.
12596
12597 2019-01-06  Tom Tromey  <tom@tromey.com>
12598
12599         * c-exp.y (struct c_parse_state) <strings>: New member.
12600         (operator_stoken): Update.
12601
12602 2019-01-06  Tom Tromey  <tom@tromey.com>
12603
12604         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12605         (union type_stack_elt) <typelist_val>: Now a pointer to
12606         std::vector.
12607         (type_stack_cleanup): Don't declare.
12608         (push_typelist): Update.
12609         * parse.c (pop_typelist): Return a std::vector.
12610         (push_typelist): Take a std::vector.
12611         (follow_types): Update.  Do not free args.
12612         (type_stack_cleanup): Remove.
12613         * c-exp.y (struct c_parse_state): New.
12614         (cpstate): New global.
12615         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12616         (nonempty_typelist): Update.
12617         (func_mod): Create a new vector.
12618         (c_parse): Create a c_parse_state.
12619         (check_parameter_typelist): Do not delete params.
12620         (function_method): Update.  Do not delete type_list.
12621
12622 2019-01-06  Tom Tromey  <tom@tromey.com>
12623
12624         PR gdb/28155:
12625         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12626         check_typedef.
12627         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12628         (print_return_value): Likewise.
12629
12630 2019-01-05  Tom Tromey  <tom@tromey.com>
12631
12632         * contrib/cleanup_check.py: Remove.
12633         * contrib/gcc-with-excheck: Remove.
12634         * contrib/exsummary.py: Remove.
12635         * contrib/excheck.py: Remove.
12636
12637 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12638
12639         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12640         NULL. Initialize tpprev to NULL instead of assigning it
12641         to NULL on the next statement.
12642         * windows-nat.c (windows_delete_thread): Remove check for
12643         main_thread_id before printing thread exit notifications.
12644         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12645         Remove thread ID check against main_thread_id.
12646         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12647         windows_delete_thread.
12648         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12649
12650 2019-01-04  Tom Tromey  <tom@tromey.com>
12651
12652         * compile/compile.c (_initialize_compile): Use upper case for
12653         metasyntactic variables.
12654         * symmisc.c (_initialize_symmisc): Use upper case for
12655         metasyntactic variables.
12656         * psymtab.c (_initialize_psymtab): Use upper case for
12657         metasyntactic variables.
12658         * demangle.c (demangle_command): Use upper case for metasyntactic
12659         variables.
12660         (_initialize_demangler): Likewise.
12661         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12662         variables.
12663
12664 2019-01-03  Tom Tromey  <tom@tromey.com>
12665
12666         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12667
12668 2019-01-03  Tom Tromey  <tom@tromey.com>
12669
12670         * python/py-symtab.c (salpy_str): Update.
12671         (struct salpy_sal_object) <symtab>: Now a PyObject.
12672         (salpy_dealloc): Update.
12673         (del_objfile_sal): Use gdbpy_ref.
12674
12675 2019-01-03  Tom Tromey  <tom@tromey.com>
12676
12677         * python/py-type.c (convert_field): Use new_reference.  Return
12678         gdbpy_ref.
12679         (make_fielditem): Return gdbpy_ref.
12680         (typy_fields): Update.
12681         (typy_getitem): Update.
12682         (field_name): Return gdbpy_ref.  Use new_reference.
12683         (typy_iterator_iternext): Update.
12684
12685 2019-01-03  Tom Tromey  <tom@tromey.com>
12686
12687         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12688
12689 2019-01-03  Tom Tromey  <tom@tromey.com>
12690
12691         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12692         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12693         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12694         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12695         (pspy_set_type_printers): Likewise.
12696         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12697         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12698         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12699         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12700         (objfpy_set_type_printers): Likewise.
12701
12702 2019-01-03  Tom Tromey  <tom@tromey.com>
12703
12704         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12705         (gdbpy_print_stack): Use gdbpy_err_fetch.
12706         * python/python-internal.h (class gdbpy_err_fetch): New class.
12707         (class gdbpy_enter) <m_error_type, m_error_value,
12708         m_error_traceback>: Remove.
12709         <m_error>: New member.
12710         (gdbpy_exception_to_string): Don't declare.
12711         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12712         * python/py-value.c (convert_value_from_python): Use
12713         gdbpy_err_fetch.
12714         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12715         gdbpy_exception_to_string.
12716         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12717         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12718         gdbpy_err_fetch.
12719
12720 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12721
12722         * linux-nat.c (delete_lwp_cleanup): Delete.
12723         (struct lwp_deleter): New struct.
12724         (lwp_info_up): New typedef.
12725         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12726         lwp_info_up.
12727
12728 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12729
12730         * linux-fork.c (class scoped_switch_fork_info): New class.
12731         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12732
12733 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12734
12735         * valops.c (find_overload_match): Remove use of null_cleanup, and
12736         calls to do_cleanups.
12737
12738 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12739
12740         * compile/compile-cplus-types.c
12741         (compile_cplus_instance::decl_name): Handle changes to
12742         cp_func_name.
12743         * cp-support.c (cp_func_name): Update header comment, update
12744         return type.
12745         * cp-support.h (cp_func_name): Update return type in declaration.
12746         * valops.c (find_overload_match): Move temp_func local to top
12747         level of function and change its type.  Use temp_func to hold and
12748         delete temporary string obtained from cp_func_name.
12749
12750 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12751
12752         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12753         gdb::char_vector, remove cleanup, and update uses of `msg`.
12754
12755 2019-01-03  Jim Wilson  <jimw@sifive.com>
12756
12757         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12758
12759 2019-01-02  Tom Tromey  <tom@tromey.com>
12760
12761         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12762         (tdesc_parse_xml): Remove cleanups.
12763         * target-descriptions.h (make_cleanup_free_target_description):
12764         Don't declare.
12765         (target_desc_deleter): New struct.
12766         (target_desc_up): New typedef.
12767         * target-descriptions.c (target_desc_deleter::operator()): Rename
12768         from free_target_description.
12769         (make_cleanup_free_target_description): Remove.
12770
12771 2019-01-02  Tom Tromey  <tom@tromey.com>
12772
12773         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12774         constructor, destructor.
12775         (linespec_parser): Remove typedef.
12776         (~linespec_parser): Rename from linespec_parser_delete.
12777         (linespec_lex_to_end, linespec_complete_label)
12778         (linespec_complete): Update.
12779         (decode_line_full): Remove cleanups.
12780         (decode_line_1): Update.
12781
12782 2019-01-02  Tom Tromey  <tom@tromey.com>
12783
12784         * python/python-internal.h (inferior_to_inferior_object): Change
12785         return type.
12786         * python/py-exitedevent.c (create_exited_event_object): Update.
12787         * python/py-inferior.c (inferior_to_inferior_object): Return
12788         gdbpy_ref.
12789         (python_new_inferior, python_inferior_deleted)
12790         (thread_to_thread_object, delete_thread_object)
12791         (build_inferior_list, gdbpy_selected_inferior): Update.
12792         * python/py-infthread.c (create_thread_object): Update.  Also fail
12793         if inferior_to_inferior_object fails.
12794
12795 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12796
12797         * inferior.h (class inferior) <displaced_step_state>: New field.
12798         * infrun.h (struct displaced_step_state): Move here from
12799         infrun.c.  Initialize fields, add constructor.
12800         <inf>: Remove field.
12801         <reset>: New method.
12802         * infrun.c (struct displaced_step_inferior_state): Move to
12803         infrun.h.
12804         (displaced_step_inferior_states): Remove.
12805         (get_displaced_stepping_state): Adust.
12806         (displaced_step_in_progress_any_inferior): Adjust.
12807         (displaced_step_in_progress_thread): Adjust.
12808         (displaced_step_in_progress): Adjust.
12809         (add_displaced_stepping_state): Remove.
12810         (get_displaced_step_closure_by_addr): Adjust.
12811         (remove_displaced_stepping_state): Remove.
12812         (infrun_inferior_exit): Call displaced_step_state.reset.
12813         (use_displaced_stepping): Don't check for NULL.
12814         (displaced_step_prepare_throw): Call
12815         get_displaced_stepping_state.
12816         (displaced_step_fixup): Don't check for NULL.
12817         (prepare_for_detach): Don't check for NULL.
12818
12819 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12820
12821         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12822          in case of call that did not complete.
12823
12824 2019-01-02  Andrey Utkin  <autkin@undo.io>
12825
12826         * symfile.c (find_separate_debug_file): Fix search of debug files for
12827         remote debuggee.
12828
12829 2019-01-02  Tom Tromey  <tom@tromey.com>
12830
12831         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12832         indentation.
12833         * python/py-frame.c (frapy_older): Remove cast.
12834         (frapy_newer): Likewise.
12835         * python/py-breakpoint.c (local_setattro): Remove cast.
12836         * python/py-arch.c (archpy_name): Remove local variable.
12837         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12838
12839 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12840
12841         * unittests/basic_string_view/element_access/char/empty.cc:
12842         Fix year range in copyright header.
12843
12844 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12845
12846         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12847         Delete.
12848         <operator==>: Update with for removed field.
12849         <hash>: Likewise.
12850         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12851         <isa_features>: ...this.
12852         <abi_features>: New field.
12853         (riscv_isa_flen): Update comment.
12854         (riscv_abi_xlen): New declaration.
12855         (riscv_abi_flen): New declaration.
12856         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12857         isa_features.
12858         (riscv_abi_xlen): New function.
12859         (riscv_isa_flen): Update to get answer from isa_features.
12860         (riscv_abi_flen): New function.
12861         (riscv_has_fp_abi): Update to get answer from abi_features.
12862         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12863         xlen and flen.
12864         (riscv_call_info) <xlen, flen>: Update comment.
12865         (riscv_call_arg_struct): Remove invalid assertions
12866         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12867         is removed.
12868         (riscv_gdbarch_init): Gather isa features and abi features
12869         separately, ensure both match on the gdbarch when reusing an old
12870         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12871         a target with 64-bit float hardware.
12872
12873 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12874
12875         * source.c (search_command_helper): Stop reverse search
12876         when line 1 has been searched.
12877
12878 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12879
12880         * record-full.c (record_full_base_target::close): Rewrite
12881         record_full_core_buf_list free logic.
12882
12883 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12884
12885         * break-catch-syscall.c (print_one_catch_syscall): xfree
12886         the last text.
12887
12888 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12889
12890         * top.c (print_gdb_version): Update Copyright year in version
12891         message.
12892
12893 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12894
12895         Update copyright year range in all GDB files.
12896
12897 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12898
12899         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12900
12901 For older changes see ChangeLog-2018.
12902 \f
12903 Local Variables:
12904 mode: change-log
12905 left-margin: 8
12906 fill-column: 74
12907 version-control: never
12908 coding: utf-8
12909 End:
12910