gdb/ChangeLog

   1 2019-08-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * printcmd.c (do_one_display, info_display_command): Update.
   4         * block.h (contained_in): Return bool.  Add allow_nested
   5         parameter.
   6         * block.c (contained_in): Return bool.  Add allow_nested
   7         parameter.
   8
   9 2019-08-19  Tom Tromey  <tom@tromey.com>
  10
  11         * configure: Rebuild.
  12         * configure.ac: Disallow the combination of -static-libstdc++ and
  13         source highlight.
  14         * source-cache.c (get_language_name): Handle rust.
  15         (source_cache::get_source_lines): Ignore highlighting exceptions.
  16
  17 2019-08-16  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  20         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  21         (struct tui_source_window_base) <make_visible, refresh_window,
  22         resize>: Remove methods.
  23         <execution_info>: Remove field.
  24         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  25         (tui_show_source_line, tui_source_window_base)
  26         (~tui_source_window_base): Update.
  27         (tui_source_window_base::resize)
  28         (tui_source_window_base::make_visible)
  29         (tui_source_window_base::refresh_window): Remove.
  30         (tui_source_window_base::update_exec_info): Update.
  31         * tui/tui-source.c (tui_source_window::set_contents): Update.
  32         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  33
  34 2019-08-16  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  37         deprecated_query_hook.
  38
  39 2019-08-16  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  42         (tui_update_source_windows_with_line): Update.
  43         * tui/tui-source.h (struct tui_source_window)
  44         <show_symtab_source>: Declare.
  45         (tui_show_symtab_source): Don't declare.
  46         * tui/tui-source.c (tui_show_symtab_source): Rename from
  47         tui_show_symtab_source.
  48
  49 2019-08-16  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-winsource.h (struct tui_source_window_base)
  52         <set_contents>: Declare.
  53         * tui/tui-winsource.c
  54         (tui_source_window_base::update_source_window_as_is): Update.
  55         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  56         Declare.
  57         (tui_set_source_content): Don't declare.
  58         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  59         tui_set_source_content.
  60         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  61         Declare.
  62         (tui_set_disassem_content): Don't declare.
  63         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  64         tui_set_disassem_content.
  65
  66 2019-08-16  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-winsource.h (struct tui_source_window_base)
  69         <update_breakpoint_info>: Declare.
  70         (tui_update_breakpoint_info): Don't declare.
  71         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  72         (tui_update_all_breakpoint_info): Update.
  73         (tui_source_window_base::update_breakpoint_info): Rename from
  74         tui_update_breakpoint_info.
  75         (tui_source_window_base::update_exec_info): Update.
  76
  77 2019-08-16  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.h (struct tui_source_window_base)
  80         <update_source_window>: Declare.
  81         (tui_update_source_window): Don't declare.
  82         * tui/tui-winsource.c
  83         (tui_source_window_base::update_source_window): Rename from
  84         tui_update_source_window.
  85         (tui_source_window_base::rerender): Update.
  86         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  87         * tui/tui-disasm.c (tui_show_disassem)
  88         (tui_show_disassem_and_update_source)
  89         (tui_disasm_window::maybe_update): Update.
  90
  91 2019-08-16  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-winsource.h (struct tui_source_window_base)
  94         <update_source_window_as_is>: Declare.
  95         (tui_update_source_window_as_is): Don't declare.
  96         * tui/tui-winsource.c (tui_update_source_window): Update
  97         (tui_source_window_base::update_source_window_as_is): Rename from
  98         tui_update_source_window_as_is.
  99         (tui_source_window_base::refill): Update.
 100         * tui/tui-source.c (tui_show_symtab_source): Update.
 101         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 102         Update.
 103
 104 2019-08-16  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.h (tui_update_source_window)
 107         (tui_update_source_window_as_is): Remove "noerror" parameter.
 108         * tui/tui-winsource.c (tui_update_source_window)
 109         (tui_update_source_window_as_is): Remove "noerror" parameter.
 110         (tui_update_source_windows_with_addr)
 111         (tui_update_source_windows_with_line)
 112         (tui_source_window_base::rerender)
 113         (tui_source_window_base::refill): Update.
 114         * tui/tui-source.h (tui_set_source_content)
 115         (tui_show_symtab_source): Remove "noerror" parameter.
 116         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 117         parameter.
 118         (tui_show_symtab_source): Likewise.
 119         (tui_source_window::maybe_update): Update.
 120         * tui/tui-disasm.c (tui_show_disassem)
 121         (tui_show_disassem_and_update_source)
 122         (tui_disasm_window::do_scroll_vertical)
 123         (tui_disasm_window::maybe_update): Update.
 124
 125 2019-08-16  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui.c (tui_is_window_visible): Update.
 128         * tui/tui-wingeneral.c (tui_make_window)
 129         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 130         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 131         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 132         (tui_set_win_height_command, parse_scrolling_args): Update.
 133         * tui/tui-source.c (tui_source_window::style_changed): Update.
 134         * tui/tui-regs.c (tui_show_registers)
 135         (tui_data_window::first_data_item_displayed)
 136         (tui_data_window::delete_data_content_windows)
 137         (tui_check_register_values, tui_reg_command): Update.
 138         * tui/tui-disasm.c (tui_show_disassem): Update.
 139         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 140         method.
 141         <is_visible>: Remove field.
 142         * tui/tui-data.c (tui_next_win, tui_prev_win)
 143         (tui_delete_invisible_windows): Update.
 144
 145 2019-08-16  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-winsource.h (struct tui_source_window_base)
 148         <m_has_locator>: Remove.
 149         * tui/tui-layout.c (show_source_disasm_command, show_data)
 150         (show_source_or_disasm_and_command): Update.
 151
 152 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 153
 154         * NEWS (Other MI changes): New subsection.
 155         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 156         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 157         * arch-utils.c (default_get_pc_address_flags): New function.
 158         * arch-utils.h (default_get_pc_address_flags): New declaration.
 159         * gdbarch.sh: Add get_pc_address_flags.
 160         * gdbarch.c: Regenerate.
 161         * gdbarch.h: Likewise.
 162         * stack.c (print_pc): New function.
 163         (print_frame_info) (print_frame): Call print_pc.
 164
 165 2019-08-16  Tom de Vries  <tdevries@suse.de>
 166
 167         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 168         print_objfile_section_info.
 169
 170 2019-08-15  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 173         calling update_cmdwin_start_line.
 174         * tui/tui-winsource.h (struct tui_source_window_base)
 175         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 176         <rerender>: Declare.
 177         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 178         Call rerender.
 179         (tui_source_window_base::set_new_height): Remove.
 180         (tui_source_window_base::rerender): Rename from
 181         do_make_visible_with_new_height.
 182         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 183         resize method.
 184         (tui_win_info::make_invisible_and_set_new_height)
 185         (tui_win_info::make_visible_with_new_height): Remove.
 186         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 187         Declare.
 188         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 189         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 190         do_make_visible_with_new_height>: Don't declare.
 191         <rerender>: Declare.
 192         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 193         set_new_height.
 194         (tui_data_window::do_make_visible_with_new_height): Remove.
 195         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 196         call tui_show_locator_content.
 197         (tui_gen_win_info::resize): Call rerender.
 198         (show_source_or_disasm_and_command): Don't call
 199         tui_show_locator_content.
 200         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 201         method.
 202         (struct tui_win_info) <rerender>: Declare.
 203         <set_new_height, make_invisible_and_set_new_height,
 204         make_visible_with_new_height>: Don't declare.
 205         * tui/tui-data.c (tui_win_list::rerender): New method.
 206         * tui/tui-command.h (struct tui_cmd_window)
 207         <do_make_visible_with_new_height>: Don't declare.
 208         * tui/tui-command.c
 209         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 210
 211 2019-08-15  Tom Tromey  <tromey@adacore.com>
 212
 213         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 214         * ada-lang.c (ada_enum_name): Likewise.
 215
 216 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 217
 218         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 219         leading underscore.
 220         (GdbOutputErrorFile): Likewise.
 221         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 222         accordingly.
 223         (execute_unwinders): Rename to have a leading underscore.
 224         (auto_load_packages): Likewise.
 225         (global scope): Adjust call to auto_load_packages accordingly.
 226         (GdbSetPythonDirectory): Likewise.
 227         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 228         instead of execute_unwinders.
 229
 230 2019-08-15  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 233         (show_data): Don't change window visibility.
 234         (tui_gen_win_info::resize): Remove special case for command
 235         window.  Use wresize, when available.
 236         (show_source_or_disasm_and_command): Don't change window
 237         visibility.
 238         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 239         <make_visible>: New method.
 240         * tui/tui-command.c (tui_cmd_window::resize): New method.
 241
 242 2019-08-15  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 245         (struct tui_source_windows): New.
 246         * tui/tui-winsource.c (tui_display_main): Update.
 247         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 248         (new_height_ok, parse_scrolling_args): Update.
 249         * tui/tui-layout.c (show_layout, show_data): Update.
 250         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 251         (tui_add_to_source_windows): Don't declare.
 252         * tui/tui-data.c (source_windows, tui_source_windows)
 253         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 254
 255 2019-08-15  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 258         Rename from reset.
 259         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 260         * tui/tui-layout.c (show_source_disasm_command, show_data):
 261         Update.
 262         (tui_gen_win_info::resize): Rename.
 263         (show_source_or_disasm_and_command): Update.
 264         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 265         reset.
 266
 267 2019-08-15  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 270         * tui/tui-interp.c (tui_interp::init): Don't call
 271         tui_initialize_static_data.
 272         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 273
 274 2019-08-15  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 277         examine tui_win_list.
 278
 279 2019-08-15  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 282         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 283         tui_clear_source_content.
 284         (tui_clear_source_content): Remove.
 285         (tui_source_window_base::do_erase_source_content): Hoist call to
 286         content.clear().
 287         * tui/tui-stack.c (tui_show_frame_info): Don't call
 288         tui_clear_source_content.
 289
 290 2019-08-15  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.h (struct tui_source_window_base)
 293         <do_erase_source_content>: New method.
 294         <erase_source_content>: New method.
 295         (tui_erase_source_content): Don't declare.
 296         * tui/tui-winsource.c (tui_clear_source_content): Update.
 297         (tui_source_window_base::do_erase_source_content): Rename from
 298         tui_erase_source_content.
 299         (tui_source_window_base::show_source_content): Update.
 300         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 301         * tui/tui-source.h (struct tui_source_window)
 302         <erase_source_content>: New method.
 303         * tui/tui-disasm.h (struct tui_disasm_window)
 304         <erase_source_content>: New method.
 305
 306 2019-08-15  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 309         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 310         constructor.
 311         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 312         * tui/tui-source.c (tui_set_source_content): Update.
 313         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 314
 315 2019-08-15  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 318         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 319         tui-source.c.
 320         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 321         Declare.
 322         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 323         method.
 324         (tui_source_window::maybe_update): Update.
 325
 326 2019-08-15  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 329         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 330         tui-disasm.c.
 331         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 332         Declare.
 333         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 334         method.
 335         (tui_disasm_window::maybe_update): Update.
 336
 337 2019-08-15  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.h (struct tui_source_window_base)
 340         <maybe_update>: Declare.
 341         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 342         method.
 343         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 344         Declare.
 345         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 346         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 347         Declare.
 348         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 349
 350 2019-08-15  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 353
 354 2019-08-15  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-wingeneral.c: Include tui-stack.h.
 357         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 358         (struct tui_locator_window): Move from tui-data.h.
 359         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 360         (tui_initialize_static_data): Move from tui-data.c.
 361         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 362         (struct tui_locator_window): Move to tui-stack.c.
 363         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 364         (tui_initialize_static_data): Move to tui-stack.c.
 365
 366 2019-08-15  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-layout.c (show_source_disasm_command)
 369         (show_source_or_disasm_and_command): Use make_visible method, not
 370         tui_make_window.
 371         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 372         Remove.
 373
 374 2019-08-15  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-wingeneral.h (tui_make_window): Update.
 377         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 378         parameter.
 379         (tui_gen_win_info::make_visible): Update.
 380         * tui/tui-regs.c (tui_data_window::display_registers_from):
 381         Update.
 382         * tui/tui-layout.c (show_source_disasm_command)
 383         (show_source_or_disasm_and_command): Update.
 384         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 385         (enum tui_box): Remove.
 386         (struct tui_win_info) <can_box>: New method.
 387         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 388         method.
 389
 390 2019-08-15  Tom de Vries  <tdevries@suse.de>
 391
 392         * linux-nat-trad.c: Include gdbarch.h.
 393
 394 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 395
 396         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 397         register sizes.
 398
 399 2019-08-14  Tom Tromey  <tromey@adacore.com>
 400
 401         * darwin-nat.c: Include gdbarch.h.
 402         * darwin-nat-info.c: Include gdbarch.h.
 403
 404 2019-08-13  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 407         Remove.
 408         * tui/tui-data.c (tui_initialize_static_data): Update.
 409
 410 2019-08-13  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (struct tui_exec_info_window)
 413         <~tui_exec_info_window, maybe_allocate_content, get_content,
 414         m_content>: Remove.
 415         (struct tui_source_window_base) <set_exec_info_content,
 416         show_exec_info_content>: Don't declare.
 417         * tui/tui-winsource.c
 418         (tui_exec_info_window::maybe_allocate_content): Remove.
 419         (tui_source_window_base::update_exec_info): Rename from
 420         set_exec_info_content.
 421         (tui_source_window_base::show_exec_info_content)
 422         (tui_source_window_base::update_exec_info): Remove.
 423
 424 2019-08-13  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 427         declare.
 428         * tui/tui-winsource.c (tui_update_source_window_as_is)
 429         (tui_update_source_windows_with_addr, tui_erase_source_content):
 430         Update.
 431         (tui_clear_exec_info_content): Remove.
 432
 433 2019-08-13  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 436         declare.
 437         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 438         call tui_erase_exec_info_content.
 439         (tui_clear_exec_info_content): Rename from
 440         tui_erase_exec_info_content.
 441         (tui_clear_exec_info_content): Delete.
 442
 443 2019-08-13  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (struct tui_source_window_base)
 446         <show_exec_info_content>: Declare.
 447         (tui_show_exec_info_content): Don't declare.
 448         * tui/tui-winsource.c
 449         (tui_source_window_base::show_exec_info_content): Rename from
 450         tui_show_exec_info_content.
 451         (tui_source_window_base::update_exec_info): Update.
 452
 453 2019-08-13  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 456         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 457         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 458         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 459         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 460         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 461         ... here.
 462
 463 2019-08-13  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-winsource.h (struct tui_source_window_base)
 466         <update_exec_info>: Declare.
 467         (tui_update_exec_info): Don't declare.
 468         * tui/tui-winsource.c (tui_update_source_window_as_is)
 469         (tui_source_window_base::refresh_all)
 470         (tui_update_all_breakpoint_info): Update.
 471         (tui_source_window_base::update_exec_info): Rename from
 472         tui_update_exec_info.
 473         * tui/tui-stack.c (tui_show_frame_info): Update.
 474
 475 2019-08-13  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.h (struct tui_source_window_base)
 478         <set_exec_info_content>: Declare.
 479         (tui_set_exec_info_content): Don't declare.
 480         * tui/tui-winsource.c
 481         (tui_source_window_base::set_exec_info_content): Rename from
 482         tui_set_exec_info_content.
 483         (tui_update_exec_info): Update.
 484
 485 2019-08-13  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-winsource.h (struct tui_source_window_base)
 488         <show_source_content>: Declare.
 489         (tui_show_source_content): Don't declare.
 490         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 491         (tui_source_window_base::show_source_content): Rename from
 492         tui_show_source_content.
 493         (tui_source_window_base::refresh_all): Update.
 494         * tui/tui-layout.c (show_source_disasm_command)
 495         (show_source_or_disasm_and_command): Update.
 496
 497 2019-08-13  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-winsource.c (tui_erase_source_content)
 500         (tui_show_source_content, tui_source_window_base::refresh_all):
 501         Update.
 502         * tui/tui-wingeneral.h
 503         (tui_check_and_display_highlight_if_needed): Don't declare.
 504         * tui/tui-wingeneral.c
 505         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 506         check_and_display_highlight_if_needed.
 507         * tui/tui-win.c (tui_rehighlight_all)
 508         (tui_win_info::make_visible_with_new_height): Update.
 509         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 510         (tui_data_window::erase_data_content)
 511         (tui_data_window::display_all_data): Update.
 512         * tui/tui-data.h (struct tui_win_info)
 513         <check_and_display_highlight_if_needed>: Declare.
 514
 515 2019-08-13  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-win.c (tui_resize_all): Call
 518         tui_delete_invisible_windows.
 519         * tui/tui-layout.c (show_layout): Call
 520         tui_delete_invisible_windows.
 521         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 522         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 523
 524 2019-08-13  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 527         tui_add_win_to_layout.
 528
 529 2019-08-13  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 532         * tui/tui-layout.c (tui_default_win_height): Now static.
 533
 534 2019-08-13  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 537         single switch.
 538         (show_source_disasm_command, show_source_or_disasm_and_command):
 539         Don't check current layout.
 540
 541 2019-08-13  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-wingeneral.c (make_all_visible): Remove.
 544         (tui_make_all_invisible): Simplify.
 545         * tui/tui-layout.c (tui_make_all_invisible): Move from
 546         tui-wingeneral.c; simplify.
 547         (show_layout): Hoist call to tui_make_all_invisible.
 548         (show_data): Don't call tui_make_all_invisible.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 553         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 554
 555 2019-08-13  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 558         tui-data.c.
 559         (show_source_disasm_command, show_data)
 560         (show_source_or_disasm_and_command): Don't use
 561         tui_set_current_layout_to.
 562         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 563         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 564         tui-layout.c.
 565         (tui_set_current_layout_to): Remove.
 566
 567 2019-08-13  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-layout.c (tui_set_layout): Update.
 570         * tui/tui-data.h (struct tui_layout_def): Remove.
 571         (tui_layout_def): Don't declare.
 572         * tui/tui-data.c (layout_def): Remove.
 573         (tui_layout_def): Remove.
 574
 575 2019-08-13  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-winsource.h (struct tui_source_window_base)
 578         <clear_detail>: No longer "override".
 579         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 580         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 581         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 582         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 583         Remove.
 584         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 585
 586 2019-08-13  Tom Tromey  <tromey@adacore.com>
 587
 588         * tracepoint.c: Don't include readline.h or history.h.
 589
 590 2019-08-12  Tom Tromey  <tom@tromey.com>
 591
 592         * configure: Rebuild.
 593         * configure.ac: Check for readline 7.
 594         * NEWS: Mention readline 7 requirement.
 595         * README: Update.
 596
 597 2019-08-12  Tom Tromey  <tom@tromey.com>
 598
 599         * mingw-hdep.c (gdb_select): Remove readline hack.
 600
 601 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 602
 603         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 604         when the function fails.
 605
 606 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 607
 608         * s390-tdep.c (s390_type_align): New function.
 609         (s390_gdbarch_init): Set it as type_align gdbarch method.
 610
 611 2019-08-09  Tom de Vries  <tdevries@suse.de>
 612
 613         PR gdb/24591
 614         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 615         pc_low with relocation offset.
 616
 617 2019-08-07  Tom Tromey  <tromey@adacore.com>
 618
 619         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 620         (print_frame_args): Update.
 621         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 622         Update.
 623         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 624         * frame.h (struct frame_arg): Add initializers.
 625         <error>: Now a unique_xmalloc_ptr.
 626
 627 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 628
 629         * NEWS: Expand the Pointer Authentication entry.
 630         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 631         (aarch64_frame_unmask_lr): ... to this.
 632         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 633         Call aarch64_frame_unmask_lr.
 634         * frame.c (struct frame_info): Add "masked" variable.
 635         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 636         (fprint_frame): Check for masked pc.
 637         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 638         declarations.
 639         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 640         * stack.c (print_frame): Check for masked pc.
 641
 642 2019-08-06  Tom Tromey  <tom@tromey.com>
 643
 644         * stabsread.c (patch_block_stabs, read_one_struct_field)
 645         (read_enum_type): Use obstack_strndup.
 646         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 647         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 648         * dwarf2read.c (guess_full_die_structure_name)
 649         (anonymous_struct_prefix): Use obstack_strndup.
 650         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 651         * c-exp.y (yylex): Use obstack_strndup.
 652         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 653         (write_var_or_type): Use obstack_strndup.
 654
 655 2019-08-06  Tom Tromey  <tom@tromey.com>
 656
 657         * symfile.c (reread_symbols): Use obstack_strdup.
 658         * stabsread.c (read_type): Use obstack_strdup.
 659         * gdb_obstack.h (obstack_strdup): New overload.
 660         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 661         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 662         (dwarf2_canonicalize_name): Use obstack_strdup.
 663         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 664         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 665         Use obstack_strdup.
 666
 667 2019-08-06  Tom Tromey  <tom@tromey.com>
 668
 669         * gdb_obstack.h (obstack_strdup): Define.
 670         * gdb_obstack.c (obstack_strdup): Don't define.
 671
 672 2019-08-06  Tom Tromey  <tom@tromey.com>
 673
 674         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 675         obstack_strdup.
 676         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 677         obstack_strdup.
 678         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 679         * stabsread.c (common_block_start): Use obstack_strdup.
 680         * objfiles.c (set_objfile_main_name, objfile): Use
 681         obstack_strdup.
 682         * namespace.c (add_using_directive): Use obstack_strdup.
 683         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 684         * jit.c (finalize_symtab): Use obstack_strdup.
 685         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 686         (guess_partial_die_structure_name, partial_die_info::fixup)
 687         (dwarf2_name): Use obstack_strdup.
 688         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 689         obstack_strdup.
 690         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 691         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 692         obstack_strdup.
 693         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 694
 695 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 696
 697         * unittests/help-doc-selftests.c: New file.
 698         * Makefile.in: Add the new file.
 699
 700 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 701
 702         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 703         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 704         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 705         the trailing '.' is not output, and the first character is uppercased.
 706         (print_help_for_command): Update call to print_doc_line.
 707         (print_doc_of_command): Likewise.
 708         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 709         * cli/cli-option.c (append_indented_doc): Do not append newline.
 710         (build_help_option): Append newline after first appended_indented_doc
 711         only if a second call is done.
 712         (build_help): Append 2 new lines before each option, except the first
 713         one.
 714         * compile/compile.c (_initialize_compile): Add new lines after
 715         %OPTIONS%, when not at the end of the help.
 716         Change help doc or code
 717         producing the help doc to respect the invariants.
 718         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 719         Also removed the new line after 'Options:', as all other commands
 720         do not put an empty line between 'Options:' and the first option.
 721         * printcmd.c (_initialize_printcmd): Likewise.
 722         * stack.c (_initialize_stack): Likewise.
 723         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 724         incorrectly telling COMMAND is optional.
 725         * ada-lang.c (_initialize_ada_language): Change help doc or code
 726         producing the help doc to respect the invariants.
 727         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 728         * breakpoint.c (_initialize_breakpoint): Likewise.
 729         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 730         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 731         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 732         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 733         _initialize_cli_style): Likewise.
 734         * corelow.c (core_target_info): Likewise.
 735         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 736         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 737         * filesystem.c (_initialize_filesystem): Likewise.
 738         * frame.c (_initialize_frame): Likewise.
 739         * gnu-nat.c (add_task_commands): Likewise.
 740         * infcall.c (_initialize_infcall): Likewise.
 741         * infcmd.c (_initialize_infcmd): Likewise.
 742         * interps.c (_initialize_interpreter): Likewise.
 743         * language.c (_initialize_language): Likewise.
 744         * linux-fork.c (_initialize_linux_fork): Likewise.
 745         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 746         * maint.c (_initialize_maint_cmds): Likewise.
 747         * memattr.c (_initialize_mem): Likewise.
 748         * printcmd.c (_initialize_printcmd): Likewise.
 749         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 750         _RegEx): Likewise.
 751         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 752         * record-btrace.c (_initialize_record_btrace): Likewise.
 753         * record-full.c (_initialize_record_full): Likewise.
 754         * record.c (_initialize_record): Likewise.
 755         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 756         * regcache.c (_initialize_regcache): Likewise.
 757         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 758         _initialize_remote): Likewise.
 759         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 760         * serial.c (_initialize_serial): Likewise.
 761         * skip.c (_initialize_step_skip): Likewise.
 762         * source.c (_initialize_source): Likewise.
 763         * stack.c (_initialize_stack): Likewise.
 764         * symfile.c (_initialize_symfile): Likewise.
 765         * symtab.c (_initialize_symtab): Likewise.
 766         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 767         * top.c (init_main): Likewise.
 768         * tracefile-tfile.c (tfile_target_info): Likewise.
 769         * tracepoint.c (_initialize_tracepoint): Likewise.
 770         * tui/tui-win.c (_initialize_tui_win): Likewise.
 771         * utils.c (add_internal_problem_command): Likewise.
 772         * valprint.c (value_print_option_defs): Likewise.
 773
 774 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 775
 776         PR build/24886
 777         * configure.ac: Drop enable-libmcheck support.
 778         * configure, config.in: Rebuild.
 779         * libmcheck.m4: Remove.
 780         * acinclude.m4: Don't include it.
 781         * Makefile.in: Don't distribute it.
 782         * top.c (print_gdb_configuration): Don't mention it.
 783
 784 2019-08-06  Tom Tromey  <tom@tromey.com>
 785
 786         * utils.c (set_output_style): Sometimes pass stream to
 787         emit_style_escape.
 788         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 789         * record-btrace.c (btrace_insn_history): Update.
 790         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 791         method.
 792         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 793         Update initializers.
 794         <m_uiout>: New field.
 795         <m_di>: Move lower.
 796         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 797         Remove "uiout" parameter.
 798         (dump_insns): Update.
 799         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 800         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 801
 802 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 803
 804         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 805         (error_in_psymtab_expansion): Likewise.
 806         (lookup_symbol_via_quick_fns): Likewise.
 807         (basic_lookup_transparent_type_quick): Likewise.
 808         (basic_lookup_transparent_type_1): Likewise.
 809
 810 2019-08-06  Tom Tromey  <tromey@adacore.com>
 811
 812         * source.c (last_source_error): Now bool.
 813         (print_source_lines_base): Make "noprint" bool.  Only open
 814         source file when last_source_visited changes.
 815
 816 2019-08-06  Tom Tromey  <tromey@adacore.com>
 817
 818         * annotate.c (annotate_source_line): Use g_source_cache.
 819         * source-cache.c (source_cache::get_plain_source_lines): Change
 820         parameters.  Populate m_offset_cache.
 821         (source_cache::ensure): New method.
 822         (source_cache::get_line_charpos): New method.
 823         (extract_lines): Move lower.  Change parameters.
 824         (source_cache::get_source_lines): Move lower.
 825         * source-cache.h (class source_cache): Update comment.
 826         <get_line_charpos>: New method.
 827         <get_source_lines>: Update comment.
 828         <clear>: Clear m_offset_cache.
 829         <get_plain_source_lines>: Change parameters.
 830         <ensure>: New method
 831         <m_offset_cache>: New member.
 832         * source.c (forget_cached_source_info_for_objfile): Update.
 833         (info_source_command): Use g_source_cache.
 834         (find_source_lines, open_source_file_with_line_charpos): Remove.
 835         (print_source_lines_base, search_command_helper): Use g_source_cache.
 836         * source.h (open_source_file_with_line_charpos): Don't declare.
 837         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 838         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 839         Use g_source_cache.
 840
 841 2019-08-06  Tom Tromey  <tromey@adacore.com>
 842
 843         * source-cache.c (source_cache::get_plain_source_lines):
 844         Remove "first_line" and "last_line" parameters.
 845         (source_cache::get_source_lines): Cache plain text.
 846         * source-cache.h (class source_cache)
 847         <get_plain_source_lines>: Update.
 848
 849 2019-08-06  Tom Tromey  <tromey@adacore.com>
 850
 851         * source-cache.c (extract_lines): No longer a method.
 852         Changed type of parameter.  Include final newline.
 853         (selftests::extract_lines_test): New function.
 854         (_initialize_source_cache): Likewise.
 855         * source-cache.h (class source_cache)
 856         <extract_lines>: Don't declare.
 857
 858 2019-08-06  Tom Tromey  <tromey@adacore.com>
 859
 860         * breakpoint.c (init_breakpoint_sal): Update.
 861         (breakpoint): Update.
 862         * breakpoint.h (struct breakpoint) <filter>: Now a
 863         unique_xmalloc_ptr.
 864
 865 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 866
 867         * NEWS: Mention dictionary access on blocks.
 868         * python/py-block.c (blpy_getitem): New function.
 869         (block_object_as_mapping): New struct.
 870         (block_object_type): Use new struct for tp_as_mapping field.
 871
 872 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 873
 874         * objfiles.h (objfile): Add a comment describing partial symbols.
 875
 876 2019-08-05  Tom Tromey  <tromey@adacore.com>
 877
 878         * compile/compile.c (_initialize_compile): Use _(), not N_().
 879         * thread.c (_initialize_thread): Use _(), not N_().
 880         * stack.c (_initialize_stack): Use _(), not N_().
 881         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 882
 883 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 884
 885         * dwarf2read.c (struct dw2_symtab_iterator):
 886         <want_specific_block>: Remove.
 887         <block_index>: Change type to gdb::optional.
 888         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 889         change type of BLOCK_INDEX parameter to gdb::optional.
 890         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 891         (dw2_lookup_symbol): Don't pass argument for
 892         WANT_SPECIFIC_BLOCK.
 893         (dw2_expand_symtabs_for_function): Don't pass argument for
 894         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 895         (class dw2_debug_names_iterator)
 896         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 897         parameter, change BLOCK_INDEX type to gdb::optional.
 898         <m_want_specific_block>: Remove.
 899         <m_block_index>: Change type to gdb::optional.
 900         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 901         gdb::optional.  Re-write in function of gdb::optional.
 902         (dw2_debug_names_lookup_symbol): Don't pass argument for
 903         WANT_SPECIFIC_BLOCK.
 904         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 905         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 906         BLOCK_INDEX.
 907
 908 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 909
 910         * NEWS: Mention changes to "info sources" command.
 911
 912 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 913
 914         * symtab.c (filename_partial_match_opts): New struct type.
 915         (struct output_source_filename_data): New members
 916         regexp, c_regexp, partial_match.
 917         (output_source_filename): Use new members to decide to print file.
 918         (info_sources_option_defs): New variable.
 919         (make_info_sources_options_def_group, print_info_sources_header,
 920         info_sources_command_completer):
 921         New functions.
 922         (info_sources_command): Read new optional arguments.
 923         (_initialize_symtab): Update info sources help.
 924
 925 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 926
 927         * ada-lang.c (exception_support_info_v0): Renamed from...
 928         (default_exception_support_info): ... this.  Create new
 929         definition for v1.
 930         (ada_has_this_exception_support): Look up catch_handlers_sym.
 931         (ada_exception_support_info_sniffer): Try v0 after default.
 932
 933 2019-08-01  Tom Tromey  <tromey@adacore.com>
 934
 935         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 936         gdbarch.h.
 937
 938 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 939
 940         * s12z-tdep.c: Fix include path for s12z-opc.h.
 941
 942 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 943
 944         * NEWS: Require GNU make 3.82.
 945
 946 2019-07-16  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 949         declare.
 950
 951 2019-07-30  Tom Tromey  <tromey@adacore.com>
 952
 953         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 954
 955 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 956
 957         * printcmd.c (print_address_symbolic): Print negative offsets.
 958         (build_address_symbolic): Force signed arithmetic when computing
 959         offset.
 960
 961 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 962
 963         PR/24474: Add a function to lookup static variables.
 964         * NEWS: Mention this new function.
 965         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 966         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 967         * python/python.c (python_GdbMethods): Add new function.
 968
 969 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 970
 971         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 972         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 973         (objfpy_lookup_static_symbol): New function.
 974         (objfile_object_methods): Add new functions.
 975
 976 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * NEWS: Mention 'set|show print frame-info'.  Mention new
 979         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 980         backtrace argument.  Mention that python frame filtering code
 981         is now consistent with what 'backtrace' command prints.
 982
 983 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 984
 985         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 986         comments.
 987         (print_frame_info_auto, print_frame_info_source_line,
 988         print_frame_info_location, print_frame_info_source_and_location,
 989         print_frame_info_location_and_address, print_frame_info_short_location):
 990         New declarations.
 991         (struct frame_print_options): New member print_frame_info.
 992         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 993         * stack.h (get_user_print_what_frame_info): New declaration.
 994         (frame_show_address): New declaration.
 995         * stack.c (print_frame_arguments_choices): New value 'presence'.
 996         (print_frame_info_auto, print_frame_info_source_line,
 997         print_frame_info_location, print_frame_info_source_and_location,
 998         print_frame_info_location_and_address, print_frame_info_short_location,
 999         print_frame_info_choices, print_frame_info_print_what): New definitions.
1000         (print_frame_args): Only print dots for args if print frame-arguments
1001         is 'presence'.
1002         (frame_print_option_defs): New element for "frame-info".
1003         (get_user_print_what_frame_info): New function.
1004         (frame_show_address): Make non static.  Move comment to stack.h.
1005         (print_frame_info_to_print_what): New function.
1006         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1007         to decide what to print.
1008         (backtrace_command_1): Handle the new print_frame_arguments_presence
1009         value.
1010         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1011         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1012         (py_print_frame): In non-mi mode, use LOCATION as default for
1013         print_what, similarly to frame information printed directly by
1014         backtrace command. Handle frame-info user option in non MI mode.
1015
1016 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1017
1018         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1019         Add case for debugging 32-bit target on 64-bit host.  Revise
1020         comment.
1021
1022 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1023
1024         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1025         instead of find_function_entry_range_from_pc.
1026
1027 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1028
1029         * stack.c (find_frame_funname): Remove code which preferred
1030         minsym over symtab sym in "certain pathological cases".
1031
1032         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1033         parameter.  Change type of "do_demangle" to bool.
1034         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1035         Pass suitable "prefer_sym_over_minsym" flag to
1036         build_address_symbolic().  Don't output "+" for negative offsets.
1037         * printcmd.c (print_address_symbolic): Update invocation of
1038         build_address_symbolic to include a "prefer_sym_over_minsym"
1039         flag.
1040         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1041         Restrict cases in which use of minimal symbol is preferred to that
1042         of a found symbol.  Update comments.
1043
1044         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1045         for entry pc when entry pc is out of range for that FDE.
1046
1047 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1048
1049         PR gdb/24839:
1050         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1051         type.
1052
1053 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1054
1055         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1056         this function's Python signature.
1057
1058
1059 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1062         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1063         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1064         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1065         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1066
1067
1068 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1069
1070         * h8300-tdep.c (h8300_register_name_common): New.
1071         h8300_register_name): Use h8300_register_name_common.
1072         (h8300s_register_name): Likewise.
1073         (h8300sx_register_name): Likewise.
1074         (h8300h_register_nam): New.
1075         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1076
1077
1078 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1079
1080         * arm-tdep.c (arm_skip_cmse_entry): New function.
1081         (arm_is_sgstubs_section): New function.
1082         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1083
1084 2019-07-22  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1087         Don't self-assign.
1088
1089 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1092         type_print.
1093
1094 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1097         so that GDB doesn't match any msymbols when searching in the
1098         TYPES_DOMAIN.
1099         (print_symbol_info): Print using typedef_print or type_print based
1100         on the type of the symbol.  Add updated FIXME comment moved from...
1101         (_initialize_symtab): ... move and update FIXME comment to above.
1102
1103 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * NEWS: Mention adding -q option to "info types".
1106         * symtab.c (struct info_types_options): New struct.
1107         (info_types_options_defs): New variable.
1108         (make_info_types_options_def_group): New function.
1109         (info_types_command): Use gdb::option framework to parse options.
1110         (info_types_command_completer): New function.
1111         (_initialize_symtab): Extend the help text on "info types" and
1112         register command completer.
1113
1114 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1115
1116         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1117         (lookup_symbol_in_objfile): Change int to block_enum and add a
1118         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1119
1120 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1121
1122         * MAINTAINERS (Write After Approval): Add self.
1123
1124 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1127         instruction to the dummy code region.
1128
1129 2019-07-19  Tom Tromey  <tromey@adacore.com>
1130
1131         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1132         (ARGSUSED, PARAMS, __func__): Remove rules.
1133
1134 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1135
1136         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1137         * features/arm/arm-with-iwmmxt.c: Remove.
1138         * features/arm/arm-with-iwmmxt.xml: Remove.
1139         * features/arm/arm-with-m-fpa-layout.c: Remove.
1140         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1141         * features/arm/arm-with-m-vfp-d16.c: Remove.
1142         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1143         * features/arm/arm-with-m.c: Remove.
1144         * features/arm/arm-with-m.xml: Remove.
1145         * features/arm/arm-with-neon.c: Remove.
1146         * features/arm/arm-with-neon.xml: Remove.
1147         * features/arm/arm-with-vfpv2.c: Remove.
1148         * features/arm/arm-with-vfpv2.xml: Remove.
1149         * features/arm/arm-with-vfpv3.c: Remove.
1150         * features/arm/arm-with-vfpv3.xml: Remove.
1151
1152 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1153
1154         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1155
1156 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * arch/aarch32.c (aarch32_create_target_description): Create
1159         target descriptions using features.
1160         * arch/arm.c (arm_create_target_description)
1161         (arm_create_mprofile_target_description): Likewise.
1162         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1163
1164 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1165
1166         * Makefile.in: Add new files.
1167         * aarch32-tdep.c: New file.
1168         * aarch32-tdep.h: New file.
1169         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1170         Call aarch32_read_description.
1171         * arch/aarch32.c: New file.
1172         * arch/aarch32.h: New file.
1173         * arch/arm.c (arm_create_target_description)
1174         (arm_create_mprofile_target_description): New function.
1175         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1176         (arm_create_target_description)
1177         (arm_create_mprofile_target_description): New declaration.
1178         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1179         read_description functions.
1180         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1181         Likewise.
1182         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1183         * arm-tdep.c (tdesc_arm_list): New variable.
1184         (arm_register_g_packet_guesses): Call create description functions.
1185         (arm_read_description) (arm_read_mprofile_description): New
1186         function.
1187         * arm-tdep.h (arm_read_description)
1188         (arm_read_mprofile_description): Add declaration.
1189         * configure.tgt: Add new files.
1190
1191 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1192
1193         * top.c (new_ui_command): Open specified terminal just once.
1194
1195 2019-07-18  Tom Tromey  <tromey@adacore.com>
1196
1197         * symtab.c (main_name): Constify return type.
1198         * symfile.c (set_initial_language): Update.
1199         * symtab.h (main_name): Constify return type.
1200
1201 2019-07-17  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-winsource.c (tui_update_source_window)
1204         (tui_update_source_window_as_is)
1205         (tui_update_source_windows_with_line): Remove return.
1206         * tui/tui-disasm.c (tui_show_disassem)
1207         (tui_show_disassem_and_update_source): Remove return.
1208         * tui/tui.c (tui_reset): Remove return.
1209         * tui/tui-wingeneral.c
1210         (tui_check_and_display_highlight_if_needed): Remove return.
1211
1212 2019-07-17  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1215
1216 2019-07-17  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-winsource.h (struct tui_exec_info_window)
1219         (struct tui_source_window_base): Move from tui-data.h.
1220         * tui/tui-winsource.c: Move many method definitions from
1221         elsewhere.  Remove "structuring" comments.
1222         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1223         (tui_source_window_base::refresh_window): Move to
1224         tui-winsource.c.
1225         * tui/tui-win.c (tui_source_window_base::refresh_all)
1226         (tui_source_window_base::update_tab_width)
1227         (tui_source_window_base::set_new_height)
1228         (tui_source_window_base::do_make_visible_with_new_height): Move to
1229         tui-winsource.c.
1230         * tui/tui-source.h: Update.
1231         * tui/tui-source.c (tui_source_window_base::reset): Move to
1232         tui-winsource.c.
1233         * tui/tui-disasm.h: Update.
1234         * tui/tui-data.h (struct tui_exec_info_window): Move to
1235         tui-winsource.h.
1236         (struct tui_source_window_base): Likewise.
1237         * tui/tui-data.c (tui_source_window_base::clear_detail)
1238         (tui_source_window_base, ~tui_source_window_base): Move to
1239         tui-winsource.c.
1240
1241 2019-07-17  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-win.c (tui_resize_all)
1244         (tui_source_window_base::update_tab_width)
1245         (tui_adjust_win_heights): Update.
1246         (tui_win_info::make_invisible_and_set_new_height): Rename from
1247         make_invisible_and_set_new_height.
1248         * tui/tui-data.h (struct tui_win_info)
1249         <make_invisible_and_set_new_height>: New method.
1250
1251 2019-07-17  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui.c: Update.
1254         * tui/tui-source.h (struct tui_source_window): Move from
1255         tui-data.h.
1256         * tui/tui-layout.c: Update.
1257         * tui/tui-disasm.c: Update.
1258         * tui/tui-data.h (struct tui_source_window): Move to
1259         tui-source.h.
1260
1261 2019-07-17  Tom Tromey  <tom@tromey.com>
1262
1263         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1264         tui-data.h.
1265         * tui/tui-data.h (struct tui_disasm_window): Move to
1266         tui-disasm.h.
1267
1268 2019-07-17  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-regs.h (struct tui_data_item_window): Move from
1271         tui-data.h.
1272         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1273         * tui/tui-data.h (struct tui_data_item_window): Move to
1274         tui-regs.h.
1275         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui.c: Update.
1280         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1281         (tui_cmd_window::max_height): Move to tui-command.c.
1282         * tui/tui-layout.c: Update.
1283         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1284         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1285         tui-command.c.
1286         * tui/tui-command.h (struct tui_cmd_window): Move from
1287         tui-data.h.
1288         * tui/tui-command.c: Remove "structuring" comments.
1289         (tui_cmd_window::clear_detail)
1290         (tui_cmd_window::do_make_visible_with_new_height)
1291         (tui_cmd_window::max_height): Move from elsewhere.
1292
1293 2019-07-17  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1296         Now static.
1297         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1298         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui.c: Update.
1303         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1304         tui-regs.c.
1305         * tui/tui-windata.h: Remove file.
1306         * tui/tui-windata.c: Remove file.
1307         * tui/tui-win.c (tui_data_window::set_new_height)
1308         (tui_data_window::do_make_visible_with_new_height): Move to
1309         tui-regs.c.
1310         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1311         * tui/tui-regs.c: Remove "structuring" comments.
1312         (tui_data_window::first_data_item_displayed)
1313         (tui_data_window::delete_data_content_windows)
1314         (tui_data_window::erase_data_content)
1315         (tui_data_window::display_all_data)
1316         (tui_data_window::refresh_all)
1317         (tui_data_window::do_scroll_vertical)
1318         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1319         (tui_data_window::do_make_visible_with_new_height)
1320         (tui_data_window::refresh_window): Move from elsewhere.
1321         (_initialize_tui_regs): Move to end of file.
1322         * tui/tui-layout.c: Update.
1323         * tui/tui-hooks.c: Update.
1324         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1325         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1326         tui-regs.c.
1327         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1332         seen.
1333
1334 2019-07-17  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-win.c (tui_source_window_base::set_new_height)
1337         (tui_source_window_base::do_make_visible_with_new_height): Use
1338         m_has_locator field directly.
1339         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1340         method.
1341         (struct tui_source_window_base) <has_locator>: Likewise.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1346         Don't declare.
1347         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1348         Remove.
1349         * tui/tui-win.c (tui_source_window_base::set_new_height)
1350         (tui_source_window_base::set_new_height)
1351         (make_invisible_and_set_new_height)
1352         (tui_source_window_base::do_make_visible_with_new_height)
1353         (tui_source_window_base::do_make_visible_with_new_height):
1354         Update.
1355         * tui/tui-layout.c (show_source_disasm_command, show_data)
1356         (show_source_or_disasm_and_command): Update.
1357         * tui/tui-layout.c (show_layout): Update.
1358
1359 2019-07-17  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-layout.c (make_data_window): Remove.
1362         (show_data): Unify creation and re-initialization cases.
1363
1364 2019-07-17  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-layout.c (make_source_window, make_disasm_window):
1367         Remove.
1368         (show_data): Unify creation and re-initialization cases.
1369
1370 2019-07-17  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-layout.c (make_command_window): Remove.
1373         (show_source_disasm_command, show_source_or_disasm_and_command):
1374         Unify creation and re-initialization cases.
1375
1376 2019-07-17  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1379         creation and re-initialization cases.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-regs.c (tui_get_register): Return void.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1388         Simplify.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1393         resetting.
1394
1395 2019-07-17  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1398         * tui/tui-regs.c (tui_reg_layout): New function.
1399         (tui_show_registers, tui_reg_command): Use it.
1400         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1401         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1402         parameters.
1403         (tui_layout_command): Remove.
1404
1405 2019-07-17  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-layout.h (tui/tui-layout): Return void.
1408         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1409
1410 2019-07-17  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-layout.c (show_source_disasm_command, show_data):
1413         Update.
1414         (reset_locator): Remove.
1415         (show_source_or_disasm_and_command): Update.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-source.c (tui_source_window_base::reset): Remove
1420         win_type parameter.
1421         * tui/tui-layout.c (make_command_window, make_source_window)
1422         (make_disasm_window, make_data_window)
1423         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1424         (reset_locator, show_source_or_disasm_and_command): Update.
1425         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1426         win_type parameter.
1427         (struct tui_source_window_base) <reset>: Likewise.
1428
1429 2019-07-17  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-layout.c (show_source_disasm_command): Use
1432         reset_locator.
1433         (reset_locator): New function.
1434         (init_and_make_win): Remove.
1435         (show_source_or_disasm_and_command): Use reset_locator.
1436
1437 2019-07-17  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1440         condition.
1441         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1442         Remove condition.
1443         * tui/tui-source.c (tui_source_window_base::reset): New method.
1444         * tui/tui-layout.c (make_command_window): Don't call
1445         init_and_make_win.
1446         (make_source_window, make_disasm_window): Don't call
1447         make_source_or_disasm_window.
1448         (make_data_window): Don't call init_and_make_win.  Change calling
1449         convention.
1450         (show_source_disasm_command, show_data): Simplify.
1451         (make_source_or_disasm_window): Remove.
1452         (show_source_or_disasm_and_command): Simplify.
1453         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1454         (struct tui_source_window_base) <reset>: Likewise.
1455         <execution_info>: Remove initializer.
1456         * tui/tui-data.c (tui_source_window_base): Initialize
1457         execution_info.
1458
1459 2019-07-17  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1462         variable.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui.c (tui_rl_other_window): Update.
1467         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1468         superclass method first.  Always iterate over regs_content.
1469         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1470         method.
1471         * tui/tui-win.c (tui_set_focus_command): Update.
1472
1473 2019-07-17  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-win.c (tui_set_focus_command): Rename from
1476         tui_set_focus.  Call tui_enable.
1477         (tui_set_focus_command): Remove.
1478
1479 2019-07-17  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1482         refresh_window.
1483         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1484         touchwin.
1485         (tui_data_window::refresh_window): Call refresh_window on data
1486         items.  Always call superclass refresh_window.
1487         (tui_win_info::refresh): Remove.
1488         (tui_source_window_base::refresh_window): Update.
1489         (tui_refresh_all): Update.
1490         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1491         refresh_window.
1492         (show_source_or_disasm_and_command): Likewise.
1493         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1494         (struct tui_source_window_base) <refresh>: Likewise.
1495
1496 2019-07-17  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-winsource.c (tui_clear_source_content)
1499         (tui_show_source_content): Update.
1500         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1501         whether content is empty.
1502         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1503         Remove.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1508         window's contents.
1509         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1510         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1515         (struct tui_data_item_window): Update.
1516
1517 2019-07-17  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1520         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1521         defines.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-winsource.h (tui_erase_source_content)
1526         (tui_clear_source_content): Remove "display_prompt" parameter.
1527         * tui/tui-winsource.c (tui_update_source_window_as_is)
1528         (tui_update_source_windows_with_addr): Update.
1529         (tui_clear_source_content): Remove "display_prompt" parameter.
1530         (tui_erase_source_content): Likewise.  Simplify.
1531         (tui_show_source_content): Update.
1532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1533         * tui/tui-stack.c (tui_show_frame_info): Update.
1534         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1535         Remove defines.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1540         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1541         parameter.
1542         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1543         parameter.
1544
1545 2019-07-17  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.c (tui_clear_source_content)
1548         (tui_show_source_content, tui_show_exec_info_content)
1549         (tui_clear_exec_info_content): Update.
1550         * tui/tui-stack.c (tui_show_locator_content): Update.
1551         (tui_show_frame_info): Update.
1552         * tui/tui-source.h (tui_source_window): Don't declare.
1553         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1554         from tui_source_is_displayed.
1555         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1556         Remove field.
1557         (struct tui_source_window_base) <content_in_use>: New field.  Now
1558         bool.
1559         (struct tui_source_window) <showing_source_p>: New method.
1560         (TUI_SRC_WIN): Change cast.
1561         * tui/tui-data.c (tui_initialize_static_data): Update.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1566         location_matches_p.
1567         * tui/tui-source.c (tui_source_window::location_matches_p): New
1568         method.
1569         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1570         method.
1571         * tui/tui-data.h (struct tui_source_window_base)
1572         <location_matches_p>: New method.
1573         (struct tui_source_window, struct tui_disasm_window)
1574         <location_matches_p>: Likewise.
1575
1576 2019-07-17  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-win.c (tui_set_win_height_command): Rename from
1579         tui_set_win_height.
1580         (tui_set_win_height_command): Remove.
1581
1582 2019-07-17  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-source.c (tui_source_window): New constructor.  Add
1585         observer.
1586         (~tui_source_window): New destructor.
1587         (tui_source_window::style_changed): New method.
1588         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1589         (tui_attach_detach_observers): Update.
1590         * tui/tui-data.h (struct tui_source_window): Make constructor not
1591         inline.  Add destructor.
1592         (struct tui_source_window) <style_changed>: New method.
1593         <m_observable>: New member.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1598         * tui/tui-win.c (tui_resize_all): Fix typo.
1599
1600 2019-07-17  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1603         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1604         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1605         * tui/tui-win.c (window_name_completer): Use foreach.
1606         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1607         (update_tab_width): Likewise.
1608         * tui/tui-layout.c (show_layout): Update.
1609         * tui/tui-data.h (class tui_window_iterator): New.
1610         (struct all_tui_windows): New.
1611         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1616         parameter.  Don't reference globals.
1617         (tui_reg_command): Update.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-regs.c (tui_show_registers): Simplify.
1622
1623 2019-07-17  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-regs.c (tui_show_registers): Update.
1626         (tui_show_register_group): Add win_info parameter.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1631         Rename from tui_display_reg_element_at_line.
1632         (tui_data_window::display_registers_from_line): Update.
1633         * tui/tui-data.h (struct tui_data_window)
1634         <display_reg_element_at_line>: New method.
1635
1636 2019-07-17  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-regs.h (tui_display_registers_from)
1639         (tui_display_registers_from_line): Don't declare.
1640         * tui/tui-windata.c (tui_data_window::display_all_data)
1641         (tui_data_window::refresh_all)
1642         (tui_data_window::do_scroll_vertical): Update.
1643         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1644         from tui_display_registers_from.
1645         (tui_display_reg_element_at_line): Update.
1646         (tui_data_window::display_registers_from_line): Rename from
1647         tui_display_registers_from_line.
1648         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1649         display_registers_from_line>: New methods.
1650
1651 2019-07-17  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1654         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1655         from tui_erase_data_content.
1656         (tui_data_window::display_all_data)
1657         (tui_data_window::refresh_all)
1658         (tui_data_window::do_scroll_vertical): Update.
1659         * tui/tui-regs.c (tui_show_registers): Update.
1660         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1661         New method.
1662
1663 2019-07-17  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1666         declare.
1667         * tui/tui-windata.c
1668         (tui_data_window::delete_data_content_windows): Rename from
1669         tui_delete_data_content_windows.
1670         (tui_data_window::display_all_data)
1671         (tui_data_window::do_scroll_vertical): Update.
1672         * tui/tui-data.h (struct tui_data_window)
1673         <delete_data_content_windows>: New method.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1678         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1683         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1684         from tui_display_all_data.
1685         * tui/tui-win.c
1686         (tui_data_window::do_make_visible_with_new_height): Update.
1687         * tui/tui-regs.c (tui_show_registers): Update.
1688         * tui/tui-layout.c (tui_set_layout): Update.
1689         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1690         method.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1695         * tui/tui-windata.c (tui_display_data_from): Remove.
1696         (tui_data_window::refresh_all): Update.
1697
1698 2019-07-17  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1701         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1702         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1703         tui_display_registers_from_line.
1704         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1705         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1706         "force_display" parameter.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1711         declare.
1712         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1713         Rename from tui_first_reg_element_no_inline.
1714         (tui_display_reg_element_at_line)
1715         (tui_display_registers_from_line): Update.
1716         * tui/tui-data.h (struct tui_data_window)
1717         <first_reg_element_no_inline>: New method.
1718
1719 2019-07-17  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-windata.c (tui_display_data_from)
1722         (tui_data_window::do_scroll_vertical): Update.
1723         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1724         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1725         Rename from tui_line_from_reg_element_no.
1726         (tui_display_registers_from_line): Update.
1727         * tui/tui-data.h (struct tui_data_window)
1728         <line_from_reg_element_no>: New method.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1733         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1734         tui_last_regs_line_no.
1735         (tui_display_reg_element_at_line)
1736         (tui_display_registers_from_line): Update.
1737         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1738         method.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         PR tui/24722:
1743         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1744         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1745         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1746         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1747         (tui_update_breakpoint_info): Likewise.
1748         * tui/tui-hooks.c (tui_event_create_breakpoint)
1749         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1750         Update.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-winsource.c (tui_update_source_window_as_is)
1759         (tui_update_source_windows_with_addr): Update.
1760         * tui/tui-source.h (tui_set_source_content)
1761         (tui_show_symtab_source): Add "win_info" parameter.
1762         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1763         parameter.
1764         (tui_show_symtab_source): Likewise.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-wingeneral.c
1769         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1774         (struct tui_cmd_window) <can_scroll>: New method.
1775         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1776         method.
1777
1778 2019-07-17  Tom Tromey  <tromey@adacore.com>
1779
1780         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1781         do_field_signed>: Rename.  Change type of "value".
1782         * ui-out.c (ui_out::field_signed): Rename from field_int.
1783         Change type of "value".
1784         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1785         type of "value".
1786         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1787         do_field_int.  Change type of "value".
1788         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1789         do_field_int.  Change type of "value".
1790         * tracepoint.c (trace_status_mi, tfind_1)
1791         (print_one_static_tracepoint_marker): Update.
1792         * thread.c (print_thread_info_1, print_selected_thread_frame):
1793         Update.
1794         * stack.c (print_frame, print_frame_info): Update.
1795         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1796         Update.
1797         * source.c (print_source_lines_base): Update.
1798         * skip.c (info_skip_command): Update.
1799         * record-btrace.c (btrace_ui_out_decode_error)
1800         (btrace_call_history_src_line): Update.
1801         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1802         Update.
1803         * progspace.c (print_program_space): Update.
1804         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1805         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1806         do_field_int.  Change type of "value".
1807         * mi/mi-out.c (mi_ui_out::do_table_begin)
1808         (mi_ui_out::do_table_header): Update.
1809         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1810         type of "value".
1811         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1812         (mi_cmd_data_list_changed_registers, output_register)
1813         (mi_cmd_data_read_memory, mi_load_progress)
1814         (mi_cmd_trace_frame_collected): Update.
1815         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1816         Update.
1817         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1818         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1819         (mi_cmd_var_list_children, varobj_update_one): Update.
1820         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1821         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1823         * inferior.c (print_inferior): Update.
1824         * gdb_bfd.c (print_one_bfd): Update.
1825         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1826         Update.
1827         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1828         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1829         do_field_int.  Change type of "value".
1830         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1831         do_field_int.  Change type of "value".
1832         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1833         (print_one_breakpoint_location, print_it_catch_fork)
1834         (print_one_catch_fork, print_it_catch_vfork)
1835         (print_one_catch_vfork, print_it_catch_solib)
1836         (print_it_catch_exec, print_it_ranged_breakpoint)
1837         (print_mention_watchpoint, print_mention_masked_watchpoint)
1838         (bkpt_print_it, update_static_tracepoint): Update.
1839         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1840         * break-catch-syscall.c (print_it_catch_syscall): Update.
1841         * ada-tasks.c (print_ada_task_info): Update.
1842         * ada-lang.c (print_it_exception, print_mention_exception):
1843         Update.
1844
1845 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         PR breakpoints/24541
1848         * gdbarch.c: Regenerate.
1849         * gdbarch.h: Regenerate.
1850         * gdbarch.sh: Adjust return type and parameter types for
1851         'stap_adjust_register'.
1852         (i386_stap_adjust_register): Adjust signature and return new
1853         register name.
1854         * stap-probe.c (stap_parse_register_operand): Adjust use of
1855         'gdbarch_stap_adjust_register'.
1856
1857 2019-07-17  Tom Tromey  <tromey@adacore.com>
1858
1859         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1860         declare VEC.
1861         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1862         std::vector.
1863         (struct s390_process_info): Add initializers.
1864         (s390_add_process): Use new.
1865         (s390_linux_nat_target::low_forget_process): Use delete.
1866         (s390_linux_nat_target::low_new_fork)
1867         (s390_linux_nat_target::stopped_by_watchpoint)
1868         (s390_linux_nat_target::low_prepare_to_resume)
1869         (s390_linux_nat_target::insert_watchpoint)
1870         (s390_linux_nat_target::insert_hw_breakpoint)
1871         (s390_linux_nat_target::remove_watchpoint)
1872         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1873
1874 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1875
1876         * aarch64-fbsd-nat.c: Include regcache.h.
1877         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1878         argument.
1879         (aarch64_fbsd_nat_target::fetch_registers)
1880         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1881         variable.
1882         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1883
1884 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1885
1886         * fbsd-nat.c: Include gdbarch.h.
1887
1888 2019-07-15  Tom Tromey  <tromey@adacore.com>
1889
1890         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1891
1892 2019-07-15  Tom Tromey  <tromey@adacore.com>
1893
1894         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1895         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1896         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1897         * cli-out.c (cli_ui_out::do_field_int): New method.
1898         * ui-out.c (ui_out::field_unsigned): New method.
1899         * symfile.c (generic_load): Use field_unsigned.
1900         (print_transfer_performance): Likewise.
1901         * record-btrace.c (ui_out_field_uint): Remove.
1902         (btrace_call_history_insn_range, btrace_call_history): Use
1903         field_unsigned.
1904         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1905         field_unsigned.
1906         * ui-out.h (class ui_out) <field_unsigned>: New method.
1907         <do_field_unsigned>: Likewise.
1908
1909 2019-07-15  Tom Tromey  <tromey@adacore.com>
1910
1911         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1912         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1913         * target.c (flash_erase_command): Use field_string.
1914         * infrun.c (print_signal_received_reason): Use field_string.
1915         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1916         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1917         field_string.
1918         * ada-tasks.c (print_ada_task_info): Use field_string.
1919
1920 2019-07-15  Tom Tromey  <tromey@adacore.com>
1921
1922         * target.c (flash_erase_command): Use field_core_addr.
1923         * symfile.c (generic_load): Use field_core_addr.
1924         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1925         Use field_core_addr.
1926         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1927         field_core_addr.
1928
1929 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1930
1931         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1932         value if its desired type is smaller than a CORE_ADDR and signed.
1933
1934 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1937         of changes to field names, and use new is_reference field to
1938         decide if a property is a reference or not.
1939         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1940         field.
1941         (struct dwarf2_property_baton): Update header comment, rename
1942         'referenced_type' to 'property_type' and update comments.
1943         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1944         default property type, store in property baton, update to take
1945         accound of renamed field.
1946         (read_func_scope): Update call to attr_to_dynamic_prop.
1947         (read_array_type): Likewise.
1948         (dwarf2_per_cu_addr_sized_int_type): New function.
1949         (read_subrange_index_type): Move type finding code to
1950         dwarf2_per_cu_addr_sized_int_type.
1951         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1952         (dwarf2_per_cu_addr_type): New function.
1953         (set_die_type): Update calls to attr_to_dynamic_prop.
1954
1955 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * dwarf2read.c (read_subrange_index_type): New function.
1958         (read_subrange_type): Move code into new function and call it.
1959         * gdbtypes.c (create_range_type): Add some asserts.
1960
1961 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1962
1963         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1964         update return statements.
1965         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1966         declaration, and update comment to match.
1967         * gdbtypes.c (resolve_dynamic_array): Update call to
1968         dwarf2_evaluate_property to match new return type.
1969
1970 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * valarith.c (value_subscripted_rvalue): Change lowerbound
1973         parameter type from int to LONGEST.
1974         * value.h (value_subscripted_rvalue): Likewise in declaration.
1975
1976 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * cli/cli-utils.c (info_print_command_completer): New function.
1979         * cli/cli-utils.h: Add 'completer.h' include, and forward
1980         declaration for 'struct cmd_list_element'.
1981         (info_print_command_completer): Declare.
1982         * stack.c (_initialize_stack): Add completer for 'info locals' and
1983         'info args'.
1984         * symtab.c (_initialize_symtab): Add completer for 'info
1985         variables' and 'info functions'.
1986         * NEWS: Mention completion for additional info commands.
1987
1988 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * cli/cli-utils.c (extract_info_print_args): Delete.
1991         (extract_arg_maybe_quoted): Delete.
1992         (info_print_options_defs): New variable.
1993         (make_info_print_options_def_group): New function.
1994         (extract_info_print_options): Define new function.
1995         * cli/cli-utils.h (extract_info_print_args): Delete.
1996         (struct info_print_options): New structure.
1997         (extract_info_print_options): Declare new function.
1998         * stack.c (info_locals_command): Update to use new
1999         extract_info_print_options, also add a header comment.
2000         (info_args_command): Likewise.
2001         * symtab.c (info_variables_command): Likewise.
2002         (info_functions_command): Likewise.
2003
2004 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2005
2006         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2007         to extract string arguments.
2008         * common/common-utils.c (extract_string_maybe_quoted): New function.
2009         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2010
2011 2019-07-11  Tom Tromey  <tromey@adacore.com>
2012
2013         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2014         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2015         * top.h (gdbinit): Don't declare.
2016         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2017         into...
2018         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2019         * top.c (gdb_init): Don't call init_cli_cmds.
2020         (gdbinit): Remove.
2021         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2022
2023 2019-07-11  Tom Tromey  <tromey@adacore.com>
2024
2025         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2026         after it has been moved.
2027
2028 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2029
2030         * valops.c (value_must_coerce_to_target): Change return type to
2031         bool.
2032         * value.h (value_must_coerce_to_target): Likewise.
2033
2034 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2035
2036         * breakpoint.c (is_hardware_watchpoint): Remove
2037         forward-declaration.
2038         (is_masked_watchpoint): Change return type to bool.
2039         (is_tracepoint): Likewise.
2040         (is_breakpoint): Likewise.
2041         (is_hardware_watchpoint): Likewise.
2042         (is_watchpoint): Likewise.
2043         (is_no_memory_software_watchpoint): Likewise.
2044         (is_catchpoint): Likewise.
2045         (breakpoint_1): Make FILTER parameter's return type bool.
2046         is_masked_watchpoint): Change return type to bool.
2047         (save_breakpoints): Make FILTER parameter's return type bool.
2048         * breakpoint.h (is_breakpoint): Change return type to bool.
2049         (is_watchpoint): Likewise.
2050         (is_catchpoint): Likewise.
2051         (is_tracepoint): Likewise.
2052
2053 2019-07-10  Tom Tromey  <tom@tromey.com>
2054
2055         * defs.h: Don't include gdbarch.h.
2056         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2057         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2058         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2059         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2060         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2061         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2062         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2063         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2064         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2065         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2066         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2067         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2068         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2069         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2070         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2071         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2072         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2073         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2074         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2075         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2076         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2077         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2078         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2079         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2080         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2081         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2082         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2083
2084 2019-07-10  Tom Tromey  <tromey@adacore.com>
2085
2086         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2087         * breakpoint.c (init_ada_exception_breakpoint): Register as
2088         bp_catchpoint.
2089         (print_one_breakpoint_location, print_one_breakpoint): Use
2090         is_ada_exception_catchpoint.
2091         * ada-lang.c (class ada_catchpoint_location): Pass
2092         bp_loc_software_breakpoint to bp_location constructor.
2093         (is_ada_exception_catchpoint): New function.
2094
2095 2019-07-10  Tom Tromey  <tromey@adacore.com>
2096
2097         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2098         VEC.
2099         (struct arm_exidx_entry): New method operator<.
2100         (struct arm_exidx_data) <section_maps>: Change type.
2101         (arm_exidx_data_free): Remove.
2102         (arm_exidx_data_key): Change type.  Move lower.
2103         (arm_exidx_new_objfile): Update.
2104         (arm_compare_exidx_entries): Remove.
2105         (arm_find_exidx_entry, _initialize_arm_tdep)
2106
2107 2019-07-10  Tom Tromey  <tromey@adacore.com>
2108
2109         * solib-spu.c (ocl_program_data_key): Change type.
2110         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2111         Update.
2112
2113 2019-07-10  Tom Tromey  <tromey@adacore.com>
2114
2115         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2116         (struct solib_aix_inferior_data) <library_list>: Change type.
2117         (solib_aix_inferior_data_handle): Change type.
2118         (get_solib_aix_inferior_data): Update.
2119         (solib_aix_free_library_list): Remove.
2120         (library_list_start_library): Update.
2121         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2122         return type.
2123         (solib_aix_get_library_list)
2124         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2125         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2126
2127 2019-07-10  Tom Tromey  <tromey@adacore.com>
2128
2129         * solib-dsbt.c (struct dsbt_info): Add initializers.
2130         (solib_dsbt_pspace_data): Change type.
2131         (dsbt_pspace_data_cleanup): Remove.
2132         (get_dsbt_info, _initialize_dsbt_solib): Update.
2133
2134 2019-07-10  Tom Tromey  <tromey@adacore.com>
2135
2136         * spu-tdep.c (spu_overlay_data): Change type.
2137         (spu_get_overlay_table, spu_overlay_new_objfile)
2138         (_initialize_spu_tdep): Update.
2139
2140 2019-07-10  Tom Tromey  <tromey@adacore.com>
2141
2142         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2143         destructor.
2144         (dbx_objfile_data_key): Change type and declare later.
2145         (DBX_SYMFILE_INFO): Rewrite.
2146         * dbxread.c (dbx_objfile_data_key): Change type.
2147         (dbx_symfile_init): Update.
2148         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2149         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2150         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2151
2152 2019-07-10  Tom Tromey  <tromey@adacore.com>
2153
2154         * jit.c (jit_program_space_key): Change type.  Move lower.
2155         (get_jit_program_space_data): Update.
2156         (jit_program_space_data_cleanup): Remove.
2157         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2158         Update.
2159         (struct jit_program_space_data): Add initializers.
2160
2161 2019-07-10  Tom Tromey  <tromey@adacore.com>
2162
2163         * solib-darwin.c (struct darwin_info): Add initializers.
2164         (solib_darwin_pspace_data): Change type.
2165         (darwin_pspace_data_cleanup): Remove.
2166         (get_darwin_info, _initialize_darwin_solib): Update.
2167
2168 2019-07-10  Tom Tromey  <tromey@adacore.com>
2169
2170         * remote-sim.c (struct sim_inferior_data): Add initializers,
2171         constructor, and destructor.
2172         (sim_inferior_data_key): Change type.  Move lower.
2173         (check_for_duplicate_sim_descriptor): Update.
2174         (get_sim_inferior_data): Use new.  Update.
2175         (~sim_inferior_data_cleanup): Rename from
2176         sim_inferior_data_cleanup.  Simplify.
2177         (gdbsim_close_inferior, simulator_command)
2178         (sim_command_completer, _initialize_remote_sim): Update.
2179         (next_pid, INITIAL_PID): Move earlier.
2180
2181 2019-07-10  Tom Tromey  <tromey@adacore.com>
2182
2183         * python/python-internal.h (create_thread_object): Return
2184         gdbpy_ref.
2185         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2186         * python/py-inferior.c (struct threadlist_entry): Add
2187         constructor.
2188         <thread_obj>: Now a gdbpy_ref.
2189         (thread_to_thread_object): Update.
2190         (add_thread_object): Use new.
2191         (delete_thread_object): Use delete.
2192         (infpy_threads): Update.
2193         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2194         GIL.
2195
2196 2019-07-10  Tom Tromey  <tromey@adacore.com>
2197
2198         * valops.c (value_cast): Specialize error message for Ada.
2199
2200 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2201
2202         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2203
2204 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2205
2206         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2207         bpstat_should_step): Return bool, adjust comments.
2208         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2209         bpstat_should_step): Likewise.
2210
2211 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2212
2213         * features/Makefile: Use feature target descriptions for Arm.
2214         * features/arm/arm-core.c: Generate new file.
2215         * features/arm/arm-fpa.c: Likewise.
2216         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2217         * features/arm/arm-m-profile.c: Likewise.
2218         * features/arm/arm-vfpv2.c: Likewise.
2219         * features/arm/arm-vfpv3.c: Likewise.
2220         * features/arm/xscale-iwmmxt.c: Likewise.
2221         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2222
2223 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2224
2225         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2226         ptrace earlier.
2227
2228 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2229
2230         * features/aarch64-pauth.c: Regenerate.
2231
2232 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2233
2234         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2235         bool.
2236         (bpstat_what): Use false instead of 0.
2237
2238 2019-07-09  Pedro Alves  <palves@redhat.com>
2239
2240         * break-catch-throw.c (is_exception_catchpoint): New.
2241         * breakpoint.c (print_one_breakpoint_location): New parameter
2242         'raw_loc'.  Handle it.  Use
2243         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2244         looking at the breakpoint's type.
2245         (print_one_breakpoint): If handling "maint info breakpoints", also
2246         print locations of exception catchpoints.
2247         * breakpoint.h (is_exception_catchpoint): Declare.
2248
2249 2019-07-09  Pedro Alves  <palves@redhat.com>
2250
2251         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2252         "addr" field.
2253         (allocate_location_exception_catchpoint): New.
2254         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2255         (initialize_throw_catchpoint_ops): Install
2256         allocate_location_exception_catchpoint as allocate_location
2257         method.
2258         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2259         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2260         bp_loc_other.
2261         (breakpoint_address_is_meaningful): Delete.
2262         (bl_address_is_meaningful): New.
2263         (breakpoint_locations_match): Adjust comment.
2264         (bp_location_from_bp_type): New, factored out of...
2265         (bp_location::bp_location(breakpoint *)): ... this.
2266         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2267         factored out of...
2268         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2269         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2270         breakpoint_address_is_meaningful.
2271         (bp_locations_compare): Adjust comment.
2272         (update_global_location_list): Use bl_address_is_meaningful
2273         instead of breakpoint_address_is_meaningful.
2274         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2275         explicit.
2276         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2277         * python/py-breakpoint.c (bppy_get_location): No longer check
2278         whether location is null.
2279
2280 2019-07-09  Pedro Alves  <palves@redhat.com>
2281
2282         PR c++/15468
2283         * breakpoint.c (print_one_breakpoint_location): Remove
2284         single-location assert.
2285
2286 2019-07-09  Tom Tromey  <tom@tromey.com>
2287
2288         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2289         * configure: Rebuild.
2290         * configure.ac: Change common to gdbsupport.
2291         * gdbsupport: Rename from common.
2292         * acinclude.m4: Change common to gdbsupport.
2293         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2294         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2295         gdbsupport.
2296         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2297         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2298         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2299         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2300         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2301         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2302         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2303         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2304         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2305         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2306         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2307         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2308         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2309         coff-pe-read.c, command.h, compile/compile-c-support.c,
2310         compile/compile-c.h, compile/compile-cplus-symbols.c,
2311         compile/compile-cplus-types.c, compile/compile-cplus.h,
2312         compile/compile-loc2c.c, compile/compile.c, completer.c,
2313         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2314         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2315         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2316         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2317         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2318         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2319         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2320         features/aarch64-core.c, features/aarch64-fpu.c,
2321         features/aarch64-pauth.c, features/aarch64-sve.c,
2322         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2323         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2324         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2325         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2326         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2327         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2328         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2329         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2330         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2331         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2332         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2333         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2334         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2335         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2336         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2337         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2338         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2339         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2340         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2341         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2342         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2343         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2344         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2345         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2346         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2347         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2348         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2349         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2350         minsyms.c, mips-linux-tdep.c, namespace.h,
2351         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2352         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2353         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2354         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2355         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2356         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2357         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2358         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2359         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2360         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2361         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2362         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2363         procfs.c, producer.c, progspace.h, psymtab.h,
2364         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2365         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2366         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2367         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2368         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2369         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2370         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2371         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2372         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2373         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2374         target-memory.c, target.c, target.h, target/waitstatus.c,
2375         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2376         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2377         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2378         unittests/array-view-selftests.c,
2379         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2380         unittests/common-utils-selftests.c,
2381         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2382         unittests/format_pieces-selftests.c,
2383         unittests/function-view-selftests.c,
2384         unittests/lookup_name_info-selftests.c,
2385         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2386         unittests/mkdir-recursive-selftests.c,
2387         unittests/observable-selftests.c,
2388         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2389         unittests/parse-connection-spec-selftests.c,
2390         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2391         unittests/scoped_fd-selftests.c,
2392         unittests/scoped_mmap-selftests.c,
2393         unittests/scoped_restore-selftests.c,
2394         unittests/string_view-selftests.c, unittests/style-selftests.c,
2395         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2396         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2397         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2398         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2399         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2400         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2401
2402 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2405         bool value.
2406         (decode_digits_ordinary): Set explicit_line field in sal.
2407         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2408         symtab_and_line that was set on an explicit line number in
2409         assembler code.  Do always update the recorded symtab and line if
2410         we do skip the prologue.
2411
2412 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * breakpoint.c (set_breakpoint_location_function): Remove
2415         explicit_loc parameter.
2416         (momentary_breakpoint_from_master): Update call to
2417         set_breakpoint_location_function.
2418         (add_location_to_breakpoint): Likewise.
2419
2420 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2423         required features based on default bfd type when no specific bfd
2424         is present.
2425
2426 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2427
2428         * NEWS: Mention that GDB printf and eval commands can now print
2429         C-style and Ada-style convenience var strings without
2430         calling the inferior.
2431         * printcmd.c (printf_c_string): Locally print GDB internal var
2432         instead of transiting via the inferior.
2433         (printf_wide_c_string): Likewise.
2434
2435 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2436
2437         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2438
2439 2019-07-04  Tom Tromey  <tom@tromey.com>
2440
2441         PR tui/24724:
2442         * tui/tui-winsource.c (tui_clear_source_content): Update.
2443         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2444         (tui_update_breakpoint_info): Update.
2445         (tui_set_exec_info_content): Update.
2446         * tui/tui-source.c (tui_set_source_content_nil): Update.
2447         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2448         has_break.
2449         * tui/tui-data.h (enum tui_bp_flag): New.
2450         (tui_bp_flags): New enum flags type.
2451         (struct tui_source_element) <break_mode>: Change type.  Rename
2452         from has_break.
2453         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2454         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2455         constants.
2456         * tui/tui-winsource.h: Fix comment.
2457
2458 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2459
2460         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2461         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2462         (store_fpregs_to_thread)
2463         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2464         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2465         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2466         (IWMMXT_REGS_SIZE): Add define.
2467         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2468         (fetch_vfp_regs, store_vfp_regs)
2469         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2470         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2471
2472 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2473
2474         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2475         defines.
2476         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2477         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2478         (ARM_INT_REGISTER_SIZE): ...to this.
2479         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2480         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2481         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2482         (arm_linux_collect_gregset, supply_nwfpe_register)
2483         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2484         defines.
2485         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2486         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2487         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2488         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2489         (arm_return_in_memory, arm_store_return_value)
2490         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2491         (arm_record_ld_st_multiple): Likewise.
2492         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2493         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2494
2495 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2498         AARCH64_DISPLACED_MODIFIED_INSNS.
2499         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2500         (aarch64_displaced_step_copy_insn): Likewise.
2501         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2502         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2503         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2504         ARM_DISPLACED_MODIFIED_INSNS.
2505         * arm-tdep.c (arm_gdbarch_init): Likewise.
2506         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2507         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2508         (struct arm_displaced_step_closure): Use
2509         ARM_DISPLACED_MODIFIED_INSNS.
2510
2511 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2512
2513         * features/Makefile: Remove unused xml files.
2514         * features/aarch64.xml: Remove.
2515         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2516         * features/i386/amd64-avx-avx512.xml: Remove.
2517         * features/i386/amd64-avx-linux.xml: Remove.
2518         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2519         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2520         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2521         * features/i386/amd64-avx-mpx.xml: Remove.
2522         * features/i386/amd64-avx.xml: Remove.
2523         * features/i386/amd64-linux.xml: Remove.
2524         * features/i386/amd64-mpx-linux.xml: Remove.
2525         * features/i386/amd64-mpx.xml: Remove.
2526         * features/i386/amd64.xml: Remove.
2527         * features/i386/i386-avx-avx512-linux.xml: Remove.
2528         * features/i386/i386-avx-avx512.xml: Remove.
2529         * features/i386/i386-avx-linux.xml: Remove.
2530         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2531         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2532         * features/i386/i386-avx-mpx-linux.xml: Remove.
2533         * features/i386/i386-avx-mpx.xml: Remove.
2534         * features/i386/i386-avx.xml: Remove.
2535         * features/i386/i386-linux.xml: Remove.
2536         * features/i386/i386-mmx-linux.xml: Remove.
2537         * features/i386/i386-mmx.xml: Remove.
2538         * features/i386/i386-mpx-linux.xml: Remove.
2539         * features/i386/i386-mpx.xml: Remove.
2540         * features/i386/i386.xml: Remove.
2541         * features/i386/x32-avx-avx512-linux.xml: Remove.
2542         * features/i386/x32-avx-linux.xml: Remove.
2543         * features/i386/x32-linux.xml: Remove.
2544
2545 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2546
2547         * regformats/aarch64.dat: Remove.
2548         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2549         * regformats/i386/amd64-avx-linux.dat: Remove.
2550         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2551         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2552         * regformats/i386/amd64-linux.dat: Remove.
2553         * regformats/i386/amd64-mpx-linux.dat: Remove.
2554         * regformats/i386/amd64.dat: Remove.
2555         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2556         * regformats/i386/i386-avx-linux.dat: Remove.
2557         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2558         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2559         * regformats/i386/i386-linux.dat: Remove.
2560         * regformats/i386/i386-mmx-linux.dat: Remove.
2561         * regformats/i386/i386-mpx-linux.dat: Remove.
2562         * regformats/i386/i386.dat: Remove.
2563         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2564         * regformats/i386/x32-avx-linux.dat: Remove.
2565         * regformats/i386/x32-linux.dat: Remove.
2566
2567 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2568
2569         * aarch64-tdep.c: Remove xml self tests.
2570         * amd64-linux-tdep.c: Likewise.
2571         * amd64-tdep.c: Likewise.
2572         * i386-linux-tdep.c: Likewise.
2573         * i386-tdep.c: Likewise.
2574
2575 2019-07-03  Pedro Alves  <palves@redhat.com>
2576
2577         PR cli/24732
2578         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2579         (pipe_cmd_option_defs): New.
2580         (make_pipe_cmd_options_def_group): New.
2581         (pipe_command): Use gdb::option::process_options.
2582         (pipe_command_completer): New function.
2583         (_initialize_cli_cmds): Install completer for "pipe" command.
2584
2585 2019-07-03  Pedro Alves  <palves@redhat.com>
2586
2587         * cli/cli-option.c (union option_value) <string>: New field.
2588         (struct option_def_and_value): Add ctor, move ctor, dtor and
2589         use DISABLE_COPY_AND_ASSIGN.
2590         (option_def_and_value::clear_value): New.
2591         (parse_option, save_option_value_in_ctx, get_val_type_str)
2592         (add_setshow_cmds_for_options): Handle var_string.
2593         * cli-option.h (union option_def::var_address) <string>: New
2594         field.
2595         (struct string_option_def): New.
2596         * maint-test-options.c (struct test_options_opts): Add default
2597         ctor and use DISABLE_COPY_AND_ASSIGN.
2598         <string_opt>: New field.
2599         (test_options_opts::~test_options_opts): New.
2600         (test_options_opts::dump): Also dump "-string".
2601         (test_options_option_defs): Install "string.
2602
2603 2019-07-03  Pedro Alves  <palves@redhat.com>
2604
2605         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2606         option_value with a null enumeration.
2607         (complete_options): Save the option values in the context.
2608         (save_option_value_in_ctx): New, factored out from ...
2609         (process_options): ... here.
2610         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2611         of the function.
2612         * maint-test-options.c (test_options_opts::dump): New, factored
2613         out from ...
2614         (maintenance_test_options_command_mode): ... here.
2615         (maintenance_test_options_command_completion_result): Delete.
2616         (maintenance_test_options_command_completion_text): Update
2617         comment.
2618         (maintenance_show_test_options_completion_result): Change
2619         prototype.  Just print
2620         maintenance_test_options_command_completion_text.
2621         (save_completion_result): New.
2622         (maintenance_test_options_completer_mode): Pass options context to
2623         complete_options, and then save a dump.
2624         (_initialize_maint_test_options): Use add_cmd to install "maint
2625         show test-options-completion-result".
2626
2627 2019-07-03  Pedro Alves  <palves@redhat.com>
2628
2629         * NEWS (New commands): Mention "with" and "maint with".
2630         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2631         (with_command, with_command_completer): New.
2632         (pipe_command): Adjust to new repeat_previous
2633         interface.
2634         (_initialize_cli_cmds): Install the "with" command and its "w"
2635         alias.
2636         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2637         declarations.
2638         * cli/cli-setshow.c (parse_cli_var_uinteger)
2639         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2640         argument strings for all var_types.
2641         (get_setshow_command_value_string): New, factored out from ...
2642         (do_show_command): ... this.
2643         * cli/cli-setshow.h: Include <string>.
2644         (get_setshow_command_value_string): Declare.
2645         * command.h (repeat_previous): Now returns const char *.  Adjust
2646         comment.
2647         * maint.c: Include "cli/cli-cmds.h".
2648         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2649         (_initialize_maint_cmds): Register the "maintenance with" command.
2650         * top.c (repeat_previous): Move bits from pipe_command here:
2651         Return the saved command line, if any; error out if there's no
2652         command to relaunch.
2653
2654 2019-07-03  Pedro Alves  <palves@redhat.com>
2655
2656         * NEWS (New commands): Mention "maint set/show test-settings"
2657         instead of "maint test-settings".
2658         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2659         (maintenance_test_settings_set_list): Rename to ...
2660         (maintenance_set_test_settings_list): ... this.
2661         (maintenance_test_settings_show_list): Rename to  ...
2662         (maintenance_show_test_settings_list): ... this.
2663         (maintenance_test_settings_cmd): Delete.
2664         (maintenance_test_settings_set_cmd): ...
2665         (maintenance_set_test_settings_cmd): ... this.
2666         (maintenance_test_settings_show_cmd): ...
2667         (maintenance_show_test_settings_cmd): ... this.
2668         (maintenance_test_settings_show_value_cmd):
2669         (maintenance_show_test_settings_value_cmd): ... this.
2670         (_initialize_maint_test_settings): No longer install the "maint
2671         test-settings" prefix command.  Rename "maint test-settings set"
2672         to "maint set test-settings", and "maint test-settings show" to
2673         "maint show test-settings".  Adjust all subcommands.
2674
2675 2019-07-03  Pedro Alves  <palves@redhat.com>
2676
2677         * maint-test-settings.c: Fix file's intro comment.  Replace all
2678         references to "test-options" with references to "test-settings",
2679         in comments.
2680
2681 2019-07-03  Pedro Alves  <palves@redhat.com>
2682
2683         * maint-test-settings.c (maintenance_test_settings_xxx)
2684         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2685         New.
2686         (maintenance_test_settings_enums): Use them.
2687         (maintenance_test_settings_enum): Default to
2688         maintenance_test_settings_xxx.
2689         (_initialize_maint_test_settings): Initialize
2690         MAINTENANCE_TEST_SETTINGS_FILENAME.
2691
2692 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2693
2694         * breakpoint.h (remove_breakpoints_inf): Change return type to
2695         void, move function documentation here.
2696         * breakpoint.c (remove_breakpoints_inf): Change return type to
2697         void, move function documentation to header.
2698
2699 2019-07-02  Pedro Alves  <palves@redhat.com>
2700
2701         * NEWS (Completion improvements): Mention "info threads".
2702         * thread.c (struct info_threads_opts, info_threads_option_defs)
2703         (make_info_threads_options_def_group): New.
2704         (info_threads_command): Use gdb::option::process_options.
2705         (info_threads_command_completer): New.
2706         (_initialize_thread): Use gdb::option::build_help to build the
2707         help text for "info threads".
2708
2709 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2710
2711         * defs.h (generic_load): Move from here...
2712         * symfile.h (generic_load): ... to here.  Rename name parameter
2713         to args.
2714         * symfile.c (generic_load): Add comment.
2715
2716 2019-07-01  Tom Tromey  <tromey@adacore.com>
2717
2718         * dwarf2read.c
2719         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2720         declaration of without_params.  Fix formatting.
2721
2722 2019-07-01  Tom Tromey  <tromey@adacore.com>
2723
2724         * ada-exp.y (find_primitive_type): Update.
2725         * ada-lang.h (ada_lookup_symbol): Update.
2726         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2727         parameter.
2728         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2729
2730 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2731
2732         PR breakpoints/24541
2733         * gdbarch.c: Regenerate.
2734         * gdbarch.h: Regenerate.
2735         * gdbarch.sh: Add 'stap_adjust_register'.
2736         * i386-tdep.c: Include '<unordered_set>'.
2737         (i386_stap_adjust_register): New function.
2738         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2739         * stap-probe.c (stap_parse_register_operand): Call
2740         'gdbarch_stap_adjust_register'.
2741
2742 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2743
2744         PR python/24742
2745         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2746         * python/python.c (do_start_initialization): Use 'xmalloc'
2747         instead of 'PyMem_Malloc'.
2748
2749 2019-06-28  Tom Tromey  <tromey@adacore.com>
2750
2751         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2752         for Ada.
2753
2754 2019-06-27  Tom Tromey  <tromey@adacore.com>
2755
2756         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2757         objfile_key.
2758         (arm_find_mapping_symbol, arm_record_special_symbol)
2759         (_initialize_arm_tdep): Update.
2760         (arm_objfile_data_free): Remove.
2761
2762 2019-06-27  Tom Tromey  <tromey@adacore.com>
2763
2764         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2765         to cp_print_static_field.
2766
2767 2019-06-26  Tom Tromey  <tromey@adacore.com>
2768
2769         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2770         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2771         declare.
2772
2773 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2774
2775         * features/aarch64-core.c (create_feature_aarch64_core):
2776         Regenerate.
2777         * features/aarch64-core.xml: Add cpsr flags.
2778
2779 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2780
2781         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2782         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2783
2784 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2785
2786         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2787         field.
2788         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2789         use.
2790         (arm_record_special_symbol): Don't insert new symbol in sorted
2791         position, push it at the end.
2792
2793 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2794
2795         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2796         (arm_mapping_symbol_s): Remove.
2797         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2798         (arm_mapping_symbol_vec): New typedef.
2799         (struct arm_per_objfile): Add constructor.
2800         <section_maps>: Change type to
2801         std::unique_ptr<arm_mapping_symbol_vec[]>.
2802         (arm_compare_mapping_symbols): Remove.
2803         (arm_find_mapping_symbol): Adjust to section_maps type change.
2804         (arm_objfile_data_free): Call delete on arm_per_objfile.
2805         (arm_record_special_symbol): Adjust to section_maps type change.
2806         Allocate arm_per_objfile with new.
2807
2808 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2809
2810         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2811         with the command prefix.
2812
2813 2019-06-25  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2816         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2817
2818 2019-06-25  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2821         type.
2822         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2823         protected.
2824
2825 2019-06-25  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-winsource.c
2828         (tui_source_window_base::set_is_exec_point_at): Add check against
2829         LOA_ADDRESS.
2830
2831 2019-06-25  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-source.c (tui_set_source_content): Don't check before
2834         xfree.
2835         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2836
2837 2019-06-25  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-winsource.h (tui_update_source_window_as_is)
2840         (tui_alloc_source_buffer, tui_line_is_displayed)
2841         (tui_addr_is_displayed): Change type of win_info.
2842         * tui/tui-winsource.c (tui_update_source_window_as_is)
2843         (tui_clear_source_content, tui_show_source_line)
2844         (tui_show_source_content, tui_source_window_base::refill)
2845         (tui_source_window_base::set_is_exec_point_at)
2846         (tui_source_window_base::set_is_exec_point_at)
2847         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2848         (tui_alloc_source_buffer, tui_line_is_displayed)
2849         (tui_addr_is_displayed): Change type of win_info.  Update.
2850         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2851         (tui_source_window_base::do_make_visible_with_new_height):
2852         Update.
2853         * tui/tui-source.c (tui_set_source_content)
2854         (tui_set_source_content_nil)
2855         (tui_source_window::do_scroll_vertical): Update.
2856         * tui/tui-layout.c (show_layout): Update.
2857         * tui/tui-disasm.c (tui_set_disassem_content)
2858         (tui_disasm_window::do_scroll_vertical): Update.
2859         * tui/tui-data.h (tui_win_content): Remove.
2860         (struct tui_gen_win_info) <content, content_size>: Remove.
2861         (struct tui_source_element): Add initializers and destructor.
2862         (union tui_which_element, struct tui_win_element): Remove.
2863         (struct tui_source_window_base) <content>: New field.
2864         (struct tui_data_window): Remove destructor.
2865         (tui_alloc_content, tui_free_win_content)
2866         (tui_free_all_source_wins_content): Don't declare.
2867         * tui/tui-data.c (tui_initialize_static_data): Update.
2868         (init_content_element, tui_alloc_content): Remove.
2869         (~tui_gen_win_info): Update.
2870         (~tui_data_window, tui_free_all_source_wins_content)
2871         (tui_free_win_content, free_content, free_content_elements):
2872         Remove.
2873
2874 2019-06-25  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-winsource.h (tui_clear_source_content)
2877         (tui_erase_source_content, tui_show_source_content): Change type
2878         of win_info.
2879         * tui/tui-winsource.c (tui_clear_source_content)
2880         (tui_erase_source_content, tui_show_source_content): Change type
2881         of win_info.
2882         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2883         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2884         win_info.
2885         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2886         win_info.
2887         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2888
2889 2019-06-25  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-winsource.c (tui_clear_source_content)
2892         (tui_source_window_base::set_is_exec_point_at): Update.
2893         * tui/tui-source.c (tui_set_source_content_nil): Update.
2894         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2895         a bool.
2896         * tui/tui-data.c (init_content_element): Update.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2901         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2902         * tui/tui-layout.c (init_and_make_win): Update.
2903         * tui/tui.h (enum tui_win_type): Update.
2904         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2905         tui_win_is_auxillary.
2906         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2907         tui_win_is_auxillary.
2908
2909 2019-06-25  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2912         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2913         (tui_delete_data_content_windows, tui_display_all_data)
2914         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2915         Update.
2916         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2917         * tui/tui-regs.c (tui_last_regs_line_no)
2918         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2919         (tui_show_registers): Update.
2920         (tui_show_register_group): Return void.  Update.
2921         (tui_display_registers_from, tui_display_reg_element_at_line)
2922         (tui_display_registers_from_line, tui_check_register_values):
2923         Update.
2924         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2925         member.
2926         (struct tui_data_window) <regs_content>: Now a std::vector.
2927         <regs_content_count>: Remove.
2928         (tui_add_content_elements, tui_free_data_content): Don't declare.
2929         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2930         (init_content_element): Remove DATA_WIN case.  Add assert.
2931         (tui_add_content_elements): Remove.
2932         (tui_data_window): Update.
2933         (tui_free_data_content): Remove.
2934         (free_content_elements): Remove DATA_WIN case.
2935
2936 2019-06-25  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-data.c (tui_data_item_window): Update.
2939         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2940         * tui/tui-windata.c (tui_display_all_data)
2941         (tui_display_data_from_line): Update.
2942         (tui_check_data_values): Remove.
2943         * tui/tui-regs.c (tui_show_register_group)
2944         (tui_display_reg_element_at_line): Update.
2945         * tui/tui-hooks.c (tui_register_changed)
2946         (tui_refresh_frame_and_register_information): Call
2947         tui_check_register_values.
2948         * tui/tui-data.h (struct tui_data_window) <data_content,
2949         data_content_count, data_type>: Remove.
2950         (enum tui_data_type): Remove.
2951
2952         * tui/tui-data.c (tui_data_window::clear_detail)
2953         (~tui_data_window): Update.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2958         declare.
2959         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2960         Rename from tui_first_data_item_displayed.  Update.
2961         (tui_data_window::refresh_all)
2962         (tui_data_window::do_scroll_vertical): Update.
2963         * tui/tui-data.h (struct tui_data_window)
2964         <first_data_item_displayed>: Declare new method.
2965
2966 2019-06-25  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2969         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2970         contents...
2971         (tui_initialize_static_data): ...here.
2972
2973 2019-06-25  Tom Tromey  <tom@tromey.com>
2974
2975         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2976         (tui_display_registers_from, tui_check_register_values): Update.
2977         (tui_display_register): Remove win_info parameter; update.
2978         (tui_get_register): Change type of parameters.
2979         * tui/tui-data.h (struct tui_data_element): Remove.
2980         (union tui_which_element) <data>: Remove.
2981         <data_window>: Change type.
2982         (struct tui_data_item_window): New.
2983         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2984         case.  Add assert.
2985         (~tui_data_item_window): New destructor.
2986         (free_content_elements): Remove DATA_ITEM_WIN case.
2987
2988 2019-06-25  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2991         Remove.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-data.h (struct tui_command_element): Remove.
2996         (union tui_which_element) <command>: Remove.
2997         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2998         assert.
2999         (free_content_elements): Remove CMD_WIN case.
3000
3001 2019-06-25  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-layout.c (tui_set_layout): Update.
3004         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3005         * tui/tui-data.c (layout_def): Update.
3006
3007 2019-06-25  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3010         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3011         (tui_source_window_base::set_new_height): Update.
3012         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3013         Update.
3014         (tui_set_locator_fullname, tui_set_locator_info)
3015         (tui_show_frame_info): Update.
3016         * tui/tui-source.c (tui_set_source_content)
3017         (tui_source_is_displayed): Update.
3018         * tui/tui-layout.c (show_source_disasm_command, show_data)
3019         (show_source_or_disasm_and_command): Update.
3020         * tui/tui-disasm.c (tui_set_disassem_content)
3021         (tui_get_begin_asm_address): Update.
3022         * tui/tui-data.h (struct tui_locator_element): Remove.
3023         (union tui_which_element) <locator>: Remove.
3024         (struct tui_locator_window): New.
3025         (tui_locator_win_info_ptr): Change return type.
3026         * tui/tui-data.c (_locator): Change type.
3027         (tui_locator_win_info_ptr): Change return type.
3028         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3029         (tui_alloc_content): Add assert.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-winsource.c
3034         (tui_exec_info_window::maybe_allocate_content): New method.
3035         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3036         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3037         (make_source_or_disasm_window): Add cast.
3038         * tui/tui-data.h (union tui_which_element) <simple_string>:
3039         Remove.
3040         (struct tui_source_info): New.
3041         (struct tui_source_window_base) <execution_info>: Change type.
3042         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3043         case, and add assert.
3044         (tui_alloc_content): Add assert.
3045
3046 2019-06-25  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3049         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3050         * tui/tui-data.c (tui_alloc_win_info): Remove.
3051
3052 2019-06-25  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3055         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3056         can_highlight.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3061         make_visible_with_new_height method.
3062         (tui_win_info::make_visible_with_new_height): New method.
3063         (tui_source_window_base::do_make_visible_with_new_height)
3064         (tui_data_window::do_make_visible_with_new_height)
3065         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3066         (make_visible_with_new_height): Remove.
3067         (tui_resize_all, tui_adjust_win_heights): Use
3068         make_visible_with_new_height method.
3069         * tui/tui-data.h (struct tui_win_info)
3070         <do_make_visible_with_new_height, make_visible_with_new_height>:
3071         New methods.
3072         (struct tui_source_window_base, struct tui_data_window)
3073         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3074         methods.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3079         method.
3080         (update_tab_width): Call update_tab_width method.
3081         * tui/tui-data.h (struct tui_win_info)
3082         (struct tui_source_window_base) <update_tab_width>: New methods.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3087         parameter.
3088         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3089         parameter.
3090         (tui_gen_win_info::make_visible): Update.
3091         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3092         parameter.
3093         * tui/tui-data.h (enum tui_box): New enum.
3094         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3095
3096 2019-06-25  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3099         init_and_make_win for EXEC_INFO_WIN.
3100         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3101         longer inline.
3102         (struct tui_win_info) <~tui_win_info>: Inline.
3103         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3104         Don't declare.
3105         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3106         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3107         Remove.
3108         (tui_initialize_static_data): Update.
3109         (~tui_gen_win_info): Handle more cleanup here.
3110         (~tui_source_window_base): Delete "execution_info".
3111         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3112
3113 2019-06-25  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-layout.c (make_command_window): Don't set
3116         can_highlight.
3117         (show_source_disasm_command): Call the reset method.
3118         (show_data): Don't set can_highlight.  Call the reset method.
3119         (tui_gen_win_info::reset): Rename from init_gen_win_info
3120         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3121         (show_source_or_disasm_and_command): Call the reset method.
3122         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3123         (struct tui_cmd_window): Set can_highlight.
3124
3125 2019-06-25  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3128         from make_visible.
3129         (tui_make_visible, tui_make_invisible): Rewrite.
3130         (tui_win_info::make_visible): Remove.
3131         (tui_source_window_base::make_visible): Update.
3132         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3133         method.  Moved from...
3134         (struct tui_win_info) <make_visible>: ...here.
3135
3136 2019-06-25  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-winsource.c
3139         (tui_source_window_base::do_scroll_horizontal): Remove direction
3140         parameter.
3141         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3142         direction parameter.
3143         * tui/tui-win.c (tui_win_info::forward_scroll)
3144         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3145         (tui_win_info::right_scroll): Update.
3146         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3147         direction parameter.
3148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3149         direction parameter.
3150         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3151         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3152         Remove direction parameter.
3153         (struct tui_source_window_base, struct tui_source_window)
3154         (struct tui_disasm_window, struct tui_data_window)
3155         (struct tui_cmd_window): Update.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-winsource.h (tui_set_exec_info_content)
3160         (tui_show_exec_info_content, tui_erase_exec_info_content)
3161         (tui_clear_exec_info_content, tui_update_exec_info): Change
3162         argument to tui_source_window_base.
3163         * tui/tui-winsource.c (tui_set_exec_info_content)
3164         (tui_show_exec_info_content, tui_erase_exec_info_content)
3165         (tui_clear_exec_info_content, tui_update_exec_info): Change
3166         argument to tui_source_window_base.
3167
3168 2019-06-25  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3171         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3172
3173 2019-06-25  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3176         check.
3177
3178 2019-06-25  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3181         type to void.
3182         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3183         type to void.
3184         * tui/tui-source.c (tui_set_source_content): Update.
3185         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-win.c (window_name_completer, tui_set_focus)
3190         (tui_all_windows_info): Use name method.
3191         * tui/tui-data.h (struct tui_gen_win_info)
3192         (struct tui_source_window, struct tui_disasm_window)
3193         (struct tui_data_window, struct tui_cmd_window) <name>: New
3194         method.
3195         (tui_win_name): Don't declare.
3196         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3197         (tui_win_name): Remove.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-winsource.h (tui_update_source_window)
3202         (tui_update_source_window_as_is): Change parameter type.
3203         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3204         to be a tui_source_window_base.
3205         (tui_update_source_window_as_is): Likewise.
3206         * tui/tui-win.c (make_visible_with_new_height): Update.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-winsource.c (tui_erase_source_content)
3211         (tui_show_source_content, tui_show_exec_info_content)
3212         (tui_erase_exec_info_content): Use refresh_window method.
3213         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3214         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3215         from tui_refresh_win.
3216         (tui_data_window::refresh_window): New method.
3217         (tui_win_info::refresh, tui_source_window_base::refresh)
3218         (tui_refresh_all): Use refresh_window method.
3219         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3220         method.
3221         * tui/tui-regs.c (tui_display_register): Call refresh_window
3222         method.
3223         * tui/tui-layout.c (show_source_disasm_command)
3224         (show_source_or_disasm_and_command): Call refresh_window method.
3225         * tui/tui-data.h (struct tui_gen_win_info)
3226         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3227         New method.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui.c (tui_rl_other_window, tui_enable)
3232         (tui_is_window_visible, tui_get_command_dimension): Update.
3233         * tui/tui-winsource.c (tui_update_source_window_as_is)
3234         (tui_clear_source_content, tui_erase_source_content)
3235         (tui_show_source_line, tui_source_window_base::refill)
3236         (tui_source_window_base::do_scroll_horizontal)
3237         (tui_source_window_base::set_is_exec_point_at)
3238         (tui_update_breakpoint_info, tui_set_exec_info_content)
3239         (tui_alloc_source_buffer, tui_line_is_displayed)
3240         (tui_addr_is_displayed): Update.
3241         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3242         (tui_check_and_display_highlight_if_needed)
3243         (tui_win_info::make_visible, tui_win_info::refresh)
3244         (tui_refresh_all): Update.
3245         * tui/tui-windata.c (tui_first_data_item_displayed)
3246         (tui_delete_data_content_windows, tui_erase_data_content)
3247         (tui_display_all_data, tui_data_window::refresh_all)
3248         (tui_check_data_values): Update.
3249         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3250         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3251         (tui_win_info::backward_scroll, tui_refresh_all_win)
3252         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3253         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3254         (tui_source_window_base::set_new_height)
3255         (tui_data_window::set_new_height)
3256         (make_invisible_and_set_new_height)
3257         (make_visible_with_new_height, new_height_ok)
3258         (parse_scrolling_args): Update.
3259         * tui/tui-stack.c (tui_show_frame_info): Update.
3260         * tui/tui-source.c (tui_set_source_content)
3261         (tui_set_source_content_nil, tui_source_is_displayed)
3262         (tui_source_window::do_scroll_vertical): Update.
3263         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3264         (tui_display_registers_from, tui_display_reg_element_at_line)
3265         (tui_check_register_values, tui_reg_command): Update.
3266         * tui/tui-layout.c (tui_default_win_height)
3267         (show_source_disasm_command, show_data, init_and_make_win)
3268         (show_source_or_disasm_and_command): Update.
3269         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3270         (tui_redisplay_readline, tui_mld_flush)
3271         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3272         (tui_getc): Update.
3273         * tui/tui-disasm.c (tui_set_disassem_content)
3274         (tui_disasm_window::do_scroll_vertical): Update.
3275         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3276         Now virtual.
3277         (struct tui_win_info): Derive from tui_gen_win_info.
3278         <~tui_win_info>: Mark as override.
3279         <generic>: Remove member.
3280         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3281         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3282         (~tui_data_window, ~tui_win_info)
3283         (tui_free_all_source_wins_content): Update.
3284         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-layout.c (init_and_make_win): Use new.
3289         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3290         destructor, initializers.
3291         (tui_alloc_generic_win_info): Don't declare.
3292         * tui/tui-data.c (_locator): Add argument to constructor.
3293         (source_win, disasm_win): New globals.
3294         (exec_info): Remove.
3295         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3296         Update.
3297         (tui_alloc_generic_win_info): Remove.
3298         (init_content_element): Use new.
3299         (tui_win_info::tui_win_info): Update.
3300         (free_content_elements) <case DATA_WIN>: Use delete.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3305         * tui/tui-windata.c (tui_first_data_item_displayed)
3306         (tui_delete_data_content_windows): Update.
3307         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3308         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3309         (tui_display_registers_from, tui_check_register_values): Update.
3310         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3311         pointer.
3312         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3313         window.
3314         (tui_free_data_content): Update.
3315         (free_content_elements) <case DATA_WIN>: Free the window.
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3320         Update.
3321         * tui/tui-layout.c (make_command_window)
3322         (show_source_disasm_command, show_data, init_and_make_win)
3323         (show_source_or_disasm_and_command): Update.
3324         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3325         method.
3326         <can_highight, is_highlighted>: Now bool.
3327         (tui_set_win_highlight): Don't declare.
3328         * tui/tui-data.c (tui_set_win_highlight): Remove.
3329
3330 2019-06-25  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-wingeneral.c (make_visible): Remove check of window
3333         type.
3334
3335 2019-06-25  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-win.c (tui_win_info::max_height)
3338         (tui_cmd_window::max_height): New methods.
3339         (new_height_ok): Call max_height.
3340         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3341         <max_height>: New method.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-win.c (tui_source_window_base::set_new_height)
3346         (tui_data_window::set_new_height): New methods.
3347         (make_invisible_and_set_new_height): Call set_new_height method.
3348         * tui/tui-data.h (struct tui_win_info)
3349         (struct tui_source_window_base, struct tui_data_window)
3350         <set_new_height>: New method.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3355         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3356         tui_refresh_data_win.
3357         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3358         method.
3359         (tui_refresh_all_win): Call the refresh_all method.
3360         (tui_set_focus): Likewise.
3361         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3362         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3363         Likewise.
3364
3365 2019-06-25  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-winsource.h (tui_refill_source_window)
3368         (tui_set_is_exec_point_at): Don't declare.
3369         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3370         (tui_source_window_base::refill): Rename from
3371         tui_refill_source_window.
3372         (tui_source_window_base::do_scroll_horizontal): Update.
3373         (tui_source_window_base::set_is_exec_point_at): Rename from
3374         tui_set_is_exec_point_at.
3375         (tui_update_all_breakpoint_info): Update.
3376         * tui/tui-stack.c (tui_show_frame_info): Update.
3377         * tui/tui-layout.c (show_data): Add cast.
3378         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3379         * tui/tui-data.h (struct tui_source_window_base) <refill,
3380         set_is_exec_point_at>: New methods.
3381         (tui_source_windows, tui_add_to_source_windows): Update types.
3382         (tui_add_to_source_windows): Remove redundant declaration.
3383         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3384         (tui_source_windows): Change return type.
3385         (tui_clear_source_windows_detail): Update.
3386         (tui_add_to_source_windows): Change type of parameter.
3387         (tui_free_all_source_wins_content): Update.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-wingeneral.c (tui_win_info::refresh)
3392         (tui_source_window_base::refresh): New methods.
3393         (tui_refresh_all): Call the refresh method.
3394         * tui/tui-data.h (struct tui_win_info)
3395         (struct tui_source_window_base) <refresh>: New method.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui.h (tui_is_window_visible): Return bool.
3400         * tui/tui.c (tui_is_window_visible): Return bool.
3401         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3402         (tui_make_visible, tui_make_invisible)
3403         (tui_win_info::make_visible)
3404         (tui_source_window_base::make_visible, make_all_visible)
3405         (tui_make_all_visible, tui_make_all_invisible): Update.
3406         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3407         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3408         bool.
3409         (struct tui_win_info, struct tui_source_window_base)
3410         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3411         * tui/tui-data.c (tui_init_generic_part): Update.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3416         (tui_source_window_base::make_visible): New methods.
3417         (make_all_visible): Make method call.
3418         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3419         (struct tui_source_window_base, struct tui_cmd_window): Override
3420         make_visible.
3421         (tui_win_is_source_type): Don't declare.
3422         * tui/tui-data.c (tui_win_is_source_type): Remove.
3423
3424 2019-06-25  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3427         NULL check.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3432         Inline constructor.  Add initializers for members.
3433         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3434         constructors; now inline in class.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-regs.c (tui_show_registers): Update.
3439         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3440         bool.
3441         * tui/tui-data.c (tui_data_window::clear_detail)
3442         (tui_data_window): Update.
3443
3444 2019-06-25  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-windata.c (tui_display_all_data)
3447         (tui_display_data_from_line, tui_display_data_from)
3448         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3449         Update.
3450         * tui/tui-regs.c (tui_last_regs_line_no)
3451         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3452         (tui_show_registers, tui_show_register_group)
3453         (tui_display_registers_from, tui_display_reg_element_at_line)
3454         (tui_display_registers_from_line, tui_check_register_values)
3455         (tui_reg_next, tui_reg_prev): Update.
3456         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3457         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3458         tui_data_window.
3459         (struct tui_win_info) <detail>: Remove.  Add new fields from
3460         tui_data_info.
3461         (TUI_DATA_WIN): Add cast.
3462         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3463         (~tui_data_window): Simplify.
3464
3465 2019-06-25  Tom Tromey  <tom@tromey.com>
3466
3467         * tui/tui-layout.c (show_source_disasm_command)
3468         (show_source_or_disasm_and_command): Update.
3469         * tui/tui-io.c (update_cmdwin_start_line)
3470         (tui_redisplay_readline): Update.
3471         * tui/tui-data.h (struct tui_command_info): Remove.
3472         (struct tui_win_info) <detail>: Remove command_info member.
3473         (struct tui_data_window) <start_line>: New member, from
3474         tui_command_info.
3475         (TUI_CMD_WIN): Add casts.
3476
3477 2019-06-25  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-winsource.c (tui_update_source_window)
3480         (tui_refill_source_window)
3481         (tui_source_window_base::do_scroll_horizontal)
3482         (tui_update_breakpoint_info, tui_set_exec_info_content)
3483         (tui_show_exec_info_content, tui_erase_exec_info_content)
3484         (tui_clear_exec_info_content): Update.
3485         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3486         Update.
3487         * tui/tui-win.c (make_invisible_and_set_new_height)
3488         (make_visible_with_new_height): Update.
3489         * tui/tui-source.c (tui_set_source_content)
3490         (tui_show_symtab_source): Update.
3491         * tui/tui-layout.c (extract_display_start_addr)
3492         (show_source_disasm_command, show_data)
3493         (make_source_or_disasm_window)
3494         (show_source_or_disasm_and_command): Update.
3495         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3496         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3497         "gdbarch".
3498         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3499         to tui_source_window_base.
3500         (struct tui_win_info) <detail>: Remove source_info member.
3501         (struct tui_source_window_base) <has_locator>: Inline.
3502         Move contents from tui_source_info; rename has_locator member to
3503         m_has_locator.
3504         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3505         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3506         header file.
3507         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3508         Simplify.
3509         (tui_free_all_source_wins_content): Cast to
3510         tui_source_window_base.
3511
3512 2019-06-25  Tom Tromey  <tom@tromey.com>
3513
3514         * tui/tui-win.c (make_invisible_and_set_new_height)
3515         (make_visible_with_new_height): Call has_locator method.
3516         * tui/tui-layout.c (show_source_disasm_command, show_data)
3517         (show_source_or_disasm_and_command): Update for bool change.
3518         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3519         (tui_win_info) <has_locator>: New method.
3520         (struct tui_source_window_base) <has_locator>: New method.
3521         (tui_win_has_locator): Don't declare.
3522         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3523         from tui_win_has_locator.
3524         (tui_source_window_base): Use false, not FALSE.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3529         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3530         clear_detail method directly.
3531         (tui_clear_win_detail): Remove.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3536         "this", not TUI_DISASM_WIN.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3541         declare.
3542         * tui/tui-winsource.c
3543         (tui_source_window_base::do_scroll_horizontal): Rename from
3544         tui_horizontal_source_scroll.
3545         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3546         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3547         from tui_vertical_data_scroll.
3548         * tui/tui-win.h (tui_scroll): Don't declare.
3549         * tui/tui-win.c (tui_win_info::forward_scroll)
3550         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3551         (tui_win_info::right_scroll): Rename and update.
3552         (tui_scroll_forward_command, tui_scroll_backward_command)
3553         (tui_scroll_left_command, tui_scroll_right_command): Update.
3554         (tui_scroll): Remove.
3555         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3556         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3557         from tui_vertical_source_scroll.
3558         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3559         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3560         from tui_vertical_disassem_scroll.
3561         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3562         do_scroll_horizontal>: New methods.
3563         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3564         Likewise.
3565         (struct tui_source_window_base): Add do_scroll_horizontal.
3566         (struct tui_source_window, struct tui_disasm_window): Add
3567         do_scroll_vertical.
3568         (struct tui_data_window, struct tui_cmd_window): Add
3569         do_scroll_horizontal and do_scroll_vertical.
3570         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3571
3572 2019-06-25  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-data.h (struct tui_source_window_base): New struct.
3575         (struct tui_source_window): Derive from tui_source_window_base.
3576         (struct tui_disasm_window): New struct.
3577         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3578         from tui_source_window::clear_detail.
3579         (tui_source_window_base): Rename from tui_source_window.
3580         (~tui_source_window_base): Rename from ~tui_source_window.
3581         (tui_alloc_win_info): Create a tui_disasm_window.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-data.h (struct tui_source_window)
3586         (struct tui_data_window): Declare destructors.
3587         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3588         destructors.
3589         (tui_win_info): Simplify.
3590
3591 2019-06-25  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-winsource.c (tui_display_main)
3594         (tui_update_source_windows_with_addr)
3595         (tui_update_all_breakpoint_info): Update.
3596         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3597         (new_height_ok, parse_scrolling_args): Update.
3598         * tui/tui-stack.c (tui_show_frame_info): Update.
3599         * tui/tui-data.h (struct tui_list): Remove.
3600         (tui_source_windows): Return a reference to a std::vector.
3601         * tui/tui-data.c (source_windows): Now a std::vector.
3602         (tui_source_windows): Change return type.
3603         (tui_clear_source_windows): Rewrite.
3604         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3605         (tui_free_all_source_wins_content): Rewrite.
3606
3607 2019-06-25  Tom Tromey  <tom@tromey.com>
3608
3609         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3610         (struct tui_data_window, struct tui_cmd_window): Declare
3611         clear_detail method.
3612         * tui/tui-data.c (tui_source_window::clear_detail)
3613         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3614         methods.
3615         (tui_clear_win_detail): Simplify.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-layout.c (make_source_window, make_disasm_window)
3620         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3621         Return the new window.
3622         (show_source_disasm_command, show_data)
3623         (show_source_or_disasm_and_command): Update.
3624
3625 2019-06-25  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3628         parameter.  Return the new window.
3629         (show_source_disasm_command): Update and remove NULL check.
3630         (show_source_or_disasm_and_command): Update.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3635
3636 2019-06-25  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-data.h (struct tui_win_info): Make constructor
3639         protected.  Make destructor virtual.  Add initializers.
3640         (tui_source_window, tui_data_window, tui_cmd_window): New
3641         classes.
3642         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3643         constructor.  Add "type" parameter.
3644         (tui_source_window, tui_data_window, tui_cmd_window): New
3645         constructors.
3646         (tui_alloc_win_info): Instantiate the appropriate subclass.
3647
3648 2019-06-25  Tom Tromey  <tom@tromey.com>
3649
3650         * tui/tui-win.c (tui_resize_all): Use delete.
3651         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3652         destructor.
3653         (tui_free_window): Don't declare.
3654         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3655         Update.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-data.h (struct tui_win_info): Add constructor.
3660         * tui/tui-data.c (tui_alloc_win_info): Use new.
3661         (tui_free_window): Use delete.
3662
3663 2019-06-22  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3666         declare.
3667         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3668
3669 2019-06-22  Tom Tromey  <tom@tromey.com>
3670
3671         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3672         declare.
3673         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3674
3675 2019-06-22  Tom de Vries  <tdevries@suse.de>
3676
3677         * dwarf2read.c (create_addrmap_from_aranges)
3678         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3679         instead of '%zu'.
3680
3681 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3682
3683         * dwarf2read.h (dwarf2_section_info_def): Remove.
3684         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3685         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3686         std::vector<dwarf2_section_info>.
3687         (struct dwo_file) <~dwo_file>: Remove.
3688         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3689         types field.
3690         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3691         (dwarf2_read_debug_names): Likewise.
3692         (create_debug_types_hash_table): Change parameter type to
3693         array_view, adjust code accordingly.
3694         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3695         (partial_die_info::fixup): Likewise.
3696         (determine_prefix): Likewise.
3697         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3698
3699 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3700
3701         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3702         gdb_bfd_ref_ptr.
3703         <~dwo_file>: Remove call to gdb_bfd_unref.
3704         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3705         gdb_bfd_ref_ptr::get.
3706
3707 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3708
3709         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3710         type to htab_up.
3711         * dwarf2read.c (struct dwo_file): Initialize fields.
3712         <~dwo_file>: New.
3713         (free_dwo_file): Remove, move content to ~dwo_file.
3714         (struct dwo_file_deleter): Remove.
3715         (dwo_file_up>: Remove custom deleter.
3716         (free_dwo_files): Remove.
3717         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3718         dwo_files.
3719         (process_skeletonless_type_units): Call unique_ptr::get.
3720         (allocate_dwo_file_hash_table): Add deleter to created hash
3721         table.  Change return type to htab_up.
3722         (lookup_dwo_file_slot): Don't memset dwo_file, call
3723         unique_ptr::get.
3724         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3725         (create_dwo_unit_in_dwp_v2): Likewise.
3726         (open_and_init_dwo_file): Likewise.
3727         (free_dwo_file_from_slot): Remove.
3728
3729 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3730
3731         * dwarf2read.h (struct dwarf2_section_info) <readin,
3732         is_virtual>: Change type to bool.
3733         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3734         true instead of 1.
3735
3736 2019-06-19  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-data.h (tui_init_content_element): Don't declare.
3739
3740 2019-06-19  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-data.h (tui_init_win_info): Don't declare.
3743
3744 2019-06-19  Tom de Vries  <tdevries@suse.de>
3745
3746         * dwarf2read.h (abstract_to_concrete): Change type to
3747         std::unordered_map<sect_offset, std::vector<sect_offset>,
3748         gdb::hash_enum<sect_offset>>.
3749
3750 2019-06-19  Tom Tromey  <tromey@adacore.com>
3751
3752         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3753         EVAL_AVOID_SIDE_EFFECTS specially.
3754
3755 2019-06-19  Tom Tromey  <tromey@adacore.com>
3756
3757         * source-cache.c (highlighter): New global.
3758         (source_cache::get_source_lines): Create a highlighter on demand.
3759
3760 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * defs.h (deprecated_interactive_hook): Delete declaration.
3763         * interps.c (clear_interpreter_hooks): Remove use of
3764         deprecated_interactive_hook.
3765         * top.c (deprecated_interactive_hook): Delete definition.
3766         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3767
3768 2019-06-18  Tom de Vries  <tdevries@suse.de>
3769
3770         PR gdb/24515
3771         * dwarf2read.h (abstract_to_concrete): Change type from
3772         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3773         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3774         * dwarf2read.c (read_variable): Update.
3775         (dwarf2_fetch_die_loc_sect_off): Update.
3776
3777 2019-06-17  Tom de Vries  <tdevries@suse.de>
3778
3779         PR gdb/24617
3780         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3781         accessing parent[parent_len - 1].
3782
3783 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3784
3785         PR gdb/24364
3786         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3787         call dtrace_process_dof with NULL dof.
3788
3789 2019-06-16  Tom de Vries  <tdevries@suse.de>
3790
3791         PR gdb/24445
3792         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3793
3794 2019-06-16  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3797         (make_all_visible): Use address of member.
3798
3799 2019-06-16  Tom Tromey  <tom@tromey.com>
3800
3801         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3802         (tui_free_window, free_content, free_content_elements): Remove
3803         unnecessary cast.
3804         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3805         cast.
3806         * tui/tui-regs.c (tui_show_register_group)
3807         (tui_display_registers_from, tui_display_reg_element_at_line):
3808         Remove unnecessary cast.
3809
3810 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * linux-nat.c (normal_mask): Delete.
3813         (_initialize_linux_nat): Don't initialise normal_mask.
3814
3815 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3816
3817         PR gdb/24445
3818         * dwarf-index-write.h (write_psymtabs_to_index): Add
3819         dwz_basename parameter.
3820         * dwarf-index-write.c (write_gdbindex): Move file writing to
3821         write_gdbindex_1.  Change return type void.
3822         (assert_file_size): Move up, remove filename parameter.
3823         (write_gdbindex_1): New function.
3824         (write_debug_names): Change return type to void, call
3825         assert_file_size.
3826         (struct index_wip_file): New struct.
3827         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3828         file logic to index_wip_file.  Write index for dwz file if
3829         needed.
3830         (save_gdb_index_command): Pass basename of dwz file, if present.
3831         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3832         build-id of dwz file, if present.
3833         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3834         (dwarf2_get_dwz_file): Likewise.
3835         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3836         (dwarf2_get_dwz_file): Likewise.
3837
3838 2019-06-16  Tom Tromey  <tom@tromey.com>
3839
3840         * coffread.c (process_coff_symbol): Use xstrdup.
3841         * value.c (create_internalvar): Use xstrdup.
3842
3843 2019-06-16  Tom Tromey  <tom@tromey.com>
3844
3845         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3846         * breakpoint.c (stopin_command, stopat_command)
3847         (until_break_command, decode_location_default): Remove unnecessary
3848         cast.
3849         * utils.c (subset_compare): Remove unnecessary cast.
3850         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3851         cast.
3852         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3853         cast.
3854         * infcmd.c (path_command): Remove unnecessary cast.
3855         * coffread.c (decode_type): Remove unnecessary cast.
3856         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3857         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3858         * tui/tui-stack.c (tui_show_locator_content)
3859         (tui_show_frame_info): Remove unnecessary cast.
3860         * tui/tui-win.c (tui_scroll_forward_command)
3861         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3862         (parse_scrolling_args): Remove unnecessary cast.
3863         * tui/tui-data.c (init_win_info, tui_del_window)
3864         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3865         (free_content_elements): Remove unnecessary cast.
3866         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3867         unnecessary cast.
3868         * tui/tui-source.c (tui_set_source_content)
3869         (tui_vertical_source_scroll): Remove unnecessary cast.
3870         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3871         cast.
3872         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3873         * tui/tui-regs.c (tui_display_registers_from)
3874         (tui_display_register): Remove unnecessary cast.
3875         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3876         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3877         (make_visible): Remove unnecessary cast.
3878         * tui/tui-winsource.c (tui_erase_source_content)
3879         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3880         unnecessary cast.
3881         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3882         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3883         * stabsread.c (read_type, read_array_type, read_range_type):
3884         Remove unnecessary cast.
3885         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3886         (parse_symbol, parse_type, upgrade_type, parse_external)
3887         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3888         unnecessary cast.
3889         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3890
3891 2019-06-16  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-data.c (tui_alloc_generic_win_info)
3894         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3895         checks.
3896
3897 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3898             Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * f-typeprint.c (f_print_type): Don't return early for not
3901         associated or not allocated types.
3902         (f_type_print_varspec_suffix): Add print_rank parameter and print
3903         ranks of array types in case they dangling.
3904         (f_type_print_base): Add print_rank parameter.
3905
3906 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * NEWS: Mention new MI commands.
3909         * break-catch-throw.c (enum exception_event_kind): Move to
3910         breakpoint.h.
3911         (print_mention_exception_catchpoint): Output text as a single
3912         message.
3913         (catch_exception_command_1): Rename to...
3914         (catch_exception_event): ...this, make non-static, update header
3915         command, and change some parameter types.
3916         (catch_catch_command): Update for changes to
3917         catch_exception_command_1.
3918         (catch_throw_command): Likewise.
3919         (catch_rethrow_command): Likewise.
3920         * breakpoint.c (enum exception_event_kind): Delete.
3921         * breakpoint.h (enum exception_event_kind): Moved here from
3922         break-catch-throw.c.
3923         (catch_exception_event): Declare.
3924         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3925         (mi_cmd_catch_throw): New function.
3926         (mi_cmd_catch_rethrow): New function.
3927         (mi_cmd_catch_catch): New function.
3928         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3929         'catch-catch' entries.
3930         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3931         (mi_cmd_catch_rethrow): Declare.
3932         (mi_cmd_catch_catch): Declare.
3933
3934 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * annotate.c (annotate_source_line): Change return type to void,
3937         update implementation to match.
3938         * annotate.h (annotate_source_line): Change return type to void,
3939         update header comment.
3940         * stack.c (print_frame_info): Don't change what frame information
3941         is printed based on whether annotations are on or not.
3942
3943 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3946         (annotate_source): Make static.
3947         (annotate_source_line): Moved from source.c and renamed from
3948         identify_source_line.  Update the return type.
3949         * annotate.h (annotate_source): Delete declaration.
3950         (annotate_source_line): Declaration moved from source.h, and
3951         renamed from identify_source_line.  Return type updated.
3952         * source.c (identify_source_line): Moved to annotate.c and renamed
3953         to annotate_source_line.
3954         (info_line_command): Remove check of annotation_level.
3955         * source.h (identify_source_line): Move declaration to annotate.h
3956         and rename to annotate_source_line.
3957         * stack.c: Add 'annotate.h' include.
3958         (print_frame_info): Remove check of annotation_level before
3959         calling annotate_source_line.
3960
3961 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * source-cache.c (source_cache::get_plain_source_lines): Use
3964         open_source_file_with_line_charpos instead of just
3965         open_source_file, remove call to find_source_lines.
3966         (source_cache::get_source_lines): Likewise.
3967         * source.c (find_source_lines): Make static.
3968         (get_filename_and_charpos): Renamed into...
3969         (open_source_file_with_line_charpos): ..this along with changes to
3970         return a scoped_fd, and some other minor clean ups.
3971         (identify_source_line): Use open_source_file_with_line_charpos.
3972         (search_command_helper): Use open_source_file_with_line_charpos
3973         instead of just open_source_file, remove call to
3974         find_source_lines.
3975         * source.h (open_source_file_with_line_charpos): Declare new
3976         function.
3977         (find_source_lines): Delete declaration.
3978
3979 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * source.c (get_filename_and_charpos): Remove fullname
3982         parameter.
3983         (identify_source_line): Update call to get_filename_and_charpos.
3984
3985 2019-06-14  Tom Tromey  <tromey@adacore.com>
3986
3987         PR gdb/24502:
3988         * ui-style.h (skip_ansi_escape): Update comment.
3989         * ui-file.h (class no_terminal_escape_file): New class.
3990         * ui-file.c (no_terminal_escape_file::write)
3991         (no_terminal_escape_file::puts): New methods.
3992         * cli/cli-logging.c (handle_redirections): Use
3993         no_terminal_escape_file.
3994
3995 2019-06-14  Tom Tromey  <tromey@adacore.com>
3996
3997         * NEWS: Move convenience variable news above Python news.
3998
3999 2019-06-14  Tom Tromey  <tom@tromey.com>
4000
4001         * gnulib: Move directory to top-level.
4002         * configure.ac: Don't configure gnulib.
4003         * configure: Rebuild.
4004         * common/common-defs.h: Use new path to gnulib.
4005         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4006         (GNULIB_H): Remove.
4007         (INCGNU): Look in new gnulib location.
4008         (HFILES_NO_SRCDIR): Remove gnulib files.
4009         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4010         (generated_files): Remove GNULIB_H.
4011         ($(LIBGNU), all-lib): Remove targets.
4012         (distclean): Don't mention GNULIB_BUILDDIR.
4013         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4014
4015 2019-06-14  Tom Tromey  <tromey@adacore.com>
4016
4017         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4018         Warn if symbol file does not provide any symbols.
4019
4020 2019-06-14  Tom Tromey  <tromey@adacore.com>
4021
4022         * source.c (find_and_open_source): Respect basenames_may_differ.
4023
4024 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * annotate.c (annotate_breakpoints_invalid): Make use of
4027         scoped_restore_terminal_state.
4028         (annotate_frames_invalid): Likewise.
4029
4030 2019-06-14  Tom Tromey  <tromey@adacore.com>
4031
4032         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4033         allow assignment to an internalvar.
4034
4035 2019-06-14  Tom Tromey  <tromey@adacore.com>
4036
4037         * ada-lex.l: Allow "_" in attribute names.
4038
4039 2019-06-14  Tom Tromey  <tromey@adacore.com>
4040
4041         PR gdb/24653:
4042         * regcache.c (registers_changed): Don't call alloca.
4043         * top.c (execute_command): Don't call alloca.
4044
4045 2019-06-13  Pedro Alves  <palves@redhat.com>
4046
4047         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4048         'expression'.  When parsing an expression, error out if there's
4049         junk after "unlimited".
4050         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4051         (do_set_command): Adjust calls to is_unlimited_literal.
4052
4053 2019-06-13  Pedro Alves  <palves@redhat.com>
4054
4055         * compile/compile.c (make_compile_options_def_group): Add braces
4056         around array_view initializer.
4057         * thread.c (make_thread_apply_all_options_def_group)
4058         (make_thread_apply_all_options_def_group): Likewise.
4059
4060 2019-06-13  Pedro Alves  <palves@redhat.com>
4061
4062         * NEWS (New commands): Mention "maint test-options
4063         require-delimiter", "maint test-options unknown-is-error", "maint
4064         test-options unknown-is-operand" and "maint show
4065         test-options-completion-result".
4066         (New command options, command completion): New section.
4067         (Completion improvements): New section.
4068         Mention that you can abbreviate "unlimited".
4069
4070 2019-06-13  Pedro Alves  <palves@redhat.com>
4071
4072         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4073         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4074         * unittests/cli-utils-selftests.c (test_parse_flags)
4075         (test_parse_flags_qcs): Delete.
4076         (test_cli_utils): Don't call deleted functions.
4077
4078 2019-06-13  Pedro Alves  <palves@redhat.com>
4079
4080         * thread.c: Include "cli/cli-option.h".
4081         (tp_array_compar_ascending): Global.
4082         (tp_array_compar): Delete function.
4083         (tp_array_compar_ascending, tp_array_compar_descending): New
4084         functions.
4085         (ascending_option_def, qcs_flag_option_def)
4086         (thr_qcs_flags_option_defs)
4087         (make_thread_apply_all_options_def_group)
4088         (make_thread_apply_options_def_group): New.
4089         (thread_apply_all_command): Use gdb::option::process_options.
4090         (thread_apply_command_completer)
4091         (thread_apply_all_command_completer): New.
4092         (thread_apply_command): Use gdb::option::process_options.
4093         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4094         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4095         to generate help text of "thread apply".  Adjust "taas"'s help.
4096         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4097         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4098
4099 2019-06-13  Pedro Alves  <palves@redhat.com>
4100
4101         * thread.c (thread_apply_command): Check for invalid TID with
4102         isdigit instead of !isalpha.
4103
4104 2019-06-13  Pedro Alves  <palves@redhat.com>
4105
4106         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4107         (validate_flags_qcs): New.
4108         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4109         (validate_flags_qcs): Declare.
4110         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4111         (make_frame_apply_options_def_group): New.
4112         (frame_apply_command_count): Process options with
4113         gdb::option::process_options.
4114         (frame_apply_completer): New.
4115         (frame_apply_level_completer, frame_apply_all_completer)
4116         (frame_apply_completer): New.
4117         (_initialize_stack): Update help of "frame apply", "frame apply
4118         level", "frame apply all" and "faas" to mention supported options
4119         and install command completers.
4120         * stack.h (frame_apply_all_completer): Declare.
4121         * thread.c: Include "stack.h".
4122         (tfaas_command): Add "--".
4123         (_initialize_thread): Update help "tfaas" to mention supported
4124         options and install command completer.
4125
4126 2019-06-13  Pedro Alves  <palves@redhat.com>
4127
4128         * completer.c (complete_nested_command_line): New.
4129         (gdb_completion_word_break_characters_throw): Add assertion.
4130         * completer.h (complete_nested_command_line): Declare.
4131
4132 2019-06-13  Pedro Alves  <palves@redhat.com>
4133
4134         * stack.c (parse_backtrace_qualifiers): New.
4135         (backtrace_command): Use it.
4136         (backtrace_command_completer): Complete on qualifiers.
4137
4138 2019-06-13  Pedro Alves  <palves@redhat.com>
4139
4140         * frame.c: Include "cli/cli-option.h.
4141         (user_set_backtrace_options): New.
4142         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4143         Delete.
4144         (get_prev_frame): Adjust.
4145         (boolean_option_def, uinteger_option_def)
4146         (set_backtrace_option_defs): New.
4147         (_initialize_frame): Adjust and use
4148         gdb::option::add_setshow_cmds_for_options to install "set
4149         backtrace past-main" and "set backtrace past-entry".
4150         * frame.h: Include "cli/cli-option.h".
4151         (struct frame_print_options): Forward declare.
4152         (print_frame_arguments_all, print_frame_arguments_scalars)
4153         (print_frame_arguments_none): Declare.
4154         (print_entry_values): Delete declaration.
4155         (struct frame_print_options, user_frame_print_options): New.
4156         (struct set_backtrace_options): New.
4157         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4158         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4159         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4160         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4161         (list_args_or_locals): Add frame_print_options parameter.
4162         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4163         * python/py-framefilter.c (enumerate_args): Pass down
4164         USER_FRAME_PRINT_OPTIONS.
4165         * stack.c: Include "cli/cli-option.h".
4166         (print_frame_arguments_all, print_frame_arguments_scalars)
4167         (print_frame_arguments_none): Declare.
4168         (print_raw_frame_arguments, print_entry_values): Delete.
4169         (user_frame_print_options): New.
4170         (boolean_option_def, enum_option_def, frame_print_option_defs):
4171         New.
4172         (struct backtrace_cmd_options): New.
4173         (bt_flag_option_def): New.
4174         (backtrace_command_option_defs): New.
4175         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4176         (print_frame_arg, read_frame_arg, print_frame_args)
4177         (print_frame_info, print_frame): Add frame_print_options parameter
4178         and use it.
4179         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4180         (backtrace_command_1): Add frame_print_options and
4181         backtrace_cmd_options parameters and use them.
4182         (make_backtrace_options_def_group): New.
4183         (backtrace_command): Process command options with
4184         gdb::option::process_options.
4185         (backtrace_command_completer): New.
4186         (_initialize_stack): Extend "backtrace"'s help to mention
4187         supported options.  Install completer for "backtrace".
4188         Install some settings commands with add_setshow_cmds_for_options.
4189
4190 2019-06-13  Pedro Alves  <palves@redhat.com>
4191
4192         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4193         and that "set/show print raw frame-arguments" are now deprecated.
4194
4195         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4196         command.
4197         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4198         * stack.c (_initialize_stack): Install "set/show print
4199         raw-frame-arguments", and deprecate "set/show print raw
4200         frame-arguments".
4201         * valprint.c (_initialize_valprint): Deprecate "set/show print
4202         raw".
4203
4204 2019-06-13  Pedro Alves  <palves@redhat.com>
4205
4206         * compile/compile.c (struct compile_options): New.
4207         (compile_flag_option_def, compile_command_option_defs)
4208         (make_compile_options_def_group): New.
4209         (compile_file_command): Handle options with
4210         gdb::option::process_options.
4211         (compile_file_command_completer): New function.
4212         (compile_code_command): Handle options with
4213         gdb::option::process_options.
4214         (compile_code_command_completer): New function.
4215         (_initialize_compiler): Install completers for "compile code" and
4216         "compile file".  Mention available options in "compile code" and
4217         "compile code"'s help.
4218         * completer.c (advance_to_completion_word): New, factored out from
4219         ...
4220         (advance_to_expression_complete_word_point): ... this.
4221         (advance_to_filename_complete_word_point): New.
4222         * completer.h (advance_to_filename_complete_word_point): New
4223         declaration.
4224
4225 2019-06-13  Pedro Alves  <palves@redhat.com>
4226
4227         * compile/compile.c: Include "cli/cli-option.h".
4228         (compile_print_value): Scope data pointer is now a
4229         value_print_options pointer; adjust.
4230         (compile_print_command): Process options.  Scope data pointer is
4231         now a value_print_options pointer; adjust.
4232         (_initialize_compile): Update "compile print"'s help to include
4233         supported options.  Install a completer for "compile print".
4234         * cp-valprint.c (show_vtblprint, show_objectprint)
4235         (show_static_field_print): Delete.
4236         (_initialize_cp_valprint): Don't install "set print
4237         static-members", "set print vtbl", "set print object" here.
4238         * printcmd.c: Include "cli/cli-option.h" and
4239         "common/gdb_optional.h".
4240         (print_command_parse_format): Rework to fill in a
4241         value_print_options instead of a format_data.
4242         (print_value): Change parameter type from format_data pointer to
4243         value_print_options reference.  Adjust.
4244         (print_command_1): Process options.  Adjust to pass down a
4245         value_print_options.
4246         (print_command_completer): New.
4247         (_initialize_printcmd): Install print_command_completer as
4248         handle_brkchars completer for the "print" command.  Update
4249         "print"'s help to include supported options.
4250         * valprint.c: Include "cli/cli-option.h".
4251         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4252         here from cp-valprint.c.
4253         (boolean_option_def, uinteger_option_def)
4254         (value_print_option_defs, make_value_print_options_def_group):
4255         New.  Use gdb::option::add_setshow_cmds_for_options to install
4256         "set print elements", "set print null-stop", "set print repeats",
4257         "set print pretty", "set print union", "set print array", "set
4258         print address", "set print symbol", "set print array-indexes".
4259         * valprint.h: Include <string> and "cli/cli-option.h".
4260         (make_value_print_options_def_group): Declare.
4261         (print_value): Change parameter type from format_data pointer to
4262         value_print_options reference.
4263         (print_command_completer): Declare.
4264
4265 2019-06-13  Pedro Alves  <palves@redhat.com>
4266
4267         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4268         (COMMON_SFILES): Add maint-test-settings.c.
4269         * cli/cli-decode.c (boolean_enums): New global, factored out from
4270         ...
4271         (add_setshow_boolean_cmd): ... here.
4272         * cli/cli-decode.h (boolean_enums): Declare.
4273         * cli/cli-option.c: New file.
4274         * cli/cli-option.h: New file.
4275         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4276         factored out from ...
4277         (parse_cli_boolean_value(const char *)): ... this.
4278         (is_unlimited_literal): Change parameter type to pointer to
4279         pointer.  Adjust and advance ARG pointer.
4280         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4281         (parse_cli_var_enum): New, factored out from ...
4282         (do_set_command): ... this.  Adjust.
4283         * cli/cli-setshow.h (parse_cli_boolean_value)
4284         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4285         (parse_cli_var_enum): Declare.
4286         * cli/cli-utils.c: Include "cli/cli-option.h".
4287         (get_ulongest): New.
4288         * cli/cli-utils.h (get_ulongest): Declare.
4289         (check_for_argument): New overloads.
4290         * maint-test-options.c: New file.
4291
4292 2019-06-13  Pedro Alves  <palves@redhat.com>
4293
4294         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4295         parse a range if "-" is at the end of the string.
4296
4297 2019-06-13  Pedro Alves  <palves@redhat.com>
4298
4299         * cli/cli-setshow.c (parse_auto_binary_operation)
4300         (parse_cli_boolean_value): Don't allow "o".
4301
4302 2019-06-13  Pedro Alves  <palves@redhat.com>
4303
4304         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4305         * NEWS: Mention maint test-settings KIND.
4306         * maint-test-settings.c: New file.
4307
4308 2019-06-13  Pedro Alves  <palves@redhat.com>
4309
4310         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4311         completer.
4312         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4313         "set" completers.
4314
4315 2019-06-13  Pedro Alves  <palves@redhat.com>
4316
4317         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4318         after item.
4319
4320 2019-06-13  Pedro Alves  <palves@redhat.com>
4321
4322         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4323
4324 2019-06-13  Pedro Alves <palves@redhat.com>
4325
4326         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4327         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4328         call.
4329         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4330         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4331         calls.
4332         (check_for_argument): Skip spaces after argument.
4333
4334 2019-06-13  Pedro Alves  <palves@redhat.com>
4335
4336         * thread.c (thread_apply_command): Adjust TID parsing.
4337         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4338         detected before end of string.
4339         (tid_is_in_list): Error out if LIST is invalid.
4340
4341 2019-06-13  Pedro Alves  <palves@redhat.com>
4342
4343         * completer.c (complete_line_internal_1): Rewind completion word
4344         point.
4345         (completion_tracker::advance_custom_word_point_by): Change
4346         parameter type to int.
4347         * completer.h (completion_tracker::advance_custom_word_point_by):
4348         Likewise.
4349
4350 2019-06-13  Pedro Alves  <palves@redhat.com>
4351
4352         * completer.c (advance_to_completion_word): Handle delimiters.
4353
4354 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4355
4356         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4357
4358 2019-06-11  Tom Tromey  <tom@tromey.com>
4359
4360         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4361         (xmalloc_failed): Move to alloc.c.
4362         * alloc.c: New file.
4363         * Makefile.in (COMMON_SFILES): Add alloc.c.
4364
4365 2019-06-11  Tom Tromey  <tom@tromey.com>
4366
4367         * nat/linux-waitpid.c: Don't include server.h.
4368         (linux_debug): Remove.
4369         (my_waitpid): Update.
4370
4371 2019-06-11  Tom Tromey  <tromey@adacore.com>
4372
4373         * infcall.c (_initialize_infcall): Remove trailing newline from
4374         help.
4375         * user-regs.c (_initialize_user_regs): Remove trailing newline
4376         from help.
4377         * typeprint.c (_initialize_typeprint): Remove trailing newline
4378         from help.
4379         * reverse.c (_initialize_reverse): Remove trailing newlines from
4380         help.
4381         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4382         from help.
4383         * language.c (add_set_language_command): Remove trailing newline
4384         from help.
4385         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4386         help.
4387         * disasm.c (_initialize_disasm): Remove trailing newline from
4388         help.
4389         * top.c (init_main): Remove trailing newline from help.
4390         * interps.c (_initialize_interpreter): Remove trailing newline
4391         from help.
4392         * btrace.c (_initialize_btrace): Remove trailing newlines from
4393         help.
4394         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4395         from help.
4396         * python/python.c (_initialize_python): Remove trailing newline
4397         from help.
4398         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4399         help.
4400         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4401         from help.  Reformat some text.
4402         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4403         from help.
4404         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4405         newline from help.
4406
4407 2019-06-11  Tom Tromey  <tromey@adacore.com>
4408
4409         * darwin-nat.c (darwin_decode_exception_message)
4410         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4411
4412 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4413
4414         * valops.c (value_slice): Check for not allocated or not
4415         associated values.
4416
4417 2019-06-10  Tom de Vries  <tdevries@suse.de>
4418
4419         PR gdb/24618
4420         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4421         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4422         invalid.
4423
4424 2019-06-10  Tom de Vries  <tdevries@suse.de>
4425
4426         PR gdb/24611
4427         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4428         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4429
4430 2019-06-10  Tom de Vries  <tdevries@suse.de>
4431
4432         PR symtab/24545
4433         * symtab.c (struct demangled_name_entry): Add language field.
4434         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4435         static minimal symbol".  Set and use language field.
4436
4437 2019-06-10  Tom Tromey  <tromey@adacore.com>
4438
4439         * ada-lang.c (_initialize_ada_language): Update help text.
4440
4441 2019-06-10  Tom Tromey  <tromey@adacore.com>
4442
4443         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4444         with a newline.
4445         * guile/guile.c (handle_boot_error): Don't end warning with a
4446         newline.
4447         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4448         warning with a newline.
4449         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4450         newline.
4451         (s12z_frame_cache): Likewise.
4452         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4453         a newline.
4454         * solib-svr4.c (disable_probes_interface): Don't end warning with
4455         a newline.
4456         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4457         newline.
4458         * python/python.c (do_finish_initialization): Don't end warning
4459         with a newline.
4460
4461 2019-06-10  Tom Tromey  <tom@tromey.com>
4462
4463         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4464         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4465         gdbpy_enter.
4466
4467 2019-06-10  Tom Tromey  <tromey@adacore.com>
4468
4469         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4470         data.
4471         (elf_new_init): Don't call stabsread_new_init.
4472         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4473         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4474         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4475
4476 2019-06-10  Tom de Vries  <tdevries@suse.de>
4477
4478         PR symtab/16264
4479         PR symtab/24517
4480         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4481
4482 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4483
4484         * source.c (find_and_open_source): Also rewrite relative file
4485         names.
4486
4487 2019-04-26  Amos Bird  <amosbird@gmail.com>
4488
4489         * annotate.c (annotate_thread_exited): Add "thread-exited"
4490         annotation.
4491
4492 2019-06-06  Tom Tromey  <tromey@adacore.com>
4493
4494         * maint.h (class scoped_command_stats): Use
4495         DISABLE_COPY_AND_ASSIGN.
4496         <print_time>: New method.
4497         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4498         print_time.
4499         (scoped_command_stats::print_time): New method.
4500
4501 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4504         instructions of lengths 6 or 8 bytes.
4505
4506 2019-06-04  Pedro Alves  <palves@redhat.com>
4507
4508         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4509
4510         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4511         * breakpoint.c (condition_completer): Likewise.
4512         * cli/cli-dump.c (scan_expression): Likewise.
4513         * common/filestuff.c (mkdir_recursive): Likewise.
4514         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4515         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4516         (gdb_abspath): Likewise.
4517         * compile/compile-cplus-types.c
4518         (compile_cplus_instance::decl_name): Likewise.
4519         * completer.c (complete_explicit_location):
4520         (signal_completer, reg_or_group_completer_1): Likewise.
4521         * cp-support.c (cp_remove_params_if_any): Likewise.
4522         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4523         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4524         * infcmd.c (strip_bg_char): Likewise.
4525         * linespec.c (copy_token_string): Likewise.
4526         * mi/mi-main.c (output_cores): Likewise.
4527         * psymtab.c (psymtab_search_name):
4528         * symfile.c (test_set_ext_lang_command): Likewise.
4529         * target.c (target_fileio_read_stralloc): Likewise.
4530         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4531         * value.c (complete_internalvar): Likewise.
4532
4533 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4534
4535         Add objfile property to gdb.Type.
4536         * NEWS: Mention Python API addition.
4537         * python/py-type.c (typy_get_objfile): New method.
4538
4539 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4540
4541         * NEWS: Mention the new set|show style [title|highlight].
4542         Mention changes to "show style", "help" and "apropos".
4543
4544 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4547         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4548         instead of print_help_for_command.
4549         (print_doc_of_command): New function.
4550         (help_list): Add 'apropos -v word' suggestion.
4551         (print_help_for_command): Style the command name using title style.
4552         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4553         (_initialize_cli_cmds): Describe -v in apropos_command help.
4554
4555 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4556
4557         * cli/cli-style.h (cli_style_option): Add name in constructor,
4558         add m_name class member, add constructor with intensity,
4559         add name class function.
4560         (cli_style_option::add_setshow_commands): Remove name argument.
4561         (highlight_style, title_style): New styles.
4562         * cli/cli-style.c (do_show): New function that shows a style
4563         characteristic styling the style name with itself.
4564         (set_style_name): New function.
4565         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4566         Update all callers according to the changes in cli/cli-style.h.
4567         * utils.h (fputs_highlighted): New function.
4568         * utils.c (fputs_highlighted): Likewise.
4569
4570 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4571
4572         * NEWS: Mention new pipe command and new convenience variables.
4573
4574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4575
4576         * cli/cli-cmds.c (pipe_command): New function.
4577         (_initialize_cli_cmds): Call add_com for pipe_command.
4578         Define | as an alias for pipe.
4579         (exit_status_set_internal_vars): New function.
4580         (shell_escape): Call exit_status_set_internal_vars.
4581         cli/cli-decode.c (find_command_name_length): Recognize | as
4582         a single character command.
4583
4584 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4585
4586         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4587         top.c (execute_command_to_ui_file): New function, mostly a copy
4588         of execute_command_to_string.
4589         (execute_command_to_string): Implement by calling
4590         execute_command_to_ui_file.
4591
4592 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4593
4594         * top.h (saved_command_line): Remove declaration.
4595         * top.c (previous_saved_command_line, previous_repeat_arguments):
4596         New variables.
4597         (saved_command_line): Make static, define together with other
4598         'repeat variables'.
4599         (dont_repeat): Clear repeat_arguments.
4600         (repeat_previous, get_saved_command_line, save_command_line):
4601         New functions.
4602         (gdb_init): Initialize saved_command_line
4603         and previous_saved_command_line.
4604         * main.c (captured_main_1): Remove saved_command_line initialization.
4605         * event-top.c (handle_line_of_input): Update to use
4606         the new 'repeat' related functions instead of direct access to
4607         saved_command_line.
4608         * command.h (repeat_previous, get_saved_command_line,
4609         save_command_line): New declarations.
4610         (dont_repeat): Add comment.
4611
4612 2019-05-30  Tom Tromey  <tromey@adacore.com>
4613
4614         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4615         Fix comment.
4616         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4617
4618 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4619
4620         PR cli/24587
4621         * completer.c (complete): Initialize variable word.
4622
4623 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4624
4625         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4626         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4627         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4628         'body' is NULL to the outter 'if', protecting the '!is_define'
4629         situation as well.
4630
4631 2019-05-29  Tom Tromey  <tromey@adacore.com>
4632
4633         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4634         (dwarf_unknown): New function.
4635         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4636         (dwarf_type_encoding_name): Use dwarf_unknown.
4637
4638 2019-05-29  Tom Tromey  <tromey@adacore.com>
4639
4640         PR c++/20020:
4641         * cp-valprint.c (cp_print_value_fields): Call
4642         cp_print_static_field inside "try".
4643
4644 2019-05-29  Tom Tromey  <tromey@adacore.com>
4645
4646         * inflow.c (struct terminal_info): Add default operator=.
4647         * configure: Rebuild.
4648         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4649         -Wdeprecated-copy-dtor, -Wredundant-move.
4650
4651 2019-05-29  Tom Tromey  <tromey@adacore.com>
4652
4653         * NEWS: Add entry.
4654         * infcmd.c (print_return_value_1): Handle finish_print
4655         option.
4656         (show_print_finish): New function.
4657         (_initialize_infcmd): Add "set/show print finish" commands.
4658         * valprint.c (user_print_options): Initialize new member.
4659         * valprint.h (struct value_print_options) <finish_print>: New
4660         member.
4661
4662 2019-05-28  Tom Tromey  <tromey@adacore.com>
4663
4664         * ada-lang.c (ada_remove_Xbn_suffix)
4665         (find_old_style_renaming_symbol)
4666         (parse_old_style_renaming): Remove.
4667         (ada_find_renaming_symbol): Don't call
4668         find_old_style_renaming_symbol.
4669         (ada_is_renaming_symbol): Rename from
4670         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4671         bool.  Now static.
4672         (ada_read_var_value): Update and simplify.
4673         * ada-exp.y (write_var_or_type): Remove old code.
4674
4675 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4676
4677         * event-top.c: Remove include comment.
4678         * inflow.c (class scoped_ignore_sigttou): Move from here...
4679         * inflow.h (class scoped_ignore_sigttou): ...to here.
4680         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4681         * top.c:  Remove include comment.
4682
4683 2019-05-27  Tom Tromey  <tom@tromey.com>
4684
4685         * NEWS: Fix typo.
4686
4687 2019-05-22  Tom Tromey  <tromey@adacore.com>
4688
4689         * target.c (target_follow_exec): Constify parameter.
4690         * target-delegates.c: Rebuild.
4691         * remote.c (remote_target::follow_exec): Constify parameter.
4692         * infrun.c (follow_exec): Constify parameter.
4693         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4694         (target_follow_exec): Likewise.
4695
4696 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4697
4698         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4699         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4700
4701 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4702
4703         * NEWS: Add debugredirect and testsuite sections.
4704
4705 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4706
4707         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4708         target descriptions using exclusively floating point register name
4709         aliases.
4710
4711 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4712
4713         PR gdb/18644:
4714         * f-lang.c (build_fortran_types): Handle the case where
4715         gdbarch_floatformat_for_type returns a nullptr.
4716
4717 2019-05-21  Tom de Vries  <tdevries@suse.de>
4718
4719         PR cli/24587
4720         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4721
4722 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4723
4724         PR gdb/18644:
4725         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4726         16-byte floats.
4727         * i386-tdep.c (i386_floatformat_for_type): Use
4728         floatformats_ia64_quad for the 16-byte floating point component
4729         within a fortran 32-byte complex number.
4730
4731 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4732
4733         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4734         delete default constructor.
4735         (find_partial_die): Update to return const struct.
4736         (partial_die_parent_scope): Move variable declaration into scope
4737         of its use and change its type to auto.
4738         (guess_partial_die_structure_name): Likewise.
4739         (partial_die_info::fixup): Likewise.
4740
4741 2019-05-17  Tom Tromey  <tromey@adacore.com>
4742
4743         * source.c (find_and_open_source): Remove cast.
4744
4745 2019-05-17  Tom Tromey  <tromey@adacore.com>
4746
4747         * annotate.c (annotate_source): Make "filename" const.
4748         * annotate.h (annotate_source): Use const.
4749
4750 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4751
4752         * disasm.c (set_disassembler_options): Send errors to stderr.
4753
4754 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4755
4756         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4757         (cli_interp_base::set_logging): Check debug_redirect.
4758         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4759         * cli/cli-logging.c (debug_redirect): Add static variable.
4760         (pop_output_files): Add default param.
4761         (handle_redirections): Print debug setting.
4762         (show_logging_command): Likewise.
4763         (_initialize_cli_logging): Add debugredirect command.
4764         * interps.c (current_interp_set_logging): Add debug_redirect
4765         parameter.
4766         * interps.h (set_logging): Add debug_redirect parameter.
4767         (current_interp_set_logging): Likewise.
4768         * mi/mi-common.h: Likewise.
4769         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4770
4771 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4772             Tom Tromey  <tromey@adacore.com>
4773
4774         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4775         directly.
4776         * cli/cli-interp.h (make_logging_output): Remove declaration.
4777         * cli/cli-logging.c (make_logging_output): Remove function.
4778         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4779         directly.
4780         * ui-file.c (tee_file::tee_file): Remove bools.
4781         (tee_file::~tee_file): Remove deletes.
4782         * ui-file.h (tee_file): Remove bools.
4783
4784 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4785
4786         * mi/mi-cmds.h (mi_cmd_complete): New function.
4787         * mi/mi-main.c (mi_cmd_complete): Likewise.
4788         * mi/mi-cmds.c: Define new MI command -complete.
4789         * NEWS: Mention new -complete command.
4790
4791 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4792
4793         * completer.h (complete): New function.
4794         * completer.c (complete): Likewise.
4795         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4796         function defined in completer.h.
4797
4798 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4799
4800         * MAINTAINERS (Write After Approval): Add myself.
4801
4802 2019-05-17  Tom de Vries  <tdevries@suse.de>
4803
4804         PR gdb/24094
4805         * dwarf2read.c (struct cu_partial_die_info): New struct.
4806         (find_partial_die): Return cu_partial_die_info.
4807         (partial_die_parent_scope, guess_partial_die_structure_name)
4808         (partial_die_info::fixup): Handle new return type of find_partial_die.
4809
4810 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4811
4812         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4813         "std::string", simplifying the algorithm.
4814
4815 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4816
4817         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4818         (stap_static_probe_ops::get_probes): Likewise.
4819
4820 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4821
4822         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4823         '-')" and "else if".
4824         (stap_parse_single_operand): Join checks for
4825         "gdbarch_stap_parse_special_token_p" and
4826         "gdbarch_stap_parse_special_token" in the same "if" statement.
4827         Invert check when verifying for operation on register
4828         displacement.
4829
4830 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4831
4832         * stap-probe.c (stap_get_opcode): Update comment.
4833         (stap_get_expected_argument_type): Likewise.
4834         (handle_stap_probe): Likewise.
4835
4836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4837
4838         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4839         return type to 'bool'.  Adjust comment.  Use 'bool' when
4840         appropriate.
4841         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4842         * stap-probe.c (stap_parse_argument_1): Likewise.
4843         (stap_is_operator): Likewise.
4844         (stap_is_generic_prefix): Likewise.
4845         (stap_is_register_prefix): Likewise.
4846         (stap_is_register_indirection_prefix): Likewise.
4847         (stap_is_integer_prefix): Likewise.
4848         (stap_generic_check_suffix): Likewise.
4849         (stap_check_integer_suffix): Likewise.
4850         (stap_check_register_suffix): Likewise.
4851         (stap_check_register_indirection_suffix): Likewise.
4852         (stap_parse_register_operand): Likewise.
4853         (stap_parse_single_operand): Likewise.
4854         (stap_parse_argument_1): Likewise.
4855         (stap_probe::get_argument_count): Likewise.
4856         (stap_is_operator): Likewise.
4857
4858 2019-05-16  Tom Tromey  <tromey@adacore.com>
4859
4860         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4861         keyword to foreach.
4862
4863 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4864
4865         * linux-thread-db.c (try_thread_db_load_1): Change return type
4866         to bool.
4867         (try_thread_db_load): Likewise.
4868         (try_thread_db_load_from_pdir_1): Likewise.
4869         (try_thread_db_load_from_pdir): Likewise.
4870         (try_thread_db_load_from_sdir): Likewise.
4871         (try_thread_db_load_from_dir): Likewise.
4872         (thread_db_load_search): Likewise.
4873         (has_libpthread): Likewise.
4874         (thread_db_load): Likewise.
4875
4876 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4877
4878         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4879         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4880         NULL, and complain/return if that's the case.
4881
4882 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4883
4884         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4885         (advance, posn, abstract_read_memory): New functions.
4886         [struct mem_read_abstraction]: New struct.
4887         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4888
4889 2019-05-14  Tom Tromey  <tromey@adacore.com>
4890
4891         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4892         value is not lval_memory.
4893
4894 2019-05-14  Tom Tromey  <tromey@adacore.com>
4895
4896         * solib.c (info_sharedlibrary_command): Style the file name.
4897
4898 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4899
4900         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4901         (aarch64_vnv_type): Likewise.
4902         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4903         * common/tdesc.c: Likewise.
4904         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4905         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4906         * features/aarch64-fpu.xml: Add ieee half view.
4907         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4908         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4909         * gdbtypes.h (struct builtin_type): Likewise.
4910         (struct objfile_type): Likewise.
4911
4912 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4913
4914         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4915         typo.
4916         * location.h (string_to_event_location): Likewise.
4917
4918 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4919
4920         GDB 8.3 released.
4921
4922 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4923
4924         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4925         New variable declaration.
4926         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4927         New variable.
4928         (print_one_breakpoint): Use ui_out::test_flags and new global
4929         variable to compute use_fixed_output.
4930         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4931         Remove.
4932         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4933         (mi_multi_location_breakpoint_output_fixed): Remove.
4934         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4935         new variable.
4936         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4937         fix_multi_location_breakpoint_output flag if version >= 3.
4938         * ui-out.h (enum ui_out_flag)
4939         <fix_multi_location_breakpoint_output>: New enumerator.
4940
4941 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4942
4943         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4944
4945 2019-05-10  Tom Tromey  <tromey@adacore.com>
4946
4947         * ada-lang.c (catch_ada_completer): New function.
4948         (_initialize_ada_language): Use it.
4949
4950 2019-05-10  Tom Tromey  <tromey@adacore.com>
4951
4952         * thread.c (print_thread_info): Make "requested_threads" const.
4953         * gdbthread.h (print_thread_info): Make "requested_threads"
4954         const.
4955         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4956         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4957
4958 2019-05-08  Tom Tromey  <tom@tromey.com>
4959
4960         * gdbtypes.c (objfile_type_data): Change type.
4961         (objfile_type, _initialize_gdbtypes): Update.
4962
4963 2019-05-08  Tom Tromey  <tom@tromey.com>
4964
4965         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4966         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4967         (_initialize_dwarf2_frame): Update.
4968
4969 2019-05-08  Tom Tromey  <tom@tromey.com>
4970
4971         * objc-lang.c (objc_objfile_data): Change type.
4972         (find_methods): Update.
4973         (_initialize_objc_lang): Remove.
4974
4975 2019-05-08  Tom Tromey  <tom@tromey.com>
4976
4977         * stabsread.c (rs6000_builtin_type_data): Change type.
4978         (rs6000_builtin_type, _initialize_stabsread): Update.
4979
4980 2019-05-08  Tom Tromey  <tom@tromey.com>
4981
4982         * mips-tdep.c (mips_pdr_data): Remove.
4983         (_initialize_mips_tdep): Update.
4984
4985 2019-05-08  Tom Tromey  <tom@tromey.com>
4986
4987         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4988         (hppa_init_objfile_priv_data, read_unwind_info)
4989         (find_unwind_entry, _initialize_hppa_tdep): Update.
4990
4991 2019-05-08  Tom Tromey  <tom@tromey.com>
4992
4993         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4994         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4995         on obstack.
4996         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4997
4998 2019-05-08  Tom Tromey  <tom@tromey.com>
4999
5000         * mdebugread.c (basic_type_data): Change type.
5001         (basic_type, _initialize_mdebugread): Update.
5002
5003 2019-05-08  Tom Tromey  <tom@tromey.com>
5004
5005         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5006
5007 2019-05-08  Tom Tromey  <tom@tromey.com>
5008
5009         * nto-tdep.c (nto_inferior_data_reg): Change type.
5010         (nto_inferior_data): Update.
5011         (nto_inferior_data_cleanup, nto_new_inferior_data)
5012         (_initialize_nto_tdep): Remove.
5013         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5014
5015 2019-05-08  Tom Tromey  <tom@tromey.com>
5016
5017         * ada-lang.c (struct ada_inferior_data): Add initializers.
5018         (ada_inferior_data): Change type.
5019         (ada_inferior_data_cleanup): Remove.
5020         (get_ada_inferior_data, ada_inferior_exit)
5021         (struct ada_pspace_data): Add initializers, destructor.
5022         (ada_pspace_data_handle): Change type.
5023         (get_ada_pspace_data): Update.
5024         (ada_pspace_data_cleanup): Remove.
5025
5026 2019-05-08  Tom Tromey  <tom@tromey.com>
5027
5028         * coffread.c (struct coff_symfile_info): Add initializers.
5029         (coff_objfile_data_key): Move lower.  Change type.
5030         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5031         Update.
5032         (coff_free_info): Remove.
5033
5034 2019-05-08  Tom Tromey  <tom@tromey.com>
5035
5036         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5037         (fbsd_pspace_data_handle): Move lower.  Change type.
5038         (get_fbsd_pspace_data): Update.
5039         (fbsd_pspace_data_cleanup): Remove.
5040         (_initialize_fbsd_tdep): Update.
5041
5042 2019-05-08  Tom Tromey  <tom@tromey.com>
5043
5044         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5045         (get_ada_tasks_pspace_data): Update.
5046         (ada_tasks_pspace_data_cleanup): Remove.
5047         (_initialize_tasks): Update.
5048         (ada_tasks_inferior_data_handle): Change type.
5049         (get_ada_tasks_inferior_data): Update.
5050         (ada_tasks_inferior_data_cleanup): Remove.
5051         (struct ada_tasks_pspace_data): Add initializers.
5052
5053 2019-05-08  Tom Tromey  <tom@tromey.com>
5054
5055         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5056         * symfile-debug.c (debug_sym_get_probes): Change type.
5057         * stap-probe.c (handle_stap_probe):
5058         (stap_static_probe_ops::get_probes): Change type.
5059         * probe.h (class static_probe_ops) <get_probes>: Change type.
5060         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5061         (parse_probes_in_pspace): Update.
5062         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5063         Update.
5064         (any_static_probe_ops::get_probes): Change type.
5065         * elfread.c (elfread_data): New typedef.
5066         (probe_key): Change type.
5067         (elf_get_probes): Likewise.  Update.
5068         (probe_key_free): Remove.
5069         (_initialize_elfread): Update.
5070         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5071         Change type.
5072         (dtrace_process_dof_probe, dtrace_process_dof)
5073         (dtrace_static_probe_ops::get_probe): Change type.
5074
5075 2019-05-08  Tom Tromey  <tom@tromey.com>
5076
5077         * xcoffread.c (struct xcoff_symfile_info): Rename from
5078         coff_symfile_info.  Add initializers.
5079         (xcoff_objfile_data_key): Move lower.  Change type.
5080         (XCOFF_DATA): Rewrite.
5081         (xcoff_free_info): Remove.
5082         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5083         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5084         (xcoff_initial_scan): Update.
5085
5086 2019-05-08  Tom Tromey  <tom@tromey.com>
5087
5088         * solib-svr4.c (struct svr4_info): Add initializers and
5089         destructor.
5090         <probes_table>: Now an htab_up.
5091         (solib_svr4_pspace_data): Change type.
5092         (free_probes_table): Simplify.
5093         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5094         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5095         (probes_table_remove_objfile_probes, register_solib_event_probe)
5096         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5097         (_initialize_svr4_solib): Update.
5098
5099 2019-05-08  Tom Tromey  <tom@tromey.com>
5100
5101         * remote.c (remote_pspace_data): Change type.
5102         (remote_pspace_data_cleanup): Remove.
5103         (get_remote_exec_file, set_pspace_remote_exec_file)
5104         (_initialize_remote): Update.
5105
5106 2019-05-08  Tom Tromey  <tom@tromey.com>
5107
5108         * breakpoint.c (breakpoint_objfile_key): Change type.
5109         (get_breakpoint_objfile_data): Update.
5110         (free_breakpoint_objfile_data): Remove.
5111         (_initialize_breakpoint): Update.
5112
5113 2019-05-08  Tom Tromey  <tom@tromey.com>
5114
5115         * linux-tdep.c (struct linux_info): Add initializers.
5116         (linux_inferior_data): Move.  Change type.
5117         (invalidate_linux_cache_inf): Update.
5118         (linux_inferior_data_cleanup): Remove.
5119         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5120
5121 2019-05-08  Tom Tromey  <tom@tromey.com>
5122
5123         * auxv.c (auxv_inferior_data): Move.  Change type.
5124         (auxv_inferior_data_cleanup): Remove.
5125         (invalidate_auxv_cache_inf): Rewrite.
5126         (get_auxv_inferior_data, _initialize_auxv): Update.
5127
5128 2019-05-08  Tom Tromey  <tom@tromey.com>
5129
5130         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5131         (symfile_debug_objfile_data_key): Change type.
5132         (symfile_debug_installed, debug_qf_has_symbols)
5133         (debug_qf_find_last_source_symtab)
5134         (debug_qf_forget_cached_source_info)
5135         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5136         (debug_qf_print_stats, debug_qf_dump)
5137         (debug_qf_expand_symtabs_for_function)
5138         (debug_qf_expand_all_symtabs)
5139         (debug_qf_expand_symtabs_with_fullname)
5140         (debug_qf_map_matching_symbols)
5141         (debug_qf_expand_symtabs_matching)
5142         (debug_qf_find_pc_sect_compunit_symtab)
5143         (debug_qf_map_symbol_filenames)
5144         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5145         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5146         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5147         (debug_sym_read_linetable, debug_sym_relocate): Update.
5148         (symfile_debug_free_objfile): Remove.
5149         (install_symfile_debug_logging, _initialize_symfile_debug):
5150         Update.
5151
5152 2019-05-08  Tom Tromey  <tom@tromey.com>
5153
5154         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5155         allocate_on_obstack.
5156         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5157         (get_dwarf2_per_objfile): Update.
5158         (set_dwarf2_per_objfile): Remove.
5159         (dwarf2_has_info, dwarf2_get_section_info): Update.
5160         (dwarf2_free_objfile): Remove.
5161         (_initialize_dwarf2_read): Update.
5162
5163 2019-05-08  Tom Tromey  <tom@tromey.com>
5164
5165         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5166         initializers.
5167         <unsupported_script_warning_printed,
5168         script_not_found_warning_printed>: Now bool.
5169         (auto_load_pspace_data): Change type.
5170         (~auto_load_pspace_info): Rename from
5171         auto_load_pspace_data_cleanup.
5172         (get_auto_load_pspace_data, init_loaded_scripts_info)
5173         (clear_section_scripts, maybe_print_unsupported_script_warning)
5174         (maybe_print_script_not_found_warning, _initialize_auto_load):
5175         Update.
5176
5177 2019-05-08  Tom Tromey  <tom@tromey.com>
5178
5179         * objfiles.c (objfile_pspace_info): Add destructor and
5180         initializers.
5181         (objfiles_pspace_data): Change type.
5182         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5183         (get_objfile_pspace_data): Update.
5184         (objfiles_bfd_data): Change type.
5185         (get_objfile_bfd_data): Update.
5186         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5187
5188 2019-05-08  Tom Tromey  <tom@tromey.com>
5189
5190         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5191         Change type.
5192         (get_catch_syscall_inferior_data): Update.
5193         (catch_syscall_inferior_data_cleanup): Remove.
5194         (_initialize_break_catch_syscall): Update.
5195
5196 2019-05-08  Tom Tromey  <tom@tromey.com>
5197
5198         * inflow.c (struct terminal_info): Add destructor and
5199         initializers.
5200         (inflow_inferior_data): Change type.
5201         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5202         (get_inflow_inferior_data, inflow_inferior_exit)
5203         (swap_terminal_info, _initialize_inflow): Update.
5204
5205 2019-05-08  Tom Tromey  <tom@tromey.com>
5206
5207         * target-dcache.c (target_dcache_cleanup): Remove.
5208         (target_dcache_aspace_key): Change type.
5209         (target_dcache_init_p, target_dcache_invalidate)
5210         (target_dcache_get, target_dcache_get_or_init)
5211         (_initialize_target_dcache): Update.
5212         * dcache.h (struct dcache_deleter): New.
5213
5214 2019-05-08  Tom Tromey  <tom@tromey.com>
5215
5216         * symtab.c (struct symbol_cache): Add destructor and
5217         initializers.
5218         (symbol_cache_key): Move.  Change type.
5219         (make_symbol_cache, free_symbol_cache): Remove.
5220         (get_symbol_cache): Update.
5221         (symbol_cache_cleanup): Remove.
5222         (ALL_PSPACES, symbol_cache_flush)
5223         (maintenance_print_symbol_cache)
5224         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5225         Update.
5226
5227 2019-05-08  Tom Tromey  <tom@tromey.com>
5228
5229         * symtab.c (struct main_info): Add destructor and initializers.
5230         (main_progspace_key): Move.  Change type.
5231         (get_main_info): Update.
5232         (main_info_cleanup): Remove.
5233         (_initialize_symtab): Update.
5234
5235 2019-05-08  Tom Tromey  <tom@tromey.com>
5236
5237         * registry.h (DECLARE_REGISTRY): Define the _key class.
5238
5239 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * NEWS: Merge two 'New commands' sections.
5242
5243 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5244
5245         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5246         parameter and use Ada language definition instead.
5247         (ada_val_print_ptr): Remove unused language parameter.
5248         (ada_val_print_num): Remove language parameter and use Ada language
5249         definition instead.
5250         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5251         parameter.
5252         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5253         parameter and use Ada language definition instead.
5254         (ada_val_print_1): Update all ada_val_print_xxx calls.
5255         Remove language parameter.
5256         (ada_val_print): Update ada_val_print_1 call.
5257
5258 2019-05-08  Tom Tromey  <tromey@adacore.com>
5259
5260         * remote.c (remote_hw_watchpoint_limit)
5261         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5262         Now static.
5263
5264 2019-05-08  Tom Tromey  <tromey@adacore.com>
5265
5266         * maint.c (_initialize_maint_cmds): Move initialization code to
5267         remote.c.
5268         (watchdog, show_watchdog): Move to remote.c.
5269         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5270         "watchdog" static.
5271         (_initialize_remote): Move initialization code from maint.c.
5272         * defs.h (watchdog): Don't declare.
5273
5274 2019-05-08  Tom Tromey  <tromey@adacore.com>
5275
5276         * tui/tui-interp.c: Include main.h.
5277         * interps.c: Include main.h.
5278         * main.h (interpreter_p): Declare.
5279         * defs.h (interpreter_p): Don't declare.
5280
5281 2019-05-08  Tom Tromey  <tromey@adacore.com>
5282
5283         * dwarf2loc.c: Include dwarf2read.h.
5284         * defs.h (read_unsigned_leb128): Don't declare.
5285         * dwarf2read.h (read_unsigned_leb128): Declare.
5286
5287 2019-05-08  Tom Tromey  <tromey@adacore.com>
5288
5289         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5290         method.
5291
5292 2019-05-08  Tom Tromey  <tromey@adacore.com>
5293
5294         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5295         when no wrap column is set.
5296
5297 2019-05-08  Tom Tromey  <tromey@adacore.com>
5298
5299         * c-lang.c (c_get_string): Handle non-C-style arrays.
5300
5301 2019-05-08  Tom Tromey  <tromey@adacore.com>
5302
5303         * typeprint.c (print_offset_data::update): Print the bit offset,
5304         not the number of bits remaining.
5305
5306 2019-05-08  Tom Tromey  <tromey@adacore.com>
5307
5308         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5309         padding at end of comment.
5310
5311 2019-05-08  Tom Tromey  <tromey@adacore.com>
5312
5313         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5314         Compare main types.
5315
5316 2019-05-06  Tom Tromey  <tom@tromey.com>
5317
5318         * common/scoped_mmap.c: Include common-defs.h.
5319         * common/scoped_mmap.h: Don't include config.h.
5320
5321 2019-05-04  Tom Tromey  <tom@tromey.com>
5322
5323         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5324         (struct aarch64_call_info): Add initializers.
5325         <si>: Now a std::vector.
5326         (pass_on_stack, aarch64_push_dummy_call): Update.
5327
5328 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5329             Tom Tromey  <tom@tromey.com>
5330
5331         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5332         (ppc_threads): Now a std::vector.  Now static.
5333         (hwdebug_find_thread_points_by_tid)
5334         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5335         Update.
5336
5337 2019-05-04  Tom Tromey  <tom@tromey.com>
5338
5339         * arc-tdep.c (arc_tdesc_init): Return bool.
5340
5341 2019-05-04  Tom Tromey  <tom@tromey.com>
5342
5343         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5344         Use gdb_assert_not_reached.
5345
5346 2019-05-04  Tom Tromey  <tom@tromey.com>
5347
5348         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5349         "false".
5350
5351 2019-05-04  Tom Tromey  <tom@tromey.com>
5352
5353         * arc-tdep.c (arc_tdesc_init): Use bool.
5354
5355 2019-05-04  Tom Tromey  <tom@tromey.com>
5356
5357         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5358
5359 2019-05-04  Tom Tromey  <tom@tromey.com>
5360
5361         * cli/cli-cmds.c (valid_command_p): Return bool.
5362
5363 2019-05-04  Tom Tromey  <tom@tromey.com>
5364
5365         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5366         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5367
5368 2019-05-04  Raul Tambre  <raul@tambre.ee>
5369
5370         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5371         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5372         operator for comparison.
5373
5374 2019-05-04  Tom Tromey  <tom@tromey.com>
5375
5376         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5377         (lookup_partial_symbol, print_partial_symbols)
5378         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5379         (psymbol_compare): Update.
5380         (add_psymbol_to_bcache): Clear the entire psymbol.
5381         (maintenance_check_psymtabs): Update.
5382         * psympriv.h (struct partial_symbol): Don't derive from
5383         general_symbol_info.
5384         <obj_section, unrelocated_address, address,
5385         set_unrelocated_address>: Update.
5386         <ginfo>: New member.
5387         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5388         (debug_names::write_psymbols): Update.
5389
5390 2019-05-04  Tom de Vries  <tdevries@suse.de>
5391
5392         * contrib/cc-with-tweaks.sh: Support -n arg.
5393
5394 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5395
5396         * corelow.c (core_target::detach): Ensure frame cache and
5397         register caches are cleared.
5398         inferior.c (exit_inferior_1): Likewise.
5399
5400 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5401             Tom Tromey  <tom@tromey.com>
5402
5403         * dictionary.c (collate_pending_symbols_by_language): Remove
5404         "struct" from foreach.
5405         * symtab.c (lookup_global_symbol_from_objfile)
5406         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5407         foreach.
5408         * ser-tcp.c (net_open): Remove "struct" from foreach.
5409         * objfiles.c (objfile_relocate, objfile_rebase)
5410         (objfile_has_symbols): Remove "struct" from foreach.
5411         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5412         from foreach.
5413         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5414         foreach.
5415         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5416         "struct" from foreach.
5417         * ada-lang.c (create_excep_cond_exprs)
5418         (ada_exception_catchpoint_cond_string): Remove "struct" from
5419         foreach.
5420
5421 2019-05-03  Tom Tromey  <tromey@adacore.com>
5422
5423         * ada-exp.y (convert_char_literal): Check suffix of each
5424         enumerator.
5425
5426 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5427
5428         PR ada/21406:
5429         * ada-exp.y (yywrap): Don't define.
5430         * ada-lex.l (%option): Add noyywrap
5431         (yywrap): Remove.
5432
5433 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5434
5435         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5436         _WIN32_WINNT to the XP level, unless already defined to a higher
5437         level.
5438
5439         * unittests/parse-connection-spec-selftests.c:
5440         * ser-tcp.c:
5441         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5442         override.
5443
5444         * symfile.c (find_separate_debug_file): Remove colon from the
5445         drive spec of DOS/Windows file names of the target, so that the
5446         file name produced from DEBUGDIR and the target's directory will
5447         be valid on DOS/Windows systems.
5448
5449 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5450
5451         * rust-lang.c (val_print_struct): Handle printing structures
5452         containing strings.
5453
5454 2019-05-02  Tom Tromey  <tromey@adacore.com>
5455
5456         * valarith.c (_initialize_valarith): Remove.
5457
5458 2019-05-01  Tom Tromey  <tromey@adacore.com>
5459
5460         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5461         bitfields.
5462
5463 2019-05-01  Tom Tromey  <tromey@adacore.com>
5464
5465         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5466         for big-endian copies.
5467
5468 2019-04-30  Ali Tamur  <tamur@google.com>
5469         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5470         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5471         (read_3_bytes): New function.
5472
5473 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5474
5475         * windows-nat.c (main_thread_id): Delete.
5476         (handle_output_debug_string): Replace main_thread_id by
5477         current_event.dwThreadId.
5478         (fake_create_process): Likewise.
5479         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5480         Do not set main_thread_id.
5481         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5482         current_event.dwThreadId.
5483         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5484
5485 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5486
5487         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5488         Use current_event.dwThreadId instead of main_thread_id.
5489
5490 2019-04-30  Tom Tromey  <tromey@adacore.com>
5491
5492         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5493         (create_excep_cond_exprs): Iterate over program spaces.
5494         (ada_exception_catchpoint_cond_string): Examine all minimal
5495         symbols for exception types.
5496
5497 2019-04-30  Tom Tromey  <tromey@adacore.com>
5498
5499         PR c++/24470:
5500         * dwarf2read.c (process_structure_scope): Handle case where type
5501         has template parameters but no symbol was created.
5502
5503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5504             Chris January  <chris.january@arm.com>
5505
5506         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5507         qualifier.
5508         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5509
5510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * f-typeprint.c (f_print_type): Update rules for printing
5513         whitespace.
5514         (f_type_print_varspec_suffix): Likewise.
5515
5516 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5517             Chris January  <chris.january@arm.com>
5518
5519         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5520         function arguments.
5521
5522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5523
5524         * f-lang.c (build_fortran_types): Change name of void type to
5525         lower case.
5526         * f-typeprint.c (f_type_print_base): Print the name of the void
5527         type, rather than a fixed string.
5528         * f-valprint.c (f_decorations): Use lower case void string.
5529
5530 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5531             Chris January  <chris.january@arm.com>
5532
5533         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5534         types for Fortran.
5535
5536 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5537             Chris January  <chris.january@arm.com>
5538             David Lecomber  <david.lecomber@arm.com>
5539
5540         * f-exp.y (BINOP_INTRINSIC): New token.
5541         (exp): New parser rule handling BINOP_INTRINSIC.
5542         (f77_keywords): Add new builtin procedures.
5543         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5544         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5545         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5546         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5547         (print_unop_subexp_f): New function.
5548         (print_binop_subexp_f): New function.
5549         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5550         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5551         (dump_subexp_body_f): Likewise.
5552         (operator_check_f): Likewise.
5553         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5554         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5555
5556 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5559         UNOP_KIND.
5560         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5561         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5562         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5563         (operator_length_f): New fuction.
5564         (print_subexp_f): New function.
5565         (op_name_f): New function.
5566         (dump_subexp_body_f): New function.
5567         (operator_check_f): New function.
5568         (exp_descriptor_f): Replace standard expression handling functions
5569         with new functions.
5570         * gdb/fortran-operator.def: New file.
5571         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5572         * gdb/std-operator.def: Remove UNOP_KIND.
5573
5574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5575
5576         * std-operator.def: Remove unbalanced, stray double quote
5577         character.
5578
5579 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5580             Chris January  <chris.january@arm.com>
5581             Daniel Everett  <daniel.everett@arm.com>
5582             Nick Forrington  <nick.forrington@arm.com>
5583             Richard Bunt  <richard.bunt@arm.com>
5584
5585         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5586         of depth when printing anonymous structs or unions.
5587         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5588         Don't print either the top-level value, or the children if the
5589         max-depth is exceeded.
5590         (ppscm_print_children): When printing the key of a map, allow one
5591         extra level of depth.
5592         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5593         print either the top-level value, or the children if the max-depth
5594         is exceeded.
5595         (print_children): When printing the key of a map, allow one extra
5596         level of depth.
5597         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5598         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5599         (user_print_options): Initialise max_depth field.
5600         (val_print_scalar_or_string_type_p): New function.
5601         (val_print): Check to see if the max depth has been reached.
5602         (val_print_check_max_depth): Define new function.
5603         (show_print_max_depth): New function.
5604         (_initialize_valprint): Add 'print max-depth' option.
5605         * valprint.h (struct value_print_options) <max_depth>: New field.
5606         (val_print_check_max_depth): Declare new function.
5607         * NEWS: Document new feature.
5608
5609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * ada-lang.c (ada_language_defn): Initialise new field.
5612         * c-lang.c (c_is_string_type_p): New function.
5613         (c_language_defn): Initialise new field.
5614         (cplus_language_defn): Initialise new field.
5615         (asm_language_defn): Initialise new field.
5616         (minimal_language_defn): Initialise new field.
5617         * c-lang.h (c_is_string_type_p): Declare new function.
5618         * d-lang.c (d_language_defn): Initialise new field.
5619         * f-lang.c (f_is_string_type_p): New function.
5620         (f_language_defn): Initialise new field.
5621         * go-lang.c (go_is_string_type_p): New function.
5622         (go_language_defn): Initialise new field.
5623         * language.c (default_is_string_type_p): New function.
5624         (unknown_language_defn): Initialise new field.
5625         (auto_language_defn): Initialise new field.
5626         * language.h (struct language_defn) <la_is_string_type_p>: New
5627         member variable.
5628         (default_is_string_type_p): Declare new function.
5629         * m2-lang.c (m2_language_defn): Initialise new field.
5630         * objc-lang.c (objc_language_defn): Initialise new field.
5631         * opencl-lang.c (opencl_language_defn): Initialise new field.
5632         * p-lang.c (pascal_is_string_type_p): New function.
5633         (pascal_language_defn): Initialise new field.
5634         * rust-lang.c (rust_is_string_type_p): New function.
5635         (rust_language_defn): Initialise new field.
5636
5637 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5638
5639         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5640         New field.
5641         * ada-lang.c (ada_language_defn): Initialise new field.
5642         * c-lang.c (c_language_defn): Likewise.
5643         (cplus_language_defn): Likewise.
5644         (asm_language_defn): Likewise.
5645         (minimal_language_defn): Likewise.
5646         * d-lang.c (d_language_defn): Likewise.
5647         * f-lang.c (f_language_defn): Likewise.
5648         * go-lang.c (go_language_defn): Likewise.
5649         * language.c (unknown_language_defn): Likewise.
5650         (auto_language_defn): Likewise.
5651         * m2-lang.c (m2_language_defn): Likewise.
5652         * objc-lang.c (objc_language_defn): Likewise.
5653         * opencl-lang.c (opencl_language_defn): Likewise.
5654         * p-lang.c (pascal_language_defn): Likewise.
5655         * rust-lang.c (rust_language_defn): Likewise.
5656
5657 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5658
5659         * ada-lang.c (ada_is_character_type): Change return type to bool.
5660         (ada_is_string_type): Likewise.
5661         * ada-lang.h (ada_is_character_type): Update declaration
5662         (ada_is_string_type): Likewise.
5663
5664 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5665
5666         Support style in 'frame|thread apply'
5667
5668         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5669         * record.c (record_start, record_stop): Update callers of
5670         execute_command_to_string with false.
5671         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5672         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5673         methods.
5674         (class string_file): New constructor with term_out parameter.
5675         Override methods term_out and can_emit_style_escape.  New member
5676         term_out.
5677         (class stdio_file): Override can_emit_style_escape.
5678         (class tee_file): Override term_out and can_emit_style_escape.
5679         * utils.h (can_emit_style_escape): Remove.
5680         * utils.c (can_emit_style_escape): Likewise.
5681         Update all callers of can_emit_style_escape (SOMESTREAM) to
5682         SOMESTREAM->can_emit_style_escape.
5683         * source-cache.c (source_cache::get_source_lines): Likewise.
5684         * stack.c (frame_apply_command_count): Call execute_command_to_string
5685         passing the term_out characteristic of the current gdb_stdout.
5686         * thread.c (thr_try_catch_cmd): Likewise.
5687         * top.c (execute_command_to_string): pass term_out parameter
5688         to construct the string_file for the command output.
5689         * ui-file.c (term_cli_styling): New function (most code moved
5690         from utils.c can_emit_style_escape).
5691         (string_file::string_file, string_file::can_emit_style_escape,
5692         stdio_file::can_emit_style_escape, tee_file::term_out,
5693         tee_file::can_emit_style_escape): New functions.
5694
5695 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5696
5697         * NEWS: Mention the new set|show may-call-functions.
5698         * infcall.c (may_call_functions_p): New variable.
5699         (show_may_call_functions_p): New function.
5700         (call_function_by_hand_dummy): Throws an error if not
5701         may-call-functions.
5702         (_initialize_infcall): Call add_setshow_boolean_cmd for
5703         may-call-functions.
5704
5705 2019-04-25  Keith Seitz  <keiths@redhat.com>
5706
5707         PR c++/24367
5708         * cp-support.c (inspect_type): Don't attempt substitutions
5709         of symbol with the same name.
5710
5711 2019-04-25  Tom Tromey  <tromey@adacore.com>
5712
5713         PR gdb/24475:
5714         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5715         static.
5716
5717 2019-04-25  Tom Tromey  <tromey@adacore.com>
5718
5719         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5720         rvalue reference.
5721         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5722         (gdb_xml_parser::parse): Use std::move.
5723         * python/python-internal.h (gdbpy_convert_exception): Take a const
5724         reference.
5725         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5726         std::move.
5727         * python/py-utils.c (gdbpy_convert_exception): Take a const
5728         reference.
5729         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5730         Use std::move.
5731         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5732         Use std::move.
5733         * mi/mi-main.c (mi_print_exception): Take a const reference.
5734         * main.c (handle_command_errors): Take a const reference.
5735         * linespec.c (parse_linespec): Use std::move.
5736         * infcall.c (run_inferior_call): Use std::move.
5737         (call_function_by_hand_dummy): Use std::move.
5738         * exec.c (try_open_exec_file): Use std::move.
5739         * exceptions.h (exception_print, exception_fprintf)
5740         (exception_print_same): Update.
5741         * exceptions.c (print_exception, exception_print)
5742         (exception_fprintf, exception_print_same): Change parameters to
5743         const reference.
5744         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5745         * common/new-op.c: Use std::move.
5746         * common/common-exceptions.h (struct gdb_exception): Add move
5747         constructor.
5748         (struct gdb_exception_error, struct gdb_exception_quit, struct
5749         gdb_quit_bad_alloc): Change constructor to move constructor.
5750         (throw_exception): Change parameter to rvalue reference.
5751         * common/common-exceptions.c (throw_exception): Take rvalue
5752         reference.
5753         * cli/cli-interp.c (safe_execute_command): Use std::move.
5754         * breakpoint.c (insert_bp_location, location_to_sals): Use
5755         std::move.
5756
5757 2019-04-25  Tom Tromey  <tromey@adacore.com>
5758
5759         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5760         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5761         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5762         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5763         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5764         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5765         guile/scm-value.c: Use unpack.
5766         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5767         gdbscm_gdb_exception.
5768         (gdbscm_throw_gdb_exception): Likewise.
5769         (struct gdbscm_gdb_exception): New.
5770         (unpack): New function.
5771         (gdbscm_wrap): Use unpack.
5772
5773 2019-04-25  Tom Tromey  <tromey@adacore.com>
5774
5775         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5776         (gdb_rl_callback_handler): Use std::move.
5777         * common/common-exceptions.h (struct gdb_exception): Add move
5778         assignment operator.
5779         (throw_exception_sjlj): Change "exception" to const reference.
5780         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5781         (throw_exception_sjlj): Change "exception" to const reference.
5782
5783 2019-04-25  Tom Tromey  <tromey@adacore.com>
5784
5785         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5786         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5787         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5788         Update.
5789         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5790         Update.
5791         * mi/mi-interp.c (mi_interp::exec): Update.
5792         * linespec.c (parse_linespec): Update.
5793         * infcall.c (run_inferior_call): Update.
5794         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5795         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5796         (gdbscm_lookup_global_symbol): Update.
5797         * guile/scm-param.c (gdbscm_parameter_value): Update.
5798         * guile/scm-frame.c (gdbscm_frame_read_register)
5799         (gdbscm_frame_read_var): Update.
5800         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5801         * exec.c (try_open_exec_file): Update.
5802         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5803         (gdb_rl_callback_handler): Update.
5804         * common/common-exceptions.h (exception_none): Don't declare.
5805         * common/common-exceptions.c (exception_none): Don't define.
5806         (struct catcher) <exception>: Update.
5807         * cli/cli-interp.c (safe_execute_command): Update.
5808         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5809
5810 2019-04-25  Ali Tamur  <tamur@google.com>
5811
5812         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5813         (read_attribute_value): Likewise.
5814         (dwarf2_read_addr_index): Update comment.
5815         (read_str_index): Add DW_FORM_strx.
5816         (dwarf2_string_attr): Likewise.
5817         (dwarf2_const_value_attr): Likewise.
5818         (dump_die_shallow): Likewise.
5819         (dwarf2_fetch_constant_bytes): Likewise.
5820         (skip_form_bytes): Likewise.
5821         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5822
5823 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5824
5825         PR corefiles/11608
5826         PR corefiles/18187
5827         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5828         OFFSET.  Verify if current mapping contains an ELF header.
5829         (linux_find_memory_regions_full): Adjust call to
5830         dump_mapping_p.
5831
5832 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5833             Kang Li <kanglictf@gmail.com>
5834
5835         PR gdb/21600
5836
5837         * dwarf2-frame.c (read_initial_length): Be consistent about using
5838         unsigned representation of length.
5839         (decode_frame_entry_1): Likewise.  Check for wraparound of
5840         end pointer as well as buffer overflow.
5841
5842 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5843
5844         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5845         "vq".
5846
5847 2019-04-24  Tom Tromey  <tromey@adacore.com>
5848
5849         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5850
5851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * s12z-tdep.c (s12z_unwind_pc): Delete.
5854         (s12z_unwind_sp): Delete.
5855         (s12z_gdbarch_init): Don't register deleted functions with
5856         gdbarch.
5857
5858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * rl78-tdep.c (rl78_unwind_sp): Delete.
5861         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5862
5863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5866         (xstormy16_unwind_pc): Delete.
5867         (xstormy16_dummy_id): Delete.
5868         (xstormy16_gdbarch_init): Don't register deleted functions with
5869         gdbarch.
5870
5871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5872
5873         * vax-tdep.c (vax_unwind_pc): Delete.
5874         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5875
5876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * v850-tdep.c (v850_unwind_sp): Delete.
5879         (v850_unwind_pc): Delete.
5880         (v850_dummy_id): Delete.
5881         (v850_gdbarch_init): Don't register deleted functions with
5882         gdbarch.
5883
5884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5887         (tilegx_unwind_pc): Delete.
5888         (tilegx_unwind_dummy_id): Delete.
5889         (tilegx_gdbarch_init): Don't register deleted functions with
5890         gdbarch.
5891
5892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5895         (tic6x_dummy_id): Delete.
5896         (tic6x_gdbarch_init): Don't register deleted functions with
5897         gdbarch.
5898
5899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5900
5901         * sparc-tdep.c (sparc_unwind_pc): Delete.
5902         (sparc32_gdbarch_init): Don't register deleted function with
5903         gdbarch.
5904
5905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * sh-tdep.c (sh_unwind_sp): Delete.
5908         (sh_unwind_pc): Delete.
5909         (sh_dummy_id): Delete.
5910         (sh_gdbarch_init): Don't register deleted functions with
5911         gdbarch.
5912
5913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * score-tdep.c (score_unwind_sp): Delete.
5916         (score_unwind_pc): Delete.
5917         (score_dummy_id): Delete.
5918         (score_gdbarch_init): Don't register deleted functions with
5919         gdbarch.
5920
5921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * rx-tdep.c (rx_unwind_pc): Delete.
5924         (rx_unwind_sp): Delete.
5925         (rx_dummy_id): Delete.
5926         (rx_gdbarch_init): Don't register deleted functions with
5927         gdbarch.  Update comment.
5928
5929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5932         (rs6000_dummy_id): Delete.
5933         (rs6000_gdbarch_init): Don't register deleted functions with
5934         gdbarch.
5935
5936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5937
5938         * or1k-tdep.c (or1k_dummy_id): Delete.
5939         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5940
5941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5942
5943         * nios2-tdep.c (nios2_dummy_id): Delete.
5944         (nios2_unwind_sp): Delete.
5945         (nios2_gdbarch_init): Don't register deleted functions with
5946         gdbarch.
5947
5948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * nds32-tdep.c (nds32_dummy_id): Delete.
5951         (nds32_unwind_pc): Delete.
5952         (nds32_unwind_sp): Delete.
5953         (nds32_gdbarch_init): Don't register deleted functions with
5954         gdbarch.
5955
5956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * msp430-tdep.c (msp430_unwind_pc): Delete.
5959         (msp430_unwind_sp): Delete.
5960         (msp430_dummy_id): Delete.
5961         (msp430_gdbarch_init): Don't register deleted functions with
5962         gdbarch.
5963
5964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * moxie-tdep.c (moxie_unwind_sp): Delete.
5967         (moxie_unwind_pc): Delete.
5968         (moxie_dummy_id): Delete.
5969         (moxie_gdbarch_init): Don't register deleted functions with
5970         gdbarch.
5971
5972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5975         (mn10300_unwind_pc): Delete.
5976         (mn10300_unwind_sp): Delete.
5977         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5978         mn10300_unwind_sp.
5979         (mn10300_frame_unwind_init): Don't register deleted functions with
5980         gdbarch.
5981
5982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * mep-tdep.c (mep_unwind_pc): Delete.
5985         (mep_unwind_sp): Delete.
5986         (mep_dummy_id): Delete.
5987         (mep_gdbarch_init): Don't register deleted functions with
5988         gdbarch.
5989
5990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5993         (m68hc11_unwind_sp): Delete.
5994         (m68hc11_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * m32r-tdep.c (m32r_unwind_sp): Delete.
6000         (m32r_unwind_pc): Delete.
6001         (m32r_dummy_id): Delete.
6002         (m32r_gdbarch_init): Don't register deleted functions with
6003         gdbarch.
6004
6005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * m32c-tdep.c (m32c_unwind_pc): Delete.
6008         (m32c_unwind_sp): Delete.
6009         (m32c_dummy_id): Delete.
6010         (m32c_gdbarch_init): Don't register deleted functions with
6011         gdbarch.
6012
6013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6016         (lm32_unwind_pc): Delete.
6017         (lm32_dummy_id): Delete.
6018         (lm32_gdbarch_init): Don't register deleted functions with
6019         gdbarch.
6020
6021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6024         (iq2000_unwind_pc): Delete.
6025         (iq2000_dummy_id): Delete.
6026         (iq2000_gdbarch_init): Don't register deleted functions with
6027         gdbarch.
6028
6029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6030
6031         * nds32-tdep.c (nds32_type_align): Delete.
6032         (nds32_push_dummy_call): Use type_align instead.
6033
6034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * arm-tdep.c (arm_type_align): Only handle vector override case.
6037         (arm_push_dummy_call): Use type_align.
6038         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6039
6040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6043         case.
6044         (pass_on_stack): Use type_align.
6045         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6046         function.
6047
6048 2019-04-23  Tom Tromey  <tromey@adacore.com>
6049
6050         * dwarf2read.c (line_header::file_name_at): Remove unused
6051         overload.
6052
6053 2019-04-23  Tom de Vries  <tdevries@suse.de>
6054
6055         PR gdb/24438
6056         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6057         invocation.
6058
6059
6060 2019-03-27  Ali Tamur  <tamur@google.com>
6061
6062         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6063         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6064         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6065         (dwarf_expr_context::get_addr_index): Likewise
6066         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6067         (symbol_needs_eval_context::get_addr_index): Likewise
6068         (disassemble_dwarf_expression): Add DW_OP_addrx
6069         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6070         (read_cutu_die_from_dwo): Update comment
6071         (skip_one_die): Add DW_FORM_addrx
6072         (read_attribute_value): Likewise
6073         (var_decode_location): Add DW_OP_addrx
6074         (dwarf2_const_value_attr): Add DW_FORM_addrx
6075         (dump_die_shallow): Likewise
6076         (dwarf2_fetch_constant_bytes): Likewise
6077         (decode_locdesc): Add DW_OP_addrx
6078         (skip_form_bytes): Add DW_FORM_addrx
6079
6080 2019-04-22  Ali Tamur  <tamur@google.com>
6081
6082         * MAINTAINERS (Write After Approval): Add self.
6083
6084 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6085
6086         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6087         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6088         (open_symbol_file_object): Likewise.
6089         (svr4_default_sos): Add info parameter.
6090         (svr4_read_so_list): Likewise.
6091         (svr4_current_sos_direct): Adjust functions calls to pass down
6092         info.
6093         (svr4_current_sos_1): Add info parameter.
6094         (svr4_current_sos): Call get_svr4_info, pass info down to
6095         svr4_current_sos_1.
6096         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6097         get_svr4_info.
6098         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6099         get_svr4_info.
6100         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6101         to get_svr4_info.
6102         (probes_table_remove_objfile_probes): Likewise.
6103         (register_solib_event_probe): Add info parameter.
6104         (solist_update_incremental): Pass info parameter down to
6105         svr4_read_so_list.
6106         (disable_probes_interface): Add info parameter.
6107         (svr4_handle_solib_event): Pass current_program_space to
6108         get_svr4_info.  Adjust disable_probes_interface cleanup.
6109         (svr4_create_probe_breakpoints): Add info parameter, pass it
6110         down to register_solib_event_probe.
6111         (svr4_create_solib_event_breakpoints): Add info parameter,
6112         pass it down to svr4_create_probe_breakpoints.
6113         (enable_break): Pass info down to
6114         svr4_create_solib_event_breakpoints.
6115         (svr4_solib_create_inferior_hook): Pass current_program_space to
6116         get_svr4_info.
6117         (svr4_clear_solib): Likewise.
6118
6119 2019-04-22  Pedro Alves  <palves@redhat.com>
6120
6121         * solib-svr4.c (svr4_free_objfile_observer): New.
6122         (probe_and_action::objfile): New field.
6123         (probes_table_htab_remove_objfile_probes)
6124         (probes_table_remove_objfile_probes): New functions.
6125         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6126         in the new probe_and_action.  Don't store the probe in 'lookup'.
6127         (svr4_create_probe_breakpoints): Pass objfile to
6128         register_solib_event_probe.
6129         (_initialize_svr4_solib): Register a free_objfile observer.
6130
6131 2019-04-19  Tom Tromey  <tom@tromey.com>
6132
6133         * common/queue.h: Remove.
6134
6135 2019-04-19  Tom Tromey  <tom@tromey.com>
6136
6137         * event-loop.c: Don't include "common/queue.h".
6138
6139 2019-04-19  Tom Tromey  <tom@tromey.com>
6140
6141         * remote.c (remote_target): Use delete.
6142         * remote-notif.h: Include <list>, not "common/queue.h".
6143         (notif_client_p): Remove typedef.
6144         (remote_notif_state): Add constructor, destructor, initializer.
6145         <notif_queue>: Now a std::list.
6146         (remote_notif_state_xfree): Don't declare.
6147         * remote-notif.c (remote_notif_process, handle_notification)
6148         (remote_notif_state_allocate): Update.
6149         (~remote_notif_state): Rename from remote_notif_state_xfree.
6150
6151 2019-04-19  Tom Tromey  <tom@tromey.com>
6152
6153         * symfile.c (reread_symbols): Update.
6154         * objfiles.c (objfile_register_static_link)
6155         (objfile_lookup_static_link): Update
6156         (~objfile) Don't delete static_links.
6157         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6158
6159 2019-04-19  Tom Tromey  <tom@tromey.com>
6160
6161         * type-stack.h (struct type_stack) <insert>: Constify string.
6162         * type-stack.c (type_stack::insert): Constify string.
6163         * gdbtypes.h (lookup_template_type): Update.
6164         (address_space_name_to_int): Update.
6165         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6166         const.
6167         (lookup_template_type): Make name const.
6168         * c-exp.y: Update rules.
6169         (lex_one_token, classify_name, classify_inner_name)
6170         (c_print_token): Update.
6171         * p-exp.y: Update rules.
6172         (yylex): Update.
6173         * f-exp.y: Update rules.
6174         (yylex): Update.
6175         * d-exp.y: Update rules.
6176         (lex_one_token, classify_name, classify_inner_name): Update.
6177         * parse.c (write_dollar_variable, copy_name): Return std::string.
6178         * parser-defs.h (copy_name): Change return type.
6179         * m2-exp.y: Update rules.
6180         (yylex): Update.
6181         * go-exp.y (lex_one_token): Update.
6182         Update rules.
6183         (classify_unsafe_function, classify_packaged_name)
6184         (classify_name, yylex): Update.
6185
6186 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6187
6188         * configure.ac: add --enable-source-highlight switch.
6189         * configure: Regenerate.
6190         * top.c (print_gdb_version): plumb --enable-source-highlight
6191         status to "show configuration".
6192
6193 2019-04-19  Tom Tromey  <tromey@adacore.com>
6194
6195         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6196         Check ADA_TYPE_P.
6197         (empty_record, ada_template_to_fixed_record_type_1)
6198         (template_to_static_fixed_type)
6199         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6200         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6201         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6202         macros.
6203
6204 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6205
6206         PR symtab/24423:
6207         * source.c (print_source_lines_base): Advance "iter" when a
6208         control character is seen.
6209
6210 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6211
6212         * inferior.h (struct infcall_suspend_state_deleter):
6213         Catch exception in destructor to avoid crash.
6214
6215 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6216
6217         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6218         close to the add_com "shell".
6219
6220 2019-04-18  Tom Tromey  <tromey@adacore.com>
6221
6222         * process-stratum-target.h (class process_stratum_target)
6223         <stratum>: Add "final".
6224
6225 2019-04-17  Tom Tromey  <tromey@adacore.com>
6226
6227         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6228         against nullptr before use.
6229
6230 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6231
6232         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6233
6234 2019-04-17  Jim Wilson  <jimw@sifive.com>
6235             Andrew Burgess  <andrew.burgess@embecosm.com>
6236
6237         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6238         code read might fail, assume 4-byte breakpoint in that case.
6239
6240 2019-04-15  Leszek Swirski  <leszeks@google.com>
6241
6242         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6243         rather than a hand-rolled POD check when checking for forced MEMORY
6244         classification.
6245
6246 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6247
6248         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6249         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6250         function.
6251         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6252         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6253         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6254         declaration.
6255
6256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6257
6258         * aarch64-linux-nat.c
6259         (aarch64_linux_nat_target::thread_architecture): Add override.
6260         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6261         each VQ.
6262
6263 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6264
6265         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6266
6267 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6270         target types of size 96-bits, add some additional comments, and
6271         check that the builtin type we found was the correct size.
6272
6273 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6274
6275         * utils.c (prompt_for_continue): Don't restore the styling at the
6276         end, as applied_style has the wrong value.  This fixes styling in
6277         long lists of file names that are interrupted by the "Continue?"
6278         prompt.
6279
6280 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6281
6282         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6283         * c-lang.c (c_language_defn): Likewise.
6284         (cplus_language_defn): Likewise.
6285         (asm_language_defn): Likewise.
6286         (minimal_language_defn): Likewise.
6287         * d-lang.c (d_language_defn): Likewise.
6288         * f-lang.c (f_language_defn): Likewise.
6289         * go-lang.c (go_language_defn): Likewise.
6290         * language.c (unknown_language_defn): Likewise.
6291         (auto_language_defn): Likewise.
6292         * language.h (struct language_defn): Remove la_magic field.
6293         (LANG_MAGIC): Delete.
6294         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6295         * objc-lang.c (objc_language_defn): Likewise.
6296         * opencl-lang.c (opencl_language_defn): Likewise.
6297         * p-lang.c (pascal_language_defn): Likewise.
6298         * rust-lang.c (rust_language_defn): Likewise.
6299
6300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6301
6302         * riscv-tdep.c (riscv_type_align): New function.
6303         (riscv_type_alignment): Delete.
6304         (riscv_arg_location): Use 'type_align'.
6305         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6306
6307 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * gdbtypes.c (type_align): A struct with no non-static fields also
6310         has alignment of 1.
6311
6312 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6315         component to 0.
6316         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6317         member.
6318         (riscv_struct_info::analyse): New implementation using new
6319         analyse_inner member function.
6320         (riscv_struct_info::field_offset): New member function.
6321         (riscv_struct_info::m_offsets): New member variable.
6322         (riscv_struct_info::analyse_inner): New private member function,
6323         takes the old implementation of riscv_struct_info::analyse but
6324         extended to track field offsets.
6325         (riscv_call_arg_struct): Update the struct folding special cases
6326         to handle cases where empty C++ structs, which are non-zero
6327         length, are found.
6328         (riscv_arg_location): Initialise the length of each location, a
6329         non-zero length now indicates the location is in use.
6330         (riscv_push_dummy_call): Allow for the first location having a
6331         non-zero offset when setting up arguments.
6332         (riscv_return_value): Likewise, but for return values.
6333
6334 2019-04-11  Tom Tromey  <tromey@adacore.com>
6335
6336         * utils.c (internal_vproblem): Make "msg" const.
6337
6338 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6339
6340         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6341         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6342         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6343         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6344
6345 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6346
6347         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6348         function.
6349         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6350         of amd64_collect_native_gregset.
6351         (amd64_linux_nat_target::store_registers): Likewise.
6352
6353 2019-04-10  Tom Tromey  <tom@tromey.com>
6354
6355         * symtab.c (lookup_global_symbol_from_objfile)
6356         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6357         * objfiles.h (class separate_debug_iterator): New.
6358         (class separate_debug_range): New.
6359         (struct objfile) <separate_debug_objfiles>: New method.
6360         (objfile_separate_debug_iterate): Don't declare.
6361         * objfiles.c (separate_debug_iterator::operator++): Rename from
6362         objfile_separate_debug_iterate.
6363         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6364         iterator.
6365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6366         iterator.
6367
6368 2019-04-10  Tom Tromey  <tom@tromey.com>
6369
6370         * symfile.c (reread_symbols): Remove old comment.
6371         * objfiles.c (free_all_objfiles): Fix a typo.
6372
6373 2019-04-10  Tom Tromey  <tom@tromey.com>
6374
6375         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6376         * minsyms.c (lookup_minimal_symbol): Use foreach.
6377         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6378         (lookup_minimal_symbol_solib_trampoline): Likewise.
6379         * symfile.c (reread_symbols): Use foreach.
6380
6381 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6382             Tom Tromey  <tromey@adacore.com>
6383
6384         PR rust/24414:
6385         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6386         (rust_lex_int_test): Change "value" to be LONGEST.
6387         (rust_lex_tests): Add test for long integer literal.
6388
6389 2019-04-09  Tom Tromey  <tromey@adacore.com>
6390
6391         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6392         to bool.
6393         (extended_remote_target::attach): Update.
6394         (remote_target::remote_notice_new_inferior): Update.
6395         (remote_target::add_current_inferior_and_thread): Update.
6396         * inferior.c (exit_inferior_1): Use "false".
6397         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6398
6399 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6400
6401         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6402         the "start" command.
6403
6404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6405
6406         * python/py-inferior.c (infpy_thread_from_thread_handle):
6407         Adjust comments to reflect renaming of thread_from_thread_handle
6408         to thread_from_handle.  Adjust keywords.  Fix type error message.
6409         (inferior_object_methods): Add thread_from_handle.  Retain
6410         thread_from_thread_handle, but mark it as deprecated.
6411
6412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6413
6414         * gdbthread.h (find_thread_by_handle): Revise declaration.
6415         * thread.c (find_thread_by_handle): Likewise.  Adjust
6416         implementation too.
6417         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6418         support for buffer objects as handles.
6419
6420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6421
6422         * python/py-infthread.c (thpy_thread_handle): New function.
6423         (thread_object_methods): Register thpy_thread_handle.
6424
6425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6426
6427         * gdbthread.h (thread_to_thread_handle): Declare.
6428         * thread.c (gdbtypes.h): Include.
6429         (thread_to_thread_handle): New function.
6430
6431         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6432         (target_thread_info_to_thread_handle): Declare.
6433         * target.c (target_thread_info_to_thread_handle): New function.
6434         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6435         * target-delegates.c: Regenerate.
6436
6437         * linux-thread-db.c (class thread_db_target): Add method
6438         thread_info_to_thread_handle.
6439         (thread_db_target::thread_info_to_thread_handle): Define.
6440         * remote.c (class remote_target): Add new method
6441         thread_info_to_thread_handle.
6442         (remote_target::thread_info_to_thread_handle): Define.
6443
6444 2019-04-08  Pedro Alves  <palves@redhat.com>
6445
6446         * common/common-exceptions.c (throw_exception): Don't create
6447         named object to throw; throw directly.
6448         (throw_it): Likewise.  Don't initialize gdb_exception::message
6449         here, with new; pass FMT and AP to the ctor instead.
6450         * common/common-exceptions.h: Include <string>.
6451         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6452         const char *, va_list)): New ctor.  Use std::make_shared.
6453         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6454         errors)): Delete.
6455         (gdb_exception_error::gdb_exception_error(enum errors, const char
6456         *, va_list)): New.
6457         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6458         Add assertion.
6459         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6460         errors)): Delete.
6461         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6462         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6463         Add assertion.
6464
6465 2019-04-08  Tom Tromey  <tom@tromey.com>
6466
6467         * valops.c (value_rtti_indirect_type): Replace throw_exception
6468         with throw.
6469         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6470         with throw.
6471         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6472         throw.
6473         * target.c (target_translate_tls_address): Replace throw_exception
6474         with throw.
6475         * stack.c (frame_apply_command_count): Replace throw_exception
6476         with throw.
6477         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6478         throw.
6479         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6480         with throw.
6481         * rs6000-tdep.c (rs6000_frame_cache)
6482         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6483         * remote.c: Replace throw_exception with throw.
6484         * record-full.c (record_full_message, record_full_wait_1)
6485         (record_full_restore): Replace throw_exception with throw.
6486         * record-btrace.c:
6487         (get_thread_current_frame_id, record_btrace_start_replaying)
6488         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6489         (cmd_record_btrace_start): Replace throw_exception with throw.
6490         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6491         throw.
6492         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6493         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6494         * linespec.c:
6495         (find_linespec_symbols): Replace throw_exception with throw.
6496         * infrun.c (displaced_step_prepare, resume): Replace
6497         throw_exception with throw.
6498         * infcmd.c (post_create_inferior): Replace throw_exception with
6499         throw.
6500         * inf-loop.c (inferior_event_handler): Replace throw_exception
6501         with throw.
6502         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6503         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6504         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6505         (get_prev_frame_always, get_frame_pc_if_available)
6506         (get_frame_address_in_block_if_available, get_frame_language):
6507         Replace throw_exception with throw.
6508         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6509         throw_exception with throw.
6510         * eval.c (fetch_subexp_value, evaluate_var_value)
6511         (evaluate_funcall, evaluate_subexp_standard): Replace
6512         throw_exception with throw.
6513         * dwarf2loc.c (call_site_find_chain)
6514         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6515         Replace throw_exception with throw.
6516         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6517         with throw.
6518         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6519         throw.
6520         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6521         * completer.c (complete_line_internal): Replace throw_exception
6522         with throw.
6523         * compile/compile-object-run.c (compile_object_run): Replace
6524         throw_exception with throw.
6525         * cli/cli-script.c (process_next_line): Replace throw_exception
6526         with throw.
6527         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6528         (btrace_enable, btrace_maint_update_pt_packets): Replace
6529         throw_exception with throw.
6530         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6531         throw_exception with throw.
6532         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6533         throw_exception with throw.
6534         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6535         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6536         * aarch64-tdep.c (aarch64_make_prologue_cache)
6537         (aarch64_make_stub_cache): Replace throw_exception with throw.
6538
6539 2019-04-08  Tom Tromey  <tom@tromey.com>
6540
6541         * common/common-exceptions.c (throw_exception): Rename from
6542         throw_exception_cxx.  Remove old copy.  Make argument const.
6543         (throw_it): Create and throw exception objects directly.
6544         * common/common-exceptions.h (throw_exception): Make argument
6545         const.
6546         (struct gdb_exception_error): Add constructor.
6547         (struct gdb_exception_quit): Add constructor.
6548
6549 2019-04-08  Tom Tromey  <tom@tromey.com>
6550
6551         * common/common-exceptions.h (exception_rethrow): Don't declare.
6552         (TRY_SJLJ): Update comment.
6553         (TRY, CATCH, END_CATCH): Remove.
6554         * common/common-exceptions.c (exception_rethrow): Remove.
6555
6556 2019-04-08  Tom Tromey  <tom@tromey.com>
6557
6558         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6559         Remove.
6560         (gdb_exception_error): Rename from
6561         gdb_exception_RETURN_MASK_ERROR.
6562         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6563         (gdb_quit_bad_alloc): Update.
6564         * aarch64-tdep.c: Update.
6565         * ada-lang.c: Update.
6566         * ada-typeprint.c: Update.
6567         * ada-valprint.c: Update.
6568         * amd64-tdep.c: Update.
6569         * arch-utils.c: Update.
6570         * break-catch-throw.c: Update.
6571         * breakpoint.c: Update.
6572         * btrace.c: Update.
6573         * c-varobj.c: Update.
6574         * cli/cli-cmds.c: Update.
6575         * cli/cli-interp.c: Update.
6576         * cli/cli-script.c: Update.
6577         * common/common-exceptions.c: Update.
6578         * common/new-op.c: Update.
6579         * common/selftest.c: Update.
6580         * compile/compile-c-symbols.c: Update.
6581         * compile/compile-cplus-symbols.c: Update.
6582         * compile/compile-object-load.c: Update.
6583         * compile/compile-object-run.c: Update.
6584         * completer.c: Update.
6585         * corelow.c: Update.
6586         * cp-abi.c: Update.
6587         * cp-support.c: Update.
6588         * cp-valprint.c: Update.
6589         * darwin-nat.c: Update.
6590         * disasm-selftests.c: Update.
6591         * dtrace-probe.c: Update.
6592         * dwarf-index-cache.c: Update.
6593         * dwarf-index-write.c: Update.
6594         * dwarf2-frame-tailcall.c: Update.
6595         * dwarf2-frame.c: Update.
6596         * dwarf2loc.c: Update.
6597         * dwarf2read.c: Update.
6598         * eval.c: Update.
6599         * event-loop.c: Update.
6600         * event-top.c: Update.
6601         * exec.c: Update.
6602         * f-valprint.c: Update.
6603         * fbsd-tdep.c: Update.
6604         * frame-unwind.c: Update.
6605         * frame.c: Update.
6606         * gdbtypes.c: Update.
6607         * gnu-v3-abi.c: Update.
6608         * guile/guile-internal.h: Update.
6609         * guile/scm-block.c: Update.
6610         * guile/scm-breakpoint.c: Update.
6611         * guile/scm-cmd.c: Update.
6612         * guile/scm-disasm.c: Update.
6613         * guile/scm-frame.c: Update.
6614         * guile/scm-lazy-string.c: Update.
6615         * guile/scm-math.c: Update.
6616         * guile/scm-param.c: Update.
6617         * guile/scm-ports.c: Update.
6618         * guile/scm-pretty-print.c: Update.
6619         * guile/scm-symbol.c: Update.
6620         * guile/scm-symtab.c: Update.
6621         * guile/scm-type.c: Update.
6622         * guile/scm-value.c: Update.
6623         * i386-linux-tdep.c: Update.
6624         * i386-tdep.c: Update.
6625         * inf-loop.c: Update.
6626         * infcall.c: Update.
6627         * infcmd.c: Update.
6628         * infrun.c: Update.
6629         * jit.c: Update.
6630         * language.c: Update.
6631         * linespec.c: Update.
6632         * linux-fork.c: Update.
6633         * linux-nat.c: Update.
6634         * linux-tdep.c: Update.
6635         * linux-thread-db.c: Update.
6636         * main.c: Update.
6637         * mi/mi-cmd-break.c: Update.
6638         * mi/mi-cmd-stack.c: Update.
6639         * mi/mi-interp.c: Update.
6640         * mi/mi-main.c: Update.
6641         * objc-lang.c: Update.
6642         * p-valprint.c: Update.
6643         * parse.c: Update.
6644         * ppc-linux-tdep.c: Update.
6645         * printcmd.c: Update.
6646         * python/py-arch.c: Update.
6647         * python/py-breakpoint.c: Update.
6648         * python/py-cmd.c: Update.
6649         * python/py-finishbreakpoint.c: Update.
6650         * python/py-frame.c: Update.
6651         * python/py-framefilter.c: Update.
6652         * python/py-gdb-readline.c: Update.
6653         * python/py-inferior.c: Update.
6654         * python/py-infthread.c: Update.
6655         * python/py-lazy-string.c: Update.
6656         * python/py-linetable.c: Update.
6657         * python/py-objfile.c: Update.
6658         * python/py-param.c: Update.
6659         * python/py-prettyprint.c: Update.
6660         * python/py-progspace.c: Update.
6661         * python/py-record-btrace.c: Update.
6662         * python/py-record.c: Update.
6663         * python/py-symbol.c: Update.
6664         * python/py-type.c: Update.
6665         * python/py-unwind.c: Update.
6666         * python/py-utils.c: Update.
6667         * python/py-value.c: Update.
6668         * python/python.c: Update.
6669         * record-btrace.c: Update.
6670         * record-full.c: Update.
6671         * remote-fileio.c: Update.
6672         * remote.c: Update.
6673         * riscv-tdep.c: Update.
6674         * rs6000-aix-tdep.c: Update.
6675         * rs6000-tdep.c: Update.
6676         * rust-exp.y: Update.
6677         * rust-lang.c: Update.
6678         * s390-tdep.c: Update.
6679         * selftest-arch.c: Update.
6680         * solib-dsbt.c: Update.
6681         * solib-frv.c: Update.
6682         * solib-spu.c: Update.
6683         * solib-svr4.c: Update.
6684         * solib.c: Update.
6685         * sparc64-linux-tdep.c: Update.
6686         * stack.c: Update.
6687         * symfile-mem.c: Update.
6688         * symmisc.c: Update.
6689         * target.c: Update.
6690         * thread.c: Update.
6691         * top.c: Update.
6692         * tracefile-tfile.c: Update.
6693         * tui/tui.c: Update.
6694         * typeprint.c: Update.
6695         * unittests/cli-utils-selftests.c: Update.
6696         * unittests/parse-connection-spec-selftests.c: Update.
6697         * valops.c: Update.
6698         * valprint.c: Update.
6699         * value.c: Update.
6700         * varobj.c: Update.
6701         * windows-nat.c: Update.
6702         * x86-linux-nat.c: Update.
6703         * xml-support.c: Update.
6704
6705 2019-04-08  Tom Tromey  <tom@tromey.com>
6706
6707         * xml-support.c: Use C++ exception handling.
6708         * x86-linux-nat.c: Use C++ exception handling.
6709         * windows-nat.c: Use C++ exception handling.
6710         * varobj.c: Use C++ exception handling.
6711         * value.c: Use C++ exception handling.
6712         * valprint.c: Use C++ exception handling.
6713         * valops.c: Use C++ exception handling.
6714         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6715         handling.
6716         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6717         * typeprint.c: Use C++ exception handling.
6718         * tui/tui.c: Use C++ exception handling.
6719         * tracefile-tfile.c: Use C++ exception handling.
6720         * top.c: Use C++ exception handling.
6721         * thread.c: Use C++ exception handling.
6722         * target.c: Use C++ exception handling.
6723         * symmisc.c: Use C++ exception handling.
6724         * symfile-mem.c: Use C++ exception handling.
6725         * stack.c: Use C++ exception handling.
6726         * sparc64-linux-tdep.c: Use C++ exception handling.
6727         * solib.c: Use C++ exception handling.
6728         * solib-svr4.c: Use C++ exception handling.
6729         * solib-spu.c: Use C++ exception handling.
6730         * solib-frv.c: Use C++ exception handling.
6731         * solib-dsbt.c: Use C++ exception handling.
6732         * selftest-arch.c: Use C++ exception handling.
6733         * s390-tdep.c: Use C++ exception handling.
6734         * rust-lang.c: Use C++ exception handling.
6735         * rust-exp.y: Use C++ exception handling.
6736         * rs6000-tdep.c: Use C++ exception handling.
6737         * rs6000-aix-tdep.c: Use C++ exception handling.
6738         * riscv-tdep.c: Use C++ exception handling.
6739         * remote.c: Use C++ exception handling.
6740         * remote-fileio.c: Use C++ exception handling.
6741         * record-full.c: Use C++ exception handling.
6742         * record-btrace.c: Use C++ exception handling.
6743         * python/python.c: Use C++ exception handling.
6744         * python/py-value.c: Use C++ exception handling.
6745         * python/py-utils.c: Use C++ exception handling.
6746         * python/py-unwind.c: Use C++ exception handling.
6747         * python/py-type.c: Use C++ exception handling.
6748         * python/py-symbol.c: Use C++ exception handling.
6749         * python/py-record.c: Use C++ exception handling.
6750         * python/py-record-btrace.c: Use C++ exception handling.
6751         * python/py-progspace.c: Use C++ exception handling.
6752         * python/py-prettyprint.c: Use C++ exception handling.
6753         * python/py-param.c: Use C++ exception handling.
6754         * python/py-objfile.c: Use C++ exception handling.
6755         * python/py-linetable.c: Use C++ exception handling.
6756         * python/py-lazy-string.c: Use C++ exception handling.
6757         * python/py-infthread.c: Use C++ exception handling.
6758         * python/py-inferior.c: Use C++ exception handling.
6759         * python/py-gdb-readline.c: Use C++ exception handling.
6760         * python/py-framefilter.c: Use C++ exception handling.
6761         * python/py-frame.c: Use C++ exception handling.
6762         * python/py-finishbreakpoint.c: Use C++ exception handling.
6763         * python/py-cmd.c: Use C++ exception handling.
6764         * python/py-breakpoint.c: Use C++ exception handling.
6765         * python/py-arch.c: Use C++ exception handling.
6766         * printcmd.c: Use C++ exception handling.
6767         * ppc-linux-tdep.c: Use C++ exception handling.
6768         * parse.c: Use C++ exception handling.
6769         * p-valprint.c: Use C++ exception handling.
6770         * objc-lang.c: Use C++ exception handling.
6771         * mi/mi-main.c: Use C++ exception handling.
6772         * mi/mi-interp.c: Use C++ exception handling.
6773         * mi/mi-cmd-stack.c: Use C++ exception handling.
6774         * mi/mi-cmd-break.c: Use C++ exception handling.
6775         * main.c: Use C++ exception handling.
6776         * linux-thread-db.c: Use C++ exception handling.
6777         * linux-tdep.c: Use C++ exception handling.
6778         * linux-nat.c: Use C++ exception handling.
6779         * linux-fork.c: Use C++ exception handling.
6780         * linespec.c: Use C++ exception handling.
6781         * language.c: Use C++ exception handling.
6782         * jit.c: Use C++ exception handling.
6783         * infrun.c: Use C++ exception handling.
6784         * infcmd.c: Use C++ exception handling.
6785         * infcall.c: Use C++ exception handling.
6786         * inf-loop.c: Use C++ exception handling.
6787         * i386-tdep.c: Use C++ exception handling.
6788         * i386-linux-tdep.c: Use C++ exception handling.
6789         * guile/scm-value.c: Use C++ exception handling.
6790         * guile/scm-type.c: Use C++ exception handling.
6791         * guile/scm-symtab.c: Use C++ exception handling.
6792         * guile/scm-symbol.c: Use C++ exception handling.
6793         * guile/scm-pretty-print.c: Use C++ exception handling.
6794         * guile/scm-ports.c: Use C++ exception handling.
6795         * guile/scm-param.c: Use C++ exception handling.
6796         * guile/scm-math.c: Use C++ exception handling.
6797         * guile/scm-lazy-string.c: Use C++ exception handling.
6798         * guile/scm-frame.c: Use C++ exception handling.
6799         * guile/scm-disasm.c: Use C++ exception handling.
6800         * guile/scm-cmd.c: Use C++ exception handling.
6801         * guile/scm-breakpoint.c: Use C++ exception handling.
6802         * guile/scm-block.c: Use C++ exception handling.
6803         * guile/guile-internal.h: Use C++ exception handling.
6804         * gnu-v3-abi.c: Use C++ exception handling.
6805         * gdbtypes.c: Use C++ exception handling.
6806         * frame.c: Use C++ exception handling.
6807         * frame-unwind.c: Use C++ exception handling.
6808         * fbsd-tdep.c: Use C++ exception handling.
6809         * f-valprint.c: Use C++ exception handling.
6810         * exec.c: Use C++ exception handling.
6811         * event-top.c: Use C++ exception handling.
6812         * event-loop.c: Use C++ exception handling.
6813         * eval.c: Use C++ exception handling.
6814         * dwarf2read.c: Use C++ exception handling.
6815         * dwarf2loc.c: Use C++ exception handling.
6816         * dwarf2-frame.c: Use C++ exception handling.
6817         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6818         * dwarf-index-write.c: Use C++ exception handling.
6819         * dwarf-index-cache.c: Use C++ exception handling.
6820         * dtrace-probe.c: Use C++ exception handling.
6821         * disasm-selftests.c: Use C++ exception handling.
6822         * darwin-nat.c: Use C++ exception handling.
6823         * cp-valprint.c: Use C++ exception handling.
6824         * cp-support.c: Use C++ exception handling.
6825         * cp-abi.c: Use C++ exception handling.
6826         * corelow.c: Use C++ exception handling.
6827         * completer.c: Use C++ exception handling.
6828         * compile/compile-object-run.c: Use C++ exception handling.
6829         * compile/compile-object-load.c: Use C++ exception handling.
6830         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6831         * compile/compile-c-symbols.c: Use C++ exception handling.
6832         * common/selftest.c: Use C++ exception handling.
6833         * common/new-op.c: Use C++ exception handling.
6834         * cli/cli-script.c: Use C++ exception handling.
6835         * cli/cli-interp.c: Use C++ exception handling.
6836         * cli/cli-cmds.c: Use C++ exception handling.
6837         * c-varobj.c: Use C++ exception handling.
6838         * btrace.c: Use C++ exception handling.
6839         * breakpoint.c: Use C++ exception handling.
6840         * break-catch-throw.c: Use C++ exception handling.
6841         * arch-utils.c: Use C++ exception handling.
6842         * amd64-tdep.c: Use C++ exception handling.
6843         * ada-valprint.c: Use C++ exception handling.
6844         * ada-typeprint.c: Use C++ exception handling.
6845         * ada-lang.c: Use C++ exception handling.
6846         * aarch64-tdep.c: Use C++ exception handling.
6847
6848 2019-04-08  Tom Tromey  <tom@tromey.com>
6849
6850         * xml-support.c (gdb_xml_parser::parse): Update.
6851         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6852         * value.c (show_convenience): Update.
6853         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6854         (test_parse_flags_qcs): Update.
6855         * thread.c (thr_try_catch_cmd): Update.
6856         * target.c (target_translate_tls_address): Update.
6857         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6858         (info_frame_command_core, frame_apply_command_count): Update.
6859         * rust-exp.y (rust_lex_exception_test): Update.
6860         * riscv-tdep.c (riscv_print_one_register_info): Update.
6861         * remote.c (remote_target::enable_btrace): Update.
6862         * record-btrace.c (record_btrace_enable_warn): Update.
6863         * python/py-utils.c (gdbpy_convert_exception): Update.
6864         * printcmd.c (do_one_display, print_variable_and_value): Update.
6865         * mi/mi-main.c (mi_print_exception): Update.
6866         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6867         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6868         * linux-nat.c (linux_nat_target::attach): Update.
6869         * linux-fork.c (class scoped_switch_fork_info): Update.
6870         * infrun.c (displaced_step_prepare): Update.
6871         * infcall.c (call_function_by_hand_dummy): Update.
6872         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6873         * gnu-v3-abi.c (print_one_vtable): Update.
6874         * frame.c (get_prev_frame_always): Update.
6875         * f-valprint.c (info_common_command_for_block): Update.
6876         * exec.c (try_open_exec_file): Update.
6877         * exceptions.c (print_exception, exception_print)
6878         (exception_fprintf, exception_print_same): Update.
6879         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6880         * dwarf-index-cache.c (index_cache::store)
6881         (index_cache::lookup_gdb_index): Update.
6882         * darwin-nat.c (maybe_cache_shell): Update.
6883         * cp-valprint.c (cp_print_value_fields): Update.
6884         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6885         (gcc_cplus_symbol_address): Update.
6886         * compile/compile-c-symbols.c (gcc_convert_symbol)
6887         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6888         * common/selftest.c: Update.
6889         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6890         a std::string.
6891         (exception_try_scope_entry, exception_try_scope_exit): Don't
6892         declare.
6893         (struct exception_try_scope): Remove.
6894         (TRY): Don't use exception_try_scope.
6895         (struct gdb_exception): Add constructor, operator=.
6896         <what>: New method.
6897         (struct gdb_exception_RETURN_MASK_ALL)
6898         (struct gdb_exception_RETURN_MASK_ERROR)
6899         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6900         (struct gdb_quit_bad_alloc): Update.
6901         * common/common-exceptions.c (exception_none): Change
6902         initializer.
6903         (struct catcher) <state, exception>: Initialize inline.
6904         <prev>: Remove member.
6905         (current_catcher): Remove.
6906         (catchers): New global.
6907         (exceptions_state_mc_init): Simplify.
6908         (catcher_pop): Remove.
6909         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6910         (try_scope_depth, exception_try_scope_entry)
6911         (exception_try_scope_exit): Remove.
6912         (throw_exception_sjlj): Update.
6913         (exception_messages, exception_messages_size): Remove.
6914         (throw_it): Simplify.
6915         (gdb_exception_sliced_copy): Remove.
6916         (throw_exception_cxx): Update.
6917         * cli/cli-script.c (script_from_file): Update.
6918         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6919         Update.
6920         * ada-valprint.c (ada_val_print): Update.
6921         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6922         (create_excep_cond_exprs): Update.
6923
6924 2019-04-08  Tom Tromey  <tom@tromey.com>
6925
6926         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6927         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6928         (TRY, CATCH, END_CATCH): Remove some definitions.
6929         * common/common-exceptions.c: Don't use GDB_XCPT.
6930         (catcher_list_size): Remove.
6931         (throw_exception, throw_it): Simplify.
6932
6933 2019-04-05  Tom Tromey  <tom@tromey.com>
6934
6935         Revert the header-sorting patch.
6936         * ft32-tdep.c: Revert.
6937         * frv-tdep.c: Revert.
6938         * frv-linux-tdep.c: Revert.
6939         * frame.c: Revert.
6940         * frame-unwind.c: Revert.
6941         * frame-base.c: Revert.
6942         * fork-child.c: Revert.
6943         * findvar.c: Revert.
6944         * findcmd.c: Revert.
6945         * filesystem.c: Revert.
6946         * filename-seen-cache.h: Revert.
6947         * filename-seen-cache.c: Revert.
6948         * fbsd-tdep.c: Revert.
6949         * fbsd-nat.h: Revert.
6950         * fbsd-nat.c: Revert.
6951         * f-valprint.c: Revert.
6952         * f-typeprint.c: Revert.
6953         * f-lang.c: Revert.
6954         * extension.h: Revert.
6955         * extension.c: Revert.
6956         * extension-priv.h: Revert.
6957         * expprint.c: Revert.
6958         * exec.h: Revert.
6959         * exec.c: Revert.
6960         * exceptions.c: Revert.
6961         * event-top.c: Revert.
6962         * event-loop.c: Revert.
6963         * eval.c: Revert.
6964         * elfread.c: Revert.
6965         * dwarf2read.h: Revert.
6966         * dwarf2read.c: Revert.
6967         * dwarf2loc.c: Revert.
6968         * dwarf2expr.h: Revert.
6969         * dwarf2expr.c: Revert.
6970         * dwarf2-frame.c: Revert.
6971         * dwarf2-frame-tailcall.c: Revert.
6972         * dwarf-index-write.h: Revert.
6973         * dwarf-index-write.c: Revert.
6974         * dwarf-index-common.c: Revert.
6975         * dwarf-index-cache.h: Revert.
6976         * dwarf-index-cache.c: Revert.
6977         * dummy-frame.c: Revert.
6978         * dtrace-probe.c: Revert.
6979         * disasm.h: Revert.
6980         * disasm.c: Revert.
6981         * disasm-selftests.c: Revert.
6982         * dictionary.c: Revert.
6983         * dicos-tdep.c: Revert.
6984         * demangle.c: Revert.
6985         * dcache.h: Revert.
6986         * dcache.c: Revert.
6987         * darwin-nat.h: Revert.
6988         * darwin-nat.c: Revert.
6989         * darwin-nat-info.c: Revert.
6990         * d-valprint.c: Revert.
6991         * d-namespace.c: Revert.
6992         * d-lang.c: Revert.
6993         * ctf.c: Revert.
6994         * csky-tdep.c: Revert.
6995         * csky-linux-tdep.c: Revert.
6996         * cris-tdep.c: Revert.
6997         * cris-linux-tdep.c: Revert.
6998         * cp-valprint.c: Revert.
6999         * cp-support.c: Revert.
7000         * cp-namespace.c: Revert.
7001         * cp-abi.c: Revert.
7002         * corelow.c: Revert.
7003         * corefile.c: Revert.
7004         * continuations.c: Revert.
7005         * completer.h: Revert.
7006         * completer.c: Revert.
7007         * complaints.c: Revert.
7008         * coffread.c: Revert.
7009         * coff-pe-read.c: Revert.
7010         * cli-out.h: Revert.
7011         * cli-out.c: Revert.
7012         * charset.c: Revert.
7013         * c-varobj.c: Revert.
7014         * c-valprint.c: Revert.
7015         * c-typeprint.c: Revert.
7016         * c-lang.c: Revert.
7017         * buildsym.c: Revert.
7018         * buildsym-legacy.c: Revert.
7019         * build-id.h: Revert.
7020         * build-id.c: Revert.
7021         * btrace.c: Revert.
7022         * bsd-uthread.c: Revert.
7023         * breakpoint.h: Revert.
7024         * breakpoint.c: Revert.
7025         * break-catch-throw.c: Revert.
7026         * break-catch-syscall.c: Revert.
7027         * break-catch-sig.c: Revert.
7028         * blockframe.c: Revert.
7029         * block.c: Revert.
7030         * bfin-tdep.c: Revert.
7031         * bfin-linux-tdep.c: Revert.
7032         * bfd-target.c: Revert.
7033         * bcache.c: Revert.
7034         * ax-general.c: Revert.
7035         * ax-gdb.h: Revert.
7036         * ax-gdb.c: Revert.
7037         * avr-tdep.c: Revert.
7038         * auxv.c: Revert.
7039         * auto-load.c: Revert.
7040         * arm-wince-tdep.c: Revert.
7041         * arm-tdep.c: Revert.
7042         * arm-symbian-tdep.c: Revert.
7043         * arm-pikeos-tdep.c: Revert.
7044         * arm-obsd-tdep.c: Revert.
7045         * arm-nbsd-tdep.c: Revert.
7046         * arm-nbsd-nat.c: Revert.
7047         * arm-linux-tdep.c: Revert.
7048         * arm-linux-nat.c: Revert.
7049         * arm-fbsd-tdep.c: Revert.
7050         * arm-fbsd-nat.c: Revert.
7051         * arm-bsd-tdep.c: Revert.
7052         * arch-utils.c: Revert.
7053         * arc-tdep.c: Revert.
7054         * arc-newlib-tdep.c: Revert.
7055         * annotate.h: Revert.
7056         * annotate.c: Revert.
7057         * amd64-windows-tdep.c: Revert.
7058         * amd64-windows-nat.c: Revert.
7059         * amd64-tdep.c: Revert.
7060         * amd64-sol2-tdep.c: Revert.
7061         * amd64-obsd-tdep.c: Revert.
7062         * amd64-obsd-nat.c: Revert.
7063         * amd64-nbsd-tdep.c: Revert.
7064         * amd64-nbsd-nat.c: Revert.
7065         * amd64-nat.c: Revert.
7066         * amd64-linux-tdep.c: Revert.
7067         * amd64-linux-nat.c: Revert.
7068         * amd64-fbsd-tdep.c: Revert.
7069         * amd64-fbsd-nat.c: Revert.
7070         * amd64-dicos-tdep.c: Revert.
7071         * amd64-darwin-tdep.c: Revert.
7072         * amd64-bsd-nat.c: Revert.
7073         * alpha-tdep.c: Revert.
7074         * alpha-obsd-tdep.c: Revert.
7075         * alpha-nbsd-tdep.c: Revert.
7076         * alpha-mdebug-tdep.c: Revert.
7077         * alpha-linux-tdep.c: Revert.
7078         * alpha-linux-nat.c: Revert.
7079         * alpha-bsd-tdep.c: Revert.
7080         * alpha-bsd-nat.c: Revert.
7081         * aix-thread.c: Revert.
7082         * agent.c: Revert.
7083         * addrmap.c: Revert.
7084         * ada-varobj.c: Revert.
7085         * ada-valprint.c: Revert.
7086         * ada-typeprint.c: Revert.
7087         * ada-tasks.c: Revert.
7088         * ada-lang.c: Revert.
7089         * aarch64-tdep.c: Revert.
7090         * aarch64-ravenscar-thread.c: Revert.
7091         * aarch64-newlib-tdep.c: Revert.
7092         * aarch64-linux-tdep.c: Revert.
7093         * aarch64-linux-nat.c: Revert.
7094         * aarch64-fbsd-tdep.c: Revert.
7095         * aarch64-fbsd-nat.c: Revert.
7096         * aarch32-linux-nat.c: Revert.
7097
7098 2019-04-05  Tom Tromey  <tom@tromey.com>
7099
7100         * ft32-tdep.c: Sort headers.
7101         * frv-tdep.c: Sort headers.
7102         * frv-linux-tdep.c: Sort headers.
7103         * frame.c: Sort headers.
7104         * frame-unwind.c: Sort headers.
7105         * frame-base.c: Sort headers.
7106         * fork-child.c: Sort headers.
7107         * findvar.c: Sort headers.
7108         * findcmd.c: Sort headers.
7109         * filesystem.c: Sort headers.
7110         * filename-seen-cache.h: Sort headers.
7111         * filename-seen-cache.c: Sort headers.
7112         * fbsd-tdep.c: Sort headers.
7113         * fbsd-nat.h: Sort headers.
7114         * fbsd-nat.c: Sort headers.
7115         * f-valprint.c: Sort headers.
7116         * f-typeprint.c: Sort headers.
7117         * f-lang.c: Sort headers.
7118         * extension.h: Sort headers.
7119         * extension.c: Sort headers.
7120         * extension-priv.h: Sort headers.
7121         * expprint.c: Sort headers.
7122         * exec.h: Sort headers.
7123         * exec.c: Sort headers.
7124         * exceptions.c: Sort headers.
7125         * event-top.c: Sort headers.
7126         * event-loop.c: Sort headers.
7127         * eval.c: Sort headers.
7128         * elfread.c: Sort headers.
7129         * dwarf2read.h: Sort headers.
7130         * dwarf2read.c: Sort headers.
7131         * dwarf2loc.c: Sort headers.
7132         * dwarf2expr.h: Sort headers.
7133         * dwarf2expr.c: Sort headers.
7134         * dwarf2-frame.c: Sort headers.
7135         * dwarf2-frame-tailcall.c: Sort headers.
7136         * dwarf-index-write.h: Sort headers.
7137         * dwarf-index-write.c: Sort headers.
7138         * dwarf-index-common.c: Sort headers.
7139         * dwarf-index-cache.h: Sort headers.
7140         * dwarf-index-cache.c: Sort headers.
7141         * dummy-frame.c: Sort headers.
7142         * dtrace-probe.c: Sort headers.
7143         * disasm.h: Sort headers.
7144         * disasm.c: Sort headers.
7145         * disasm-selftests.c: Sort headers.
7146         * dictionary.c: Sort headers.
7147         * dicos-tdep.c: Sort headers.
7148         * demangle.c: Sort headers.
7149         * dcache.h: Sort headers.
7150         * dcache.c: Sort headers.
7151         * darwin-nat.h: Sort headers.
7152         * darwin-nat.c: Sort headers.
7153         * darwin-nat-info.c: Sort headers.
7154         * d-valprint.c: Sort headers.
7155         * d-namespace.c: Sort headers.
7156         * d-lang.c: Sort headers.
7157         * ctf.c: Sort headers.
7158         * csky-tdep.c: Sort headers.
7159         * csky-linux-tdep.c: Sort headers.
7160         * cris-tdep.c: Sort headers.
7161         * cris-linux-tdep.c: Sort headers.
7162         * cp-valprint.c: Sort headers.
7163         * cp-support.c: Sort headers.
7164         * cp-namespace.c: Sort headers.
7165         * cp-abi.c: Sort headers.
7166         * corelow.c: Sort headers.
7167         * corefile.c: Sort headers.
7168         * continuations.c: Sort headers.
7169         * completer.h: Sort headers.
7170         * completer.c: Sort headers.
7171         * complaints.c: Sort headers.
7172         * coffread.c: Sort headers.
7173         * coff-pe-read.c: Sort headers.
7174         * cli-out.h: Sort headers.
7175         * cli-out.c: Sort headers.
7176         * charset.c: Sort headers.
7177         * c-varobj.c: Sort headers.
7178         * c-valprint.c: Sort headers.
7179         * c-typeprint.c: Sort headers.
7180         * c-lang.c: Sort headers.
7181         * buildsym.c: Sort headers.
7182         * buildsym-legacy.c: Sort headers.
7183         * build-id.h: Sort headers.
7184         * build-id.c: Sort headers.
7185         * btrace.c: Sort headers.
7186         * bsd-uthread.c: Sort headers.
7187         * breakpoint.h: Sort headers.
7188         * breakpoint.c: Sort headers.
7189         * break-catch-throw.c: Sort headers.
7190         * break-catch-syscall.c: Sort headers.
7191         * break-catch-sig.c: Sort headers.
7192         * blockframe.c: Sort headers.
7193         * block.c: Sort headers.
7194         * bfin-tdep.c: Sort headers.
7195         * bfin-linux-tdep.c: Sort headers.
7196         * bfd-target.c: Sort headers.
7197         * bcache.c: Sort headers.
7198         * ax-general.c: Sort headers.
7199         * ax-gdb.h: Sort headers.
7200         * ax-gdb.c: Sort headers.
7201         * avr-tdep.c: Sort headers.
7202         * auxv.c: Sort headers.
7203         * auto-load.c: Sort headers.
7204         * arm-wince-tdep.c: Sort headers.
7205         * arm-tdep.c: Sort headers.
7206         * arm-symbian-tdep.c: Sort headers.
7207         * arm-pikeos-tdep.c: Sort headers.
7208         * arm-obsd-tdep.c: Sort headers.
7209         * arm-nbsd-tdep.c: Sort headers.
7210         * arm-nbsd-nat.c: Sort headers.
7211         * arm-linux-tdep.c: Sort headers.
7212         * arm-linux-nat.c: Sort headers.
7213         * arm-fbsd-tdep.c: Sort headers.
7214         * arm-fbsd-nat.c: Sort headers.
7215         * arm-bsd-tdep.c: Sort headers.
7216         * arch-utils.c: Sort headers.
7217         * arc-tdep.c: Sort headers.
7218         * arc-newlib-tdep.c: Sort headers.
7219         * annotate.h: Sort headers.
7220         * annotate.c: Sort headers.
7221         * amd64-windows-tdep.c: Sort headers.
7222         * amd64-windows-nat.c: Sort headers.
7223         * amd64-tdep.c: Sort headers.
7224         * amd64-sol2-tdep.c: Sort headers.
7225         * amd64-obsd-tdep.c: Sort headers.
7226         * amd64-obsd-nat.c: Sort headers.
7227         * amd64-nbsd-tdep.c: Sort headers.
7228         * amd64-nbsd-nat.c: Sort headers.
7229         * amd64-nat.c: Sort headers.
7230         * amd64-linux-tdep.c: Sort headers.
7231         * amd64-linux-nat.c: Sort headers.
7232         * amd64-fbsd-tdep.c: Sort headers.
7233         * amd64-fbsd-nat.c: Sort headers.
7234         * amd64-dicos-tdep.c: Sort headers.
7235         * amd64-darwin-tdep.c: Sort headers.
7236         * amd64-bsd-nat.c: Sort headers.
7237         * alpha-tdep.c: Sort headers.
7238         * alpha-obsd-tdep.c: Sort headers.
7239         * alpha-nbsd-tdep.c: Sort headers.
7240         * alpha-mdebug-tdep.c: Sort headers.
7241         * alpha-linux-tdep.c: Sort headers.
7242         * alpha-linux-nat.c: Sort headers.
7243         * alpha-bsd-tdep.c: Sort headers.
7244         * alpha-bsd-nat.c: Sort headers.
7245         * aix-thread.c: Sort headers.
7246         * agent.c: Sort headers.
7247         * addrmap.c: Sort headers.
7248         * ada-varobj.c: Sort headers.
7249         * ada-valprint.c: Sort headers.
7250         * ada-typeprint.c: Sort headers.
7251         * ada-tasks.c: Sort headers.
7252         * ada-lang.c: Sort headers.
7253         * aarch64-tdep.c: Sort headers.
7254         * aarch64-ravenscar-thread.c: Sort headers.
7255         * aarch64-newlib-tdep.c: Sort headers.
7256         * aarch64-linux-tdep.c: Sort headers.
7257         * aarch64-linux-nat.c: Sort headers.
7258         * aarch64-fbsd-tdep.c: Sort headers.
7259         * aarch64-fbsd-nat.c: Sort headers.
7260         * aarch32-linux-nat.c: Sort headers.
7261
7262 2019-04-04  Tom Tromey  <tom@tromey.com>
7263
7264         * varobj.c (varobj_create): Update.
7265         * rust-exp.y (struct rust_parser) <update_innermost_block,
7266         lookup_symbol>: New methods.
7267         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7268         Rename.
7269         (rust_parser::rust_lookup_type)
7270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7271         * printcmd.c (display_command, do_one_display): Update.
7272         * parser-defs.h (struct parser_state) <parser_state>: Add
7273         "tracker" parameter.
7274         (block_tracker): New member.
7275         (class innermost_block_tracker) <innermost_block_tracker>: Add
7276         "types" parameter.
7277         <reset>: Remove method.
7278         (innermost_block): Don't declare.
7279         (null_post_parser): Update.
7280         * parse.c (innermost_block): Remove global.
7281         (write_dollar_variable): Update.
7282         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7283         Remove "tracker_types" parameter.
7284         (parse_expression): Add "tracker" parameter.
7285         (parse_expression_for_completion): Update.
7286         (null_post_parser): Add "tracker" parameter.
7287         * p-exp.y: Update rules.
7288         * m2-exp.y: Update rules.
7289         * language.h (struct language_defn) <la_post_parser>: Add
7290         "tracker" parameter.
7291         * go-exp.y: Update rules.
7292         * f-exp.y: Update rules.
7293         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7294         parameter.
7295         * d-exp.y: Update rules.
7296         * c-exp.y: Update rules.
7297         * breakpoint.c (set_breakpoint_condition): Create an
7298         innermost_block_tracker.
7299         (watch_command_1): Likewise.
7300         * ada-lang.c (resolve): Add "tracker" parameter.
7301         (resolve_subexp): Likewise.
7302         * ada-exp.y (write_var_from_sym): Update.
7303
7304 2019-04-04  Tom Tromey  <tom@tromey.com>
7305
7306         * type-stack.h: New file.
7307         * type-stack.c: New file.
7308         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7309         type-stack.h.
7310         (insert_into_type_stack, insert_type, push_type, push_type_int)
7311         (insert_type_address_space, pop_type, pop_type_int)
7312         (pop_typelist, pop_type_stack, append_type_stack)
7313         (push_type_stack, get_type_stack, push_typelist)
7314         (follow_type_instance_flags, follow_types): Don't declare.
7315         * parse.c (type_stack): Remove global.
7316         (parse_exp_in_context): Update.
7317         (insert_into_type_stack, insert_type, push_type, push_type_int)
7318         (insert_type_address_space, pop_type, pop_type_int)
7319         (pop_typelist, pop_type_stack, append_type_stack)
7320         (push_type_stack, get_type_stack, push_typelist)
7321         (follow_type_instance_flags, follow_types): Remove (moved to
7322         type-stack.c).
7323         * f-exp.y (type_stack): New global.
7324         Update rules.
7325         (push_kind_type, f_parse): Update.
7326         * d-exp.y (type_stack): New global.
7327         Update rules.
7328         (d_parse): Update.
7329         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7330         Update rules.
7331         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7332         (HFILES_NO_SRCDIR): Add type-stack.h.
7333
7334 2019-04-04  Tom Tromey  <tom@tromey.com>
7335
7336         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7337         (rust_parser::convert_ast_to_expression, rust_parse)
7338         (rust_lex_test_completion, rust_lex_tests): Update.
7339         * parser-defs.h (struct expr_completion_state): New.
7340         (struct parser_state) <parser_state>: Add completion parameter.
7341         <mark_struct_expression, mark_completion_tag>: New methods.
7342         <parse_completion, m_completion_state>: New members.
7343         (prefixify_expression, null_post_parser): Update.
7344         (mark_struct_expression, mark_completion_tag): Don't declare.
7345         * parse.c (parse_completion, expout_last_struct)
7346         (expout_tag_completion_type, expout_completion_name): Remove
7347         globals.
7348         (parser_state::mark_struct_expression)
7349         (parser_state::mark_completion_tag): Now methods.
7350         (prefixify_expression): Add last_struct parameter.
7351         (prefixify_subexp): Likewise.
7352         (parse_exp_1): Update.
7353         (parse_exp_in_context): Add cstate parameter.  Update.
7354         (parse_expression_for_completion): Create an
7355         expr_completion_state.
7356         (null_post_parser): Add "completion" parameter.
7357         * p-exp.y: Update rules.
7358         (yylex): Update.
7359         * language.h (struct language_defn) <la_post_parser>: Add
7360         "completing" parameter.
7361         * go-exp.y: Update rules.
7362         (lex_one_token): Update.
7363         * expression.h (parse_completion): Don't declare.
7364         * d-exp.y: Update rules.
7365         (lex_one_token): Update rules.
7366         * c-exp.y: Update rules.
7367         (lex_one_token): Update.
7368         * ada-lang.c (resolve): Add "parse_completion" parameter.
7369         (resolve_subexp): Likewise.
7370         (ada_resolve_function): Likewise.
7371
7372 2019-04-04  Tom Tromey  <tom@tromey.com>
7373
7374         * parser-defs.h (struct parser_state) <start_arglist,
7375         end_arglist>: New methods.
7376         <arglist_len, m_funcall_chain>: New members.
7377         (arglist_len, start_arglist, end_arglist): Don't declare.
7378         * parse.c (arglist_len, funcall_chain): Remove global.
7379         (start_arglist, end_arglist): Remove functions.
7380         (parse_exp_in_context): Update.
7381         * p-exp.y: Update rules.
7382         * m2-exp.y: Update rules.
7383         * go-exp.y: Update rules.
7384         * f-exp.y: Update rules.
7385         * d-exp.y: Update rules.
7386         * c-exp.y: Update rules.
7387
7388 2019-04-04  Tom Tromey  <tom@tromey.com>
7389
7390         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7391         lex_operator, push_back>: New methods.
7392         Update all rules.
7393         (rust_parser::lex_hex, lex_escape): Rename and update.
7394         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7395         (rust_parser::lex_operator): Rename and update.
7396         (rust_parser::lex_number, rustyylex, rustyyerror)
7397         (rust_lex_test_init, rust_lex_test_sequence)
7398         (rust_lex_test_push_back, rust_lex_tests): Update.
7399         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7400         parameter.
7401         <lexptr, prev_lexptr>: New members.
7402         (lexptr, prev_lexptr): Don't declare.
7403         * parse.c (lexptr, prev_lexptr): Remove globals.
7404         (parse_exp_in_context): Update.
7405         * p-exp.y (yylex, yyerror): Update.
7406         * m2-exp.y (parse_number, yylex, yyerror): Update.
7407         * go-exp.y (lex_one_token, yyerror): Update.
7408         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7409         * d-exp.y (lex_one_token, yyerror): Update.
7410         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7411         (lex_one_token, yyerror): Update.
7412         * ada-lex.l (YY_INPUT): Update.
7413         (rewind_to_char): Update.
7414         * ada-exp.y (yyerror): Update.
7415
7416 2019-04-04  Tom Tromey  <tom@tromey.com>
7417
7418         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7419         * parser-defs.h (struct parser_state) <parser_state>: Add new
7420         parameter.
7421         <comma_terminates>: New member.
7422         (comma_terminates): Don't declare global.
7423         * parse.c (comma_terminates): Remove global.
7424         (parse_exp_in_context): Update.
7425         * p-exp.y (yylex): Update.
7426         * m2-exp.y (yylex): Update.
7427         * go-exp.y (lex_one_token): Update.
7428         * f-exp.y (yylex): Update.
7429         * d-exp.y (lex_one_token): Update.
7430         * c-exp.y (lex_one_token): Update.
7431         * ada-lex.l: Update.
7432
7433 2019-04-04  Tom Tromey  <tom@tromey.com>
7434
7435         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7436         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7437         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7438         * parser-defs.h (paren_depth): Don't declare.
7439         * parse.c (paren_depth): Remove global.
7440         (parse_exp_in_context): Update.
7441         * p-exp.y (paren_depth): New global.
7442         (pascal_parse): Initialize it.
7443         * m2-exp.y (paren_depth): New global.
7444         (m2_parse): Initialize it.
7445         * go-exp.y (paren_depth): New global.
7446         (go_parse): Initialize it.
7447         * f-exp.y (paren_depth): New global.
7448         (f_parse): Initialize it.
7449         * d-exp.y (paren_depth): New global.
7450         (d_parse): Initialize it.
7451         * c-exp.y (paren_depth): New global.
7452         (c_parse): Initialize it.
7453         * ada-lex.l (paren_depth): New global.
7454         (lexer_init): Initialize it.
7455
7456 2019-04-04  Tom Tromey  <tom@tromey.com>
7457
7458         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7459         (rust_parser::convert_ast_to_type)
7460         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7461         * parser-defs.h (struct parser_state) <parser_state>: Add
7462         parameters.  Initialize new members.
7463         <expression_context_block, expression_context_pc>: New members.
7464         * parse.c (expression_context_block, expression_context_pc):
7465         Remove globals.
7466         (parse_exp_in_context): Update.
7467         * p-exp.y: Update all rules.
7468         (yylex): Update.
7469         * m2-exp.y: Update all rules.
7470         (yylex): Update.
7471         * go-exp.y (yylex): Update.
7472         * f-exp.y (yylex): Update.
7473         * d-exp.y: Update all rules.
7474         (yylex): Update.
7475         * c-exp.y: Update all rules.
7476         (lex_one_token, classify_name, yylex, c_parse): Update.
7477         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7478
7479 2019-04-04  Tom Tromey  <tom@tromey.com>
7480
7481         * gdbarch.h, gdbarch.c: Rebuild.
7482         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7483         * stap-probe.h:
7484         (struct stap_parse_info): Replace "parser_state" with
7485         "expr_builder".
7486         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7487         (parser_state): New class.
7488         * parse.c (expr_builder): Rename.
7489         (expr_builder::release): Rename.
7490         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7491         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7492         (write_exp_elt_longcst, write_exp_elt_floatcst)
7493         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7494         (write_exp_string_vector, write_exp_bitstring)
7495         (write_exp_msymbol, mark_struct_expression)
7496         (write_dollar_variable)
7497         (insert_type_address_space, increase_expout_size): Replace
7498         "parser_state" with "expr_builder".
7499         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7500         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7501         "parser_state" with "expr_builder".
7502
7503 2019-04-04  Tom Tromey  <tom@tromey.com>
7504
7505         * rust-exp.y: Replace "parse_language" with method call.
7506         * p-exp.y:
7507         (yylex): Replace "parse_language" with method call.
7508         * m2-exp.y:
7509         (yylex): Replace "parse_language" with method call.
7510         * go-exp.y (classify_name): Replace "parse_language" with method
7511         call.
7512         * f-exp.y (yylex): Replace "parse_language" with method call.
7513         * d-exp.y (lex_one_token): Replace "parse_language" with method
7514         call.
7515         * c-exp.y:
7516         (lex_one_token, classify_name, yylex): Replace "parse_language"
7517         with method call.
7518         * ada-exp.y (find_primitive_type, type_char)
7519         (type_system_address): Replace "parse_language" with method call.
7520
7521 2019-04-04  Tom Tromey  <tom@tromey.com>
7522
7523         * rust-exp.y: Replace "parse_gdbarch" with method call.
7524         * parse.c (write_dollar_variable, insert_type_address_space):
7525         Replace "parse_gdbarch" with method call.
7526         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7527         call.
7528         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7529         call.
7530         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7531         "parse_gdbarch" with method call.
7532         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7533         with method call.
7534         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7535         "parse_gdbarch" with method call.
7536         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7537         "parse_gdbarch" with method call.
7538         * c-exp.y (parse_type, parse_number, classify_name): Replace
7539         "parse_gdbarch" with method call.
7540         * ada-lex.l: Replace "parse_gdbarch" with method call.
7541         * ada-exp.y (parse_type, find_primitive_type, type_char)
7542         (type_system_address): Replace "parse_gdbarch" with method call.
7543
7544 2019-04-04  Tom Tromey  <tom@tromey.com>
7545
7546         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7547         * stap-probe.c (stap_parse_argument): Update.
7548         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7549         initial_size parameter.
7550         * rust-exp.y (rust_lex_tests): Update.
7551         * parse.c (parser_state): Update.
7552         (parse_exp_in_context): Update.
7553         * parser-defs.h (struct parser_state) <parser_state>: Remove
7554         "initial_size" parameter.
7555
7556 2019-04-04  Tom Tromey  <tom@tromey.com>
7557
7558         * parser-defs.h (increase_expout_size): Don't declare.
7559         * parse.c (increase_expout_size): Now static.
7560
7561 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7562
7563         * gnu-nat.c (gnu_nat_target::wait): Fix
7564         target_waitstatus_to_string call.
7565
7566 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * eval.c (evaluate_subexp_standard): Handle internal functions
7569         during Fortran function call handling.
7570
7571 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7572
7573         * NEWS: Mention new internal functions.
7574         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7575         (read_base_type): Use dwarf2_init_complex_target_type.
7576         * value.c (creal_internal_fn): New function.
7577         (cimag_internal_fn): New function.
7578         (_initialize_values): Register new internal functions.
7579
7580 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7581
7582         * infrun.c (stop_all_threads): If debug_infrun, always
7583         trace the wait status after wait_one, using
7584         target_waitstatus_to_string and target_pid_to_str.
7585         (handle_inferior_event): Replace various trace of
7586         wait status kind by a single trace.
7587         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7588         wait status kind image by target_waitstatus_to_string.
7589         * target/waitstatus.c (target_waitstatus_to_string): Fix
7590         obsolete comment.
7591
7592 2019-04-01  Tom Tromey  <tromey@adacore.com>
7593
7594         PR symtab/23331:
7595         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7596
7597 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7598             Pedro Alves  <palves@redhat.com>
7599
7600         * top.c (quit_force): Call 'finalize_values'.
7601         * value.c (finalize_values): New function.
7602         * value.h (finalize_values): Declare.
7603
7604 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7605
7606         * NEWS: Announce $_gdb_major and $_gdb_minor.
7607
7608         * top.c (init_gdb_version_vars): New function.
7609         (gdb_init): Call init_gdb_version_vars.
7610
7611 2019-03-29  Tom Tromey  <tromey@adacore.com>
7612
7613         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7614         help text.  Remove dead code.
7615
7616 2019-03-29  Keith Seitz  <keiths@redhat.com>
7617
7618         From Siddhesh Poyarekar:
7619         * f-lang.h (f77_get_upperbound): Return LONGEST.
7620         (f77_get_lowerbound): Likewise.
7621         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7622         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7623         print them.
7624         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7625         plongest to format print it.
7626         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7627         (f77_get_upperbound): Likewise.
7628         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7629         LOWER_BOUND to LONGEST.
7630         (f77_create_arrayprint_offset_tbl): Likewise.
7631
7632 2019-03-29  Keith Seitz  <keiths@redhat.com>
7633
7634         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7635         %s/pulongest for TYPE_LENGTH instead of %d in format
7636         strings.
7637         * ada-typerint.c (ada_print_type): Likewise.
7638         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7639         * compile/compile-c-support.c (generate_register_struct): Likewise.
7640         * gdbtypes.c (recursive_dump_type): Likewise.
7641         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7642         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7643         instead of %d in format strings.
7644         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7645         to std::min to ULONGEST.
7646         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7647         instead of %d in format strings.
7648         * tracepoint.c (info_scope_command): Likewise.
7649         * typeprint.c (print_offset_data::update)
7650         (print_offset_data::finish): Likewise.
7651         * xtensa-tdep.c (xtensa_store_return_value)
7652         (xtensa_push_dummy_call): Likewise.
7653
7654 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7655
7656         * windows-nat.c (display_selector): Fixed format specifications
7657         for 64-bit Cygwin.
7658
7659 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7660
7661         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7662
7663 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7664
7665         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7666         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7667         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7668         (nios2_linux_init_abi): Install it.
7669
7670 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7671
7672         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7673
7674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7675
7676         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7677
7678 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7679             Tom Tromey  <tromey@adacore.com>
7680
7681         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7682
7683 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7684
7685         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7686         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7687         method to compute the bounds of range types. Also print "[evaluated]"
7688         if the bounds' values come from a dynamic evaluation.
7689
7690 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7693         whitespace when pretty printing is on.
7694
7695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * ppc-linux-nat.c: Add include.
7698
7699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7700
7701         * NEWS: Mention AArch64 Pointer Authentication.
7702
7703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7704
7705         * arm-linux-nat.c: Add include.
7706
7707 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7708
7709         * source-cache.c (source_cache::get_source_lines): Re-read
7710         fullname after calling open_source_file.
7711
7712 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7713
7714         * NEWS: Mention TLS support for FreeBSD.
7715
7716 2019-03-25  Tom Tromey  <tromey@adacore.com>
7717
7718         * minsyms.c (BUNCH_SIZE): Update comment.
7719         (~minimal_symbol_reader): Remove old comment.
7720         (compact_minimal_symbols): Update comment.
7721         (minimal_symbol_reader::install): Remove old comment.  Update
7722         other comments.
7723
7724 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7725
7726         * s390-linux-nat.c: Add include.
7727
7728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7729
7730         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7731         Call linux_get_hwcap.
7732         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7733         Likewise.
7734         (aarch64_linux_get_hwcap): Remove function.
7735         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7736         declaration.
7737         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7738         linux_get_hwcap.
7739         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7740         * linux-tdep.c (linux_get_hwcap): Add function.
7741         (linux_get_hwcap2): Likewise.
7742         * linux-tdep.h (linux_get_hwcap): Add declaration.
7743         (linux_get_hwcap2): Likewise.
7744         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7745         (ppc_linux_get_hwcap2): Likewise.
7746         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7747         linux_get_hwcap.
7748         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7749         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7750         (ppc_linux_nat_target::read_description): Likewise.
7751         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7752         * s390-linux-nat.c: Likewise.
7753         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7754
7755 2019-03-24  Tom Tromey  <tom@tromey.com>
7756
7757         * ada-lang.c (standard_lookup): Simplify initialization.
7758         (ada_lookup_symbol_nonlocal): Simplify return.
7759         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7760         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7761         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7762         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7763         initialization.
7764         * solib.c (solib_global_lookup): Simplify.
7765         * symtab.c (null_block_symbol): Remove.
7766         (symbol_cache_lookup): Simplify returns.
7767         (lookup_language_this): Simplify returns.
7768         (lookup_symbol_aux): Simplify return.
7769         (lookup_local_symbol): Simplify returns.
7770         (lookup_global_symbol_from_objfile): Simplify return.
7771         (lookup_symbol_in_objfile_symtabs)
7772         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7773         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7774         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7775         * cp-namespace.c (cp_lookup_bare_symbol)
7776         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7777         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7778         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7779         (cp_lookup_symbol_via_imports): Simplify initialization.
7780         (find_symbol_in_baseclass): Likewise.
7781         * symtab.h (null_block_symbol): Remove.
7782         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7783         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7784         (d_lookup_symbol_module): Likewise.
7785         (find_symbol_in_baseclass): Simplify initialization.
7786
7787 2019-03-24  Tom Tromey  <tom@tromey.com>
7788
7789         * expression.h: Don't include symtab.h.
7790         (struct block): Forward declare.
7791
7792 2019-03-24  Tom Tromey  <tom@tromey.com>
7793
7794         * c-exp.y (typebase): Remove casts.
7795         * gdbtypes.c (lookup_unsigned_typename, )
7796         (lookup_signed_typename): Remove cast.
7797         * eval.c (parse_to_comma_and_eval): Remove cast.
7798         * parse.c (write_dollar_variable): Remove cast.
7799         * block.h (struct block) <superblock>: Now const.
7800         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7801         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7802         (map_block): Make "block" const.
7803         * symfile.h (struct quick_symbol_functions)
7804         <map_matching_symbols>: Constify block argument to "callback".
7805         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7806         const.
7807         (find_pc_sect_compunit_symtab): Make "b" const.
7808         (find_symbol_at_address): Likewise.
7809         (search_symbols): Likewise.
7810         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7811         (dw2_debug_names_lookup_symbol): Likewise.
7812         (dw2_map_matching_symbols): Update.
7813         * p-valprint.c (pascal_val_print): Remove "block".
7814         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7815         (aux_add_nonlocal_symbols): Make "block" const.
7816         (resolve_subexp): Remove cast.
7817         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7818         const.
7819         (iterate_over_file_blocks): Likewise.
7820         * f-exp.y (%union) <bval>: Remove.
7821         * coffread.c (patch_opaque_types): Make "b" const.
7822         * spu-tdep.c (spu_catch_start): Make "block" const.
7823         * c-valprint.c (print_unpacked_pointer): Remove "block".
7824         * symmisc.c (dump_symtab_1): Make "b" const.
7825         (block_depth): Make "block" const.
7826         * d-exp.y (%union) <bval>: Remove.
7827         * cp-support.h (cp_lookup_rtti_type): Update.
7828         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7829         * psymtab.c (psym_lookup_symbol): Make "block" const.
7830         (maintenance_check_psymtabs): Make "b" const.
7831         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7832         (enumerate_locals, enumerate_args): Update.
7833         * python/py-symtab.c (stpy_global_block): Make "block" const.
7834         (stpy_static_block): Likewise.
7835         * inline-frame.c (block_starting_point_at): Make "new_block"
7836         const.
7837         * block.c (find_block_in_blockvector): Make return type const.
7838         (blockvector_for_pc_sect): Make "b" const.
7839         (find_block_in_blockvector): Make "b" const.
7840
7841 2019-03-23  Tom Tromey  <tom@tromey.com>
7842
7843         * varobj.c (varobj_create): Update.
7844         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7845         * printcmd.c (display_command, do_one_display): Don't reset
7846         innermost_block.
7847         * parser-defs.h (enum innermost_block_tracker_type): Move to
7848         expression.h.
7849         (innermost_block): Update comment.
7850         * parse.c (parse_exp_1): Add tracker_types parameter.
7851         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7852         tracker_types parameter.  Reset innermost_block.
7853         (parse_exp_in_context): Remove.
7854         (parse_expression_for_completion): Update.
7855         * objfiles.c (~objfile): Don't reset expression_context_block or
7856         innermost_block.
7857         * expression.h (enum innermost_block_tracker_type): Move from
7858         parser-defs.h.
7859         (parse_exp_1): Add tracker_types parameter.
7860         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7861         reset innermost_block.
7862
7863 2019-03-23  Tom Tromey  <tom@tromey.com>
7864
7865         * objfiles.h: Include bcache.h.
7866
7867 2019-03-23  Tom Tromey  <tom@tromey.com>
7868
7869         * linespec.c (get_current_search_block): Use
7870         scoped_restore_current_language.
7871         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7872
7873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7874             Jiong Wang  <jiong.wang@arm.com>
7875
7876         * aarch64-linux-tdep.c
7877         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7878         section.
7879         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7880
7881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7882             Jiong Wang  <jiong.wang@arm.com>
7883
7884         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7885         instructions.
7886         (aarch64_analyze_prologue_test): Add PACIASP test.
7887         (aarch64_prologue_prev_register): Unmask PC value.
7888
7889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7890             Jiong Wang  <jiong.wang@arm.com>
7891
7892         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7893         (aarch64_dwarf2_prev_register): Unmask PC value.
7894         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7895         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7896         DW_CFA_AARCH64_negate_ra_state.
7897         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7898
7899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7900             Jiong Wang  <jiong.wang@arm.com>
7901
7902         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7903         registers.
7904         (aarch64_pseudo_register_name): Likewise.
7905         (aarch64_pseudo_register_type): Likewise.
7906         (aarch64_pseudo_register_reggroup_p): Likewise.
7907         (aarch64_gdbarch_init): Add pauth registers.
7908         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7909         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7910         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7911         (struct gdbarch_tdep): Add regnum for ra_state.
7912
7913 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7914             Jiong Wang  <jiong.wang@arm.com>
7915
7916         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7917
7918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7919             Jiong Wang  <jiong.wang@arm.com>
7920
7921         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7922         function.
7923         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7924         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7925         (aarch64_gdbarch_init): Add puth registers.
7926         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7927         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7928         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7929
7930 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7931             Jiong Wang  <jiong.wang@arm.com>
7932
7933         * aarch64-linux-nat.c
7934         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7935         * aarch64-linux-tdep.c
7936         (aarch64_linux_core_read_description): Likewise.
7937         (aarch64_linux_get_hwcap): New function.
7938         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7939         (aarch64_linux_get_hwcap): New declaration.
7940
7941 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7942             Jiong Wang  <jiong.wang@arm.com>
7943
7944         * aarch64-linux-nat.c
7945         (aarch64_linux_nat_target::read_description): Add pauth param.
7946         * aarch64-linux-tdep.c
7947         (aarch64_linux_core_read_description): Likewise.
7948         * aarch64-tdep.c (struct target_desc): Add in pauth.
7949         (aarch64_read_description): Add pauth param.
7950         (aarch64_gdbarch_init): Likewise.
7951         * aarch64-tdep.h (aarch64_read_description): Likewise.
7952         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7953         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7954         * features/Makefile: Add new files.
7955         * features/aarch64-pauth.c: New file.
7956         * features/aarch64-pauth.xml: New file.
7957
7958 2019-03-20  Tom Tromey  <tromey@adacore.com>
7959
7960         * infrun.c (handle_inferior_event): Rename from
7961         handle_inferior_event_1.  Create a scoped_value_mark.
7962         (handle_inferior_event): Remove.
7963
7964 2019-03-19  Tom Tromey  <tromey@adacore.com>
7965
7966         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7967         * infrun.h (print_stop_event): Add "displays" parameter.
7968         * infrun.c (print_stop_event): Add "displays" parameter.
7969
7970 2019-03-19  Pedro Alves  <palves@redhat.com>
7971
7972         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7973         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7974         to -1.  Fix TABs vs spaces.
7975         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7976         * tui/tui-out.h (tui_ui_out) Add intro comments.
7977         <m_line, m_start_of_line>: In-class initialize, and add describing
7978         comment.
7979
7980 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7981
7982         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7983         variable names.
7984         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7985
7986 2019-03-18  Pedro Alves  <palves@redhat.com>
7987             Eli Zaretskii <eliz@gnu.org>
7988
7989         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7990         m_line and m_start_of_line.
7991
7992 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7993
7994         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7995         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7996         it returns a newline.  This fixes a regression in TU mode, whereby
7997         the next line is output on the same screen line as the user input.
7998
7999 2019-03-18  Tom Tromey  <tromey@adacore.com>
8000
8001         * minsyms.c (minimal_symbol_reader::install): Remove call to
8002         obstack_blank.
8003
8004 2019-03-18  Pedro Alves  <palves@redhat.com>
8005
8006         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8007         New globals.
8008         (apply_style): New, factored out from ...
8009         (apply_ansi_escape): ... this.  Handle reverse video mode.
8010         (tui_set_reverse_mode): New function.
8011         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8012         * tui/tui-winsource.c (tui_show_source_line): Use
8013         tui_set_reverse_mode instead of setting A_STANDOUT.
8014         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8015         New setter methods.
8016
8017 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8018
8019         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8020         Handle tabs.
8021
8022 2019-03-18  Tom Tromey  <tromey@adacore.com>
8023
8024         * ada-lang.c (empty_array): Add "high" parameter.
8025         (ada_evaluate_subexp): Update.
8026
8027 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8028
8029         * unittests/string_view-selftests.c: Define
8030         _initialize_string_view_selftests unconditionally.
8031
8032 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8033
8034         PR gdb/24350
8035         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8036
8037 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8038
8039         PR gdb/24351
8040         * windows-nat.c (display_selector): Fix format specifiers.
8041
8042 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8043
8044         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8045         tui_refill_source_window instead of tui_refresh_win, to update the
8046         current execution line.  This fixes redisplay of the current line
8047         when stepping through the code with "next" or "step".
8048
8049 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8050
8051         * source-cache.c (source_cache::get_source_lines): Call
8052         find_source_lines to initialize s->nlines.  This fixes vertical
8053         scrolling of TUI source window when the DOWN arrow is pressed.
8054
8055 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8056
8057         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8058         linux-thread-db.c (_initialize_thread_db): Likewise.
8059
8060 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8061
8062         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8063         wclrtoeol in tui_show_source_line".  This reverts changes made in
8064         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8065
8066 2019-03-15  Tom Tromey  <tom@tromey.com>
8067
8068         * symtab.h (struct minimal_symbol): Derive from
8069         general_symbol_info.
8070         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8071         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8072         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8073         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8074         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8075         (MSYMBOL_SEARCH_NAME): Update.
8076         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8077         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8078         * minsyms.c (minimal_symbol_reader::record_full): Update.
8079
8080 2019-03-15  Tom Tromey  <tom@tromey.com>
8081
8082         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8083
8084 2019-03-15  Tom Tromey  <tom@tromey.com>
8085
8086         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8087         unique_xmalloc_ptr.
8088         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8089         Update.
8090         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8091         (build_minimal_symbol_hash_tables)
8092         (minimal_symbol_reader::install): Update.
8093
8094 2019-03-15  Tom Tromey  <tom@tromey.com>
8095
8096         * symtab.c (create_demangled_names_hash): Update.
8097         (symbol_set_names): Update.
8098         * objfiles.h (struct objfile_per_bfd_storage)
8099         <demangled_names_hash>: Now an htab_up.
8100         * objfiles.c (objfile_per_bfd_storage): Simplify.
8101
8102 2019-03-15  Tom Tromey  <tom@tromey.com>
8103
8104         * objfiles.h (struct objfile_per_bfd_storage): Declare
8105         destructor.
8106         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8107         New.
8108         (get_objfile_bfd_data): Use new.  Don't initialize
8109         language_of_main.
8110         (free_objfile_per_bfd_storage): Remove.
8111         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8112
8113 2019-03-15  Tom Tromey  <tom@tromey.com>
8114
8115         * symfile.c (reread_symbols): Update.
8116         * objfiles.c (objfile::objfile): Update.
8117         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8118         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8119         comment.
8120         (minimal_symbol_reader::install): Update.
8121         (terminate_minimal_symbol_table): Remove.
8122         * jit.c (jit_object_close_impl): Update.
8123
8124 2019-03-15  Tom Tromey  <tom@tromey.com>
8125
8126         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8127         initializations.
8128
8129 2019-03-15  Tom Tromey  <tom@tromey.com>
8130
8131         * objfiles.h (struct objfile_per_bfd_storage)
8132         <demangled_hash_languages>: Now a bitset.
8133         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8134         (lookup_minimal_symbol): Update.
8135
8136 2019-03-15  Tom Tromey  <tom@tromey.com>
8137
8138         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8139         Don't return the symbol.
8140         * coffread.c (record_minimal_symbol): Use record_full.
8141
8142 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8143
8144         The MS-Windows port of ncurses fails to switch to a color pair if
8145         one or both of the colors are the implicit default colors.  This
8146         change records the default colors when TUI is initialized, and
8147         then specifies them explicitly when a color pair uses the default
8148         colors.  This allows color styling in TUI mode on MS-Windows.
8149
8150         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8151         ncurses_norm_attr.
8152         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8153         colors in ncurses_norm_attr.
8154         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8155         "none", replace it with the default color recorded in
8156         ncurses_norm_attr.
8157
8158 2019-03-14  Tom Tromey  <tromey@adacore.com>
8159
8160         * source-cache.h (class source_cache) <get_source_lines>: Return
8161         std::string.
8162         * source-cache.c (source_cache::extract_lines): Handle case where
8163         first_pos==npos.  Return std::string.
8164         (source_cache::get_source_lines): Update.
8165
8166 2019-03-14  Tom Tromey  <tromey@adacore.com>
8167
8168         * NEWS: Add item for "style sources" commands.
8169         * source-cache.c (source_cache::get_source_lines): Check
8170         source_styling.
8171         * cli/cli-style.c (source_styling): New global.
8172         (_initialize_cli_style): Add "style sources" commands.
8173         (show_style_sources): New function.
8174         * cli/cli-style.h (source_styling): Declare.
8175
8176 2019-03-14  Pedro Alves  <palves@redhat.com>
8177             Tom Tromey  <tromey@adacore.com>
8178
8179         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8180         * tui/tui-winsource.c (tui_refill_source_window): New function,
8181         from...
8182         (tui_horizontal_source_scroll): ... here.  Move some logic.
8183         * cli/cli-style.c (set_style_enabled): Notify new observable.
8184         * tui/tui-hooks.c (tui_redisplay_source): New function.
8185         (tui_attach_detach_observers): Attach or detach
8186         tui_redisplay_source.
8187         * observable.h (source_styling_changed): New observable.
8188         * observable.c: Define source_styling_changed observable.
8189
8190 2019-03-13  Tom Tromey  <tromey@adacore.com>
8191
8192         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8193         (i386_gnu_nat_target::store_registers): Update.
8194         * target-debug.h (target_debug_print_std_string): New macro.
8195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8196         * windows-tdep.c (display_one_tib): Update.
8197         * tui/tui-stack.c (tui_make_status_line): Update.
8198         * top.c (print_inferior_quit_action): Update.
8199         * thread.c (thr_try_catch_cmd): Update.
8200         (add_thread_with_info): Update.
8201         (thread_target_id_str): Update.
8202         (thr_try_catch_cmd): Update.
8203         (thread_command): Update.
8204         (thread_find_command): Update.
8205         * record-btrace.c (record_btrace_target::info_record)
8206         (record_btrace_resume_thread, record_btrace_target::resume)
8207         (record_btrace_cancel_resume, record_btrace_step_thread)
8208         (record_btrace_target::wait, record_btrace_target::wait)
8209         (record_btrace_target::wait, record_btrace_target::stop): Update.
8210         * progspace.c (print_program_space): Update.
8211         * process-stratum-target.c
8212         (process_stratum_target::thread_address_space): Update.
8213         * linux-fork.c (linux_fork_mourn_inferior)
8214         (detach_checkpoint_command, info_checkpoints_command)
8215         (linux_fork_context): Update.
8216         (linux_fork_detach): Update.
8217         (class scoped_switch_fork_info): Update.
8218         (delete_checkpoint_command): Update.
8219         * infrun.c (follow_fork_inferior): Update.
8220         (follow_fork_inferior): Update.
8221         (proceed_after_vfork_done): Update.
8222         (handle_vfork_child_exec_or_exit): Update.
8223         (follow_exec): Update.
8224         (displaced_step_prepare_throw): Update.
8225         (displaced_step_restore): Update.
8226         (start_step_over): Update.
8227         (resume_1): Update.
8228         (clear_proceed_status_thread): Update.
8229         (proceed): Update.
8230         (print_target_wait_results): Update.
8231         (do_target_wait): Update.
8232         (context_switch): Update.
8233         (stop_all_threads): Update.
8234         (restart_threads): Update.
8235         (finish_step_over): Update.
8236         (handle_signal_stop): Update.
8237         (switch_back_to_stepped_thread): Update.
8238         (keep_going_pass_signal): Update.
8239         (print_exited_reason): Update.
8240         (normal_stop): Update.
8241         * inferior.c (inferior_pid_to_str): Change return type.
8242         (print_selected_inferior): Update.
8243         (add_inferior): Update.
8244         (detach_inferior): Update.
8245         * dummy-frame.c (fprint_dummy_frames): Update.
8246         * dcache.c (dcache_info_1): Update.
8247         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8248         (btrace_fetch, btrace_clear): Update.
8249         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8250         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8251         type.
8252         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8253         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8254         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8255         * gdbarch.c, gdbarch.h: Rebuild.
8256         * gdbarch.sh (core_pid_to_str): Change return type.
8257         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8258         return type.
8259         (windows_nat_target::pid_to_str): Change return type.
8260         (windows_delete_thread): Update.
8261         (windows_nat_target::attach): Update.
8262         (windows_nat_target::files_info): Update.
8263         * target-delegates.c: Rebuild.
8264         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8265         return type.
8266         (sol_thread_target::pid_to_str): Change return type.
8267         * remote.c (class remote_target) <pid_to_str>: Change return
8268         type.
8269         (remote_target::pid_to_str): Change return type.
8270         (extended_remote_target::attach, remote_target::remote_stop_ns)
8271         (remote_target::remote_notif_remove_queued_reply)
8272         (remote_target::push_stop_reply, remote_target::disable_btrace):
8273         Update.
8274         (extended_remote_target::attach): Update.
8275         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8276         type.
8277         (gdbsim_target::pid_to_str): Change return type.
8278         * ravenscar-thread.c (struct ravenscar_thread_target)
8279         <pid_to_str>: Change return type.
8280         (ravenscar_thread_target::pid_to_str): Change return type.
8281         * procfs.c (class procfs_target) <pid_to_str>: Change return
8282         type.
8283         (procfs_target::pid_to_str): Change return type.
8284         (procfs_target::attach): Update.
8285         (procfs_target::detach): Update.
8286         (procfs_target::fetch_registers): Update.
8287         (procfs_target::store_registers): Update.
8288         (procfs_target::wait): Update.
8289         (procfs_target::files_info): Update.
8290         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8291         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8292         return type.
8293         (nto_procfs_target::pid_to_str): Change return type.
8294         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8295         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8296         return type.
8297         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8298         (exit_lwp): Update.
8299         (attach_proc_task_lwp_callback, get_detach_signal)
8300         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8301         (linux_nat_target::resume, wait_lwp, stop_callback)
8302         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8303         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8304         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8305         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8306         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8307         type.
8308         (inf_ptrace_target::attach): Update.
8309         (inf_ptrace_target::files_info): Update.
8310         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8311         type.
8312         (go32_nat_target::pid_to_str): Change return type.
8313         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8314         (gnu_nat_target::wait): Update.
8315         (gnu_nat_target::wait): Update.
8316         (gnu_nat_target::resume): Update.
8317         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8318         (fbsd_nat_target::wait): Update.
8319         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8320         type.
8321         (darwin_nat_target::attach): Update.
8322         * corelow.c (class core_target) <pid_to_str>: Change return type.
8323         (core_target::pid_to_str): Change return type.
8324         * target.c (normal_pid_to_str): Change return type.
8325         (default_pid_to_str): Likewise.
8326         (target_pid_to_str): Change return type.
8327         (target_translate_tls_address): Update.
8328         (target_announce_detach): Update.
8329         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8330         return type.
8331         (bsd_uthread_target::pid_to_str): Change return type.
8332         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8333         type.
8334         (bsd_kvm_target::pid_to_str): Change return type.
8335         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8336         return type.
8337         (aix_thread_target::pid_to_str): Change return type.
8338         * target.h (struct target_ops) <pid_to_str>: Change return type.
8339         (target_pid_to_str, normal_pid_to_str): Likewise.
8340         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8341         type.
8342         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8343         type.
8344         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8345         return type.
8346         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8347         type.
8348         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8349         type.
8350         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8351         return type.
8352
8353 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8354
8355         * NEWS: Mention that the new default MI version is 3.  Mention
8356         changes to the output of commands and events that deal with
8357         multi-location breakpoints.
8358         * breakpoint.c: Include "mi/mi-out.h".
8359         (print_one_breakpoint): Change output syntax if using MI version
8360         >= 3.
8361         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8362         New.
8363         (mi_multi_location_breakpoint_output_fixed): New.
8364         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8365         (mi_cmd_fix_multi_location_breakpoint_output): New.
8366         (mi_multi_location_breakpoint_output_fixed): New.
8367         * mi/mi-cmds.c (mi_cmds): Register command
8368         -fix-multi-location-breakpoint-output.
8369         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8370         interpreter "mi".
8371
8372 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8373
8374         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8375         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8376         instantiate mi_ui_out based on interpreter name.
8377         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8378         * mi/mi-main.c (mi_load_progress): Likewise.
8379
8380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8381
8382         * NEWS: Combine separate "New targets" sections for 8.3.
8383
8384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8385
8386         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8387         (ppcfbsd_init_abi): Install gdbarch
8388         "fetch_tls_load_module_address" and "get_thread_local_address"
8389         methods.
8390
8391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8392
8393         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8394         (riscv_fbsd_init_abi): Install gdbarch
8395         "fetch_tls_load_module_address" and "get_thread_local_address"
8396         methods.
8397
8398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8399
8400         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8401         (i386fbsd_init_abi): Install gdbarch
8402         "fetch_tls_load_module_address" and "get_thread_local_address"
8403         methods.
8404
8405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8406
8407         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8408         (amd64fbsd_init_abi): Install gdbarch
8409         "fetch_tls_load_module_address" and "get_thread_local_address"
8410         methods.
8411
8412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8413
8414         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8415         (struct fbsd_pspace_data): New type.
8416         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8417         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8418         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8419         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8420         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8421
8422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8423
8424         * gdbtypes.c (lookup_struct_elt): New function.
8425         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8426         * gdbtypes.h (struct struct_elt): New type.
8427         (lookup_struct_elt): New prototype.
8428
8429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8430
8431         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8432         remove disabled code block.
8433
8434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8435
8436         * gdbarch.sh (get_thread_local_address): New method.
8437         * gdbarch.h, gdbarch.c: Regenerate.
8438         * target.c (target_translate_tls_address): Use
8439         gdbarch_get_thread_local_address if present instead of
8440         target::get_thread_local_address.
8441
8442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8443
8444         * target.h (target::get_thread_local_address): Update comment.
8445
8446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8447
8448         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8449         objfile->separate_debug_objfile_backlink if not NULL.
8450
8451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8452
8453         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8454         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8455         (amd64bsd_store_inferior_registers): Likewise.
8456         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8457         Enable segment base registers.
8458         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8459         PT_GETFSBASE and PT_GETGSBASE.
8460         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8461         PT_SETGSBASE.
8462         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8463         segment base registers.
8464         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8465
8466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8467
8468         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8469         Update calls to i386_target_description to add 'segments'
8470         parameter.
8471         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8472         add segment base registers.
8473         * arch/i386.c (i386_create_target_description): Add 'segments'
8474         parameter to enable segment base registers.
8475         * arch/i386.h (i386_create_target_description): Likewise.
8476         * features/i386/32bit-segments.xml: New file.
8477         * features/i386/32bit-segments.c: Generate.
8478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8479         call to i386_target_description to add 'segments' parameter.
8480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8481         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8482         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8483         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8484         if feature is present.
8485         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8486         Add 'segments' parameter to call to i386_target_description.
8487         (i386_target_description): Add 'segments' parameter to enable
8488         segment base registers.
8489         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8490         to call to i386_target_description.
8491         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8492         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8493         Define I386_NUM_REGS.
8494         (i386_target_description): Add 'segments' parameter to enable
8495         segment base registers.
8496
8497 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8498
8499         PR/24325
8500         * source-cache.c: #undef open and close, to avoid unresolved
8501         externals during linking.
8502
8503 2019-03-12  Tom Tromey  <tromey@adacore.com>
8504
8505         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8506         const.  Add initializers.
8507         (_initialize_remote): Don't initialize ptid globals.
8508
8509 2019-03-12  Pedro Alves  <palves@redhat.com>
8510
8511         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8512
8513 2019-03-12  Pedro Alves  <palves@redhat.com>
8514
8515         * cp-name-parser.y (main): Remove unused 'len' variable.
8516
8517 2019-03-12  Tom Tromey  <tromey@adacore.com>
8518
8519         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8520         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8521
8522 2019-03-12  Tom Tromey  <tromey@adacore.com>
8523
8524         * linux-nat.c (iterate_over_lwps): Update.
8525         (stop_callback): Remove parameter.
8526         (stop_wait_callback, detach_callback, resume_set_callback)
8527         (select_singlestep_lwp_callback, set_ignore_sigint)
8528         (status_callback, resumed_callback, resume_clear_callback)
8529         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8530         data parameter.
8531         (linux_nat_target::detach, linux_nat_target::resume)
8532         (linux_stop_and_wait_all_lwps, select_event_lwp)
8533         (linux_nat_filter_event, linux_nat_wait_1)
8534         (linux_nat_target::kill, linux_nat_target::stop)
8535         (linux_nat_target::stop): Update.
8536         (linux_nat_resume_callback): Change type.
8537         (resume_stopped_resumed_lwps, count_events_callback)
8538         (select_event_lwp_callback): Likewise.
8539         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8540         * arm-linux-nat.c (struct update_registers_data): Remove.
8541         (update_registers_callback): Change type.
8542         (arm_linux_insert_hw_breakpoint1): Update.
8543         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8544         parameter.
8545         (x86_linux_dr_set_addr): Update.
8546         (x86_linux_dr_set_control): Update.
8547         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8548         (iterate_over_lwps): Use gdb::function_view.
8549         * nat/aarch64-linux-hw-point.c (struct
8550         aarch64_dr_update_callback_param): Remove.
8551         (debug_reg_change_callback): Change type.
8552         (aarch64_notify_debug_reg_change): Update.
8553         * s390-linux-nat.c (s390_refresh_per_info): Update.
8554
8555 2019-03-11  Tom Tromey  <tromey@adacore.com>
8556
8557         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8558         redundant assignment to "this_cu".
8559
8560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8561
8562         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8563
8564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8565
8566         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8567         from...
8568         (rank_one_type): ... this.
8569
8570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8571
8572         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8573         from...
8574         (rank_one_type): ... this.
8575
8576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8577
8578         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8579         from...
8580         (rank_one_type): ... this.
8581
8582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8583
8584         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8585         from...
8586         (rank_one_type): ... this.
8587
8588 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8589
8590         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8591         from...
8592         (rank_one_type): ... this.
8593
8594 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8595
8596         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8597         from...
8598         (rank_one_type): ... this.
8599
8600 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8601
8602         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8603         from...
8604         (rank_one_type): ... this.
8605
8606 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8607
8608         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8609         from...
8610         (rank_one_type): ... this.
8611
8612 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8613
8614         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8615         from...
8616         (rank_one_type): ... this.
8617
8618 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8619
8620         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8621         from...
8622         (rank_one_type): ... this.
8623
8624 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8625
8626         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8627         from...
8628         (rank_one_type): ... this.
8629
8630 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8631
8632         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8633         from...
8634         (rank_one_type): ... this.
8635
8636 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8637
8638         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8639         inferior-events' shows the example events.
8640
8641 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8642
8643         Support styling on native MS-Windows console
8644
8645         PR/24315
8646         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8647         on MS-Windows if $TERM is not defined.
8648
8649         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8650
8651         * posix-hdep.c (gdb_console_fputs):
8652         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8653         functions.
8654         * ui-file.h (gdb_console_fputs): Add prototype.
8655
8656         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8657         back to fputs only if the former returns zero.
8658
8659 2019-03-07  Tom Tromey  <tom@tromey.com>
8660
8661         * symmisc.c (print_symbol_bcache_statistics): Update.
8662         (print_objfile_statistics): Update.
8663         * symfile.c (allocate_symtab): Update.
8664         * stabsread.c: Don't include bcache.h.
8665         * psymtab.h (struct psymbol_bcache): Don't declare.
8666         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8667         (psymbol_bcache_init, psymbol_bcache_free)
8668         (psymbol_bcache_get_bcache): Don't declare.
8669         * psymtab.c (struct psymbol_bcache): Remove.
8670         (psymtab_storage::psymtab_storage): Update.
8671         (psymtab_storage::~psymtab_storage): Update.
8672         (psymbol_bcache_init, psymbol_bcache_free)
8673         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8674         (add_psymbol_to_bcache): Update.
8675         (allocate_psymtab): Update.
8676         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8677         macro_cache>: No longer pointers.
8678         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8679         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8680         * macrotab.c (macro_bcache): Update.
8681         * macroexp.c: Don't include bcache.h.
8682         * gdbtypes.c (check_types_worklist): Update.
8683         (types_deeply_equal): Remove TRY/CATCH.  Update.
8684         * elfread.c (elf_symtab_read): Update.
8685         * dwarf2read.c: Don't include bcache.h.
8686         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8687         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8688         (print_bcache_statistics, bcache_memory_used): Don't declare.
8689         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8690         methods.  Rename all data members.
8691         * bcache.c (struct bcache): Move to bcache.h.
8692         (bcache::expand_hash_table): Rename from expand_hash_table.
8693         (bcache): Remove.
8694         (bcache::insert): Rename from bcache_full.
8695         (bcache::compare): Rename from bcache_compare.
8696         (bcache_xmalloc): Remove.
8697         (bcache::~bcache): Rename from bcache_xfree.
8698         (bcache::print_statistics): Rename from print_bcache_statistics.
8699         (bcache::memory_used): Rename from bcache_memory_used.
8700
8701 2019-03-07  Pedro Alves  <palves@redhat.com>
8702
8703         * infrun.c (normal_stop): Also check for
8704         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8705
8706 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8707
8708         * f-lang.c (value_from_host_double): Moved to...
8709         * value.c (value_from_host_double): ...here.
8710         * value.h (value_from_host_double): Declare.
8711         * guile/scm-math.c (vlscm_convert_typed_number): Use
8712         value_from_host_double.
8713         (vlscm_convert_number): Likewise.
8714         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8715         * python/py-value.c (convert_value_from_python): Likewise.
8716
8717 2019-03-06  Tom Tromey  <tom@tromey.com>
8718
8719         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8720
8721 2019-03-06  Tom Tromey  <tom@tromey.com>
8722
8723         * utils.h (free_current_contents): Don't declare.
8724         * utils.c (free_current_contents): Remove.
8725
8726 2019-03-06  Tom Tromey  <tom@tromey.com>
8727
8728         * top.c (quit_force): Update.
8729         * main.c (captured_command_loop): Update.
8730         * common/new-op.c (operator new): Update.
8731         * common/common-exceptions.c (struct catcher)
8732         <save_cleanup_chain>: Remove member.
8733         (exceptions_state_mc_init): Update.
8734         (exception_try_scope_entry): Return nullptr.
8735         (exception_try_scope_exit, exception_rethrow)
8736         (throw_exception_sjlj, throw_exception_cxx): Update.
8737         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8738         (all_cleanups, do_cleanups, discard_cleanups)
8739         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8740         (restore_cleanups, restore_final_cleanups): Don't declare.
8741         (do_final_cleanups): Remove parameter.
8742         * common/cleanups.c (cleanup_chain, make_cleanup)
8743         (make_cleanup_dtor, all_cleanups, do_cleanups)
8744         (discard_my_cleanups, discard_cleanups)
8745         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8746         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8747         (null_cleanup): Remove.
8748         (do_final_cleanups): Remove parameter.
8749
8750 2019-03-06  Tom Tromey  <tom@tromey.com>
8751
8752         * remote.c (remote_target::remote_parse_stop_reply): Use
8753         unique_xmalloc_ptr.
8754
8755 2019-03-06  Tom Tromey  <tom@tromey.com>
8756
8757         * stabsread.c (struct stabs_field_info): Rename from field_info.
8758         <list, fnlist>: Add initializers.
8759         <obstack>: New member.
8760         (read_member_functions, read_struct_fields, read_baseclasses):
8761         Allocate on obstack.  Don't use cleanups.
8762         (read_one_struct_field, read_member_functions, read_struct_fields)
8763         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8764         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8765         (read_struct_type): Update.
8766
8767 2019-03-06  Tom Tromey  <tom@tromey.com>
8768
8769         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8770         * common/filestuff.h (make_cleanup_close): Don't declare.
8771         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8772         Remove.
8773
8774 2019-03-06  Tom Tromey  <tom@tromey.com>
8775
8776         * solib-aix.c: Use make_scope_exit.
8777
8778 2019-03-06  Tom Tromey  <tom@tromey.com>
8779
8780         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8781         Use make_scope_exit.
8782
8783 2019-03-06  Tom Tromey  <tom@tromey.com>
8784
8785         * solib-svr4.c (disable_probes_interface): Remove parameter.
8786         (svr4_handle_solib_event): Use make_scope_exit.
8787
8788 2019-03-06  Tom Tromey  <tom@tromey.com>
8789
8790         * remote.c (struct stop_reply_deleter): Remove.
8791         (stop_reply_up): Update.
8792         (struct stop_reply): Derive from notif_event.  Don't typedef.
8793         <regcache>: Now a std::vector.
8794         (stop_reply_xfree): Remove.
8795         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8796         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8797         (remote_target::discard_pending_stop_replies): Use delete.
8798         (remote_target::remote_parse_stop_reply): Update.
8799         (remote_target::process_stop_reply): Update.
8800         * remote-notif.h (struct notif_event): Add virtual destructor.
8801         Remove "dtr" member.
8802         (struct notif_client) <alloc_event>: Return a unique_ptr.
8803         (notif_event_xfree): Don't declare.
8804         (notif_event_up): New typedef.
8805         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8806         (notif_event_xfree, do_notif_event_xfree): Remove.
8807         (remote_notif_state_xfree): Update.
8808
8809 2019-03-06  Tom Tromey  <tom@tromey.com>
8810
8811         * infrun.c (displaced_step_clear_cleanup): Now a
8812         forward_scope_exit type.
8813         (displaced_step_prepare_throw): Update.
8814         (displaced_step_fixup): Update.
8815
8816 2019-03-06  Tom Tromey  <tom@tromey.com>
8817
8818         * inferior.h (class inferior): Update comment.
8819         * gdbthread.h (class thread_info): Update comment.
8820
8821 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8822             Tom Tromey  <tom@tromey.com>
8823
8824         * stabsread.h (struct stab_section_list): Remove.
8825         (coffstab_build_psymtabs): Update.
8826         * dbxread.c (symbuf_sections): Now a std::vector.
8827         (sect_idx): New global.
8828         (fill_symbuf): Update.
8829         (coffstab_build_psymtabs): Change type of stabsects parameter.
8830         Update.
8831         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8832         std::vector.
8833         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8834         (coff_locate_sections): Update.
8835         (coff_symfile_read): Remove cleanups.  Update.
8836         (init_stringtab): Add storage parameter.
8837         (free_stringtab, free_stringtab_cleanup): Remove.
8838         (init_lineno): Add storage parameter.
8839         (free_linetab, free_linetab_cleanup): Remove.
8840
8841 2019-03-06  Pedro Alves  <palves@redhat.com>
8842
8843         * linux-fork.c (fork_info::clobber_regs): Delete.
8844         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8845         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8846         comment.  Adjust.
8847         (scoped_switch_fork_info::scoped_switch_fork_info)
8848         (checkpoint_command, linux_fork_context): Adjust
8849         fork_save_infrun_state calls.
8850
8851 2019-03-06  Pedro Alves  <palves@redhat.com>
8852
8853         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8854         (inf_has_multiple_threads): Return 'bool' and rewrite using
8855         inferior_info::threads().
8856
8857 2019-03-06  Pedro Alves  <palves@redhat.com>
8858
8859         * linux-fork.c: Include <list>.
8860         (fork_list): Now a std::list instance.
8861         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8862         (forks_exist_p, find_last_fork): Adjust.
8863         (new_fork): Delete.
8864         (one_fork_p): New.
8865         (add_fork): Adjust.
8866         (free_fork): Delete, folded into fork_info::~fork_info().
8867         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8868         Adjust.
8869         (init_fork_list): Delete.
8870         (linux_fork_killall, linux_fork_mourn_inferior)
8871         (linux_fork_detach, info_checkpoints_command): Adjust.
8872         (_initialize_linux_fork): No longer call init_fork_list.
8873
8874 2019-03-06  Pedro Alves  <palves@redhat.com>
8875
8876         * linux-fork.c (new_fork): New, split out of ...
8877         (add_fork): ... this.  Return void.  Move "first fork" special
8878         case from here, to ...
8879         (checkpoint_command): ... here.
8880         * linux-linux.h (add_fork): Return void.
8881
8882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8885
8886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8887             Chris January  <chris.january@arm.com>
8888             David Lecomber  <david.lecomber@arm.com>
8889
8890         * f-exp.y: New token, UNOP_INTRINSIC.
8891         (exp): New pattern using UNOP_INTRINSIC token.
8892         (f77_keywords): Add 'abs' keyword.
8893         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8894         (value_from_host_double): New function.
8895         (evaluate_subexp_f): Support UNOP_ABS.
8896
8897 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8900         types.
8901
8902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8905         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8906         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8907
8908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8909
8910         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8911
8912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8913             Chris January  <chris.january@arm.com>
8914
8915         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8916         * f-exp.y: Define 'KIND' token.
8917         (exp): New pattern for KIND expressions.
8918         (ptype): Handle types with a kind extension.
8919         (direct_abs_decl): Extend to spot kind extensions.
8920         (f77_keywords): Add 'kind' to the list.
8921         (push_kind_type): New function.
8922         (convert_to_kind_type): New function.
8923         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8924         * parse.c (operator_length_standard): Likewise.
8925         * parser-defs.h (enum type_pieces): Add tp_kind.
8926         * std-operator.def: Add UNOP_KIND.
8927
8928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8929
8930         * f-exp.y (f_parse): Set yydebug.
8931
8932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * f-lang.c (evaluate_subexp_f): New function.
8935         (exp_descriptor_f): New global.
8936         (f_language_defn): Use exp_descriptor_f instead of
8937         exp_descriptor_standard.
8938
8939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8940
8941         * f-exp.y (struct token): Add comments.
8942         (dot_ops): Remove uppercase versions and the end marker.
8943         (f77_keywords): Likewise.
8944         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8945         entries in the dot_ops array are case insensitive, and use
8946         strncasecmp to compare strings.  Also some whitespace cleanup in
8947         this area.  Similar for the f77_keywords array, except entries in
8948         this list might be case sensitive.
8949
8950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8951
8952         * f-exp.y (struct f77_boolean_val): Add comments.
8953         (boolean_values): Remove uppercase versions, and end marker.
8954         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8955         and use strncasecmp to achieve case insensitivity.  Additionally,
8956         perform whitespace cleanup around this code.
8957
8958 2019-03-06  Tom Tromey  <tromey@adacore.com>
8959
8960         * remote-sim.c (gdbsim_target_open): Use result of
8961         gdb_argv::release.
8962
8963 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8964         Dirk Schubert  <dirk.schubert@arm.com>
8965         Chris January  <chris.january@arm.com>
8966
8967         * eval.c (evaluate_subexp_standard): Call Fortran argument
8968         wrapping logic.
8969         * f-lang.c (struct value): A value which can be passed into a
8970         Fortran function call.
8971         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8972         where appropriate.
8973         (struct type): Value ready for a Fortran function call.
8974         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8975         is needed.
8976         * f-lang.h (fortran_argument_convert): Declaration.
8977         (fortran_preserve_arg_pointer): Declaration.
8978         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8979
8980 2019-03-05  Tom Tromey  <tromey@adacore.com>
8981
8982         * python/py-prettyprint.c (print_string_repr): Remove #if.
8983         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8984
8985 2019-03-05  Tom Tromey  <tromey@adacore.com>
8986
8987         * target.c (the_dummy_target): Move later.  Change type to
8988         "dummy_target".
8989         (initialize_targets): Don't initialize the_dummy_target.
8990
8991 2019-03-05  Tom Tromey  <tromey@adacore.com>
8992
8993         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8994         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8995
8996 2019-03-05  Tom Tromey  <tromey@adacore.com>
8997
8998         * windows-nat.c (windows_nat_target::attach)
8999         (windows_nat_target::detach): Don't call gdb_flush.
9000         * valprint.c (generic_val_print, val_print, val_print_string):
9001         Don't call gdb_flush.
9002         * utils.c (defaulted_query): Don't call gdb_flush.
9003         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9004         * target.c (target_announce_detach): Don't call gdb_flush.
9005         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9006         * remote.c (extended_remote_target::attach): Don't call
9007         gdb_flush.
9008         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9009         * printcmd.c (do_examine): Don't call gdb_flush.
9010         (info_display_command): Don't call gdb_flush.
9011         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9012         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9013         * memattr.c (info_mem_command): Don't call gdb_flush.
9014         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9015         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9016         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9017         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9018         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9019         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9020         (gnu_nat_target::detach): Don't call gdb_flush.
9021         * f-valprint.c (f_val_print): Don't call gdb_flush.
9022         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9023         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9024         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9025         gdb_flush.
9026         * c-valprint.c (c_val_print): Don't call gdb_flush.
9027         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9028
9029 2019-03-05  Tom Tromey  <tromey@adacore.com>
9030
9031         * varobj.c (update_dynamic_varobj_children): Update.
9032         (install_default_visualizer): Use reset, not release.
9033         * value.c (set_internalvar): Update.
9034         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9035         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9036         ATTRIBUTE_UNUSED_RESULT.
9037
9038 2019-03-05  Tom Tromey  <tromey@adacore.com>
9039
9040         * remote.c (class scoped_remote_fd) <release>: Add
9041         ATTRIBUTE_UNUSED_RESULT.
9042
9043 2019-03-05  Tom Tromey  <tromey@adacore.com>
9044
9045         * macroexp.c (struct macro_buffer) <release>: Add
9046         ATTRIBUTE_UNUSED_RESULT.
9047
9048 2019-03-05  Tom Tromey  <tromey@adacore.com>
9049
9050         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9051         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9052         ATTRIBUTE_UNUSED_RESULT.
9053
9054 2019-03-05  Tom Tromey  <tromey@adacore.com>
9055
9056         * common/scoped_fd.h (class scoped_fd) <release>: Add
9057         ATTRIBUTE_UNUSED_RESULT.
9058
9059 2019-03-05  Tom Tromey  <tromey@adacore.com>
9060
9061         * parser-defs.h (struct parser_state) <release>: Add
9062         ATTRIBUTE_UNUSED_RESULT.
9063
9064 2019-03-05  Tom Tromey  <tromey@adacore.com>
9065
9066         * utils.h (class gdb_argv) <release>: Add
9067         ATTRIBUTE_UNUSED_RESULT.
9068         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9069
9070 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9071
9072         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9073         for-loop range, to avoid compiler warnings.
9074
9075         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9076         avoid compiler warnings about unused variables.
9077
9078         * NEWS: Mention end of support for native debugging on MS-Windows
9079         before XP.
9080
9081         PR gdb/24292
9082         * common/netstuff.c:
9083         * gdbserver/gdbreplay.c
9084         * gdbserver/remote-utils.c:
9085         * ser-tcp.c:
9086         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9087         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9088         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9089         'getaddrinfo' and 'freeaddrinfo' were not available before
9090         Windows XP, and mingw.org's MinGW headers by default define
9091         _WIN32_WINNT to 0x500.
9092
9093 2019-03-01  Gary Benson <gbenson@redhat.com>
9094
9095         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9096
9097 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9098             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9099
9100         PR gdb/8527
9101         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9102         set_sigint_trap, clear_sigint_trap.
9103
9104 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9105
9106         * target.c (target_detach): Clear the regcache and the
9107         frame cache.
9108
9109 2019-02-27  Pedro Alves  <palves@redhat.com>
9110
9111         * utils.c (set_screen_size): When we cap the height/width sizes,
9112         tweak the corresponding command variable to show "unlimited":
9113
9114 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9115             Pedro Alves  <palves@redhat.com>
9116
9117         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9118         before calling rl_set_screen_size.
9119
9120 2019-02-27  Tom Tromey  <tromey@adacore.com>
9121
9122         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9123         define.
9124         * python/py-value.c: Remove Python 2.4 workaround.
9125         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9126         workaround.
9127         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9128         Python 2.4 workaround.
9129         * python/python-internal.h: Remove Python 2.4 comment.
9130         (Py_ssize_t): Don't define.
9131         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9132         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9133         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9134         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9135         * python/python.c (do_start_initialization): Remove Python 2.4
9136         workaround.
9137         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9138         (print_children): Remove Python 2.4 workaround.
9139         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9140         workaround.
9141         (CHARBUFFERPROC_NAME): Remove.
9142         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9143         Python 2.4 workaround.
9144
9145 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9146
9147         * NEWS: Note minimum Python version.
9148
9149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9150
9151         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9152         code from these functions.  Remove corresponding ifdefs.  Use
9153         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9154         Remove gotos and target of gotos.
9155         (infpy_search_memory): Likewise.
9156
9157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9158
9159         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9160         (hppa_gdbarch_init): Don't register deleted functions with
9161         gdbarch.
9162
9163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9166         (h8300_unwind_sp): Delete.
9167         (h8300_dummy_id): Delete.
9168         (h8300_gdbarch_init): Don't register deleted functions with
9169         gdbarch.
9170
9171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9174         (ft32_unwind_pc): Delete.
9175         (ft32_unwind_sp): Delete.
9176         (ft32_gdbarch_init): Don't register deleted functions with
9177         gdbarch.
9178
9179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9182         (frv_unwind_pc): Delete.
9183         (frv_unwind_sp): Delete.
9184         (frv_gdbarch_init): Don't register deleted functions with
9185         gdbarch.
9186
9187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9188
9189         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9190         (riscv_unwind_pc): Delete.
9191         (riscv_unwind_sp): Delete.
9192         (riscv_gdbarch_init): Don't register deleted functions with
9193         gdbarch.
9194
9195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9198         (csky_unwind_pc): Delete.
9199         (csky_unwind_sp): Delete.
9200         (csky_gdbarch_init): Don't register deleted functions with
9201         gdbarch.
9202
9203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9206         (cris_unwind_pc): Delete.
9207         (cris_unwind_sp): Delete.
9208         (cris_gdbarch_init): Don't register deleted functions with
9209         gdbarch.
9210
9211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9212
9213         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9214         (bfin_unwind_pc): Delete.
9215         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9216
9217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9220         (arm_unwind_pc): Delete.
9221         (arm_unwind_sp): Delete.
9222         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9223
9224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9227         (arc_unwind_pc): Delete.
9228         (arc_unwind_sp): Delete.
9229         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9230
9231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9234         (alpha_unwind_pc): Delete.
9235         (alpha_gdbarch_init): Don't register deleted functions with
9236         gdbarch.
9237
9238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9241         (aarch64_unwind_pc): Delete.
9242         (aarch64_unwind_sp): Delete.
9243         (aarch64_gdbarch_init): Don't register deleted functions with
9244         gdbarch.
9245
9246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * gdbtypes.c (type_align): Don't consider static members when
9249         computing structure alignment.
9250
9251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9254         return 0 for other types.
9255         * arch-utils.c (default_type_align): Always return 0.
9256         * gdbarch.h: Regenerate.
9257         * gdbarch.sh (type_align): Extend comment.
9258         * gdbtypes.c (type_align): Add additional comments, always call
9259         gdbarch_type_align before applying the default rules.
9260         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9261         generic code will then apply a suitable default.
9262         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9263         types, return 0 for other types.
9264
9265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9266
9267         * NEWS: Create a new section for the next release branch.
9268         Rename the section of the current branch, now that it has
9269         been cut.
9270
9271 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9272
9273         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9274         * version.in: Bump version to 8.3.50.DATE-git.
9275
9276 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9277
9278         * aix-thread.c (ptid_cmp): Remove unused variable.
9279         (get_signaled_thread): Likewise.
9280         (store_regs_user_thread): Likewise.
9281         (store_regs_kernel_thread): Likewise.
9282         (fetch_regs_kernel_thread): Remove shadowed variable.
9283
9284 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * features/riscv/32bit-cpu.xml: Add register numbers.
9287         * features/riscv/32bit-fpu.c: Regenerate.
9288         * features/riscv/32bit-fpu.xml: Add register numbers.
9289         * features/riscv/64bit-cpu.xml: Add register numbers.
9290         * features/riscv/64bit-fpu.c: Regenerate.
9291         * features/riscv/64bit-fpu.xml: Add register numbers.
9292
9293 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9294
9295         * NEWS: Mention two argument form of gdb.Value constructor.
9296         * python/py-value.c (convert_buffer_and_type_to_value): New
9297         function.
9298         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9299         Add support for handling an optional second argument.  Call
9300         convert_buffer_and_type_to_value as appropriate.
9301         * python/python-internal.h (Py_buffer_deleter): New struct.
9302         (Py_buffer_up): New typedef.
9303
9304 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9305
9306         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9307         instead of releasing ownership.
9308
9309 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9310
9311         * dwarf2read.c (open_and_init_dwp_file): Call
9312         elf_numsections instead of bfd_count_sections to initialize
9313         dwp_file->num_sections.
9314
9315 2019-02-25  Tom Tromey  <tromey@adacore.com>
9316
9317         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9318
9319 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9320
9321         * gcore.in: Add '--readnever' option when invoking GDB.
9322
9323 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9324
9325         * MAINTAINERS: Update my email address.
9326
9327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9328
9329         * build-id.c (build_id_to_debug_bfd_1): New function.
9330         (build_id_to_debug_bfd): Look for separate debug file in
9331         sysroot.
9332
9333 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9334
9335         * gdbarch.sh: Update the copyright year range that is placed into
9336         generated files.
9337
9338 2019-02-22  Keith Seitz  <keiths@redhat.com>
9339
9340         PR symtab/23853
9341         * linespec.c (create_sals_line_offset): Search for the default
9342         symtab's filename instead of its fullname.
9343
9344 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9345
9346         * NEWS: Update style defaults.
9347
9348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9349
9350         * main.c (captured_main_1): Disable styling in batch mode.
9351
9352 2019-02-20  Tom Tromey  <tom@tromey.com>
9353
9354         * symtab.c (symtab_symbol_info): Fix typos.
9355
9356 2019-02-20  Tom Tromey  <tromey@adacore.com>
9357
9358         * findcmd.c (_initialize_mem_search): Use upper case for
9359         metasyntactic variables.
9360
9361 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9362
9363         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9364         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9365
9366 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9367
9368         * top.h (source_file_name): Change to std::string.
9369         * top.c (source_file_name): Likewise.
9370         (command_line_input): Adjust.
9371         * cli/cli-script.c (script_from_file): Adjust.
9372
9373 2019-02-19  Tom Tromey  <tromey@adacore.com>
9374
9375         * ravenscar-thread.c
9376         (ravenscar_thread_target::update_thread_list): Don't call
9377         ada_build_task_list.
9378         * ada-lang.h (ada_build_task_list): Don't declare.
9379         * ada-tasks.c (struct ada_tasks_inferior_data)
9380         <task_list_valid_p>: Now bool.
9381         (read_known_tasks, ada_task_list_changed)
9382         (ada_tasks_invalidate_inferior_data): Update.
9383         (read_known_tasks_array): Return bool.
9384         (read_known_tasks_list): Likewise.
9385         (read_known_tasks): Return void.
9386         (ada_build_task_list): Now static.
9387
9388 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9391         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9392
9393 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9394
9395         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9396         variant for ada_tasks_pspace_data_handle and
9397         ada_tasks_inferior_data_handle.
9398         (ada_tasks_pspace_data_cleanup): New function.
9399         (ada_tasks_inferior_data_cleanup): New function.
9400
9401 2019-02-17  Tom Tromey  <tom@tromey.com>
9402
9403         * macrotab.h (macro_source_fullname): Return a std::string.
9404         * macrotab.c (macro_include, check_for_redefinition)
9405         (macro_undef, macro_lookup_definition, foreach_macro)
9406         (foreach_macro_in_scope): Update.
9407         (macro_source_fullname): Return a std::string.
9408         * macrocmd.c (show_pp_source_pos): Update.
9409
9410 2019-02-17  Tom Tromey  <tom@tromey.com>
9411
9412         * macrocmd.c (show_pp_source_pos): Style the file names.
9413
9414 2019-02-17  Tom Tromey  <tom@tromey.com>
9415
9416         PR tui/24197:
9417         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9418
9419 2019-02-17  Tom Tromey  <tom@tromey.com>
9420
9421         * ada-lang.c (user_select_syms): Use filtered printing.
9422         * utils.c (wrap_style): New global.
9423         (desired_style): Remove.
9424         (emit_style_escape): Add stream parameter.
9425         (set_output_style, reset_terminal_style, prompt_for_continue):
9426         Update.
9427         (flush_wrap_buffer): Only flush gdb_stdout.
9428         (wrap_here): Set wrap_style.
9429         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9430         treat escape sequences as a character.  Change when wrap buffer is
9431         flushed.
9432         (fputs_styled): Do not set the output style when the default is
9433         requested.
9434         * ui-style.h (struct ui_file_style) <is_default>: New method.
9435         * source.c (print_source_lines_base): Emit escape sequences in one
9436         piece.
9437
9438 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9439
9440         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9441         integers and enumeration types.
9442
9443 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9444
9445         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9446         instead of lookup_symbol_in_language
9447         (do_exact_match): New function.
9448         (ada_get_symbol_name_matcher): Return do_exact_match when
9449         doing a verbatim match.
9450
9451 2019-02-15  Tom Tromey  <tromey@adacore.com>
9452
9453         * ravenscar-thread.c (ravenscar_thread_target::resume)
9454         (ravenscar_thread_target::wait): Special case wildcard requests.
9455
9456 2019-02-15  Tom Tromey  <tromey@adacore.com>
9457
9458         * ravenscar-thread.c (base_ptid): Remove.
9459         (struct ravenscar_thread_target) <close>: New method.
9460         <m_base_ptid>: New member.
9461         <update_inferior_ptid, active_task, task_is_currently_active,
9462         runtime_initialized>: Declare methods.
9463         <ravenscar_thread_target>: Add constructor.
9464         (ravenscar_thread_target::task_is_currently_active)
9465         (ravenscar_thread_target::update_inferior_ptid)
9466         (ravenscar_runtime_initialized): Rename.  Now methods.
9467         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9468         (ravenscar_thread_target::update_thread_list): Update.
9469         (ravenscar_thread_target::active_task): Now method.
9470         (ravenscar_thread_target::store_registers)
9471         (ravenscar_thread_target::prepare_to_store)
9472         (ravenscar_thread_target::prepare_to_store)
9473         (ravenscar_thread_target::mourn_inferior): Update.
9474         (ravenscar_inferior_created): Use "new" to create target.
9475         (ravenscar_thread_target::get_ada_task_ptid): Update.
9476         (_initialize_ravenscar): Don't initialize base_ptid.
9477         (ravenscar_ops): Remove global.
9478
9479 2019-02-15  Tom Tromey  <tromey@adacore.com>
9480
9481         * target.h (push_target): Declare new overload.
9482         * target.c (push_target): New overload, taking an rvalue reference.
9483         * remote.c (remote_target::open_1): Use push_target overload.
9484         * corelow.c (core_target_open): Use push_target overload.
9485
9486 2019-02-15  Tom Tromey  <tromey@adacore.com>
9487
9488         * ravenscar-thread.c (is_ravenscar_task)
9489         (ravenscar_task_is_currently_active): Return bool.
9490         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9491         (_initialize_ravenscar): Remove "(void)".
9492         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9493         Return bool.
9494
9495 2019-02-15  Tom Tromey  <tromey@adacore.com>
9496
9497         * ravenscar-thread.c (ravenscar_runtime_initializer)
9498         (has_ravenscar_runtime, get_running_thread_id)
9499         (ravenscar_thread_target::resume): Fix indentation.
9500
9501 2019-02-15  Tom Tromey  <tromey@adacore.com>
9502
9503         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9504         from ravenscar_arch_ops.
9505         (sparc_ravenscar_ops::fetch_registers)
9506         (sparc_ravenscar_ops::store_registers): Now methods.
9507         (sparc_ravenscar_prepare_to_store): Remove.
9508         (sparc_ravenscar_ops): Redefine.
9509         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9510         methods and destructor.  Remove members.
9511         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9512         (ravenscar_thread_target::store_registers)
9513         (ravenscar_thread_target::prepare_to_store): Update.
9514         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9515         Remove.
9516         (struct ppc_ravenscar_powerpc_ops): Derive from
9517         ravenscar_arch_ops.
9518         (ppc_ravenscar_powerpc_ops::fetch_registers)
9519         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9520         (ppc_ravenscar_powerpc_ops): Redefine.
9521         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9522         (ppc_ravenscar_e500_ops::fetch_registers)
9523         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9524         (ppc_ravenscar_e500_ops): Redefine.
9525         * aarch64-ravenscar-thread.c
9526         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9527         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9528         (aarch64_ravenscar_fetch_registers)
9529         (aarch64_ravenscar_store_registers): Now methods.
9530         (aarch64_ravenscar_ops): Redefine.
9531
9532 2019-02-15  Tom Tromey  <tromey@adacore.com>
9533
9534         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9535         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9536         (ravenscar_thread_target::stopped_by_watchpoint)
9537         (ravenscar_thread_target::stopped_data_address)
9538         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9539
9540 2019-02-15  Tom Tromey  <tromey@adacore.com>
9541
9542         * ravenscar-thread.c: Fix some typos.
9543
9544 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9545             Tom Tromey  <tromey@adacore.com>
9546
9547         * ada-lang.c (ada_exception_sal): Change addr_string to a
9548         std::string.
9549         (create_ada_exception_catchpoint): Update.
9550
9551 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9552             Tom Tromey  <tromey@adacore.com>
9553
9554         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9555         (bp_location_ops): Remove.
9556         (base_breakpoint_allocate_location): Update.
9557         (free_bp_location): Update.
9558         * ada-lang.c (class ada_catchpoint_location)
9559         <ada_catchpoint_location>: Remove ops parameter.
9560         (ada_catchpoint_location_dtor): Remove.
9561         (ada_catchpoint_location_ops): Remove.
9562         (allocate_location_exception): Update.
9563         * breakpoint.h (struct bp_location_ops): Remove.
9564         (class bp_location) <bp_location>: Remove bp_location_ops
9565         parameter.
9566         <~bp_location>: Add destructor.
9567         <ops>: Remove.
9568
9569 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9570             Pedro Alves  <palves@redhat.com>
9571
9572         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9573         'PATH_MAX'.
9574
9575 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9576             Samuel Thibault  <samuel.thibault@gnu.org>
9577             Thomas Schwinge  <thomas@codesourcery.com>
9578
9579         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9580         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9581
9582 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9583
9584         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9585         (check_empty): Use "const char *".
9586
9587         * gnu-nat.c (gnu_nat_target::detach): Instead of
9588         'detach_inferior (pid)' call
9589         'detach_inferior (find_inferior_pid (pid))'.
9590
9591         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9592         'nat/fork-inferior.o'.
9593         * gnu-nat.c: #include "nat/fork-inferior.h".
9594
9595         * gnu-nat.c (gnu_nat_target::detach): Instead of
9596         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9597         * gnu-nat.h: #include "inf-child.h".
9598         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9599         'i386_gnu_nat_target::fetch_registers'.
9600         (gnu_store_registers): Rename/move to
9601         'i386_gnu_nat_target::store_registers'.
9602
9603         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9604         * gnu-nat.h (mach_thread_info): New function.
9605         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9606
9607         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9608
9609 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9610
9611         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9612
9613 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9614
9615         * windows-nat.c (windows_add_thread): Add new parameter
9616         "main_thread_p" with default value set to false.  Update
9617         function documentation as well as all callers.
9618         (windows_delete_thread): Likewise.
9619         (fake_create_process): Update call to windows_add_thread.
9620         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9621         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9622         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9623         call to windows_delete_thread.
9624
9625 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9626
9627         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9628
9629 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9630
9631         * symfile.c (find_separate_debug_file): Use canonical path of
9632         sysroot with child_path instead of gdb_sysroot if it is valid.
9633
9634 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9635
9636         * symfile.c (find_separate_debug_file): Use child_path to
9637         determine if an object file is under a sysroot.
9638
9639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9640
9641         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9642         unittests/child-path-selftests.c.
9643         * common/pathstuff.c (child_path): New function.
9644         * common/pathstuff.h (child_path): New prototype.
9645         * unittests/child-path-selftests.c: New file.
9646
9647 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9648
9649         * symfile.c (find_separate_debug_file): Look for separate debug
9650         files in debug directories under the sysroot.
9651
9652 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9653
9654         * symtab.h (struct minimal_symbol data_p): New const method.
9655         (struct minimal_symbol text_p): Likewise.
9656         * symtab.c (output_source_filename): Use file name style
9657         to print file name.
9658         (print_symbol_info): Likewise.
9659         (print_msymbol_info): Use address style to print addresses.
9660         Use function name style to print executable text symbols.
9661         (expand_symtab_containing_pc): Use data_p.
9662         (find_pc_sect_compunit_symtab): Likewise.
9663
9664 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9665
9666         * breakpoint.c (describe_other_breakpoints): Use address style
9667         to print addresses.
9668         (say_where): Likewise.
9669
9670 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9671
9672         * ada-typeprint.c (print_func_type): Print function name
9673         style to print function name.
9674         * c-typeprint.c (c_print_type_1): Likewise.
9675
9676 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9677
9678         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9679         for execve.
9680
9681 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9682
9683         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9684         type_stack.
9685
9686 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9687
9688         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9689         TYPE_CODE_REF types.
9690
9691 2019-02-08  Jim Wilson  <jimw@sifive.com>
9692
9693         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9694         (riscv_linux_fregset): New.
9695         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9696
9697 2019-02-07  Tom Tromey  <tom@tromey.com>
9698
9699         * thread.c (thread_cancel_execution_command): Update.
9700         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9701         methods.
9702         (struct thread_fsm_ops): Remove.
9703         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9704         (thread_fsm_should_stop, thread_fsm_return_value)
9705         (thread_fsm_set_finished, thread_fsm_finished_p)
9706         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9707         Don't declare.
9708         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9709         * infrun.c (clear_proceed_status_thread)
9710         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9711         (print_stop_event): Update.
9712         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9713         Add constructor.
9714         (step_command_fsm_ops): Remove.
9715         (new_step_command_fsm): Remove.
9716         (step_1): Update.
9717         (step_command_fsm::should_stop): Rename from
9718         step_command_fsm_should_stop.
9719         (step_command_fsm::clean_up): Rename from
9720         step_command_fsm_clean_up.
9721         (step_command_fsm::do_async_reply_reason): Rename from
9722         step_command_fsm_async_reply_reason.
9723         (struct until_next_fsm): Inherit from thread_fsm.  Add
9724         constructor.
9725         (until_next_fsm_ops): Remove.
9726         (new_until_next_fsm): Remove.
9727         (until_next_fsm::should_stop): Rename from
9728         until_next_fsm_should_stop.
9729         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9730         (until_next_fsm::do_async_reply_reason): Rename from
9731         until_next_fsm_async_reply_reason.
9732         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9733         constructor.  Change type of breakpoint.
9734         (finish_command_fsm_ops): Remove.
9735         (new_finish_command_fsm): Remove.
9736         (finish_command_fsm::should_stop): Rename from
9737         finish_command_fsm_should_stop.
9738         (finish_command_fsm::clean_up): Rename from
9739         finish_command_fsm_clean_up.
9740         (finish_command_fsm::return_value): Rename from
9741         finish_command_fsm_return_value.
9742         (finish_command_fsm::do_async_reply_reason): Rename from
9743         finish_command_fsm_async_reply_reason.
9744         (finish_command): Update.
9745         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9746         Add constructor.
9747         (call_thread_fsm_ops): Remove.
9748         (call_thread_fsm::call_thread_fsm): Rename from
9749         new_call_thread_fsm.
9750         (call_thread_fsm::should_stop): Rename from
9751         call_thread_fsm_should_stop.
9752         (call_thread_fsm::should_notify_stop): Rename from
9753         call_thread_fsm_should_notify_stop.
9754         (run_inferior_call, call_function_by_hand_dummy): Update.
9755         * cli/cli-interp.c (should_print_stop_to_console): Update.
9756         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9757         Add constructor.  Change type of location_breakpoint,
9758         caller_breakpoint.
9759         (until_break_fsm_ops): Remove.
9760         (new_until_break_fsm): Remove.
9761         (until_break_fsm::should_stop): Rename from
9762         until_break_fsm_should_stop.
9763         (until_break_fsm::clean_up): Rename from
9764         until_break_fsm_clean_up.
9765         (until_break_fsm::do_async_reply_reason): Rename from
9766         until_break_fsm_async_reply_reason.
9767         (until_break_command): Update.
9768         * thread-fsm.c: Remove.
9769         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9770
9771 2019-02-07  Tom Tromey  <tom@tromey.com>
9772
9773         * yy-remap.h: Add include guard.
9774         * xtensa-tdep.h: Add include guard.
9775         * xcoffread.h: Rename include guard.
9776         * varobj-iter.h: Add include guard.
9777         * tui/tui.h: Rename include guard.
9778         * tui/tui-winsource.h: Rename include guard.
9779         * tui/tui-wingeneral.h: Rename include guard.
9780         * tui/tui-windata.h: Rename include guard.
9781         * tui/tui-win.h: Rename include guard.
9782         * tui/tui-stack.h: Rename include guard.
9783         * tui/tui-source.h: Rename include guard.
9784         * tui/tui-regs.h: Rename include guard.
9785         * tui/tui-out.h: Rename include guard.
9786         * tui/tui-layout.h: Rename include guard.
9787         * tui/tui-io.h: Rename include guard.
9788         * tui/tui-hooks.h: Rename include guard.
9789         * tui/tui-file.h: Rename include guard.
9790         * tui/tui-disasm.h: Rename include guard.
9791         * tui/tui-data.h: Rename include guard.
9792         * tui/tui-command.h: Rename include guard.
9793         * tic6x-tdep.h: Add include guard.
9794         * target/waitstatus.h: Rename include guard.
9795         * target/wait.h: Rename include guard.
9796         * target/target.h: Rename include guard.
9797         * target/resume.h: Rename include guard.
9798         * target-float.h: Rename include guard.
9799         * stabsread.h: Add include guard.
9800         * rs6000-tdep.h: Add include guard.
9801         * riscv-fbsd-tdep.h: Add include guard.
9802         * regformats/regdef.h: Rename include guard.
9803         * record.h: Rename include guard.
9804         * python/python.h: Rename include guard.
9805         * python/python-internal.h: Rename include guard.
9806         * python/py-stopevent.h: Rename include guard.
9807         * python/py-ref.h: Rename include guard.
9808         * python/py-record.h: Rename include guard.
9809         * python/py-record-full.h: Rename include guard.
9810         * python/py-record-btrace.h: Rename include guard.
9811         * python/py-instruction.h: Rename include guard.
9812         * python/py-events.h: Rename include guard.
9813         * python/py-event.h: Rename include guard.
9814         * procfs.h: Add include guard.
9815         * proc-utils.h: Add include guard.
9816         * p-lang.h: Add include guard.
9817         * or1k-tdep.h: Rename include guard.
9818         * observable.h: Rename include guard.
9819         * nto-tdep.h: Rename include guard.
9820         * nat/x86-linux.h: Rename include guard.
9821         * nat/x86-linux-dregs.h: Rename include guard.
9822         * nat/x86-gcc-cpuid.h: Add include guard.
9823         * nat/x86-dregs.h: Rename include guard.
9824         * nat/x86-cpuid.h: Rename include guard.
9825         * nat/ppc-linux.h: Rename include guard.
9826         * nat/mips-linux-watch.h: Rename include guard.
9827         * nat/linux-waitpid.h: Rename include guard.
9828         * nat/linux-ptrace.h: Rename include guard.
9829         * nat/linux-procfs.h: Rename include guard.
9830         * nat/linux-osdata.h: Rename include guard.
9831         * nat/linux-nat.h: Rename include guard.
9832         * nat/linux-namespaces.h: Rename include guard.
9833         * nat/linux-btrace.h: Rename include guard.
9834         * nat/glibc_thread_db.h: Rename include guard.
9835         * nat/gdb_thread_db.h: Rename include guard.
9836         * nat/gdb_ptrace.h: Rename include guard.
9837         * nat/fork-inferior.h: Rename include guard.
9838         * nat/amd64-linux-siginfo.h: Rename include guard.
9839         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9840         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9841         * nat/aarch64-linux.h: Rename include guard.
9842         * nat/aarch64-linux-hw-point.h: Rename include guard.
9843         * mn10300-tdep.h: Add include guard.
9844         * mips-linux-tdep.h: Add include guard.
9845         * mi/mi-parse.h: Rename include guard.
9846         * mi/mi-out.h: Rename include guard.
9847         * mi/mi-main.h: Rename include guard.
9848         * mi/mi-interp.h: Rename include guard.
9849         * mi/mi-getopt.h: Rename include guard.
9850         * mi/mi-console.h: Rename include guard.
9851         * mi/mi-common.h: Rename include guard.
9852         * mi/mi-cmds.h: Rename include guard.
9853         * mi/mi-cmd-break.h: Rename include guard.
9854         * m2-lang.h: Add include guard.
9855         * location.h: Rename include guard.
9856         * linux-record.h: Rename include guard.
9857         * linux-nat.h: Add include guard.
9858         * linux-fork.h: Add include guard.
9859         * i386-darwin-tdep.h: Rename include guard.
9860         * hppa-linux-offsets.h: Add include guard.
9861         * guile/guile.h: Rename include guard.
9862         * guile/guile-internal.h: Rename include guard.
9863         * gnu-nat.h: Rename include guard.
9864         * gdb-stabs.h: Rename include guard.
9865         * frv-tdep.h: Add include guard.
9866         * f-lang.h: Add include guard.
9867         * event-loop.h: Add include guard.
9868         * darwin-nat.h: Rename include guard.
9869         * cp-abi.h: Rename include guard.
9870         * config/sparc/nm-sol2.h: Rename include guard.
9871         * config/nm-nto.h: Rename include guard.
9872         * config/nm-linux.h: Add include guard.
9873         * config/i386/nm-i386gnu.h: Rename include guard.
9874         * config/djgpp/nl_types.h: Rename include guard.
9875         * config/djgpp/langinfo.h: Rename include guard.
9876         * compile/gcc-cp-plugin.h: Add include guard.
9877         * compile/gcc-c-plugin.h: Add include guard.
9878         * compile/compile.h: Rename include guard.
9879         * compile/compile-object-run.h: Rename include guard.
9880         * compile/compile-object-load.h: Rename include guard.
9881         * compile/compile-internal.h: Rename include guard.
9882         * compile/compile-cplus.h: Rename include guard.
9883         * compile/compile-c.h: Rename include guard.
9884         * common/xml-utils.h: Rename include guard.
9885         * common/x86-xstate.h: Rename include guard.
9886         * common/version.h: Rename include guard.
9887         * common/vec.h: Rename include guard.
9888         * common/tdesc.h: Rename include guard.
9889         * common/selftest.h: Rename include guard.
9890         * common/scoped_restore.h: Rename include guard.
9891         * common/scoped_mmap.h: Rename include guard.
9892         * common/scoped_fd.h: Rename include guard.
9893         * common/safe-iterator.h: Rename include guard.
9894         * common/run-time-clock.h: Rename include guard.
9895         * common/refcounted-object.h: Rename include guard.
9896         * common/queue.h: Rename include guard.
9897         * common/ptid.h: Rename include guard.
9898         * common/print-utils.h: Rename include guard.
9899         * common/preprocessor.h: Rename include guard.
9900         * common/pathstuff.h: Rename include guard.
9901         * common/observable.h: Rename include guard.
9902         * common/netstuff.h: Rename include guard.
9903         * common/job-control.h: Rename include guard.
9904         * common/host-defs.h: Rename include guard.
9905         * common/gdb_wait.h: Rename include guard.
9906         * common/gdb_vecs.h: Rename include guard.
9907         * common/gdb_unlinker.h: Rename include guard.
9908         * common/gdb_unique_ptr.h: Rename include guard.
9909         * common/gdb_tilde_expand.h: Rename include guard.
9910         * common/gdb_sys_time.h: Rename include guard.
9911         * common/gdb_string_view.h: Rename include guard.
9912         * common/gdb_splay_tree.h: Rename include guard.
9913         * common/gdb_setjmp.h: Rename include guard.
9914         * common/gdb_ref_ptr.h: Rename include guard.
9915         * common/gdb_optional.h: Rename include guard.
9916         * common/gdb_locale.h: Rename include guard.
9917         * common/gdb_assert.h: Rename include guard.
9918         * common/filtered-iterator.h: Rename include guard.
9919         * common/filestuff.h: Rename include guard.
9920         * common/fileio.h: Rename include guard.
9921         * common/environ.h: Rename include guard.
9922         * common/common-utils.h: Rename include guard.
9923         * common/common-types.h: Rename include guard.
9924         * common/common-regcache.h: Rename include guard.
9925         * common/common-inferior.h: Rename include guard.
9926         * common/common-gdbthread.h: Rename include guard.
9927         * common/common-exceptions.h: Rename include guard.
9928         * common/common-defs.h: Rename include guard.
9929         * common/common-debug.h: Rename include guard.
9930         * common/cleanups.h: Rename include guard.
9931         * common/buffer.h: Rename include guard.
9932         * common/btrace-common.h: Rename include guard.
9933         * common/break-common.h: Rename include guard.
9934         * cli/cli-utils.h: Rename include guard.
9935         * cli/cli-style.h: Rename include guard.
9936         * cli/cli-setshow.h: Rename include guard.
9937         * cli/cli-script.h: Rename include guard.
9938         * cli/cli-interp.h: Rename include guard.
9939         * cli/cli-decode.h: Rename include guard.
9940         * cli/cli-cmds.h: Rename include guard.
9941         * charset-list.h: Add include guard.
9942         * buildsym-legacy.h: Rename include guard.
9943         * bfin-tdep.h: Add include guard.
9944         * ax.h: Rename include guard.
9945         * arm-linux-tdep.h: Add include guard.
9946         * arm-fbsd-tdep.h: Add include guard.
9947         * arch/xtensa.h: Rename include guard.
9948         * arch/tic6x.h: Add include guard.
9949         * arch/i386.h: Add include guard.
9950         * arch/arm.h: Rename include guard.
9951         * arch/arm-linux.h: Rename include guard.
9952         * arch/arm-get-next-pcs.h: Rename include guard.
9953         * arch/amd64.h: Add include guard.
9954         * arch/aarch64-insn.h: Rename include guard.
9955         * arch-utils.h: Rename include guard.
9956         * annotate.h: Add include guard.
9957         * amd64-darwin-tdep.h: Rename include guard.
9958         * aarch64-linux-tdep.h: Add include guard.
9959         * aarch64-fbsd-tdep.h: Add include guard.
9960         * aarch32-linux-nat.h: Add include guard.
9961
9962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9963
9964         * macrotab.c (macro_define_internal): New function that
9965         factorizes macro_define_object_internal and macro_define_function
9966         code.
9967         (macro_define_object_internal): Use macro_define_internal.
9968         (macro_define_function): Likewise.
9969
9970 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9971
9972         * macrocmd.c (extract_identifier): Return
9973         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9974         callers.
9975
9976 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9977
9978         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9979
9980 2019-02-05  Tom Tromey  <tom@tromey.com>
9981
9982         * target.c (target_stack::unpush): Move assertion earlier.
9983
9984 2019-01-30  Tom Tromey  <tom@tromey.com>
9985
9986         PR python/23615:
9987         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9988         (gdbpy_parse_and_eval): Likewise.
9989         * python/python-internal.h (gdbpy_allow_threads): New class.
9990
9991 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9992
9993         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9994         (aarch64_fbsd_fpregmap): Move earlier.
9995         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9996         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9997         instead of individual calls to trad_frame_set_reg_addr.
9998         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9999         earlier.
10000         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10001         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10002         instead of individual calls to trad_frame_set_reg_addr.
10003
10004 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10005
10006         * CONTRIBUTE: Replace contribution list with wiki link.
10007
10008 2019-01-25  Tom Tromey  <tom@tromey.com>
10009
10010         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10011
10012 2019-01-25  Tom Tromey  <tom@tromey.com>
10013
10014         * xtensa-linux-nat.c: Fix common/ includes.
10015         * xml-support.h: Fix common/ includes.
10016         * xml-support.c: Fix common/ includes.
10017         * x86-linux-nat.c: Fix common/ includes.
10018         * windows-nat.c: Fix common/ includes.
10019         * varobj.h: Fix common/ includes.
10020         * varobj.c: Fix common/ includes.
10021         * value.c: Fix common/ includes.
10022         * valops.c: Fix common/ includes.
10023         * utils.c: Fix common/ includes.
10024         * unittests/xml-utils-selftests.c: Fix common/ includes.
10025         * unittests/utils-selftests.c: Fix common/ includes.
10026         * unittests/unpack-selftests.c: Fix common/ includes.
10027         * unittests/tracepoint-selftests.c: Fix common/ includes.
10028         * unittests/style-selftests.c: Fix common/ includes.
10029         * unittests/string_view-selftests.c: Fix common/ includes.
10030         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10031         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10032         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10033         * unittests/rsp-low-selftests.c: Fix common/ includes.
10034         * unittests/parse-connection-spec-selftests.c: Fix common/
10035         includes.
10036         * unittests/optional-selftests.c: Fix common/ includes.
10037         * unittests/offset-type-selftests.c: Fix common/ includes.
10038         * unittests/observable-selftests.c: Fix common/ includes.
10039         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10040         * unittests/memrange-selftests.c: Fix common/ includes.
10041         * unittests/memory-map-selftests.c: Fix common/ includes.
10042         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10043         * unittests/function-view-selftests.c: Fix common/ includes.
10044         * unittests/environ-selftests.c: Fix common/ includes.
10045         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10046         * unittests/common-utils-selftests.c: Fix common/ includes.
10047         * unittests/cli-utils-selftests.c: Fix common/ includes.
10048         * unittests/array-view-selftests.c: Fix common/ includes.
10049         * ui-file.c: Fix common/ includes.
10050         * tui/tui-io.c: Fix common/ includes.
10051         * tracepoint.h: Fix common/ includes.
10052         * tracepoint.c: Fix common/ includes.
10053         * tracefile-tfile.c: Fix common/ includes.
10054         * top.h: Fix common/ includes.
10055         * top.c: Fix common/ includes.
10056         * thread.c: Fix common/ includes.
10057         * target/waitstatus.h: Fix common/ includes.
10058         * target/waitstatus.c: Fix common/ includes.
10059         * target.h: Fix common/ includes.
10060         * target.c: Fix common/ includes.
10061         * target-memory.c: Fix common/ includes.
10062         * target-descriptions.c: Fix common/ includes.
10063         * symtab.h: Fix common/ includes.
10064         * symfile.c: Fix common/ includes.
10065         * stap-probe.c: Fix common/ includes.
10066         * spu-linux-nat.c: Fix common/ includes.
10067         * sparc-nat.c: Fix common/ includes.
10068         * source.c: Fix common/ includes.
10069         * solib.c: Fix common/ includes.
10070         * solib-target.c: Fix common/ includes.
10071         * ser-unix.c: Fix common/ includes.
10072         * ser-tcp.c: Fix common/ includes.
10073         * ser-pipe.c: Fix common/ includes.
10074         * ser-base.c: Fix common/ includes.
10075         * selftest-arch.c: Fix common/ includes.
10076         * s12z-tdep.c: Fix common/ includes.
10077         * rust-exp.y: Fix common/ includes.
10078         * rs6000-aix-tdep.c: Fix common/ includes.
10079         * riscv-tdep.c: Fix common/ includes.
10080         * remote.c: Fix common/ includes.
10081         * remote-notif.h: Fix common/ includes.
10082         * remote-fileio.h: Fix common/ includes.
10083         * remote-fileio.c: Fix common/ includes.
10084         * regcache.h: Fix common/ includes.
10085         * regcache.c: Fix common/ includes.
10086         * record-btrace.c: Fix common/ includes.
10087         * python/python.c: Fix common/ includes.
10088         * python/py-type.c: Fix common/ includes.
10089         * python/py-inferior.c: Fix common/ includes.
10090         * progspace.h: Fix common/ includes.
10091         * producer.c: Fix common/ includes.
10092         * procfs.c: Fix common/ includes.
10093         * proc-api.c: Fix common/ includes.
10094         * printcmd.c: Fix common/ includes.
10095         * ppc-linux-nat.c: Fix common/ includes.
10096         * parser-defs.h: Fix common/ includes.
10097         * osdata.c: Fix common/ includes.
10098         * obsd-nat.c: Fix common/ includes.
10099         * nat/x86-linux.c: Fix common/ includes.
10100         * nat/x86-linux-dregs.c: Fix common/ includes.
10101         * nat/x86-dregs.h: Fix common/ includes.
10102         * nat/x86-dregs.c: Fix common/ includes.
10103         * nat/ppc-linux.c: Fix common/ includes.
10104         * nat/mips-linux-watch.h: Fix common/ includes.
10105         * nat/mips-linux-watch.c: Fix common/ includes.
10106         * nat/linux-waitpid.c: Fix common/ includes.
10107         * nat/linux-ptrace.h: Fix common/ includes.
10108         * nat/linux-ptrace.c: Fix common/ includes.
10109         * nat/linux-procfs.c: Fix common/ includes.
10110         * nat/linux-personality.c: Fix common/ includes.
10111         * nat/linux-osdata.c: Fix common/ includes.
10112         * nat/linux-namespaces.c: Fix common/ includes.
10113         * nat/linux-btrace.h: Fix common/ includes.
10114         * nat/linux-btrace.c: Fix common/ includes.
10115         * nat/fork-inferior.c: Fix common/ includes.
10116         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10117         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10118         * nat/aarch64-linux.c: Fix common/ includes.
10119         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10120         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10121         * namespace.h: Fix common/ includes.
10122         * mips-linux-tdep.c: Fix common/ includes.
10123         * minsyms.c: Fix common/ includes.
10124         * mi/mi-parse.h: Fix common/ includes.
10125         * mi/mi-main.c: Fix common/ includes.
10126         * mi/mi-cmd-env.c: Fix common/ includes.
10127         * memrange.h: Fix common/ includes.
10128         * memattr.c: Fix common/ includes.
10129         * maint.h: Fix common/ includes.
10130         * maint.c: Fix common/ includes.
10131         * main.c: Fix common/ includes.
10132         * machoread.c: Fix common/ includes.
10133         * location.c: Fix common/ includes.
10134         * linux-thread-db.c: Fix common/ includes.
10135         * linux-nat.c: Fix common/ includes.
10136         * linux-fork.c: Fix common/ includes.
10137         * inline-frame.c: Fix common/ includes.
10138         * infrun.c: Fix common/ includes.
10139         * inflow.c: Fix common/ includes.
10140         * inferior.h: Fix common/ includes.
10141         * inferior.c: Fix common/ includes.
10142         * infcmd.c: Fix common/ includes.
10143         * inf-ptrace.c: Fix common/ includes.
10144         * inf-child.c: Fix common/ includes.
10145         * ia64-linux-nat.c: Fix common/ includes.
10146         * i387-tdep.c: Fix common/ includes.
10147         * i386-tdep.c: Fix common/ includes.
10148         * i386-linux-tdep.c: Fix common/ includes.
10149         * i386-linux-nat.c: Fix common/ includes.
10150         * i386-go32-tdep.c: Fix common/ includes.
10151         * i386-fbsd-tdep.c: Fix common/ includes.
10152         * i386-fbsd-nat.c: Fix common/ includes.
10153         * guile/scm-type.c: Fix common/ includes.
10154         * guile/guile.c: Fix common/ includes.
10155         * go32-nat.c: Fix common/ includes.
10156         * gnu-nat.c: Fix common/ includes.
10157         * gdbthread.h: Fix common/ includes.
10158         * gdbarch-selftests.c: Fix common/ includes.
10159         * gdb_usleep.c: Fix common/ includes.
10160         * gdb_select.h: Fix common/ includes.
10161         * gdb_bfd.c: Fix common/ includes.
10162         * gcore.c: Fix common/ includes.
10163         * fork-child.c: Fix common/ includes.
10164         * findvar.c: Fix common/ includes.
10165         * fbsd-nat.c: Fix common/ includes.
10166         * event-top.c: Fix common/ includes.
10167         * event-loop.c: Fix common/ includes.
10168         * dwarf2read.c: Fix common/ includes.
10169         * dwarf2loc.c: Fix common/ includes.
10170         * dwarf2-frame.c: Fix common/ includes.
10171         * dwarf-index-cache.c: Fix common/ includes.
10172         * dtrace-probe.c: Fix common/ includes.
10173         * disasm-selftests.c: Fix common/ includes.
10174         * defs.h: Fix common/ includes.
10175         * csky-tdep.c: Fix common/ includes.
10176         * cp-valprint.c: Fix common/ includes.
10177         * cp-support.h: Fix common/ includes.
10178         * cp-support.c: Fix common/ includes.
10179         * corelow.c: Fix common/ includes.
10180         * completer.h: Fix common/ includes.
10181         * completer.c: Fix common/ includes.
10182         * compile/compile.c: Fix common/ includes.
10183         * compile/compile-loc2c.c: Fix common/ includes.
10184         * compile/compile-cplus-types.c: Fix common/ includes.
10185         * compile/compile-cplus-symbols.c: Fix common/ includes.
10186         * command.h: Fix common/ includes.
10187         * cli/cli-dump.c: Fix common/ includes.
10188         * cli/cli-cmds.c: Fix common/ includes.
10189         * charset.c: Fix common/ includes.
10190         * build-id.c: Fix common/ includes.
10191         * btrace.h: Fix common/ includes.
10192         * btrace.c: Fix common/ includes.
10193         * breakpoint.h: Fix common/ includes.
10194         * breakpoint.c: Fix common/ includes.
10195         * ax.h:
10196         (enum agent_op): Fix common/ includes.
10197         * ax-general.c (struct aop_map): Fix common/ includes.
10198         * ax-gdb.c: Fix common/ includes.
10199         * auxv.c: Fix common/ includes.
10200         * auto-load.c: Fix common/ includes.
10201         * arm-tdep.c: Fix common/ includes.
10202         * arch/riscv.c: Fix common/ includes.
10203         * arch/ppc-linux-common.c: Fix common/ includes.
10204         * arch/i386.c: Fix common/ includes.
10205         * arch/arm.c: Fix common/ includes.
10206         * arch/arm-linux.c: Fix common/ includes.
10207         * arch/arm-get-next-pcs.c: Fix common/ includes.
10208         * arch/amd64.c: Fix common/ includes.
10209         * arch/aarch64.c: Fix common/ includes.
10210         * arch/aarch64-insn.c: Fix common/ includes.
10211         * arch-utils.c: Fix common/ includes.
10212         * amd64-windows-tdep.c: Fix common/ includes.
10213         * amd64-tdep.c: Fix common/ includes.
10214         * amd64-sol2-tdep.c: Fix common/ includes.
10215         * amd64-obsd-tdep.c: Fix common/ includes.
10216         * amd64-nbsd-tdep.c: Fix common/ includes.
10217         * amd64-linux-tdep.c: Fix common/ includes.
10218         * amd64-linux-nat.c: Fix common/ includes.
10219         * amd64-fbsd-tdep.c: Fix common/ includes.
10220         * amd64-fbsd-nat.c: Fix common/ includes.
10221         * amd64-dicos-tdep.c: Fix common/ includes.
10222         * amd64-darwin-tdep.c: Fix common/ includes.
10223         * agent.c: Fix common/ includes.
10224         * ada-lang.h: Fix common/ includes.
10225         * ada-lang.c: Fix common/ includes.
10226         * aarch64-tdep.c: Fix common/ includes.
10227
10228 2019-01-25  Tom Tromey  <tom@tromey.com>
10229
10230         * common/create-version.sh: Use common/version.h.
10231
10232 2019-01-24  Pedro Alves  <palves@redhat.com>
10233
10234         * infrun.c (signal_stop, signal_print, signal_program)
10235         (signal_catch, signal_pass): Now arrays instead of pointers.
10236         (update_signals_program_target, do_target_resume)
10237         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10238         * linux-nat.c (linux_nat_target::pass_signals)
10239         (linux_nat_target::create_inferior, linux_nat_target::attach):
10240         Adjust.
10241         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10242         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10243         * procfs.c (procfs_target::pass_signals): Adjust.
10244         * record-full.c (record_full_target::resume): Adjust.
10245         * remote.c (remote_target::pass_signals)
10246         (remote_target::program_signals): Adjust.
10247         * target-debug.h (target_debug_print_signals): Now takes a
10248         gdb::array_view as parameter.  Adjust.
10249         * target.h (target_ops) <pass_signals, program_signals>: Replace
10250         pointer and length parameters with gdb::array_view.
10251         (target_pass_signals, target_program_signals): Likewise.
10252         * target-delegates.c: Regenerate.
10253
10254 2019-01-24  Pedro Alves  <palves@redhat.com>
10255
10256         * common/forward-scope-exit.h
10257         (forward_scope_exit::forward_scope_exit): Pass arguments to
10258         m_bind_function directly, instead of creating a std::bind and
10259         copying that.
10260
10261 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10262
10263         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10264         for static members.
10265         (pass_in_v_vfp_candidate): Likewise.
10266
10267 2019-01-23  Tom Tromey  <tom@tromey.com>
10268             Pedro Alves  <palves@redhat.com>
10269
10270         * regcache.c (class regcache_invalidator): Remove.
10271         (regcache::raw_write): Use make_scope_exit.
10272
10273 2019-01-23  Tom Tromey  <tom@tromey.com>
10274
10275         * ui-out.h (class ui_out_emit_type): Update comment.
10276
10277 2019-01-23  Tom Tromey  <tom@tromey.com>
10278
10279         * infrun.c (fetch_inferior_event): Update comment.
10280
10281 2019-01-23  Tom Tromey  <tom@tromey.com>
10282             Pedro Alves  <palves@redhat.com>
10283
10284         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10285         parameter.
10286         (fetch_inferior_event): Use SCOPE_EXIT.
10287
10288
10289 2019-01-23  Tom Tromey  <tom@tromey.com>
10290             Pedro Alves  <palves@redhat.com>
10291
10292         * infrun.c (disable_thread_events): Delete.
10293         (stop_all_threads): Use SCOPE_EXIT.
10294
10295 2019-01-23  Tom Tromey  <tom@tromey.com>
10296             Pedro Alves  <palves@redhat.com>
10297
10298         * symfile.c: Include forward-scope-exit.h.
10299         (clear_symtab_users_cleanup): Replace forward declaration with
10300         a FORWARD_SCOPE_EXIT.
10301         (syms_from_objfile_1): Use the forward_scope_exit and
10302         gdb::optional instead of cleanup_function.
10303         (reread_symbols): Use the forward_scope_exit instead of
10304         cleanup_function.
10305         (clear_symtab_users_cleanup): Remove function.
10306
10307 2019-01-23  Tom Tromey  <tom@tromey.com>
10308             Pedro Alves  <palves@redhat.com>
10309
10310         * linux-nat.c: Include scope-exit.h.
10311         (cleanup_target_stop): Remove.
10312         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10313         SCOPE_EXIT.
10314
10315 2019-01-23  Tom Tromey  <tom@tromey.com>
10316             Pedro Alves  <palves@redhat.com>
10317
10318         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10319         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10320
10321 2019-01-23  Tom Tromey  <tom@tromey.com>
10322             Andrew Burgess  <andrew.burgess@embecosm.com>
10323             Pedro Alves  <palves@redhat.com>
10324
10325         * infrun.c (fetch_inferior_event): Use scope_exit.
10326         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10327         * top.c (execute_command): Use scope_exit.
10328         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10329         * utils.c (do_bpstat_clear_actions_cleanup)
10330         (make_bpstat_clear_actions_cleanup): Remove.
10331
10332 2019-01-23  Tom Tromey  <tom@tromey.com>
10333             Pedro Alves  <palves@redhat.com>
10334
10335         * infrun.c: Include "common/scope-exit.h"
10336         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10337         (wait_for_inferior): Use SCOPE_EXIT.
10338         (fetch_inferior_event): Use scope_exit.
10339
10340 2019-01-23  Tom Tromey  <tom@tromey.com>
10341             Pedro Alves  <palves@redhat.com>
10342
10343         * breakpoint.c (create_breakpoint): Remove cleanup.
10344
10345 2019-01-23  Tom Tromey  <tom@tromey.com>
10346             Andrew Burgess  <andrew.burgess@embecosm.com>
10347             Pedro Alves  <palves@redhat.com>
10348
10349 2019-01-23  Pedro Alves  <palves@redhat.com>
10350
10351         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10352
10353 2019-01-23  Pedro Alves  <palves@redhat.com>
10354             Andrew Burgess  <andrew.burgess@embecosm.com>
10355
10356         * gdbthread.h: Include "common/forward-scope-exit.h".
10357         (scoped_finish_thread_state): Redefine custom class in terms of
10358         forward_scope_exit.
10359
10360 2019-01-23  Pedro Alves  <palves@redhat.com>
10361             Andrew Burgess  <andrew.burgess@embecosm.com>
10362
10363         * common/forward-scope-exit.h: New file.
10364
10365 2019-01-23  Pedro Alves  <palves@redhat.com>
10366             Andrew Burgess  <andrew.burgess@embecosm.com>
10367             Tom Tromey  <tom@tromey.com>
10368
10369         * common/scope-exit.h: New file.
10370
10371 2019-01-23  Pedro Alves  <palves@redhat.com>
10372
10373         * common/preprocessor.h (ESC): Rename to ...
10374         (ESC_PARENS): ... this.
10375         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10376         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10377
10378 2019-01-23  Tom Tromey  <tom@tromey.com>
10379
10380         * language.h (class scoped_switch_to_sym_language_if_auto):
10381         Initialize m_lang in both cases.
10382
10383 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10384
10385         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10386         with XCNEW.
10387
10388 2019-01-22  Tom Tromey  <tom@tromey.com>
10389
10390         * corelow.c: Do not include sys/file.h.
10391
10392 2019-01-22  Tom Tromey  <tom@tromey.com>
10393
10394         * tui/tui-wingeneral.h: Include gdb_curses.h.
10395
10396 2019-01-22  Tom Tromey  <tom@tromey.com>
10397
10398         * source-cache.h (class source_cache) <get_source_lines,
10399         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10400
10401 2019-01-22  Tom Tromey  <tom@tromey.com>
10402
10403         * remote-fileio.h (struct remote_target): Declare.
10404
10405 2019-01-22  Tom Tromey  <tom@tromey.com>
10406
10407         * python/py-arch.c: Do not include py-ref.h.
10408         * python/py-bpevent.c: Do not include py-ref.h.
10409         * python/py-cmd.c: Do not include py-ref.h.
10410         * python/py-continueevent.c: Do not include py-ref.h.
10411         * python/py-event.h: Do not include py-ref.h.
10412         * python/py-evtregistry.c: Do not include py-ref.h.
10413         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10414         * python/py-frame.c: Do not include py-ref.h.
10415         * python/py-framefilter.c: Do not include py-ref.h.
10416         * python/py-function.c: Do not include py-ref.h.
10417         * python/py-infevents.c: Do not include py-ref.h.
10418         * python/py-linetable.c: Do not include py-ref.h.
10419         * python/py-objfile.c: Do not include py-ref.h.
10420         * python/py-param.c: Do not include py-ref.h.
10421         * python/py-prettyprint.c: Do not include py-ref.h.
10422         * python/py-progspace.c: Do not include py-ref.h.
10423         * python/py-symbol.c: Do not include py-ref.h.
10424         * python/py-symtab.c: Do not include py-ref.h.
10425         * python/py-type.c: Do not include py-ref.h.
10426         * python/py-unwind.c: Do not include py-ref.h.
10427         * python/py-utils.c: Do not include py-ref.h.
10428         * python/py-value.c: Do not include py-ref.h.
10429         * python/py-varobj.c: Do not include py-ref.h.
10430         * python/py-xmethods.c: Do not include py-ref.h.
10431         * python/python.c: Do not include py-ref.h.
10432         * varobj.c: Do not include py-ref.h.
10433
10434 2019-01-22  Tom Tromey  <tom@tromey.com>
10435
10436         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10437         keyword for bcache.
10438
10439 2019-01-22  Tom Tromey  <tom@tromey.com>
10440
10441         * compile/compile-cplus-types.c: Remove a comment by #include.
10442
10443 2019-01-22  Tom Tromey  <tom@tromey.com>
10444
10445         * compile/gcc-c-plugin.h: Include compile-internal.h.
10446
10447 2019-01-22  Tom Tromey  <tom@tromey.com>
10448
10449         * stabsread.c (EXTERN): Do not define.
10450         (symnum, next_symbol_text_func, processing_gcc_compilation)
10451         (within_function, global_sym_chain, global_stabs)
10452         (previous_stab_code, this_object_header_files)
10453         (n_this_object_header_files)
10454         (n_allocated_this_object_header_files): Define.
10455         * stabsread.h (EXTERN): Never define.  Use "extern".
10456
10457 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10458
10459         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10460         history_value.
10461
10462 2019-01-21  Tom Tromey  <tom@tromey.com>
10463
10464         * ui-out.c: Fix includes.
10465         * tui/tui-source.c: Fix includes.
10466         * target.c: Fix includes.
10467         * remote.c: Fix includes.
10468         * regcache.c: Fix includes.
10469         * python/py-block.c: Fix includes.
10470         * printcmd.c: Fix includes.
10471         * or1k-tdep.c: Fix includes.
10472         * mi/mi-main.c: Fix includes.
10473         * m32r-tdep.c: Fix includes.
10474         * csky-tdep.c: Fix includes.
10475         * compile/compile-cplus-types.c: Fix includes.
10476         * cli/cli-interp.c: Fix includes.
10477
10478 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10479
10480         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10481         for padding.
10482
10483 2019-01-16  Tom Tromey  <tom@tromey.com>
10484
10485         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10486         earlier.
10487         (struct objfile) <msymbols_range>: Move from top level.
10488         <msymbols>: New method.
10489         (class objfile_msymbols): Remove.
10490         * symtab.c (default_collect_symbol_completion_matches_break_on):
10491         Update.
10492         * symmisc.c (dump_msymbols): Update.
10493         * stabsread.c (scan_file_globals): Update.
10494         * objc-lang.c (info_selectors_command, info_classes_command)
10495         (find_methods): Update.
10496         * minsyms.c (find_solib_trampoline_target): Update.
10497         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10498         * coffread.c (coff_symfile_read): Update.
10499         * ada-lang.c (ada_lookup_simple_minsym)
10500         (ada_collect_symbol_completion_matches): Update.
10501
10502 2019-01-16  Tom Tromey  <tom@tromey.com>
10503
10504         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10505         type.  Remove no-argument constructor.
10506         <iterator::operator++>: Simplify.
10507         <begin>: Update.
10508         <end>: Use minimal_symbol_count.
10509
10510 2019-01-16  Tom Tromey  <tom@tromey.com>
10511
10512         * objfiles.h (struct objfile) <psymtabs>: New method.
10513         (class objfile_psymtabs): Remove.
10514         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10515         typedef.
10516         <range>: New method.
10517         (require_partial_symbols): Change return type.
10518         * psymtab.c (require_partial_symbols)
10519         (psym_expand_symtabs_matching): Update.
10520         * mdebugread.c (parse_partial_symbols): Update.
10521         * dbxread.c (dbx_end_psymtab): Update.
10522
10523 2019-01-15  Tom Tromey  <tom@tromey.com>
10524
10525         * symtab.c (lookup_objfile_from_block)
10526         (lookup_symbol_in_objfile_symtabs)
10527         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10528         (find_line_symtab, info_sources_command)
10529         (default_collect_symbol_completion_matches_break_on)
10530         (make_source_files_completion_list): Update.
10531         * symmisc.c (print_objfile_statistics, dump_objfile)
10532         (maintenance_print_symbols, maintenance_info_symtabs)
10533         (maintenance_check_symtabs, maintenance_info_line_tables):
10534         Update.
10535         * source.c (select_source_symtab)
10536         (forget_cached_source_info_for_objfile): Update.
10537         * objfiles.h (class objfile_compunits): Remove.
10538         (struct objfile) <compunits_range>: New typedef.
10539         (compunits): New method.
10540         * objfiles.c (objfile_relocate1): Update.
10541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10542         * maint.c (count_symtabs_and_blocks): Update.
10543         * linespec.c (iterate_over_all_matching_symtabs): Update.
10544         * cp-support.c (add_symbol_overload_list_qualified): Update.
10545         * coffread.c (coff_symtab_read): Update.
10546         * ada-lang.c (add_nonlocal_symbols)
10547         (ada_collect_symbol_completion_matches)
10548         (ada_add_global_exceptions): Update.
10549
10550 2019-01-15  Tom Tromey  <tom@tromey.com>
10551
10552         * progspace.h (program_space) <objfiles_safe_range>: New
10553         typedef.
10554         <objfiles_safe>: New method.
10555         * objfiles.h (class all_objfiles_safe): Remove.
10556         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10557         * jit.c (jit_inferior_exit_hook): Update.
10558
10559 2019-01-17  Tom Tromey  <tom@tromey.com>
10560
10561         * progspace.h (program_space) <objfiles_range>: New typedef.
10562         <objfiles>: New method.
10563         <objfiles_head>: Rename from objfiles.
10564         (object_files): Update.
10565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10566         * guile/scm-pretty-print.c
10567         (ppscm_find_pretty_printer_from_objfiles): Update.
10568         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10570         Update.
10571         * python/py-progspace.c (pspy_get_objfiles): Update.
10572         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10573         Update.
10574         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10575         (objfpy_lookup_objfile_by_build_id): Update.
10576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10577         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10578         Update.
10579         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10580         (expand_symtab_containing_pc, lookup_objfile_from_block)
10581         (lookup_static_symbol, basic_lookup_transparent_type)
10582         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10583         (find_line_symtab, info_sources_command)
10584         (default_collect_symbol_completion_matches_break_on)
10585         (make_source_files_completion_list, find_main_name): Update.
10586         * symmisc.c (print_symbol_bcache_statistics)
10587         (print_objfile_statistics, maintenance_print_symbols)
10588         (maintenance_print_msymbols, maintenance_print_objfiles)
10589         (maintenance_info_symtabs, maintenance_check_symtabs)
10590         (maintenance_expand_symtabs, maintenance_info_line_tables):
10591         Update.
10592         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10593         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10594         (map_overlay_command, unmap_overlay_command)
10595         (simple_overlay_update, expand_symtabs_matching)
10596         (map_symbol_filenames): Update.
10597         * symfile-debug.c (set_debug_symfile): Update.
10598         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10599         Update.
10600         * source.c (select_source_symtab, forget_cached_source_info):
10601         Update.
10602         * solib.c (solib_read_symbols): Update.
10603         * solib-spu.c (append_ocl_sos): Update.
10604         * psymtab.c (maintenance_print_psymbols)
10605         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10606         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10607         * printcmd.c (info_symbol_command): Update.
10608         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10609         Update.
10610         * objfiles.h (class all_objfiles): Remove.
10611         * objfiles.c (have_partial_symbols, have_full_symbols)
10612         (have_minimal_symbols, qsort_cmp, update_section_map)
10613         (shared_objfile_contains_address_p)
10614         (default_iterate_over_objfiles_in_search_order): Update.
10615         * objc-lang.c (info_selectors_command, info_classes_command)
10616         (find_methods): Update.
10617         * minsyms.c (find_solib_trampoline_target): Update.
10618         * maint.c (maintenance_info_sections)
10619         (maintenance_translate_address, count_symtabs_and_blocks):
10620         Update.
10621         * main.c (captured_main_1): Update.
10622         * linux-thread-db.c (try_thread_db_load_from_pdir)
10623         (has_libpthread): Update.
10624         * linespec.c (iterate_over_all_matching_symtabs)
10625         (search_minsyms_for_name): Update.
10626         * jit.c (jit_find_objf_with_entry_addr): Update.
10627         * hppa-tdep.c (find_unwind_entry)
10628         (hppa_lookup_stub_minimal_symbol): Update.
10629         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10630         Update.
10631         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10632         (elf_gnu_ifunc_resolve_by_got): Update.
10633         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10634         * dwarf-index-write.c (save_gdb_index_command): Update.
10635         * cp-support.c (add_symbol_overload_list_qualified): Update.
10636         * breakpoint.c (create_overlay_event_breakpoint)
10637         (create_longjmp_master_breakpoint)
10638         (create_std_terminate_master_breakpoint)
10639         (create_exception_master_breakpoint): Update.
10640         * blockframe.c (find_pc_partial_function): Update.
10641         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10642         (ada_collect_symbol_completion_matches)
10643         (ada_add_global_exceptions): Update.
10644
10645 2019-01-17  Tom Tromey  <tom@tromey.com>
10646
10647         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10648         declare VEC.
10649         (solib_target_parse_libraries): Change return type.
10650         (library_list_start_segment, library_list_start_section)
10651         (library_list_end_library, library_list_start_library); Update.
10652         (solib_target_free_library_list): Remove.
10653         (solib_target_parse_libraries): Remove cleanup.  Change return
10654         type.
10655         (solib_target_current_sos): Update.
10656
10657 2019-01-17  Tom Tromey  <tromey@bapiya>
10658
10659         * valprint.c: Replace "the the" with "the".
10660         * symtab.c: Replace "the the" with "the".
10661         * solib.c: Replace "the the" with "the".
10662         * solib-dsbt.c: Replace "the the" with "the".
10663         * linespec.c: Replace "the the" with "the".
10664         * dwarf2loc.h: Replace "the the" with "the".
10665         * amd64-windows-tdep.c: Replace "the the" with "the".
10666         * aarch64-tdep.c: Replace "the the" with "the".
10667
10668 2019-01-16  Keith Seitz  <keiths@redhat.com>
10669
10670         PR gdb/23773
10671         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10672         <builder>: Rename to ..
10673         <m_builder>: ... this and make private.
10674         (dwarf2_cu::get_builder): New method.  Change all users of
10675         `builder' to use this method.
10676         (dwarf2_start_symtab): Move to ...
10677         (dwarf2_cu::start_symtab): ... here.  Update all callers
10678         (setup_type_unit_groups): Move to ...
10679         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10680         callers.
10681         (dwarf2_cu::reset_builder): New method.
10682         (process_full_compunit, process_full_type_unit): Use
10683         dwarf2_cu::reset_builder.
10684         (follow_die_offset): Record the ancestor CU if it is different
10685         from the followed DIE's CU.
10686         (follow_die_sig_1): Likewise.
10687
10688 2019-01-15  Tom Tromey  <tom@tromey.com>
10689
10690         * remote.c (class remote_state) <buf>: Now a char_vector.
10691         <buf_size>: Remove.
10692         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10693         parameter.
10694         (remote_target::getpkt_or_notif_sane_1)
10695         (remote_target::getpkt_sane)
10696         (remote_target::getpkt_or_notif_sane): Likewise.
10697         (class remote_target) <putpkt>: New overload.
10698         (remote_target::read_frame): Change type of "buf_p".  Remove
10699         sizeof_p parameter.
10700         (packet_ok): New overload.
10701         (packet_check_result): New overload.
10702         Update all uses.
10703
10704 2019-01-14  Tom Tromey  <tom@tromey.com>
10705
10706         * remote-notif.c (handle_notification, remote_notif_ack)
10707         (remote_notif_parse): Make "buf" const.
10708         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10709         const.
10710         (remote_notif_parse, remote_notif_ack, handle_notification):
10711         Likewise.
10712         * remote.c (remote_notif_stop_parse): Make "buf" const.
10713         (remote_target::remote_parse_stop_reply): Make "buf" const.
10714         (remote_notif_stop_ack): Make "buf" const.
10715
10716 2019-01-14  Tom Tromey  <tom@tromey.com>
10717
10718         * remote.c (remote_console_output): Make parameter const.
10719
10720 2019-01-14  Tom Tromey  <tom@tromey.com>
10721
10722         * target-debug.h (target_debug_print_signals): Constify.
10723         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10724         * procfs.c (procfs_target::pass_signals): Update.
10725         * linux-nat.c (linux_nat_target::pass_signals): Update.
10726         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10727         * target-delegates.c: Rebuild.
10728         * remote.c (remote_target::program_signals): Update.
10729         (remote_target::pass_signals): Update.
10730         * target.c (target_pass_signals): Constify argument.
10731         (target_program_signals): Likewise.
10732         * target.h (struct target_ops) <pass_signals, program_signals>:
10733         Constify argument.
10734         (target_pass_signals, target_program_signals): Constify argument.
10735
10736 2019-01-14  Tom Tromey  <tom@tromey.com>
10737
10738         PR tui/28819:
10739         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10740
10741 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10742
10743         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10744         field.
10745         * rs6000-tdep.c: Include reggroups.h.
10746         (IS_V_ALIAS_PSEUDOREG): Define.
10747         (rs6000_register_name): Return names for the "vX" aliases.
10748         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10749         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10750         aliases.  Call default_register_reggroup_p for all other
10751         pseudo-registers.
10752         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10753         New functions.
10754         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10755         Handle "vX" aliases.
10756         (v_alias_pseudo_register_collect): New function.
10757         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10758         (rs6000_gdbarch_init): Initialize "vX" aliases as
10759         pseudo-registers.  Restore registration of
10760         rs6000_pseudo_register_reggroup_p with
10761         set_tdesc_pseudo_register_reggroup_p.
10762
10763 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10764
10765         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10766         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10767         set_gdbarch_num_pseudo_regs.
10768
10769 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10770
10771         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10772         Remove arg prefixname, add do_set and do_show.
10773         Add member functions set_list and show_list.
10774         * cli/cli-style.c (class cli_style_option): Update accordingly.
10775         (style_set_list): Move to file scope.
10776         (style_show_list): Likewise.
10777         (set_style): Call help_list.
10778         (show_style): Call cmd_show_list.
10779         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10780         Update to use the new macro.
10781
10782 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10783
10784         * ada-lang.c (_initialize_ada_language): Expand the help text
10785         for the "catch exception" command.
10786
10787 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10788
10789         * symtab.c (matching_obj_sections): Initialize obj,
10790         declare it closer to its usage.
10791
10792 2019-01-10  Tom Tromey  <tom@tromey.com>
10793
10794         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10795         (basic_inf_threads_range): Remove.
10796         (inf_threads_range, inf_non_exited_threads_range)
10797         (safe_inf_threads_range): Use next_adapter.
10798
10799 2019-01-10  Keith Seitz  <keiths@redhat.com>
10800
10801         PR gdb/23712
10802         PR symtab/23010
10803         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10804         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10805
10806 2019-01-10  Keith Seitz  <keiths@redhat.com>
10807
10808         PR gdb/23712
10809         PR symtab/23010
10810         * dictionary.c (pending_to_vector): Remove.
10811         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10812         Remove _1 suffix, replacing functions of the same name.  Update
10813         all callers.
10814         (dict_create_hashed, dict_create_hashed_expandable)
10815         (dict_create_linear, dict_create_linear_expandable, dict_free)
10816         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10817         Make functions static.
10818
10819 2019-01-10  Keith Seitz  <keiths@redhat.com>
10820
10821         PR gdb/23712
10822         PR symtab/23010
10823         * dictionary.h (struct dictionary): Replace declaration with
10824         multidictionary.
10825         (dict_create_hashed, dict_create_hashed_expandable)
10826         (dict_create_linear, dict_create_linear_expandable)
10827         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10828         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10829         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10830         taking multidictionary argument.
10831         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10832         * block.h (struct block) <dict>: Change to multidictionary
10833         and rename `multidict'.
10834         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10835         symmisc.c: Update all dictionary references to multidictionary.
10836
10837 2019-01-10  Keith Seitz  <keiths@redhat.com>
10838
10839         PR gdb/23712
10840         PR symtab/23010
10841         * dictionary.c: Include unordered_map.
10842         (pending_to_vector): New function.
10843         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10844         Rewrite the non-"_1" functions to take vector instead
10845         of linked list.
10846         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10847         "new" _1 versions of the same name.
10848         (multidictionary): Define.
10849         (std::hash<enum language): New definition.
10850         (collate_pending_symbols_by_language, mdict_create_hashed)
10851         (mdict_create_hashed_expandable, mdict_create_linear)
10852         (mdict_create_linear_expandable, mdict_free)
10853         (find_language_dictionary, create_new_language_dictionary)
10854         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10855         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10856         (mdict_size, mdict_empty): New functions.
10857         * dictionary.h (mdict_iterator): Define.
10858
10859 2019-01-10  Pedro Alves  <palves@redhat.com>
10860
10861         * breakpoint.c (read_uploaded_action)
10862         (create_tracepoint_from_upload): Adjust to use
10863         gdb::unique_xmalloc_ptr.
10864         * ctf.c (ctf_write_uploaded_tp):
10865         (SET_ARRAY_FIELD): Use emplace_back.
10866         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10867         * tracefile-tfile.c (tfile_write_uploaded_tp):
10868         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10869         gdb::unique_xmalloc_ptr.
10870         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10871         at_string, cond_string, cmd_strings>: Replace char pointers
10872         with gdb::unique_xmalloc_ptr.
10873
10874 2019-01-10  Pedro Alves  <palves@redhat.com>
10875
10876         * solib-target.c (library_list_start_library): Don't xstrdup name.
10877
10878 2019-01-10  Pedro Alves  <palves@redhat.com>
10879
10880         * mdebugread.c (parse_partial_symbols): Use
10881         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10882
10883 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * linux-fork.c (scoped_switch_fork_info)
10886         <~scoped_switch_fork_info>: Fix incorrect variable name.
10887
10888 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10889
10890         * linux-fork.c (scoped_switch_fork_info)
10891         <scoped_switch_fork_info>: Make explicit.
10892         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10893
10894 2019-01-10  Tom Tromey  <tom@tromey.com>
10895
10896         * objfiles.h (objfile::reset_psymtabs): Update.
10897         * objfiles.c (objfile::objfile): Update.
10898         * psymtab.h (psymtab_storage::obstack): Update.
10899         (psymtab_storage::m_obstack): Use gdb::optional.
10900         (class psymtab_storage): Update comment.  Remove objfile
10901         parameter.
10902         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10903
10904 2019-01-10  Tom Tromey  <tom@tromey.com>
10905
10906         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10907         <free_psymtabs>: Now private.
10908         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10909         (allocate_psymtab): Use new method.
10910
10911 2019-01-10  Tom Tromey  <tom@tromey.com>
10912
10913         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10914         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10915         * mdebugread.c (parse_partial_symbols): Use
10916         allocate_dependencies.
10917         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10918         allocate_dependencies.
10919         (process_psymtab_comp_unit_reader)
10920         (build_type_psymtab_dependencies): Likewise.
10921         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10922
10923 2019-01-10  Tom Tromey  <tom@tromey.com>
10924
10925         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10926         PSYMBOL_SET_LANGUAGE.
10927         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10928
10929 2019-01-10  Tom Tromey  <tom@tromey.com>
10930
10931         * psymtab.h (psymtab_storage::obstack): New method.
10932         <m_obstack>: Rename from obstack; now private.
10933         * psymtab.c (psymtab_storage): Update.
10934         * dwarf2read.c (create_addrmap_from_index)
10935         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10936         Update.
10937
10938 2019-01-10  Tom Tromey  <tom@tromey.com>
10939
10940         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10941         * objfiles.h (objfile::reset_psymtabs): New method.
10942
10943 2019-01-10  Tom Tromey  <tom@tromey.com>
10944
10945         * symmisc.c (print_symbol_bcache_statistics): Update.
10946         (print_objfile_statistics): Update.
10947         * symfile.c (reread_symbols): Update.
10948         * psymtab.h (class psymtab_storage): New.
10949         * psymtab.c (psymtab_storage): New constructor.
10950         (~psymtab_storage): New destructor.
10951         (require_partial_symbols): Update.
10952         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10953         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10954         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10955         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10956         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10957         (start_psymtab_common, end_psymtab_common)
10958         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10959         (allocate_psymtab): Update.
10960         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10961         Update.
10962         (dump_psymtab_addrmap, maintenance_print_psymbols)
10963         (maintenance_check_psymtabs): Update.
10964         (class objfile_psymtabs): Move to objfiles.h.
10965         * psympriv.h (discard_psymtab): Now inline.
10966         (psymtab_discarder::psymtab_discarder): Update.
10967         (psymtab_discarder::~psymtab_discarder): Update.
10968         (ALL_OBJFILE_PSYMTABS): Rewrite.
10969         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10970         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10971         Remove fields.
10972         <partial_symtabs>: New field.
10973         (class objfile_psymtabs): Move from psymtab.h.  Update.
10974         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10975         psymbol_cache.
10976         (objfile::~objfile): Don't destroy psymbol_cache.
10977         * mdebugread.c (parse_partial_symbols): Update.
10978         * dwarf2read.c (create_addrmap_from_index)
10979         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10980         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10981         (add_partial_subprogram, dwarf2_ranges_read): Update.
10982         * dwarf-index-write.c (write_address_map)
10983         (write_one_signatured_type, recursively_write_psymbols)
10984         (class debug_names, class debug_names, write_psymtabs_to_index):
10985         Update.
10986
10987 2019-01-10  Tom Tromey  <tom@tromey.com>
10988
10989         * symtab.h (SYMBOL_SET_NAMES): Update.
10990         (symbol_set_names): Update.
10991         (MSYMBOL_SET_NAMES): Update.
10992         * symtab.c (symbol_set_names): Change argument to be an
10993         objfile_per_bfd_storage.
10994         * psymtab.c (add_psymbol_to_bcache): Update.
10995         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10996
10997 2019-01-10  Tom Tromey  <tom@tromey.com>
10998
10999         * symtab.c (create_demangled_names_hash): Change argument to be an
11000         objfile_per_bfd_storage.
11001         (symbol_set_names): Update.
11002
11003 2019-01-10  Tom Tromey  <tom@tromey.com>
11004
11005         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11006         init_psymbol_list.
11007         * psymtab.c (init_psymbol_list): Do nothing if already called.
11008         * psympriv.h (init_psymbol_list): Add comment.
11009         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11010         init_psymbol_list.
11011         * dbxread.c (dbx_symfile_read): Unconditionally call
11012         init_psymbol_list.
11013
11014 2019-01-10  Tom Tromey  <tom@tromey.com>
11015
11016         * xcoffread.c (scan_xcoff_symtab): Update.
11017         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11018         "where".
11019         * mdebugread.c (parse_partial_symbols)
11020         (handle_psymbol_enumerators): Update.
11021         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11022         * dbxread.c (read_dbx_symtab): Update.
11023         * psympriv.h (psymbol_placement): New enum.
11024         (add_psymbol_to_list): Update.
11025
11026 2019-01-10  Tom Tromey  <tom@tromey.com>
11027
11028         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11029         static_psymbols parameters.
11030         (scan_xcoff_symtab): Update.
11031         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11032         static_psymbols parameters.
11033         * psympriv.h (start_psymtab_common): Update.
11034         * mdebugread.c (parse_partial_symbols): Update.
11035         * dwarf2read.c (create_partial_symtab): Update.
11036         * dbxread.c (read_dbx_symtab): Update.
11037         (start_psymtab): Remove global_psymbols and static_psymbols
11038         parameters.
11039
11040 2019-01-10  Tom Tromey  <tom@tromey.com>
11041
11042         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11043         * psymtab.c (allocate_psymtab): Add comment.
11044         * psympriv.h (allocate_psymtab): Add comment.
11045         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11046         initializations.
11047         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11048
11049 2019-01-10  Tom Tromey  <tom@tromey.com>
11050
11051         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11052         Don't declare.
11053         * mipsread.c: Include mdebugread.h.
11054         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11055         Declare.
11056         * elfread.c: Include mdebugread.h.
11057
11058 2019-01-09  Tom Tromey  <tom@tromey.com>
11059
11060         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11061         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11062         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11063         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11064         (psym_lookup_symbol, psym_find_last_source_symtab)
11065         (psym_forget_cached_source_info, psym_print_stats)
11066         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11067         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11068         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11069         (psym_find_compunit_symtab_by_address)
11070         (maintenance_print_psymbols, maintenance_info_psymtabs)
11071         (maintenance_check_psymtabs): Use ranged for.
11072         * psymtab.h (class objfile_psymtabs): New.
11073         (require_partial_symbols): Return objfile_psymtabs.
11074         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11075
11076 2019-01-09  Tom Tromey  <tom@tromey.com>
11077
11078         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11079         (find_pc_mapped_section, list_overlays_command)
11080         (map_overlay_command, unmap_overlay_command)
11081         (simple_overlay_update): Use all_objfiles.
11082         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11083         * printcmd.c (info_symbol_command): Use all_objfiles.
11084         * objfiles.h (ALL_OBJSECTIONS): Remove.
11085         * maint.c (maintenance_translate_address): Use all_objfiles.
11086         * gcore.c (gcore_create_callback): Use all_objfiles.
11087         (objfile_find_memory_regions): Likewise.
11088
11089 2019-01-09  Tom Tromey  <tom@tromey.com>
11090
11091         * symtab.c (find_line_symtab, info_sources_command)
11092         (make_source_files_completion_list): Use objfile_compunits.
11093         * source.c (select_source_symtab): Use objfile_compunits.
11094         * objfiles.h (struct objfile): Update comment.
11095         (ALL_OBJFILES): Remove.
11096         (ALL_FILETABS): Remove.
11097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11098         objfile_compunits.
11099
11100 2019-01-09  Tom Tromey  <tom@tromey.com>
11101
11102         * symmisc.c (print_objfile_statistics, dump_objfile)
11103         (maintenance_print_symbols): Use compunit_filetabs.
11104         * source.c (forget_cached_source_info_for_objfile): Use
11105         compunit_filetabs.
11106         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11107         (ALL_FILETABS): Use compunit_filetabs.
11108         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11109         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11110
11111 2019-01-09  Tom Tromey  <tom@tromey.com>
11112
11113         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11114         (compunit_filetabs): New.
11115         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11116         compunit_filetabs.
11117         (info_sources_command, make_source_files_completion_list): Remove
11118         declaration.
11119         * symmisc.c (print_objfile_statistics, dump_objfile)
11120         (maintenance_print_symbols): Remove declaration.
11121         (maintenance_info_symtabs): Use compunit_filetabs.
11122         (maintenance_info_line_tables): Likewise.
11123         * source.c (select_source_symtab): Change local variable name.
11124         (forget_cached_source_info_for_objfile): Remove declaration.
11125         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11126         * objfiles.c (objfile_relocate1): Remove declaration.
11127         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11128         declaration.
11129         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11130         * coffread.c (coff_symtab_read): Remove declaration.
11131         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11132         compunit_filetabs.
11133
11134 2019-01-09  Tom Tromey  <tom@tromey.com>
11135
11136         * symtab.c (lookup_objfile_from_block)
11137         (find_pc_sect_compunit_symtab, search_symbols)
11138         (default_collect_symbol_completion_matches_break_on): Use
11139         objfile_compunits.
11140         * objfiles.h (ALL_COMPUNITS): Remove.
11141         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11142         * cp-support.c (add_symbol_overload_list_qualified): Use
11143         objfile_compunits.
11144         * ada-lang.c (ada_collect_symbol_completion_matches)
11145         (ada_add_global_exceptions): Use objfile_compunits.
11146
11147 2019-01-09  Tom Tromey  <tom@tromey.com>
11148
11149         * source.c (select_source_symtab)
11150         (forget_cached_source_info_for_objfile): Remove declaration.
11151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11152         declaration.
11153         * maint.c (count_symtabs_and_blocks): Remove declaration.
11154         * cp-support.c (add_symbol_overload_list_qualified): Remove
11155         declaration.
11156         * coffread.c (coff_symtab_read): Remove declaration.
11157         * symtab.c (lookup_symbol_in_objfile_symtabs)
11158         (basic_lookup_transparent_type_1): Use objfile_compunits.
11159         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11160         (info_sources_command, search_symbols)
11161         (default_collect_symbol_completion_matches_break_on)
11162         (make_source_files_completion_list): Remove declaration.
11163         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11164         (ada_collect_symbol_completion_matches)
11165         (ada_add_global_exceptions): Remove declaration.
11166         * linespec.c (iterate_over_all_matching_symtabs): Use
11167         objfile_compunits.
11168         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11169         (class objfile_compunits): New.
11170         (ALL_COMPUNITS): Use objfile_compunits.
11171         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11172         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11173         objfile_compunits.
11174         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11175
11176 2019-01-09  Tom Tromey  <tom@tromey.com>
11177
11178         * symtab.c (search_symbols)
11179         (default_collect_symbol_completion_matches_break_on): Use
11180         objfile_msymbols.
11181         * ada-lang.c (ada_lookup_simple_minsym)
11182         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11183         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11184         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11185         objfile_msymbols.
11186         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11187         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11188         * objc-lang.c (find_methods): Use objfile_msymbols.
11189         (info_selectors_command, info_classes_command): Likewise.
11190         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11191         * objfiles.h (class objfile_msymbols): New.
11192         (ALL_OBJFILE_MSYMBOLS): Remove.
11193         (ALL_MSYMBOLS): Remove.
11194
11195 2019-01-09  Tom Tromey  <tom@tromey.com>
11196
11197         * common/next-iterator.h (next_adapter): Add Iterator template
11198         parameter.
11199         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11200         (class all_objfiles_safe): New.
11201         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11202         * objfiles.c (put_objfile_before): Update comment.
11203         (add_separate_debug_objfile): Likewise.
11204         (free_all_objfiles): Use all_objfiles_safe.
11205         (objfile_purge_solibs): Likewise.
11206
11207 2019-01-09  Tom Tromey  <tom@tromey.com>
11208
11209         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11210         (expand_symtab_containing_pc, lookup_static_symbol)
11211         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11212         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11213         all_objfiles.
11214         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11215         * breakpoint.c (create_overlay_event_breakpoint)
11216         (create_longjmp_master_breakpoint)
11217         (create_std_terminate_master_breakpoint)
11218         (create_exception_master_breakpoint): Use all_objfiles.
11219         * linux-thread-db.c (try_thread_db_load_from_pdir)
11220         (has_libpthread): Use all_objfiles.
11221         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11222         * linespec.c (iterate_over_all_matching_symtabs)
11223         (search_minsyms_for_name): Use all_objfiles.
11224         * maint.c (maintenance_info_sections): Use all_objfiles.
11225         * main.c (captured_main_1): Use all_objfiles.
11226         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11227         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11228         * guile/scm-pretty-print.c
11229         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11230         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11231         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11232         (maintenance_print_msymbols): Use all_objfiles.
11233         * source.c (select_source_symtab): Use all_objfiles.
11234         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11235         * symfile.c (remove_symbol_file_command)
11236         (expand_symtabs_matching, map_symbol_filenames): Use
11237         all_objfiles.
11238         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11239         all_objfiles.
11240         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11241         * objc-lang.c (find_methods): Use all_objfiles.
11242         * objfiles.c (have_partial_symbols, have_full_symbols)
11243         (have_minimal_symbols, qsort_cmp)
11244         (default_iterate_over_objfiles_in_search_order): Use
11245         all_objfiles.
11246         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11247         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11248         (maintenance_check_psymtabs): Use all_objfiles.
11249         (ALL_PSYMTABS): Remove.
11250         * compile/compile-object-run.c (do_module_cleanup): Use
11251         all_objfiles.
11252         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11253         * cp-support.c (add_symbol_overload_list_qualified): Use
11254         all_objfiles.
11255         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11256         Use all_objfiles.
11257         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11258         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11259         all_objfiles.
11260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11261         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11263         Uses all_objfiles.
11264         * solib.c (solib_read_symbols): Use all_objfiles
11265
11266 2019-01-09  Tom Tromey  <tom@tromey.com>
11267
11268         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11269         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11270         all_objfiles.
11271         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11272         * symmisc.c (print_symbol_bcache_statistics)
11273         (print_objfile_statistics, maintenance_print_objfiles)
11274         (maintenance_info_symtabs, maintenance_check_symtabs)
11275         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11276         all_objfiles.
11277         * source.c (forget_cached_source_info): Use all_objfiles.
11278         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11279         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11280         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11281         * objfiles.c (update_section_map): Use all_objfiles.
11282         (shared_objfile_contains_address_p): Likewise.
11283         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11284         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11285
11286 2019-01-09  Tom Tromey  <tom@tromey.com>
11287
11288         * common/next-iterator.h: New file.
11289         * objfiles.h (class all_objfiles): New.
11290         (struct objfile_iterator): New.
11291
11292 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11293
11294         * NEWS: Move the description of the changed "frame", "select-frame",
11295          and "info frame" commands to the Changed commands section.
11296
11297 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11298
11299         * gdbtypes.c (check_stub_method_group): Remove handling of old
11300         mangling schemes.
11301         * linespec.c (find_methods): Likewise.
11302         * stabsread.c (read_member_functions): Likewise.
11303         * valops.c (search_struct_method): Likewise.
11304         (value_struct_elt_for_reference): Likewise.
11305         * NEWS: Mention this change.
11306
11307 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11308
11309         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11310         print_source_lines.
11311         * source.c (print_source_lines_base): Update line number check.
11312         (print_source_lines): New function.
11313         (source_lines_range::source_lines_range): New function.
11314         * source.h (class source_lines_range): New class.
11315         (print_source_lines): New declaration.
11316
11317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11318
11319         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11320
11321 2019-01-08  Tom Tromey  <tom@tromey.com>
11322             Simon Marchi  <simon.marchi@ericsson.com>
11323
11324         PR gdb/24060
11325         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11326         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11327         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11328         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11329         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11330         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11331
11332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * source.c (select_source_symtab): Move header comment to
11335         declaration in source.h.
11336         (forget_cached_source_info_for_objfile): Likewise.
11337         (forget_cached_source_info): Likewise.
11338         (identify_source_line): Likewise.
11339         * source.h (identify_source_line): Move declaration from symtab.h
11340         and add comment from source.c
11341         (print_source_lines): Likewise.
11342         (forget_cached_source_info_for_objfile): Likewise.
11343         (forget_cached_source_info): Likewise.
11344         (select_source_symtab): Likewise.
11345         (enum print_source_lines_flag): Move definition from symtab.h.
11346         * symtab.h (identify_source_line): Move declaration to source.h.
11347         (print_source_lines): Likewise.
11348         (forget_cached_source_info_for_objfile): Likewise.
11349         (forget_cached_source_info): Likewise.
11350         (select_source_symtab): Likewise.
11351         (enum print_source_lines_flag): Move definition to source.h.
11352         * tui/tui-hooks.c: Add 'source.h' include.
11353
11354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * source.c (print_source_lines_base): Handle requests to print
11357         reverse line number sequences, and guard against empty lines
11358         string.
11359
11360 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11361
11362         * source.c (print_source_lines_base): Fix skip of '\r' if next
11363         character is '\n'.
11364
11365 2019-01-06  Tom Tromey  <tom@tromey.com>
11366
11367         * c-exp.y (struct c_parse_state) <macro_original_text,
11368         expansion_obstack>: New member.
11369         (macro_original_text, expansion_obstack): Remove globals.
11370         (scan_macro_expansion, scanning_macro_expansion)
11371         (finished_macro_expansion): Update.
11372         (scan_macro_cleanup): Remove.
11373         (yylex, c_parse): Update.
11374
11375 2019-01-06  Tom Tromey  <tom@tromey.com>
11376
11377         * c-exp.y (struct c_parse_state) <strings>: New member.
11378         (operator_stoken): Update.
11379
11380 2019-01-06  Tom Tromey  <tom@tromey.com>
11381
11382         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11383         (union type_stack_elt) <typelist_val>: Now a pointer to
11384         std::vector.
11385         (type_stack_cleanup): Don't declare.
11386         (push_typelist): Update.
11387         * parse.c (pop_typelist): Return a std::vector.
11388         (push_typelist): Take a std::vector.
11389         (follow_types): Update.  Do not free args.
11390         (type_stack_cleanup): Remove.
11391         * c-exp.y (struct c_parse_state): New.
11392         (cpstate): New global.
11393         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11394         (nonempty_typelist): Update.
11395         (func_mod): Create a new vector.
11396         (c_parse): Create a c_parse_state.
11397         (check_parameter_typelist): Do not delete params.
11398         (function_method): Update.  Do not delete type_list.
11399
11400 2019-01-06  Tom Tromey  <tom@tromey.com>
11401
11402         PR gdb/28155:
11403         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11404         check_typedef.
11405         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11406         (print_return_value): Likewise.
11407
11408 2019-01-05  Tom Tromey  <tom@tromey.com>
11409
11410         * contrib/cleanup_check.py: Remove.
11411         * contrib/gcc-with-excheck: Remove.
11412         * contrib/exsummary.py: Remove.
11413         * contrib/excheck.py: Remove.
11414
11415 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11416
11417         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11418         NULL. Initialize tpprev to NULL instead of assigning it
11419         to NULL on the next statement.
11420         * windows-nat.c (windows_delete_thread): Remove check for
11421         main_thread_id before printing thread exit notifications.
11422         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11423         Remove thread ID check against main_thread_id.
11424         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11425         windows_delete_thread.
11426         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11427
11428 2019-01-04  Tom Tromey  <tom@tromey.com>
11429
11430         * compile/compile.c (_initialize_compile): Use upper case for
11431         metasyntactic variables.
11432         * symmisc.c (_initialize_symmisc): Use upper case for
11433         metasyntactic variables.
11434         * psymtab.c (_initialize_psymtab): Use upper case for
11435         metasyntactic variables.
11436         * demangle.c (demangle_command): Use upper case for metasyntactic
11437         variables.
11438         (_initialize_demangler): Likewise.
11439         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11440         variables.
11441
11442 2019-01-03  Tom Tromey  <tom@tromey.com>
11443
11444         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11445
11446 2019-01-03  Tom Tromey  <tom@tromey.com>
11447
11448         * python/py-symtab.c (salpy_str): Update.
11449         (struct salpy_sal_object) <symtab>: Now a PyObject.
11450         (salpy_dealloc): Update.
11451         (del_objfile_sal): Use gdbpy_ref.
11452
11453 2019-01-03  Tom Tromey  <tom@tromey.com>
11454
11455         * python/py-type.c (convert_field): Use new_reference.  Return
11456         gdbpy_ref.
11457         (make_fielditem): Return gdbpy_ref.
11458         (typy_fields): Update.
11459         (typy_getitem): Update.
11460         (field_name): Return gdbpy_ref.  Use new_reference.
11461         (typy_iterator_iternext): Update.
11462
11463 2019-01-03  Tom Tromey  <tom@tromey.com>
11464
11465         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11466
11467 2019-01-03  Tom Tromey  <tom@tromey.com>
11468
11469         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11470         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11471         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11472         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11473         (pspy_set_type_printers): Likewise.
11474         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11475         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11476         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11477         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11478         (objfpy_set_type_printers): Likewise.
11479
11480 2019-01-03  Tom Tromey  <tom@tromey.com>
11481
11482         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11483         (gdbpy_print_stack): Use gdbpy_err_fetch.
11484         * python/python-internal.h (class gdbpy_err_fetch): New class.
11485         (class gdbpy_enter) <m_error_type, m_error_value,
11486         m_error_traceback>: Remove.
11487         <m_error>: New member.
11488         (gdbpy_exception_to_string): Don't declare.
11489         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11490         * python/py-value.c (convert_value_from_python): Use
11491         gdbpy_err_fetch.
11492         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11493         gdbpy_exception_to_string.
11494         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11495         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11496         gdbpy_err_fetch.
11497
11498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11499
11500         * linux-nat.c (delete_lwp_cleanup): Delete.
11501         (struct lwp_deleter): New struct.
11502         (lwp_info_up): New typedef.
11503         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11504         lwp_info_up.
11505
11506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11507
11508         * linux-fork.c (class scoped_switch_fork_info): New class.
11509         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11510
11511 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11512
11513         * valops.c (find_overload_match): Remove use of null_cleanup, and
11514         calls to do_cleanups.
11515
11516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11517
11518         * compile/compile-cplus-types.c
11519         (compile_cplus_instance::decl_name): Handle changes to
11520         cp_func_name.
11521         * cp-support.c (cp_func_name): Update header comment, update
11522         return type.
11523         * cp-support.h (cp_func_name): Update return type in declaration.
11524         * valops.c (find_overload_match): Move temp_func local to top
11525         level of function and change its type.  Use temp_func to hold and
11526         delete temporary string obtained from cp_func_name.
11527
11528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11529
11530         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11531         gdb::char_vector, remove cleanup, and update uses of `msg`.
11532
11533 2019-01-03  Jim Wilson  <jimw@sifive.com>
11534
11535         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11536
11537 2019-01-02  Tom Tromey  <tom@tromey.com>
11538
11539         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11540         (tdesc_parse_xml): Remove cleanups.
11541         * target-descriptions.h (make_cleanup_free_target_description):
11542         Don't declare.
11543         (target_desc_deleter): New struct.
11544         (target_desc_up): New typedef.
11545         * target-descriptions.c (target_desc_deleter::operator()): Rename
11546         from free_target_description.
11547         (make_cleanup_free_target_description): Remove.
11548
11549 2019-01-02  Tom Tromey  <tom@tromey.com>
11550
11551         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11552         constructor, destructor.
11553         (linespec_parser): Remove typedef.
11554         (~linespec_parser): Rename from linespec_parser_delete.
11555         (linespec_lex_to_end, linespec_complete_label)
11556         (linespec_complete): Update.
11557         (decode_line_full): Remove cleanups.
11558         (decode_line_1): Update.
11559
11560 2019-01-02  Tom Tromey  <tom@tromey.com>
11561
11562         * python/python-internal.h (inferior_to_inferior_object): Change
11563         return type.
11564         * python/py-exitedevent.c (create_exited_event_object): Update.
11565         * python/py-inferior.c (inferior_to_inferior_object): Return
11566         gdbpy_ref.
11567         (python_new_inferior, python_inferior_deleted)
11568         (thread_to_thread_object, delete_thread_object)
11569         (build_inferior_list, gdbpy_selected_inferior): Update.
11570         * python/py-infthread.c (create_thread_object): Update.  Also fail
11571         if inferior_to_inferior_object fails.
11572
11573 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11574
11575         * inferior.h (class inferior) <displaced_step_state>: New field.
11576         * infrun.h (struct displaced_step_state): Move here from
11577         infrun.c.  Initialize fields, add constructor.
11578         <inf>: Remove field.
11579         <reset>: New method.
11580         * infrun.c (struct displaced_step_inferior_state): Move to
11581         infrun.h.
11582         (displaced_step_inferior_states): Remove.
11583         (get_displaced_stepping_state): Adust.
11584         (displaced_step_in_progress_any_inferior): Adjust.
11585         (displaced_step_in_progress_thread): Adjust.
11586         (displaced_step_in_progress): Adjust.
11587         (add_displaced_stepping_state): Remove.
11588         (get_displaced_step_closure_by_addr): Adjust.
11589         (remove_displaced_stepping_state): Remove.
11590         (infrun_inferior_exit): Call displaced_step_state.reset.
11591         (use_displaced_stepping): Don't check for NULL.
11592         (displaced_step_prepare_throw): Call
11593         get_displaced_stepping_state.
11594         (displaced_step_fixup): Don't check for NULL.
11595         (prepare_for_detach): Don't check for NULL.
11596
11597 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11598
11599         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11600          in case of call that did not complete.
11601
11602 2019-01-02  Andrey Utkin  <autkin@undo.io>
11603
11604         * symfile.c (find_separate_debug_file): Fix search of debug files for
11605         remote debuggee.
11606
11607 2019-01-02  Tom Tromey  <tom@tromey.com>
11608
11609         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11610         indentation.
11611         * python/py-frame.c (frapy_older): Remove cast.
11612         (frapy_newer): Likewise.
11613         * python/py-breakpoint.c (local_setattro): Remove cast.
11614         * python/py-arch.c (archpy_name): Remove local variable.
11615         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11616
11617 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11618
11619         * unittests/basic_string_view/element_access/char/empty.cc:
11620         Fix year range in copyright header.
11621
11622 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11623
11624         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11625         Delete.
11626         <operator==>: Update with for removed field.
11627         <hash>: Likewise.
11628         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11629         <isa_features>: ...this.
11630         <abi_features>: New field.
11631         (riscv_isa_flen): Update comment.
11632         (riscv_abi_xlen): New declaration.
11633         (riscv_abi_flen): New declaration.
11634         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11635         isa_features.
11636         (riscv_abi_xlen): New function.
11637         (riscv_isa_flen): Update to get answer from isa_features.
11638         (riscv_abi_flen): New function.
11639         (riscv_has_fp_abi): Update to get answer from abi_features.
11640         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11641         xlen and flen.
11642         (riscv_call_info) <xlen, flen>: Update comment.
11643         (riscv_call_arg_struct): Remove invalid assertions
11644         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11645         is removed.
11646         (riscv_gdbarch_init): Gather isa features and abi features
11647         separately, ensure both match on the gdbarch when reusing an old
11648         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11649         a target with 64-bit float hardware.
11650
11651 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11652
11653         * source.c (search_command_helper): Stop reverse search
11654         when line 1 has been searched.
11655
11656 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11657
11658         * record-full.c (record_full_base_target::close): Rewrite
11659         record_full_core_buf_list free logic.
11660
11661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11662
11663         * break-catch-syscall.c (print_one_catch_syscall): xfree
11664         the last text.
11665
11666 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11667
11668         * top.c (print_gdb_version): Update Copyright year in version
11669         message.
11670
11671 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11672
11673         Update copyright year range in all GDB files.
11674
11675 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11676
11677         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11678
11679 For older changes see ChangeLog-2018.
11680 \f
11681 Local Variables:
11682 mode: change-log
11683 left-margin: 8
11684 fill-column: 74
11685 version-control: never
11686 coding: utf-8
11687 End:
11688