gdb/ChangeLog

   1 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
   4         (Write After Approval): Remove Tom de Vries.
   5
   6 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
   7
   8         revert partially:
   9         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  10
  11         * buildsym.c (record_line): Fix undefined behavior and preserve
  12         lines at eof.
  13
  14 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
  15
  16         * auxv.h (svr4_auxv_parse): New.
  17         * auxv.c (default_auxv_parse): Split into default_auxv_parse
  18         and generic_auxv_parse.
  19         (svr4_auxv_parse): Add.
  20         * obsd-tdep.c: Include "auxv.h".
  21         (obsd_auxv_parse): Remove.
  22         (obsd_init_abi): Remove comment.
  23         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
  24         from `obsd_auxv_parse' to `svr4_auxv_parse'.
  25         * nbsd-tdep.c: Include "auxv.h".
  26         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
  27
  28 2020-04-08  Tom Tromey  <tromey@adacore.com>
  29
  30         * nat/windows-nat.h (last_wait_event): Don't declare.
  31         (wait_for_debug_event): Update comment.
  32         * nat/windows-nat.c (last_wait_event): Now static.
  33
  34 2020-04-08  Tom Tromey  <tromey@adacore.com>
  35
  36         * windows-nat.c (wait_for_debug_event): Move to
  37         nat/windows-nat.c.
  38         * nat/windows-nat.h (wait_for_debug_event): Declare.
  39         * nat/windows-nat.c (wait_for_debug_event): Move from
  40         windows-nat.c.  No longer static.
  41
  42 2020-04-08  Tom Tromey  <tromey@adacore.com>
  43
  44         * windows-nat.c (get_windows_debug_event): Use
  45         fetch_pending_stop.
  46         * nat/windows-nat.h (fetch_pending_stop): Declare.
  47         * nat/windows-nat.c (fetch_pending_stop): New function.
  48
  49 2020-04-08  Tom Tromey  <tromey@adacore.com>
  50
  51         * windows-nat.c (windows_continue): Use matching_pending_stop and
  52         continue_last_debug_event.
  53         * nat/windows-nat.h (matching_pending_stop)
  54         (continue_last_debug_event): Declare.
  55         * nat/windows-nat.c (DEBUG_EVENTS): New define.
  56         (matching_pending_stop, continue_last_debug_event): New
  57         functions.
  58
  59 2020-04-08  Tom Tromey  <tromey@adacore.com>
  60
  61         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
  62         (handle_exception_result): Move to nat/windows-nat.h.
  63         (DEBUG_EXCEPTION_SIMPLE): Remove.
  64         (windows_nat::handle_ms_vc_exception): New function.
  65         (handle_exception): Move to nat/windows-nat.c.
  66         (get_windows_debug_event): Update.
  67         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
  68         nat/windows-nat.c.
  69         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
  70         (handle_exception_result): Move from windows-nat.c.
  71         (handle_exception): Declare.
  72         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
  73         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
  74         windows-nat.c.
  75
  76 2020-04-08  Tom Tromey  <tromey@adacore.com>
  77
  78         * windows-nat.c (exception_count, event_count): Remove.
  79         (handle_exception, get_windows_debug_event)
  80         (do_initial_windows_stuff): Update.
  81
  82 2020-04-08  Tom Tromey  <tromey@adacore.com>
  83
  84         * windows-nat.c (windows_nat::handle_load_dll)
  85         (windows_nat::handle_unload_dll): Rename.  No longer static.
  86         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
  87         Declare.
  88
  89 2020-04-08  Tom Tromey  <tromey@adacore.com>
  90
  91         * complaints.h (stop_whining): Declare at top-level.
  92         (complaint): Don't declare stop_whining.
  93
  94 2020-04-08  Tom Tromey  <tromey@adacore.com>
  95
  96         * windows-nat.c (windows_nat::handle_output_debug_string):
  97         Rename.  No longer static.
  98         * nat/windows-nat.h (handle_output_debug_string): Declare.
  99
 100 2020-04-08  Tom Tromey  <tromey@adacore.com>
 101
 102         * windows-nat.c (current_process_handle, current_process_id)
 103         (main_thread_id, last_sig, current_event, last_wait_event)
 104         (current_windows_thread, desired_stop_thread_id, pending_stops)
 105         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
 106         (display_selectors, fake_create_process)
 107         (get_windows_debug_event): Update.
 108         * nat/windows-nat.h (current_process_handle, current_process_id)
 109         (main_thread_id, last_sig, current_event, last_wait_event)
 110         (current_windows_thread, desired_stop_thread_id, pending_stops)
 111         (struct pending_stop, siginfo_er): Move from windows-nat.c.
 112         * nat/windows-nat.c (current_process_handle, current_process_id)
 113         (main_thread_id, last_sig, current_event, last_wait_event)
 114         (current_windows_thread, desired_stop_thread_id, pending_stops)
 115         (siginfo_er): New globals.  Move from windows-nat.c.
 116
 117 2020-04-08  Tom Tromey  <tromey@adacore.com>
 118
 119         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
 120         (handle_load_dll): Update.
 121         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
 122
 123 2020-04-08  Tom Tromey  <tromey@adacore.com>
 124
 125         * windows-nat.c (enum thread_disposition_type): Move to
 126         nat/windows-nat.h.
 127         (windows_nat::thread_rec): Rename from thread_rec.  No longer
 128         static.
 129         (windows_add_thread, windows_nat_target::fetch_registers)
 130         (windows_nat_target::store_registers, handle_exception)
 131         (windows_nat_target::resume, get_windows_debug_event)
 132         (windows_nat_target::get_tib_address)
 133         (windows_nat_target::thread_name)
 134         (windows_nat_target::thread_alive): Update.
 135         * nat/windows-nat.h (enum thread_disposition_type): Move from
 136         windows-nat.c.
 137         (thread_rec): Declare.
 138
 139 2020-04-08  Tom Tromey  <tromey@adacore.com>
 140
 141         * windows-nat.c: Add "using namespace".
 142         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
 143         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
 144
 145 2020-04-08  Tom Tromey  <tromey@adacore.com>
 146
 147         * nat/windows-nat.h (struct windows_thread_info): Declare
 148         destructor.
 149         * nat/windows-nat.c (~windows_thread_info): New.
 150
 151 2020-04-08  Tom Tromey  <tromey@adacore.com>
 152
 153         PR gdb/22992
 154         * windows-nat.c (current_event): Update comment.
 155         (last_wait_event, desired_stop_thread_id): New globals.
 156         (struct pending_stop): New.
 157         (pending_stops): New global.
 158         (windows_nat_target) <stopped_by_sw_breakpoint>
 159         <supports_stopped_by_sw_breakpoint>: New methods.
 160         (windows_fetch_one_register): Add assertions.  Adjust PC.
 161         (windows_continue): Handle pending stops.  Suspend other threads
 162         when stepping.  Use last_wait_event
 163         (wait_for_debug_event): New function.
 164         (get_windows_debug_event): Use wait_for_debug_event.  Handle
 165         pending stops.  Queue spurious stops.
 166         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
 167         (windows_nat_target::kill): Use wait_for_debug_event.
 168         * nat/windows-nat.h (struct windows_thread_info)
 169         <stopped_at_software_breakpoint>: New field.
 170         * nat/windows-nat.c (windows_thread_info::resume): Clear
 171         stopped_at_software_breakpoint.
 172
 173 2020-04-08  Tom Tromey  <tromey@adacore.com>
 174
 175         * windows-nat.c (enum thread_disposition_type): New.
 176         (thread_rec): Replace "get_context" parameter with "disposition";
 177         change type.
 178         (windows_add_thread, windows_nat_target::fetch_registers)
 179         (windows_nat_target::store_registers, handle_exception)
 180         (windows_nat_target::resume, get_windows_debug_event)
 181         (windows_nat_target::get_tib_address)
 182         (windows_nat_target::thread_name)
 183         (windows_nat_target::thread_alive): Update.
 184
 185 2020-04-08  Tom Tromey  <tromey@adacore.com>
 186
 187         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
 188         (windows_continue): Use windows_continue::resume.
 189         * nat/windows-nat.h (struct windows_thread_info) <suspend,
 190         resume>: Declare new methods.
 191         * nat/windows-nat.c: New file.
 192         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
 193
 194 2020-04-08  Tom Tromey  <tromey@adacore.com>
 195
 196         * windows-nat.c (windows_add_thread, windows_delete_thread)
 197         (windows_nat_target::fetch_registers)
 198         (windows_nat_target::store_registers, fake_create_process)
 199         (windows_nat_target::resume, windows_nat_target::resume)
 200         (get_windows_debug_event, windows_nat_target::wait)
 201         (windows_nat_target::pid_to_str)
 202         (windows_nat_target::get_tib_address)
 203         (windows_nat_target::get_ada_task_ptid)
 204         (windows_nat_target::thread_name)
 205         (windows_nat_target::thread_alive): Use lwp, not tid.
 206
 207 2020-04-08  Tom Tromey  <tromey@adacore.com>
 208
 209         * windows-nat.c (handle_exception)
 210         (windows_nat_target::thread_name): Update.
 211         * nat/windows-nat.h (windows_thread_info): Remove destructor.
 212         <name>: Now unique_xmalloc_ptr.
 213
 214 2020-04-08  Tom Tromey  <tromey@adacore.com>
 215
 216         * windows-nat.c (thread_rec)
 217         (windows_nat_target::fetch_registers): Update.
 218         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
 219         Update comment.
 220         <debug_registers_changed, reload_context>: Now bool.
 221
 222 2020-04-08  Tom Tromey  <tromey@adacore.com>
 223
 224         * windows-nat.c (windows_add_thread): Use new.
 225         (windows_init_thread_list, windows_delete_thread): Use delete.
 226         (get_windows_debug_event): Update.
 227         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
 228         destructor, and initializers.
 229
 230 2020-04-08  Tom Tromey  <tromey@adacore.com>
 231
 232         * windows-nat.c (struct windows_thread_info): Remove.
 233         * nat/windows-nat.h: New file.
 234
 235 2020-04-08  Tom Tromey  <tromey@adacore.com>
 236
 237         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
 238         (thread_rec, windows_add_thread, windows_delete_thread)
 239         (windows_continue): Update.
 240
 241 2020-04-08  Tom Tromey  <tromey@adacore.com>
 242
 243         * windows-nat.c (struct windows_thread_info): Remove typedef.
 244         (thread_head): Remove.
 245         (thread_list): New global.
 246         (thread_rec, windows_add_thread, windows_init_thread_list)
 247         (windows_delete_thread, windows_continue): Update.
 248
 249 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * windows-tdep.h (windows_init_abi): Add comment.
 252         (cygwin_init_abi): New declaration.
 253         * windows-tdep.c: Split signal enumeration in two, one for
 254         Windows and one for Cygwin.
 255         (windows_gdb_signal_to_target): Only deal with signal of the
 256         Windows OS ABI.
 257         (cygwin_gdb_signal_to_target): New function.
 258         (windows_init_abi): Rename to windows_init_abi_common, don't set
 259         gdb_signal_to_target gdbarch method.  Add new new function with
 260         this name.
 261         (cygwin_init_abi): New function.
 262         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
 263         comment.  Don't call windows_init_abi.
 264         (amd64_windows_init_abi): Add comment, call windows_init_abi.
 265         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
 266         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
 267         i386_windows_init_abi_common, don't call windows_init_abi.  Add
 268         a new function of this name.
 269         (i386_cygwin_init_abi): New function.
 270         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
 271         OS ABI Cygwin.
 272
 273 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
 274
 275         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
 276         parameter.c.
 277         (dwarf2_read_gdb_index): Update.
 278
 279 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
 280
 281         * nbsd-tdep.c: Include "objfiles.h".
 282         (nbsd_skip_solib_resolver): New.
 283         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
 284
 285 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 286
 287         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
 288         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
 289         with DW_LLE_base_addressx are being emitted in DWARFv5.
 290         Add the newly added kind DW_LOC_OFFSET_PAIR also.
 291         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
 292         unsigned integer.
 293
 294 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 295
 296         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
 297         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
 298         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
 299         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
 300         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
 301         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
 302         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
 303
 304
 305 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
 306
 307         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
 308         (read_loclist_index): New function definition.
 309         (lookup_loclist_base): New function definition.
 310         (read_loclist_header): New function definition.
 311         (dwarf2_cu): Add loclist_base and loclist_header field.
 312         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
 313         (read_full_die_1): Read the value of DW_AT_loclists_base.
 314         (read_attribute_reprocess): Handle DW_FORM_loclistx.
 315         (read_attribute_value): Handle DW_FORM_loclistx.
 316         (skip_one_die): Handle DW_FORM_loclistx.
 317         (loclist_header): New structure declaration.
 318         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
 319
 320 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
 321
 322         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
 323         constructor.  Remove `addr` parameter from other constructor and
 324         add `per_cu` parameter.
 325         * dwarf2/read.c (create_partial_symtab): Update.
 326
 327 2020-04-07  Tom de Vries  <tdevries@suse.de>
 328
 329         PR symtab/25796
 330         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
 331         (partial_die_info::fixup): Inherit has_const_value.
 332
 333 2020-04-07  Tom de Vries  <tdevries@suse.de>
 334
 335         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
 336         symbols without address.
 337
 338 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 339
 340         * nbsd-nat.h (struct thread_info): Add forward declaration.
 341         (nbsd_nat_target::thread_alive): Add.
 342         (nbsd_nat_target::thread_name): Likewise.
 343         (nbsd_nat_target::update_thread_list): Likewise.
 344         (update_thread_list::post_attach): Likewise.
 345         (post_attach::pid_to_str): Likewise.
 346         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
 347         (nbsd_thread_lister): Add.
 348         (nbsd_nat_target::thread_alive): Likewise.
 349         (nbsd_nat_target::thread_name): Likewise.
 350         (nbsd_add_threads): Likewise.
 351         (update_thread_list::post_attach): Likewise.
 352         (nbsd_nat_target::update_thread_list): Likewise.
 353         (post_attach::pid_to_str): Likewise.
 354
 355 2020-04-06  Tom Tromey  <tromey@adacore.com>
 356
 357         * ada-valprint.c (print_variant_part): Extract the variant field.
 358         (print_field_values): Use the field as the outer value when
 359         recursing.
 360
 361 2020-04-06  Tom Tromey  <tromey@adacore.com>
 362
 363         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
 364         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
 365         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
 366         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
 367         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
 368
 369 2020-04-06  Tom Tromey  <tromey@adacore.com>
 370
 371         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
 372         TYPE_CODE_ERROR.
 373
 374 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
 375
 376         * nbsd-tdep.c: Include "gdbarch.h".
 377         Define enum with NetBSD signal numbers.
 378         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
 379         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
 380         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
 381         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
 382         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
 383         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
 384         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
 385         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
 386         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
 387         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
 388         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
 389         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
 390
 391 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
 392
 393         PR gdb/25325
 394         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
 395
 396 2020-04-03  Tom Tromey  <tromey@adacore.com>
 397
 398         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
 399         Read constant block.
 400
 401 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 402
 403         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
 404         (gdb_bfd_get_full_section_contents): New declaration.
 405         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
 406         * windows-tdep.c (is_linked_with_cygwin_dll): Use
 407         gdb_bfd_get_full_section_contents.
 408
 409 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
 410
 411         * exec.c (build_section_table): Replace internal_error with
 412         gdb_assert.
 413         (section_table_xfer_memory_partial): Likewise.
 414         * mdebugread.c (parse_partial_symbols): Likewise.
 415         * psymtab.c (lookup_partial_symbol): Likewise.
 416         * utils.c (wrap_here): Likewise.
 417
 418 2020-04-02  Tom Tromey  <tromey@adacore.com>
 419
 420         * f-lang.c (build_fortran_types): Use arch_type to initialize
 421         builtin_complex_s32 in the TYPE_CODE_ERROR case.
 422
 423 2020-04-02  Tom Tromey  <tromey@adacore.com>
 424
 425         * dwarf2/read.c (partial_die_info::read): Do not create a vector
 426         of attributes.
 427
 428 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 429             Bernd Edlinger <bernd.edlinger@hotmail.de>
 430             Tom Tromey  <tromey@adacore.com>
 431
 432         * buildsym.c (buildsym_compunit::record_line): Remove
 433         deduplication code.
 434
 435 2020-04-02  Tom de Vries  <tdevries@suse.de>
 436
 437         PR ada/24671
 438         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
 439
 440 2020-04-02  Tom de Vries  <tdevries@suse.de>
 441
 442         * dwarf2/read.c (dwarf2_gdb_index_functions,
 443         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
 444         NULL.
 445         * psymtab.c (psym_lookup_global_symbol_language): New function.
 446         (psym_functions): Init psym_lookup_global_symbol_language with
 447         psym_lookup_global_symbol_language.
 448         * symfile-debug.c (debug_sym_quick_functions): Init
 449         lookup_global_symbol_language with NULL.
 450         * symfile.c (set_initial_language): Remove fixme comment.
 451         * symfile.h (struct quick_symbol_functions): Add
 452         lookup_global_symbol_language.
 453         * symtab.c (find_quick_global_symbol_language): New function.
 454         (find_main_name): Use find_quick_global_symbol_language.
 455
 456 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
 457
 458         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
 459
 460 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 461
 462         * buildsym.c (record_line): Fix undefined behavior and preserve
 463         lines at eof.
 464
 465 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 466
 467         * buildsym.c (record_line): Fix the resizing condition.
 468
 469 2020-04-01  Tom Tromey  <tom@tromey.com>
 470
 471         * value.h (value_literal_complex): Add comment.
 472         * valops.c (value_literal_complex): Refer to value.h.
 473
 474 2020-04-01  Tom Tromey  <tom@tromey.com>
 475
 476         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
 477         (scalar_type): New rule, from typebase.
 478         (typebase): Use scalar_type.  Recognize complex types.
 479         (field_name): Handle FLOAT_KEYWORD.
 480         (ident_tokens): Add _Complex and __complex__.
 481
 482 2020-04-01  Tom Tromey  <tom@tromey.com>
 483
 484         PR exp/25299:
 485         * valarith.c (promotion_type, complex_binop): New functions.
 486         (scalar_binop): Handle complex numbers.  Use promotion_type.
 487         (value_pos, value_neg, value_complement): Handle complex numbers.
 488
 489 2020-04-01  Tom Tromey  <tom@tromey.com>
 490
 491         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
 492         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
 493         (parse_number): Handle complex numbers.
 494
 495 2020-04-01  Tom Tromey  <tom@tromey.com>
 496
 497         * c-valprint.c (c_decorations): Change complex suffix to "i".
 498
 499 2020-04-01  Tom Tromey  <tom@tromey.com>
 500
 501         * valprint.c (generic_value_print_complex): Use accessors.
 502         * value.h (value_real_part, value_imaginary_part): Declare.
 503         * valops.c (value_real_part, value_imaginary_part): New
 504         functions.
 505         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
 506
 507 2020-04-01  Tom Tromey  <tom@tromey.com>
 508
 509         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
 510         (read_range_type): Update.
 511         * mdebugread.c (basic_type): Update.
 512         * go-lang.c (build_go_types): Use init_complex_type.
 513         * gdbtypes.h (struct main_type) <complex_type>: New member.
 514         (init_complex_type): Update.
 515         (arch_complex_type): Don't declare.
 516         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
 517         Make name if none given.  Use alloc_type_copy.  Look for cached
 518         complex type.
 519         (arch_complex_type): Remove.
 520         (gdbtypes_post_init): Use init_complex_type.
 521         * f-lang.c (build_fortran_types): Use init_complex_type.
 522         * dwarf2/read.c (read_base_type): Update.
 523         * d-lang.c (build_d_types): Use init_complex_type.
 524         * ctfread.c (read_base_type): Update.
 525
 526 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 527
 528         * infrun.c (stop_all_threads): Update assertion, plus when
 529         stopping threads, take into account that we might be trying
 530         to stop an all-stop target.
 531         (stop_waiting): Call 'stop_all_threads' if there exists a
 532         non-stop target.
 533
 534 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 535
 536         * target.h (exists_non_stop_target): New function declaration.
 537         * target.c (exists_non_stop_target): New function.
 538
 539 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
 540
 541         PR gdb/24789
 542         * eval.c (is_integral_or_integral_reference): New function.
 543         (evaluate_subexp_standard): Allow integer references in
 544         pointer arithmetic.
 545
 546 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 547
 548         * remote.c (remote_target::remote_parse_stop_reply): Remove the
 549         check for no ptid in the stop reply when the target is non-stop.
 550
 551 2020-04-01  Tom Tromey  <tromey@adacore.com>
 552
 553         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
 554         "name" parameter to rvalue reference.  Initialize m_name_holder.
 555         <lookup_name_info>: New overloads.
 556         <name>: Return gdb::string_view.
 557         <c_str>: New method.
 558         <make_ignore_params>: Update.
 559         <search_name_hash>: Update.
 560         <language_lookup_name>: Return const char *.
 561         <m_name>: Change type.
 562         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
 563         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
 564         (lookup_name_info::match_any): Update.
 565         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
 566         Update.
 567         * minsyms.c (linkage_name_str): Update.
 568         * language.c (default_symbol_name_matcher): Update.
 569         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
 570         Update.
 571         * ada-lang.c (ada_fold_name): Change parameter to string_view.
 572         (ada_lookup_name_info::ada_lookup_name_info): Update.
 573         (literal_symbol_name_matcher): Update.
 574
 575 2020-04-01  Tom Tromey  <tromey@adacore.com>
 576
 577         * psymtab.c (psymtab_search_name): Remove function.
 578         (psym_lookup_symbol): Create search name and lookup name here.
 579         (lookup_partial_symbol): Remove "name" parameter; add
 580         lookup_name.
 581         (psym_expand_symtabs_for_function): Update.
 582
 583 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
 584
 585         PR tui/25597:
 586         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
 587
 588 2020-03-31  Tom Tromey  <tromey@adacore.com>
 589
 590         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
 591         memcpy.
 592
 593 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
 594
 595         * features/riscv/32bit-csr.xml: Regenerated.
 596         * features/riscv/64bit-csr.xml: Regenerated.
 597
 598 2020-03-30  Tom Tromey  <tromey@adacore.com>
 599
 600         * ada-valprint.c (print_variant_part): Update.
 601         * ada-lang.h (ada_which_variant_applies): Update.
 602         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
 603         outer_valaddr parameters; replace with "outer" value parameter.
 604         (to_fixed_variant_branch_type): Update.
 605
 606 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 607
 608         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
 609         <list>.  Remove inclusion of observable.h.
 610         (PPC_DEBUG_CURRENT_VERSION): Move up define.
 611         (struct arch_lwp_info): New struct.
 612         (class ppc_linux_dreg_interface): New class.
 613         (struct ppc_linux_process_info): New struct.
 614         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
 615         <low_new_clone, low_forget_process, low_prepare_to_resume>
 616         <copy_thread_dreg_state, mark_thread_stale>
 617         <mark_debug_registers_changed, register_hw_breakpoint>
 618         <clear_hw_breakpoint, register_wp, clear_wp>
 619         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
 620         <num_memory_accesses, get_trigger_type>
 621         <create_watchpoint_request, hwdebug_point_cmp>
 622         <init_arch_lwp_info, get_arch_lwp_info>
 623         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
 624         methods.
 625         <struct ptid_hash>: New inner struct.
 626         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
 627         members.
 628         (saved_dabr_value, hwdebug_info, max_slots_number)
 629         (struct hw_break_tuple, struct thread_points, ppc_threads)
 630         (have_ptrace_hwdebug_interface)
 631         (hwdebug_find_thread_points_by_tid)
 632         (hwdebug_insert_point, hwdebug_remove_point): Remove.
 633         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
 634         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
 635         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
 636         use m_dreg_interface.
 637         (hwdebug_point_cmp): Change to...
 638         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
 639         reference arguments instead of pointers.
 640         (ppc_linux_nat_target::ranged_break_num_registers): Use
 641         m_dreg_interface.
 642         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
 643         m_dreg_interface.  Call register_hw_breakpoint.
 644         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
 645         m_dreg_interface.  Call clear_hw_breakpoint.
 646         (get_trigger_type): Change to...
 647         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
 648         comment.
 649         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
 650         use m_dreg_interface.  Call register_hw_breakpoint.
 651         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
 652         use m_dreg_interface.  Call clear_hw_breakpoint.
 653         (can_use_watchpoint_cond_accel): Change to...
 654         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
 655         method.  Update comment, use m_dreg_interface and
 656         m_process_info.
 657         (calculate_dvc): Change to...
 658         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
 659         m_dreg_interface.
 660         (num_memory_accesses): Change to...
 661         (ppc_linux_nat_target::num_memory_accesses): ...this method.
 662         (check_condition): Change to...
 663         (ppc_linux_nat_target::check_condition): ...this method.
 664         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
 665         comment, use m_dreg_interface.
 666         (create_watchpoint_request): Change to...
 667         (ppc_linux_nat_target::create_watchpoint_request): ...this
 668         method.  Use m_dreg_interface.
 669         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
 670         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
 671         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
 672         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
 673         (ppc_linux_nat_target::low_forget_process)
 674         (ppc_linux_nat_target::low_new_fork)
 675         (ppc_linux_nat_target::low_new_clone)
 676         (ppc_linux_nat_target::low_delete_thread)
 677         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
 678         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
 679         only call mark_thread_stale.
 680         (ppc_linux_thread_exit): Remove.
 681         (ppc_linux_nat_target::stopped_data_address): Change to...
 682         (ppc_linux_nat_target::low_stopped_data_address): This. Add
 683         comment, use m_dreg_interface and m_thread_hw_breakpoints.
 684         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
 685         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
 686         comment.  Call low_stopped_data_address.
 687         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
 688         m_dreg_interface.
 689         (ppc_linux_nat_target::masked_watch_num_registers): Use
 690         m_dreg_interface.
 691         (ppc_linux_nat_target::copy_thread_dreg_state)
 692         (ppc_linux_nat_target::mark_thread_stale)
 693         (ppc_linux_nat_target::mark_debug_registers_changed)
 694         (ppc_linux_nat_target::register_hw_breakpoint)
 695         (ppc_linux_nat_target::clear_hw_breakpoint)
 696         (ppc_linux_nat_target::register_wp)
 697         (ppc_linux_nat_target::clear_wp)
 698         (ppc_linux_nat_target::init_arch_lwp_info)
 699         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
 700         (_initialize_ppc_linux_nat): Remove observer callback.
 701
 702 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 703
 704         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
 705         (ppc_linux_nat_target::auxv_parse)
 706         (ppc_linux_nat_target::read_description)
 707         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
 708         Move up.
 709
 710 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 711
 712         * linux-nat.h (low_new_clone): New method.
 713         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
 714
 715 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 716
 717         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
 718         (dbx_expand_psymtab): ... this.
 719         (start_psymtab): Update.
 720         * mdebugread.c (psymtab_to_symtab_1): Rename to...
 721         (mdebug_expand_psymtab): ... this.
 722         (parse_partial_symbols): Update.
 723         (new_psymtab): Update.
 724         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
 725         (xcoff_expand_psymtab): ... this.
 726         (xcoff_start_psymtab): Update.
 727
 728 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 729
 730         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
 731         <expand_dependencies>: ... this.
 732         * psymtab.c (partial_symtab::read_dependencies): Rename to...
 733         (partial_symtab::expand_dependencies): ... this.
 734         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
 735         Update.
 736         (dwarf2_psymtab::expand_psymtab): Update.
 737         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
 738         * mdebugread.c (psymtab_to_symtab_1): Update.
 739         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 740
 741 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 742
 743         * psympriv.h (discard_psymtab): Remove.
 744         * dbxread.c (dbx_end_psymtab): Update.
 745         * xcoffread.c (xcoff_end_psymtab): Update.
 746
 747 2020-03-28  Tom Tromey  <tom@tromey.com>
 748
 749         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
 750         comment.
 751
 752 2020-03-28  Tom Tromey  <tom@tromey.com>
 753
 754         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
 755
 756 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
 757
 758         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 759
 760 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
 763
 764 2020-03-26  Tom Tromey  <tom@tromey.com>
 765
 766         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
 767         (mark_common_block_symbol_computed, read_tag_string_type)
 768         (attr_to_dynamic_prop, read_subrange_type): Update.
 769         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
 770         to be methods on struct attribute.
 771         (skip_one_die, process_imported_unit_die, read_namespace_alias)
 772         (read_call_site_scope, partial_die_info::read)
 773         (partial_die_info::read, lookup_die_type, follow_die_ref):
 774         Update.
 775         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
 776         from dwarf2_get_ref_die_offset.
 777         (attribute::constant_value): New method, from
 778         dwarf2_get_attr_constant_value.
 779         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
 780         Declare method.
 781         <constant_value>: New method.
 782
 783 2020-03-26  Tom Tromey  <tom@tromey.com>
 784
 785         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
 786         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
 787         (dwarf_type_encoding_name): Move to stringify.c.
 788         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
 789         * dwarf2/stringify.c: New file.
 790         * dwarf2/stringify.h: New file.
 791
 792 2020-03-26  Tom Tromey  <tom@tromey.com>
 793
 794         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
 795         Rewrite.
 796
 797 2020-03-26  Tom Tromey  <tom@tromey.com>
 798
 799         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
 800         methods.
 801         * dwarf2/read.c (lookup_addr_base): Move to die.h.
 802         (lookup_ranges_base): Likewise.
 803         (read_cutu_die_from_dwo, read_full_die_1): Update.
 804
 805 2020-03-26  Tom Tromey  <tom@tromey.com>
 806
 807         * dwarf2/read.c (read_import_statement, read_file_scope)
 808         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
 809         (read_lexical_block_scope, read_call_site_scope)
 810         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
 811         (handle_struct_member_die, process_structure_scope)
 812         (update_enumeration_type_from_children)
 813         (process_enumeration_scope, read_array_type, read_common_block)
 814         (read_namespace, read_module, read_subroutine_type): Update.
 815         (sibling_die): Remove.
 816
 817 2020-03-26  Tom Tromey  <tom@tromey.com>
 818
 819         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
 820         (build_type_psymtabs_reader, read_structure_type)
 821         (read_enumeration_type, read_full_die_1): Update.
 822         (dwarf2_attr_no_follow): Move to die.h.
 823         * dwarf2/die.h (struct die_info) <attr>: New method.
 824
 825 2020-03-26  Tom Tromey  <tom@tromey.com>
 826
 827         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
 828         <base_address>: Now an optional.
 829         (dwarf2_find_base_address, dwarf2_rnglists_process)
 830         (dwarf2_ranges_process, fill_in_loclist_baton)
 831         (dwarf2_symbol_mark_computed): Update.
 832
 833 2020-03-26  Tom Tromey  <tom@tromey.com>
 834
 835         * dwarf2/read.c (struct die_info): Move to die.h.
 836         * dwarf2/die.h: New file.
 837
 838 2020-03-26  Tom Tromey  <tom@tromey.com>
 839
 840         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
 841         * dwarf2/read.c
 842         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 843         Move to line-header.c.
 844         (read_checked_initial_length_and_offset, read_formatted_entries):
 845         Likewise.
 846         (dwarf_decode_line_header): Split into two.
 847         * dwarf2/line-header.c
 848         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 849         Move from read.c.
 850         (read_checked_initial_length_and_offset, read_formatted_entries):
 851         Likewise.
 852         (dwarf_decode_line_header): New function, split from read.c.
 853
 854 2020-03-26  Tom Tromey  <tom@tromey.com>
 855
 856         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
 857         Declare method.
 858         * dwarf2/read.c (read_attribute_value): Update.
 859         (dwarf2_per_objfile::read_line_string): Rename from
 860         read_indirect_line_string.
 861         (read_formatted_entries): Update.
 862
 863 2020-03-26  Tom Tromey  <tom@tromey.com>
 864
 865         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
 866         variable.
 867
 868 2020-03-26  Tom Tromey  <tom@tromey.com>
 869
 870         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
 871         const.
 872         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
 873         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
 874         parameter const.
 875
 876 2020-03-26  Tom Tromey  <tom@tromey.com>
 877
 878         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
 879         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
 880         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
 881         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
 882
 883 2020-03-26  Tom Tromey  <tom@tromey.com>
 884
 885         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
 886         file_names_size, file_full_name, file_file_name>: Use const.
 887         <file_name_at, file_names>: Add const overload.
 888         * dwarf2/line-header.c (line_header::file_file_name)
 889         (line_header::file_full_name): Update.
 890
 891 2020-03-26  Tom Tromey  <tom@tromey.com>
 892
 893         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
 894         (macro_start_file, consume_improper_spaces)
 895         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
 896         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
 897         (dwarf_decode_macros): Move to macro.c.
 898         * dwarf2/macro.c: New file.
 899         * dwarf2/macro.h: New file.
 900         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
 901
 902 2020-03-26  Tom Tromey  <tom@tromey.com>
 903
 904         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
 905         method.
 906         * dwarf2/section.c: New method.  From
 907         read_indirect_string_at_offset_from.
 908         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
 909         (read_indirect_string_at_offset_from): Move to section.c.
 910         (read_indirect_string_at_offset): Rewrite.
 911         (read_indirect_line_string_at_offset): Remove.
 912         (read_indirect_string, read_indirect_line_string)
 913         (dwarf_decode_macro_bytes): Update.
 914
 915 2020-03-26  Tom Tromey  <tom@tromey.com>
 916
 917         * dwarf2/section.h (struct dwarf2_section_info)
 918         <overload_complaint>: Declare.
 919         (dwarf2_section_buffer_overflow_complaint): Don't declare.
 920         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
 921         Rename from dwarf2_section_buffer_overflow_complaint.
 922         * dwarf2/read.c (skip_one_die, partial_die_info::read)
 923         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
 924
 925 2020-03-26  Tom Tromey  <tom@tromey.com>
 926
 927         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
 928         Declare.
 929         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
 930         Move from read.c.
 931         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
 932         to section.c.
 933
 934 2020-03-26  Tom Tromey  <tom@tromey.com>
 935
 936         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
 937
 938 2020-03-26  Tom Tromey  <tom@tromey.com>
 939
 940         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
 941         "builder".
 942         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
 943         parameter.
 944         (dwarf_decode_macros): Update.
 945
 946 2020-03-26  Tom Tromey  <tom@tromey.com>
 947
 948         * dwarf2/read.c (read_attribute_value): Update.
 949         (read_indirect_string_from_dwz): Move to dwz.c; change into
 950         method.
 951         (dwarf_decode_macro_bytes): Update.
 952         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
 953         * dwarf2/dwz.c: New file.
 954         * Makefile.in (COMMON_SFILES): Add dwz.c.
 955
 956 2020-03-26  Tom Tromey  <tom@tromey.com>
 957
 958         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
 959         * dwarf2/read.c: Add include.
 960         * dwarf2/index-write.c: Add include.
 961         * dwarf2/index-cache.c: Add include.
 962         * dwarf2/dwz.h: New file.
 963
 964 2020-03-25  Tom Tromey  <tom@tromey.com>
 965
 966         * compile/compile-object-load.c (get_out_value_type): Mention
 967         correct symbol name in error message.
 968
 969 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
 970
 971         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 972
 973 2020-03-25  Tom de Vries  <tdevries@suse.de>
 974
 975         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
 976         * symmisc.c (dump_symtab_1): Print user and includes fields.
 977         (maintenance_info_symtabs): Same.
 978
 979 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         PR gdb/25534
 982         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
 983         (riscv_regcache_cooked_write): New function.
 984         (riscv_push_dummy_call): Use new function.
 985         (riscv_return_value): Likewise.
 986
 987 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
 988
 989         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
 990         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
 991         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
 992         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
 993         * infrun.c (follow_fork): Likewise.
 994         (follow_fork_inferior): Likewise.
 995         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
 996         * linux-nat.h (class linux_nat_target): Likewise.
 997         * remote.c (class remote_target) <follow_fork>: Likewise.
 998         (remote_target::follow_fork): Likewise.
 999         * target-delegates.c: Re-generate.
1000         * target.c (default_follow_fork): Likewise.
1001         (target_follow_fork): Likewise.
1002         * target.h (struct target_ops) <follow_fork>: Likewise.
1003         (target_follow_fork): Likewise.
1004
1005 2020-03-24  Tom de Vries  <tdevries@suse.de>
1006
1007         * psymtab.c (maintenance_info_psymtabs): Print user field.
1008
1009 2020-03-20  Tom Tromey  <tromey@adacore.com>
1010
1011         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
1012         const.
1013         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
1014         const.
1015
1016 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
1017
1018         * ptrace.m4: Don't check for ptrace declaration.
1019         * config.in: Re-generate.
1020         * configure: Re-generate.
1021         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
1022         not defined.
1023
1024 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1025
1026         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
1027         `PTRACE_TYPE_RET'.
1028         * i386-bsd-nat.c (gdb_ptrace): Likewise.
1029         * sparc-nat.c (gdb_ptrace): Likewise.
1030         * x86-bsd-nat.c (gdb_ptrace): Likewise.
1031
1032 2020-03-20  Tom Tromey  <tromey@adacore.com>
1033
1034         * c-exp.y (lex_one_token): Fix assert.
1035
1036 2020-03-20  Tom Tromey  <tromey@adacore.com>
1037
1038         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
1039         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
1040         strncpy call.
1041
1042 2020-03-20  Tom Tromey  <tromey@adacore.com>
1043
1044         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
1045
1046 2020-03-20  Tom Tromey  <tromey@adacore.com>
1047
1048         * ada-valprint.c (print_variant_part): Remove parameters; switch
1049         to value-based API.
1050         (print_field_values): Likewise.
1051         (ada_val_print_struct_union): Likewise.
1052         (ada_value_print_1): Update.
1053
1054 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1055
1056         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
1057         nbsd_nat_target instead of inf_ptrace_target.
1058         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1059         nbsd_nat_target.
1060
1061 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1062
1063         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
1064         it to the ptrace call.
1065         * (store_registers): Likewise.
1066
1067 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
1068
1069         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
1070         it to the ptrace call.
1071         * (store_registers): Likewise.
1072
1073 2020-03-19  Luis Machado  <luis.machado@linaro.org>
1074
1075         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
1076         valid, fetch vg value from ptrace.
1077
1078 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1079         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
1080         * inf-ptrace.c: Likewise.
1081         * (gdb_ptrace): Add.
1082         * (inf_ptrace_target::resume): Update.
1083         * (inf_ptrace_target::xfer_partial): Likewise.
1084         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
1085         * (inf_ptrace_peek_poke): Update.
1086
1087 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
1088
1089         * x86-bsd-nat.c (gdb_ptrace): New.
1090         * (x86bsd_dr_set): Add new argument `ptid'.
1091         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
1092         x86bsd_dr_set_addr): Update.
1093
1094 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * remote.c (remote_target::process_stop_reply): Handle events for
1097         all threads differently.
1098
1099 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * completer.c (completion_tracker::remove_completion): Define new
1102         function.
1103         * completer.h (completion_tracker::remove_completion): Declare new
1104         function.
1105         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
1106         when adding a C++ function symbol.
1107
1108 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * completer.c (completion_tracker::completion_hash_entry): Define
1111         new class.
1112         (advance_to_filename_complete_word_point): Call
1113         recompute_lowest_common_denominator.
1114         (completion_tracker::completion_tracker): Call discard_completions
1115         to setup the hash table.
1116         (completion_tracker::discard_completions): Allow for being called
1117         from the constructor, pass new equal function, and element deleter
1118         when constructing the hash table.  Initialise new class member
1119         variables.
1120         (completion_tracker::maybe_add_completion): Remove use of
1121         m_entries_vec, and store more information into m_entries_hash.
1122         (completion_tracker::recompute_lcd_visitor): New function, most
1123         content taken from...
1124         (completion_tracker::recompute_lowest_common_denominator):
1125         ...here, this now just visits each item in the hash calling the
1126         above visitor.
1127         (completion_tracker::build_completion_result): Remove use of
1128         m_entries_vec, call recompute_lowest_common_denominator.
1129         * completer.h (completion_tracker::have_completions): Remove use
1130         of m_entries_vec.
1131         (completion_tracker::completion_hash_entry): Declare new class.
1132         (completion_tracker::recompute_lowest_common_denominator): Change
1133         function signature.
1134         (completion_tracker::recompute_lcd_visitor): Declare new function.
1135         (completion_tracker::m_entries_vec): Delete.
1136         (completion_tracker::m_entries_hash): Initialize to NULL.
1137         (completion_tracker::m_lowest_common_denominator_valid): New
1138         member variable.
1139         (completion_tracker::m_lowest_common_denominator_max_length): New
1140         member variable.
1141
1142 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1143
1144         * regformats/regdef.h: Put reg in gdb namespace.
1145
1146 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1147
1148         * i386-bsd-nat.c (gdb_ptrace): New.
1149         * (i386bsd_fetch_inferior_registers,
1150         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1151         * (i386bsd_fetch_inferior_registers,
1152         i386bsd_store_inferior_registers) Use gdb_ptrace.
1153
1154 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1155
1156         * amd64-bsd-nat.c (gdb_ptrace): New.
1157         * (amd64bsd_fetch_inferior_registers,
1158         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
1159         * (amd64bsd_fetch_inferior_registers,
1160         amd64bsd_store_inferior_registers) Use gdb_ptrace.
1161
1162 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1163
1164         * user-regs.c (user_reg::read): Rename to...
1165         (user_reg::xread): ...this.
1166         * (append_user_reg): Rename argument `read' to `xread'.
1167         * (user_reg_add_builtin): Likewise.
1168         * (user_reg_add): Likewise.
1169         * (value_of_user_reg): Likewise.
1170
1171 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1172
1173         * sparc-nat.c (gdb_ptrace): New.
1174         * sparc-nat.c (sparc_fetch_inferior_registers)
1175         (sparc_store_inferior_registers) Remove obsolete comment.
1176         * sparc-nat.c (sparc_fetch_inferior_registers)
1177         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
1178         * sparc-nat.c (sparc_fetch_inferior_registers)
1179         (sparc_store_inferior_registers) Use gdb_ptrace.
1180
1181 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1182
1183         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
1184         it to the ptrace call.
1185         * sh-nbsd-nat.c (store_registers): Likewise.
1186
1187 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1188
1189         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
1190         nbsd_nat_target instead of inf_ptrace_target.
1191         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1192         nbsd_nat_target.
1193
1194 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1195
1196         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
1197
1198 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
1199
1200         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
1201         <sys/sysctl.h>.
1202         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
1203
1204 2020-03-17  Tom de Vries  <tdevries@suse.de>
1205
1206         PR gdb/23710
1207         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
1208         fields.
1209         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
1210         fields.
1211         (process_imported_unit_die): Skip import of c++ CUs.
1212
1213 2020-03-16  Tom Tromey  <tom@tromey.com>
1214
1215         * p-valprint.c (pascal_object_print_value): Initialize
1216         base_value.
1217
1218 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
1219             Shahab Vahedi  <shahab@synopsys.com>
1220
1221         * Makefile.in: Add arch/arc.o
1222         * configure.tgt: Likewise.
1223         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
1224         (_initialize_arc_tdep): Don't initialize old target descriptions.
1225         (arc_read_description): New function to cache target descriptions.
1226         * arc-tdep.h (arc_read_description): Add proto type.
1227         * arch/arc.c: New file.
1228         * arch/arc.h: Likewise.
1229         * features/Makefile: Replace old target descriptions with new.
1230         * features/arc-arcompact.c: Remove.
1231         * features/arc-arcompact.xml: Likewise.
1232         * features/arc-v2.c: Likewise
1233         * features/arc-v2.xml: Likewise
1234         * features/arc/aux-arcompact.xml: New file.
1235         * features/arc/aux-v2.xml: Likewise.
1236         * features/arc/core-arcompact.xml: Likewise.
1237         * features/arc/core-v2.xml: Likewise.
1238         * features/arc/aux-arcompact.c: Generate.
1239         * features/arc/aux-v2.c: Likewise.
1240         * features/arc/core-arcompact.c: Likewise.
1241         * features/arc/core-v2.c: Likewise.
1242         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
1243
1244 2020-03-16  Tom Tromey  <tromey@adacore.com>
1245
1246         PR gdb/25663:
1247         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
1248         putting value into bcache.
1249
1250 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1251
1252         PR gdb/21500
1253         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
1254         to...
1255         (amd64_windows_init_abi_common): ... this.  Don't set size of
1256         long type.
1257         (amd64_windows_init_abi): New function.
1258         (amd64_cygwin_init_abi): New function.
1259         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
1260         the Cygwin OS ABI.
1261         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
1262         comment.
1263
1264 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1265
1266         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
1267         * windows-tdep.c (CYGWIN_DLL_NAME): New.
1268         (pe_import_directory_entry): New struct type.
1269         (is_linked_with_cygwin_dll): New function.
1270         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
1271         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
1272         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
1273
1274 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1275
1276         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
1277         i386_cygwin_core_osabi_sniffer.
1278
1279 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * i386-cygwin-tdep.c: Rename to...
1282         * i386-windows-tdep.c: ... this.
1283         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
1284         i386-windows-tdep.c.
1285         * configure.tgt: Likewise.
1286
1287 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1288
1289         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
1290         * osabi.c (gdb_osabi_names): Add "Windows".
1291         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
1292         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
1293         (i386_cygwin_core_osabi_sniffer): New function, extracted from
1294         i386_cygwin_osabi_sniffer.
1295         (_initialize_i386_cygwin_tdep): Register OS ABI
1296         GDB_OSABI_WINDOWS for i386.
1297         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
1298         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
1299         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
1300         for x86-64.
1301         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
1302         when the target matches '*-*-mingw*'.
1303
1304 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1305
1306         * defs.h (enum gdb_osabi): Move to...
1307         * osabi.h (enum gdb_osabi): ... here.
1308         * gdbarch.sh: Include osabi.h in gdbarch.h.
1309         * gdbarch.h: Re-generate.
1310
1311 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
1312
1313         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
1314         function.
1315         (_initialize_amd64_windows_tdep): Register osabi sniffer.
1316
1317 2020-03-14  Tom Tromey  <tom@tromey.com>
1318
1319         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
1320         for C++.
1321         (c_type_print_modifier): Likewise.  Add "language" parameter.
1322         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
1323         (c_type_print_base_1): Update.
1324         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
1325         constants.
1326         * type-stack.c (type_stack::insert): Handle tp_atomic and
1327         tp_restrict.
1328         (type_stack::follow_type_instance_flags): Likewise.
1329         (type_stack::follow_types): Likewise.  Merge type-following code.
1330         * c-exp.y (RESTRICT, ATOMIC): New tokens.
1331         (space_identifier, cv_with_space_id)
1332         (const_or_volatile_or_space_identifier_noopt)
1333         (const_or_volatile_or_space_identifier): Remove.
1334         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
1335         rules.
1336         (ptr_operator, typebase): Update.
1337         (enum token_flag) <FLAG_C>: New constant.
1338         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
1339         "_Atomic".
1340         (lex_one_token): Handle FLAG_C.
1341
1342 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1343
1344         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
1345         it to the ptrace call.
1346         * m68k-bsd-nat.c (store_registers): Likewise.
1347
1348 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1349
1350         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
1351         gdb_byte *.
1352         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
1353         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
1354         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
1355
1356 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1357
1358         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
1359         nbsd_nat_target instead of inf_ptrace_target.
1360         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1361         nbsd_nat_target.
1362
1363 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1364
1365         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
1366         register_t.
1367
1368 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1369
1370         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
1371         it to the ptrace call.
1372         * alpha-bsd-nat.c (store_registers): Likewise.
1373
1374 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1375
1376         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
1377         includes.
1378         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
1379         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
1380         fill_fpregset): Likewise.
1381
1382 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1383
1384         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
1385         nbsd_nat_target instead of inf_ptrace_target.
1386         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1387         nbsd_nat_target.
1388
1389 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1390
1391         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
1392         register_t.
1393
1394 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1395
1396         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
1397         it to the ptrace call.
1398         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
1399         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
1400         * arm-nbsd-nat.c (store_register): Likewise.
1401         * arm-nbsd-nat.c (store_regs): Likewise.
1402         * arm-nbsd-nat.c (store_fp_register): Likewise.
1403         * arm-nbsd-nat.c (store_fp_regs): Likewise.
1404
1405 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1406
1407         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
1408         nbsd_nat_target instead of inf_ptrace_target.
1409         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
1410         nbsd_nat_target.
1411
1412 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1413
1414         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
1415         it to the ptrace call.
1416         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
1417
1418 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1419
1420         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
1421         it to the ptrace call.
1422         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
1423
1424 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1425
1426         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
1427         gdb_byte *.
1428         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
1429
1430 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1431
1432         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
1433         instead of inf_ptrace_target.
1434         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
1435         nbsd_nat_target.
1436
1437 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1438
1439         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1440         register_t.
1441
1442 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1443
1444         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1445         register_t.
1446
1447 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
1448
1449         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
1450         register_t.
1451
1452 2020-03-13  Tom Tromey  <tom@tromey.com>
1453
1454         * value.h (val_print): Don't declare.
1455         * valprint.h (val_print_array_elements)
1456         (val_print_scalar_formatted, generic_val_print): Don't declare.
1457         * valprint.c (generic_val_print_array): Take a struct value.
1458         (generic_val_print_ptr, generic_val_print_memberptr)
1459         (generic_val_print_bool, generic_val_print_int)
1460         (generic_val_print_char, generic_val_print_complex)
1461         (generic_val_print): Remove.
1462         (generic_value_print): Update.
1463         (do_val_print): Remove unused parameters.  Don't call
1464         la_val_print.
1465         (val_print): Remove.
1466         (common_val_print): Update.  Don't call value_check_printable.
1467         (val_print_scalar_formatted, val_print_array_elements): Remove.
1468         * rust-lang.c (rust_val_print): Remove.
1469         (rust_language_defn): Update.
1470         * p-valprint.c (pascal_val_print): Remove.
1471         (pascal_value_print_inner): Update.
1472         (pascal_object_print_val_fields, pascal_object_print_val):
1473         Remove.
1474         (pascal_object_print_static_field): Update.
1475         * p-lang.h (pascal_val_print): Don't declare.
1476         * p-lang.c (pascal_language_defn): Update.
1477         * opencl-lang.c (opencl_language_defn): Update.
1478         * objc-lang.c (objc_language_defn): Update.
1479         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
1480         * m2-lang.h (m2_val_print): Don't declare.
1481         * m2-lang.c (m2_language_defn): Update.
1482         * language.h (struct language_defn) <la_val_print>: Remove.
1483         * language.c (unk_lang_value_print_inner): Rename.  Change
1484         argument types.
1485         (unknown_language_defn, auto_language_defn): Update.
1486         * go-valprint.c (go_val_print): Remove.
1487         * go-lang.h (go_val_print): Don't declare.
1488         * go-lang.c (go_language_defn): Update.
1489         * f-valprint.c (f_val_print): Remove.
1490         * f-lang.h (f_value_print): Don't declare.
1491         * f-lang.c (f_language_defn): Update.
1492         * d-valprint.c (d_val_print): Remove.
1493         * d-lang.h (d_value_print): Don't declare.
1494         * d-lang.c (d_language_defn): Update.
1495         * cp-valprint.c (cp_print_value_fields)
1496         (cp_print_value_fields_rtti, cp_print_value): Remove.
1497         (cp_print_static_field): Update.
1498         * c-valprint.c (c_val_print_array, c_val_print_ptr)
1499         (c_val_print_struct, c_val_print_union, c_val_print_int)
1500         (c_val_print_memberptr, c_val_print): Remove.
1501         * c-lang.h (c_val_print_array, cp_print_value_fields)
1502         (cp_print_value_fields_rtti): Don't declare.
1503         * c-lang.c (c_language_defn, cplus_language_defn)
1504         (asm_language_defn, minimal_language_defn): Update.
1505         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
1506         (ada_val_print_enum): Take a struct value.
1507         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
1508         (ada_val_print): Remove.
1509         (ada_value_print_1): Update.
1510         (printable_val_type): Remove.
1511         * ada-lang.h (ada_val_print): Don't declare.
1512         * ada-lang.c (ada_language_defn): Update.
1513
1514 2020-03-13  Tom Tromey  <tom@tromey.com>
1515
1516         * valprint.c (do_val_print): Update.
1517         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
1518         a struct value.
1519         (value_to_value_object_no_release): Declare.
1520         * python/py-value.c (value_to_value_object_no_release): New
1521         function.
1522         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
1523         struct value.
1524         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
1525         function.
1526         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
1527         a struct value.
1528         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
1529         Declare.
1530         (gdbscm_apply_val_pretty_printer): Take a struct value.
1531         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
1532         value.
1533         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
1534         value.
1535         * extension-priv.h (struct extension_language_ops)
1536         <apply_val_pretty_printer>: Take a struct value.
1537         * cp-valprint.c (cp_print_value): Create a struct value.
1538         (cp_print_value): Update.
1539
1540 2020-03-13  Tom Tromey  <tom@tromey.com>
1541
1542         * ada-valprint.c (print_field_values): Call common_val_print.
1543
1544 2020-03-13  Tom Tromey  <tom@tromey.com>
1545
1546         * ada-valprint.c (val_print_packed_array_elements): Remove
1547         bitoffset and val parameters.  Call common_val_print.
1548         (ada_val_print_string): Remove offset, address, and original_value
1549         parameters.
1550         (ada_val_print_array): Update.
1551         (ada_value_print_array): New function.
1552         (ada_value_print_1): Call it.
1553
1554 2020-03-13  Tom Tromey  <tom@tromey.com>
1555
1556         * ada-valprint.c (ada_value_print): Use common_val_print.
1557
1558 2020-03-13  Tom Tromey  <tom@tromey.com>
1559
1560         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
1561
1562 2020-03-13  Tom Tromey  <tom@tromey.com>
1563
1564         * ada-valprint.c (ada_value_print_num): New function.
1565         (ada_value_print_1): Use it.
1566
1567 2020-03-13  Tom Tromey  <tom@tromey.com>
1568
1569         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
1570
1571 2020-03-13  Tom Tromey  <tom@tromey.com>
1572
1573         * ada-valprint.c (ada_value_print_ptr): New function.
1574         (ada_value_print_1): Use it.
1575
1576 2020-03-13  Tom Tromey  <tom@tromey.com>
1577
1578         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
1579         call common_val_print.
1580         (ada_val_print_1): Update.
1581         (ada_value_print_1): New function.
1582         (ada_value_print_inner): Rewrite.
1583
1584 2020-03-13  Tom Tromey  <tom@tromey.com>
1585
1586         * cp-valprint.c (cp_print_value_fields): Update.
1587         (cp_print_value): New function.
1588
1589 2020-03-13  Tom Tromey  <tom@tromey.com>
1590
1591         * m2-valprint.c (m2_value_print_inner): Use
1592         cp_print_value_fields.
1593         * cp-valprint.c (cp_print_value_fields): New function.
1594         * c-valprint.c (c_value_print_struct): New function.
1595         (c_value_print_inner): Use c_value_print_struct.
1596         * c-lang.h (cp_print_value_fields): Declare.
1597
1598 2020-03-13  Tom Tromey  <tom@tromey.com>
1599
1600         * c-valprint.c (c_value_print_array): New function.
1601         (c_value_print_inner): Use it.
1602
1603 2020-03-13  Tom Tromey  <tom@tromey.com>
1604
1605         * c-valprint.c (c_value_print_memberptr): New function.
1606         (c_value_print_inner): Use it.
1607
1608 2020-03-13  Tom Tromey  <tom@tromey.com>
1609
1610         * c-valprint.c (c_value_print_int): New function.
1611         (c_value_print_inner): Use it.
1612
1613 2020-03-13  Tom Tromey  <tom@tromey.com>
1614
1615         * c-valprint.c (c_value_print_ptr): New function.
1616         (c_value_print_inner): Use it.
1617
1618 2020-03-13  Tom Tromey  <tom@tromey.com>
1619
1620         * c-valprint.c (c_value_print_inner): Rewrite.
1621
1622 2020-03-13  Tom Tromey  <tom@tromey.com>
1623
1624         * valprint.c (generic_value_print_complex): New function.
1625         (generic_value_print): Use it.
1626
1627 2020-03-13  Tom Tromey  <tom@tromey.com>
1628
1629         * valprint.c (generic_val_print_float): Don't call
1630         val_print_scalar_formatted.
1631         (generic_val_print, generic_value_print): Update.
1632
1633 2020-03-13  Tom Tromey  <tom@tromey.com>
1634
1635         * valprint.c (generic_value_print_char): New function
1636         (generic_value_print): Use it.
1637
1638 2020-03-13  Tom Tromey  <tom@tromey.com>
1639
1640         * valprint.c (generic_value_print_int): New function.
1641         (generic_value_print): Use it.
1642
1643 2020-03-13  Tom Tromey  <tom@tromey.com>
1644
1645         * valprint.c (generic_value_print_bool): New function.
1646         (generic_value_print): Use it.
1647
1648 2020-03-13  Tom Tromey  <tom@tromey.com>
1649
1650         * valprint.c (generic_val_print_func): Simplify.
1651         (generic_val_print, generic_value_print): Update.
1652
1653 2020-03-13  Tom Tromey  <tom@tromey.com>
1654
1655         * valprint.c (generic_val_print_flags): Remove.
1656         (generic_val_print, generic_value_print): Update.
1657         (val_print_type_code_flags): Add original_value parameter.
1658
1659 2020-03-13  Tom Tromey  <tom@tromey.com>
1660
1661         * valprint.c (generic_val_print): Update.
1662         (generic_value_print): Update.
1663         * valprint.c (generic_val_print_enum): Don't call
1664         val_print_scalar_formatted.
1665
1666 2020-03-13  Tom Tromey  <tom@tromey.com>
1667
1668         * valprint.c (generic_value_print): Call generic_value_print_ptr.
1669         * valprint.c (generic_value_print_ptr): New function.
1670
1671 2020-03-13  Tom Tromey  <tom@tromey.com>
1672
1673         * valprint.c (generic_value_print): Rewrite.
1674
1675 2020-03-13  Tom Tromey  <tom@tromey.com>
1676
1677         * p-valprint.c (pascal_object_print_value_fields)
1678         (pascal_object_print_value): New functions.
1679
1680 2020-03-13  Tom Tromey  <tom@tromey.com>
1681
1682         * p-valprint.c (pascal_value_print_inner): Rewrite.
1683
1684 2020-03-13  Tom Tromey  <tom@tromey.com>
1685
1686         * f-valprint.c (f_value_print_innner): Rewrite.
1687
1688 2020-03-13  Tom Tromey  <tom@tromey.com>
1689
1690         * m2-valprint.c (m2_print_unbounded_array): New overload.
1691         (m2_print_unbounded_array): Update.
1692         (m2_print_array_contents): Take a struct value.
1693         (m2_value_print_inner): Rewrite.
1694
1695 2020-03-13  Tom Tromey  <tom@tromey.com>
1696
1697         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
1698         (d_value_print_inner): New function.
1699         * d-lang.h (d_value_print_inner): Declare.
1700         * d-lang.c (d_language_defn): Use d_value_print_inner.
1701
1702 2020-03-13  Tom Tromey  <tom@tromey.com>
1703
1704         * go-valprint.c (go_value_print_inner): New function.
1705         * go-lang.h (go_value_print_inner): Declare.
1706         * go-lang.c (go_language_defn): Use go_value_print_inner.
1707
1708 2020-03-13  Tom Tromey  <tom@tromey.com>
1709
1710         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
1711         API.
1712         (rust_val_print): Rewrite.
1713         (rust_value_print_inner): New function, from rust_val_print.
1714         (rust_language_defn): Use rust_value_print_inner.
1715
1716 2020-03-13  Tom Tromey  <tom@tromey.com>
1717
1718         * ada-valprint.c (ada_value_print_inner): New function.
1719         * ada-lang.h (ada_value_print_inner): Declare.
1720         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
1721
1722 2020-03-13  Tom Tromey  <tom@tromey.com>
1723
1724         * f-valprint.c (f_value_print_innner): New function.
1725         * f-lang.h (f_value_print_innner): Declare.
1726         * f-lang.c (f_language_defn): Use f_value_print_innner.
1727
1728 2020-03-13  Tom Tromey  <tom@tromey.com>
1729
1730         * p-valprint.c (pascal_value_print_inner): New function.
1731         * p-lang.h (pascal_value_print_inner): Declare.
1732         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
1733
1734 2020-03-13  Tom Tromey  <tom@tromey.com>
1735
1736         * m2-valprint.c (m2_value_print_inner): New function.
1737         * m2-lang.h (m2_value_print_inner): Declare.
1738         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
1739
1740 2020-03-13  Tom Tromey  <tom@tromey.com>
1741
1742         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
1743         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
1744         * c-valprint.c (c_value_print_inner): New function.
1745         * c-lang.h (c_value_print_inner): Declare.
1746         * c-lang.c (c_language_defn, cplus_language_defn)
1747         (asm_language_defn, minimal_language_defn): Use
1748         c_value_print_inner.
1749
1750 2020-03-13  Tom Tromey  <tom@tromey.com>
1751
1752         * p-valprint.c (pascal_object_print_value_fields): Now static.
1753         * p-lang.h (pascal_object_print_value_fields): Don't declare.
1754
1755 2020-03-13  Tom Tromey  <tom@tromey.com>
1756
1757         * c-valprint.c (c_val_print_array): Simplify.
1758
1759 2020-03-13  Tom Tromey  <tom@tromey.com>
1760
1761         * valprint.c (value_print_array_elements): New function.
1762         * valprint.h (value_print_array_elements): Declare.
1763
1764 2020-03-13  Tom Tromey  <tom@tromey.com>
1765
1766         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
1767         * mips-tdep.c (mips_print_register): Use
1768         value_print_scalar_formatted.
1769
1770 2020-03-13  Tom Tromey  <tom@tromey.com>
1771
1772         * valprint.h (value_print_scalar_formatted): Declare.
1773         * valprint.c (value_print_scalar_formatted): New function.
1774
1775 2020-03-13  Tom Tromey  <tom@tromey.com>
1776
1777         * valprint.h (generic_value_print): Declare.
1778         * valprint.c (generic_value_print): New function.
1779
1780 2020-03-13  Tom Tromey  <tom@tromey.com>
1781
1782         * valprint.c (do_val_print): Call la_value_print_inner, if
1783         available.
1784         * rust-lang.c (rust_language_defn): Update.
1785         * p-lang.c (pascal_language_defn): Update.
1786         * opencl-lang.c (opencl_language_defn): Update.
1787         * objc-lang.c (objc_language_defn): Update.
1788         * m2-lang.c (m2_language_defn): Update.
1789         * language.h (struct language_defn) <la_value_print_inner>: New
1790         member.
1791         * language.c (unknown_language_defn, auto_language_defn): Update.
1792         * go-lang.c (go_language_defn): Update.
1793         * f-lang.c (f_language_defn): Update.
1794         * d-lang.c (d_language_defn): Update.
1795         * c-lang.c (c_language_defn, cplus_language_defn)
1796         (asm_language_defn, minimal_language_defn): Update.
1797         * ada-lang.c (ada_language_defn): Update.
1798
1799 2020-03-13  Tom Tromey  <tom@tromey.com>
1800
1801         * c-valprint.c (c_value_print): Use common_val_print.
1802
1803 2020-03-13  Tom Tromey  <tom@tromey.com>
1804
1805         * cp-valprint.c (cp_print_static_field): Use common_val_print.
1806
1807 2020-03-13  Tom Tromey  <tom@tromey.com>
1808
1809         * f-valprint.c (f77_print_array_1, f_val_print): Use
1810         common_val_print.
1811
1812 2020-03-13  Tom Tromey  <tom@tromey.com>
1813
1814         * riscv-tdep.c (riscv_print_one_register_info): Use
1815         common_val_print.
1816
1817 2020-03-13  Tom Tromey  <tom@tromey.com>
1818
1819         * mi/mi-main.c (output_register): Use common_val_print.
1820
1821 2020-03-13  Tom Tromey  <tom@tromey.com>
1822
1823         * infcmd.c (default_print_one_register_info): Use
1824         common_val_print.
1825
1826 2020-03-13  Tom Tromey  <tom@tromey.com>
1827
1828         * valprint.h (common_val_print_checked): Declare.
1829         * valprint.c (common_val_print_checked): New function.
1830         * stack.c (print_frame_arg): Use common_val_print_checked.
1831
1832 2020-03-13  Tom Tromey  <tom@tromey.com>
1833
1834         * valprint.c (do_val_print): New function, from val_print.
1835         (val_print): Use do_val_print.
1836         (common_val_print): Use do_val_print.
1837
1838 2020-03-13  Tom Tromey  <tom@tromey.com>
1839
1840         * valprint.c (value_print): Use scoped_value_mark.
1841
1842 2020-03-13  Tom de Vries  <tdevries@suse.de>
1843
1844         PR symtab/25646
1845         * psymtab.c (partial_symtab::partial_symtab): Don't set
1846         globals_offset and statics_offset.  Push element onto
1847         current_global_psymbols and current_static_psymbols stacks.
1848         (concat): New function.
1849         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
1850         element from current_global_psymbols and current_static_psymbols
1851         stacks.  Concat popped elements to global_psymbols and
1852         static_symbols.
1853         (add_psymbol_to_list): Use current_global_psymbols and
1854         current_static_psymbols stacks.
1855         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
1856         current_static_psymbols fields.
1857
1858 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1859
1860         * corelow.c (sniff_core_bfd): Remove.
1861         (class core_target) <m_core_vec>: Remove.
1862         (core_target::core_target): Update.
1863         (core_file_fns): Remove.
1864         (deprecated_add_core_fns): Remove.
1865         (default_core_sniffer): Remove.
1866         (sniff_core_bfd): Remove.
1867         (default_check_format): Remove.
1868         (gdb_check_format): Remove.
1869         (core_target_open): Update.
1870         (core_target::get_core_register_section): Update.
1871         (get_core_registers_cb): Update.
1872         (core_target::fetch_registers): Update.
1873         * gdbcore.h (struct core_fns): Remove.
1874         (deprecated_add_core_fns): Remove.
1875         (default_core_sniffer): Remove.
1876         (default_check_format): Remove.
1877
1878 2020-03-12  Tom Tromey  <tom@tromey.com>
1879
1880         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
1881         CORE_ADDR.
1882         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
1883
1884 2020-03-12  Tom Tromey  <tom@tromey.com>
1885
1886         * remote.c (remote_target::download_tracepoint)
1887         (remote_target::enable_tracepoint)
1888         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
1889         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
1890         sprintf_vma.
1891
1892 2020-03-12  Tom Tromey  <tom@tromey.com>
1893
1894         * symfile-mem.c: Update CORE_ADDR size assert.
1895
1896 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1897
1898         * selftest.m4: Move to gdbsupport/.
1899         * acinclude.m4: Update path to selftest.m4.
1900
1901 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1902
1903         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
1904         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
1905         gdbarch-selfselftests.c and selftest-arch.c.
1906         (SUBDIR_UNITTESTS_OBS): Rename to...
1907         (SELFTESTS_OBS): ... this.
1908         (COMMON_SFILES): Remove disasm-selftests.c and
1909         gdbarch-selftests.c.
1910         * configure.ac: Don't add selftest-arch.{c,o} to
1911         CONFIG_{SRCS,OBS}.
1912         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
1913         preprocessor conditions.
1914
1915 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1916
1917         * configure.ac: Don't source bfd/development.sh.
1918         * selftest.m4: Modify comment.
1919         * configure: Re-generate.
1920
1921 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1922
1923         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
1924         not "true" or "false".
1925         * configure: Re-generate.
1926
1927 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1928
1929         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
1930         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
1931         renamed to arm_nbsd_supply_gregset.
1932         (fetch_register): Update to call arm_nbsd_supply_gregset.
1933         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
1934         (arm_netbsd_nat_target::fetch_registers): Update.
1935         (fetch_elfcore_registers): Removed.
1936         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
1937         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
1938         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
1939         not require NetBSD system headers.
1940         (arm_nbsd_regset): New struct.
1941         (arm_nbsd_iterate_over_regset_sections): New function.
1942         (arm_netbsd_init_abi_common): Updated to call
1943         set_gdbarch_iterate_over_regset_sections.
1944         * arm-nbsd-tdep.h: New file.
1945
1946 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
1947
1948         * symtab.c (find_pc_sect_line): Add check which prevents infinite
1949         recursion.
1950
1951 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
1952
1953         * configure: Re-generate.
1954
1955 2020-03-11  Tom Tromey  <tromey@adacore.com>
1956
1957         * ada-typeprint.c (print_choices): Fix comment.
1958
1959 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
1962         previous item in the list, when the list has no items.
1963
1964 2020-03-11  Tom de Vries  <tdevries@suse.de>
1965
1966         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
1967         PROP_LOCLIST handling code.
1968
1969 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         * buildsym-legacy.c (record_line): Pass extra parameter to
1972         record_line.
1973         * buildsym.c (buildsym_compunit::record_line): Take an extra
1974         parameter, reduce duplication in the line table, and record the
1975         is_stmt flag in the line table.
1976         * buildsym.h (buildsym_compunit::record_line): Add extra
1977         parameter.
1978         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1979         non-statement lines.
1980         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1981         this to the symtab builder.
1982         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1983         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1984         through to dwarf_record_line_1.
1985         * infrun.c (process_event_stop_test): When stepping, don't stop at
1986         a non-statement instruction, and only refresh the step info when
1987         we land in the middle of a line's range.  Also add an extra
1988         comment.
1989         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1990         field.
1991         * record-btrace.c (btrace_find_line_range): Only record lines
1992         marked as is-statement.
1993         * stack.c (frame_show_address): Show the frame address if we are
1994         in a non-statement sal.
1995         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1996         (maintenance_print_one_line_table): Print a header for the is_stmt
1997         column, and include is_stmt information in the output.
1998         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1999         preference to non-statements.
2000         (find_pcs_for_symtab_line): Prefer is-statement entries.
2001         (find_line_common): Likewise.
2002         * symtab.h (struct linetable_entry): Add is_stmt field.
2003         (struct symtab_and_line): Likewise.
2004         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
2005         arranging the line table.
2006
2007 2020-03-07  Tom de Vries  <tdevries@suse.de>
2008
2009         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
2010         DIE.
2011
2012 2020-03-07  Tom Tromey  <tom@tromey.com>
2013
2014         * valops.c (value_literal_complex): Remove obsolete comment.
2015         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
2016         comment.
2017
2018 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2019
2020         * infrun.h: Forward-declare thread_info.
2021         (set_step_info): Add thread_info parameter, add doc.
2022         * infrun.c (set_step_info): Add thread_info parameter, move doc
2023         to header.
2024         * infrun.c (process_event_stop_test): Pass thread to
2025         set_step_info call.
2026         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
2027         set_step_info.
2028         (prepare_one_step): Add thread_info parameter, pass it to
2029         set_step_frame and prepare_one_step (recursive) call.
2030         (step_1): Pass thread to prepare_one_step call.
2031         (step_command_fsm::should_stop): Pass thread to
2032         prepare_one_step.
2033         (until_next_fsm): Pass thread to set_step_frame call.
2034         (finish_command): Pass thread to set_step_info call.
2035
2036 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
2037
2038         * windows-tdep.c (windows_solib_create_inferior_hook):
2039         Check if inferior is running.
2040
2041 2020-03-06  Tom de Vries  <tdevries@suse.de>
2042
2043         * NEWS: Fix "the the".
2044         * ctfread.c: Same.
2045
2046 2020-03-06  Tom de Vries  <tdevries@suse.de>
2047
2048         * psymtab.c (psymtab_to_symtab): Don't print "done.".
2049
2050 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * .dir-locals.el: Add a comment referencing the other copies of
2053         this file.
2054
2055 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
2056
2057         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
2058         psargs.
2059
2060 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2061
2062         * .gitattributes: New file.
2063
2064 2020-03-04  Tom Tromey  <tom@tromey.com>
2065
2066         * symmisc.c (print_symbol_bcache_statistics)
2067         (print_objfile_statistics): Update.
2068         * symfile.c (allocate_symtab): Use intern.
2069         * psymtab.c (partial_symtab::partial_symtab): Use intern.
2070         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2071         macro_cache>: Remove.
2072         <string_cache>: New member.
2073         (struct objfile) <intern>: New methods.
2074         * elfread.c (elf_symtab_read): Use intern.
2075         * dwarf2/read.c (fixup_go_packaging): Intern package name.
2076         (dwarf2_compute_name, dwarf2_physname)
2077         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
2078         names.
2079         (guess_partial_die_structure_name): Update.
2080         (partial_die_info::fixup): Intern name.
2081         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
2082         name.
2083         (dwarf2_name): Intern name.  Update.
2084         * buildsym.c (buildsym_compunit::get_macro_table): Use
2085         string_cache.
2086
2087 2020-03-04  Tom Tromey  <tom@tromey.com>
2088
2089         * jit.c (bfd_open_from_target_memory): Make "target" const.
2090         * corefile.c (gnutarget): Now const.
2091         * gdbcore.h (gnutarget): Now const.
2092
2093 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
2094
2095         * NEWS: Mention support for WOW64 processes.
2096         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
2097         (amd64_windows_segment_register_p): Remove static.
2098         (_initialize_amd64_windows_nat): Update.
2099         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
2100         * i386-windows-nat.c (context_offset): Update.
2101         (i386_mappings): Rename and remove static.
2102         (i386_windows_segment_register_p): Remove static.
2103         (_initialize_i386_windows_nat): Update.
2104         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
2105         (STATUS_WX86_SINGLE_STEP): New macro.
2106         (EnumProcessModulesEx): New macro.
2107         (Wow64SuspendThread): New macro.
2108         (Wow64GetThreadContext): New macro.
2109         (Wow64SetThreadContext): New macro.
2110         (Wow64GetThreadSelectorEntry): New macro.
2111         (windows_set_context_register_offsets): Add static.
2112         (windows_set_segment_register_p): Likewise.
2113         (windows_add_thread): Adapt for WOW64 processes.
2114         (windows_fetch_one_register): Likewise.
2115         (windows_nat_target::fetch_registers): Likewise.
2116         (windows_store_one_register): Likewise.
2117         (display_selector): Likewise.
2118         (display_selectors): Likewise.
2119         (handle_exception): Likewise.
2120         (windows_continue): Likewise.
2121         (windows_nat_target::resume): Likewise.
2122         (windows_add_all_dlls): Likewise.
2123         (do_initial_windows_stuff): Likewise.
2124         (windows_nat_target::attach): Likewise.
2125         (windows_get_exec_module_filename): Likewise.
2126         (windows_nat_target::create_inferior): Likewise.
2127         (windows_xfer_siginfo): Likewise.
2128         (_initialize_loadable): Initialize Wow64SuspendThread,
2129         Wow64GetThreadContext, Wow64SetThreadContext,
2130         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
2131         * windows-nat.h (windows_set_context_register_offsets):
2132         Remove declaration.
2133         (windows_set_segment_register_p): Likewise.
2134         (i386_windows_segment_register_p): Add declaration.
2135         (amd64_windows_segment_register_p): Likewise.
2136
2137 2020-03-04  Luis Machado  <luis.machado@linaro.org>
2138
2139         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
2140         in "info registers" for AArch64/ARM.
2141
2142         The change caused "info registers" to not print GPR's.
2143
2144         gdb/ChangeLog:
2145
2146         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
2147
2148         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
2149         when reg->group is empty and reggroup is not.
2150
2151 2020-03-03  Tom Tromey  <tromey@adacore.com>
2152
2153         * dwarf2/frame.c (struct dwarf2_frame_cache)
2154         <checked_tailcall_bottom, entry_cfa_sp_offset,
2155         entry_cfa_sp_offset_p>: Remove members.
2156         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
2157         (dwarf2_frame_prev_register): Don't call
2158         dwarf2_tailcall_sniffer_first.
2159         (dwarf2_append_unwinders): Don't append tailcall unwinder.
2160         * frame-unwind.c (add_unwinder): New fuction.
2161         (frame_unwind_init): Use it.  Add tailcall unwinder.
2162
2163 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2164             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2165
2166         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
2167         value should be printed as true.
2168
2169 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
2170
2171         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
2172         (windows_init_abi): Set and use windows_so_ops.
2173
2174 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
2175
2176         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
2177         when verifying if dealing with a convenience variable.
2178
2179 2020-03-03  Luis Machado  <luis.machado@linaro.org>
2180
2181         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
2182
2183 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2184
2185         * infrun.c (gdbarch_supports_displaced_stepping): New.
2186         (use_displaced_stepping): Break up conditions in smaller pieces.
2187         Use gdbarch_supports_displaced_stepping.
2188         (displaced_step_prepare_throw): Use
2189         gdbarch_supports_displaced_stepping.
2190
2191 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * NEWS: Mention new behaviour of the history filename.
2194         * top.c (write_history_p): Add comment.
2195         (show_write_history_p): Add header comment, give a different
2196         message when history writing is on, but the history filename is
2197         empty.
2198         (history_filename): Add comment.
2199         (history_filename_empty): New function.
2200         (show_history_filename): Add header comment, give a different
2201         message when the filename is empty.
2202         (init_history): Compare history_filename against nullptr, and only
2203         read history if the filename is not empty.
2204         (set_history_filename): Add header comment, and only make
2205         non-empty filenames absolute.
2206         (init_main): Make the filename argument to 'set history filename'
2207         optional.
2208
2209 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
2210
2211         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
2212         (arm_supply_vfpregset): ...this, and update to use VFP registers.
2213         (fetch_fp_register): Update.
2214         (fetch_fp_regs): Update.
2215         (store_fp_register): Update.
2216         (store_fp_regs): Update.
2217         (arm_netbsd_nat_target::read_description): New function.
2218         (fetch_elfcore_registers): Update.
2219
2220 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
2223         general_thread if the stop reply is missing a thread-id.
2224         (remote_target::process_stop_reply): Use the first non-exited
2225         thread if the target didn't pass a thread-id.
2226         * infrun.c (do_target_wait): Move call to
2227         switch_to_inferior_no_thread to ....
2228         (do_target_wait_1): ... here.
2229
2230 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
2231
2232         * debuginfod-support.c: Include defs.h first.
2233
2234 2020-02-28  Tom de Vries  <tdevries@suse.de>
2235
2236         * symfile.c (set_initial_language): Use default language for lookup.
2237
2238 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
2239
2240         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
2241         reader variable, pass `this` to read_cutu_die_from_dwo.
2242
2243 2020-02-27  Aaron Merey  <amerey@redhat.com>
2244
2245         * source.c (open_source_file): Check for nullptr when computing
2246         srcpath.
2247
2248 2020-02-27  Tom Tromey  <tromey@adacore.com>
2249
2250         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
2251         member.
2252         (dwarf2_add_field): Don't update nfields.
2253         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
2254
2255 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
2258         abs.
2259
2260 2020-02-26  Tom Tromey  <tom@tromey.com>
2261
2262         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
2263         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
2264         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
2265         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
2266         per_cu_data.
2267
2268 2020-02-26  Tom Tromey  <tom@tromey.com>
2269
2270         * dwarf2/index-write.c (psym_index_map): Change type.
2271         (add_address_entry_worker, write_one_signatured_type)
2272         (recursively_count_psymbols, recursively_write_psymbols)
2273         (class debug_names, psyms_seen_size, write_gdbindex)
2274         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
2275
2276 2020-02-26  Aaron Merey  <amerey@redhat.com>
2277
2278         * Makefile.in: Handle optional debuginfod support.
2279         * NEWS: Update.
2280         * README: Add --with-debuginfod summary.
2281         * config.in: Regenerate.
2282         * configure: Regenerate.
2283         * configure.ac: Handle optional debuginfod support.
2284         * debuginfod-support.c: debuginfod helper functions.
2285         * debuginfod-support.h: Ditto.
2286         * doc/gdb.texinfo: Add --with-debuginfod to configure options
2287         summary.
2288         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
2289         when a dwz file cannot be found.
2290         * elfread.c (elf_symfile_read): Query debuginfod servers when a
2291         debuginfo file cannot be found.
2292         * source.c (open_source_file): Query debuginfod servers when a
2293         source file cannot be found.
2294         * top.c (print_gdb_configuration): Include
2295         --{with,without}-debuginfod in the output.
2296
2297 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
2298
2299         * thread.c (thr_try_catch_cmd): Print thread name.
2300
2301 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
2302
2303         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
2304         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2305         dwarf2_fetch_die_type_sect_off): Move to...
2306         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2307         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2308         dwarf2_fetch_die_type_sect_off): ... here.
2309         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2310         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2311         dwarf2_fetch_die_type_sect_off): Move doc to header file.
2312
2313 2020-02-26  Tom de Vries  <tdevries@suse.de>
2314
2315         PR gdb/25603
2316         * symfile.c (set_initial_language): Exit-early if
2317         language_mode == language_mode_manual.
2318
2319 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2320
2321         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
2322         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
2323         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
2324
2325 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * gdbtypes.c (create_array_type_with_stride): Handle negative
2328         array strides.
2329         * valarith.c (value_subscripted_rvalue): Likewise.
2330
2331 2020-02-25  Luis Machado  <luis.machado@linaro.org>
2332
2333         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
2334
2335 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
2336
2337         * loc.h (dwarf2_get_die_type): Move to...
2338         * read.h (dwarf2_get_die_type): ... here.
2339         * read.c (dwarf2_get_die_type): Move doc to header.
2340
2341 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
2342
2343         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
2344         'gnulib/Makefile.in' to the list.
2345
2346 2020-02-24  Tom Tromey  <tom@tromey.com>
2347
2348         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
2349         Remove.
2350         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
2351         XOBNEWVEC.
2352
2353 2020-02-24  Tom Tromey  <tom@tromey.com>
2354
2355         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
2356         New method.
2357         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
2358         (dw2_do_instantiate_symtab, dw2_get_file_names)
2359         (build_type_psymtab_dependencies, load_full_type_unit): Update.
2360
2361 2020-02-24  Tom Tromey  <tom@tromey.com>
2362
2363         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
2364         make_scoped_restore.
2365         (dwarf2_psymtab::read_symtab): Don't clear
2366         reading_partial_symbols.
2367
2368 2020-02-24  Tom de Vries  <tdevries@suse.de>
2369
2370         PR gdb/25592
2371         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
2372
2373 2020-02-24  Tom de Vries  <tdevries@suse.de>
2374
2375         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
2376         commands layout next/prev/regs.
2377
2378 2020-02-22  Tom Tromey  <tom@tromey.com>
2379
2380         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
2381         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
2382
2383 2020-02-22  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
2386
2387 2020-02-22  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-win.c (_initialize_tui_win): Add usage text.
2390         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
2391         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
2392         * tui/tui.c (_initialize_tui): Add usage text.
2393
2394 2020-02-22  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-win.c (tui_set_focus_command)
2397         (tui_set_win_height_command): Use error_no_arg.
2398         (_initialize_tui_win): Update help text.
2399         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
2400
2401 2020-02-22  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
2404         * tui/tui-disasm.h (struct tui_disasm_window)
2405         <display_start_addr>: Declare.
2406         * tui/tui-source.h (struct tui_source_window)
2407         <display_start_addr>: Declare.
2408         * tui/tui-winsource.h (struct tui_source_window_base)
2409         <show_source_line, display_start_addr>: New methods.
2410         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
2411         Rename and move to protected section.
2412         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
2413         (tui_source_window_base::do_erase_source_content): Update.
2414         (tui_source_window_base::show_source_line): Now a method.
2415         (tui_source_window_base::show_source_content)
2416         (tui_source_window_base::tui_source_window_base)
2417         (tui_source_window_base::rerender)
2418         (tui_source_window_base::refill)
2419         (tui_source_window_base::do_scroll_horizontal)
2420         (tui_source_window_base::set_is_exec_point_at)
2421         (tui_source_window_base::update_breakpoint_info)
2422         (tui_source_window_base::update_exec_info): Update.
2423         * tui/tui-source.c (tui_source_window::set_contents)
2424         (tui_source_window::showing_source_p)
2425         (tui_source_window::do_scroll_vertical)
2426         (tui_source_window::location_matches_p)
2427         (tui_source_window::line_is_displayed): Update.
2428         (tui_source_window::display_start_addr): New method.
2429         * tui/tui-disasm.c (tui_disasm_window::set_contents)
2430         (tui_disasm_window::do_scroll_vertical)
2431         (tui_disasm_window::location_matches_p): Update.
2432         (tui_disasm_window::display_start_addr): New method.
2433
2434 2020-02-22  Tom Tromey  <tom@tromey.com>
2435
2436         * NEWS: Add entry for gdb.register_window_type.
2437         * tui/tui-layout.h (window_factory): New typedef.
2438         (tui_register_window): Declare.
2439         * tui/tui-layout.c (saved_tui_windows): New global.
2440         (tui_apply_current_layout): Use it.
2441         (tui_register_window): New function.
2442         * python/python.c (do_start_initialization): Call
2443         gdbpy_initialize_tui.
2444         (python_GdbMethods): Add "register_window_type" function.
2445         * python/python-internal.h (gdbpy_register_tui_window)
2446         (gdbpy_initialize_tui): Declare.
2447         * python/py-tui.c: New file.
2448         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
2449
2450 2020-02-22  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
2453
2454 2020-02-22  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
2457         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
2458         * tui/tui-data.c (tui_set_win_with_focus): Remove.
2459         (tui_set_win_focus_to): Move from tui-win.c.
2460
2461 2020-02-22  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-layout.c (make_standard_window, get_locator_window): New
2464         functions.
2465         (known_window_types): New global.
2466         (tui_get_window_by_name): Reimplement.
2467         (initialize_known_windows): New function.
2468         (validate_window_name): Rewrite.
2469         (_initialize_tui_layout): Call initialize_known_windows.
2470
2471 2020-02-22  Tom Tromey  <tom@tromey.com>
2472
2473         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
2474         Remove constants.
2475         * tui/tui-winsource.h (struct tui_source_window_base)
2476         <tui_source_window_base>: Remove parameter.
2477         * tui/tui-winsource.c
2478         (tui_source_window_base::tui_source_window_base): Remove
2479         parameter.
2480         (tui_source_window_base::refill): Update.
2481         * tui/tui-stack.h (struct tui_locator_window)
2482         <tui_locator_window>: Update.
2483         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
2484         Default the constructor.
2485         * tui/tui-regs.h (struct tui_data_item_window)
2486         <tui_data_item_window>: Default the constructor.
2487         (struct tui_data_window) <tui_data_window>: Likewise.
2488         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
2489         Default the constructor.
2490         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
2491         Default the constructor.
2492         <type>: Remove.
2493         (struct tui_win_info) <tui_win_info>: Default the constructor.
2494         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
2495         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2496         Default the constructor.
2497
2498 2020-02-22  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
2501         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
2502         * tui/tui-win.c (tui_resize_all): Don't call
2503         tui_delete_invisible_windows.
2504         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
2505         done.
2506         (tui_set_layout): Update.
2507         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
2508         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
2509         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
2510
2511 2020-02-22  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
2514         correctly.
2515
2516 2020-02-22  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
2519
2520 2020-02-22  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-winsource.h (struct tui_source_window_iterator)
2523         <inner_iterator>: New etytypedef.
2524         <tui_source_window_iterator>: Take "end" parameter.
2525         <tui_source_window_iterator>: Take iterator.
2526         <operator*, advance>: Update.
2527         <m_iter>: Change type.
2528         <m_end>: New field.
2529         (struct tui_source_windows) <begin, end>: Update.
2530         * tui/tui-layout.c (tui_windows): New global.
2531         (tui_apply_current_layout): Clear tui_windows.
2532         (tui_layout_window::apply): Update tui_windows.
2533         * tui/tui-data.h (tui_windows): Declare.
2534         (all_tui_windows): Now inline function.
2535         (class tui_window_iterator, struct all_tui_windows): Remove.
2536
2537 2020-02-22  Tom Tromey  <tom@tromey.com>
2538
2539         PR tui/17850:
2540         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
2541         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
2542         "height" argument.
2543         (class tui_layout_window) <get_sizes>: Likewise.
2544         (class tui_layout_split) <tui_layout_split>: Add "vertical"
2545         argument.
2546         <get_sizes>: Add "height" argument.
2547         <m_vertical>: New field.
2548         * tui/tui-layout.c (tui_layout_split::clone): Update.
2549         (tui_layout_split::get_sizes): Add "height" argument.
2550         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
2551         (tui_new_layout_command): Parse "-horizontal".
2552         (_initialize_tui_layout): Update help string.
2553         (tui_layout_split::specification): Add "-horizontal" when needed.
2554         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
2555         argument.
2556         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
2557         New methods.
2558
2559 2020-02-22  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-layout.h (enum tui_adjust_result): New.
2562         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
2563         (class tui_layout_window) <adjust_size>: Return
2564         tui_adjust_result.  Rewrite.
2565         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
2566         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
2567
2568 2020-02-22  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
2571         parameter and return types.
2572         (class tui_layout_base) <specification>: Add "depth".
2573         (class tui_layout_window) <specification>: Add "depth".
2574         (class tui_layout_split) <specification>: Add "depth".
2575         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
2576         and return types.
2577         (tui_new_layout_command): Parse sub-layouts.
2578         (_initialize_tui_layout): Update help string.
2579         (tui_layout_window::specification): Add "depth".
2580         (add_layout_command): Update.
2581
2582 2020-02-22  Tom Tromey  <tom@tromey.com>
2583
2584         * NEWS: Add "tui new-layout" item.
2585         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
2586         Add new-layout command to help text.
2587         (validate_window_name): New function.
2588         (tui_new_layout_command): New function.
2589         (_initialize_tui_layout): Register "new-layout".
2590         (tui_layout_window::specification): New method.
2591         (tui_layout_window::specification): New method.
2592         * tui/tui-layout.h (class tui_layout_base) <specification>: New
2593         method.
2594         (class tui_layout_window) <specification>: New method.
2595         (class tui_layout_split) <specification>: New method.
2596
2597 2020-02-22  Tom Tromey  <tom@tromey.com>
2598
2599         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
2600         * tui/tui-win.c (window_name_completer): Update comment.
2601         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
2602         Declare method.
2603         (class tui_layout_window) <replace_window>: Likewise.
2604         (class tui_layout_split) <replace_window>: Likewise.
2605         (tui_set_layout): Don't declare.
2606         (tui_set_initial_layout): Declare function.
2607         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
2608         (asm_regs_layout): New globals.
2609         (tui_current_layout, show_layout): Remove.
2610         (tui_set_layout, tui_add_win_to_layout): Rewrite.
2611         (find_layout, tui_apply_layout): New function.
2612         (layout_completer): Remove.
2613         (tui_next_layout): Reimplement.
2614         (tui_next_layout_command): New function.
2615         (tui_set_initial_layout, tui_prev_layout_command): New functions.
2616         (tui_regs_layout): Reimplement.
2617         (tui_regs_layout_command): New function.
2618         (extract_display_start_addr): Rewrite.
2619         (next_layout, prev_layout): Remove.
2620         (tui_layout_window::replace_window): New method.
2621         (tui_layout_split::replace_window): New method.
2622         (destroy_layout): New function.
2623         (layout_list): New global.
2624         (add_layout_command): New function.
2625         (initialize_layouts): Update.
2626         (tui_layout_command): New function.
2627         (_initialize_tui_layout): Install "layout" commands.
2628         * tui/tui-data.h (enum tui_layout_type): Remove.
2629         (tui_current_layout): Don't declare.
2630
2631 2020-02-22  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-regs.c (tui_reg_layout): Remove.
2634         (tui_reg_command): Use tui_regs_layout.
2635         * tui/tui-layout.h (tui_reg_command): Declare.
2636         * tui/tui-layout.c (tui_reg_command): New function.
2637
2638 2020-02-22  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui.c (tui_rl_delete_other_windows): Call
2641         tui_remove_some_windows.
2642         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
2643         Declare method.
2644         (class tui_layout_window) <remove_windows>: New method.
2645         (class tui_layout_split) <remove_windows>: Declare.
2646         (tui_remove_some_windows): Declare.
2647         * tui/tui-layout.c (tui_remove_some_windows): New function.
2648         (tui_layout_split::remove_windows): New method.
2649
2650 2020-02-22  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
2653         * tui/tui-layout.h (tui_next_layout): Declare.
2654         * tui/tui-layout.c (tui_next_layout): New function.
2655
2656 2020-02-22  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
2659         correct coordinates.
2660
2661 2020-02-22  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
2664         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
2665         DATA_WIN case.
2666
2667 2020-02-22  Tom Tromey  <tom@tromey.com>
2668
2669         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
2670         TUI_DISASM_WIN, not tui_win_list.
2671
2672 2020-02-22  Tom Tromey  <tom@tromey.com>
2673
2674         * valprint.c (generic_val_print_enum_1)
2675         (val_print_type_code_flags): Style member names.
2676         * rust-lang.c (val_print_struct, rust_print_enum)
2677         (rust_print_struct_def, rust_internal_print_type): Style member
2678         names.
2679         * p-valprint.c (pascal_object_print_value_fields): Style member
2680         names.  Only call fprintf_symbol_filtered for static members.
2681         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
2682         * f-valprint.c (f_val_print): Style member names.
2683         * f-typeprint.c (f_type_print_base): Style member names.
2684         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
2685         call fprintf_symbol_filtered for static members.
2686         (cp_print_class_member): Style member names.
2687         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
2688         member names.
2689         * ada-valprint.c (ada_print_scalar): Style enum names.
2690         (ada_val_print_enum): Likewise.
2691         * ada-typeprint.c (print_enum_type): Style enum names.
2692
2693 2020-02-21  Tom Tromey  <tom@tromey.com>
2694
2695         * psympriv.h (struct partial_symtab): Update comment.
2696
2697 2020-02-21  Tom Tromey  <tromey@adacore.com>
2698
2699         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
2700         type is CORE_ADDR.
2701
2702 2020-02-21  Tom de Vries  <tdevries@suse.de>
2703
2704         PR gdb/25534
2705         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
2706         if dependencies[i]->user != NULL.
2707
2708 2020-02-21  Ali Tamur  <tamur@google.com>
2709
2710         * dwarf2/read.c (dwarf2_name): Add null check.
2711
2712 2020-02-20  Tom Tromey  <tom@tromey.com>
2713
2714         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
2715         ">=", in binary search.
2716         (dwarf2_find_containing_comp_unit): New overload.
2717         (run_test): New self-test.
2718         (_initialize_dwarf2_read): Register new test.
2719
2720 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
2721
2722         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
2723         * riscv-tdep.h: Likewise.
2724         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
2725         rv32-only CSR.
2726         * features/riscv/64bit-csr.xml: Regenerated.
2727
2728 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
2729             Tom Tromey  <tom@tromey.com>
2730
2731         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
2732         of 'fputc_unfiltered'.
2733         (putchar_unfiltered): Call 'fputc_unfiltered'.
2734         (fputc_unfiltered): Call 'fputs_unfiltered'.
2735
2736 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * config.in: Regenerate.
2739         * configure: Regenerate.
2740         * configure.ac: Add --with-python-libdir option.
2741         * main.c: Use WITH_PYTHON_LIBDIR.
2742
2743 2020-02-19  Tom Tromey  <tom@tromey.com>
2744
2745         * symtab.c (general_symbol_info::compute_and_set_names): Use
2746         obstack_strndup.  Simplify call to symbol_set_demangled_name.
2747
2748 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
2749
2750         * dwarf2/read.c (allocate_signatured_type_table,
2751         allocate_dwo_unit_table, allocate_type_unit_groups_table,
2752         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
2753         Remove objfile parameter, update all callers.
2754
2755 2020-02-19  Doug Evans  <dje@google.com>
2756
2757         PR rust/25535
2758         * rust-lang.c (rust_print_enum): Apply embedded_offset to
2759         rust_enum_variant calculation.
2760
2761 2020-02-19  Tom Tromey  <tromey@adacore.com>
2762
2763         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
2764
2765 2020-02-19  Tom Tromey  <tromey@adacore.com>
2766
2767         * ada-lang.c (cache_symbol): Use obstack_strdup.
2768
2769 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * configure: Regenerate.
2772
2773 2020-02-19  Tom Tromey  <tromey@adacore.com>
2774
2775         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
2776         NULL check.
2777
2778 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
2779
2780         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
2781
2782 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
2785         if GDBSERVER is not defined.
2786         (riscv_tdesc_cache): Likewise, also store const target_desc.
2787         (STATIC_IN_GDB): Define.
2788         (riscv_create_target_description): Update declaration with
2789         STATIC_IN_GDB.
2790         (riscv_lookup_target_description): New function, only define if
2791         GDBSERVER is not defined.
2792         * arch/riscv.h (riscv_create_target_description): Declare only
2793         when GDBSERVER is defined.
2794         (riscv_lookup_target_description): New declaration when GDBSERVER
2795         is not defined.
2796         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
2797         (riscv_linux_read_features): ...this, and return
2798         riscv_gdbarch_features instead of target_desc.
2799         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
2800         (riscv_linux_read_description): Rename to...
2801         (riscv_linux_read_features): ...this.
2802         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2803         Update to use riscv_gdbarch_features and
2804         riscv_lookup_target_description.
2805         * riscv-tdep.c (riscv_find_default_target_description): Use
2806         riscv_lookup_target_description instead of
2807         riscv_create_target_description.
2808
2809 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2810
2811         * valprint.c (generic_val_print_enum_1): When printing a flag
2812         enum with value 0 and there is no enumerator with value 0, print
2813         just "0" instead of "(unknown: 0x0)".
2814
2815 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * valprint.c (generic_val_print_enum_1): Print unknown part of
2818         flag enum in hex.
2819
2820 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2821
2822         * dwarf2/read.c (update_enumeration_type_from_children): Allow
2823         flag enums to contain duplicate enumerators.
2824         * valprint.c (generic_val_print_enum_1): Update comment.
2825
2826 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2827
2828         * dwarf2/read.c: Include "count-one-bits.h".
2829         (update_enumeration_type_from_children): If an enumerator has
2830         multiple bits set, don't treat the enumeration as a "flag enum".
2831         * valprint.c (generic_val_print_enum_1): Assert that enumerators
2832         of flag enums have 0 or 1 bit set.
2833
2834 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2835
2836         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
2837         conversion.
2838         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2839         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2840         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2841         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2842         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2843
2844 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2845
2846         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
2847
2848 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2849
2850         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
2851         displaced_step_closure_up.
2852         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2853         (struct displaced_step_closure_up):
2854         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2855         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2856         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
2857         Likewise.
2858         * gdbarch.sh (displaced_step_copy_insn): Likewise.
2859         * gdbarch.c, gdbarch.h: Re-generate.
2860         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
2861         displaced_step_closure_up.
2862         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2863         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2864         * infrun.h (displaced_step_closure_up): New type alias.
2865         (struct displaced_step_inferior_state) <step_closure>: Change
2866         type to displaced_step_closure_up.
2867         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
2868         displaced_step_closure_up.
2869         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2870
2871 2020-02-14  Tom Tromey  <tom@tromey.com>
2872
2873         * minidebug.c (gnu_debug_key): New global.
2874         (find_separate_debug_file_in_section): Use it.
2875
2876 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2877
2878         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
2879         std::unique_ptr.
2880         * gdbarch.c: Re-generate.
2881         * gdbarch.h: Re-generate.
2882         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
2883         change.
2884         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
2885         type to std::unique_ptr.
2886         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2887         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2888         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2889         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2890         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
2891         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2892         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2893         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2894         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2895
2896 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2897
2898         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
2899         std::unique_ptr.
2900         (displaced_step_clear): Rename to...
2901         (displaced_step_reset): ... this.  Just call displaced->reset ().
2902         (displaced_step_clear_cleanup): Rename to...
2903         (displaced_step_reset_cleanup): ... this.
2904         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
2905         (displaced_step_fixup): Likewise.
2906         (resume_1): Likewise.
2907         (handle_inferior_event): Restore child's memory before calling
2908         displaced_step_fixup on the parent.
2909         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
2910         to std::unique_ptr.
2911         <step_closure>: Change type to std::unique_ptr.
2912
2913 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2914
2915         * arm-tdep.c: Include count-one-bits.h.
2916         (cleanup_block_store_pc): Use count_one_bits.
2917         (cleanup_block_load_pc): Use count_one_bits.
2918         (arm_copy_block_xfer): Use count_one_bits.
2919         (thumb2_copy_block_xfer): Use count_one_bits.
2920         (thumb_copy_pop_pc_16bit): Use count_one_bits.
2921         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
2922         (thumb_get_next_pcs_raw): Use count_one_bits.
2923         (arm_get_next_pcs_raw): Use count_one_bits_l.
2924         * arch/arm.c (bitcount): Remove.
2925         * arch/arm.h (bitcount): Remove.
2926
2927 2020-02-14  Tom Tromey  <tromey@adacore.com>
2928
2929         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
2930         Update.
2931         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
2932         * dwarf2/loc.c (call_site_find_chain_1): Return
2933         unique_xmalloc_ptr.
2934         (call_site_find_chain): Likewise.
2935
2936 2020-02-14  Richard Biener  <rguenther@suse.de>
2937
2938         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
2939         on expression with division operators.
2940
2941 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2942
2943         * MAINTAINERS (Write After Approval): Adding myself.
2944
2945 2020-02-12  Tom Tromey  <tom@tromey.com>
2946
2947         * event-loop.c (event_data, gdb_event, event_handler_func):
2948         Remove.
2949
2950 2020-02-12  Tom Tromey  <tom@tromey.com>
2951
2952         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
2953         (dwarf2_frame_objfile_data): Add comment.
2954         (find_comp_unit, set_comp_unit): New functions.
2955         (dwarf2_frame_find_fde): Use find_comp_unit.
2956         (dwarf2_build_frame_info): Use set_comp_unit.
2957
2958 2020-02-12  Tom Tromey  <tom@tromey.com>
2959
2960         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
2961         (comp_unit): Don't initialize objfile.
2962         (execute_cfa_program): Add text_offset parameter.
2963         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
2964         (dwarf2_frame_cache): Update.
2965         (dwarf2_build_frame_info): Don't set "objfile" member.
2966
2967 2020-02-12  Tom Tromey  <tom@tromey.com>
2968
2969         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
2970         (decode_frame_entry): Likewise.
2971         (dwarf2_build_frame_info): Update.
2972
2973 2020-02-12  Tom Tromey  <tom@tromey.com>
2974
2975         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
2976         (decode_frame_entry_1): Use the comp_unit obstack.
2977
2978 2020-02-12  Tom Tromey  <tom@tromey.com>
2979
2980         * dwarf2/frame.c (struct comp_unit): Add initializers and
2981         constructor.
2982         (dwarf2_frame_objfile_data): Store a comp_unit.
2983         (dwarf2_frame_find_fde): Update.
2984         (dwarf2_build_frame_info): Use "new".
2985
2986 2020-02-12  Tom Tromey  <tom@tromey.com>
2987
2988         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2989         (dwarf2_fde_table): Typedef for std::vector.
2990         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2991         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2992         (decode_frame_entry): Update.
2993         (dwarf2_build_frame_info): Use "new".
2994
2995 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2996
2997         * arm-tdep.c (arm_gdbarch_init): Update.
2998         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2999         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
3000         have_neon, is_m>: Change to bool.
3001
3002 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
3003
3004         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
3005
3006 2020-02-12  Tom Tromey  <tom@tromey.com>
3007
3008         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
3009
3010 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
3011
3012         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
3013         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
3014
3015 2020-02-11  Tom Tromey  <tom@tromey.com>
3016
3017         * psymtab.h: Update comment.
3018
3019 2020-02-11  Tom Tromey  <tom@tromey.com>
3020
3021         * gdb_obstack.h (struct auto_obstack): Use
3022         DISABLE_COPY_AND_ASSIGN.
3023
3024 2020-02-11  Tom Tromey  <tom@tromey.com>
3025
3026         * dwarf2/frame.h (struct objfile): Don't forward declare.
3027
3028 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3029
3030         * cris-tdep.c (cris_supply_gregset): Change signature to match
3031         what struct regset expects.
3032         (cris_regset): New struct.
3033         (fetch_core_registers): Remove.
3034         (cris_iterate_over_regset_sections): New function.
3035         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
3036         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
3037
3038 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3039
3040         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
3041         registers.
3042
3043 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
3044
3045         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
3046
3047 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3048
3049         * configure: Re-generate.
3050
3051 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3052
3053         * configure: Re-generate.
3054
3055 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
3056
3057         * acinclude: Update warning.m4 path.
3058         * warning.m4: Move to gdbsupport.
3059
3060 2020-02-11  Tom Tromey  <tromey@adacore.com>
3061
3062         * remote.c (remote_console_output): Update.
3063         * printcmd.c (printf_command): Update.
3064         * event-loop.c (gdb_wait_for_event): Update.
3065         * linux-nat.c (sigchld_handler): Update.
3066         * remote-sim.c (gdb_os_write_stdout): Update.
3067         (gdb_os_flush_stdout): Update.
3068         (gdb_os_flush_stderr): Update.
3069         (gdb_os_write_stderr): Update.
3070         * exceptions.c (print_exception): Update.
3071         * remote-fileio.c (remote_fileio_func_read): Update.
3072         (remote_fileio_func_write): Update.
3073         * tui/tui.c (tui_enable): Update.
3074         * tui/tui-interp.c (tui_interp::init): Update.
3075         * utils.c (init_page_info): Update.
3076         (putchar_unfiltered, fputc_unfiltered): Update.
3077         (gdb_flush): Update.
3078         (emit_style_escape): Update.
3079         (flush_wrap_buffer, fputs_maybe_filtered): Update.
3080         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
3081         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
3082         (stderr_file::write): Update.
3083         (stderr_file::puts): Update.
3084         * ui-file.h (ui_file_isatty, ui_file_write)
3085         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
3086         (ui_file_puts): Don't declare.
3087
3088 2020-02-10  Tom de Vries  <tdevries@suse.de>
3089
3090         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
3091         sentinel to char *.
3092
3093 2020-02-09  Tom de Vries  <tdevries@suse.de>
3094
3095         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
3096         filename if it matches "<artificial>".
3097
3098 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3099
3100         * windows-tdep.c (struct enum_value_name): New struct.
3101         (create_enum): New function.
3102         (windows_get_siginfo_type): Create and use enum types.
3103
3104 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
3105
3106         * NEWS: Mention $_siginfo support for Windows.
3107         * windows-nat.c (handle_exception): Set siginfo_er.
3108         (windows_nat_target::mourn_inferior): Reset siginfo_er.
3109         (windows_xfer_siginfo): New function.
3110         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
3111         * windows-tdep.c (struct windows_gdbarch_data): New struct.
3112         (init_windows_gdbarch_data): New function.
3113         (get_windows_gdbarch_data): New function.
3114         (windows_get_siginfo_type): New function.
3115         (windows_init_abi): Register windows_get_siginfo_type.
3116         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
3117
3118 2020-02-08  Tom Tromey  <tom@tromey.com>
3119
3120         * dwarf2/read.c (class cutu_reader) <cutu_reader,
3121         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
3122         <keep>: Declare method.
3123         <m_keep>: Remove member.
3124         <~cutu_reader>: Remove.
3125         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3126         (cutu_reader::cutu_reader): Update.
3127         (cutu_reader::keep): Rename from ~cutu_reader.
3128         (process_psymtab_comp_unit, build_type_psymtabs_1)
3129         (process_skeletonless_type_unit, load_partial_comp_unit)
3130         (load_full_comp_unit, dwarf2_read_addr_index)
3131         (read_signatured_type): Update.
3132
3133 2020-02-08  Tom Tromey  <tom@tromey.com>
3134
3135         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
3136         "want_partial_unit" parameter.
3137         (process_psymtab_comp_unit): Change want_partial_unit to bool.
3138         Inline check for DW_TAG_partial_unit.
3139         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
3140
3141 2020-02-08  Tom Tromey  <tom@tromey.com>
3142
3143         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
3144         read.c.
3145         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
3146         read.c.
3147
3148 2020-02-08  Tom Tromey  <tom@tromey.com>
3149
3150         * dwarf2/read.c (read_address): Move to comp-unit.c.
3151         (dwarf2_rnglists_process, dwarf2_ranges_process)
3152         (read_attribute_value, dwarf_decode_lines_1)
3153         (var_decode_location, decode_locdesc): Update.
3154         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
3155         read.c.  Remove "cu" parameter.
3156         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
3157         method.
3158
3159 2020-02-08  Tom Tromey  <tom@tromey.com>
3160
3161         * dwarf2/read.c (read_attribute_value, read_indirect_string)
3162         (read_indirect_line_string): Update.
3163         * dwarf2/comp-unit.c (read_offset): Remove.
3164         (read_comp_unit_head): Update.
3165         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
3166         method.
3167         (read_offset): Don't declare.
3168
3169 2020-02-08  Tom Tromey  <tom@tromey.com>
3170
3171         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
3172         * dwarf2/read.c (struct comp_unit_head): Move to
3173         dwarf2/comp-unit.h.
3174         (enum class rcuh_kind): Move to comp-unit.h.
3175         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
3176         (read_comp_unit_head, error_check_comp_unit_head)
3177         (read_and_check_comp_unit_head): Move to comp-unit.c.
3178         (read_offset, dwarf_unit_type_name): Likewise.
3179         (create_debug_type_hash_table, read_cutu_die_from_dwo)
3180         (cutu_reader::cutu_reader, read_call_site_scope)
3181         (find_partial_die, follow_die_offset): Update.
3182         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
3183
3184 2020-02-08  Tom Tromey  <tom@tromey.com>
3185
3186         * dwarf2/read.c (read_offset_1): Move to leb.c.
3187         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
3188         (dwarf_decode_macro_bytes): Update.
3189         * dwarf2/leb.c (read_offset): Rename; move from read.c.
3190         * dwarf2/leb.h (read_offset): Declare.
3191
3192 2020-02-08  Tom Tromey  <tom@tromey.com>
3193
3194         * dwarf2/read.c (dwarf2_section_size): Remove.
3195         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
3196         Update.
3197         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
3198
3199 2020-02-08  Tom Tromey  <tom@tromey.com>
3200
3201         * dwarf2/read.c (read_initial_length): Move to leb.c.
3202         * dwarf2/leb.h (read_initial_length): Declare.
3203         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
3204         handle_nonstd parameter.
3205         * dwarf2/frame.c (read_initial_length): Remove.
3206         (decode_frame_entry_1): Update.
3207
3208 2020-02-08  Tom Tromey  <tom@tromey.com>
3209
3210         * dwarf2/loc.c (dwarf2_find_location_expression)
3211         (dwarf_evaluate_loc_desc::get_tls_address)
3212         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
3213         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
3214         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
3215         (dwarf2_compile_property_to_c)
3216         (dwarf2_loc_desc_get_symbol_read_needs)
3217         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
3218         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
3219         (loclist_describe_location, loclist_tracepoint_var_ref)
3220         (loclist_generate_c_location): Update.
3221         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
3222         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
3223         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
3224         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
3225         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
3226         (dwarf2_per_cu_data::addr_size)
3227         (dwarf2_per_cu_data::ref_addr_size)
3228         (dwarf2_per_cu_data::text_offset)
3229         (dwarf2_per_cu_data::addr_type): Now methods.
3230         (per_cu_header_read_in): Make per_cu "const".
3231         (dwarf2_version): Remove.
3232         (dwarf2_per_cu_data::int_type): Now a method.
3233         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
3234         (set_die_type, read_array_type, read_subrange_index_type)
3235         (read_tag_string_type, read_subrange_type): Update.
3236         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
3237         offset_size, ref_addr_size, text_offset, addr_type, version,
3238         objfile, int_type, addr_sized_int_type>: Declare methods.
3239
3240 2020-02-08  Tom Tromey  <tom@tromey.com>
3241
3242         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
3243         Move earlier.
3244
3245 2020-02-08  Tom Tromey  <tom@tromey.com>
3246
3247         * dwarf2/read.h (dwarf_line_debug): Declare.
3248         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
3249         * dwarf2/read.c: Move line_header code to new files.
3250         (dwarf_line_debug): No longer static.
3251         * dwarf2/line-header.c: New file.
3252         * dwarf2/line-header.h: New file.
3253
3254 2020-02-08  Tom Tromey  <tom@tromey.com>
3255
3256         * dwarf2/read.c (struct line_header) <file_full_name,
3257         file_file_name>: Return unique_xmalloc_ptr.
3258         (line_header::file_file_name): Update.
3259         (line_header::file_full_name): Update.
3260         (dw2_get_file_names_reader): Update.
3261         (macro_start_file): Update.
3262
3263 2020-02-08  Tom Tromey  <tom@tromey.com>
3264
3265         * dwarf2/read.c (struct line_header) <file_full_name,
3266         file_file_name>: Declare methods.
3267         (dw2_get_file_names_reader): Update.
3268         (file_file_name): Now a method.
3269         (file_full_name): Likewise.
3270         (macro_start_file): Update.
3271
3272 2020-02-08  Tom Tromey  <tom@tromey.com>
3273
3274         * dwarf2/read.c (dwarf_always_disassemble)
3275         (show_dwarf_always_disassemble): Move to loc.c.
3276         (_initialize_dwarf2_read): Move "always-disassemble" registration
3277         to loc.c.
3278         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
3279         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
3280         static.
3281         (show_dwarf_always_disassemble): Move from read.c.
3282         (_initialize_dwarf2loc): Move always-disassemble from read.c.
3283
3284 2020-02-08  Tom Tromey  <tom@tromey.com>
3285
3286         * dwarf2/read.c (~dwarf2_per_objfile): Update.
3287         (create_quick_file_names_table): Return htab_up.
3288         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
3289         Update.
3290         * dwarf2/read.h (struct dwarf2_per_objfile)
3291         <quick_file_names_table>: Now htab_up.
3292
3293 2020-02-08  Tom Tromey  <tom@tromey.com>
3294
3295         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
3296
3297 2020-02-08  Tom Tromey  <tom@tromey.com>
3298
3299         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
3300         Rewrite.
3301         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
3302         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
3303         (abbrev_table::abbrev_table): No longer inline.
3304         (ABBREV_HASH_SIZE): Remove.
3305         (abbrev_table::m_abbrevs): Now an htab_up.
3306
3307 2020-02-08  Tom Tromey  <tom@tromey.com>
3308
3309         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
3310         (cutu_reader): Update.
3311         (build_type_psymtabs_1): Update.
3312         * dwarf2/abbrev.c (abbrev_table::read): Rename.
3313         (abbrev_table::alloc_abbrev): Update.
3314         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
3315         (abbrev_table::read): New static method, renamed from
3316         abbrev_table_read_table.
3317         (abbrev_table::alloc_abbrev)
3318         (abbrev_table::add_abbrev): Now private.
3319         (abbrev_table::abbrev_table): Now private.
3320         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
3321
3322 2020-02-08  Tom Tromey  <tom@tromey.com>
3323
3324         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
3325         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
3326         htab_up.
3327
3328 2020-02-08  Tom Tromey  <tom@tromey.com>
3329
3330         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
3331         htab_up.
3332         (lookup_dwo_unit_in_dwp): Update.
3333         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
3334         on obstack.
3335
3336 2020-02-08  Tom Tromey  <tom@tromey.com>
3337
3338         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
3339         obstack.
3340
3341 2020-02-08  Tom Tromey  <tom@tromey.com>
3342
3343         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
3344         line_header_hash.
3345         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
3346         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
3347         Change type to htab_up.
3348
3349 2020-02-08  Tom Tromey  <tom@tromey.com>
3350
3351         * dwarf2/read.c (allocate_type_unit_groups_table): Return
3352         htab_up.  Don't allocate on obstack.
3353         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
3354         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
3355         Change type to htab_up.
3356
3357 2020-02-08  Tom Tromey  <tom@tromey.com>
3358
3359         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
3360         Change type to htab_up.
3361         * dwarf2/read.c (create_signatured_type_table_from_index)
3362         (create_signatured_type_table_from_debug_names)
3363         (create_all_type_units, add_type_unit)
3364         (lookup_dwo_signatured_type, lookup_signatured_type)
3365         (process_skeletonless_type_unit): Update.
3366         (create_debug_type_hash_table, create_debug_types_hash_table):
3367         Change type of types_htab.
3368         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
3369         htab_up.  Don't allocate on obstack.
3370         (create_cus_hash_table): Change type of cus_htab parameter.
3371         (struct dwo_file) <cus, tus>: Now htab_up.
3372         (lookup_dwo_signatured_type, lookup_dwo_cutu)
3373         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
3374         (queue_and_load_all_dwo_tus): Update.
3375         * dwarf2/index-write.c (write_gdbindex): Update.
3376         (write_debug_names): Update.
3377
3378 2020-02-08  Tom Tromey  <tom@tromey.com>
3379
3380         * dwarf2/read.h (struct dwarf2_queue_item): Move from
3381         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
3382         destructor.
3383         (struct dwarf2_per_objfile) <queue>: New member.
3384         * dwarf2/read.c (struct dwarf2_queue_item): Move to
3385         dwarf2/read.h.
3386         (dwarf2_queue, dwarf2_queue_tail): Remove.
3387         (class dwarf2_queue_guard): Add parameter to constructor.  Use
3388         DISABLE_COPY_AND_ASSIGN.
3389         <m_per_objfile>: New member.
3390         <~dwarf2_queue_guard>: Rewrite.
3391         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
3392         Update.
3393         (~dwarf2_queue_item): New.
3394
3395 2020-02-08  Tom Tromey  <tom@tromey.com>
3396
3397         * dwarf2/read.c (struct die_info) <has_children>: New member.
3398         (dw2_get_file_names_reader): Remove has_children.
3399         (dw2_get_file_names): Update.
3400         (read_cutu_die_from_dwo): Remove has_children.
3401         (cutu_reader::init_tu_and_read_dwo_dies)
3402         (cutu_reader::cutu_reader): Update.
3403         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
3404         Remove has_children.
3405         (build_type_psymtabs_1, process_skeletonless_type_unit)
3406         (load_partial_comp_unit, load_full_comp_unit): Update.
3407         (create_dwo_cu_reader): Remove has_children.
3408         (create_cus_hash_table, read_die_and_children): Update.
3409         (read_full_die_1,read_full_die): Remove has_children.
3410         (read_signatured_type): Update.
3411         (class cutu_reader) <has_children>: Remove.
3412
3413 2020-02-08  Tom Tromey  <tom@tromey.com>
3414
3415         * dwarf2/expr.c: Rename from dwarf2expr.c.
3416         * dwarf2/expr.h: Rename from dwarf2expr.h.
3417         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
3418         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
3419         * dwarf2/frame.c: Rename from dwarf2-frame.c.
3420         * dwarf2/frame.h: Rename from dwarf2-frame.h.
3421         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
3422         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
3423         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
3424         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
3425         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
3426         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
3427         * dwarf2/loc.c: Rename from dwarf2loc.c.
3428         * dwarf2/loc.h: Rename from dwarf2loc.h.
3429         * dwarf2/read.c: Rename from dwarf2read.c.
3430         * dwarf2/read.h: Rename from dwarf2read.h.
3431         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
3432         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
3433         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
3434         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
3435         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
3436         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
3437         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
3438         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
3439         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
3440         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
3441         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
3442         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
3443         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
3444         Update.
3445         * Makefile.in (COMMON_SFILES): Update.
3446         (HFILES_NO_SRCDIR): Update.
3447
3448 2020-02-08  Tom Tromey  <tom@tromey.com>
3449
3450         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
3451         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
3452
3453 2020-02-08  Tom Tromey  <tom@tromey.com>
3454
3455         * dwarf2read.h (struct die_info): Don't declare.
3456
3457 2020-02-08  Tom Tromey  <tom@tromey.com>
3458
3459         * dwarf2read.h (die_info_ptr): Remove typedef.
3460
3461 2020-02-08  Tom Tromey  <tom@tromey.com>
3462
3463         * dwarf2read.c (read_call_site_scope)
3464         (handle_data_member_location, dwarf2_add_member_fn)
3465         (mark_common_block_symbol_computed, read_common_block)
3466         (attr_to_dynamic_prop, partial_die_info::read)
3467         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
3468         (dwarf2_symbol_mark_computed, set_die_type): Update.
3469         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
3470         method.
3471         (attr_form_is_block): Don't declare.
3472         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
3473
3474 2020-02-08  Tom Tromey  <tom@tromey.com>
3475
3476         * dwarf2read.c (dwarf2_find_base_address, )
3477         (read_call_site_scope, rust_containing_type)
3478         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
3479         (handle_data_member_location, dwarf2_add_member_fn)
3480         (get_alignment, read_structure_type, process_structure_scope)
3481         (mark_common_block_symbol_computed, read_common_block)
3482         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
3483         (partial_die_info::read, read_attribute_value, new_symbol)
3484         (lookup_die_type, dwarf2_get_ref_die_offset)
3485         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
3486         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
3487         (dwarf2_symbol_mark_computed): Update.
3488         * dwarf2/attribute.h (struct attribute) <value_as_address,
3489         form_is_section_offset, form_is_constant, form_is_ref>: Declare
3490         methods.
3491         (value_as_address, attr_form_is_section_offset)
3492         (attr_form_is_constant, attr_form_is_ref): Don't declare.
3493         * dwarf2/attribute.c (attribute::value_as_address)
3494         (attribute::form_is_section_offset, attribute::form_is_constant)
3495         (attribute::form_is_ref): Now methods.
3496
3497 2020-02-08  Tom Tromey  <tom@tromey.com>
3498
3499         * dwarf2read.c (struct attribute, DW_STRING)
3500         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
3501         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
3502         (attr_form_is_block, attr_form_is_section_offset)
3503         (attr_form_is_constant, attr_form_is_ref): Move.
3504         * dwarf2/attribute.h: New file.
3505         * dwarf2/attribute.c: New file, from dwarf2read.c.
3506         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
3507
3508 2020-02-08  Tom Tromey  <tom@tromey.com>
3509
3510         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
3511         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
3512         Move.
3513         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
3514         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
3515         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
3516         abbrev.c.
3517         * dwarf2/abbrev.h: New file.
3518         * dwarf2/abbrev.c: New file, from dwarf2read.c.
3519         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
3520
3521 2020-02-08  Tom Tromey  <tom@tromey.com>
3522
3523         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
3524         (dwarf2_section_size, dwarf2_get_section_info)
3525         (create_signatured_type_table_from_debug_names)
3526         (create_addrmap_from_aranges, read_debug_names_from_section)
3527         (get_gdb_index_contents_from_section, read_comp_unit_head)
3528         (error_check_comp_unit_head, read_abbrev_offset)
3529         (create_debug_type_hash_table, init_cu_die_reader)
3530         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
3531         (read_comp_units_from_section, create_cus_hash_table)
3532         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3533         (create_dwp_v2_section, dwarf2_rnglists_process)
3534         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
3535         (abbrev_table_read_table, read_indirect_string_at_offset_from)
3536         (read_indirect_string_from_dwz, read_addr_index_1)
3537         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
3538         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3539         (fill_in_loclist_baton): Update.
3540         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
3541         get_containing_section, get_bfd_owner, get_bfd_section,
3542         get_file_name, get_id, get_flags, empty, read>: Declare methods.
3543         (dwarf2_read_section, get_section_name, get_section_file_name)
3544         (get_containing_section, get_section_bfd_owner)
3545         (get_section_bfd_section, get_section_name, get_section_file_name)
3546         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
3547         declare.
3548         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
3549         (dwarf2_section_info::get_bfd_owner)
3550         (dwarf2_section_info::get_bfd_section)
3551         (dwarf2_section_info::get_name)
3552         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
3553         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
3554         (dwarf2_section_info::read): Now methods.
3555         * dwarf-index-write.c (class debug_names): Update.
3556
3557 2020-02-08  Tom Tromey  <tom@tromey.com>
3558
3559         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
3560         Move to dwarf2/section.h.
3561         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
3562         (get_section_bfd_section, get_section_name)
3563         (get_section_file_name, get_section_id, get_section_flags)
3564         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
3565         dwarf2/section.c.
3566         * dwarf2/section.h: New file.
3567         * dwarf2/section.c: New file, from dwarf2read.c.
3568         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
3569
3570 2020-02-08  Tom Tromey  <tom@tromey.com>
3571
3572         * dwarf2read.h (read_unsigned_leb128): Don't declare.
3573         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
3574         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
3575         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
3576         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
3577         * dwarf2/leb.h: New file, from dwarf2read.c.
3578         * dwarf2/leb.c: New file, from dwarf2read.c.
3579         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
3580         Remove.
3581         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
3582         (COMMON_SFILES): Add dwarf2/leb.c.
3583
3584 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
3585
3586         GDB 9.1 released.
3587
3588 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3589
3590         PR gdb/25190:
3591         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
3592         * gdb/remote.c (remote_console_output): Update.
3593         * gdb/ui-file.c (fputs_unfiltered): Rename to...
3594         (ui_file_puts): ...this.
3595         * gdb/ui-file.h (ui_file_puts): Add declaration.
3596         * gdb/utils.c (emit_style_escape): Update.
3597         (flush_wrap_buffer): Update.
3598         (fputs_maybe_filtered): Update.
3599         (fputs_unfiltered): Add function.
3600
3601 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3602
3603         * gdb/event-loop.c (gdb_wait_for_event): Update.
3604         * gdb/printcmd.c (printf_command): Update.
3605         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
3606         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
3607         (gdb_os_flush_stderr): Update.
3608         * gdb/remote.c (remote_console_output): Update.
3609         * gdb/ui-file.c (gdb_flush): Rename to...
3610         (ui_file_flush): ...this.
3611         (stderr_file::write): Update.
3612         (stderr_file::puts): Update.
3613         * gdb/ui-file.h (gdb_flush): Rename to...
3614         (ui_file_flush): ...this.
3615         * gdb/utils.c (gdb_flush): Add function.
3616         * gdb/utils.h (gdb_flush): Add declaration.
3617
3618 2020-02-07  Tom Tromey  <tromey@adacore.com>
3619
3620         PR breakpoints/24915:
3621         * source.c (find_and_open_source): Do not check basenames_may_differ.
3622
3623 2020-02-07  Tom Tromey  <tom@tromey.com>
3624
3625         * README: Update gdbserver documentation.
3626         * gdbserver: Move to top level.
3627         * configure.tgt (build_gdbserver): Remove.
3628         * configure.ac: Remove --enable-gdbserver.
3629         * configure: Rebuild.
3630         * Makefile.in (distclean): Don't mention gdbserver.
3631
3632 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3633
3634         * source-cache.c (source_cache::ensure): Surround
3635         get_plain_source_lines with a try/catch.
3636         (source_cache::get_line_charpos): Get rid of try/catch
3637         and only check for the return value of "ensure".
3638         * tui/tui-source.c (tui_source_window::set_contents):
3639         Simplify "nlines" calculation.
3640
3641 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3642
3643         * MAINTAINERS (Write After Approval): Add myself.
3644
3645 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3646
3647         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
3648         function call.
3649
3650 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3651
3652         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
3653
3654 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
3655
3656         * nat/riscv-linux-tdesc.h: New file.
3657         * nat/riscv-linux-tdesc.c: New file, taking code from...
3658         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3659         ... here.
3660         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
3661         NATDEPFILES.
3662
3663 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
3664
3665         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
3666         we don't set the fake simulator ptid to the null_ptid.
3667
3668 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
3669
3670         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
3671         * gdbthread.h (class thread_info) <resumed>: Likewise.
3672         * infrun.c (resume_1): Likewise.
3673         (proceed): Likewise.
3674         (infrun_thread_stop_requested): Likewise.
3675         (stop_all_threads): Likewise.
3676         (handle_inferior_event): Likewise.
3677         (restart_threads): Likewise.
3678         (finish_step_over): Likewise.
3679         (keep_going_stepped_thread): Likewise.
3680         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
3681         (linux_handle_extended_wait): Likewise.
3682         * record-btrace.c (get_thread_current_frame_id): Likewise.
3683         * record-full.c (record_full_wait_1): Likewise.
3684         * remote.c (remote_target::process_initial_stop_replies): Likewise.
3685         * target.c (target_resume): Likewise.
3686         * thread.c (set_running_thread): Likewise.
3687
3688 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3689
3690         * f-valprint.c (f77_print_array_1): Changed datatype of index
3691         variable to LONGEST from int to enable it to contain bound
3692         values correctly.
3693
3694 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
3695
3696         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
3697         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
3698         offsets according to FLEN determined.
3699         (riscv_linux_nat_target::read_description): Determine FLEN
3700         dynamically.
3701         (riscv_linux_nat_target::fetch_registers): Size regset buffer
3702         according to FLEN determined.
3703         (riscv_linux_nat_target::store_registers): Likewise.
3704
3705 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3706
3707         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3708         when reg->group is empty and reggroup is not.
3709
3710 2020-01-31  Tom Tromey  <tromey@adacore.com>
3711
3712         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
3713         Call beneath target's mourn_inferior after unpushing.
3714
3715 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         PR tui/9765
3718         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
3719         have enough lines to fill the screen, still return the lowest
3720         address we found.
3721
3722 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
3725         '-', '<', and '>' commands.
3726
3727 2020-01-29  Pedro Alves  <palves@redhat.com>
3728             Sergio Durigan Junior  <sergiodj@redhat.com>
3729
3730         * infcmd.c (construct_inferior_arguments): Assert that
3731         'argc' is greater than 0.
3732
3733 2020-01-29  Luis Machado  <luis.machado@linaro.org>
3734
3735         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
3736         (BRK_INSN_MASK): Define to 0xd4200000.
3737         (aarch64_program_breakpoint_here_p): New function.
3738         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
3739         * arch-utils.c (default_program_breakpoint_here_p): Moved from
3740         breakpoint.c.
3741         * arch-utils.h (default_program_breakpoint_here_p): Moved from
3742         breakpoint.h
3743         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
3744         call gdbarch_program_breakpoint_here_p.
3745         (program_breakpoint_here): Moved to arch-utils.c, renamed to
3746         default_program_breakpoint_here_p, changed return type to bool and
3747         simplified.
3748         * breakpoint.h (program_breakpoint_here): Moved prototype to
3749         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
3750         return type to bool.
3751         * gdbarch.c: Regenerate.
3752         * gdbarch.h: Regenerate.
3753         * gdbarch.sh (program_breakpoint_here_p): New method.
3754         * infrun.c (handle_signal_stop): Call
3755         gdbarch_program_breakpoint_here_p.
3756
3757 2020-01-26  Tom Tromey  <tom@tromey.com>
3758
3759         * ctfread.c (struct ctf_fp_info): Reindent.
3760         (_initialize_ctfread): Remove.
3761
3762 2020-01-26  Tom Tromey  <tom@tromey.com>
3763
3764         * psymtab.c (partial_map_expand_apply)
3765         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3766         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3767         (psym_print_stats, psym_expand_symtabs_for_function)
3768         (psym_map_symbol_filenames, psym_map_matching_symbols)
3769         (psym_expand_symtabs_matching)
3770         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3771         (maintenance_check_psymtabs): Use new methods.
3772         * psympriv.h (struct partial_symtab) <readin_p,
3773         get_compunit_symtab>: New methods.
3774         <readin, compunit_symtab>: Remove members.
3775         (struct standard_psymtab): New.
3776         (struct legacy_psymtab): Derive from standard_psymtab.
3777         * dwarf2read.h (struct dwarf2_psymtab): Derive from
3778         standard_psymtab.
3779         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
3780
3781 2020-01-26  Tom Tromey  <tom@tromey.com>
3782
3783         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
3784         read_dependencies.  Add assert.
3785         * psymtab.c (partial_symtab::read_dependencies): New method.
3786         * psympriv.h (struct partial_symtab) <read_dependencies>: New
3787         method.
3788         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
3789         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
3790         read_dependencies.
3791         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
3792         Add assert.
3793
3794 2020-01-26  Tom Tromey  <tom@tromey.com>
3795
3796         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
3797         Call expand_psymtab.
3798         (xcoff_read_symtab): Call expand_psymtab.
3799         (xcoff_start_psymtab, xcoff_end_psymtab): Set
3800         legacy_expand_psymtab.
3801         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
3802         method.
3803         (struct legacy_psymtab) <expand_psymtab>: Implement.
3804         <legacy_expand_psymtab>: New member.
3805         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
3806         (parse_partial_symbols): Set legacy_expand_psymtab.
3807         (psymtab_to_symtab_1): Change argument order.  Call
3808         expand_psymtab.
3809         (new_psymtab): Set legacy_expand_psymtab.
3810         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
3811         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
3812         expand_psymtab.
3813         (dwarf2_psymtab::expand_psymtab): Rename from
3814         psymtab_to_symtab_1.  Call expand_psymtab.
3815         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
3816         (dbx_end_psymtab): Likewise.
3817         (dbx_psymtab_to_symtab_1): Change argument order. Call
3818         expand_psymtab.
3819         (dbx_read_symtab): Call expand_psymtab.
3820         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
3821         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
3822         (ctf_psymtab::read_symtab): Call expand_psymtab.
3823
3824 2020-01-26  Tom Tromey  <tom@tromey.com>
3825
3826         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
3827         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
3828         messages.
3829         * mdebugread.c (mdebug_read_symtab): Remove prints.
3830         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
3831         assert.
3832         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
3833
3834 2020-01-26  Tom Tromey  <tom@tromey.com>
3835
3836         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
3837         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
3838         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
3839         legacy_symtab.
3840         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
3841         * psymtab.c (psymtab_to_symtab): Call method.
3842         (dump_psymtab): Update.
3843         * psympriv.h (struct partial_symtab): Add virtual destructor.
3844         <read_symtab>: New method.
3845         (struct legacy_symtab): New.
3846         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
3847         (struct pst_map) <pst>: Now a legacy_psymtab.
3848         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
3849         (new_psymtab): Use legacy_psymtab.
3850         * dwarf2read.h (struct dwarf2_psymtab): New.
3851         (struct dwarf2_per_cu_data) <psymtab>: Use it.
3852         * dwarf2read.c (dwarf2_create_include_psymtab)
3853         (dwarf2_build_include_psymtabs, create_type_unit_group)
3854         (create_partial_symtab, process_psymtab_comp_unit_reader)
3855         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
3856         (set_partial_user): Use dwarf2_psymtab.
3857         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
3858         (psymtab_to_symtab_1, process_full_comp_unit)
3859         (process_full_type_unit, dwarf2_ranges_read)
3860         (dwarf2_get_pc_bounds, psymtab_include_file_name)
3861         (dwarf_decode_lines): Use dwarf2_psymtab.
3862         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
3863         (add_address_entry_worker, write_one_signatured_type)
3864         (recursively_count_psymbols, recursively_write_psymbols)
3865         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
3866         (write_debug_names): Likewise.
3867         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
3868         <pst>: Now a legacy_psymtab.
3869         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
3870         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
3871         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
3872         * ctfread.c (struct ctf_psymtab): New.
3873         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
3874         ctf_psymtab.
3875         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
3876         (create_partial_symtab): Return a ctf_psymtab.
3877         (scan_partial_symbols): Update.
3878
3879 2020-01-26  Tom Tromey  <tom@tromey.com>
3880
3881         * xcoffread.c (xcoff_start_psymtab): Use new.
3882         * psymtab.c (partial_symtab::partial_symtab): New constructor,
3883         renamed from start_psymtab_common.
3884         * psympriv.h (struct partial_symtab): Add new constructor.
3885         (start_psymtab_common): Don't declare.
3886         * mdebugread.c (parse_partial_symbols): Use new.
3887         * dwarf2read.c (create_partial_symtab): Use new.
3888         * dbxread.c (start_psymtab): Use new.
3889         * ctfread.c (create_partial_symtab): Use new.
3890
3891 2020-01-26  Tom Tromey  <tom@tromey.com>
3892
3893         * xcoffread.c (xcoff_end_psymtab): Use new.
3894         * psymtab.c (start_psymtab_common): Use new.
3895         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
3896         Update.
3897         * psympriv.h (struct partial_symtab): Add parameters to
3898         constructor.  Don't inline.
3899         (allocate_psymtab): Don't declare.
3900         * mdebugread.c (new_psymtab): Use new.
3901         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
3902         * dbxread.c (dbx_end_psymtab): Use new.
3903
3904 2020-01-26  Tom Tromey  <tom@tromey.com>
3905
3906         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
3907         allocate_psymtab.  Update documentation.
3908         * psymtab.c (psymtab_storage::install_psymtab): Rename from
3909         allocate_psymtab.  Do not use new.
3910         (allocate_psymtab): Use new.  Update.
3911
3912 2020-01-26  Tom Tromey  <tom@tromey.com>
3913
3914         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3915         * psymtab.c (psym_print_stats): Update.
3916         * psympriv.h (struct partial_symtab) <readin,
3917         psymtabs_addrmap_supported, anonymous>: Now bool.
3918         * mdebugread.c (psymtab_to_symtab_1): Update.
3919         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
3920         (build_type_psymtabs_reader, psymtab_to_symtab_1)
3921         (process_full_comp_unit, process_full_type_unit): Update.
3922         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
3923         * ctfread.c (psymtab_to_symtab): Update.
3924
3925 2020-01-26  Tom Tromey  <tom@tromey.com>
3926
3927         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
3928         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
3929         * psymtab.c (psymtab_storage): Delete psymtabs.
3930         (psymtab_storage::allocate_psymtab): Use new.
3931         (psymtab_storage::discard_psymtab): Use delete.
3932         * psympriv.h (struct partial_symtab): Add constructor and
3933         initializers.
3934
3935 2020-01-26  Tom Tromey  <tom@tromey.com>
3936
3937         * machoread.c: Do not include psympriv.h.
3938
3939 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940
3941         * NEWS: Mention the new option and the set/show commands.
3942
3943 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944
3945         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
3946         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
3947         (validate_exec_file): New variables, enums, functions.
3948         (exec_file_locate_attach, print_section_info): Style the filenames.
3949         (_initialize_exec): Install show_exec_file_mismatch_command and
3950          set_exec_file_mismatch_command.
3951         * gdbcore.h (validate_exec_file): Declare.
3952         * infcmd.c (attach_command): Call validate_exec_file.
3953         * remote.c ( remote_target::remote_add_inferior): Likewise.
3954
3955 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * frame.c (find_frame_sal): Move call to get_next_frame into more
3958         inner scope.
3959         * inline-frame.c (inilne_state) <inline_state>: Update argument
3960         types.
3961         (inilne_state) <skipped_symbol>: Rename to...
3962         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
3963         (skip_inline_frames): Build vector of skipped symbols and use this
3964         to reate the inline_state.
3965         (inline_skipped_symbol): Add a comment and some assertions, fetch
3966         skipped symbol from the list.
3967
3968 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * buildsym.c (lte_is_less_than): Delete.
3971         (buildsym_compunit::end_symtab_with_blockvector): Create local
3972         lambda function to sort line table entries, and use
3973         std::stable_sort instead of std::sort.
3974         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
3975         markers when looking for a previous line.
3976
3977 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3978
3979         * dwarf2read.c (lnp_state_machine::record_line): Include
3980         end_sequence parameter in debug print out.  Record the line if we
3981         are at an end_sequence marker even if it's not the start of a
3982         statement.
3983         * symmisc.c (maintenance_print_one_line_table): Print end of
3984         sequence markers with 'END' not '0'.
3985
3986 2020-01-24  Pedro Alves  <palves@redhat.com>
3987
3988         PR gdb/25410
3989         * thread.c (scoped_restore_current_thread::restore): Use
3990         switch_to_inferior_no_thread.
3991         * exec.c: Include "progspace-and-thread.h".
3992         (add_target_sections, remove_target_sections):
3993         scoped_restore_current_pspace_and_thread instead of
3994         scoped_restore_current_thread.
3995         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3996         and aspace to the inferior before calling clone_program_space.
3997         Remove stale comment.
3998
3999 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4000
4001         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
4002         (arm_netbsd_nat_target::fetch_registers): ...this.
4003         (arm_nbsd_nat_target::store_registers): Rename to...
4004         (arm_netbsd_nat_target::store_registers): ...this.
4005
4006 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4007
4008         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
4009         register_t.
4010
4011 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
4012
4013         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
4014         Update comment.
4015         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
4016         Likewise.
4017         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
4018         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
4019         the correct replacement (iterate_over_regset_sections).
4020         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
4021         Update comment.
4022
4023 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
4024
4025         PR gdb/23718
4026         * gdb/python/python.c (execute_gdb_command): Call
4027         async_enable_stdin in catch block.
4028
4029 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4030
4031         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
4032         SWITCH_THRU_ALL_UIS.
4033
4034 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         PR tui/9765
4037         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
4038         comment, add extra parameter, and update to store previous symbol
4039         when appropriate.
4040         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
4041         add extra parameter.
4042         * tui/tui-disasm.c (tui_disassemble): Update header comment,
4043         remove unneeded parameter, add try/catch around gdb_print_insn,
4044         rewrite to add items to asm_lines vector.
4045         (tui_find_backward_disassembly_start_address): New function.
4046         (tui_find_disassembly_address): Updated throughout.
4047         (tui_disasm_window::set_contents): Update for changes to
4048         tui_disassemble.
4049         (tui_disasm_window::do_scroll_vertical): No need to adjust the
4050         number of lines to scroll.
4051
4052 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
4053
4054         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
4055         (SECT_OFF_DATA): Likewise.
4056         (SECT_OFF_RODATA): Likewise.
4057         (SECT_OFF_TEXT): Likewise.
4058         (SECT_OFF_BSS): Likewise.
4059         (struct objfile) <text_section_offset, data_section_offset>: New
4060         methods.
4061         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
4062         objfile::text_section_offset.
4063         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
4064         * coffread.c (coff_symtab_read): Likewise.
4065         (enter_linenos): Likewise.
4066         (process_coff_symbol): Likewise.
4067         * ctfread.c (get_objfile_text_range): Likewise.
4068         * dtrace-probe.c (dtrace_probe::get_relocated_address):
4069         Use objfile::data_section_offset.
4070         * dwarf2-frame.c (execute_cfa_program): Use
4071         objfile::text_section_offset.
4072         (dwarf2_frame_find_fde): Likewise.
4073         * dwarf2read.c (create_addrmap_from_index): Likewise.
4074         (create_addrmap_from_aranges): Likewise.
4075         (dw2_find_pc_sect_compunit_symtab): Likewise.
4076         (process_psymtab_comp_unit_reader): Likewise.
4077         (add_partial_symbol): Likewise.
4078         (add_partial_subprogram): Likewise.
4079         (process_full_comp_unit): Likewise.
4080         (read_file_scope): Likewise.
4081         (read_func_scope): Likewise.
4082         (read_lexical_block_scope): Likewise.
4083         (read_call_site_scope): Likewise.
4084         (dwarf2_rnglists_process): Likewise.
4085         (dwarf2_ranges_process): Likewise.
4086         (dwarf2_ranges_read): Likewise.
4087         (dwarf_decode_lines_1): Likewise.
4088         (new_symbol): Likewise.
4089         (dwarf2_fetch_die_loc_sect_off): Likewise.
4090         (dwarf2_per_cu_text_offset): Likewise.
4091         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
4092         * hppa-tdep.c (read_unwind_info): Likewise.
4093         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
4094         * psympriv.h (struct partial_symtab): Likewise.
4095         * psymtab.c (find_pc_sect_psymtab): Likewise.
4096         * solib-svr4.c (enable_break): Likewise.
4097         * stap-probe.c (relocate_address): Use
4098         objfile::data_section_offset.
4099         * xcoffread.c (enter_line_range): Use
4100         objfile::text_section_offset.
4101         (read_xcoff_symtab): Likewise.
4102
4103 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4104
4105         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
4106         declaration to narrower scopes.
4107
4108 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
4109
4110         * darwin-nat.h (struct darwin_exception_msg, enum
4111         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
4112         Move up.
4113         (class darwin_nat_target) <wait_1, check_new_threads,
4114         decode_exception_message, decode_message, stop_inferior,
4115         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
4116         * darwin-nat.c (darwin_check_new_threads): Rename to...
4117         (darwin_nat_target::check_new_threads): ... this.
4118         (darwin_suspend_inferior_it): Remove.
4119         (darwin_decode_exception_message): Rename to...
4120         (darwin_nat_target::decode_exception_message): ... this.
4121         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
4122         (darwin_decode_message): Rename to...
4123         (darwin_nat_target::decode_message): ... this.
4124         (cancel_breakpoint): Rename to...
4125         (darwin_nat_target::cancel_breakpoint): ... this.
4126         (darwin_wait): Rename to...
4127         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
4128         instead of iterate_over_inferiors.
4129         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
4130         (darwin_stop_inferior): Rename to...
4131         (darwin_nat_target::stop_inferior): ... this.
4132         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
4133         (darwin_init_thread_list): Rename to...
4134         (darwin_nat_target::init_thread_list): ... this.
4135         (darwin_ptrace_him): Rename to...
4136         (darwin_nat_target::ptrace_him): ... this.
4137         (darwin_nat_target::create_inferior): Pass lambda function to
4138         fork_inferior.
4139         (darwin_nat_target::detach): Call stop_inferior instead of
4140         darwin_stop_inferior.
4141         * fork-inferior.h (fork_inferior): Change init_trace_fun
4142         parameter to gdb::function_view.
4143         * fork-inferior.c (fork_inferior): Likewise.
4144
4145 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
4146
4147         * i386-cygwin-tdep.c (core_process_module_section): Update.
4148         * windows-nat.c (struct lm_info_windows): Add text_offset.
4149         (windows_xfer_shared_libraries): Update.
4150         * windows-tdep.c (windows_xfer_shared_library):
4151         Add text_offset_cached argument.
4152         * windows-tdep.h (windows_xfer_shared_library): Update.
4153
4154 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4155
4156         * gdbarch.sh: Add declaration for _initialize_gdbarch.
4157
4158 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4159
4160         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
4161         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
4162         replace with range-based for.
4163         (gdbsim_interrupt_inferior): Remove.
4164         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
4165         with a range-based for.  Inline code from
4166         gdbsim_interrupt_inferior.
4167
4168 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
4169
4170         * infrun.c (proceed): Fix indentation.
4171
4172 2020-01-21  Tom Tromey  <tromey@adacore.com>
4173
4174         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
4175         * python/python.c (python_extension_ops): Update.
4176         (gdbpy_colorize): New function.
4177         * python/lib/gdb/__init__.py (colorize): New function.
4178         * extension.h (ext_lang_colorize): Declare.
4179         * extension.c (ext_lang_colorize): New function.
4180         * extension-priv.h (struct extension_language_ops) <colorize>: New
4181         member.
4182         * cli/cli-style.c (_initialize_cli_style): Update help text.
4183
4184 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4185
4186         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
4187         <cond>: Change type to bool.
4188         (aarch64_displaced_step_b_cond): Update cond to use bool type.
4189         (aarch64_displaced_step_cb): Likewise.
4190         (aarch64_displaced_step_tb): Likewise.
4191
4192 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4193
4194         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
4195         output.
4196
4197 2020-01-21  Luis Machado  <luis.machado@linaro.org>
4198
4199         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
4200         <pc_adjust>: Adjust the documentation.
4201         (aarch64_displaced_step_fixup): Check if PC really moved before
4202         adjusting it.
4203
4204 2020-01-19  Tom Tromey  <tom@tromey.com>
4205
4206         * disasm.c (~gdb_disassembler): New destructor.
4207         (gdb_buffered_insn_length): Call disassemble_free_target.
4208         * disasm.h (class gdb_disassembler): Declare destructor.  Use
4209         DISABLE_COPY_AND_ASSIGN.
4210
4211 2020-01-19  Tom Tromey  <tom@tromey.com>
4212
4213         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
4214         (die_reader_func_ftype): Remove.
4215         (cutu_reader): New class.
4216         (dw2_get_file_names_reader): Remove "data" parameter.
4217         (dw2_get_file_names): Use cutu_reader.
4218         (create_debug_type_hash_table): Update.
4219         (read_cutu_die_from_dwo): Update comment.
4220         (lookup_dwo_unit): Add dwo_name parameter.
4221         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
4222         die_reader_func_ftype and data parameters.
4223         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
4224         Remove die_reader_func_ftype and data parameters.
4225         (~cutu_reader): New; from init_cutu_and_read_dies.
4226         (cutu_reader::cutu_reader): Rename from
4227         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
4228         and data parameters.
4229         (init_cutu_and_read_dies_simple): Remove.
4230         (struct process_psymtab_comp_unit_data): Remove.
4231         (process_psymtab_comp_unit_reader): Remove data parameter; add
4232         want_partial_unit and pretend_language parameters.
4233         (process_psymtab_comp_unit): Use cutu_reader.
4234         (build_type_psymtabs_reader): Remove data parameter.
4235         (build_type_psymtabs_1): Use cutu_reader.
4236         (process_skeletonless_type_unit): Likewise.
4237         (load_partial_comp_unit_reader): Remove.
4238         (load_partial_comp_unit): Use cutu_reader.
4239         (load_full_comp_unit_reader): Remove.
4240         (load_full_comp_unit): Use cutu_reader.
4241         (struct create_dwo_cu_data): Remove.
4242         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
4243         dwo_unit parameters.
4244         (create_cus_hash_table): Use cutu_reader.
4245         (struct dwarf2_read_addr_index_data): Remove.
4246         (dwarf2_read_addr_index_reader): Remove.
4247         (dwarf2_read_addr_index): Use cutu_reader.
4248         (read_signatured_type_reader): Remove.
4249         (read_signatured_type): Use cutu_reader.
4250
4251 2020-01-19  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
4254         * tui/tui-wingeneral.h (class tui_suppress_output): New.
4255         (tui_wrefresh): Declare.
4256         * tui/tui-wingeneral.c (suppress_output): New global.
4257         (tui_suppress_output, ~tui_suppress_output): New constructor and
4258         destructor.
4259         (tui_wrefresh): New function.
4260         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
4261         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
4262         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
4263         method.
4264         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
4265         tui_wrefresh.
4266         (tui_data_window::no_refresh): New method.
4267         (tui_data_item_window::refresh_window): Call tui_wrefresh.
4268         (tui_reg_command): Use tui_suppress_output
4269         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
4270         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
4271         method.
4272         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
4273
4274 2020-01-19  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4277         Handle case where symtab is null.
4278
4279 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
4280
4281         * linux-fork.c (one_fork_p): Simplify.
4282
4283 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4284
4285         * top.c (struct qt_args): Remove.
4286         (kill_or_detach): Change return type to void, replace `void *`
4287         parameter with a proper one.
4288         (print_inferior_quit_action):  Likewise.
4289         (quit_confirm): Use range-based for loop to iterate over inferiors.
4290         (quit_force): Likewise.
4291
4292 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4293
4294         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
4295         `void *` parameter with proper parameters.
4296         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
4297         (print_one_inferior): Change return type to void, replace `void *`
4298         parameter with proper parameters.
4299         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
4300         inferiors.
4301         (get_other_inferior): Remove.
4302         (mi_cmd_remove_inferior): Use range-based loop to iterate over
4303         inferiors.
4304
4305 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4306
4307         * mi/mi-interp.c (report_initial_inferior): Remove.
4308         (mi_interp::init): Use range-based for to iterate over inferiors.
4309
4310 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
4311
4312         * python/py-inferior.c (build_inferior_list): Remove.
4313         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
4314
4315 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
4316
4317         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
4318         (btrace_stitch_trace): Likewise.
4319         * charset.c (intermediate_encoding): Likewise (vaild).
4320         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
4321         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
4322         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
4323
4324 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
4325
4326         * windows-tdep.c (windows_get_tlb_type):
4327         Add rtl_user_process_parameters type.
4328
4329 2020-01-16  Pedro Alves  <palves@redhat.com>
4330             Norbert Lange  <nolange79@gmail.com>
4331
4332         PR build/24805
4333         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
4334         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
4335         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
4336         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
4337         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
4338         (ps_plog): Redeclare exported functions with default visibility.
4339
4340 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
4341
4342         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
4343         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
4344
4345 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
4346
4347         * infcmd.c (post_create_inferior): Use get_thread_regcache
4348         instead of get_current_regcache.
4349
4350 2020-01-14  Tom Tromey  <tom@tromey.com>
4351
4352         PR symtab/12535:
4353         * python/python.c (gdbpy_decode_line): Treat empty string the same
4354         as no argument.
4355
4356 2020-01-14  Tom Tromey  <tom@tromey.com>
4357
4358         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
4359
4360 2020-01-14  Tom Tromey  <tom@tromey.com>
4361
4362         * nat/linux-btrace.c: Don't include <config.h>.
4363         * nat/linux-ptrace.c: Don't include <config.h>.
4364         * nat/x86-linux-dregs.c: Don't include <config.h>.
4365
4366 2020-01-14  Tom Tromey  <tom@tromey.com>
4367
4368         * configure: Rebuild.
4369         * configure.ac: Move many checks to ../gdbsupport/common.m4.
4370
4371 2020-01-14  Tom Tromey  <tom@tromey.com>
4372
4373         * nat/x86-linux-dregs.c: Include configh.h.
4374         * nat/linux-ptrace.c: Include configh.h.
4375         * nat/linux-btrace.c: Include configh.h.
4376         * defs.h: Include config.h, bfd.h.
4377         * configure.ac: Don't source common.host.
4378         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
4379         * configure: Rebuild.
4380         * acinclude.m4: Update path.
4381         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
4382         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
4383         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
4384         (CLIBS): Add LIBSUPPORT.
4385         (CDEPS): Likewise.
4386         (COMMON_SFILES): Remove gdbsupport files.
4387         (HFILES_NO_SRCDIR): Likewise.
4388         (stamp-version): Update path to create-version.sh.
4389         (ALLDEPFILES): Remove gdbsupport files.
4390
4391 2020-01-14  Tom Tromey  <tom@tromey.com>
4392
4393         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
4394         USE_WIN32API when needed.
4395         * configure.ac (USE_WIN32API): Don't define.
4396         (WIN32LIBS): Use WIN32APILIBS.
4397         * configure: Rebuild.
4398
4399 2020-01-14  Tom Tromey  <tom@tromey.com>
4400
4401         * configure: Rebuild.
4402         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
4403
4404 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4405
4406         * skip.c (skip_function_command): Make skip w/o arguments use the
4407         name of the inlined function if pc is inside any inlined function.
4408
4409 2020-01-14  Luis Machado  <luis.machado@linaro.org>
4410
4411         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
4412         * infrun.c (resume_1): Likewise.
4413         (handle_inferior_event): Remove stale comment.
4414         * linux-nat.c (linux_nat_target::resume): Update comments.
4415         (save_stop_reason): Likewise.
4416         (linux_nat_filter_event): Likewise.
4417         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
4418
4419 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * elfread.c (record_minimal_symbol): Set section index to 0 for
4422         non-allocatable sections.
4423
4424
4425 2020-01-13  Ali Tamur <tamur@google.com>
4426
4427         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
4428         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
4429         to gdb::optional.  Update comments.
4430         (dwo_file): Update comments.
4431         (read_attribute): Update API to take an additional out parameter,
4432         need_reprocess.  This is used to mark attributes that need other
4433         attributes (e.g. str_offsets_base) for correct computation which may not
4434         have been read yet.
4435         (read_attribute_reprocess): New function declaration.
4436         (read_addr_index): Likewise.
4437         (read_dwo_str_index): Likewise.
4438         (read_stub_str_index): Likewise.
4439         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
4440         (lookup_addr_base): New function definition.
4441         (lookup_ranges_base): Likewise.
4442         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
4443         lookup_ranges_base.
4444         (init_cutu_and_read_dies): Update comments.
4445         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
4446         unit.  This is used to inherit parent's str_offsets_base and addr_base.
4447         Update comments.
4448         (init_cutu_and_read_dies_simple): Reflect API changes.
4449         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
4450         (create_cus_hash_table): Change API to take parent compile unit.
4451         Reflect API changes.
4452         (open_and_init_dwo_file): Reflect API changes.
4453         (dwarf2_get_pc_bounds): Update comments.
4454         (dwarf2_record_block_ranges): Likewise.
4455         (read_full_die_1): Change implementation to reprocess attributes that
4456         need str_offsets_base and addr_base.
4457         (partial_die_info::read): Likewise.
4458         (read_attribute_reprocess): New function definition.
4459         (read_attribute_value): Change API to take an additional out parameter,
4460         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
4461         when a non-dwo compile unit has index based attributes.
4462         (read_attribute): Reflect API changes.
4463         (read_addr_index_1): Reflect API changes.  Update comments.
4464         (dwarf2_read_addr_index_data): Reflect API changes.
4465         (dwarf2_read_addr_index): Likewise.
4466         (read_str_index): Change API and implementation.  This becomes a helper
4467         to be used by the new string index related methods.  Update error
4468         message and comments.
4469         (read_dwo_str_index): New function definition.
4470         (read_stub_str_index): Likewise.
4471         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
4472         * symfile.h (dwarf2_debug_sections): Likewise.
4473         * xcoffread.c (dwarf2_debug_sections): Likewise.
4474
4475 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4476
4477         * gdbcore.h (struct core_fns) <core_read_registers>: Change
4478         core_reg_sect type to gdb_byte *.
4479         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
4480         * cris-tdep.c (fetch_core_registers): Likewise.
4481         * corelow.c (core_target::get_core_register_section): Change
4482         type of `contents` to gdb::byte_vector.
4483
4484 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4485
4486         * tui/tui-wingeneral.c (box_win): Position the title in the center
4487         of the border.
4488
4489 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4490
4491         * corelow.c (core_target::get_core_register_section): Use
4492           std::vector instead of alloca.
4493
4494 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4495
4496         * warning.m4: Add -Wmissing-declarations to build_warnings.
4497         * configure: Re-generate.
4498
4499 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4500
4501         * python/python.c (init__gdb_module): Add declaration.
4502
4503 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4504
4505         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
4506         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
4507         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
4508         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
4509         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
4510         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
4511         * ada-exp.y (_initialize_ada_exp): Add declaration.
4512         * ada-lang.c (_initialize_ada_language): Add declaration.
4513         * ada-tasks.c (_initialize_tasks): Add declaration.
4514         * agent.c (_initialize_agent): Add declaration.
4515         * aix-thread.c (_initialize_aix_thread): Add declaration.
4516         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
4517         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
4518         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
4519         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
4520         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
4521         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
4522         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
4523         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
4524         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
4525         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
4526         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
4527         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
4528         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
4529         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
4530         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
4531         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
4532         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
4533         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
4534         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
4535         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
4536         * annotate.c (_initialize_annotate): Add declaration.
4537         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
4538         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
4539         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
4540         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
4541         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
4542         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
4543         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
4544         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
4545         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
4546         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
4547         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
4548         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
4549         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
4550         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
4551         * auto-load.c (_initialize_auto_load): Add declaration.
4552         * auxv.c (_initialize_auxv): Add declaration.
4553         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
4554         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
4555         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
4556         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
4557         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
4558         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
4559         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
4560         * breakpoint.c (_initialize_breakpoint): Add declaration.
4561         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
4562         * btrace.c (_initialize_btrace): Add declaration.
4563         * charset.c (_initialize_charset): Add declaration.
4564         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
4565         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
4566         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
4567         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
4568         * cli/cli-script.c (_initialize_cli_script): Add declaration.
4569         * cli/cli-style.c (_initialize_cli_style): Add declaration.
4570         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
4571         * coffread.c (_initialize_coffread): Add declaration.
4572         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
4573         * compile/compile.c (_initialize_compile): Add declaration.
4574         * complaints.c (_initialize_complaints): Add declaration.
4575         * completer.c (_initialize_completer): Add declaration.
4576         * copying.c (_initialize_copying): Add declaration.
4577         * corefile.c (_initialize_core): Add declaration.
4578         * corelow.c (_initialize_corelow): Add declaration.
4579         * cp-abi.c (_initialize_cp_abi): Add declaration.
4580         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
4581         * cp-support.c (_initialize_cp_support): Add declaration.
4582         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
4583         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
4584         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
4585         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
4586         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
4587         * ctfread.c (_initialize_ctfread): Add declaration.
4588         * d-lang.c (_initialize_d_language): Add declaration.
4589         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
4590         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
4591         * dbxread.c (_initialize_dbxread): Add declaration.
4592         * dcache.c (_initialize_dcache): Add declaration.
4593         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
4594         * disasm.c (_initialize_disasm): Add declaration.
4595         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
4596         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
4597         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
4598         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
4599         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
4600         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
4601         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
4602         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
4603         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
4604         * elfread.c (_initialize_elfread): Add declaration.
4605         * exec.c (_initialize_exec): Add declaration.
4606         * extension.c (_initialize_extension): Add declaration.
4607         * f-lang.c (_initialize_f_language): Add declaration.
4608         * f-valprint.c (_initialize_f_valprint): Add declaration.
4609         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
4610         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
4611         * filesystem.c (_initialize_filesystem): Add declaration.
4612         * findcmd.c (_initialize_mem_search): Add declaration.
4613         * findvar.c (_initialize_findvar): Add declaration.
4614         * fork-child.c (_initialize_fork_child): Add declaration.
4615         * frame-base.c (_initialize_frame_base): Add declaration.
4616         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
4617         * frame.c (_initialize_frame): Add declaration.
4618         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
4619         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
4620         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
4621         * gcore.c (_initialize_gcore): Add declaration.
4622         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
4623         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
4624         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
4625         * gdbarch.c (_initialize_gdbarch): Add declaration.
4626         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
4627         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
4628         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
4629         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
4630         * go-lang.c (_initialize_go_language): Add declaration.
4631         * go32-nat.c (_initialize_go32_nat): Add declaration.
4632         * guile/guile.c (_initialize_guile): Add declaration.
4633         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
4634         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
4635         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
4636         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
4637         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
4638         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
4639         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
4640         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
4641         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
4642         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
4643         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
4644         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
4645         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
4646         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
4647         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
4648         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
4649         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
4650         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
4651         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
4652         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
4653         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
4654         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
4655         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
4656         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
4657         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
4658         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
4659         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
4660         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
4661         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
4662         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
4663         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
4664         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
4665         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
4666         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
4667         * infcall.c (_initialize_infcall): Add declaration.
4668         * infcmd.c (_initialize_infcmd): Add declaration.
4669         * inflow.c (_initialize_inflow): Add declaration.
4670         * infrun.c (_initialize_infrun): Add declaration.
4671         * interps.c (_initialize_interpreter): Add declaration.
4672         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
4673         * jit.c (_initialize_jit): Add declaration.
4674         * language.c (_initialize_language): Add declaration.
4675         * linux-fork.c (_initialize_linux_fork): Add declaration.
4676         * linux-nat.c (_initialize_linux_nat): Add declaration.
4677         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
4678         * linux-thread-db.c (_initialize_thread_db): Add declaration.
4679         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
4680         * m2-lang.c (_initialize_m2_language): Add declaration.
4681         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
4682         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
4683         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
4684         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
4685         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
4686         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
4687         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
4688         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
4689         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
4690         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
4691         * machoread.c (_initialize_machoread): Add declaration.
4692         * macrocmd.c (_initialize_macrocmd): Add declaration.
4693         * macroscope.c (_initialize_macroscope): Add declaration.
4694         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
4695         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
4696         * maint.c (_initialize_maint_cmds): Add declaration.
4697         * mdebugread.c (_initialize_mdebugread): Add declaration.
4698         * memattr.c (_initialize_mem): Add declaration.
4699         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
4700         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
4701         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
4702         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
4703         * mi/mi-main.c (_initialize_mi_main): Add declaration.
4704         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
4705         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
4706         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
4707         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
4708         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
4709         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
4710         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
4711         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
4712         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
4713         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
4714         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
4715         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
4716         * mipsread.c (_initialize_mipsread): Add declaration.
4717         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
4718         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
4719         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
4720         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
4721         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
4722         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
4723         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
4724         * nto-procfs.c (_initialize_procfs): Add declaration.
4725         * objc-lang.c (_initialize_objc_language): Add declaration.
4726         * observable.c (_initialize_observer): Add declaration.
4727         * opencl-lang.c (_initialize_opencl_language): Add declaration.
4728         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
4729         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
4730         * osabi.c (_initialize_gdb_osabi): Add declaration.
4731         * osdata.c (_initialize_osdata): Add declaration.
4732         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
4733         * parse.c (_initialize_parse): Add declaration.
4734         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
4735         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
4736         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
4737         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
4738         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
4739         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
4740         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
4741         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
4742         * printcmd.c (_initialize_printcmd): Add declaration.
4743         * probe.c (_initialize_probe): Add declaration.
4744         * proc-api.c (_initialize_proc_api): Add declaration.
4745         * proc-events.c (_initialize_proc_events): Add declaration.
4746         * proc-service.c (_initialize_proc_service): Add declaration.
4747         * procfs.c (_initialize_procfs): Add declaration.
4748         * producer.c (_initialize_producer): Add declaration.
4749         * psymtab.c (_initialize_psymtab): Add declaration.
4750         * python/python.c (_initialize_python): Add declaration.
4751         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
4752         * record-btrace.c (_initialize_record_btrace): Add declaration.
4753         * record-full.c (_initialize_record_full): Add declaration.
4754         * record.c (_initialize_record): Add declaration.
4755         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
4756         * regcache.c (_initialize_regcache): Add declaration.
4757         * reggroups.c (_initialize_reggroup): Add declaration.
4758         * remote-notif.c (_initialize_notif): Add declaration.
4759         * remote-sim.c (_initialize_remote_sim): Add declaration.
4760         * remote.c (_initialize_remote): Add declaration.
4761         * reverse.c (_initialize_reverse): Add declaration.
4762         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
4763         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
4764         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
4765         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
4766         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
4767         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
4768         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
4769         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
4770         Add declaration.
4771         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
4772         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
4773         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
4774         * rust-exp.y (_initialize_rust_exp): Add declaration.
4775         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
4776         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
4777         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
4778         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
4779         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
4780         * score-tdep.c (_initialize_score_tdep): Add declaration.
4781         * ser-go32.c (_initialize_ser_dos): Add declaration.
4782         * ser-mingw.c (_initialize_ser_windows): Add declaration.
4783         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
4784         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
4785         * ser-uds.c (_initialize_ser_socket): Add declaration.
4786         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
4787         * serial.c (_initialize_serial): Add declaration.
4788         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
4789         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
4790         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
4791         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
4792         * skip.c (_initialize_step_skip): Add declaration.
4793         * sol-thread.c (_initialize_sol_thread): Add declaration.
4794         * solib-aix.c (_initialize_solib_aix): Add declaration.
4795         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
4796         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
4797         * solib-frv.c (_initialize_frv_solib): Add declaration.
4798         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
4799         * solib-target.c (_initialize_solib_target): Add declaration.
4800         * solib.c (_initialize_solib): Add declaration.
4801         * source-cache.c (_initialize_source_cache): Add declaration.
4802         * source.c (_initialize_source): Add declaration.
4803         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
4804         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
4805         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
4806         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
4807         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
4808         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
4809         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
4810         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
4811         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
4812         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
4813         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
4814         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
4815         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
4816         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
4817         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
4818         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
4819         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
4820         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
4821         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
4822         * stabsread.c (_initialize_stabsread): Add declaration.
4823         * stack.c (_initialize_stack): Add declaration.
4824         * stap-probe.c (_initialize_stap_probe): Add declaration.
4825         * std-regs.c (_initialize_frame_reg): Add declaration.
4826         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
4827         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
4828         * symfile.c (_initialize_symfile): Add declaration.
4829         * symmisc.c (_initialize_symmisc): Add declaration.
4830         * symtab.c (_initialize_symtab): Add declaration.
4831         * target.c (_initialize_target): Add declaration.
4832         * target-connection.c (_initialize_target_connection): Add
4833         declaration.
4834         * target-dcache.c (_initialize_target_dcache): Add declaration.
4835         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
4836         * thread.c (_initialize_thread): Add declaration.
4837         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
4838         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
4839         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
4840         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
4841         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
4842         * tracectf.c (_initialize_ctf): Add declaration.
4843         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
4844         * tracefile.c (_initialize_tracefile): Add declaration.
4845         * tracepoint.c (_initialize_tracepoint): Add declaration.
4846         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
4847         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
4848         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
4849         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
4850         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
4851         * tui/tui-win.c (_initialize_tui_win): Add declaration.
4852         * tui/tui.c (_initialize_tui): Add declaration.
4853         * typeprint.c (_initialize_typeprint): Add declaration.
4854         * ui-style.c (_initialize_ui_style): Add declaration.
4855         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
4856         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
4857         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
4858         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
4859         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
4860         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
4861         * unittests/filtered_iterator-selftests.c
4862         (_initialize_filtered_iterator_selftests): Add declaration.
4863         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
4864         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
4865         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
4866         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
4867         * unittests/main-thread-selftests.c
4868         (_initialize_main_thread_selftests): Add declaration.
4869         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
4870         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
4871         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
4872         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
4873         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
4874         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
4875         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
4876         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
4877         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
4878         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
4879         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
4880         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
4881         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
4882         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
4883         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
4884         declaration.
4885         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
4886         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
4887         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
4888         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
4889         * user-regs.c (_initialize_user_regs): Add declaration.
4890         * utils.c (_initialize_utils): Add declaration.
4891         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
4892         * valops.c (_initialize_valops): Add declaration.
4893         * valprint.c (_initialize_valprint): Add declaration.
4894         * value.c (_initialize_values): Add declaration.
4895         * varobj.c (_initialize_varobj): Add declaration.
4896         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
4897         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
4898         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
4899         * windows-nat.c (_initialize_windows_nat): Add declaration.
4900         (_initialize_check_for_gdb_ini): Add declaration.
4901         (_initialize_loadable): Add declaration.
4902         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
4903         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
4904         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
4905         * xcoffread.c (_initialize_xcoffread): Add declaration.
4906         * xml-support.c (_initialize_xml_support): Add declaration.
4907         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
4908         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
4909         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
4910         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
4911
4912 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4913
4914         * regformats/regdat.sh: Generate declaration for init function.
4915
4916 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4917
4918         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
4919         up.
4920         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
4921         close_one_inferior>: New methods.
4922         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
4923         pass down target to find_inferior_pid.
4924         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
4925         Pass down target to find_inferior_ptid.
4926         (gdbsim_target::create_inferior): Pass down target to
4927         add_thread_silent.
4928         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
4929         target down to find_inferior_ptid and switch_to_thread.
4930         (gdbsim_target::close): Update to call close_one_inferior.
4931         (struct resume_data): Remove.
4932         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
4933         directly, rather than through a void pointer.
4934         (gdbsim_target::resume): Update to call resume_one_inferior.
4935
4936 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
4937
4938         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
4939
4940 2020-01-12  Pedro Alves  <palves@redhat.com>
4941
4942         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
4943         directly for the current inferior instead of
4944         discard_all_inferiors.
4945         (discard_all_inferiors): Delete.
4946
4947 2020-01-11  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-wingeneral.c (box_win): Check cli_styling.
4950         * tui/tui-winsource.c (tui_source_window_base::refill): Use
4951         deprecated_safe_get_selected_frame.
4952
4953 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4954
4955         * inferior.c (print_inferior): Switch inferior before printing it.
4956
4957 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
4958             Pedro Alves  <palves@redhat.com>
4959
4960         * progspace-and-thread.c (switch_to_program_space_and_thread):
4961         Assert there's an inferior for PSPACE.  Use
4962         switch_to_inferior_no_thread to switch the inferior too.
4963         * progspace.c (program_space::~program_space): Call
4964         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
4965         (program_space::free_all_objfiles): Don't call clear_symtab_users
4966         here.
4967         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
4968
4969 2020-01-10  Pedro Alves  <palves@redhat.com>
4970
4971         * NEWS: Mention multi-target debugging, "info connections", and
4972         "add-inferior -no-connection".
4973
4974 2020-01-10  Pedro Alves  <palves@redhat.com>
4975
4976         * infrun.c: Include "target-connection.h".
4977         (check_multi_target_resumption): New.
4978         (proceed): Call it.
4979         * target-connection.c (make_target_connection_string): Make
4980         extern.
4981         * target-connection.h (make_target_connection_string): Declare.
4982
4983 2020-01-10  Pedro Alves  <palves@redhat.com>
4984
4985         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4986         * inferior.c (uiout_field_connection): New function.
4987         (print_inferior): Add new "connection-id" column.
4988         (add_inferior_command): Show connection number/string of added
4989         inferior.
4990         * process-stratum-target.h
4991         (process_stratum_target::connection_string): New virtual method.
4992         (process_stratum_target::connection_number): New field.
4993         * remote.c (remote_target::connection_string): New override.
4994         * target-connection.c: New file.
4995         * target-connection.h: New file.
4996         * target.c (decref_target): Remove process_stratum targets from
4997         the connection list.
4998         (target_stack::push): Add process_stratum targets to the
4999         connection list.
5000
5001 2020-01-10  Pedro Alves  <palves@redhat.com>
5002
5003         Revert:
5004         2016-04-12  Pedro Alves  <palves@redhat.com>
5005         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
5006         Remove references to name.
5007         * serial.h (struct serial) <name>: Delete.
5008
5009 2020-01-10  Pedro Alves  <palves@redhat.com>
5010
5011         * gdbarch-selftests.c (register_to_value_test): Remove "target
5012         already pushed" check.
5013
5014 2020-01-10  Pedro Alves  <palves@redhat.com>
5015             John Baldwin  <jhb@FreeBSD.org>
5016
5017         * aarch64-linux-nat.c
5018         (aarch64_linux_nat_target::thread_architecture): Adjust.
5019         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
5020         (task_command_1): Likewise.
5021         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
5022         (aix_thread_target::wait, aix_thread_target::fetch_registers)
5023         (aix_thread_target::store_registers)
5024         (aix_thread_target::thread_alive): Adjust.
5025         * amd64-fbsd-tdep.c: Include "inferior.h".
5026         (amd64fbsd_get_thread_local_address): Pass down target.
5027         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
5028         thread's gdbarch instead of target_gdbarch.
5029         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
5030         get_last_target_status.
5031         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
5032         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
5033         inferiors.
5034         (update_inserted_breakpoint_locations): Skip if inferiors with no
5035         execution.
5036         (update_global_location_list): When handling moribund locations,
5037         find representative inferior for location's pspace, and use thread
5038         count of its process_stratum target.
5039         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
5040         * bsd-uthread.c (bsd_uthread_target::wait): Use
5041         as_process_stratum_target and adjust thread_change_ptid and
5042         add_thread calls.
5043         (bsd_uthread_target::update_thread_list): Use
5044         as_process_stratum_target and adjust find_thread_ptid,
5045         thread_change_ptid and add_thread calls.
5046         * btrace.c (maint_btrace_packet_history_cmd): Adjust
5047         find_thread_ptid call.
5048         * corelow.c (add_to_thread_list): Adjust add_thread call.
5049         (core_target_open): Adjust add_thread_silent and thread_count
5050         calls.
5051         (core_target::pid_to_str): Adjust find_inferior_ptid call.
5052         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
5053         * event-top.c (async_disconnect): Pop targets from all inferiors.
5054         * exec.c (add_target_sections): Push exec target on all inferiors
5055         sharing the program space.
5056         (remove_target_sections): Remove the exec target from all
5057         inferiors sharing the program space.
5058         (exec_on_vfork): New.
5059         * exec.h (exec_on_vfork): Declare.
5060         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
5061         Pass it down.
5062         (fbsd_nat_target::update_thread_list): Adjust.
5063         (fbsd_nat_target::resume): Adjust.
5064         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
5065         down.
5066         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
5067         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
5068         get_thread_arch_regcache call.
5069         * fork-child.c (gdb_startup_inferior): Pass target down to
5070         startup_inferior and set_executing.
5071         * gdbthread.h (struct process_stratum_target): Forward declare.
5072         (add_thread, add_thread_silent, add_thread_with_info)
5073         (in_thread_list): Add process_stratum_target parameter.
5074         (find_thread_ptid(inferior*, ptid_t)): New overload.
5075         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
5076         parameter.
5077         (all_threads()): Delete overload.
5078         (all_threads, all_non_exited_threads): Add process_stratum_target
5079         parameter.
5080         (all_threads_safe): Use brace initialization.
5081         (thread_count): Add process_stratum_target parameter.
5082         (set_resumed, set_running, set_stop_requested, set_executing)
5083         (threads_are_executing, finish_thread_state): Add
5084         process_stratum_target parameter.
5085         (switch_to_thread): Use is_current_thread.
5086         * i386-fbsd-tdep.c: Include "inferior.h".
5087         (i386fbsd_get_thread_local_address): Pass down target.
5088         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
5089         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
5090         have_inferiors check.
5091         * inf-ptrace.c (inf_ptrace_target::create_inferior)
5092         (inf_ptrace_target::attach): Adjust.
5093         * infcall.c (run_inferior_call): Adjust.
5094         * infcmd.c (run_command_1): Pass target to
5095         scoped_finish_thread_state.
5096         (proceed_thread_callback): Skip inferiors with no execution.
5097         (continue_command): Rename 'all_threads' local to avoid hiding
5098         'all_threads' function.  Adjust get_last_target_status call.
5099         (prepare_one_step): Adjust set_running call.
5100         (signal_command): Use user_visible_resume_target.  Compare thread
5101         pointers instead of inferior_ptid.
5102         (info_program_command): Adjust to pass down target.
5103         (attach_command): Mark target's 'thread_executing' flag.
5104         (stop_current_target_threads_ns): New, factored out from ...
5105         (interrupt_target_1): ... this.  Switch inferior before making
5106         target calls.
5107         * inferior-iter.h
5108         (struct all_inferiors_iterator, struct all_inferiors_range)
5109         (struct all_inferiors_safe_range)
5110         (struct all_non_exited_inferiors_range): Filter on
5111         process_stratum_target too.  Remove explicit.
5112         * inferior.c (inferior::inferior): Push dummy target on target
5113         stack.
5114         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
5115         Add process_stratum_target parameter, and pass it down.
5116         (have_live_inferiors): Adjust.
5117         (switch_to_inferior_and_push_target): New.
5118         (add_inferior_command, clone_inferior_command): Handle
5119         "-no-connection" parameter.  Use
5120         switch_to_inferior_and_push_target.
5121         (_initialize_inferior): Mention "-no-connection" option in
5122         the help of "add-inferior" and "clone-inferior" commands.
5123         * inferior.h: Include "process-stratum-target.h".
5124         (interrupt_target_1): Use bool.
5125         (struct inferior) <push_target, unpush_target, target_is_pushed,
5126         find_target_beneath, top_target, process_target, target_at,
5127         m_stack>: New.
5128         (discard_all_inferiors): Delete.
5129         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
5130         (all_inferiors, all_non_exited_inferiors): Add
5131         process_stratum_target parameter.
5132         * infrun.c: Include "gdb_select.h" and <unordered_map>.
5133         (target_last_proc_target): New global.
5134         (follow_fork_inferior): Push target on new inferior.  Pass target
5135         to add_thread_silent.  Call exec_on_vfork.  Handle target's
5136         reference count.
5137         (follow_fork): Adjust get_last_target_status call.  Also consider
5138         target.
5139         (follow_exec): Push target on new inferior.
5140         (struct execution_control_state) <target>: New field.
5141         (user_visible_resume_target): New.
5142         (do_target_resume): Call target_async.
5143         (resume_1): Set target's threads_executing flag.  Consider resume
5144         target.
5145         (commit_resume_all_targets): New.
5146         (proceed): Also consider resume target.  Skip threads of inferiors
5147         with no execution.  Commit resumtion in all targets.
5148         (start_remote): Pass current inferior to wait_for_inferior.
5149         (infrun_thread_stop_requested): Consider target as well.  Pass
5150         thread_info pointer to clear_inline_frame_state instead of ptid.
5151         (infrun_thread_thread_exit): Consider target as well.
5152         (random_pending_event_thread): New inferior parameter.  Use it.
5153         (do_target_wait): Rename to ...
5154         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
5155         down.
5156         (threads_are_resumed_pending_p, do_target_wait): New.
5157         (prepare_for_detach): Adjust calls.
5158         (wait_for_inferior): New inferior parameter.  Handle it.  Use
5159         do_target_wait_1 instead of do_target_wait.
5160         (fetch_inferior_event): Adjust.  Switch to representative
5161         inferior.  Pass target down.
5162         (set_last_target_status): Add process_stratum_target parameter.
5163         Save target in global.
5164         (get_last_target_status): Add process_stratum_target parameter and
5165         handle it.
5166         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
5167         (context_switch): Check inferior_ptid == null_ptid before calling
5168         inferior_thread().
5169         (get_inferior_stop_soon): Pass down target.
5170         (wait_one): Rename to ...
5171         (poll_one_curr_target): ... this.
5172         (struct wait_one_event): New.
5173         (wait_one): New.
5174         (stop_all_threads): Adjust.
5175         (handle_no_resumed, handle_inferior_event): Adjust to consider the
5176         event's target.
5177         (switch_back_to_stepped_thread): Also consider target.
5178         (print_stop_event): Update.
5179         (normal_stop): Update.  Also consider the resume target.
5180         * infrun.h (wait_for_inferior): Remove declaration.
5181         (user_visible_resume_target): New declaration.
5182         (get_last_target_status, set_last_target_status): New
5183         process_stratum_target parameter.
5184         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5185         process_stratum_target parameter, and use it.
5186         (clear_inline_frame_state (thread_info*)): New.
5187         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
5188         process_stratum_target parameter.
5189         (clear_inline_frame_state (thread_info*)): Declare.
5190         * linux-fork.c (delete_checkpoint_command): Pass target down to
5191         find_thread_ptid.
5192         (checkpoint_command): Adjust.
5193         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
5194         instead of just tweaking inferior_ptid.
5195         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
5196         (exit_lwp): Pass target down to find_thread_ptid.
5197         (attach_proc_task_lwp_callback): Pass target down to
5198         add_thread/set_running/set_executing.
5199         (linux_nat_target::attach): Pass target down to
5200         thread_change_ptid.
5201         (get_detach_signal): Pass target down to find_thread_ptid.
5202         Consider last target status's target.
5203         (linux_resume_one_lwp_throw, resume_lwp)
5204         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
5205         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
5206         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
5207         (linux_nat_target::async_wait_fd): New.
5208         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
5209         target down.
5210         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
5211         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
5212         * linux-thread-db.c (struct thread_db_info::process_target): New
5213         field.
5214         (add_thread_db_info): Save target.
5215         (get_thread_db_info): New process_stratum_target parameter.  Also
5216         match target.
5217         (delete_thread_db_info): New process_stratum_target parameter.
5218         Also match target.
5219         (thread_from_lwp): Adjust to pass down target.
5220         (thread_db_notice_clone): Pass down target.
5221         (check_thread_db_callback): Pass down target.
5222         (try_thread_db_load_1): Always push the thread_db target.
5223         (try_thread_db_load, record_thread): Pass target down.
5224         (thread_db_target::detach): Pass target down.  Always unpush the
5225         thread_db target.
5226         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
5227         target down.  Always unpush the thread_db target.
5228         (find_new_threads_callback, thread_db_find_new_threads_2)
5229         (thread_db_target::update_thread_list): Pass target down.
5230         (thread_db_target::pid_to_str): Pass current inferior down.
5231         (thread_db_target::get_thread_local_address): Pass target down.
5232         (thread_db_target::resume, maintenance_check_libthread_db): Pass
5233         target down.
5234         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
5235         * procfs.c (procfs_target::procfs_init_inferior): Declare.
5236         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
5237         (procfs_init_inferior): Rename to ...
5238         (procfs_target::procfs_init_inferior): ... this and adjust.
5239         (procfs_target::create_inferior, procfs_notice_thread)
5240         (procfs_do_thread_registers): Adjust.
5241         * ppc-fbsd-tdep.c: Include "inferior.h".
5242         (ppcfbsd_get_thread_local_address): Pass down target.
5243         * proc-service.c (ps_xfer_memory): Switch current inferior and
5244         program space as well.
5245         (get_ps_regcache): Pass target down.
5246         * process-stratum-target.c
5247         (process_stratum_target::thread_address_space)
5248         (process_stratum_target::thread_architecture): Pass target down.
5249         * process-stratum-target.h
5250         (process_stratum_target::threads_executing): New field.
5251         (as_process_stratum_target): New.
5252         * ravenscar-thread.c
5253         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
5254         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
5255         down.
5256         * record-btrace.c (record_btrace_target::info_record): Adjust.
5257         (record_btrace_target::record_method)
5258         (record_btrace_target::record_is_replaying)
5259         (record_btrace_target::fetch_registers)
5260         (get_thread_current_frame_id, record_btrace_target::resume)
5261         (record_btrace_target::wait, record_btrace_target::stop): Pass
5262         target down.
5263         * record-full.c (record_full_wait_1): Switch to event thread.
5264         Pass target down.
5265         * regcache.c (regcache::regcache)
5266         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
5267         process_stratum_target parameter and handle it.
5268         (current_thread_target): New global.
5269         (get_thread_regcache): Add process_stratum_target parameter and
5270         handle it.  Switch inferior before calling target method.
5271         (get_thread_regcache): Pass target down.
5272         (get_thread_regcache_for_ptid): Pass target down.
5273         (registers_changed_ptid): Add process_stratum_target parameter and
5274         handle it.
5275         (registers_changed_thread, registers_changed): Pass target down.
5276         (test_get_thread_arch_aspace_regcache): New.
5277         (current_regcache_test): Define a couple local test_target_ops
5278         instances and use them for testing.
5279         (readwrite_regcache): Pass process_stratum_target parameter.
5280         (cooked_read_test, cooked_write_test): Pass mock_target down.
5281         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
5282         (get_thread_arch_aspace_regcache): Add process_stratum_target
5283         parameter.
5284         (regcache::target): New method.
5285         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
5286         (regcache::registers_changed_ptid): Add process_stratum_target
5287         parameter.
5288         (regcache::m_target): New field.
5289         (registers_changed_ptid): Add process_stratum_target parameter.
5290         * remote.c (remote_state::supports_vCont_probed): New field.
5291         (remote_target::async_wait_fd): New method.
5292         (remote_unpush_and_throw): Add remote_target parameter.
5293         (get_current_remote_target): Adjust.
5294         (remote_target::remote_add_inferior): Push target.
5295         (remote_target::remote_add_thread)
5296         (remote_target::remote_notice_new_inferior)
5297         (get_remote_thread_info): Pass target down.
5298         (remote_target::update_thread_list): Skip threads of inferiors
5299         bound to other targets.  (remote_target::close): Don't discard
5300         inferiors.  (remote_target::add_current_inferior_and_thread)
5301         (remote_target::process_initial_stop_replies)
5302         (remote_target::start_remote)
5303         (remote_target::remote_serial_quit_handler): Pass down target.
5304         (remote_target::remote_unpush_target): New remote_target
5305         parameter.  Unpush the target from all inferiors.
5306         (remote_target::remote_unpush_and_throw): New remote_target
5307         parameter.  Pass it down.
5308         (remote_target::open_1): Check whether the current inferior has
5309         execution instead of checking whether any inferior is live.  Pass
5310         target down.
5311         (remote_target::remote_detach_1): Pass down target.  Use
5312         remote_unpush_target.
5313         (extended_remote_target::attach): Pass down target.
5314         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
5315         (remote_target::append_resumption): Pass down target.
5316         (remote_target::append_pending_thread_resumptions)
5317         (remote_target::remote_resume_with_hc, remote_target::resume)
5318         (remote_target::commit_resume): Pass down target.
5319         (remote_target::remote_stop_ns): Check supports_vCont_probed.
5320         (remote_target::interrupt_query)
5321         (remote_target::remove_new_fork_children)
5322         (remote_target::check_pending_events_prevent_wildcard_vcont)
5323         (remote_target::remote_parse_stop_reply)
5324         (remote_target::process_stop_reply): Pass down target.
5325         (first_remote_resumed_thread): New remote_target parameter.  Pass
5326         it down.
5327         (remote_target::wait_as): Pass down target.
5328         (unpush_and_perror): New remote_target parameter.  Pass it down.
5329         (remote_target::readchar, remote_target::remote_serial_write)
5330         (remote_target::getpkt_or_notif_sane_1)
5331         (remote_target::kill_new_fork_children, remote_target::kill): Pass
5332         down target.
5333         (remote_target::mourn_inferior): Pass down target.  Use
5334         remote_unpush_target.
5335         (remote_target::core_of_thread)
5336         (remote_target::remote_btrace_maybe_reopen): Pass down target.
5337         (remote_target::pid_to_exec_file)
5338         (remote_target::thread_handle_to_thread_info): Pass down target.
5339         (remote_target::async_wait_fd): New.
5340         * riscv-fbsd-tdep.c: Include "inferior.h".
5341         (riscv_fbsd_get_thread_local_address): Pass down target.
5342         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
5343         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
5344         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
5345         Adjust.
5346         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
5347         * solib-svr4.c (enable_break): Pass down target.
5348         * spu-multiarch.c (parse_spufs_run): Pass down target.
5349         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
5350         * target-delegates.c: Regenerate.
5351         * target.c (g_target_stack): Delete.
5352         (current_top_target): Return the current inferior's top target.
5353         (target_has_execution_1): Refer to the passed-in inferior's top
5354         target.
5355         (target_supports_terminal_ours): Check whether the initial
5356         inferior was already created.
5357         (decref_target): New.
5358         (target_stack::push): Incref/decref the target.
5359         (push_target, push_target, unpush_target): Adjust.
5360         (target_stack::unpush): Defref target.
5361         (target_is_pushed): Return bool.  Adjust to refer to the current
5362         inferior's target stack.
5363         (dispose_inferior): Delete, and inline parts ...
5364         (target_preopen): ... here.  Only dispose of the current inferior.
5365         (target_detach): Hold strong target reference while detaching.
5366         Pass target down.
5367         (target_thread_name): Add assertion.
5368         (target_resume): Pass down target.
5369         (target_ops::beneath, find_target_at): Adjust to refer to the
5370         current inferior's target stack.
5371         (get_dummy_target): New.
5372         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
5373         has a thread running.
5374         (initialize_targets): Rename to ...
5375         (_initialize_target): ... this.
5376         * target.h: Include "gdbsupport/refcounted-object.h".
5377         (struct target_ops): Inherit refcounted_object.
5378         (target_ops::shortname, target_ops::longname): Make const.
5379         (target_ops::async_wait_fd): New method.
5380         (decref_target): Declare.
5381         (struct target_ops_ref_policy): New.
5382         (target_ops_ref): New typedef.
5383         (get_dummy_target): Declare function.
5384         (target_is_pushed): Return bool.
5385         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
5386         (all_matching_threads_iterator::all_matching_threads_iterator):
5387         Handle filter target.
5388         * thread-iter.h (struct all_matching_threads_iterator, struct
5389         all_matching_threads_range, class all_non_exited_threads_range):
5390         Filter by target too.  Remove explicit.
5391         * thread.c (threads_executing): Delete.
5392         (inferior_thread): Pass down current inferior.
5393         (clear_thread_inferior_resources): Pass down thread pointer
5394         instead of ptid_t.
5395         (add_thread_silent, add_thread_with_info, add_thread): Add
5396         process_stratum_target parameter.  Use it for thread and inferior
5397         searches.
5398         (is_current_thread): New.
5399         (thread_info::deletable): Use it.
5400         (find_thread_ptid, thread_count, in_thread_list)
5401         (thread_change_ptid, set_resumed, set_running): New
5402         process_stratum_target parameter.  Pass it down.
5403         (set_executing): New process_stratum_target parameter.  Pass it
5404         down.  Adjust reference to 'threads_executing'.
5405         (threads_are_executing): New process_stratum_target parameter.
5406         Adjust reference to 'threads_executing'.
5407         (set_stop_requested, finish_thread_state): New
5408         process_stratum_target parameter.  Pass it down.
5409         (switch_to_thread): Also match inferior.
5410         (switch_to_thread): New process_stratum_target parameter.  Pass it
5411         down.
5412         (update_threads_executing): Reimplement.
5413         * top.c (quit_force): Pop targets from all inferior.
5414         (gdb_init): Don't call initialize_targets.
5415         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
5416         Declare.
5417         (windows_add_thread, windows_delete_thread): Adjust.
5418         (get_windows_debug_event): Rename to ...
5419         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
5420         * tracefile-tfile.c (tfile_target_open): Pass down target.
5421         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
5422         Forward declare.
5423         (switch_to_thread): Add process_stratum_target parameter.
5424         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
5425         parameter.  Use it.
5426         (mi_on_resume): Pass target down.
5427         * nat/fork-inferior.c (startup_inferior): Add
5428         process_stratum_target parameter.  Pass it down.
5429         * nat/fork-inferior.h (startup_inferior): Add
5430         process_stratum_target parameter.
5431         * python/py-threadevent.c (py_get_event_thread): Pass target down.
5432
5433 2020-01-10  Pedro Alves  <palves@redhat.com>
5434
5435         * remote.c (remote_target::start_remote): Don't set inferior_ptid
5436         directly.  Instead find the first thread in the thread list and
5437         use switch_to_thread.
5438
5439 2020-01-10  Pedro Alves  <palves@redhat.com>
5440
5441         * remote.c (remote_target::remote_add_inferior): Don't bind a
5442         process to the current inferior if the current inferior is already
5443         bound to a process.
5444
5445 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5446             Pedro Alves  <palves@redhat.com>
5447
5448         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
5449         If no process is specified, return null_ptid instead of
5450         inferior_ptid.
5451         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
5452         TARGET_WAITKIND_SIGNALLED with no pid.
5453
5454 2020-01-10  Pedro Alves  <palves@redhat.com>
5455
5456         * remote.c (first_remote_resumed_thread): New.
5457         (remote_target::wait_as): Use it as default event_ptid instead of
5458         inferior_ptid.
5459
5460 2020-01-10  Pedro Alves  <palves@redhat.com>
5461
5462         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
5463
5464 2020-01-10  Pedro Alves  <palves@redhat.com>
5465
5466         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
5467         not -1.
5468
5469 2020-01-10  Pedro Alves  <palves@redhat.com>
5470
5471         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
5472         ptid to get_last_target_status.
5473         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
5474         ptid to get_last_target_status.
5475         * infcmd.c (continue_command): Don't pass a target_waitstatus to
5476         get_last_target_status.
5477         (info_program_command): Don't pass a target_waitstatus to
5478         get_last_target_status.
5479         * infrun.c (init_wait_for_inferior): Use
5480         nullify_last_target_wait_ptid.
5481         (get_last_target_status): Handle nullptr arguments.
5482         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
5483         (print_stop_event): Don't pass a ptid to get_last_target_status.
5484         (normal_stop): Don't pass a ptid to get_last_target_status.
5485         * infrun.h (get_last_target_status, set_last_target_status): Move
5486         comments here and update.
5487         (nullify_last_target_wait_ptid): Declare.
5488         * linux-fork.c (fork_load_infrun_state): Remove local extern
5489         declaration of nullify_last_target_wait_ptid.
5490         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
5491         to get_last_target_status.
5492
5493 2020-01-10  Pedro Alves  <palves@redhat.com>
5494
5495         * gdbthread.h (scoped_restore_current_thread)
5496         <dont_restore, restore, m_dont_restore>: Declare.
5497         * thread.c (thread_alive): Add assertion.  Return bool.
5498         (switch_to_thread_if_alive): New.
5499         (prune_threads): Switch inferior/thread.
5500         (print_thread_info_1): Switch thread before calling target methods.
5501         (scoped_restore_current_thread::restore): New, factored out from
5502         ...
5503         (scoped_restore_current_thread::~scoped_restore_current_thread):
5504         ... this.
5505         (scoped_restore_current_thread::scoped_restore_current_thread):
5506         Add assertion.
5507         (thread_apply_all_command, thread_select): Use
5508         switch_to_thread_if_alive.
5509         * infrun.c (proceed, restart_threads, handle_signal_stop)
5510         (switch_back_to_stepped_thread): Switch current thread before
5511         calling target methods.
5512
5513 2020-01-10  Pedro Alves <palves@redhat.com>
5514
5515         * inferior.c (switch_to_inferior_no_thread): New function,
5516         factored out from ...
5517         (inferior_command): ... here.
5518         * inferior.h (switch_to_inferior_no_thread): Declare.
5519         * mi/mi-main.c (run_one_inferior): Use
5520         switch_to_inferior_no_thread.
5521
5522 2020-01-10  Pedro Alves  <palves@redhat.com>
5523
5524         * infcmd.c (kill_command): Remove dead code.
5525
5526 2020-01-10  Pedro Alves  <palves@redhat.com>
5527
5528         * remote.c (remote_target::mourn_inferior): No longer check
5529         whether the target is running.
5530
5531 2020-01-10  Pedro Alves  <palves@redhat.com>
5532
5533         * corelow.c (core_target::has_execution): Change parameter type to
5534         inferior pointer.
5535         * inferior.c (number_of_live_inferiors): Use
5536         inferior::has_execution instead of target_has_execution_1.
5537         * inferior.h (inferior::has_execution): New.
5538         * linux-thread-db.c (thread_db_target::update_thread_list): Use
5539         inferior::has_execution instead of target_has_execution_1.
5540         * process-stratum-target.c
5541         (process_stratum_target::has_execution): Change parameter type to
5542         inferior pointer.  Check the inferior's PID instead of
5543         inferior_ptid.
5544         * process-stratum-target.h
5545         (process_stratum_target::has_execution): Change parameter type to
5546         inferior pointer.
5547         * record-full.c (record_full_core_target::has_execution): Change
5548         parameter type to inferior pointer.
5549         * target.c (target_has_execution_1): Change parameter type to
5550         inferior pointer.
5551         (target_has_execution_current): Adjust.
5552         * target.h (target_ops::has_execution): Change parameter type to
5553         inferior pointer.
5554         (target_has_execution_1): Change parameter type to inferior
5555         pointer.  Change return type to bool.
5556         * tracefile.h (tracefile_target::has_execution): Change parameter
5557         type to inferior pointer.
5558
5559 2020-01-10  Pedro Alves  <palves@redhat.com>
5560
5561         * exceptions.c (print_flush): Remove current_top_target() check.
5562
5563 2020-01-10  Pedro Alves  <palves@redhat.com>
5564
5565         * remote.c (show_remote_exec_file): Show the current inferior's
5566         exec-file instead of the command variable's value.
5567
5568 2020-01-10  Pedro Alves  <palves@redhat.com>
5569
5570         * record-full.c (record_full_resume_ptid): New global.
5571         (record_full_target::resume): Set it.
5572         (record_full_wait_1): Use record_full_resume_ptid instead of
5573         inferior_ptid.
5574
5575 2020-01-10  Pedro Alves  <palves@redhat.com>
5576
5577         * gdbthread.h (scoped_restore_current_thread)
5578         <dont_restore, restore, m_dont_restore>: Declare.
5579         * thread.c (thread_alive): Add assertion.  Return bool.
5580         (switch_to_thread_if_alive): New.
5581         (prune_threads): Switch inferior/thread.
5582         (print_thread_info_1): Switch thread before calling target methods.
5583         (scoped_restore_current_thread::restore): New, factored out from
5584         ...
5585         (scoped_restore_current_thread::~scoped_restore_current_thread):
5586         ... this.
5587         (scoped_restore_current_thread::scoped_restore_current_thread):
5588         Add assertion.
5589         (thread_apply_all_command, thread_select): Use
5590         switch_to_thread_if_alive.
5591
5592 2020-01-10  George Barrett  <bob@bob131.so>
5593
5594         * stap-probe.c (stap_modify_semaphore): Don't check for null
5595         semaphores.
5596         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
5597         for null semaphores.
5598
5599 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
5602         all source windows, and maintain horizontal scroll status while
5603         doing so.
5604
5605 2020-01-09  Tom Tromey  <tom@tromey.com>
5606
5607         PR tui/18932:
5608         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
5609         update_source_window, not print_source_lines.
5610
5611 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * tui/tui.c (tui_enable): Register tui hooks after calling
5614         tui_display_main.
5615
5616 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5617
5618         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
5619
5620 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
5621
5622         * thread.c (print_thread_info_1): Fix indentation.
5623
5624 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5625
5626         * symtab.c (general_symbol_info::compute_and_set_names): Move the
5627         unique_xmalloc_ptr outside the if to always free the demangled name.
5628
5629 2020-01-08  Tom Tromey  <tromey@adacore.com>
5630
5631         * xcoffread.c (enter_line_range, read_xcoff_symtab)
5632         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
5633         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
5634         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
5635         Remove.
5636         (section_offsets): New typedef.
5637         * symtab.c (fixup_section, get_msymbol_address): Update.
5638         * symmisc.c (dump_msymbols): Update.
5639         * symfile.h (relative_addr_info_to_section_offsets)
5640         (symfile_map_offsets_to_segments): Update.
5641         * symfile.c (build_section_addr_info_from_objfile)
5642         (init_objfile_sect_indices): Update.
5643         (struct place_section_arg): Change type of "offsets".
5644         (place_section): Update.
5645         (relative_addr_info_to_section_offsets): Change type of
5646         "section_offsets".  Remove "num_sections" parameter.
5647         (default_symfile_offsets, syms_from_objfile_1)
5648         (set_objfile_default_section_offset): Update.
5649         (reread_symbols): No need to preserve section offsets by hand.
5650         (symfile_map_offsets_to_segments): Change type of "offsets".
5651         * stap-probe.c (relocate_address): Update.
5652         * stabsread.h (process_one_symbol): Update.
5653         * solib-target.c (struct lm_info_target) <offsets>: Change type.
5654         (solib_target_relocate_section_addresses): Update.
5655         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
5656         Update.
5657         * solib-frv.c (frv_relocate_main_executable): Update.
5658         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
5659         * solib-aix.c (solib_aix_get_section_offsets): Change return
5660         type.
5661         (solib_aix_solib_create_inferior_hook): Update.
5662         * remote.c (remote_target::get_offsets): Update.
5663         * psymtab.c (find_pc_sect_psymtab): Update.
5664         * psympriv.h (struct partial_symbol) <address, text_low,
5665         text_high>: Update.
5666         * objfiles.h (obj_section_offset): Update.
5667         (struct objfile) <section_offsets>: Change type.
5668         <num_sections>: Remove.
5669         (objfile_relocate): Update.
5670         * objfiles.c (entry_point_address_query): Update
5671         (relocate_one_symbol): Change type of "section_offsets".
5672         (objfile_relocate1, objfile_relocate1): Change type of
5673         "new_offsets".
5674         (objfile_rebase1): Update.
5675         * mipsread.c (mipscoff_symfile_read): Update.
5676         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
5677         parameter.
5678         * mdebugread.c (parse_symbol): Change type of "section_offsets".
5679         (parse_external, psymtab_to_symtab_1): Update.
5680         * machoread.c (macho_symfile_offsets): Update.
5681         * ia64-tdep.c (ia64_find_unwind_table): Update.
5682         * hppa-tdep.c (read_unwind_info): Update.
5683         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
5684         * dwarf2read.c (create_addrmap_from_index)
5685         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5686         (process_psymtab_comp_unit_reader, add_partial_symbol)
5687         (add_partial_subprogram, process_full_comp_unit)
5688         (read_file_scope, read_func_scope, read_lexical_block_scope)
5689         (read_call_site_scope, dwarf2_rnglists_process)
5690         (dwarf2_ranges_process, dwarf2_ranges_read)
5691         (dwarf_decode_lines_1, var_decode_location, new_symbol)
5692         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
5693         Update.
5694         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
5695         Update.
5696         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
5697         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
5698         (process_one_symbol): Change type of "section_offsets".
5699         * ctfread.c (get_objfile_text_range): Update.
5700         * coffread.c (coff_symtab_read, enter_linenos)
5701         (process_coff_symbol): Update.
5702         * coff-pe-read.c (add_pe_forwarded_sym): Update.
5703         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
5704
5705 2020-01-08  Tom Tromey  <tromey@adacore.com>
5706
5707         * dwarf2read.c (parse_macro_definition): Use std::string.
5708         (parse_macro_definition): Likewise.
5709
5710 2020-01-08  Tom Tromey  <tromey@adacore.com>
5711
5712         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
5713         (ATTR_ALLOC_CHUNK): Remove.
5714
5715 2020-01-08  Tom Tromey  <tromey@adacore.com>
5716
5717         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
5718
5719 2020-01-08  Tom Tromey  <tromey@adacore.com>
5720
5721         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
5722         (dwarf2_compute_name, open_dwo_file): Likewise.
5723         (process_enumeration_scope): Use std::vector.
5724         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
5725         (partial_die_info::fixup, dwarf2_start_subfile)
5726         (guess_full_die_structure_name, dwarf2_name): Likewise.
5727         (determine_prefix): Update.
5728         (guess_full_die_structure_name): Make return type const.
5729         (partial_die_full_name): Return unique_xmalloc_ptr.
5730         (DW_FIELD_ALLOC_CHUNK): Remove.
5731
5732 2020-01-07  Tom Tromey  <tromey@adacore.com>
5733
5734         PR build/24937:
5735         * stap-probe.c (class stap_static_probe_ops): Add constructor.
5736
5737 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5738
5739         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
5740
5741 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * stack.c (print_frame_info): Move disassemble_next_line code
5744         inside source_print block.
5745
5746 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5747
5748         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
5749         gdb/signals.h, as we are now using native signal symbols.
5750
5751 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5752
5753         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
5754         overflow by an early check of content vs threshold.
5755         * tui/tui-source.c (tui_source_window::line_is_displayed):
5756         Likewise.
5757
5758 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5759
5760         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
5761
5762 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5763
5764         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
5765         export table if no section contains it's RVA.
5766
5767 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5768
5769         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
5770
5771 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
5772
5773         * source.c (print_source_lines_base): Set last_line_listed.
5774
5775 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5776
5777         * tui/tui-disasm.c: Remove trailing spaces.
5778
5779 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5780             Pedro Alves  <palves@redhat.com>
5781
5782         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
5783         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
5784         (windows_gdb_signal_to_target): New function, uses the above
5785         enumeration to convert GDB internal signal codes to equivalent
5786         Windows codes.
5787         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
5788         * windows-nat.c: Include "gdb_wait.h".
5789         (get_windows_debug_event): Extract the fatal exception from the
5790         exit status and convert to the equivalent Posix signal number.
5791         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
5792         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
5793         * gdbsupport/gdb_wait.c: New file, implements
5794         windows_status_to_termsig.
5795         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
5796         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
5797
5798 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5799
5800         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
5801         show_layout.
5802
5803 2020-01-05  Luis Machado  <luis.machado@linaro.org>
5804
5805         * aarch64-linux-nat.c
5806         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
5807         and bfd_mach_aarch64.
5808
5809 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5810
5811         * ui-file.c (stdio_file::can_emit_style_escape)
5812         (tee_file::can_emit_style_escape): Ensure style is used also on
5813         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
5814         to gdb_stdout.
5815         * main.c (set_gdb_data_directory): Use file style to output the
5816         warning that the given pathname is not a directory.
5817         * top.c (show_history_filename, gdb_safe_append_history)
5818         (show_gdb_datadir): Use file style.
5819
5820 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5821
5822         * solib-target.c (struct lm_info_target):
5823         Change offsets to be a unique_xmalloc_ptr.
5824         (solib_target_relocate_section_addresses): Update.
5825
5826 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5827
5828         * windows-nat.c (windows_clear_solib): Free so_list linked list.
5829
5830 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5831
5832         * MAINTAINERS (Write After Approval): Add myself.
5833
5834 2020-01-02  Luis Machado  <luis.machado@linaro.org>
5835
5836         * proc-service.c (get_ps_regcache): Remove reference to obsolete
5837         Cell BE architecture.
5838         * target.h (struct target_ops) <thread_architecture>: Likewise.
5839
5840 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5841
5842         * Makefile.in: Use INSTALL_PROGRAM_ENV.
5843
5844 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5845
5846         * MAINTAINERS (Write After Approval): Add myself.
5847
5848 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5849
5850         * gdbarch.sh: Update copyright year range of generated files.
5851
5852 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5853
5854         Update copyright year range in all GDB files.
5855
5856 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5857
5858         * copyright.py: Convert to Python 3.
5859
5860 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5861
5862         * copyright.py: Adapt after move of gnulib directory from gdb
5863         directory to toplevel directory.
5864
5865 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5866
5867         * copyright.py (main): Exit if run from the wrong directory.
5868
5869 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5870
5871         * top.c (print_gdb_version): Change copyright year to 2020.
5872
5873 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5874
5875         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
5876
5877 For older changes see ChangeLog-2019.
5878 \f
5879 Local Variables:
5880 mode: change-log
5881 left-margin: 8
5882 fill-column: 74
5883 version-control: never
5884 coding: utf-8
5885 End: