gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.c (objfile_pspace_info): Add destructor and
   4         initializers.
   5         (objfiles_pspace_data): Change type.
   6         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
   7         (get_objfile_pspace_data): Update.
   8         (objfiles_bfd_data): Change type.
   9         (get_objfile_bfd_data): Update.
  10         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  15         Change type.
  16         (get_catch_syscall_inferior_data): Update.
  17         (catch_syscall_inferior_data_cleanup): Remove.
  18         (_initialize_break_catch_syscall): Update.
  19
  20 2019-05-08  Tom Tromey  <tom@tromey.com>
  21
  22         * inflow.c (struct terminal_info): Add destructor and
  23         initializers.
  24         (inflow_inferior_data): Change type.
  25         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  26         (get_inflow_inferior_data, inflow_inferior_exit)
  27         (swap_terminal_info, _initialize_inflow): Update.
  28
  29 2019-05-08  Tom Tromey  <tom@tromey.com>
  30
  31         * target-dcache.c (target_dcache_cleanup): Remove.
  32         (target_dcache_aspace_key): Change type.
  33         (target_dcache_init_p, target_dcache_invalidate)
  34         (target_dcache_get, target_dcache_get_or_init)
  35         (_initialize_target_dcache): Update.
  36         * dcache.h (struct dcache_deleter): New.
  37
  38 2019-05-08  Tom Tromey  <tom@tromey.com>
  39
  40         * symtab.c (struct symbol_cache): Add destructor and
  41         initializers.
  42         (symbol_cache_key): Move.  Change type.
  43         (make_symbol_cache, free_symbol_cache): Remove.
  44         (get_symbol_cache): Update.
  45         (symbol_cache_cleanup): Remove.
  46         (ALL_PSPACES, symbol_cache_flush)
  47         (maintenance_print_symbol_cache)
  48         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  49         Update.
  50
  51 2019-05-08  Tom Tromey  <tom@tromey.com>
  52
  53         * symtab.c (struct main_info): Add destructor and initializers.
  54         (main_progspace_key): Move.  Change type.
  55         (get_main_info): Update.
  56         (main_info_cleanup): Remove.
  57         (_initialize_symtab): Update.
  58
  59 2019-05-08  Tom Tromey  <tom@tromey.com>
  60
  61         * registry.h (DECLARE_REGISTRY): Define the _key class.
  62
  63 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  64
  65         * NEWS: Merge two 'New commands' sections.
  66
  67 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  68
  69         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  70         parameter and use Ada language definition instead.
  71         (ada_val_print_ptr): Remove unused language parameter.
  72         (ada_val_print_num): Remove language parameter and use Ada language
  73         definition instead.
  74         (ada_val_print_enum, ada_val_print_flt): Remove unused language
  75         parameter.
  76         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  77         parameter and use Ada language definition instead.
  78         (ada_val_print_1): Update all ada_val_print_xxx calls.
  79         Remove language parameter.
  80         (ada_val_print): Update ada_val_print_1 call.
  81
  82 2019-05-08  Tom Tromey  <tromey@adacore.com>
  83
  84         * remote.c (remote_hw_watchpoint_limit)
  85         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
  86         Now static.
  87
  88 2019-05-08  Tom Tromey  <tromey@adacore.com>
  89
  90         * maint.c (_initialize_maint_cmds): Move initialization code to
  91         remote.c.
  92         (watchdog, show_watchdog): Move to remote.c.
  93         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
  94         "watchdog" static.
  95         (_initialize_remote): Move initialization code from maint.c.
  96         * defs.h (watchdog): Don't declare.
  97
  98 2019-05-08  Tom Tromey  <tromey@adacore.com>
  99
 100         * tui/tui-interp.c: Include main.h.
 101         * interps.c: Include main.h.
 102         * main.h (interpreter_p): Declare.
 103         * defs.h (interpreter_p): Don't declare.
 104
 105 2019-05-08  Tom Tromey  <tromey@adacore.com>
 106
 107         * dwarf2loc.c: Include dwarf2read.h.
 108         * defs.h (read_unsigned_leb128): Don't declare.
 109         * dwarf2read.h (read_unsigned_leb128): Declare.
 110
 111 2019-05-08  Tom Tromey  <tromey@adacore.com>
 112
 113         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 114         method.
 115
 116 2019-05-08  Tom Tromey  <tromey@adacore.com>
 117
 118         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 119         when no wrap column is set.
 120
 121 2019-05-08  Tom Tromey  <tromey@adacore.com>
 122
 123         * c-lang.c (c_get_string): Handle non-C-style arrays.
 124
 125 2019-05-08  Tom Tromey  <tromey@adacore.com>
 126
 127         * typeprint.c (print_offset_data::update): Print the bit offset,
 128         not the number of bits remaining.
 129
 130 2019-05-08  Tom Tromey  <tromey@adacore.com>
 131
 132         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 133         padding at end of comment.
 134
 135 2019-05-08  Tom Tromey  <tromey@adacore.com>
 136
 137         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 138         Compare main types.
 139
 140 2019-05-06  Tom Tromey  <tom@tromey.com>
 141
 142         * common/scoped_mmap.c: Include common-defs.h.
 143         * common/scoped_mmap.h: Don't include config.h.
 144
 145 2019-05-04  Tom Tromey  <tom@tromey.com>
 146
 147         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 148         (struct aarch64_call_info): Add initializers.
 149         <si>: Now a std::vector.
 150         (pass_on_stack, aarch64_push_dummy_call): Update.
 151
 152 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 153             Tom Tromey  <tom@tromey.com>
 154
 155         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 156         (ppc_threads): Now a std::vector.  Now static.
 157         (hwdebug_find_thread_points_by_tid)
 158         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 159         Update.
 160
 161 2019-05-04  Tom Tromey  <tom@tromey.com>
 162
 163         * arc-tdep.c (arc_tdesc_init): Return bool.
 164
 165 2019-05-04  Tom Tromey  <tom@tromey.com>
 166
 167         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 168         Use gdb_assert_not_reached.
 169
 170 2019-05-04  Tom Tromey  <tom@tromey.com>
 171
 172         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 173         "false".
 174
 175 2019-05-04  Tom Tromey  <tom@tromey.com>
 176
 177         * arc-tdep.c (arc_tdesc_init): Use bool.
 178
 179 2019-05-04  Tom Tromey  <tom@tromey.com>
 180
 181         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 182
 183 2019-05-04  Tom Tromey  <tom@tromey.com>
 184
 185         * cli/cli-cmds.c (valid_command_p): Return bool.
 186
 187 2019-05-04  Tom Tromey  <tom@tromey.com>
 188
 189         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 190         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 191
 192 2019-05-04  Raul Tambre  <raul@tambre.ee>
 193
 194         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 195         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 196         operator for comparison.
 197
 198 2019-05-04  Tom Tromey  <tom@tromey.com>
 199
 200         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 201         (lookup_partial_symbol, print_partial_symbols)
 202         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 203         (psymbol_compare): Update.
 204         (add_psymbol_to_bcache): Clear the entire psymbol.
 205         (maintenance_check_psymtabs): Update.
 206         * psympriv.h (struct partial_symbol): Don't derive from
 207         general_symbol_info.
 208         <obj_section, unrelocated_address, address,
 209         set_unrelocated_address>: Update.
 210         <ginfo>: New member.
 211         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 212         (debug_names::write_psymbols): Update.
 213
 214 2019-05-04  Tom de Vries  <tdevries@suse.de>
 215
 216         * contrib/cc-with-tweaks.sh: Support -n arg.
 217
 218 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 219
 220         * corelow.c (core_target::detach): Ensure frame cache and
 221         register caches are cleared.
 222         inferior.c (exit_inferior_1): Likewise.
 223
 224 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 225             Tom Tromey  <tom@tromey.com>
 226
 227         * dictionary.c (collate_pending_symbols_by_language): Remove
 228         "struct" from foreach.
 229         * symtab.c (lookup_global_symbol_from_objfile)
 230         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 231         foreach.
 232         * ser-tcp.c (net_open): Remove "struct" from foreach.
 233         * objfiles.c (objfile_relocate, objfile_rebase)
 234         (objfile_has_symbols): Remove "struct" from foreach.
 235         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 236         from foreach.
 237         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 238         foreach.
 239         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 240         "struct" from foreach.
 241         * ada-lang.c (create_excep_cond_exprs)
 242         (ada_exception_catchpoint_cond_string): Remove "struct" from
 243         foreach.
 244
 245 2019-05-03  Tom Tromey  <tromey@adacore.com>
 246
 247         * ada-exp.y (convert_char_literal): Check suffix of each
 248         enumerator.
 249
 250 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 251
 252         PR ada/21406:
 253         * ada-exp.y (yywrap): Don't define.
 254         * ada-lex.l (%option): Add noyywrap
 255         (yywrap): Remove.
 256
 257 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 258
 259         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 260         _WIN32_WINNT to the XP level, unless already defined to a higher
 261         level.
 262
 263         * unittests/parse-connection-spec-selftests.c:
 264         * ser-tcp.c:
 265         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 266         override.
 267
 268         * symfile.c (find_separate_debug_file): Remove colon from the
 269         drive spec of DOS/Windows file names of the target, so that the
 270         file name produced from DEBUGDIR and the target's directory will
 271         be valid on DOS/Windows systems.
 272
 273 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * rust-lang.c (val_print_struct): Handle printing structures
 276         containing strings.
 277
 278 2019-05-02  Tom Tromey  <tromey@adacore.com>
 279
 280         * valarith.c (_initialize_valarith): Remove.
 281
 282 2019-05-01  Tom Tromey  <tromey@adacore.com>
 283
 284         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 285         bitfields.
 286
 287 2019-05-01  Tom Tromey  <tromey@adacore.com>
 288
 289         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 290         for big-endian copies.
 291
 292 2019-04-30  Ali Tamur  <tamur@google.com>
 293         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 294         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 295         (read_3_bytes): New function.
 296
 297 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 298
 299         * windows-nat.c (main_thread_id): Delete.
 300         (handle_output_debug_string): Replace main_thread_id by
 301         current_event.dwThreadId.
 302         (fake_create_process): Likewise.
 303         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 304         Do not set main_thread_id.
 305         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 306         current_event.dwThreadId.
 307         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 308
 309 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 310
 311         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 312         Use current_event.dwThreadId instead of main_thread_id.
 313
 314 2019-04-30  Tom Tromey  <tromey@adacore.com>
 315
 316         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 317         (create_excep_cond_exprs): Iterate over program spaces.
 318         (ada_exception_catchpoint_cond_string): Examine all minimal
 319         symbols for exception types.
 320
 321 2019-04-30  Tom Tromey  <tromey@adacore.com>
 322
 323         PR c++/24470:
 324         * dwarf2read.c (process_structure_scope): Handle case where type
 325         has template parameters but no symbol was created.
 326
 327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 328             Chris January  <chris.january@arm.com>
 329
 330         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 331         qualifier.
 332         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 333
 334 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * f-typeprint.c (f_print_type): Update rules for printing
 337         whitespace.
 338         (f_type_print_varspec_suffix): Likewise.
 339
 340 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 341             Chris January  <chris.january@arm.com>
 342
 343         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 344         function arguments.
 345
 346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * f-lang.c (build_fortran_types): Change name of void type to
 349         lower case.
 350         * f-typeprint.c (f_type_print_base): Print the name of the void
 351         type, rather than a fixed string.
 352         * f-valprint.c (f_decorations): Use lower case void string.
 353
 354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 355             Chris January  <chris.january@arm.com>
 356
 357         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 358         types for Fortran.
 359
 360 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 361             Chris January  <chris.january@arm.com>
 362             David Lecomber  <david.lecomber@arm.com>
 363
 364         * f-exp.y (BINOP_INTRINSIC): New token.
 365         (exp): New parser rule handling BINOP_INTRINSIC.
 366         (f77_keywords): Add new builtin procedures.
 367         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 368         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 369         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 370         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 371         (print_unop_subexp_f): New function.
 372         (print_binop_subexp_f): New function.
 373         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 374         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 375         (dump_subexp_body_f): Likewise.
 376         (operator_check_f): Likewise.
 377         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 378         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 379
 380 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 383         UNOP_KIND.
 384         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 385         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 386         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 387         (operator_length_f): New fuction.
 388         (print_subexp_f): New function.
 389         (op_name_f): New function.
 390         (dump_subexp_body_f): New function.
 391         (operator_check_f): New function.
 392         (exp_descriptor_f): Replace standard expression handling functions
 393         with new functions.
 394         * gdb/fortran-operator.def: New file.
 395         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 396         * gdb/std-operator.def: Remove UNOP_KIND.
 397
 398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * std-operator.def: Remove unbalanced, stray double quote
 401         character.
 402
 403 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 404             Chris January  <chris.january@arm.com>
 405             Daniel Everett  <daniel.everett@arm.com>
 406             Nick Forrington  <nick.forrington@arm.com>
 407             Richard Bunt  <richard.bunt@arm.com>
 408
 409         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 410         of depth when printing anonymous structs or unions.
 411         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 412         Don't print either the top-level value, or the children if the
 413         max-depth is exceeded.
 414         (ppscm_print_children): When printing the key of a map, allow one
 415         extra level of depth.
 416         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 417         print either the top-level value, or the children if the max-depth
 418         is exceeded.
 419         (print_children): When printing the key of a map, allow one extra
 420         level of depth.
 421         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 422         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 423         (user_print_options): Initialise max_depth field.
 424         (val_print_scalar_or_string_type_p): New function.
 425         (val_print): Check to see if the max depth has been reached.
 426         (val_print_check_max_depth): Define new function.
 427         (show_print_max_depth): New function.
 428         (_initialize_valprint): Add 'print max-depth' option.
 429         * valprint.h (struct value_print_options) <max_depth>: New field.
 430         (val_print_check_max_depth): Declare new function.
 431         * NEWS: Document new feature.
 432
 433 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 434
 435         * ada-lang.c (ada_language_defn): Initialise new field.
 436         * c-lang.c (c_is_string_type_p): New function.
 437         (c_language_defn): Initialise new field.
 438         (cplus_language_defn): Initialise new field.
 439         (asm_language_defn): Initialise new field.
 440         (minimal_language_defn): Initialise new field.
 441         * c-lang.h (c_is_string_type_p): Declare new function.
 442         * d-lang.c (d_language_defn): Initialise new field.
 443         * f-lang.c (f_is_string_type_p): New function.
 444         (f_language_defn): Initialise new field.
 445         * go-lang.c (go_is_string_type_p): New function.
 446         (go_language_defn): Initialise new field.
 447         * language.c (default_is_string_type_p): New function.
 448         (unknown_language_defn): Initialise new field.
 449         (auto_language_defn): Initialise new field.
 450         * language.h (struct language_defn) <la_is_string_type_p>: New
 451         member variable.
 452         (default_is_string_type_p): Declare new function.
 453         * m2-lang.c (m2_language_defn): Initialise new field.
 454         * objc-lang.c (objc_language_defn): Initialise new field.
 455         * opencl-lang.c (opencl_language_defn): Initialise new field.
 456         * p-lang.c (pascal_is_string_type_p): New function.
 457         (pascal_language_defn): Initialise new field.
 458         * rust-lang.c (rust_is_string_type_p): New function.
 459         (rust_language_defn): Initialise new field.
 460
 461 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 464         New field.
 465         * ada-lang.c (ada_language_defn): Initialise new field.
 466         * c-lang.c (c_language_defn): Likewise.
 467         (cplus_language_defn): Likewise.
 468         (asm_language_defn): Likewise.
 469         (minimal_language_defn): Likewise.
 470         * d-lang.c (d_language_defn): Likewise.
 471         * f-lang.c (f_language_defn): Likewise.
 472         * go-lang.c (go_language_defn): Likewise.
 473         * language.c (unknown_language_defn): Likewise.
 474         (auto_language_defn): Likewise.
 475         * m2-lang.c (m2_language_defn): Likewise.
 476         * objc-lang.c (objc_language_defn): Likewise.
 477         * opencl-lang.c (opencl_language_defn): Likewise.
 478         * p-lang.c (pascal_language_defn): Likewise.
 479         * rust-lang.c (rust_language_defn): Likewise.
 480
 481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * ada-lang.c (ada_is_character_type): Change return type to bool.
 484         (ada_is_string_type): Likewise.
 485         * ada-lang.h (ada_is_character_type): Update declaration
 486         (ada_is_string_type): Likewise.
 487
 488 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 489
 490         Support style in 'frame|thread apply'
 491
 492         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 493         * record.c (record_start, record_stop): Update callers of
 494         execute_command_to_string with false.
 495         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 496         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 497         methods.
 498         (class string_file): New constructor with term_out parameter.
 499         Override methods term_out and can_emit_style_escape.  New member
 500         term_out.
 501         (class stdio_file): Override can_emit_style_escape.
 502         (class tee_file): Override term_out and can_emit_style_escape.
 503         * utils.h (can_emit_style_escape): Remove.
 504         * utils.c (can_emit_style_escape): Likewise.
 505         Update all callers of can_emit_style_escape (SOMESTREAM) to
 506         SOMESTREAM->can_emit_style_escape.
 507         * source-cache.c (source_cache::get_source_lines): Likewise.
 508         * stack.c (frame_apply_command_count): Call execute_command_to_string
 509         passing the term_out characteristic of the current gdb_stdout.
 510         * thread.c (thr_try_catch_cmd): Likewise.
 511         * top.c (execute_command_to_string): pass term_out parameter
 512         to construct the string_file for the command output.
 513         * ui-file.c (term_cli_styling): New function (most code moved
 514         from utils.c can_emit_style_escape).
 515         (string_file::string_file, string_file::can_emit_style_escape,
 516         stdio_file::can_emit_style_escape, tee_file::term_out,
 517         tee_file::can_emit_style_escape): New functions.
 518
 519 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 520
 521         * NEWS: Mention the new set|show may-call-functions.
 522         * infcall.c (may_call_functions_p): New variable.
 523         (show_may_call_functions_p): New function.
 524         (call_function_by_hand_dummy): Throws an error if not
 525         may-call-functions.
 526         (_initialize_infcall): Call add_setshow_boolean_cmd for
 527         may-call-functions.
 528
 529 2019-04-25  Keith Seitz  <keiths@redhat.com>
 530
 531         PR c++/24367
 532         * cp-support.c (inspect_type): Don't attempt substitutions
 533         of symbol with the same name.
 534
 535 2019-04-25  Tom Tromey  <tromey@adacore.com>
 536
 537         PR gdb/24475:
 538         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 539         static.
 540
 541 2019-04-25  Tom Tromey  <tromey@adacore.com>
 542
 543         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 544         rvalue reference.
 545         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 546         (gdb_xml_parser::parse): Use std::move.
 547         * python/python-internal.h (gdbpy_convert_exception): Take a const
 548         reference.
 549         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 550         std::move.
 551         * python/py-utils.c (gdbpy_convert_exception): Take a const
 552         reference.
 553         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 554         Use std::move.
 555         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 556         Use std::move.
 557         * mi/mi-main.c (mi_print_exception): Take a const reference.
 558         * main.c (handle_command_errors): Take a const reference.
 559         * linespec.c (parse_linespec): Use std::move.
 560         * infcall.c (run_inferior_call): Use std::move.
 561         (call_function_by_hand_dummy): Use std::move.
 562         * exec.c (try_open_exec_file): Use std::move.
 563         * exceptions.h (exception_print, exception_fprintf)
 564         (exception_print_same): Update.
 565         * exceptions.c (print_exception, exception_print)
 566         (exception_fprintf, exception_print_same): Change parameters to
 567         const reference.
 568         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 569         * common/new-op.c: Use std::move.
 570         * common/common-exceptions.h (struct gdb_exception): Add move
 571         constructor.
 572         (struct gdb_exception_error, struct gdb_exception_quit, struct
 573         gdb_quit_bad_alloc): Change constructor to move constructor.
 574         (throw_exception): Change parameter to rvalue reference.
 575         * common/common-exceptions.c (throw_exception): Take rvalue
 576         reference.
 577         * cli/cli-interp.c (safe_execute_command): Use std::move.
 578         * breakpoint.c (insert_bp_location, location_to_sals): Use
 579         std::move.
 580
 581 2019-04-25  Tom Tromey  <tromey@adacore.com>
 582
 583         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 584         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 585         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 586         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 587         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 588         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 589         guile/scm-value.c: Use unpack.
 590         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 591         gdbscm_gdb_exception.
 592         (gdbscm_throw_gdb_exception): Likewise.
 593         (struct gdbscm_gdb_exception): New.
 594         (unpack): New function.
 595         (gdbscm_wrap): Use unpack.
 596
 597 2019-04-25  Tom Tromey  <tromey@adacore.com>
 598
 599         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 600         (gdb_rl_callback_handler): Use std::move.
 601         * common/common-exceptions.h (struct gdb_exception): Add move
 602         assignment operator.
 603         (throw_exception_sjlj): Change "exception" to const reference.
 604         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 605         (throw_exception_sjlj): Change "exception" to const reference.
 606
 607 2019-04-25  Tom Tromey  <tromey@adacore.com>
 608
 609         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 610         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 611         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 612         Update.
 613         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 614         Update.
 615         * mi/mi-interp.c (mi_interp::exec): Update.
 616         * linespec.c (parse_linespec): Update.
 617         * infcall.c (run_inferior_call): Update.
 618         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 619         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 620         (gdbscm_lookup_global_symbol): Update.
 621         * guile/scm-param.c (gdbscm_parameter_value): Update.
 622         * guile/scm-frame.c (gdbscm_frame_read_register)
 623         (gdbscm_frame_read_var): Update.
 624         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 625         * exec.c (try_open_exec_file): Update.
 626         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 627         (gdb_rl_callback_handler): Update.
 628         * common/common-exceptions.h (exception_none): Don't declare.
 629         * common/common-exceptions.c (exception_none): Don't define.
 630         (struct catcher) <exception>: Update.
 631         * cli/cli-interp.c (safe_execute_command): Update.
 632         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 633
 634 2019-04-25  Ali Tamur  <tamur@google.com>
 635
 636         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 637         (read_attribute_value): Likewise.
 638         (dwarf2_read_addr_index): Update comment.
 639         (read_str_index): Add DW_FORM_strx.
 640         (dwarf2_string_attr): Likewise.
 641         (dwarf2_const_value_attr): Likewise.
 642         (dump_die_shallow): Likewise.
 643         (dwarf2_fetch_constant_bytes): Likewise.
 644         (skip_form_bytes): Likewise.
 645         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 646
 647 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 648
 649         PR corefiles/11608
 650         PR corefiles/18187
 651         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 652         OFFSET.  Verify if current mapping contains an ELF header.
 653         (linux_find_memory_regions_full): Adjust call to
 654         dump_mapping_p.
 655
 656 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 657             Kang Li <kanglictf@gmail.com>
 658
 659         PR gdb/21600
 660
 661         * dwarf2-frame.c (read_initial_length): Be consistent about using
 662         unsigned representation of length.
 663         (decode_frame_entry_1): Likewise.  Check for wraparound of
 664         end pointer as well as buffer overflow.
 665
 666 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 667
 668         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 669         "vq".
 670
 671 2019-04-24  Tom Tromey  <tromey@adacore.com>
 672
 673         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 674
 675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 676
 677         * s12z-tdep.c (s12z_unwind_pc): Delete.
 678         (s12z_unwind_sp): Delete.
 679         (s12z_gdbarch_init): Don't register deleted functions with
 680         gdbarch.
 681
 682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * rl78-tdep.c (rl78_unwind_sp): Delete.
 685         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 686
 687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 690         (xstormy16_unwind_pc): Delete.
 691         (xstormy16_dummy_id): Delete.
 692         (xstormy16_gdbarch_init): Don't register deleted functions with
 693         gdbarch.
 694
 695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 696
 697         * vax-tdep.c (vax_unwind_pc): Delete.
 698         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 699
 700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * v850-tdep.c (v850_unwind_sp): Delete.
 703         (v850_unwind_pc): Delete.
 704         (v850_dummy_id): Delete.
 705         (v850_gdbarch_init): Don't register deleted functions with
 706         gdbarch.
 707
 708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 711         (tilegx_unwind_pc): Delete.
 712         (tilegx_unwind_dummy_id): Delete.
 713         (tilegx_gdbarch_init): Don't register deleted functions with
 714         gdbarch.
 715
 716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 717
 718         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 719         (tic6x_dummy_id): Delete.
 720         (tic6x_gdbarch_init): Don't register deleted functions with
 721         gdbarch.
 722
 723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * sparc-tdep.c (sparc_unwind_pc): Delete.
 726         (sparc32_gdbarch_init): Don't register deleted function with
 727         gdbarch.
 728
 729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * sh-tdep.c (sh_unwind_sp): Delete.
 732         (sh_unwind_pc): Delete.
 733         (sh_dummy_id): Delete.
 734         (sh_gdbarch_init): Don't register deleted functions with
 735         gdbarch.
 736
 737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * score-tdep.c (score_unwind_sp): Delete.
 740         (score_unwind_pc): Delete.
 741         (score_dummy_id): Delete.
 742         (score_gdbarch_init): Don't register deleted functions with
 743         gdbarch.
 744
 745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * rx-tdep.c (rx_unwind_pc): Delete.
 748         (rx_unwind_sp): Delete.
 749         (rx_dummy_id): Delete.
 750         (rx_gdbarch_init): Don't register deleted functions with
 751         gdbarch.  Update comment.
 752
 753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 756         (rs6000_dummy_id): Delete.
 757         (rs6000_gdbarch_init): Don't register deleted functions with
 758         gdbarch.
 759
 760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 761
 762         * or1k-tdep.c (or1k_dummy_id): Delete.
 763         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 764
 765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * nios2-tdep.c (nios2_dummy_id): Delete.
 768         (nios2_unwind_sp): Delete.
 769         (nios2_gdbarch_init): Don't register deleted functions with
 770         gdbarch.
 771
 772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 773
 774         * nds32-tdep.c (nds32_dummy_id): Delete.
 775         (nds32_unwind_pc): Delete.
 776         (nds32_unwind_sp): Delete.
 777         (nds32_gdbarch_init): Don't register deleted functions with
 778         gdbarch.
 779
 780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * msp430-tdep.c (msp430_unwind_pc): Delete.
 783         (msp430_unwind_sp): Delete.
 784         (msp430_dummy_id): Delete.
 785         (msp430_gdbarch_init): Don't register deleted functions with
 786         gdbarch.
 787
 788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * moxie-tdep.c (moxie_unwind_sp): Delete.
 791         (moxie_unwind_pc): Delete.
 792         (moxie_dummy_id): Delete.
 793         (moxie_gdbarch_init): Don't register deleted functions with
 794         gdbarch.
 795
 796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 799         (mn10300_unwind_pc): Delete.
 800         (mn10300_unwind_sp): Delete.
 801         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 802         mn10300_unwind_sp.
 803         (mn10300_frame_unwind_init): Don't register deleted functions with
 804         gdbarch.
 805
 806 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * mep-tdep.c (mep_unwind_pc): Delete.
 809         (mep_unwind_sp): Delete.
 810         (mep_dummy_id): Delete.
 811         (mep_gdbarch_init): Don't register deleted functions with
 812         gdbarch.
 813
 814 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 815
 816         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 817         (m68hc11_unwind_sp): Delete.
 818         (m68hc11_gdbarch_init): Don't register deleted functions with
 819         gdbarch.
 820
 821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * m32r-tdep.c (m32r_unwind_sp): Delete.
 824         (m32r_unwind_pc): Delete.
 825         (m32r_dummy_id): Delete.
 826         (m32r_gdbarch_init): Don't register deleted functions with
 827         gdbarch.
 828
 829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 830
 831         * m32c-tdep.c (m32c_unwind_pc): Delete.
 832         (m32c_unwind_sp): Delete.
 833         (m32c_dummy_id): Delete.
 834         (m32c_gdbarch_init): Don't register deleted functions with
 835         gdbarch.
 836
 837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 840         (lm32_unwind_pc): Delete.
 841         (lm32_dummy_id): Delete.
 842         (lm32_gdbarch_init): Don't register deleted functions with
 843         gdbarch.
 844
 845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 848         (iq2000_unwind_pc): Delete.
 849         (iq2000_dummy_id): Delete.
 850         (iq2000_gdbarch_init): Don't register deleted functions with
 851         gdbarch.
 852
 853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * nds32-tdep.c (nds32_type_align): Delete.
 856         (nds32_push_dummy_call): Use type_align instead.
 857
 858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 859
 860         * arm-tdep.c (arm_type_align): Only handle vector override case.
 861         (arm_push_dummy_call): Use type_align.
 862         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 863
 864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 865
 866         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 867         case.
 868         (pass_on_stack): Use type_align.
 869         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 870         function.
 871
 872 2019-04-23  Tom Tromey  <tromey@adacore.com>
 873
 874         * dwarf2read.c (line_header::file_name_at): Remove unused
 875         overload.
 876
 877 2019-04-23  Tom de Vries  <tdevries@suse.de>
 878
 879         PR gdb/24438
 880         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 881         invocation.
 882
 883
 884 2019-03-27  Ali Tamur  <tamur@google.com>
 885
 886         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 887         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 888         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 889         (dwarf_expr_context::get_addr_index): Likewise
 890         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 891         (symbol_needs_eval_context::get_addr_index): Likewise
 892         (disassemble_dwarf_expression): Add DW_OP_addrx
 893         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 894         (read_cutu_die_from_dwo): Update comment
 895         (skip_one_die): Add DW_FORM_addrx
 896         (read_attribute_value): Likewise
 897         (var_decode_location): Add DW_OP_addrx
 898         (dwarf2_const_value_attr): Add DW_FORM_addrx
 899         (dump_die_shallow): Likewise
 900         (dwarf2_fetch_constant_bytes): Likewise
 901         (decode_locdesc): Add DW_OP_addrx
 902         (skip_form_bytes): Add DW_FORM_addrx
 903
 904 2019-04-22  Ali Tamur  <tamur@google.com>
 905
 906         * MAINTAINERS (Write After Approval): Add self.
 907
 908 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 909
 910         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 911         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 912         (open_symbol_file_object): Likewise.
 913         (svr4_default_sos): Add info parameter.
 914         (svr4_read_so_list): Likewise.
 915         (svr4_current_sos_direct): Adjust functions calls to pass down
 916         info.
 917         (svr4_current_sos_1): Add info parameter.
 918         (svr4_current_sos): Call get_svr4_info, pass info down to
 919         svr4_current_sos_1.
 920         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 921         get_svr4_info.
 922         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 923         get_svr4_info.
 924         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 925         to get_svr4_info.
 926         (probes_table_remove_objfile_probes): Likewise.
 927         (register_solib_event_probe): Add info parameter.
 928         (solist_update_incremental): Pass info parameter down to
 929         svr4_read_so_list.
 930         (disable_probes_interface): Add info parameter.
 931         (svr4_handle_solib_event): Pass current_program_space to
 932         get_svr4_info.  Adjust disable_probes_interface cleanup.
 933         (svr4_create_probe_breakpoints): Add info parameter, pass it
 934         down to register_solib_event_probe.
 935         (svr4_create_solib_event_breakpoints): Add info parameter,
 936         pass it down to svr4_create_probe_breakpoints.
 937         (enable_break): Pass info down to
 938         svr4_create_solib_event_breakpoints.
 939         (svr4_solib_create_inferior_hook): Pass current_program_space to
 940         get_svr4_info.
 941         (svr4_clear_solib): Likewise.
 942
 943 2019-04-22  Pedro Alves  <palves@redhat.com>
 944
 945         * solib-svr4.c (svr4_free_objfile_observer): New.
 946         (probe_and_action::objfile): New field.
 947         (probes_table_htab_remove_objfile_probes)
 948         (probes_table_remove_objfile_probes): New functions.
 949         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 950         in the new probe_and_action.  Don't store the probe in 'lookup'.
 951         (svr4_create_probe_breakpoints): Pass objfile to
 952         register_solib_event_probe.
 953         (_initialize_svr4_solib): Register a free_objfile observer.
 954
 955 2019-04-19  Tom Tromey  <tom@tromey.com>
 956
 957         * common/queue.h: Remove.
 958
 959 2019-04-19  Tom Tromey  <tom@tromey.com>
 960
 961         * event-loop.c: Don't include "common/queue.h".
 962
 963 2019-04-19  Tom Tromey  <tom@tromey.com>
 964
 965         * remote.c (remote_target): Use delete.
 966         * remote-notif.h: Include <list>, not "common/queue.h".
 967         (notif_client_p): Remove typedef.
 968         (remote_notif_state): Add constructor, destructor, initializer.
 969         <notif_queue>: Now a std::list.
 970         (remote_notif_state_xfree): Don't declare.
 971         * remote-notif.c (remote_notif_process, handle_notification)
 972         (remote_notif_state_allocate): Update.
 973         (~remote_notif_state): Rename from remote_notif_state_xfree.
 974
 975 2019-04-19  Tom Tromey  <tom@tromey.com>
 976
 977         * symfile.c (reread_symbols): Update.
 978         * objfiles.c (objfile_register_static_link)
 979         (objfile_lookup_static_link): Update
 980         (~objfile) Don't delete static_links.
 981         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 982
 983 2019-04-19  Tom Tromey  <tom@tromey.com>
 984
 985         * type-stack.h (struct type_stack) <insert>: Constify string.
 986         * type-stack.c (type_stack::insert): Constify string.
 987         * gdbtypes.h (lookup_template_type): Update.
 988         (address_space_name_to_int): Update.
 989         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 990         const.
 991         (lookup_template_type): Make name const.
 992         * c-exp.y: Update rules.
 993         (lex_one_token, classify_name, classify_inner_name)
 994         (c_print_token): Update.
 995         * p-exp.y: Update rules.
 996         (yylex): Update.
 997         * f-exp.y: Update rules.
 998         (yylex): Update.
 999         * d-exp.y: Update rules.
1000         (lex_one_token, classify_name, classify_inner_name): Update.
1001         * parse.c (write_dollar_variable, copy_name): Return std::string.
1002         * parser-defs.h (copy_name): Change return type.
1003         * m2-exp.y: Update rules.
1004         (yylex): Update.
1005         * go-exp.y (lex_one_token): Update.
1006         Update rules.
1007         (classify_unsafe_function, classify_packaged_name)
1008         (classify_name, yylex): Update.
1009
1010 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1011
1012         * configure.ac: add --enable-source-highlight switch.
1013         * configure: Regenerate.
1014         * top.c (print_gdb_version): plumb --enable-source-highlight
1015         status to "show configuration".
1016
1017 2019-04-19  Tom Tromey  <tromey@adacore.com>
1018
1019         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1020         Check ADA_TYPE_P.
1021         (empty_record, ada_template_to_fixed_record_type_1)
1022         (template_to_static_fixed_type)
1023         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1024         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1025         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1026         macros.
1027
1028 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1029
1030         PR symtab/24423:
1031         * source.c (print_source_lines_base): Advance "iter" when a
1032         control character is seen.
1033
1034 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1035
1036         * inferior.h (struct infcall_suspend_state_deleter):
1037         Catch exception in destructor to avoid crash.
1038
1039 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1042         close to the add_com "shell".
1043
1044 2019-04-18  Tom Tromey  <tromey@adacore.com>
1045
1046         * process-stratum-target.h (class process_stratum_target)
1047         <stratum>: Add "final".
1048
1049 2019-04-17  Tom Tromey  <tromey@adacore.com>
1050
1051         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1052         against nullptr before use.
1053
1054 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1055
1056         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1057
1058 2019-04-17  Jim Wilson  <jimw@sifive.com>
1059             Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1062         code read might fail, assume 4-byte breakpoint in that case.
1063
1064 2019-04-15  Leszek Swirski  <leszeks@google.com>
1065
1066         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1067         rather than a hand-rolled POD check when checking for forced MEMORY
1068         classification.
1069
1070 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1071
1072         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1073         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1074         function.
1075         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1076         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1077         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1078         declaration.
1079
1080 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1081
1082         * aarch64-linux-nat.c
1083         (aarch64_linux_nat_target::thread_architecture): Add override.
1084         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1085         each VQ.
1086
1087 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1088
1089         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1090
1091 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1094         target types of size 96-bits, add some additional comments, and
1095         check that the builtin type we found was the correct size.
1096
1097 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1098
1099         * utils.c (prompt_for_continue): Don't restore the styling at the
1100         end, as applied_style has the wrong value.  This fixes styling in
1101         long lists of file names that are interrupted by the "Continue?"
1102         prompt.
1103
1104 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1107         * c-lang.c (c_language_defn): Likewise.
1108         (cplus_language_defn): Likewise.
1109         (asm_language_defn): Likewise.
1110         (minimal_language_defn): Likewise.
1111         * d-lang.c (d_language_defn): Likewise.
1112         * f-lang.c (f_language_defn): Likewise.
1113         * go-lang.c (go_language_defn): Likewise.
1114         * language.c (unknown_language_defn): Likewise.
1115         (auto_language_defn): Likewise.
1116         * language.h (struct language_defn): Remove la_magic field.
1117         (LANG_MAGIC): Delete.
1118         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1119         * objc-lang.c (objc_language_defn): Likewise.
1120         * opencl-lang.c (opencl_language_defn): Likewise.
1121         * p-lang.c (pascal_language_defn): Likewise.
1122         * rust-lang.c (rust_language_defn): Likewise.
1123
1124 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * riscv-tdep.c (riscv_type_align): New function.
1127         (riscv_type_alignment): Delete.
1128         (riscv_arg_location): Use 'type_align'.
1129         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1130
1131 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdbtypes.c (type_align): A struct with no non-static fields also
1134         has alignment of 1.
1135
1136 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1139         component to 0.
1140         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1141         member.
1142         (riscv_struct_info::analyse): New implementation using new
1143         analyse_inner member function.
1144         (riscv_struct_info::field_offset): New member function.
1145         (riscv_struct_info::m_offsets): New member variable.
1146         (riscv_struct_info::analyse_inner): New private member function,
1147         takes the old implementation of riscv_struct_info::analyse but
1148         extended to track field offsets.
1149         (riscv_call_arg_struct): Update the struct folding special cases
1150         to handle cases where empty C++ structs, which are non-zero
1151         length, are found.
1152         (riscv_arg_location): Initialise the length of each location, a
1153         non-zero length now indicates the location is in use.
1154         (riscv_push_dummy_call): Allow for the first location having a
1155         non-zero offset when setting up arguments.
1156         (riscv_return_value): Likewise, but for return values.
1157
1158 2019-04-11  Tom Tromey  <tromey@adacore.com>
1159
1160         * utils.c (internal_vproblem): Make "msg" const.
1161
1162 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1163
1164         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1165         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1166         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1167         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1168
1169 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1170
1171         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1172         function.
1173         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1174         of amd64_collect_native_gregset.
1175         (amd64_linux_nat_target::store_registers): Likewise.
1176
1177 2019-04-10  Tom Tromey  <tom@tromey.com>
1178
1179         * symtab.c (lookup_global_symbol_from_objfile)
1180         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1181         * objfiles.h (class separate_debug_iterator): New.
1182         (class separate_debug_range): New.
1183         (struct objfile) <separate_debug_objfiles>: New method.
1184         (objfile_separate_debug_iterate): Don't declare.
1185         * objfiles.c (separate_debug_iterator::operator++): Rename from
1186         objfile_separate_debug_iterate.
1187         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1188         iterator.
1189         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1190         iterator.
1191
1192 2019-04-10  Tom Tromey  <tom@tromey.com>
1193
1194         * symfile.c (reread_symbols): Remove old comment.
1195         * objfiles.c (free_all_objfiles): Fix a typo.
1196
1197 2019-04-10  Tom Tromey  <tom@tromey.com>
1198
1199         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1200         * minsyms.c (lookup_minimal_symbol): Use foreach.
1201         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1202         (lookup_minimal_symbol_solib_trampoline): Likewise.
1203         * symfile.c (reread_symbols): Use foreach.
1204
1205 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1206             Tom Tromey  <tromey@adacore.com>
1207
1208         PR rust/24414:
1209         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1210         (rust_lex_int_test): Change "value" to be LONGEST.
1211         (rust_lex_tests): Add test for long integer literal.
1212
1213 2019-04-09  Tom Tromey  <tromey@adacore.com>
1214
1215         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1216         to bool.
1217         (extended_remote_target::attach): Update.
1218         (remote_target::remote_notice_new_inferior): Update.
1219         (remote_target::add_current_inferior_and_thread): Update.
1220         * inferior.c (exit_inferior_1): Use "false".
1221         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1222
1223 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1224
1225         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1226         the "start" command.
1227
1228 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1229
1230         * python/py-inferior.c (infpy_thread_from_thread_handle):
1231         Adjust comments to reflect renaming of thread_from_thread_handle
1232         to thread_from_handle.  Adjust keywords.  Fix type error message.
1233         (inferior_object_methods): Add thread_from_handle.  Retain
1234         thread_from_thread_handle, but mark it as deprecated.
1235
1236 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1237
1238         * gdbthread.h (find_thread_by_handle): Revise declaration.
1239         * thread.c (find_thread_by_handle): Likewise.  Adjust
1240         implementation too.
1241         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1242         support for buffer objects as handles.
1243
1244 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1245
1246         * python/py-infthread.c (thpy_thread_handle): New function.
1247         (thread_object_methods): Register thpy_thread_handle.
1248
1249 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1250
1251         * gdbthread.h (thread_to_thread_handle): Declare.
1252         * thread.c (gdbtypes.h): Include.
1253         (thread_to_thread_handle): New function.
1254
1255         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1256         (target_thread_info_to_thread_handle): Declare.
1257         * target.c (target_thread_info_to_thread_handle): New function.
1258         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1259         * target-delegates.c: Regenerate.
1260
1261         * linux-thread-db.c (class thread_db_target): Add method
1262         thread_info_to_thread_handle.
1263         (thread_db_target::thread_info_to_thread_handle): Define.
1264         * remote.c (class remote_target): Add new method
1265         thread_info_to_thread_handle.
1266         (remote_target::thread_info_to_thread_handle): Define.
1267
1268 2019-04-08  Pedro Alves  <palves@redhat.com>
1269
1270         * common/common-exceptions.c (throw_exception): Don't create
1271         named object to throw; throw directly.
1272         (throw_it): Likewise.  Don't initialize gdb_exception::message
1273         here, with new; pass FMT and AP to the ctor instead.
1274         * common/common-exceptions.h: Include <string>.
1275         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1276         const char *, va_list)): New ctor.  Use std::make_shared.
1277         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1278         errors)): Delete.
1279         (gdb_exception_error::gdb_exception_error(enum errors, const char
1280         *, va_list)): New.
1281         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1282         Add assertion.
1283         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1284         errors)): Delete.
1285         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1286         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1287         Add assertion.
1288
1289 2019-04-08  Tom Tromey  <tom@tromey.com>
1290
1291         * valops.c (value_rtti_indirect_type): Replace throw_exception
1292         with throw.
1293         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1294         with throw.
1295         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1296         throw.
1297         * target.c (target_translate_tls_address): Replace throw_exception
1298         with throw.
1299         * stack.c (frame_apply_command_count): Replace throw_exception
1300         with throw.
1301         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1302         throw.
1303         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1304         with throw.
1305         * rs6000-tdep.c (rs6000_frame_cache)
1306         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1307         * remote.c: Replace throw_exception with throw.
1308         * record-full.c (record_full_message, record_full_wait_1)
1309         (record_full_restore): Replace throw_exception with throw.
1310         * record-btrace.c:
1311         (get_thread_current_frame_id, record_btrace_start_replaying)
1312         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1313         (cmd_record_btrace_start): Replace throw_exception with throw.
1314         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1315         throw.
1316         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1317         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1318         * linespec.c:
1319         (find_linespec_symbols): Replace throw_exception with throw.
1320         * infrun.c (displaced_step_prepare, resume): Replace
1321         throw_exception with throw.
1322         * infcmd.c (post_create_inferior): Replace throw_exception with
1323         throw.
1324         * inf-loop.c (inferior_event_handler): Replace throw_exception
1325         with throw.
1326         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1327         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1328         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1329         (get_prev_frame_always, get_frame_pc_if_available)
1330         (get_frame_address_in_block_if_available, get_frame_language):
1331         Replace throw_exception with throw.
1332         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1333         throw_exception with throw.
1334         * eval.c (fetch_subexp_value, evaluate_var_value)
1335         (evaluate_funcall, evaluate_subexp_standard): Replace
1336         throw_exception with throw.
1337         * dwarf2loc.c (call_site_find_chain)
1338         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1339         Replace throw_exception with throw.
1340         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1341         with throw.
1342         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1343         throw.
1344         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1345         * completer.c (complete_line_internal): Replace throw_exception
1346         with throw.
1347         * compile/compile-object-run.c (compile_object_run): Replace
1348         throw_exception with throw.
1349         * cli/cli-script.c (process_next_line): Replace throw_exception
1350         with throw.
1351         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1352         (btrace_enable, btrace_maint_update_pt_packets): Replace
1353         throw_exception with throw.
1354         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1355         throw_exception with throw.
1356         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1357         throw_exception with throw.
1358         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1359         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1360         * aarch64-tdep.c (aarch64_make_prologue_cache)
1361         (aarch64_make_stub_cache): Replace throw_exception with throw.
1362
1363 2019-04-08  Tom Tromey  <tom@tromey.com>
1364
1365         * common/common-exceptions.c (throw_exception): Rename from
1366         throw_exception_cxx.  Remove old copy.  Make argument const.
1367         (throw_it): Create and throw exception objects directly.
1368         * common/common-exceptions.h (throw_exception): Make argument
1369         const.
1370         (struct gdb_exception_error): Add constructor.
1371         (struct gdb_exception_quit): Add constructor.
1372
1373 2019-04-08  Tom Tromey  <tom@tromey.com>
1374
1375         * common/common-exceptions.h (exception_rethrow): Don't declare.
1376         (TRY_SJLJ): Update comment.
1377         (TRY, CATCH, END_CATCH): Remove.
1378         * common/common-exceptions.c (exception_rethrow): Remove.
1379
1380 2019-04-08  Tom Tromey  <tom@tromey.com>
1381
1382         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1383         Remove.
1384         (gdb_exception_error): Rename from
1385         gdb_exception_RETURN_MASK_ERROR.
1386         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1387         (gdb_quit_bad_alloc): Update.
1388         * aarch64-tdep.c: Update.
1389         * ada-lang.c: Update.
1390         * ada-typeprint.c: Update.
1391         * ada-valprint.c: Update.
1392         * amd64-tdep.c: Update.
1393         * arch-utils.c: Update.
1394         * break-catch-throw.c: Update.
1395         * breakpoint.c: Update.
1396         * btrace.c: Update.
1397         * c-varobj.c: Update.
1398         * cli/cli-cmds.c: Update.
1399         * cli/cli-interp.c: Update.
1400         * cli/cli-script.c: Update.
1401         * common/common-exceptions.c: Update.
1402         * common/new-op.c: Update.
1403         * common/selftest.c: Update.
1404         * compile/compile-c-symbols.c: Update.
1405         * compile/compile-cplus-symbols.c: Update.
1406         * compile/compile-object-load.c: Update.
1407         * compile/compile-object-run.c: Update.
1408         * completer.c: Update.
1409         * corelow.c: Update.
1410         * cp-abi.c: Update.
1411         * cp-support.c: Update.
1412         * cp-valprint.c: Update.
1413         * darwin-nat.c: Update.
1414         * disasm-selftests.c: Update.
1415         * dtrace-probe.c: Update.
1416         * dwarf-index-cache.c: Update.
1417         * dwarf-index-write.c: Update.
1418         * dwarf2-frame-tailcall.c: Update.
1419         * dwarf2-frame.c: Update.
1420         * dwarf2loc.c: Update.
1421         * dwarf2read.c: Update.
1422         * eval.c: Update.
1423         * event-loop.c: Update.
1424         * event-top.c: Update.
1425         * exec.c: Update.
1426         * f-valprint.c: Update.
1427         * fbsd-tdep.c: Update.
1428         * frame-unwind.c: Update.
1429         * frame.c: Update.
1430         * gdbtypes.c: Update.
1431         * gnu-v3-abi.c: Update.
1432         * guile/guile-internal.h: Update.
1433         * guile/scm-block.c: Update.
1434         * guile/scm-breakpoint.c: Update.
1435         * guile/scm-cmd.c: Update.
1436         * guile/scm-disasm.c: Update.
1437         * guile/scm-frame.c: Update.
1438         * guile/scm-lazy-string.c: Update.
1439         * guile/scm-math.c: Update.
1440         * guile/scm-param.c: Update.
1441         * guile/scm-ports.c: Update.
1442         * guile/scm-pretty-print.c: Update.
1443         * guile/scm-symbol.c: Update.
1444         * guile/scm-symtab.c: Update.
1445         * guile/scm-type.c: Update.
1446         * guile/scm-value.c: Update.
1447         * i386-linux-tdep.c: Update.
1448         * i386-tdep.c: Update.
1449         * inf-loop.c: Update.
1450         * infcall.c: Update.
1451         * infcmd.c: Update.
1452         * infrun.c: Update.
1453         * jit.c: Update.
1454         * language.c: Update.
1455         * linespec.c: Update.
1456         * linux-fork.c: Update.
1457         * linux-nat.c: Update.
1458         * linux-tdep.c: Update.
1459         * linux-thread-db.c: Update.
1460         * main.c: Update.
1461         * mi/mi-cmd-break.c: Update.
1462         * mi/mi-cmd-stack.c: Update.
1463         * mi/mi-interp.c: Update.
1464         * mi/mi-main.c: Update.
1465         * objc-lang.c: Update.
1466         * p-valprint.c: Update.
1467         * parse.c: Update.
1468         * ppc-linux-tdep.c: Update.
1469         * printcmd.c: Update.
1470         * python/py-arch.c: Update.
1471         * python/py-breakpoint.c: Update.
1472         * python/py-cmd.c: Update.
1473         * python/py-finishbreakpoint.c: Update.
1474         * python/py-frame.c: Update.
1475         * python/py-framefilter.c: Update.
1476         * python/py-gdb-readline.c: Update.
1477         * python/py-inferior.c: Update.
1478         * python/py-infthread.c: Update.
1479         * python/py-lazy-string.c: Update.
1480         * python/py-linetable.c: Update.
1481         * python/py-objfile.c: Update.
1482         * python/py-param.c: Update.
1483         * python/py-prettyprint.c: Update.
1484         * python/py-progspace.c: Update.
1485         * python/py-record-btrace.c: Update.
1486         * python/py-record.c: Update.
1487         * python/py-symbol.c: Update.
1488         * python/py-type.c: Update.
1489         * python/py-unwind.c: Update.
1490         * python/py-utils.c: Update.
1491         * python/py-value.c: Update.
1492         * python/python.c: Update.
1493         * record-btrace.c: Update.
1494         * record-full.c: Update.
1495         * remote-fileio.c: Update.
1496         * remote.c: Update.
1497         * riscv-tdep.c: Update.
1498         * rs6000-aix-tdep.c: Update.
1499         * rs6000-tdep.c: Update.
1500         * rust-exp.y: Update.
1501         * rust-lang.c: Update.
1502         * s390-tdep.c: Update.
1503         * selftest-arch.c: Update.
1504         * solib-dsbt.c: Update.
1505         * solib-frv.c: Update.
1506         * solib-spu.c: Update.
1507         * solib-svr4.c: Update.
1508         * solib.c: Update.
1509         * sparc64-linux-tdep.c: Update.
1510         * stack.c: Update.
1511         * symfile-mem.c: Update.
1512         * symmisc.c: Update.
1513         * target.c: Update.
1514         * thread.c: Update.
1515         * top.c: Update.
1516         * tracefile-tfile.c: Update.
1517         * tui/tui.c: Update.
1518         * typeprint.c: Update.
1519         * unittests/cli-utils-selftests.c: Update.
1520         * unittests/parse-connection-spec-selftests.c: Update.
1521         * valops.c: Update.
1522         * valprint.c: Update.
1523         * value.c: Update.
1524         * varobj.c: Update.
1525         * windows-nat.c: Update.
1526         * x86-linux-nat.c: Update.
1527         * xml-support.c: Update.
1528
1529 2019-04-08  Tom Tromey  <tom@tromey.com>
1530
1531         * xml-support.c: Use C++ exception handling.
1532         * x86-linux-nat.c: Use C++ exception handling.
1533         * windows-nat.c: Use C++ exception handling.
1534         * varobj.c: Use C++ exception handling.
1535         * value.c: Use C++ exception handling.
1536         * valprint.c: Use C++ exception handling.
1537         * valops.c: Use C++ exception handling.
1538         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1539         handling.
1540         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1541         * typeprint.c: Use C++ exception handling.
1542         * tui/tui.c: Use C++ exception handling.
1543         * tracefile-tfile.c: Use C++ exception handling.
1544         * top.c: Use C++ exception handling.
1545         * thread.c: Use C++ exception handling.
1546         * target.c: Use C++ exception handling.
1547         * symmisc.c: Use C++ exception handling.
1548         * symfile-mem.c: Use C++ exception handling.
1549         * stack.c: Use C++ exception handling.
1550         * sparc64-linux-tdep.c: Use C++ exception handling.
1551         * solib.c: Use C++ exception handling.
1552         * solib-svr4.c: Use C++ exception handling.
1553         * solib-spu.c: Use C++ exception handling.
1554         * solib-frv.c: Use C++ exception handling.
1555         * solib-dsbt.c: Use C++ exception handling.
1556         * selftest-arch.c: Use C++ exception handling.
1557         * s390-tdep.c: Use C++ exception handling.
1558         * rust-lang.c: Use C++ exception handling.
1559         * rust-exp.y: Use C++ exception handling.
1560         * rs6000-tdep.c: Use C++ exception handling.
1561         * rs6000-aix-tdep.c: Use C++ exception handling.
1562         * riscv-tdep.c: Use C++ exception handling.
1563         * remote.c: Use C++ exception handling.
1564         * remote-fileio.c: Use C++ exception handling.
1565         * record-full.c: Use C++ exception handling.
1566         * record-btrace.c: Use C++ exception handling.
1567         * python/python.c: Use C++ exception handling.
1568         * python/py-value.c: Use C++ exception handling.
1569         * python/py-utils.c: Use C++ exception handling.
1570         * python/py-unwind.c: Use C++ exception handling.
1571         * python/py-type.c: Use C++ exception handling.
1572         * python/py-symbol.c: Use C++ exception handling.
1573         * python/py-record.c: Use C++ exception handling.
1574         * python/py-record-btrace.c: Use C++ exception handling.
1575         * python/py-progspace.c: Use C++ exception handling.
1576         * python/py-prettyprint.c: Use C++ exception handling.
1577         * python/py-param.c: Use C++ exception handling.
1578         * python/py-objfile.c: Use C++ exception handling.
1579         * python/py-linetable.c: Use C++ exception handling.
1580         * python/py-lazy-string.c: Use C++ exception handling.
1581         * python/py-infthread.c: Use C++ exception handling.
1582         * python/py-inferior.c: Use C++ exception handling.
1583         * python/py-gdb-readline.c: Use C++ exception handling.
1584         * python/py-framefilter.c: Use C++ exception handling.
1585         * python/py-frame.c: Use C++ exception handling.
1586         * python/py-finishbreakpoint.c: Use C++ exception handling.
1587         * python/py-cmd.c: Use C++ exception handling.
1588         * python/py-breakpoint.c: Use C++ exception handling.
1589         * python/py-arch.c: Use C++ exception handling.
1590         * printcmd.c: Use C++ exception handling.
1591         * ppc-linux-tdep.c: Use C++ exception handling.
1592         * parse.c: Use C++ exception handling.
1593         * p-valprint.c: Use C++ exception handling.
1594         * objc-lang.c: Use C++ exception handling.
1595         * mi/mi-main.c: Use C++ exception handling.
1596         * mi/mi-interp.c: Use C++ exception handling.
1597         * mi/mi-cmd-stack.c: Use C++ exception handling.
1598         * mi/mi-cmd-break.c: Use C++ exception handling.
1599         * main.c: Use C++ exception handling.
1600         * linux-thread-db.c: Use C++ exception handling.
1601         * linux-tdep.c: Use C++ exception handling.
1602         * linux-nat.c: Use C++ exception handling.
1603         * linux-fork.c: Use C++ exception handling.
1604         * linespec.c: Use C++ exception handling.
1605         * language.c: Use C++ exception handling.
1606         * jit.c: Use C++ exception handling.
1607         * infrun.c: Use C++ exception handling.
1608         * infcmd.c: Use C++ exception handling.
1609         * infcall.c: Use C++ exception handling.
1610         * inf-loop.c: Use C++ exception handling.
1611         * i386-tdep.c: Use C++ exception handling.
1612         * i386-linux-tdep.c: Use C++ exception handling.
1613         * guile/scm-value.c: Use C++ exception handling.
1614         * guile/scm-type.c: Use C++ exception handling.
1615         * guile/scm-symtab.c: Use C++ exception handling.
1616         * guile/scm-symbol.c: Use C++ exception handling.
1617         * guile/scm-pretty-print.c: Use C++ exception handling.
1618         * guile/scm-ports.c: Use C++ exception handling.
1619         * guile/scm-param.c: Use C++ exception handling.
1620         * guile/scm-math.c: Use C++ exception handling.
1621         * guile/scm-lazy-string.c: Use C++ exception handling.
1622         * guile/scm-frame.c: Use C++ exception handling.
1623         * guile/scm-disasm.c: Use C++ exception handling.
1624         * guile/scm-cmd.c: Use C++ exception handling.
1625         * guile/scm-breakpoint.c: Use C++ exception handling.
1626         * guile/scm-block.c: Use C++ exception handling.
1627         * guile/guile-internal.h: Use C++ exception handling.
1628         * gnu-v3-abi.c: Use C++ exception handling.
1629         * gdbtypes.c: Use C++ exception handling.
1630         * frame.c: Use C++ exception handling.
1631         * frame-unwind.c: Use C++ exception handling.
1632         * fbsd-tdep.c: Use C++ exception handling.
1633         * f-valprint.c: Use C++ exception handling.
1634         * exec.c: Use C++ exception handling.
1635         * event-top.c: Use C++ exception handling.
1636         * event-loop.c: Use C++ exception handling.
1637         * eval.c: Use C++ exception handling.
1638         * dwarf2read.c: Use C++ exception handling.
1639         * dwarf2loc.c: Use C++ exception handling.
1640         * dwarf2-frame.c: Use C++ exception handling.
1641         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1642         * dwarf-index-write.c: Use C++ exception handling.
1643         * dwarf-index-cache.c: Use C++ exception handling.
1644         * dtrace-probe.c: Use C++ exception handling.
1645         * disasm-selftests.c: Use C++ exception handling.
1646         * darwin-nat.c: Use C++ exception handling.
1647         * cp-valprint.c: Use C++ exception handling.
1648         * cp-support.c: Use C++ exception handling.
1649         * cp-abi.c: Use C++ exception handling.
1650         * corelow.c: Use C++ exception handling.
1651         * completer.c: Use C++ exception handling.
1652         * compile/compile-object-run.c: Use C++ exception handling.
1653         * compile/compile-object-load.c: Use C++ exception handling.
1654         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1655         * compile/compile-c-symbols.c: Use C++ exception handling.
1656         * common/selftest.c: Use C++ exception handling.
1657         * common/new-op.c: Use C++ exception handling.
1658         * cli/cli-script.c: Use C++ exception handling.
1659         * cli/cli-interp.c: Use C++ exception handling.
1660         * cli/cli-cmds.c: Use C++ exception handling.
1661         * c-varobj.c: Use C++ exception handling.
1662         * btrace.c: Use C++ exception handling.
1663         * breakpoint.c: Use C++ exception handling.
1664         * break-catch-throw.c: Use C++ exception handling.
1665         * arch-utils.c: Use C++ exception handling.
1666         * amd64-tdep.c: Use C++ exception handling.
1667         * ada-valprint.c: Use C++ exception handling.
1668         * ada-typeprint.c: Use C++ exception handling.
1669         * ada-lang.c: Use C++ exception handling.
1670         * aarch64-tdep.c: Use C++ exception handling.
1671
1672 2019-04-08  Tom Tromey  <tom@tromey.com>
1673
1674         * xml-support.c (gdb_xml_parser::parse): Update.
1675         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1676         * value.c (show_convenience): Update.
1677         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1678         (test_parse_flags_qcs): Update.
1679         * thread.c (thr_try_catch_cmd): Update.
1680         * target.c (target_translate_tls_address): Update.
1681         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1682         (info_frame_command_core, frame_apply_command_count): Update.
1683         * rust-exp.y (rust_lex_exception_test): Update.
1684         * riscv-tdep.c (riscv_print_one_register_info): Update.
1685         * remote.c (remote_target::enable_btrace): Update.
1686         * record-btrace.c (record_btrace_enable_warn): Update.
1687         * python/py-utils.c (gdbpy_convert_exception): Update.
1688         * printcmd.c (do_one_display, print_variable_and_value): Update.
1689         * mi/mi-main.c (mi_print_exception): Update.
1690         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1691         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1692         * linux-nat.c (linux_nat_target::attach): Update.
1693         * linux-fork.c (class scoped_switch_fork_info): Update.
1694         * infrun.c (displaced_step_prepare): Update.
1695         * infcall.c (call_function_by_hand_dummy): Update.
1696         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1697         * gnu-v3-abi.c (print_one_vtable): Update.
1698         * frame.c (get_prev_frame_always): Update.
1699         * f-valprint.c (info_common_command_for_block): Update.
1700         * exec.c (try_open_exec_file): Update.
1701         * exceptions.c (print_exception, exception_print)
1702         (exception_fprintf, exception_print_same): Update.
1703         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1704         * dwarf-index-cache.c (index_cache::store)
1705         (index_cache::lookup_gdb_index): Update.
1706         * darwin-nat.c (maybe_cache_shell): Update.
1707         * cp-valprint.c (cp_print_value_fields): Update.
1708         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1709         (gcc_cplus_symbol_address): Update.
1710         * compile/compile-c-symbols.c (gcc_convert_symbol)
1711         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1712         * common/selftest.c: Update.
1713         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1714         a std::string.
1715         (exception_try_scope_entry, exception_try_scope_exit): Don't
1716         declare.
1717         (struct exception_try_scope): Remove.
1718         (TRY): Don't use exception_try_scope.
1719         (struct gdb_exception): Add constructor, operator=.
1720         <what>: New method.
1721         (struct gdb_exception_RETURN_MASK_ALL)
1722         (struct gdb_exception_RETURN_MASK_ERROR)
1723         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1724         (struct gdb_quit_bad_alloc): Update.
1725         * common/common-exceptions.c (exception_none): Change
1726         initializer.
1727         (struct catcher) <state, exception>: Initialize inline.
1728         <prev>: Remove member.
1729         (current_catcher): Remove.
1730         (catchers): New global.
1731         (exceptions_state_mc_init): Simplify.
1732         (catcher_pop): Remove.
1733         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1734         (try_scope_depth, exception_try_scope_entry)
1735         (exception_try_scope_exit): Remove.
1736         (throw_exception_sjlj): Update.
1737         (exception_messages, exception_messages_size): Remove.
1738         (throw_it): Simplify.
1739         (gdb_exception_sliced_copy): Remove.
1740         (throw_exception_cxx): Update.
1741         * cli/cli-script.c (script_from_file): Update.
1742         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1743         Update.
1744         * ada-valprint.c (ada_val_print): Update.
1745         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1746         (create_excep_cond_exprs): Update.
1747
1748 2019-04-08  Tom Tromey  <tom@tromey.com>
1749
1750         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1751         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1752         (TRY, CATCH, END_CATCH): Remove some definitions.
1753         * common/common-exceptions.c: Don't use GDB_XCPT.
1754         (catcher_list_size): Remove.
1755         (throw_exception, throw_it): Simplify.
1756
1757 2019-04-05  Tom Tromey  <tom@tromey.com>
1758
1759         Revert the header-sorting patch.
1760         * ft32-tdep.c: Revert.
1761         * frv-tdep.c: Revert.
1762         * frv-linux-tdep.c: Revert.
1763         * frame.c: Revert.
1764         * frame-unwind.c: Revert.
1765         * frame-base.c: Revert.
1766         * fork-child.c: Revert.
1767         * findvar.c: Revert.
1768         * findcmd.c: Revert.
1769         * filesystem.c: Revert.
1770         * filename-seen-cache.h: Revert.
1771         * filename-seen-cache.c: Revert.
1772         * fbsd-tdep.c: Revert.
1773         * fbsd-nat.h: Revert.
1774         * fbsd-nat.c: Revert.
1775         * f-valprint.c: Revert.
1776         * f-typeprint.c: Revert.
1777         * f-lang.c: Revert.
1778         * extension.h: Revert.
1779         * extension.c: Revert.
1780         * extension-priv.h: Revert.
1781         * expprint.c: Revert.
1782         * exec.h: Revert.
1783         * exec.c: Revert.
1784         * exceptions.c: Revert.
1785         * event-top.c: Revert.
1786         * event-loop.c: Revert.
1787         * eval.c: Revert.
1788         * elfread.c: Revert.
1789         * dwarf2read.h: Revert.
1790         * dwarf2read.c: Revert.
1791         * dwarf2loc.c: Revert.
1792         * dwarf2expr.h: Revert.
1793         * dwarf2expr.c: Revert.
1794         * dwarf2-frame.c: Revert.
1795         * dwarf2-frame-tailcall.c: Revert.
1796         * dwarf-index-write.h: Revert.
1797         * dwarf-index-write.c: Revert.
1798         * dwarf-index-common.c: Revert.
1799         * dwarf-index-cache.h: Revert.
1800         * dwarf-index-cache.c: Revert.
1801         * dummy-frame.c: Revert.
1802         * dtrace-probe.c: Revert.
1803         * disasm.h: Revert.
1804         * disasm.c: Revert.
1805         * disasm-selftests.c: Revert.
1806         * dictionary.c: Revert.
1807         * dicos-tdep.c: Revert.
1808         * demangle.c: Revert.
1809         * dcache.h: Revert.
1810         * dcache.c: Revert.
1811         * darwin-nat.h: Revert.
1812         * darwin-nat.c: Revert.
1813         * darwin-nat-info.c: Revert.
1814         * d-valprint.c: Revert.
1815         * d-namespace.c: Revert.
1816         * d-lang.c: Revert.
1817         * ctf.c: Revert.
1818         * csky-tdep.c: Revert.
1819         * csky-linux-tdep.c: Revert.
1820         * cris-tdep.c: Revert.
1821         * cris-linux-tdep.c: Revert.
1822         * cp-valprint.c: Revert.
1823         * cp-support.c: Revert.
1824         * cp-namespace.c: Revert.
1825         * cp-abi.c: Revert.
1826         * corelow.c: Revert.
1827         * corefile.c: Revert.
1828         * continuations.c: Revert.
1829         * completer.h: Revert.
1830         * completer.c: Revert.
1831         * complaints.c: Revert.
1832         * coffread.c: Revert.
1833         * coff-pe-read.c: Revert.
1834         * cli-out.h: Revert.
1835         * cli-out.c: Revert.
1836         * charset.c: Revert.
1837         * c-varobj.c: Revert.
1838         * c-valprint.c: Revert.
1839         * c-typeprint.c: Revert.
1840         * c-lang.c: Revert.
1841         * buildsym.c: Revert.
1842         * buildsym-legacy.c: Revert.
1843         * build-id.h: Revert.
1844         * build-id.c: Revert.
1845         * btrace.c: Revert.
1846         * bsd-uthread.c: Revert.
1847         * breakpoint.h: Revert.
1848         * breakpoint.c: Revert.
1849         * break-catch-throw.c: Revert.
1850         * break-catch-syscall.c: Revert.
1851         * break-catch-sig.c: Revert.
1852         * blockframe.c: Revert.
1853         * block.c: Revert.
1854         * bfin-tdep.c: Revert.
1855         * bfin-linux-tdep.c: Revert.
1856         * bfd-target.c: Revert.
1857         * bcache.c: Revert.
1858         * ax-general.c: Revert.
1859         * ax-gdb.h: Revert.
1860         * ax-gdb.c: Revert.
1861         * avr-tdep.c: Revert.
1862         * auxv.c: Revert.
1863         * auto-load.c: Revert.
1864         * arm-wince-tdep.c: Revert.
1865         * arm-tdep.c: Revert.
1866         * arm-symbian-tdep.c: Revert.
1867         * arm-pikeos-tdep.c: Revert.
1868         * arm-obsd-tdep.c: Revert.
1869         * arm-nbsd-tdep.c: Revert.
1870         * arm-nbsd-nat.c: Revert.
1871         * arm-linux-tdep.c: Revert.
1872         * arm-linux-nat.c: Revert.
1873         * arm-fbsd-tdep.c: Revert.
1874         * arm-fbsd-nat.c: Revert.
1875         * arm-bsd-tdep.c: Revert.
1876         * arch-utils.c: Revert.
1877         * arc-tdep.c: Revert.
1878         * arc-newlib-tdep.c: Revert.
1879         * annotate.h: Revert.
1880         * annotate.c: Revert.
1881         * amd64-windows-tdep.c: Revert.
1882         * amd64-windows-nat.c: Revert.
1883         * amd64-tdep.c: Revert.
1884         * amd64-sol2-tdep.c: Revert.
1885         * amd64-obsd-tdep.c: Revert.
1886         * amd64-obsd-nat.c: Revert.
1887         * amd64-nbsd-tdep.c: Revert.
1888         * amd64-nbsd-nat.c: Revert.
1889         * amd64-nat.c: Revert.
1890         * amd64-linux-tdep.c: Revert.
1891         * amd64-linux-nat.c: Revert.
1892         * amd64-fbsd-tdep.c: Revert.
1893         * amd64-fbsd-nat.c: Revert.
1894         * amd64-dicos-tdep.c: Revert.
1895         * amd64-darwin-tdep.c: Revert.
1896         * amd64-bsd-nat.c: Revert.
1897         * alpha-tdep.c: Revert.
1898         * alpha-obsd-tdep.c: Revert.
1899         * alpha-nbsd-tdep.c: Revert.
1900         * alpha-mdebug-tdep.c: Revert.
1901         * alpha-linux-tdep.c: Revert.
1902         * alpha-linux-nat.c: Revert.
1903         * alpha-bsd-tdep.c: Revert.
1904         * alpha-bsd-nat.c: Revert.
1905         * aix-thread.c: Revert.
1906         * agent.c: Revert.
1907         * addrmap.c: Revert.
1908         * ada-varobj.c: Revert.
1909         * ada-valprint.c: Revert.
1910         * ada-typeprint.c: Revert.
1911         * ada-tasks.c: Revert.
1912         * ada-lang.c: Revert.
1913         * aarch64-tdep.c: Revert.
1914         * aarch64-ravenscar-thread.c: Revert.
1915         * aarch64-newlib-tdep.c: Revert.
1916         * aarch64-linux-tdep.c: Revert.
1917         * aarch64-linux-nat.c: Revert.
1918         * aarch64-fbsd-tdep.c: Revert.
1919         * aarch64-fbsd-nat.c: Revert.
1920         * aarch32-linux-nat.c: Revert.
1921
1922 2019-04-05  Tom Tromey  <tom@tromey.com>
1923
1924         * ft32-tdep.c: Sort headers.
1925         * frv-tdep.c: Sort headers.
1926         * frv-linux-tdep.c: Sort headers.
1927         * frame.c: Sort headers.
1928         * frame-unwind.c: Sort headers.
1929         * frame-base.c: Sort headers.
1930         * fork-child.c: Sort headers.
1931         * findvar.c: Sort headers.
1932         * findcmd.c: Sort headers.
1933         * filesystem.c: Sort headers.
1934         * filename-seen-cache.h: Sort headers.
1935         * filename-seen-cache.c: Sort headers.
1936         * fbsd-tdep.c: Sort headers.
1937         * fbsd-nat.h: Sort headers.
1938         * fbsd-nat.c: Sort headers.
1939         * f-valprint.c: Sort headers.
1940         * f-typeprint.c: Sort headers.
1941         * f-lang.c: Sort headers.
1942         * extension.h: Sort headers.
1943         * extension.c: Sort headers.
1944         * extension-priv.h: Sort headers.
1945         * expprint.c: Sort headers.
1946         * exec.h: Sort headers.
1947         * exec.c: Sort headers.
1948         * exceptions.c: Sort headers.
1949         * event-top.c: Sort headers.
1950         * event-loop.c: Sort headers.
1951         * eval.c: Sort headers.
1952         * elfread.c: Sort headers.
1953         * dwarf2read.h: Sort headers.
1954         * dwarf2read.c: Sort headers.
1955         * dwarf2loc.c: Sort headers.
1956         * dwarf2expr.h: Sort headers.
1957         * dwarf2expr.c: Sort headers.
1958         * dwarf2-frame.c: Sort headers.
1959         * dwarf2-frame-tailcall.c: Sort headers.
1960         * dwarf-index-write.h: Sort headers.
1961         * dwarf-index-write.c: Sort headers.
1962         * dwarf-index-common.c: Sort headers.
1963         * dwarf-index-cache.h: Sort headers.
1964         * dwarf-index-cache.c: Sort headers.
1965         * dummy-frame.c: Sort headers.
1966         * dtrace-probe.c: Sort headers.
1967         * disasm.h: Sort headers.
1968         * disasm.c: Sort headers.
1969         * disasm-selftests.c: Sort headers.
1970         * dictionary.c: Sort headers.
1971         * dicos-tdep.c: Sort headers.
1972         * demangle.c: Sort headers.
1973         * dcache.h: Sort headers.
1974         * dcache.c: Sort headers.
1975         * darwin-nat.h: Sort headers.
1976         * darwin-nat.c: Sort headers.
1977         * darwin-nat-info.c: Sort headers.
1978         * d-valprint.c: Sort headers.
1979         * d-namespace.c: Sort headers.
1980         * d-lang.c: Sort headers.
1981         * ctf.c: Sort headers.
1982         * csky-tdep.c: Sort headers.
1983         * csky-linux-tdep.c: Sort headers.
1984         * cris-tdep.c: Sort headers.
1985         * cris-linux-tdep.c: Sort headers.
1986         * cp-valprint.c: Sort headers.
1987         * cp-support.c: Sort headers.
1988         * cp-namespace.c: Sort headers.
1989         * cp-abi.c: Sort headers.
1990         * corelow.c: Sort headers.
1991         * corefile.c: Sort headers.
1992         * continuations.c: Sort headers.
1993         * completer.h: Sort headers.
1994         * completer.c: Sort headers.
1995         * complaints.c: Sort headers.
1996         * coffread.c: Sort headers.
1997         * coff-pe-read.c: Sort headers.
1998         * cli-out.h: Sort headers.
1999         * cli-out.c: Sort headers.
2000         * charset.c: Sort headers.
2001         * c-varobj.c: Sort headers.
2002         * c-valprint.c: Sort headers.
2003         * c-typeprint.c: Sort headers.
2004         * c-lang.c: Sort headers.
2005         * buildsym.c: Sort headers.
2006         * buildsym-legacy.c: Sort headers.
2007         * build-id.h: Sort headers.
2008         * build-id.c: Sort headers.
2009         * btrace.c: Sort headers.
2010         * bsd-uthread.c: Sort headers.
2011         * breakpoint.h: Sort headers.
2012         * breakpoint.c: Sort headers.
2013         * break-catch-throw.c: Sort headers.
2014         * break-catch-syscall.c: Sort headers.
2015         * break-catch-sig.c: Sort headers.
2016         * blockframe.c: Sort headers.
2017         * block.c: Sort headers.
2018         * bfin-tdep.c: Sort headers.
2019         * bfin-linux-tdep.c: Sort headers.
2020         * bfd-target.c: Sort headers.
2021         * bcache.c: Sort headers.
2022         * ax-general.c: Sort headers.
2023         * ax-gdb.h: Sort headers.
2024         * ax-gdb.c: Sort headers.
2025         * avr-tdep.c: Sort headers.
2026         * auxv.c: Sort headers.
2027         * auto-load.c: Sort headers.
2028         * arm-wince-tdep.c: Sort headers.
2029         * arm-tdep.c: Sort headers.
2030         * arm-symbian-tdep.c: Sort headers.
2031         * arm-pikeos-tdep.c: Sort headers.
2032         * arm-obsd-tdep.c: Sort headers.
2033         * arm-nbsd-tdep.c: Sort headers.
2034         * arm-nbsd-nat.c: Sort headers.
2035         * arm-linux-tdep.c: Sort headers.
2036         * arm-linux-nat.c: Sort headers.
2037         * arm-fbsd-tdep.c: Sort headers.
2038         * arm-fbsd-nat.c: Sort headers.
2039         * arm-bsd-tdep.c: Sort headers.
2040         * arch-utils.c: Sort headers.
2041         * arc-tdep.c: Sort headers.
2042         * arc-newlib-tdep.c: Sort headers.
2043         * annotate.h: Sort headers.
2044         * annotate.c: Sort headers.
2045         * amd64-windows-tdep.c: Sort headers.
2046         * amd64-windows-nat.c: Sort headers.
2047         * amd64-tdep.c: Sort headers.
2048         * amd64-sol2-tdep.c: Sort headers.
2049         * amd64-obsd-tdep.c: Sort headers.
2050         * amd64-obsd-nat.c: Sort headers.
2051         * amd64-nbsd-tdep.c: Sort headers.
2052         * amd64-nbsd-nat.c: Sort headers.
2053         * amd64-nat.c: Sort headers.
2054         * amd64-linux-tdep.c: Sort headers.
2055         * amd64-linux-nat.c: Sort headers.
2056         * amd64-fbsd-tdep.c: Sort headers.
2057         * amd64-fbsd-nat.c: Sort headers.
2058         * amd64-dicos-tdep.c: Sort headers.
2059         * amd64-darwin-tdep.c: Sort headers.
2060         * amd64-bsd-nat.c: Sort headers.
2061         * alpha-tdep.c: Sort headers.
2062         * alpha-obsd-tdep.c: Sort headers.
2063         * alpha-nbsd-tdep.c: Sort headers.
2064         * alpha-mdebug-tdep.c: Sort headers.
2065         * alpha-linux-tdep.c: Sort headers.
2066         * alpha-linux-nat.c: Sort headers.
2067         * alpha-bsd-tdep.c: Sort headers.
2068         * alpha-bsd-nat.c: Sort headers.
2069         * aix-thread.c: Sort headers.
2070         * agent.c: Sort headers.
2071         * addrmap.c: Sort headers.
2072         * ada-varobj.c: Sort headers.
2073         * ada-valprint.c: Sort headers.
2074         * ada-typeprint.c: Sort headers.
2075         * ada-tasks.c: Sort headers.
2076         * ada-lang.c: Sort headers.
2077         * aarch64-tdep.c: Sort headers.
2078         * aarch64-ravenscar-thread.c: Sort headers.
2079         * aarch64-newlib-tdep.c: Sort headers.
2080         * aarch64-linux-tdep.c: Sort headers.
2081         * aarch64-linux-nat.c: Sort headers.
2082         * aarch64-fbsd-tdep.c: Sort headers.
2083         * aarch64-fbsd-nat.c: Sort headers.
2084         * aarch32-linux-nat.c: Sort headers.
2085
2086 2019-04-04  Tom Tromey  <tom@tromey.com>
2087
2088         * varobj.c (varobj_create): Update.
2089         * rust-exp.y (struct rust_parser) <update_innermost_block,
2090         lookup_symbol>: New methods.
2091         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2092         Rename.
2093         (rust_parser::rust_lookup_type)
2094         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2095         * printcmd.c (display_command, do_one_display): Update.
2096         * parser-defs.h (struct parser_state) <parser_state>: Add
2097         "tracker" parameter.
2098         (block_tracker): New member.
2099         (class innermost_block_tracker) <innermost_block_tracker>: Add
2100         "types" parameter.
2101         <reset>: Remove method.
2102         (innermost_block): Don't declare.
2103         (null_post_parser): Update.
2104         * parse.c (innermost_block): Remove global.
2105         (write_dollar_variable): Update.
2106         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2107         Remove "tracker_types" parameter.
2108         (parse_expression): Add "tracker" parameter.
2109         (parse_expression_for_completion): Update.
2110         (null_post_parser): Add "tracker" parameter.
2111         * p-exp.y: Update rules.
2112         * m2-exp.y: Update rules.
2113         * language.h (struct language_defn) <la_post_parser>: Add
2114         "tracker" parameter.
2115         * go-exp.y: Update rules.
2116         * f-exp.y: Update rules.
2117         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2118         parameter.
2119         * d-exp.y: Update rules.
2120         * c-exp.y: Update rules.
2121         * breakpoint.c (set_breakpoint_condition): Create an
2122         innermost_block_tracker.
2123         (watch_command_1): Likewise.
2124         * ada-lang.c (resolve): Add "tracker" parameter.
2125         (resolve_subexp): Likewise.
2126         * ada-exp.y (write_var_from_sym): Update.
2127
2128 2019-04-04  Tom Tromey  <tom@tromey.com>
2129
2130         * type-stack.h: New file.
2131         * type-stack.c: New file.
2132         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2133         type-stack.h.
2134         (insert_into_type_stack, insert_type, push_type, push_type_int)
2135         (insert_type_address_space, pop_type, pop_type_int)
2136         (pop_typelist, pop_type_stack, append_type_stack)
2137         (push_type_stack, get_type_stack, push_typelist)
2138         (follow_type_instance_flags, follow_types): Don't declare.
2139         * parse.c (type_stack): Remove global.
2140         (parse_exp_in_context): Update.
2141         (insert_into_type_stack, insert_type, push_type, push_type_int)
2142         (insert_type_address_space, pop_type, pop_type_int)
2143         (pop_typelist, pop_type_stack, append_type_stack)
2144         (push_type_stack, get_type_stack, push_typelist)
2145         (follow_type_instance_flags, follow_types): Remove (moved to
2146         type-stack.c).
2147         * f-exp.y (type_stack): New global.
2148         Update rules.
2149         (push_kind_type, f_parse): Update.
2150         * d-exp.y (type_stack): New global.
2151         Update rules.
2152         (d_parse): Update.
2153         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2154         Update rules.
2155         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2156         (HFILES_NO_SRCDIR): Add type-stack.h.
2157
2158 2019-04-04  Tom Tromey  <tom@tromey.com>
2159
2160         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2161         (rust_parser::convert_ast_to_expression, rust_parse)
2162         (rust_lex_test_completion, rust_lex_tests): Update.
2163         * parser-defs.h (struct expr_completion_state): New.
2164         (struct parser_state) <parser_state>: Add completion parameter.
2165         <mark_struct_expression, mark_completion_tag>: New methods.
2166         <parse_completion, m_completion_state>: New members.
2167         (prefixify_expression, null_post_parser): Update.
2168         (mark_struct_expression, mark_completion_tag): Don't declare.
2169         * parse.c (parse_completion, expout_last_struct)
2170         (expout_tag_completion_type, expout_completion_name): Remove
2171         globals.
2172         (parser_state::mark_struct_expression)
2173         (parser_state::mark_completion_tag): Now methods.
2174         (prefixify_expression): Add last_struct parameter.
2175         (prefixify_subexp): Likewise.
2176         (parse_exp_1): Update.
2177         (parse_exp_in_context): Add cstate parameter.  Update.
2178         (parse_expression_for_completion): Create an
2179         expr_completion_state.
2180         (null_post_parser): Add "completion" parameter.
2181         * p-exp.y: Update rules.
2182         (yylex): Update.
2183         * language.h (struct language_defn) <la_post_parser>: Add
2184         "completing" parameter.
2185         * go-exp.y: Update rules.
2186         (lex_one_token): Update.
2187         * expression.h (parse_completion): Don't declare.
2188         * d-exp.y: Update rules.
2189         (lex_one_token): Update rules.
2190         * c-exp.y: Update rules.
2191         (lex_one_token): Update.
2192         * ada-lang.c (resolve): Add "parse_completion" parameter.
2193         (resolve_subexp): Likewise.
2194         (ada_resolve_function): Likewise.
2195
2196 2019-04-04  Tom Tromey  <tom@tromey.com>
2197
2198         * parser-defs.h (struct parser_state) <start_arglist,
2199         end_arglist>: New methods.
2200         <arglist_len, m_funcall_chain>: New members.
2201         (arglist_len, start_arglist, end_arglist): Don't declare.
2202         * parse.c (arglist_len, funcall_chain): Remove global.
2203         (start_arglist, end_arglist): Remove functions.
2204         (parse_exp_in_context): Update.
2205         * p-exp.y: Update rules.
2206         * m2-exp.y: Update rules.
2207         * go-exp.y: Update rules.
2208         * f-exp.y: Update rules.
2209         * d-exp.y: Update rules.
2210         * c-exp.y: Update rules.
2211
2212 2019-04-04  Tom Tromey  <tom@tromey.com>
2213
2214         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2215         lex_operator, push_back>: New methods.
2216         Update all rules.
2217         (rust_parser::lex_hex, lex_escape): Rename and update.
2218         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2219         (rust_parser::lex_operator): Rename and update.
2220         (rust_parser::lex_number, rustyylex, rustyyerror)
2221         (rust_lex_test_init, rust_lex_test_sequence)
2222         (rust_lex_test_push_back, rust_lex_tests): Update.
2223         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2224         parameter.
2225         <lexptr, prev_lexptr>: New members.
2226         (lexptr, prev_lexptr): Don't declare.
2227         * parse.c (lexptr, prev_lexptr): Remove globals.
2228         (parse_exp_in_context): Update.
2229         * p-exp.y (yylex, yyerror): Update.
2230         * m2-exp.y (parse_number, yylex, yyerror): Update.
2231         * go-exp.y (lex_one_token, yyerror): Update.
2232         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2233         * d-exp.y (lex_one_token, yyerror): Update.
2234         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2235         (lex_one_token, yyerror): Update.
2236         * ada-lex.l (YY_INPUT): Update.
2237         (rewind_to_char): Update.
2238         * ada-exp.y (yyerror): Update.
2239
2240 2019-04-04  Tom Tromey  <tom@tromey.com>
2241
2242         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2243         * parser-defs.h (struct parser_state) <parser_state>: Add new
2244         parameter.
2245         <comma_terminates>: New member.
2246         (comma_terminates): Don't declare global.
2247         * parse.c (comma_terminates): Remove global.
2248         (parse_exp_in_context): Update.
2249         * p-exp.y (yylex): Update.
2250         * m2-exp.y (yylex): Update.
2251         * go-exp.y (lex_one_token): Update.
2252         * f-exp.y (yylex): Update.
2253         * d-exp.y (lex_one_token): Update.
2254         * c-exp.y (lex_one_token): Update.
2255         * ada-lex.l: Update.
2256
2257 2019-04-04  Tom Tromey  <tom@tromey.com>
2258
2259         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2260         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2261         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2262         * parser-defs.h (paren_depth): Don't declare.
2263         * parse.c (paren_depth): Remove global.
2264         (parse_exp_in_context): Update.
2265         * p-exp.y (paren_depth): New global.
2266         (pascal_parse): Initialize it.
2267         * m2-exp.y (paren_depth): New global.
2268         (m2_parse): Initialize it.
2269         * go-exp.y (paren_depth): New global.
2270         (go_parse): Initialize it.
2271         * f-exp.y (paren_depth): New global.
2272         (f_parse): Initialize it.
2273         * d-exp.y (paren_depth): New global.
2274         (d_parse): Initialize it.
2275         * c-exp.y (paren_depth): New global.
2276         (c_parse): Initialize it.
2277         * ada-lex.l (paren_depth): New global.
2278         (lexer_init): Initialize it.
2279
2280 2019-04-04  Tom Tromey  <tom@tromey.com>
2281
2282         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2283         (rust_parser::convert_ast_to_type)
2284         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2285         * parser-defs.h (struct parser_state) <parser_state>: Add
2286         parameters.  Initialize new members.
2287         <expression_context_block, expression_context_pc>: New members.
2288         * parse.c (expression_context_block, expression_context_pc):
2289         Remove globals.
2290         (parse_exp_in_context): Update.
2291         * p-exp.y: Update all rules.
2292         (yylex): Update.
2293         * m2-exp.y: Update all rules.
2294         (yylex): Update.
2295         * go-exp.y (yylex): Update.
2296         * f-exp.y (yylex): Update.
2297         * d-exp.y: Update all rules.
2298         (yylex): Update.
2299         * c-exp.y: Update all rules.
2300         (lex_one_token, classify_name, yylex, c_parse): Update.
2301         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2302
2303 2019-04-04  Tom Tromey  <tom@tromey.com>
2304
2305         * gdbarch.h, gdbarch.c: Rebuild.
2306         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2307         * stap-probe.h:
2308         (struct stap_parse_info): Replace "parser_state" with
2309         "expr_builder".
2310         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2311         (parser_state): New class.
2312         * parse.c (expr_builder): Rename.
2313         (expr_builder::release): Rename.
2314         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2315         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2316         (write_exp_elt_longcst, write_exp_elt_floatcst)
2317         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2318         (write_exp_string_vector, write_exp_bitstring)
2319         (write_exp_msymbol, mark_struct_expression)
2320         (write_dollar_variable)
2321         (insert_type_address_space, increase_expout_size): Replace
2322         "parser_state" with "expr_builder".
2323         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2324         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2325         "parser_state" with "expr_builder".
2326
2327 2019-04-04  Tom Tromey  <tom@tromey.com>
2328
2329         * rust-exp.y: Replace "parse_language" with method call.
2330         * p-exp.y:
2331         (yylex): Replace "parse_language" with method call.
2332         * m2-exp.y:
2333         (yylex): Replace "parse_language" with method call.
2334         * go-exp.y (classify_name): Replace "parse_language" with method
2335         call.
2336         * f-exp.y (yylex): Replace "parse_language" with method call.
2337         * d-exp.y (lex_one_token): Replace "parse_language" with method
2338         call.
2339         * c-exp.y:
2340         (lex_one_token, classify_name, yylex): Replace "parse_language"
2341         with method call.
2342         * ada-exp.y (find_primitive_type, type_char)
2343         (type_system_address): Replace "parse_language" with method call.
2344
2345 2019-04-04  Tom Tromey  <tom@tromey.com>
2346
2347         * rust-exp.y: Replace "parse_gdbarch" with method call.
2348         * parse.c (write_dollar_variable, insert_type_address_space):
2349         Replace "parse_gdbarch" with method call.
2350         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2351         call.
2352         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2353         call.
2354         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2355         "parse_gdbarch" with method call.
2356         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2357         with method call.
2358         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2359         "parse_gdbarch" with method call.
2360         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2361         "parse_gdbarch" with method call.
2362         * c-exp.y (parse_type, parse_number, classify_name): Replace
2363         "parse_gdbarch" with method call.
2364         * ada-lex.l: Replace "parse_gdbarch" with method call.
2365         * ada-exp.y (parse_type, find_primitive_type, type_char)
2366         (type_system_address): Replace "parse_gdbarch" with method call.
2367
2368 2019-04-04  Tom Tromey  <tom@tromey.com>
2369
2370         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2371         * stap-probe.c (stap_parse_argument): Update.
2372         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2373         initial_size parameter.
2374         * rust-exp.y (rust_lex_tests): Update.
2375         * parse.c (parser_state): Update.
2376         (parse_exp_in_context): Update.
2377         * parser-defs.h (struct parser_state) <parser_state>: Remove
2378         "initial_size" parameter.
2379
2380 2019-04-04  Tom Tromey  <tom@tromey.com>
2381
2382         * parser-defs.h (increase_expout_size): Don't declare.
2383         * parse.c (increase_expout_size): Now static.
2384
2385 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2386
2387         * gnu-nat.c (gnu_nat_target::wait): Fix
2388         target_waitstatus_to_string call.
2389
2390 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * eval.c (evaluate_subexp_standard): Handle internal functions
2393         during Fortran function call handling.
2394
2395 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * NEWS: Mention new internal functions.
2398         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2399         (read_base_type): Use dwarf2_init_complex_target_type.
2400         * value.c (creal_internal_fn): New function.
2401         (cimag_internal_fn): New function.
2402         (_initialize_values): Register new internal functions.
2403
2404 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2405
2406         * infrun.c (stop_all_threads): If debug_infrun, always
2407         trace the wait status after wait_one, using
2408         target_waitstatus_to_string and target_pid_to_str.
2409         (handle_inferior_event): Replace various trace of
2410         wait status kind by a single trace.
2411         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2412         wait status kind image by target_waitstatus_to_string.
2413         * target/waitstatus.c (target_waitstatus_to_string): Fix
2414         obsolete comment.
2415
2416 2019-04-01  Tom Tromey  <tromey@adacore.com>
2417
2418         PR symtab/23331:
2419         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2420
2421 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2422             Pedro Alves  <palves@redhat.com>
2423
2424         * top.c (quit_force): Call 'finalize_values'.
2425         * value.c (finalize_values): New function.
2426         * value.h (finalize_values): Declare.
2427
2428 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2429
2430         * NEWS: Announce $_gdb_major and $_gdb_minor.
2431
2432         * top.c (init_gdb_version_vars): New function.
2433         (gdb_init): Call init_gdb_version_vars.
2434
2435 2019-03-29  Tom Tromey  <tromey@adacore.com>
2436
2437         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2438         help text.  Remove dead code.
2439
2440 2019-03-29  Keith Seitz  <keiths@redhat.com>
2441
2442         From Siddhesh Poyarekar:
2443         * f-lang.h (f77_get_upperbound): Return LONGEST.
2444         (f77_get_lowerbound): Likewise.
2445         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2446         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2447         print them.
2448         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2449         plongest to format print it.
2450         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2451         (f77_get_upperbound): Likewise.
2452         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2453         LOWER_BOUND to LONGEST.
2454         (f77_create_arrayprint_offset_tbl): Likewise.
2455
2456 2019-03-29  Keith Seitz  <keiths@redhat.com>
2457
2458         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2459         %s/pulongest for TYPE_LENGTH instead of %d in format
2460         strings.
2461         * ada-typerint.c (ada_print_type): Likewise.
2462         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2463         * compile/compile-c-support.c (generate_register_struct): Likewise.
2464         * gdbtypes.c (recursive_dump_type): Likewise.
2465         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2466         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2467         instead of %d in format strings.
2468         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2469         to std::min to ULONGEST.
2470         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2471         instead of %d in format strings.
2472         * tracepoint.c (info_scope_command): Likewise.
2473         * typeprint.c (print_offset_data::update)
2474         (print_offset_data::finish): Likewise.
2475         * xtensa-tdep.c (xtensa_store_return_value)
2476         (xtensa_push_dummy_call): Likewise.
2477
2478 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2479
2480         * windows-nat.c (display_selector): Fixed format specifications
2481         for 64-bit Cygwin.
2482
2483 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2484
2485         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2486
2487 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2488
2489         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2490         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2491         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2492         (nios2_linux_init_abi): Install it.
2493
2494 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2495
2496         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2497
2498 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2499
2500         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2501
2502 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2503             Tom Tromey  <tromey@adacore.com>
2504
2505         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2506
2507 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2508
2509         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2510         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2511         method to compute the bounds of range types. Also print "[evaluated]"
2512         if the bounds' values come from a dynamic evaluation.
2513
2514 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2517         whitespace when pretty printing is on.
2518
2519 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * ppc-linux-nat.c: Add include.
2522
2523 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2524
2525         * NEWS: Mention AArch64 Pointer Authentication.
2526
2527 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2528
2529         * arm-linux-nat.c: Add include.
2530
2531 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2532
2533         * source-cache.c (source_cache::get_source_lines): Re-read
2534         fullname after calling open_source_file.
2535
2536 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2537
2538         * NEWS: Mention TLS support for FreeBSD.
2539
2540 2019-03-25  Tom Tromey  <tromey@adacore.com>
2541
2542         * minsyms.c (BUNCH_SIZE): Update comment.
2543         (~minimal_symbol_reader): Remove old comment.
2544         (compact_minimal_symbols): Update comment.
2545         (minimal_symbol_reader::install): Remove old comment.  Update
2546         other comments.
2547
2548 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2549
2550         * s390-linux-nat.c: Add include.
2551
2552 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2553
2554         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2555         Call linux_get_hwcap.
2556         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2557         Likewise.
2558         (aarch64_linux_get_hwcap): Remove function.
2559         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2560         declaration.
2561         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2562         linux_get_hwcap.
2563         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2564         * linux-tdep.c (linux_get_hwcap): Add function.
2565         (linux_get_hwcap2): Likewise.
2566         * linux-tdep.h (linux_get_hwcap): Add declaration.
2567         (linux_get_hwcap2): Likewise.
2568         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2569         (ppc_linux_get_hwcap2): Likewise.
2570         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2571         linux_get_hwcap.
2572         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2573         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2574         (ppc_linux_nat_target::read_description): Likewise.
2575         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2576         * s390-linux-nat.c: Likewise.
2577         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2578
2579 2019-03-24  Tom Tromey  <tom@tromey.com>
2580
2581         * ada-lang.c (standard_lookup): Simplify initialization.
2582         (ada_lookup_symbol_nonlocal): Simplify return.
2583         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2584         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2585         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2586         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2587         initialization.
2588         * solib.c (solib_global_lookup): Simplify.
2589         * symtab.c (null_block_symbol): Remove.
2590         (symbol_cache_lookup): Simplify returns.
2591         (lookup_language_this): Simplify returns.
2592         (lookup_symbol_aux): Simplify return.
2593         (lookup_local_symbol): Simplify returns.
2594         (lookup_global_symbol_from_objfile): Simplify return.
2595         (lookup_symbol_in_objfile_symtabs)
2596         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2597         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2598         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2599         * cp-namespace.c (cp_lookup_bare_symbol)
2600         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2601         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2602         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2603         (cp_lookup_symbol_via_imports): Simplify initialization.
2604         (find_symbol_in_baseclass): Likewise.
2605         * symtab.h (null_block_symbol): Remove.
2606         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2607         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2608         (d_lookup_symbol_module): Likewise.
2609         (find_symbol_in_baseclass): Simplify initialization.
2610
2611 2019-03-24  Tom Tromey  <tom@tromey.com>
2612
2613         * expression.h: Don't include symtab.h.
2614         (struct block): Forward declare.
2615
2616 2019-03-24  Tom Tromey  <tom@tromey.com>
2617
2618         * c-exp.y (typebase): Remove casts.
2619         * gdbtypes.c (lookup_unsigned_typename, )
2620         (lookup_signed_typename): Remove cast.
2621         * eval.c (parse_to_comma_and_eval): Remove cast.
2622         * parse.c (write_dollar_variable): Remove cast.
2623         * block.h (struct block) <superblock>: Now const.
2624         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2625         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2626         (map_block): Make "block" const.
2627         * symfile.h (struct quick_symbol_functions)
2628         <map_matching_symbols>: Constify block argument to "callback".
2629         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2630         const.
2631         (find_pc_sect_compunit_symtab): Make "b" const.
2632         (find_symbol_at_address): Likewise.
2633         (search_symbols): Likewise.
2634         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2635         (dw2_debug_names_lookup_symbol): Likewise.
2636         (dw2_map_matching_symbols): Update.
2637         * p-valprint.c (pascal_val_print): Remove "block".
2638         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2639         (aux_add_nonlocal_symbols): Make "block" const.
2640         (resolve_subexp): Remove cast.
2641         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2642         const.
2643         (iterate_over_file_blocks): Likewise.
2644         * f-exp.y (%union) <bval>: Remove.
2645         * coffread.c (patch_opaque_types): Make "b" const.
2646         * spu-tdep.c (spu_catch_start): Make "block" const.
2647         * c-valprint.c (print_unpacked_pointer): Remove "block".
2648         * symmisc.c (dump_symtab_1): Make "b" const.
2649         (block_depth): Make "block" const.
2650         * d-exp.y (%union) <bval>: Remove.
2651         * cp-support.h (cp_lookup_rtti_type): Update.
2652         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2653         * psymtab.c (psym_lookup_symbol): Make "block" const.
2654         (maintenance_check_psymtabs): Make "b" const.
2655         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2656         (enumerate_locals, enumerate_args): Update.
2657         * python/py-symtab.c (stpy_global_block): Make "block" const.
2658         (stpy_static_block): Likewise.
2659         * inline-frame.c (block_starting_point_at): Make "new_block"
2660         const.
2661         * block.c (find_block_in_blockvector): Make return type const.
2662         (blockvector_for_pc_sect): Make "b" const.
2663         (find_block_in_blockvector): Make "b" const.
2664
2665 2019-03-23  Tom Tromey  <tom@tromey.com>
2666
2667         * varobj.c (varobj_create): Update.
2668         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2669         * printcmd.c (display_command, do_one_display): Don't reset
2670         innermost_block.
2671         * parser-defs.h (enum innermost_block_tracker_type): Move to
2672         expression.h.
2673         (innermost_block): Update comment.
2674         * parse.c (parse_exp_1): Add tracker_types parameter.
2675         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2676         tracker_types parameter.  Reset innermost_block.
2677         (parse_exp_in_context): Remove.
2678         (parse_expression_for_completion): Update.
2679         * objfiles.c (~objfile): Don't reset expression_context_block or
2680         innermost_block.
2681         * expression.h (enum innermost_block_tracker_type): Move from
2682         parser-defs.h.
2683         (parse_exp_1): Add tracker_types parameter.
2684         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2685         reset innermost_block.
2686
2687 2019-03-23  Tom Tromey  <tom@tromey.com>
2688
2689         * objfiles.h: Include bcache.h.
2690
2691 2019-03-23  Tom Tromey  <tom@tromey.com>
2692
2693         * linespec.c (get_current_search_block): Use
2694         scoped_restore_current_language.
2695         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2696
2697 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2698             Jiong Wang  <jiong.wang@arm.com>
2699
2700         * aarch64-linux-tdep.c
2701         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2702         section.
2703         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2704
2705 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2706             Jiong Wang  <jiong.wang@arm.com>
2707
2708         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2709         instructions.
2710         (aarch64_analyze_prologue_test): Add PACIASP test.
2711         (aarch64_prologue_prev_register): Unmask PC value.
2712
2713 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2714             Jiong Wang  <jiong.wang@arm.com>
2715
2716         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2717         (aarch64_dwarf2_prev_register): Unmask PC value.
2718         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2719         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2720         DW_CFA_AARCH64_negate_ra_state.
2721         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2722
2723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2724             Jiong Wang  <jiong.wang@arm.com>
2725
2726         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2727         registers.
2728         (aarch64_pseudo_register_name): Likewise.
2729         (aarch64_pseudo_register_type): Likewise.
2730         (aarch64_pseudo_register_reggroup_p): Likewise.
2731         (aarch64_gdbarch_init): Add pauth registers.
2732         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2733         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2734         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2735         (struct gdbarch_tdep): Add regnum for ra_state.
2736
2737 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2738             Jiong Wang  <jiong.wang@arm.com>
2739
2740         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2741
2742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2743             Jiong Wang  <jiong.wang@arm.com>
2744
2745         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2746         function.
2747         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2748         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2749         (aarch64_gdbarch_init): Add puth registers.
2750         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2751         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2752         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2753
2754 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2755             Jiong Wang  <jiong.wang@arm.com>
2756
2757         * aarch64-linux-nat.c
2758         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2759         * aarch64-linux-tdep.c
2760         (aarch64_linux_core_read_description): Likewise.
2761         (aarch64_linux_get_hwcap): New function.
2762         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2763         (aarch64_linux_get_hwcap): New declaration.
2764
2765 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2766             Jiong Wang  <jiong.wang@arm.com>
2767
2768         * aarch64-linux-nat.c
2769         (aarch64_linux_nat_target::read_description): Add pauth param.
2770         * aarch64-linux-tdep.c
2771         (aarch64_linux_core_read_description): Likewise.
2772         * aarch64-tdep.c (struct target_desc): Add in pauth.
2773         (aarch64_read_description): Add pauth param.
2774         (aarch64_gdbarch_init): Likewise.
2775         * aarch64-tdep.h (aarch64_read_description): Likewise.
2776         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2777         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2778         * features/Makefile: Add new files.
2779         * features/aarch64-pauth.c: New file.
2780         * features/aarch64-pauth.xml: New file.
2781
2782 2019-03-20  Tom Tromey  <tromey@adacore.com>
2783
2784         * infrun.c (handle_inferior_event): Rename from
2785         handle_inferior_event_1.  Create a scoped_value_mark.
2786         (handle_inferior_event): Remove.
2787
2788 2019-03-19  Tom Tromey  <tromey@adacore.com>
2789
2790         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2791         * infrun.h (print_stop_event): Add "displays" parameter.
2792         * infrun.c (print_stop_event): Add "displays" parameter.
2793
2794 2019-03-19  Pedro Alves  <palves@redhat.com>
2795
2796         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2797         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2798         to -1.  Fix TABs vs spaces.
2799         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2800         * tui/tui-out.h (tui_ui_out) Add intro comments.
2801         <m_line, m_start_of_line>: In-class initialize, and add describing
2802         comment.
2803
2804 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2805
2806         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2807         variable names.
2808         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2809
2810 2019-03-18  Pedro Alves  <palves@redhat.com>
2811             Eli Zaretskii <eliz@gnu.org>
2812
2813         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2814         m_line and m_start_of_line.
2815
2816 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2817
2818         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2819         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2820         it returns a newline.  This fixes a regression in TU mode, whereby
2821         the next line is output on the same screen line as the user input.
2822
2823 2019-03-18  Tom Tromey  <tromey@adacore.com>
2824
2825         * minsyms.c (minimal_symbol_reader::install): Remove call to
2826         obstack_blank.
2827
2828 2019-03-18  Pedro Alves  <palves@redhat.com>
2829
2830         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2831         New globals.
2832         (apply_style): New, factored out from ...
2833         (apply_ansi_escape): ... this.  Handle reverse video mode.
2834         (tui_set_reverse_mode): New function.
2835         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2836         * tui/tui-winsource.c (tui_show_source_line): Use
2837         tui_set_reverse_mode instead of setting A_STANDOUT.
2838         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2839         New setter methods.
2840
2841 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2842
2843         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2844         Handle tabs.
2845
2846 2019-03-18  Tom Tromey  <tromey@adacore.com>
2847
2848         * ada-lang.c (empty_array): Add "high" parameter.
2849         (ada_evaluate_subexp): Update.
2850
2851 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2852
2853         * unittests/string_view-selftests.c: Define
2854         _initialize_string_view_selftests unconditionally.
2855
2856 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2857
2858         PR gdb/24350
2859         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2860
2861 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2862
2863         PR gdb/24351
2864         * windows-nat.c (display_selector): Fix format specifiers.
2865
2866 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2867
2868         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2869         tui_refill_source_window instead of tui_refresh_win, to update the
2870         current execution line.  This fixes redisplay of the current line
2871         when stepping through the code with "next" or "step".
2872
2873 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2874
2875         * source-cache.c (source_cache::get_source_lines): Call
2876         find_source_lines to initialize s->nlines.  This fixes vertical
2877         scrolling of TUI source window when the DOWN arrow is pressed.
2878
2879 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2880
2881         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2882         linux-thread-db.c (_initialize_thread_db): Likewise.
2883
2884 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2885
2886         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2887         wclrtoeol in tui_show_source_line".  This reverts changes made in
2888         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2889
2890 2019-03-15  Tom Tromey  <tom@tromey.com>
2891
2892         * symtab.h (struct minimal_symbol): Derive from
2893         general_symbol_info.
2894         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2895         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2896         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2897         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2898         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2899         (MSYMBOL_SEARCH_NAME): Update.
2900         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2901         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2902         * minsyms.c (minimal_symbol_reader::record_full): Update.
2903
2904 2019-03-15  Tom Tromey  <tom@tromey.com>
2905
2906         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2907
2908 2019-03-15  Tom Tromey  <tom@tromey.com>
2909
2910         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2911         unique_xmalloc_ptr.
2912         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2913         Update.
2914         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2915         (build_minimal_symbol_hash_tables)
2916         (minimal_symbol_reader::install): Update.
2917
2918 2019-03-15  Tom Tromey  <tom@tromey.com>
2919
2920         * symtab.c (create_demangled_names_hash): Update.
2921         (symbol_set_names): Update.
2922         * objfiles.h (struct objfile_per_bfd_storage)
2923         <demangled_names_hash>: Now an htab_up.
2924         * objfiles.c (objfile_per_bfd_storage): Simplify.
2925
2926 2019-03-15  Tom Tromey  <tom@tromey.com>
2927
2928         * objfiles.h (struct objfile_per_bfd_storage): Declare
2929         destructor.
2930         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2931         New.
2932         (get_objfile_bfd_data): Use new.  Don't initialize
2933         language_of_main.
2934         (free_objfile_per_bfd_storage): Remove.
2935         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2936
2937 2019-03-15  Tom Tromey  <tom@tromey.com>
2938
2939         * symfile.c (reread_symbols): Update.
2940         * objfiles.c (objfile::objfile): Update.
2941         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2942         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2943         comment.
2944         (minimal_symbol_reader::install): Update.
2945         (terminate_minimal_symbol_table): Remove.
2946         * jit.c (jit_object_close_impl): Update.
2947
2948 2019-03-15  Tom Tromey  <tom@tromey.com>
2949
2950         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2951         initializations.
2952
2953 2019-03-15  Tom Tromey  <tom@tromey.com>
2954
2955         * objfiles.h (struct objfile_per_bfd_storage)
2956         <demangled_hash_languages>: Now a bitset.
2957         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2958         (lookup_minimal_symbol): Update.
2959
2960 2019-03-15  Tom Tromey  <tom@tromey.com>
2961
2962         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2963         Don't return the symbol.
2964         * coffread.c (record_minimal_symbol): Use record_full.
2965
2966 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2967
2968         The MS-Windows port of ncurses fails to switch to a color pair if
2969         one or both of the colors are the implicit default colors.  This
2970         change records the default colors when TUI is initialized, and
2971         then specifies them explicitly when a color pair uses the default
2972         colors.  This allows color styling in TUI mode on MS-Windows.
2973
2974         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2975         ncurses_norm_attr.
2976         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2977         colors in ncurses_norm_attr.
2978         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2979         "none", replace it with the default color recorded in
2980         ncurses_norm_attr.
2981
2982 2019-03-14  Tom Tromey  <tromey@adacore.com>
2983
2984         * source-cache.h (class source_cache) <get_source_lines>: Return
2985         std::string.
2986         * source-cache.c (source_cache::extract_lines): Handle case where
2987         first_pos==npos.  Return std::string.
2988         (source_cache::get_source_lines): Update.
2989
2990 2019-03-14  Tom Tromey  <tromey@adacore.com>
2991
2992         * NEWS: Add item for "style sources" commands.
2993         * source-cache.c (source_cache::get_source_lines): Check
2994         source_styling.
2995         * cli/cli-style.c (source_styling): New global.
2996         (_initialize_cli_style): Add "style sources" commands.
2997         (show_style_sources): New function.
2998         * cli/cli-style.h (source_styling): Declare.
2999
3000 2019-03-14  Pedro Alves  <palves@redhat.com>
3001             Tom Tromey  <tromey@adacore.com>
3002
3003         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3004         * tui/tui-winsource.c (tui_refill_source_window): New function,
3005         from...
3006         (tui_horizontal_source_scroll): ... here.  Move some logic.
3007         * cli/cli-style.c (set_style_enabled): Notify new observable.
3008         * tui/tui-hooks.c (tui_redisplay_source): New function.
3009         (tui_attach_detach_observers): Attach or detach
3010         tui_redisplay_source.
3011         * observable.h (source_styling_changed): New observable.
3012         * observable.c: Define source_styling_changed observable.
3013
3014 2019-03-13  Tom Tromey  <tromey@adacore.com>
3015
3016         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3017         (i386_gnu_nat_target::store_registers): Update.
3018         * target-debug.h (target_debug_print_std_string): New macro.
3019         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3020         * windows-tdep.c (display_one_tib): Update.
3021         * tui/tui-stack.c (tui_make_status_line): Update.
3022         * top.c (print_inferior_quit_action): Update.
3023         * thread.c (thr_try_catch_cmd): Update.
3024         (add_thread_with_info): Update.
3025         (thread_target_id_str): Update.
3026         (thr_try_catch_cmd): Update.
3027         (thread_command): Update.
3028         (thread_find_command): Update.
3029         * record-btrace.c (record_btrace_target::info_record)
3030         (record_btrace_resume_thread, record_btrace_target::resume)
3031         (record_btrace_cancel_resume, record_btrace_step_thread)
3032         (record_btrace_target::wait, record_btrace_target::wait)
3033         (record_btrace_target::wait, record_btrace_target::stop): Update.
3034         * progspace.c (print_program_space): Update.
3035         * process-stratum-target.c
3036         (process_stratum_target::thread_address_space): Update.
3037         * linux-fork.c (linux_fork_mourn_inferior)
3038         (detach_checkpoint_command, info_checkpoints_command)
3039         (linux_fork_context): Update.
3040         (linux_fork_detach): Update.
3041         (class scoped_switch_fork_info): Update.
3042         (delete_checkpoint_command): Update.
3043         * infrun.c (follow_fork_inferior): Update.
3044         (follow_fork_inferior): Update.
3045         (proceed_after_vfork_done): Update.
3046         (handle_vfork_child_exec_or_exit): Update.
3047         (follow_exec): Update.
3048         (displaced_step_prepare_throw): Update.
3049         (displaced_step_restore): Update.
3050         (start_step_over): Update.
3051         (resume_1): Update.
3052         (clear_proceed_status_thread): Update.
3053         (proceed): Update.
3054         (print_target_wait_results): Update.
3055         (do_target_wait): Update.
3056         (context_switch): Update.
3057         (stop_all_threads): Update.
3058         (restart_threads): Update.
3059         (finish_step_over): Update.
3060         (handle_signal_stop): Update.
3061         (switch_back_to_stepped_thread): Update.
3062         (keep_going_pass_signal): Update.
3063         (print_exited_reason): Update.
3064         (normal_stop): Update.
3065         * inferior.c (inferior_pid_to_str): Change return type.
3066         (print_selected_inferior): Update.
3067         (add_inferior): Update.
3068         (detach_inferior): Update.
3069         * dummy-frame.c (fprint_dummy_frames): Update.
3070         * dcache.c (dcache_info_1): Update.
3071         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3072         (btrace_fetch, btrace_clear): Update.
3073         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3074         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3075         type.
3076         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3077         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3078         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3079         * gdbarch.c, gdbarch.h: Rebuild.
3080         * gdbarch.sh (core_pid_to_str): Change return type.
3081         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3082         return type.
3083         (windows_nat_target::pid_to_str): Change return type.
3084         (windows_delete_thread): Update.
3085         (windows_nat_target::attach): Update.
3086         (windows_nat_target::files_info): Update.
3087         * target-delegates.c: Rebuild.
3088         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3089         return type.
3090         (sol_thread_target::pid_to_str): Change return type.
3091         * remote.c (class remote_target) <pid_to_str>: Change return
3092         type.
3093         (remote_target::pid_to_str): Change return type.
3094         (extended_remote_target::attach, remote_target::remote_stop_ns)
3095         (remote_target::remote_notif_remove_queued_reply)
3096         (remote_target::push_stop_reply, remote_target::disable_btrace):
3097         Update.
3098         (extended_remote_target::attach): Update.
3099         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3100         type.
3101         (gdbsim_target::pid_to_str): Change return type.
3102         * ravenscar-thread.c (struct ravenscar_thread_target)
3103         <pid_to_str>: Change return type.
3104         (ravenscar_thread_target::pid_to_str): Change return type.
3105         * procfs.c (class procfs_target) <pid_to_str>: Change return
3106         type.
3107         (procfs_target::pid_to_str): Change return type.
3108         (procfs_target::attach): Update.
3109         (procfs_target::detach): Update.
3110         (procfs_target::fetch_registers): Update.
3111         (procfs_target::store_registers): Update.
3112         (procfs_target::wait): Update.
3113         (procfs_target::files_info): Update.
3114         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3115         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3116         return type.
3117         (nto_procfs_target::pid_to_str): Change return type.
3118         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3119         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3120         return type.
3121         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3122         (exit_lwp): Update.
3123         (attach_proc_task_lwp_callback, get_detach_signal)
3124         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3125         (linux_nat_target::resume, wait_lwp, stop_callback)
3126         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3127         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3128         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3129         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3130         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3131         type.
3132         (inf_ptrace_target::attach): Update.
3133         (inf_ptrace_target::files_info): Update.
3134         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3135         type.
3136         (go32_nat_target::pid_to_str): Change return type.
3137         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3138         (gnu_nat_target::wait): Update.
3139         (gnu_nat_target::wait): Update.
3140         (gnu_nat_target::resume): Update.
3141         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3142         (fbsd_nat_target::wait): Update.
3143         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3144         type.
3145         (darwin_nat_target::attach): Update.
3146         * corelow.c (class core_target) <pid_to_str>: Change return type.
3147         (core_target::pid_to_str): Change return type.
3148         * target.c (normal_pid_to_str): Change return type.
3149         (default_pid_to_str): Likewise.
3150         (target_pid_to_str): Change return type.
3151         (target_translate_tls_address): Update.
3152         (target_announce_detach): Update.
3153         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3154         return type.
3155         (bsd_uthread_target::pid_to_str): Change return type.
3156         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3157         type.
3158         (bsd_kvm_target::pid_to_str): Change return type.
3159         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3160         return type.
3161         (aix_thread_target::pid_to_str): Change return type.
3162         * target.h (struct target_ops) <pid_to_str>: Change return type.
3163         (target_pid_to_str, normal_pid_to_str): Likewise.
3164         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3165         type.
3166         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3167         type.
3168         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3169         return type.
3170         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3171         type.
3172         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3173         type.
3174         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3175         return type.
3176
3177 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3178
3179         * NEWS: Mention that the new default MI version is 3.  Mention
3180         changes to the output of commands and events that deal with
3181         multi-location breakpoints.
3182         * breakpoint.c: Include "mi/mi-out.h".
3183         (print_one_breakpoint): Change output syntax if using MI version
3184         >= 3.
3185         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3186         New.
3187         (mi_multi_location_breakpoint_output_fixed): New.
3188         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3189         (mi_cmd_fix_multi_location_breakpoint_output): New.
3190         (mi_multi_location_breakpoint_output_fixed): New.
3191         * mi/mi-cmds.c (mi_cmds): Register command
3192         -fix-multi-location-breakpoint-output.
3193         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3194         interpreter "mi".
3195
3196 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3197
3198         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3199         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3200         instantiate mi_ui_out based on interpreter name.
3201         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3202         * mi/mi-main.c (mi_load_progress): Likewise.
3203
3204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3205
3206         * NEWS: Combine separate "New targets" sections for 8.3.
3207
3208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3209
3210         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3211         (ppcfbsd_init_abi): Install gdbarch
3212         "fetch_tls_load_module_address" and "get_thread_local_address"
3213         methods.
3214
3215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3216
3217         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3218         (riscv_fbsd_init_abi): Install gdbarch
3219         "fetch_tls_load_module_address" and "get_thread_local_address"
3220         methods.
3221
3222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3223
3224         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3225         (i386fbsd_init_abi): Install gdbarch
3226         "fetch_tls_load_module_address" and "get_thread_local_address"
3227         methods.
3228
3229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3230
3231         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3232         (amd64fbsd_init_abi): Install gdbarch
3233         "fetch_tls_load_module_address" and "get_thread_local_address"
3234         methods.
3235
3236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3237
3238         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3239         (struct fbsd_pspace_data): New type.
3240         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3241         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3242         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3243         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3244         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3245
3246 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3247
3248         * gdbtypes.c (lookup_struct_elt): New function.
3249         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3250         * gdbtypes.h (struct struct_elt): New type.
3251         (lookup_struct_elt): New prototype.
3252
3253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3254
3255         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3256         remove disabled code block.
3257
3258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3259
3260         * gdbarch.sh (get_thread_local_address): New method.
3261         * gdbarch.h, gdbarch.c: Regenerate.
3262         * target.c (target_translate_tls_address): Use
3263         gdbarch_get_thread_local_address if present instead of
3264         target::get_thread_local_address.
3265
3266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3267
3268         * target.h (target::get_thread_local_address): Update comment.
3269
3270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3271
3272         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3273         objfile->separate_debug_objfile_backlink if not NULL.
3274
3275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3276
3277         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3278         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3279         (amd64bsd_store_inferior_registers): Likewise.
3280         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3281         Enable segment base registers.
3282         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3283         PT_GETFSBASE and PT_GETGSBASE.
3284         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3285         PT_SETGSBASE.
3286         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3287         segment base registers.
3288         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3289
3290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3291
3292         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3293         Update calls to i386_target_description to add 'segments'
3294         parameter.
3295         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3296         add segment base registers.
3297         * arch/i386.c (i386_create_target_description): Add 'segments'
3298         parameter to enable segment base registers.
3299         * arch/i386.h (i386_create_target_description): Likewise.
3300         * features/i386/32bit-segments.xml: New file.
3301         * features/i386/32bit-segments.c: Generate.
3302         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3303         call to i386_target_description to add 'segments' parameter.
3304         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3305         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3306         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3307         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3308         if feature is present.
3309         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3310         Add 'segments' parameter to call to i386_target_description.
3311         (i386_target_description): Add 'segments' parameter to enable
3312         segment base registers.
3313         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3314         to call to i386_target_description.
3315         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3316         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3317         Define I386_NUM_REGS.
3318         (i386_target_description): Add 'segments' parameter to enable
3319         segment base registers.
3320
3321 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3322
3323         PR/24325
3324         * source-cache.c: #undef open and close, to avoid unresolved
3325         externals during linking.
3326
3327 2019-03-12  Tom Tromey  <tromey@adacore.com>
3328
3329         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3330         const.  Add initializers.
3331         (_initialize_remote): Don't initialize ptid globals.
3332
3333 2019-03-12  Pedro Alves  <palves@redhat.com>
3334
3335         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3336
3337 2019-03-12  Pedro Alves  <palves@redhat.com>
3338
3339         * cp-name-parser.y (main): Remove unused 'len' variable.
3340
3341 2019-03-12  Tom Tromey  <tromey@adacore.com>
3342
3343         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3344         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3345
3346 2019-03-12  Tom Tromey  <tromey@adacore.com>
3347
3348         * linux-nat.c (iterate_over_lwps): Update.
3349         (stop_callback): Remove parameter.
3350         (stop_wait_callback, detach_callback, resume_set_callback)
3351         (select_singlestep_lwp_callback, set_ignore_sigint)
3352         (status_callback, resumed_callback, resume_clear_callback)
3353         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3354         data parameter.
3355         (linux_nat_target::detach, linux_nat_target::resume)
3356         (linux_stop_and_wait_all_lwps, select_event_lwp)
3357         (linux_nat_filter_event, linux_nat_wait_1)
3358         (linux_nat_target::kill, linux_nat_target::stop)
3359         (linux_nat_target::stop): Update.
3360         (linux_nat_resume_callback): Change type.
3361         (resume_stopped_resumed_lwps, count_events_callback)
3362         (select_event_lwp_callback): Likewise.
3363         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3364         * arm-linux-nat.c (struct update_registers_data): Remove.
3365         (update_registers_callback): Change type.
3366         (arm_linux_insert_hw_breakpoint1): Update.
3367         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3368         parameter.
3369         (x86_linux_dr_set_addr): Update.
3370         (x86_linux_dr_set_control): Update.
3371         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3372         (iterate_over_lwps): Use gdb::function_view.
3373         * nat/aarch64-linux-hw-point.c (struct
3374         aarch64_dr_update_callback_param): Remove.
3375         (debug_reg_change_callback): Change type.
3376         (aarch64_notify_debug_reg_change): Update.
3377         * s390-linux-nat.c (s390_refresh_per_info): Update.
3378
3379 2019-03-11  Tom Tromey  <tromey@adacore.com>
3380
3381         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3382         redundant assignment to "this_cu".
3383
3384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3385
3386         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3387
3388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3389
3390         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3391         from...
3392         (rank_one_type): ... this.
3393
3394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3395
3396         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3397         from...
3398         (rank_one_type): ... this.
3399
3400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3401
3402         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3403         from...
3404         (rank_one_type): ... this.
3405
3406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3407
3408         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3409         from...
3410         (rank_one_type): ... this.
3411
3412 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3413
3414         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3415         from...
3416         (rank_one_type): ... this.
3417
3418 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3419
3420         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3421         from...
3422         (rank_one_type): ... this.
3423
3424 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3425
3426         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3427         from...
3428         (rank_one_type): ... this.
3429
3430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3431
3432         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3433         from...
3434         (rank_one_type): ... this.
3435
3436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3437
3438         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3439         from...
3440         (rank_one_type): ... this.
3441
3442 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3443
3444         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3445         from...
3446         (rank_one_type): ... this.
3447
3448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3449
3450         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3451         from...
3452         (rank_one_type): ... this.
3453
3454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3455
3456         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3457         from...
3458         (rank_one_type): ... this.
3459
3460 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3461
3462         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3463         inferior-events' shows the example events.
3464
3465 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3466
3467         Support styling on native MS-Windows console
3468
3469         PR/24315
3470         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3471         on MS-Windows if $TERM is not defined.
3472
3473         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3474
3475         * posix-hdep.c (gdb_console_fputs):
3476         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3477         functions.
3478         * ui-file.h (gdb_console_fputs): Add prototype.
3479
3480         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3481         back to fputs only if the former returns zero.
3482
3483 2019-03-07  Tom Tromey  <tom@tromey.com>
3484
3485         * symmisc.c (print_symbol_bcache_statistics): Update.
3486         (print_objfile_statistics): Update.
3487         * symfile.c (allocate_symtab): Update.
3488         * stabsread.c: Don't include bcache.h.
3489         * psymtab.h (struct psymbol_bcache): Don't declare.
3490         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3491         (psymbol_bcache_init, psymbol_bcache_free)
3492         (psymbol_bcache_get_bcache): Don't declare.
3493         * psymtab.c (struct psymbol_bcache): Remove.
3494         (psymtab_storage::psymtab_storage): Update.
3495         (psymtab_storage::~psymtab_storage): Update.
3496         (psymbol_bcache_init, psymbol_bcache_free)
3497         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3498         (add_psymbol_to_bcache): Update.
3499         (allocate_psymtab): Update.
3500         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3501         macro_cache>: No longer pointers.
3502         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3503         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3504         * macrotab.c (macro_bcache): Update.
3505         * macroexp.c: Don't include bcache.h.
3506         * gdbtypes.c (check_types_worklist): Update.
3507         (types_deeply_equal): Remove TRY/CATCH.  Update.
3508         * elfread.c (elf_symtab_read): Update.
3509         * dwarf2read.c: Don't include bcache.h.
3510         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3511         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3512         (print_bcache_statistics, bcache_memory_used): Don't declare.
3513         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3514         methods.  Rename all data members.
3515         * bcache.c (struct bcache): Move to bcache.h.
3516         (bcache::expand_hash_table): Rename from expand_hash_table.
3517         (bcache): Remove.
3518         (bcache::insert): Rename from bcache_full.
3519         (bcache::compare): Rename from bcache_compare.
3520         (bcache_xmalloc): Remove.
3521         (bcache::~bcache): Rename from bcache_xfree.
3522         (bcache::print_statistics): Rename from print_bcache_statistics.
3523         (bcache::memory_used): Rename from bcache_memory_used.
3524
3525 2019-03-07  Pedro Alves  <palves@redhat.com>
3526
3527         * infrun.c (normal_stop): Also check for
3528         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3529
3530 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * f-lang.c (value_from_host_double): Moved to...
3533         * value.c (value_from_host_double): ...here.
3534         * value.h (value_from_host_double): Declare.
3535         * guile/scm-math.c (vlscm_convert_typed_number): Use
3536         value_from_host_double.
3537         (vlscm_convert_number): Likewise.
3538         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3539         * python/py-value.c (convert_value_from_python): Likewise.
3540
3541 2019-03-06  Tom Tromey  <tom@tromey.com>
3542
3543         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3544
3545 2019-03-06  Tom Tromey  <tom@tromey.com>
3546
3547         * utils.h (free_current_contents): Don't declare.
3548         * utils.c (free_current_contents): Remove.
3549
3550 2019-03-06  Tom Tromey  <tom@tromey.com>
3551
3552         * top.c (quit_force): Update.
3553         * main.c (captured_command_loop): Update.
3554         * common/new-op.c (operator new): Update.
3555         * common/common-exceptions.c (struct catcher)
3556         <save_cleanup_chain>: Remove member.
3557         (exceptions_state_mc_init): Update.
3558         (exception_try_scope_entry): Return nullptr.
3559         (exception_try_scope_exit, exception_rethrow)
3560         (throw_exception_sjlj, throw_exception_cxx): Update.
3561         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3562         (all_cleanups, do_cleanups, discard_cleanups)
3563         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3564         (restore_cleanups, restore_final_cleanups): Don't declare.
3565         (do_final_cleanups): Remove parameter.
3566         * common/cleanups.c (cleanup_chain, make_cleanup)
3567         (make_cleanup_dtor, all_cleanups, do_cleanups)
3568         (discard_my_cleanups, discard_cleanups)
3569         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3570         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3571         (null_cleanup): Remove.
3572         (do_final_cleanups): Remove parameter.
3573
3574 2019-03-06  Tom Tromey  <tom@tromey.com>
3575
3576         * remote.c (remote_target::remote_parse_stop_reply): Use
3577         unique_xmalloc_ptr.
3578
3579 2019-03-06  Tom Tromey  <tom@tromey.com>
3580
3581         * stabsread.c (struct stabs_field_info): Rename from field_info.
3582         <list, fnlist>: Add initializers.
3583         <obstack>: New member.
3584         (read_member_functions, read_struct_fields, read_baseclasses):
3585         Allocate on obstack.  Don't use cleanups.
3586         (read_one_struct_field, read_member_functions, read_struct_fields)
3587         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3588         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3589         (read_struct_type): Update.
3590
3591 2019-03-06  Tom Tromey  <tom@tromey.com>
3592
3593         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3594         * common/filestuff.h (make_cleanup_close): Don't declare.
3595         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3596         Remove.
3597
3598 2019-03-06  Tom Tromey  <tom@tromey.com>
3599
3600         * solib-aix.c: Use make_scope_exit.
3601
3602 2019-03-06  Tom Tromey  <tom@tromey.com>
3603
3604         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3605         Use make_scope_exit.
3606
3607 2019-03-06  Tom Tromey  <tom@tromey.com>
3608
3609         * solib-svr4.c (disable_probes_interface): Remove parameter.
3610         (svr4_handle_solib_event): Use make_scope_exit.
3611
3612 2019-03-06  Tom Tromey  <tom@tromey.com>
3613
3614         * remote.c (struct stop_reply_deleter): Remove.
3615         (stop_reply_up): Update.
3616         (struct stop_reply): Derive from notif_event.  Don't typedef.
3617         <regcache>: Now a std::vector.
3618         (stop_reply_xfree): Remove.
3619         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3620         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3621         (remote_target::discard_pending_stop_replies): Use delete.
3622         (remote_target::remote_parse_stop_reply): Update.
3623         (remote_target::process_stop_reply): Update.
3624         * remote-notif.h (struct notif_event): Add virtual destructor.
3625         Remove "dtr" member.
3626         (struct notif_client) <alloc_event>: Return a unique_ptr.
3627         (notif_event_xfree): Don't declare.
3628         (notif_event_up): New typedef.
3629         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3630         (notif_event_xfree, do_notif_event_xfree): Remove.
3631         (remote_notif_state_xfree): Update.
3632
3633 2019-03-06  Tom Tromey  <tom@tromey.com>
3634
3635         * infrun.c (displaced_step_clear_cleanup): Now a
3636         forward_scope_exit type.
3637         (displaced_step_prepare_throw): Update.
3638         (displaced_step_fixup): Update.
3639
3640 2019-03-06  Tom Tromey  <tom@tromey.com>
3641
3642         * inferior.h (class inferior): Update comment.
3643         * gdbthread.h (class thread_info): Update comment.
3644
3645 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3646             Tom Tromey  <tom@tromey.com>
3647
3648         * stabsread.h (struct stab_section_list): Remove.
3649         (coffstab_build_psymtabs): Update.
3650         * dbxread.c (symbuf_sections): Now a std::vector.
3651         (sect_idx): New global.
3652         (fill_symbuf): Update.
3653         (coffstab_build_psymtabs): Change type of stabsects parameter.
3654         Update.
3655         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3656         std::vector.
3657         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3658         (coff_locate_sections): Update.
3659         (coff_symfile_read): Remove cleanups.  Update.
3660         (init_stringtab): Add storage parameter.
3661         (free_stringtab, free_stringtab_cleanup): Remove.
3662         (init_lineno): Add storage parameter.
3663         (free_linetab, free_linetab_cleanup): Remove.
3664
3665 2019-03-06  Pedro Alves  <palves@redhat.com>
3666
3667         * linux-fork.c (fork_info::clobber_regs): Delete.
3668         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3669         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3670         comment.  Adjust.
3671         (scoped_switch_fork_info::scoped_switch_fork_info)
3672         (checkpoint_command, linux_fork_context): Adjust
3673         fork_save_infrun_state calls.
3674
3675 2019-03-06  Pedro Alves  <palves@redhat.com>
3676
3677         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3678         (inf_has_multiple_threads): Return 'bool' and rewrite using
3679         inferior_info::threads().
3680
3681 2019-03-06  Pedro Alves  <palves@redhat.com>
3682
3683         * linux-fork.c: Include <list>.
3684         (fork_list): Now a std::list instance.
3685         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3686         (forks_exist_p, find_last_fork): Adjust.
3687         (new_fork): Delete.
3688         (one_fork_p): New.
3689         (add_fork): Adjust.
3690         (free_fork): Delete, folded into fork_info::~fork_info().
3691         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3692         Adjust.
3693         (init_fork_list): Delete.
3694         (linux_fork_killall, linux_fork_mourn_inferior)
3695         (linux_fork_detach, info_checkpoints_command): Adjust.
3696         (_initialize_linux_fork): No longer call init_fork_list.
3697
3698 2019-03-06  Pedro Alves  <palves@redhat.com>
3699
3700         * linux-fork.c (new_fork): New, split out of ...
3701         (add_fork): ... this.  Return void.  Move "first fork" special
3702         case from here, to ...
3703         (checkpoint_command): ... here.
3704         * linux-linux.h (add_fork): Return void.
3705
3706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3709
3710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3711             Chris January  <chris.january@arm.com>
3712             David Lecomber  <david.lecomber@arm.com>
3713
3714         * f-exp.y: New token, UNOP_INTRINSIC.
3715         (exp): New pattern using UNOP_INTRINSIC token.
3716         (f77_keywords): Add 'abs' keyword.
3717         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3718         (value_from_host_double): New function.
3719         (evaluate_subexp_f): Support UNOP_ABS.
3720
3721 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3722
3723         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3724         types.
3725
3726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3729         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3730         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3731
3732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3735
3736 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3737             Chris January  <chris.january@arm.com>
3738
3739         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3740         * f-exp.y: Define 'KIND' token.
3741         (exp): New pattern for KIND expressions.
3742         (ptype): Handle types with a kind extension.
3743         (direct_abs_decl): Extend to spot kind extensions.
3744         (f77_keywords): Add 'kind' to the list.
3745         (push_kind_type): New function.
3746         (convert_to_kind_type): New function.
3747         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3748         * parse.c (operator_length_standard): Likewise.
3749         * parser-defs.h (enum type_pieces): Add tp_kind.
3750         * std-operator.def: Add UNOP_KIND.
3751
3752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * f-exp.y (f_parse): Set yydebug.
3755
3756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3757
3758         * f-lang.c (evaluate_subexp_f): New function.
3759         (exp_descriptor_f): New global.
3760         (f_language_defn): Use exp_descriptor_f instead of
3761         exp_descriptor_standard.
3762
3763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * f-exp.y (struct token): Add comments.
3766         (dot_ops): Remove uppercase versions and the end marker.
3767         (f77_keywords): Likewise.
3768         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3769         entries in the dot_ops array are case insensitive, and use
3770         strncasecmp to compare strings.  Also some whitespace cleanup in
3771         this area.  Similar for the f77_keywords array, except entries in
3772         this list might be case sensitive.
3773
3774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * f-exp.y (struct f77_boolean_val): Add comments.
3777         (boolean_values): Remove uppercase versions, and end marker.
3778         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3779         and use strncasecmp to achieve case insensitivity.  Additionally,
3780         perform whitespace cleanup around this code.
3781
3782 2019-03-06  Tom Tromey  <tromey@adacore.com>
3783
3784         * remote-sim.c (gdbsim_target_open): Use result of
3785         gdb_argv::release.
3786
3787 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3788         Dirk Schubert  <dirk.schubert@arm.com>
3789         Chris January  <chris.january@arm.com>
3790
3791         * eval.c (evaluate_subexp_standard): Call Fortran argument
3792         wrapping logic.
3793         * f-lang.c (struct value): A value which can be passed into a
3794         Fortran function call.
3795         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3796         where appropriate.
3797         (struct type): Value ready for a Fortran function call.
3798         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3799         is needed.
3800         * f-lang.h (fortran_argument_convert): Declaration.
3801         (fortran_preserve_arg_pointer): Declaration.
3802         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3803
3804 2019-03-05  Tom Tromey  <tromey@adacore.com>
3805
3806         * python/py-prettyprint.c (print_string_repr): Remove #if.
3807         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3808
3809 2019-03-05  Tom Tromey  <tromey@adacore.com>
3810
3811         * target.c (the_dummy_target): Move later.  Change type to
3812         "dummy_target".
3813         (initialize_targets): Don't initialize the_dummy_target.
3814
3815 2019-03-05  Tom Tromey  <tromey@adacore.com>
3816
3817         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3818         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3819
3820 2019-03-05  Tom Tromey  <tromey@adacore.com>
3821
3822         * windows-nat.c (windows_nat_target::attach)
3823         (windows_nat_target::detach): Don't call gdb_flush.
3824         * valprint.c (generic_val_print, val_print, val_print_string):
3825         Don't call gdb_flush.
3826         * utils.c (defaulted_query): Don't call gdb_flush.
3827         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3828         * target.c (target_announce_detach): Don't call gdb_flush.
3829         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3830         * remote.c (extended_remote_target::attach): Don't call
3831         gdb_flush.
3832         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3833         * printcmd.c (do_examine): Don't call gdb_flush.
3834         (info_display_command): Don't call gdb_flush.
3835         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3836         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3837         * memattr.c (info_mem_command): Don't call gdb_flush.
3838         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3839         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3840         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3841         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3842         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3843         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3844         (gnu_nat_target::detach): Don't call gdb_flush.
3845         * f-valprint.c (f_val_print): Don't call gdb_flush.
3846         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3847         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3848         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3849         gdb_flush.
3850         * c-valprint.c (c_val_print): Don't call gdb_flush.
3851         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3852
3853 2019-03-05  Tom Tromey  <tromey@adacore.com>
3854
3855         * varobj.c (update_dynamic_varobj_children): Update.
3856         (install_default_visualizer): Use reset, not release.
3857         * value.c (set_internalvar): Update.
3858         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3859         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3860         ATTRIBUTE_UNUSED_RESULT.
3861
3862 2019-03-05  Tom Tromey  <tromey@adacore.com>
3863
3864         * remote.c (class scoped_remote_fd) <release>: Add
3865         ATTRIBUTE_UNUSED_RESULT.
3866
3867 2019-03-05  Tom Tromey  <tromey@adacore.com>
3868
3869         * macroexp.c (struct macro_buffer) <release>: Add
3870         ATTRIBUTE_UNUSED_RESULT.
3871
3872 2019-03-05  Tom Tromey  <tromey@adacore.com>
3873
3874         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3875         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3876         ATTRIBUTE_UNUSED_RESULT.
3877
3878 2019-03-05  Tom Tromey  <tromey@adacore.com>
3879
3880         * common/scoped_fd.h (class scoped_fd) <release>: Add
3881         ATTRIBUTE_UNUSED_RESULT.
3882
3883 2019-03-05  Tom Tromey  <tromey@adacore.com>
3884
3885         * parser-defs.h (struct parser_state) <release>: Add
3886         ATTRIBUTE_UNUSED_RESULT.
3887
3888 2019-03-05  Tom Tromey  <tromey@adacore.com>
3889
3890         * utils.h (class gdb_argv) <release>: Add
3891         ATTRIBUTE_UNUSED_RESULT.
3892         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3893
3894 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3895
3896         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3897         for-loop range, to avoid compiler warnings.
3898
3899         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3900         avoid compiler warnings about unused variables.
3901
3902         * NEWS: Mention end of support for native debugging on MS-Windows
3903         before XP.
3904
3905         PR gdb/24292
3906         * common/netstuff.c:
3907         * gdbserver/gdbreplay.c
3908         * gdbserver/remote-utils.c:
3909         * ser-tcp.c:
3910         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3911         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3912         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3913         'getaddrinfo' and 'freeaddrinfo' were not available before
3914         Windows XP, and mingw.org's MinGW headers by default define
3915         _WIN32_WINNT to 0x500.
3916
3917 2019-03-01  Gary Benson <gbenson@redhat.com>
3918
3919         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3920
3921 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3922             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3923
3924         PR gdb/8527
3925         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3926         set_sigint_trap, clear_sigint_trap.
3927
3928 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * target.c (target_detach): Clear the regcache and the
3931         frame cache.
3932
3933 2019-02-27  Pedro Alves  <palves@redhat.com>
3934
3935         * utils.c (set_screen_size): When we cap the height/width sizes,
3936         tweak the corresponding command variable to show "unlimited":
3937
3938 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3939             Pedro Alves  <palves@redhat.com>
3940
3941         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3942         before calling rl_set_screen_size.
3943
3944 2019-02-27  Tom Tromey  <tromey@adacore.com>
3945
3946         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3947         define.
3948         * python/py-value.c: Remove Python 2.4 workaround.
3949         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3950         workaround.
3951         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3952         Python 2.4 workaround.
3953         * python/python-internal.h: Remove Python 2.4 comment.
3954         (Py_ssize_t): Don't define.
3955         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3956         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3957         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3958         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3959         * python/python.c (do_start_initialization): Remove Python 2.4
3960         workaround.
3961         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3962         (print_children): Remove Python 2.4 workaround.
3963         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3964         workaround.
3965         (CHARBUFFERPROC_NAME): Remove.
3966         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3967         Python 2.4 workaround.
3968
3969 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3970
3971         * NEWS: Note minimum Python version.
3972
3973 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3974
3975         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3976         code from these functions.  Remove corresponding ifdefs.  Use
3977         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3978         Remove gotos and target of gotos.
3979         (infpy_search_memory): Likewise.
3980
3981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3984         (hppa_gdbarch_init): Don't register deleted functions with
3985         gdbarch.
3986
3987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3990         (h8300_unwind_sp): Delete.
3991         (h8300_dummy_id): Delete.
3992         (h8300_gdbarch_init): Don't register deleted functions with
3993         gdbarch.
3994
3995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3998         (ft32_unwind_pc): Delete.
3999         (ft32_unwind_sp): Delete.
4000         (ft32_gdbarch_init): Don't register deleted functions with
4001         gdbarch.
4002
4003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4006         (frv_unwind_pc): Delete.
4007         (frv_unwind_sp): Delete.
4008         (frv_gdbarch_init): Don't register deleted functions with
4009         gdbarch.
4010
4011 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4014         (riscv_unwind_pc): Delete.
4015         (riscv_unwind_sp): Delete.
4016         (riscv_gdbarch_init): Don't register deleted functions with
4017         gdbarch.
4018
4019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4022         (csky_unwind_pc): Delete.
4023         (csky_unwind_sp): Delete.
4024         (csky_gdbarch_init): Don't register deleted functions with
4025         gdbarch.
4026
4027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4030         (cris_unwind_pc): Delete.
4031         (cris_unwind_sp): Delete.
4032         (cris_gdbarch_init): Don't register deleted functions with
4033         gdbarch.
4034
4035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4036
4037         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4038         (bfin_unwind_pc): Delete.
4039         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4040
4041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4042
4043         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4044         (arm_unwind_pc): Delete.
4045         (arm_unwind_sp): Delete.
4046         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4047
4048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4049
4050         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4051         (arc_unwind_pc): Delete.
4052         (arc_unwind_sp): Delete.
4053         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4054
4055 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4058         (alpha_unwind_pc): Delete.
4059         (alpha_gdbarch_init): Don't register deleted functions with
4060         gdbarch.
4061
4062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4063
4064         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4065         (aarch64_unwind_pc): Delete.
4066         (aarch64_unwind_sp): Delete.
4067         (aarch64_gdbarch_init): Don't register deleted functions with
4068         gdbarch.
4069
4070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4071
4072         * gdbtypes.c (type_align): Don't consider static members when
4073         computing structure alignment.
4074
4075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4078         return 0 for other types.
4079         * arch-utils.c (default_type_align): Always return 0.
4080         * gdbarch.h: Regenerate.
4081         * gdbarch.sh (type_align): Extend comment.
4082         * gdbtypes.c (type_align): Add additional comments, always call
4083         gdbarch_type_align before applying the default rules.
4084         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4085         generic code will then apply a suitable default.
4086         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4087         types, return 0 for other types.
4088
4089 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4090
4091         * NEWS: Create a new section for the next release branch.
4092         Rename the section of the current branch, now that it has
4093         been cut.
4094
4095 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4096
4097         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4098         * version.in: Bump version to 8.3.50.DATE-git.
4099
4100 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4101
4102         * aix-thread.c (ptid_cmp): Remove unused variable.
4103         (get_signaled_thread): Likewise.
4104         (store_regs_user_thread): Likewise.
4105         (store_regs_kernel_thread): Likewise.
4106         (fetch_regs_kernel_thread): Remove shadowed variable.
4107
4108 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * features/riscv/32bit-cpu.xml: Add register numbers.
4111         * features/riscv/32bit-fpu.c: Regenerate.
4112         * features/riscv/32bit-fpu.xml: Add register numbers.
4113         * features/riscv/64bit-cpu.xml: Add register numbers.
4114         * features/riscv/64bit-fpu.c: Regenerate.
4115         * features/riscv/64bit-fpu.xml: Add register numbers.
4116
4117 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4118
4119         * NEWS: Mention two argument form of gdb.Value constructor.
4120         * python/py-value.c (convert_buffer_and_type_to_value): New
4121         function.
4122         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4123         Add support for handling an optional second argument.  Call
4124         convert_buffer_and_type_to_value as appropriate.
4125         * python/python-internal.h (Py_buffer_deleter): New struct.
4126         (Py_buffer_up): New typedef.
4127
4128 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4129
4130         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4131         instead of releasing ownership.
4132
4133 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4134
4135         * dwarf2read.c (open_and_init_dwp_file): Call
4136         elf_numsections instead of bfd_count_sections to initialize
4137         dwp_file->num_sections.
4138
4139 2019-02-25  Tom Tromey  <tromey@adacore.com>
4140
4141         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4142
4143 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4144
4145         * gcore.in: Add '--readnever' option when invoking GDB.
4146
4147 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4148
4149         * MAINTAINERS: Update my email address.
4150
4151 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4152
4153         * build-id.c (build_id_to_debug_bfd_1): New function.
4154         (build_id_to_debug_bfd): Look for separate debug file in
4155         sysroot.
4156
4157 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * gdbarch.sh: Update the copyright year range that is placed into
4160         generated files.
4161
4162 2019-02-22  Keith Seitz  <keiths@redhat.com>
4163
4164         PR symtab/23853
4165         * linespec.c (create_sals_line_offset): Search for the default
4166         symtab's filename instead of its fullname.
4167
4168 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4169
4170         * NEWS: Update style defaults.
4171
4172 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4173
4174         * main.c (captured_main_1): Disable styling in batch mode.
4175
4176 2019-02-20  Tom Tromey  <tom@tromey.com>
4177
4178         * symtab.c (symtab_symbol_info): Fix typos.
4179
4180 2019-02-20  Tom Tromey  <tromey@adacore.com>
4181
4182         * findcmd.c (_initialize_mem_search): Use upper case for
4183         metasyntactic variables.
4184
4185 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4186
4187         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4188         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4189
4190 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4191
4192         * top.h (source_file_name): Change to std::string.
4193         * top.c (source_file_name): Likewise.
4194         (command_line_input): Adjust.
4195         * cli/cli-script.c (script_from_file): Adjust.
4196
4197 2019-02-19  Tom Tromey  <tromey@adacore.com>
4198
4199         * ravenscar-thread.c
4200         (ravenscar_thread_target::update_thread_list): Don't call
4201         ada_build_task_list.
4202         * ada-lang.h (ada_build_task_list): Don't declare.
4203         * ada-tasks.c (struct ada_tasks_inferior_data)
4204         <task_list_valid_p>: Now bool.
4205         (read_known_tasks, ada_task_list_changed)
4206         (ada_tasks_invalidate_inferior_data): Update.
4207         (read_known_tasks_array): Return bool.
4208         (read_known_tasks_list): Likewise.
4209         (read_known_tasks): Return void.
4210         (ada_build_task_list): Now static.
4211
4212 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4213
4214         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4215         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4216
4217 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4218
4219         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4220         variant for ada_tasks_pspace_data_handle and
4221         ada_tasks_inferior_data_handle.
4222         (ada_tasks_pspace_data_cleanup): New function.
4223         (ada_tasks_inferior_data_cleanup): New function.
4224
4225 2019-02-17  Tom Tromey  <tom@tromey.com>
4226
4227         * macrotab.h (macro_source_fullname): Return a std::string.
4228         * macrotab.c (macro_include, check_for_redefinition)
4229         (macro_undef, macro_lookup_definition, foreach_macro)
4230         (foreach_macro_in_scope): Update.
4231         (macro_source_fullname): Return a std::string.
4232         * macrocmd.c (show_pp_source_pos): Update.
4233
4234 2019-02-17  Tom Tromey  <tom@tromey.com>
4235
4236         * macrocmd.c (show_pp_source_pos): Style the file names.
4237
4238 2019-02-17  Tom Tromey  <tom@tromey.com>
4239
4240         PR tui/24197:
4241         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4242
4243 2019-02-17  Tom Tromey  <tom@tromey.com>
4244
4245         * ada-lang.c (user_select_syms): Use filtered printing.
4246         * utils.c (wrap_style): New global.
4247         (desired_style): Remove.
4248         (emit_style_escape): Add stream parameter.
4249         (set_output_style, reset_terminal_style, prompt_for_continue):
4250         Update.
4251         (flush_wrap_buffer): Only flush gdb_stdout.
4252         (wrap_here): Set wrap_style.
4253         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4254         treat escape sequences as a character.  Change when wrap buffer is
4255         flushed.
4256         (fputs_styled): Do not set the output style when the default is
4257         requested.
4258         * ui-style.h (struct ui_file_style) <is_default>: New method.
4259         * source.c (print_source_lines_base): Emit escape sequences in one
4260         piece.
4261
4262 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4263
4264         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4265         integers and enumeration types.
4266
4267 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4268
4269         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4270         instead of lookup_symbol_in_language
4271         (do_exact_match): New function.
4272         (ada_get_symbol_name_matcher): Return do_exact_match when
4273         doing a verbatim match.
4274
4275 2019-02-15  Tom Tromey  <tromey@adacore.com>
4276
4277         * ravenscar-thread.c (ravenscar_thread_target::resume)
4278         (ravenscar_thread_target::wait): Special case wildcard requests.
4279
4280 2019-02-15  Tom Tromey  <tromey@adacore.com>
4281
4282         * ravenscar-thread.c (base_ptid): Remove.
4283         (struct ravenscar_thread_target) <close>: New method.
4284         <m_base_ptid>: New member.
4285         <update_inferior_ptid, active_task, task_is_currently_active,
4286         runtime_initialized>: Declare methods.
4287         <ravenscar_thread_target>: Add constructor.
4288         (ravenscar_thread_target::task_is_currently_active)
4289         (ravenscar_thread_target::update_inferior_ptid)
4290         (ravenscar_runtime_initialized): Rename.  Now methods.
4291         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4292         (ravenscar_thread_target::update_thread_list): Update.
4293         (ravenscar_thread_target::active_task): Now method.
4294         (ravenscar_thread_target::store_registers)
4295         (ravenscar_thread_target::prepare_to_store)
4296         (ravenscar_thread_target::prepare_to_store)
4297         (ravenscar_thread_target::mourn_inferior): Update.
4298         (ravenscar_inferior_created): Use "new" to create target.
4299         (ravenscar_thread_target::get_ada_task_ptid): Update.
4300         (_initialize_ravenscar): Don't initialize base_ptid.
4301         (ravenscar_ops): Remove global.
4302
4303 2019-02-15  Tom Tromey  <tromey@adacore.com>
4304
4305         * target.h (push_target): Declare new overload.
4306         * target.c (push_target): New overload, taking an rvalue reference.
4307         * remote.c (remote_target::open_1): Use push_target overload.
4308         * corelow.c (core_target_open): Use push_target overload.
4309
4310 2019-02-15  Tom Tromey  <tromey@adacore.com>
4311
4312         * ravenscar-thread.c (is_ravenscar_task)
4313         (ravenscar_task_is_currently_active): Return bool.
4314         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4315         (_initialize_ravenscar): Remove "(void)".
4316         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4317         Return bool.
4318
4319 2019-02-15  Tom Tromey  <tromey@adacore.com>
4320
4321         * ravenscar-thread.c (ravenscar_runtime_initializer)
4322         (has_ravenscar_runtime, get_running_thread_id)
4323         (ravenscar_thread_target::resume): Fix indentation.
4324
4325 2019-02-15  Tom Tromey  <tromey@adacore.com>
4326
4327         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4328         from ravenscar_arch_ops.
4329         (sparc_ravenscar_ops::fetch_registers)
4330         (sparc_ravenscar_ops::store_registers): Now methods.
4331         (sparc_ravenscar_prepare_to_store): Remove.
4332         (sparc_ravenscar_ops): Redefine.
4333         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4334         methods and destructor.  Remove members.
4335         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4336         (ravenscar_thread_target::store_registers)
4337         (ravenscar_thread_target::prepare_to_store): Update.
4338         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4339         Remove.
4340         (struct ppc_ravenscar_powerpc_ops): Derive from
4341         ravenscar_arch_ops.
4342         (ppc_ravenscar_powerpc_ops::fetch_registers)
4343         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4344         (ppc_ravenscar_powerpc_ops): Redefine.
4345         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4346         (ppc_ravenscar_e500_ops::fetch_registers)
4347         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4348         (ppc_ravenscar_e500_ops): Redefine.
4349         * aarch64-ravenscar-thread.c
4350         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4351         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4352         (aarch64_ravenscar_fetch_registers)
4353         (aarch64_ravenscar_store_registers): Now methods.
4354         (aarch64_ravenscar_ops): Redefine.
4355
4356 2019-02-15  Tom Tromey  <tromey@adacore.com>
4357
4358         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4359         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4360         (ravenscar_thread_target::stopped_by_watchpoint)
4361         (ravenscar_thread_target::stopped_data_address)
4362         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4363
4364 2019-02-15  Tom Tromey  <tromey@adacore.com>
4365
4366         * ravenscar-thread.c: Fix some typos.
4367
4368 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4369             Tom Tromey  <tromey@adacore.com>
4370
4371         * ada-lang.c (ada_exception_sal): Change addr_string to a
4372         std::string.
4373         (create_ada_exception_catchpoint): Update.
4374
4375 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4376             Tom Tromey  <tromey@adacore.com>
4377
4378         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4379         (bp_location_ops): Remove.
4380         (base_breakpoint_allocate_location): Update.
4381         (free_bp_location): Update.
4382         * ada-lang.c (class ada_catchpoint_location)
4383         <ada_catchpoint_location>: Remove ops parameter.
4384         (ada_catchpoint_location_dtor): Remove.
4385         (ada_catchpoint_location_ops): Remove.
4386         (allocate_location_exception): Update.
4387         * breakpoint.h (struct bp_location_ops): Remove.
4388         (class bp_location) <bp_location>: Remove bp_location_ops
4389         parameter.
4390         <~bp_location>: Add destructor.
4391         <ops>: Remove.
4392
4393 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4394             Pedro Alves  <palves@redhat.com>
4395
4396         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4397         'PATH_MAX'.
4398
4399 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4400             Samuel Thibault  <samuel.thibault@gnu.org>
4401             Thomas Schwinge  <thomas@codesourcery.com>
4402
4403         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4404         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4405
4406 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4407
4408         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4409         (check_empty): Use "const char *".
4410
4411         * gnu-nat.c (gnu_nat_target::detach): Instead of
4412         'detach_inferior (pid)' call
4413         'detach_inferior (find_inferior_pid (pid))'.
4414
4415         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4416         'nat/fork-inferior.o'.
4417         * gnu-nat.c: #include "nat/fork-inferior.h".
4418
4419         * gnu-nat.c (gnu_nat_target::detach): Instead of
4420         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4421         * gnu-nat.h: #include "inf-child.h".
4422         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4423         'i386_gnu_nat_target::fetch_registers'.
4424         (gnu_store_registers): Rename/move to
4425         'i386_gnu_nat_target::store_registers'.
4426
4427         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4428         * gnu-nat.h (mach_thread_info): New function.
4429         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4430
4431         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4432
4433 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4434
4435         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4436
4437 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4438
4439         * windows-nat.c (windows_add_thread): Add new parameter
4440         "main_thread_p" with default value set to false.  Update
4441         function documentation as well as all callers.
4442         (windows_delete_thread): Likewise.
4443         (fake_create_process): Update call to windows_add_thread.
4444         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4445         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4446         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4447         call to windows_delete_thread.
4448
4449 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4450
4451         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4452
4453 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4454
4455         * symfile.c (find_separate_debug_file): Use canonical path of
4456         sysroot with child_path instead of gdb_sysroot if it is valid.
4457
4458 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4459
4460         * symfile.c (find_separate_debug_file): Use child_path to
4461         determine if an object file is under a sysroot.
4462
4463 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4464
4465         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4466         unittests/child-path-selftests.c.
4467         * common/pathstuff.c (child_path): New function.
4468         * common/pathstuff.h (child_path): New prototype.
4469         * unittests/child-path-selftests.c: New file.
4470
4471 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4472
4473         * symfile.c (find_separate_debug_file): Look for separate debug
4474         files in debug directories under the sysroot.
4475
4476 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4477
4478         * symtab.h (struct minimal_symbol data_p): New const method.
4479         (struct minimal_symbol text_p): Likewise.
4480         * symtab.c (output_source_filename): Use file name style
4481         to print file name.
4482         (print_symbol_info): Likewise.
4483         (print_msymbol_info): Use address style to print addresses.
4484         Use function name style to print executable text symbols.
4485         (expand_symtab_containing_pc): Use data_p.
4486         (find_pc_sect_compunit_symtab): Likewise.
4487
4488 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4489
4490         * breakpoint.c (describe_other_breakpoints): Use address style
4491         to print addresses.
4492         (say_where): Likewise.
4493
4494 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4495
4496         * ada-typeprint.c (print_func_type): Print function name
4497         style to print function name.
4498         * c-typeprint.c (c_print_type_1): Likewise.
4499
4500 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4501
4502         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4503         for execve.
4504
4505 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4506
4507         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4508         type_stack.
4509
4510 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4511
4512         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4513         TYPE_CODE_REF types.
4514
4515 2019-02-08  Jim Wilson  <jimw@sifive.com>
4516
4517         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4518         (riscv_linux_fregset): New.
4519         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4520
4521 2019-02-07  Tom Tromey  <tom@tromey.com>
4522
4523         * thread.c (thread_cancel_execution_command): Update.
4524         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4525         methods.
4526         (struct thread_fsm_ops): Remove.
4527         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4528         (thread_fsm_should_stop, thread_fsm_return_value)
4529         (thread_fsm_set_finished, thread_fsm_finished_p)
4530         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4531         Don't declare.
4532         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4533         * infrun.c (clear_proceed_status_thread)
4534         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4535         (print_stop_event): Update.
4536         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4537         Add constructor.
4538         (step_command_fsm_ops): Remove.
4539         (new_step_command_fsm): Remove.
4540         (step_1): Update.
4541         (step_command_fsm::should_stop): Rename from
4542         step_command_fsm_should_stop.
4543         (step_command_fsm::clean_up): Rename from
4544         step_command_fsm_clean_up.
4545         (step_command_fsm::do_async_reply_reason): Rename from
4546         step_command_fsm_async_reply_reason.
4547         (struct until_next_fsm): Inherit from thread_fsm.  Add
4548         constructor.
4549         (until_next_fsm_ops): Remove.
4550         (new_until_next_fsm): Remove.
4551         (until_next_fsm::should_stop): Rename from
4552         until_next_fsm_should_stop.
4553         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4554         (until_next_fsm::do_async_reply_reason): Rename from
4555         until_next_fsm_async_reply_reason.
4556         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4557         constructor.  Change type of breakpoint.
4558         (finish_command_fsm_ops): Remove.
4559         (new_finish_command_fsm): Remove.
4560         (finish_command_fsm::should_stop): Rename from
4561         finish_command_fsm_should_stop.
4562         (finish_command_fsm::clean_up): Rename from
4563         finish_command_fsm_clean_up.
4564         (finish_command_fsm::return_value): Rename from
4565         finish_command_fsm_return_value.
4566         (finish_command_fsm::do_async_reply_reason): Rename from
4567         finish_command_fsm_async_reply_reason.
4568         (finish_command): Update.
4569         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4570         Add constructor.
4571         (call_thread_fsm_ops): Remove.
4572         (call_thread_fsm::call_thread_fsm): Rename from
4573         new_call_thread_fsm.
4574         (call_thread_fsm::should_stop): Rename from
4575         call_thread_fsm_should_stop.
4576         (call_thread_fsm::should_notify_stop): Rename from
4577         call_thread_fsm_should_notify_stop.
4578         (run_inferior_call, call_function_by_hand_dummy): Update.
4579         * cli/cli-interp.c (should_print_stop_to_console): Update.
4580         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4581         Add constructor.  Change type of location_breakpoint,
4582         caller_breakpoint.
4583         (until_break_fsm_ops): Remove.
4584         (new_until_break_fsm): Remove.
4585         (until_break_fsm::should_stop): Rename from
4586         until_break_fsm_should_stop.
4587         (until_break_fsm::clean_up): Rename from
4588         until_break_fsm_clean_up.
4589         (until_break_fsm::do_async_reply_reason): Rename from
4590         until_break_fsm_async_reply_reason.
4591         (until_break_command): Update.
4592         * thread-fsm.c: Remove.
4593         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4594
4595 2019-02-07  Tom Tromey  <tom@tromey.com>
4596
4597         * yy-remap.h: Add include guard.
4598         * xtensa-tdep.h: Add include guard.
4599         * xcoffread.h: Rename include guard.
4600         * varobj-iter.h: Add include guard.
4601         * tui/tui.h: Rename include guard.
4602         * tui/tui-winsource.h: Rename include guard.
4603         * tui/tui-wingeneral.h: Rename include guard.
4604         * tui/tui-windata.h: Rename include guard.
4605         * tui/tui-win.h: Rename include guard.
4606         * tui/tui-stack.h: Rename include guard.
4607         * tui/tui-source.h: Rename include guard.
4608         * tui/tui-regs.h: Rename include guard.
4609         * tui/tui-out.h: Rename include guard.
4610         * tui/tui-layout.h: Rename include guard.
4611         * tui/tui-io.h: Rename include guard.
4612         * tui/tui-hooks.h: Rename include guard.
4613         * tui/tui-file.h: Rename include guard.
4614         * tui/tui-disasm.h: Rename include guard.
4615         * tui/tui-data.h: Rename include guard.
4616         * tui/tui-command.h: Rename include guard.
4617         * tic6x-tdep.h: Add include guard.
4618         * target/waitstatus.h: Rename include guard.
4619         * target/wait.h: Rename include guard.
4620         * target/target.h: Rename include guard.
4621         * target/resume.h: Rename include guard.
4622         * target-float.h: Rename include guard.
4623         * stabsread.h: Add include guard.
4624         * rs6000-tdep.h: Add include guard.
4625         * riscv-fbsd-tdep.h: Add include guard.
4626         * regformats/regdef.h: Rename include guard.
4627         * record.h: Rename include guard.
4628         * python/python.h: Rename include guard.
4629         * python/python-internal.h: Rename include guard.
4630         * python/py-stopevent.h: Rename include guard.
4631         * python/py-ref.h: Rename include guard.
4632         * python/py-record.h: Rename include guard.
4633         * python/py-record-full.h: Rename include guard.
4634         * python/py-record-btrace.h: Rename include guard.
4635         * python/py-instruction.h: Rename include guard.
4636         * python/py-events.h: Rename include guard.
4637         * python/py-event.h: Rename include guard.
4638         * procfs.h: Add include guard.
4639         * proc-utils.h: Add include guard.
4640         * p-lang.h: Add include guard.
4641         * or1k-tdep.h: Rename include guard.
4642         * observable.h: Rename include guard.
4643         * nto-tdep.h: Rename include guard.
4644         * nat/x86-linux.h: Rename include guard.
4645         * nat/x86-linux-dregs.h: Rename include guard.
4646         * nat/x86-gcc-cpuid.h: Add include guard.
4647         * nat/x86-dregs.h: Rename include guard.
4648         * nat/x86-cpuid.h: Rename include guard.
4649         * nat/ppc-linux.h: Rename include guard.
4650         * nat/mips-linux-watch.h: Rename include guard.
4651         * nat/linux-waitpid.h: Rename include guard.
4652         * nat/linux-ptrace.h: Rename include guard.
4653         * nat/linux-procfs.h: Rename include guard.
4654         * nat/linux-osdata.h: Rename include guard.
4655         * nat/linux-nat.h: Rename include guard.
4656         * nat/linux-namespaces.h: Rename include guard.
4657         * nat/linux-btrace.h: Rename include guard.
4658         * nat/glibc_thread_db.h: Rename include guard.
4659         * nat/gdb_thread_db.h: Rename include guard.
4660         * nat/gdb_ptrace.h: Rename include guard.
4661         * nat/fork-inferior.h: Rename include guard.
4662         * nat/amd64-linux-siginfo.h: Rename include guard.
4663         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4664         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4665         * nat/aarch64-linux.h: Rename include guard.
4666         * nat/aarch64-linux-hw-point.h: Rename include guard.
4667         * mn10300-tdep.h: Add include guard.
4668         * mips-linux-tdep.h: Add include guard.
4669         * mi/mi-parse.h: Rename include guard.
4670         * mi/mi-out.h: Rename include guard.
4671         * mi/mi-main.h: Rename include guard.
4672         * mi/mi-interp.h: Rename include guard.
4673         * mi/mi-getopt.h: Rename include guard.
4674         * mi/mi-console.h: Rename include guard.
4675         * mi/mi-common.h: Rename include guard.
4676         * mi/mi-cmds.h: Rename include guard.
4677         * mi/mi-cmd-break.h: Rename include guard.
4678         * m2-lang.h: Add include guard.
4679         * location.h: Rename include guard.
4680         * linux-record.h: Rename include guard.
4681         * linux-nat.h: Add include guard.
4682         * linux-fork.h: Add include guard.
4683         * i386-darwin-tdep.h: Rename include guard.
4684         * hppa-linux-offsets.h: Add include guard.
4685         * guile/guile.h: Rename include guard.
4686         * guile/guile-internal.h: Rename include guard.
4687         * gnu-nat.h: Rename include guard.
4688         * gdb-stabs.h: Rename include guard.
4689         * frv-tdep.h: Add include guard.
4690         * f-lang.h: Add include guard.
4691         * event-loop.h: Add include guard.
4692         * darwin-nat.h: Rename include guard.
4693         * cp-abi.h: Rename include guard.
4694         * config/sparc/nm-sol2.h: Rename include guard.
4695         * config/nm-nto.h: Rename include guard.
4696         * config/nm-linux.h: Add include guard.
4697         * config/i386/nm-i386gnu.h: Rename include guard.
4698         * config/djgpp/nl_types.h: Rename include guard.
4699         * config/djgpp/langinfo.h: Rename include guard.
4700         * compile/gcc-cp-plugin.h: Add include guard.
4701         * compile/gcc-c-plugin.h: Add include guard.
4702         * compile/compile.h: Rename include guard.
4703         * compile/compile-object-run.h: Rename include guard.
4704         * compile/compile-object-load.h: Rename include guard.
4705         * compile/compile-internal.h: Rename include guard.
4706         * compile/compile-cplus.h: Rename include guard.
4707         * compile/compile-c.h: Rename include guard.
4708         * common/xml-utils.h: Rename include guard.
4709         * common/x86-xstate.h: Rename include guard.
4710         * common/version.h: Rename include guard.
4711         * common/vec.h: Rename include guard.
4712         * common/tdesc.h: Rename include guard.
4713         * common/selftest.h: Rename include guard.
4714         * common/scoped_restore.h: Rename include guard.
4715         * common/scoped_mmap.h: Rename include guard.
4716         * common/scoped_fd.h: Rename include guard.
4717         * common/safe-iterator.h: Rename include guard.
4718         * common/run-time-clock.h: Rename include guard.
4719         * common/refcounted-object.h: Rename include guard.
4720         * common/queue.h: Rename include guard.
4721         * common/ptid.h: Rename include guard.
4722         * common/print-utils.h: Rename include guard.
4723         * common/preprocessor.h: Rename include guard.
4724         * common/pathstuff.h: Rename include guard.
4725         * common/observable.h: Rename include guard.
4726         * common/netstuff.h: Rename include guard.
4727         * common/job-control.h: Rename include guard.
4728         * common/host-defs.h: Rename include guard.
4729         * common/gdb_wait.h: Rename include guard.
4730         * common/gdb_vecs.h: Rename include guard.
4731         * common/gdb_unlinker.h: Rename include guard.
4732         * common/gdb_unique_ptr.h: Rename include guard.
4733         * common/gdb_tilde_expand.h: Rename include guard.
4734         * common/gdb_sys_time.h: Rename include guard.
4735         * common/gdb_string_view.h: Rename include guard.
4736         * common/gdb_splay_tree.h: Rename include guard.
4737         * common/gdb_setjmp.h: Rename include guard.
4738         * common/gdb_ref_ptr.h: Rename include guard.
4739         * common/gdb_optional.h: Rename include guard.
4740         * common/gdb_locale.h: Rename include guard.
4741         * common/gdb_assert.h: Rename include guard.
4742         * common/filtered-iterator.h: Rename include guard.
4743         * common/filestuff.h: Rename include guard.
4744         * common/fileio.h: Rename include guard.
4745         * common/environ.h: Rename include guard.
4746         * common/common-utils.h: Rename include guard.
4747         * common/common-types.h: Rename include guard.
4748         * common/common-regcache.h: Rename include guard.
4749         * common/common-inferior.h: Rename include guard.
4750         * common/common-gdbthread.h: Rename include guard.
4751         * common/common-exceptions.h: Rename include guard.
4752         * common/common-defs.h: Rename include guard.
4753         * common/common-debug.h: Rename include guard.
4754         * common/cleanups.h: Rename include guard.
4755         * common/buffer.h: Rename include guard.
4756         * common/btrace-common.h: Rename include guard.
4757         * common/break-common.h: Rename include guard.
4758         * cli/cli-utils.h: Rename include guard.
4759         * cli/cli-style.h: Rename include guard.
4760         * cli/cli-setshow.h: Rename include guard.
4761         * cli/cli-script.h: Rename include guard.
4762         * cli/cli-interp.h: Rename include guard.
4763         * cli/cli-decode.h: Rename include guard.
4764         * cli/cli-cmds.h: Rename include guard.
4765         * charset-list.h: Add include guard.
4766         * buildsym-legacy.h: Rename include guard.
4767         * bfin-tdep.h: Add include guard.
4768         * ax.h: Rename include guard.
4769         * arm-linux-tdep.h: Add include guard.
4770         * arm-fbsd-tdep.h: Add include guard.
4771         * arch/xtensa.h: Rename include guard.
4772         * arch/tic6x.h: Add include guard.
4773         * arch/i386.h: Add include guard.
4774         * arch/arm.h: Rename include guard.
4775         * arch/arm-linux.h: Rename include guard.
4776         * arch/arm-get-next-pcs.h: Rename include guard.
4777         * arch/amd64.h: Add include guard.
4778         * arch/aarch64-insn.h: Rename include guard.
4779         * arch-utils.h: Rename include guard.
4780         * annotate.h: Add include guard.
4781         * amd64-darwin-tdep.h: Rename include guard.
4782         * aarch64-linux-tdep.h: Add include guard.
4783         * aarch64-fbsd-tdep.h: Add include guard.
4784         * aarch32-linux-nat.h: Add include guard.
4785
4786 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4787
4788         * macrotab.c (macro_define_internal): New function that
4789         factorizes macro_define_object_internal and macro_define_function
4790         code.
4791         (macro_define_object_internal): Use macro_define_internal.
4792         (macro_define_function): Likewise.
4793
4794 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4795
4796         * macrocmd.c (extract_identifier): Return
4797         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4798         callers.
4799
4800 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4801
4802         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4803
4804 2019-02-05  Tom Tromey  <tom@tromey.com>
4805
4806         * target.c (target_stack::unpush): Move assertion earlier.
4807
4808 2019-01-30  Tom Tromey  <tom@tromey.com>
4809
4810         PR python/23615:
4811         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4812         (gdbpy_parse_and_eval): Likewise.
4813         * python/python-internal.h (gdbpy_allow_threads): New class.
4814
4815 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4816
4817         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4818         (aarch64_fbsd_fpregmap): Move earlier.
4819         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4820         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4821         instead of individual calls to trad_frame_set_reg_addr.
4822         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4823         earlier.
4824         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4825         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4826         instead of individual calls to trad_frame_set_reg_addr.
4827
4828 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4829
4830         * CONTRIBUTE: Replace contribution list with wiki link.
4831
4832 2019-01-25  Tom Tromey  <tom@tromey.com>
4833
4834         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4835
4836 2019-01-25  Tom Tromey  <tom@tromey.com>
4837
4838         * xtensa-linux-nat.c: Fix common/ includes.
4839         * xml-support.h: Fix common/ includes.
4840         * xml-support.c: Fix common/ includes.
4841         * x86-linux-nat.c: Fix common/ includes.
4842         * windows-nat.c: Fix common/ includes.
4843         * varobj.h: Fix common/ includes.
4844         * varobj.c: Fix common/ includes.
4845         * value.c: Fix common/ includes.
4846         * valops.c: Fix common/ includes.
4847         * utils.c: Fix common/ includes.
4848         * unittests/xml-utils-selftests.c: Fix common/ includes.
4849         * unittests/utils-selftests.c: Fix common/ includes.
4850         * unittests/unpack-selftests.c: Fix common/ includes.
4851         * unittests/tracepoint-selftests.c: Fix common/ includes.
4852         * unittests/style-selftests.c: Fix common/ includes.
4853         * unittests/string_view-selftests.c: Fix common/ includes.
4854         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4855         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4856         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4857         * unittests/rsp-low-selftests.c: Fix common/ includes.
4858         * unittests/parse-connection-spec-selftests.c: Fix common/
4859         includes.
4860         * unittests/optional-selftests.c: Fix common/ includes.
4861         * unittests/offset-type-selftests.c: Fix common/ includes.
4862         * unittests/observable-selftests.c: Fix common/ includes.
4863         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4864         * unittests/memrange-selftests.c: Fix common/ includes.
4865         * unittests/memory-map-selftests.c: Fix common/ includes.
4866         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4867         * unittests/function-view-selftests.c: Fix common/ includes.
4868         * unittests/environ-selftests.c: Fix common/ includes.
4869         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4870         * unittests/common-utils-selftests.c: Fix common/ includes.
4871         * unittests/cli-utils-selftests.c: Fix common/ includes.
4872         * unittests/array-view-selftests.c: Fix common/ includes.
4873         * ui-file.c: Fix common/ includes.
4874         * tui/tui-io.c: Fix common/ includes.
4875         * tracepoint.h: Fix common/ includes.
4876         * tracepoint.c: Fix common/ includes.
4877         * tracefile-tfile.c: Fix common/ includes.
4878         * top.h: Fix common/ includes.
4879         * top.c: Fix common/ includes.
4880         * thread.c: Fix common/ includes.
4881         * target/waitstatus.h: Fix common/ includes.
4882         * target/waitstatus.c: Fix common/ includes.
4883         * target.h: Fix common/ includes.
4884         * target.c: Fix common/ includes.
4885         * target-memory.c: Fix common/ includes.
4886         * target-descriptions.c: Fix common/ includes.
4887         * symtab.h: Fix common/ includes.
4888         * symfile.c: Fix common/ includes.
4889         * stap-probe.c: Fix common/ includes.
4890         * spu-linux-nat.c: Fix common/ includes.
4891         * sparc-nat.c: Fix common/ includes.
4892         * source.c: Fix common/ includes.
4893         * solib.c: Fix common/ includes.
4894         * solib-target.c: Fix common/ includes.
4895         * ser-unix.c: Fix common/ includes.
4896         * ser-tcp.c: Fix common/ includes.
4897         * ser-pipe.c: Fix common/ includes.
4898         * ser-base.c: Fix common/ includes.
4899         * selftest-arch.c: Fix common/ includes.
4900         * s12z-tdep.c: Fix common/ includes.
4901         * rust-exp.y: Fix common/ includes.
4902         * rs6000-aix-tdep.c: Fix common/ includes.
4903         * riscv-tdep.c: Fix common/ includes.
4904         * remote.c: Fix common/ includes.
4905         * remote-notif.h: Fix common/ includes.
4906         * remote-fileio.h: Fix common/ includes.
4907         * remote-fileio.c: Fix common/ includes.
4908         * regcache.h: Fix common/ includes.
4909         * regcache.c: Fix common/ includes.
4910         * record-btrace.c: Fix common/ includes.
4911         * python/python.c: Fix common/ includes.
4912         * python/py-type.c: Fix common/ includes.
4913         * python/py-inferior.c: Fix common/ includes.
4914         * progspace.h: Fix common/ includes.
4915         * producer.c: Fix common/ includes.
4916         * procfs.c: Fix common/ includes.
4917         * proc-api.c: Fix common/ includes.
4918         * printcmd.c: Fix common/ includes.
4919         * ppc-linux-nat.c: Fix common/ includes.
4920         * parser-defs.h: Fix common/ includes.
4921         * osdata.c: Fix common/ includes.
4922         * obsd-nat.c: Fix common/ includes.
4923         * nat/x86-linux.c: Fix common/ includes.
4924         * nat/x86-linux-dregs.c: Fix common/ includes.
4925         * nat/x86-dregs.h: Fix common/ includes.
4926         * nat/x86-dregs.c: Fix common/ includes.
4927         * nat/ppc-linux.c: Fix common/ includes.
4928         * nat/mips-linux-watch.h: Fix common/ includes.
4929         * nat/mips-linux-watch.c: Fix common/ includes.
4930         * nat/linux-waitpid.c: Fix common/ includes.
4931         * nat/linux-ptrace.h: Fix common/ includes.
4932         * nat/linux-ptrace.c: Fix common/ includes.
4933         * nat/linux-procfs.c: Fix common/ includes.
4934         * nat/linux-personality.c: Fix common/ includes.
4935         * nat/linux-osdata.c: Fix common/ includes.
4936         * nat/linux-namespaces.c: Fix common/ includes.
4937         * nat/linux-btrace.h: Fix common/ includes.
4938         * nat/linux-btrace.c: Fix common/ includes.
4939         * nat/fork-inferior.c: Fix common/ includes.
4940         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4941         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4942         * nat/aarch64-linux.c: Fix common/ includes.
4943         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4944         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4945         * namespace.h: Fix common/ includes.
4946         * mips-linux-tdep.c: Fix common/ includes.
4947         * minsyms.c: Fix common/ includes.
4948         * mi/mi-parse.h: Fix common/ includes.
4949         * mi/mi-main.c: Fix common/ includes.
4950         * mi/mi-cmd-env.c: Fix common/ includes.
4951         * memrange.h: Fix common/ includes.
4952         * memattr.c: Fix common/ includes.
4953         * maint.h: Fix common/ includes.
4954         * maint.c: Fix common/ includes.
4955         * main.c: Fix common/ includes.
4956         * machoread.c: Fix common/ includes.
4957         * location.c: Fix common/ includes.
4958         * linux-thread-db.c: Fix common/ includes.
4959         * linux-nat.c: Fix common/ includes.
4960         * linux-fork.c: Fix common/ includes.
4961         * inline-frame.c: Fix common/ includes.
4962         * infrun.c: Fix common/ includes.
4963         * inflow.c: Fix common/ includes.
4964         * inferior.h: Fix common/ includes.
4965         * inferior.c: Fix common/ includes.
4966         * infcmd.c: Fix common/ includes.
4967         * inf-ptrace.c: Fix common/ includes.
4968         * inf-child.c: Fix common/ includes.
4969         * ia64-linux-nat.c: Fix common/ includes.
4970         * i387-tdep.c: Fix common/ includes.
4971         * i386-tdep.c: Fix common/ includes.
4972         * i386-linux-tdep.c: Fix common/ includes.
4973         * i386-linux-nat.c: Fix common/ includes.
4974         * i386-go32-tdep.c: Fix common/ includes.
4975         * i386-fbsd-tdep.c: Fix common/ includes.
4976         * i386-fbsd-nat.c: Fix common/ includes.
4977         * guile/scm-type.c: Fix common/ includes.
4978         * guile/guile.c: Fix common/ includes.
4979         * go32-nat.c: Fix common/ includes.
4980         * gnu-nat.c: Fix common/ includes.
4981         * gdbthread.h: Fix common/ includes.
4982         * gdbarch-selftests.c: Fix common/ includes.
4983         * gdb_usleep.c: Fix common/ includes.
4984         * gdb_select.h: Fix common/ includes.
4985         * gdb_bfd.c: Fix common/ includes.
4986         * gcore.c: Fix common/ includes.
4987         * fork-child.c: Fix common/ includes.
4988         * findvar.c: Fix common/ includes.
4989         * fbsd-nat.c: Fix common/ includes.
4990         * event-top.c: Fix common/ includes.
4991         * event-loop.c: Fix common/ includes.
4992         * dwarf2read.c: Fix common/ includes.
4993         * dwarf2loc.c: Fix common/ includes.
4994         * dwarf2-frame.c: Fix common/ includes.
4995         * dwarf-index-cache.c: Fix common/ includes.
4996         * dtrace-probe.c: Fix common/ includes.
4997         * disasm-selftests.c: Fix common/ includes.
4998         * defs.h: Fix common/ includes.
4999         * csky-tdep.c: Fix common/ includes.
5000         * cp-valprint.c: Fix common/ includes.
5001         * cp-support.h: Fix common/ includes.
5002         * cp-support.c: Fix common/ includes.
5003         * corelow.c: Fix common/ includes.
5004         * completer.h: Fix common/ includes.
5005         * completer.c: Fix common/ includes.
5006         * compile/compile.c: Fix common/ includes.
5007         * compile/compile-loc2c.c: Fix common/ includes.
5008         * compile/compile-cplus-types.c: Fix common/ includes.
5009         * compile/compile-cplus-symbols.c: Fix common/ includes.
5010         * command.h: Fix common/ includes.
5011         * cli/cli-dump.c: Fix common/ includes.
5012         * cli/cli-cmds.c: Fix common/ includes.
5013         * charset.c: Fix common/ includes.
5014         * build-id.c: Fix common/ includes.
5015         * btrace.h: Fix common/ includes.
5016         * btrace.c: Fix common/ includes.
5017         * breakpoint.h: Fix common/ includes.
5018         * breakpoint.c: Fix common/ includes.
5019         * ax.h:
5020         (enum agent_op): Fix common/ includes.
5021         * ax-general.c (struct aop_map): Fix common/ includes.
5022         * ax-gdb.c: Fix common/ includes.
5023         * auxv.c: Fix common/ includes.
5024         * auto-load.c: Fix common/ includes.
5025         * arm-tdep.c: Fix common/ includes.
5026         * arch/riscv.c: Fix common/ includes.
5027         * arch/ppc-linux-common.c: Fix common/ includes.
5028         * arch/i386.c: Fix common/ includes.
5029         * arch/arm.c: Fix common/ includes.
5030         * arch/arm-linux.c: Fix common/ includes.
5031         * arch/arm-get-next-pcs.c: Fix common/ includes.
5032         * arch/amd64.c: Fix common/ includes.
5033         * arch/aarch64.c: Fix common/ includes.
5034         * arch/aarch64-insn.c: Fix common/ includes.
5035         * arch-utils.c: Fix common/ includes.
5036         * amd64-windows-tdep.c: Fix common/ includes.
5037         * amd64-tdep.c: Fix common/ includes.
5038         * amd64-sol2-tdep.c: Fix common/ includes.
5039         * amd64-obsd-tdep.c: Fix common/ includes.
5040         * amd64-nbsd-tdep.c: Fix common/ includes.
5041         * amd64-linux-tdep.c: Fix common/ includes.
5042         * amd64-linux-nat.c: Fix common/ includes.
5043         * amd64-fbsd-tdep.c: Fix common/ includes.
5044         * amd64-fbsd-nat.c: Fix common/ includes.
5045         * amd64-dicos-tdep.c: Fix common/ includes.
5046         * amd64-darwin-tdep.c: Fix common/ includes.
5047         * agent.c: Fix common/ includes.
5048         * ada-lang.h: Fix common/ includes.
5049         * ada-lang.c: Fix common/ includes.
5050         * aarch64-tdep.c: Fix common/ includes.
5051
5052 2019-01-25  Tom Tromey  <tom@tromey.com>
5053
5054         * common/create-version.sh: Use common/version.h.
5055
5056 2019-01-24  Pedro Alves  <palves@redhat.com>
5057
5058         * infrun.c (signal_stop, signal_print, signal_program)
5059         (signal_catch, signal_pass): Now arrays instead of pointers.
5060         (update_signals_program_target, do_target_resume)
5061         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5062         * linux-nat.c (linux_nat_target::pass_signals)
5063         (linux_nat_target::create_inferior, linux_nat_target::attach):
5064         Adjust.
5065         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5066         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5067         * procfs.c (procfs_target::pass_signals): Adjust.
5068         * record-full.c (record_full_target::resume): Adjust.
5069         * remote.c (remote_target::pass_signals)
5070         (remote_target::program_signals): Adjust.
5071         * target-debug.h (target_debug_print_signals): Now takes a
5072         gdb::array_view as parameter.  Adjust.
5073         * target.h (target_ops) <pass_signals, program_signals>: Replace
5074         pointer and length parameters with gdb::array_view.
5075         (target_pass_signals, target_program_signals): Likewise.
5076         * target-delegates.c: Regenerate.
5077
5078 2019-01-24  Pedro Alves  <palves@redhat.com>
5079
5080         * common/forward-scope-exit.h
5081         (forward_scope_exit::forward_scope_exit): Pass arguments to
5082         m_bind_function directly, instead of creating a std::bind and
5083         copying that.
5084
5085 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5086
5087         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5088         for static members.
5089         (pass_in_v_vfp_candidate): Likewise.
5090
5091 2019-01-23  Tom Tromey  <tom@tromey.com>
5092             Pedro Alves  <palves@redhat.com>
5093
5094         * regcache.c (class regcache_invalidator): Remove.
5095         (regcache::raw_write): Use make_scope_exit.
5096
5097 2019-01-23  Tom Tromey  <tom@tromey.com>
5098
5099         * ui-out.h (class ui_out_emit_type): Update comment.
5100
5101 2019-01-23  Tom Tromey  <tom@tromey.com>
5102
5103         * infrun.c (fetch_inferior_event): Update comment.
5104
5105 2019-01-23  Tom Tromey  <tom@tromey.com>
5106             Pedro Alves  <palves@redhat.com>
5107
5108         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5109         parameter.
5110         (fetch_inferior_event): Use SCOPE_EXIT.
5111
5112
5113 2019-01-23  Tom Tromey  <tom@tromey.com>
5114             Pedro Alves  <palves@redhat.com>
5115
5116         * infrun.c (disable_thread_events): Delete.
5117         (stop_all_threads): Use SCOPE_EXIT.
5118
5119 2019-01-23  Tom Tromey  <tom@tromey.com>
5120             Pedro Alves  <palves@redhat.com>
5121
5122         * symfile.c: Include forward-scope-exit.h.
5123         (clear_symtab_users_cleanup): Replace forward declaration with
5124         a FORWARD_SCOPE_EXIT.
5125         (syms_from_objfile_1): Use the forward_scope_exit and
5126         gdb::optional instead of cleanup_function.
5127         (reread_symbols): Use the forward_scope_exit instead of
5128         cleanup_function.
5129         (clear_symtab_users_cleanup): Remove function.
5130
5131 2019-01-23  Tom Tromey  <tom@tromey.com>
5132             Pedro Alves  <palves@redhat.com>
5133
5134         * linux-nat.c: Include scope-exit.h.
5135         (cleanup_target_stop): Remove.
5136         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5137         SCOPE_EXIT.
5138
5139 2019-01-23  Tom Tromey  <tom@tromey.com>
5140             Pedro Alves  <palves@redhat.com>
5141
5142         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5143         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5144
5145 2019-01-23  Tom Tromey  <tom@tromey.com>
5146             Andrew Burgess  <andrew.burgess@embecosm.com>
5147             Pedro Alves  <palves@redhat.com>
5148
5149         * infrun.c (fetch_inferior_event): Use scope_exit.
5150         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5151         * top.c (execute_command): Use scope_exit.
5152         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5153         * utils.c (do_bpstat_clear_actions_cleanup)
5154         (make_bpstat_clear_actions_cleanup): Remove.
5155
5156 2019-01-23  Tom Tromey  <tom@tromey.com>
5157             Pedro Alves  <palves@redhat.com>
5158
5159         * infrun.c: Include "common/scope-exit.h"
5160         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5161         (wait_for_inferior): Use SCOPE_EXIT.
5162         (fetch_inferior_event): Use scope_exit.
5163
5164 2019-01-23  Tom Tromey  <tom@tromey.com>
5165             Pedro Alves  <palves@redhat.com>
5166
5167         * breakpoint.c (create_breakpoint): Remove cleanup.
5168
5169 2019-01-23  Tom Tromey  <tom@tromey.com>
5170             Andrew Burgess  <andrew.burgess@embecosm.com>
5171             Pedro Alves  <palves@redhat.com>
5172
5173 2019-01-23  Pedro Alves  <palves@redhat.com>
5174
5175         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5176
5177 2019-01-23  Pedro Alves  <palves@redhat.com>
5178             Andrew Burgess  <andrew.burgess@embecosm.com>
5179
5180         * gdbthread.h: Include "common/forward-scope-exit.h".
5181         (scoped_finish_thread_state): Redefine custom class in terms of
5182         forward_scope_exit.
5183
5184 2019-01-23  Pedro Alves  <palves@redhat.com>
5185             Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * common/forward-scope-exit.h: New file.
5188
5189 2019-01-23  Pedro Alves  <palves@redhat.com>
5190             Andrew Burgess  <andrew.burgess@embecosm.com>
5191             Tom Tromey  <tom@tromey.com>
5192
5193         * common/scope-exit.h: New file.
5194
5195 2019-01-23  Pedro Alves  <palves@redhat.com>
5196
5197         * common/preprocessor.h (ESC): Rename to ...
5198         (ESC_PARENS): ... this.
5199         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5200         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5201
5202 2019-01-23  Tom Tromey  <tom@tromey.com>
5203
5204         * language.h (class scoped_switch_to_sym_language_if_auto):
5205         Initialize m_lang in both cases.
5206
5207 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5208
5209         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5210         with XCNEW.
5211
5212 2019-01-22  Tom Tromey  <tom@tromey.com>
5213
5214         * corelow.c: Do not include sys/file.h.
5215
5216 2019-01-22  Tom Tromey  <tom@tromey.com>
5217
5218         * tui/tui-wingeneral.h: Include gdb_curses.h.
5219
5220 2019-01-22  Tom Tromey  <tom@tromey.com>
5221
5222         * source-cache.h (class source_cache) <get_source_lines,
5223         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5224
5225 2019-01-22  Tom Tromey  <tom@tromey.com>
5226
5227         * remote-fileio.h (struct remote_target): Declare.
5228
5229 2019-01-22  Tom Tromey  <tom@tromey.com>
5230
5231         * python/py-arch.c: Do not include py-ref.h.
5232         * python/py-bpevent.c: Do not include py-ref.h.
5233         * python/py-cmd.c: Do not include py-ref.h.
5234         * python/py-continueevent.c: Do not include py-ref.h.
5235         * python/py-event.h: Do not include py-ref.h.
5236         * python/py-evtregistry.c: Do not include py-ref.h.
5237         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5238         * python/py-frame.c: Do not include py-ref.h.
5239         * python/py-framefilter.c: Do not include py-ref.h.
5240         * python/py-function.c: Do not include py-ref.h.
5241         * python/py-infevents.c: Do not include py-ref.h.
5242         * python/py-linetable.c: Do not include py-ref.h.
5243         * python/py-objfile.c: Do not include py-ref.h.
5244         * python/py-param.c: Do not include py-ref.h.
5245         * python/py-prettyprint.c: Do not include py-ref.h.
5246         * python/py-progspace.c: Do not include py-ref.h.
5247         * python/py-symbol.c: Do not include py-ref.h.
5248         * python/py-symtab.c: Do not include py-ref.h.
5249         * python/py-type.c: Do not include py-ref.h.
5250         * python/py-unwind.c: Do not include py-ref.h.
5251         * python/py-utils.c: Do not include py-ref.h.
5252         * python/py-value.c: Do not include py-ref.h.
5253         * python/py-varobj.c: Do not include py-ref.h.
5254         * python/py-xmethods.c: Do not include py-ref.h.
5255         * python/python.c: Do not include py-ref.h.
5256         * varobj.c: Do not include py-ref.h.
5257
5258 2019-01-22  Tom Tromey  <tom@tromey.com>
5259
5260         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5261         keyword for bcache.
5262
5263 2019-01-22  Tom Tromey  <tom@tromey.com>
5264
5265         * compile/compile-cplus-types.c: Remove a comment by #include.
5266
5267 2019-01-22  Tom Tromey  <tom@tromey.com>
5268
5269         * compile/gcc-c-plugin.h: Include compile-internal.h.
5270
5271 2019-01-22  Tom Tromey  <tom@tromey.com>
5272
5273         * stabsread.c (EXTERN): Do not define.
5274         (symnum, next_symbol_text_func, processing_gcc_compilation)
5275         (within_function, global_sym_chain, global_stabs)
5276         (previous_stab_code, this_object_header_files)
5277         (n_this_object_header_files)
5278         (n_allocated_this_object_header_files): Define.
5279         * stabsread.h (EXTERN): Never define.  Use "extern".
5280
5281 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5282
5283         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5284         history_value.
5285
5286 2019-01-21  Tom Tromey  <tom@tromey.com>
5287
5288         * ui-out.c: Fix includes.
5289         * tui/tui-source.c: Fix includes.
5290         * target.c: Fix includes.
5291         * remote.c: Fix includes.
5292         * regcache.c: Fix includes.
5293         * python/py-block.c: Fix includes.
5294         * printcmd.c: Fix includes.
5295         * or1k-tdep.c: Fix includes.
5296         * mi/mi-main.c: Fix includes.
5297         * m32r-tdep.c: Fix includes.
5298         * csky-tdep.c: Fix includes.
5299         * compile/compile-cplus-types.c: Fix includes.
5300         * cli/cli-interp.c: Fix includes.
5301
5302 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5303
5304         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5305         for padding.
5306
5307 2019-01-16  Tom Tromey  <tom@tromey.com>
5308
5309         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5310         earlier.
5311         (struct objfile) <msymbols_range>: Move from top level.
5312         <msymbols>: New method.
5313         (class objfile_msymbols): Remove.
5314         * symtab.c (default_collect_symbol_completion_matches_break_on):
5315         Update.
5316         * symmisc.c (dump_msymbols): Update.
5317         * stabsread.c (scan_file_globals): Update.
5318         * objc-lang.c (info_selectors_command, info_classes_command)
5319         (find_methods): Update.
5320         * minsyms.c (find_solib_trampoline_target): Update.
5321         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5322         * coffread.c (coff_symfile_read): Update.
5323         * ada-lang.c (ada_lookup_simple_minsym)
5324         (ada_collect_symbol_completion_matches): Update.
5325
5326 2019-01-16  Tom Tromey  <tom@tromey.com>
5327
5328         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5329         type.  Remove no-argument constructor.
5330         <iterator::operator++>: Simplify.
5331         <begin>: Update.
5332         <end>: Use minimal_symbol_count.
5333
5334 2019-01-16  Tom Tromey  <tom@tromey.com>
5335
5336         * objfiles.h (struct objfile) <psymtabs>: New method.
5337         (class objfile_psymtabs): Remove.
5338         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5339         typedef.
5340         <range>: New method.
5341         (require_partial_symbols): Change return type.
5342         * psymtab.c (require_partial_symbols)
5343         (psym_expand_symtabs_matching): Update.
5344         * mdebugread.c (parse_partial_symbols): Update.
5345         * dbxread.c (dbx_end_psymtab): Update.
5346
5347 2019-01-15  Tom Tromey  <tom@tromey.com>
5348
5349         * symtab.c (lookup_objfile_from_block)
5350         (lookup_symbol_in_objfile_symtabs)
5351         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5352         (find_line_symtab, info_sources_command)
5353         (default_collect_symbol_completion_matches_break_on)
5354         (make_source_files_completion_list): Update.
5355         * symmisc.c (print_objfile_statistics, dump_objfile)
5356         (maintenance_print_symbols, maintenance_info_symtabs)
5357         (maintenance_check_symtabs, maintenance_info_line_tables):
5358         Update.
5359         * source.c (select_source_symtab)
5360         (forget_cached_source_info_for_objfile): Update.
5361         * objfiles.h (class objfile_compunits): Remove.
5362         (struct objfile) <compunits_range>: New typedef.
5363         (compunits): New method.
5364         * objfiles.c (objfile_relocate1): Update.
5365         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5366         * maint.c (count_symtabs_and_blocks): Update.
5367         * linespec.c (iterate_over_all_matching_symtabs): Update.
5368         * cp-support.c (add_symbol_overload_list_qualified): Update.
5369         * coffread.c (coff_symtab_read): Update.
5370         * ada-lang.c (add_nonlocal_symbols)
5371         (ada_collect_symbol_completion_matches)
5372         (ada_add_global_exceptions): Update.
5373
5374 2019-01-15  Tom Tromey  <tom@tromey.com>
5375
5376         * progspace.h (program_space) <objfiles_safe_range>: New
5377         typedef.
5378         <objfiles_safe>: New method.
5379         * objfiles.h (class all_objfiles_safe): Remove.
5380         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5381         * jit.c (jit_inferior_exit_hook): Update.
5382
5383 2019-01-17  Tom Tromey  <tom@tromey.com>
5384
5385         * progspace.h (program_space) <objfiles_range>: New typedef.
5386         <objfiles>: New method.
5387         <objfiles_head>: Rename from objfiles.
5388         (object_files): Update.
5389         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5390         * guile/scm-pretty-print.c
5391         (ppscm_find_pretty_printer_from_objfiles): Update.
5392         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5393         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5394         Update.
5395         * python/py-progspace.c (pspy_get_objfiles): Update.
5396         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5397         Update.
5398         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5399         (objfpy_lookup_objfile_by_build_id): Update.
5400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5401         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5402         Update.
5403         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5404         (expand_symtab_containing_pc, lookup_objfile_from_block)
5405         (lookup_static_symbol, basic_lookup_transparent_type)
5406         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5407         (find_line_symtab, info_sources_command)
5408         (default_collect_symbol_completion_matches_break_on)
5409         (make_source_files_completion_list, find_main_name): Update.
5410         * symmisc.c (print_symbol_bcache_statistics)
5411         (print_objfile_statistics, maintenance_print_symbols)
5412         (maintenance_print_msymbols, maintenance_print_objfiles)
5413         (maintenance_info_symtabs, maintenance_check_symtabs)
5414         (maintenance_expand_symtabs, maintenance_info_line_tables):
5415         Update.
5416         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5417         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5418         (map_overlay_command, unmap_overlay_command)
5419         (simple_overlay_update, expand_symtabs_matching)
5420         (map_symbol_filenames): Update.
5421         * symfile-debug.c (set_debug_symfile): Update.
5422         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5423         Update.
5424         * source.c (select_source_symtab, forget_cached_source_info):
5425         Update.
5426         * solib.c (solib_read_symbols): Update.
5427         * solib-spu.c (append_ocl_sos): Update.
5428         * psymtab.c (maintenance_print_psymbols)
5429         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5430         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5431         * printcmd.c (info_symbol_command): Update.
5432         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5433         Update.
5434         * objfiles.h (class all_objfiles): Remove.
5435         * objfiles.c (have_partial_symbols, have_full_symbols)
5436         (have_minimal_symbols, qsort_cmp, update_section_map)
5437         (shared_objfile_contains_address_p)
5438         (default_iterate_over_objfiles_in_search_order): Update.
5439         * objc-lang.c (info_selectors_command, info_classes_command)
5440         (find_methods): Update.
5441         * minsyms.c (find_solib_trampoline_target): Update.
5442         * maint.c (maintenance_info_sections)
5443         (maintenance_translate_address, count_symtabs_and_blocks):
5444         Update.
5445         * main.c (captured_main_1): Update.
5446         * linux-thread-db.c (try_thread_db_load_from_pdir)
5447         (has_libpthread): Update.
5448         * linespec.c (iterate_over_all_matching_symtabs)
5449         (search_minsyms_for_name): Update.
5450         * jit.c (jit_find_objf_with_entry_addr): Update.
5451         * hppa-tdep.c (find_unwind_entry)
5452         (hppa_lookup_stub_minimal_symbol): Update.
5453         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5454         Update.
5455         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5456         (elf_gnu_ifunc_resolve_by_got): Update.
5457         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5458         * dwarf-index-write.c (save_gdb_index_command): Update.
5459         * cp-support.c (add_symbol_overload_list_qualified): Update.
5460         * breakpoint.c (create_overlay_event_breakpoint)
5461         (create_longjmp_master_breakpoint)
5462         (create_std_terminate_master_breakpoint)
5463         (create_exception_master_breakpoint): Update.
5464         * blockframe.c (find_pc_partial_function): Update.
5465         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5466         (ada_collect_symbol_completion_matches)
5467         (ada_add_global_exceptions): Update.
5468
5469 2019-01-17  Tom Tromey  <tom@tromey.com>
5470
5471         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5472         declare VEC.
5473         (solib_target_parse_libraries): Change return type.
5474         (library_list_start_segment, library_list_start_section)
5475         (library_list_end_library, library_list_start_library); Update.
5476         (solib_target_free_library_list): Remove.
5477         (solib_target_parse_libraries): Remove cleanup.  Change return
5478         type.
5479         (solib_target_current_sos): Update.
5480
5481 2019-01-17  Tom Tromey  <tromey@bapiya>
5482
5483         * valprint.c: Replace "the the" with "the".
5484         * symtab.c: Replace "the the" with "the".
5485         * solib.c: Replace "the the" with "the".
5486         * solib-dsbt.c: Replace "the the" with "the".
5487         * linespec.c: Replace "the the" with "the".
5488         * dwarf2loc.h: Replace "the the" with "the".
5489         * amd64-windows-tdep.c: Replace "the the" with "the".
5490         * aarch64-tdep.c: Replace "the the" with "the".
5491
5492 2019-01-16  Keith Seitz  <keiths@redhat.com>
5493
5494         PR gdb/23773
5495         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5496         <builder>: Rename to ..
5497         <m_builder>: ... this and make private.
5498         (dwarf2_cu::get_builder): New method.  Change all users of
5499         `builder' to use this method.
5500         (dwarf2_start_symtab): Move to ...
5501         (dwarf2_cu::start_symtab): ... here.  Update all callers
5502         (setup_type_unit_groups): Move to ...
5503         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5504         callers.
5505         (dwarf2_cu::reset_builder): New method.
5506         (process_full_compunit, process_full_type_unit): Use
5507         dwarf2_cu::reset_builder.
5508         (follow_die_offset): Record the ancestor CU if it is different
5509         from the followed DIE's CU.
5510         (follow_die_sig_1): Likewise.
5511
5512 2019-01-15  Tom Tromey  <tom@tromey.com>
5513
5514         * remote.c (class remote_state) <buf>: Now a char_vector.
5515         <buf_size>: Remove.
5516         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5517         parameter.
5518         (remote_target::getpkt_or_notif_sane_1)
5519         (remote_target::getpkt_sane)
5520         (remote_target::getpkt_or_notif_sane): Likewise.
5521         (class remote_target) <putpkt>: New overload.
5522         (remote_target::read_frame): Change type of "buf_p".  Remove
5523         sizeof_p parameter.
5524         (packet_ok): New overload.
5525         (packet_check_result): New overload.
5526         Update all uses.
5527
5528 2019-01-14  Tom Tromey  <tom@tromey.com>
5529
5530         * remote-notif.c (handle_notification, remote_notif_ack)
5531         (remote_notif_parse): Make "buf" const.
5532         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5533         const.
5534         (remote_notif_parse, remote_notif_ack, handle_notification):
5535         Likewise.
5536         * remote.c (remote_notif_stop_parse): Make "buf" const.
5537         (remote_target::remote_parse_stop_reply): Make "buf" const.
5538         (remote_notif_stop_ack): Make "buf" const.
5539
5540 2019-01-14  Tom Tromey  <tom@tromey.com>
5541
5542         * remote.c (remote_console_output): Make parameter const.
5543
5544 2019-01-14  Tom Tromey  <tom@tromey.com>
5545
5546         * target-debug.h (target_debug_print_signals): Constify.
5547         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5548         * procfs.c (procfs_target::pass_signals): Update.
5549         * linux-nat.c (linux_nat_target::pass_signals): Update.
5550         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5551         * target-delegates.c: Rebuild.
5552         * remote.c (remote_target::program_signals): Update.
5553         (remote_target::pass_signals): Update.
5554         * target.c (target_pass_signals): Constify argument.
5555         (target_program_signals): Likewise.
5556         * target.h (struct target_ops) <pass_signals, program_signals>:
5557         Constify argument.
5558         (target_pass_signals, target_program_signals): Constify argument.
5559
5560 2019-01-14  Tom Tromey  <tom@tromey.com>
5561
5562         PR tui/28819:
5563         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5564
5565 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5566
5567         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5568         field.
5569         * rs6000-tdep.c: Include reggroups.h.
5570         (IS_V_ALIAS_PSEUDOREG): Define.
5571         (rs6000_register_name): Return names for the "vX" aliases.
5572         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5573         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5574         aliases.  Call default_register_reggroup_p for all other
5575         pseudo-registers.
5576         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5577         New functions.
5578         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5579         Handle "vX" aliases.
5580         (v_alias_pseudo_register_collect): New function.
5581         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5582         (rs6000_gdbarch_init): Initialize "vX" aliases as
5583         pseudo-registers.  Restore registration of
5584         rs6000_pseudo_register_reggroup_p with
5585         set_tdesc_pseudo_register_reggroup_p.
5586
5587 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5588
5589         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5590         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5591         set_gdbarch_num_pseudo_regs.
5592
5593 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5594
5595         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5596         Remove arg prefixname, add do_set and do_show.
5597         Add member functions set_list and show_list.
5598         * cli/cli-style.c (class cli_style_option): Update accordingly.
5599         (style_set_list): Move to file scope.
5600         (style_show_list): Likewise.
5601         (set_style): Call help_list.
5602         (show_style): Call cmd_show_list.
5603         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5604         Update to use the new macro.
5605
5606 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5607
5608         * ada-lang.c (_initialize_ada_language): Expand the help text
5609         for the "catch exception" command.
5610
5611 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5612
5613         * symtab.c (matching_obj_sections): Initialize obj,
5614         declare it closer to its usage.
5615
5616 2019-01-10  Tom Tromey  <tom@tromey.com>
5617
5618         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5619         (basic_inf_threads_range): Remove.
5620         (inf_threads_range, inf_non_exited_threads_range)
5621         (safe_inf_threads_range): Use next_adapter.
5622
5623 2019-01-10  Keith Seitz  <keiths@redhat.com>
5624
5625         PR gdb/23712
5626         PR symtab/23010
5627         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5628         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5629
5630 2019-01-10  Keith Seitz  <keiths@redhat.com>
5631
5632         PR gdb/23712
5633         PR symtab/23010
5634         * dictionary.c (pending_to_vector): Remove.
5635         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5636         Remove _1 suffix, replacing functions of the same name.  Update
5637         all callers.
5638         (dict_create_hashed, dict_create_hashed_expandable)
5639         (dict_create_linear, dict_create_linear_expandable, dict_free)
5640         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5641         Make functions static.
5642
5643 2019-01-10  Keith Seitz  <keiths@redhat.com>
5644
5645         PR gdb/23712
5646         PR symtab/23010
5647         * dictionary.h (struct dictionary): Replace declaration with
5648         multidictionary.
5649         (dict_create_hashed, dict_create_hashed_expandable)
5650         (dict_create_linear, dict_create_linear_expandable)
5651         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5652         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5653         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5654         taking multidictionary argument.
5655         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5656         * block.h (struct block) <dict>: Change to multidictionary
5657         and rename `multidict'.
5658         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5659         symmisc.c: Update all dictionary references to multidictionary.
5660
5661 2019-01-10  Keith Seitz  <keiths@redhat.com>
5662
5663         PR gdb/23712
5664         PR symtab/23010
5665         * dictionary.c: Include unordered_map.
5666         (pending_to_vector): New function.
5667         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5668         Rewrite the non-"_1" functions to take vector instead
5669         of linked list.
5670         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5671         "new" _1 versions of the same name.
5672         (multidictionary): Define.
5673         (std::hash<enum language): New definition.
5674         (collate_pending_symbols_by_language, mdict_create_hashed)
5675         (mdict_create_hashed_expandable, mdict_create_linear)
5676         (mdict_create_linear_expandable, mdict_free)
5677         (find_language_dictionary, create_new_language_dictionary)
5678         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5679         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5680         (mdict_size, mdict_empty): New functions.
5681         * dictionary.h (mdict_iterator): Define.
5682
5683 2019-01-10  Pedro Alves  <palves@redhat.com>
5684
5685         * breakpoint.c (read_uploaded_action)
5686         (create_tracepoint_from_upload): Adjust to use
5687         gdb::unique_xmalloc_ptr.
5688         * ctf.c (ctf_write_uploaded_tp):
5689         (SET_ARRAY_FIELD): Use emplace_back.
5690         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5691         * tracefile-tfile.c (tfile_write_uploaded_tp):
5692         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5693         gdb::unique_xmalloc_ptr.
5694         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5695         at_string, cond_string, cmd_strings>: Replace char pointers
5696         with gdb::unique_xmalloc_ptr.
5697
5698 2019-01-10  Pedro Alves  <palves@redhat.com>
5699
5700         * solib-target.c (library_list_start_library): Don't xstrdup name.
5701
5702 2019-01-10  Pedro Alves  <palves@redhat.com>
5703
5704         * mdebugread.c (parse_partial_symbols): Use
5705         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5706
5707 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5708
5709         * linux-fork.c (scoped_switch_fork_info)
5710         <~scoped_switch_fork_info>: Fix incorrect variable name.
5711
5712 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5713
5714         * linux-fork.c (scoped_switch_fork_info)
5715         <scoped_switch_fork_info>: Make explicit.
5716         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5717
5718 2019-01-10  Tom Tromey  <tom@tromey.com>
5719
5720         * objfiles.h (objfile::reset_psymtabs): Update.
5721         * objfiles.c (objfile::objfile): Update.
5722         * psymtab.h (psymtab_storage::obstack): Update.
5723         (psymtab_storage::m_obstack): Use gdb::optional.
5724         (class psymtab_storage): Update comment.  Remove objfile
5725         parameter.
5726         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5727
5728 2019-01-10  Tom Tromey  <tom@tromey.com>
5729
5730         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5731         <free_psymtabs>: Now private.
5732         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5733         (allocate_psymtab): Use new method.
5734
5735 2019-01-10  Tom Tromey  <tom@tromey.com>
5736
5737         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5738         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5739         * mdebugread.c (parse_partial_symbols): Use
5740         allocate_dependencies.
5741         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5742         allocate_dependencies.
5743         (process_psymtab_comp_unit_reader)
5744         (build_type_psymtab_dependencies): Likewise.
5745         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5746
5747 2019-01-10  Tom Tromey  <tom@tromey.com>
5748
5749         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5750         PSYMBOL_SET_LANGUAGE.
5751         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5752
5753 2019-01-10  Tom Tromey  <tom@tromey.com>
5754
5755         * psymtab.h (psymtab_storage::obstack): New method.
5756         <m_obstack>: Rename from obstack; now private.
5757         * psymtab.c (psymtab_storage): Update.
5758         * dwarf2read.c (create_addrmap_from_index)
5759         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5760         Update.
5761
5762 2019-01-10  Tom Tromey  <tom@tromey.com>
5763
5764         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5765         * objfiles.h (objfile::reset_psymtabs): New method.
5766
5767 2019-01-10  Tom Tromey  <tom@tromey.com>
5768
5769         * symmisc.c (print_symbol_bcache_statistics): Update.
5770         (print_objfile_statistics): Update.
5771         * symfile.c (reread_symbols): Update.
5772         * psymtab.h (class psymtab_storage): New.
5773         * psymtab.c (psymtab_storage): New constructor.
5774         (~psymtab_storage): New destructor.
5775         (require_partial_symbols): Update.
5776         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5777         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5778         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5779         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5780         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5781         (start_psymtab_common, end_psymtab_common)
5782         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5783         (allocate_psymtab): Update.
5784         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5785         Update.
5786         (dump_psymtab_addrmap, maintenance_print_psymbols)
5787         (maintenance_check_psymtabs): Update.
5788         (class objfile_psymtabs): Move to objfiles.h.
5789         * psympriv.h (discard_psymtab): Now inline.
5790         (psymtab_discarder::psymtab_discarder): Update.
5791         (psymtab_discarder::~psymtab_discarder): Update.
5792         (ALL_OBJFILE_PSYMTABS): Rewrite.
5793         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5794         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5795         Remove fields.
5796         <partial_symtabs>: New field.
5797         (class objfile_psymtabs): Move from psymtab.h.  Update.
5798         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5799         psymbol_cache.
5800         (objfile::~objfile): Don't destroy psymbol_cache.
5801         * mdebugread.c (parse_partial_symbols): Update.
5802         * dwarf2read.c (create_addrmap_from_index)
5803         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5804         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5805         (add_partial_subprogram, dwarf2_ranges_read): Update.
5806         * dwarf-index-write.c (write_address_map)
5807         (write_one_signatured_type, recursively_write_psymbols)
5808         (class debug_names, class debug_names, write_psymtabs_to_index):
5809         Update.
5810
5811 2019-01-10  Tom Tromey  <tom@tromey.com>
5812
5813         * symtab.h (SYMBOL_SET_NAMES): Update.
5814         (symbol_set_names): Update.
5815         (MSYMBOL_SET_NAMES): Update.
5816         * symtab.c (symbol_set_names): Change argument to be an
5817         objfile_per_bfd_storage.
5818         * psymtab.c (add_psymbol_to_bcache): Update.
5819         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5820
5821 2019-01-10  Tom Tromey  <tom@tromey.com>
5822
5823         * symtab.c (create_demangled_names_hash): Change argument to be an
5824         objfile_per_bfd_storage.
5825         (symbol_set_names): Update.
5826
5827 2019-01-10  Tom Tromey  <tom@tromey.com>
5828
5829         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5830         init_psymbol_list.
5831         * psymtab.c (init_psymbol_list): Do nothing if already called.
5832         * psympriv.h (init_psymbol_list): Add comment.
5833         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5834         init_psymbol_list.
5835         * dbxread.c (dbx_symfile_read): Unconditionally call
5836         init_psymbol_list.
5837
5838 2019-01-10  Tom Tromey  <tom@tromey.com>
5839
5840         * xcoffread.c (scan_xcoff_symtab): Update.
5841         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5842         "where".
5843         * mdebugread.c (parse_partial_symbols)
5844         (handle_psymbol_enumerators): Update.
5845         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5846         * dbxread.c (read_dbx_symtab): Update.
5847         * psympriv.h (psymbol_placement): New enum.
5848         (add_psymbol_to_list): Update.
5849
5850 2019-01-10  Tom Tromey  <tom@tromey.com>
5851
5852         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5853         static_psymbols parameters.
5854         (scan_xcoff_symtab): Update.
5855         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5856         static_psymbols parameters.
5857         * psympriv.h (start_psymtab_common): Update.
5858         * mdebugread.c (parse_partial_symbols): Update.
5859         * dwarf2read.c (create_partial_symtab): Update.
5860         * dbxread.c (read_dbx_symtab): Update.
5861         (start_psymtab): Remove global_psymbols and static_psymbols
5862         parameters.
5863
5864 2019-01-10  Tom Tromey  <tom@tromey.com>
5865
5866         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5867         * psymtab.c (allocate_psymtab): Add comment.
5868         * psympriv.h (allocate_psymtab): Add comment.
5869         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5870         initializations.
5871         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5872
5873 2019-01-10  Tom Tromey  <tom@tromey.com>
5874
5875         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5876         Don't declare.
5877         * mipsread.c: Include mdebugread.h.
5878         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5879         Declare.
5880         * elfread.c: Include mdebugread.h.
5881
5882 2019-01-09  Tom Tromey  <tom@tromey.com>
5883
5884         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5885         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5886         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5887         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5888         (psym_lookup_symbol, psym_find_last_source_symtab)
5889         (psym_forget_cached_source_info, psym_print_stats)
5890         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5891         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5892         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5893         (psym_find_compunit_symtab_by_address)
5894         (maintenance_print_psymbols, maintenance_info_psymtabs)
5895         (maintenance_check_psymtabs): Use ranged for.
5896         * psymtab.h (class objfile_psymtabs): New.
5897         (require_partial_symbols): Return objfile_psymtabs.
5898         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5899
5900 2019-01-09  Tom Tromey  <tom@tromey.com>
5901
5902         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5903         (find_pc_mapped_section, list_overlays_command)
5904         (map_overlay_command, unmap_overlay_command)
5905         (simple_overlay_update): Use all_objfiles.
5906         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5907         * printcmd.c (info_symbol_command): Use all_objfiles.
5908         * objfiles.h (ALL_OBJSECTIONS): Remove.
5909         * maint.c (maintenance_translate_address): Use all_objfiles.
5910         * gcore.c (gcore_create_callback): Use all_objfiles.
5911         (objfile_find_memory_regions): Likewise.
5912
5913 2019-01-09  Tom Tromey  <tom@tromey.com>
5914
5915         * symtab.c (find_line_symtab, info_sources_command)
5916         (make_source_files_completion_list): Use objfile_compunits.
5917         * source.c (select_source_symtab): Use objfile_compunits.
5918         * objfiles.h (struct objfile): Update comment.
5919         (ALL_OBJFILES): Remove.
5920         (ALL_FILETABS): Remove.
5921         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5922         objfile_compunits.
5923
5924 2019-01-09  Tom Tromey  <tom@tromey.com>
5925
5926         * symmisc.c (print_objfile_statistics, dump_objfile)
5927         (maintenance_print_symbols): Use compunit_filetabs.
5928         * source.c (forget_cached_source_info_for_objfile): Use
5929         compunit_filetabs.
5930         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5931         (ALL_FILETABS): Use compunit_filetabs.
5932         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5933         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5934
5935 2019-01-09  Tom Tromey  <tom@tromey.com>
5936
5937         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5938         (compunit_filetabs): New.
5939         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5940         compunit_filetabs.
5941         (info_sources_command, make_source_files_completion_list): Remove
5942         declaration.
5943         * symmisc.c (print_objfile_statistics, dump_objfile)
5944         (maintenance_print_symbols): Remove declaration.
5945         (maintenance_info_symtabs): Use compunit_filetabs.
5946         (maintenance_info_line_tables): Likewise.
5947         * source.c (select_source_symtab): Change local variable name.
5948         (forget_cached_source_info_for_objfile): Remove declaration.
5949         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5950         * objfiles.c (objfile_relocate1): Remove declaration.
5951         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5952         declaration.
5953         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5954         * coffread.c (coff_symtab_read): Remove declaration.
5955         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5956         compunit_filetabs.
5957
5958 2019-01-09  Tom Tromey  <tom@tromey.com>
5959
5960         * symtab.c (lookup_objfile_from_block)
5961         (find_pc_sect_compunit_symtab, search_symbols)
5962         (default_collect_symbol_completion_matches_break_on): Use
5963         objfile_compunits.
5964         * objfiles.h (ALL_COMPUNITS): Remove.
5965         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5966         * cp-support.c (add_symbol_overload_list_qualified): Use
5967         objfile_compunits.
5968         * ada-lang.c (ada_collect_symbol_completion_matches)
5969         (ada_add_global_exceptions): Use objfile_compunits.
5970
5971 2019-01-09  Tom Tromey  <tom@tromey.com>
5972
5973         * source.c (select_source_symtab)
5974         (forget_cached_source_info_for_objfile): Remove declaration.
5975         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5976         declaration.
5977         * maint.c (count_symtabs_and_blocks): Remove declaration.
5978         * cp-support.c (add_symbol_overload_list_qualified): Remove
5979         declaration.
5980         * coffread.c (coff_symtab_read): Remove declaration.
5981         * symtab.c (lookup_symbol_in_objfile_symtabs)
5982         (basic_lookup_transparent_type_1): Use objfile_compunits.
5983         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5984         (info_sources_command, search_symbols)
5985         (default_collect_symbol_completion_matches_break_on)
5986         (make_source_files_completion_list): Remove declaration.
5987         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5988         (ada_collect_symbol_completion_matches)
5989         (ada_add_global_exceptions): Remove declaration.
5990         * linespec.c (iterate_over_all_matching_symtabs): Use
5991         objfile_compunits.
5992         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5993         (class objfile_compunits): New.
5994         (ALL_COMPUNITS): Use objfile_compunits.
5995         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5996         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5997         objfile_compunits.
5998         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5999
6000 2019-01-09  Tom Tromey  <tom@tromey.com>
6001
6002         * symtab.c (search_symbols)
6003         (default_collect_symbol_completion_matches_break_on): Use
6004         objfile_msymbols.
6005         * ada-lang.c (ada_lookup_simple_minsym)
6006         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6007         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6008         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6009         objfile_msymbols.
6010         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6011         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6012         * objc-lang.c (find_methods): Use objfile_msymbols.
6013         (info_selectors_command, info_classes_command): Likewise.
6014         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6015         * objfiles.h (class objfile_msymbols): New.
6016         (ALL_OBJFILE_MSYMBOLS): Remove.
6017         (ALL_MSYMBOLS): Remove.
6018
6019 2019-01-09  Tom Tromey  <tom@tromey.com>
6020
6021         * common/next-iterator.h (next_adapter): Add Iterator template
6022         parameter.
6023         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6024         (class all_objfiles_safe): New.
6025         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6026         * objfiles.c (put_objfile_before): Update comment.
6027         (add_separate_debug_objfile): Likewise.
6028         (free_all_objfiles): Use all_objfiles_safe.
6029         (objfile_purge_solibs): Likewise.
6030
6031 2019-01-09  Tom Tromey  <tom@tromey.com>
6032
6033         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6034         (expand_symtab_containing_pc, lookup_static_symbol)
6035         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6036         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6037         all_objfiles.
6038         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6039         * breakpoint.c (create_overlay_event_breakpoint)
6040         (create_longjmp_master_breakpoint)
6041         (create_std_terminate_master_breakpoint)
6042         (create_exception_master_breakpoint): Use all_objfiles.
6043         * linux-thread-db.c (try_thread_db_load_from_pdir)
6044         (has_libpthread): Use all_objfiles.
6045         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6046         * linespec.c (iterate_over_all_matching_symtabs)
6047         (search_minsyms_for_name): Use all_objfiles.
6048         * maint.c (maintenance_info_sections): Use all_objfiles.
6049         * main.c (captured_main_1): Use all_objfiles.
6050         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6051         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6052         * guile/scm-pretty-print.c
6053         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6054         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6055         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6056         (maintenance_print_msymbols): Use all_objfiles.
6057         * source.c (select_source_symtab): Use all_objfiles.
6058         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6059         * symfile.c (remove_symbol_file_command)
6060         (expand_symtabs_matching, map_symbol_filenames): Use
6061         all_objfiles.
6062         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6063         all_objfiles.
6064         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6065         * objc-lang.c (find_methods): Use all_objfiles.
6066         * objfiles.c (have_partial_symbols, have_full_symbols)
6067         (have_minimal_symbols, qsort_cmp)
6068         (default_iterate_over_objfiles_in_search_order): Use
6069         all_objfiles.
6070         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6071         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6072         (maintenance_check_psymtabs): Use all_objfiles.
6073         (ALL_PSYMTABS): Remove.
6074         * compile/compile-object-run.c (do_module_cleanup): Use
6075         all_objfiles.
6076         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6077         * cp-support.c (add_symbol_overload_list_qualified): Use
6078         all_objfiles.
6079         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6080         Use all_objfiles.
6081         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6082         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6083         all_objfiles.
6084         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6085         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6086         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6087         Uses all_objfiles.
6088         * solib.c (solib_read_symbols): Use all_objfiles
6089
6090 2019-01-09  Tom Tromey  <tom@tromey.com>
6091
6092         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6093         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6094         all_objfiles.
6095         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6096         * symmisc.c (print_symbol_bcache_statistics)
6097         (print_objfile_statistics, maintenance_print_objfiles)
6098         (maintenance_info_symtabs, maintenance_check_symtabs)
6099         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6100         all_objfiles.
6101         * source.c (forget_cached_source_info): Use all_objfiles.
6102         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6103         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6104         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6105         * objfiles.c (update_section_map): Use all_objfiles.
6106         (shared_objfile_contains_address_p): Likewise.
6107         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6108         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6109
6110 2019-01-09  Tom Tromey  <tom@tromey.com>
6111
6112         * common/next-iterator.h: New file.
6113         * objfiles.h (class all_objfiles): New.
6114         (struct objfile_iterator): New.
6115
6116 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6117
6118         * NEWS: Move the description of the changed "frame", "select-frame",
6119          and "info frame" commands to the Changed commands section.
6120
6121 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6122
6123         * gdbtypes.c (check_stub_method_group): Remove handling of old
6124         mangling schemes.
6125         * linespec.c (find_methods): Likewise.
6126         * stabsread.c (read_member_functions): Likewise.
6127         * valops.c (search_struct_method): Likewise.
6128         (value_struct_elt_for_reference): Likewise.
6129         * NEWS: Mention this change.
6130
6131 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6134         print_source_lines.
6135         * source.c (print_source_lines_base): Update line number check.
6136         (print_source_lines): New function.
6137         (source_lines_range::source_lines_range): New function.
6138         * source.h (class source_lines_range): New class.
6139         (print_source_lines): New declaration.
6140
6141 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6142
6143         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6144
6145 2019-01-08  Tom Tromey  <tom@tromey.com>
6146             Simon Marchi  <simon.marchi@ericsson.com>
6147
6148         PR gdb/24060
6149         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6150         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6151         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6152         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6153         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6154         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6155
6156 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * source.c (select_source_symtab): Move header comment to
6159         declaration in source.h.
6160         (forget_cached_source_info_for_objfile): Likewise.
6161         (forget_cached_source_info): Likewise.
6162         (identify_source_line): Likewise.
6163         * source.h (identify_source_line): Move declaration from symtab.h
6164         and add comment from source.c
6165         (print_source_lines): Likewise.
6166         (forget_cached_source_info_for_objfile): Likewise.
6167         (forget_cached_source_info): Likewise.
6168         (select_source_symtab): Likewise.
6169         (enum print_source_lines_flag): Move definition from symtab.h.
6170         * symtab.h (identify_source_line): Move declaration to source.h.
6171         (print_source_lines): Likewise.
6172         (forget_cached_source_info_for_objfile): Likewise.
6173         (forget_cached_source_info): Likewise.
6174         (select_source_symtab): Likewise.
6175         (enum print_source_lines_flag): Move definition to source.h.
6176         * tui/tui-hooks.c: Add 'source.h' include.
6177
6178 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * source.c (print_source_lines_base): Handle requests to print
6181         reverse line number sequences, and guard against empty lines
6182         string.
6183
6184 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * source.c (print_source_lines_base): Fix skip of '\r' if next
6187         character is '\n'.
6188
6189 2019-01-06  Tom Tromey  <tom@tromey.com>
6190
6191         * c-exp.y (struct c_parse_state) <macro_original_text,
6192         expansion_obstack>: New member.
6193         (macro_original_text, expansion_obstack): Remove globals.
6194         (scan_macro_expansion, scanning_macro_expansion)
6195         (finished_macro_expansion): Update.
6196         (scan_macro_cleanup): Remove.
6197         (yylex, c_parse): Update.
6198
6199 2019-01-06  Tom Tromey  <tom@tromey.com>
6200
6201         * c-exp.y (struct c_parse_state) <strings>: New member.
6202         (operator_stoken): Update.
6203
6204 2019-01-06  Tom Tromey  <tom@tromey.com>
6205
6206         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6207         (union type_stack_elt) <typelist_val>: Now a pointer to
6208         std::vector.
6209         (type_stack_cleanup): Don't declare.
6210         (push_typelist): Update.
6211         * parse.c (pop_typelist): Return a std::vector.
6212         (push_typelist): Take a std::vector.
6213         (follow_types): Update.  Do not free args.
6214         (type_stack_cleanup): Remove.
6215         * c-exp.y (struct c_parse_state): New.
6216         (cpstate): New global.
6217         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6218         (nonempty_typelist): Update.
6219         (func_mod): Create a new vector.
6220         (c_parse): Create a c_parse_state.
6221         (check_parameter_typelist): Do not delete params.
6222         (function_method): Update.  Do not delete type_list.
6223
6224 2019-01-06  Tom Tromey  <tom@tromey.com>
6225
6226         PR gdb/28155:
6227         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6228         check_typedef.
6229         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6230         (print_return_value): Likewise.
6231
6232 2019-01-05  Tom Tromey  <tom@tromey.com>
6233
6234         * contrib/cleanup_check.py: Remove.
6235         * contrib/gcc-with-excheck: Remove.
6236         * contrib/exsummary.py: Remove.
6237         * contrib/excheck.py: Remove.
6238
6239 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6240
6241         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6242         NULL. Initialize tpprev to NULL instead of assigning it
6243         to NULL on the next statement.
6244         * windows-nat.c (windows_delete_thread): Remove check for
6245         main_thread_id before printing thread exit notifications.
6246         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6247         Remove thread ID check against main_thread_id.
6248         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6249         windows_delete_thread.
6250         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6251
6252 2019-01-04  Tom Tromey  <tom@tromey.com>
6253
6254         * compile/compile.c (_initialize_compile): Use upper case for
6255         metasyntactic variables.
6256         * symmisc.c (_initialize_symmisc): Use upper case for
6257         metasyntactic variables.
6258         * psymtab.c (_initialize_psymtab): Use upper case for
6259         metasyntactic variables.
6260         * demangle.c (demangle_command): Use upper case for metasyntactic
6261         variables.
6262         (_initialize_demangler): Likewise.
6263         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6264         variables.
6265
6266 2019-01-03  Tom Tromey  <tom@tromey.com>
6267
6268         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6269
6270 2019-01-03  Tom Tromey  <tom@tromey.com>
6271
6272         * python/py-symtab.c (salpy_str): Update.
6273         (struct salpy_sal_object) <symtab>: Now a PyObject.
6274         (salpy_dealloc): Update.
6275         (del_objfile_sal): Use gdbpy_ref.
6276
6277 2019-01-03  Tom Tromey  <tom@tromey.com>
6278
6279         * python/py-type.c (convert_field): Use new_reference.  Return
6280         gdbpy_ref.
6281         (make_fielditem): Return gdbpy_ref.
6282         (typy_fields): Update.
6283         (typy_getitem): Update.
6284         (field_name): Return gdbpy_ref.  Use new_reference.
6285         (typy_iterator_iternext): Update.
6286
6287 2019-01-03  Tom Tromey  <tom@tromey.com>
6288
6289         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6290
6291 2019-01-03  Tom Tromey  <tom@tromey.com>
6292
6293         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6294         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6295         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6296         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6297         (pspy_set_type_printers): Likewise.
6298         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6299         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6300         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6301         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6302         (objfpy_set_type_printers): Likewise.
6303
6304 2019-01-03  Tom Tromey  <tom@tromey.com>
6305
6306         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6307         (gdbpy_print_stack): Use gdbpy_err_fetch.
6308         * python/python-internal.h (class gdbpy_err_fetch): New class.
6309         (class gdbpy_enter) <m_error_type, m_error_value,
6310         m_error_traceback>: Remove.
6311         <m_error>: New member.
6312         (gdbpy_exception_to_string): Don't declare.
6313         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6314         * python/py-value.c (convert_value_from_python): Use
6315         gdbpy_err_fetch.
6316         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6317         gdbpy_exception_to_string.
6318         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6319         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6320         gdbpy_err_fetch.
6321
6322 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * linux-nat.c (delete_lwp_cleanup): Delete.
6325         (struct lwp_deleter): New struct.
6326         (lwp_info_up): New typedef.
6327         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6328         lwp_info_up.
6329
6330 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * linux-fork.c (class scoped_switch_fork_info): New class.
6333         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6334
6335 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * valops.c (find_overload_match): Remove use of null_cleanup, and
6338         calls to do_cleanups.
6339
6340 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * compile/compile-cplus-types.c
6343         (compile_cplus_instance::decl_name): Handle changes to
6344         cp_func_name.
6345         * cp-support.c (cp_func_name): Update header comment, update
6346         return type.
6347         * cp-support.h (cp_func_name): Update return type in declaration.
6348         * valops.c (find_overload_match): Move temp_func local to top
6349         level of function and change its type.  Use temp_func to hold and
6350         delete temporary string obtained from cp_func_name.
6351
6352 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6353
6354         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6355         gdb::char_vector, remove cleanup, and update uses of `msg`.
6356
6357 2019-01-03  Jim Wilson  <jimw@sifive.com>
6358
6359         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6360
6361 2019-01-02  Tom Tromey  <tom@tromey.com>
6362
6363         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6364         (tdesc_parse_xml): Remove cleanups.
6365         * target-descriptions.h (make_cleanup_free_target_description):
6366         Don't declare.
6367         (target_desc_deleter): New struct.
6368         (target_desc_up): New typedef.
6369         * target-descriptions.c (target_desc_deleter::operator()): Rename
6370         from free_target_description.
6371         (make_cleanup_free_target_description): Remove.
6372
6373 2019-01-02  Tom Tromey  <tom@tromey.com>
6374
6375         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6376         constructor, destructor.
6377         (linespec_parser): Remove typedef.
6378         (~linespec_parser): Rename from linespec_parser_delete.
6379         (linespec_lex_to_end, linespec_complete_label)
6380         (linespec_complete): Update.
6381         (decode_line_full): Remove cleanups.
6382         (decode_line_1): Update.
6383
6384 2019-01-02  Tom Tromey  <tom@tromey.com>
6385
6386         * python/python-internal.h (inferior_to_inferior_object): Change
6387         return type.
6388         * python/py-exitedevent.c (create_exited_event_object): Update.
6389         * python/py-inferior.c (inferior_to_inferior_object): Return
6390         gdbpy_ref.
6391         (python_new_inferior, python_inferior_deleted)
6392         (thread_to_thread_object, delete_thread_object)
6393         (build_inferior_list, gdbpy_selected_inferior): Update.
6394         * python/py-infthread.c (create_thread_object): Update.  Also fail
6395         if inferior_to_inferior_object fails.
6396
6397 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6398
6399         * inferior.h (class inferior) <displaced_step_state>: New field.
6400         * infrun.h (struct displaced_step_state): Move here from
6401         infrun.c.  Initialize fields, add constructor.
6402         <inf>: Remove field.
6403         <reset>: New method.
6404         * infrun.c (struct displaced_step_inferior_state): Move to
6405         infrun.h.
6406         (displaced_step_inferior_states): Remove.
6407         (get_displaced_stepping_state): Adust.
6408         (displaced_step_in_progress_any_inferior): Adjust.
6409         (displaced_step_in_progress_thread): Adjust.
6410         (displaced_step_in_progress): Adjust.
6411         (add_displaced_stepping_state): Remove.
6412         (get_displaced_step_closure_by_addr): Adjust.
6413         (remove_displaced_stepping_state): Remove.
6414         (infrun_inferior_exit): Call displaced_step_state.reset.
6415         (use_displaced_stepping): Don't check for NULL.
6416         (displaced_step_prepare_throw): Call
6417         get_displaced_stepping_state.
6418         (displaced_step_fixup): Don't check for NULL.
6419         (prepare_for_detach): Don't check for NULL.
6420
6421 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6422
6423         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6424          in case of call that did not complete.
6425
6426 2019-01-02  Andrey Utkin  <autkin@undo.io>
6427
6428         * symfile.c (find_separate_debug_file): Fix search of debug files for
6429         remote debuggee.
6430
6431 2019-01-02  Tom Tromey  <tom@tromey.com>
6432
6433         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6434         indentation.
6435         * python/py-frame.c (frapy_older): Remove cast.
6436         (frapy_newer): Likewise.
6437         * python/py-breakpoint.c (local_setattro): Remove cast.
6438         * python/py-arch.c (archpy_name): Remove local variable.
6439         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6440
6441 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6442
6443         * unittests/basic_string_view/element_access/char/empty.cc:
6444         Fix year range in copyright header.
6445
6446 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6449         Delete.
6450         <operator==>: Update with for removed field.
6451         <hash>: Likewise.
6452         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6453         <isa_features>: ...this.
6454         <abi_features>: New field.
6455         (riscv_isa_flen): Update comment.
6456         (riscv_abi_xlen): New declaration.
6457         (riscv_abi_flen): New declaration.
6458         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6459         isa_features.
6460         (riscv_abi_xlen): New function.
6461         (riscv_isa_flen): Update to get answer from isa_features.
6462         (riscv_abi_flen): New function.
6463         (riscv_has_fp_abi): Update to get answer from abi_features.
6464         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6465         xlen and flen.
6466         (riscv_call_info) <xlen, flen>: Update comment.
6467         (riscv_call_arg_struct): Remove invalid assertions
6468         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6469         is removed.
6470         (riscv_gdbarch_init): Gather isa features and abi features
6471         separately, ensure both match on the gdbarch when reusing an old
6472         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6473         a target with 64-bit float hardware.
6474
6475 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6476
6477         * source.c (search_command_helper): Stop reverse search
6478         when line 1 has been searched.
6479
6480 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6481
6482         * record-full.c (record_full_base_target::close): Rewrite
6483         record_full_core_buf_list free logic.
6484
6485 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6486
6487         * break-catch-syscall.c (print_one_catch_syscall): xfree
6488         the last text.
6489
6490 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6491
6492         * top.c (print_gdb_version): Update Copyright year in version
6493         message.
6494
6495 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6496
6497         Update copyright year range in all GDB files.
6498
6499 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6500
6501         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6502
6503 For older changes see ChangeLog-2018.
6504 \f
6505 Local Variables:
6506 mode: change-log
6507 left-margin: 8
6508 fill-column: 74
6509 version-control: never
6510 coding: utf-8
6511 End:
6512