gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * arc-tdep.c (arc_tdesc_init): Use bool.
   4
   5 2019-05-04  Tom Tromey  <tom@tromey.com>
   6
   7         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
   8
   9 2019-05-04  Tom Tromey  <tom@tromey.com>
  10
  11         * cli/cli-cmds.c (valid_command_p): Return bool.
  12
  13 2019-05-04  Tom Tromey  <tom@tromey.com>
  14
  15         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  16         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  17
  18 2019-05-04  Raul Tambre  <raul@tambre.ee>
  19
  20         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  21         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  22         operator for comparison.
  23
  24 2019-05-04  Tom Tromey  <tom@tromey.com>
  25
  26         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  27         (lookup_partial_symbol, print_partial_symbols)
  28         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  29         (psymbol_compare): Update.
  30         (add_psymbol_to_bcache): Clear the entire psymbol.
  31         (maintenance_check_psymtabs): Update.
  32         * psympriv.h (struct partial_symbol): Don't derive from
  33         general_symbol_info.
  34         <obj_section, unrelocated_address, address,
  35         set_unrelocated_address>: Update.
  36         <ginfo>: New member.
  37         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  38         (debug_names::write_psymbols): Update.
  39
  40 2019-05-04  Tom de Vries  <tdevries@suse.de>
  41
  42         * contrib/cc-with-tweaks.sh: Support -n arg.
  43
  44 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  45
  46         * corelow.c (core_target::detach): Ensure frame cache and
  47         register caches are cleared.
  48         inferior.c (exit_inferior_1): Likewise.
  49
  50 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  51             Tom Tromey  <tom@tromey.com>
  52
  53         * dictionary.c (collate_pending_symbols_by_language): Remove
  54         "struct" from foreach.
  55         * symtab.c (lookup_global_symbol_from_objfile)
  56         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  57         foreach.
  58         * ser-tcp.c (net_open): Remove "struct" from foreach.
  59         * objfiles.c (objfile_relocate, objfile_rebase)
  60         (objfile_has_symbols): Remove "struct" from foreach.
  61         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  62         from foreach.
  63         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  64         foreach.
  65         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  66         "struct" from foreach.
  67         * ada-lang.c (create_excep_cond_exprs)
  68         (ada_exception_catchpoint_cond_string): Remove "struct" from
  69         foreach.
  70
  71 2019-05-03  Tom Tromey  <tromey@adacore.com>
  72
  73         * ada-exp.y (convert_char_literal): Check suffix of each
  74         enumerator.
  75
  76 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  77
  78         PR ada/21406:
  79         * ada-exp.y (yywrap): Don't define.
  80         * ada-lex.l (%option): Add noyywrap
  81         (yywrap): Remove.
  82
  83 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  84
  85         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  86         _WIN32_WINNT to the XP level, unless already defined to a higher
  87         level.
  88
  89         * unittests/parse-connection-spec-selftests.c:
  90         * ser-tcp.c:
  91         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  92         override.
  93
  94         * symfile.c (find_separate_debug_file): Remove colon from the
  95         drive spec of DOS/Windows file names of the target, so that the
  96         file name produced from DEBUGDIR and the target's directory will
  97         be valid on DOS/Windows systems.
  98
  99 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 100
 101         * rust-lang.c (val_print_struct): Handle printing structures
 102         containing strings.
 103
 104 2019-05-02  Tom Tromey  <tromey@adacore.com>
 105
 106         * valarith.c (_initialize_valarith): Remove.
 107
 108 2019-05-01  Tom Tromey  <tromey@adacore.com>
 109
 110         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 111         bitfields.
 112
 113 2019-05-01  Tom Tromey  <tromey@adacore.com>
 114
 115         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 116         for big-endian copies.
 117
 118 2019-04-30  Ali Tamur  <tamur@google.com>
 119         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 120         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 121         (read_3_bytes): New function.
 122
 123 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 124
 125         * windows-nat.c (main_thread_id): Delete.
 126         (handle_output_debug_string): Replace main_thread_id by
 127         current_event.dwThreadId.
 128         (fake_create_process): Likewise.
 129         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 130         Do not set main_thread_id.
 131         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 132         current_event.dwThreadId.
 133         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 134
 135 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 136
 137         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 138         Use current_event.dwThreadId instead of main_thread_id.
 139
 140 2019-04-30  Tom Tromey  <tromey@adacore.com>
 141
 142         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 143         (create_excep_cond_exprs): Iterate over program spaces.
 144         (ada_exception_catchpoint_cond_string): Examine all minimal
 145         symbols for exception types.
 146
 147 2019-04-30  Tom Tromey  <tromey@adacore.com>
 148
 149         PR c++/24470:
 150         * dwarf2read.c (process_structure_scope): Handle case where type
 151         has template parameters but no symbol was created.
 152
 153 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 154             Chris January  <chris.january@arm.com>
 155
 156         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 157         qualifier.
 158         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 159
 160 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * f-typeprint.c (f_print_type): Update rules for printing
 163         whitespace.
 164         (f_type_print_varspec_suffix): Likewise.
 165
 166 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 167             Chris January  <chris.january@arm.com>
 168
 169         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 170         function arguments.
 171
 172 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 173
 174         * f-lang.c (build_fortran_types): Change name of void type to
 175         lower case.
 176         * f-typeprint.c (f_type_print_base): Print the name of the void
 177         type, rather than a fixed string.
 178         * f-valprint.c (f_decorations): Use lower case void string.
 179
 180 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 181             Chris January  <chris.january@arm.com>
 182
 183         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 184         types for Fortran.
 185
 186 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 187             Chris January  <chris.january@arm.com>
 188             David Lecomber  <david.lecomber@arm.com>
 189
 190         * f-exp.y (BINOP_INTRINSIC): New token.
 191         (exp): New parser rule handling BINOP_INTRINSIC.
 192         (f77_keywords): Add new builtin procedures.
 193         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 194         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 195         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 196         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 197         (print_unop_subexp_f): New function.
 198         (print_binop_subexp_f): New function.
 199         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 200         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 201         (dump_subexp_body_f): Likewise.
 202         (operator_check_f): Likewise.
 203         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 204         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 205
 206 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 209         UNOP_KIND.
 210         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 211         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 212         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 213         (operator_length_f): New fuction.
 214         (print_subexp_f): New function.
 215         (op_name_f): New function.
 216         (dump_subexp_body_f): New function.
 217         (operator_check_f): New function.
 218         (exp_descriptor_f): Replace standard expression handling functions
 219         with new functions.
 220         * gdb/fortran-operator.def: New file.
 221         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 222         * gdb/std-operator.def: Remove UNOP_KIND.
 223
 224 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 225
 226         * std-operator.def: Remove unbalanced, stray double quote
 227         character.
 228
 229 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 230             Chris January  <chris.january@arm.com>
 231             Daniel Everett  <daniel.everett@arm.com>
 232             Nick Forrington  <nick.forrington@arm.com>
 233             Richard Bunt  <richard.bunt@arm.com>
 234
 235         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 236         of depth when printing anonymous structs or unions.
 237         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 238         Don't print either the top-level value, or the children if the
 239         max-depth is exceeded.
 240         (ppscm_print_children): When printing the key of a map, allow one
 241         extra level of depth.
 242         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 243         print either the top-level value, or the children if the max-depth
 244         is exceeded.
 245         (print_children): When printing the key of a map, allow one extra
 246         level of depth.
 247         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 248         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 249         (user_print_options): Initialise max_depth field.
 250         (val_print_scalar_or_string_type_p): New function.
 251         (val_print): Check to see if the max depth has been reached.
 252         (val_print_check_max_depth): Define new function.
 253         (show_print_max_depth): New function.
 254         (_initialize_valprint): Add 'print max-depth' option.
 255         * valprint.h (struct value_print_options) <max_depth>: New field.
 256         (val_print_check_max_depth): Declare new function.
 257         * NEWS: Document new feature.
 258
 259 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 260
 261         * ada-lang.c (ada_language_defn): Initialise new field.
 262         * c-lang.c (c_is_string_type_p): New function.
 263         (c_language_defn): Initialise new field.
 264         (cplus_language_defn): Initialise new field.
 265         (asm_language_defn): Initialise new field.
 266         (minimal_language_defn): Initialise new field.
 267         * c-lang.h (c_is_string_type_p): Declare new function.
 268         * d-lang.c (d_language_defn): Initialise new field.
 269         * f-lang.c (f_is_string_type_p): New function.
 270         (f_language_defn): Initialise new field.
 271         * go-lang.c (go_is_string_type_p): New function.
 272         (go_language_defn): Initialise new field.
 273         * language.c (default_is_string_type_p): New function.
 274         (unknown_language_defn): Initialise new field.
 275         (auto_language_defn): Initialise new field.
 276         * language.h (struct language_defn) <la_is_string_type_p>: New
 277         member variable.
 278         (default_is_string_type_p): Declare new function.
 279         * m2-lang.c (m2_language_defn): Initialise new field.
 280         * objc-lang.c (objc_language_defn): Initialise new field.
 281         * opencl-lang.c (opencl_language_defn): Initialise new field.
 282         * p-lang.c (pascal_is_string_type_p): New function.
 283         (pascal_language_defn): Initialise new field.
 284         * rust-lang.c (rust_is_string_type_p): New function.
 285         (rust_language_defn): Initialise new field.
 286
 287 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 290         New field.
 291         * ada-lang.c (ada_language_defn): Initialise new field.
 292         * c-lang.c (c_language_defn): Likewise.
 293         (cplus_language_defn): Likewise.
 294         (asm_language_defn): Likewise.
 295         (minimal_language_defn): Likewise.
 296         * d-lang.c (d_language_defn): Likewise.
 297         * f-lang.c (f_language_defn): Likewise.
 298         * go-lang.c (go_language_defn): Likewise.
 299         * language.c (unknown_language_defn): Likewise.
 300         (auto_language_defn): Likewise.
 301         * m2-lang.c (m2_language_defn): Likewise.
 302         * objc-lang.c (objc_language_defn): Likewise.
 303         * opencl-lang.c (opencl_language_defn): Likewise.
 304         * p-lang.c (pascal_language_defn): Likewise.
 305         * rust-lang.c (rust_language_defn): Likewise.
 306
 307 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * ada-lang.c (ada_is_character_type): Change return type to bool.
 310         (ada_is_string_type): Likewise.
 311         * ada-lang.h (ada_is_character_type): Update declaration
 312         (ada_is_string_type): Likewise.
 313
 314 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 315
 316         Support style in 'frame|thread apply'
 317
 318         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 319         * record.c (record_start, record_stop): Update callers of
 320         execute_command_to_string with false.
 321         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 322         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 323         methods.
 324         (class string_file): New constructor with term_out parameter.
 325         Override methods term_out and can_emit_style_escape.  New member
 326         term_out.
 327         (class stdio_file): Override can_emit_style_escape.
 328         (class tee_file): Override term_out and can_emit_style_escape.
 329         * utils.h (can_emit_style_escape): Remove.
 330         * utils.c (can_emit_style_escape): Likewise.
 331         Update all callers of can_emit_style_escape (SOMESTREAM) to
 332         SOMESTREAM->can_emit_style_escape.
 333         * source-cache.c (source_cache::get_source_lines): Likewise.
 334         * stack.c (frame_apply_command_count): Call execute_command_to_string
 335         passing the term_out characteristic of the current gdb_stdout.
 336         * thread.c (thr_try_catch_cmd): Likewise.
 337         * top.c (execute_command_to_string): pass term_out parameter
 338         to construct the string_file for the command output.
 339         * ui-file.c (term_cli_styling): New function (most code moved
 340         from utils.c can_emit_style_escape).
 341         (string_file::string_file, string_file::can_emit_style_escape,
 342         stdio_file::can_emit_style_escape, tee_file::term_out,
 343         tee_file::can_emit_style_escape): New functions.
 344
 345 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 346
 347         * NEWS: Mention the new set|show may-call-functions.
 348         * infcall.c (may_call_functions_p): New variable.
 349         (show_may_call_functions_p): New function.
 350         (call_function_by_hand_dummy): Throws an error if not
 351         may-call-functions.
 352         (_initialize_infcall): Call add_setshow_boolean_cmd for
 353         may-call-functions.
 354
 355 2019-04-25  Keith Seitz  <keiths@redhat.com>
 356
 357         PR c++/24367
 358         * cp-support.c (inspect_type): Don't attempt substitutions
 359         of symbol with the same name.
 360
 361 2019-04-25  Tom Tromey  <tromey@adacore.com>
 362
 363         PR gdb/24475:
 364         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 365         static.
 366
 367 2019-04-25  Tom Tromey  <tromey@adacore.com>
 368
 369         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 370         rvalue reference.
 371         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 372         (gdb_xml_parser::parse): Use std::move.
 373         * python/python-internal.h (gdbpy_convert_exception): Take a const
 374         reference.
 375         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 376         std::move.
 377         * python/py-utils.c (gdbpy_convert_exception): Take a const
 378         reference.
 379         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 380         Use std::move.
 381         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 382         Use std::move.
 383         * mi/mi-main.c (mi_print_exception): Take a const reference.
 384         * main.c (handle_command_errors): Take a const reference.
 385         * linespec.c (parse_linespec): Use std::move.
 386         * infcall.c (run_inferior_call): Use std::move.
 387         (call_function_by_hand_dummy): Use std::move.
 388         * exec.c (try_open_exec_file): Use std::move.
 389         * exceptions.h (exception_print, exception_fprintf)
 390         (exception_print_same): Update.
 391         * exceptions.c (print_exception, exception_print)
 392         (exception_fprintf, exception_print_same): Change parameters to
 393         const reference.
 394         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 395         * common/new-op.c: Use std::move.
 396         * common/common-exceptions.h (struct gdb_exception): Add move
 397         constructor.
 398         (struct gdb_exception_error, struct gdb_exception_quit, struct
 399         gdb_quit_bad_alloc): Change constructor to move constructor.
 400         (throw_exception): Change parameter to rvalue reference.
 401         * common/common-exceptions.c (throw_exception): Take rvalue
 402         reference.
 403         * cli/cli-interp.c (safe_execute_command): Use std::move.
 404         * breakpoint.c (insert_bp_location, location_to_sals): Use
 405         std::move.
 406
 407 2019-04-25  Tom Tromey  <tromey@adacore.com>
 408
 409         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 410         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 411         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 412         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 413         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 414         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 415         guile/scm-value.c: Use unpack.
 416         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 417         gdbscm_gdb_exception.
 418         (gdbscm_throw_gdb_exception): Likewise.
 419         (struct gdbscm_gdb_exception): New.
 420         (unpack): New function.
 421         (gdbscm_wrap): Use unpack.
 422
 423 2019-04-25  Tom Tromey  <tromey@adacore.com>
 424
 425         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 426         (gdb_rl_callback_handler): Use std::move.
 427         * common/common-exceptions.h (struct gdb_exception): Add move
 428         assignment operator.
 429         (throw_exception_sjlj): Change "exception" to const reference.
 430         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 431         (throw_exception_sjlj): Change "exception" to const reference.
 432
 433 2019-04-25  Tom Tromey  <tromey@adacore.com>
 434
 435         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 436         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 437         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 438         Update.
 439         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 440         Update.
 441         * mi/mi-interp.c (mi_interp::exec): Update.
 442         * linespec.c (parse_linespec): Update.
 443         * infcall.c (run_inferior_call): Update.
 444         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 445         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 446         (gdbscm_lookup_global_symbol): Update.
 447         * guile/scm-param.c (gdbscm_parameter_value): Update.
 448         * guile/scm-frame.c (gdbscm_frame_read_register)
 449         (gdbscm_frame_read_var): Update.
 450         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 451         * exec.c (try_open_exec_file): Update.
 452         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 453         (gdb_rl_callback_handler): Update.
 454         * common/common-exceptions.h (exception_none): Don't declare.
 455         * common/common-exceptions.c (exception_none): Don't define.
 456         (struct catcher) <exception>: Update.
 457         * cli/cli-interp.c (safe_execute_command): Update.
 458         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 459
 460 2019-04-25  Ali Tamur  <tamur@google.com>
 461
 462         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 463         (read_attribute_value): Likewise.
 464         (dwarf2_read_addr_index): Update comment.
 465         (read_str_index): Add DW_FORM_strx.
 466         (dwarf2_string_attr): Likewise.
 467         (dwarf2_const_value_attr): Likewise.
 468         (dump_die_shallow): Likewise.
 469         (dwarf2_fetch_constant_bytes): Likewise.
 470         (skip_form_bytes): Likewise.
 471         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 472
 473 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 474
 475         PR corefiles/11608
 476         PR corefiles/18187
 477         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 478         OFFSET.  Verify if current mapping contains an ELF header.
 479         (linux_find_memory_regions_full): Adjust call to
 480         dump_mapping_p.
 481
 482 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 483             Kang Li <kanglictf@gmail.com>
 484
 485         PR gdb/21600
 486
 487         * dwarf2-frame.c (read_initial_length): Be consistent about using
 488         unsigned representation of length.
 489         (decode_frame_entry_1): Likewise.  Check for wraparound of
 490         end pointer as well as buffer overflow.
 491
 492 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 493
 494         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 495         "vq".
 496
 497 2019-04-24  Tom Tromey  <tromey@adacore.com>
 498
 499         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 500
 501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * s12z-tdep.c (s12z_unwind_pc): Delete.
 504         (s12z_unwind_sp): Delete.
 505         (s12z_gdbarch_init): Don't register deleted functions with
 506         gdbarch.
 507
 508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * rl78-tdep.c (rl78_unwind_sp): Delete.
 511         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 512
 513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 516         (xstormy16_unwind_pc): Delete.
 517         (xstormy16_dummy_id): Delete.
 518         (xstormy16_gdbarch_init): Don't register deleted functions with
 519         gdbarch.
 520
 521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * vax-tdep.c (vax_unwind_pc): Delete.
 524         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 525
 526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * v850-tdep.c (v850_unwind_sp): Delete.
 529         (v850_unwind_pc): Delete.
 530         (v850_dummy_id): Delete.
 531         (v850_gdbarch_init): Don't register deleted functions with
 532         gdbarch.
 533
 534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 535
 536         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 537         (tilegx_unwind_pc): Delete.
 538         (tilegx_unwind_dummy_id): Delete.
 539         (tilegx_gdbarch_init): Don't register deleted functions with
 540         gdbarch.
 541
 542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 545         (tic6x_dummy_id): Delete.
 546         (tic6x_gdbarch_init): Don't register deleted functions with
 547         gdbarch.
 548
 549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * sparc-tdep.c (sparc_unwind_pc): Delete.
 552         (sparc32_gdbarch_init): Don't register deleted function with
 553         gdbarch.
 554
 555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 556
 557         * sh-tdep.c (sh_unwind_sp): Delete.
 558         (sh_unwind_pc): Delete.
 559         (sh_dummy_id): Delete.
 560         (sh_gdbarch_init): Don't register deleted functions with
 561         gdbarch.
 562
 563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * score-tdep.c (score_unwind_sp): Delete.
 566         (score_unwind_pc): Delete.
 567         (score_dummy_id): Delete.
 568         (score_gdbarch_init): Don't register deleted functions with
 569         gdbarch.
 570
 571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * rx-tdep.c (rx_unwind_pc): Delete.
 574         (rx_unwind_sp): Delete.
 575         (rx_dummy_id): Delete.
 576         (rx_gdbarch_init): Don't register deleted functions with
 577         gdbarch.  Update comment.
 578
 579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 582         (rs6000_dummy_id): Delete.
 583         (rs6000_gdbarch_init): Don't register deleted functions with
 584         gdbarch.
 585
 586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 587
 588         * or1k-tdep.c (or1k_dummy_id): Delete.
 589         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 590
 591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         * nios2-tdep.c (nios2_dummy_id): Delete.
 594         (nios2_unwind_sp): Delete.
 595         (nios2_gdbarch_init): Don't register deleted functions with
 596         gdbarch.
 597
 598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * nds32-tdep.c (nds32_dummy_id): Delete.
 601         (nds32_unwind_pc): Delete.
 602         (nds32_unwind_sp): Delete.
 603         (nds32_gdbarch_init): Don't register deleted functions with
 604         gdbarch.
 605
 606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * msp430-tdep.c (msp430_unwind_pc): Delete.
 609         (msp430_unwind_sp): Delete.
 610         (msp430_dummy_id): Delete.
 611         (msp430_gdbarch_init): Don't register deleted functions with
 612         gdbarch.
 613
 614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * moxie-tdep.c (moxie_unwind_sp): Delete.
 617         (moxie_unwind_pc): Delete.
 618         (moxie_dummy_id): Delete.
 619         (moxie_gdbarch_init): Don't register deleted functions with
 620         gdbarch.
 621
 622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 623
 624         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 625         (mn10300_unwind_pc): Delete.
 626         (mn10300_unwind_sp): Delete.
 627         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 628         mn10300_unwind_sp.
 629         (mn10300_frame_unwind_init): Don't register deleted functions with
 630         gdbarch.
 631
 632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * mep-tdep.c (mep_unwind_pc): Delete.
 635         (mep_unwind_sp): Delete.
 636         (mep_dummy_id): Delete.
 637         (mep_gdbarch_init): Don't register deleted functions with
 638         gdbarch.
 639
 640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 641
 642         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 643         (m68hc11_unwind_sp): Delete.
 644         (m68hc11_gdbarch_init): Don't register deleted functions with
 645         gdbarch.
 646
 647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * m32r-tdep.c (m32r_unwind_sp): Delete.
 650         (m32r_unwind_pc): Delete.
 651         (m32r_dummy_id): Delete.
 652         (m32r_gdbarch_init): Don't register deleted functions with
 653         gdbarch.
 654
 655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * m32c-tdep.c (m32c_unwind_pc): Delete.
 658         (m32c_unwind_sp): Delete.
 659         (m32c_dummy_id): Delete.
 660         (m32c_gdbarch_init): Don't register deleted functions with
 661         gdbarch.
 662
 663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 666         (lm32_unwind_pc): Delete.
 667         (lm32_dummy_id): Delete.
 668         (lm32_gdbarch_init): Don't register deleted functions with
 669         gdbarch.
 670
 671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 672
 673         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 674         (iq2000_unwind_pc): Delete.
 675         (iq2000_dummy_id): Delete.
 676         (iq2000_gdbarch_init): Don't register deleted functions with
 677         gdbarch.
 678
 679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * nds32-tdep.c (nds32_type_align): Delete.
 682         (nds32_push_dummy_call): Use type_align instead.
 683
 684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 685
 686         * arm-tdep.c (arm_type_align): Only handle vector override case.
 687         (arm_push_dummy_call): Use type_align.
 688         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 689
 690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 693         case.
 694         (pass_on_stack): Use type_align.
 695         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 696         function.
 697
 698 2019-04-23  Tom Tromey  <tromey@adacore.com>
 699
 700         * dwarf2read.c (line_header::file_name_at): Remove unused
 701         overload.
 702
 703 2019-04-23  Tom de Vries  <tdevries@suse.de>
 704
 705         PR gdb/24438
 706         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 707         invocation.
 708
 709
 710 2019-03-27  Ali Tamur  <tamur@google.com>
 711
 712         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 713         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 714         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 715         (dwarf_expr_context::get_addr_index): Likewise
 716         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 717         (symbol_needs_eval_context::get_addr_index): Likewise
 718         (disassemble_dwarf_expression): Add DW_OP_addrx
 719         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 720         (read_cutu_die_from_dwo): Update comment
 721         (skip_one_die): Add DW_FORM_addrx
 722         (read_attribute_value): Likewise
 723         (var_decode_location): Add DW_OP_addrx
 724         (dwarf2_const_value_attr): Add DW_FORM_addrx
 725         (dump_die_shallow): Likewise
 726         (dwarf2_fetch_constant_bytes): Likewise
 727         (decode_locdesc): Add DW_OP_addrx
 728         (skip_form_bytes): Add DW_FORM_addrx
 729
 730 2019-04-22  Ali Tamur  <tamur@google.com>
 731
 732         * MAINTAINERS (Write After Approval): Add self.
 733
 734 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 735
 736         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 737         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 738         (open_symbol_file_object): Likewise.
 739         (svr4_default_sos): Add info parameter.
 740         (svr4_read_so_list): Likewise.
 741         (svr4_current_sos_direct): Adjust functions calls to pass down
 742         info.
 743         (svr4_current_sos_1): Add info parameter.
 744         (svr4_current_sos): Call get_svr4_info, pass info down to
 745         svr4_current_sos_1.
 746         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 747         get_svr4_info.
 748         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 749         get_svr4_info.
 750         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 751         to get_svr4_info.
 752         (probes_table_remove_objfile_probes): Likewise.
 753         (register_solib_event_probe): Add info parameter.
 754         (solist_update_incremental): Pass info parameter down to
 755         svr4_read_so_list.
 756         (disable_probes_interface): Add info parameter.
 757         (svr4_handle_solib_event): Pass current_program_space to
 758         get_svr4_info.  Adjust disable_probes_interface cleanup.
 759         (svr4_create_probe_breakpoints): Add info parameter, pass it
 760         down to register_solib_event_probe.
 761         (svr4_create_solib_event_breakpoints): Add info parameter,
 762         pass it down to svr4_create_probe_breakpoints.
 763         (enable_break): Pass info down to
 764         svr4_create_solib_event_breakpoints.
 765         (svr4_solib_create_inferior_hook): Pass current_program_space to
 766         get_svr4_info.
 767         (svr4_clear_solib): Likewise.
 768
 769 2019-04-22  Pedro Alves  <palves@redhat.com>
 770
 771         * solib-svr4.c (svr4_free_objfile_observer): New.
 772         (probe_and_action::objfile): New field.
 773         (probes_table_htab_remove_objfile_probes)
 774         (probes_table_remove_objfile_probes): New functions.
 775         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 776         in the new probe_and_action.  Don't store the probe in 'lookup'.
 777         (svr4_create_probe_breakpoints): Pass objfile to
 778         register_solib_event_probe.
 779         (_initialize_svr4_solib): Register a free_objfile observer.
 780
 781 2019-04-19  Tom Tromey  <tom@tromey.com>
 782
 783         * common/queue.h: Remove.
 784
 785 2019-04-19  Tom Tromey  <tom@tromey.com>
 786
 787         * event-loop.c: Don't include "common/queue.h".
 788
 789 2019-04-19  Tom Tromey  <tom@tromey.com>
 790
 791         * remote.c (remote_target): Use delete.
 792         * remote-notif.h: Include <list>, not "common/queue.h".
 793         (notif_client_p): Remove typedef.
 794         (remote_notif_state): Add constructor, destructor, initializer.
 795         <notif_queue>: Now a std::list.
 796         (remote_notif_state_xfree): Don't declare.
 797         * remote-notif.c (remote_notif_process, handle_notification)
 798         (remote_notif_state_allocate): Update.
 799         (~remote_notif_state): Rename from remote_notif_state_xfree.
 800
 801 2019-04-19  Tom Tromey  <tom@tromey.com>
 802
 803         * symfile.c (reread_symbols): Update.
 804         * objfiles.c (objfile_register_static_link)
 805         (objfile_lookup_static_link): Update
 806         (~objfile) Don't delete static_links.
 807         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 808
 809 2019-04-19  Tom Tromey  <tom@tromey.com>
 810
 811         * type-stack.h (struct type_stack) <insert>: Constify string.
 812         * type-stack.c (type_stack::insert): Constify string.
 813         * gdbtypes.h (lookup_template_type): Update.
 814         (address_space_name_to_int): Update.
 815         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 816         const.
 817         (lookup_template_type): Make name const.
 818         * c-exp.y: Update rules.
 819         (lex_one_token, classify_name, classify_inner_name)
 820         (c_print_token): Update.
 821         * p-exp.y: Update rules.
 822         (yylex): Update.
 823         * f-exp.y: Update rules.
 824         (yylex): Update.
 825         * d-exp.y: Update rules.
 826         (lex_one_token, classify_name, classify_inner_name): Update.
 827         * parse.c (write_dollar_variable, copy_name): Return std::string.
 828         * parser-defs.h (copy_name): Change return type.
 829         * m2-exp.y: Update rules.
 830         (yylex): Update.
 831         * go-exp.y (lex_one_token): Update.
 832         Update rules.
 833         (classify_unsafe_function, classify_packaged_name)
 834         (classify_name, yylex): Update.
 835
 836 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 837
 838         * configure.ac: add --enable-source-highlight switch.
 839         * configure: Regenerate.
 840         * top.c (print_gdb_version): plumb --enable-source-highlight
 841         status to "show configuration".
 842
 843 2019-04-19  Tom Tromey  <tromey@adacore.com>
 844
 845         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 846         Check ADA_TYPE_P.
 847         (empty_record, ada_template_to_fixed_record_type_1)
 848         (template_to_static_fixed_type)
 849         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 850         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 851         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 852         macros.
 853
 854 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 855
 856         PR symtab/24423:
 857         * source.c (print_source_lines_base): Advance "iter" when a
 858         control character is seen.
 859
 860 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 861
 862         * inferior.h (struct infcall_suspend_state_deleter):
 863         Catch exception in destructor to avoid crash.
 864
 865 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 866
 867         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 868         close to the add_com "shell".
 869
 870 2019-04-18  Tom Tromey  <tromey@adacore.com>
 871
 872         * process-stratum-target.h (class process_stratum_target)
 873         <stratum>: Add "final".
 874
 875 2019-04-17  Tom Tromey  <tromey@adacore.com>
 876
 877         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 878         against nullptr before use.
 879
 880 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 881
 882         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 883
 884 2019-04-17  Jim Wilson  <jimw@sifive.com>
 885             Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 888         code read might fail, assume 4-byte breakpoint in that case.
 889
 890 2019-04-15  Leszek Swirski  <leszeks@google.com>
 891
 892         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 893         rather than a hand-rolled POD check when checking for forced MEMORY
 894         classification.
 895
 896 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 899         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 900         function.
 901         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 902         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 903         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 904         declaration.
 905
 906 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 907
 908         * aarch64-linux-nat.c
 909         (aarch64_linux_nat_target::thread_architecture): Add override.
 910         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 911         each VQ.
 912
 913 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 914
 915         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 916
 917 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 920         target types of size 96-bits, add some additional comments, and
 921         check that the builtin type we found was the correct size.
 922
 923 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 924
 925         * utils.c (prompt_for_continue): Don't restore the styling at the
 926         end, as applied_style has the wrong value.  This fixes styling in
 927         long lists of file names that are interrupted by the "Continue?"
 928         prompt.
 929
 930 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 933         * c-lang.c (c_language_defn): Likewise.
 934         (cplus_language_defn): Likewise.
 935         (asm_language_defn): Likewise.
 936         (minimal_language_defn): Likewise.
 937         * d-lang.c (d_language_defn): Likewise.
 938         * f-lang.c (f_language_defn): Likewise.
 939         * go-lang.c (go_language_defn): Likewise.
 940         * language.c (unknown_language_defn): Likewise.
 941         (auto_language_defn): Likewise.
 942         * language.h (struct language_defn): Remove la_magic field.
 943         (LANG_MAGIC): Delete.
 944         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 945         * objc-lang.c (objc_language_defn): Likewise.
 946         * opencl-lang.c (opencl_language_defn): Likewise.
 947         * p-lang.c (pascal_language_defn): Likewise.
 948         * rust-lang.c (rust_language_defn): Likewise.
 949
 950 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * riscv-tdep.c (riscv_type_align): New function.
 953         (riscv_type_alignment): Delete.
 954         (riscv_arg_location): Use 'type_align'.
 955         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 956
 957 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * gdbtypes.c (type_align): A struct with no non-static fields also
 960         has alignment of 1.
 961
 962 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 965         component to 0.
 966         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 967         member.
 968         (riscv_struct_info::analyse): New implementation using new
 969         analyse_inner member function.
 970         (riscv_struct_info::field_offset): New member function.
 971         (riscv_struct_info::m_offsets): New member variable.
 972         (riscv_struct_info::analyse_inner): New private member function,
 973         takes the old implementation of riscv_struct_info::analyse but
 974         extended to track field offsets.
 975         (riscv_call_arg_struct): Update the struct folding special cases
 976         to handle cases where empty C++ structs, which are non-zero
 977         length, are found.
 978         (riscv_arg_location): Initialise the length of each location, a
 979         non-zero length now indicates the location is in use.
 980         (riscv_push_dummy_call): Allow for the first location having a
 981         non-zero offset when setting up arguments.
 982         (riscv_return_value): Likewise, but for return values.
 983
 984 2019-04-11  Tom Tromey  <tromey@adacore.com>
 985
 986         * utils.c (internal_vproblem): Make "msg" const.
 987
 988 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 989
 990         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 991         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 992         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 993         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 994
 995 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 996
 997         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 998         function.
 999         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1000         of amd64_collect_native_gregset.
1001         (amd64_linux_nat_target::store_registers): Likewise.
1002
1003 2019-04-10  Tom Tromey  <tom@tromey.com>
1004
1005         * symtab.c (lookup_global_symbol_from_objfile)
1006         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1007         * objfiles.h (class separate_debug_iterator): New.
1008         (class separate_debug_range): New.
1009         (struct objfile) <separate_debug_objfiles>: New method.
1010         (objfile_separate_debug_iterate): Don't declare.
1011         * objfiles.c (separate_debug_iterator::operator++): Rename from
1012         objfile_separate_debug_iterate.
1013         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1014         iterator.
1015         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1016         iterator.
1017
1018 2019-04-10  Tom Tromey  <tom@tromey.com>
1019
1020         * symfile.c (reread_symbols): Remove old comment.
1021         * objfiles.c (free_all_objfiles): Fix a typo.
1022
1023 2019-04-10  Tom Tromey  <tom@tromey.com>
1024
1025         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1026         * minsyms.c (lookup_minimal_symbol): Use foreach.
1027         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1028         (lookup_minimal_symbol_solib_trampoline): Likewise.
1029         * symfile.c (reread_symbols): Use foreach.
1030
1031 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1032             Tom Tromey  <tromey@adacore.com>
1033
1034         PR rust/24414:
1035         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1036         (rust_lex_int_test): Change "value" to be LONGEST.
1037         (rust_lex_tests): Add test for long integer literal.
1038
1039 2019-04-09  Tom Tromey  <tromey@adacore.com>
1040
1041         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1042         to bool.
1043         (extended_remote_target::attach): Update.
1044         (remote_target::remote_notice_new_inferior): Update.
1045         (remote_target::add_current_inferior_and_thread): Update.
1046         * inferior.c (exit_inferior_1): Use "false".
1047         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1048
1049 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1050
1051         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1052         the "start" command.
1053
1054 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1055
1056         * python/py-inferior.c (infpy_thread_from_thread_handle):
1057         Adjust comments to reflect renaming of thread_from_thread_handle
1058         to thread_from_handle.  Adjust keywords.  Fix type error message.
1059         (inferior_object_methods): Add thread_from_handle.  Retain
1060         thread_from_thread_handle, but mark it as deprecated.
1061
1062 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1063
1064         * gdbthread.h (find_thread_by_handle): Revise declaration.
1065         * thread.c (find_thread_by_handle): Likewise.  Adjust
1066         implementation too.
1067         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1068         support for buffer objects as handles.
1069
1070 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1071
1072         * python/py-infthread.c (thpy_thread_handle): New function.
1073         (thread_object_methods): Register thpy_thread_handle.
1074
1075 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1076
1077         * gdbthread.h (thread_to_thread_handle): Declare.
1078         * thread.c (gdbtypes.h): Include.
1079         (thread_to_thread_handle): New function.
1080
1081         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1082         (target_thread_info_to_thread_handle): Declare.
1083         * target.c (target_thread_info_to_thread_handle): New function.
1084         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1085         * target-delegates.c: Regenerate.
1086
1087         * linux-thread-db.c (class thread_db_target): Add method
1088         thread_info_to_thread_handle.
1089         (thread_db_target::thread_info_to_thread_handle): Define.
1090         * remote.c (class remote_target): Add new method
1091         thread_info_to_thread_handle.
1092         (remote_target::thread_info_to_thread_handle): Define.
1093
1094 2019-04-08  Pedro Alves  <palves@redhat.com>
1095
1096         * common/common-exceptions.c (throw_exception): Don't create
1097         named object to throw; throw directly.
1098         (throw_it): Likewise.  Don't initialize gdb_exception::message
1099         here, with new; pass FMT and AP to the ctor instead.
1100         * common/common-exceptions.h: Include <string>.
1101         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1102         const char *, va_list)): New ctor.  Use std::make_shared.
1103         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1104         errors)): Delete.
1105         (gdb_exception_error::gdb_exception_error(enum errors, const char
1106         *, va_list)): New.
1107         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1108         Add assertion.
1109         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1110         errors)): Delete.
1111         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1112         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1113         Add assertion.
1114
1115 2019-04-08  Tom Tromey  <tom@tromey.com>
1116
1117         * valops.c (value_rtti_indirect_type): Replace throw_exception
1118         with throw.
1119         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1120         with throw.
1121         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1122         throw.
1123         * target.c (target_translate_tls_address): Replace throw_exception
1124         with throw.
1125         * stack.c (frame_apply_command_count): Replace throw_exception
1126         with throw.
1127         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1128         throw.
1129         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1130         with throw.
1131         * rs6000-tdep.c (rs6000_frame_cache)
1132         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1133         * remote.c: Replace throw_exception with throw.
1134         * record-full.c (record_full_message, record_full_wait_1)
1135         (record_full_restore): Replace throw_exception with throw.
1136         * record-btrace.c:
1137         (get_thread_current_frame_id, record_btrace_start_replaying)
1138         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1139         (cmd_record_btrace_start): Replace throw_exception with throw.
1140         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1141         throw.
1142         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1143         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1144         * linespec.c:
1145         (find_linespec_symbols): Replace throw_exception with throw.
1146         * infrun.c (displaced_step_prepare, resume): Replace
1147         throw_exception with throw.
1148         * infcmd.c (post_create_inferior): Replace throw_exception with
1149         throw.
1150         * inf-loop.c (inferior_event_handler): Replace throw_exception
1151         with throw.
1152         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1153         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1154         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1155         (get_prev_frame_always, get_frame_pc_if_available)
1156         (get_frame_address_in_block_if_available, get_frame_language):
1157         Replace throw_exception with throw.
1158         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1159         throw_exception with throw.
1160         * eval.c (fetch_subexp_value, evaluate_var_value)
1161         (evaluate_funcall, evaluate_subexp_standard): Replace
1162         throw_exception with throw.
1163         * dwarf2loc.c (call_site_find_chain)
1164         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1165         Replace throw_exception with throw.
1166         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1167         with throw.
1168         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1169         throw.
1170         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1171         * completer.c (complete_line_internal): Replace throw_exception
1172         with throw.
1173         * compile/compile-object-run.c (compile_object_run): Replace
1174         throw_exception with throw.
1175         * cli/cli-script.c (process_next_line): Replace throw_exception
1176         with throw.
1177         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1178         (btrace_enable, btrace_maint_update_pt_packets): Replace
1179         throw_exception with throw.
1180         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1181         throw_exception with throw.
1182         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1183         throw_exception with throw.
1184         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1185         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1186         * aarch64-tdep.c (aarch64_make_prologue_cache)
1187         (aarch64_make_stub_cache): Replace throw_exception with throw.
1188
1189 2019-04-08  Tom Tromey  <tom@tromey.com>
1190
1191         * common/common-exceptions.c (throw_exception): Rename from
1192         throw_exception_cxx.  Remove old copy.  Make argument const.
1193         (throw_it): Create and throw exception objects directly.
1194         * common/common-exceptions.h (throw_exception): Make argument
1195         const.
1196         (struct gdb_exception_error): Add constructor.
1197         (struct gdb_exception_quit): Add constructor.
1198
1199 2019-04-08  Tom Tromey  <tom@tromey.com>
1200
1201         * common/common-exceptions.h (exception_rethrow): Don't declare.
1202         (TRY_SJLJ): Update comment.
1203         (TRY, CATCH, END_CATCH): Remove.
1204         * common/common-exceptions.c (exception_rethrow): Remove.
1205
1206 2019-04-08  Tom Tromey  <tom@tromey.com>
1207
1208         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1209         Remove.
1210         (gdb_exception_error): Rename from
1211         gdb_exception_RETURN_MASK_ERROR.
1212         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1213         (gdb_quit_bad_alloc): Update.
1214         * aarch64-tdep.c: Update.
1215         * ada-lang.c: Update.
1216         * ada-typeprint.c: Update.
1217         * ada-valprint.c: Update.
1218         * amd64-tdep.c: Update.
1219         * arch-utils.c: Update.
1220         * break-catch-throw.c: Update.
1221         * breakpoint.c: Update.
1222         * btrace.c: Update.
1223         * c-varobj.c: Update.
1224         * cli/cli-cmds.c: Update.
1225         * cli/cli-interp.c: Update.
1226         * cli/cli-script.c: Update.
1227         * common/common-exceptions.c: Update.
1228         * common/new-op.c: Update.
1229         * common/selftest.c: Update.
1230         * compile/compile-c-symbols.c: Update.
1231         * compile/compile-cplus-symbols.c: Update.
1232         * compile/compile-object-load.c: Update.
1233         * compile/compile-object-run.c: Update.
1234         * completer.c: Update.
1235         * corelow.c: Update.
1236         * cp-abi.c: Update.
1237         * cp-support.c: Update.
1238         * cp-valprint.c: Update.
1239         * darwin-nat.c: Update.
1240         * disasm-selftests.c: Update.
1241         * dtrace-probe.c: Update.
1242         * dwarf-index-cache.c: Update.
1243         * dwarf-index-write.c: Update.
1244         * dwarf2-frame-tailcall.c: Update.
1245         * dwarf2-frame.c: Update.
1246         * dwarf2loc.c: Update.
1247         * dwarf2read.c: Update.
1248         * eval.c: Update.
1249         * event-loop.c: Update.
1250         * event-top.c: Update.
1251         * exec.c: Update.
1252         * f-valprint.c: Update.
1253         * fbsd-tdep.c: Update.
1254         * frame-unwind.c: Update.
1255         * frame.c: Update.
1256         * gdbtypes.c: Update.
1257         * gnu-v3-abi.c: Update.
1258         * guile/guile-internal.h: Update.
1259         * guile/scm-block.c: Update.
1260         * guile/scm-breakpoint.c: Update.
1261         * guile/scm-cmd.c: Update.
1262         * guile/scm-disasm.c: Update.
1263         * guile/scm-frame.c: Update.
1264         * guile/scm-lazy-string.c: Update.
1265         * guile/scm-math.c: Update.
1266         * guile/scm-param.c: Update.
1267         * guile/scm-ports.c: Update.
1268         * guile/scm-pretty-print.c: Update.
1269         * guile/scm-symbol.c: Update.
1270         * guile/scm-symtab.c: Update.
1271         * guile/scm-type.c: Update.
1272         * guile/scm-value.c: Update.
1273         * i386-linux-tdep.c: Update.
1274         * i386-tdep.c: Update.
1275         * inf-loop.c: Update.
1276         * infcall.c: Update.
1277         * infcmd.c: Update.
1278         * infrun.c: Update.
1279         * jit.c: Update.
1280         * language.c: Update.
1281         * linespec.c: Update.
1282         * linux-fork.c: Update.
1283         * linux-nat.c: Update.
1284         * linux-tdep.c: Update.
1285         * linux-thread-db.c: Update.
1286         * main.c: Update.
1287         * mi/mi-cmd-break.c: Update.
1288         * mi/mi-cmd-stack.c: Update.
1289         * mi/mi-interp.c: Update.
1290         * mi/mi-main.c: Update.
1291         * objc-lang.c: Update.
1292         * p-valprint.c: Update.
1293         * parse.c: Update.
1294         * ppc-linux-tdep.c: Update.
1295         * printcmd.c: Update.
1296         * python/py-arch.c: Update.
1297         * python/py-breakpoint.c: Update.
1298         * python/py-cmd.c: Update.
1299         * python/py-finishbreakpoint.c: Update.
1300         * python/py-frame.c: Update.
1301         * python/py-framefilter.c: Update.
1302         * python/py-gdb-readline.c: Update.
1303         * python/py-inferior.c: Update.
1304         * python/py-infthread.c: Update.
1305         * python/py-lazy-string.c: Update.
1306         * python/py-linetable.c: Update.
1307         * python/py-objfile.c: Update.
1308         * python/py-param.c: Update.
1309         * python/py-prettyprint.c: Update.
1310         * python/py-progspace.c: Update.
1311         * python/py-record-btrace.c: Update.
1312         * python/py-record.c: Update.
1313         * python/py-symbol.c: Update.
1314         * python/py-type.c: Update.
1315         * python/py-unwind.c: Update.
1316         * python/py-utils.c: Update.
1317         * python/py-value.c: Update.
1318         * python/python.c: Update.
1319         * record-btrace.c: Update.
1320         * record-full.c: Update.
1321         * remote-fileio.c: Update.
1322         * remote.c: Update.
1323         * riscv-tdep.c: Update.
1324         * rs6000-aix-tdep.c: Update.
1325         * rs6000-tdep.c: Update.
1326         * rust-exp.y: Update.
1327         * rust-lang.c: Update.
1328         * s390-tdep.c: Update.
1329         * selftest-arch.c: Update.
1330         * solib-dsbt.c: Update.
1331         * solib-frv.c: Update.
1332         * solib-spu.c: Update.
1333         * solib-svr4.c: Update.
1334         * solib.c: Update.
1335         * sparc64-linux-tdep.c: Update.
1336         * stack.c: Update.
1337         * symfile-mem.c: Update.
1338         * symmisc.c: Update.
1339         * target.c: Update.
1340         * thread.c: Update.
1341         * top.c: Update.
1342         * tracefile-tfile.c: Update.
1343         * tui/tui.c: Update.
1344         * typeprint.c: Update.
1345         * unittests/cli-utils-selftests.c: Update.
1346         * unittests/parse-connection-spec-selftests.c: Update.
1347         * valops.c: Update.
1348         * valprint.c: Update.
1349         * value.c: Update.
1350         * varobj.c: Update.
1351         * windows-nat.c: Update.
1352         * x86-linux-nat.c: Update.
1353         * xml-support.c: Update.
1354
1355 2019-04-08  Tom Tromey  <tom@tromey.com>
1356
1357         * xml-support.c: Use C++ exception handling.
1358         * x86-linux-nat.c: Use C++ exception handling.
1359         * windows-nat.c: Use C++ exception handling.
1360         * varobj.c: Use C++ exception handling.
1361         * value.c: Use C++ exception handling.
1362         * valprint.c: Use C++ exception handling.
1363         * valops.c: Use C++ exception handling.
1364         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1365         handling.
1366         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1367         * typeprint.c: Use C++ exception handling.
1368         * tui/tui.c: Use C++ exception handling.
1369         * tracefile-tfile.c: Use C++ exception handling.
1370         * top.c: Use C++ exception handling.
1371         * thread.c: Use C++ exception handling.
1372         * target.c: Use C++ exception handling.
1373         * symmisc.c: Use C++ exception handling.
1374         * symfile-mem.c: Use C++ exception handling.
1375         * stack.c: Use C++ exception handling.
1376         * sparc64-linux-tdep.c: Use C++ exception handling.
1377         * solib.c: Use C++ exception handling.
1378         * solib-svr4.c: Use C++ exception handling.
1379         * solib-spu.c: Use C++ exception handling.
1380         * solib-frv.c: Use C++ exception handling.
1381         * solib-dsbt.c: Use C++ exception handling.
1382         * selftest-arch.c: Use C++ exception handling.
1383         * s390-tdep.c: Use C++ exception handling.
1384         * rust-lang.c: Use C++ exception handling.
1385         * rust-exp.y: Use C++ exception handling.
1386         * rs6000-tdep.c: Use C++ exception handling.
1387         * rs6000-aix-tdep.c: Use C++ exception handling.
1388         * riscv-tdep.c: Use C++ exception handling.
1389         * remote.c: Use C++ exception handling.
1390         * remote-fileio.c: Use C++ exception handling.
1391         * record-full.c: Use C++ exception handling.
1392         * record-btrace.c: Use C++ exception handling.
1393         * python/python.c: Use C++ exception handling.
1394         * python/py-value.c: Use C++ exception handling.
1395         * python/py-utils.c: Use C++ exception handling.
1396         * python/py-unwind.c: Use C++ exception handling.
1397         * python/py-type.c: Use C++ exception handling.
1398         * python/py-symbol.c: Use C++ exception handling.
1399         * python/py-record.c: Use C++ exception handling.
1400         * python/py-record-btrace.c: Use C++ exception handling.
1401         * python/py-progspace.c: Use C++ exception handling.
1402         * python/py-prettyprint.c: Use C++ exception handling.
1403         * python/py-param.c: Use C++ exception handling.
1404         * python/py-objfile.c: Use C++ exception handling.
1405         * python/py-linetable.c: Use C++ exception handling.
1406         * python/py-lazy-string.c: Use C++ exception handling.
1407         * python/py-infthread.c: Use C++ exception handling.
1408         * python/py-inferior.c: Use C++ exception handling.
1409         * python/py-gdb-readline.c: Use C++ exception handling.
1410         * python/py-framefilter.c: Use C++ exception handling.
1411         * python/py-frame.c: Use C++ exception handling.
1412         * python/py-finishbreakpoint.c: Use C++ exception handling.
1413         * python/py-cmd.c: Use C++ exception handling.
1414         * python/py-breakpoint.c: Use C++ exception handling.
1415         * python/py-arch.c: Use C++ exception handling.
1416         * printcmd.c: Use C++ exception handling.
1417         * ppc-linux-tdep.c: Use C++ exception handling.
1418         * parse.c: Use C++ exception handling.
1419         * p-valprint.c: Use C++ exception handling.
1420         * objc-lang.c: Use C++ exception handling.
1421         * mi/mi-main.c: Use C++ exception handling.
1422         * mi/mi-interp.c: Use C++ exception handling.
1423         * mi/mi-cmd-stack.c: Use C++ exception handling.
1424         * mi/mi-cmd-break.c: Use C++ exception handling.
1425         * main.c: Use C++ exception handling.
1426         * linux-thread-db.c: Use C++ exception handling.
1427         * linux-tdep.c: Use C++ exception handling.
1428         * linux-nat.c: Use C++ exception handling.
1429         * linux-fork.c: Use C++ exception handling.
1430         * linespec.c: Use C++ exception handling.
1431         * language.c: Use C++ exception handling.
1432         * jit.c: Use C++ exception handling.
1433         * infrun.c: Use C++ exception handling.
1434         * infcmd.c: Use C++ exception handling.
1435         * infcall.c: Use C++ exception handling.
1436         * inf-loop.c: Use C++ exception handling.
1437         * i386-tdep.c: Use C++ exception handling.
1438         * i386-linux-tdep.c: Use C++ exception handling.
1439         * guile/scm-value.c: Use C++ exception handling.
1440         * guile/scm-type.c: Use C++ exception handling.
1441         * guile/scm-symtab.c: Use C++ exception handling.
1442         * guile/scm-symbol.c: Use C++ exception handling.
1443         * guile/scm-pretty-print.c: Use C++ exception handling.
1444         * guile/scm-ports.c: Use C++ exception handling.
1445         * guile/scm-param.c: Use C++ exception handling.
1446         * guile/scm-math.c: Use C++ exception handling.
1447         * guile/scm-lazy-string.c: Use C++ exception handling.
1448         * guile/scm-frame.c: Use C++ exception handling.
1449         * guile/scm-disasm.c: Use C++ exception handling.
1450         * guile/scm-cmd.c: Use C++ exception handling.
1451         * guile/scm-breakpoint.c: Use C++ exception handling.
1452         * guile/scm-block.c: Use C++ exception handling.
1453         * guile/guile-internal.h: Use C++ exception handling.
1454         * gnu-v3-abi.c: Use C++ exception handling.
1455         * gdbtypes.c: Use C++ exception handling.
1456         * frame.c: Use C++ exception handling.
1457         * frame-unwind.c: Use C++ exception handling.
1458         * fbsd-tdep.c: Use C++ exception handling.
1459         * f-valprint.c: Use C++ exception handling.
1460         * exec.c: Use C++ exception handling.
1461         * event-top.c: Use C++ exception handling.
1462         * event-loop.c: Use C++ exception handling.
1463         * eval.c: Use C++ exception handling.
1464         * dwarf2read.c: Use C++ exception handling.
1465         * dwarf2loc.c: Use C++ exception handling.
1466         * dwarf2-frame.c: Use C++ exception handling.
1467         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1468         * dwarf-index-write.c: Use C++ exception handling.
1469         * dwarf-index-cache.c: Use C++ exception handling.
1470         * dtrace-probe.c: Use C++ exception handling.
1471         * disasm-selftests.c: Use C++ exception handling.
1472         * darwin-nat.c: Use C++ exception handling.
1473         * cp-valprint.c: Use C++ exception handling.
1474         * cp-support.c: Use C++ exception handling.
1475         * cp-abi.c: Use C++ exception handling.
1476         * corelow.c: Use C++ exception handling.
1477         * completer.c: Use C++ exception handling.
1478         * compile/compile-object-run.c: Use C++ exception handling.
1479         * compile/compile-object-load.c: Use C++ exception handling.
1480         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1481         * compile/compile-c-symbols.c: Use C++ exception handling.
1482         * common/selftest.c: Use C++ exception handling.
1483         * common/new-op.c: Use C++ exception handling.
1484         * cli/cli-script.c: Use C++ exception handling.
1485         * cli/cli-interp.c: Use C++ exception handling.
1486         * cli/cli-cmds.c: Use C++ exception handling.
1487         * c-varobj.c: Use C++ exception handling.
1488         * btrace.c: Use C++ exception handling.
1489         * breakpoint.c: Use C++ exception handling.
1490         * break-catch-throw.c: Use C++ exception handling.
1491         * arch-utils.c: Use C++ exception handling.
1492         * amd64-tdep.c: Use C++ exception handling.
1493         * ada-valprint.c: Use C++ exception handling.
1494         * ada-typeprint.c: Use C++ exception handling.
1495         * ada-lang.c: Use C++ exception handling.
1496         * aarch64-tdep.c: Use C++ exception handling.
1497
1498 2019-04-08  Tom Tromey  <tom@tromey.com>
1499
1500         * xml-support.c (gdb_xml_parser::parse): Update.
1501         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1502         * value.c (show_convenience): Update.
1503         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1504         (test_parse_flags_qcs): Update.
1505         * thread.c (thr_try_catch_cmd): Update.
1506         * target.c (target_translate_tls_address): Update.
1507         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1508         (info_frame_command_core, frame_apply_command_count): Update.
1509         * rust-exp.y (rust_lex_exception_test): Update.
1510         * riscv-tdep.c (riscv_print_one_register_info): Update.
1511         * remote.c (remote_target::enable_btrace): Update.
1512         * record-btrace.c (record_btrace_enable_warn): Update.
1513         * python/py-utils.c (gdbpy_convert_exception): Update.
1514         * printcmd.c (do_one_display, print_variable_and_value): Update.
1515         * mi/mi-main.c (mi_print_exception): Update.
1516         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1517         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1518         * linux-nat.c (linux_nat_target::attach): Update.
1519         * linux-fork.c (class scoped_switch_fork_info): Update.
1520         * infrun.c (displaced_step_prepare): Update.
1521         * infcall.c (call_function_by_hand_dummy): Update.
1522         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1523         * gnu-v3-abi.c (print_one_vtable): Update.
1524         * frame.c (get_prev_frame_always): Update.
1525         * f-valprint.c (info_common_command_for_block): Update.
1526         * exec.c (try_open_exec_file): Update.
1527         * exceptions.c (print_exception, exception_print)
1528         (exception_fprintf, exception_print_same): Update.
1529         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1530         * dwarf-index-cache.c (index_cache::store)
1531         (index_cache::lookup_gdb_index): Update.
1532         * darwin-nat.c (maybe_cache_shell): Update.
1533         * cp-valprint.c (cp_print_value_fields): Update.
1534         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1535         (gcc_cplus_symbol_address): Update.
1536         * compile/compile-c-symbols.c (gcc_convert_symbol)
1537         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1538         * common/selftest.c: Update.
1539         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1540         a std::string.
1541         (exception_try_scope_entry, exception_try_scope_exit): Don't
1542         declare.
1543         (struct exception_try_scope): Remove.
1544         (TRY): Don't use exception_try_scope.
1545         (struct gdb_exception): Add constructor, operator=.
1546         <what>: New method.
1547         (struct gdb_exception_RETURN_MASK_ALL)
1548         (struct gdb_exception_RETURN_MASK_ERROR)
1549         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1550         (struct gdb_quit_bad_alloc): Update.
1551         * common/common-exceptions.c (exception_none): Change
1552         initializer.
1553         (struct catcher) <state, exception>: Initialize inline.
1554         <prev>: Remove member.
1555         (current_catcher): Remove.
1556         (catchers): New global.
1557         (exceptions_state_mc_init): Simplify.
1558         (catcher_pop): Remove.
1559         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1560         (try_scope_depth, exception_try_scope_entry)
1561         (exception_try_scope_exit): Remove.
1562         (throw_exception_sjlj): Update.
1563         (exception_messages, exception_messages_size): Remove.
1564         (throw_it): Simplify.
1565         (gdb_exception_sliced_copy): Remove.
1566         (throw_exception_cxx): Update.
1567         * cli/cli-script.c (script_from_file): Update.
1568         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1569         Update.
1570         * ada-valprint.c (ada_val_print): Update.
1571         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1572         (create_excep_cond_exprs): Update.
1573
1574 2019-04-08  Tom Tromey  <tom@tromey.com>
1575
1576         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1577         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1578         (TRY, CATCH, END_CATCH): Remove some definitions.
1579         * common/common-exceptions.c: Don't use GDB_XCPT.
1580         (catcher_list_size): Remove.
1581         (throw_exception, throw_it): Simplify.
1582
1583 2019-04-05  Tom Tromey  <tom@tromey.com>
1584
1585         Revert the header-sorting patch.
1586         * ft32-tdep.c: Revert.
1587         * frv-tdep.c: Revert.
1588         * frv-linux-tdep.c: Revert.
1589         * frame.c: Revert.
1590         * frame-unwind.c: Revert.
1591         * frame-base.c: Revert.
1592         * fork-child.c: Revert.
1593         * findvar.c: Revert.
1594         * findcmd.c: Revert.
1595         * filesystem.c: Revert.
1596         * filename-seen-cache.h: Revert.
1597         * filename-seen-cache.c: Revert.
1598         * fbsd-tdep.c: Revert.
1599         * fbsd-nat.h: Revert.
1600         * fbsd-nat.c: Revert.
1601         * f-valprint.c: Revert.
1602         * f-typeprint.c: Revert.
1603         * f-lang.c: Revert.
1604         * extension.h: Revert.
1605         * extension.c: Revert.
1606         * extension-priv.h: Revert.
1607         * expprint.c: Revert.
1608         * exec.h: Revert.
1609         * exec.c: Revert.
1610         * exceptions.c: Revert.
1611         * event-top.c: Revert.
1612         * event-loop.c: Revert.
1613         * eval.c: Revert.
1614         * elfread.c: Revert.
1615         * dwarf2read.h: Revert.
1616         * dwarf2read.c: Revert.
1617         * dwarf2loc.c: Revert.
1618         * dwarf2expr.h: Revert.
1619         * dwarf2expr.c: Revert.
1620         * dwarf2-frame.c: Revert.
1621         * dwarf2-frame-tailcall.c: Revert.
1622         * dwarf-index-write.h: Revert.
1623         * dwarf-index-write.c: Revert.
1624         * dwarf-index-common.c: Revert.
1625         * dwarf-index-cache.h: Revert.
1626         * dwarf-index-cache.c: Revert.
1627         * dummy-frame.c: Revert.
1628         * dtrace-probe.c: Revert.
1629         * disasm.h: Revert.
1630         * disasm.c: Revert.
1631         * disasm-selftests.c: Revert.
1632         * dictionary.c: Revert.
1633         * dicos-tdep.c: Revert.
1634         * demangle.c: Revert.
1635         * dcache.h: Revert.
1636         * dcache.c: Revert.
1637         * darwin-nat.h: Revert.
1638         * darwin-nat.c: Revert.
1639         * darwin-nat-info.c: Revert.
1640         * d-valprint.c: Revert.
1641         * d-namespace.c: Revert.
1642         * d-lang.c: Revert.
1643         * ctf.c: Revert.
1644         * csky-tdep.c: Revert.
1645         * csky-linux-tdep.c: Revert.
1646         * cris-tdep.c: Revert.
1647         * cris-linux-tdep.c: Revert.
1648         * cp-valprint.c: Revert.
1649         * cp-support.c: Revert.
1650         * cp-namespace.c: Revert.
1651         * cp-abi.c: Revert.
1652         * corelow.c: Revert.
1653         * corefile.c: Revert.
1654         * continuations.c: Revert.
1655         * completer.h: Revert.
1656         * completer.c: Revert.
1657         * complaints.c: Revert.
1658         * coffread.c: Revert.
1659         * coff-pe-read.c: Revert.
1660         * cli-out.h: Revert.
1661         * cli-out.c: Revert.
1662         * charset.c: Revert.
1663         * c-varobj.c: Revert.
1664         * c-valprint.c: Revert.
1665         * c-typeprint.c: Revert.
1666         * c-lang.c: Revert.
1667         * buildsym.c: Revert.
1668         * buildsym-legacy.c: Revert.
1669         * build-id.h: Revert.
1670         * build-id.c: Revert.
1671         * btrace.c: Revert.
1672         * bsd-uthread.c: Revert.
1673         * breakpoint.h: Revert.
1674         * breakpoint.c: Revert.
1675         * break-catch-throw.c: Revert.
1676         * break-catch-syscall.c: Revert.
1677         * break-catch-sig.c: Revert.
1678         * blockframe.c: Revert.
1679         * block.c: Revert.
1680         * bfin-tdep.c: Revert.
1681         * bfin-linux-tdep.c: Revert.
1682         * bfd-target.c: Revert.
1683         * bcache.c: Revert.
1684         * ax-general.c: Revert.
1685         * ax-gdb.h: Revert.
1686         * ax-gdb.c: Revert.
1687         * avr-tdep.c: Revert.
1688         * auxv.c: Revert.
1689         * auto-load.c: Revert.
1690         * arm-wince-tdep.c: Revert.
1691         * arm-tdep.c: Revert.
1692         * arm-symbian-tdep.c: Revert.
1693         * arm-pikeos-tdep.c: Revert.
1694         * arm-obsd-tdep.c: Revert.
1695         * arm-nbsd-tdep.c: Revert.
1696         * arm-nbsd-nat.c: Revert.
1697         * arm-linux-tdep.c: Revert.
1698         * arm-linux-nat.c: Revert.
1699         * arm-fbsd-tdep.c: Revert.
1700         * arm-fbsd-nat.c: Revert.
1701         * arm-bsd-tdep.c: Revert.
1702         * arch-utils.c: Revert.
1703         * arc-tdep.c: Revert.
1704         * arc-newlib-tdep.c: Revert.
1705         * annotate.h: Revert.
1706         * annotate.c: Revert.
1707         * amd64-windows-tdep.c: Revert.
1708         * amd64-windows-nat.c: Revert.
1709         * amd64-tdep.c: Revert.
1710         * amd64-sol2-tdep.c: Revert.
1711         * amd64-obsd-tdep.c: Revert.
1712         * amd64-obsd-nat.c: Revert.
1713         * amd64-nbsd-tdep.c: Revert.
1714         * amd64-nbsd-nat.c: Revert.
1715         * amd64-nat.c: Revert.
1716         * amd64-linux-tdep.c: Revert.
1717         * amd64-linux-nat.c: Revert.
1718         * amd64-fbsd-tdep.c: Revert.
1719         * amd64-fbsd-nat.c: Revert.
1720         * amd64-dicos-tdep.c: Revert.
1721         * amd64-darwin-tdep.c: Revert.
1722         * amd64-bsd-nat.c: Revert.
1723         * alpha-tdep.c: Revert.
1724         * alpha-obsd-tdep.c: Revert.
1725         * alpha-nbsd-tdep.c: Revert.
1726         * alpha-mdebug-tdep.c: Revert.
1727         * alpha-linux-tdep.c: Revert.
1728         * alpha-linux-nat.c: Revert.
1729         * alpha-bsd-tdep.c: Revert.
1730         * alpha-bsd-nat.c: Revert.
1731         * aix-thread.c: Revert.
1732         * agent.c: Revert.
1733         * addrmap.c: Revert.
1734         * ada-varobj.c: Revert.
1735         * ada-valprint.c: Revert.
1736         * ada-typeprint.c: Revert.
1737         * ada-tasks.c: Revert.
1738         * ada-lang.c: Revert.
1739         * aarch64-tdep.c: Revert.
1740         * aarch64-ravenscar-thread.c: Revert.
1741         * aarch64-newlib-tdep.c: Revert.
1742         * aarch64-linux-tdep.c: Revert.
1743         * aarch64-linux-nat.c: Revert.
1744         * aarch64-fbsd-tdep.c: Revert.
1745         * aarch64-fbsd-nat.c: Revert.
1746         * aarch32-linux-nat.c: Revert.
1747
1748 2019-04-05  Tom Tromey  <tom@tromey.com>
1749
1750         * ft32-tdep.c: Sort headers.
1751         * frv-tdep.c: Sort headers.
1752         * frv-linux-tdep.c: Sort headers.
1753         * frame.c: Sort headers.
1754         * frame-unwind.c: Sort headers.
1755         * frame-base.c: Sort headers.
1756         * fork-child.c: Sort headers.
1757         * findvar.c: Sort headers.
1758         * findcmd.c: Sort headers.
1759         * filesystem.c: Sort headers.
1760         * filename-seen-cache.h: Sort headers.
1761         * filename-seen-cache.c: Sort headers.
1762         * fbsd-tdep.c: Sort headers.
1763         * fbsd-nat.h: Sort headers.
1764         * fbsd-nat.c: Sort headers.
1765         * f-valprint.c: Sort headers.
1766         * f-typeprint.c: Sort headers.
1767         * f-lang.c: Sort headers.
1768         * extension.h: Sort headers.
1769         * extension.c: Sort headers.
1770         * extension-priv.h: Sort headers.
1771         * expprint.c: Sort headers.
1772         * exec.h: Sort headers.
1773         * exec.c: Sort headers.
1774         * exceptions.c: Sort headers.
1775         * event-top.c: Sort headers.
1776         * event-loop.c: Sort headers.
1777         * eval.c: Sort headers.
1778         * elfread.c: Sort headers.
1779         * dwarf2read.h: Sort headers.
1780         * dwarf2read.c: Sort headers.
1781         * dwarf2loc.c: Sort headers.
1782         * dwarf2expr.h: Sort headers.
1783         * dwarf2expr.c: Sort headers.
1784         * dwarf2-frame.c: Sort headers.
1785         * dwarf2-frame-tailcall.c: Sort headers.
1786         * dwarf-index-write.h: Sort headers.
1787         * dwarf-index-write.c: Sort headers.
1788         * dwarf-index-common.c: Sort headers.
1789         * dwarf-index-cache.h: Sort headers.
1790         * dwarf-index-cache.c: Sort headers.
1791         * dummy-frame.c: Sort headers.
1792         * dtrace-probe.c: Sort headers.
1793         * disasm.h: Sort headers.
1794         * disasm.c: Sort headers.
1795         * disasm-selftests.c: Sort headers.
1796         * dictionary.c: Sort headers.
1797         * dicos-tdep.c: Sort headers.
1798         * demangle.c: Sort headers.
1799         * dcache.h: Sort headers.
1800         * dcache.c: Sort headers.
1801         * darwin-nat.h: Sort headers.
1802         * darwin-nat.c: Sort headers.
1803         * darwin-nat-info.c: Sort headers.
1804         * d-valprint.c: Sort headers.
1805         * d-namespace.c: Sort headers.
1806         * d-lang.c: Sort headers.
1807         * ctf.c: Sort headers.
1808         * csky-tdep.c: Sort headers.
1809         * csky-linux-tdep.c: Sort headers.
1810         * cris-tdep.c: Sort headers.
1811         * cris-linux-tdep.c: Sort headers.
1812         * cp-valprint.c: Sort headers.
1813         * cp-support.c: Sort headers.
1814         * cp-namespace.c: Sort headers.
1815         * cp-abi.c: Sort headers.
1816         * corelow.c: Sort headers.
1817         * corefile.c: Sort headers.
1818         * continuations.c: Sort headers.
1819         * completer.h: Sort headers.
1820         * completer.c: Sort headers.
1821         * complaints.c: Sort headers.
1822         * coffread.c: Sort headers.
1823         * coff-pe-read.c: Sort headers.
1824         * cli-out.h: Sort headers.
1825         * cli-out.c: Sort headers.
1826         * charset.c: Sort headers.
1827         * c-varobj.c: Sort headers.
1828         * c-valprint.c: Sort headers.
1829         * c-typeprint.c: Sort headers.
1830         * c-lang.c: Sort headers.
1831         * buildsym.c: Sort headers.
1832         * buildsym-legacy.c: Sort headers.
1833         * build-id.h: Sort headers.
1834         * build-id.c: Sort headers.
1835         * btrace.c: Sort headers.
1836         * bsd-uthread.c: Sort headers.
1837         * breakpoint.h: Sort headers.
1838         * breakpoint.c: Sort headers.
1839         * break-catch-throw.c: Sort headers.
1840         * break-catch-syscall.c: Sort headers.
1841         * break-catch-sig.c: Sort headers.
1842         * blockframe.c: Sort headers.
1843         * block.c: Sort headers.
1844         * bfin-tdep.c: Sort headers.
1845         * bfin-linux-tdep.c: Sort headers.
1846         * bfd-target.c: Sort headers.
1847         * bcache.c: Sort headers.
1848         * ax-general.c: Sort headers.
1849         * ax-gdb.h: Sort headers.
1850         * ax-gdb.c: Sort headers.
1851         * avr-tdep.c: Sort headers.
1852         * auxv.c: Sort headers.
1853         * auto-load.c: Sort headers.
1854         * arm-wince-tdep.c: Sort headers.
1855         * arm-tdep.c: Sort headers.
1856         * arm-symbian-tdep.c: Sort headers.
1857         * arm-pikeos-tdep.c: Sort headers.
1858         * arm-obsd-tdep.c: Sort headers.
1859         * arm-nbsd-tdep.c: Sort headers.
1860         * arm-nbsd-nat.c: Sort headers.
1861         * arm-linux-tdep.c: Sort headers.
1862         * arm-linux-nat.c: Sort headers.
1863         * arm-fbsd-tdep.c: Sort headers.
1864         * arm-fbsd-nat.c: Sort headers.
1865         * arm-bsd-tdep.c: Sort headers.
1866         * arch-utils.c: Sort headers.
1867         * arc-tdep.c: Sort headers.
1868         * arc-newlib-tdep.c: Sort headers.
1869         * annotate.h: Sort headers.
1870         * annotate.c: Sort headers.
1871         * amd64-windows-tdep.c: Sort headers.
1872         * amd64-windows-nat.c: Sort headers.
1873         * amd64-tdep.c: Sort headers.
1874         * amd64-sol2-tdep.c: Sort headers.
1875         * amd64-obsd-tdep.c: Sort headers.
1876         * amd64-obsd-nat.c: Sort headers.
1877         * amd64-nbsd-tdep.c: Sort headers.
1878         * amd64-nbsd-nat.c: Sort headers.
1879         * amd64-nat.c: Sort headers.
1880         * amd64-linux-tdep.c: Sort headers.
1881         * amd64-linux-nat.c: Sort headers.
1882         * amd64-fbsd-tdep.c: Sort headers.
1883         * amd64-fbsd-nat.c: Sort headers.
1884         * amd64-dicos-tdep.c: Sort headers.
1885         * amd64-darwin-tdep.c: Sort headers.
1886         * amd64-bsd-nat.c: Sort headers.
1887         * alpha-tdep.c: Sort headers.
1888         * alpha-obsd-tdep.c: Sort headers.
1889         * alpha-nbsd-tdep.c: Sort headers.
1890         * alpha-mdebug-tdep.c: Sort headers.
1891         * alpha-linux-tdep.c: Sort headers.
1892         * alpha-linux-nat.c: Sort headers.
1893         * alpha-bsd-tdep.c: Sort headers.
1894         * alpha-bsd-nat.c: Sort headers.
1895         * aix-thread.c: Sort headers.
1896         * agent.c: Sort headers.
1897         * addrmap.c: Sort headers.
1898         * ada-varobj.c: Sort headers.
1899         * ada-valprint.c: Sort headers.
1900         * ada-typeprint.c: Sort headers.
1901         * ada-tasks.c: Sort headers.
1902         * ada-lang.c: Sort headers.
1903         * aarch64-tdep.c: Sort headers.
1904         * aarch64-ravenscar-thread.c: Sort headers.
1905         * aarch64-newlib-tdep.c: Sort headers.
1906         * aarch64-linux-tdep.c: Sort headers.
1907         * aarch64-linux-nat.c: Sort headers.
1908         * aarch64-fbsd-tdep.c: Sort headers.
1909         * aarch64-fbsd-nat.c: Sort headers.
1910         * aarch32-linux-nat.c: Sort headers.
1911
1912 2019-04-04  Tom Tromey  <tom@tromey.com>
1913
1914         * varobj.c (varobj_create): Update.
1915         * rust-exp.y (struct rust_parser) <update_innermost_block,
1916         lookup_symbol>: New methods.
1917         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1918         Rename.
1919         (rust_parser::rust_lookup_type)
1920         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1921         * printcmd.c (display_command, do_one_display): Update.
1922         * parser-defs.h (struct parser_state) <parser_state>: Add
1923         "tracker" parameter.
1924         (block_tracker): New member.
1925         (class innermost_block_tracker) <innermost_block_tracker>: Add
1926         "types" parameter.
1927         <reset>: Remove method.
1928         (innermost_block): Don't declare.
1929         (null_post_parser): Update.
1930         * parse.c (innermost_block): Remove global.
1931         (write_dollar_variable): Update.
1932         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1933         Remove "tracker_types" parameter.
1934         (parse_expression): Add "tracker" parameter.
1935         (parse_expression_for_completion): Update.
1936         (null_post_parser): Add "tracker" parameter.
1937         * p-exp.y: Update rules.
1938         * m2-exp.y: Update rules.
1939         * language.h (struct language_defn) <la_post_parser>: Add
1940         "tracker" parameter.
1941         * go-exp.y: Update rules.
1942         * f-exp.y: Update rules.
1943         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1944         parameter.
1945         * d-exp.y: Update rules.
1946         * c-exp.y: Update rules.
1947         * breakpoint.c (set_breakpoint_condition): Create an
1948         innermost_block_tracker.
1949         (watch_command_1): Likewise.
1950         * ada-lang.c (resolve): Add "tracker" parameter.
1951         (resolve_subexp): Likewise.
1952         * ada-exp.y (write_var_from_sym): Update.
1953
1954 2019-04-04  Tom Tromey  <tom@tromey.com>
1955
1956         * type-stack.h: New file.
1957         * type-stack.c: New file.
1958         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1959         type-stack.h.
1960         (insert_into_type_stack, insert_type, push_type, push_type_int)
1961         (insert_type_address_space, pop_type, pop_type_int)
1962         (pop_typelist, pop_type_stack, append_type_stack)
1963         (push_type_stack, get_type_stack, push_typelist)
1964         (follow_type_instance_flags, follow_types): Don't declare.
1965         * parse.c (type_stack): Remove global.
1966         (parse_exp_in_context): Update.
1967         (insert_into_type_stack, insert_type, push_type, push_type_int)
1968         (insert_type_address_space, pop_type, pop_type_int)
1969         (pop_typelist, pop_type_stack, append_type_stack)
1970         (push_type_stack, get_type_stack, push_typelist)
1971         (follow_type_instance_flags, follow_types): Remove (moved to
1972         type-stack.c).
1973         * f-exp.y (type_stack): New global.
1974         Update rules.
1975         (push_kind_type, f_parse): Update.
1976         * d-exp.y (type_stack): New global.
1977         Update rules.
1978         (d_parse): Update.
1979         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1980         Update rules.
1981         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1982         (HFILES_NO_SRCDIR): Add type-stack.h.
1983
1984 2019-04-04  Tom Tromey  <tom@tromey.com>
1985
1986         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1987         (rust_parser::convert_ast_to_expression, rust_parse)
1988         (rust_lex_test_completion, rust_lex_tests): Update.
1989         * parser-defs.h (struct expr_completion_state): New.
1990         (struct parser_state) <parser_state>: Add completion parameter.
1991         <mark_struct_expression, mark_completion_tag>: New methods.
1992         <parse_completion, m_completion_state>: New members.
1993         (prefixify_expression, null_post_parser): Update.
1994         (mark_struct_expression, mark_completion_tag): Don't declare.
1995         * parse.c (parse_completion, expout_last_struct)
1996         (expout_tag_completion_type, expout_completion_name): Remove
1997         globals.
1998         (parser_state::mark_struct_expression)
1999         (parser_state::mark_completion_tag): Now methods.
2000         (prefixify_expression): Add last_struct parameter.
2001         (prefixify_subexp): Likewise.
2002         (parse_exp_1): Update.
2003         (parse_exp_in_context): Add cstate parameter.  Update.
2004         (parse_expression_for_completion): Create an
2005         expr_completion_state.
2006         (null_post_parser): Add "completion" parameter.
2007         * p-exp.y: Update rules.
2008         (yylex): Update.
2009         * language.h (struct language_defn) <la_post_parser>: Add
2010         "completing" parameter.
2011         * go-exp.y: Update rules.
2012         (lex_one_token): Update.
2013         * expression.h (parse_completion): Don't declare.
2014         * d-exp.y: Update rules.
2015         (lex_one_token): Update rules.
2016         * c-exp.y: Update rules.
2017         (lex_one_token): Update.
2018         * ada-lang.c (resolve): Add "parse_completion" parameter.
2019         (resolve_subexp): Likewise.
2020         (ada_resolve_function): Likewise.
2021
2022 2019-04-04  Tom Tromey  <tom@tromey.com>
2023
2024         * parser-defs.h (struct parser_state) <start_arglist,
2025         end_arglist>: New methods.
2026         <arglist_len, m_funcall_chain>: New members.
2027         (arglist_len, start_arglist, end_arglist): Don't declare.
2028         * parse.c (arglist_len, funcall_chain): Remove global.
2029         (start_arglist, end_arglist): Remove functions.
2030         (parse_exp_in_context): Update.
2031         * p-exp.y: Update rules.
2032         * m2-exp.y: Update rules.
2033         * go-exp.y: Update rules.
2034         * f-exp.y: Update rules.
2035         * d-exp.y: Update rules.
2036         * c-exp.y: Update rules.
2037
2038 2019-04-04  Tom Tromey  <tom@tromey.com>
2039
2040         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2041         lex_operator, push_back>: New methods.
2042         Update all rules.
2043         (rust_parser::lex_hex, lex_escape): Rename and update.
2044         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2045         (rust_parser::lex_operator): Rename and update.
2046         (rust_parser::lex_number, rustyylex, rustyyerror)
2047         (rust_lex_test_init, rust_lex_test_sequence)
2048         (rust_lex_test_push_back, rust_lex_tests): Update.
2049         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2050         parameter.
2051         <lexptr, prev_lexptr>: New members.
2052         (lexptr, prev_lexptr): Don't declare.
2053         * parse.c (lexptr, prev_lexptr): Remove globals.
2054         (parse_exp_in_context): Update.
2055         * p-exp.y (yylex, yyerror): Update.
2056         * m2-exp.y (parse_number, yylex, yyerror): Update.
2057         * go-exp.y (lex_one_token, yyerror): Update.
2058         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2059         * d-exp.y (lex_one_token, yyerror): Update.
2060         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2061         (lex_one_token, yyerror): Update.
2062         * ada-lex.l (YY_INPUT): Update.
2063         (rewind_to_char): Update.
2064         * ada-exp.y (yyerror): Update.
2065
2066 2019-04-04  Tom Tromey  <tom@tromey.com>
2067
2068         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2069         * parser-defs.h (struct parser_state) <parser_state>: Add new
2070         parameter.
2071         <comma_terminates>: New member.
2072         (comma_terminates): Don't declare global.
2073         * parse.c (comma_terminates): Remove global.
2074         (parse_exp_in_context): Update.
2075         * p-exp.y (yylex): Update.
2076         * m2-exp.y (yylex): Update.
2077         * go-exp.y (lex_one_token): Update.
2078         * f-exp.y (yylex): Update.
2079         * d-exp.y (lex_one_token): Update.
2080         * c-exp.y (lex_one_token): Update.
2081         * ada-lex.l: Update.
2082
2083 2019-04-04  Tom Tromey  <tom@tromey.com>
2084
2085         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2086         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2087         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2088         * parser-defs.h (paren_depth): Don't declare.
2089         * parse.c (paren_depth): Remove global.
2090         (parse_exp_in_context): Update.
2091         * p-exp.y (paren_depth): New global.
2092         (pascal_parse): Initialize it.
2093         * m2-exp.y (paren_depth): New global.
2094         (m2_parse): Initialize it.
2095         * go-exp.y (paren_depth): New global.
2096         (go_parse): Initialize it.
2097         * f-exp.y (paren_depth): New global.
2098         (f_parse): Initialize it.
2099         * d-exp.y (paren_depth): New global.
2100         (d_parse): Initialize it.
2101         * c-exp.y (paren_depth): New global.
2102         (c_parse): Initialize it.
2103         * ada-lex.l (paren_depth): New global.
2104         (lexer_init): Initialize it.
2105
2106 2019-04-04  Tom Tromey  <tom@tromey.com>
2107
2108         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2109         (rust_parser::convert_ast_to_type)
2110         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2111         * parser-defs.h (struct parser_state) <parser_state>: Add
2112         parameters.  Initialize new members.
2113         <expression_context_block, expression_context_pc>: New members.
2114         * parse.c (expression_context_block, expression_context_pc):
2115         Remove globals.
2116         (parse_exp_in_context): Update.
2117         * p-exp.y: Update all rules.
2118         (yylex): Update.
2119         * m2-exp.y: Update all rules.
2120         (yylex): Update.
2121         * go-exp.y (yylex): Update.
2122         * f-exp.y (yylex): Update.
2123         * d-exp.y: Update all rules.
2124         (yylex): Update.
2125         * c-exp.y: Update all rules.
2126         (lex_one_token, classify_name, yylex, c_parse): Update.
2127         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2128
2129 2019-04-04  Tom Tromey  <tom@tromey.com>
2130
2131         * gdbarch.h, gdbarch.c: Rebuild.
2132         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2133         * stap-probe.h:
2134         (struct stap_parse_info): Replace "parser_state" with
2135         "expr_builder".
2136         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2137         (parser_state): New class.
2138         * parse.c (expr_builder): Rename.
2139         (expr_builder::release): Rename.
2140         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2141         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2142         (write_exp_elt_longcst, write_exp_elt_floatcst)
2143         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2144         (write_exp_string_vector, write_exp_bitstring)
2145         (write_exp_msymbol, mark_struct_expression)
2146         (write_dollar_variable)
2147         (insert_type_address_space, increase_expout_size): Replace
2148         "parser_state" with "expr_builder".
2149         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2150         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2151         "parser_state" with "expr_builder".
2152
2153 2019-04-04  Tom Tromey  <tom@tromey.com>
2154
2155         * rust-exp.y: Replace "parse_language" with method call.
2156         * p-exp.y:
2157         (yylex): Replace "parse_language" with method call.
2158         * m2-exp.y:
2159         (yylex): Replace "parse_language" with method call.
2160         * go-exp.y (classify_name): Replace "parse_language" with method
2161         call.
2162         * f-exp.y (yylex): Replace "parse_language" with method call.
2163         * d-exp.y (lex_one_token): Replace "parse_language" with method
2164         call.
2165         * c-exp.y:
2166         (lex_one_token, classify_name, yylex): Replace "parse_language"
2167         with method call.
2168         * ada-exp.y (find_primitive_type, type_char)
2169         (type_system_address): Replace "parse_language" with method call.
2170
2171 2019-04-04  Tom Tromey  <tom@tromey.com>
2172
2173         * rust-exp.y: Replace "parse_gdbarch" with method call.
2174         * parse.c (write_dollar_variable, insert_type_address_space):
2175         Replace "parse_gdbarch" with method call.
2176         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2177         call.
2178         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2179         call.
2180         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2181         "parse_gdbarch" with method call.
2182         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2183         with method call.
2184         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2185         "parse_gdbarch" with method call.
2186         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2187         "parse_gdbarch" with method call.
2188         * c-exp.y (parse_type, parse_number, classify_name): Replace
2189         "parse_gdbarch" with method call.
2190         * ada-lex.l: Replace "parse_gdbarch" with method call.
2191         * ada-exp.y (parse_type, find_primitive_type, type_char)
2192         (type_system_address): Replace "parse_gdbarch" with method call.
2193
2194 2019-04-04  Tom Tromey  <tom@tromey.com>
2195
2196         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2197         * stap-probe.c (stap_parse_argument): Update.
2198         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2199         initial_size parameter.
2200         * rust-exp.y (rust_lex_tests): Update.
2201         * parse.c (parser_state): Update.
2202         (parse_exp_in_context): Update.
2203         * parser-defs.h (struct parser_state) <parser_state>: Remove
2204         "initial_size" parameter.
2205
2206 2019-04-04  Tom Tromey  <tom@tromey.com>
2207
2208         * parser-defs.h (increase_expout_size): Don't declare.
2209         * parse.c (increase_expout_size): Now static.
2210
2211 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2212
2213         * gnu-nat.c (gnu_nat_target::wait): Fix
2214         target_waitstatus_to_string call.
2215
2216 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2217
2218         * eval.c (evaluate_subexp_standard): Handle internal functions
2219         during Fortran function call handling.
2220
2221 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * NEWS: Mention new internal functions.
2224         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2225         (read_base_type): Use dwarf2_init_complex_target_type.
2226         * value.c (creal_internal_fn): New function.
2227         (cimag_internal_fn): New function.
2228         (_initialize_values): Register new internal functions.
2229
2230 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2231
2232         * infrun.c (stop_all_threads): If debug_infrun, always
2233         trace the wait status after wait_one, using
2234         target_waitstatus_to_string and target_pid_to_str.
2235         (handle_inferior_event): Replace various trace of
2236         wait status kind by a single trace.
2237         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2238         wait status kind image by target_waitstatus_to_string.
2239         * target/waitstatus.c (target_waitstatus_to_string): Fix
2240         obsolete comment.
2241
2242 2019-04-01  Tom Tromey  <tromey@adacore.com>
2243
2244         PR symtab/23331:
2245         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2246
2247 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2248             Pedro Alves  <palves@redhat.com>
2249
2250         * top.c (quit_force): Call 'finalize_values'.
2251         * value.c (finalize_values): New function.
2252         * value.h (finalize_values): Declare.
2253
2254 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2255
2256         * NEWS: Announce $_gdb_major and $_gdb_minor.
2257
2258         * top.c (init_gdb_version_vars): New function.
2259         (gdb_init): Call init_gdb_version_vars.
2260
2261 2019-03-29  Tom Tromey  <tromey@adacore.com>
2262
2263         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2264         help text.  Remove dead code.
2265
2266 2019-03-29  Keith Seitz  <keiths@redhat.com>
2267
2268         From Siddhesh Poyarekar:
2269         * f-lang.h (f77_get_upperbound): Return LONGEST.
2270         (f77_get_lowerbound): Likewise.
2271         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2272         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2273         print them.
2274         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2275         plongest to format print it.
2276         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2277         (f77_get_upperbound): Likewise.
2278         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2279         LOWER_BOUND to LONGEST.
2280         (f77_create_arrayprint_offset_tbl): Likewise.
2281
2282 2019-03-29  Keith Seitz  <keiths@redhat.com>
2283
2284         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2285         %s/pulongest for TYPE_LENGTH instead of %d in format
2286         strings.
2287         * ada-typerint.c (ada_print_type): Likewise.
2288         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2289         * compile/compile-c-support.c (generate_register_struct): Likewise.
2290         * gdbtypes.c (recursive_dump_type): Likewise.
2291         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2292         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2293         instead of %d in format strings.
2294         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2295         to std::min to ULONGEST.
2296         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2297         instead of %d in format strings.
2298         * tracepoint.c (info_scope_command): Likewise.
2299         * typeprint.c (print_offset_data::update)
2300         (print_offset_data::finish): Likewise.
2301         * xtensa-tdep.c (xtensa_store_return_value)
2302         (xtensa_push_dummy_call): Likewise.
2303
2304 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2305
2306         * windows-nat.c (display_selector): Fixed format specifications
2307         for 64-bit Cygwin.
2308
2309 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2310
2311         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2312
2313 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2314
2315         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2316         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2317         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2318         (nios2_linux_init_abi): Install it.
2319
2320 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2321
2322         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2323
2324 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2325
2326         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2327
2328 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2329             Tom Tromey  <tromey@adacore.com>
2330
2331         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2332
2333 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2334
2335         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2336         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2337         method to compute the bounds of range types. Also print "[evaluated]"
2338         if the bounds' values come from a dynamic evaluation.
2339
2340 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2341
2342         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2343         whitespace when pretty printing is on.
2344
2345 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2346
2347         * ppc-linux-nat.c: Add include.
2348
2349 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2350
2351         * NEWS: Mention AArch64 Pointer Authentication.
2352
2353 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2354
2355         * arm-linux-nat.c: Add include.
2356
2357 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2358
2359         * source-cache.c (source_cache::get_source_lines): Re-read
2360         fullname after calling open_source_file.
2361
2362 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2363
2364         * NEWS: Mention TLS support for FreeBSD.
2365
2366 2019-03-25  Tom Tromey  <tromey@adacore.com>
2367
2368         * minsyms.c (BUNCH_SIZE): Update comment.
2369         (~minimal_symbol_reader): Remove old comment.
2370         (compact_minimal_symbols): Update comment.
2371         (minimal_symbol_reader::install): Remove old comment.  Update
2372         other comments.
2373
2374 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2375
2376         * s390-linux-nat.c: Add include.
2377
2378 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2379
2380         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2381         Call linux_get_hwcap.
2382         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2383         Likewise.
2384         (aarch64_linux_get_hwcap): Remove function.
2385         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2386         declaration.
2387         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2388         linux_get_hwcap.
2389         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2390         * linux-tdep.c (linux_get_hwcap): Add function.
2391         (linux_get_hwcap2): Likewise.
2392         * linux-tdep.h (linux_get_hwcap): Add declaration.
2393         (linux_get_hwcap2): Likewise.
2394         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2395         (ppc_linux_get_hwcap2): Likewise.
2396         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2397         linux_get_hwcap.
2398         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2399         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2400         (ppc_linux_nat_target::read_description): Likewise.
2401         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2402         * s390-linux-nat.c: Likewise.
2403         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2404
2405 2019-03-24  Tom Tromey  <tom@tromey.com>
2406
2407         * ada-lang.c (standard_lookup): Simplify initialization.
2408         (ada_lookup_symbol_nonlocal): Simplify return.
2409         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2410         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2411         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2412         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2413         initialization.
2414         * solib.c (solib_global_lookup): Simplify.
2415         * symtab.c (null_block_symbol): Remove.
2416         (symbol_cache_lookup): Simplify returns.
2417         (lookup_language_this): Simplify returns.
2418         (lookup_symbol_aux): Simplify return.
2419         (lookup_local_symbol): Simplify returns.
2420         (lookup_global_symbol_from_objfile): Simplify return.
2421         (lookup_symbol_in_objfile_symtabs)
2422         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2423         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2424         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2425         * cp-namespace.c (cp_lookup_bare_symbol)
2426         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2427         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2428         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2429         (cp_lookup_symbol_via_imports): Simplify initialization.
2430         (find_symbol_in_baseclass): Likewise.
2431         * symtab.h (null_block_symbol): Remove.
2432         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2433         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2434         (d_lookup_symbol_module): Likewise.
2435         (find_symbol_in_baseclass): Simplify initialization.
2436
2437 2019-03-24  Tom Tromey  <tom@tromey.com>
2438
2439         * expression.h: Don't include symtab.h.
2440         (struct block): Forward declare.
2441
2442 2019-03-24  Tom Tromey  <tom@tromey.com>
2443
2444         * c-exp.y (typebase): Remove casts.
2445         * gdbtypes.c (lookup_unsigned_typename, )
2446         (lookup_signed_typename): Remove cast.
2447         * eval.c (parse_to_comma_and_eval): Remove cast.
2448         * parse.c (write_dollar_variable): Remove cast.
2449         * block.h (struct block) <superblock>: Now const.
2450         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2451         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2452         (map_block): Make "block" const.
2453         * symfile.h (struct quick_symbol_functions)
2454         <map_matching_symbols>: Constify block argument to "callback".
2455         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2456         const.
2457         (find_pc_sect_compunit_symtab): Make "b" const.
2458         (find_symbol_at_address): Likewise.
2459         (search_symbols): Likewise.
2460         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2461         (dw2_debug_names_lookup_symbol): Likewise.
2462         (dw2_map_matching_symbols): Update.
2463         * p-valprint.c (pascal_val_print): Remove "block".
2464         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2465         (aux_add_nonlocal_symbols): Make "block" const.
2466         (resolve_subexp): Remove cast.
2467         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2468         const.
2469         (iterate_over_file_blocks): Likewise.
2470         * f-exp.y (%union) <bval>: Remove.
2471         * coffread.c (patch_opaque_types): Make "b" const.
2472         * spu-tdep.c (spu_catch_start): Make "block" const.
2473         * c-valprint.c (print_unpacked_pointer): Remove "block".
2474         * symmisc.c (dump_symtab_1): Make "b" const.
2475         (block_depth): Make "block" const.
2476         * d-exp.y (%union) <bval>: Remove.
2477         * cp-support.h (cp_lookup_rtti_type): Update.
2478         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2479         * psymtab.c (psym_lookup_symbol): Make "block" const.
2480         (maintenance_check_psymtabs): Make "b" const.
2481         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2482         (enumerate_locals, enumerate_args): Update.
2483         * python/py-symtab.c (stpy_global_block): Make "block" const.
2484         (stpy_static_block): Likewise.
2485         * inline-frame.c (block_starting_point_at): Make "new_block"
2486         const.
2487         * block.c (find_block_in_blockvector): Make return type const.
2488         (blockvector_for_pc_sect): Make "b" const.
2489         (find_block_in_blockvector): Make "b" const.
2490
2491 2019-03-23  Tom Tromey  <tom@tromey.com>
2492
2493         * varobj.c (varobj_create): Update.
2494         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2495         * printcmd.c (display_command, do_one_display): Don't reset
2496         innermost_block.
2497         * parser-defs.h (enum innermost_block_tracker_type): Move to
2498         expression.h.
2499         (innermost_block): Update comment.
2500         * parse.c (parse_exp_1): Add tracker_types parameter.
2501         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2502         tracker_types parameter.  Reset innermost_block.
2503         (parse_exp_in_context): Remove.
2504         (parse_expression_for_completion): Update.
2505         * objfiles.c (~objfile): Don't reset expression_context_block or
2506         innermost_block.
2507         * expression.h (enum innermost_block_tracker_type): Move from
2508         parser-defs.h.
2509         (parse_exp_1): Add tracker_types parameter.
2510         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2511         reset innermost_block.
2512
2513 2019-03-23  Tom Tromey  <tom@tromey.com>
2514
2515         * objfiles.h: Include bcache.h.
2516
2517 2019-03-23  Tom Tromey  <tom@tromey.com>
2518
2519         * linespec.c (get_current_search_block): Use
2520         scoped_restore_current_language.
2521         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2522
2523 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2524             Jiong Wang  <jiong.wang@arm.com>
2525
2526         * aarch64-linux-tdep.c
2527         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2528         section.
2529         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2530
2531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2532             Jiong Wang  <jiong.wang@arm.com>
2533
2534         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2535         instructions.
2536         (aarch64_analyze_prologue_test): Add PACIASP test.
2537         (aarch64_prologue_prev_register): Unmask PC value.
2538
2539 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2540             Jiong Wang  <jiong.wang@arm.com>
2541
2542         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2543         (aarch64_dwarf2_prev_register): Unmask PC value.
2544         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2545         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2546         DW_CFA_AARCH64_negate_ra_state.
2547         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2548
2549 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2550             Jiong Wang  <jiong.wang@arm.com>
2551
2552         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2553         registers.
2554         (aarch64_pseudo_register_name): Likewise.
2555         (aarch64_pseudo_register_type): Likewise.
2556         (aarch64_pseudo_register_reggroup_p): Likewise.
2557         (aarch64_gdbarch_init): Add pauth registers.
2558         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2559         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2560         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2561         (struct gdbarch_tdep): Add regnum for ra_state.
2562
2563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2564             Jiong Wang  <jiong.wang@arm.com>
2565
2566         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2567
2568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2569             Jiong Wang  <jiong.wang@arm.com>
2570
2571         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2572         function.
2573         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2574         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2575         (aarch64_gdbarch_init): Add puth registers.
2576         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2577         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2578         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2579
2580 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2581             Jiong Wang  <jiong.wang@arm.com>
2582
2583         * aarch64-linux-nat.c
2584         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2585         * aarch64-linux-tdep.c
2586         (aarch64_linux_core_read_description): Likewise.
2587         (aarch64_linux_get_hwcap): New function.
2588         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2589         (aarch64_linux_get_hwcap): New declaration.
2590
2591 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2592             Jiong Wang  <jiong.wang@arm.com>
2593
2594         * aarch64-linux-nat.c
2595         (aarch64_linux_nat_target::read_description): Add pauth param.
2596         * aarch64-linux-tdep.c
2597         (aarch64_linux_core_read_description): Likewise.
2598         * aarch64-tdep.c (struct target_desc): Add in pauth.
2599         (aarch64_read_description): Add pauth param.
2600         (aarch64_gdbarch_init): Likewise.
2601         * aarch64-tdep.h (aarch64_read_description): Likewise.
2602         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2603         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2604         * features/Makefile: Add new files.
2605         * features/aarch64-pauth.c: New file.
2606         * features/aarch64-pauth.xml: New file.
2607
2608 2019-03-20  Tom Tromey  <tromey@adacore.com>
2609
2610         * infrun.c (handle_inferior_event): Rename from
2611         handle_inferior_event_1.  Create a scoped_value_mark.
2612         (handle_inferior_event): Remove.
2613
2614 2019-03-19  Tom Tromey  <tromey@adacore.com>
2615
2616         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2617         * infrun.h (print_stop_event): Add "displays" parameter.
2618         * infrun.c (print_stop_event): Add "displays" parameter.
2619
2620 2019-03-19  Pedro Alves  <palves@redhat.com>
2621
2622         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2623         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2624         to -1.  Fix TABs vs spaces.
2625         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2626         * tui/tui-out.h (tui_ui_out) Add intro comments.
2627         <m_line, m_start_of_line>: In-class initialize, and add describing
2628         comment.
2629
2630 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2631
2632         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2633         variable names.
2634         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2635
2636 2019-03-18  Pedro Alves  <palves@redhat.com>
2637             Eli Zaretskii <eliz@gnu.org>
2638
2639         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2640         m_line and m_start_of_line.
2641
2642 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2643
2644         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2645         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2646         it returns a newline.  This fixes a regression in TU mode, whereby
2647         the next line is output on the same screen line as the user input.
2648
2649 2019-03-18  Tom Tromey  <tromey@adacore.com>
2650
2651         * minsyms.c (minimal_symbol_reader::install): Remove call to
2652         obstack_blank.
2653
2654 2019-03-18  Pedro Alves  <palves@redhat.com>
2655
2656         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2657         New globals.
2658         (apply_style): New, factored out from ...
2659         (apply_ansi_escape): ... this.  Handle reverse video mode.
2660         (tui_set_reverse_mode): New function.
2661         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2662         * tui/tui-winsource.c (tui_show_source_line): Use
2663         tui_set_reverse_mode instead of setting A_STANDOUT.
2664         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2665         New setter methods.
2666
2667 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2668
2669         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2670         Handle tabs.
2671
2672 2019-03-18  Tom Tromey  <tromey@adacore.com>
2673
2674         * ada-lang.c (empty_array): Add "high" parameter.
2675         (ada_evaluate_subexp): Update.
2676
2677 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2678
2679         * unittests/string_view-selftests.c: Define
2680         _initialize_string_view_selftests unconditionally.
2681
2682 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2683
2684         PR gdb/24350
2685         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2686
2687 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2688
2689         PR gdb/24351
2690         * windows-nat.c (display_selector): Fix format specifiers.
2691
2692 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2693
2694         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2695         tui_refill_source_window instead of tui_refresh_win, to update the
2696         current execution line.  This fixes redisplay of the current line
2697         when stepping through the code with "next" or "step".
2698
2699 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2700
2701         * source-cache.c (source_cache::get_source_lines): Call
2702         find_source_lines to initialize s->nlines.  This fixes vertical
2703         scrolling of TUI source window when the DOWN arrow is pressed.
2704
2705 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2706
2707         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2708         linux-thread-db.c (_initialize_thread_db): Likewise.
2709
2710 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2711
2712         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2713         wclrtoeol in tui_show_source_line".  This reverts changes made in
2714         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2715
2716 2019-03-15  Tom Tromey  <tom@tromey.com>
2717
2718         * symtab.h (struct minimal_symbol): Derive from
2719         general_symbol_info.
2720         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2721         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2722         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2723         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2724         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2725         (MSYMBOL_SEARCH_NAME): Update.
2726         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2727         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2728         * minsyms.c (minimal_symbol_reader::record_full): Update.
2729
2730 2019-03-15  Tom Tromey  <tom@tromey.com>
2731
2732         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2733
2734 2019-03-15  Tom Tromey  <tom@tromey.com>
2735
2736         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2737         unique_xmalloc_ptr.
2738         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2739         Update.
2740         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2741         (build_minimal_symbol_hash_tables)
2742         (minimal_symbol_reader::install): Update.
2743
2744 2019-03-15  Tom Tromey  <tom@tromey.com>
2745
2746         * symtab.c (create_demangled_names_hash): Update.
2747         (symbol_set_names): Update.
2748         * objfiles.h (struct objfile_per_bfd_storage)
2749         <demangled_names_hash>: Now an htab_up.
2750         * objfiles.c (objfile_per_bfd_storage): Simplify.
2751
2752 2019-03-15  Tom Tromey  <tom@tromey.com>
2753
2754         * objfiles.h (struct objfile_per_bfd_storage): Declare
2755         destructor.
2756         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2757         New.
2758         (get_objfile_bfd_data): Use new.  Don't initialize
2759         language_of_main.
2760         (free_objfile_per_bfd_storage): Remove.
2761         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2762
2763 2019-03-15  Tom Tromey  <tom@tromey.com>
2764
2765         * symfile.c (reread_symbols): Update.
2766         * objfiles.c (objfile::objfile): Update.
2767         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2768         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2769         comment.
2770         (minimal_symbol_reader::install): Update.
2771         (terminate_minimal_symbol_table): Remove.
2772         * jit.c (jit_object_close_impl): Update.
2773
2774 2019-03-15  Tom Tromey  <tom@tromey.com>
2775
2776         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2777         initializations.
2778
2779 2019-03-15  Tom Tromey  <tom@tromey.com>
2780
2781         * objfiles.h (struct objfile_per_bfd_storage)
2782         <demangled_hash_languages>: Now a bitset.
2783         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2784         (lookup_minimal_symbol): Update.
2785
2786 2019-03-15  Tom Tromey  <tom@tromey.com>
2787
2788         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2789         Don't return the symbol.
2790         * coffread.c (record_minimal_symbol): Use record_full.
2791
2792 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2793
2794         The MS-Windows port of ncurses fails to switch to a color pair if
2795         one or both of the colors are the implicit default colors.  This
2796         change records the default colors when TUI is initialized, and
2797         then specifies them explicitly when a color pair uses the default
2798         colors.  This allows color styling in TUI mode on MS-Windows.
2799
2800         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2801         ncurses_norm_attr.
2802         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2803         colors in ncurses_norm_attr.
2804         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2805         "none", replace it with the default color recorded in
2806         ncurses_norm_attr.
2807
2808 2019-03-14  Tom Tromey  <tromey@adacore.com>
2809
2810         * source-cache.h (class source_cache) <get_source_lines>: Return
2811         std::string.
2812         * source-cache.c (source_cache::extract_lines): Handle case where
2813         first_pos==npos.  Return std::string.
2814         (source_cache::get_source_lines): Update.
2815
2816 2019-03-14  Tom Tromey  <tromey@adacore.com>
2817
2818         * NEWS: Add item for "style sources" commands.
2819         * source-cache.c (source_cache::get_source_lines): Check
2820         source_styling.
2821         * cli/cli-style.c (source_styling): New global.
2822         (_initialize_cli_style): Add "style sources" commands.
2823         (show_style_sources): New function.
2824         * cli/cli-style.h (source_styling): Declare.
2825
2826 2019-03-14  Pedro Alves  <palves@redhat.com>
2827             Tom Tromey  <tromey@adacore.com>
2828
2829         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2830         * tui/tui-winsource.c (tui_refill_source_window): New function,
2831         from...
2832         (tui_horizontal_source_scroll): ... here.  Move some logic.
2833         * cli/cli-style.c (set_style_enabled): Notify new observable.
2834         * tui/tui-hooks.c (tui_redisplay_source): New function.
2835         (tui_attach_detach_observers): Attach or detach
2836         tui_redisplay_source.
2837         * observable.h (source_styling_changed): New observable.
2838         * observable.c: Define source_styling_changed observable.
2839
2840 2019-03-13  Tom Tromey  <tromey@adacore.com>
2841
2842         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2843         (i386_gnu_nat_target::store_registers): Update.
2844         * target-debug.h (target_debug_print_std_string): New macro.
2845         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2846         * windows-tdep.c (display_one_tib): Update.
2847         * tui/tui-stack.c (tui_make_status_line): Update.
2848         * top.c (print_inferior_quit_action): Update.
2849         * thread.c (thr_try_catch_cmd): Update.
2850         (add_thread_with_info): Update.
2851         (thread_target_id_str): Update.
2852         (thr_try_catch_cmd): Update.
2853         (thread_command): Update.
2854         (thread_find_command): Update.
2855         * record-btrace.c (record_btrace_target::info_record)
2856         (record_btrace_resume_thread, record_btrace_target::resume)
2857         (record_btrace_cancel_resume, record_btrace_step_thread)
2858         (record_btrace_target::wait, record_btrace_target::wait)
2859         (record_btrace_target::wait, record_btrace_target::stop): Update.
2860         * progspace.c (print_program_space): Update.
2861         * process-stratum-target.c
2862         (process_stratum_target::thread_address_space): Update.
2863         * linux-fork.c (linux_fork_mourn_inferior)
2864         (detach_checkpoint_command, info_checkpoints_command)
2865         (linux_fork_context): Update.
2866         (linux_fork_detach): Update.
2867         (class scoped_switch_fork_info): Update.
2868         (delete_checkpoint_command): Update.
2869         * infrun.c (follow_fork_inferior): Update.
2870         (follow_fork_inferior): Update.
2871         (proceed_after_vfork_done): Update.
2872         (handle_vfork_child_exec_or_exit): Update.
2873         (follow_exec): Update.
2874         (displaced_step_prepare_throw): Update.
2875         (displaced_step_restore): Update.
2876         (start_step_over): Update.
2877         (resume_1): Update.
2878         (clear_proceed_status_thread): Update.
2879         (proceed): Update.
2880         (print_target_wait_results): Update.
2881         (do_target_wait): Update.
2882         (context_switch): Update.
2883         (stop_all_threads): Update.
2884         (restart_threads): Update.
2885         (finish_step_over): Update.
2886         (handle_signal_stop): Update.
2887         (switch_back_to_stepped_thread): Update.
2888         (keep_going_pass_signal): Update.
2889         (print_exited_reason): Update.
2890         (normal_stop): Update.
2891         * inferior.c (inferior_pid_to_str): Change return type.
2892         (print_selected_inferior): Update.
2893         (add_inferior): Update.
2894         (detach_inferior): Update.
2895         * dummy-frame.c (fprint_dummy_frames): Update.
2896         * dcache.c (dcache_info_1): Update.
2897         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2898         (btrace_fetch, btrace_clear): Update.
2899         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2900         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2901         type.
2902         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2903         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2904         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2905         * gdbarch.c, gdbarch.h: Rebuild.
2906         * gdbarch.sh (core_pid_to_str): Change return type.
2907         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2908         return type.
2909         (windows_nat_target::pid_to_str): Change return type.
2910         (windows_delete_thread): Update.
2911         (windows_nat_target::attach): Update.
2912         (windows_nat_target::files_info): Update.
2913         * target-delegates.c: Rebuild.
2914         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2915         return type.
2916         (sol_thread_target::pid_to_str): Change return type.
2917         * remote.c (class remote_target) <pid_to_str>: Change return
2918         type.
2919         (remote_target::pid_to_str): Change return type.
2920         (extended_remote_target::attach, remote_target::remote_stop_ns)
2921         (remote_target::remote_notif_remove_queued_reply)
2922         (remote_target::push_stop_reply, remote_target::disable_btrace):
2923         Update.
2924         (extended_remote_target::attach): Update.
2925         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2926         type.
2927         (gdbsim_target::pid_to_str): Change return type.
2928         * ravenscar-thread.c (struct ravenscar_thread_target)
2929         <pid_to_str>: Change return type.
2930         (ravenscar_thread_target::pid_to_str): Change return type.
2931         * procfs.c (class procfs_target) <pid_to_str>: Change return
2932         type.
2933         (procfs_target::pid_to_str): Change return type.
2934         (procfs_target::attach): Update.
2935         (procfs_target::detach): Update.
2936         (procfs_target::fetch_registers): Update.
2937         (procfs_target::store_registers): Update.
2938         (procfs_target::wait): Update.
2939         (procfs_target::files_info): Update.
2940         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2941         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2942         return type.
2943         (nto_procfs_target::pid_to_str): Change return type.
2944         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2945         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2946         return type.
2947         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2948         (exit_lwp): Update.
2949         (attach_proc_task_lwp_callback, get_detach_signal)
2950         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2951         (linux_nat_target::resume, wait_lwp, stop_callback)
2952         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2953         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2954         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2955         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2956         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2957         type.
2958         (inf_ptrace_target::attach): Update.
2959         (inf_ptrace_target::files_info): Update.
2960         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2961         type.
2962         (go32_nat_target::pid_to_str): Change return type.
2963         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2964         (gnu_nat_target::wait): Update.
2965         (gnu_nat_target::wait): Update.
2966         (gnu_nat_target::resume): Update.
2967         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2968         (fbsd_nat_target::wait): Update.
2969         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2970         type.
2971         (darwin_nat_target::attach): Update.
2972         * corelow.c (class core_target) <pid_to_str>: Change return type.
2973         (core_target::pid_to_str): Change return type.
2974         * target.c (normal_pid_to_str): Change return type.
2975         (default_pid_to_str): Likewise.
2976         (target_pid_to_str): Change return type.
2977         (target_translate_tls_address): Update.
2978         (target_announce_detach): Update.
2979         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2980         return type.
2981         (bsd_uthread_target::pid_to_str): Change return type.
2982         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2983         type.
2984         (bsd_kvm_target::pid_to_str): Change return type.
2985         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2986         return type.
2987         (aix_thread_target::pid_to_str): Change return type.
2988         * target.h (struct target_ops) <pid_to_str>: Change return type.
2989         (target_pid_to_str, normal_pid_to_str): Likewise.
2990         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2991         type.
2992         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2993         type.
2994         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2995         return type.
2996         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2997         type.
2998         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2999         type.
3000         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3001         return type.
3002
3003 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3004
3005         * NEWS: Mention that the new default MI version is 3.  Mention
3006         changes to the output of commands and events that deal with
3007         multi-location breakpoints.
3008         * breakpoint.c: Include "mi/mi-out.h".
3009         (print_one_breakpoint): Change output syntax if using MI version
3010         >= 3.
3011         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3012         New.
3013         (mi_multi_location_breakpoint_output_fixed): New.
3014         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3015         (mi_cmd_fix_multi_location_breakpoint_output): New.
3016         (mi_multi_location_breakpoint_output_fixed): New.
3017         * mi/mi-cmds.c (mi_cmds): Register command
3018         -fix-multi-location-breakpoint-output.
3019         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3020         interpreter "mi".
3021
3022 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3023
3024         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3025         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3026         instantiate mi_ui_out based on interpreter name.
3027         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3028         * mi/mi-main.c (mi_load_progress): Likewise.
3029
3030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3031
3032         * NEWS: Combine separate "New targets" sections for 8.3.
3033
3034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3035
3036         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3037         (ppcfbsd_init_abi): Install gdbarch
3038         "fetch_tls_load_module_address" and "get_thread_local_address"
3039         methods.
3040
3041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3042
3043         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3044         (riscv_fbsd_init_abi): Install gdbarch
3045         "fetch_tls_load_module_address" and "get_thread_local_address"
3046         methods.
3047
3048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3049
3050         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3051         (i386fbsd_init_abi): Install gdbarch
3052         "fetch_tls_load_module_address" and "get_thread_local_address"
3053         methods.
3054
3055 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3056
3057         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3058         (amd64fbsd_init_abi): Install gdbarch
3059         "fetch_tls_load_module_address" and "get_thread_local_address"
3060         methods.
3061
3062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3063
3064         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3065         (struct fbsd_pspace_data): New type.
3066         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3067         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3068         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3069         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3070         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3071
3072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3073
3074         * gdbtypes.c (lookup_struct_elt): New function.
3075         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3076         * gdbtypes.h (struct struct_elt): New type.
3077         (lookup_struct_elt): New prototype.
3078
3079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3080
3081         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3082         remove disabled code block.
3083
3084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * gdbarch.sh (get_thread_local_address): New method.
3087         * gdbarch.h, gdbarch.c: Regenerate.
3088         * target.c (target_translate_tls_address): Use
3089         gdbarch_get_thread_local_address if present instead of
3090         target::get_thread_local_address.
3091
3092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3093
3094         * target.h (target::get_thread_local_address): Update comment.
3095
3096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3097
3098         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3099         objfile->separate_debug_objfile_backlink if not NULL.
3100
3101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3102
3103         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3104         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3105         (amd64bsd_store_inferior_registers): Likewise.
3106         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3107         Enable segment base registers.
3108         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3109         PT_GETFSBASE and PT_GETGSBASE.
3110         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3111         PT_SETGSBASE.
3112         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3113         segment base registers.
3114         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3115
3116 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3117
3118         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3119         Update calls to i386_target_description to add 'segments'
3120         parameter.
3121         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3122         add segment base registers.
3123         * arch/i386.c (i386_create_target_description): Add 'segments'
3124         parameter to enable segment base registers.
3125         * arch/i386.h (i386_create_target_description): Likewise.
3126         * features/i386/32bit-segments.xml: New file.
3127         * features/i386/32bit-segments.c: Generate.
3128         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3129         call to i386_target_description to add 'segments' parameter.
3130         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3131         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3132         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3133         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3134         if feature is present.
3135         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3136         Add 'segments' parameter to call to i386_target_description.
3137         (i386_target_description): Add 'segments' parameter to enable
3138         segment base registers.
3139         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3140         to call to i386_target_description.
3141         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3142         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3143         Define I386_NUM_REGS.
3144         (i386_target_description): Add 'segments' parameter to enable
3145         segment base registers.
3146
3147 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3148
3149         PR/24325
3150         * source-cache.c: #undef open and close, to avoid unresolved
3151         externals during linking.
3152
3153 2019-03-12  Tom Tromey  <tromey@adacore.com>
3154
3155         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3156         const.  Add initializers.
3157         (_initialize_remote): Don't initialize ptid globals.
3158
3159 2019-03-12  Pedro Alves  <palves@redhat.com>
3160
3161         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3162
3163 2019-03-12  Pedro Alves  <palves@redhat.com>
3164
3165         * cp-name-parser.y (main): Remove unused 'len' variable.
3166
3167 2019-03-12  Tom Tromey  <tromey@adacore.com>
3168
3169         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3170         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3171
3172 2019-03-12  Tom Tromey  <tromey@adacore.com>
3173
3174         * linux-nat.c (iterate_over_lwps): Update.
3175         (stop_callback): Remove parameter.
3176         (stop_wait_callback, detach_callback, resume_set_callback)
3177         (select_singlestep_lwp_callback, set_ignore_sigint)
3178         (status_callback, resumed_callback, resume_clear_callback)
3179         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3180         data parameter.
3181         (linux_nat_target::detach, linux_nat_target::resume)
3182         (linux_stop_and_wait_all_lwps, select_event_lwp)
3183         (linux_nat_filter_event, linux_nat_wait_1)
3184         (linux_nat_target::kill, linux_nat_target::stop)
3185         (linux_nat_target::stop): Update.
3186         (linux_nat_resume_callback): Change type.
3187         (resume_stopped_resumed_lwps, count_events_callback)
3188         (select_event_lwp_callback): Likewise.
3189         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3190         * arm-linux-nat.c (struct update_registers_data): Remove.
3191         (update_registers_callback): Change type.
3192         (arm_linux_insert_hw_breakpoint1): Update.
3193         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3194         parameter.
3195         (x86_linux_dr_set_addr): Update.
3196         (x86_linux_dr_set_control): Update.
3197         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3198         (iterate_over_lwps): Use gdb::function_view.
3199         * nat/aarch64-linux-hw-point.c (struct
3200         aarch64_dr_update_callback_param): Remove.
3201         (debug_reg_change_callback): Change type.
3202         (aarch64_notify_debug_reg_change): Update.
3203         * s390-linux-nat.c (s390_refresh_per_info): Update.
3204
3205 2019-03-11  Tom Tromey  <tromey@adacore.com>
3206
3207         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3208         redundant assignment to "this_cu".
3209
3210 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3211
3212         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3213
3214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3215
3216         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3217         from...
3218         (rank_one_type): ... this.
3219
3220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3221
3222         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3223         from...
3224         (rank_one_type): ... this.
3225
3226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3227
3228         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3229         from...
3230         (rank_one_type): ... this.
3231
3232 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3233
3234         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3235         from...
3236         (rank_one_type): ... this.
3237
3238 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3239
3240         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3241         from...
3242         (rank_one_type): ... this.
3243
3244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3245
3246         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3247         from...
3248         (rank_one_type): ... this.
3249
3250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3251
3252         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3253         from...
3254         (rank_one_type): ... this.
3255
3256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3257
3258         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3259         from...
3260         (rank_one_type): ... this.
3261
3262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3263
3264         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3265         from...
3266         (rank_one_type): ... this.
3267
3268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3269
3270         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3271         from...
3272         (rank_one_type): ... this.
3273
3274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3275
3276         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3277         from...
3278         (rank_one_type): ... this.
3279
3280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3281
3282         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3283         from...
3284         (rank_one_type): ... this.
3285
3286 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3287
3288         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3289         inferior-events' shows the example events.
3290
3291 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3292
3293         Support styling on native MS-Windows console
3294
3295         PR/24315
3296         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3297         on MS-Windows if $TERM is not defined.
3298
3299         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3300
3301         * posix-hdep.c (gdb_console_fputs):
3302         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3303         functions.
3304         * ui-file.h (gdb_console_fputs): Add prototype.
3305
3306         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3307         back to fputs only if the former returns zero.
3308
3309 2019-03-07  Tom Tromey  <tom@tromey.com>
3310
3311         * symmisc.c (print_symbol_bcache_statistics): Update.
3312         (print_objfile_statistics): Update.
3313         * symfile.c (allocate_symtab): Update.
3314         * stabsread.c: Don't include bcache.h.
3315         * psymtab.h (struct psymbol_bcache): Don't declare.
3316         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3317         (psymbol_bcache_init, psymbol_bcache_free)
3318         (psymbol_bcache_get_bcache): Don't declare.
3319         * psymtab.c (struct psymbol_bcache): Remove.
3320         (psymtab_storage::psymtab_storage): Update.
3321         (psymtab_storage::~psymtab_storage): Update.
3322         (psymbol_bcache_init, psymbol_bcache_free)
3323         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3324         (add_psymbol_to_bcache): Update.
3325         (allocate_psymtab): Update.
3326         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3327         macro_cache>: No longer pointers.
3328         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3329         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3330         * macrotab.c (macro_bcache): Update.
3331         * macroexp.c: Don't include bcache.h.
3332         * gdbtypes.c (check_types_worklist): Update.
3333         (types_deeply_equal): Remove TRY/CATCH.  Update.
3334         * elfread.c (elf_symtab_read): Update.
3335         * dwarf2read.c: Don't include bcache.h.
3336         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3337         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3338         (print_bcache_statistics, bcache_memory_used): Don't declare.
3339         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3340         methods.  Rename all data members.
3341         * bcache.c (struct bcache): Move to bcache.h.
3342         (bcache::expand_hash_table): Rename from expand_hash_table.
3343         (bcache): Remove.
3344         (bcache::insert): Rename from bcache_full.
3345         (bcache::compare): Rename from bcache_compare.
3346         (bcache_xmalloc): Remove.
3347         (bcache::~bcache): Rename from bcache_xfree.
3348         (bcache::print_statistics): Rename from print_bcache_statistics.
3349         (bcache::memory_used): Rename from bcache_memory_used.
3350
3351 2019-03-07  Pedro Alves  <palves@redhat.com>
3352
3353         * infrun.c (normal_stop): Also check for
3354         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3355
3356 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * f-lang.c (value_from_host_double): Moved to...
3359         * value.c (value_from_host_double): ...here.
3360         * value.h (value_from_host_double): Declare.
3361         * guile/scm-math.c (vlscm_convert_typed_number): Use
3362         value_from_host_double.
3363         (vlscm_convert_number): Likewise.
3364         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3365         * python/py-value.c (convert_value_from_python): Likewise.
3366
3367 2019-03-06  Tom Tromey  <tom@tromey.com>
3368
3369         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3370
3371 2019-03-06  Tom Tromey  <tom@tromey.com>
3372
3373         * utils.h (free_current_contents): Don't declare.
3374         * utils.c (free_current_contents): Remove.
3375
3376 2019-03-06  Tom Tromey  <tom@tromey.com>
3377
3378         * top.c (quit_force): Update.
3379         * main.c (captured_command_loop): Update.
3380         * common/new-op.c (operator new): Update.
3381         * common/common-exceptions.c (struct catcher)
3382         <save_cleanup_chain>: Remove member.
3383         (exceptions_state_mc_init): Update.
3384         (exception_try_scope_entry): Return nullptr.
3385         (exception_try_scope_exit, exception_rethrow)
3386         (throw_exception_sjlj, throw_exception_cxx): Update.
3387         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3388         (all_cleanups, do_cleanups, discard_cleanups)
3389         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3390         (restore_cleanups, restore_final_cleanups): Don't declare.
3391         (do_final_cleanups): Remove parameter.
3392         * common/cleanups.c (cleanup_chain, make_cleanup)
3393         (make_cleanup_dtor, all_cleanups, do_cleanups)
3394         (discard_my_cleanups, discard_cleanups)
3395         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3396         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3397         (null_cleanup): Remove.
3398         (do_final_cleanups): Remove parameter.
3399
3400 2019-03-06  Tom Tromey  <tom@tromey.com>
3401
3402         * remote.c (remote_target::remote_parse_stop_reply): Use
3403         unique_xmalloc_ptr.
3404
3405 2019-03-06  Tom Tromey  <tom@tromey.com>
3406
3407         * stabsread.c (struct stabs_field_info): Rename from field_info.
3408         <list, fnlist>: Add initializers.
3409         <obstack>: New member.
3410         (read_member_functions, read_struct_fields, read_baseclasses):
3411         Allocate on obstack.  Don't use cleanups.
3412         (read_one_struct_field, read_member_functions, read_struct_fields)
3413         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3414         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3415         (read_struct_type): Update.
3416
3417 2019-03-06  Tom Tromey  <tom@tromey.com>
3418
3419         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3420         * common/filestuff.h (make_cleanup_close): Don't declare.
3421         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3422         Remove.
3423
3424 2019-03-06  Tom Tromey  <tom@tromey.com>
3425
3426         * solib-aix.c: Use make_scope_exit.
3427
3428 2019-03-06  Tom Tromey  <tom@tromey.com>
3429
3430         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3431         Use make_scope_exit.
3432
3433 2019-03-06  Tom Tromey  <tom@tromey.com>
3434
3435         * solib-svr4.c (disable_probes_interface): Remove parameter.
3436         (svr4_handle_solib_event): Use make_scope_exit.
3437
3438 2019-03-06  Tom Tromey  <tom@tromey.com>
3439
3440         * remote.c (struct stop_reply_deleter): Remove.
3441         (stop_reply_up): Update.
3442         (struct stop_reply): Derive from notif_event.  Don't typedef.
3443         <regcache>: Now a std::vector.
3444         (stop_reply_xfree): Remove.
3445         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3446         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3447         (remote_target::discard_pending_stop_replies): Use delete.
3448         (remote_target::remote_parse_stop_reply): Update.
3449         (remote_target::process_stop_reply): Update.
3450         * remote-notif.h (struct notif_event): Add virtual destructor.
3451         Remove "dtr" member.
3452         (struct notif_client) <alloc_event>: Return a unique_ptr.
3453         (notif_event_xfree): Don't declare.
3454         (notif_event_up): New typedef.
3455         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3456         (notif_event_xfree, do_notif_event_xfree): Remove.
3457         (remote_notif_state_xfree): Update.
3458
3459 2019-03-06  Tom Tromey  <tom@tromey.com>
3460
3461         * infrun.c (displaced_step_clear_cleanup): Now a
3462         forward_scope_exit type.
3463         (displaced_step_prepare_throw): Update.
3464         (displaced_step_fixup): Update.
3465
3466 2019-03-06  Tom Tromey  <tom@tromey.com>
3467
3468         * inferior.h (class inferior): Update comment.
3469         * gdbthread.h (class thread_info): Update comment.
3470
3471 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3472             Tom Tromey  <tom@tromey.com>
3473
3474         * stabsread.h (struct stab_section_list): Remove.
3475         (coffstab_build_psymtabs): Update.
3476         * dbxread.c (symbuf_sections): Now a std::vector.
3477         (sect_idx): New global.
3478         (fill_symbuf): Update.
3479         (coffstab_build_psymtabs): Change type of stabsects parameter.
3480         Update.
3481         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3482         std::vector.
3483         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3484         (coff_locate_sections): Update.
3485         (coff_symfile_read): Remove cleanups.  Update.
3486         (init_stringtab): Add storage parameter.
3487         (free_stringtab, free_stringtab_cleanup): Remove.
3488         (init_lineno): Add storage parameter.
3489         (free_linetab, free_linetab_cleanup): Remove.
3490
3491 2019-03-06  Pedro Alves  <palves@redhat.com>
3492
3493         * linux-fork.c (fork_info::clobber_regs): Delete.
3494         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3495         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3496         comment.  Adjust.
3497         (scoped_switch_fork_info::scoped_switch_fork_info)
3498         (checkpoint_command, linux_fork_context): Adjust
3499         fork_save_infrun_state calls.
3500
3501 2019-03-06  Pedro Alves  <palves@redhat.com>
3502
3503         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3504         (inf_has_multiple_threads): Return 'bool' and rewrite using
3505         inferior_info::threads().
3506
3507 2019-03-06  Pedro Alves  <palves@redhat.com>
3508
3509         * linux-fork.c: Include <list>.
3510         (fork_list): Now a std::list instance.
3511         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3512         (forks_exist_p, find_last_fork): Adjust.
3513         (new_fork): Delete.
3514         (one_fork_p): New.
3515         (add_fork): Adjust.
3516         (free_fork): Delete, folded into fork_info::~fork_info().
3517         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3518         Adjust.
3519         (init_fork_list): Delete.
3520         (linux_fork_killall, linux_fork_mourn_inferior)
3521         (linux_fork_detach, info_checkpoints_command): Adjust.
3522         (_initialize_linux_fork): No longer call init_fork_list.
3523
3524 2019-03-06  Pedro Alves  <palves@redhat.com>
3525
3526         * linux-fork.c (new_fork): New, split out of ...
3527         (add_fork): ... this.  Return void.  Move "first fork" special
3528         case from here, to ...
3529         (checkpoint_command): ... here.
3530         * linux-linux.h (add_fork): Return void.
3531
3532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3533
3534         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3535
3536 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3537             Chris January  <chris.january@arm.com>
3538             David Lecomber  <david.lecomber@arm.com>
3539
3540         * f-exp.y: New token, UNOP_INTRINSIC.
3541         (exp): New pattern using UNOP_INTRINSIC token.
3542         (f77_keywords): Add 'abs' keyword.
3543         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3544         (value_from_host_double): New function.
3545         (evaluate_subexp_f): Support UNOP_ABS.
3546
3547 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3550         types.
3551
3552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3555         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3556         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3557
3558 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3559
3560         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3561
3562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3563             Chris January  <chris.january@arm.com>
3564
3565         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3566         * f-exp.y: Define 'KIND' token.
3567         (exp): New pattern for KIND expressions.
3568         (ptype): Handle types with a kind extension.
3569         (direct_abs_decl): Extend to spot kind extensions.
3570         (f77_keywords): Add 'kind' to the list.
3571         (push_kind_type): New function.
3572         (convert_to_kind_type): New function.
3573         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3574         * parse.c (operator_length_standard): Likewise.
3575         * parser-defs.h (enum type_pieces): Add tp_kind.
3576         * std-operator.def: Add UNOP_KIND.
3577
3578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         * f-exp.y (f_parse): Set yydebug.
3581
3582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * f-lang.c (evaluate_subexp_f): New function.
3585         (exp_descriptor_f): New global.
3586         (f_language_defn): Use exp_descriptor_f instead of
3587         exp_descriptor_standard.
3588
3589 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         * f-exp.y (struct token): Add comments.
3592         (dot_ops): Remove uppercase versions and the end marker.
3593         (f77_keywords): Likewise.
3594         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3595         entries in the dot_ops array are case insensitive, and use
3596         strncasecmp to compare strings.  Also some whitespace cleanup in
3597         this area.  Similar for the f77_keywords array, except entries in
3598         this list might be case sensitive.
3599
3600 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3601
3602         * f-exp.y (struct f77_boolean_val): Add comments.
3603         (boolean_values): Remove uppercase versions, and end marker.
3604         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3605         and use strncasecmp to achieve case insensitivity.  Additionally,
3606         perform whitespace cleanup around this code.
3607
3608 2019-03-06  Tom Tromey  <tromey@adacore.com>
3609
3610         * remote-sim.c (gdbsim_target_open): Use result of
3611         gdb_argv::release.
3612
3613 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3614         Dirk Schubert  <dirk.schubert@arm.com>
3615         Chris January  <chris.january@arm.com>
3616
3617         * eval.c (evaluate_subexp_standard): Call Fortran argument
3618         wrapping logic.
3619         * f-lang.c (struct value): A value which can be passed into a
3620         Fortran function call.
3621         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3622         where appropriate.
3623         (struct type): Value ready for a Fortran function call.
3624         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3625         is needed.
3626         * f-lang.h (fortran_argument_convert): Declaration.
3627         (fortran_preserve_arg_pointer): Declaration.
3628         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3629
3630 2019-03-05  Tom Tromey  <tromey@adacore.com>
3631
3632         * python/py-prettyprint.c (print_string_repr): Remove #if.
3633         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3634
3635 2019-03-05  Tom Tromey  <tromey@adacore.com>
3636
3637         * target.c (the_dummy_target): Move later.  Change type to
3638         "dummy_target".
3639         (initialize_targets): Don't initialize the_dummy_target.
3640
3641 2019-03-05  Tom Tromey  <tromey@adacore.com>
3642
3643         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3644         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3645
3646 2019-03-05  Tom Tromey  <tromey@adacore.com>
3647
3648         * windows-nat.c (windows_nat_target::attach)
3649         (windows_nat_target::detach): Don't call gdb_flush.
3650         * valprint.c (generic_val_print, val_print, val_print_string):
3651         Don't call gdb_flush.
3652         * utils.c (defaulted_query): Don't call gdb_flush.
3653         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3654         * target.c (target_announce_detach): Don't call gdb_flush.
3655         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3656         * remote.c (extended_remote_target::attach): Don't call
3657         gdb_flush.
3658         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3659         * printcmd.c (do_examine): Don't call gdb_flush.
3660         (info_display_command): Don't call gdb_flush.
3661         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3662         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3663         * memattr.c (info_mem_command): Don't call gdb_flush.
3664         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3665         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3666         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3667         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3668         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3669         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3670         (gnu_nat_target::detach): Don't call gdb_flush.
3671         * f-valprint.c (f_val_print): Don't call gdb_flush.
3672         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3673         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3674         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3675         gdb_flush.
3676         * c-valprint.c (c_val_print): Don't call gdb_flush.
3677         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3678
3679 2019-03-05  Tom Tromey  <tromey@adacore.com>
3680
3681         * varobj.c (update_dynamic_varobj_children): Update.
3682         (install_default_visualizer): Use reset, not release.
3683         * value.c (set_internalvar): Update.
3684         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3685         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3686         ATTRIBUTE_UNUSED_RESULT.
3687
3688 2019-03-05  Tom Tromey  <tromey@adacore.com>
3689
3690         * remote.c (class scoped_remote_fd) <release>: Add
3691         ATTRIBUTE_UNUSED_RESULT.
3692
3693 2019-03-05  Tom Tromey  <tromey@adacore.com>
3694
3695         * macroexp.c (struct macro_buffer) <release>: Add
3696         ATTRIBUTE_UNUSED_RESULT.
3697
3698 2019-03-05  Tom Tromey  <tromey@adacore.com>
3699
3700         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3701         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3702         ATTRIBUTE_UNUSED_RESULT.
3703
3704 2019-03-05  Tom Tromey  <tromey@adacore.com>
3705
3706         * common/scoped_fd.h (class scoped_fd) <release>: Add
3707         ATTRIBUTE_UNUSED_RESULT.
3708
3709 2019-03-05  Tom Tromey  <tromey@adacore.com>
3710
3711         * parser-defs.h (struct parser_state) <release>: Add
3712         ATTRIBUTE_UNUSED_RESULT.
3713
3714 2019-03-05  Tom Tromey  <tromey@adacore.com>
3715
3716         * utils.h (class gdb_argv) <release>: Add
3717         ATTRIBUTE_UNUSED_RESULT.
3718         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3719
3720 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3721
3722         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3723         for-loop range, to avoid compiler warnings.
3724
3725         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3726         avoid compiler warnings about unused variables.
3727
3728         * NEWS: Mention end of support for native debugging on MS-Windows
3729         before XP.
3730
3731         PR gdb/24292
3732         * common/netstuff.c:
3733         * gdbserver/gdbreplay.c
3734         * gdbserver/remote-utils.c:
3735         * ser-tcp.c:
3736         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3737         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3738         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3739         'getaddrinfo' and 'freeaddrinfo' were not available before
3740         Windows XP, and mingw.org's MinGW headers by default define
3741         _WIN32_WINNT to 0x500.
3742
3743 2019-03-01  Gary Benson <gbenson@redhat.com>
3744
3745         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3746
3747 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3748             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3749
3750         PR gdb/8527
3751         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3752         set_sigint_trap, clear_sigint_trap.
3753
3754 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3755
3756         * target.c (target_detach): Clear the regcache and the
3757         frame cache.
3758
3759 2019-02-27  Pedro Alves  <palves@redhat.com>
3760
3761         * utils.c (set_screen_size): When we cap the height/width sizes,
3762         tweak the corresponding command variable to show "unlimited":
3763
3764 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3765             Pedro Alves  <palves@redhat.com>
3766
3767         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3768         before calling rl_set_screen_size.
3769
3770 2019-02-27  Tom Tromey  <tromey@adacore.com>
3771
3772         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3773         define.
3774         * python/py-value.c: Remove Python 2.4 workaround.
3775         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3776         workaround.
3777         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3778         Python 2.4 workaround.
3779         * python/python-internal.h: Remove Python 2.4 comment.
3780         (Py_ssize_t): Don't define.
3781         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3782         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3783         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3784         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3785         * python/python.c (do_start_initialization): Remove Python 2.4
3786         workaround.
3787         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3788         (print_children): Remove Python 2.4 workaround.
3789         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3790         workaround.
3791         (CHARBUFFERPROC_NAME): Remove.
3792         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3793         Python 2.4 workaround.
3794
3795 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3796
3797         * NEWS: Note minimum Python version.
3798
3799 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3800
3801         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3802         code from these functions.  Remove corresponding ifdefs.  Use
3803         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3804         Remove gotos and target of gotos.
3805         (infpy_search_memory): Likewise.
3806
3807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3810         (hppa_gdbarch_init): Don't register deleted functions with
3811         gdbarch.
3812
3813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3816         (h8300_unwind_sp): Delete.
3817         (h8300_dummy_id): Delete.
3818         (h8300_gdbarch_init): Don't register deleted functions with
3819         gdbarch.
3820
3821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3824         (ft32_unwind_pc): Delete.
3825         (ft32_unwind_sp): Delete.
3826         (ft32_gdbarch_init): Don't register deleted functions with
3827         gdbarch.
3828
3829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3832         (frv_unwind_pc): Delete.
3833         (frv_unwind_sp): Delete.
3834         (frv_gdbarch_init): Don't register deleted functions with
3835         gdbarch.
3836
3837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3838
3839         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3840         (riscv_unwind_pc): Delete.
3841         (riscv_unwind_sp): Delete.
3842         (riscv_gdbarch_init): Don't register deleted functions with
3843         gdbarch.
3844
3845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3848         (csky_unwind_pc): Delete.
3849         (csky_unwind_sp): Delete.
3850         (csky_gdbarch_init): Don't register deleted functions with
3851         gdbarch.
3852
3853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3856         (cris_unwind_pc): Delete.
3857         (cris_unwind_sp): Delete.
3858         (cris_gdbarch_init): Don't register deleted functions with
3859         gdbarch.
3860
3861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3864         (bfin_unwind_pc): Delete.
3865         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3866
3867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3870         (arm_unwind_pc): Delete.
3871         (arm_unwind_sp): Delete.
3872         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3873
3874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3877         (arc_unwind_pc): Delete.
3878         (arc_unwind_sp): Delete.
3879         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3880
3881 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3884         (alpha_unwind_pc): Delete.
3885         (alpha_gdbarch_init): Don't register deleted functions with
3886         gdbarch.
3887
3888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3891         (aarch64_unwind_pc): Delete.
3892         (aarch64_unwind_sp): Delete.
3893         (aarch64_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * gdbtypes.c (type_align): Don't consider static members when
3899         computing structure alignment.
3900
3901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3904         return 0 for other types.
3905         * arch-utils.c (default_type_align): Always return 0.
3906         * gdbarch.h: Regenerate.
3907         * gdbarch.sh (type_align): Extend comment.
3908         * gdbtypes.c (type_align): Add additional comments, always call
3909         gdbarch_type_align before applying the default rules.
3910         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3911         generic code will then apply a suitable default.
3912         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3913         types, return 0 for other types.
3914
3915 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3916
3917         * NEWS: Create a new section for the next release branch.
3918         Rename the section of the current branch, now that it has
3919         been cut.
3920
3921 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3922
3923         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3924         * version.in: Bump version to 8.3.50.DATE-git.
3925
3926 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3927
3928         * aix-thread.c (ptid_cmp): Remove unused variable.
3929         (get_signaled_thread): Likewise.
3930         (store_regs_user_thread): Likewise.
3931         (store_regs_kernel_thread): Likewise.
3932         (fetch_regs_kernel_thread): Remove shadowed variable.
3933
3934 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * features/riscv/32bit-cpu.xml: Add register numbers.
3937         * features/riscv/32bit-fpu.c: Regenerate.
3938         * features/riscv/32bit-fpu.xml: Add register numbers.
3939         * features/riscv/64bit-cpu.xml: Add register numbers.
3940         * features/riscv/64bit-fpu.c: Regenerate.
3941         * features/riscv/64bit-fpu.xml: Add register numbers.
3942
3943 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3944
3945         * NEWS: Mention two argument form of gdb.Value constructor.
3946         * python/py-value.c (convert_buffer_and_type_to_value): New
3947         function.
3948         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3949         Add support for handling an optional second argument.  Call
3950         convert_buffer_and_type_to_value as appropriate.
3951         * python/python-internal.h (Py_buffer_deleter): New struct.
3952         (Py_buffer_up): New typedef.
3953
3954 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3955
3956         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3957         instead of releasing ownership.
3958
3959 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3960
3961         * dwarf2read.c (open_and_init_dwp_file): Call
3962         elf_numsections instead of bfd_count_sections to initialize
3963         dwp_file->num_sections.
3964
3965 2019-02-25  Tom Tromey  <tromey@adacore.com>
3966
3967         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3968
3969 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3970
3971         * gcore.in: Add '--readnever' option when invoking GDB.
3972
3973 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3974
3975         * MAINTAINERS: Update my email address.
3976
3977 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3978
3979         * build-id.c (build_id_to_debug_bfd_1): New function.
3980         (build_id_to_debug_bfd): Look for separate debug file in
3981         sysroot.
3982
3983 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * gdbarch.sh: Update the copyright year range that is placed into
3986         generated files.
3987
3988 2019-02-22  Keith Seitz  <keiths@redhat.com>
3989
3990         PR symtab/23853
3991         * linespec.c (create_sals_line_offset): Search for the default
3992         symtab's filename instead of its fullname.
3993
3994 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3995
3996         * NEWS: Update style defaults.
3997
3998 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3999
4000         * main.c (captured_main_1): Disable styling in batch mode.
4001
4002 2019-02-20  Tom Tromey  <tom@tromey.com>
4003
4004         * symtab.c (symtab_symbol_info): Fix typos.
4005
4006 2019-02-20  Tom Tromey  <tromey@adacore.com>
4007
4008         * findcmd.c (_initialize_mem_search): Use upper case for
4009         metasyntactic variables.
4010
4011 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4012
4013         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4014         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4015
4016 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4017
4018         * top.h (source_file_name): Change to std::string.
4019         * top.c (source_file_name): Likewise.
4020         (command_line_input): Adjust.
4021         * cli/cli-script.c (script_from_file): Adjust.
4022
4023 2019-02-19  Tom Tromey  <tromey@adacore.com>
4024
4025         * ravenscar-thread.c
4026         (ravenscar_thread_target::update_thread_list): Don't call
4027         ada_build_task_list.
4028         * ada-lang.h (ada_build_task_list): Don't declare.
4029         * ada-tasks.c (struct ada_tasks_inferior_data)
4030         <task_list_valid_p>: Now bool.
4031         (read_known_tasks, ada_task_list_changed)
4032         (ada_tasks_invalidate_inferior_data): Update.
4033         (read_known_tasks_array): Return bool.
4034         (read_known_tasks_list): Likewise.
4035         (read_known_tasks): Return void.
4036         (ada_build_task_list): Now static.
4037
4038 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4041         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4042
4043 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4044
4045         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4046         variant for ada_tasks_pspace_data_handle and
4047         ada_tasks_inferior_data_handle.
4048         (ada_tasks_pspace_data_cleanup): New function.
4049         (ada_tasks_inferior_data_cleanup): New function.
4050
4051 2019-02-17  Tom Tromey  <tom@tromey.com>
4052
4053         * macrotab.h (macro_source_fullname): Return a std::string.
4054         * macrotab.c (macro_include, check_for_redefinition)
4055         (macro_undef, macro_lookup_definition, foreach_macro)
4056         (foreach_macro_in_scope): Update.
4057         (macro_source_fullname): Return a std::string.
4058         * macrocmd.c (show_pp_source_pos): Update.
4059
4060 2019-02-17  Tom Tromey  <tom@tromey.com>
4061
4062         * macrocmd.c (show_pp_source_pos): Style the file names.
4063
4064 2019-02-17  Tom Tromey  <tom@tromey.com>
4065
4066         PR tui/24197:
4067         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4068
4069 2019-02-17  Tom Tromey  <tom@tromey.com>
4070
4071         * ada-lang.c (user_select_syms): Use filtered printing.
4072         * utils.c (wrap_style): New global.
4073         (desired_style): Remove.
4074         (emit_style_escape): Add stream parameter.
4075         (set_output_style, reset_terminal_style, prompt_for_continue):
4076         Update.
4077         (flush_wrap_buffer): Only flush gdb_stdout.
4078         (wrap_here): Set wrap_style.
4079         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4080         treat escape sequences as a character.  Change when wrap buffer is
4081         flushed.
4082         (fputs_styled): Do not set the output style when the default is
4083         requested.
4084         * ui-style.h (struct ui_file_style) <is_default>: New method.
4085         * source.c (print_source_lines_base): Emit escape sequences in one
4086         piece.
4087
4088 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4089
4090         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4091         integers and enumeration types.
4092
4093 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4094
4095         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4096         instead of lookup_symbol_in_language
4097         (do_exact_match): New function.
4098         (ada_get_symbol_name_matcher): Return do_exact_match when
4099         doing a verbatim match.
4100
4101 2019-02-15  Tom Tromey  <tromey@adacore.com>
4102
4103         * ravenscar-thread.c (ravenscar_thread_target::resume)
4104         (ravenscar_thread_target::wait): Special case wildcard requests.
4105
4106 2019-02-15  Tom Tromey  <tromey@adacore.com>
4107
4108         * ravenscar-thread.c (base_ptid): Remove.
4109         (struct ravenscar_thread_target) <close>: New method.
4110         <m_base_ptid>: New member.
4111         <update_inferior_ptid, active_task, task_is_currently_active,
4112         runtime_initialized>: Declare methods.
4113         <ravenscar_thread_target>: Add constructor.
4114         (ravenscar_thread_target::task_is_currently_active)
4115         (ravenscar_thread_target::update_inferior_ptid)
4116         (ravenscar_runtime_initialized): Rename.  Now methods.
4117         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4118         (ravenscar_thread_target::update_thread_list): Update.
4119         (ravenscar_thread_target::active_task): Now method.
4120         (ravenscar_thread_target::store_registers)
4121         (ravenscar_thread_target::prepare_to_store)
4122         (ravenscar_thread_target::prepare_to_store)
4123         (ravenscar_thread_target::mourn_inferior): Update.
4124         (ravenscar_inferior_created): Use "new" to create target.
4125         (ravenscar_thread_target::get_ada_task_ptid): Update.
4126         (_initialize_ravenscar): Don't initialize base_ptid.
4127         (ravenscar_ops): Remove global.
4128
4129 2019-02-15  Tom Tromey  <tromey@adacore.com>
4130
4131         * target.h (push_target): Declare new overload.
4132         * target.c (push_target): New overload, taking an rvalue reference.
4133         * remote.c (remote_target::open_1): Use push_target overload.
4134         * corelow.c (core_target_open): Use push_target overload.
4135
4136 2019-02-15  Tom Tromey  <tromey@adacore.com>
4137
4138         * ravenscar-thread.c (is_ravenscar_task)
4139         (ravenscar_task_is_currently_active): Return bool.
4140         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4141         (_initialize_ravenscar): Remove "(void)".
4142         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4143         Return bool.
4144
4145 2019-02-15  Tom Tromey  <tromey@adacore.com>
4146
4147         * ravenscar-thread.c (ravenscar_runtime_initializer)
4148         (has_ravenscar_runtime, get_running_thread_id)
4149         (ravenscar_thread_target::resume): Fix indentation.
4150
4151 2019-02-15  Tom Tromey  <tromey@adacore.com>
4152
4153         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4154         from ravenscar_arch_ops.
4155         (sparc_ravenscar_ops::fetch_registers)
4156         (sparc_ravenscar_ops::store_registers): Now methods.
4157         (sparc_ravenscar_prepare_to_store): Remove.
4158         (sparc_ravenscar_ops): Redefine.
4159         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4160         methods and destructor.  Remove members.
4161         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4162         (ravenscar_thread_target::store_registers)
4163         (ravenscar_thread_target::prepare_to_store): Update.
4164         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4165         Remove.
4166         (struct ppc_ravenscar_powerpc_ops): Derive from
4167         ravenscar_arch_ops.
4168         (ppc_ravenscar_powerpc_ops::fetch_registers)
4169         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4170         (ppc_ravenscar_powerpc_ops): Redefine.
4171         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4172         (ppc_ravenscar_e500_ops::fetch_registers)
4173         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4174         (ppc_ravenscar_e500_ops): Redefine.
4175         * aarch64-ravenscar-thread.c
4176         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4177         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4178         (aarch64_ravenscar_fetch_registers)
4179         (aarch64_ravenscar_store_registers): Now methods.
4180         (aarch64_ravenscar_ops): Redefine.
4181
4182 2019-02-15  Tom Tromey  <tromey@adacore.com>
4183
4184         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4185         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4186         (ravenscar_thread_target::stopped_by_watchpoint)
4187         (ravenscar_thread_target::stopped_data_address)
4188         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4189
4190 2019-02-15  Tom Tromey  <tromey@adacore.com>
4191
4192         * ravenscar-thread.c: Fix some typos.
4193
4194 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4195             Tom Tromey  <tromey@adacore.com>
4196
4197         * ada-lang.c (ada_exception_sal): Change addr_string to a
4198         std::string.
4199         (create_ada_exception_catchpoint): Update.
4200
4201 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4202             Tom Tromey  <tromey@adacore.com>
4203
4204         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4205         (bp_location_ops): Remove.
4206         (base_breakpoint_allocate_location): Update.
4207         (free_bp_location): Update.
4208         * ada-lang.c (class ada_catchpoint_location)
4209         <ada_catchpoint_location>: Remove ops parameter.
4210         (ada_catchpoint_location_dtor): Remove.
4211         (ada_catchpoint_location_ops): Remove.
4212         (allocate_location_exception): Update.
4213         * breakpoint.h (struct bp_location_ops): Remove.
4214         (class bp_location) <bp_location>: Remove bp_location_ops
4215         parameter.
4216         <~bp_location>: Add destructor.
4217         <ops>: Remove.
4218
4219 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4220             Pedro Alves  <palves@redhat.com>
4221
4222         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4223         'PATH_MAX'.
4224
4225 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4226             Samuel Thibault  <samuel.thibault@gnu.org>
4227             Thomas Schwinge  <thomas@codesourcery.com>
4228
4229         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4230         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4231
4232 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4233
4234         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4235         (check_empty): Use "const char *".
4236
4237         * gnu-nat.c (gnu_nat_target::detach): Instead of
4238         'detach_inferior (pid)' call
4239         'detach_inferior (find_inferior_pid (pid))'.
4240
4241         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4242         'nat/fork-inferior.o'.
4243         * gnu-nat.c: #include "nat/fork-inferior.h".
4244
4245         * gnu-nat.c (gnu_nat_target::detach): Instead of
4246         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4247         * gnu-nat.h: #include "inf-child.h".
4248         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4249         'i386_gnu_nat_target::fetch_registers'.
4250         (gnu_store_registers): Rename/move to
4251         'i386_gnu_nat_target::store_registers'.
4252
4253         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4254         * gnu-nat.h (mach_thread_info): New function.
4255         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4256
4257         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4258
4259 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4260
4261         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4262
4263 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4264
4265         * windows-nat.c (windows_add_thread): Add new parameter
4266         "main_thread_p" with default value set to false.  Update
4267         function documentation as well as all callers.
4268         (windows_delete_thread): Likewise.
4269         (fake_create_process): Update call to windows_add_thread.
4270         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4271         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4272         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4273         call to windows_delete_thread.
4274
4275 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4276
4277         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4278
4279 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4280
4281         * symfile.c (find_separate_debug_file): Use canonical path of
4282         sysroot with child_path instead of gdb_sysroot if it is valid.
4283
4284 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4285
4286         * symfile.c (find_separate_debug_file): Use child_path to
4287         determine if an object file is under a sysroot.
4288
4289 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4290
4291         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4292         unittests/child-path-selftests.c.
4293         * common/pathstuff.c (child_path): New function.
4294         * common/pathstuff.h (child_path): New prototype.
4295         * unittests/child-path-selftests.c: New file.
4296
4297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4298
4299         * symfile.c (find_separate_debug_file): Look for separate debug
4300         files in debug directories under the sysroot.
4301
4302 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4303
4304         * symtab.h (struct minimal_symbol data_p): New const method.
4305         (struct minimal_symbol text_p): Likewise.
4306         * symtab.c (output_source_filename): Use file name style
4307         to print file name.
4308         (print_symbol_info): Likewise.
4309         (print_msymbol_info): Use address style to print addresses.
4310         Use function name style to print executable text symbols.
4311         (expand_symtab_containing_pc): Use data_p.
4312         (find_pc_sect_compunit_symtab): Likewise.
4313
4314 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315
4316         * breakpoint.c (describe_other_breakpoints): Use address style
4317         to print addresses.
4318         (say_where): Likewise.
4319
4320 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4321
4322         * ada-typeprint.c (print_func_type): Print function name
4323         style to print function name.
4324         * c-typeprint.c (c_print_type_1): Likewise.
4325
4326 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4327
4328         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4329         for execve.
4330
4331 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4332
4333         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4334         type_stack.
4335
4336 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4337
4338         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4339         TYPE_CODE_REF types.
4340
4341 2019-02-08  Jim Wilson  <jimw@sifive.com>
4342
4343         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4344         (riscv_linux_fregset): New.
4345         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4346
4347 2019-02-07  Tom Tromey  <tom@tromey.com>
4348
4349         * thread.c (thread_cancel_execution_command): Update.
4350         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4351         methods.
4352         (struct thread_fsm_ops): Remove.
4353         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4354         (thread_fsm_should_stop, thread_fsm_return_value)
4355         (thread_fsm_set_finished, thread_fsm_finished_p)
4356         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4357         Don't declare.
4358         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4359         * infrun.c (clear_proceed_status_thread)
4360         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4361         (print_stop_event): Update.
4362         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4363         Add constructor.
4364         (step_command_fsm_ops): Remove.
4365         (new_step_command_fsm): Remove.
4366         (step_1): Update.
4367         (step_command_fsm::should_stop): Rename from
4368         step_command_fsm_should_stop.
4369         (step_command_fsm::clean_up): Rename from
4370         step_command_fsm_clean_up.
4371         (step_command_fsm::do_async_reply_reason): Rename from
4372         step_command_fsm_async_reply_reason.
4373         (struct until_next_fsm): Inherit from thread_fsm.  Add
4374         constructor.
4375         (until_next_fsm_ops): Remove.
4376         (new_until_next_fsm): Remove.
4377         (until_next_fsm::should_stop): Rename from
4378         until_next_fsm_should_stop.
4379         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4380         (until_next_fsm::do_async_reply_reason): Rename from
4381         until_next_fsm_async_reply_reason.
4382         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4383         constructor.  Change type of breakpoint.
4384         (finish_command_fsm_ops): Remove.
4385         (new_finish_command_fsm): Remove.
4386         (finish_command_fsm::should_stop): Rename from
4387         finish_command_fsm_should_stop.
4388         (finish_command_fsm::clean_up): Rename from
4389         finish_command_fsm_clean_up.
4390         (finish_command_fsm::return_value): Rename from
4391         finish_command_fsm_return_value.
4392         (finish_command_fsm::do_async_reply_reason): Rename from
4393         finish_command_fsm_async_reply_reason.
4394         (finish_command): Update.
4395         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4396         Add constructor.
4397         (call_thread_fsm_ops): Remove.
4398         (call_thread_fsm::call_thread_fsm): Rename from
4399         new_call_thread_fsm.
4400         (call_thread_fsm::should_stop): Rename from
4401         call_thread_fsm_should_stop.
4402         (call_thread_fsm::should_notify_stop): Rename from
4403         call_thread_fsm_should_notify_stop.
4404         (run_inferior_call, call_function_by_hand_dummy): Update.
4405         * cli/cli-interp.c (should_print_stop_to_console): Update.
4406         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4407         Add constructor.  Change type of location_breakpoint,
4408         caller_breakpoint.
4409         (until_break_fsm_ops): Remove.
4410         (new_until_break_fsm): Remove.
4411         (until_break_fsm::should_stop): Rename from
4412         until_break_fsm_should_stop.
4413         (until_break_fsm::clean_up): Rename from
4414         until_break_fsm_clean_up.
4415         (until_break_fsm::do_async_reply_reason): Rename from
4416         until_break_fsm_async_reply_reason.
4417         (until_break_command): Update.
4418         * thread-fsm.c: Remove.
4419         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4420
4421 2019-02-07  Tom Tromey  <tom@tromey.com>
4422
4423         * yy-remap.h: Add include guard.
4424         * xtensa-tdep.h: Add include guard.
4425         * xcoffread.h: Rename include guard.
4426         * varobj-iter.h: Add include guard.
4427         * tui/tui.h: Rename include guard.
4428         * tui/tui-winsource.h: Rename include guard.
4429         * tui/tui-wingeneral.h: Rename include guard.
4430         * tui/tui-windata.h: Rename include guard.
4431         * tui/tui-win.h: Rename include guard.
4432         * tui/tui-stack.h: Rename include guard.
4433         * tui/tui-source.h: Rename include guard.
4434         * tui/tui-regs.h: Rename include guard.
4435         * tui/tui-out.h: Rename include guard.
4436         * tui/tui-layout.h: Rename include guard.
4437         * tui/tui-io.h: Rename include guard.
4438         * tui/tui-hooks.h: Rename include guard.
4439         * tui/tui-file.h: Rename include guard.
4440         * tui/tui-disasm.h: Rename include guard.
4441         * tui/tui-data.h: Rename include guard.
4442         * tui/tui-command.h: Rename include guard.
4443         * tic6x-tdep.h: Add include guard.
4444         * target/waitstatus.h: Rename include guard.
4445         * target/wait.h: Rename include guard.
4446         * target/target.h: Rename include guard.
4447         * target/resume.h: Rename include guard.
4448         * target-float.h: Rename include guard.
4449         * stabsread.h: Add include guard.
4450         * rs6000-tdep.h: Add include guard.
4451         * riscv-fbsd-tdep.h: Add include guard.
4452         * regformats/regdef.h: Rename include guard.
4453         * record.h: Rename include guard.
4454         * python/python.h: Rename include guard.
4455         * python/python-internal.h: Rename include guard.
4456         * python/py-stopevent.h: Rename include guard.
4457         * python/py-ref.h: Rename include guard.
4458         * python/py-record.h: Rename include guard.
4459         * python/py-record-full.h: Rename include guard.
4460         * python/py-record-btrace.h: Rename include guard.
4461         * python/py-instruction.h: Rename include guard.
4462         * python/py-events.h: Rename include guard.
4463         * python/py-event.h: Rename include guard.
4464         * procfs.h: Add include guard.
4465         * proc-utils.h: Add include guard.
4466         * p-lang.h: Add include guard.
4467         * or1k-tdep.h: Rename include guard.
4468         * observable.h: Rename include guard.
4469         * nto-tdep.h: Rename include guard.
4470         * nat/x86-linux.h: Rename include guard.
4471         * nat/x86-linux-dregs.h: Rename include guard.
4472         * nat/x86-gcc-cpuid.h: Add include guard.
4473         * nat/x86-dregs.h: Rename include guard.
4474         * nat/x86-cpuid.h: Rename include guard.
4475         * nat/ppc-linux.h: Rename include guard.
4476         * nat/mips-linux-watch.h: Rename include guard.
4477         * nat/linux-waitpid.h: Rename include guard.
4478         * nat/linux-ptrace.h: Rename include guard.
4479         * nat/linux-procfs.h: Rename include guard.
4480         * nat/linux-osdata.h: Rename include guard.
4481         * nat/linux-nat.h: Rename include guard.
4482         * nat/linux-namespaces.h: Rename include guard.
4483         * nat/linux-btrace.h: Rename include guard.
4484         * nat/glibc_thread_db.h: Rename include guard.
4485         * nat/gdb_thread_db.h: Rename include guard.
4486         * nat/gdb_ptrace.h: Rename include guard.
4487         * nat/fork-inferior.h: Rename include guard.
4488         * nat/amd64-linux-siginfo.h: Rename include guard.
4489         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4490         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4491         * nat/aarch64-linux.h: Rename include guard.
4492         * nat/aarch64-linux-hw-point.h: Rename include guard.
4493         * mn10300-tdep.h: Add include guard.
4494         * mips-linux-tdep.h: Add include guard.
4495         * mi/mi-parse.h: Rename include guard.
4496         * mi/mi-out.h: Rename include guard.
4497         * mi/mi-main.h: Rename include guard.
4498         * mi/mi-interp.h: Rename include guard.
4499         * mi/mi-getopt.h: Rename include guard.
4500         * mi/mi-console.h: Rename include guard.
4501         * mi/mi-common.h: Rename include guard.
4502         * mi/mi-cmds.h: Rename include guard.
4503         * mi/mi-cmd-break.h: Rename include guard.
4504         * m2-lang.h: Add include guard.
4505         * location.h: Rename include guard.
4506         * linux-record.h: Rename include guard.
4507         * linux-nat.h: Add include guard.
4508         * linux-fork.h: Add include guard.
4509         * i386-darwin-tdep.h: Rename include guard.
4510         * hppa-linux-offsets.h: Add include guard.
4511         * guile/guile.h: Rename include guard.
4512         * guile/guile-internal.h: Rename include guard.
4513         * gnu-nat.h: Rename include guard.
4514         * gdb-stabs.h: Rename include guard.
4515         * frv-tdep.h: Add include guard.
4516         * f-lang.h: Add include guard.
4517         * event-loop.h: Add include guard.
4518         * darwin-nat.h: Rename include guard.
4519         * cp-abi.h: Rename include guard.
4520         * config/sparc/nm-sol2.h: Rename include guard.
4521         * config/nm-nto.h: Rename include guard.
4522         * config/nm-linux.h: Add include guard.
4523         * config/i386/nm-i386gnu.h: Rename include guard.
4524         * config/djgpp/nl_types.h: Rename include guard.
4525         * config/djgpp/langinfo.h: Rename include guard.
4526         * compile/gcc-cp-plugin.h: Add include guard.
4527         * compile/gcc-c-plugin.h: Add include guard.
4528         * compile/compile.h: Rename include guard.
4529         * compile/compile-object-run.h: Rename include guard.
4530         * compile/compile-object-load.h: Rename include guard.
4531         * compile/compile-internal.h: Rename include guard.
4532         * compile/compile-cplus.h: Rename include guard.
4533         * compile/compile-c.h: Rename include guard.
4534         * common/xml-utils.h: Rename include guard.
4535         * common/x86-xstate.h: Rename include guard.
4536         * common/version.h: Rename include guard.
4537         * common/vec.h: Rename include guard.
4538         * common/tdesc.h: Rename include guard.
4539         * common/selftest.h: Rename include guard.
4540         * common/scoped_restore.h: Rename include guard.
4541         * common/scoped_mmap.h: Rename include guard.
4542         * common/scoped_fd.h: Rename include guard.
4543         * common/safe-iterator.h: Rename include guard.
4544         * common/run-time-clock.h: Rename include guard.
4545         * common/refcounted-object.h: Rename include guard.
4546         * common/queue.h: Rename include guard.
4547         * common/ptid.h: Rename include guard.
4548         * common/print-utils.h: Rename include guard.
4549         * common/preprocessor.h: Rename include guard.
4550         * common/pathstuff.h: Rename include guard.
4551         * common/observable.h: Rename include guard.
4552         * common/netstuff.h: Rename include guard.
4553         * common/job-control.h: Rename include guard.
4554         * common/host-defs.h: Rename include guard.
4555         * common/gdb_wait.h: Rename include guard.
4556         * common/gdb_vecs.h: Rename include guard.
4557         * common/gdb_unlinker.h: Rename include guard.
4558         * common/gdb_unique_ptr.h: Rename include guard.
4559         * common/gdb_tilde_expand.h: Rename include guard.
4560         * common/gdb_sys_time.h: Rename include guard.
4561         * common/gdb_string_view.h: Rename include guard.
4562         * common/gdb_splay_tree.h: Rename include guard.
4563         * common/gdb_setjmp.h: Rename include guard.
4564         * common/gdb_ref_ptr.h: Rename include guard.
4565         * common/gdb_optional.h: Rename include guard.
4566         * common/gdb_locale.h: Rename include guard.
4567         * common/gdb_assert.h: Rename include guard.
4568         * common/filtered-iterator.h: Rename include guard.
4569         * common/filestuff.h: Rename include guard.
4570         * common/fileio.h: Rename include guard.
4571         * common/environ.h: Rename include guard.
4572         * common/common-utils.h: Rename include guard.
4573         * common/common-types.h: Rename include guard.
4574         * common/common-regcache.h: Rename include guard.
4575         * common/common-inferior.h: Rename include guard.
4576         * common/common-gdbthread.h: Rename include guard.
4577         * common/common-exceptions.h: Rename include guard.
4578         * common/common-defs.h: Rename include guard.
4579         * common/common-debug.h: Rename include guard.
4580         * common/cleanups.h: Rename include guard.
4581         * common/buffer.h: Rename include guard.
4582         * common/btrace-common.h: Rename include guard.
4583         * common/break-common.h: Rename include guard.
4584         * cli/cli-utils.h: Rename include guard.
4585         * cli/cli-style.h: Rename include guard.
4586         * cli/cli-setshow.h: Rename include guard.
4587         * cli/cli-script.h: Rename include guard.
4588         * cli/cli-interp.h: Rename include guard.
4589         * cli/cli-decode.h: Rename include guard.
4590         * cli/cli-cmds.h: Rename include guard.
4591         * charset-list.h: Add include guard.
4592         * buildsym-legacy.h: Rename include guard.
4593         * bfin-tdep.h: Add include guard.
4594         * ax.h: Rename include guard.
4595         * arm-linux-tdep.h: Add include guard.
4596         * arm-fbsd-tdep.h: Add include guard.
4597         * arch/xtensa.h: Rename include guard.
4598         * arch/tic6x.h: Add include guard.
4599         * arch/i386.h: Add include guard.
4600         * arch/arm.h: Rename include guard.
4601         * arch/arm-linux.h: Rename include guard.
4602         * arch/arm-get-next-pcs.h: Rename include guard.
4603         * arch/amd64.h: Add include guard.
4604         * arch/aarch64-insn.h: Rename include guard.
4605         * arch-utils.h: Rename include guard.
4606         * annotate.h: Add include guard.
4607         * amd64-darwin-tdep.h: Rename include guard.
4608         * aarch64-linux-tdep.h: Add include guard.
4609         * aarch64-fbsd-tdep.h: Add include guard.
4610         * aarch32-linux-nat.h: Add include guard.
4611
4612 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4613
4614         * macrotab.c (macro_define_internal): New function that
4615         factorizes macro_define_object_internal and macro_define_function
4616         code.
4617         (macro_define_object_internal): Use macro_define_internal.
4618         (macro_define_function): Likewise.
4619
4620 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4621
4622         * macrocmd.c (extract_identifier): Return
4623         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4624         callers.
4625
4626 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4627
4628         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4629
4630 2019-02-05  Tom Tromey  <tom@tromey.com>
4631
4632         * target.c (target_stack::unpush): Move assertion earlier.
4633
4634 2019-01-30  Tom Tromey  <tom@tromey.com>
4635
4636         PR python/23615:
4637         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4638         (gdbpy_parse_and_eval): Likewise.
4639         * python/python-internal.h (gdbpy_allow_threads): New class.
4640
4641 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4644         (aarch64_fbsd_fpregmap): Move earlier.
4645         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4646         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4647         instead of individual calls to trad_frame_set_reg_addr.
4648         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4649         earlier.
4650         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4651         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4652         instead of individual calls to trad_frame_set_reg_addr.
4653
4654 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4655
4656         * CONTRIBUTE: Replace contribution list with wiki link.
4657
4658 2019-01-25  Tom Tromey  <tom@tromey.com>
4659
4660         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4661
4662 2019-01-25  Tom Tromey  <tom@tromey.com>
4663
4664         * xtensa-linux-nat.c: Fix common/ includes.
4665         * xml-support.h: Fix common/ includes.
4666         * xml-support.c: Fix common/ includes.
4667         * x86-linux-nat.c: Fix common/ includes.
4668         * windows-nat.c: Fix common/ includes.
4669         * varobj.h: Fix common/ includes.
4670         * varobj.c: Fix common/ includes.
4671         * value.c: Fix common/ includes.
4672         * valops.c: Fix common/ includes.
4673         * utils.c: Fix common/ includes.
4674         * unittests/xml-utils-selftests.c: Fix common/ includes.
4675         * unittests/utils-selftests.c: Fix common/ includes.
4676         * unittests/unpack-selftests.c: Fix common/ includes.
4677         * unittests/tracepoint-selftests.c: Fix common/ includes.
4678         * unittests/style-selftests.c: Fix common/ includes.
4679         * unittests/string_view-selftests.c: Fix common/ includes.
4680         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4681         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4682         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4683         * unittests/rsp-low-selftests.c: Fix common/ includes.
4684         * unittests/parse-connection-spec-selftests.c: Fix common/
4685         includes.
4686         * unittests/optional-selftests.c: Fix common/ includes.
4687         * unittests/offset-type-selftests.c: Fix common/ includes.
4688         * unittests/observable-selftests.c: Fix common/ includes.
4689         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4690         * unittests/memrange-selftests.c: Fix common/ includes.
4691         * unittests/memory-map-selftests.c: Fix common/ includes.
4692         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4693         * unittests/function-view-selftests.c: Fix common/ includes.
4694         * unittests/environ-selftests.c: Fix common/ includes.
4695         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4696         * unittests/common-utils-selftests.c: Fix common/ includes.
4697         * unittests/cli-utils-selftests.c: Fix common/ includes.
4698         * unittests/array-view-selftests.c: Fix common/ includes.
4699         * ui-file.c: Fix common/ includes.
4700         * tui/tui-io.c: Fix common/ includes.
4701         * tracepoint.h: Fix common/ includes.
4702         * tracepoint.c: Fix common/ includes.
4703         * tracefile-tfile.c: Fix common/ includes.
4704         * top.h: Fix common/ includes.
4705         * top.c: Fix common/ includes.
4706         * thread.c: Fix common/ includes.
4707         * target/waitstatus.h: Fix common/ includes.
4708         * target/waitstatus.c: Fix common/ includes.
4709         * target.h: Fix common/ includes.
4710         * target.c: Fix common/ includes.
4711         * target-memory.c: Fix common/ includes.
4712         * target-descriptions.c: Fix common/ includes.
4713         * symtab.h: Fix common/ includes.
4714         * symfile.c: Fix common/ includes.
4715         * stap-probe.c: Fix common/ includes.
4716         * spu-linux-nat.c: Fix common/ includes.
4717         * sparc-nat.c: Fix common/ includes.
4718         * source.c: Fix common/ includes.
4719         * solib.c: Fix common/ includes.
4720         * solib-target.c: Fix common/ includes.
4721         * ser-unix.c: Fix common/ includes.
4722         * ser-tcp.c: Fix common/ includes.
4723         * ser-pipe.c: Fix common/ includes.
4724         * ser-base.c: Fix common/ includes.
4725         * selftest-arch.c: Fix common/ includes.
4726         * s12z-tdep.c: Fix common/ includes.
4727         * rust-exp.y: Fix common/ includes.
4728         * rs6000-aix-tdep.c: Fix common/ includes.
4729         * riscv-tdep.c: Fix common/ includes.
4730         * remote.c: Fix common/ includes.
4731         * remote-notif.h: Fix common/ includes.
4732         * remote-fileio.h: Fix common/ includes.
4733         * remote-fileio.c: Fix common/ includes.
4734         * regcache.h: Fix common/ includes.
4735         * regcache.c: Fix common/ includes.
4736         * record-btrace.c: Fix common/ includes.
4737         * python/python.c: Fix common/ includes.
4738         * python/py-type.c: Fix common/ includes.
4739         * python/py-inferior.c: Fix common/ includes.
4740         * progspace.h: Fix common/ includes.
4741         * producer.c: Fix common/ includes.
4742         * procfs.c: Fix common/ includes.
4743         * proc-api.c: Fix common/ includes.
4744         * printcmd.c: Fix common/ includes.
4745         * ppc-linux-nat.c: Fix common/ includes.
4746         * parser-defs.h: Fix common/ includes.
4747         * osdata.c: Fix common/ includes.
4748         * obsd-nat.c: Fix common/ includes.
4749         * nat/x86-linux.c: Fix common/ includes.
4750         * nat/x86-linux-dregs.c: Fix common/ includes.
4751         * nat/x86-dregs.h: Fix common/ includes.
4752         * nat/x86-dregs.c: Fix common/ includes.
4753         * nat/ppc-linux.c: Fix common/ includes.
4754         * nat/mips-linux-watch.h: Fix common/ includes.
4755         * nat/mips-linux-watch.c: Fix common/ includes.
4756         * nat/linux-waitpid.c: Fix common/ includes.
4757         * nat/linux-ptrace.h: Fix common/ includes.
4758         * nat/linux-ptrace.c: Fix common/ includes.
4759         * nat/linux-procfs.c: Fix common/ includes.
4760         * nat/linux-personality.c: Fix common/ includes.
4761         * nat/linux-osdata.c: Fix common/ includes.
4762         * nat/linux-namespaces.c: Fix common/ includes.
4763         * nat/linux-btrace.h: Fix common/ includes.
4764         * nat/linux-btrace.c: Fix common/ includes.
4765         * nat/fork-inferior.c: Fix common/ includes.
4766         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4767         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4768         * nat/aarch64-linux.c: Fix common/ includes.
4769         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4770         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4771         * namespace.h: Fix common/ includes.
4772         * mips-linux-tdep.c: Fix common/ includes.
4773         * minsyms.c: Fix common/ includes.
4774         * mi/mi-parse.h: Fix common/ includes.
4775         * mi/mi-main.c: Fix common/ includes.
4776         * mi/mi-cmd-env.c: Fix common/ includes.
4777         * memrange.h: Fix common/ includes.
4778         * memattr.c: Fix common/ includes.
4779         * maint.h: Fix common/ includes.
4780         * maint.c: Fix common/ includes.
4781         * main.c: Fix common/ includes.
4782         * machoread.c: Fix common/ includes.
4783         * location.c: Fix common/ includes.
4784         * linux-thread-db.c: Fix common/ includes.
4785         * linux-nat.c: Fix common/ includes.
4786         * linux-fork.c: Fix common/ includes.
4787         * inline-frame.c: Fix common/ includes.
4788         * infrun.c: Fix common/ includes.
4789         * inflow.c: Fix common/ includes.
4790         * inferior.h: Fix common/ includes.
4791         * inferior.c: Fix common/ includes.
4792         * infcmd.c: Fix common/ includes.
4793         * inf-ptrace.c: Fix common/ includes.
4794         * inf-child.c: Fix common/ includes.
4795         * ia64-linux-nat.c: Fix common/ includes.
4796         * i387-tdep.c: Fix common/ includes.
4797         * i386-tdep.c: Fix common/ includes.
4798         * i386-linux-tdep.c: Fix common/ includes.
4799         * i386-linux-nat.c: Fix common/ includes.
4800         * i386-go32-tdep.c: Fix common/ includes.
4801         * i386-fbsd-tdep.c: Fix common/ includes.
4802         * i386-fbsd-nat.c: Fix common/ includes.
4803         * guile/scm-type.c: Fix common/ includes.
4804         * guile/guile.c: Fix common/ includes.
4805         * go32-nat.c: Fix common/ includes.
4806         * gnu-nat.c: Fix common/ includes.
4807         * gdbthread.h: Fix common/ includes.
4808         * gdbarch-selftests.c: Fix common/ includes.
4809         * gdb_usleep.c: Fix common/ includes.
4810         * gdb_select.h: Fix common/ includes.
4811         * gdb_bfd.c: Fix common/ includes.
4812         * gcore.c: Fix common/ includes.
4813         * fork-child.c: Fix common/ includes.
4814         * findvar.c: Fix common/ includes.
4815         * fbsd-nat.c: Fix common/ includes.
4816         * event-top.c: Fix common/ includes.
4817         * event-loop.c: Fix common/ includes.
4818         * dwarf2read.c: Fix common/ includes.
4819         * dwarf2loc.c: Fix common/ includes.
4820         * dwarf2-frame.c: Fix common/ includes.
4821         * dwarf-index-cache.c: Fix common/ includes.
4822         * dtrace-probe.c: Fix common/ includes.
4823         * disasm-selftests.c: Fix common/ includes.
4824         * defs.h: Fix common/ includes.
4825         * csky-tdep.c: Fix common/ includes.
4826         * cp-valprint.c: Fix common/ includes.
4827         * cp-support.h: Fix common/ includes.
4828         * cp-support.c: Fix common/ includes.
4829         * corelow.c: Fix common/ includes.
4830         * completer.h: Fix common/ includes.
4831         * completer.c: Fix common/ includes.
4832         * compile/compile.c: Fix common/ includes.
4833         * compile/compile-loc2c.c: Fix common/ includes.
4834         * compile/compile-cplus-types.c: Fix common/ includes.
4835         * compile/compile-cplus-symbols.c: Fix common/ includes.
4836         * command.h: Fix common/ includes.
4837         * cli/cli-dump.c: Fix common/ includes.
4838         * cli/cli-cmds.c: Fix common/ includes.
4839         * charset.c: Fix common/ includes.
4840         * build-id.c: Fix common/ includes.
4841         * btrace.h: Fix common/ includes.
4842         * btrace.c: Fix common/ includes.
4843         * breakpoint.h: Fix common/ includes.
4844         * breakpoint.c: Fix common/ includes.
4845         * ax.h:
4846         (enum agent_op): Fix common/ includes.
4847         * ax-general.c (struct aop_map): Fix common/ includes.
4848         * ax-gdb.c: Fix common/ includes.
4849         * auxv.c: Fix common/ includes.
4850         * auto-load.c: Fix common/ includes.
4851         * arm-tdep.c: Fix common/ includes.
4852         * arch/riscv.c: Fix common/ includes.
4853         * arch/ppc-linux-common.c: Fix common/ includes.
4854         * arch/i386.c: Fix common/ includes.
4855         * arch/arm.c: Fix common/ includes.
4856         * arch/arm-linux.c: Fix common/ includes.
4857         * arch/arm-get-next-pcs.c: Fix common/ includes.
4858         * arch/amd64.c: Fix common/ includes.
4859         * arch/aarch64.c: Fix common/ includes.
4860         * arch/aarch64-insn.c: Fix common/ includes.
4861         * arch-utils.c: Fix common/ includes.
4862         * amd64-windows-tdep.c: Fix common/ includes.
4863         * amd64-tdep.c: Fix common/ includes.
4864         * amd64-sol2-tdep.c: Fix common/ includes.
4865         * amd64-obsd-tdep.c: Fix common/ includes.
4866         * amd64-nbsd-tdep.c: Fix common/ includes.
4867         * amd64-linux-tdep.c: Fix common/ includes.
4868         * amd64-linux-nat.c: Fix common/ includes.
4869         * amd64-fbsd-tdep.c: Fix common/ includes.
4870         * amd64-fbsd-nat.c: Fix common/ includes.
4871         * amd64-dicos-tdep.c: Fix common/ includes.
4872         * amd64-darwin-tdep.c: Fix common/ includes.
4873         * agent.c: Fix common/ includes.
4874         * ada-lang.h: Fix common/ includes.
4875         * ada-lang.c: Fix common/ includes.
4876         * aarch64-tdep.c: Fix common/ includes.
4877
4878 2019-01-25  Tom Tromey  <tom@tromey.com>
4879
4880         * common/create-version.sh: Use common/version.h.
4881
4882 2019-01-24  Pedro Alves  <palves@redhat.com>
4883
4884         * infrun.c (signal_stop, signal_print, signal_program)
4885         (signal_catch, signal_pass): Now arrays instead of pointers.
4886         (update_signals_program_target, do_target_resume)
4887         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4888         * linux-nat.c (linux_nat_target::pass_signals)
4889         (linux_nat_target::create_inferior, linux_nat_target::attach):
4890         Adjust.
4891         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4892         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4893         * procfs.c (procfs_target::pass_signals): Adjust.
4894         * record-full.c (record_full_target::resume): Adjust.
4895         * remote.c (remote_target::pass_signals)
4896         (remote_target::program_signals): Adjust.
4897         * target-debug.h (target_debug_print_signals): Now takes a
4898         gdb::array_view as parameter.  Adjust.
4899         * target.h (target_ops) <pass_signals, program_signals>: Replace
4900         pointer and length parameters with gdb::array_view.
4901         (target_pass_signals, target_program_signals): Likewise.
4902         * target-delegates.c: Regenerate.
4903
4904 2019-01-24  Pedro Alves  <palves@redhat.com>
4905
4906         * common/forward-scope-exit.h
4907         (forward_scope_exit::forward_scope_exit): Pass arguments to
4908         m_bind_function directly, instead of creating a std::bind and
4909         copying that.
4910
4911 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4912
4913         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4914         for static members.
4915         (pass_in_v_vfp_candidate): Likewise.
4916
4917 2019-01-23  Tom Tromey  <tom@tromey.com>
4918             Pedro Alves  <palves@redhat.com>
4919
4920         * regcache.c (class regcache_invalidator): Remove.
4921         (regcache::raw_write): Use make_scope_exit.
4922
4923 2019-01-23  Tom Tromey  <tom@tromey.com>
4924
4925         * ui-out.h (class ui_out_emit_type): Update comment.
4926
4927 2019-01-23  Tom Tromey  <tom@tromey.com>
4928
4929         * infrun.c (fetch_inferior_event): Update comment.
4930
4931 2019-01-23  Tom Tromey  <tom@tromey.com>
4932             Pedro Alves  <palves@redhat.com>
4933
4934         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4935         parameter.
4936         (fetch_inferior_event): Use SCOPE_EXIT.
4937
4938
4939 2019-01-23  Tom Tromey  <tom@tromey.com>
4940             Pedro Alves  <palves@redhat.com>
4941
4942         * infrun.c (disable_thread_events): Delete.
4943         (stop_all_threads): Use SCOPE_EXIT.
4944
4945 2019-01-23  Tom Tromey  <tom@tromey.com>
4946             Pedro Alves  <palves@redhat.com>
4947
4948         * symfile.c: Include forward-scope-exit.h.
4949         (clear_symtab_users_cleanup): Replace forward declaration with
4950         a FORWARD_SCOPE_EXIT.
4951         (syms_from_objfile_1): Use the forward_scope_exit and
4952         gdb::optional instead of cleanup_function.
4953         (reread_symbols): Use the forward_scope_exit instead of
4954         cleanup_function.
4955         (clear_symtab_users_cleanup): Remove function.
4956
4957 2019-01-23  Tom Tromey  <tom@tromey.com>
4958             Pedro Alves  <palves@redhat.com>
4959
4960         * linux-nat.c: Include scope-exit.h.
4961         (cleanup_target_stop): Remove.
4962         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4963         SCOPE_EXIT.
4964
4965 2019-01-23  Tom Tromey  <tom@tromey.com>
4966             Pedro Alves  <palves@redhat.com>
4967
4968         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4969         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4970
4971 2019-01-23  Tom Tromey  <tom@tromey.com>
4972             Andrew Burgess  <andrew.burgess@embecosm.com>
4973             Pedro Alves  <palves@redhat.com>
4974
4975         * infrun.c (fetch_inferior_event): Use scope_exit.
4976         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4977         * top.c (execute_command): Use scope_exit.
4978         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4979         * utils.c (do_bpstat_clear_actions_cleanup)
4980         (make_bpstat_clear_actions_cleanup): Remove.
4981
4982 2019-01-23  Tom Tromey  <tom@tromey.com>
4983             Pedro Alves  <palves@redhat.com>
4984
4985         * infrun.c: Include "common/scope-exit.h"
4986         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4987         (wait_for_inferior): Use SCOPE_EXIT.
4988         (fetch_inferior_event): Use scope_exit.
4989
4990 2019-01-23  Tom Tromey  <tom@tromey.com>
4991             Pedro Alves  <palves@redhat.com>
4992
4993         * breakpoint.c (create_breakpoint): Remove cleanup.
4994
4995 2019-01-23  Tom Tromey  <tom@tromey.com>
4996             Andrew Burgess  <andrew.burgess@embecosm.com>
4997             Pedro Alves  <palves@redhat.com>
4998
4999 2019-01-23  Pedro Alves  <palves@redhat.com>
5000
5001         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5002
5003 2019-01-23  Pedro Alves  <palves@redhat.com>
5004             Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * gdbthread.h: Include "common/forward-scope-exit.h".
5007         (scoped_finish_thread_state): Redefine custom class in terms of
5008         forward_scope_exit.
5009
5010 2019-01-23  Pedro Alves  <palves@redhat.com>
5011             Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * common/forward-scope-exit.h: New file.
5014
5015 2019-01-23  Pedro Alves  <palves@redhat.com>
5016             Andrew Burgess  <andrew.burgess@embecosm.com>
5017             Tom Tromey  <tom@tromey.com>
5018
5019         * common/scope-exit.h: New file.
5020
5021 2019-01-23  Pedro Alves  <palves@redhat.com>
5022
5023         * common/preprocessor.h (ESC): Rename to ...
5024         (ESC_PARENS): ... this.
5025         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5026         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5027
5028 2019-01-23  Tom Tromey  <tom@tromey.com>
5029
5030         * language.h (class scoped_switch_to_sym_language_if_auto):
5031         Initialize m_lang in both cases.
5032
5033 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5034
5035         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5036         with XCNEW.
5037
5038 2019-01-22  Tom Tromey  <tom@tromey.com>
5039
5040         * corelow.c: Do not include sys/file.h.
5041
5042 2019-01-22  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-wingeneral.h: Include gdb_curses.h.
5045
5046 2019-01-22  Tom Tromey  <tom@tromey.com>
5047
5048         * source-cache.h (class source_cache) <get_source_lines,
5049         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5050
5051 2019-01-22  Tom Tromey  <tom@tromey.com>
5052
5053         * remote-fileio.h (struct remote_target): Declare.
5054
5055 2019-01-22  Tom Tromey  <tom@tromey.com>
5056
5057         * python/py-arch.c: Do not include py-ref.h.
5058         * python/py-bpevent.c: Do not include py-ref.h.
5059         * python/py-cmd.c: Do not include py-ref.h.
5060         * python/py-continueevent.c: Do not include py-ref.h.
5061         * python/py-event.h: Do not include py-ref.h.
5062         * python/py-evtregistry.c: Do not include py-ref.h.
5063         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5064         * python/py-frame.c: Do not include py-ref.h.
5065         * python/py-framefilter.c: Do not include py-ref.h.
5066         * python/py-function.c: Do not include py-ref.h.
5067         * python/py-infevents.c: Do not include py-ref.h.
5068         * python/py-linetable.c: Do not include py-ref.h.
5069         * python/py-objfile.c: Do not include py-ref.h.
5070         * python/py-param.c: Do not include py-ref.h.
5071         * python/py-prettyprint.c: Do not include py-ref.h.
5072         * python/py-progspace.c: Do not include py-ref.h.
5073         * python/py-symbol.c: Do not include py-ref.h.
5074         * python/py-symtab.c: Do not include py-ref.h.
5075         * python/py-type.c: Do not include py-ref.h.
5076         * python/py-unwind.c: Do not include py-ref.h.
5077         * python/py-utils.c: Do not include py-ref.h.
5078         * python/py-value.c: Do not include py-ref.h.
5079         * python/py-varobj.c: Do not include py-ref.h.
5080         * python/py-xmethods.c: Do not include py-ref.h.
5081         * python/python.c: Do not include py-ref.h.
5082         * varobj.c: Do not include py-ref.h.
5083
5084 2019-01-22  Tom Tromey  <tom@tromey.com>
5085
5086         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5087         keyword for bcache.
5088
5089 2019-01-22  Tom Tromey  <tom@tromey.com>
5090
5091         * compile/compile-cplus-types.c: Remove a comment by #include.
5092
5093 2019-01-22  Tom Tromey  <tom@tromey.com>
5094
5095         * compile/gcc-c-plugin.h: Include compile-internal.h.
5096
5097 2019-01-22  Tom Tromey  <tom@tromey.com>
5098
5099         * stabsread.c (EXTERN): Do not define.
5100         (symnum, next_symbol_text_func, processing_gcc_compilation)
5101         (within_function, global_sym_chain, global_stabs)
5102         (previous_stab_code, this_object_header_files)
5103         (n_this_object_header_files)
5104         (n_allocated_this_object_header_files): Define.
5105         * stabsread.h (EXTERN): Never define.  Use "extern".
5106
5107 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5108
5109         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5110         history_value.
5111
5112 2019-01-21  Tom Tromey  <tom@tromey.com>
5113
5114         * ui-out.c: Fix includes.
5115         * tui/tui-source.c: Fix includes.
5116         * target.c: Fix includes.
5117         * remote.c: Fix includes.
5118         * regcache.c: Fix includes.
5119         * python/py-block.c: Fix includes.
5120         * printcmd.c: Fix includes.
5121         * or1k-tdep.c: Fix includes.
5122         * mi/mi-main.c: Fix includes.
5123         * m32r-tdep.c: Fix includes.
5124         * csky-tdep.c: Fix includes.
5125         * compile/compile-cplus-types.c: Fix includes.
5126         * cli/cli-interp.c: Fix includes.
5127
5128 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5131         for padding.
5132
5133 2019-01-16  Tom Tromey  <tom@tromey.com>
5134
5135         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5136         earlier.
5137         (struct objfile) <msymbols_range>: Move from top level.
5138         <msymbols>: New method.
5139         (class objfile_msymbols): Remove.
5140         * symtab.c (default_collect_symbol_completion_matches_break_on):
5141         Update.
5142         * symmisc.c (dump_msymbols): Update.
5143         * stabsread.c (scan_file_globals): Update.
5144         * objc-lang.c (info_selectors_command, info_classes_command)
5145         (find_methods): Update.
5146         * minsyms.c (find_solib_trampoline_target): Update.
5147         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5148         * coffread.c (coff_symfile_read): Update.
5149         * ada-lang.c (ada_lookup_simple_minsym)
5150         (ada_collect_symbol_completion_matches): Update.
5151
5152 2019-01-16  Tom Tromey  <tom@tromey.com>
5153
5154         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5155         type.  Remove no-argument constructor.
5156         <iterator::operator++>: Simplify.
5157         <begin>: Update.
5158         <end>: Use minimal_symbol_count.
5159
5160 2019-01-16  Tom Tromey  <tom@tromey.com>
5161
5162         * objfiles.h (struct objfile) <psymtabs>: New method.
5163         (class objfile_psymtabs): Remove.
5164         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5165         typedef.
5166         <range>: New method.
5167         (require_partial_symbols): Change return type.
5168         * psymtab.c (require_partial_symbols)
5169         (psym_expand_symtabs_matching): Update.
5170         * mdebugread.c (parse_partial_symbols): Update.
5171         * dbxread.c (dbx_end_psymtab): Update.
5172
5173 2019-01-15  Tom Tromey  <tom@tromey.com>
5174
5175         * symtab.c (lookup_objfile_from_block)
5176         (lookup_symbol_in_objfile_symtabs)
5177         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5178         (find_line_symtab, info_sources_command)
5179         (default_collect_symbol_completion_matches_break_on)
5180         (make_source_files_completion_list): Update.
5181         * symmisc.c (print_objfile_statistics, dump_objfile)
5182         (maintenance_print_symbols, maintenance_info_symtabs)
5183         (maintenance_check_symtabs, maintenance_info_line_tables):
5184         Update.
5185         * source.c (select_source_symtab)
5186         (forget_cached_source_info_for_objfile): Update.
5187         * objfiles.h (class objfile_compunits): Remove.
5188         (struct objfile) <compunits_range>: New typedef.
5189         (compunits): New method.
5190         * objfiles.c (objfile_relocate1): Update.
5191         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5192         * maint.c (count_symtabs_and_blocks): Update.
5193         * linespec.c (iterate_over_all_matching_symtabs): Update.
5194         * cp-support.c (add_symbol_overload_list_qualified): Update.
5195         * coffread.c (coff_symtab_read): Update.
5196         * ada-lang.c (add_nonlocal_symbols)
5197         (ada_collect_symbol_completion_matches)
5198         (ada_add_global_exceptions): Update.
5199
5200 2019-01-15  Tom Tromey  <tom@tromey.com>
5201
5202         * progspace.h (program_space) <objfiles_safe_range>: New
5203         typedef.
5204         <objfiles_safe>: New method.
5205         * objfiles.h (class all_objfiles_safe): Remove.
5206         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5207         * jit.c (jit_inferior_exit_hook): Update.
5208
5209 2019-01-17  Tom Tromey  <tom@tromey.com>
5210
5211         * progspace.h (program_space) <objfiles_range>: New typedef.
5212         <objfiles>: New method.
5213         <objfiles_head>: Rename from objfiles.
5214         (object_files): Update.
5215         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5216         * guile/scm-pretty-print.c
5217         (ppscm_find_pretty_printer_from_objfiles): Update.
5218         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5219         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5220         Update.
5221         * python/py-progspace.c (pspy_get_objfiles): Update.
5222         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5223         Update.
5224         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5225         (objfpy_lookup_objfile_by_build_id): Update.
5226         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5227         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5228         Update.
5229         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5230         (expand_symtab_containing_pc, lookup_objfile_from_block)
5231         (lookup_static_symbol, basic_lookup_transparent_type)
5232         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5233         (find_line_symtab, info_sources_command)
5234         (default_collect_symbol_completion_matches_break_on)
5235         (make_source_files_completion_list, find_main_name): Update.
5236         * symmisc.c (print_symbol_bcache_statistics)
5237         (print_objfile_statistics, maintenance_print_symbols)
5238         (maintenance_print_msymbols, maintenance_print_objfiles)
5239         (maintenance_info_symtabs, maintenance_check_symtabs)
5240         (maintenance_expand_symtabs, maintenance_info_line_tables):
5241         Update.
5242         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5243         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5244         (map_overlay_command, unmap_overlay_command)
5245         (simple_overlay_update, expand_symtabs_matching)
5246         (map_symbol_filenames): Update.
5247         * symfile-debug.c (set_debug_symfile): Update.
5248         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5249         Update.
5250         * source.c (select_source_symtab, forget_cached_source_info):
5251         Update.
5252         * solib.c (solib_read_symbols): Update.
5253         * solib-spu.c (append_ocl_sos): Update.
5254         * psymtab.c (maintenance_print_psymbols)
5255         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5256         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5257         * printcmd.c (info_symbol_command): Update.
5258         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5259         Update.
5260         * objfiles.h (class all_objfiles): Remove.
5261         * objfiles.c (have_partial_symbols, have_full_symbols)
5262         (have_minimal_symbols, qsort_cmp, update_section_map)
5263         (shared_objfile_contains_address_p)
5264         (default_iterate_over_objfiles_in_search_order): Update.
5265         * objc-lang.c (info_selectors_command, info_classes_command)
5266         (find_methods): Update.
5267         * minsyms.c (find_solib_trampoline_target): Update.
5268         * maint.c (maintenance_info_sections)
5269         (maintenance_translate_address, count_symtabs_and_blocks):
5270         Update.
5271         * main.c (captured_main_1): Update.
5272         * linux-thread-db.c (try_thread_db_load_from_pdir)
5273         (has_libpthread): Update.
5274         * linespec.c (iterate_over_all_matching_symtabs)
5275         (search_minsyms_for_name): Update.
5276         * jit.c (jit_find_objf_with_entry_addr): Update.
5277         * hppa-tdep.c (find_unwind_entry)
5278         (hppa_lookup_stub_minimal_symbol): Update.
5279         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5280         Update.
5281         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5282         (elf_gnu_ifunc_resolve_by_got): Update.
5283         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5284         * dwarf-index-write.c (save_gdb_index_command): Update.
5285         * cp-support.c (add_symbol_overload_list_qualified): Update.
5286         * breakpoint.c (create_overlay_event_breakpoint)
5287         (create_longjmp_master_breakpoint)
5288         (create_std_terminate_master_breakpoint)
5289         (create_exception_master_breakpoint): Update.
5290         * blockframe.c (find_pc_partial_function): Update.
5291         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5292         (ada_collect_symbol_completion_matches)
5293         (ada_add_global_exceptions): Update.
5294
5295 2019-01-17  Tom Tromey  <tom@tromey.com>
5296
5297         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5298         declare VEC.
5299         (solib_target_parse_libraries): Change return type.
5300         (library_list_start_segment, library_list_start_section)
5301         (library_list_end_library, library_list_start_library); Update.
5302         (solib_target_free_library_list): Remove.
5303         (solib_target_parse_libraries): Remove cleanup.  Change return
5304         type.
5305         (solib_target_current_sos): Update.
5306
5307 2019-01-17  Tom Tromey  <tromey@bapiya>
5308
5309         * valprint.c: Replace "the the" with "the".
5310         * symtab.c: Replace "the the" with "the".
5311         * solib.c: Replace "the the" with "the".
5312         * solib-dsbt.c: Replace "the the" with "the".
5313         * linespec.c: Replace "the the" with "the".
5314         * dwarf2loc.h: Replace "the the" with "the".
5315         * amd64-windows-tdep.c: Replace "the the" with "the".
5316         * aarch64-tdep.c: Replace "the the" with "the".
5317
5318 2019-01-16  Keith Seitz  <keiths@redhat.com>
5319
5320         PR gdb/23773
5321         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5322         <builder>: Rename to ..
5323         <m_builder>: ... this and make private.
5324         (dwarf2_cu::get_builder): New method.  Change all users of
5325         `builder' to use this method.
5326         (dwarf2_start_symtab): Move to ...
5327         (dwarf2_cu::start_symtab): ... here.  Update all callers
5328         (setup_type_unit_groups): Move to ...
5329         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5330         callers.
5331         (dwarf2_cu::reset_builder): New method.
5332         (process_full_compunit, process_full_type_unit): Use
5333         dwarf2_cu::reset_builder.
5334         (follow_die_offset): Record the ancestor CU if it is different
5335         from the followed DIE's CU.
5336         (follow_die_sig_1): Likewise.
5337
5338 2019-01-15  Tom Tromey  <tom@tromey.com>
5339
5340         * remote.c (class remote_state) <buf>: Now a char_vector.
5341         <buf_size>: Remove.
5342         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5343         parameter.
5344         (remote_target::getpkt_or_notif_sane_1)
5345         (remote_target::getpkt_sane)
5346         (remote_target::getpkt_or_notif_sane): Likewise.
5347         (class remote_target) <putpkt>: New overload.
5348         (remote_target::read_frame): Change type of "buf_p".  Remove
5349         sizeof_p parameter.
5350         (packet_ok): New overload.
5351         (packet_check_result): New overload.
5352         Update all uses.
5353
5354 2019-01-14  Tom Tromey  <tom@tromey.com>
5355
5356         * remote-notif.c (handle_notification, remote_notif_ack)
5357         (remote_notif_parse): Make "buf" const.
5358         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5359         const.
5360         (remote_notif_parse, remote_notif_ack, handle_notification):
5361         Likewise.
5362         * remote.c (remote_notif_stop_parse): Make "buf" const.
5363         (remote_target::remote_parse_stop_reply): Make "buf" const.
5364         (remote_notif_stop_ack): Make "buf" const.
5365
5366 2019-01-14  Tom Tromey  <tom@tromey.com>
5367
5368         * remote.c (remote_console_output): Make parameter const.
5369
5370 2019-01-14  Tom Tromey  <tom@tromey.com>
5371
5372         * target-debug.h (target_debug_print_signals): Constify.
5373         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5374         * procfs.c (procfs_target::pass_signals): Update.
5375         * linux-nat.c (linux_nat_target::pass_signals): Update.
5376         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5377         * target-delegates.c: Rebuild.
5378         * remote.c (remote_target::program_signals): Update.
5379         (remote_target::pass_signals): Update.
5380         * target.c (target_pass_signals): Constify argument.
5381         (target_program_signals): Likewise.
5382         * target.h (struct target_ops) <pass_signals, program_signals>:
5383         Constify argument.
5384         (target_pass_signals, target_program_signals): Constify argument.
5385
5386 2019-01-14  Tom Tromey  <tom@tromey.com>
5387
5388         PR tui/28819:
5389         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5390
5391 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5392
5393         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5394         field.
5395         * rs6000-tdep.c: Include reggroups.h.
5396         (IS_V_ALIAS_PSEUDOREG): Define.
5397         (rs6000_register_name): Return names for the "vX" aliases.
5398         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5399         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5400         aliases.  Call default_register_reggroup_p for all other
5401         pseudo-registers.
5402         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5403         New functions.
5404         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5405         Handle "vX" aliases.
5406         (v_alias_pseudo_register_collect): New function.
5407         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5408         (rs6000_gdbarch_init): Initialize "vX" aliases as
5409         pseudo-registers.  Restore registration of
5410         rs6000_pseudo_register_reggroup_p with
5411         set_tdesc_pseudo_register_reggroup_p.
5412
5413 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5414
5415         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5416         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5417         set_gdbarch_num_pseudo_regs.
5418
5419 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5420
5421         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5422         Remove arg prefixname, add do_set and do_show.
5423         Add member functions set_list and show_list.
5424         * cli/cli-style.c (class cli_style_option): Update accordingly.
5425         (style_set_list): Move to file scope.
5426         (style_show_list): Likewise.
5427         (set_style): Call help_list.
5428         (show_style): Call cmd_show_list.
5429         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5430         Update to use the new macro.
5431
5432 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5433
5434         * ada-lang.c (_initialize_ada_language): Expand the help text
5435         for the "catch exception" command.
5436
5437 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * symtab.c (matching_obj_sections): Initialize obj,
5440         declare it closer to its usage.
5441
5442 2019-01-10  Tom Tromey  <tom@tromey.com>
5443
5444         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5445         (basic_inf_threads_range): Remove.
5446         (inf_threads_range, inf_non_exited_threads_range)
5447         (safe_inf_threads_range): Use next_adapter.
5448
5449 2019-01-10  Keith Seitz  <keiths@redhat.com>
5450
5451         PR gdb/23712
5452         PR symtab/23010
5453         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5454         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5455
5456 2019-01-10  Keith Seitz  <keiths@redhat.com>
5457
5458         PR gdb/23712
5459         PR symtab/23010
5460         * dictionary.c (pending_to_vector): Remove.
5461         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5462         Remove _1 suffix, replacing functions of the same name.  Update
5463         all callers.
5464         (dict_create_hashed, dict_create_hashed_expandable)
5465         (dict_create_linear, dict_create_linear_expandable, dict_free)
5466         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5467         Make functions static.
5468
5469 2019-01-10  Keith Seitz  <keiths@redhat.com>
5470
5471         PR gdb/23712
5472         PR symtab/23010
5473         * dictionary.h (struct dictionary): Replace declaration with
5474         multidictionary.
5475         (dict_create_hashed, dict_create_hashed_expandable)
5476         (dict_create_linear, dict_create_linear_expandable)
5477         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5478         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5479         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5480         taking multidictionary argument.
5481         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5482         * block.h (struct block) <dict>: Change to multidictionary
5483         and rename `multidict'.
5484         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5485         symmisc.c: Update all dictionary references to multidictionary.
5486
5487 2019-01-10  Keith Seitz  <keiths@redhat.com>
5488
5489         PR gdb/23712
5490         PR symtab/23010
5491         * dictionary.c: Include unordered_map.
5492         (pending_to_vector): New function.
5493         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5494         Rewrite the non-"_1" functions to take vector instead
5495         of linked list.
5496         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5497         "new" _1 versions of the same name.
5498         (multidictionary): Define.
5499         (std::hash<enum language): New definition.
5500         (collate_pending_symbols_by_language, mdict_create_hashed)
5501         (mdict_create_hashed_expandable, mdict_create_linear)
5502         (mdict_create_linear_expandable, mdict_free)
5503         (find_language_dictionary, create_new_language_dictionary)
5504         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5505         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5506         (mdict_size, mdict_empty): New functions.
5507         * dictionary.h (mdict_iterator): Define.
5508
5509 2019-01-10  Pedro Alves  <palves@redhat.com>
5510
5511         * breakpoint.c (read_uploaded_action)
5512         (create_tracepoint_from_upload): Adjust to use
5513         gdb::unique_xmalloc_ptr.
5514         * ctf.c (ctf_write_uploaded_tp):
5515         (SET_ARRAY_FIELD): Use emplace_back.
5516         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5517         * tracefile-tfile.c (tfile_write_uploaded_tp):
5518         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5519         gdb::unique_xmalloc_ptr.
5520         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5521         at_string, cond_string, cmd_strings>: Replace char pointers
5522         with gdb::unique_xmalloc_ptr.
5523
5524 2019-01-10  Pedro Alves  <palves@redhat.com>
5525
5526         * solib-target.c (library_list_start_library): Don't xstrdup name.
5527
5528 2019-01-10  Pedro Alves  <palves@redhat.com>
5529
5530         * mdebugread.c (parse_partial_symbols): Use
5531         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5532
5533 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * linux-fork.c (scoped_switch_fork_info)
5536         <~scoped_switch_fork_info>: Fix incorrect variable name.
5537
5538 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5539
5540         * linux-fork.c (scoped_switch_fork_info)
5541         <scoped_switch_fork_info>: Make explicit.
5542         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5543
5544 2019-01-10  Tom Tromey  <tom@tromey.com>
5545
5546         * objfiles.h (objfile::reset_psymtabs): Update.
5547         * objfiles.c (objfile::objfile): Update.
5548         * psymtab.h (psymtab_storage::obstack): Update.
5549         (psymtab_storage::m_obstack): Use gdb::optional.
5550         (class psymtab_storage): Update comment.  Remove objfile
5551         parameter.
5552         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5553
5554 2019-01-10  Tom Tromey  <tom@tromey.com>
5555
5556         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5557         <free_psymtabs>: Now private.
5558         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5559         (allocate_psymtab): Use new method.
5560
5561 2019-01-10  Tom Tromey  <tom@tromey.com>
5562
5563         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5564         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5565         * mdebugread.c (parse_partial_symbols): Use
5566         allocate_dependencies.
5567         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5568         allocate_dependencies.
5569         (process_psymtab_comp_unit_reader)
5570         (build_type_psymtab_dependencies): Likewise.
5571         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5572
5573 2019-01-10  Tom Tromey  <tom@tromey.com>
5574
5575         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5576         PSYMBOL_SET_LANGUAGE.
5577         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5578
5579 2019-01-10  Tom Tromey  <tom@tromey.com>
5580
5581         * psymtab.h (psymtab_storage::obstack): New method.
5582         <m_obstack>: Rename from obstack; now private.
5583         * psymtab.c (psymtab_storage): Update.
5584         * dwarf2read.c (create_addrmap_from_index)
5585         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5586         Update.
5587
5588 2019-01-10  Tom Tromey  <tom@tromey.com>
5589
5590         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5591         * objfiles.h (objfile::reset_psymtabs): New method.
5592
5593 2019-01-10  Tom Tromey  <tom@tromey.com>
5594
5595         * symmisc.c (print_symbol_bcache_statistics): Update.
5596         (print_objfile_statistics): Update.
5597         * symfile.c (reread_symbols): Update.
5598         * psymtab.h (class psymtab_storage): New.
5599         * psymtab.c (psymtab_storage): New constructor.
5600         (~psymtab_storage): New destructor.
5601         (require_partial_symbols): Update.
5602         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5603         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5604         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5605         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5606         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5607         (start_psymtab_common, end_psymtab_common)
5608         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5609         (allocate_psymtab): Update.
5610         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5611         Update.
5612         (dump_psymtab_addrmap, maintenance_print_psymbols)
5613         (maintenance_check_psymtabs): Update.
5614         (class objfile_psymtabs): Move to objfiles.h.
5615         * psympriv.h (discard_psymtab): Now inline.
5616         (psymtab_discarder::psymtab_discarder): Update.
5617         (psymtab_discarder::~psymtab_discarder): Update.
5618         (ALL_OBJFILE_PSYMTABS): Rewrite.
5619         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5620         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5621         Remove fields.
5622         <partial_symtabs>: New field.
5623         (class objfile_psymtabs): Move from psymtab.h.  Update.
5624         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5625         psymbol_cache.
5626         (objfile::~objfile): Don't destroy psymbol_cache.
5627         * mdebugread.c (parse_partial_symbols): Update.
5628         * dwarf2read.c (create_addrmap_from_index)
5629         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5630         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5631         (add_partial_subprogram, dwarf2_ranges_read): Update.
5632         * dwarf-index-write.c (write_address_map)
5633         (write_one_signatured_type, recursively_write_psymbols)
5634         (class debug_names, class debug_names, write_psymtabs_to_index):
5635         Update.
5636
5637 2019-01-10  Tom Tromey  <tom@tromey.com>
5638
5639         * symtab.h (SYMBOL_SET_NAMES): Update.
5640         (symbol_set_names): Update.
5641         (MSYMBOL_SET_NAMES): Update.
5642         * symtab.c (symbol_set_names): Change argument to be an
5643         objfile_per_bfd_storage.
5644         * psymtab.c (add_psymbol_to_bcache): Update.
5645         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5646
5647 2019-01-10  Tom Tromey  <tom@tromey.com>
5648
5649         * symtab.c (create_demangled_names_hash): Change argument to be an
5650         objfile_per_bfd_storage.
5651         (symbol_set_names): Update.
5652
5653 2019-01-10  Tom Tromey  <tom@tromey.com>
5654
5655         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5656         init_psymbol_list.
5657         * psymtab.c (init_psymbol_list): Do nothing if already called.
5658         * psympriv.h (init_psymbol_list): Add comment.
5659         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5660         init_psymbol_list.
5661         * dbxread.c (dbx_symfile_read): Unconditionally call
5662         init_psymbol_list.
5663
5664 2019-01-10  Tom Tromey  <tom@tromey.com>
5665
5666         * xcoffread.c (scan_xcoff_symtab): Update.
5667         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5668         "where".
5669         * mdebugread.c (parse_partial_symbols)
5670         (handle_psymbol_enumerators): Update.
5671         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5672         * dbxread.c (read_dbx_symtab): Update.
5673         * psympriv.h (psymbol_placement): New enum.
5674         (add_psymbol_to_list): Update.
5675
5676 2019-01-10  Tom Tromey  <tom@tromey.com>
5677
5678         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5679         static_psymbols parameters.
5680         (scan_xcoff_symtab): Update.
5681         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5682         static_psymbols parameters.
5683         * psympriv.h (start_psymtab_common): Update.
5684         * mdebugread.c (parse_partial_symbols): Update.
5685         * dwarf2read.c (create_partial_symtab): Update.
5686         * dbxread.c (read_dbx_symtab): Update.
5687         (start_psymtab): Remove global_psymbols and static_psymbols
5688         parameters.
5689
5690 2019-01-10  Tom Tromey  <tom@tromey.com>
5691
5692         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5693         * psymtab.c (allocate_psymtab): Add comment.
5694         * psympriv.h (allocate_psymtab): Add comment.
5695         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5696         initializations.
5697         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5698
5699 2019-01-10  Tom Tromey  <tom@tromey.com>
5700
5701         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5702         Don't declare.
5703         * mipsread.c: Include mdebugread.h.
5704         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5705         Declare.
5706         * elfread.c: Include mdebugread.h.
5707
5708 2019-01-09  Tom Tromey  <tom@tromey.com>
5709
5710         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5711         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5712         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5713         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5714         (psym_lookup_symbol, psym_find_last_source_symtab)
5715         (psym_forget_cached_source_info, psym_print_stats)
5716         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5717         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5718         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5719         (psym_find_compunit_symtab_by_address)
5720         (maintenance_print_psymbols, maintenance_info_psymtabs)
5721         (maintenance_check_psymtabs): Use ranged for.
5722         * psymtab.h (class objfile_psymtabs): New.
5723         (require_partial_symbols): Return objfile_psymtabs.
5724         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5725
5726 2019-01-09  Tom Tromey  <tom@tromey.com>
5727
5728         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5729         (find_pc_mapped_section, list_overlays_command)
5730         (map_overlay_command, unmap_overlay_command)
5731         (simple_overlay_update): Use all_objfiles.
5732         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5733         * printcmd.c (info_symbol_command): Use all_objfiles.
5734         * objfiles.h (ALL_OBJSECTIONS): Remove.
5735         * maint.c (maintenance_translate_address): Use all_objfiles.
5736         * gcore.c (gcore_create_callback): Use all_objfiles.
5737         (objfile_find_memory_regions): Likewise.
5738
5739 2019-01-09  Tom Tromey  <tom@tromey.com>
5740
5741         * symtab.c (find_line_symtab, info_sources_command)
5742         (make_source_files_completion_list): Use objfile_compunits.
5743         * source.c (select_source_symtab): Use objfile_compunits.
5744         * objfiles.h (struct objfile): Update comment.
5745         (ALL_OBJFILES): Remove.
5746         (ALL_FILETABS): Remove.
5747         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5748         objfile_compunits.
5749
5750 2019-01-09  Tom Tromey  <tom@tromey.com>
5751
5752         * symmisc.c (print_objfile_statistics, dump_objfile)
5753         (maintenance_print_symbols): Use compunit_filetabs.
5754         * source.c (forget_cached_source_info_for_objfile): Use
5755         compunit_filetabs.
5756         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5757         (ALL_FILETABS): Use compunit_filetabs.
5758         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5759         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5760
5761 2019-01-09  Tom Tromey  <tom@tromey.com>
5762
5763         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5764         (compunit_filetabs): New.
5765         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5766         compunit_filetabs.
5767         (info_sources_command, make_source_files_completion_list): Remove
5768         declaration.
5769         * symmisc.c (print_objfile_statistics, dump_objfile)
5770         (maintenance_print_symbols): Remove declaration.
5771         (maintenance_info_symtabs): Use compunit_filetabs.
5772         (maintenance_info_line_tables): Likewise.
5773         * source.c (select_source_symtab): Change local variable name.
5774         (forget_cached_source_info_for_objfile): Remove declaration.
5775         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5776         * objfiles.c (objfile_relocate1): Remove declaration.
5777         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5778         declaration.
5779         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5780         * coffread.c (coff_symtab_read): Remove declaration.
5781         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5782         compunit_filetabs.
5783
5784 2019-01-09  Tom Tromey  <tom@tromey.com>
5785
5786         * symtab.c (lookup_objfile_from_block)
5787         (find_pc_sect_compunit_symtab, search_symbols)
5788         (default_collect_symbol_completion_matches_break_on): Use
5789         objfile_compunits.
5790         * objfiles.h (ALL_COMPUNITS): Remove.
5791         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5792         * cp-support.c (add_symbol_overload_list_qualified): Use
5793         objfile_compunits.
5794         * ada-lang.c (ada_collect_symbol_completion_matches)
5795         (ada_add_global_exceptions): Use objfile_compunits.
5796
5797 2019-01-09  Tom Tromey  <tom@tromey.com>
5798
5799         * source.c (select_source_symtab)
5800         (forget_cached_source_info_for_objfile): Remove declaration.
5801         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5802         declaration.
5803         * maint.c (count_symtabs_and_blocks): Remove declaration.
5804         * cp-support.c (add_symbol_overload_list_qualified): Remove
5805         declaration.
5806         * coffread.c (coff_symtab_read): Remove declaration.
5807         * symtab.c (lookup_symbol_in_objfile_symtabs)
5808         (basic_lookup_transparent_type_1): Use objfile_compunits.
5809         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5810         (info_sources_command, search_symbols)
5811         (default_collect_symbol_completion_matches_break_on)
5812         (make_source_files_completion_list): Remove declaration.
5813         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5814         (ada_collect_symbol_completion_matches)
5815         (ada_add_global_exceptions): Remove declaration.
5816         * linespec.c (iterate_over_all_matching_symtabs): Use
5817         objfile_compunits.
5818         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5819         (class objfile_compunits): New.
5820         (ALL_COMPUNITS): Use objfile_compunits.
5821         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5822         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5823         objfile_compunits.
5824         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5825
5826 2019-01-09  Tom Tromey  <tom@tromey.com>
5827
5828         * symtab.c (search_symbols)
5829         (default_collect_symbol_completion_matches_break_on): Use
5830         objfile_msymbols.
5831         * ada-lang.c (ada_lookup_simple_minsym)
5832         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5833         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5834         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5835         objfile_msymbols.
5836         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5837         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5838         * objc-lang.c (find_methods): Use objfile_msymbols.
5839         (info_selectors_command, info_classes_command): Likewise.
5840         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5841         * objfiles.h (class objfile_msymbols): New.
5842         (ALL_OBJFILE_MSYMBOLS): Remove.
5843         (ALL_MSYMBOLS): Remove.
5844
5845 2019-01-09  Tom Tromey  <tom@tromey.com>
5846
5847         * common/next-iterator.h (next_adapter): Add Iterator template
5848         parameter.
5849         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5850         (class all_objfiles_safe): New.
5851         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5852         * objfiles.c (put_objfile_before): Update comment.
5853         (add_separate_debug_objfile): Likewise.
5854         (free_all_objfiles): Use all_objfiles_safe.
5855         (objfile_purge_solibs): Likewise.
5856
5857 2019-01-09  Tom Tromey  <tom@tromey.com>
5858
5859         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5860         (expand_symtab_containing_pc, lookup_static_symbol)
5861         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5862         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5863         all_objfiles.
5864         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5865         * breakpoint.c (create_overlay_event_breakpoint)
5866         (create_longjmp_master_breakpoint)
5867         (create_std_terminate_master_breakpoint)
5868         (create_exception_master_breakpoint): Use all_objfiles.
5869         * linux-thread-db.c (try_thread_db_load_from_pdir)
5870         (has_libpthread): Use all_objfiles.
5871         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5872         * linespec.c (iterate_over_all_matching_symtabs)
5873         (search_minsyms_for_name): Use all_objfiles.
5874         * maint.c (maintenance_info_sections): Use all_objfiles.
5875         * main.c (captured_main_1): Use all_objfiles.
5876         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5877         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5878         * guile/scm-pretty-print.c
5879         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5880         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5881         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5882         (maintenance_print_msymbols): Use all_objfiles.
5883         * source.c (select_source_symtab): Use all_objfiles.
5884         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5885         * symfile.c (remove_symbol_file_command)
5886         (expand_symtabs_matching, map_symbol_filenames): Use
5887         all_objfiles.
5888         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5889         all_objfiles.
5890         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5891         * objc-lang.c (find_methods): Use all_objfiles.
5892         * objfiles.c (have_partial_symbols, have_full_symbols)
5893         (have_minimal_symbols, qsort_cmp)
5894         (default_iterate_over_objfiles_in_search_order): Use
5895         all_objfiles.
5896         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5897         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5898         (maintenance_check_psymtabs): Use all_objfiles.
5899         (ALL_PSYMTABS): Remove.
5900         * compile/compile-object-run.c (do_module_cleanup): Use
5901         all_objfiles.
5902         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5903         * cp-support.c (add_symbol_overload_list_qualified): Use
5904         all_objfiles.
5905         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5906         Use all_objfiles.
5907         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5908         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5909         all_objfiles.
5910         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5911         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5912         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5913         Uses all_objfiles.
5914         * solib.c (solib_read_symbols): Use all_objfiles
5915
5916 2019-01-09  Tom Tromey  <tom@tromey.com>
5917
5918         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5919         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5920         all_objfiles.
5921         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5922         * symmisc.c (print_symbol_bcache_statistics)
5923         (print_objfile_statistics, maintenance_print_objfiles)
5924         (maintenance_info_symtabs, maintenance_check_symtabs)
5925         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5926         all_objfiles.
5927         * source.c (forget_cached_source_info): Use all_objfiles.
5928         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5929         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5930         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5931         * objfiles.c (update_section_map): Use all_objfiles.
5932         (shared_objfile_contains_address_p): Likewise.
5933         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5934         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5935
5936 2019-01-09  Tom Tromey  <tom@tromey.com>
5937
5938         * common/next-iterator.h: New file.
5939         * objfiles.h (class all_objfiles): New.
5940         (struct objfile_iterator): New.
5941
5942 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5943
5944         * NEWS: Move the description of the changed "frame", "select-frame",
5945          and "info frame" commands to the Changed commands section.
5946
5947 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5948
5949         * gdbtypes.c (check_stub_method_group): Remove handling of old
5950         mangling schemes.
5951         * linespec.c (find_methods): Likewise.
5952         * stabsread.c (read_member_functions): Likewise.
5953         * valops.c (search_struct_method): Likewise.
5954         (value_struct_elt_for_reference): Likewise.
5955         * NEWS: Mention this change.
5956
5957 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5958
5959         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5960         print_source_lines.
5961         * source.c (print_source_lines_base): Update line number check.
5962         (print_source_lines): New function.
5963         (source_lines_range::source_lines_range): New function.
5964         * source.h (class source_lines_range): New class.
5965         (print_source_lines): New declaration.
5966
5967 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5968
5969         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5970
5971 2019-01-08  Tom Tromey  <tom@tromey.com>
5972             Simon Marchi  <simon.marchi@ericsson.com>
5973
5974         PR gdb/24060
5975         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5976         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5977         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5978         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5979         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5980         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5981
5982 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * source.c (select_source_symtab): Move header comment to
5985         declaration in source.h.
5986         (forget_cached_source_info_for_objfile): Likewise.
5987         (forget_cached_source_info): Likewise.
5988         (identify_source_line): Likewise.
5989         * source.h (identify_source_line): Move declaration from symtab.h
5990         and add comment from source.c
5991         (print_source_lines): Likewise.
5992         (forget_cached_source_info_for_objfile): Likewise.
5993         (forget_cached_source_info): Likewise.
5994         (select_source_symtab): Likewise.
5995         (enum print_source_lines_flag): Move definition from symtab.h.
5996         * symtab.h (identify_source_line): Move declaration to source.h.
5997         (print_source_lines): Likewise.
5998         (forget_cached_source_info_for_objfile): Likewise.
5999         (forget_cached_source_info): Likewise.
6000         (select_source_symtab): Likewise.
6001         (enum print_source_lines_flag): Move definition to source.h.
6002         * tui/tui-hooks.c: Add 'source.h' include.
6003
6004 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * source.c (print_source_lines_base): Handle requests to print
6007         reverse line number sequences, and guard against empty lines
6008         string.
6009
6010 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6011
6012         * source.c (print_source_lines_base): Fix skip of '\r' if next
6013         character is '\n'.
6014
6015 2019-01-06  Tom Tromey  <tom@tromey.com>
6016
6017         * c-exp.y (struct c_parse_state) <macro_original_text,
6018         expansion_obstack>: New member.
6019         (macro_original_text, expansion_obstack): Remove globals.
6020         (scan_macro_expansion, scanning_macro_expansion)
6021         (finished_macro_expansion): Update.
6022         (scan_macro_cleanup): Remove.
6023         (yylex, c_parse): Update.
6024
6025 2019-01-06  Tom Tromey  <tom@tromey.com>
6026
6027         * c-exp.y (struct c_parse_state) <strings>: New member.
6028         (operator_stoken): Update.
6029
6030 2019-01-06  Tom Tromey  <tom@tromey.com>
6031
6032         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6033         (union type_stack_elt) <typelist_val>: Now a pointer to
6034         std::vector.
6035         (type_stack_cleanup): Don't declare.
6036         (push_typelist): Update.
6037         * parse.c (pop_typelist): Return a std::vector.
6038         (push_typelist): Take a std::vector.
6039         (follow_types): Update.  Do not free args.
6040         (type_stack_cleanup): Remove.
6041         * c-exp.y (struct c_parse_state): New.
6042         (cpstate): New global.
6043         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6044         (nonempty_typelist): Update.
6045         (func_mod): Create a new vector.
6046         (c_parse): Create a c_parse_state.
6047         (check_parameter_typelist): Do not delete params.
6048         (function_method): Update.  Do not delete type_list.
6049
6050 2019-01-06  Tom Tromey  <tom@tromey.com>
6051
6052         PR gdb/28155:
6053         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6054         check_typedef.
6055         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6056         (print_return_value): Likewise.
6057
6058 2019-01-05  Tom Tromey  <tom@tromey.com>
6059
6060         * contrib/cleanup_check.py: Remove.
6061         * contrib/gcc-with-excheck: Remove.
6062         * contrib/exsummary.py: Remove.
6063         * contrib/excheck.py: Remove.
6064
6065 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6066
6067         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6068         NULL. Initialize tpprev to NULL instead of assigning it
6069         to NULL on the next statement.
6070         * windows-nat.c (windows_delete_thread): Remove check for
6071         main_thread_id before printing thread exit notifications.
6072         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6073         Remove thread ID check against main_thread_id.
6074         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6075         windows_delete_thread.
6076         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6077
6078 2019-01-04  Tom Tromey  <tom@tromey.com>
6079
6080         * compile/compile.c (_initialize_compile): Use upper case for
6081         metasyntactic variables.
6082         * symmisc.c (_initialize_symmisc): Use upper case for
6083         metasyntactic variables.
6084         * psymtab.c (_initialize_psymtab): Use upper case for
6085         metasyntactic variables.
6086         * demangle.c (demangle_command): Use upper case for metasyntactic
6087         variables.
6088         (_initialize_demangler): Likewise.
6089         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6090         variables.
6091
6092 2019-01-03  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6095
6096 2019-01-03  Tom Tromey  <tom@tromey.com>
6097
6098         * python/py-symtab.c (salpy_str): Update.
6099         (struct salpy_sal_object) <symtab>: Now a PyObject.
6100         (salpy_dealloc): Update.
6101         (del_objfile_sal): Use gdbpy_ref.
6102
6103 2019-01-03  Tom Tromey  <tom@tromey.com>
6104
6105         * python/py-type.c (convert_field): Use new_reference.  Return
6106         gdbpy_ref.
6107         (make_fielditem): Return gdbpy_ref.
6108         (typy_fields): Update.
6109         (typy_getitem): Update.
6110         (field_name): Return gdbpy_ref.  Use new_reference.
6111         (typy_iterator_iternext): Update.
6112
6113 2019-01-03  Tom Tromey  <tom@tromey.com>
6114
6115         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6116
6117 2019-01-03  Tom Tromey  <tom@tromey.com>
6118
6119         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6120         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6121         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6122         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6123         (pspy_set_type_printers): Likewise.
6124         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6125         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6126         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6127         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6128         (objfpy_set_type_printers): Likewise.
6129
6130 2019-01-03  Tom Tromey  <tom@tromey.com>
6131
6132         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6133         (gdbpy_print_stack): Use gdbpy_err_fetch.
6134         * python/python-internal.h (class gdbpy_err_fetch): New class.
6135         (class gdbpy_enter) <m_error_type, m_error_value,
6136         m_error_traceback>: Remove.
6137         <m_error>: New member.
6138         (gdbpy_exception_to_string): Don't declare.
6139         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6140         * python/py-value.c (convert_value_from_python): Use
6141         gdbpy_err_fetch.
6142         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6143         gdbpy_exception_to_string.
6144         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6145         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6146         gdbpy_err_fetch.
6147
6148 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6149
6150         * linux-nat.c (delete_lwp_cleanup): Delete.
6151         (struct lwp_deleter): New struct.
6152         (lwp_info_up): New typedef.
6153         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6154         lwp_info_up.
6155
6156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * linux-fork.c (class scoped_switch_fork_info): New class.
6159         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6160
6161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * valops.c (find_overload_match): Remove use of null_cleanup, and
6164         calls to do_cleanups.
6165
6166 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * compile/compile-cplus-types.c
6169         (compile_cplus_instance::decl_name): Handle changes to
6170         cp_func_name.
6171         * cp-support.c (cp_func_name): Update header comment, update
6172         return type.
6173         * cp-support.h (cp_func_name): Update return type in declaration.
6174         * valops.c (find_overload_match): Move temp_func local to top
6175         level of function and change its type.  Use temp_func to hold and
6176         delete temporary string obtained from cp_func_name.
6177
6178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6181         gdb::char_vector, remove cleanup, and update uses of `msg`.
6182
6183 2019-01-03  Jim Wilson  <jimw@sifive.com>
6184
6185         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6186
6187 2019-01-02  Tom Tromey  <tom@tromey.com>
6188
6189         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6190         (tdesc_parse_xml): Remove cleanups.
6191         * target-descriptions.h (make_cleanup_free_target_description):
6192         Don't declare.
6193         (target_desc_deleter): New struct.
6194         (target_desc_up): New typedef.
6195         * target-descriptions.c (target_desc_deleter::operator()): Rename
6196         from free_target_description.
6197         (make_cleanup_free_target_description): Remove.
6198
6199 2019-01-02  Tom Tromey  <tom@tromey.com>
6200
6201         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6202         constructor, destructor.
6203         (linespec_parser): Remove typedef.
6204         (~linespec_parser): Rename from linespec_parser_delete.
6205         (linespec_lex_to_end, linespec_complete_label)
6206         (linespec_complete): Update.
6207         (decode_line_full): Remove cleanups.
6208         (decode_line_1): Update.
6209
6210 2019-01-02  Tom Tromey  <tom@tromey.com>
6211
6212         * python/python-internal.h (inferior_to_inferior_object): Change
6213         return type.
6214         * python/py-exitedevent.c (create_exited_event_object): Update.
6215         * python/py-inferior.c (inferior_to_inferior_object): Return
6216         gdbpy_ref.
6217         (python_new_inferior, python_inferior_deleted)
6218         (thread_to_thread_object, delete_thread_object)
6219         (build_inferior_list, gdbpy_selected_inferior): Update.
6220         * python/py-infthread.c (create_thread_object): Update.  Also fail
6221         if inferior_to_inferior_object fails.
6222
6223 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6224
6225         * inferior.h (class inferior) <displaced_step_state>: New field.
6226         * infrun.h (struct displaced_step_state): Move here from
6227         infrun.c.  Initialize fields, add constructor.
6228         <inf>: Remove field.
6229         <reset>: New method.
6230         * infrun.c (struct displaced_step_inferior_state): Move to
6231         infrun.h.
6232         (displaced_step_inferior_states): Remove.
6233         (get_displaced_stepping_state): Adust.
6234         (displaced_step_in_progress_any_inferior): Adjust.
6235         (displaced_step_in_progress_thread): Adjust.
6236         (displaced_step_in_progress): Adjust.
6237         (add_displaced_stepping_state): Remove.
6238         (get_displaced_step_closure_by_addr): Adjust.
6239         (remove_displaced_stepping_state): Remove.
6240         (infrun_inferior_exit): Call displaced_step_state.reset.
6241         (use_displaced_stepping): Don't check for NULL.
6242         (displaced_step_prepare_throw): Call
6243         get_displaced_stepping_state.
6244         (displaced_step_fixup): Don't check for NULL.
6245         (prepare_for_detach): Don't check for NULL.
6246
6247 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6248
6249         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6250          in case of call that did not complete.
6251
6252 2019-01-02  Andrey Utkin  <autkin@undo.io>
6253
6254         * symfile.c (find_separate_debug_file): Fix search of debug files for
6255         remote debuggee.
6256
6257 2019-01-02  Tom Tromey  <tom@tromey.com>
6258
6259         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6260         indentation.
6261         * python/py-frame.c (frapy_older): Remove cast.
6262         (frapy_newer): Likewise.
6263         * python/py-breakpoint.c (local_setattro): Remove cast.
6264         * python/py-arch.c (archpy_name): Remove local variable.
6265         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6266
6267 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6268
6269         * unittests/basic_string_view/element_access/char/empty.cc:
6270         Fix year range in copyright header.
6271
6272 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6275         Delete.
6276         <operator==>: Update with for removed field.
6277         <hash>: Likewise.
6278         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6279         <isa_features>: ...this.
6280         <abi_features>: New field.
6281         (riscv_isa_flen): Update comment.
6282         (riscv_abi_xlen): New declaration.
6283         (riscv_abi_flen): New declaration.
6284         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6285         isa_features.
6286         (riscv_abi_xlen): New function.
6287         (riscv_isa_flen): Update to get answer from isa_features.
6288         (riscv_abi_flen): New function.
6289         (riscv_has_fp_abi): Update to get answer from abi_features.
6290         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6291         xlen and flen.
6292         (riscv_call_info) <xlen, flen>: Update comment.
6293         (riscv_call_arg_struct): Remove invalid assertions
6294         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6295         is removed.
6296         (riscv_gdbarch_init): Gather isa features and abi features
6297         separately, ensure both match on the gdbarch when reusing an old
6298         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6299         a target with 64-bit float hardware.
6300
6301 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6302
6303         * source.c (search_command_helper): Stop reverse search
6304         when line 1 has been searched.
6305
6306 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6307
6308         * record-full.c (record_full_base_target::close): Rewrite
6309         record_full_core_buf_list free logic.
6310
6311 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * break-catch-syscall.c (print_one_catch_syscall): xfree
6314         the last text.
6315
6316 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6317
6318         * top.c (print_gdb_version): Update Copyright year in version
6319         message.
6320
6321 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6322
6323         Update copyright year range in all GDB files.
6324
6325 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6326
6327         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6328
6329 For older changes see ChangeLog-2018.
6330 \f
6331 Local Variables:
6332 mode: change-log
6333 left-margin: 8
6334 fill-column: 74
6335 version-control: never
6336 coding: utf-8
6337 End:
6338