1 2019-09-02 Alan Hayward <alan.hayward@arm.com>
3 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
6 (compile_probe_arg): Likewise.
7 * probe.h (get_argument_count): Likewise.
8 * solib-svr4.c (solib_event_probe_action): Likewise.
9 * stap-probe.c (stap_probe::get_argument_count): Likewise.
11 2019-09-02 Alan Hayward <alan.hayward@arm.com>
13 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
15 (svr4_create_solib_event_breakpoints): ...from here.
17 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
19 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
20 suffix from warning message.
22 2019-08-30 Tom Tromey <tom@tromey.com>
24 * tui/tui-winsource.h (struct tui_source_window_base)
25 <refresh_all>: Don't declare.
26 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
28 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
29 tui_show_locator_content.
30 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
32 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
33 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
36 2019-08-30 Tom Tromey <tom@tromey.com>
38 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
40 2019-08-30 Tom Tromey <tom@tromey.com>
42 * tui/tui-stack.c (_initialize_tui_stack): Move later.
43 Remove unnecessary forward declarations.
45 2019-08-30 Tom Tromey <tom@tromey.com>
47 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
49 (tui_update_locator_fullname, tui_show_frame_info): Don't call
50 tui_show_locator_content.
52 2019-08-30 Tom Tromey <tom@tromey.com>
54 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
55 (tui_locator_window::rerender): Rewrite using body of previous
56 tui_show_locator_content.
58 2019-08-30 Tom Tromey <tom@tromey.com>
60 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
61 set_locator_fullname>: New methods.
62 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
63 Rename from tui_set_locator_fullname.
64 (tui_locator_window::set_locator_info): Rename from
65 tui_set_locator_info. Return bool.
66 (tui_update_locator_fullname, tui_show_frame_info): Update.
68 2019-08-30 Tom Tromey <tom@tromey.com>
70 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
72 2019-08-30 Tom Tromey <tom@tromey.com>
74 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
77 2019-08-30 Tom Tromey <tom@tromey.com>
79 * tui/tui-wingeneral.c (box_win): Assume win_info and
80 win_info->handle cannot be NULL.
82 2019-08-30 Tom Tromey <tom@tromey.com>
84 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
85 refresh_window>: Declare.
86 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
88 (tui_data_item_window::rerender): Rename from
90 (tui_data_item_window::refresh_window): New method.
91 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
94 2019-08-30 Tom Tromey <tom@tromey.com>
96 * tui/tui-regs.h (struct tui_data_window) <regs_content,
97 regs_column_count, current_group>: Move later. Now private.
98 <get_current_group>: New method.
99 * tui/tui-regs.c (tui_reg_command): Update.
100 * tui/tui-layout.c (tui_set_layout): Update.
102 2019-08-30 Tom Tromey <tom@tromey.com>
104 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
105 (tui_data_window::rerender): Don't call
106 check_and_display_highlight_if_needed.
107 (tui_data_window::refresh_all): Remove call to
110 2019-08-30 Tom Tromey <tom@tromey.com>
112 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
113 (tui_data_window::display_registers_from)
114 (tui_data_window::display_reg_element_at_line)
115 (tui_data_window::display_registers_from_line): Remove checks of
118 2019-08-30 Tom Tromey <tom@tromey.com>
120 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
122 * tui/tui-regs.c (tui_data_window::show_registers): Call
124 (tui_data_window::rerender): Rename from display_all_data.
125 (tui_data_window::rerender): Remove old implementation.
127 2019-08-30 Tom Tromey <tom@tromey.com>
129 * tui/tui-regs.c (tui_data_window::display_all_data): Change
131 * tui/tui-data.h (NO_DATA_STRING): Remove define.
133 2019-08-29 Bernhard Wodok <barto@gmx.net>
134 Sergio Durigan Junior <sergiodj@redhat.com>
137 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
139 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
141 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
142 when searching for types.
144 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
146 * f-lang.c (f_language_defn): Use f_print_typedef.
147 * f-lang.h (f_print_typedef): Declare.
148 * f-typeprint.c (f_print_typedef): Define.
150 2019-08-27 Christian Biesinger <cbiesinger@google.com>
152 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
154 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
156 * cli/cli-utils.c (info_print_options_defs): Delete.
157 (make_info_print_options_def_group): Delete.
158 (extract_info_print_options): Delete.
159 (info_print_command_completer): Delete.
160 (info_print_args_help): Add extra parameter, and optionally
161 include text about -n flag.
162 * cli/cli-utils.h (struct info_print_options): Delete.
163 (extract_info_print_options): Delete declaration.
164 (info_print_command_completer): Delete declaration.
165 (info_print_args_help): Add extra parameter, extend header
167 * python/python.c (gdbpy_rbreak): Pass additional parameter to
169 * stack.c (struct info_print_options): New type.
170 (info_print_options_defs): New file scoped variable.
171 (make_info_print_options_def_group): New static function.
172 (info_print_command_completer): New static function.
173 (info_locals_command): Update to use new local functions.
174 (info_args_command): Likewise.
175 (_initialize_stack): Add extra parameter to calls to
176 info_print_args_help.
177 * symtab.c (search_symbols): Add extra parameter, use this to
178 possibly excluse non-debug symbols.
179 (symtab_symbol_info): Add extra parameter, which is passed on to
181 (struct info_print_options): New type.
182 (info_print_options_defs): New file scoped variable.
183 (make_info_print_options_def_group): New static function.
184 (info_print_command_completer): New static function.
185 (info_variables_command): Update to use local functions, and pass
186 extra parameter through to symtab_symbol_info.
187 (info_functions_command): Likewise.
188 (info_types_command): Pass additional argument through to
190 (rbreak_command): Pass extra argument to search_symbols.
191 (_initialize_symtab): Add extra arguments for calls to
192 info_print_args_help, and update help text for 'info variables',
193 'whereis', and 'info functions' commands.
194 * symtab.h (search_symbols): Add extra argument to declaration.
195 * NEWS: Mention new flags.
197 2019-08-26 Christian Biesinger <cbiesinger@google.com>
199 * symtab.c (lookup_static_symbol): Call the new function (and move
200 it down to be next to lookup_global_symbol).
201 (struct global_sym_lookup_data): Add block_enum member and rename to...
202 (struct global_or_static_sym_lookup_data): ...this.
203 (lookup_symbol_global_iterator_cb): Pass block_index instead of
204 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
205 (lookup_symbol_global_or_static_iterator_cb): ...this.
206 (lookup_global_or_static_symbol): New function.
207 (lookup_global_symbol): Call new function.
209 2019-08-26 Tom de Vries <tdevries@suse.de>
212 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
213 when pc_probe.prob == NULL.
215 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
217 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
218 variable symbol_linkage to symbol_linkage_.
220 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
222 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
223 represent whether the symbol is static, dynamic, or we don't
226 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
228 * gdb/rx-tdep.c (rx_register_names): New.
229 (rx_register_name): Delete.
230 (rx_psw_type): Delete.
231 (rx_fpsw_type): Delete.
232 (rx_register_type): Delete.
233 (rx_gdbarch_init): Convert target-descriptions.
234 (_initialize_rx_tdep): Add initialize_tdesc_rx.
235 * gdb/features/Makefile: Add rx.xml.
236 * gdb/features/rx.xml: New.
237 * gdb/features/rx.c: Generated.
238 * gdb/NEWS: Mention target description support.
240 2019-08-22 Christian Biesinger <cbiesinger@google.com>
242 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
245 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
247 * configure.ac: Don't check for 'dlfcn.h' (moved to
248 gdbsupport/common.m4).
249 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
251 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
252 * compile/compile-c-support.c: Include
253 'gdbsupport/gdb-dlfcn.h'.
254 * gdbsupport/common.m4: Check for 'dlfcn.h'.
255 * gdb-dlfcn.c: Move to...
256 * gdbsupport/gdb-dlfcn.c: ... here.
257 * gdb-dlfcn.h: Move to...
258 * gdbsupport/gdb-dlfcn.h: ... here.
260 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
262 * nios2-tdep.c (struct reg_value): Improve comments. Make
263 the offset field signed.
265 2019-08-22 Christian Biesinger <cbiesinger@google.com>
267 * python/lib/gdb/__init__.py (_execute_file): New function.
268 * python/python.c (python_run_simple_file): Call gdb._execute_file
271 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
273 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
274 all uses as this was never set to anything but a zero value.
276 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
278 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
280 2019-08-21 Christian Biesinger <cbiesinger@google.com>
282 * tui/tui-data.h (tui_gen_win_info): Add an =default
283 move constructor, required by some GCC versions.
285 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
287 * go32-nat.c (go32_sysinfo): Add hygon_p.
289 2019-08-20 Tom Tromey <tom@tromey.com>
291 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
292 line_from_reg_element_no, first_reg_element_no_inline,
293 display_all_data, delete_data_content_windows,
294 erase_data_content>: Now private.
296 2019-08-20 Tom Tromey <tom@tromey.com>
298 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
299 (tui_unhighlight_win, tui_highlight_win)
300 (tui_win_info::make_window): Update.
301 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
303 2019-08-20 Tom Tromey <tom@tromey.com>
305 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
306 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
307 (MAX_PID_WIDTH): Move to tui-stack.c.
308 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
309 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
310 (MAX_PID_WIDTH): Move from tui-data.h.
312 2019-08-20 Tom Tromey <tom@tromey.com>
314 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
315 * tui/tui-wingeneral.c (box_win): Change type of win_info.
317 (tui_gen_win_info::make_window): Rename from tui_make_window.
318 (tui_win_info::make_window): New method.
319 (tui_gen_win_info::make_visible): Update.
320 * tui/tui-source.c (tui_source_window::set_contents): Update.
321 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
322 (tui_data_window::display_registers_from): Update.
323 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
324 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
328 (struct tui_win_info) <make_window>: Declare.
329 <can_box>: Now virtual.
331 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
332 * tui/tui-command.c (tui_cmd_window::resize): Update.
334 2019-08-20 Tom Tromey <tom@tromey.com>
336 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
337 * tui/tui-regs.c (tui_data_window::show_registers): Update.
338 (tui_data_window::check_register_values): Update.
340 2019-08-20 Tom Tromey <tom@tromey.com>
342 * tui/tui-regs.h (struct tui_data_window): Use
343 DISABLE_COPY_AND_ASSIGN.
344 <regs_content>: Change type, removing unique_ptr.
345 <tui_data_window>: Add move constructor.
346 * tui/tui-regs.c (tui_data_window::show_registers)
347 (tui_data_window::show_register_group)
348 (tui_data_window::display_registers_from)
349 (tui_data_window::display_registers_from)
350 (tui_data_window::first_data_item_displayed)
351 (tui_data_window::delete_data_content_windows)
352 (tui_data_window::rerender, tui_data_window::refresh_window)
353 (tui_data_window::check_register_values): Update.
355 2019-08-20 Tom Tromey <tom@tromey.com>
357 * tui/tui-regs.h (struct tui_data_window) <show_registers,
358 show_register_group>: Declare.
359 (tui_show_register_group): Don't declare.
360 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
362 (tui_data_window::show_register_group): Rename from
363 tui_show_register_group.
364 (tui_data_window::check_register_values, tui_reg_command):
366 * tui/tui-layout.c (tui_set_layout): Update.
368 2019-08-20 Tom Tromey <tom@tromey.com>
370 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
372 (tui_check_register_values): Don't declare.
373 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
374 from tui_check_register_values.
375 * tui/tui-hooks.c (tui_register_changed): Update.
377 2019-08-20 Tom Tromey <tom@tromey.com>
379 * tui/tui-regs.c (tui_reg_layout): Move later.
380 (tui_show_registers): Don't enable TUI mode or change layout.
382 2019-08-20 Tom Tromey <tom@tromey.com>
384 * tui/tui-regs.h (struct tui_data_item_window)
385 <~tui_data_item_window>: Remove.
386 <content>: Now a unique_xmalloc_ptr.
387 * tui/tui-regs.c (tui_register_format): Return a
389 (tui_get_register): Update.
390 (~tui_data_item_window): Remove.
391 (tui_data_window::display_registers_from, tui_display_register):
393 * tui/tui-io.h (tui_expand_tabs): Update.
394 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
395 Remove "col" parameter.
397 2019-08-20 Tom Tromey <tom@tromey.com>
399 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
401 * tui/tui-regs.c (~tui_data_item_window): Update.
403 2019-08-20 Tom Tromey <tom@tromey.com>
405 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
408 2019-08-20 Tom Tromey <tom@tromey.com>
410 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
412 2019-08-20 Tom Tromey <tom@tromey.com>
414 * tui/tui-source.h (struct tui_source_window): Update.
415 * tui/tui-regs.c (tui_show_registers): Update.
416 * tui/tui-disasm.h (struct tui_disasm_window): Update.
417 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
418 (NO_REGS_STRING): Remove defines.
420 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
422 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
423 unnecessary thread walk if remote doesn't support the packet.
425 2019-08-19 Tom Tromey <tromey@adacore.com>
427 * python/py-value.c (value_has_field): Fix indentation.
429 2019-08-19 Tom Tromey <tromey@adacore.com>
431 * printcmd.c (do_one_display, info_display_command): Update.
432 * block.h (contained_in): Return bool. Add allow_nested
434 * block.c (contained_in): Return bool. Add allow_nested
437 2019-08-19 Tom Tromey <tom@tromey.com>
439 * configure: Rebuild.
440 * configure.ac: Disallow the combination of -static-libstdc++ and
442 * source-cache.c (get_language_name): Handle rust.
443 (source_cache::get_source_lines): Ignore highlighting exceptions.
445 2019-08-16 Tom Tromey <tom@tromey.com>
447 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
448 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
449 (struct tui_source_window_base) <make_visible, refresh_window,
450 resize>: Remove methods.
451 <execution_info>: Remove field.
452 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
453 (tui_show_source_line, tui_source_window_base)
454 (~tui_source_window_base): Update.
455 (tui_source_window_base::resize)
456 (tui_source_window_base::make_visible)
457 (tui_source_window_base::refresh_window): Remove.
458 (tui_source_window_base::update_exec_info): Update.
459 * tui/tui-source.c (tui_source_window::set_contents): Update.
460 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
462 2019-08-16 Tom Tromey <tom@tromey.com>
464 * tui/tui-hooks.c (tui_remove_hooks): Don't set
465 deprecated_query_hook.
467 2019-08-16 Tom Tromey <tom@tromey.com>
469 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
470 (tui_update_source_windows_with_line): Update.
471 * tui/tui-source.h (struct tui_source_window)
472 <show_symtab_source>: Declare.
473 (tui_show_symtab_source): Don't declare.
474 * tui/tui-source.c (tui_show_symtab_source): Rename from
475 tui_show_symtab_source.
477 2019-08-16 Tom Tromey <tom@tromey.com>
479 * tui/tui-winsource.h (struct tui_source_window_base)
480 <set_contents>: Declare.
481 * tui/tui-winsource.c
482 (tui_source_window_base::update_source_window_as_is): Update.
483 * tui/tui-source.h (struct tui_source_window) <set_contents>:
485 (tui_set_source_content): Don't declare.
486 * tui/tui-source.c (tui_source_window::set_contents): Rename from
487 tui_set_source_content.
488 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
490 (tui_set_disassem_content): Don't declare.
491 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
492 tui_set_disassem_content.
494 2019-08-16 Tom Tromey <tom@tromey.com>
496 * tui/tui-winsource.h (struct tui_source_window_base)
497 <update_breakpoint_info>: Declare.
498 (tui_update_breakpoint_info): Don't declare.
499 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
500 (tui_update_all_breakpoint_info): Update.
501 (tui_source_window_base::update_breakpoint_info): Rename from
502 tui_update_breakpoint_info.
503 (tui_source_window_base::update_exec_info): Update.
505 2019-08-16 Tom Tromey <tom@tromey.com>
507 * tui/tui-winsource.h (struct tui_source_window_base)
508 <update_source_window>: Declare.
509 (tui_update_source_window): Don't declare.
510 * tui/tui-winsource.c
511 (tui_source_window_base::update_source_window): Rename from
512 tui_update_source_window.
513 (tui_source_window_base::rerender): Update.
514 * tui/tui-source.c (tui_source_window::maybe_update): Update.
515 * tui/tui-disasm.c (tui_show_disassem)
516 (tui_show_disassem_and_update_source)
517 (tui_disasm_window::maybe_update): Update.
519 2019-08-16 Tom Tromey <tom@tromey.com>
521 * tui/tui-winsource.h (struct tui_source_window_base)
522 <update_source_window_as_is>: Declare.
523 (tui_update_source_window_as_is): Don't declare.
524 * tui/tui-winsource.c (tui_update_source_window): Update
525 (tui_source_window_base::update_source_window_as_is): Rename from
526 tui_update_source_window_as_is.
527 (tui_source_window_base::refill): Update.
528 * tui/tui-source.c (tui_show_symtab_source): Update.
529 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
532 2019-08-16 Tom Tromey <tom@tromey.com>
534 * tui/tui-winsource.h (tui_update_source_window)
535 (tui_update_source_window_as_is): Remove "noerror" parameter.
536 * tui/tui-winsource.c (tui_update_source_window)
537 (tui_update_source_window_as_is): Remove "noerror" parameter.
538 (tui_update_source_windows_with_addr)
539 (tui_update_source_windows_with_line)
540 (tui_source_window_base::rerender)
541 (tui_source_window_base::refill): Update.
542 * tui/tui-source.h (tui_set_source_content)
543 (tui_show_symtab_source): Remove "noerror" parameter.
544 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
546 (tui_show_symtab_source): Likewise.
547 (tui_source_window::maybe_update): Update.
548 * tui/tui-disasm.c (tui_show_disassem)
549 (tui_show_disassem_and_update_source)
550 (tui_disasm_window::do_scroll_vertical)
551 (tui_disasm_window::maybe_update): Update.
553 2019-08-16 Tom Tromey <tom@tromey.com>
555 * tui/tui.c (tui_is_window_visible): Update.
556 * tui/tui-wingeneral.c (tui_make_window)
557 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
558 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
559 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
560 (tui_set_win_height_command, parse_scrolling_args): Update.
561 * tui/tui-source.c (tui_source_window::style_changed): Update.
562 * tui/tui-regs.c (tui_show_registers)
563 (tui_data_window::first_data_item_displayed)
564 (tui_data_window::delete_data_content_windows)
565 (tui_check_register_values, tui_reg_command): Update.
566 * tui/tui-disasm.c (tui_show_disassem): Update.
567 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
569 <is_visible>: Remove field.
570 * tui/tui-data.c (tui_next_win, tui_prev_win)
571 (tui_delete_invisible_windows): Update.
573 2019-08-16 Tom Tromey <tom@tromey.com>
575 * tui/tui-winsource.h (struct tui_source_window_base)
576 <m_has_locator>: Remove.
577 * tui/tui-layout.c (show_source_disasm_command, show_data)
578 (show_source_or_disasm_and_command): Update.
580 2019-08-16 Alan Hayward <alan.hayward@arm.com>
582 * NEWS (Other MI changes): New subsection.
583 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
584 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
585 * arch-utils.c (default_get_pc_address_flags): New function.
586 * arch-utils.h (default_get_pc_address_flags): New declaration.
587 * gdbarch.sh: Add get_pc_address_flags.
588 * gdbarch.c: Regenerate.
589 * gdbarch.h: Likewise.
590 * stack.c (print_pc): New function.
591 (print_frame_info) (print_frame): Call print_pc.
593 2019-08-16 Tom de Vries <tdevries@suse.de>
595 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
596 print_objfile_section_info.
598 2019-08-15 Tom Tromey <tom@tromey.com>
600 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
601 calling update_cmdwin_start_line.
602 * tui/tui-winsource.h (struct tui_source_window_base)
603 <do_make_visible_with_new_height, set_new_height>: Don't declare.
605 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
607 (tui_source_window_base::set_new_height): Remove.
608 (tui_source_window_base::rerender): Rename from
609 do_make_visible_with_new_height.
610 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
612 (tui_win_info::make_invisible_and_set_new_height)
613 (tui_win_info::make_visible_with_new_height): Remove.
614 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
616 * tui/tui-stack.c (tui_locator_window::rerender): New method.
617 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
618 do_make_visible_with_new_height>: Don't declare.
620 * tui/tui-regs.c (tui_data_window::rerender): Rename from
622 (tui_data_window::do_make_visible_with_new_height): Remove.
623 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
624 call tui_show_locator_content.
625 (tui_gen_win_info::resize): Call rerender.
626 (show_source_or_disasm_and_command): Don't call
627 tui_show_locator_content.
628 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
630 (struct tui_win_info) <rerender>: Declare.
631 <set_new_height, make_invisible_and_set_new_height,
632 make_visible_with_new_height>: Don't declare.
633 * tui/tui-data.c (tui_win_list::rerender): New method.
634 * tui/tui-command.h (struct tui_cmd_window)
635 <do_make_visible_with_new_height>: Don't declare.
637 (tui_cmd_window::do_make_visible_with_new_height): Remove.
639 2019-08-15 Tom Tromey <tromey@adacore.com>
641 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
642 * ada-lang.c (ada_enum_name): Likewise.
644 2019-08-15 Christian Biesinger <cbiesinger@google.com>
646 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
648 (GdbOutputErrorFile): Likewise.
649 (global scope): Adjust constructor calls to GdbOutput{,Error}File
651 (execute_unwinders): Rename to have a leading underscore.
652 (auto_load_packages): Likewise.
653 (global scope): Adjust call to auto_load_packages accordingly.
654 (GdbSetPythonDirectory): Likewise.
655 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
656 instead of execute_unwinders.
658 2019-08-15 Tom Tromey <tom@tromey.com>
660 * tui/tui-layout.c (show_layout, show_source_disasm_command)
661 (show_data): Don't change window visibility.
662 (tui_gen_win_info::resize): Remove special case for command
663 window. Use wresize, when available.
664 (show_source_or_disasm_and_command): Don't change window
666 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
667 <make_visible>: New method.
668 * tui/tui-command.c (tui_cmd_window::resize): New method.
670 2019-08-15 Tom Tromey <tom@tromey.com>
672 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
673 (struct tui_source_windows): New.
674 * tui/tui-winsource.c (tui_display_main): Update.
675 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
676 (new_height_ok, parse_scrolling_args): Update.
677 * tui/tui-layout.c (show_layout, show_data): Update.
678 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
679 (tui_add_to_source_windows): Don't declare.
680 * tui/tui-data.c (source_windows, tui_source_windows)
681 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
683 2019-08-15 Tom Tromey <tom@tromey.com>
685 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
687 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
688 * tui/tui-layout.c (show_source_disasm_command, show_data):
690 (tui_gen_win_info::resize): Rename.
691 (show_source_or_disasm_and_command): Update.
692 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
695 2019-08-15 Tom Tromey <tom@tromey.com>
697 * tui/tui-stack.c (tui_initialize_static_data): Remove.
698 * tui/tui-interp.c (tui_interp::init): Don't call
699 tui_initialize_static_data.
700 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
702 2019-08-15 Tom Tromey <tom@tromey.com>
704 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
705 examine tui_win_list.
707 2019-08-15 Tom Tromey <tom@tromey.com>
709 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
710 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
711 tui_clear_source_content.
712 (tui_clear_source_content): Remove.
713 (tui_source_window_base::do_erase_source_content): Hoist call to
715 * tui/tui-stack.c (tui_show_frame_info): Don't call
716 tui_clear_source_content.
718 2019-08-15 Tom Tromey <tom@tromey.com>
720 * tui/tui-winsource.h (struct tui_source_window_base)
721 <do_erase_source_content>: New method.
722 <erase_source_content>: New method.
723 (tui_erase_source_content): Don't declare.
724 * tui/tui-winsource.c (tui_clear_source_content): Update.
725 (tui_source_window_base::do_erase_source_content): Rename from
726 tui_erase_source_content.
727 (tui_source_window_base::show_source_content): Update.
728 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
729 * tui/tui-source.h (struct tui_source_window)
730 <erase_source_content>: New method.
731 * tui/tui-disasm.h (struct tui_disasm_window)
732 <erase_source_content>: New method.
734 2019-08-15 Tom Tromey <tom@tromey.com>
736 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
737 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
739 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
740 * tui/tui-source.c (tui_set_source_content): Update.
741 * tui/tui-disasm.c (tui_set_disassem_content): Update.
743 2019-08-15 Tom Tromey <tom@tromey.com>
745 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
746 * tui/tui-winsource.c (tui_line_is_displayed): Move to
748 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
750 * tui/tui-source.c (tui_source_window::line_is_displayed): New
752 (tui_source_window::maybe_update): Update.
754 2019-08-15 Tom Tromey <tom@tromey.com>
756 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
757 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
759 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
761 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
763 (tui_disasm_window::maybe_update): Update.
765 2019-08-15 Tom Tromey <tom@tromey.com>
767 * tui/tui-winsource.h (struct tui_source_window_base)
768 <maybe_update>: Declare.
769 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
771 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
773 * tui/tui-source.c (tui_source_window::maybe_update): New method.
774 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
776 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
778 2019-08-15 Tom Tromey <tom@tromey.com>
780 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
782 2019-08-15 Tom Tromey <tom@tromey.com>
784 * tui/tui-wingeneral.c: Include tui-stack.h.
785 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
786 (struct tui_locator_window): Move from tui-data.h.
787 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
788 (tui_initialize_static_data): Move from tui-data.c.
789 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
790 (struct tui_locator_window): Move to tui-stack.c.
791 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
792 (tui_initialize_static_data): Move to tui-stack.c.
794 2019-08-15 Tom Tromey <tom@tromey.com>
796 * tui/tui-layout.c (show_source_disasm_command)
797 (show_source_or_disasm_and_command): Use make_visible method, not
799 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
802 2019-08-15 Tom Tromey <tom@tromey.com>
804 * tui/tui-wingeneral.h (tui_make_window): Update.
805 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
807 (tui_gen_win_info::make_visible): Update.
808 * tui/tui-regs.c (tui_data_window::display_registers_from):
810 * tui/tui-layout.c (show_source_disasm_command)
811 (show_source_or_disasm_and_command): Update.
812 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
813 (enum tui_box): Remove.
814 (struct tui_win_info) <can_box>: New method.
815 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
818 2019-08-15 Tom de Vries <tdevries@suse.de>
820 * linux-nat-trad.c: Include gdbarch.h.
822 2019-08-14 Alan Hayward <alan.hayward@arm.com>
824 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
827 2019-08-14 Tom Tromey <tromey@adacore.com>
829 * darwin-nat.c: Include gdbarch.h.
830 * darwin-nat-info.c: Include gdbarch.h.
832 2019-08-13 Tom Tromey <tom@tromey.com>
834 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
836 * tui/tui-data.c (tui_initialize_static_data): Update.
838 2019-08-13 Tom Tromey <tom@tromey.com>
840 * tui/tui-winsource.h (struct tui_exec_info_window)
841 <~tui_exec_info_window, maybe_allocate_content, get_content,
843 (struct tui_source_window_base) <set_exec_info_content,
844 show_exec_info_content>: Don't declare.
845 * tui/tui-winsource.c
846 (tui_exec_info_window::maybe_allocate_content): Remove.
847 (tui_source_window_base::update_exec_info): Rename from
848 set_exec_info_content.
849 (tui_source_window_base::show_exec_info_content)
850 (tui_source_window_base::update_exec_info): Remove.
852 2019-08-13 Tom Tromey <tom@tromey.com>
854 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
856 * tui/tui-winsource.c (tui_update_source_window_as_is)
857 (tui_update_source_windows_with_addr, tui_erase_source_content):
859 (tui_clear_exec_info_content): Remove.
861 2019-08-13 Tom Tromey <tom@tromey.com>
863 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
865 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
866 call tui_erase_exec_info_content.
867 (tui_clear_exec_info_content): Rename from
868 tui_erase_exec_info_content.
869 (tui_clear_exec_info_content): Delete.
871 2019-08-13 Tom Tromey <tom@tromey.com>
873 * tui/tui-winsource.h (struct tui_source_window_base)
874 <show_exec_info_content>: Declare.
875 (tui_show_exec_info_content): Don't declare.
876 * tui/tui-winsource.c
877 (tui_source_window_base::show_exec_info_content): Rename from
878 tui_show_exec_info_content.
879 (tui_source_window_base::update_exec_info): Update.
881 2019-08-13 Tom Tromey <tom@tromey.com>
883 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
884 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
885 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
886 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
887 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
888 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
891 2019-08-13 Tom Tromey <tom@tromey.com>
893 * tui/tui-winsource.h (struct tui_source_window_base)
894 <update_exec_info>: Declare.
895 (tui_update_exec_info): Don't declare.
896 * tui/tui-winsource.c (tui_update_source_window_as_is)
897 (tui_source_window_base::refresh_all)
898 (tui_update_all_breakpoint_info): Update.
899 (tui_source_window_base::update_exec_info): Rename from
900 tui_update_exec_info.
901 * tui/tui-stack.c (tui_show_frame_info): Update.
903 2019-08-13 Tom Tromey <tom@tromey.com>
905 * tui/tui-winsource.h (struct tui_source_window_base)
906 <set_exec_info_content>: Declare.
907 (tui_set_exec_info_content): Don't declare.
908 * tui/tui-winsource.c
909 (tui_source_window_base::set_exec_info_content): Rename from
910 tui_set_exec_info_content.
911 (tui_update_exec_info): Update.
913 2019-08-13 Tom Tromey <tom@tromey.com>
915 * tui/tui-winsource.h (struct tui_source_window_base)
916 <show_source_content>: Declare.
917 (tui_show_source_content): Don't declare.
918 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
919 (tui_source_window_base::show_source_content): Rename from
920 tui_show_source_content.
921 (tui_source_window_base::refresh_all): Update.
922 * tui/tui-layout.c (show_source_disasm_command)
923 (show_source_or_disasm_and_command): Update.
925 2019-08-13 Tom Tromey <tom@tromey.com>
927 * tui/tui-winsource.c (tui_erase_source_content)
928 (tui_show_source_content, tui_source_window_base::refresh_all):
930 * tui/tui-wingeneral.h
931 (tui_check_and_display_highlight_if_needed): Don't declare.
932 * tui/tui-wingeneral.c
933 (tui_win_info::check_and_display_highlight_if_needed): Rename from
934 check_and_display_highlight_if_needed.
935 * tui/tui-win.c (tui_rehighlight_all)
936 (tui_win_info::make_visible_with_new_height): Update.
937 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
938 (tui_data_window::erase_data_content)
939 (tui_data_window::display_all_data): Update.
940 * tui/tui-data.h (struct tui_win_info)
941 <check_and_display_highlight_if_needed>: Declare.
943 2019-08-13 Tom Tromey <tom@tromey.com>
945 * tui/tui-win.c (tui_resize_all): Call
946 tui_delete_invisible_windows.
947 * tui/tui-layout.c (show_layout): Call
948 tui_delete_invisible_windows.
949 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
950 * tui/tui-data.c (tui_delete_invisible_windows): New function.
952 2019-08-13 Tom Tromey <tom@tromey.com>
954 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
955 tui_add_win_to_layout.
957 2019-08-13 Tom Tromey <tom@tromey.com>
959 * tui/tui-layout.h (tui_default_win_height): Don't declare.
960 * tui/tui-layout.c (tui_default_win_height): Now static.
962 2019-08-13 Tom Tromey <tom@tromey.com>
964 * tui/tui-layout.c (show_layout): Unify all layout cases into a
966 (show_source_disasm_command, show_source_or_disasm_and_command):
967 Don't check current layout.
969 2019-08-13 Tom Tromey <tom@tromey.com>
971 * tui/tui-wingeneral.c (make_all_visible): Remove.
972 (tui_make_all_invisible): Simplify.
973 * tui/tui-layout.c (tui_make_all_invisible): Move from
974 tui-wingeneral.c; simplify.
975 (show_layout): Hoist call to tui_make_all_invisible.
976 (show_data): Don't call tui_make_all_invisible.
978 2019-08-13 Tom Tromey <tom@tromey.com>
980 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
981 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
983 2019-08-13 Tom Tromey <tom@tromey.com>
985 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
987 (show_source_disasm_command, show_data)
988 (show_source_or_disasm_and_command): Don't use
989 tui_set_current_layout_to.
990 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
991 * tui/tui-data.c (current_layout, tui_current_layout): Move to
993 (tui_set_current_layout_to): Remove.
995 2019-08-13 Tom Tromey <tom@tromey.com>
997 * tui/tui-layout.c (tui_set_layout): Update.
998 * tui/tui-data.h (struct tui_layout_def): Remove.
999 (tui_layout_def): Don't declare.
1000 * tui/tui-data.c (layout_def): Remove.
1001 (tui_layout_def): Remove.
1003 2019-08-13 Tom Tromey <tom@tromey.com>
1005 * tui/tui-winsource.h (struct tui_source_window_base)
1006 <clear_detail>: No longer "override".
1007 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1008 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1009 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1010 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1012 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1014 2019-08-13 Tom Tromey <tromey@adacore.com>
1016 * tracepoint.c: Don't include readline.h or history.h.
1018 2019-08-12 Tom Tromey <tom@tromey.com>
1020 * configure: Rebuild.
1021 * configure.ac: Check for readline 7.
1022 * NEWS: Mention readline 7 requirement.
1025 2019-08-12 Tom Tromey <tom@tromey.com>
1027 * mingw-hdep.c (gdb_select): Remove readline hack.
1029 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1031 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1032 when the function fails.
1034 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1036 * s390-tdep.c (s390_type_align): New function.
1037 (s390_gdbarch_init): Set it as type_align gdbarch method.
1039 2019-08-09 Tom de Vries <tdevries@suse.de>
1042 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1043 pc_low with relocation offset.
1045 2019-08-07 Tom Tromey <tromey@adacore.com>
1047 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1048 (print_frame_args): Update.
1049 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1051 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1052 * frame.h (struct frame_arg): Add initializers.
1053 <error>: Now a unique_xmalloc_ptr.
1055 2019-08-07 Alan Hayward <alan.hayward@arm.com>
1057 * NEWS: Expand the Pointer Authentication entry.
1058 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1059 (aarch64_frame_unmask_lr): ... to this.
1060 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1061 Call aarch64_frame_unmask_lr.
1062 * frame.c (struct frame_info): Add "masked" variable.
1063 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1064 (fprint_frame): Check for masked pc.
1065 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1067 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1068 * stack.c (print_frame): Check for masked pc.
1070 2019-08-06 Tom Tromey <tom@tromey.com>
1072 * stabsread.c (patch_block_stabs, read_one_struct_field)
1073 (read_enum_type): Use obstack_strndup.
1074 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1075 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1076 * dwarf2read.c (guess_full_die_structure_name)
1077 (anonymous_struct_prefix): Use obstack_strndup.
1078 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1079 * c-exp.y (yylex): Use obstack_strndup.
1080 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1081 (write_var_or_type): Use obstack_strndup.
1083 2019-08-06 Tom Tromey <tom@tromey.com>
1085 * symfile.c (reread_symbols): Use obstack_strdup.
1086 * stabsread.c (read_type): Use obstack_strdup.
1087 * gdb_obstack.h (obstack_strdup): New overload.
1088 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1089 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1090 (dwarf2_canonicalize_name): Use obstack_strdup.
1091 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1092 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1095 2019-08-06 Tom Tromey <tom@tromey.com>
1097 * gdb_obstack.h (obstack_strdup): Define.
1098 * gdb_obstack.c (obstack_strdup): Don't define.
1100 2019-08-06 Tom Tromey <tom@tromey.com>
1102 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1104 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1106 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1107 * stabsread.c (common_block_start): Use obstack_strdup.
1108 * objfiles.c (set_objfile_main_name, objfile): Use
1110 * namespace.c (add_using_directive): Use obstack_strdup.
1111 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1112 * jit.c (finalize_symtab): Use obstack_strdup.
1113 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1114 (guess_partial_die_structure_name, partial_die_info::fixup)
1115 (dwarf2_name): Use obstack_strdup.
1116 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1118 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1119 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1121 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1123 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1125 * unittests/help-doc-selftests.c: New file.
1126 * Makefile.in: Add the new file.
1128 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1130 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1131 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1132 the full first line, except when FOR_VALUE_PREFIX. In this case,
1133 the trailing '.' is not output, and the first character is uppercased.
1134 (print_help_for_command): Update call to print_doc_line.
1135 (print_doc_of_command): Likewise.
1136 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1137 * cli/cli-option.c (append_indented_doc): Do not append newline.
1138 (build_help_option): Append newline after first appended_indented_doc
1139 only if a second call is done.
1140 (build_help): Append 2 new lines before each option, except the first
1142 * compile/compile.c (_initialize_compile): Add new lines after
1143 %OPTIONS%, when not at the end of the help.
1144 Change help doc or code
1145 producing the help doc to respect the invariants.
1146 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1147 Also removed the new line after 'Options:', as all other commands
1148 do not put an empty line between 'Options:' and the first option.
1149 * printcmd.c (_initialize_printcmd): Likewise.
1150 * stack.c (_initialize_stack): Likewise.
1151 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1152 incorrectly telling COMMAND is optional.
1153 * ada-lang.c (_initialize_ada_language): Change help doc or code
1154 producing the help doc to respect the invariants.
1155 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1156 * breakpoint.c (_initialize_breakpoint): Likewise.
1157 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1158 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1159 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1160 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1161 _initialize_cli_style): Likewise.
1162 * corelow.c (core_target_info): Likewise.
1163 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1164 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1165 * filesystem.c (_initialize_filesystem): Likewise.
1166 * frame.c (_initialize_frame): Likewise.
1167 * gnu-nat.c (add_task_commands): Likewise.
1168 * infcall.c (_initialize_infcall): Likewise.
1169 * infcmd.c (_initialize_infcmd): Likewise.
1170 * interps.c (_initialize_interpreter): Likewise.
1171 * language.c (_initialize_language): Likewise.
1172 * linux-fork.c (_initialize_linux_fork): Likewise.
1173 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1174 * maint.c (_initialize_maint_cmds): Likewise.
1175 * memattr.c (_initialize_mem): Likewise.
1176 * printcmd.c (_initialize_printcmd): Likewise.
1177 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1179 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1180 * record-btrace.c (_initialize_record_btrace): Likewise.
1181 * record-full.c (_initialize_record_full): Likewise.
1182 * record.c (_initialize_record): Likewise.
1183 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1184 * regcache.c (_initialize_regcache): Likewise.
1185 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1186 _initialize_remote): Likewise.
1187 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1188 * serial.c (_initialize_serial): Likewise.
1189 * skip.c (_initialize_step_skip): Likewise.
1190 * source.c (_initialize_source): Likewise.
1191 * stack.c (_initialize_stack): Likewise.
1192 * symfile.c (_initialize_symfile): Likewise.
1193 * symtab.c (_initialize_symtab): Likewise.
1194 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1195 * top.c (init_main): Likewise.
1196 * tracefile-tfile.c (tfile_target_info): Likewise.
1197 * tracepoint.c (_initialize_tracepoint): Likewise.
1198 * tui/tui-win.c (_initialize_tui_win): Likewise.
1199 * utils.c (add_internal_problem_command): Likewise.
1200 * valprint.c (value_print_option_defs): Likewise.
1202 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
1205 * configure.ac: Drop enable-libmcheck support.
1206 * configure, config.in: Rebuild.
1207 * libmcheck.m4: Remove.
1208 * acinclude.m4: Don't include it.
1209 * Makefile.in: Don't distribute it.
1210 * top.c (print_gdb_configuration): Don't mention it.
1212 2019-08-06 Tom Tromey <tom@tromey.com>
1214 * utils.c (set_output_style): Sometimes pass stream to
1216 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1217 * record-btrace.c (btrace_insn_history): Update.
1218 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1220 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1221 Update initializers.
1222 <m_uiout>: New field.
1224 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1225 Remove "uiout" parameter.
1226 (dump_insns): Update.
1227 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1228 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1230 2019-08-06 Christian Biesinger <cbiesinger@google.com>
1232 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1233 (error_in_psymtab_expansion): Likewise.
1234 (lookup_symbol_via_quick_fns): Likewise.
1235 (basic_lookup_transparent_type_quick): Likewise.
1236 (basic_lookup_transparent_type_1): Likewise.
1238 2019-08-06 Tom Tromey <tromey@adacore.com>
1240 * source.c (last_source_error): Now bool.
1241 (print_source_lines_base): Make "noprint" bool. Only open
1242 source file when last_source_visited changes.
1244 2019-08-06 Tom Tromey <tromey@adacore.com>
1246 * annotate.c (annotate_source_line): Use g_source_cache.
1247 * source-cache.c (source_cache::get_plain_source_lines): Change
1248 parameters. Populate m_offset_cache.
1249 (source_cache::ensure): New method.
1250 (source_cache::get_line_charpos): New method.
1251 (extract_lines): Move lower. Change parameters.
1252 (source_cache::get_source_lines): Move lower.
1253 * source-cache.h (class source_cache): Update comment.
1254 <get_line_charpos>: New method.
1255 <get_source_lines>: Update comment.
1256 <clear>: Clear m_offset_cache.
1257 <get_plain_source_lines>: Change parameters.
1258 <ensure>: New method
1259 <m_offset_cache>: New member.
1260 * source.c (forget_cached_source_info_for_objfile): Update.
1261 (info_source_command): Use g_source_cache.
1262 (find_source_lines, open_source_file_with_line_charpos): Remove.
1263 (print_source_lines_base, search_command_helper): Use g_source_cache.
1264 * source.h (open_source_file_with_line_charpos): Don't declare.
1265 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1266 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1269 2019-08-06 Tom Tromey <tromey@adacore.com>
1271 * source-cache.c (source_cache::get_plain_source_lines):
1272 Remove "first_line" and "last_line" parameters.
1273 (source_cache::get_source_lines): Cache plain text.
1274 * source-cache.h (class source_cache)
1275 <get_plain_source_lines>: Update.
1277 2019-08-06 Tom Tromey <tromey@adacore.com>
1279 * source-cache.c (extract_lines): No longer a method.
1280 Changed type of parameter. Include final newline.
1281 (selftests::extract_lines_test): New function.
1282 (_initialize_source_cache): Likewise.
1283 * source-cache.h (class source_cache)
1284 <extract_lines>: Don't declare.
1286 2019-08-06 Tom Tromey <tromey@adacore.com>
1288 * breakpoint.c (init_breakpoint_sal): Update.
1289 (breakpoint): Update.
1290 * breakpoint.h (struct breakpoint) <filter>: Now a
1293 2019-08-05 Christian Biesinger <cbiesinger@google.com>
1295 * NEWS: Mention dictionary access on blocks.
1296 * python/py-block.c (blpy_getitem): New function.
1297 (block_object_as_mapping): New struct.
1298 (block_object_type): Use new struct for tp_as_mapping field.
1300 2019-08-05 Christian Biesinger <cbiesinger@google.com>
1302 * objfiles.h (objfile): Add a comment describing partial symbols.
1304 2019-08-05 Tom Tromey <tromey@adacore.com>
1306 * compile/compile.c (_initialize_compile): Use _(), not N_().
1307 * thread.c (_initialize_thread): Use _(), not N_().
1308 * stack.c (_initialize_stack): Use _(), not N_().
1309 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1311 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1313 * dwarf2read.c (struct dw2_symtab_iterator):
1314 <want_specific_block>: Remove.
1315 <block_index>: Change type to gdb::optional.
1316 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1317 change type of BLOCK_INDEX parameter to gdb::optional.
1318 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1319 (dw2_lookup_symbol): Don't pass argument for
1320 WANT_SPECIFIC_BLOCK.
1321 (dw2_expand_symtabs_for_function): Don't pass argument for
1322 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1323 (class dw2_debug_names_iterator)
1324 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1325 parameter, change BLOCK_INDEX type to gdb::optional.
1326 <m_want_specific_block>: Remove.
1327 <m_block_index>: Change type to gdb::optional.
1328 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1329 gdb::optional. Re-write in function of gdb::optional.
1330 (dw2_debug_names_lookup_symbol): Don't pass argument for
1331 WANT_SPECIFIC_BLOCK.
1332 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1333 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1336 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1338 * NEWS: Mention changes to "info sources" command.
1340 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1342 * symtab.c (filename_partial_match_opts): New struct type.
1343 (struct output_source_filename_data): New members
1344 regexp, c_regexp, partial_match.
1345 (output_source_filename): Use new members to decide to print file.
1346 (info_sources_option_defs): New variable.
1347 (make_info_sources_options_def_group, print_info_sources_header,
1348 info_sources_command_completer):
1350 (info_sources_command): Read new optional arguments.
1351 (_initialize_symtab): Update info sources help.
1353 2019-08-02 Alexandre Oliva <oliva@adacore.com>
1355 * ada-lang.c (exception_support_info_v0): Renamed from...
1356 (default_exception_support_info): ... this. Create new
1358 (ada_has_this_exception_support): Look up catch_handlers_sym.
1359 (ada_exception_support_info_sniffer): Try v0 after default.
1361 2019-08-01 Tom Tromey <tromey@adacore.com>
1363 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1366 2019-08-01 Christian Biesinger <cbiesinger@google.com>
1368 * s12z-tdep.c: Fix include path for s12z-opc.h.
1370 2019-08-01 Alan Hayward <alan.hayward@arm.com>
1372 * NEWS: Require GNU make 3.82.
1374 2019-07-16 Tom Tromey <tom@tromey.com>
1376 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1379 2019-07-30 Tom Tromey <tromey@adacore.com>
1381 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1383 2019-07-30 Kevin Buettner <kevinb@redhat.com>
1385 * printcmd.c (print_address_symbolic): Print negative offsets.
1386 (build_address_symbolic): Force signed arithmetic when computing
1389 2019-07-30 Christian Biesinger <cbiesinger@google.com>
1391 PR/24474: Add a function to lookup static variables.
1392 * NEWS: Mention this new function.
1393 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1394 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1395 * python/python.c (python_GdbMethods): Add new function.
1397 2019-07-29 Christian Biesinger <cbiesinger@google.com>
1399 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1400 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1401 (objfpy_lookup_static_symbol): New function.
1402 (objfile_object_methods): Add new functions.
1404 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1406 * NEWS: Mention 'set|show print frame-info'. Mention new
1407 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1408 backtrace argument. Mention that python frame filtering code
1409 is now consistent with what 'backtrace' command prints.
1411 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1413 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1415 (print_frame_info_auto, print_frame_info_source_line,
1416 print_frame_info_location, print_frame_info_source_and_location,
1417 print_frame_info_location_and_address, print_frame_info_short_location):
1419 (struct frame_print_options): New member print_frame_info.
1420 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1421 * stack.h (get_user_print_what_frame_info): New declaration.
1422 (frame_show_address): New declaration.
1423 * stack.c (print_frame_arguments_choices): New value 'presence'.
1424 (print_frame_info_auto, print_frame_info_source_line,
1425 print_frame_info_location, print_frame_info_source_and_location,
1426 print_frame_info_location_and_address, print_frame_info_short_location,
1427 print_frame_info_choices, print_frame_info_print_what): New definitions.
1428 (print_frame_args): Only print dots for args if print frame-arguments
1430 (frame_print_option_defs): New element for "frame-info".
1431 (get_user_print_what_frame_info): New function.
1432 (frame_show_address): Make non static. Move comment to stack.h.
1433 (print_frame_info_to_print_what): New function.
1434 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1435 to decide what to print.
1436 (backtrace_command_1): Handle the new print_frame_arguments_presence
1438 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1439 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1440 (py_print_frame): In non-mi mode, use LOCATION as default for
1441 print_what, similarly to frame information printed directly by
1442 backtrace command. Handle frame-info user option in non MI mode.
1444 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1446 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1447 Add case for debugging 32-bit target on 64-bit host. Revise
1450 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1452 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1453 instead of find_function_entry_range_from_pc.
1455 2019-07-27 Kevin Buettner <kevinb@redhat.com>
1457 * stack.c (find_frame_funname): Remove code which preferred
1458 minsym over symtab sym in "certain pathological cases".
1460 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1461 parameter. Change type of "do_demangle" to bool.
1462 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1463 Pass suitable "prefer_sym_over_minsym" flag to
1464 build_address_symbolic(). Don't output "+" for negative offsets.
1465 * printcmd.c (print_address_symbolic): Update invocation of
1466 build_address_symbolic to include a "prefer_sym_over_minsym"
1468 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1469 Restrict cases in which use of minimal symbol is preferred to that
1470 of a found symbol. Update comments.
1472 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1473 for entry pc when entry pc is out of range for that FDE.
1475 2019-07-26 Brian Callahan <bcallah@openbsd.org>
1478 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1481 2019-07-25 Christian Biesinger <cbiesinger@google.com>
1483 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1484 this function's Python signature.
1487 2019-07-24 Christian Biesinger <cbiesinger@google.com>
1489 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1490 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1491 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1492 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1493 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1496 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1498 * h8300-tdep.c (h8300_register_name_common): New.
1499 h8300_register_name): Use h8300_register_name_common.
1500 (h8300s_register_name): Likewise.
1501 (h8300sx_register_name): Likewise.
1502 (h8300h_register_nam): New.
1503 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1506 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1508 * arm-tdep.c (arm_skip_cmse_entry): New function.
1509 (arm_is_sgstubs_section): New function.
1510 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1512 2019-07-22 Tom Tromey <tom@tromey.com>
1514 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1517 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1519 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1522 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1524 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1525 so that GDB doesn't match any msymbols when searching in the
1527 (print_symbol_info): Print using typedef_print or type_print based
1528 on the type of the symbol. Add updated FIXME comment moved from...
1529 (_initialize_symtab): ... move and update FIXME comment to above.
1531 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1533 * NEWS: Mention adding -q option to "info types".
1534 * symtab.c (struct info_types_options): New struct.
1535 (info_types_options_defs): New variable.
1536 (make_info_types_options_def_group): New function.
1537 (info_types_command): Use gdb::option framework to parse options.
1538 (info_types_command_completer): New function.
1539 (_initialize_symtab): Extend the help text on "info types" and
1540 register command completer.
1542 2019-07-21 Christian Biesinger <cbiesinger@google.com>
1544 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1545 (lookup_symbol_in_objfile): Change int to block_enum and add a
1546 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1548 2019-07-20 Christian Biesinger <cbiesinger@google.com>
1550 * MAINTAINERS (Write After Approval): Add self.
1552 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1554 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1555 instruction to the dummy code region.
1557 2019-07-19 Tom Tromey <tromey@adacore.com>
1559 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1560 (ARGSUSED, PARAMS, __func__): Remove rules.
1562 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1564 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1565 * features/arm/arm-with-iwmmxt.c: Remove.
1566 * features/arm/arm-with-iwmmxt.xml: Remove.
1567 * features/arm/arm-with-m-fpa-layout.c: Remove.
1568 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1569 * features/arm/arm-with-m-vfp-d16.c: Remove.
1570 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1571 * features/arm/arm-with-m.c: Remove.
1572 * features/arm/arm-with-m.xml: Remove.
1573 * features/arm/arm-with-neon.c: Remove.
1574 * features/arm/arm-with-neon.xml: Remove.
1575 * features/arm/arm-with-vfpv2.c: Remove.
1576 * features/arm/arm-with-vfpv2.xml: Remove.
1577 * features/arm/arm-with-vfpv3.c: Remove.
1578 * features/arm/arm-with-vfpv3.xml: Remove.
1580 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1582 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1584 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1586 * arch/aarch32.c (aarch32_create_target_description): Create
1587 target descriptions using features.
1588 * arch/arm.c (arm_create_target_description)
1589 (arm_create_mprofile_target_description): Likewise.
1590 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1592 2019-07-19 Alan Hayward <alan.hayward@arm.com>
1594 * Makefile.in: Add new files.
1595 * aarch32-tdep.c: New file.
1596 * aarch32-tdep.h: New file.
1597 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1598 Call aarch32_read_description.
1599 * arch/aarch32.c: New file.
1600 * arch/aarch32.h: New file.
1601 * arch/arm.c (arm_create_target_description)
1602 (arm_create_mprofile_target_description): New function.
1603 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1604 (arm_create_target_description)
1605 (arm_create_mprofile_target_description): New declaration.
1606 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1607 read_description functions.
1608 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1610 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1611 * arm-tdep.c (tdesc_arm_list): New variable.
1612 (arm_register_g_packet_guesses): Call create description functions.
1613 (arm_read_description) (arm_read_mprofile_description): New
1615 * arm-tdep.h (arm_read_description)
1616 (arm_read_mprofile_description): Add declaration.
1617 * configure.tgt: Add new files.
1619 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1621 * top.c (new_ui_command): Open specified terminal just once.
1623 2019-07-18 Tom Tromey <tromey@adacore.com>
1625 * symtab.c (main_name): Constify return type.
1626 * symfile.c (set_initial_language): Update.
1627 * symtab.h (main_name): Constify return type.
1629 2019-07-17 Tom Tromey <tom@tromey.com>
1631 * tui/tui-winsource.c (tui_update_source_window)
1632 (tui_update_source_window_as_is)
1633 (tui_update_source_windows_with_line): Remove return.
1634 * tui/tui-disasm.c (tui_show_disassem)
1635 (tui_show_disassem_and_update_source): Remove return.
1636 * tui/tui.c (tui_reset): Remove return.
1637 * tui/tui-wingeneral.c
1638 (tui_check_and_display_highlight_if_needed): Remove return.
1640 2019-07-17 Tom Tromey <tom@tromey.com>
1642 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1644 2019-07-17 Tom Tromey <tom@tromey.com>
1646 * tui/tui-winsource.h (struct tui_exec_info_window)
1647 (struct tui_source_window_base): Move from tui-data.h.
1648 * tui/tui-winsource.c: Move many method definitions from
1649 elsewhere. Remove "structuring" comments.
1650 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1651 (tui_source_window_base::refresh_window): Move to
1653 * tui/tui-win.c (tui_source_window_base::refresh_all)
1654 (tui_source_window_base::update_tab_width)
1655 (tui_source_window_base::set_new_height)
1656 (tui_source_window_base::do_make_visible_with_new_height): Move to
1658 * tui/tui-source.h: Update.
1659 * tui/tui-source.c (tui_source_window_base::reset): Move to
1661 * tui/tui-disasm.h: Update.
1662 * tui/tui-data.h (struct tui_exec_info_window): Move to
1664 (struct tui_source_window_base): Likewise.
1665 * tui/tui-data.c (tui_source_window_base::clear_detail)
1666 (tui_source_window_base, ~tui_source_window_base): Move to
1669 2019-07-17 Tom Tromey <tom@tromey.com>
1671 * tui/tui-win.c (tui_resize_all)
1672 (tui_source_window_base::update_tab_width)
1673 (tui_adjust_win_heights): Update.
1674 (tui_win_info::make_invisible_and_set_new_height): Rename from
1675 make_invisible_and_set_new_height.
1676 * tui/tui-data.h (struct tui_win_info)
1677 <make_invisible_and_set_new_height>: New method.
1679 2019-07-17 Tom Tromey <tom@tromey.com>
1681 * tui/tui.c: Update.
1682 * tui/tui-source.h (struct tui_source_window): Move from
1684 * tui/tui-layout.c: Update.
1685 * tui/tui-disasm.c: Update.
1686 * tui/tui-data.h (struct tui_source_window): Move to
1689 2019-07-17 Tom Tromey <tom@tromey.com>
1691 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1693 * tui/tui-data.h (struct tui_disasm_window): Move to
1696 2019-07-17 Tom Tromey <tom@tromey.com>
1698 * tui/tui-regs.h (struct tui_data_item_window): Move from
1700 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1701 * tui/tui-data.h (struct tui_data_item_window): Move to
1703 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1705 2019-07-17 Tom Tromey <tom@tromey.com>
1707 * tui/tui.c: Update.
1708 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1709 (tui_cmd_window::max_height): Move to tui-command.c.
1710 * tui/tui-layout.c: Update.
1711 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1712 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1714 * tui/tui-command.h (struct tui_cmd_window): Move from
1716 * tui/tui-command.c: Remove "structuring" comments.
1717 (tui_cmd_window::clear_detail)
1718 (tui_cmd_window::do_make_visible_with_new_height)
1719 (tui_cmd_window::max_height): Move from elsewhere.
1721 2019-07-17 Tom Tromey <tom@tromey.com>
1723 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1725 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1726 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1728 2019-07-17 Tom Tromey <tom@tromey.com>
1730 * tui/tui.c: Update.
1731 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1733 * tui/tui-windata.h: Remove file.
1734 * tui/tui-windata.c: Remove file.
1735 * tui/tui-win.c (tui_data_window::set_new_height)
1736 (tui_data_window::do_make_visible_with_new_height): Move to
1738 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1739 * tui/tui-regs.c: Remove "structuring" comments.
1740 (tui_data_window::first_data_item_displayed)
1741 (tui_data_window::delete_data_content_windows)
1742 (tui_data_window::erase_data_content)
1743 (tui_data_window::display_all_data)
1744 (tui_data_window::refresh_all)
1745 (tui_data_window::do_scroll_vertical)
1746 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1747 (tui_data_window::do_make_visible_with_new_height)
1748 (tui_data_window::refresh_window): Move from elsewhere.
1749 (_initialize_tui_regs): Move to end of file.
1750 * tui/tui-layout.c: Update.
1751 * tui/tui-hooks.c: Update.
1752 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1753 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1755 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1757 2019-07-17 Tom Tromey <tom@tromey.com>
1759 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1762 2019-07-17 Tom Tromey <tom@tromey.com>
1764 * tui/tui-win.c (tui_source_window_base::set_new_height)
1765 (tui_source_window_base::do_make_visible_with_new_height): Use
1766 m_has_locator field directly.
1767 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1769 (struct tui_source_window_base) <has_locator>: Likewise.
1771 2019-07-17 Tom Tromey <tom@tromey.com>
1773 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1775 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1777 * tui/tui-win.c (tui_source_window_base::set_new_height)
1778 (tui_source_window_base::set_new_height)
1779 (make_invisible_and_set_new_height)
1780 (tui_source_window_base::do_make_visible_with_new_height)
1781 (tui_source_window_base::do_make_visible_with_new_height):
1783 * tui/tui-layout.c (show_source_disasm_command, show_data)
1784 (show_source_or_disasm_and_command): Update.
1785 * tui/tui-layout.c (show_layout): Update.
1787 2019-07-17 Tom Tromey <tom@tromey.com>
1789 * tui/tui-layout.c (make_data_window): Remove.
1790 (show_data): Unify creation and re-initialization cases.
1792 2019-07-17 Tom Tromey <tom@tromey.com>
1794 * tui/tui-layout.c (make_source_window, make_disasm_window):
1796 (show_data): Unify creation and re-initialization cases.
1798 2019-07-17 Tom Tromey <tom@tromey.com>
1800 * tui/tui-layout.c (make_command_window): Remove.
1801 (show_source_disasm_command, show_source_or_disasm_and_command):
1802 Unify creation and re-initialization cases.
1804 2019-07-17 Tom Tromey <tom@tromey.com>
1806 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1807 creation and re-initialization cases.
1809 2019-07-17 Tom Tromey <tom@tromey.com>
1811 * tui/tui-regs.c (tui_get_register): Return void.
1813 2019-07-17 Tom Tromey <tom@tromey.com>
1815 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1818 2019-07-17 Tom Tromey <tom@tromey.com>
1820 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1823 2019-07-17 Tom Tromey <tom@tromey.com>
1825 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1826 * tui/tui-regs.c (tui_reg_layout): New function.
1827 (tui_show_registers, tui_reg_command): Use it.
1828 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1829 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1831 (tui_layout_command): Remove.
1833 2019-07-17 Tom Tromey <tom@tromey.com>
1835 * tui/tui-layout.h (tui/tui-layout): Return void.
1836 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1838 2019-07-17 Tom Tromey <tom@tromey.com>
1840 * tui/tui-layout.c (show_source_disasm_command, show_data):
1842 (reset_locator): Remove.
1843 (show_source_or_disasm_and_command): Update.
1845 2019-07-17 Tom Tromey <tom@tromey.com>
1847 * tui/tui-source.c (tui_source_window_base::reset): Remove
1849 * tui/tui-layout.c (make_command_window, make_source_window)
1850 (make_disasm_window, make_data_window)
1851 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1852 (reset_locator, show_source_or_disasm_and_command): Update.
1853 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1855 (struct tui_source_window_base) <reset>: Likewise.
1857 2019-07-17 Tom Tromey <tom@tromey.com>
1859 * tui/tui-layout.c (show_source_disasm_command): Use
1861 (reset_locator): New function.
1862 (init_and_make_win): Remove.
1863 (show_source_or_disasm_and_command): Use reset_locator.
1865 2019-07-17 Tom Tromey <tom@tromey.com>
1867 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1869 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1871 * tui/tui-source.c (tui_source_window_base::reset): New method.
1872 * tui/tui-layout.c (make_command_window): Don't call
1874 (make_source_window, make_disasm_window): Don't call
1875 make_source_or_disasm_window.
1876 (make_data_window): Don't call init_and_make_win. Change calling
1878 (show_source_disasm_command, show_data): Simplify.
1879 (make_source_or_disasm_window): Remove.
1880 (show_source_or_disasm_and_command): Simplify.
1881 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1882 (struct tui_source_window_base) <reset>: Likewise.
1883 <execution_info>: Remove initializer.
1884 * tui/tui-data.c (tui_source_window_base): Initialize
1887 2019-07-17 Tom Tromey <tom@tromey.com>
1889 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1892 2019-07-17 Tom Tromey <tom@tromey.com>
1894 * tui/tui.c (tui_rl_other_window): Update.
1895 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1896 superclass method first. Always iterate over regs_content.
1897 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1899 * tui/tui-win.c (tui_set_focus_command): Update.
1901 2019-07-17 Tom Tromey <tom@tromey.com>
1903 * tui/tui-win.c (tui_set_focus_command): Rename from
1904 tui_set_focus. Call tui_enable.
1905 (tui_set_focus_command): Remove.
1907 2019-07-17 Tom Tromey <tom@tromey.com>
1909 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1911 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1913 (tui_data_window::refresh_window): Call refresh_window on data
1914 items. Always call superclass refresh_window.
1915 (tui_win_info::refresh): Remove.
1916 (tui_source_window_base::refresh_window): Update.
1917 (tui_refresh_all): Update.
1918 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1920 (show_source_or_disasm_and_command): Likewise.
1921 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1922 (struct tui_source_window_base) <refresh>: Likewise.
1924 2019-07-17 Tom Tromey <tom@tromey.com>
1926 * tui/tui-winsource.c (tui_clear_source_content)
1927 (tui_show_source_content): Update.
1928 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1929 whether content is empty.
1930 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1933 2019-07-17 Tom Tromey <tom@tromey.com>
1935 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1937 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1938 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1940 2019-07-17 Tom Tromey <tom@tromey.com>
1942 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1943 (struct tui_data_item_window): Update.
1945 2019-07-17 Tom Tromey <tom@tromey.com>
1947 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1948 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1951 2019-07-17 Tom Tromey <tom@tromey.com>
1953 * tui/tui-winsource.h (tui_erase_source_content)
1954 (tui_clear_source_content): Remove "display_prompt" parameter.
1955 * tui/tui-winsource.c (tui_update_source_window_as_is)
1956 (tui_update_source_windows_with_addr): Update.
1957 (tui_clear_source_content): Remove "display_prompt" parameter.
1958 (tui_erase_source_content): Likewise. Simplify.
1959 (tui_show_source_content): Update.
1960 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1961 * tui/tui-stack.c (tui_show_frame_info): Update.
1962 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1965 2019-07-17 Tom Tromey <tom@tromey.com>
1967 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1968 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1970 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1973 2019-07-17 Tom Tromey <tom@tromey.com>
1975 * tui/tui-winsource.c (tui_clear_source_content)
1976 (tui_show_source_content, tui_show_exec_info_content)
1977 (tui_clear_exec_info_content): Update.
1978 * tui/tui-stack.c (tui_show_locator_content): Update.
1979 (tui_show_frame_info): Update.
1980 * tui/tui-source.h (tui_source_window): Don't declare.
1981 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1982 from tui_source_is_displayed.
1983 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1985 (struct tui_source_window_base) <content_in_use>: New field. Now
1987 (struct tui_source_window) <showing_source_p>: New method.
1988 (TUI_SRC_WIN): Change cast.
1989 * tui/tui-data.c (tui_initialize_static_data): Update.
1991 2019-07-17 Tom Tromey <tom@tromey.com>
1993 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1995 * tui/tui-source.c (tui_source_window::location_matches_p): New
1997 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1999 * tui/tui-data.h (struct tui_source_window_base)
2000 <location_matches_p>: New method.
2001 (struct tui_source_window, struct tui_disasm_window)
2002 <location_matches_p>: Likewise.
2004 2019-07-17 Tom Tromey <tom@tromey.com>
2006 * tui/tui-win.c (tui_set_win_height_command): Rename from
2008 (tui_set_win_height_command): Remove.
2010 2019-07-17 Tom Tromey <tom@tromey.com>
2012 * tui/tui-source.c (tui_source_window): New constructor. Add
2014 (~tui_source_window): New destructor.
2015 (tui_source_window::style_changed): New method.
2016 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2017 (tui_attach_detach_observers): Update.
2018 * tui/tui-data.h (struct tui_source_window): Make constructor not
2019 inline. Add destructor.
2020 (struct tui_source_window) <style_changed>: New method.
2021 <m_observable>: New member.
2023 2019-07-17 Tom Tromey <tom@tromey.com>
2025 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2026 * tui/tui-win.c (tui_resize_all): Fix typo.
2028 2019-07-17 Tom Tromey <tom@tromey.com>
2030 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2031 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2032 (tui_refresh_all): Remove "list" parameter. Use foreach.
2033 * tui/tui-win.c (window_name_completer): Use foreach.
2034 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2035 (update_tab_width): Likewise.
2036 * tui/tui-layout.c (show_layout): Update.
2037 * tui/tui-data.h (class tui_window_iterator): New.
2038 (struct all_tui_windows): New.
2039 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2041 2019-07-17 Tom Tromey <tom@tromey.com>
2043 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2044 parameter. Don't reference globals.
2045 (tui_reg_command): Update.
2047 2019-07-17 Tom Tromey <tom@tromey.com>
2049 * tui/tui-regs.c (tui_show_registers): Simplify.
2051 2019-07-17 Tom Tromey <tom@tromey.com>
2053 * tui/tui-regs.c (tui_show_registers): Update.
2054 (tui_show_register_group): Add win_info parameter.
2056 2019-07-17 Tom Tromey <tom@tromey.com>
2058 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2059 Rename from tui_display_reg_element_at_line.
2060 (tui_data_window::display_registers_from_line): Update.
2061 * tui/tui-data.h (struct tui_data_window)
2062 <display_reg_element_at_line>: New method.
2064 2019-07-17 Tom Tromey <tom@tromey.com>
2066 * tui/tui-regs.h (tui_display_registers_from)
2067 (tui_display_registers_from_line): Don't declare.
2068 * tui/tui-windata.c (tui_data_window::display_all_data)
2069 (tui_data_window::refresh_all)
2070 (tui_data_window::do_scroll_vertical): Update.
2071 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2072 from tui_display_registers_from.
2073 (tui_display_reg_element_at_line): Update.
2074 (tui_data_window::display_registers_from_line): Rename from
2075 tui_display_registers_from_line.
2076 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2077 display_registers_from_line>: New methods.
2079 2019-07-17 Tom Tromey <tom@tromey.com>
2081 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2082 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2083 from tui_erase_data_content.
2084 (tui_data_window::display_all_data)
2085 (tui_data_window::refresh_all)
2086 (tui_data_window::do_scroll_vertical): Update.
2087 * tui/tui-regs.c (tui_show_registers): Update.
2088 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2091 2019-07-17 Tom Tromey <tom@tromey.com>
2093 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2096 (tui_data_window::delete_data_content_windows): Rename from
2097 tui_delete_data_content_windows.
2098 (tui_data_window::display_all_data)
2099 (tui_data_window::do_scroll_vertical): Update.
2100 * tui/tui-data.h (struct tui_data_window)
2101 <delete_data_content_windows>: New method.
2103 2019-07-17 Tom Tromey <tom@tromey.com>
2105 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2106 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2108 2019-07-17 Tom Tromey <tom@tromey.com>
2110 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2111 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2112 from tui_display_all_data.
2114 (tui_data_window::do_make_visible_with_new_height): Update.
2115 * tui/tui-regs.c (tui_show_registers): Update.
2116 * tui/tui-layout.c (tui_set_layout): Update.
2117 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2120 2019-07-17 Tom Tromey <tom@tromey.com>
2122 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2123 * tui/tui-windata.c (tui_display_data_from): Remove.
2124 (tui_data_window::refresh_all): Update.
2126 2019-07-17 Tom Tromey <tom@tromey.com>
2128 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2129 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2130 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2131 tui_display_registers_from_line.
2132 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2133 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2134 "force_display" parameter.
2136 2019-07-17 Tom Tromey <tom@tromey.com>
2138 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2140 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2141 Rename from tui_first_reg_element_no_inline.
2142 (tui_display_reg_element_at_line)
2143 (tui_display_registers_from_line): Update.
2144 * tui/tui-data.h (struct tui_data_window)
2145 <first_reg_element_no_inline>: New method.
2147 2019-07-17 Tom Tromey <tom@tromey.com>
2149 * tui/tui-windata.c (tui_display_data_from)
2150 (tui_data_window::do_scroll_vertical): Update.
2151 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2152 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2153 Rename from tui_line_from_reg_element_no.
2154 (tui_display_registers_from_line): Update.
2155 * tui/tui-data.h (struct tui_data_window)
2156 <line_from_reg_element_no>: New method.
2158 2019-07-17 Tom Tromey <tom@tromey.com>
2160 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2161 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2162 tui_last_regs_line_no.
2163 (tui_display_reg_element_at_line)
2164 (tui_display_registers_from_line): Update.
2165 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2168 2019-07-17 Tom Tromey <tom@tromey.com>
2171 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2172 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2173 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2174 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2175 (tui_update_breakpoint_info): Likewise.
2176 * tui/tui-hooks.c (tui_event_create_breakpoint)
2177 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2180 2019-07-17 Tom Tromey <tom@tromey.com>
2182 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2184 2019-07-17 Tom Tromey <tom@tromey.com>
2186 * tui/tui-winsource.c (tui_update_source_window_as_is)
2187 (tui_update_source_windows_with_addr): Update.
2188 * tui/tui-source.h (tui_set_source_content)
2189 (tui_show_symtab_source): Add "win_info" parameter.
2190 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2192 (tui_show_symtab_source): Likewise.
2194 2019-07-17 Tom Tromey <tom@tromey.com>
2196 * tui/tui-wingeneral.c
2197 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2199 2019-07-17 Tom Tromey <tom@tromey.com>
2201 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2202 (struct tui_cmd_window) <can_scroll>: New method.
2203 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2206 2019-07-17 Tom Tromey <tromey@adacore.com>
2208 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2209 do_field_signed>: Rename. Change type of "value".
2210 * ui-out.c (ui_out::field_signed): Rename from field_int.
2211 Change type of "value".
2212 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2214 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2215 do_field_int. Change type of "value".
2216 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2217 do_field_int. Change type of "value".
2218 * tracepoint.c (trace_status_mi, tfind_1)
2219 (print_one_static_tracepoint_marker): Update.
2220 * thread.c (print_thread_info_1, print_selected_thread_frame):
2222 * stack.c (print_frame, print_frame_info): Update.
2223 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2225 * source.c (print_source_lines_base): Update.
2226 * skip.c (info_skip_command): Update.
2227 * record-btrace.c (btrace_ui_out_decode_error)
2228 (btrace_call_history_src_line): Update.
2229 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2231 * progspace.c (print_program_space): Update.
2232 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2233 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2234 do_field_int. Change type of "value".
2235 * mi/mi-out.c (mi_ui_out::do_table_begin)
2236 (mi_ui_out::do_table_header): Update.
2237 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2239 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2240 (mi_cmd_data_list_changed_registers, output_register)
2241 (mi_cmd_data_read_memory, mi_load_progress)
2242 (mi_cmd_trace_frame_collected): Update.
2243 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2245 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2246 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2247 (mi_cmd_var_list_children, varobj_update_one): Update.
2248 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2249 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2250 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2251 * inferior.c (print_inferior): Update.
2252 * gdb_bfd.c (print_one_bfd): Update.
2253 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2255 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2256 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2257 do_field_int. Change type of "value".
2258 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2259 do_field_int. Change type of "value".
2260 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2261 (print_one_breakpoint_location, print_it_catch_fork)
2262 (print_one_catch_fork, print_it_catch_vfork)
2263 (print_one_catch_vfork, print_it_catch_solib)
2264 (print_it_catch_exec, print_it_ranged_breakpoint)
2265 (print_mention_watchpoint, print_mention_masked_watchpoint)
2266 (bkpt_print_it, update_static_tracepoint): Update.
2267 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2268 * break-catch-syscall.c (print_it_catch_syscall): Update.
2269 * ada-tasks.c (print_ada_task_info): Update.
2270 * ada-lang.c (print_it_exception, print_mention_exception):
2273 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2275 PR breakpoints/24541
2276 * gdbarch.c: Regenerate.
2277 * gdbarch.h: Regenerate.
2278 * gdbarch.sh: Adjust return type and parameter types for
2279 'stap_adjust_register'.
2280 (i386_stap_adjust_register): Adjust signature and return new
2282 * stap-probe.c (stap_parse_register_operand): Adjust use of
2283 'gdbarch_stap_adjust_register'.
2285 2019-07-17 Tom Tromey <tromey@adacore.com>
2287 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2289 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2291 (struct s390_process_info): Add initializers.
2292 (s390_add_process): Use new.
2293 (s390_linux_nat_target::low_forget_process): Use delete.
2294 (s390_linux_nat_target::low_new_fork)
2295 (s390_linux_nat_target::stopped_by_watchpoint)
2296 (s390_linux_nat_target::low_prepare_to_resume)
2297 (s390_linux_nat_target::insert_watchpoint)
2298 (s390_linux_nat_target::insert_hw_breakpoint)
2299 (s390_linux_nat_target::remove_watchpoint)
2300 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2302 2019-07-16 John Baldwin <jhb@FreeBSD.org>
2304 * aarch64-fbsd-nat.c: Include regcache.h.
2305 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2307 (aarch64_fbsd_nat_target::fetch_registers)
2308 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2310 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2312 2019-07-16 John Baldwin <jhb@FreeBSD.org>
2314 * fbsd-nat.c: Include gdbarch.h.
2316 2019-07-15 Tom Tromey <tromey@adacore.com>
2318 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2320 2019-07-15 Tom Tromey <tromey@adacore.com>
2322 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2323 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2324 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2325 * cli-out.c (cli_ui_out::do_field_int): New method.
2326 * ui-out.c (ui_out::field_unsigned): New method.
2327 * symfile.c (generic_load): Use field_unsigned.
2328 (print_transfer_performance): Likewise.
2329 * record-btrace.c (ui_out_field_uint): Remove.
2330 (btrace_call_history_insn_range, btrace_call_history): Use
2332 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2334 * ui-out.h (class ui_out) <field_unsigned>: New method.
2335 <do_field_unsigned>: Likewise.
2337 2019-07-15 Tom Tromey <tromey@adacore.com>
2339 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2340 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2341 * target.c (flash_erase_command): Use field_string.
2342 * infrun.c (print_signal_received_reason): Use field_string.
2343 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2344 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2346 * ada-tasks.c (print_ada_task_info): Use field_string.
2348 2019-07-15 Tom Tromey <tromey@adacore.com>
2350 * target.c (flash_erase_command): Use field_core_addr.
2351 * symfile.c (generic_load): Use field_core_addr.
2352 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2353 Use field_core_addr.
2354 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2357 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2359 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2360 value if its desired type is smaller than a CORE_ADDR and signed.
2362 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2364 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2365 of changes to field names, and use new is_reference field to
2366 decide if a property is a reference or not.
2367 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2369 (struct dwarf2_property_baton): Update header comment, rename
2370 'referenced_type' to 'property_type' and update comments.
2371 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2372 default property type, store in property baton, update to take
2373 accound of renamed field.
2374 (read_func_scope): Update call to attr_to_dynamic_prop.
2375 (read_array_type): Likewise.
2376 (dwarf2_per_cu_addr_sized_int_type): New function.
2377 (read_subrange_index_type): Move type finding code to
2378 dwarf2_per_cu_addr_sized_int_type.
2379 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2380 (dwarf2_per_cu_addr_type): New function.
2381 (set_die_type): Update calls to attr_to_dynamic_prop.
2383 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2385 * dwarf2read.c (read_subrange_index_type): New function.
2386 (read_subrange_type): Move code into new function and call it.
2387 * gdbtypes.c (create_range_type): Add some asserts.
2389 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2391 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2392 update return statements.
2393 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2394 declaration, and update comment to match.
2395 * gdbtypes.c (resolve_dynamic_array): Update call to
2396 dwarf2_evaluate_property to match new return type.
2398 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2400 * valarith.c (value_subscripted_rvalue): Change lowerbound
2401 parameter type from int to LONGEST.
2402 * value.h (value_subscripted_rvalue): Likewise in declaration.
2404 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2406 * cli/cli-utils.c (info_print_command_completer): New function.
2407 * cli/cli-utils.h: Add 'completer.h' include, and forward
2408 declaration for 'struct cmd_list_element'.
2409 (info_print_command_completer): Declare.
2410 * stack.c (_initialize_stack): Add completer for 'info locals' and
2412 * symtab.c (_initialize_symtab): Add completer for 'info
2413 variables' and 'info functions'.
2414 * NEWS: Mention completion for additional info commands.
2416 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2418 * cli/cli-utils.c (extract_info_print_args): Delete.
2419 (extract_arg_maybe_quoted): Delete.
2420 (info_print_options_defs): New variable.
2421 (make_info_print_options_def_group): New function.
2422 (extract_info_print_options): Define new function.
2423 * cli/cli-utils.h (extract_info_print_args): Delete.
2424 (struct info_print_options): New structure.
2425 (extract_info_print_options): Declare new function.
2426 * stack.c (info_locals_command): Update to use new
2427 extract_info_print_options, also add a header comment.
2428 (info_args_command): Likewise.
2429 * symtab.c (info_variables_command): Likewise.
2430 (info_functions_command): Likewise.
2432 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2434 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2435 to extract string arguments.
2436 * common/common-utils.c (extract_string_maybe_quoted): New function.
2437 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2439 2019-07-11 Tom Tromey <tromey@adacore.com>
2441 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2442 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2443 * top.h (gdbinit): Don't declare.
2444 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2446 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2447 * top.c (gdb_init): Don't call init_cli_cmds.
2449 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2451 2019-07-11 Tom Tromey <tromey@adacore.com>
2453 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2454 after it has been moved.
2456 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2458 * valops.c (value_must_coerce_to_target): Change return type to
2460 * value.h (value_must_coerce_to_target): Likewise.
2462 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
2464 * breakpoint.c (is_hardware_watchpoint): Remove
2465 forward-declaration.
2466 (is_masked_watchpoint): Change return type to bool.
2467 (is_tracepoint): Likewise.
2468 (is_breakpoint): Likewise.
2469 (is_hardware_watchpoint): Likewise.
2470 (is_watchpoint): Likewise.
2471 (is_no_memory_software_watchpoint): Likewise.
2472 (is_catchpoint): Likewise.
2473 (breakpoint_1): Make FILTER parameter's return type bool.
2474 is_masked_watchpoint): Change return type to bool.
2475 (save_breakpoints): Make FILTER parameter's return type bool.
2476 * breakpoint.h (is_breakpoint): Change return type to bool.
2477 (is_watchpoint): Likewise.
2478 (is_catchpoint): Likewise.
2479 (is_tracepoint): Likewise.
2481 2019-07-10 Tom Tromey <tom@tromey.com>
2483 * defs.h: Don't include gdbarch.h.
2484 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2485 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2486 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2487 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2488 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2489 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2490 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2491 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2492 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2493 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2494 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2495 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2496 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2497 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2498 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2499 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2500 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2501 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2502 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2503 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2504 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2505 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2506 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2507 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2508 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2509 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2510 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2512 2019-07-10 Tom Tromey <tromey@adacore.com>
2514 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2515 * breakpoint.c (init_ada_exception_breakpoint): Register as
2517 (print_one_breakpoint_location, print_one_breakpoint): Use
2518 is_ada_exception_catchpoint.
2519 * ada-lang.c (class ada_catchpoint_location): Pass
2520 bp_loc_software_breakpoint to bp_location constructor.
2521 (is_ada_exception_catchpoint): New function.
2523 2019-07-10 Tom Tromey <tromey@adacore.com>
2525 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2527 (struct arm_exidx_entry): New method operator<.
2528 (struct arm_exidx_data) <section_maps>: Change type.
2529 (arm_exidx_data_free): Remove.
2530 (arm_exidx_data_key): Change type. Move lower.
2531 (arm_exidx_new_objfile): Update.
2532 (arm_compare_exidx_entries): Remove.
2533 (arm_find_exidx_entry, _initialize_arm_tdep)
2535 2019-07-10 Tom Tromey <tromey@adacore.com>
2537 * solib-spu.c (ocl_program_data_key): Change type.
2538 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2541 2019-07-10 Tom Tromey <tromey@adacore.com>
2543 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2544 (struct solib_aix_inferior_data) <library_list>: Change type.
2545 (solib_aix_inferior_data_handle): Change type.
2546 (get_solib_aix_inferior_data): Update.
2547 (solib_aix_free_library_list): Remove.
2548 (library_list_start_library): Update.
2549 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2551 (solib_aix_get_library_list)
2552 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2553 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2555 2019-07-10 Tom Tromey <tromey@adacore.com>
2557 * solib-dsbt.c (struct dsbt_info): Add initializers.
2558 (solib_dsbt_pspace_data): Change type.
2559 (dsbt_pspace_data_cleanup): Remove.
2560 (get_dsbt_info, _initialize_dsbt_solib): Update.
2562 2019-07-10 Tom Tromey <tromey@adacore.com>
2564 * spu-tdep.c (spu_overlay_data): Change type.
2565 (spu_get_overlay_table, spu_overlay_new_objfile)
2566 (_initialize_spu_tdep): Update.
2568 2019-07-10 Tom Tromey <tromey@adacore.com>
2570 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2572 (dbx_objfile_data_key): Change type and declare later.
2573 (DBX_SYMFILE_INFO): Rewrite.
2574 * dbxread.c (dbx_objfile_data_key): Change type.
2575 (dbx_symfile_init): Update.
2576 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2577 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2578 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2580 2019-07-10 Tom Tromey <tromey@adacore.com>
2582 * jit.c (jit_program_space_key): Change type. Move lower.
2583 (get_jit_program_space_data): Update.
2584 (jit_program_space_data_cleanup): Remove.
2585 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2587 (struct jit_program_space_data): Add initializers.
2589 2019-07-10 Tom Tromey <tromey@adacore.com>
2591 * solib-darwin.c (struct darwin_info): Add initializers.
2592 (solib_darwin_pspace_data): Change type.
2593 (darwin_pspace_data_cleanup): Remove.
2594 (get_darwin_info, _initialize_darwin_solib): Update.
2596 2019-07-10 Tom Tromey <tromey@adacore.com>
2598 * remote-sim.c (struct sim_inferior_data): Add initializers,
2599 constructor, and destructor.
2600 (sim_inferior_data_key): Change type. Move lower.
2601 (check_for_duplicate_sim_descriptor): Update.
2602 (get_sim_inferior_data): Use new. Update.
2603 (~sim_inferior_data_cleanup): Rename from
2604 sim_inferior_data_cleanup. Simplify.
2605 (gdbsim_close_inferior, simulator_command)
2606 (sim_command_completer, _initialize_remote_sim): Update.
2607 (next_pid, INITIAL_PID): Move earlier.
2609 2019-07-10 Tom Tromey <tromey@adacore.com>
2611 * python/python-internal.h (create_thread_object): Return
2613 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2614 * python/py-inferior.c (struct threadlist_entry): Add
2616 <thread_obj>: Now a gdbpy_ref.
2617 (thread_to_thread_object): Update.
2618 (add_thread_object): Use new.
2619 (delete_thread_object): Use delete.
2620 (infpy_threads): Update.
2621 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2624 2019-07-10 Tom Tromey <tromey@adacore.com>
2626 * valops.c (value_cast): Specialize error message for Ada.
2628 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2630 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2632 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2634 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2635 bpstat_should_step): Return bool, adjust comments.
2636 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2637 bpstat_should_step): Likewise.
2639 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2641 * features/Makefile: Use feature target descriptions for Arm.
2642 * features/arm/arm-core.c: Generate new file.
2643 * features/arm/arm-fpa.c: Likewise.
2644 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2645 * features/arm/arm-m-profile.c: Likewise.
2646 * features/arm/arm-vfpv2.c: Likewise.
2647 * features/arm/arm-vfpv3.c: Likewise.
2648 * features/arm/xscale-iwmmxt.c: Likewise.
2649 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2651 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2653 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2656 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2658 * features/aarch64-pauth.c: Regenerate.
2660 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2662 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2664 (bpstat_what): Use false instead of 0.
2666 2019-07-09 Pedro Alves <palves@redhat.com>
2668 * break-catch-throw.c (is_exception_catchpoint): New.
2669 * breakpoint.c (print_one_breakpoint_location): New parameter
2670 'raw_loc'. Handle it. Use
2671 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2672 looking at the breakpoint's type.
2673 (print_one_breakpoint): If handling "maint info breakpoints", also
2674 print locations of exception catchpoints.
2675 * breakpoint.h (is_exception_catchpoint): Declare.
2677 2019-07-09 Pedro Alves <palves@redhat.com>
2679 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2681 (allocate_location_exception_catchpoint): New.
2682 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2683 (initialize_throw_catchpoint_ops): Install
2684 allocate_location_exception_catchpoint as allocate_location
2686 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2687 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2689 (breakpoint_address_is_meaningful): Delete.
2690 (bl_address_is_meaningful): New.
2691 (breakpoint_locations_match): Adjust comment.
2692 (bp_location_from_bp_type): New, factored out of...
2693 (bp_location::bp_location(breakpoint *)): ... this.
2694 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2696 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2697 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2698 breakpoint_address_is_meaningful.
2699 (bp_locations_compare): Adjust comment.
2700 (update_global_location_list): Use bl_address_is_meaningful
2701 instead of breakpoint_address_is_meaningful.
2702 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2704 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2705 * python/py-breakpoint.c (bppy_get_location): No longer check
2706 whether location is null.
2708 2019-07-09 Pedro Alves <palves@redhat.com>
2711 * breakpoint.c (print_one_breakpoint_location): Remove
2712 single-location assert.
2714 2019-07-09 Tom Tromey <tom@tromey.com>
2716 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2717 * configure: Rebuild.
2718 * configure.ac: Change common to gdbsupport.
2719 * gdbsupport: Rename from common.
2720 * acinclude.m4: Change common to gdbsupport.
2721 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2722 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2724 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2725 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2726 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2727 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2728 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2729 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2730 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2731 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2732 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2733 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2734 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2735 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2736 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2737 coff-pe-read.c, command.h, compile/compile-c-support.c,
2738 compile/compile-c.h, compile/compile-cplus-symbols.c,
2739 compile/compile-cplus-types.c, compile/compile-cplus.h,
2740 compile/compile-loc2c.c, compile/compile.c, completer.c,
2741 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2742 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2743 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2744 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2745 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2746 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2747 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2748 features/aarch64-core.c, features/aarch64-fpu.c,
2749 features/aarch64-pauth.c, features/aarch64-sve.c,
2750 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2751 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2752 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2753 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2754 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2755 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2756 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2757 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2758 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2759 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2760 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2761 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2762 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2763 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2764 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2765 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2766 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2767 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2768 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2769 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2770 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2771 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2772 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2773 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2774 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2775 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2776 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2777 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2778 minsyms.c, mips-linux-tdep.c, namespace.h,
2779 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2780 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2781 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2782 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2783 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2784 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2785 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2786 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2787 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2788 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2789 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2790 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2791 procfs.c, producer.c, progspace.h, psymtab.h,
2792 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2793 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2794 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2795 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2796 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2797 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2798 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2799 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2800 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2801 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2802 target-memory.c, target.c, target.h, target/waitstatus.c,
2803 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2804 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2805 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2806 unittests/array-view-selftests.c,
2807 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2808 unittests/common-utils-selftests.c,
2809 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2810 unittests/format_pieces-selftests.c,
2811 unittests/function-view-selftests.c,
2812 unittests/lookup_name_info-selftests.c,
2813 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2814 unittests/mkdir-recursive-selftests.c,
2815 unittests/observable-selftests.c,
2816 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2817 unittests/parse-connection-spec-selftests.c,
2818 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2819 unittests/scoped_fd-selftests.c,
2820 unittests/scoped_mmap-selftests.c,
2821 unittests/scoped_restore-selftests.c,
2822 unittests/string_view-selftests.c, unittests/style-selftests.c,
2823 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2824 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2825 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2826 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2827 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2828 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2830 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2832 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2834 (decode_digits_ordinary): Set explicit_line field in sal.
2835 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2836 symtab_and_line that was set on an explicit line number in
2837 assembler code. Do always update the recorded symtab and line if
2838 we do skip the prologue.
2840 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2842 * breakpoint.c (set_breakpoint_location_function): Remove
2843 explicit_loc parameter.
2844 (momentary_breakpoint_from_master): Update call to
2845 set_breakpoint_location_function.
2846 (add_location_to_breakpoint): Likewise.
2848 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2850 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2851 required features based on default bfd type when no specific bfd
2854 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2856 * NEWS: Mention that GDB printf and eval commands can now print
2857 C-style and Ada-style convenience var strings without
2858 calling the inferior.
2859 * printcmd.c (printf_c_string): Locally print GDB internal var
2860 instead of transiting via the inferior.
2861 (printf_wide_c_string): Likewise.
2863 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2865 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2867 2019-07-04 Tom Tromey <tom@tromey.com>
2870 * tui/tui-winsource.c (tui_clear_source_content): Update.
2871 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2872 (tui_update_breakpoint_info): Update.
2873 (tui_set_exec_info_content): Update.
2874 * tui/tui-source.c (tui_set_source_content_nil): Update.
2875 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2877 * tui/tui-data.h (enum tui_bp_flag): New.
2878 (tui_bp_flags): New enum flags type.
2879 (struct tui_source_element) <break_mode>: Change type. Rename
2881 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2882 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2884 * tui/tui-winsource.h: Fix comment.
2886 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2888 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2889 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2890 (store_fpregs_to_thread)
2891 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2892 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2893 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2894 (IWMMXT_REGS_SIZE): Add define.
2895 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2896 (fetch_vfp_regs, store_vfp_regs)
2897 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2898 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2900 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2902 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2904 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2905 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2906 (ARM_INT_REGISTER_SIZE): ...to this.
2907 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2908 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2909 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2910 (arm_linux_collect_gregset, supply_nwfpe_register)
2911 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2913 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2914 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2915 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2916 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2917 (arm_return_in_memory, arm_store_return_value)
2918 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2919 (arm_record_ld_st_multiple): Likewise.
2920 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2921 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2923 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2925 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2926 AARCH64_DISPLACED_MODIFIED_INSNS.
2927 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2928 (aarch64_displaced_step_copy_insn): Likewise.
2929 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2930 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2931 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2932 ARM_DISPLACED_MODIFIED_INSNS.
2933 * arm-tdep.c (arm_gdbarch_init): Likewise.
2934 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2935 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2936 (struct arm_displaced_step_closure): Use
2937 ARM_DISPLACED_MODIFIED_INSNS.
2939 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2941 * features/Makefile: Remove unused xml files.
2942 * features/aarch64.xml: Remove.
2943 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2944 * features/i386/amd64-avx-avx512.xml: Remove.
2945 * features/i386/amd64-avx-linux.xml: Remove.
2946 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2947 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2948 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2949 * features/i386/amd64-avx-mpx.xml: Remove.
2950 * features/i386/amd64-avx.xml: Remove.
2951 * features/i386/amd64-linux.xml: Remove.
2952 * features/i386/amd64-mpx-linux.xml: Remove.
2953 * features/i386/amd64-mpx.xml: Remove.
2954 * features/i386/amd64.xml: Remove.
2955 * features/i386/i386-avx-avx512-linux.xml: Remove.
2956 * features/i386/i386-avx-avx512.xml: Remove.
2957 * features/i386/i386-avx-linux.xml: Remove.
2958 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2959 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2960 * features/i386/i386-avx-mpx-linux.xml: Remove.
2961 * features/i386/i386-avx-mpx.xml: Remove.
2962 * features/i386/i386-avx.xml: Remove.
2963 * features/i386/i386-linux.xml: Remove.
2964 * features/i386/i386-mmx-linux.xml: Remove.
2965 * features/i386/i386-mmx.xml: Remove.
2966 * features/i386/i386-mpx-linux.xml: Remove.
2967 * features/i386/i386-mpx.xml: Remove.
2968 * features/i386/i386.xml: Remove.
2969 * features/i386/x32-avx-avx512-linux.xml: Remove.
2970 * features/i386/x32-avx-linux.xml: Remove.
2971 * features/i386/x32-linux.xml: Remove.
2973 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2975 * regformats/aarch64.dat: Remove.
2976 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2977 * regformats/i386/amd64-avx-linux.dat: Remove.
2978 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2979 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2980 * regformats/i386/amd64-linux.dat: Remove.
2981 * regformats/i386/amd64-mpx-linux.dat: Remove.
2982 * regformats/i386/amd64.dat: Remove.
2983 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2984 * regformats/i386/i386-avx-linux.dat: Remove.
2985 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2986 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2987 * regformats/i386/i386-linux.dat: Remove.
2988 * regformats/i386/i386-mmx-linux.dat: Remove.
2989 * regformats/i386/i386-mpx-linux.dat: Remove.
2990 * regformats/i386/i386.dat: Remove.
2991 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2992 * regformats/i386/x32-avx-linux.dat: Remove.
2993 * regformats/i386/x32-linux.dat: Remove.
2995 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2997 * aarch64-tdep.c: Remove xml self tests.
2998 * amd64-linux-tdep.c: Likewise.
2999 * amd64-tdep.c: Likewise.
3000 * i386-linux-tdep.c: Likewise.
3001 * i386-tdep.c: Likewise.
3003 2019-07-03 Pedro Alves <palves@redhat.com>
3006 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3007 (pipe_cmd_option_defs): New.
3008 (make_pipe_cmd_options_def_group): New.
3009 (pipe_command): Use gdb::option::process_options.
3010 (pipe_command_completer): New function.
3011 (_initialize_cli_cmds): Install completer for "pipe" command.
3013 2019-07-03 Pedro Alves <palves@redhat.com>
3015 * cli/cli-option.c (union option_value) <string>: New field.
3016 (struct option_def_and_value): Add ctor, move ctor, dtor and
3017 use DISABLE_COPY_AND_ASSIGN.
3018 (option_def_and_value::clear_value): New.
3019 (parse_option, save_option_value_in_ctx, get_val_type_str)
3020 (add_setshow_cmds_for_options): Handle var_string.
3021 * cli-option.h (union option_def::var_address) <string>: New
3023 (struct string_option_def): New.
3024 * maint-test-options.c (struct test_options_opts): Add default
3025 ctor and use DISABLE_COPY_AND_ASSIGN.
3026 <string_opt>: New field.
3027 (test_options_opts::~test_options_opts): New.
3028 (test_options_opts::dump): Also dump "-string".
3029 (test_options_option_defs): Install "string.
3031 2019-07-03 Pedro Alves <palves@redhat.com>
3033 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3034 option_value with a null enumeration.
3035 (complete_options): Save the option values in the context.
3036 (save_option_value_in_ctx): New, factored out from ...
3037 (process_options): ... here.
3038 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3040 * maint-test-options.c (test_options_opts::dump): New, factored
3042 (maintenance_test_options_command_mode): ... here.
3043 (maintenance_test_options_command_completion_result): Delete.
3044 (maintenance_test_options_command_completion_text): Update
3046 (maintenance_show_test_options_completion_result): Change
3047 prototype. Just print
3048 maintenance_test_options_command_completion_text.
3049 (save_completion_result): New.
3050 (maintenance_test_options_completer_mode): Pass options context to
3051 complete_options, and then save a dump.
3052 (_initialize_maint_test_options): Use add_cmd to install "maint
3053 show test-options-completion-result".
3055 2019-07-03 Pedro Alves <palves@redhat.com>
3057 * NEWS (New commands): Mention "with" and "maint with".
3058 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3059 (with_command, with_command_completer): New.
3060 (pipe_command): Adjust to new repeat_previous
3062 (_initialize_cli_cmds): Install the "with" command and its "w"
3064 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3066 * cli/cli-setshow.c (parse_cli_var_uinteger)
3067 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3068 argument strings for all var_types.
3069 (get_setshow_command_value_string): New, factored out from ...
3070 (do_show_command): ... this.
3071 * cli/cli-setshow.h: Include <string>.
3072 (get_setshow_command_value_string): Declare.
3073 * command.h (repeat_previous): Now returns const char *. Adjust
3075 * maint.c: Include "cli/cli-cmds.h".
3076 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3077 (_initialize_maint_cmds): Register the "maintenance with" command.
3078 * top.c (repeat_previous): Move bits from pipe_command here:
3079 Return the saved command line, if any; error out if there's no
3080 command to relaunch.
3082 2019-07-03 Pedro Alves <palves@redhat.com>
3084 * NEWS (New commands): Mention "maint set/show test-settings"
3085 instead of "maint test-settings".
3086 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3087 (maintenance_test_settings_set_list): Rename to ...
3088 (maintenance_set_test_settings_list): ... this.
3089 (maintenance_test_settings_show_list): Rename to ...
3090 (maintenance_show_test_settings_list): ... this.
3091 (maintenance_test_settings_cmd): Delete.
3092 (maintenance_test_settings_set_cmd): ...
3093 (maintenance_set_test_settings_cmd): ... this.
3094 (maintenance_test_settings_show_cmd): ...
3095 (maintenance_show_test_settings_cmd): ... this.
3096 (maintenance_test_settings_show_value_cmd):
3097 (maintenance_show_test_settings_value_cmd): ... this.
3098 (_initialize_maint_test_settings): No longer install the "maint
3099 test-settings" prefix command. Rename "maint test-settings set"
3100 to "maint set test-settings", and "maint test-settings show" to
3101 "maint show test-settings". Adjust all subcommands.
3103 2019-07-03 Pedro Alves <palves@redhat.com>
3105 * maint-test-settings.c: Fix file's intro comment. Replace all
3106 references to "test-options" with references to "test-settings",
3109 2019-07-03 Pedro Alves <palves@redhat.com>
3111 * maint-test-settings.c (maintenance_test_settings_xxx)
3112 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3114 (maintenance_test_settings_enums): Use them.
3115 (maintenance_test_settings_enum): Default to
3116 maintenance_test_settings_xxx.
3117 (_initialize_maint_test_settings): Initialize
3118 MAINTENANCE_TEST_SETTINGS_FILENAME.
3120 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3122 * breakpoint.h (remove_breakpoints_inf): Change return type to
3123 void, move function documentation here.
3124 * breakpoint.c (remove_breakpoints_inf): Change return type to
3125 void, move function documentation to header.
3127 2019-07-02 Pedro Alves <palves@redhat.com>
3129 * NEWS (Completion improvements): Mention "info threads".
3130 * thread.c (struct info_threads_opts, info_threads_option_defs)
3131 (make_info_threads_options_def_group): New.
3132 (info_threads_command): Use gdb::option::process_options.
3133 (info_threads_command_completer): New.
3134 (_initialize_thread): Use gdb::option::build_help to build the
3135 help text for "info threads".
3137 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3139 * defs.h (generic_load): Move from here...
3140 * symfile.h (generic_load): ... to here. Rename name parameter
3142 * symfile.c (generic_load): Add comment.
3144 2019-07-01 Tom Tromey <tromey@adacore.com>
3147 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3148 declaration of without_params. Fix formatting.
3150 2019-07-01 Tom Tromey <tromey@adacore.com>
3152 * ada-exp.y (find_primitive_type): Update.
3153 * ada-lang.h (ada_lookup_symbol): Update.
3154 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3156 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3158 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3160 PR breakpoints/24541
3161 * gdbarch.c: Regenerate.
3162 * gdbarch.h: Regenerate.
3163 * gdbarch.sh: Add 'stap_adjust_register'.
3164 * i386-tdep.c: Include '<unordered_set>'.
3165 (i386_stap_adjust_register): New function.
3166 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3167 * stap-probe.c (stap_parse_register_operand): Call
3168 'gdbarch_stap_adjust_register'.
3170 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3173 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3174 * python/python.c (do_start_initialization): Use 'xmalloc'
3175 instead of 'PyMem_Malloc'.
3177 2019-06-28 Tom Tromey <tromey@adacore.com>
3179 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3182 2019-06-27 Tom Tromey <tromey@adacore.com>
3184 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3186 (arm_find_mapping_symbol, arm_record_special_symbol)
3187 (_initialize_arm_tdep): Update.
3188 (arm_objfile_data_free): Remove.
3190 2019-06-27 Tom Tromey <tromey@adacore.com>
3192 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3193 to cp_print_static_field.
3195 2019-06-26 Tom Tromey <tromey@adacore.com>
3197 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3198 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3201 2019-06-26 Alan Hayward <alan.hayward@arm.com>
3203 * features/aarch64-core.c (create_feature_aarch64_core):
3205 * features/aarch64-core.xml: Add cpsr flags.
3207 2019-06-26 Alan Hayward <alan.hayward@arm.com>
3209 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3210 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3212 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3214 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3216 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3218 (arm_record_special_symbol): Don't insert new symbol in sorted
3219 position, push it at the end.
3221 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3223 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3224 (arm_mapping_symbol_s): Remove.
3225 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3226 (arm_mapping_symbol_vec): New typedef.
3227 (struct arm_per_objfile): Add constructor.
3228 <section_maps>: Change type to
3229 std::unique_ptr<arm_mapping_symbol_vec[]>.
3230 (arm_compare_mapping_symbols): Remove.
3231 (arm_find_mapping_symbol): Adjust to section_maps type change.
3232 (arm_objfile_data_free): Call delete on arm_per_objfile.
3233 (arm_record_special_symbol): Adjust to section_maps type change.
3234 Allocate arm_per_objfile with new.
3236 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3238 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3239 with the command prefix.
3241 2019-06-25 Tom Tromey <tom@tromey.com>
3243 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3244 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3246 2019-06-25 Tom Tromey <tom@tromey.com>
3248 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3250 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3253 2019-06-25 Tom Tromey <tom@tromey.com>
3255 * tui/tui-winsource.c
3256 (tui_source_window_base::set_is_exec_point_at): Add check against
3259 2019-06-25 Tom Tromey <tom@tromey.com>
3261 * tui/tui-source.c (tui_set_source_content): Don't check before
3263 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3265 2019-06-25 Tom Tromey <tom@tromey.com>
3267 * tui/tui-winsource.h (tui_update_source_window_as_is)
3268 (tui_alloc_source_buffer, tui_line_is_displayed)
3269 (tui_addr_is_displayed): Change type of win_info.
3270 * tui/tui-winsource.c (tui_update_source_window_as_is)
3271 (tui_clear_source_content, tui_show_source_line)
3272 (tui_show_source_content, tui_source_window_base::refill)
3273 (tui_source_window_base::set_is_exec_point_at)
3274 (tui_source_window_base::set_is_exec_point_at)
3275 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3276 (tui_alloc_source_buffer, tui_line_is_displayed)
3277 (tui_addr_is_displayed): Change type of win_info. Update.
3278 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3279 (tui_source_window_base::do_make_visible_with_new_height):
3281 * tui/tui-source.c (tui_set_source_content)
3282 (tui_set_source_content_nil)
3283 (tui_source_window::do_scroll_vertical): Update.
3284 * tui/tui-layout.c (show_layout): Update.
3285 * tui/tui-disasm.c (tui_set_disassem_content)
3286 (tui_disasm_window::do_scroll_vertical): Update.
3287 * tui/tui-data.h (tui_win_content): Remove.
3288 (struct tui_gen_win_info) <content, content_size>: Remove.
3289 (struct tui_source_element): Add initializers and destructor.
3290 (union tui_which_element, struct tui_win_element): Remove.
3291 (struct tui_source_window_base) <content>: New field.
3292 (struct tui_data_window): Remove destructor.
3293 (tui_alloc_content, tui_free_win_content)
3294 (tui_free_all_source_wins_content): Don't declare.
3295 * tui/tui-data.c (tui_initialize_static_data): Update.
3296 (init_content_element, tui_alloc_content): Remove.
3297 (~tui_gen_win_info): Update.
3298 (~tui_data_window, tui_free_all_source_wins_content)
3299 (tui_free_win_content, free_content, free_content_elements):
3302 2019-06-25 Tom Tromey <tom@tromey.com>
3304 * tui/tui-winsource.h (tui_clear_source_content)
3305 (tui_erase_source_content, tui_show_source_content): Change type
3307 * tui/tui-winsource.c (tui_clear_source_content)
3308 (tui_erase_source_content, tui_show_source_content): Change type
3310 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3311 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3313 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3315 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3317 2019-06-25 Tom Tromey <tom@tromey.com>
3319 * tui/tui-winsource.c (tui_clear_source_content)
3320 (tui_source_window_base::set_is_exec_point_at): Update.
3321 * tui/tui-source.c (tui_set_source_content_nil): Update.
3322 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3324 * tui/tui-data.c (init_content_element): Update.
3326 2019-06-25 Tom Tromey <tom@tromey.com>
3328 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3329 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3330 * tui/tui-layout.c (init_and_make_win): Update.
3331 * tui/tui.h (enum tui_win_type): Update.
3332 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3333 tui_win_is_auxillary.
3334 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3335 tui_win_is_auxillary.
3337 2019-06-25 Tom Tromey <tom@tromey.com>
3339 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3340 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3341 (tui_delete_data_content_windows, tui_display_all_data)
3342 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3344 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3345 * tui/tui-regs.c (tui_last_regs_line_no)
3346 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3347 (tui_show_registers): Update.
3348 (tui_show_register_group): Return void. Update.
3349 (tui_display_registers_from, tui_display_reg_element_at_line)
3350 (tui_display_registers_from_line, tui_check_register_values):
3352 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3354 (struct tui_data_window) <regs_content>: Now a std::vector.
3355 <regs_content_count>: Remove.
3356 (tui_add_content_elements, tui_free_data_content): Don't declare.
3357 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3358 (init_content_element): Remove DATA_WIN case. Add assert.
3359 (tui_add_content_elements): Remove.
3360 (tui_data_window): Update.
3361 (tui_free_data_content): Remove.
3362 (free_content_elements): Remove DATA_WIN case.
3364 2019-06-25 Tom Tromey <tom@tromey.com>
3366 * tui/tui-data.c (tui_data_item_window): Update.
3367 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3368 * tui/tui-windata.c (tui_display_all_data)
3369 (tui_display_data_from_line): Update.
3370 (tui_check_data_values): Remove.
3371 * tui/tui-regs.c (tui_show_register_group)
3372 (tui_display_reg_element_at_line): Update.
3373 * tui/tui-hooks.c (tui_register_changed)
3374 (tui_refresh_frame_and_register_information): Call
3375 tui_check_register_values.
3376 * tui/tui-data.h (struct tui_data_window) <data_content,
3377 data_content_count, data_type>: Remove.
3378 (enum tui_data_type): Remove.
3380 * tui/tui-data.c (tui_data_window::clear_detail)
3381 (~tui_data_window): Update.
3383 2019-06-25 Tom Tromey <tom@tromey.com>
3385 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3387 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3388 Rename from tui_first_data_item_displayed. Update.
3389 (tui_data_window::refresh_all)
3390 (tui_data_window::do_scroll_vertical): Update.
3391 * tui/tui-data.h (struct tui_data_window)
3392 <first_data_item_displayed>: Declare new method.
3394 2019-06-25 Tom Tromey <tom@tromey.com>
3396 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3397 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3399 (tui_initialize_static_data): ...here.
3401 2019-06-25 Tom Tromey <tom@tromey.com>
3403 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3404 (tui_display_registers_from, tui_check_register_values): Update.
3405 (tui_display_register): Remove win_info parameter; update.
3406 (tui_get_register): Change type of parameters.
3407 * tui/tui-data.h (struct tui_data_element): Remove.
3408 (union tui_which_element) <data>: Remove.
3409 <data_window>: Change type.
3410 (struct tui_data_item_window): New.
3411 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3413 (~tui_data_item_window): New destructor.
3414 (free_content_elements): Remove DATA_ITEM_WIN case.
3416 2019-06-25 Tom Tromey <tom@tromey.com>
3418 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3421 2019-06-25 Tom Tromey <tom@tromey.com>
3423 * tui/tui-data.h (struct tui_command_element): Remove.
3424 (union tui_which_element) <command>: Remove.
3425 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3427 (free_content_elements): Remove CMD_WIN case.
3429 2019-06-25 Tom Tromey <tom@tromey.com>
3431 * tui/tui-layout.c (tui_set_layout): Update.
3432 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3433 * tui/tui-data.c (layout_def): Update.
3435 2019-06-25 Tom Tromey <tom@tromey.com>
3437 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3438 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3439 (tui_source_window_base::set_new_height): Update.
3440 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3442 (tui_set_locator_fullname, tui_set_locator_info)
3443 (tui_show_frame_info): Update.
3444 * tui/tui-source.c (tui_set_source_content)
3445 (tui_source_is_displayed): Update.
3446 * tui/tui-layout.c (show_source_disasm_command, show_data)
3447 (show_source_or_disasm_and_command): Update.
3448 * tui/tui-disasm.c (tui_set_disassem_content)
3449 (tui_get_begin_asm_address): Update.
3450 * tui/tui-data.h (struct tui_locator_element): Remove.
3451 (union tui_which_element) <locator>: Remove.
3452 (struct tui_locator_window): New.
3453 (tui_locator_win_info_ptr): Change return type.
3454 * tui/tui-data.c (_locator): Change type.
3455 (tui_locator_win_info_ptr): Change return type.
3456 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3457 (tui_alloc_content): Add assert.
3459 2019-06-25 Tom Tromey <tom@tromey.com>
3461 * tui/tui-winsource.c
3462 (tui_exec_info_window::maybe_allocate_content): New method.
3463 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3464 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3465 (make_source_or_disasm_window): Add cast.
3466 * tui/tui-data.h (union tui_which_element) <simple_string>:
3468 (struct tui_source_info): New.
3469 (struct tui_source_window_base) <execution_info>: Change type.
3470 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3471 case, and add assert.
3472 (tui_alloc_content): Add assert.
3474 2019-06-25 Tom Tromey <tom@tromey.com>
3476 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3477 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3478 * tui/tui-data.c (tui_alloc_win_info): Remove.
3480 2019-06-25 Tom Tromey <tom@tromey.com>
3482 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3483 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3486 2019-06-25 Tom Tromey <tom@tromey.com>
3488 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3489 make_visible_with_new_height method.
3490 (tui_win_info::make_visible_with_new_height): New method.
3491 (tui_source_window_base::do_make_visible_with_new_height)
3492 (tui_data_window::do_make_visible_with_new_height)
3493 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3494 (make_visible_with_new_height): Remove.
3495 (tui_resize_all, tui_adjust_win_heights): Use
3496 make_visible_with_new_height method.
3497 * tui/tui-data.h (struct tui_win_info)
3498 <do_make_visible_with_new_height, make_visible_with_new_height>:
3500 (struct tui_source_window_base, struct tui_data_window)
3501 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3504 2019-06-25 Tom Tromey <tom@tromey.com>
3506 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3508 (update_tab_width): Call update_tab_width method.
3509 * tui/tui-data.h (struct tui_win_info)
3510 (struct tui_source_window_base) <update_tab_width>: New methods.
3512 2019-06-25 Tom Tromey <tom@tromey.com>
3514 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3516 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3518 (tui_gen_win_info::make_visible): Update.
3519 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3521 * tui/tui-data.h (enum tui_box): New enum.
3522 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3524 2019-06-25 Tom Tromey <tom@tromey.com>
3526 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3527 init_and_make_win for EXEC_INFO_WIN.
3528 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3530 (struct tui_win_info) <~tui_win_info>: Inline.
3531 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3533 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3534 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3536 (tui_initialize_static_data): Update.
3537 (~tui_gen_win_info): Handle more cleanup here.
3538 (~tui_source_window_base): Delete "execution_info".
3539 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3541 2019-06-25 Tom Tromey <tom@tromey.com>
3543 * tui/tui-layout.c (make_command_window): Don't set
3545 (show_source_disasm_command): Call the reset method.
3546 (show_data): Don't set can_highlight. Call the reset method.
3547 (tui_gen_win_info::reset): Rename from init_gen_win_info
3548 (init_and_make_win): Simplify. Return tui_gen_win_info.
3549 (show_source_or_disasm_and_command): Call the reset method.
3550 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3551 (struct tui_cmd_window): Set can_highlight.
3553 2019-06-25 Tom Tromey <tom@tromey.com>
3555 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3557 (tui_make_visible, tui_make_invisible): Rewrite.
3558 (tui_win_info::make_visible): Remove.
3559 (tui_source_window_base::make_visible): Update.
3560 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3561 method. Moved from...
3562 (struct tui_win_info) <make_visible>: ...here.
3564 2019-06-25 Tom Tromey <tom@tromey.com>
3566 * tui/tui-winsource.c
3567 (tui_source_window_base::do_scroll_horizontal): Remove direction
3569 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3570 direction parameter.
3571 * tui/tui-win.c (tui_win_info::forward_scroll)
3572 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3573 (tui_win_info::right_scroll): Update.
3574 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3575 direction parameter.
3576 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3577 direction parameter.
3578 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3579 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3580 Remove direction parameter.
3581 (struct tui_source_window_base, struct tui_source_window)
3582 (struct tui_disasm_window, struct tui_data_window)
3583 (struct tui_cmd_window): Update.
3585 2019-06-25 Tom Tromey <tom@tromey.com>
3587 * tui/tui-winsource.h (tui_set_exec_info_content)
3588 (tui_show_exec_info_content, tui_erase_exec_info_content)
3589 (tui_clear_exec_info_content, tui_update_exec_info): Change
3590 argument to tui_source_window_base.
3591 * tui/tui-winsource.c (tui_set_exec_info_content)
3592 (tui_show_exec_info_content, tui_erase_exec_info_content)
3593 (tui_clear_exec_info_content, tui_update_exec_info): Change
3594 argument to tui_source_window_base.
3596 2019-06-25 Tom Tromey <tom@tromey.com>
3598 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3599 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3601 2019-06-25 Tom Tromey <tom@tromey.com>
3603 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3606 2019-06-25 Tom Tromey <tom@tromey.com>
3608 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3610 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3612 * tui/tui-source.c (tui_set_source_content): Update.
3613 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3615 2019-06-25 Tom Tromey <tom@tromey.com>
3617 * tui/tui-win.c (window_name_completer, tui_set_focus)
3618 (tui_all_windows_info): Use name method.
3619 * tui/tui-data.h (struct tui_gen_win_info)
3620 (struct tui_source_window, struct tui_disasm_window)
3621 (struct tui_data_window, struct tui_cmd_window) <name>: New
3623 (tui_win_name): Don't declare.
3624 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3625 (tui_win_name): Remove.
3627 2019-06-25 Tom Tromey <tom@tromey.com>
3629 * tui/tui-winsource.h (tui_update_source_window)
3630 (tui_update_source_window_as_is): Change parameter type.
3631 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3632 to be a tui_source_window_base.
3633 (tui_update_source_window_as_is): Likewise.
3634 * tui/tui-win.c (make_visible_with_new_height): Update.
3636 2019-06-25 Tom Tromey <tom@tromey.com>
3638 * tui/tui-winsource.c (tui_erase_source_content)
3639 (tui_show_source_content, tui_show_exec_info_content)
3640 (tui_erase_exec_info_content): Use refresh_window method.
3641 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3642 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3643 from tui_refresh_win.
3644 (tui_data_window::refresh_window): New method.
3645 (tui_win_info::refresh, tui_source_window_base::refresh)
3646 (tui_refresh_all): Use refresh_window method.
3647 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3649 * tui/tui-regs.c (tui_display_register): Call refresh_window
3651 * tui/tui-layout.c (show_source_disasm_command)
3652 (show_source_or_disasm_and_command): Call refresh_window method.
3653 * tui/tui-data.h (struct tui_gen_win_info)
3654 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3657 2019-06-25 Tom Tromey <tom@tromey.com>
3659 * tui/tui.c (tui_rl_other_window, tui_enable)
3660 (tui_is_window_visible, tui_get_command_dimension): Update.
3661 * tui/tui-winsource.c (tui_update_source_window_as_is)
3662 (tui_clear_source_content, tui_erase_source_content)
3663 (tui_show_source_line, tui_source_window_base::refill)
3664 (tui_source_window_base::do_scroll_horizontal)
3665 (tui_source_window_base::set_is_exec_point_at)
3666 (tui_update_breakpoint_info, tui_set_exec_info_content)
3667 (tui_alloc_source_buffer, tui_line_is_displayed)
3668 (tui_addr_is_displayed): Update.
3669 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3670 (tui_check_and_display_highlight_if_needed)
3671 (tui_win_info::make_visible, tui_win_info::refresh)
3672 (tui_refresh_all): Update.
3673 * tui/tui-windata.c (tui_first_data_item_displayed)
3674 (tui_delete_data_content_windows, tui_erase_data_content)
3675 (tui_display_all_data, tui_data_window::refresh_all)
3676 (tui_check_data_values): Update.
3677 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3678 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3679 (tui_win_info::backward_scroll, tui_refresh_all_win)
3680 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3681 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3682 (tui_source_window_base::set_new_height)
3683 (tui_data_window::set_new_height)
3684 (make_invisible_and_set_new_height)
3685 (make_visible_with_new_height, new_height_ok)
3686 (parse_scrolling_args): Update.
3687 * tui/tui-stack.c (tui_show_frame_info): Update.
3688 * tui/tui-source.c (tui_set_source_content)
3689 (tui_set_source_content_nil, tui_source_is_displayed)
3690 (tui_source_window::do_scroll_vertical): Update.
3691 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3692 (tui_display_registers_from, tui_display_reg_element_at_line)
3693 (tui_check_register_values, tui_reg_command): Update.
3694 * tui/tui-layout.c (tui_default_win_height)
3695 (show_source_disasm_command, show_data, init_and_make_win)
3696 (show_source_or_disasm_and_command): Update.
3697 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3698 (tui_redisplay_readline, tui_mld_flush)
3699 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3701 * tui/tui-disasm.c (tui_set_disassem_content)
3702 (tui_disasm_window::do_scroll_vertical): Update.
3703 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3705 (struct tui_win_info): Derive from tui_gen_win_info.
3706 <~tui_win_info>: Mark as override.
3707 <generic>: Remove member.
3708 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3709 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3710 (~tui_data_window, ~tui_win_info)
3711 (tui_free_all_source_wins_content): Update.
3712 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3714 2019-06-25 Tom Tromey <tom@tromey.com>
3716 * tui/tui-layout.c (init_and_make_win): Use new.
3717 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3718 destructor, initializers.
3719 (tui_alloc_generic_win_info): Don't declare.
3720 * tui/tui-data.c (_locator): Add argument to constructor.
3721 (source_win, disasm_win): New globals.
3722 (exec_info): Remove.
3723 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3725 (tui_alloc_generic_win_info): Remove.
3726 (init_content_element): Use new.
3727 (tui_win_info::tui_win_info): Update.
3728 (free_content_elements) <case DATA_WIN>: Use delete.
3730 2019-06-25 Tom Tromey <tom@tromey.com>
3732 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3733 * tui/tui-windata.c (tui_first_data_item_displayed)
3734 (tui_delete_data_content_windows): Update.
3735 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3736 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3737 (tui_display_registers_from, tui_check_register_values): Update.
3738 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3740 * tui/tui-data.c (init_content_element): Update. Allocate the new
3742 (tui_free_data_content): Update.
3743 (free_content_elements) <case DATA_WIN>: Free the window.
3745 2019-06-25 Tom Tromey <tom@tromey.com>
3747 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3749 * tui/tui-layout.c (make_command_window)
3750 (show_source_disasm_command, show_data, init_and_make_win)
3751 (show_source_or_disasm_and_command): Update.
3752 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3754 <can_highight, is_highlighted>: Now bool.
3755 (tui_set_win_highlight): Don't declare.
3756 * tui/tui-data.c (tui_set_win_highlight): Remove.
3758 2019-06-25 Tom Tromey <tom@tromey.com>
3760 * tui/tui-wingeneral.c (make_visible): Remove check of window
3763 2019-06-25 Tom Tromey <tom@tromey.com>
3765 * tui/tui-win.c (tui_win_info::max_height)
3766 (tui_cmd_window::max_height): New methods.
3767 (new_height_ok): Call max_height.
3768 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3769 <max_height>: New method.
3771 2019-06-25 Tom Tromey <tom@tromey.com>
3773 * tui/tui-win.c (tui_source_window_base::set_new_height)
3774 (tui_data_window::set_new_height): New methods.
3775 (make_invisible_and_set_new_height): Call set_new_height method.
3776 * tui/tui-data.h (struct tui_win_info)
3777 (struct tui_source_window_base, struct tui_data_window)
3778 <set_new_height>: New method.
3780 2019-06-25 Tom Tromey <tom@tromey.com>
3782 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3783 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3784 tui_refresh_data_win.
3785 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3787 (tui_refresh_all_win): Call the refresh_all method.
3788 (tui_set_focus): Likewise.
3789 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3790 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3793 2019-06-25 Tom Tromey <tom@tromey.com>
3795 * tui/tui-winsource.h (tui_refill_source_window)
3796 (tui_set_is_exec_point_at): Don't declare.
3797 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3798 (tui_source_window_base::refill): Rename from
3799 tui_refill_source_window.
3800 (tui_source_window_base::do_scroll_horizontal): Update.
3801 (tui_source_window_base::set_is_exec_point_at): Rename from
3802 tui_set_is_exec_point_at.
3803 (tui_update_all_breakpoint_info): Update.
3804 * tui/tui-stack.c (tui_show_frame_info): Update.
3805 * tui/tui-layout.c (show_data): Add cast.
3806 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3807 * tui/tui-data.h (struct tui_source_window_base) <refill,
3808 set_is_exec_point_at>: New methods.
3809 (tui_source_windows, tui_add_to_source_windows): Update types.
3810 (tui_add_to_source_windows): Remove redundant declaration.
3811 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3812 (tui_source_windows): Change return type.
3813 (tui_clear_source_windows_detail): Update.
3814 (tui_add_to_source_windows): Change type of parameter.
3815 (tui_free_all_source_wins_content): Update.
3817 2019-06-25 Tom Tromey <tom@tromey.com>
3819 * tui/tui-wingeneral.c (tui_win_info::refresh)
3820 (tui_source_window_base::refresh): New methods.
3821 (tui_refresh_all): Call the refresh method.
3822 * tui/tui-data.h (struct tui_win_info)
3823 (struct tui_source_window_base) <refresh>: New method.
3825 2019-06-25 Tom Tromey <tom@tromey.com>
3827 * tui/tui.h (tui_is_window_visible): Return bool.
3828 * tui/tui.c (tui_is_window_visible): Return bool.
3829 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3830 (tui_make_visible, tui_make_invisible)
3831 (tui_win_info::make_visible)
3832 (tui_source_window_base::make_visible, make_all_visible)
3833 (tui_make_all_visible, tui_make_all_invisible): Update.
3834 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3835 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3837 (struct tui_win_info, struct tui_source_window_base)
3838 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3839 * tui/tui-data.c (tui_init_generic_part): Update.
3841 2019-06-25 Tom Tromey <tom@tromey.com>
3843 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3844 (tui_source_window_base::make_visible): New methods.
3845 (make_all_visible): Make method call.
3846 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3847 (struct tui_source_window_base, struct tui_cmd_window): Override
3849 (tui_win_is_source_type): Don't declare.
3850 * tui/tui-data.c (tui_win_is_source_type): Remove.
3852 2019-06-25 Tom Tromey <tom@tromey.com>
3854 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3857 2019-06-25 Tom Tromey <tom@tromey.com>
3859 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3860 Inline constructor. Add initializers for members.
3861 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3862 constructors; now inline in class.
3864 2019-06-25 Tom Tromey <tom@tromey.com>
3866 * tui/tui-regs.c (tui_show_registers): Update.
3867 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3869 * tui/tui-data.c (tui_data_window::clear_detail)
3870 (tui_data_window): Update.
3872 2019-06-25 Tom Tromey <tom@tromey.com>
3874 * tui/tui-windata.c (tui_display_all_data)
3875 (tui_display_data_from_line, tui_display_data_from)
3876 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3878 * tui/tui-regs.c (tui_last_regs_line_no)
3879 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3880 (tui_show_registers, tui_show_register_group)
3881 (tui_display_registers_from, tui_display_reg_element_at_line)
3882 (tui_display_registers_from_line, tui_check_register_values)
3883 (tui_reg_next, tui_reg_prev): Update.
3884 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3885 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3887 (struct tui_win_info) <detail>: Remove. Add new fields from
3889 (TUI_DATA_WIN): Add cast.
3890 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3891 (~tui_data_window): Simplify.
3893 2019-06-25 Tom Tromey <tom@tromey.com>
3895 * tui/tui-layout.c (show_source_disasm_command)
3896 (show_source_or_disasm_and_command): Update.
3897 * tui/tui-io.c (update_cmdwin_start_line)
3898 (tui_redisplay_readline): Update.
3899 * tui/tui-data.h (struct tui_command_info): Remove.
3900 (struct tui_win_info) <detail>: Remove command_info member.
3901 (struct tui_data_window) <start_line>: New member, from
3903 (TUI_CMD_WIN): Add casts.
3905 2019-06-25 Tom Tromey <tom@tromey.com>
3907 * tui/tui-winsource.c (tui_update_source_window)
3908 (tui_refill_source_window)
3909 (tui_source_window_base::do_scroll_horizontal)
3910 (tui_update_breakpoint_info, tui_set_exec_info_content)
3911 (tui_show_exec_info_content, tui_erase_exec_info_content)
3912 (tui_clear_exec_info_content): Update.
3913 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3915 * tui/tui-win.c (make_invisible_and_set_new_height)
3916 (make_visible_with_new_height): Update.
3917 * tui/tui-source.c (tui_set_source_content)
3918 (tui_show_symtab_source): Update.
3919 * tui/tui-layout.c (extract_display_start_addr)
3920 (show_source_disasm_command, show_data)
3921 (make_source_or_disasm_window)
3922 (show_source_or_disasm_and_command): Update.
3923 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3924 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3926 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3927 to tui_source_window_base.
3928 (struct tui_win_info) <detail>: Remove source_info member.
3929 (struct tui_source_window_base) <has_locator>: Inline.
3930 Move contents from tui_source_info; rename has_locator member to
3932 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3933 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3935 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3937 (tui_free_all_source_wins_content): Cast to
3938 tui_source_window_base.
3940 2019-06-25 Tom Tromey <tom@tromey.com>
3942 * tui/tui-win.c (make_invisible_and_set_new_height)
3943 (make_visible_with_new_height): Call has_locator method.
3944 * tui/tui-layout.c (show_source_disasm_command, show_data)
3945 (show_source_or_disasm_and_command): Update for bool change.
3946 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3947 (tui_win_info) <has_locator>: New method.
3948 (struct tui_source_window_base) <has_locator>: New method.
3949 (tui_win_has_locator): Don't declare.
3950 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3951 from tui_win_has_locator.
3952 (tui_source_window_base): Use false, not FALSE.
3954 2019-06-25 Tom Tromey <tom@tromey.com>
3956 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3957 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3958 clear_detail method directly.
3959 (tui_clear_win_detail): Remove.
3961 2019-06-25 Tom Tromey <tom@tromey.com>
3963 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3964 "this", not TUI_DISASM_WIN.
3966 2019-06-25 Tom Tromey <tom@tromey.com>
3968 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3970 * tui/tui-winsource.c
3971 (tui_source_window_base::do_scroll_horizontal): Rename from
3972 tui_horizontal_source_scroll.
3973 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3974 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3975 from tui_vertical_data_scroll.
3976 * tui/tui-win.h (tui_scroll): Don't declare.
3977 * tui/tui-win.c (tui_win_info::forward_scroll)
3978 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3979 (tui_win_info::right_scroll): Rename and update.
3980 (tui_scroll_forward_command, tui_scroll_backward_command)
3981 (tui_scroll_left_command, tui_scroll_right_command): Update.
3982 (tui_scroll): Remove.
3983 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3984 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3985 from tui_vertical_source_scroll.
3986 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3987 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3988 from tui_vertical_disassem_scroll.
3989 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3990 do_scroll_horizontal>: New methods.
3991 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3993 (struct tui_source_window_base): Add do_scroll_horizontal.
3994 (struct tui_source_window, struct tui_disasm_window): Add
3996 (struct tui_data_window, struct tui_cmd_window): Add
3997 do_scroll_horizontal and do_scroll_vertical.
3998 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4000 2019-06-25 Tom Tromey <tom@tromey.com>
4002 * tui/tui-data.h (struct tui_source_window_base): New struct.
4003 (struct tui_source_window): Derive from tui_source_window_base.
4004 (struct tui_disasm_window): New struct.
4005 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4006 from tui_source_window::clear_detail.
4007 (tui_source_window_base): Rename from tui_source_window.
4008 (~tui_source_window_base): Rename from ~tui_source_window.
4009 (tui_alloc_win_info): Create a tui_disasm_window.
4011 2019-06-25 Tom Tromey <tom@tromey.com>
4013 * tui/tui-data.h (struct tui_source_window)
4014 (struct tui_data_window): Declare destructors.
4015 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4017 (tui_win_info): Simplify.
4019 2019-06-25 Tom Tromey <tom@tromey.com>
4021 * tui/tui-winsource.c (tui_display_main)
4022 (tui_update_source_windows_with_addr)
4023 (tui_update_all_breakpoint_info): Update.
4024 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4025 (new_height_ok, parse_scrolling_args): Update.
4026 * tui/tui-stack.c (tui_show_frame_info): Update.
4027 * tui/tui-data.h (struct tui_list): Remove.
4028 (tui_source_windows): Return a reference to a std::vector.
4029 * tui/tui-data.c (source_windows): Now a std::vector.
4030 (tui_source_windows): Change return type.
4031 (tui_clear_source_windows): Rewrite.
4032 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4033 (tui_free_all_source_wins_content): Rewrite.
4035 2019-06-25 Tom Tromey <tom@tromey.com>
4037 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4038 (struct tui_data_window, struct tui_cmd_window): Declare
4039 clear_detail method.
4040 * tui/tui-data.c (tui_source_window::clear_detail)
4041 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4043 (tui_clear_win_detail): Simplify.
4045 2019-06-25 Tom Tromey <tom@tromey.com>
4047 * tui/tui-layout.c (make_source_window, make_disasm_window)
4048 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4049 Return the new window.
4050 (show_source_disasm_command, show_data)
4051 (show_source_or_disasm_and_command): Update.
4053 2019-06-25 Tom Tromey <tom@tromey.com>
4055 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4056 parameter. Return the new window.
4057 (show_source_disasm_command): Update and remove NULL check.
4058 (show_source_or_disasm_and_command): Update.
4060 2019-06-25 Tom Tromey <tom@tromey.com>
4062 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4064 2019-06-25 Tom Tromey <tom@tromey.com>
4066 * tui/tui-data.h (struct tui_win_info): Make constructor
4067 protected. Make destructor virtual. Add initializers.
4068 (tui_source_window, tui_data_window, tui_cmd_window): New
4070 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4071 constructor. Add "type" parameter.
4072 (tui_source_window, tui_data_window, tui_cmd_window): New
4074 (tui_alloc_win_info): Instantiate the appropriate subclass.
4076 2019-06-25 Tom Tromey <tom@tromey.com>
4078 * tui/tui-win.c (tui_resize_all): Use delete.
4079 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4081 (tui_free_window): Don't declare.
4082 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4085 2019-06-25 Tom Tromey <tom@tromey.com>
4087 * tui/tui-data.h (struct tui_win_info): Add constructor.
4088 * tui/tui-data.c (tui_alloc_win_info): Use new.
4089 (tui_free_window): Use delete.
4091 2019-06-22 Tom Tromey <tom@tromey.com>
4093 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4095 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4097 2019-06-22 Tom Tromey <tom@tromey.com>
4099 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4101 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4103 2019-06-22 Tom de Vries <tdevries@suse.de>
4105 * dwarf2read.c (create_addrmap_from_aranges)
4106 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4109 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
4111 * dwarf2read.h (dwarf2_section_info_def): Remove.
4112 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4113 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4114 std::vector<dwarf2_section_info>.
4115 (struct dwo_file) <~dwo_file>: Remove.
4116 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4118 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4119 (dwarf2_read_debug_names): Likewise.
4120 (create_debug_types_hash_table): Change parameter type to
4121 array_view, adjust code accordingly.
4122 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4123 (partial_die_info::fixup): Likewise.
4124 (determine_prefix): Likewise.
4125 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4127 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4129 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4131 <~dwo_file>: Remove call to gdb_bfd_unref.
4132 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4133 gdb_bfd_ref_ptr::get.
4135 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4137 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4139 * dwarf2read.c (struct dwo_file): Initialize fields.
4141 (free_dwo_file): Remove, move content to ~dwo_file.
4142 (struct dwo_file_deleter): Remove.
4143 (dwo_file_up>: Remove custom deleter.
4144 (free_dwo_files): Remove.
4145 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4147 (process_skeletonless_type_units): Call unique_ptr::get.
4148 (allocate_dwo_file_hash_table): Add deleter to created hash
4149 table. Change return type to htab_up.
4150 (lookup_dwo_file_slot): Don't memset dwo_file, call
4152 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4153 (create_dwo_unit_in_dwp_v2): Likewise.
4154 (open_and_init_dwo_file): Likewise.
4155 (free_dwo_file_from_slot): Remove.
4157 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4159 * dwarf2read.h (struct dwarf2_section_info) <readin,
4160 is_virtual>: Change type to bool.
4161 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4164 2019-06-19 Tom Tromey <tom@tromey.com>
4166 * tui/tui-data.h (tui_init_content_element): Don't declare.
4168 2019-06-19 Tom Tromey <tom@tromey.com>
4170 * tui/tui-data.h (tui_init_win_info): Don't declare.
4172 2019-06-19 Tom de Vries <tdevries@suse.de>
4174 * dwarf2read.h (abstract_to_concrete): Change type to
4175 std::unordered_map<sect_offset, std::vector<sect_offset>,
4176 gdb::hash_enum<sect_offset>>.
4178 2019-06-19 Tom Tromey <tromey@adacore.com>
4180 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4181 EVAL_AVOID_SIDE_EFFECTS specially.
4183 2019-06-19 Tom Tromey <tromey@adacore.com>
4185 * source-cache.c (highlighter): New global.
4186 (source_cache::get_source_lines): Create a highlighter on demand.
4188 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4190 * defs.h (deprecated_interactive_hook): Delete declaration.
4191 * interps.c (clear_interpreter_hooks): Remove use of
4192 deprecated_interactive_hook.
4193 * top.c (deprecated_interactive_hook): Delete definition.
4194 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4196 2019-06-18 Tom de Vries <tdevries@suse.de>
4199 * dwarf2read.h (abstract_to_concrete): Change type from
4200 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4201 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4202 * dwarf2read.c (read_variable): Update.
4203 (dwarf2_fetch_die_loc_sect_off): Update.
4205 2019-06-17 Tom de Vries <tdevries@suse.de>
4208 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4209 accessing parent[parent_len - 1].
4211 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4214 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4215 call dtrace_process_dof with NULL dof.
4217 2019-06-16 Tom de Vries <tdevries@suse.de>
4220 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4222 2019-06-16 Tom Tromey <tom@tromey.com>
4224 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4225 (make_all_visible): Use address of member.
4227 2019-06-16 Tom Tromey <tom@tromey.com>
4229 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4230 (tui_free_window, free_content, free_content_elements): Remove
4232 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4234 * tui/tui-regs.c (tui_show_register_group)
4235 (tui_display_registers_from, tui_display_reg_element_at_line):
4236 Remove unnecessary cast.
4238 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4240 * linux-nat.c (normal_mask): Delete.
4241 (_initialize_linux_nat): Don't initialise normal_mask.
4243 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4246 * dwarf-index-write.h (write_psymtabs_to_index): Add
4247 dwz_basename parameter.
4248 * dwarf-index-write.c (write_gdbindex): Move file writing to
4249 write_gdbindex_1. Change return type void.
4250 (assert_file_size): Move up, remove filename parameter.
4251 (write_gdbindex_1): New function.
4252 (write_debug_names): Change return type to void, call
4254 (struct index_wip_file): New struct.
4255 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4256 file logic to index_wip_file. Write index for dwz file if
4258 (save_gdb_index_command): Pass basename of dwz file, if present.
4259 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4260 build-id of dwz file, if present.
4261 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4262 (dwarf2_get_dwz_file): Likewise.
4263 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4264 (dwarf2_get_dwz_file): Likewise.
4266 2019-06-16 Tom Tromey <tom@tromey.com>
4268 * coffread.c (process_coff_symbol): Use xstrdup.
4269 * value.c (create_internalvar): Use xstrdup.
4271 2019-06-16 Tom Tromey <tom@tromey.com>
4273 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4274 * breakpoint.c (stopin_command, stopat_command)
4275 (until_break_command, decode_location_default): Remove unnecessary
4277 * utils.c (subset_compare): Remove unnecessary cast.
4278 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4280 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4282 * infcmd.c (path_command): Remove unnecessary cast.
4283 * coffread.c (decode_type): Remove unnecessary cast.
4284 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4285 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4286 * tui/tui-stack.c (tui_show_locator_content)
4287 (tui_show_frame_info): Remove unnecessary cast.
4288 * tui/tui-win.c (tui_scroll_forward_command)
4289 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4290 (parse_scrolling_args): Remove unnecessary cast.
4291 * tui/tui-data.c (init_win_info, tui_del_window)
4292 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4293 (free_content_elements): Remove unnecessary cast.
4294 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4296 * tui/tui-source.c (tui_set_source_content)
4297 (tui_vertical_source_scroll): Remove unnecessary cast.
4298 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4300 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4301 * tui/tui-regs.c (tui_display_registers_from)
4302 (tui_display_register): Remove unnecessary cast.
4303 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4304 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4305 (make_visible): Remove unnecessary cast.
4306 * tui/tui-winsource.c (tui_erase_source_content)
4307 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4309 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4310 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4311 * stabsread.c (read_type, read_array_type, read_range_type):
4312 Remove unnecessary cast.
4313 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4314 (parse_symbol, parse_type, upgrade_type, parse_external)
4315 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4317 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4319 2019-06-16 Tom Tromey <tom@tromey.com>
4321 * tui/tui-data.c (tui_alloc_generic_win_info)
4322 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4325 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4326 Andrew Burgess <andrew.burgess@embecosm.com>
4328 * f-typeprint.c (f_print_type): Don't return early for not
4329 associated or not allocated types.
4330 (f_type_print_varspec_suffix): Add print_rank parameter and print
4331 ranks of array types in case they dangling.
4332 (f_type_print_base): Add print_rank parameter.
4334 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4336 * NEWS: Mention new MI commands.
4337 * break-catch-throw.c (enum exception_event_kind): Move to
4339 (print_mention_exception_catchpoint): Output text as a single
4341 (catch_exception_command_1): Rename to...
4342 (catch_exception_event): ...this, make non-static, update header
4343 command, and change some parameter types.
4344 (catch_catch_command): Update for changes to
4345 catch_exception_command_1.
4346 (catch_throw_command): Likewise.
4347 (catch_rethrow_command): Likewise.
4348 * breakpoint.c (enum exception_event_kind): Delete.
4349 * breakpoint.h (enum exception_event_kind): Moved here from
4350 break-catch-throw.c.
4351 (catch_exception_event): Declare.
4352 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4353 (mi_cmd_catch_throw): New function.
4354 (mi_cmd_catch_rethrow): New function.
4355 (mi_cmd_catch_catch): New function.
4356 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4357 'catch-catch' entries.
4358 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4359 (mi_cmd_catch_rethrow): Declare.
4360 (mi_cmd_catch_catch): Declare.
4362 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4364 * annotate.c (annotate_source_line): Change return type to void,
4365 update implementation to match.
4366 * annotate.h (annotate_source_line): Change return type to void,
4367 update header comment.
4368 * stack.c (print_frame_info): Don't change what frame information
4369 is printed based on whether annotations are on or not.
4371 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4373 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4374 (annotate_source): Make static.
4375 (annotate_source_line): Moved from source.c and renamed from
4376 identify_source_line. Update the return type.
4377 * annotate.h (annotate_source): Delete declaration.
4378 (annotate_source_line): Declaration moved from source.h, and
4379 renamed from identify_source_line. Return type updated.
4380 * source.c (identify_source_line): Moved to annotate.c and renamed
4381 to annotate_source_line.
4382 (info_line_command): Remove check of annotation_level.
4383 * source.h (identify_source_line): Move declaration to annotate.h
4384 and rename to annotate_source_line.
4385 * stack.c: Add 'annotate.h' include.
4386 (print_frame_info): Remove check of annotation_level before
4387 calling annotate_source_line.
4389 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4391 * source-cache.c (source_cache::get_plain_source_lines): Use
4392 open_source_file_with_line_charpos instead of just
4393 open_source_file, remove call to find_source_lines.
4394 (source_cache::get_source_lines): Likewise.
4395 * source.c (find_source_lines): Make static.
4396 (get_filename_and_charpos): Renamed into...
4397 (open_source_file_with_line_charpos): ..this along with changes to
4398 return a scoped_fd, and some other minor clean ups.
4399 (identify_source_line): Use open_source_file_with_line_charpos.
4400 (search_command_helper): Use open_source_file_with_line_charpos
4401 instead of just open_source_file, remove call to
4403 * source.h (open_source_file_with_line_charpos): Declare new
4405 (find_source_lines): Delete declaration.
4407 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4409 * source.c (get_filename_and_charpos): Remove fullname
4411 (identify_source_line): Update call to get_filename_and_charpos.
4413 2019-06-14 Tom Tromey <tromey@adacore.com>
4416 * ui-style.h (skip_ansi_escape): Update comment.
4417 * ui-file.h (class no_terminal_escape_file): New class.
4418 * ui-file.c (no_terminal_escape_file::write)
4419 (no_terminal_escape_file::puts): New methods.
4420 * cli/cli-logging.c (handle_redirections): Use
4421 no_terminal_escape_file.
4423 2019-06-14 Tom Tromey <tromey@adacore.com>
4425 * NEWS: Move convenience variable news above Python news.
4427 2019-06-14 Tom Tromey <tom@tromey.com>
4429 * gnulib: Move directory to top-level.
4430 * configure.ac: Don't configure gnulib.
4431 * configure: Rebuild.
4432 * common/common-defs.h: Use new path to gnulib.
4433 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4435 (INCGNU): Look in new gnulib location.
4436 (HFILES_NO_SRCDIR): Remove gnulib files.
4437 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4438 (generated_files): Remove GNULIB_H.
4439 ($(LIBGNU), all-lib): Remove targets.
4440 (distclean): Don't mention GNULIB_BUILDDIR.
4441 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4443 2019-06-14 Tom Tromey <tromey@adacore.com>
4445 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4446 Warn if symbol file does not provide any symbols.
4448 2019-06-14 Tom Tromey <tromey@adacore.com>
4450 * source.c (find_and_open_source): Respect basenames_may_differ.
4452 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4454 * annotate.c (annotate_breakpoints_invalid): Make use of
4455 scoped_restore_terminal_state.
4456 (annotate_frames_invalid): Likewise.
4458 2019-06-14 Tom Tromey <tromey@adacore.com>
4460 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4461 allow assignment to an internalvar.
4463 2019-06-14 Tom Tromey <tromey@adacore.com>
4465 * ada-lex.l: Allow "_" in attribute names.
4467 2019-06-14 Tom Tromey <tromey@adacore.com>
4470 * regcache.c (registers_changed): Don't call alloca.
4471 * top.c (execute_command): Don't call alloca.
4473 2019-06-13 Pedro Alves <palves@redhat.com>
4475 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4476 'expression'. When parsing an expression, error out if there's
4477 junk after "unlimited".
4478 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4479 (do_set_command): Adjust calls to is_unlimited_literal.
4481 2019-06-13 Pedro Alves <palves@redhat.com>
4483 * compile/compile.c (make_compile_options_def_group): Add braces
4484 around array_view initializer.
4485 * thread.c (make_thread_apply_all_options_def_group)
4486 (make_thread_apply_all_options_def_group): Likewise.
4488 2019-06-13 Pedro Alves <palves@redhat.com>
4490 * NEWS (New commands): Mention "maint test-options
4491 require-delimiter", "maint test-options unknown-is-error", "maint
4492 test-options unknown-is-operand" and "maint show
4493 test-options-completion-result".
4494 (New command options, command completion): New section.
4495 (Completion improvements): New section.
4496 Mention that you can abbreviate "unlimited".
4498 2019-06-13 Pedro Alves <palves@redhat.com>
4500 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4501 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4502 * unittests/cli-utils-selftests.c (test_parse_flags)
4503 (test_parse_flags_qcs): Delete.
4504 (test_cli_utils): Don't call deleted functions.
4506 2019-06-13 Pedro Alves <palves@redhat.com>
4508 * thread.c: Include "cli/cli-option.h".
4509 (tp_array_compar_ascending): Global.
4510 (tp_array_compar): Delete function.
4511 (tp_array_compar_ascending, tp_array_compar_descending): New
4513 (ascending_option_def, qcs_flag_option_def)
4514 (thr_qcs_flags_option_defs)
4515 (make_thread_apply_all_options_def_group)
4516 (make_thread_apply_options_def_group): New.
4517 (thread_apply_all_command): Use gdb::option::process_options.
4518 (thread_apply_command_completer)
4519 (thread_apply_all_command_completer): New.
4520 (thread_apply_command): Use gdb::option::process_options.
4521 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4522 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4523 to generate help text of "thread apply". Adjust "taas"'s help.
4524 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4525 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4527 2019-06-13 Pedro Alves <palves@redhat.com>
4529 * thread.c (thread_apply_command): Check for invalid TID with
4530 isdigit instead of !isalpha.
4532 2019-06-13 Pedro Alves <palves@redhat.com>
4534 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4535 (validate_flags_qcs): New.
4536 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4537 (validate_flags_qcs): Declare.
4538 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4539 (make_frame_apply_options_def_group): New.
4540 (frame_apply_command_count): Process options with
4541 gdb::option::process_options.
4542 (frame_apply_completer): New.
4543 (frame_apply_level_completer, frame_apply_all_completer)
4544 (frame_apply_completer): New.
4545 (_initialize_stack): Update help of "frame apply", "frame apply
4546 level", "frame apply all" and "faas" to mention supported options
4547 and install command completers.
4548 * stack.h (frame_apply_all_completer): Declare.
4549 * thread.c: Include "stack.h".
4550 (tfaas_command): Add "--".
4551 (_initialize_thread): Update help "tfaas" to mention supported
4552 options and install command completer.
4554 2019-06-13 Pedro Alves <palves@redhat.com>
4556 * completer.c (complete_nested_command_line): New.
4557 (gdb_completion_word_break_characters_throw): Add assertion.
4558 * completer.h (complete_nested_command_line): Declare.
4560 2019-06-13 Pedro Alves <palves@redhat.com>
4562 * stack.c (parse_backtrace_qualifiers): New.
4563 (backtrace_command): Use it.
4564 (backtrace_command_completer): Complete on qualifiers.
4566 2019-06-13 Pedro Alves <palves@redhat.com>
4568 * frame.c: Include "cli/cli-option.h.
4569 (user_set_backtrace_options): New.
4570 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4572 (get_prev_frame): Adjust.
4573 (boolean_option_def, uinteger_option_def)
4574 (set_backtrace_option_defs): New.
4575 (_initialize_frame): Adjust and use
4576 gdb::option::add_setshow_cmds_for_options to install "set
4577 backtrace past-main" and "set backtrace past-entry".
4578 * frame.h: Include "cli/cli-option.h".
4579 (struct frame_print_options): Forward declare.
4580 (print_frame_arguments_all, print_frame_arguments_scalars)
4581 (print_frame_arguments_none): Declare.
4582 (print_entry_values): Delete declaration.
4583 (struct frame_print_options, user_frame_print_options): New.
4584 (struct set_backtrace_options): New.
4585 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4586 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4587 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4588 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4589 (list_args_or_locals): Add frame_print_options parameter.
4590 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4591 * python/py-framefilter.c (enumerate_args): Pass down
4592 USER_FRAME_PRINT_OPTIONS.
4593 * stack.c: Include "cli/cli-option.h".
4594 (print_frame_arguments_all, print_frame_arguments_scalars)
4595 (print_frame_arguments_none): Declare.
4596 (print_raw_frame_arguments, print_entry_values): Delete.
4597 (user_frame_print_options): New.
4598 (boolean_option_def, enum_option_def, frame_print_option_defs):
4600 (struct backtrace_cmd_options): New.
4601 (bt_flag_option_def): New.
4602 (backtrace_command_option_defs): New.
4603 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4604 (print_frame_arg, read_frame_arg, print_frame_args)
4605 (print_frame_info, print_frame): Add frame_print_options parameter
4607 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4608 (backtrace_command_1): Add frame_print_options and
4609 backtrace_cmd_options parameters and use them.
4610 (make_backtrace_options_def_group): New.
4611 (backtrace_command): Process command options with
4612 gdb::option::process_options.
4613 (backtrace_command_completer): New.
4614 (_initialize_stack): Extend "backtrace"'s help to mention
4615 supported options. Install completer for "backtrace".
4616 Install some settings commands with add_setshow_cmds_for_options.
4618 2019-06-13 Pedro Alves <palves@redhat.com>
4620 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4621 and that "set/show print raw frame-arguments" are now deprecated.
4623 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4625 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4626 * stack.c (_initialize_stack): Install "set/show print
4627 raw-frame-arguments", and deprecate "set/show print raw
4629 * valprint.c (_initialize_valprint): Deprecate "set/show print
4632 2019-06-13 Pedro Alves <palves@redhat.com>
4634 * compile/compile.c (struct compile_options): New.
4635 (compile_flag_option_def, compile_command_option_defs)
4636 (make_compile_options_def_group): New.
4637 (compile_file_command): Handle options with
4638 gdb::option::process_options.
4639 (compile_file_command_completer): New function.
4640 (compile_code_command): Handle options with
4641 gdb::option::process_options.
4642 (compile_code_command_completer): New function.
4643 (_initialize_compiler): Install completers for "compile code" and
4644 "compile file". Mention available options in "compile code" and
4645 "compile code"'s help.
4646 * completer.c (advance_to_completion_word): New, factored out from
4648 (advance_to_expression_complete_word_point): ... this.
4649 (advance_to_filename_complete_word_point): New.
4650 * completer.h (advance_to_filename_complete_word_point): New
4653 2019-06-13 Pedro Alves <palves@redhat.com>
4655 * compile/compile.c: Include "cli/cli-option.h".
4656 (compile_print_value): Scope data pointer is now a
4657 value_print_options pointer; adjust.
4658 (compile_print_command): Process options. Scope data pointer is
4659 now a value_print_options pointer; adjust.
4660 (_initialize_compile): Update "compile print"'s help to include
4661 supported options. Install a completer for "compile print".
4662 * cp-valprint.c (show_vtblprint, show_objectprint)
4663 (show_static_field_print): Delete.
4664 (_initialize_cp_valprint): Don't install "set print
4665 static-members", "set print vtbl", "set print object" here.
4666 * printcmd.c: Include "cli/cli-option.h" and
4667 "common/gdb_optional.h".
4668 (print_command_parse_format): Rework to fill in a
4669 value_print_options instead of a format_data.
4670 (print_value): Change parameter type from format_data pointer to
4671 value_print_options reference. Adjust.
4672 (print_command_1): Process options. Adjust to pass down a
4673 value_print_options.
4674 (print_command_completer): New.
4675 (_initialize_printcmd): Install print_command_completer as
4676 handle_brkchars completer for the "print" command. Update
4677 "print"'s help to include supported options.
4678 * valprint.c: Include "cli/cli-option.h".
4679 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4680 here from cp-valprint.c.
4681 (boolean_option_def, uinteger_option_def)
4682 (value_print_option_defs, make_value_print_options_def_group):
4683 New. Use gdb::option::add_setshow_cmds_for_options to install
4684 "set print elements", "set print null-stop", "set print repeats",
4685 "set print pretty", "set print union", "set print array", "set
4686 print address", "set print symbol", "set print array-indexes".
4687 * valprint.h: Include <string> and "cli/cli-option.h".
4688 (make_value_print_options_def_group): Declare.
4689 (print_value): Change parameter type from format_data pointer to
4690 value_print_options reference.
4691 (print_command_completer): Declare.
4693 2019-06-13 Pedro Alves <palves@redhat.com>
4695 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4696 (COMMON_SFILES): Add maint-test-settings.c.
4697 * cli/cli-decode.c (boolean_enums): New global, factored out from
4699 (add_setshow_boolean_cmd): ... here.
4700 * cli/cli-decode.h (boolean_enums): Declare.
4701 * cli/cli-option.c: New file.
4702 * cli/cli-option.h: New file.
4703 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4704 factored out from ...
4705 (parse_cli_boolean_value(const char *)): ... this.
4706 (is_unlimited_literal): Change parameter type to pointer to
4707 pointer. Adjust and advance ARG pointer.
4708 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4709 (parse_cli_var_enum): New, factored out from ...
4710 (do_set_command): ... this. Adjust.
4711 * cli/cli-setshow.h (parse_cli_boolean_value)
4712 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4713 (parse_cli_var_enum): Declare.
4714 * cli/cli-utils.c: Include "cli/cli-option.h".
4715 (get_ulongest): New.
4716 * cli/cli-utils.h (get_ulongest): Declare.
4717 (check_for_argument): New overloads.
4718 * maint-test-options.c: New file.
4720 2019-06-13 Pedro Alves <palves@redhat.com>
4722 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4723 parse a range if "-" is at the end of the string.
4725 2019-06-13 Pedro Alves <palves@redhat.com>
4727 * cli/cli-setshow.c (parse_auto_binary_operation)
4728 (parse_cli_boolean_value): Don't allow "o".
4730 2019-06-13 Pedro Alves <palves@redhat.com>
4732 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4733 * NEWS: Mention maint test-settings KIND.
4734 * maint-test-settings.c: New file.
4736 2019-06-13 Pedro Alves <palves@redhat.com>
4738 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4740 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4743 2019-06-13 Pedro Alves <palves@redhat.com>
4745 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4748 2019-06-13 Pedro Alves <palves@redhat.com>
4750 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4752 2019-06-13 Pedro Alves <palves@redhat.com>
4754 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4755 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4757 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4758 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4760 (check_for_argument): Skip spaces after argument.
4762 2019-06-13 Pedro Alves <palves@redhat.com>
4764 * thread.c (thread_apply_command): Adjust TID parsing.
4765 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4766 detected before end of string.
4767 (tid_is_in_list): Error out if LIST is invalid.
4769 2019-06-13 Pedro Alves <palves@redhat.com>
4771 * completer.c (complete_line_internal_1): Rewind completion word
4773 (completion_tracker::advance_custom_word_point_by): Change
4774 parameter type to int.
4775 * completer.h (completion_tracker::advance_custom_word_point_by):
4778 2019-06-13 Pedro Alves <palves@redhat.com>
4780 * completer.c (advance_to_completion_word): Handle delimiters.
4782 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4784 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4786 2019-06-11 Tom Tromey <tom@tromey.com>
4788 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4789 (xmalloc_failed): Move to alloc.c.
4790 * alloc.c: New file.
4791 * Makefile.in (COMMON_SFILES): Add alloc.c.
4793 2019-06-11 Tom Tromey <tom@tromey.com>
4795 * nat/linux-waitpid.c: Don't include server.h.
4796 (linux_debug): Remove.
4797 (my_waitpid): Update.
4799 2019-06-11 Tom Tromey <tromey@adacore.com>
4801 * infcall.c (_initialize_infcall): Remove trailing newline from
4803 * user-regs.c (_initialize_user_regs): Remove trailing newline
4805 * typeprint.c (_initialize_typeprint): Remove trailing newline
4807 * reverse.c (_initialize_reverse): Remove trailing newlines from
4809 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4811 * language.c (add_set_language_command): Remove trailing newline
4813 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4815 * disasm.c (_initialize_disasm): Remove trailing newline from
4817 * top.c (init_main): Remove trailing newline from help.
4818 * interps.c (_initialize_interpreter): Remove trailing newline
4820 * btrace.c (_initialize_btrace): Remove trailing newlines from
4822 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4824 * python/python.c (_initialize_python): Remove trailing newline
4826 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4828 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4829 from help. Reformat some text.
4830 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4832 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4835 2019-06-11 Tom Tromey <tromey@adacore.com>
4837 * darwin-nat.c (darwin_decode_exception_message)
4838 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4840 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4842 * valops.c (value_slice): Check for not allocated or not
4845 2019-06-10 Tom de Vries <tdevries@suse.de>
4848 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4849 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4852 2019-06-10 Tom de Vries <tdevries@suse.de>
4855 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4856 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4858 2019-06-10 Tom de Vries <tdevries@suse.de>
4861 * symtab.c (struct demangled_name_entry): Add language field.
4862 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4863 static minimal symbol". Set and use language field.
4865 2019-06-10 Tom Tromey <tromey@adacore.com>
4867 * ada-lang.c (_initialize_ada_language): Update help text.
4869 2019-06-10 Tom Tromey <tromey@adacore.com>
4871 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4873 * guile/guile.c (handle_boot_error): Don't end warning with a
4875 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4876 warning with a newline.
4877 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4879 (s12z_frame_cache): Likewise.
4880 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4882 * solib-svr4.c (disable_probes_interface): Don't end warning with
4884 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4886 * python/python.c (do_finish_initialization): Don't end warning
4889 2019-06-10 Tom Tromey <tom@tromey.com>
4891 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4892 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4895 2019-06-10 Tom Tromey <tromey@adacore.com>
4897 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4899 (elf_new_init): Don't call stabsread_new_init.
4900 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4901 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4902 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4904 2019-06-10 Tom de Vries <tdevries@suse.de>
4908 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4910 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4912 * source.c (find_and_open_source): Also rewrite relative file
4915 2019-04-26 Amos Bird <amosbird@gmail.com>
4917 * annotate.c (annotate_thread_exited): Add "thread-exited"
4920 2019-06-06 Tom Tromey <tromey@adacore.com>
4922 * maint.h (class scoped_command_stats): Use
4923 DISABLE_COPY_AND_ASSIGN.
4924 <print_time>: New method.
4925 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4927 (scoped_command_stats::print_time): New method.
4929 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4931 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4932 instructions of lengths 6 or 8 bytes.
4934 2019-06-04 Pedro Alves <palves@redhat.com>
4936 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4938 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4939 * breakpoint.c (condition_completer): Likewise.
4940 * cli/cli-dump.c (scan_expression): Likewise.
4941 * common/filestuff.c (mkdir_recursive): Likewise.
4942 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4943 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4944 (gdb_abspath): Likewise.
4945 * compile/compile-cplus-types.c
4946 (compile_cplus_instance::decl_name): Likewise.
4947 * completer.c (complete_explicit_location):
4948 (signal_completer, reg_or_group_completer_1): Likewise.
4949 * cp-support.c (cp_remove_params_if_any): Likewise.
4950 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4951 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4952 * infcmd.c (strip_bg_char): Likewise.
4953 * linespec.c (copy_token_string): Likewise.
4954 * mi/mi-main.c (output_cores): Likewise.
4955 * psymtab.c (psymtab_search_name):
4956 * symfile.c (test_set_ext_lang_command): Likewise.
4957 * target.c (target_fileio_read_stralloc): Likewise.
4958 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4959 * value.c (complete_internalvar): Likewise.
4961 2019-06-04 Christian Biesinger <cbiesinger@google.com>
4963 Add objfile property to gdb.Type.
4964 * NEWS: Mention Python API addition.
4965 * python/py-type.c (typy_get_objfile): New method.
4967 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4969 * NEWS: Mention the new set|show style [title|highlight].
4970 Mention changes to "show style", "help" and "apropos".
4972 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4974 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4975 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4976 instead of print_help_for_command.
4977 (print_doc_of_command): New function.
4978 (help_list): Add 'apropos -v word' suggestion.
4979 (print_help_for_command): Style the command name using title style.
4980 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4981 (_initialize_cli_cmds): Describe -v in apropos_command help.
4983 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4985 * cli/cli-style.h (cli_style_option): Add name in constructor,
4986 add m_name class member, add constructor with intensity,
4987 add name class function.
4988 (cli_style_option::add_setshow_commands): Remove name argument.
4989 (highlight_style, title_style): New styles.
4990 * cli/cli-style.c (do_show): New function that shows a style
4991 characteristic styling the style name with itself.
4992 (set_style_name): New function.
4993 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4994 Update all callers according to the changes in cli/cli-style.h.
4995 * utils.h (fputs_highlighted): New function.
4996 * utils.c (fputs_highlighted): Likewise.
4998 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5000 * NEWS: Mention new pipe command and new convenience variables.
5002 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5004 * cli/cli-cmds.c (pipe_command): New function.
5005 (_initialize_cli_cmds): Call add_com for pipe_command.
5006 Define | as an alias for pipe.
5007 (exit_status_set_internal_vars): New function.
5008 (shell_escape): Call exit_status_set_internal_vars.
5009 cli/cli-decode.c (find_command_name_length): Recognize | as
5010 a single character command.
5012 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5014 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5015 top.c (execute_command_to_ui_file): New function, mostly a copy
5016 of execute_command_to_string.
5017 (execute_command_to_string): Implement by calling
5018 execute_command_to_ui_file.
5020 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5022 * top.h (saved_command_line): Remove declaration.
5023 * top.c (previous_saved_command_line, previous_repeat_arguments):
5025 (saved_command_line): Make static, define together with other
5027 (dont_repeat): Clear repeat_arguments.
5028 (repeat_previous, get_saved_command_line, save_command_line):
5030 (gdb_init): Initialize saved_command_line
5031 and previous_saved_command_line.
5032 * main.c (captured_main_1): Remove saved_command_line initialization.
5033 * event-top.c (handle_line_of_input): Update to use
5034 the new 'repeat' related functions instead of direct access to
5036 * command.h (repeat_previous, get_saved_command_line,
5037 save_command_line): New declarations.
5038 (dont_repeat): Add comment.
5040 2019-05-30 Tom Tromey <tromey@adacore.com>
5042 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5044 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5046 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5049 * completer.c (complete): Initialize variable word.
5051 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5053 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5054 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5055 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5056 'body' is NULL to the outter 'if', protecting the '!is_define'
5059 2019-05-29 Tom Tromey <tromey@adacore.com>
5061 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5062 (dwarf_unknown): New function.
5063 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5064 (dwarf_type_encoding_name): Use dwarf_unknown.
5066 2019-05-29 Tom Tromey <tromey@adacore.com>
5069 * cp-valprint.c (cp_print_value_fields): Call
5070 cp_print_static_field inside "try".
5072 2019-05-29 Tom Tromey <tromey@adacore.com>
5074 * inflow.c (struct terminal_info): Add default operator=.
5075 * configure: Rebuild.
5076 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5077 -Wdeprecated-copy-dtor, -Wredundant-move.
5079 2019-05-29 Tom Tromey <tromey@adacore.com>
5082 * infcmd.c (print_return_value_1): Handle finish_print
5084 (show_print_finish): New function.
5085 (_initialize_infcmd): Add "set/show print finish" commands.
5086 * valprint.c (user_print_options): Initialize new member.
5087 * valprint.h (struct value_print_options) <finish_print>: New
5090 2019-05-28 Tom Tromey <tromey@adacore.com>
5092 * ada-lang.c (ada_remove_Xbn_suffix)
5093 (find_old_style_renaming_symbol)
5094 (parse_old_style_renaming): Remove.
5095 (ada_find_renaming_symbol): Don't call
5096 find_old_style_renaming_symbol.
5097 (ada_is_renaming_symbol): Rename from
5098 ada_find_renaming_symbol. Remove "block" parameter. Return
5100 (ada_read_var_value): Update and simplify.
5101 * ada-exp.y (write_var_or_type): Remove old code.
5103 2019-05-28 Alan Hayward <alan.hayward@arm.com>
5105 * event-top.c: Remove include comment.
5106 * inflow.c (class scoped_ignore_sigttou): Move from here...
5107 * inflow.h (class scoped_ignore_sigttou): ...to here.
5108 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5109 * top.c: Remove include comment.
5111 2019-05-27 Tom Tromey <tom@tromey.com>
5115 2019-05-22 Tom Tromey <tromey@adacore.com>
5117 * target.c (target_follow_exec): Constify parameter.
5118 * target-delegates.c: Rebuild.
5119 * remote.c (remote_target::follow_exec): Constify parameter.
5120 * infrun.c (follow_exec): Constify parameter.
5121 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5122 (target_follow_exec): Likewise.
5124 2019-05-22 Alan Hayward <alan.hayward@arm.com>
5126 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5127 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5129 2019-05-22 Alan Hayward <alan.hayward@arm.com>
5131 * NEWS: Add debugredirect and testsuite sections.
5133 2019-05-22 Simon Cook <simon.cook@embecosm.com>
5135 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5136 target descriptions using exclusively floating point register name
5139 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5142 * f-lang.c (build_fortran_types): Handle the case where
5143 gdbarch_floatformat_for_type returns a nullptr.
5145 2019-05-21 Tom de Vries <tdevries@suse.de>
5148 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5150 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5153 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5155 * i386-tdep.c (i386_floatformat_for_type): Use
5156 floatformats_ia64_quad for the 16-byte floating point component
5157 within a fortran 32-byte complex number.
5159 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5161 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5162 delete default constructor.
5163 (find_partial_die): Update to return const struct.
5164 (partial_die_parent_scope): Move variable declaration into scope
5165 of its use and change its type to auto.
5166 (guess_partial_die_structure_name): Likewise.
5167 (partial_die_info::fixup): Likewise.
5169 2019-05-17 Tom Tromey <tromey@adacore.com>
5171 * source.c (find_and_open_source): Remove cast.
5173 2019-05-17 Tom Tromey <tromey@adacore.com>
5175 * annotate.c (annotate_source): Make "filename" const.
5176 * annotate.h (annotate_source): Use const.
5178 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5180 * disasm.c (set_disassembler_options): Send errors to stderr.
5182 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5184 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5185 (cli_interp_base::set_logging): Check debug_redirect.
5186 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5187 * cli/cli-logging.c (debug_redirect): Add static variable.
5188 (pop_output_files): Add default param.
5189 (handle_redirections): Print debug setting.
5190 (show_logging_command): Likewise.
5191 (_initialize_cli_logging): Add debugredirect command.
5192 * interps.c (current_interp_set_logging): Add debug_redirect
5194 * interps.h (set_logging): Add debug_redirect parameter.
5195 (current_interp_set_logging): Likewise.
5196 * mi/mi-common.h: Likewise.
5197 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5199 2019-05-17 Alan Hayward <alan.hayward@arm.com>
5200 Tom Tromey <tromey@adacore.com>
5202 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5204 * cli/cli-interp.h (make_logging_output): Remove declaration.
5205 * cli/cli-logging.c (make_logging_output): Remove function.
5206 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5208 * ui-file.c (tee_file::tee_file): Remove bools.
5209 (tee_file::~tee_file): Remove deletes.
5210 * ui-file.h (tee_file): Remove bools.
5212 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5214 * mi/mi-cmds.h (mi_cmd_complete): New function.
5215 * mi/mi-main.c (mi_cmd_complete): Likewise.
5216 * mi/mi-cmds.c: Define new MI command -complete.
5217 * NEWS: Mention new -complete command.
5219 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5221 * completer.h (complete): New function.
5222 * completer.c (complete): Likewise.
5223 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5224 function defined in completer.h.
5226 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5228 * MAINTAINERS (Write After Approval): Add myself.
5230 2019-05-17 Tom de Vries <tdevries@suse.de>
5233 * dwarf2read.c (struct cu_partial_die_info): New struct.
5234 (find_partial_die): Return cu_partial_die_info.
5235 (partial_die_parent_scope, guess_partial_die_structure_name)
5236 (partial_die_info::fixup): Handle new return type of find_partial_die.
5238 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5240 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5241 "std::string", simplifying the algorithm.
5243 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5245 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5246 (stap_static_probe_ops::get_probes): Likewise.
5248 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5250 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5251 '-')" and "else if".
5252 (stap_parse_single_operand): Join checks for
5253 "gdbarch_stap_parse_special_token_p" and
5254 "gdbarch_stap_parse_special_token" in the same "if" statement.
5255 Invert check when verifying for operation on register
5258 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5260 * stap-probe.c (stap_get_opcode): Update comment.
5261 (stap_get_expected_argument_type): Likewise.
5262 (handle_stap_probe): Likewise.
5264 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5266 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5267 return type to 'bool'. Adjust comment. Use 'bool' when
5269 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5270 * stap-probe.c (stap_parse_argument_1): Likewise.
5271 (stap_is_operator): Likewise.
5272 (stap_is_generic_prefix): Likewise.
5273 (stap_is_register_prefix): Likewise.
5274 (stap_is_register_indirection_prefix): Likewise.
5275 (stap_is_integer_prefix): Likewise.
5276 (stap_generic_check_suffix): Likewise.
5277 (stap_check_integer_suffix): Likewise.
5278 (stap_check_register_suffix): Likewise.
5279 (stap_check_register_indirection_suffix): Likewise.
5280 (stap_parse_register_operand): Likewise.
5281 (stap_parse_single_operand): Likewise.
5282 (stap_parse_argument_1): Likewise.
5283 (stap_probe::get_argument_count): Likewise.
5284 (stap_is_operator): Likewise.
5286 2019-05-16 Tom Tromey <tromey@adacore.com>
5288 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5291 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
5293 * linux-thread-db.c (try_thread_db_load_1): Change return type
5295 (try_thread_db_load): Likewise.
5296 (try_thread_db_load_from_pdir_1): Likewise.
5297 (try_thread_db_load_from_pdir): Likewise.
5298 (try_thread_db_load_from_sdir): Likewise.
5299 (try_thread_db_load_from_dir): Likewise.
5300 (thread_db_load_search): Likewise.
5301 (has_libpthread): Likewise.
5302 (thread_db_load): Likewise.
5304 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5306 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5307 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5308 NULL, and complain/return if that's the case.
5310 2019-05-15 John Darrington <john@darrington.wattle.id.au>
5312 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5313 (advance, posn, abstract_read_memory): New functions.
5314 [struct mem_read_abstraction]: New struct.
5315 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5317 2019-05-14 Tom Tromey <tromey@adacore.com>
5319 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5320 value is not lval_memory.
5322 2019-05-14 Tom Tromey <tromey@adacore.com>
5324 * solib.c (info_sharedlibrary_command): Style the file name.
5326 2019-05-14 Alan Hayward <alan.hayward@arm.com>
5328 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5329 (aarch64_vnv_type): Likewise.
5330 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5331 * common/tdesc.c: Likewise.
5332 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5333 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5334 * features/aarch64-fpu.xml: Add ieee half view.
5335 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5336 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5337 * gdbtypes.h (struct builtin_type): Likewise.
5338 (struct objfile_type): Likewise.
5340 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
5342 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5344 * location.h (string_to_event_location): Likewise.
5346 2019-05-11 Joel Brobecker <brobecker@adacore.com>
5350 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
5352 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5353 New variable declaration.
5354 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5356 (print_one_breakpoint): Use ui_out::test_flags and new global
5357 variable to compute use_fixed_output.
5358 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5360 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5361 (mi_multi_location_breakpoint_output_fixed): Remove.
5362 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5364 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5365 fix_multi_location_breakpoint_output flag if version >= 3.
5366 * ui-out.h (enum ui_out_flag)
5367 <fix_multi_location_breakpoint_output>: New enumerator.
5369 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
5371 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5373 2019-05-10 Tom Tromey <tromey@adacore.com>
5375 * ada-lang.c (catch_ada_completer): New function.
5376 (_initialize_ada_language): Use it.
5378 2019-05-10 Tom Tromey <tromey@adacore.com>
5380 * thread.c (print_thread_info): Make "requested_threads" const.
5381 * gdbthread.h (print_thread_info): Make "requested_threads"
5383 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5384 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5386 2019-05-08 Tom Tromey <tom@tromey.com>
5388 * gdbtypes.c (objfile_type_data): Change type.
5389 (objfile_type, _initialize_gdbtypes): Update.
5391 2019-05-08 Tom Tromey <tom@tromey.com>
5393 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5394 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5395 (_initialize_dwarf2_frame): Update.
5397 2019-05-08 Tom Tromey <tom@tromey.com>
5399 * objc-lang.c (objc_objfile_data): Change type.
5400 (find_methods): Update.
5401 (_initialize_objc_lang): Remove.
5403 2019-05-08 Tom Tromey <tom@tromey.com>
5405 * stabsread.c (rs6000_builtin_type_data): Change type.
5406 (rs6000_builtin_type, _initialize_stabsread): Update.
5408 2019-05-08 Tom Tromey <tom@tromey.com>
5410 * mips-tdep.c (mips_pdr_data): Remove.
5411 (_initialize_mips_tdep): Update.
5413 2019-05-08 Tom Tromey <tom@tromey.com>
5415 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5416 (hppa_init_objfile_priv_data, read_unwind_info)
5417 (find_unwind_entry, _initialize_hppa_tdep): Update.
5419 2019-05-08 Tom Tromey <tom@tromey.com>
5421 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5422 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5424 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5426 2019-05-08 Tom Tromey <tom@tromey.com>
5428 * mdebugread.c (basic_type_data): Change type.
5429 (basic_type, _initialize_mdebugread): Update.
5431 2019-05-08 Tom Tromey <tom@tromey.com>
5433 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5435 2019-05-08 Tom Tromey <tom@tromey.com>
5437 * nto-tdep.c (nto_inferior_data_reg): Change type.
5438 (nto_inferior_data): Update.
5439 (nto_inferior_data_cleanup, nto_new_inferior_data)
5440 (_initialize_nto_tdep): Remove.
5441 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5443 2019-05-08 Tom Tromey <tom@tromey.com>
5445 * ada-lang.c (struct ada_inferior_data): Add initializers.
5446 (ada_inferior_data): Change type.
5447 (ada_inferior_data_cleanup): Remove.
5448 (get_ada_inferior_data, ada_inferior_exit)
5449 (struct ada_pspace_data): Add initializers, destructor.
5450 (ada_pspace_data_handle): Change type.
5451 (get_ada_pspace_data): Update.
5452 (ada_pspace_data_cleanup): Remove.
5454 2019-05-08 Tom Tromey <tom@tromey.com>
5456 * coffread.c (struct coff_symfile_info): Add initializers.
5457 (coff_objfile_data_key): Move lower. Change type.
5458 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5460 (coff_free_info): Remove.
5462 2019-05-08 Tom Tromey <tom@tromey.com>
5464 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5465 (fbsd_pspace_data_handle): Move lower. Change type.
5466 (get_fbsd_pspace_data): Update.
5467 (fbsd_pspace_data_cleanup): Remove.
5468 (_initialize_fbsd_tdep): Update.
5470 2019-05-08 Tom Tromey <tom@tromey.com>
5472 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5473 (get_ada_tasks_pspace_data): Update.
5474 (ada_tasks_pspace_data_cleanup): Remove.
5475 (_initialize_tasks): Update.
5476 (ada_tasks_inferior_data_handle): Change type.
5477 (get_ada_tasks_inferior_data): Update.
5478 (ada_tasks_inferior_data_cleanup): Remove.
5479 (struct ada_tasks_pspace_data): Add initializers.
5481 2019-05-08 Tom Tromey <tom@tromey.com>
5483 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5484 * symfile-debug.c (debug_sym_get_probes): Change type.
5485 * stap-probe.c (handle_stap_probe):
5486 (stap_static_probe_ops::get_probes): Change type.
5487 * probe.h (class static_probe_ops) <get_probes>: Change type.
5488 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5489 (parse_probes_in_pspace): Update.
5490 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5492 (any_static_probe_ops::get_probes): Change type.
5493 * elfread.c (elfread_data): New typedef.
5494 (probe_key): Change type.
5495 (elf_get_probes): Likewise. Update.
5496 (probe_key_free): Remove.
5497 (_initialize_elfread): Update.
5498 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5500 (dtrace_process_dof_probe, dtrace_process_dof)
5501 (dtrace_static_probe_ops::get_probe): Change type.
5503 2019-05-08 Tom Tromey <tom@tromey.com>
5505 * xcoffread.c (struct xcoff_symfile_info): Rename from
5506 coff_symfile_info. Add initializers.
5507 (xcoff_objfile_data_key): Move lower. Change type.
5508 (XCOFF_DATA): Rewrite.
5509 (xcoff_free_info): Remove.
5510 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5511 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5512 (xcoff_initial_scan): Update.
5514 2019-05-08 Tom Tromey <tom@tromey.com>
5516 * solib-svr4.c (struct svr4_info): Add initializers and
5518 <probes_table>: Now an htab_up.
5519 (solib_svr4_pspace_data): Change type.
5520 (free_probes_table): Simplify.
5521 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5522 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5523 (probes_table_remove_objfile_probes, register_solib_event_probe)
5524 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5525 (_initialize_svr4_solib): Update.
5527 2019-05-08 Tom Tromey <tom@tromey.com>
5529 * remote.c (remote_pspace_data): Change type.
5530 (remote_pspace_data_cleanup): Remove.
5531 (get_remote_exec_file, set_pspace_remote_exec_file)
5532 (_initialize_remote): Update.
5534 2019-05-08 Tom Tromey <tom@tromey.com>
5536 * breakpoint.c (breakpoint_objfile_key): Change type.
5537 (get_breakpoint_objfile_data): Update.
5538 (free_breakpoint_objfile_data): Remove.
5539 (_initialize_breakpoint): Update.
5541 2019-05-08 Tom Tromey <tom@tromey.com>
5543 * linux-tdep.c (struct linux_info): Add initializers.
5544 (linux_inferior_data): Move. Change type.
5545 (invalidate_linux_cache_inf): Update.
5546 (linux_inferior_data_cleanup): Remove.
5547 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5549 2019-05-08 Tom Tromey <tom@tromey.com>
5551 * auxv.c (auxv_inferior_data): Move. Change type.
5552 (auxv_inferior_data_cleanup): Remove.
5553 (invalidate_auxv_cache_inf): Rewrite.
5554 (get_auxv_inferior_data, _initialize_auxv): Update.
5556 2019-05-08 Tom Tromey <tom@tromey.com>
5558 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5559 (symfile_debug_objfile_data_key): Change type.
5560 (symfile_debug_installed, debug_qf_has_symbols)
5561 (debug_qf_find_last_source_symtab)
5562 (debug_qf_forget_cached_source_info)
5563 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5564 (debug_qf_print_stats, debug_qf_dump)
5565 (debug_qf_expand_symtabs_for_function)
5566 (debug_qf_expand_all_symtabs)
5567 (debug_qf_expand_symtabs_with_fullname)
5568 (debug_qf_map_matching_symbols)
5569 (debug_qf_expand_symtabs_matching)
5570 (debug_qf_find_pc_sect_compunit_symtab)
5571 (debug_qf_map_symbol_filenames)
5572 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5573 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5574 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5575 (debug_sym_read_linetable, debug_sym_relocate): Update.
5576 (symfile_debug_free_objfile): Remove.
5577 (install_symfile_debug_logging, _initialize_symfile_debug):
5580 2019-05-08 Tom Tromey <tom@tromey.com>
5582 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5583 allocate_on_obstack.
5584 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5585 (get_dwarf2_per_objfile): Update.
5586 (set_dwarf2_per_objfile): Remove.
5587 (dwarf2_has_info, dwarf2_get_section_info): Update.
5588 (dwarf2_free_objfile): Remove.
5589 (_initialize_dwarf2_read): Update.
5591 2019-05-08 Tom Tromey <tom@tromey.com>
5593 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5595 <unsupported_script_warning_printed,
5596 script_not_found_warning_printed>: Now bool.
5597 (auto_load_pspace_data): Change type.
5598 (~auto_load_pspace_info): Rename from
5599 auto_load_pspace_data_cleanup.
5600 (get_auto_load_pspace_data, init_loaded_scripts_info)
5601 (clear_section_scripts, maybe_print_unsupported_script_warning)
5602 (maybe_print_script_not_found_warning, _initialize_auto_load):
5605 2019-05-08 Tom Tromey <tom@tromey.com>
5607 * objfiles.c (objfile_pspace_info): Add destructor and
5609 (objfiles_pspace_data): Change type.
5610 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5611 (get_objfile_pspace_data): Update.
5612 (objfiles_bfd_data): Change type.
5613 (get_objfile_bfd_data): Update.
5614 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5616 2019-05-08 Tom Tromey <tom@tromey.com>
5618 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5620 (get_catch_syscall_inferior_data): Update.
5621 (catch_syscall_inferior_data_cleanup): Remove.
5622 (_initialize_break_catch_syscall): Update.
5624 2019-05-08 Tom Tromey <tom@tromey.com>
5626 * inflow.c (struct terminal_info): Add destructor and
5628 (inflow_inferior_data): Change type.
5629 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5630 (get_inflow_inferior_data, inflow_inferior_exit)
5631 (swap_terminal_info, _initialize_inflow): Update.
5633 2019-05-08 Tom Tromey <tom@tromey.com>
5635 * target-dcache.c (target_dcache_cleanup): Remove.
5636 (target_dcache_aspace_key): Change type.
5637 (target_dcache_init_p, target_dcache_invalidate)
5638 (target_dcache_get, target_dcache_get_or_init)
5639 (_initialize_target_dcache): Update.
5640 * dcache.h (struct dcache_deleter): New.
5642 2019-05-08 Tom Tromey <tom@tromey.com>
5644 * symtab.c (struct symbol_cache): Add destructor and
5646 (symbol_cache_key): Move. Change type.
5647 (make_symbol_cache, free_symbol_cache): Remove.
5648 (get_symbol_cache): Update.
5649 (symbol_cache_cleanup): Remove.
5650 (ALL_PSPACES, symbol_cache_flush)
5651 (maintenance_print_symbol_cache)
5652 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5655 2019-05-08 Tom Tromey <tom@tromey.com>
5657 * symtab.c (struct main_info): Add destructor and initializers.
5658 (main_progspace_key): Move. Change type.
5659 (get_main_info): Update.
5660 (main_info_cleanup): Remove.
5661 (_initialize_symtab): Update.
5663 2019-05-08 Tom Tromey <tom@tromey.com>
5665 * registry.h (DECLARE_REGISTRY): Define the _key class.
5667 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5669 * NEWS: Merge two 'New commands' sections.
5671 2019-05-08 Joel Brobecker <brobecker@adacore.com>
5673 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5674 parameter and use Ada language definition instead.
5675 (ada_val_print_ptr): Remove unused language parameter.
5676 (ada_val_print_num): Remove language parameter and use Ada language
5678 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5680 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5681 parameter and use Ada language definition instead.
5682 (ada_val_print_1): Update all ada_val_print_xxx calls.
5683 Remove language parameter.
5684 (ada_val_print): Update ada_val_print_1 call.
5686 2019-05-08 Tom Tromey <tromey@adacore.com>
5688 * remote.c (remote_hw_watchpoint_limit)
5689 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5692 2019-05-08 Tom Tromey <tromey@adacore.com>
5694 * maint.c (_initialize_maint_cmds): Move initialization code to
5696 (watchdog, show_watchdog): Move to remote.c.
5697 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5699 (_initialize_remote): Move initialization code from maint.c.
5700 * defs.h (watchdog): Don't declare.
5702 2019-05-08 Tom Tromey <tromey@adacore.com>
5704 * tui/tui-interp.c: Include main.h.
5705 * interps.c: Include main.h.
5706 * main.h (interpreter_p): Declare.
5707 * defs.h (interpreter_p): Don't declare.
5709 2019-05-08 Tom Tromey <tromey@adacore.com>
5711 * dwarf2loc.c: Include dwarf2read.h.
5712 * defs.h (read_unsigned_leb128): Don't declare.
5713 * dwarf2read.h (read_unsigned_leb128): Declare.
5715 2019-05-08 Tom Tromey <tromey@adacore.com>
5717 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5720 2019-05-08 Tom Tromey <tromey@adacore.com>
5722 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5723 when no wrap column is set.
5725 2019-05-08 Tom Tromey <tromey@adacore.com>
5727 * c-lang.c (c_get_string): Handle non-C-style arrays.
5729 2019-05-08 Tom Tromey <tromey@adacore.com>
5731 * typeprint.c (print_offset_data::update): Print the bit offset,
5732 not the number of bits remaining.
5734 2019-05-08 Tom Tromey <tromey@adacore.com>
5736 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5737 padding at end of comment.
5739 2019-05-08 Tom Tromey <tromey@adacore.com>
5741 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5744 2019-05-06 Tom Tromey <tom@tromey.com>
5746 * common/scoped_mmap.c: Include common-defs.h.
5747 * common/scoped_mmap.h: Don't include config.h.
5749 2019-05-04 Tom Tromey <tom@tromey.com>
5751 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5752 (struct aarch64_call_info): Add initializers.
5753 <si>: Now a std::vector.
5754 (pass_on_stack, aarch64_push_dummy_call): Update.
5756 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
5757 Tom Tromey <tom@tromey.com>
5759 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5760 (ppc_threads): Now a std::vector. Now static.
5761 (hwdebug_find_thread_points_by_tid)
5762 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5765 2019-05-04 Tom Tromey <tom@tromey.com>
5767 * arc-tdep.c (arc_tdesc_init): Return bool.
5769 2019-05-04 Tom Tromey <tom@tromey.com>
5771 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5772 Use gdb_assert_not_reached.
5774 2019-05-04 Tom Tromey <tom@tromey.com>
5776 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5779 2019-05-04 Tom Tromey <tom@tromey.com>
5781 * arc-tdep.c (arc_tdesc_init): Use bool.
5783 2019-05-04 Tom Tromey <tom@tromey.com>
5785 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5787 2019-05-04 Tom Tromey <tom@tromey.com>
5789 * cli/cli-cmds.c (valid_command_p): Return bool.
5791 2019-05-04 Tom Tromey <tom@tromey.com>
5793 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5794 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5796 2019-05-04 Raul Tambre <raul@tambre.ee>
5798 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5799 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5800 operator for comparison.
5802 2019-05-04 Tom Tromey <tom@tromey.com>
5804 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5805 (lookup_partial_symbol, print_partial_symbols)
5806 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5807 (psymbol_compare): Update.
5808 (add_psymbol_to_bcache): Clear the entire psymbol.
5809 (maintenance_check_psymtabs): Update.
5810 * psympriv.h (struct partial_symbol): Don't derive from
5811 general_symbol_info.
5812 <obj_section, unrelocated_address, address,
5813 set_unrelocated_address>: Update.
5814 <ginfo>: New member.
5815 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5816 (debug_names::write_psymbols): Update.
5818 2019-05-04 Tom de Vries <tdevries@suse.de>
5820 * contrib/cc-with-tweaks.sh: Support -n arg.
5822 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5824 * corelow.c (core_target::detach): Ensure frame cache and
5825 register caches are cleared.
5826 inferior.c (exit_inferior_1): Likewise.
5828 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5829 Tom Tromey <tom@tromey.com>
5831 * dictionary.c (collate_pending_symbols_by_language): Remove
5832 "struct" from foreach.
5833 * symtab.c (lookup_global_symbol_from_objfile)
5834 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5836 * ser-tcp.c (net_open): Remove "struct" from foreach.
5837 * objfiles.c (objfile_relocate, objfile_rebase)
5838 (objfile_has_symbols): Remove "struct" from foreach.
5839 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5841 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5843 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5844 "struct" from foreach.
5845 * ada-lang.c (create_excep_cond_exprs)
5846 (ada_exception_catchpoint_cond_string): Remove "struct" from
5849 2019-05-03 Tom Tromey <tromey@adacore.com>
5851 * ada-exp.y (convert_char_literal): Check suffix of each
5854 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5857 * ada-exp.y (yywrap): Don't define.
5858 * ada-lex.l (%option): Add noyywrap
5861 2019-05-03 Eli Zaretskii <eliz@gnu.org>
5863 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5864 _WIN32_WINNT to the XP level, unless already defined to a higher
5867 * unittests/parse-connection-spec-selftests.c:
5869 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5872 * symfile.c (find_separate_debug_file): Remove colon from the
5873 drive spec of DOS/Windows file names of the target, so that the
5874 file name produced from DEBUGDIR and the target's directory will
5875 be valid on DOS/Windows systems.
5877 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5879 * rust-lang.c (val_print_struct): Handle printing structures
5882 2019-05-02 Tom Tromey <tromey@adacore.com>
5884 * valarith.c (_initialize_valarith): Remove.
5886 2019-05-01 Tom Tromey <tromey@adacore.com>
5888 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5891 2019-05-01 Tom Tromey <tromey@adacore.com>
5893 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5894 for big-endian copies.
5896 2019-04-30 Ali Tamur <tamur@google.com>
5897 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5898 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5899 (read_3_bytes): New function.
5901 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5903 * windows-nat.c (main_thread_id): Delete.
5904 (handle_output_debug_string): Replace main_thread_id by
5905 current_event.dwThreadId.
5906 (fake_create_process): Likewise.
5907 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5908 Do not set main_thread_id.
5909 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5910 current_event.dwThreadId.
5911 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5913 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5915 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5916 Use current_event.dwThreadId instead of main_thread_id.
5918 2019-04-30 Tom Tromey <tromey@adacore.com>
5920 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5921 (create_excep_cond_exprs): Iterate over program spaces.
5922 (ada_exception_catchpoint_cond_string): Examine all minimal
5923 symbols for exception types.
5925 2019-04-30 Tom Tromey <tromey@adacore.com>
5928 * dwarf2read.c (process_structure_scope): Handle case where type
5929 has template parameters but no symbol was created.
5931 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5932 Chris January <chris.january@arm.com>
5934 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5936 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5938 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5940 * f-typeprint.c (f_print_type): Update rules for printing
5942 (f_type_print_varspec_suffix): Likewise.
5944 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5945 Chris January <chris.january@arm.com>
5947 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5950 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5952 * f-lang.c (build_fortran_types): Change name of void type to
5954 * f-typeprint.c (f_type_print_base): Print the name of the void
5955 type, rather than a fixed string.
5956 * f-valprint.c (f_decorations): Use lower case void string.
5958 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5959 Chris January <chris.january@arm.com>
5961 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5964 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5965 Chris January <chris.january@arm.com>
5966 David Lecomber <david.lecomber@arm.com>
5968 * f-exp.y (BINOP_INTRINSIC): New token.
5969 (exp): New parser rule handling BINOP_INTRINSIC.
5970 (f77_keywords): Add new builtin procedures.
5971 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5972 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5973 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5974 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5975 (print_unop_subexp_f): New function.
5976 (print_binop_subexp_f): New function.
5977 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5978 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5979 (dump_subexp_body_f): Likewise.
5980 (operator_check_f): Likewise.
5981 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5982 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5984 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5986 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5988 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5989 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5990 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5991 (operator_length_f): New fuction.
5992 (print_subexp_f): New function.
5993 (op_name_f): New function.
5994 (dump_subexp_body_f): New function.
5995 (operator_check_f): New function.
5996 (exp_descriptor_f): Replace standard expression handling functions
5998 * gdb/fortran-operator.def: New file.
5999 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6000 * gdb/std-operator.def: Remove UNOP_KIND.
6002 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6004 * std-operator.def: Remove unbalanced, stray double quote
6007 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6008 Chris January <chris.january@arm.com>
6009 Daniel Everett <daniel.everett@arm.com>
6010 Nick Forrington <nick.forrington@arm.com>
6011 Richard Bunt <richard.bunt@arm.com>
6013 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6014 of depth when printing anonymous structs or unions.
6015 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6016 Don't print either the top-level value, or the children if the
6017 max-depth is exceeded.
6018 (ppscm_print_children): When printing the key of a map, allow one
6019 extra level of depth.
6020 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6021 print either the top-level value, or the children if the max-depth
6023 (print_children): When printing the key of a map, allow one extra
6025 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6026 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6027 (user_print_options): Initialise max_depth field.
6028 (val_print_scalar_or_string_type_p): New function.
6029 (val_print): Check to see if the max depth has been reached.
6030 (val_print_check_max_depth): Define new function.
6031 (show_print_max_depth): New function.
6032 (_initialize_valprint): Add 'print max-depth' option.
6033 * valprint.h (struct value_print_options) <max_depth>: New field.
6034 (val_print_check_max_depth): Declare new function.
6035 * NEWS: Document new feature.
6037 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6039 * ada-lang.c (ada_language_defn): Initialise new field.
6040 * c-lang.c (c_is_string_type_p): New function.
6041 (c_language_defn): Initialise new field.
6042 (cplus_language_defn): Initialise new field.
6043 (asm_language_defn): Initialise new field.
6044 (minimal_language_defn): Initialise new field.
6045 * c-lang.h (c_is_string_type_p): Declare new function.
6046 * d-lang.c (d_language_defn): Initialise new field.
6047 * f-lang.c (f_is_string_type_p): New function.
6048 (f_language_defn): Initialise new field.
6049 * go-lang.c (go_is_string_type_p): New function.
6050 (go_language_defn): Initialise new field.
6051 * language.c (default_is_string_type_p): New function.
6052 (unknown_language_defn): Initialise new field.
6053 (auto_language_defn): Initialise new field.
6054 * language.h (struct language_defn) <la_is_string_type_p>: New
6056 (default_is_string_type_p): Declare new function.
6057 * m2-lang.c (m2_language_defn): Initialise new field.
6058 * objc-lang.c (objc_language_defn): Initialise new field.
6059 * opencl-lang.c (opencl_language_defn): Initialise new field.
6060 * p-lang.c (pascal_is_string_type_p): New function.
6061 (pascal_language_defn): Initialise new field.
6062 * rust-lang.c (rust_is_string_type_p): New function.
6063 (rust_language_defn): Initialise new field.
6065 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6067 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6069 * ada-lang.c (ada_language_defn): Initialise new field.
6070 * c-lang.c (c_language_defn): Likewise.
6071 (cplus_language_defn): Likewise.
6072 (asm_language_defn): Likewise.
6073 (minimal_language_defn): Likewise.
6074 * d-lang.c (d_language_defn): Likewise.
6075 * f-lang.c (f_language_defn): Likewise.
6076 * go-lang.c (go_language_defn): Likewise.
6077 * language.c (unknown_language_defn): Likewise.
6078 (auto_language_defn): Likewise.
6079 * m2-lang.c (m2_language_defn): Likewise.
6080 * objc-lang.c (objc_language_defn): Likewise.
6081 * opencl-lang.c (opencl_language_defn): Likewise.
6082 * p-lang.c (pascal_language_defn): Likewise.
6083 * rust-lang.c (rust_language_defn): Likewise.
6085 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6087 * ada-lang.c (ada_is_character_type): Change return type to bool.
6088 (ada_is_string_type): Likewise.
6089 * ada-lang.h (ada_is_character_type): Update declaration
6090 (ada_is_string_type): Likewise.
6092 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6094 Support style in 'frame|thread apply'
6096 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6097 * record.c (record_start, record_stop): Update callers of
6098 execute_command_to_string with false.
6099 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6100 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6102 (class string_file): New constructor with term_out parameter.
6103 Override methods term_out and can_emit_style_escape. New member
6105 (class stdio_file): Override can_emit_style_escape.
6106 (class tee_file): Override term_out and can_emit_style_escape.
6107 * utils.h (can_emit_style_escape): Remove.
6108 * utils.c (can_emit_style_escape): Likewise.
6109 Update all callers of can_emit_style_escape (SOMESTREAM) to
6110 SOMESTREAM->can_emit_style_escape.
6111 * source-cache.c (source_cache::get_source_lines): Likewise.
6112 * stack.c (frame_apply_command_count): Call execute_command_to_string
6113 passing the term_out characteristic of the current gdb_stdout.
6114 * thread.c (thr_try_catch_cmd): Likewise.
6115 * top.c (execute_command_to_string): pass term_out parameter
6116 to construct the string_file for the command output.
6117 * ui-file.c (term_cli_styling): New function (most code moved
6118 from utils.c can_emit_style_escape).
6119 (string_file::string_file, string_file::can_emit_style_escape,
6120 stdio_file::can_emit_style_escape, tee_file::term_out,
6121 tee_file::can_emit_style_escape): New functions.
6123 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6125 * NEWS: Mention the new set|show may-call-functions.
6126 * infcall.c (may_call_functions_p): New variable.
6127 (show_may_call_functions_p): New function.
6128 (call_function_by_hand_dummy): Throws an error if not
6130 (_initialize_infcall): Call add_setshow_boolean_cmd for
6133 2019-04-25 Keith Seitz <keiths@redhat.com>
6136 * cp-support.c (inspect_type): Don't attempt substitutions
6137 of symbol with the same name.
6139 2019-04-25 Tom Tromey <tromey@adacore.com>
6142 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6145 2019-04-25 Tom Tromey <tromey@adacore.com>
6147 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6149 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6150 (gdb_xml_parser::parse): Use std::move.
6151 * python/python-internal.h (gdbpy_convert_exception): Take a const
6153 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6155 * python/py-utils.c (gdbpy_convert_exception): Take a const
6157 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6159 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6161 * mi/mi-main.c (mi_print_exception): Take a const reference.
6162 * main.c (handle_command_errors): Take a const reference.
6163 * linespec.c (parse_linespec): Use std::move.
6164 * infcall.c (run_inferior_call): Use std::move.
6165 (call_function_by_hand_dummy): Use std::move.
6166 * exec.c (try_open_exec_file): Use std::move.
6167 * exceptions.h (exception_print, exception_fprintf)
6168 (exception_print_same): Update.
6169 * exceptions.c (print_exception, exception_print)
6170 (exception_fprintf, exception_print_same): Change parameters to
6172 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6173 * common/new-op.c: Use std::move.
6174 * common/common-exceptions.h (struct gdb_exception): Add move
6176 (struct gdb_exception_error, struct gdb_exception_quit, struct
6177 gdb_quit_bad_alloc): Change constructor to move constructor.
6178 (throw_exception): Change parameter to rvalue reference.
6179 * common/common-exceptions.c (throw_exception): Take rvalue
6181 * cli/cli-interp.c (safe_execute_command): Use std::move.
6182 * breakpoint.c (insert_bp_location, location_to_sals): Use
6185 2019-04-25 Tom Tromey <tromey@adacore.com>
6187 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6188 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6189 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6190 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6191 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6192 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6193 guile/scm-value.c: Use unpack.
6194 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6195 gdbscm_gdb_exception.
6196 (gdbscm_throw_gdb_exception): Likewise.
6197 (struct gdbscm_gdb_exception): New.
6198 (unpack): New function.
6199 (gdbscm_wrap): Use unpack.
6201 2019-04-25 Tom Tromey <tromey@adacore.com>
6203 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6204 (gdb_rl_callback_handler): Use std::move.
6205 * common/common-exceptions.h (struct gdb_exception): Add move
6206 assignment operator.
6207 (throw_exception_sjlj): Change "exception" to const reference.
6208 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6209 (throw_exception_sjlj): Change "exception" to const reference.
6211 2019-04-25 Tom Tromey <tromey@adacore.com>
6213 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6214 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6215 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6217 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6219 * mi/mi-interp.c (mi_interp::exec): Update.
6220 * linespec.c (parse_linespec): Update.
6221 * infcall.c (run_inferior_call): Update.
6222 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6223 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6224 (gdbscm_lookup_global_symbol): Update.
6225 * guile/scm-param.c (gdbscm_parameter_value): Update.
6226 * guile/scm-frame.c (gdbscm_frame_read_register)
6227 (gdbscm_frame_read_var): Update.
6228 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6229 * exec.c (try_open_exec_file): Update.
6230 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6231 (gdb_rl_callback_handler): Update.
6232 * common/common-exceptions.h (exception_none): Don't declare.
6233 * common/common-exceptions.c (exception_none): Don't define.
6234 (struct catcher) <exception>: Update.
6235 * cli/cli-interp.c (safe_execute_command): Update.
6236 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6238 2019-04-25 Ali Tamur <tamur@google.com>
6240 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6241 (read_attribute_value): Likewise.
6242 (dwarf2_read_addr_index): Update comment.
6243 (read_str_index): Add DW_FORM_strx.
6244 (dwarf2_string_attr): Likewise.
6245 (dwarf2_const_value_attr): Likewise.
6246 (dump_die_shallow): Likewise.
6247 (dwarf2_fetch_constant_bytes): Likewise.
6248 (skip_form_bytes): Likewise.
6249 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6251 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6255 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6256 OFFSET. Verify if current mapping contains an ELF header.
6257 (linux_find_memory_regions_full): Adjust call to
6260 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6261 Kang Li <kanglictf@gmail.com>
6265 * dwarf2-frame.c (read_initial_length): Be consistent about using
6266 unsigned representation of length.
6267 (decode_frame_entry_1): Likewise. Check for wraparound of
6268 end pointer as well as buffer overflow.
6270 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6272 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6275 2019-04-24 Tom Tromey <tromey@adacore.com>
6277 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6279 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6281 * s12z-tdep.c (s12z_unwind_pc): Delete.
6282 (s12z_unwind_sp): Delete.
6283 (s12z_gdbarch_init): Don't register deleted functions with
6286 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6288 * rl78-tdep.c (rl78_unwind_sp): Delete.
6289 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6291 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6293 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6294 (xstormy16_unwind_pc): Delete.
6295 (xstormy16_dummy_id): Delete.
6296 (xstormy16_gdbarch_init): Don't register deleted functions with
6299 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6301 * vax-tdep.c (vax_unwind_pc): Delete.
6302 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6304 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6306 * v850-tdep.c (v850_unwind_sp): Delete.
6307 (v850_unwind_pc): Delete.
6308 (v850_dummy_id): Delete.
6309 (v850_gdbarch_init): Don't register deleted functions with
6312 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6314 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6315 (tilegx_unwind_pc): Delete.
6316 (tilegx_unwind_dummy_id): Delete.
6317 (tilegx_gdbarch_init): Don't register deleted functions with
6320 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6322 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6323 (tic6x_dummy_id): Delete.
6324 (tic6x_gdbarch_init): Don't register deleted functions with
6327 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6329 * sparc-tdep.c (sparc_unwind_pc): Delete.
6330 (sparc32_gdbarch_init): Don't register deleted function with
6333 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6335 * sh-tdep.c (sh_unwind_sp): Delete.
6336 (sh_unwind_pc): Delete.
6337 (sh_dummy_id): Delete.
6338 (sh_gdbarch_init): Don't register deleted functions with
6341 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6343 * score-tdep.c (score_unwind_sp): Delete.
6344 (score_unwind_pc): Delete.
6345 (score_dummy_id): Delete.
6346 (score_gdbarch_init): Don't register deleted functions with
6349 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6351 * rx-tdep.c (rx_unwind_pc): Delete.
6352 (rx_unwind_sp): Delete.
6353 (rx_dummy_id): Delete.
6354 (rx_gdbarch_init): Don't register deleted functions with
6355 gdbarch. Update comment.
6357 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6359 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6360 (rs6000_dummy_id): Delete.
6361 (rs6000_gdbarch_init): Don't register deleted functions with
6364 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6366 * or1k-tdep.c (or1k_dummy_id): Delete.
6367 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6369 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6371 * nios2-tdep.c (nios2_dummy_id): Delete.
6372 (nios2_unwind_sp): Delete.
6373 (nios2_gdbarch_init): Don't register deleted functions with
6376 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6378 * nds32-tdep.c (nds32_dummy_id): Delete.
6379 (nds32_unwind_pc): Delete.
6380 (nds32_unwind_sp): Delete.
6381 (nds32_gdbarch_init): Don't register deleted functions with
6384 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6386 * msp430-tdep.c (msp430_unwind_pc): Delete.
6387 (msp430_unwind_sp): Delete.
6388 (msp430_dummy_id): Delete.
6389 (msp430_gdbarch_init): Don't register deleted functions with
6392 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6394 * moxie-tdep.c (moxie_unwind_sp): Delete.
6395 (moxie_unwind_pc): Delete.
6396 (moxie_dummy_id): Delete.
6397 (moxie_gdbarch_init): Don't register deleted functions with
6400 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6402 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6403 (mn10300_unwind_pc): Delete.
6404 (mn10300_unwind_sp): Delete.
6405 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6407 (mn10300_frame_unwind_init): Don't register deleted functions with
6410 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6412 * mep-tdep.c (mep_unwind_pc): Delete.
6413 (mep_unwind_sp): Delete.
6414 (mep_dummy_id): Delete.
6415 (mep_gdbarch_init): Don't register deleted functions with
6418 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6420 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6421 (m68hc11_unwind_sp): Delete.
6422 (m68hc11_gdbarch_init): Don't register deleted functions with
6425 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6427 * m32r-tdep.c (m32r_unwind_sp): Delete.
6428 (m32r_unwind_pc): Delete.
6429 (m32r_dummy_id): Delete.
6430 (m32r_gdbarch_init): Don't register deleted functions with
6433 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6435 * m32c-tdep.c (m32c_unwind_pc): Delete.
6436 (m32c_unwind_sp): Delete.
6437 (m32c_dummy_id): Delete.
6438 (m32c_gdbarch_init): Don't register deleted functions with
6441 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6443 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6444 (lm32_unwind_pc): Delete.
6445 (lm32_dummy_id): Delete.
6446 (lm32_gdbarch_init): Don't register deleted functions with
6449 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6451 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6452 (iq2000_unwind_pc): Delete.
6453 (iq2000_dummy_id): Delete.
6454 (iq2000_gdbarch_init): Don't register deleted functions with
6457 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6459 * nds32-tdep.c (nds32_type_align): Delete.
6460 (nds32_push_dummy_call): Use type_align instead.
6462 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6464 * arm-tdep.c (arm_type_align): Only handle vector override case.
6465 (arm_push_dummy_call): Use type_align.
6466 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6468 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6470 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6472 (pass_on_stack): Use type_align.
6473 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6476 2019-04-23 Tom Tromey <tromey@adacore.com>
6478 * dwarf2read.c (line_header::file_name_at): Remove unused
6481 2019-04-23 Tom de Vries <tdevries@suse.de>
6484 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6488 2019-03-27 Ali Tamur <tamur@google.com>
6490 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6491 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6492 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6493 (dwarf_expr_context::get_addr_index): Likewise
6494 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6495 (symbol_needs_eval_context::get_addr_index): Likewise
6496 (disassemble_dwarf_expression): Add DW_OP_addrx
6497 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6498 (read_cutu_die_from_dwo): Update comment
6499 (skip_one_die): Add DW_FORM_addrx
6500 (read_attribute_value): Likewise
6501 (var_decode_location): Add DW_OP_addrx
6502 (dwarf2_const_value_attr): Add DW_FORM_addrx
6503 (dump_die_shallow): Likewise
6504 (dwarf2_fetch_constant_bytes): Likewise
6505 (decode_locdesc): Add DW_OP_addrx
6506 (skip_form_bytes): Add DW_FORM_addrx
6508 2019-04-22 Ali Tamur <tamur@google.com>
6510 * MAINTAINERS (Write After Approval): Add self.
6512 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
6514 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6515 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6516 (open_symbol_file_object): Likewise.
6517 (svr4_default_sos): Add info parameter.
6518 (svr4_read_so_list): Likewise.
6519 (svr4_current_sos_direct): Adjust functions calls to pass down
6521 (svr4_current_sos_1): Add info parameter.
6522 (svr4_current_sos): Call get_svr4_info, pass info down to
6524 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6526 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6528 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6530 (probes_table_remove_objfile_probes): Likewise.
6531 (register_solib_event_probe): Add info parameter.
6532 (solist_update_incremental): Pass info parameter down to
6534 (disable_probes_interface): Add info parameter.
6535 (svr4_handle_solib_event): Pass current_program_space to
6536 get_svr4_info. Adjust disable_probes_interface cleanup.
6537 (svr4_create_probe_breakpoints): Add info parameter, pass it
6538 down to register_solib_event_probe.
6539 (svr4_create_solib_event_breakpoints): Add info parameter,
6540 pass it down to svr4_create_probe_breakpoints.
6541 (enable_break): Pass info down to
6542 svr4_create_solib_event_breakpoints.
6543 (svr4_solib_create_inferior_hook): Pass current_program_space to
6545 (svr4_clear_solib): Likewise.
6547 2019-04-22 Pedro Alves <palves@redhat.com>
6549 * solib-svr4.c (svr4_free_objfile_observer): New.
6550 (probe_and_action::objfile): New field.
6551 (probes_table_htab_remove_objfile_probes)
6552 (probes_table_remove_objfile_probes): New functions.
6553 (register_solib_event_probe): Add 'objfile' parameter. Store it
6554 in the new probe_and_action. Don't store the probe in 'lookup'.
6555 (svr4_create_probe_breakpoints): Pass objfile to
6556 register_solib_event_probe.
6557 (_initialize_svr4_solib): Register a free_objfile observer.
6559 2019-04-19 Tom Tromey <tom@tromey.com>
6561 * common/queue.h: Remove.
6563 2019-04-19 Tom Tromey <tom@tromey.com>
6565 * event-loop.c: Don't include "common/queue.h".
6567 2019-04-19 Tom Tromey <tom@tromey.com>
6569 * remote.c (remote_target): Use delete.
6570 * remote-notif.h: Include <list>, not "common/queue.h".
6571 (notif_client_p): Remove typedef.
6572 (remote_notif_state): Add constructor, destructor, initializer.
6573 <notif_queue>: Now a std::list.
6574 (remote_notif_state_xfree): Don't declare.
6575 * remote-notif.c (remote_notif_process, handle_notification)
6576 (remote_notif_state_allocate): Update.
6577 (~remote_notif_state): Rename from remote_notif_state_xfree.
6579 2019-04-19 Tom Tromey <tom@tromey.com>
6581 * symfile.c (reread_symbols): Update.
6582 * objfiles.c (objfile_register_static_link)
6583 (objfile_lookup_static_link): Update
6584 (~objfile) Don't delete static_links.
6585 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6587 2019-04-19 Tom Tromey <tom@tromey.com>
6589 * type-stack.h (struct type_stack) <insert>: Constify string.
6590 * type-stack.c (type_stack::insert): Constify string.
6591 * gdbtypes.h (lookup_template_type): Update.
6592 (address_space_name_to_int): Update.
6593 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6595 (lookup_template_type): Make name const.
6596 * c-exp.y: Update rules.
6597 (lex_one_token, classify_name, classify_inner_name)
6598 (c_print_token): Update.
6599 * p-exp.y: Update rules.
6601 * f-exp.y: Update rules.
6603 * d-exp.y: Update rules.
6604 (lex_one_token, classify_name, classify_inner_name): Update.
6605 * parse.c (write_dollar_variable, copy_name): Return std::string.
6606 * parser-defs.h (copy_name): Change return type.
6607 * m2-exp.y: Update rules.
6609 * go-exp.y (lex_one_token): Update.
6611 (classify_unsafe_function, classify_packaged_name)
6612 (classify_name, yylex): Update.
6614 2019-04-19 Sergei Trofimovich <siarheit@google.com>
6616 * configure.ac: add --enable-source-highlight switch.
6617 * configure: Regenerate.
6618 * top.c (print_gdb_version): plumb --enable-source-highlight
6619 status to "show configuration".
6621 2019-04-19 Tom Tromey <tromey@adacore.com>
6623 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6625 (empty_record, ada_template_to_fixed_record_type_1)
6626 (template_to_static_fixed_type)
6627 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6628 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6629 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6632 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6635 * source.c (print_source_lines_base): Advance "iter" when a
6636 control character is seen.
6638 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6640 * inferior.h (struct infcall_suspend_state_deleter):
6641 Catch exception in destructor to avoid crash.
6643 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6645 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6646 close to the add_com "shell".
6648 2019-04-18 Tom Tromey <tromey@adacore.com>
6650 * process-stratum-target.h (class process_stratum_target)
6651 <stratum>: Add "final".
6653 2019-04-17 Tom Tromey <tromey@adacore.com>
6655 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6656 against nullptr before use.
6658 2019-04-17 Alan Hayward <alan.hayward@arm.com>
6660 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6662 2019-04-17 Jim Wilson <jimw@sifive.com>
6663 Andrew Burgess <andrew.burgess@embecosm.com>
6665 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6666 code read might fail, assume 4-byte breakpoint in that case.
6668 2019-04-15 Leszek Swirski <leszeks@google.com>
6670 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6671 rather than a hand-rolled POD check when checking for forced MEMORY
6674 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6676 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6677 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6679 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6680 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6681 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6684 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6686 * aarch64-linux-nat.c
6687 (aarch64_linux_nat_target::thread_architecture): Add override.
6688 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6691 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6693 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6695 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6697 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6698 target types of size 96-bits, add some additional comments, and
6699 check that the builtin type we found was the correct size.
6701 2019-04-12 Eli Zaretskii <eliz@gnu.org>
6703 * utils.c (prompt_for_continue): Don't restore the styling at the
6704 end, as applied_style has the wrong value. This fixes styling in
6705 long lists of file names that are interrupted by the "Continue?"
6708 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6710 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6711 * c-lang.c (c_language_defn): Likewise.
6712 (cplus_language_defn): Likewise.
6713 (asm_language_defn): Likewise.
6714 (minimal_language_defn): Likewise.
6715 * d-lang.c (d_language_defn): Likewise.
6716 * f-lang.c (f_language_defn): Likewise.
6717 * go-lang.c (go_language_defn): Likewise.
6718 * language.c (unknown_language_defn): Likewise.
6719 (auto_language_defn): Likewise.
6720 * language.h (struct language_defn): Remove la_magic field.
6721 (LANG_MAGIC): Delete.
6722 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6723 * objc-lang.c (objc_language_defn): Likewise.
6724 * opencl-lang.c (opencl_language_defn): Likewise.
6725 * p-lang.c (pascal_language_defn): Likewise.
6726 * rust-lang.c (rust_language_defn): Likewise.
6728 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6730 * riscv-tdep.c (riscv_type_align): New function.
6731 (riscv_type_alignment): Delete.
6732 (riscv_arg_location): Use 'type_align'.
6733 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6735 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6737 * gdbtypes.c (type_align): A struct with no non-static fields also
6740 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6742 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6744 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6746 (riscv_struct_info::analyse): New implementation using new
6747 analyse_inner member function.
6748 (riscv_struct_info::field_offset): New member function.
6749 (riscv_struct_info::m_offsets): New member variable.
6750 (riscv_struct_info::analyse_inner): New private member function,
6751 takes the old implementation of riscv_struct_info::analyse but
6752 extended to track field offsets.
6753 (riscv_call_arg_struct): Update the struct folding special cases
6754 to handle cases where empty C++ structs, which are non-zero
6756 (riscv_arg_location): Initialise the length of each location, a
6757 non-zero length now indicates the location is in use.
6758 (riscv_push_dummy_call): Allow for the first location having a
6759 non-zero offset when setting up arguments.
6760 (riscv_return_value): Likewise, but for return values.
6762 2019-04-11 Tom Tromey <tromey@adacore.com>
6764 * utils.c (internal_vproblem): Make "msg" const.
6766 2019-04-11 Alan Hayward <alan.hayward@arm.com>
6768 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6769 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6770 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6771 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6773 2019-04-10 Kevin Buettner <kevinb@redhat.com>
6775 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6777 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6778 of amd64_collect_native_gregset.
6779 (amd64_linux_nat_target::store_registers): Likewise.
6781 2019-04-10 Tom Tromey <tom@tromey.com>
6783 * symtab.c (lookup_global_symbol_from_objfile)
6784 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6785 * objfiles.h (class separate_debug_iterator): New.
6786 (class separate_debug_range): New.
6787 (struct objfile) <separate_debug_objfiles>: New method.
6788 (objfile_separate_debug_iterate): Don't declare.
6789 * objfiles.c (separate_debug_iterator::operator++): Rename from
6790 objfile_separate_debug_iterate.
6791 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6793 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6796 2019-04-10 Tom Tromey <tom@tromey.com>
6798 * symfile.c (reread_symbols): Remove old comment.
6799 * objfiles.c (free_all_objfiles): Fix a typo.
6801 2019-04-10 Tom Tromey <tom@tromey.com>
6803 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6804 * minsyms.c (lookup_minimal_symbol): Use foreach.
6805 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6806 (lookup_minimal_symbol_solib_trampoline): Likewise.
6807 * symfile.c (reread_symbols): Use foreach.
6809 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
6810 Tom Tromey <tromey@adacore.com>
6813 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6814 (rust_lex_int_test): Change "value" to be LONGEST.
6815 (rust_lex_tests): Add test for long integer literal.
6817 2019-04-09 Tom Tromey <tromey@adacore.com>
6819 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6821 (extended_remote_target::attach): Update.
6822 (remote_target::remote_notice_new_inferior): Update.
6823 (remote_target::add_current_inferior_and_thread): Update.
6824 * inferior.c (exit_inferior_1): Use "false".
6825 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6827 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
6829 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6830 the "start" command.
6832 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6834 * python/py-inferior.c (infpy_thread_from_thread_handle):
6835 Adjust comments to reflect renaming of thread_from_thread_handle
6836 to thread_from_handle. Adjust keywords. Fix type error message.
6837 (inferior_object_methods): Add thread_from_handle. Retain
6838 thread_from_thread_handle, but mark it as deprecated.
6840 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6842 * gdbthread.h (find_thread_by_handle): Revise declaration.
6843 * thread.c (find_thread_by_handle): Likewise. Adjust
6845 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6846 support for buffer objects as handles.
6848 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6850 * python/py-infthread.c (thpy_thread_handle): New function.
6851 (thread_object_methods): Register thpy_thread_handle.
6853 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6855 * gdbthread.h (thread_to_thread_handle): Declare.
6856 * thread.c (gdbtypes.h): Include.
6857 (thread_to_thread_handle): New function.
6859 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6860 (target_thread_info_to_thread_handle): Declare.
6861 * target.c (target_thread_info_to_thread_handle): New function.
6862 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6863 * target-delegates.c: Regenerate.
6865 * linux-thread-db.c (class thread_db_target): Add method
6866 thread_info_to_thread_handle.
6867 (thread_db_target::thread_info_to_thread_handle): Define.
6868 * remote.c (class remote_target): Add new method
6869 thread_info_to_thread_handle.
6870 (remote_target::thread_info_to_thread_handle): Define.
6872 2019-04-08 Pedro Alves <palves@redhat.com>
6874 * common/common-exceptions.c (throw_exception): Don't create
6875 named object to throw; throw directly.
6876 (throw_it): Likewise. Don't initialize gdb_exception::message
6877 here, with new; pass FMT and AP to the ctor instead.
6878 * common/common-exceptions.h: Include <string>.
6879 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6880 const char *, va_list)): New ctor. Use std::make_shared.
6881 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6883 (gdb_exception_error::gdb_exception_error(enum errors, const char
6885 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6887 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6889 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6890 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6893 2019-04-08 Tom Tromey <tom@tromey.com>
6895 * valops.c (value_rtti_indirect_type): Replace throw_exception
6897 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6899 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6901 * target.c (target_translate_tls_address): Replace throw_exception
6903 * stack.c (frame_apply_command_count): Replace throw_exception
6905 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6907 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6909 * rs6000-tdep.c (rs6000_frame_cache)
6910 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6911 * remote.c: Replace throw_exception with throw.
6912 * record-full.c (record_full_message, record_full_wait_1)
6913 (record_full_restore): Replace throw_exception with throw.
6915 (get_thread_current_frame_id, record_btrace_start_replaying)
6916 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6917 (cmd_record_btrace_start): Replace throw_exception with throw.
6918 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6920 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6921 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6923 (find_linespec_symbols): Replace throw_exception with throw.
6924 * infrun.c (displaced_step_prepare, resume): Replace
6925 throw_exception with throw.
6926 * infcmd.c (post_create_inferior): Replace throw_exception with
6928 * inf-loop.c (inferior_event_handler): Replace throw_exception
6930 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6931 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6932 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6933 (get_prev_frame_always, get_frame_pc_if_available)
6934 (get_frame_address_in_block_if_available, get_frame_language):
6935 Replace throw_exception with throw.
6936 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6937 throw_exception with throw.
6938 * eval.c (fetch_subexp_value, evaluate_var_value)
6939 (evaluate_funcall, evaluate_subexp_standard): Replace
6940 throw_exception with throw.
6941 * dwarf2loc.c (call_site_find_chain)
6942 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6943 Replace throw_exception with throw.
6944 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6946 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6948 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6949 * completer.c (complete_line_internal): Replace throw_exception
6951 * compile/compile-object-run.c (compile_object_run): Replace
6952 throw_exception with throw.
6953 * cli/cli-script.c (process_next_line): Replace throw_exception
6955 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6956 (btrace_enable, btrace_maint_update_pt_packets): Replace
6957 throw_exception with throw.
6958 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6959 throw_exception with throw.
6960 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6961 throw_exception with throw.
6962 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6963 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6964 * aarch64-tdep.c (aarch64_make_prologue_cache)
6965 (aarch64_make_stub_cache): Replace throw_exception with throw.
6967 2019-04-08 Tom Tromey <tom@tromey.com>
6969 * common/common-exceptions.c (throw_exception): Rename from
6970 throw_exception_cxx. Remove old copy. Make argument const.
6971 (throw_it): Create and throw exception objects directly.
6972 * common/common-exceptions.h (throw_exception): Make argument
6974 (struct gdb_exception_error): Add constructor.
6975 (struct gdb_exception_quit): Add constructor.
6977 2019-04-08 Tom Tromey <tom@tromey.com>
6979 * common/common-exceptions.h (exception_rethrow): Don't declare.
6980 (TRY_SJLJ): Update comment.
6981 (TRY, CATCH, END_CATCH): Remove.
6982 * common/common-exceptions.c (exception_rethrow): Remove.
6984 2019-04-08 Tom Tromey <tom@tromey.com>
6986 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6988 (gdb_exception_error): Rename from
6989 gdb_exception_RETURN_MASK_ERROR.
6990 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6991 (gdb_quit_bad_alloc): Update.
6992 * aarch64-tdep.c: Update.
6993 * ada-lang.c: Update.
6994 * ada-typeprint.c: Update.
6995 * ada-valprint.c: Update.
6996 * amd64-tdep.c: Update.
6997 * arch-utils.c: Update.
6998 * break-catch-throw.c: Update.
6999 * breakpoint.c: Update.
7001 * c-varobj.c: Update.
7002 * cli/cli-cmds.c: Update.
7003 * cli/cli-interp.c: Update.
7004 * cli/cli-script.c: Update.
7005 * common/common-exceptions.c: Update.
7006 * common/new-op.c: Update.
7007 * common/selftest.c: Update.
7008 * compile/compile-c-symbols.c: Update.
7009 * compile/compile-cplus-symbols.c: Update.
7010 * compile/compile-object-load.c: Update.
7011 * compile/compile-object-run.c: Update.
7012 * completer.c: Update.
7013 * corelow.c: Update.
7015 * cp-support.c: Update.
7016 * cp-valprint.c: Update.
7017 * darwin-nat.c: Update.
7018 * disasm-selftests.c: Update.
7019 * dtrace-probe.c: Update.
7020 * dwarf-index-cache.c: Update.
7021 * dwarf-index-write.c: Update.
7022 * dwarf2-frame-tailcall.c: Update.
7023 * dwarf2-frame.c: Update.
7024 * dwarf2loc.c: Update.
7025 * dwarf2read.c: Update.
7027 * event-loop.c: Update.
7028 * event-top.c: Update.
7030 * f-valprint.c: Update.
7031 * fbsd-tdep.c: Update.
7032 * frame-unwind.c: Update.
7034 * gdbtypes.c: Update.
7035 * gnu-v3-abi.c: Update.
7036 * guile/guile-internal.h: Update.
7037 * guile/scm-block.c: Update.
7038 * guile/scm-breakpoint.c: Update.
7039 * guile/scm-cmd.c: Update.
7040 * guile/scm-disasm.c: Update.
7041 * guile/scm-frame.c: Update.
7042 * guile/scm-lazy-string.c: Update.
7043 * guile/scm-math.c: Update.
7044 * guile/scm-param.c: Update.
7045 * guile/scm-ports.c: Update.
7046 * guile/scm-pretty-print.c: Update.
7047 * guile/scm-symbol.c: Update.
7048 * guile/scm-symtab.c: Update.
7049 * guile/scm-type.c: Update.
7050 * guile/scm-value.c: Update.
7051 * i386-linux-tdep.c: Update.
7052 * i386-tdep.c: Update.
7053 * inf-loop.c: Update.
7054 * infcall.c: Update.
7058 * language.c: Update.
7059 * linespec.c: Update.
7060 * linux-fork.c: Update.
7061 * linux-nat.c: Update.
7062 * linux-tdep.c: Update.
7063 * linux-thread-db.c: Update.
7065 * mi/mi-cmd-break.c: Update.
7066 * mi/mi-cmd-stack.c: Update.
7067 * mi/mi-interp.c: Update.
7068 * mi/mi-main.c: Update.
7069 * objc-lang.c: Update.
7070 * p-valprint.c: Update.
7072 * ppc-linux-tdep.c: Update.
7073 * printcmd.c: Update.
7074 * python/py-arch.c: Update.
7075 * python/py-breakpoint.c: Update.
7076 * python/py-cmd.c: Update.
7077 * python/py-finishbreakpoint.c: Update.
7078 * python/py-frame.c: Update.
7079 * python/py-framefilter.c: Update.
7080 * python/py-gdb-readline.c: Update.
7081 * python/py-inferior.c: Update.
7082 * python/py-infthread.c: Update.
7083 * python/py-lazy-string.c: Update.
7084 * python/py-linetable.c: Update.
7085 * python/py-objfile.c: Update.
7086 * python/py-param.c: Update.
7087 * python/py-prettyprint.c: Update.
7088 * python/py-progspace.c: Update.
7089 * python/py-record-btrace.c: Update.
7090 * python/py-record.c: Update.
7091 * python/py-symbol.c: Update.
7092 * python/py-type.c: Update.
7093 * python/py-unwind.c: Update.
7094 * python/py-utils.c: Update.
7095 * python/py-value.c: Update.
7096 * python/python.c: Update.
7097 * record-btrace.c: Update.
7098 * record-full.c: Update.
7099 * remote-fileio.c: Update.
7101 * riscv-tdep.c: Update.
7102 * rs6000-aix-tdep.c: Update.
7103 * rs6000-tdep.c: Update.
7104 * rust-exp.y: Update.
7105 * rust-lang.c: Update.
7106 * s390-tdep.c: Update.
7107 * selftest-arch.c: Update.
7108 * solib-dsbt.c: Update.
7109 * solib-frv.c: Update.
7110 * solib-spu.c: Update.
7111 * solib-svr4.c: Update.
7113 * sparc64-linux-tdep.c: Update.
7115 * symfile-mem.c: Update.
7116 * symmisc.c: Update.
7120 * tracefile-tfile.c: Update.
7121 * tui/tui.c: Update.
7122 * typeprint.c: Update.
7123 * unittests/cli-utils-selftests.c: Update.
7124 * unittests/parse-connection-spec-selftests.c: Update.
7126 * valprint.c: Update.
7129 * windows-nat.c: Update.
7130 * x86-linux-nat.c: Update.
7131 * xml-support.c: Update.
7133 2019-04-08 Tom Tromey <tom@tromey.com>
7135 * xml-support.c: Use C++ exception handling.
7136 * x86-linux-nat.c: Use C++ exception handling.
7137 * windows-nat.c: Use C++ exception handling.
7138 * varobj.c: Use C++ exception handling.
7139 * value.c: Use C++ exception handling.
7140 * valprint.c: Use C++ exception handling.
7141 * valops.c: Use C++ exception handling.
7142 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7144 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7145 * typeprint.c: Use C++ exception handling.
7146 * tui/tui.c: Use C++ exception handling.
7147 * tracefile-tfile.c: Use C++ exception handling.
7148 * top.c: Use C++ exception handling.
7149 * thread.c: Use C++ exception handling.
7150 * target.c: Use C++ exception handling.
7151 * symmisc.c: Use C++ exception handling.
7152 * symfile-mem.c: Use C++ exception handling.
7153 * stack.c: Use C++ exception handling.
7154 * sparc64-linux-tdep.c: Use C++ exception handling.
7155 * solib.c: Use C++ exception handling.
7156 * solib-svr4.c: Use C++ exception handling.
7157 * solib-spu.c: Use C++ exception handling.
7158 * solib-frv.c: Use C++ exception handling.
7159 * solib-dsbt.c: Use C++ exception handling.
7160 * selftest-arch.c: Use C++ exception handling.
7161 * s390-tdep.c: Use C++ exception handling.
7162 * rust-lang.c: Use C++ exception handling.
7163 * rust-exp.y: Use C++ exception handling.
7164 * rs6000-tdep.c: Use C++ exception handling.
7165 * rs6000-aix-tdep.c: Use C++ exception handling.
7166 * riscv-tdep.c: Use C++ exception handling.
7167 * remote.c: Use C++ exception handling.
7168 * remote-fileio.c: Use C++ exception handling.
7169 * record-full.c: Use C++ exception handling.
7170 * record-btrace.c: Use C++ exception handling.
7171 * python/python.c: Use C++ exception handling.
7172 * python/py-value.c: Use C++ exception handling.
7173 * python/py-utils.c: Use C++ exception handling.
7174 * python/py-unwind.c: Use C++ exception handling.
7175 * python/py-type.c: Use C++ exception handling.
7176 * python/py-symbol.c: Use C++ exception handling.
7177 * python/py-record.c: Use C++ exception handling.
7178 * python/py-record-btrace.c: Use C++ exception handling.
7179 * python/py-progspace.c: Use C++ exception handling.
7180 * python/py-prettyprint.c: Use C++ exception handling.
7181 * python/py-param.c: Use C++ exception handling.
7182 * python/py-objfile.c: Use C++ exception handling.
7183 * python/py-linetable.c: Use C++ exception handling.
7184 * python/py-lazy-string.c: Use C++ exception handling.
7185 * python/py-infthread.c: Use C++ exception handling.
7186 * python/py-inferior.c: Use C++ exception handling.
7187 * python/py-gdb-readline.c: Use C++ exception handling.
7188 * python/py-framefilter.c: Use C++ exception handling.
7189 * python/py-frame.c: Use C++ exception handling.
7190 * python/py-finishbreakpoint.c: Use C++ exception handling.
7191 * python/py-cmd.c: Use C++ exception handling.
7192 * python/py-breakpoint.c: Use C++ exception handling.
7193 * python/py-arch.c: Use C++ exception handling.
7194 * printcmd.c: Use C++ exception handling.
7195 * ppc-linux-tdep.c: Use C++ exception handling.
7196 * parse.c: Use C++ exception handling.
7197 * p-valprint.c: Use C++ exception handling.
7198 * objc-lang.c: Use C++ exception handling.
7199 * mi/mi-main.c: Use C++ exception handling.
7200 * mi/mi-interp.c: Use C++ exception handling.
7201 * mi/mi-cmd-stack.c: Use C++ exception handling.
7202 * mi/mi-cmd-break.c: Use C++ exception handling.
7203 * main.c: Use C++ exception handling.
7204 * linux-thread-db.c: Use C++ exception handling.
7205 * linux-tdep.c: Use C++ exception handling.
7206 * linux-nat.c: Use C++ exception handling.
7207 * linux-fork.c: Use C++ exception handling.
7208 * linespec.c: Use C++ exception handling.
7209 * language.c: Use C++ exception handling.
7210 * jit.c: Use C++ exception handling.
7211 * infrun.c: Use C++ exception handling.
7212 * infcmd.c: Use C++ exception handling.
7213 * infcall.c: Use C++ exception handling.
7214 * inf-loop.c: Use C++ exception handling.
7215 * i386-tdep.c: Use C++ exception handling.
7216 * i386-linux-tdep.c: Use C++ exception handling.
7217 * guile/scm-value.c: Use C++ exception handling.
7218 * guile/scm-type.c: Use C++ exception handling.
7219 * guile/scm-symtab.c: Use C++ exception handling.
7220 * guile/scm-symbol.c: Use C++ exception handling.
7221 * guile/scm-pretty-print.c: Use C++ exception handling.
7222 * guile/scm-ports.c: Use C++ exception handling.
7223 * guile/scm-param.c: Use C++ exception handling.
7224 * guile/scm-math.c: Use C++ exception handling.
7225 * guile/scm-lazy-string.c: Use C++ exception handling.
7226 * guile/scm-frame.c: Use C++ exception handling.
7227 * guile/scm-disasm.c: Use C++ exception handling.
7228 * guile/scm-cmd.c: Use C++ exception handling.
7229 * guile/scm-breakpoint.c: Use C++ exception handling.
7230 * guile/scm-block.c: Use C++ exception handling.
7231 * guile/guile-internal.h: Use C++ exception handling.
7232 * gnu-v3-abi.c: Use C++ exception handling.
7233 * gdbtypes.c: Use C++ exception handling.
7234 * frame.c: Use C++ exception handling.
7235 * frame-unwind.c: Use C++ exception handling.
7236 * fbsd-tdep.c: Use C++ exception handling.
7237 * f-valprint.c: Use C++ exception handling.
7238 * exec.c: Use C++ exception handling.
7239 * event-top.c: Use C++ exception handling.
7240 * event-loop.c: Use C++ exception handling.
7241 * eval.c: Use C++ exception handling.
7242 * dwarf2read.c: Use C++ exception handling.
7243 * dwarf2loc.c: Use C++ exception handling.
7244 * dwarf2-frame.c: Use C++ exception handling.
7245 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7246 * dwarf-index-write.c: Use C++ exception handling.
7247 * dwarf-index-cache.c: Use C++ exception handling.
7248 * dtrace-probe.c: Use C++ exception handling.
7249 * disasm-selftests.c: Use C++ exception handling.
7250 * darwin-nat.c: Use C++ exception handling.
7251 * cp-valprint.c: Use C++ exception handling.
7252 * cp-support.c: Use C++ exception handling.
7253 * cp-abi.c: Use C++ exception handling.
7254 * corelow.c: Use C++ exception handling.
7255 * completer.c: Use C++ exception handling.
7256 * compile/compile-object-run.c: Use C++ exception handling.
7257 * compile/compile-object-load.c: Use C++ exception handling.
7258 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7259 * compile/compile-c-symbols.c: Use C++ exception handling.
7260 * common/selftest.c: Use C++ exception handling.
7261 * common/new-op.c: Use C++ exception handling.
7262 * cli/cli-script.c: Use C++ exception handling.
7263 * cli/cli-interp.c: Use C++ exception handling.
7264 * cli/cli-cmds.c: Use C++ exception handling.
7265 * c-varobj.c: Use C++ exception handling.
7266 * btrace.c: Use C++ exception handling.
7267 * breakpoint.c: Use C++ exception handling.
7268 * break-catch-throw.c: Use C++ exception handling.
7269 * arch-utils.c: Use C++ exception handling.
7270 * amd64-tdep.c: Use C++ exception handling.
7271 * ada-valprint.c: Use C++ exception handling.
7272 * ada-typeprint.c: Use C++ exception handling.
7273 * ada-lang.c: Use C++ exception handling.
7274 * aarch64-tdep.c: Use C++ exception handling.
7276 2019-04-08 Tom Tromey <tom@tromey.com>
7278 * xml-support.c (gdb_xml_parser::parse): Update.
7279 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7280 * value.c (show_convenience): Update.
7281 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7282 (test_parse_flags_qcs): Update.
7283 * thread.c (thr_try_catch_cmd): Update.
7284 * target.c (target_translate_tls_address): Update.
7285 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7286 (info_frame_command_core, frame_apply_command_count): Update.
7287 * rust-exp.y (rust_lex_exception_test): Update.
7288 * riscv-tdep.c (riscv_print_one_register_info): Update.
7289 * remote.c (remote_target::enable_btrace): Update.
7290 * record-btrace.c (record_btrace_enable_warn): Update.
7291 * python/py-utils.c (gdbpy_convert_exception): Update.
7292 * printcmd.c (do_one_display, print_variable_and_value): Update.
7293 * mi/mi-main.c (mi_print_exception): Update.
7294 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7295 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7296 * linux-nat.c (linux_nat_target::attach): Update.
7297 * linux-fork.c (class scoped_switch_fork_info): Update.
7298 * infrun.c (displaced_step_prepare): Update.
7299 * infcall.c (call_function_by_hand_dummy): Update.
7300 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7301 * gnu-v3-abi.c (print_one_vtable): Update.
7302 * frame.c (get_prev_frame_always): Update.
7303 * f-valprint.c (info_common_command_for_block): Update.
7304 * exec.c (try_open_exec_file): Update.
7305 * exceptions.c (print_exception, exception_print)
7306 (exception_fprintf, exception_print_same): Update.
7307 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7308 * dwarf-index-cache.c (index_cache::store)
7309 (index_cache::lookup_gdb_index): Update.
7310 * darwin-nat.c (maybe_cache_shell): Update.
7311 * cp-valprint.c (cp_print_value_fields): Update.
7312 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7313 (gcc_cplus_symbol_address): Update.
7314 * compile/compile-c-symbols.c (gcc_convert_symbol)
7315 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7316 * common/selftest.c: Update.
7317 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7319 (exception_try_scope_entry, exception_try_scope_exit): Don't
7321 (struct exception_try_scope): Remove.
7322 (TRY): Don't use exception_try_scope.
7323 (struct gdb_exception): Add constructor, operator=.
7325 (struct gdb_exception_RETURN_MASK_ALL)
7326 (struct gdb_exception_RETURN_MASK_ERROR)
7327 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7328 (struct gdb_quit_bad_alloc): Update.
7329 * common/common-exceptions.c (exception_none): Change
7331 (struct catcher) <state, exception>: Initialize inline.
7332 <prev>: Remove member.
7333 (current_catcher): Remove.
7334 (catchers): New global.
7335 (exceptions_state_mc_init): Simplify.
7336 (catcher_pop): Remove.
7337 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7338 (try_scope_depth, exception_try_scope_entry)
7339 (exception_try_scope_exit): Remove.
7340 (throw_exception_sjlj): Update.
7341 (exception_messages, exception_messages_size): Remove.
7342 (throw_it): Simplify.
7343 (gdb_exception_sliced_copy): Remove.
7344 (throw_exception_cxx): Update.
7345 * cli/cli-script.c (script_from_file): Update.
7346 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7348 * ada-valprint.c (ada_val_print): Update.
7349 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7350 (create_excep_cond_exprs): Update.
7352 2019-04-08 Tom Tromey <tom@tromey.com>
7354 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7355 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7356 (TRY, CATCH, END_CATCH): Remove some definitions.
7357 * common/common-exceptions.c: Don't use GDB_XCPT.
7358 (catcher_list_size): Remove.
7359 (throw_exception, throw_it): Simplify.
7361 2019-04-05 Tom Tromey <tom@tromey.com>
7363 Revert the header-sorting patch.
7364 * ft32-tdep.c: Revert.
7365 * frv-tdep.c: Revert.
7366 * frv-linux-tdep.c: Revert.
7368 * frame-unwind.c: Revert.
7369 * frame-base.c: Revert.
7370 * fork-child.c: Revert.
7371 * findvar.c: Revert.
7372 * findcmd.c: Revert.
7373 * filesystem.c: Revert.
7374 * filename-seen-cache.h: Revert.
7375 * filename-seen-cache.c: Revert.
7376 * fbsd-tdep.c: Revert.
7377 * fbsd-nat.h: Revert.
7378 * fbsd-nat.c: Revert.
7379 * f-valprint.c: Revert.
7380 * f-typeprint.c: Revert.
7382 * extension.h: Revert.
7383 * extension.c: Revert.
7384 * extension-priv.h: Revert.
7385 * expprint.c: Revert.
7388 * exceptions.c: Revert.
7389 * event-top.c: Revert.
7390 * event-loop.c: Revert.
7392 * elfread.c: Revert.
7393 * dwarf2read.h: Revert.
7394 * dwarf2read.c: Revert.
7395 * dwarf2loc.c: Revert.
7396 * dwarf2expr.h: Revert.
7397 * dwarf2expr.c: Revert.
7398 * dwarf2-frame.c: Revert.
7399 * dwarf2-frame-tailcall.c: Revert.
7400 * dwarf-index-write.h: Revert.
7401 * dwarf-index-write.c: Revert.
7402 * dwarf-index-common.c: Revert.
7403 * dwarf-index-cache.h: Revert.
7404 * dwarf-index-cache.c: Revert.
7405 * dummy-frame.c: Revert.
7406 * dtrace-probe.c: Revert.
7409 * disasm-selftests.c: Revert.
7410 * dictionary.c: Revert.
7411 * dicos-tdep.c: Revert.
7412 * demangle.c: Revert.
7415 * darwin-nat.h: Revert.
7416 * darwin-nat.c: Revert.
7417 * darwin-nat-info.c: Revert.
7418 * d-valprint.c: Revert.
7419 * d-namespace.c: Revert.
7422 * csky-tdep.c: Revert.
7423 * csky-linux-tdep.c: Revert.
7424 * cris-tdep.c: Revert.
7425 * cris-linux-tdep.c: Revert.
7426 * cp-valprint.c: Revert.
7427 * cp-support.c: Revert.
7428 * cp-namespace.c: Revert.
7430 * corelow.c: Revert.
7431 * corefile.c: Revert.
7432 * continuations.c: Revert.
7433 * completer.h: Revert.
7434 * completer.c: Revert.
7435 * complaints.c: Revert.
7436 * coffread.c: Revert.
7437 * coff-pe-read.c: Revert.
7438 * cli-out.h: Revert.
7439 * cli-out.c: Revert.
7440 * charset.c: Revert.
7441 * c-varobj.c: Revert.
7442 * c-valprint.c: Revert.
7443 * c-typeprint.c: Revert.
7445 * buildsym.c: Revert.
7446 * buildsym-legacy.c: Revert.
7447 * build-id.h: Revert.
7448 * build-id.c: Revert.
7450 * bsd-uthread.c: Revert.
7451 * breakpoint.h: Revert.
7452 * breakpoint.c: Revert.
7453 * break-catch-throw.c: Revert.
7454 * break-catch-syscall.c: Revert.
7455 * break-catch-sig.c: Revert.
7456 * blockframe.c: Revert.
7458 * bfin-tdep.c: Revert.
7459 * bfin-linux-tdep.c: Revert.
7460 * bfd-target.c: Revert.
7462 * ax-general.c: Revert.
7465 * avr-tdep.c: Revert.
7467 * auto-load.c: Revert.
7468 * arm-wince-tdep.c: Revert.
7469 * arm-tdep.c: Revert.
7470 * arm-symbian-tdep.c: Revert.
7471 * arm-pikeos-tdep.c: Revert.
7472 * arm-obsd-tdep.c: Revert.
7473 * arm-nbsd-tdep.c: Revert.
7474 * arm-nbsd-nat.c: Revert.
7475 * arm-linux-tdep.c: Revert.
7476 * arm-linux-nat.c: Revert.
7477 * arm-fbsd-tdep.c: Revert.
7478 * arm-fbsd-nat.c: Revert.
7479 * arm-bsd-tdep.c: Revert.
7480 * arch-utils.c: Revert.
7481 * arc-tdep.c: Revert.
7482 * arc-newlib-tdep.c: Revert.
7483 * annotate.h: Revert.
7484 * annotate.c: Revert.
7485 * amd64-windows-tdep.c: Revert.
7486 * amd64-windows-nat.c: Revert.
7487 * amd64-tdep.c: Revert.
7488 * amd64-sol2-tdep.c: Revert.
7489 * amd64-obsd-tdep.c: Revert.
7490 * amd64-obsd-nat.c: Revert.
7491 * amd64-nbsd-tdep.c: Revert.
7492 * amd64-nbsd-nat.c: Revert.
7493 * amd64-nat.c: Revert.
7494 * amd64-linux-tdep.c: Revert.
7495 * amd64-linux-nat.c: Revert.
7496 * amd64-fbsd-tdep.c: Revert.
7497 * amd64-fbsd-nat.c: Revert.
7498 * amd64-dicos-tdep.c: Revert.
7499 * amd64-darwin-tdep.c: Revert.
7500 * amd64-bsd-nat.c: Revert.
7501 * alpha-tdep.c: Revert.
7502 * alpha-obsd-tdep.c: Revert.
7503 * alpha-nbsd-tdep.c: Revert.
7504 * alpha-mdebug-tdep.c: Revert.
7505 * alpha-linux-tdep.c: Revert.
7506 * alpha-linux-nat.c: Revert.
7507 * alpha-bsd-tdep.c: Revert.
7508 * alpha-bsd-nat.c: Revert.
7509 * aix-thread.c: Revert.
7511 * addrmap.c: Revert.
7512 * ada-varobj.c: Revert.
7513 * ada-valprint.c: Revert.
7514 * ada-typeprint.c: Revert.
7515 * ada-tasks.c: Revert.
7516 * ada-lang.c: Revert.
7517 * aarch64-tdep.c: Revert.
7518 * aarch64-ravenscar-thread.c: Revert.
7519 * aarch64-newlib-tdep.c: Revert.
7520 * aarch64-linux-tdep.c: Revert.
7521 * aarch64-linux-nat.c: Revert.
7522 * aarch64-fbsd-tdep.c: Revert.
7523 * aarch64-fbsd-nat.c: Revert.
7524 * aarch32-linux-nat.c: Revert.
7526 2019-04-05 Tom Tromey <tom@tromey.com>
7528 * ft32-tdep.c: Sort headers.
7529 * frv-tdep.c: Sort headers.
7530 * frv-linux-tdep.c: Sort headers.
7531 * frame.c: Sort headers.
7532 * frame-unwind.c: Sort headers.
7533 * frame-base.c: Sort headers.
7534 * fork-child.c: Sort headers.
7535 * findvar.c: Sort headers.
7536 * findcmd.c: Sort headers.
7537 * filesystem.c: Sort headers.
7538 * filename-seen-cache.h: Sort headers.
7539 * filename-seen-cache.c: Sort headers.
7540 * fbsd-tdep.c: Sort headers.
7541 * fbsd-nat.h: Sort headers.
7542 * fbsd-nat.c: Sort headers.
7543 * f-valprint.c: Sort headers.
7544 * f-typeprint.c: Sort headers.
7545 * f-lang.c: Sort headers.
7546 * extension.h: Sort headers.
7547 * extension.c: Sort headers.
7548 * extension-priv.h: Sort headers.
7549 * expprint.c: Sort headers.
7550 * exec.h: Sort headers.
7551 * exec.c: Sort headers.
7552 * exceptions.c: Sort headers.
7553 * event-top.c: Sort headers.
7554 * event-loop.c: Sort headers.
7555 * eval.c: Sort headers.
7556 * elfread.c: Sort headers.
7557 * dwarf2read.h: Sort headers.
7558 * dwarf2read.c: Sort headers.
7559 * dwarf2loc.c: Sort headers.
7560 * dwarf2expr.h: Sort headers.
7561 * dwarf2expr.c: Sort headers.
7562 * dwarf2-frame.c: Sort headers.
7563 * dwarf2-frame-tailcall.c: Sort headers.
7564 * dwarf-index-write.h: Sort headers.
7565 * dwarf-index-write.c: Sort headers.
7566 * dwarf-index-common.c: Sort headers.
7567 * dwarf-index-cache.h: Sort headers.
7568 * dwarf-index-cache.c: Sort headers.
7569 * dummy-frame.c: Sort headers.
7570 * dtrace-probe.c: Sort headers.
7571 * disasm.h: Sort headers.
7572 * disasm.c: Sort headers.
7573 * disasm-selftests.c: Sort headers.
7574 * dictionary.c: Sort headers.
7575 * dicos-tdep.c: Sort headers.
7576 * demangle.c: Sort headers.
7577 * dcache.h: Sort headers.
7578 * dcache.c: Sort headers.
7579 * darwin-nat.h: Sort headers.
7580 * darwin-nat.c: Sort headers.
7581 * darwin-nat-info.c: Sort headers.
7582 * d-valprint.c: Sort headers.
7583 * d-namespace.c: Sort headers.
7584 * d-lang.c: Sort headers.
7585 * ctf.c: Sort headers.
7586 * csky-tdep.c: Sort headers.
7587 * csky-linux-tdep.c: Sort headers.
7588 * cris-tdep.c: Sort headers.
7589 * cris-linux-tdep.c: Sort headers.
7590 * cp-valprint.c: Sort headers.
7591 * cp-support.c: Sort headers.
7592 * cp-namespace.c: Sort headers.
7593 * cp-abi.c: Sort headers.
7594 * corelow.c: Sort headers.
7595 * corefile.c: Sort headers.
7596 * continuations.c: Sort headers.
7597 * completer.h: Sort headers.
7598 * completer.c: Sort headers.
7599 * complaints.c: Sort headers.
7600 * coffread.c: Sort headers.
7601 * coff-pe-read.c: Sort headers.
7602 * cli-out.h: Sort headers.
7603 * cli-out.c: Sort headers.
7604 * charset.c: Sort headers.
7605 * c-varobj.c: Sort headers.
7606 * c-valprint.c: Sort headers.
7607 * c-typeprint.c: Sort headers.
7608 * c-lang.c: Sort headers.
7609 * buildsym.c: Sort headers.
7610 * buildsym-legacy.c: Sort headers.
7611 * build-id.h: Sort headers.
7612 * build-id.c: Sort headers.
7613 * btrace.c: Sort headers.
7614 * bsd-uthread.c: Sort headers.
7615 * breakpoint.h: Sort headers.
7616 * breakpoint.c: Sort headers.
7617 * break-catch-throw.c: Sort headers.
7618 * break-catch-syscall.c: Sort headers.
7619 * break-catch-sig.c: Sort headers.
7620 * blockframe.c: Sort headers.
7621 * block.c: Sort headers.
7622 * bfin-tdep.c: Sort headers.
7623 * bfin-linux-tdep.c: Sort headers.
7624 * bfd-target.c: Sort headers.
7625 * bcache.c: Sort headers.
7626 * ax-general.c: Sort headers.
7627 * ax-gdb.h: Sort headers.
7628 * ax-gdb.c: Sort headers.
7629 * avr-tdep.c: Sort headers.
7630 * auxv.c: Sort headers.
7631 * auto-load.c: Sort headers.
7632 * arm-wince-tdep.c: Sort headers.
7633 * arm-tdep.c: Sort headers.
7634 * arm-symbian-tdep.c: Sort headers.
7635 * arm-pikeos-tdep.c: Sort headers.
7636 * arm-obsd-tdep.c: Sort headers.
7637 * arm-nbsd-tdep.c: Sort headers.
7638 * arm-nbsd-nat.c: Sort headers.
7639 * arm-linux-tdep.c: Sort headers.
7640 * arm-linux-nat.c: Sort headers.
7641 * arm-fbsd-tdep.c: Sort headers.
7642 * arm-fbsd-nat.c: Sort headers.
7643 * arm-bsd-tdep.c: Sort headers.
7644 * arch-utils.c: Sort headers.
7645 * arc-tdep.c: Sort headers.
7646 * arc-newlib-tdep.c: Sort headers.
7647 * annotate.h: Sort headers.
7648 * annotate.c: Sort headers.
7649 * amd64-windows-tdep.c: Sort headers.
7650 * amd64-windows-nat.c: Sort headers.
7651 * amd64-tdep.c: Sort headers.
7652 * amd64-sol2-tdep.c: Sort headers.
7653 * amd64-obsd-tdep.c: Sort headers.
7654 * amd64-obsd-nat.c: Sort headers.
7655 * amd64-nbsd-tdep.c: Sort headers.
7656 * amd64-nbsd-nat.c: Sort headers.
7657 * amd64-nat.c: Sort headers.
7658 * amd64-linux-tdep.c: Sort headers.
7659 * amd64-linux-nat.c: Sort headers.
7660 * amd64-fbsd-tdep.c: Sort headers.
7661 * amd64-fbsd-nat.c: Sort headers.
7662 * amd64-dicos-tdep.c: Sort headers.
7663 * amd64-darwin-tdep.c: Sort headers.
7664 * amd64-bsd-nat.c: Sort headers.
7665 * alpha-tdep.c: Sort headers.
7666 * alpha-obsd-tdep.c: Sort headers.
7667 * alpha-nbsd-tdep.c: Sort headers.
7668 * alpha-mdebug-tdep.c: Sort headers.
7669 * alpha-linux-tdep.c: Sort headers.
7670 * alpha-linux-nat.c: Sort headers.
7671 * alpha-bsd-tdep.c: Sort headers.
7672 * alpha-bsd-nat.c: Sort headers.
7673 * aix-thread.c: Sort headers.
7674 * agent.c: Sort headers.
7675 * addrmap.c: Sort headers.
7676 * ada-varobj.c: Sort headers.
7677 * ada-valprint.c: Sort headers.
7678 * ada-typeprint.c: Sort headers.
7679 * ada-tasks.c: Sort headers.
7680 * ada-lang.c: Sort headers.
7681 * aarch64-tdep.c: Sort headers.
7682 * aarch64-ravenscar-thread.c: Sort headers.
7683 * aarch64-newlib-tdep.c: Sort headers.
7684 * aarch64-linux-tdep.c: Sort headers.
7685 * aarch64-linux-nat.c: Sort headers.
7686 * aarch64-fbsd-tdep.c: Sort headers.
7687 * aarch64-fbsd-nat.c: Sort headers.
7688 * aarch32-linux-nat.c: Sort headers.
7690 2019-04-04 Tom Tromey <tom@tromey.com>
7692 * varobj.c (varobj_create): Update.
7693 * rust-exp.y (struct rust_parser) <update_innermost_block,
7694 lookup_symbol>: New methods.
7695 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7697 (rust_parser::rust_lookup_type)
7698 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7699 * printcmd.c (display_command, do_one_display): Update.
7700 * parser-defs.h (struct parser_state) <parser_state>: Add
7701 "tracker" parameter.
7702 (block_tracker): New member.
7703 (class innermost_block_tracker) <innermost_block_tracker>: Add
7705 <reset>: Remove method.
7706 (innermost_block): Don't declare.
7707 (null_post_parser): Update.
7708 * parse.c (innermost_block): Remove global.
7709 (write_dollar_variable): Update.
7710 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7711 Remove "tracker_types" parameter.
7712 (parse_expression): Add "tracker" parameter.
7713 (parse_expression_for_completion): Update.
7714 (null_post_parser): Add "tracker" parameter.
7715 * p-exp.y: Update rules.
7716 * m2-exp.y: Update rules.
7717 * language.h (struct language_defn) <la_post_parser>: Add
7718 "tracker" parameter.
7719 * go-exp.y: Update rules.
7720 * f-exp.y: Update rules.
7721 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7723 * d-exp.y: Update rules.
7724 * c-exp.y: Update rules.
7725 * breakpoint.c (set_breakpoint_condition): Create an
7726 innermost_block_tracker.
7727 (watch_command_1): Likewise.
7728 * ada-lang.c (resolve): Add "tracker" parameter.
7729 (resolve_subexp): Likewise.
7730 * ada-exp.y (write_var_from_sym): Update.
7732 2019-04-04 Tom Tromey <tom@tromey.com>
7734 * type-stack.h: New file.
7735 * type-stack.c: New file.
7736 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7738 (insert_into_type_stack, insert_type, push_type, push_type_int)
7739 (insert_type_address_space, pop_type, pop_type_int)
7740 (pop_typelist, pop_type_stack, append_type_stack)
7741 (push_type_stack, get_type_stack, push_typelist)
7742 (follow_type_instance_flags, follow_types): Don't declare.
7743 * parse.c (type_stack): Remove global.
7744 (parse_exp_in_context): Update.
7745 (insert_into_type_stack, insert_type, push_type, push_type_int)
7746 (insert_type_address_space, pop_type, pop_type_int)
7747 (pop_typelist, pop_type_stack, append_type_stack)
7748 (push_type_stack, get_type_stack, push_typelist)
7749 (follow_type_instance_flags, follow_types): Remove (moved to
7751 * f-exp.y (type_stack): New global.
7753 (push_kind_type, f_parse): Update.
7754 * d-exp.y (type_stack): New global.
7757 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7759 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7760 (HFILES_NO_SRCDIR): Add type-stack.h.
7762 2019-04-04 Tom Tromey <tom@tromey.com>
7764 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7765 (rust_parser::convert_ast_to_expression, rust_parse)
7766 (rust_lex_test_completion, rust_lex_tests): Update.
7767 * parser-defs.h (struct expr_completion_state): New.
7768 (struct parser_state) <parser_state>: Add completion parameter.
7769 <mark_struct_expression, mark_completion_tag>: New methods.
7770 <parse_completion, m_completion_state>: New members.
7771 (prefixify_expression, null_post_parser): Update.
7772 (mark_struct_expression, mark_completion_tag): Don't declare.
7773 * parse.c (parse_completion, expout_last_struct)
7774 (expout_tag_completion_type, expout_completion_name): Remove
7776 (parser_state::mark_struct_expression)
7777 (parser_state::mark_completion_tag): Now methods.
7778 (prefixify_expression): Add last_struct parameter.
7779 (prefixify_subexp): Likewise.
7780 (parse_exp_1): Update.
7781 (parse_exp_in_context): Add cstate parameter. Update.
7782 (parse_expression_for_completion): Create an
7783 expr_completion_state.
7784 (null_post_parser): Add "completion" parameter.
7785 * p-exp.y: Update rules.
7787 * language.h (struct language_defn) <la_post_parser>: Add
7788 "completing" parameter.
7789 * go-exp.y: Update rules.
7790 (lex_one_token): Update.
7791 * expression.h (parse_completion): Don't declare.
7792 * d-exp.y: Update rules.
7793 (lex_one_token): Update rules.
7794 * c-exp.y: Update rules.
7795 (lex_one_token): Update.
7796 * ada-lang.c (resolve): Add "parse_completion" parameter.
7797 (resolve_subexp): Likewise.
7798 (ada_resolve_function): Likewise.
7800 2019-04-04 Tom Tromey <tom@tromey.com>
7802 * parser-defs.h (struct parser_state) <start_arglist,
7803 end_arglist>: New methods.
7804 <arglist_len, m_funcall_chain>: New members.
7805 (arglist_len, start_arglist, end_arglist): Don't declare.
7806 * parse.c (arglist_len, funcall_chain): Remove global.
7807 (start_arglist, end_arglist): Remove functions.
7808 (parse_exp_in_context): Update.
7809 * p-exp.y: Update rules.
7810 * m2-exp.y: Update rules.
7811 * go-exp.y: Update rules.
7812 * f-exp.y: Update rules.
7813 * d-exp.y: Update rules.
7814 * c-exp.y: Update rules.
7816 2019-04-04 Tom Tromey <tom@tromey.com>
7818 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7819 lex_operator, push_back>: New methods.
7821 (rust_parser::lex_hex, lex_escape): Rename and update.
7822 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7823 (rust_parser::lex_operator): Rename and update.
7824 (rust_parser::lex_number, rustyylex, rustyyerror)
7825 (rust_lex_test_init, rust_lex_test_sequence)
7826 (rust_lex_test_push_back, rust_lex_tests): Update.
7827 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7829 <lexptr, prev_lexptr>: New members.
7830 (lexptr, prev_lexptr): Don't declare.
7831 * parse.c (lexptr, prev_lexptr): Remove globals.
7832 (parse_exp_in_context): Update.
7833 * p-exp.y (yylex, yyerror): Update.
7834 * m2-exp.y (parse_number, yylex, yyerror): Update.
7835 * go-exp.y (lex_one_token, yyerror): Update.
7836 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7837 * d-exp.y (lex_one_token, yyerror): Update.
7838 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7839 (lex_one_token, yyerror): Update.
7840 * ada-lex.l (YY_INPUT): Update.
7841 (rewind_to_char): Update.
7842 * ada-exp.y (yyerror): Update.
7844 2019-04-04 Tom Tromey <tom@tromey.com>
7846 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7847 * parser-defs.h (struct parser_state) <parser_state>: Add new
7849 <comma_terminates>: New member.
7850 (comma_terminates): Don't declare global.
7851 * parse.c (comma_terminates): Remove global.
7852 (parse_exp_in_context): Update.
7853 * p-exp.y (yylex): Update.
7854 * m2-exp.y (yylex): Update.
7855 * go-exp.y (lex_one_token): Update.
7856 * f-exp.y (yylex): Update.
7857 * d-exp.y (lex_one_token): Update.
7858 * c-exp.y (lex_one_token): Update.
7859 * ada-lex.l: Update.
7861 2019-04-04 Tom Tromey <tom@tromey.com>
7863 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7864 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7865 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7866 * parser-defs.h (paren_depth): Don't declare.
7867 * parse.c (paren_depth): Remove global.
7868 (parse_exp_in_context): Update.
7869 * p-exp.y (paren_depth): New global.
7870 (pascal_parse): Initialize it.
7871 * m2-exp.y (paren_depth): New global.
7872 (m2_parse): Initialize it.
7873 * go-exp.y (paren_depth): New global.
7874 (go_parse): Initialize it.
7875 * f-exp.y (paren_depth): New global.
7876 (f_parse): Initialize it.
7877 * d-exp.y (paren_depth): New global.
7878 (d_parse): Initialize it.
7879 * c-exp.y (paren_depth): New global.
7880 (c_parse): Initialize it.
7881 * ada-lex.l (paren_depth): New global.
7882 (lexer_init): Initialize it.
7884 2019-04-04 Tom Tromey <tom@tromey.com>
7886 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7887 (rust_parser::convert_ast_to_type)
7888 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7889 * parser-defs.h (struct parser_state) <parser_state>: Add
7890 parameters. Initialize new members.
7891 <expression_context_block, expression_context_pc>: New members.
7892 * parse.c (expression_context_block, expression_context_pc):
7894 (parse_exp_in_context): Update.
7895 * p-exp.y: Update all rules.
7897 * m2-exp.y: Update all rules.
7899 * go-exp.y (yylex): Update.
7900 * f-exp.y (yylex): Update.
7901 * d-exp.y: Update all rules.
7903 * c-exp.y: Update all rules.
7904 (lex_one_token, classify_name, yylex, c_parse): Update.
7905 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7907 2019-04-04 Tom Tromey <tom@tromey.com>
7909 * gdbarch.h, gdbarch.c: Rebuild.
7910 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7912 (struct stap_parse_info): Replace "parser_state" with
7914 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7915 (parser_state): New class.
7916 * parse.c (expr_builder): Rename.
7917 (expr_builder::release): Rename.
7918 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7919 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7920 (write_exp_elt_longcst, write_exp_elt_floatcst)
7921 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7922 (write_exp_string_vector, write_exp_bitstring)
7923 (write_exp_msymbol, mark_struct_expression)
7924 (write_dollar_variable)
7925 (insert_type_address_space, increase_expout_size): Replace
7926 "parser_state" with "expr_builder".
7927 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7928 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7929 "parser_state" with "expr_builder".
7931 2019-04-04 Tom Tromey <tom@tromey.com>
7933 * rust-exp.y: Replace "parse_language" with method call.
7935 (yylex): Replace "parse_language" with method call.
7937 (yylex): Replace "parse_language" with method call.
7938 * go-exp.y (classify_name): Replace "parse_language" with method
7940 * f-exp.y (yylex): Replace "parse_language" with method call.
7941 * d-exp.y (lex_one_token): Replace "parse_language" with method
7944 (lex_one_token, classify_name, yylex): Replace "parse_language"
7946 * ada-exp.y (find_primitive_type, type_char)
7947 (type_system_address): Replace "parse_language" with method call.
7949 2019-04-04 Tom Tromey <tom@tromey.com>
7951 * rust-exp.y: Replace "parse_gdbarch" with method call.
7952 * parse.c (write_dollar_variable, insert_type_address_space):
7953 Replace "parse_gdbarch" with method call.
7954 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7956 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7958 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7959 "parse_gdbarch" with method call.
7960 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7962 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7963 "parse_gdbarch" with method call.
7964 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7965 "parse_gdbarch" with method call.
7966 * c-exp.y (parse_type, parse_number, classify_name): Replace
7967 "parse_gdbarch" with method call.
7968 * ada-lex.l: Replace "parse_gdbarch" with method call.
7969 * ada-exp.y (parse_type, find_primitive_type, type_char)
7970 (type_system_address): Replace "parse_gdbarch" with method call.
7972 2019-04-04 Tom Tromey <tom@tromey.com>
7974 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7975 * stap-probe.c (stap_parse_argument): Update.
7976 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7977 initial_size parameter.
7978 * rust-exp.y (rust_lex_tests): Update.
7979 * parse.c (parser_state): Update.
7980 (parse_exp_in_context): Update.
7981 * parser-defs.h (struct parser_state) <parser_state>: Remove
7982 "initial_size" parameter.
7984 2019-04-04 Tom Tromey <tom@tromey.com>
7986 * parser-defs.h (increase_expout_size): Don't declare.
7987 * parse.c (increase_expout_size): Now static.
7989 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7991 * gnu-nat.c (gnu_nat_target::wait): Fix
7992 target_waitstatus_to_string call.
7994 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7996 * eval.c (evaluate_subexp_standard): Handle internal functions
7997 during Fortran function call handling.
7999 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8001 * NEWS: Mention new internal functions.
8002 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8003 (read_base_type): Use dwarf2_init_complex_target_type.
8004 * value.c (creal_internal_fn): New function.
8005 (cimag_internal_fn): New function.
8006 (_initialize_values): Register new internal functions.
8008 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8010 * infrun.c (stop_all_threads): If debug_infrun, always
8011 trace the wait status after wait_one, using
8012 target_waitstatus_to_string and target_pid_to_str.
8013 (handle_inferior_event): Replace various trace of
8014 wait status kind by a single trace.
8015 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8016 wait status kind image by target_waitstatus_to_string.
8017 * target/waitstatus.c (target_waitstatus_to_string): Fix
8020 2019-04-01 Tom Tromey <tromey@adacore.com>
8023 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8025 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8026 Pedro Alves <palves@redhat.com>
8028 * top.c (quit_force): Call 'finalize_values'.
8029 * value.c (finalize_values): New function.
8030 * value.h (finalize_values): Declare.
8032 2019-03-30 Eli Zaretskii <eliz@gnu.org>
8034 * NEWS: Announce $_gdb_major and $_gdb_minor.
8036 * top.c (init_gdb_version_vars): New function.
8037 (gdb_init): Call init_gdb_version_vars.
8039 2019-03-29 Tom Tromey <tromey@adacore.com>
8041 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8042 help text. Remove dead code.
8044 2019-03-29 Keith Seitz <keiths@redhat.com>
8046 From Siddhesh Poyarekar:
8047 * f-lang.h (f77_get_upperbound): Return LONGEST.
8048 (f77_get_lowerbound): Likewise.
8049 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8050 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8052 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8053 plongest to format print it.
8054 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8055 (f77_get_upperbound): Likewise.
8056 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8057 LOWER_BOUND to LONGEST.
8058 (f77_create_arrayprint_offset_tbl): Likewise.
8060 2019-03-29 Keith Seitz <keiths@redhat.com>
8062 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8063 %s/pulongest for TYPE_LENGTH instead of %d in format
8065 * ada-typerint.c (ada_print_type): Likewise.
8066 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8067 * compile/compile-c-support.c (generate_register_struct): Likewise.
8068 * gdbtypes.c (recursive_dump_type): Likewise.
8069 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8070 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8071 instead of %d in format strings.
8072 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8073 to std::min to ULONGEST.
8074 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8075 instead of %d in format strings.
8076 * tracepoint.c (info_scope_command): Likewise.
8077 * typeprint.c (print_offset_data::update)
8078 (print_offset_data::finish): Likewise.
8079 * xtensa-tdep.c (xtensa_store_return_value)
8080 (xtensa_push_dummy_call): Likewise.
8082 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8084 * windows-nat.c (display_selector): Fixed format specifications
8087 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8089 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8091 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8093 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8094 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8095 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8096 (nios2_linux_init_abi): Install it.
8098 2019-03-28 Alan Hayward <alan.hayward@arm.com>
8100 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8102 2019-03-28 Alan Hayward <alan.hayward@arm.com>
8104 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8106 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8107 Tom Tromey <tromey@adacore.com>
8109 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8111 2019-03-26 Joel Brobecker <brobecker@adacore.com>
8113 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8114 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8115 method to compute the bounds of range types. Also print "[evaluated]"
8116 if the bounds' values come from a dynamic evaluation.
8118 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8120 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8121 whitespace when pretty printing is on.
8123 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8125 * ppc-linux-nat.c: Add include.
8127 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8129 * NEWS: Mention AArch64 Pointer Authentication.
8131 2019-03-26 Alan Hayward <alan.hayward@arm.com>
8133 * arm-linux-nat.c: Add include.
8135 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8137 * source-cache.c (source_cache::get_source_lines): Re-read
8138 fullname after calling open_source_file.
8140 2019-03-25 John Baldwin <jhb@FreeBSD.org>
8142 * NEWS: Mention TLS support for FreeBSD.
8144 2019-03-25 Tom Tromey <tromey@adacore.com>
8146 * minsyms.c (BUNCH_SIZE): Update comment.
8147 (~minimal_symbol_reader): Remove old comment.
8148 (compact_minimal_symbols): Update comment.
8149 (minimal_symbol_reader::install): Remove old comment. Update
8152 2019-03-25 Alan Hayward <alan.hayward@arm.com>
8154 * s390-linux-nat.c: Add include.
8156 2019-03-25 Alan Hayward <alan.hayward@arm.com>
8158 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8159 Call linux_get_hwcap.
8160 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8162 (aarch64_linux_get_hwcap): Remove function.
8163 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8165 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8167 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8168 * linux-tdep.c (linux_get_hwcap): Add function.
8169 (linux_get_hwcap2): Likewise.
8170 * linux-tdep.h (linux_get_hwcap): Add declaration.
8171 (linux_get_hwcap2): Likewise.
8172 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8173 (ppc_linux_get_hwcap2): Likewise.
8174 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8176 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8177 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8178 (ppc_linux_nat_target::read_description): Likewise.
8179 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8180 * s390-linux-nat.c: Likewise.
8181 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8183 2019-03-24 Tom Tromey <tom@tromey.com>
8185 * ada-lang.c (standard_lookup): Simplify initialization.
8186 (ada_lookup_symbol_nonlocal): Simplify return.
8187 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8188 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8189 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8190 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8192 * solib.c (solib_global_lookup): Simplify.
8193 * symtab.c (null_block_symbol): Remove.
8194 (symbol_cache_lookup): Simplify returns.
8195 (lookup_language_this): Simplify returns.
8196 (lookup_symbol_aux): Simplify return.
8197 (lookup_local_symbol): Simplify returns.
8198 (lookup_global_symbol_from_objfile): Simplify return.
8199 (lookup_symbol_in_objfile_symtabs)
8200 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8201 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8202 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8203 * cp-namespace.c (cp_lookup_bare_symbol)
8204 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8205 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8206 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8207 (cp_lookup_symbol_via_imports): Simplify initialization.
8208 (find_symbol_in_baseclass): Likewise.
8209 * symtab.h (null_block_symbol): Remove.
8210 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8211 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8212 (d_lookup_symbol_module): Likewise.
8213 (find_symbol_in_baseclass): Simplify initialization.
8215 2019-03-24 Tom Tromey <tom@tromey.com>
8217 * expression.h: Don't include symtab.h.
8218 (struct block): Forward declare.
8220 2019-03-24 Tom Tromey <tom@tromey.com>
8222 * c-exp.y (typebase): Remove casts.
8223 * gdbtypes.c (lookup_unsigned_typename, )
8224 (lookup_signed_typename): Remove cast.
8225 * eval.c (parse_to_comma_and_eval): Remove cast.
8226 * parse.c (write_dollar_variable): Remove cast.
8227 * block.h (struct block) <superblock>: Now const.
8228 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8229 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8230 (map_block): Make "block" const.
8231 * symfile.h (struct quick_symbol_functions)
8232 <map_matching_symbols>: Constify block argument to "callback".
8233 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8235 (find_pc_sect_compunit_symtab): Make "b" const.
8236 (find_symbol_at_address): Likewise.
8237 (search_symbols): Likewise.
8238 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8239 (dw2_debug_names_lookup_symbol): Likewise.
8240 (dw2_map_matching_symbols): Update.
8241 * p-valprint.c (pascal_val_print): Remove "block".
8242 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8243 (aux_add_nonlocal_symbols): Make "block" const.
8244 (resolve_subexp): Remove cast.
8245 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8247 (iterate_over_file_blocks): Likewise.
8248 * f-exp.y (%union) <bval>: Remove.
8249 * coffread.c (patch_opaque_types): Make "b" const.
8250 * spu-tdep.c (spu_catch_start): Make "block" const.
8251 * c-valprint.c (print_unpacked_pointer): Remove "block".
8252 * symmisc.c (dump_symtab_1): Make "b" const.
8253 (block_depth): Make "block" const.
8254 * d-exp.y (%union) <bval>: Remove.
8255 * cp-support.h (cp_lookup_rtti_type): Update.
8256 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8257 * psymtab.c (psym_lookup_symbol): Make "block" const.
8258 (maintenance_check_psymtabs): Make "b" const.
8259 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8260 (enumerate_locals, enumerate_args): Update.
8261 * python/py-symtab.c (stpy_global_block): Make "block" const.
8262 (stpy_static_block): Likewise.
8263 * inline-frame.c (block_starting_point_at): Make "new_block"
8265 * block.c (find_block_in_blockvector): Make return type const.
8266 (blockvector_for_pc_sect): Make "b" const.
8267 (find_block_in_blockvector): Make "b" const.
8269 2019-03-23 Tom Tromey <tom@tromey.com>
8271 * varobj.c (varobj_create): Update.
8272 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8273 * printcmd.c (display_command, do_one_display): Don't reset
8275 * parser-defs.h (enum innermost_block_tracker_type): Move to
8277 (innermost_block): Update comment.
8278 * parse.c (parse_exp_1): Add tracker_types parameter.
8279 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8280 tracker_types parameter. Reset innermost_block.
8281 (parse_exp_in_context): Remove.
8282 (parse_expression_for_completion): Update.
8283 * objfiles.c (~objfile): Don't reset expression_context_block or
8285 * expression.h (enum innermost_block_tracker_type): Move from
8287 (parse_exp_1): Add tracker_types parameter.
8288 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8289 reset innermost_block.
8291 2019-03-23 Tom Tromey <tom@tromey.com>
8293 * objfiles.h: Include bcache.h.
8295 2019-03-23 Tom Tromey <tom@tromey.com>
8297 * linespec.c (get_current_search_block): Use
8298 scoped_restore_current_language.
8299 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8301 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8302 Jiong Wang <jiong.wang@arm.com>
8304 * aarch64-linux-tdep.c
8305 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8307 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8309 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8310 Jiong Wang <jiong.wang@arm.com>
8312 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8314 (aarch64_analyze_prologue_test): Add PACIASP test.
8315 (aarch64_prologue_prev_register): Unmask PC value.
8317 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8318 Jiong Wang <jiong.wang@arm.com>
8320 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8321 (aarch64_dwarf2_prev_register): Unmask PC value.
8322 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8323 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8324 DW_CFA_AARCH64_negate_ra_state.
8325 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8327 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8328 Jiong Wang <jiong.wang@arm.com>
8330 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8332 (aarch64_pseudo_register_name): Likewise.
8333 (aarch64_pseudo_register_type): Likewise.
8334 (aarch64_pseudo_register_reggroup_p): Likewise.
8335 (aarch64_gdbarch_init): Add pauth registers.
8336 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8337 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8338 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8339 (struct gdbarch_tdep): Add regnum for ra_state.
8341 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8342 Jiong Wang <jiong.wang@arm.com>
8344 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8346 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8347 Jiong Wang <jiong.wang@arm.com>
8349 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8351 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8352 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8353 (aarch64_gdbarch_init): Add puth registers.
8354 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8355 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8356 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8358 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8359 Jiong Wang <jiong.wang@arm.com>
8361 * aarch64-linux-nat.c
8362 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8363 * aarch64-linux-tdep.c
8364 (aarch64_linux_core_read_description): Likewise.
8365 (aarch64_linux_get_hwcap): New function.
8366 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8367 (aarch64_linux_get_hwcap): New declaration.
8369 2019-03-22 Alan Hayward <alan.hayward@arm.com>
8370 Jiong Wang <jiong.wang@arm.com>
8372 * aarch64-linux-nat.c
8373 (aarch64_linux_nat_target::read_description): Add pauth param.
8374 * aarch64-linux-tdep.c
8375 (aarch64_linux_core_read_description): Likewise.
8376 * aarch64-tdep.c (struct target_desc): Add in pauth.
8377 (aarch64_read_description): Add pauth param.
8378 (aarch64_gdbarch_init): Likewise.
8379 * aarch64-tdep.h (aarch64_read_description): Likewise.
8380 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8381 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8382 * features/Makefile: Add new files.
8383 * features/aarch64-pauth.c: New file.
8384 * features/aarch64-pauth.xml: New file.
8386 2019-03-20 Tom Tromey <tromey@adacore.com>
8388 * infrun.c (handle_inferior_event): Rename from
8389 handle_inferior_event_1. Create a scoped_value_mark.
8390 (handle_inferior_event): Remove.
8392 2019-03-19 Tom Tromey <tromey@adacore.com>
8394 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8395 * infrun.h (print_stop_event): Add "displays" parameter.
8396 * infrun.c (print_stop_event): Add "displays" parameter.
8398 2019-03-19 Pedro Alves <palves@redhat.com>
8400 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8401 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8402 to -1. Fix TABs vs spaces.
8403 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8404 * tui/tui-out.h (tui_ui_out) Add intro comments.
8405 <m_line, m_start_of_line>: In-class initialize, and add describing
8408 2019-03-18 Alan Hayward <alan.hayward@arm.com>
8410 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8412 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8414 2019-03-18 Pedro Alves <palves@redhat.com>
8415 Eli Zaretskii <eliz@gnu.org>
8417 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8418 m_line and m_start_of_line.
8420 2019-03-18 Eli Zaretskii <eliz@gnu.org>
8422 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8423 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8424 it returns a newline. This fixes a regression in TU mode, whereby
8425 the next line is output on the same screen line as the user input.
8427 2019-03-18 Tom Tromey <tromey@adacore.com>
8429 * minsyms.c (minimal_symbol_reader::install): Remove call to
8432 2019-03-18 Pedro Alves <palves@redhat.com>
8434 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8436 (apply_style): New, factored out from ...
8437 (apply_ansi_escape): ... this. Handle reverse video mode.
8438 (tui_set_reverse_mode): New function.
8439 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8440 * tui/tui-winsource.c (tui_show_source_line): Use
8441 tui_set_reverse_mode instead of setting A_STANDOUT.
8442 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8445 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
8447 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8450 2019-03-18 Tom Tromey <tromey@adacore.com>
8452 * ada-lang.c (empty_array): Add "high" parameter.
8453 (ada_evaluate_subexp): Update.
8455 2019-03-17 Sergei Trofimovich <siarheit@google.com>
8457 * unittests/string_view-selftests.c: Define
8458 _initialize_string_view_selftests unconditionally.
8460 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8463 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8465 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8468 * windows-nat.c (display_selector): Fix format specifiers.
8470 2019-03-17 Eli Zaretskii <eliz@gnu.org>
8472 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8473 tui_refill_source_window instead of tui_refresh_win, to update the
8474 current execution line. This fixes redisplay of the current line
8475 when stepping through the code with "next" or "step".
8477 2019-03-16 Eli Zaretskii <eliz@gnu.org>
8479 * source-cache.c (source_cache::get_source_lines): Call
8480 find_source_lines to initialize s->nlines. This fixes vertical
8481 scrolling of TUI source window when the DOWN arrow is pressed.
8483 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8485 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8486 linux-thread-db.c (_initialize_thread_db): Likewise.
8488 2019-03-16 Eli Zaretskii <eliz@gnu.org>
8490 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8491 wclrtoeol in tui_show_source_line". This reverts changes made in
8492 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8494 2019-03-15 Tom Tromey <tom@tromey.com>
8496 * symtab.h (struct minimal_symbol): Derive from
8497 general_symbol_info.
8498 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8499 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8500 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8501 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8502 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8503 (MSYMBOL_SEARCH_NAME): Update.
8504 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8505 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8506 * minsyms.c (minimal_symbol_reader::record_full): Update.
8508 2019-03-15 Tom Tromey <tom@tromey.com>
8510 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8512 2019-03-15 Tom Tromey <tom@tromey.com>
8514 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8516 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8518 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8519 (build_minimal_symbol_hash_tables)
8520 (minimal_symbol_reader::install): Update.
8522 2019-03-15 Tom Tromey <tom@tromey.com>
8524 * symtab.c (create_demangled_names_hash): Update.
8525 (symbol_set_names): Update.
8526 * objfiles.h (struct objfile_per_bfd_storage)
8527 <demangled_names_hash>: Now an htab_up.
8528 * objfiles.c (objfile_per_bfd_storage): Simplify.
8530 2019-03-15 Tom Tromey <tom@tromey.com>
8532 * objfiles.h (struct objfile_per_bfd_storage): Declare
8534 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8536 (get_objfile_bfd_data): Use new. Don't initialize
8538 (free_objfile_per_bfd_storage): Remove.
8539 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8541 2019-03-15 Tom Tromey <tom@tromey.com>
8543 * symfile.c (reread_symbols): Update.
8544 * objfiles.c (objfile::objfile): Update.
8545 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8546 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8548 (minimal_symbol_reader::install): Update.
8549 (terminate_minimal_symbol_table): Remove.
8550 * jit.c (jit_object_close_impl): Update.
8552 2019-03-15 Tom Tromey <tom@tromey.com>
8554 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8557 2019-03-15 Tom Tromey <tom@tromey.com>
8559 * objfiles.h (struct objfile_per_bfd_storage)
8560 <demangled_hash_languages>: Now a bitset.
8561 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8562 (lookup_minimal_symbol): Update.
8564 2019-03-15 Tom Tromey <tom@tromey.com>
8566 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8567 Don't return the symbol.
8568 * coffread.c (record_minimal_symbol): Use record_full.
8570 2019-03-14 Eli Zaretskii <eliz@gnu.org>
8572 The MS-Windows port of ncurses fails to switch to a color pair if
8573 one or both of the colors are the implicit default colors. This
8574 change records the default colors when TUI is initialized, and
8575 then specifies them explicitly when a color pair uses the default
8576 colors. This allows color styling in TUI mode on MS-Windows.
8578 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8580 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8581 colors in ncurses_norm_attr.
8582 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8583 "none", replace it with the default color recorded in
8586 2019-03-14 Tom Tromey <tromey@adacore.com>
8588 * source-cache.h (class source_cache) <get_source_lines>: Return
8590 * source-cache.c (source_cache::extract_lines): Handle case where
8591 first_pos==npos. Return std::string.
8592 (source_cache::get_source_lines): Update.
8594 2019-03-14 Tom Tromey <tromey@adacore.com>
8596 * NEWS: Add item for "style sources" commands.
8597 * source-cache.c (source_cache::get_source_lines): Check
8599 * cli/cli-style.c (source_styling): New global.
8600 (_initialize_cli_style): Add "style sources" commands.
8601 (show_style_sources): New function.
8602 * cli/cli-style.h (source_styling): Declare.
8604 2019-03-14 Pedro Alves <palves@redhat.com>
8605 Tom Tromey <tromey@adacore.com>
8607 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8608 * tui/tui-winsource.c (tui_refill_source_window): New function,
8610 (tui_horizontal_source_scroll): ... here. Move some logic.
8611 * cli/cli-style.c (set_style_enabled): Notify new observable.
8612 * tui/tui-hooks.c (tui_redisplay_source): New function.
8613 (tui_attach_detach_observers): Attach or detach
8614 tui_redisplay_source.
8615 * observable.h (source_styling_changed): New observable.
8616 * observable.c: Define source_styling_changed observable.
8618 2019-03-13 Tom Tromey <tromey@adacore.com>
8620 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8621 (i386_gnu_nat_target::store_registers): Update.
8622 * target-debug.h (target_debug_print_std_string): New macro.
8623 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8624 * windows-tdep.c (display_one_tib): Update.
8625 * tui/tui-stack.c (tui_make_status_line): Update.
8626 * top.c (print_inferior_quit_action): Update.
8627 * thread.c (thr_try_catch_cmd): Update.
8628 (add_thread_with_info): Update.
8629 (thread_target_id_str): Update.
8630 (thr_try_catch_cmd): Update.
8631 (thread_command): Update.
8632 (thread_find_command): Update.
8633 * record-btrace.c (record_btrace_target::info_record)
8634 (record_btrace_resume_thread, record_btrace_target::resume)
8635 (record_btrace_cancel_resume, record_btrace_step_thread)
8636 (record_btrace_target::wait, record_btrace_target::wait)
8637 (record_btrace_target::wait, record_btrace_target::stop): Update.
8638 * progspace.c (print_program_space): Update.
8639 * process-stratum-target.c
8640 (process_stratum_target::thread_address_space): Update.
8641 * linux-fork.c (linux_fork_mourn_inferior)
8642 (detach_checkpoint_command, info_checkpoints_command)
8643 (linux_fork_context): Update.
8644 (linux_fork_detach): Update.
8645 (class scoped_switch_fork_info): Update.
8646 (delete_checkpoint_command): Update.
8647 * infrun.c (follow_fork_inferior): Update.
8648 (follow_fork_inferior): Update.
8649 (proceed_after_vfork_done): Update.
8650 (handle_vfork_child_exec_or_exit): Update.
8651 (follow_exec): Update.
8652 (displaced_step_prepare_throw): Update.
8653 (displaced_step_restore): Update.
8654 (start_step_over): Update.
8656 (clear_proceed_status_thread): Update.
8658 (print_target_wait_results): Update.
8659 (do_target_wait): Update.
8660 (context_switch): Update.
8661 (stop_all_threads): Update.
8662 (restart_threads): Update.
8663 (finish_step_over): Update.
8664 (handle_signal_stop): Update.
8665 (switch_back_to_stepped_thread): Update.
8666 (keep_going_pass_signal): Update.
8667 (print_exited_reason): Update.
8668 (normal_stop): Update.
8669 * inferior.c (inferior_pid_to_str): Change return type.
8670 (print_selected_inferior): Update.
8671 (add_inferior): Update.
8672 (detach_inferior): Update.
8673 * dummy-frame.c (fprint_dummy_frames): Update.
8674 * dcache.c (dcache_info_1): Update.
8675 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8676 (btrace_fetch, btrace_clear): Update.
8677 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8678 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8680 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8681 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8682 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8683 * gdbarch.c, gdbarch.h: Rebuild.
8684 * gdbarch.sh (core_pid_to_str): Change return type.
8685 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8687 (windows_nat_target::pid_to_str): Change return type.
8688 (windows_delete_thread): Update.
8689 (windows_nat_target::attach): Update.
8690 (windows_nat_target::files_info): Update.
8691 * target-delegates.c: Rebuild.
8692 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8694 (sol_thread_target::pid_to_str): Change return type.
8695 * remote.c (class remote_target) <pid_to_str>: Change return
8697 (remote_target::pid_to_str): Change return type.
8698 (extended_remote_target::attach, remote_target::remote_stop_ns)
8699 (remote_target::remote_notif_remove_queued_reply)
8700 (remote_target::push_stop_reply, remote_target::disable_btrace):
8702 (extended_remote_target::attach): Update.
8703 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8705 (gdbsim_target::pid_to_str): Change return type.
8706 * ravenscar-thread.c (struct ravenscar_thread_target)
8707 <pid_to_str>: Change return type.
8708 (ravenscar_thread_target::pid_to_str): Change return type.
8709 * procfs.c (class procfs_target) <pid_to_str>: Change return
8711 (procfs_target::pid_to_str): Change return type.
8712 (procfs_target::attach): Update.
8713 (procfs_target::detach): Update.
8714 (procfs_target::fetch_registers): Update.
8715 (procfs_target::store_registers): Update.
8716 (procfs_target::wait): Update.
8717 (procfs_target::files_info): Update.
8718 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8719 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8721 (nto_procfs_target::pid_to_str): Change return type.
8722 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8723 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8725 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8727 (attach_proc_task_lwp_callback, get_detach_signal)
8728 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8729 (linux_nat_target::resume, wait_lwp, stop_callback)
8730 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8731 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8732 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8733 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8734 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8736 (inf_ptrace_target::attach): Update.
8737 (inf_ptrace_target::files_info): Update.
8738 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8740 (go32_nat_target::pid_to_str): Change return type.
8741 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8742 (gnu_nat_target::wait): Update.
8743 (gnu_nat_target::wait): Update.
8744 (gnu_nat_target::resume): Update.
8745 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8746 (fbsd_nat_target::wait): Update.
8747 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8749 (darwin_nat_target::attach): Update.
8750 * corelow.c (class core_target) <pid_to_str>: Change return type.
8751 (core_target::pid_to_str): Change return type.
8752 * target.c (normal_pid_to_str): Change return type.
8753 (default_pid_to_str): Likewise.
8754 (target_pid_to_str): Change return type.
8755 (target_translate_tls_address): Update.
8756 (target_announce_detach): Update.
8757 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8759 (bsd_uthread_target::pid_to_str): Change return type.
8760 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8762 (bsd_kvm_target::pid_to_str): Change return type.
8763 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8765 (aix_thread_target::pid_to_str): Change return type.
8766 * target.h (struct target_ops) <pid_to_str>: Change return type.
8767 (target_pid_to_str, normal_pid_to_str): Likewise.
8768 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8770 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8772 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8774 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8776 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8778 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8781 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8783 * NEWS: Mention that the new default MI version is 3. Mention
8784 changes to the output of commands and events that deal with
8785 multi-location breakpoints.
8786 * breakpoint.c: Include "mi/mi-out.h".
8787 (print_one_breakpoint): Change output syntax if using MI version
8789 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8791 (mi_multi_location_breakpoint_output_fixed): New.
8792 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8793 (mi_cmd_fix_multi_location_breakpoint_output): New.
8794 (mi_multi_location_breakpoint_output_fixed): New.
8795 * mi/mi-cmds.c (mi_cmds): Register command
8796 -fix-multi-location-breakpoint-output.
8797 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8800 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8802 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8803 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8804 instantiate mi_ui_out based on interpreter name.
8805 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8806 * mi/mi-main.c (mi_load_progress): Likewise.
8808 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8810 * NEWS: Combine separate "New targets" sections for 8.3.
8812 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8814 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8815 (ppcfbsd_init_abi): Install gdbarch
8816 "fetch_tls_load_module_address" and "get_thread_local_address"
8819 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8821 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8822 (riscv_fbsd_init_abi): Install gdbarch
8823 "fetch_tls_load_module_address" and "get_thread_local_address"
8826 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8828 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8829 (i386fbsd_init_abi): Install gdbarch
8830 "fetch_tls_load_module_address" and "get_thread_local_address"
8833 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8835 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8836 (amd64fbsd_init_abi): Install gdbarch
8837 "fetch_tls_load_module_address" and "get_thread_local_address"
8840 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8842 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8843 (struct fbsd_pspace_data): New type.
8844 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8845 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8846 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8847 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8848 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8850 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8852 * gdbtypes.c (lookup_struct_elt): New function.
8853 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8854 * gdbtypes.h (struct struct_elt): New type.
8855 (lookup_struct_elt): New prototype.
8857 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8859 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8860 remove disabled code block.
8862 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8864 * gdbarch.sh (get_thread_local_address): New method.
8865 * gdbarch.h, gdbarch.c: Regenerate.
8866 * target.c (target_translate_tls_address): Use
8867 gdbarch_get_thread_local_address if present instead of
8868 target::get_thread_local_address.
8870 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8872 * target.h (target::get_thread_local_address): Update comment.
8874 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8876 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8877 objfile->separate_debug_objfile_backlink if not NULL.
8879 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8881 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8882 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8883 (amd64bsd_store_inferior_registers): Likewise.
8884 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8885 Enable segment base registers.
8886 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8887 PT_GETFSBASE and PT_GETGSBASE.
8888 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8890 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8891 segment base registers.
8892 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8894 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8896 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8897 Update calls to i386_target_description to add 'segments'
8899 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8900 add segment base registers.
8901 * arch/i386.c (i386_create_target_description): Add 'segments'
8902 parameter to enable segment base registers.
8903 * arch/i386.h (i386_create_target_description): Likewise.
8904 * features/i386/32bit-segments.xml: New file.
8905 * features/i386/32bit-segments.c: Generate.
8906 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8907 call to i386_target_description to add 'segments' parameter.
8908 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8909 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8910 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8911 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8912 if feature is present.
8913 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8914 Add 'segments' parameter to call to i386_target_description.
8915 (i386_target_description): Add 'segments' parameter to enable
8916 segment base registers.
8917 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8918 to call to i386_target_description.
8919 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8920 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8921 Define I386_NUM_REGS.
8922 (i386_target_description): Add 'segments' parameter to enable
8923 segment base registers.
8925 2019-03-12 Eli Zaretskii <eliz@gnu.org>
8928 * source-cache.c: #undef open and close, to avoid unresolved
8929 externals during linking.
8931 2019-03-12 Tom Tromey <tromey@adacore.com>
8933 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8934 const. Add initializers.
8935 (_initialize_remote): Don't initialize ptid globals.
8937 2019-03-12 Pedro Alves <palves@redhat.com>
8939 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8941 2019-03-12 Pedro Alves <palves@redhat.com>
8943 * cp-name-parser.y (main): Remove unused 'len' variable.
8945 2019-03-12 Tom Tromey <tromey@adacore.com>
8947 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8948 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8950 2019-03-12 Tom Tromey <tromey@adacore.com>
8952 * linux-nat.c (iterate_over_lwps): Update.
8953 (stop_callback): Remove parameter.
8954 (stop_wait_callback, detach_callback, resume_set_callback)
8955 (select_singlestep_lwp_callback, set_ignore_sigint)
8956 (status_callback, resumed_callback, resume_clear_callback)
8957 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8959 (linux_nat_target::detach, linux_nat_target::resume)
8960 (linux_stop_and_wait_all_lwps, select_event_lwp)
8961 (linux_nat_filter_event, linux_nat_wait_1)
8962 (linux_nat_target::kill, linux_nat_target::stop)
8963 (linux_nat_target::stop): Update.
8964 (linux_nat_resume_callback): Change type.
8965 (resume_stopped_resumed_lwps, count_events_callback)
8966 (select_event_lwp_callback): Likewise.
8967 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8968 * arm-linux-nat.c (struct update_registers_data): Remove.
8969 (update_registers_callback): Change type.
8970 (arm_linux_insert_hw_breakpoint1): Update.
8971 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8973 (x86_linux_dr_set_addr): Update.
8974 (x86_linux_dr_set_control): Update.
8975 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8976 (iterate_over_lwps): Use gdb::function_view.
8977 * nat/aarch64-linux-hw-point.c (struct
8978 aarch64_dr_update_callback_param): Remove.
8979 (debug_reg_change_callback): Change type.
8980 (aarch64_notify_debug_reg_change): Update.
8981 * s390-linux-nat.c (s390_refresh_per_info): Update.
8983 2019-03-11 Tom Tromey <tromey@adacore.com>
8985 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8986 redundant assignment to "this_cu".
8988 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8990 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8992 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8994 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8996 (rank_one_type): ... this.
8998 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9000 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9002 (rank_one_type): ... this.
9004 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9006 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9008 (rank_one_type): ... this.
9010 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9012 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9014 (rank_one_type): ... this.
9016 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9018 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9020 (rank_one_type): ... this.
9022 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9024 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9026 (rank_one_type): ... this.
9028 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9030 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9032 (rank_one_type): ... this.
9034 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9036 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9038 (rank_one_type): ... this.
9040 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9042 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9044 (rank_one_type): ... this.
9046 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9048 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9050 (rank_one_type): ... this.
9052 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9054 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9056 (rank_one_type): ... this.
9058 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
9060 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9062 (rank_one_type): ... this.
9064 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9066 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9067 inferior-events' shows the example events.
9069 2019-03-08 Eli Zaretskii <eliz@gnu.org>
9071 Support styling on native MS-Windows console
9074 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9075 on MS-Windows if $TERM is not defined.
9077 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9079 * posix-hdep.c (gdb_console_fputs):
9080 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9082 * ui-file.h (gdb_console_fputs): Add prototype.
9084 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9085 back to fputs only if the former returns zero.
9087 2019-03-07 Tom Tromey <tom@tromey.com>
9089 * symmisc.c (print_symbol_bcache_statistics): Update.
9090 (print_objfile_statistics): Update.
9091 * symfile.c (allocate_symtab): Update.
9092 * stabsread.c: Don't include bcache.h.
9093 * psymtab.h (struct psymbol_bcache): Don't declare.
9094 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9095 (psymbol_bcache_init, psymbol_bcache_free)
9096 (psymbol_bcache_get_bcache): Don't declare.
9097 * psymtab.c (struct psymbol_bcache): Remove.
9098 (psymtab_storage::psymtab_storage): Update.
9099 (psymtab_storage::~psymtab_storage): Update.
9100 (psymbol_bcache_init, psymbol_bcache_free)
9101 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9102 (add_psymbol_to_bcache): Update.
9103 (allocate_psymtab): Update.
9104 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9105 macro_cache>: No longer pointers.
9106 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9107 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9108 * macrotab.c (macro_bcache): Update.
9109 * macroexp.c: Don't include bcache.h.
9110 * gdbtypes.c (check_types_worklist): Update.
9111 (types_deeply_equal): Remove TRY/CATCH. Update.
9112 * elfread.c (elf_symtab_read): Update.
9113 * dwarf2read.c: Don't include bcache.h.
9114 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9115 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9116 (print_bcache_statistics, bcache_memory_used): Don't declare.
9117 (struct bcache): Move from bcache.c. Add constructor, destructor,
9118 methods. Rename all data members.
9119 * bcache.c (struct bcache): Move to bcache.h.
9120 (bcache::expand_hash_table): Rename from expand_hash_table.
9122 (bcache::insert): Rename from bcache_full.
9123 (bcache::compare): Rename from bcache_compare.
9124 (bcache_xmalloc): Remove.
9125 (bcache::~bcache): Rename from bcache_xfree.
9126 (bcache::print_statistics): Rename from print_bcache_statistics.
9127 (bcache::memory_used): Rename from bcache_memory_used.
9129 2019-03-07 Pedro Alves <palves@redhat.com>
9131 * infrun.c (normal_stop): Also check for
9132 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9134 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9136 * f-lang.c (value_from_host_double): Moved to...
9137 * value.c (value_from_host_double): ...here.
9138 * value.h (value_from_host_double): Declare.
9139 * guile/scm-math.c (vlscm_convert_typed_number): Use
9140 value_from_host_double.
9141 (vlscm_convert_number): Likewise.
9142 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9143 * python/py-value.c (convert_value_from_python): Likewise.
9145 2019-03-06 Tom Tromey <tom@tromey.com>
9147 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9149 2019-03-06 Tom Tromey <tom@tromey.com>
9151 * utils.h (free_current_contents): Don't declare.
9152 * utils.c (free_current_contents): Remove.
9154 2019-03-06 Tom Tromey <tom@tromey.com>
9156 * top.c (quit_force): Update.
9157 * main.c (captured_command_loop): Update.
9158 * common/new-op.c (operator new): Update.
9159 * common/common-exceptions.c (struct catcher)
9160 <save_cleanup_chain>: Remove member.
9161 (exceptions_state_mc_init): Update.
9162 (exception_try_scope_entry): Return nullptr.
9163 (exception_try_scope_exit, exception_rethrow)
9164 (throw_exception_sjlj, throw_exception_cxx): Update.
9165 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9166 (all_cleanups, do_cleanups, discard_cleanups)
9167 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9168 (restore_cleanups, restore_final_cleanups): Don't declare.
9169 (do_final_cleanups): Remove parameter.
9170 * common/cleanups.c (cleanup_chain, make_cleanup)
9171 (make_cleanup_dtor, all_cleanups, do_cleanups)
9172 (discard_my_cleanups, discard_cleanups)
9173 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9174 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9175 (null_cleanup): Remove.
9176 (do_final_cleanups): Remove parameter.
9178 2019-03-06 Tom Tromey <tom@tromey.com>
9180 * remote.c (remote_target::remote_parse_stop_reply): Use
9183 2019-03-06 Tom Tromey <tom@tromey.com>
9185 * stabsread.c (struct stabs_field_info): Rename from field_info.
9186 <list, fnlist>: Add initializers.
9187 <obstack>: New member.
9188 (read_member_functions, read_struct_fields, read_baseclasses):
9189 Allocate on obstack. Don't use cleanups.
9190 (read_one_struct_field, read_member_functions, read_struct_fields)
9191 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9192 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9193 (read_struct_type): Update.
9195 2019-03-06 Tom Tromey <tom@tromey.com>
9197 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9198 * common/filestuff.h (make_cleanup_close): Don't declare.
9199 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9202 2019-03-06 Tom Tromey <tom@tromey.com>
9204 * solib-aix.c: Use make_scope_exit.
9206 2019-03-06 Tom Tromey <tom@tromey.com>
9208 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9209 Use make_scope_exit.
9211 2019-03-06 Tom Tromey <tom@tromey.com>
9213 * solib-svr4.c (disable_probes_interface): Remove parameter.
9214 (svr4_handle_solib_event): Use make_scope_exit.
9216 2019-03-06 Tom Tromey <tom@tromey.com>
9218 * remote.c (struct stop_reply_deleter): Remove.
9219 (stop_reply_up): Update.
9220 (struct stop_reply): Derive from notif_event. Don't typedef.
9221 <regcache>: Now a std::vector.
9222 (stop_reply_xfree): Remove.
9223 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9224 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9225 (remote_target::discard_pending_stop_replies): Use delete.
9226 (remote_target::remote_parse_stop_reply): Update.
9227 (remote_target::process_stop_reply): Update.
9228 * remote-notif.h (struct notif_event): Add virtual destructor.
9229 Remove "dtr" member.
9230 (struct notif_client) <alloc_event>: Return a unique_ptr.
9231 (notif_event_xfree): Don't declare.
9232 (notif_event_up): New typedef.
9233 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9234 (notif_event_xfree, do_notif_event_xfree): Remove.
9235 (remote_notif_state_xfree): Update.
9237 2019-03-06 Tom Tromey <tom@tromey.com>
9239 * infrun.c (displaced_step_clear_cleanup): Now a
9240 forward_scope_exit type.
9241 (displaced_step_prepare_throw): Update.
9242 (displaced_step_fixup): Update.
9244 2019-03-06 Tom Tromey <tom@tromey.com>
9246 * inferior.h (class inferior): Update comment.
9247 * gdbthread.h (class thread_info): Update comment.
9249 2019-03-06 Joel Brobecker <brobecker@adacore.com>
9250 Tom Tromey <tom@tromey.com>
9252 * stabsread.h (struct stab_section_list): Remove.
9253 (coffstab_build_psymtabs): Update.
9254 * dbxread.c (symbuf_sections): Now a std::vector.
9255 (sect_idx): New global.
9256 (fill_symbuf): Update.
9257 (coffstab_build_psymtabs): Change type of stabsects parameter.
9259 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9261 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9262 (coff_locate_sections): Update.
9263 (coff_symfile_read): Remove cleanups. Update.
9264 (init_stringtab): Add storage parameter.
9265 (free_stringtab, free_stringtab_cleanup): Remove.
9266 (init_lineno): Add storage parameter.
9267 (free_linetab, free_linetab_cleanup): Remove.
9269 2019-03-06 Pedro Alves <palves@redhat.com>
9271 * linux-fork.c (fork_info::clobber_regs): Delete.
9272 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9273 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9275 (scoped_switch_fork_info::scoped_switch_fork_info)
9276 (checkpoint_command, linux_fork_context): Adjust
9277 fork_save_infrun_state calls.
9279 2019-03-06 Pedro Alves <palves@redhat.com>
9281 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9282 (inf_has_multiple_threads): Return 'bool' and rewrite using
9283 inferior_info::threads().
9285 2019-03-06 Pedro Alves <palves@redhat.com>
9287 * linux-fork.c: Include <list>.
9288 (fork_list): Now a std::list instance.
9289 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9290 (forks_exist_p, find_last_fork): Adjust.
9294 (free_fork): Delete, folded into fork_info::~fork_info().
9295 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9297 (init_fork_list): Delete.
9298 (linux_fork_killall, linux_fork_mourn_inferior)
9299 (linux_fork_detach, info_checkpoints_command): Adjust.
9300 (_initialize_linux_fork): No longer call init_fork_list.
9302 2019-03-06 Pedro Alves <palves@redhat.com>
9304 * linux-fork.c (new_fork): New, split out of ...
9305 (add_fork): ... this. Return void. Move "first fork" special
9306 case from here, to ...
9307 (checkpoint_command): ... here.
9308 * linux-linux.h (add_fork): Return void.
9310 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9312 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9314 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9315 Chris January <chris.january@arm.com>
9316 David Lecomber <david.lecomber@arm.com>
9318 * f-exp.y: New token, UNOP_INTRINSIC.
9319 (exp): New pattern using UNOP_INTRINSIC token.
9320 (f77_keywords): Add 'abs' keyword.
9321 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9322 (value_from_host_double): New function.
9323 (evaluate_subexp_f): Support UNOP_ABS.
9325 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9327 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9330 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9332 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9333 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9334 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9336 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9338 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9340 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9341 Chris January <chris.january@arm.com>
9343 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9344 * f-exp.y: Define 'KIND' token.
9345 (exp): New pattern for KIND expressions.
9346 (ptype): Handle types with a kind extension.
9347 (direct_abs_decl): Extend to spot kind extensions.
9348 (f77_keywords): Add 'kind' to the list.
9349 (push_kind_type): New function.
9350 (convert_to_kind_type): New function.
9351 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9352 * parse.c (operator_length_standard): Likewise.
9353 * parser-defs.h (enum type_pieces): Add tp_kind.
9354 * std-operator.def: Add UNOP_KIND.
9356 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9358 * f-exp.y (f_parse): Set yydebug.
9360 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9362 * f-lang.c (evaluate_subexp_f): New function.
9363 (exp_descriptor_f): New global.
9364 (f_language_defn): Use exp_descriptor_f instead of
9365 exp_descriptor_standard.
9367 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9369 * f-exp.y (struct token): Add comments.
9370 (dot_ops): Remove uppercase versions and the end marker.
9371 (f77_keywords): Likewise.
9372 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9373 entries in the dot_ops array are case insensitive, and use
9374 strncasecmp to compare strings. Also some whitespace cleanup in
9375 this area. Similar for the f77_keywords array, except entries in
9376 this list might be case sensitive.
9378 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9380 * f-exp.y (struct f77_boolean_val): Add comments.
9381 (boolean_values): Remove uppercase versions, and end marker.
9382 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9383 and use strncasecmp to achieve case insensitivity. Additionally,
9384 perform whitespace cleanup around this code.
9386 2019-03-06 Tom Tromey <tromey@adacore.com>
9388 * remote-sim.c (gdbsim_target_open): Use result of
9391 2019-03-06 Richard Bunt <richard.bunt@arm.com>
9392 Dirk Schubert <dirk.schubert@arm.com>
9393 Chris January <chris.january@arm.com>
9395 * eval.c (evaluate_subexp_standard): Call Fortran argument
9397 * f-lang.c (struct value): A value which can be passed into a
9398 Fortran function call.
9399 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9401 (struct type): Value ready for a Fortran function call.
9402 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9404 * f-lang.h (fortran_argument_convert): Declaration.
9405 (fortran_preserve_arg_pointer): Declaration.
9406 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9408 2019-03-05 Tom Tromey <tromey@adacore.com>
9410 * python/py-prettyprint.c (print_string_repr): Remove #if.
9411 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9413 2019-03-05 Tom Tromey <tromey@adacore.com>
9415 * target.c (the_dummy_target): Move later. Change type to
9417 (initialize_targets): Don't initialize the_dummy_target.
9419 2019-03-05 Tom Tromey <tromey@adacore.com>
9421 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9422 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9424 2019-03-05 Tom Tromey <tromey@adacore.com>
9426 * windows-nat.c (windows_nat_target::attach)
9427 (windows_nat_target::detach): Don't call gdb_flush.
9428 * valprint.c (generic_val_print, val_print, val_print_string):
9429 Don't call gdb_flush.
9430 * utils.c (defaulted_query): Don't call gdb_flush.
9431 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9432 * target.c (target_announce_detach): Don't call gdb_flush.
9433 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9434 * remote.c (extended_remote_target::attach): Don't call
9436 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9437 * printcmd.c (do_examine): Don't call gdb_flush.
9438 (info_display_command): Don't call gdb_flush.
9439 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9440 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9441 * memattr.c (info_mem_command): Don't call gdb_flush.
9442 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9443 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9444 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9445 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9446 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9447 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9448 (gnu_nat_target::detach): Don't call gdb_flush.
9449 * f-valprint.c (f_val_print): Don't call gdb_flush.
9450 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9451 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9452 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9454 * c-valprint.c (c_val_print): Don't call gdb_flush.
9455 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9457 2019-03-05 Tom Tromey <tromey@adacore.com>
9459 * varobj.c (update_dynamic_varobj_children): Update.
9460 (install_default_visualizer): Use reset, not release.
9461 * value.c (set_internalvar): Update.
9462 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9463 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9464 ATTRIBUTE_UNUSED_RESULT.
9466 2019-03-05 Tom Tromey <tromey@adacore.com>
9468 * remote.c (class scoped_remote_fd) <release>: Add
9469 ATTRIBUTE_UNUSED_RESULT.
9471 2019-03-05 Tom Tromey <tromey@adacore.com>
9473 * macroexp.c (struct macro_buffer) <release>: Add
9474 ATTRIBUTE_UNUSED_RESULT.
9476 2019-03-05 Tom Tromey <tromey@adacore.com>
9478 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9479 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9480 ATTRIBUTE_UNUSED_RESULT.
9482 2019-03-05 Tom Tromey <tromey@adacore.com>
9484 * common/scoped_fd.h (class scoped_fd) <release>: Add
9485 ATTRIBUTE_UNUSED_RESULT.
9487 2019-03-05 Tom Tromey <tromey@adacore.com>
9489 * parser-defs.h (struct parser_state) <release>: Add
9490 ATTRIBUTE_UNUSED_RESULT.
9492 2019-03-05 Tom Tromey <tromey@adacore.com>
9494 * utils.h (class gdb_argv) <release>: Add
9495 ATTRIBUTE_UNUSED_RESULT.
9496 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9498 2019-03-02 Eli Zaretskii <eliz@gnu.org>
9500 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9501 for-loop range, to avoid compiler warnings.
9503 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9504 avoid compiler warnings about unused variables.
9506 * NEWS: Mention end of support for native debugging on MS-Windows
9510 * common/netstuff.c:
9511 * gdbserver/gdbreplay.c
9512 * gdbserver/remote-utils.c:
9514 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9515 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9516 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9517 'getaddrinfo' and 'freeaddrinfo' were not available before
9518 Windows XP, and mingw.org's MinGW headers by default define
9519 _WIN32_WINNT to 0x500.
9521 2019-03-01 Gary Benson <gbenson@redhat.com>
9523 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9525 2019-02-28 Brian Vandenberg <phantall@gmail.com>
9526 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9529 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9530 set_sigint_trap, clear_sigint_trap.
9532 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9534 * target.c (target_detach): Clear the regcache and the
9537 2019-02-27 Pedro Alves <palves@redhat.com>
9539 * utils.c (set_screen_size): When we cap the height/width sizes,
9540 tweak the corresponding command variable to show "unlimited":
9542 2019-02-27 Saagar Jha <saagar@saagarjha.com>
9543 Pedro Alves <palves@redhat.com>
9545 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9546 before calling rl_set_screen_size.
9548 2019-02-27 Tom Tromey <tromey@adacore.com>
9550 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9552 * python/py-value.c: Remove Python 2.4 workaround.
9553 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9555 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9556 Python 2.4 workaround.
9557 * python/python-internal.h: Remove Python 2.4 comment.
9558 (Py_ssize_t): Don't define.
9559 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9560 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9561 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9562 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9563 * python/python.c (do_start_initialization): Remove Python 2.4
9565 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9566 (print_children): Remove Python 2.4 workaround.
9567 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9569 (CHARBUFFERPROC_NAME): Remove.
9570 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9571 Python 2.4 workaround.
9573 2019-02-27 Kevin Buettner <kevinb@redhat.com>
9575 * NEWS: Note minimum Python version.
9577 2019-02-27 Kevin Buettner <kevinb@redhat.com>
9579 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9580 code from these functions. Remove corresponding ifdefs. Use
9581 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9582 Remove gotos and target of gotos.
9583 (infpy_search_memory): Likewise.
9585 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9587 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9588 (hppa_gdbarch_init): Don't register deleted functions with
9591 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9593 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9594 (h8300_unwind_sp): Delete.
9595 (h8300_dummy_id): Delete.
9596 (h8300_gdbarch_init): Don't register deleted functions with
9599 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9601 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9602 (ft32_unwind_pc): Delete.
9603 (ft32_unwind_sp): Delete.
9604 (ft32_gdbarch_init): Don't register deleted functions with
9607 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9609 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9610 (frv_unwind_pc): Delete.
9611 (frv_unwind_sp): Delete.
9612 (frv_gdbarch_init): Don't register deleted functions with
9615 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9617 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9618 (riscv_unwind_pc): Delete.
9619 (riscv_unwind_sp): Delete.
9620 (riscv_gdbarch_init): Don't register deleted functions with
9623 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9625 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9626 (csky_unwind_pc): Delete.
9627 (csky_unwind_sp): Delete.
9628 (csky_gdbarch_init): Don't register deleted functions with
9631 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9633 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9634 (cris_unwind_pc): Delete.
9635 (cris_unwind_sp): Delete.
9636 (cris_gdbarch_init): Don't register deleted functions with
9639 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9641 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9642 (bfin_unwind_pc): Delete.
9643 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9645 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9647 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9648 (arm_unwind_pc): Delete.
9649 (arm_unwind_sp): Delete.
9650 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9652 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9654 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9655 (arc_unwind_pc): Delete.
9656 (arc_unwind_sp): Delete.
9657 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9659 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9661 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9662 (alpha_unwind_pc): Delete.
9663 (alpha_gdbarch_init): Don't register deleted functions with
9666 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9668 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9669 (aarch64_unwind_pc): Delete.
9670 (aarch64_unwind_sp): Delete.
9671 (aarch64_gdbarch_init): Don't register deleted functions with
9674 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9676 * gdbtypes.c (type_align): Don't consider static members when
9677 computing structure alignment.
9679 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9681 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9682 return 0 for other types.
9683 * arch-utils.c (default_type_align): Always return 0.
9684 * gdbarch.h: Regenerate.
9685 * gdbarch.sh (type_align): Extend comment.
9686 * gdbtypes.c (type_align): Add additional comments, always call
9687 gdbarch_type_align before applying the default rules.
9688 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9689 generic code will then apply a suitable default.
9690 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9691 types, return 0 for other types.
9693 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9695 * NEWS: Create a new section for the next release branch.
9696 Rename the section of the current branch, now that it has
9699 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9701 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9702 * version.in: Bump version to 8.3.50.DATE-git.
9704 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
9706 * aix-thread.c (ptid_cmp): Remove unused variable.
9707 (get_signaled_thread): Likewise.
9708 (store_regs_user_thread): Likewise.
9709 (store_regs_kernel_thread): Likewise.
9710 (fetch_regs_kernel_thread): Remove shadowed variable.
9712 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9714 * features/riscv/32bit-cpu.xml: Add register numbers.
9715 * features/riscv/32bit-fpu.c: Regenerate.
9716 * features/riscv/32bit-fpu.xml: Add register numbers.
9717 * features/riscv/64bit-cpu.xml: Add register numbers.
9718 * features/riscv/64bit-fpu.c: Regenerate.
9719 * features/riscv/64bit-fpu.xml: Add register numbers.
9721 2019-02-26 Kevin Buettner <kevinb@redhat.com>
9723 * NEWS: Mention two argument form of gdb.Value constructor.
9724 * python/py-value.c (convert_buffer_and_type_to_value): New
9726 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9727 Add support for handling an optional second argument. Call
9728 convert_buffer_and_type_to_value as appropriate.
9729 * python/python-internal.h (Py_buffer_deleter): New struct.
9730 (Py_buffer_up): New typedef.
9732 2019-02-25 John Baldwin <jhb@FreeBSD.org>
9734 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9735 instead of releasing ownership.
9737 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
9739 * dwarf2read.c (open_and_init_dwp_file): Call
9740 elf_numsections instead of bfd_count_sections to initialize
9741 dwp_file->num_sections.
9743 2019-02-25 Tom Tromey <tromey@adacore.com>
9745 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9747 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9749 * gcore.in: Add '--readnever' option when invoking GDB.
9751 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9753 * MAINTAINERS: Update my email address.
9755 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9757 * build-id.c (build_id_to_debug_bfd_1): New function.
9758 (build_id_to_debug_bfd): Look for separate debug file in
9761 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9763 * gdbarch.sh: Update the copyright year range that is placed into
9766 2019-02-22 Keith Seitz <keiths@redhat.com>
9769 * linespec.c (create_sals_line_offset): Search for the default
9770 symtab's filename instead of its fullname.
9772 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9774 * NEWS: Update style defaults.
9776 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9778 * main.c (captured_main_1): Disable styling in batch mode.
9780 2019-02-20 Tom Tromey <tom@tromey.com>
9782 * symtab.c (symtab_symbol_info): Fix typos.
9784 2019-02-20 Tom Tromey <tromey@adacore.com>
9786 * findcmd.c (_initialize_mem_search): Use upper case for
9787 metasyntactic variables.
9789 2019-02-20 Alan Hayward <alan.hayward@arm.com>
9791 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9792 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9794 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9796 * top.h (source_file_name): Change to std::string.
9797 * top.c (source_file_name): Likewise.
9798 (command_line_input): Adjust.
9799 * cli/cli-script.c (script_from_file): Adjust.
9801 2019-02-19 Tom Tromey <tromey@adacore.com>
9803 * ravenscar-thread.c
9804 (ravenscar_thread_target::update_thread_list): Don't call
9805 ada_build_task_list.
9806 * ada-lang.h (ada_build_task_list): Don't declare.
9807 * ada-tasks.c (struct ada_tasks_inferior_data)
9808 <task_list_valid_p>: Now bool.
9809 (read_known_tasks, ada_task_list_changed)
9810 (ada_tasks_invalidate_inferior_data): Update.
9811 (read_known_tasks_array): Return bool.
9812 (read_known_tasks_list): Likewise.
9813 (read_known_tasks): Return void.
9814 (ada_build_task_list): Now static.
9816 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9818 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9819 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9821 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9823 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9824 variant for ada_tasks_pspace_data_handle and
9825 ada_tasks_inferior_data_handle.
9826 (ada_tasks_pspace_data_cleanup): New function.
9827 (ada_tasks_inferior_data_cleanup): New function.
9829 2019-02-17 Tom Tromey <tom@tromey.com>
9831 * macrotab.h (macro_source_fullname): Return a std::string.
9832 * macrotab.c (macro_include, check_for_redefinition)
9833 (macro_undef, macro_lookup_definition, foreach_macro)
9834 (foreach_macro_in_scope): Update.
9835 (macro_source_fullname): Return a std::string.
9836 * macrocmd.c (show_pp_source_pos): Update.
9838 2019-02-17 Tom Tromey <tom@tromey.com>
9840 * macrocmd.c (show_pp_source_pos): Style the file names.
9842 2019-02-17 Tom Tromey <tom@tromey.com>
9845 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9847 2019-02-17 Tom Tromey <tom@tromey.com>
9849 * ada-lang.c (user_select_syms): Use filtered printing.
9850 * utils.c (wrap_style): New global.
9851 (desired_style): Remove.
9852 (emit_style_escape): Add stream parameter.
9853 (set_output_style, reset_terminal_style, prompt_for_continue):
9855 (flush_wrap_buffer): Only flush gdb_stdout.
9856 (wrap_here): Set wrap_style.
9857 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9858 treat escape sequences as a character. Change when wrap buffer is
9860 (fputs_styled): Do not set the output style when the default is
9862 * ui-style.h (struct ui_file_style) <is_default>: New method.
9863 * source.c (print_source_lines_base): Emit escape sequences in one
9866 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9868 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9869 integers and enumeration types.
9871 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9873 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9874 instead of lookup_symbol_in_language
9875 (do_exact_match): New function.
9876 (ada_get_symbol_name_matcher): Return do_exact_match when
9877 doing a verbatim match.
9879 2019-02-15 Tom Tromey <tromey@adacore.com>
9881 * ravenscar-thread.c (ravenscar_thread_target::resume)
9882 (ravenscar_thread_target::wait): Special case wildcard requests.
9884 2019-02-15 Tom Tromey <tromey@adacore.com>
9886 * ravenscar-thread.c (base_ptid): Remove.
9887 (struct ravenscar_thread_target) <close>: New method.
9888 <m_base_ptid>: New member.
9889 <update_inferior_ptid, active_task, task_is_currently_active,
9890 runtime_initialized>: Declare methods.
9891 <ravenscar_thread_target>: Add constructor.
9892 (ravenscar_thread_target::task_is_currently_active)
9893 (ravenscar_thread_target::update_inferior_ptid)
9894 (ravenscar_runtime_initialized): Rename. Now methods.
9895 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9896 (ravenscar_thread_target::update_thread_list): Update.
9897 (ravenscar_thread_target::active_task): Now method.
9898 (ravenscar_thread_target::store_registers)
9899 (ravenscar_thread_target::prepare_to_store)
9900 (ravenscar_thread_target::prepare_to_store)
9901 (ravenscar_thread_target::mourn_inferior): Update.
9902 (ravenscar_inferior_created): Use "new" to create target.
9903 (ravenscar_thread_target::get_ada_task_ptid): Update.
9904 (_initialize_ravenscar): Don't initialize base_ptid.
9905 (ravenscar_ops): Remove global.
9907 2019-02-15 Tom Tromey <tromey@adacore.com>
9909 * target.h (push_target): Declare new overload.
9910 * target.c (push_target): New overload, taking an rvalue reference.
9911 * remote.c (remote_target::open_1): Use push_target overload.
9912 * corelow.c (core_target_open): Use push_target overload.
9914 2019-02-15 Tom Tromey <tromey@adacore.com>
9916 * ravenscar-thread.c (is_ravenscar_task)
9917 (ravenscar_task_is_currently_active): Return bool.
9918 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9919 (_initialize_ravenscar): Remove "(void)".
9920 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9923 2019-02-15 Tom Tromey <tromey@adacore.com>
9925 * ravenscar-thread.c (ravenscar_runtime_initializer)
9926 (has_ravenscar_runtime, get_running_thread_id)
9927 (ravenscar_thread_target::resume): Fix indentation.
9929 2019-02-15 Tom Tromey <tromey@adacore.com>
9931 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9932 from ravenscar_arch_ops.
9933 (sparc_ravenscar_ops::fetch_registers)
9934 (sparc_ravenscar_ops::store_registers): Now methods.
9935 (sparc_ravenscar_prepare_to_store): Remove.
9936 (sparc_ravenscar_ops): Redefine.
9937 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9938 methods and destructor. Remove members.
9939 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9940 (ravenscar_thread_target::store_registers)
9941 (ravenscar_thread_target::prepare_to_store): Update.
9942 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9944 (struct ppc_ravenscar_powerpc_ops): Derive from
9946 (ppc_ravenscar_powerpc_ops::fetch_registers)
9947 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9948 (ppc_ravenscar_powerpc_ops): Redefine.
9949 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9950 (ppc_ravenscar_e500_ops::fetch_registers)
9951 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9952 (ppc_ravenscar_e500_ops): Redefine.
9953 * aarch64-ravenscar-thread.c
9954 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9955 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9956 (aarch64_ravenscar_fetch_registers)
9957 (aarch64_ravenscar_store_registers): Now methods.
9958 (aarch64_ravenscar_ops): Redefine.
9960 2019-02-15 Tom Tromey <tromey@adacore.com>
9962 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9963 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9964 (ravenscar_thread_target::stopped_by_watchpoint)
9965 (ravenscar_thread_target::stopped_data_address)
9966 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9968 2019-02-15 Tom Tromey <tromey@adacore.com>
9970 * ravenscar-thread.c: Fix some typos.
9972 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9973 Tom Tromey <tromey@adacore.com>
9975 * ada-lang.c (ada_exception_sal): Change addr_string to a
9977 (create_ada_exception_catchpoint): Update.
9979 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9980 Tom Tromey <tromey@adacore.com>
9982 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9983 (bp_location_ops): Remove.
9984 (base_breakpoint_allocate_location): Update.
9985 (free_bp_location): Update.
9986 * ada-lang.c (class ada_catchpoint_location)
9987 <ada_catchpoint_location>: Remove ops parameter.
9988 (ada_catchpoint_location_dtor): Remove.
9989 (ada_catchpoint_location_ops): Remove.
9990 (allocate_location_exception): Update.
9991 * breakpoint.h (struct bp_location_ops): Remove.
9992 (class bp_location) <bp_location>: Remove bp_location_ops
9994 <~bp_location>: Add destructor.
9997 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9998 Pedro Alves <palves@redhat.com>
10000 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10003 2019-02-14 David Michael <fedora.dm0@gmail.com>
10004 Samuel Thibault <samuel.thibault@gnu.org>
10005 Thomas Schwinge <thomas@codesourcery.com>
10007 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10008 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10010 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10012 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10013 (check_empty): Use "const char *".
10015 * gnu-nat.c (gnu_nat_target::detach): Instead of
10016 'detach_inferior (pid)' call
10017 'detach_inferior (find_inferior_pid (pid))'.
10019 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10020 'nat/fork-inferior.o'.
10021 * gnu-nat.c: #include "nat/fork-inferior.h".
10023 * gnu-nat.c (gnu_nat_target::detach): Instead of
10024 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10025 * gnu-nat.h: #include "inf-child.h".
10026 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10027 'i386_gnu_nat_target::fetch_registers'.
10028 (gnu_store_registers): Rename/move to
10029 'i386_gnu_nat_target::store_registers'.
10031 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10032 * gnu-nat.h (mach_thread_info): New function.
10033 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10035 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10037 2019-02-14 Frederic Konrad <konrad@adacore.com>
10039 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10041 2019-02-14 Joel Brobecker <brobecker@adacore.com>
10043 * windows-nat.c (windows_add_thread): Add new parameter
10044 "main_thread_p" with default value set to false. Update
10045 function documentation as well as all callers.
10046 (windows_delete_thread): Likewise.
10047 (fake_create_process): Update call to windows_add_thread.
10048 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10049 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10050 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10051 call to windows_delete_thread.
10053 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10055 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10057 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10059 * symfile.c (find_separate_debug_file): Use canonical path of
10060 sysroot with child_path instead of gdb_sysroot if it is valid.
10062 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10064 * symfile.c (find_separate_debug_file): Use child_path to
10065 determine if an object file is under a sysroot.
10067 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10069 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10070 unittests/child-path-selftests.c.
10071 * common/pathstuff.c (child_path): New function.
10072 * common/pathstuff.h (child_path): New prototype.
10073 * unittests/child-path-selftests.c: New file.
10075 2019-02-12 John Baldwin <jhb@FreeBSD.org>
10077 * symfile.c (find_separate_debug_file): Look for separate debug
10078 files in debug directories under the sysroot.
10080 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10082 * symtab.h (struct minimal_symbol data_p): New const method.
10083 (struct minimal_symbol text_p): Likewise.
10084 * symtab.c (output_source_filename): Use file name style
10085 to print file name.
10086 (print_symbol_info): Likewise.
10087 (print_msymbol_info): Use address style to print addresses.
10088 Use function name style to print executable text symbols.
10089 (expand_symtab_containing_pc): Use data_p.
10090 (find_pc_sect_compunit_symtab): Likewise.
10092 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10094 * breakpoint.c (describe_other_breakpoints): Use address style
10095 to print addresses.
10096 (say_where): Likewise.
10098 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10100 * ada-typeprint.c (print_func_type): Print function name
10101 style to print function name.
10102 * c-typeprint.c (c_print_type_1): Likewise.
10104 2019-02-11 Alan Hayward <alan.hayward@arm.com>
10106 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10109 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10111 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10114 2019-02-10 Joel Brobecker <brobecker@adacore.com>
10116 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10117 TYPE_CODE_REF types.
10119 2019-02-08 Jim Wilson <jimw@sifive.com>
10121 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10122 (riscv_linux_fregset): New.
10123 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10125 2019-02-07 Tom Tromey <tom@tromey.com>
10127 * thread.c (thread_cancel_execution_command): Update.
10128 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10130 (struct thread_fsm_ops): Remove.
10131 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10132 (thread_fsm_should_stop, thread_fsm_return_value)
10133 (thread_fsm_set_finished, thread_fsm_finished_p)
10134 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10136 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10137 * infrun.c (clear_proceed_status_thread)
10138 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10139 (print_stop_event): Update.
10140 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10142 (step_command_fsm_ops): Remove.
10143 (new_step_command_fsm): Remove.
10145 (step_command_fsm::should_stop): Rename from
10146 step_command_fsm_should_stop.
10147 (step_command_fsm::clean_up): Rename from
10148 step_command_fsm_clean_up.
10149 (step_command_fsm::do_async_reply_reason): Rename from
10150 step_command_fsm_async_reply_reason.
10151 (struct until_next_fsm): Inherit from thread_fsm. Add
10153 (until_next_fsm_ops): Remove.
10154 (new_until_next_fsm): Remove.
10155 (until_next_fsm::should_stop): Rename from
10156 until_next_fsm_should_stop.
10157 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10158 (until_next_fsm::do_async_reply_reason): Rename from
10159 until_next_fsm_async_reply_reason.
10160 (struct finish_command_fsm): Inherit from thread_fsm. Add
10161 constructor. Change type of breakpoint.
10162 (finish_command_fsm_ops): Remove.
10163 (new_finish_command_fsm): Remove.
10164 (finish_command_fsm::should_stop): Rename from
10165 finish_command_fsm_should_stop.
10166 (finish_command_fsm::clean_up): Rename from
10167 finish_command_fsm_clean_up.
10168 (finish_command_fsm::return_value): Rename from
10169 finish_command_fsm_return_value.
10170 (finish_command_fsm::do_async_reply_reason): Rename from
10171 finish_command_fsm_async_reply_reason.
10172 (finish_command): Update.
10173 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10175 (call_thread_fsm_ops): Remove.
10176 (call_thread_fsm::call_thread_fsm): Rename from
10177 new_call_thread_fsm.
10178 (call_thread_fsm::should_stop): Rename from
10179 call_thread_fsm_should_stop.
10180 (call_thread_fsm::should_notify_stop): Rename from
10181 call_thread_fsm_should_notify_stop.
10182 (run_inferior_call, call_function_by_hand_dummy): Update.
10183 * cli/cli-interp.c (should_print_stop_to_console): Update.
10184 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10185 Add constructor. Change type of location_breakpoint,
10187 (until_break_fsm_ops): Remove.
10188 (new_until_break_fsm): Remove.
10189 (until_break_fsm::should_stop): Rename from
10190 until_break_fsm_should_stop.
10191 (until_break_fsm::clean_up): Rename from
10192 until_break_fsm_clean_up.
10193 (until_break_fsm::do_async_reply_reason): Rename from
10194 until_break_fsm_async_reply_reason.
10195 (until_break_command): Update.
10196 * thread-fsm.c: Remove.
10197 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10199 2019-02-07 Tom Tromey <tom@tromey.com>
10201 * yy-remap.h: Add include guard.
10202 * xtensa-tdep.h: Add include guard.
10203 * xcoffread.h: Rename include guard.
10204 * varobj-iter.h: Add include guard.
10205 * tui/tui.h: Rename include guard.
10206 * tui/tui-winsource.h: Rename include guard.
10207 * tui/tui-wingeneral.h: Rename include guard.
10208 * tui/tui-windata.h: Rename include guard.
10209 * tui/tui-win.h: Rename include guard.
10210 * tui/tui-stack.h: Rename include guard.
10211 * tui/tui-source.h: Rename include guard.
10212 * tui/tui-regs.h: Rename include guard.
10213 * tui/tui-out.h: Rename include guard.
10214 * tui/tui-layout.h: Rename include guard.
10215 * tui/tui-io.h: Rename include guard.
10216 * tui/tui-hooks.h: Rename include guard.
10217 * tui/tui-file.h: Rename include guard.
10218 * tui/tui-disasm.h: Rename include guard.
10219 * tui/tui-data.h: Rename include guard.
10220 * tui/tui-command.h: Rename include guard.
10221 * tic6x-tdep.h: Add include guard.
10222 * target/waitstatus.h: Rename include guard.
10223 * target/wait.h: Rename include guard.
10224 * target/target.h: Rename include guard.
10225 * target/resume.h: Rename include guard.
10226 * target-float.h: Rename include guard.
10227 * stabsread.h: Add include guard.
10228 * rs6000-tdep.h: Add include guard.
10229 * riscv-fbsd-tdep.h: Add include guard.
10230 * regformats/regdef.h: Rename include guard.
10231 * record.h: Rename include guard.
10232 * python/python.h: Rename include guard.
10233 * python/python-internal.h: Rename include guard.
10234 * python/py-stopevent.h: Rename include guard.
10235 * python/py-ref.h: Rename include guard.
10236 * python/py-record.h: Rename include guard.
10237 * python/py-record-full.h: Rename include guard.
10238 * python/py-record-btrace.h: Rename include guard.
10239 * python/py-instruction.h: Rename include guard.
10240 * python/py-events.h: Rename include guard.
10241 * python/py-event.h: Rename include guard.
10242 * procfs.h: Add include guard.
10243 * proc-utils.h: Add include guard.
10244 * p-lang.h: Add include guard.
10245 * or1k-tdep.h: Rename include guard.
10246 * observable.h: Rename include guard.
10247 * nto-tdep.h: Rename include guard.
10248 * nat/x86-linux.h: Rename include guard.
10249 * nat/x86-linux-dregs.h: Rename include guard.
10250 * nat/x86-gcc-cpuid.h: Add include guard.
10251 * nat/x86-dregs.h: Rename include guard.
10252 * nat/x86-cpuid.h: Rename include guard.
10253 * nat/ppc-linux.h: Rename include guard.
10254 * nat/mips-linux-watch.h: Rename include guard.
10255 * nat/linux-waitpid.h: Rename include guard.
10256 * nat/linux-ptrace.h: Rename include guard.
10257 * nat/linux-procfs.h: Rename include guard.
10258 * nat/linux-osdata.h: Rename include guard.
10259 * nat/linux-nat.h: Rename include guard.
10260 * nat/linux-namespaces.h: Rename include guard.
10261 * nat/linux-btrace.h: Rename include guard.
10262 * nat/glibc_thread_db.h: Rename include guard.
10263 * nat/gdb_thread_db.h: Rename include guard.
10264 * nat/gdb_ptrace.h: Rename include guard.
10265 * nat/fork-inferior.h: Rename include guard.
10266 * nat/amd64-linux-siginfo.h: Rename include guard.
10267 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10268 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10269 * nat/aarch64-linux.h: Rename include guard.
10270 * nat/aarch64-linux-hw-point.h: Rename include guard.
10271 * mn10300-tdep.h: Add include guard.
10272 * mips-linux-tdep.h: Add include guard.
10273 * mi/mi-parse.h: Rename include guard.
10274 * mi/mi-out.h: Rename include guard.
10275 * mi/mi-main.h: Rename include guard.
10276 * mi/mi-interp.h: Rename include guard.
10277 * mi/mi-getopt.h: Rename include guard.
10278 * mi/mi-console.h: Rename include guard.
10279 * mi/mi-common.h: Rename include guard.
10280 * mi/mi-cmds.h: Rename include guard.
10281 * mi/mi-cmd-break.h: Rename include guard.
10282 * m2-lang.h: Add include guard.
10283 * location.h: Rename include guard.
10284 * linux-record.h: Rename include guard.
10285 * linux-nat.h: Add include guard.
10286 * linux-fork.h: Add include guard.
10287 * i386-darwin-tdep.h: Rename include guard.
10288 * hppa-linux-offsets.h: Add include guard.
10289 * guile/guile.h: Rename include guard.
10290 * guile/guile-internal.h: Rename include guard.
10291 * gnu-nat.h: Rename include guard.
10292 * gdb-stabs.h: Rename include guard.
10293 * frv-tdep.h: Add include guard.
10294 * f-lang.h: Add include guard.
10295 * event-loop.h: Add include guard.
10296 * darwin-nat.h: Rename include guard.
10297 * cp-abi.h: Rename include guard.
10298 * config/sparc/nm-sol2.h: Rename include guard.
10299 * config/nm-nto.h: Rename include guard.
10300 * config/nm-linux.h: Add include guard.
10301 * config/i386/nm-i386gnu.h: Rename include guard.
10302 * config/djgpp/nl_types.h: Rename include guard.
10303 * config/djgpp/langinfo.h: Rename include guard.
10304 * compile/gcc-cp-plugin.h: Add include guard.
10305 * compile/gcc-c-plugin.h: Add include guard.
10306 * compile/compile.h: Rename include guard.
10307 * compile/compile-object-run.h: Rename include guard.
10308 * compile/compile-object-load.h: Rename include guard.
10309 * compile/compile-internal.h: Rename include guard.
10310 * compile/compile-cplus.h: Rename include guard.
10311 * compile/compile-c.h: Rename include guard.
10312 * common/xml-utils.h: Rename include guard.
10313 * common/x86-xstate.h: Rename include guard.
10314 * common/version.h: Rename include guard.
10315 * common/vec.h: Rename include guard.
10316 * common/tdesc.h: Rename include guard.
10317 * common/selftest.h: Rename include guard.
10318 * common/scoped_restore.h: Rename include guard.
10319 * common/scoped_mmap.h: Rename include guard.
10320 * common/scoped_fd.h: Rename include guard.
10321 * common/safe-iterator.h: Rename include guard.
10322 * common/run-time-clock.h: Rename include guard.
10323 * common/refcounted-object.h: Rename include guard.
10324 * common/queue.h: Rename include guard.
10325 * common/ptid.h: Rename include guard.
10326 * common/print-utils.h: Rename include guard.
10327 * common/preprocessor.h: Rename include guard.
10328 * common/pathstuff.h: Rename include guard.
10329 * common/observable.h: Rename include guard.
10330 * common/netstuff.h: Rename include guard.
10331 * common/job-control.h: Rename include guard.
10332 * common/host-defs.h: Rename include guard.
10333 * common/gdb_wait.h: Rename include guard.
10334 * common/gdb_vecs.h: Rename include guard.
10335 * common/gdb_unlinker.h: Rename include guard.
10336 * common/gdb_unique_ptr.h: Rename include guard.
10337 * common/gdb_tilde_expand.h: Rename include guard.
10338 * common/gdb_sys_time.h: Rename include guard.
10339 * common/gdb_string_view.h: Rename include guard.
10340 * common/gdb_splay_tree.h: Rename include guard.
10341 * common/gdb_setjmp.h: Rename include guard.
10342 * common/gdb_ref_ptr.h: Rename include guard.
10343 * common/gdb_optional.h: Rename include guard.
10344 * common/gdb_locale.h: Rename include guard.
10345 * common/gdb_assert.h: Rename include guard.
10346 * common/filtered-iterator.h: Rename include guard.
10347 * common/filestuff.h: Rename include guard.
10348 * common/fileio.h: Rename include guard.
10349 * common/environ.h: Rename include guard.
10350 * common/common-utils.h: Rename include guard.
10351 * common/common-types.h: Rename include guard.
10352 * common/common-regcache.h: Rename include guard.
10353 * common/common-inferior.h: Rename include guard.
10354 * common/common-gdbthread.h: Rename include guard.
10355 * common/common-exceptions.h: Rename include guard.
10356 * common/common-defs.h: Rename include guard.
10357 * common/common-debug.h: Rename include guard.
10358 * common/cleanups.h: Rename include guard.
10359 * common/buffer.h: Rename include guard.
10360 * common/btrace-common.h: Rename include guard.
10361 * common/break-common.h: Rename include guard.
10362 * cli/cli-utils.h: Rename include guard.
10363 * cli/cli-style.h: Rename include guard.
10364 * cli/cli-setshow.h: Rename include guard.
10365 * cli/cli-script.h: Rename include guard.
10366 * cli/cli-interp.h: Rename include guard.
10367 * cli/cli-decode.h: Rename include guard.
10368 * cli/cli-cmds.h: Rename include guard.
10369 * charset-list.h: Add include guard.
10370 * buildsym-legacy.h: Rename include guard.
10371 * bfin-tdep.h: Add include guard.
10372 * ax.h: Rename include guard.
10373 * arm-linux-tdep.h: Add include guard.
10374 * arm-fbsd-tdep.h: Add include guard.
10375 * arch/xtensa.h: Rename include guard.
10376 * arch/tic6x.h: Add include guard.
10377 * arch/i386.h: Add include guard.
10378 * arch/arm.h: Rename include guard.
10379 * arch/arm-linux.h: Rename include guard.
10380 * arch/arm-get-next-pcs.h: Rename include guard.
10381 * arch/amd64.h: Add include guard.
10382 * arch/aarch64-insn.h: Rename include guard.
10383 * arch-utils.h: Rename include guard.
10384 * annotate.h: Add include guard.
10385 * amd64-darwin-tdep.h: Rename include guard.
10386 * aarch64-linux-tdep.h: Add include guard.
10387 * aarch64-fbsd-tdep.h: Add include guard.
10388 * aarch32-linux-nat.h: Add include guard.
10390 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10392 * macrotab.c (macro_define_internal): New function that
10393 factorizes macro_define_object_internal and macro_define_function
10395 (macro_define_object_internal): Use macro_define_internal.
10396 (macro_define_function): Likewise.
10398 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10400 * macrocmd.c (extract_identifier): Return
10401 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10404 2019-02-06 John Baldwin <jhb@FreeBSD.org>
10406 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10408 2019-02-05 Tom Tromey <tom@tromey.com>
10410 * target.c (target_stack::unpush): Move assertion earlier.
10412 2019-01-30 Tom Tromey <tom@tromey.com>
10415 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10416 (gdbpy_parse_and_eval): Likewise.
10417 * python/python-internal.h (gdbpy_allow_threads): New class.
10419 2019-01-28 John Baldwin <jhb@FreeBSD.org>
10421 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10422 (aarch64_fbsd_fpregmap): Move earlier.
10423 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10424 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10425 instead of individual calls to trad_frame_set_reg_addr.
10426 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10428 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10429 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10430 instead of individual calls to trad_frame_set_reg_addr.
10432 2019-01-28 Alan Hayward <alan.hayward@arm.com>
10434 * CONTRIBUTE: Replace contribution list with wiki link.
10436 2019-01-25 Tom Tromey <tom@tromey.com>
10438 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10440 2019-01-25 Tom Tromey <tom@tromey.com>
10442 * xtensa-linux-nat.c: Fix common/ includes.
10443 * xml-support.h: Fix common/ includes.
10444 * xml-support.c: Fix common/ includes.
10445 * x86-linux-nat.c: Fix common/ includes.
10446 * windows-nat.c: Fix common/ includes.
10447 * varobj.h: Fix common/ includes.
10448 * varobj.c: Fix common/ includes.
10449 * value.c: Fix common/ includes.
10450 * valops.c: Fix common/ includes.
10451 * utils.c: Fix common/ includes.
10452 * unittests/xml-utils-selftests.c: Fix common/ includes.
10453 * unittests/utils-selftests.c: Fix common/ includes.
10454 * unittests/unpack-selftests.c: Fix common/ includes.
10455 * unittests/tracepoint-selftests.c: Fix common/ includes.
10456 * unittests/style-selftests.c: Fix common/ includes.
10457 * unittests/string_view-selftests.c: Fix common/ includes.
10458 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10459 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10460 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10461 * unittests/rsp-low-selftests.c: Fix common/ includes.
10462 * unittests/parse-connection-spec-selftests.c: Fix common/
10464 * unittests/optional-selftests.c: Fix common/ includes.
10465 * unittests/offset-type-selftests.c: Fix common/ includes.
10466 * unittests/observable-selftests.c: Fix common/ includes.
10467 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10468 * unittests/memrange-selftests.c: Fix common/ includes.
10469 * unittests/memory-map-selftests.c: Fix common/ includes.
10470 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10471 * unittests/function-view-selftests.c: Fix common/ includes.
10472 * unittests/environ-selftests.c: Fix common/ includes.
10473 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10474 * unittests/common-utils-selftests.c: Fix common/ includes.
10475 * unittests/cli-utils-selftests.c: Fix common/ includes.
10476 * unittests/array-view-selftests.c: Fix common/ includes.
10477 * ui-file.c: Fix common/ includes.
10478 * tui/tui-io.c: Fix common/ includes.
10479 * tracepoint.h: Fix common/ includes.
10480 * tracepoint.c: Fix common/ includes.
10481 * tracefile-tfile.c: Fix common/ includes.
10482 * top.h: Fix common/ includes.
10483 * top.c: Fix common/ includes.
10484 * thread.c: Fix common/ includes.
10485 * target/waitstatus.h: Fix common/ includes.
10486 * target/waitstatus.c: Fix common/ includes.
10487 * target.h: Fix common/ includes.
10488 * target.c: Fix common/ includes.
10489 * target-memory.c: Fix common/ includes.
10490 * target-descriptions.c: Fix common/ includes.
10491 * symtab.h: Fix common/ includes.
10492 * symfile.c: Fix common/ includes.
10493 * stap-probe.c: Fix common/ includes.
10494 * spu-linux-nat.c: Fix common/ includes.
10495 * sparc-nat.c: Fix common/ includes.
10496 * source.c: Fix common/ includes.
10497 * solib.c: Fix common/ includes.
10498 * solib-target.c: Fix common/ includes.
10499 * ser-unix.c: Fix common/ includes.
10500 * ser-tcp.c: Fix common/ includes.
10501 * ser-pipe.c: Fix common/ includes.
10502 * ser-base.c: Fix common/ includes.
10503 * selftest-arch.c: Fix common/ includes.
10504 * s12z-tdep.c: Fix common/ includes.
10505 * rust-exp.y: Fix common/ includes.
10506 * rs6000-aix-tdep.c: Fix common/ includes.
10507 * riscv-tdep.c: Fix common/ includes.
10508 * remote.c: Fix common/ includes.
10509 * remote-notif.h: Fix common/ includes.
10510 * remote-fileio.h: Fix common/ includes.
10511 * remote-fileio.c: Fix common/ includes.
10512 * regcache.h: Fix common/ includes.
10513 * regcache.c: Fix common/ includes.
10514 * record-btrace.c: Fix common/ includes.
10515 * python/python.c: Fix common/ includes.
10516 * python/py-type.c: Fix common/ includes.
10517 * python/py-inferior.c: Fix common/ includes.
10518 * progspace.h: Fix common/ includes.
10519 * producer.c: Fix common/ includes.
10520 * procfs.c: Fix common/ includes.
10521 * proc-api.c: Fix common/ includes.
10522 * printcmd.c: Fix common/ includes.
10523 * ppc-linux-nat.c: Fix common/ includes.
10524 * parser-defs.h: Fix common/ includes.
10525 * osdata.c: Fix common/ includes.
10526 * obsd-nat.c: Fix common/ includes.
10527 * nat/x86-linux.c: Fix common/ includes.
10528 * nat/x86-linux-dregs.c: Fix common/ includes.
10529 * nat/x86-dregs.h: Fix common/ includes.
10530 * nat/x86-dregs.c: Fix common/ includes.
10531 * nat/ppc-linux.c: Fix common/ includes.
10532 * nat/mips-linux-watch.h: Fix common/ includes.
10533 * nat/mips-linux-watch.c: Fix common/ includes.
10534 * nat/linux-waitpid.c: Fix common/ includes.
10535 * nat/linux-ptrace.h: Fix common/ includes.
10536 * nat/linux-ptrace.c: Fix common/ includes.
10537 * nat/linux-procfs.c: Fix common/ includes.
10538 * nat/linux-personality.c: Fix common/ includes.
10539 * nat/linux-osdata.c: Fix common/ includes.
10540 * nat/linux-namespaces.c: Fix common/ includes.
10541 * nat/linux-btrace.h: Fix common/ includes.
10542 * nat/linux-btrace.c: Fix common/ includes.
10543 * nat/fork-inferior.c: Fix common/ includes.
10544 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10545 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10546 * nat/aarch64-linux.c: Fix common/ includes.
10547 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10548 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10549 * namespace.h: Fix common/ includes.
10550 * mips-linux-tdep.c: Fix common/ includes.
10551 * minsyms.c: Fix common/ includes.
10552 * mi/mi-parse.h: Fix common/ includes.
10553 * mi/mi-main.c: Fix common/ includes.
10554 * mi/mi-cmd-env.c: Fix common/ includes.
10555 * memrange.h: Fix common/ includes.
10556 * memattr.c: Fix common/ includes.
10557 * maint.h: Fix common/ includes.
10558 * maint.c: Fix common/ includes.
10559 * main.c: Fix common/ includes.
10560 * machoread.c: Fix common/ includes.
10561 * location.c: Fix common/ includes.
10562 * linux-thread-db.c: Fix common/ includes.
10563 * linux-nat.c: Fix common/ includes.
10564 * linux-fork.c: Fix common/ includes.
10565 * inline-frame.c: Fix common/ includes.
10566 * infrun.c: Fix common/ includes.
10567 * inflow.c: Fix common/ includes.
10568 * inferior.h: Fix common/ includes.
10569 * inferior.c: Fix common/ includes.
10570 * infcmd.c: Fix common/ includes.
10571 * inf-ptrace.c: Fix common/ includes.
10572 * inf-child.c: Fix common/ includes.
10573 * ia64-linux-nat.c: Fix common/ includes.
10574 * i387-tdep.c: Fix common/ includes.
10575 * i386-tdep.c: Fix common/ includes.
10576 * i386-linux-tdep.c: Fix common/ includes.
10577 * i386-linux-nat.c: Fix common/ includes.
10578 * i386-go32-tdep.c: Fix common/ includes.
10579 * i386-fbsd-tdep.c: Fix common/ includes.
10580 * i386-fbsd-nat.c: Fix common/ includes.
10581 * guile/scm-type.c: Fix common/ includes.
10582 * guile/guile.c: Fix common/ includes.
10583 * go32-nat.c: Fix common/ includes.
10584 * gnu-nat.c: Fix common/ includes.
10585 * gdbthread.h: Fix common/ includes.
10586 * gdbarch-selftests.c: Fix common/ includes.
10587 * gdb_usleep.c: Fix common/ includes.
10588 * gdb_select.h: Fix common/ includes.
10589 * gdb_bfd.c: Fix common/ includes.
10590 * gcore.c: Fix common/ includes.
10591 * fork-child.c: Fix common/ includes.
10592 * findvar.c: Fix common/ includes.
10593 * fbsd-nat.c: Fix common/ includes.
10594 * event-top.c: Fix common/ includes.
10595 * event-loop.c: Fix common/ includes.
10596 * dwarf2read.c: Fix common/ includes.
10597 * dwarf2loc.c: Fix common/ includes.
10598 * dwarf2-frame.c: Fix common/ includes.
10599 * dwarf-index-cache.c: Fix common/ includes.
10600 * dtrace-probe.c: Fix common/ includes.
10601 * disasm-selftests.c: Fix common/ includes.
10602 * defs.h: Fix common/ includes.
10603 * csky-tdep.c: Fix common/ includes.
10604 * cp-valprint.c: Fix common/ includes.
10605 * cp-support.h: Fix common/ includes.
10606 * cp-support.c: Fix common/ includes.
10607 * corelow.c: Fix common/ includes.
10608 * completer.h: Fix common/ includes.
10609 * completer.c: Fix common/ includes.
10610 * compile/compile.c: Fix common/ includes.
10611 * compile/compile-loc2c.c: Fix common/ includes.
10612 * compile/compile-cplus-types.c: Fix common/ includes.
10613 * compile/compile-cplus-symbols.c: Fix common/ includes.
10614 * command.h: Fix common/ includes.
10615 * cli/cli-dump.c: Fix common/ includes.
10616 * cli/cli-cmds.c: Fix common/ includes.
10617 * charset.c: Fix common/ includes.
10618 * build-id.c: Fix common/ includes.
10619 * btrace.h: Fix common/ includes.
10620 * btrace.c: Fix common/ includes.
10621 * breakpoint.h: Fix common/ includes.
10622 * breakpoint.c: Fix common/ includes.
10624 (enum agent_op): Fix common/ includes.
10625 * ax-general.c (struct aop_map): Fix common/ includes.
10626 * ax-gdb.c: Fix common/ includes.
10627 * auxv.c: Fix common/ includes.
10628 * auto-load.c: Fix common/ includes.
10629 * arm-tdep.c: Fix common/ includes.
10630 * arch/riscv.c: Fix common/ includes.
10631 * arch/ppc-linux-common.c: Fix common/ includes.
10632 * arch/i386.c: Fix common/ includes.
10633 * arch/arm.c: Fix common/ includes.
10634 * arch/arm-linux.c: Fix common/ includes.
10635 * arch/arm-get-next-pcs.c: Fix common/ includes.
10636 * arch/amd64.c: Fix common/ includes.
10637 * arch/aarch64.c: Fix common/ includes.
10638 * arch/aarch64-insn.c: Fix common/ includes.
10639 * arch-utils.c: Fix common/ includes.
10640 * amd64-windows-tdep.c: Fix common/ includes.
10641 * amd64-tdep.c: Fix common/ includes.
10642 * amd64-sol2-tdep.c: Fix common/ includes.
10643 * amd64-obsd-tdep.c: Fix common/ includes.
10644 * amd64-nbsd-tdep.c: Fix common/ includes.
10645 * amd64-linux-tdep.c: Fix common/ includes.
10646 * amd64-linux-nat.c: Fix common/ includes.
10647 * amd64-fbsd-tdep.c: Fix common/ includes.
10648 * amd64-fbsd-nat.c: Fix common/ includes.
10649 * amd64-dicos-tdep.c: Fix common/ includes.
10650 * amd64-darwin-tdep.c: Fix common/ includes.
10651 * agent.c: Fix common/ includes.
10652 * ada-lang.h: Fix common/ includes.
10653 * ada-lang.c: Fix common/ includes.
10654 * aarch64-tdep.c: Fix common/ includes.
10656 2019-01-25 Tom Tromey <tom@tromey.com>
10658 * common/create-version.sh: Use common/version.h.
10660 2019-01-24 Pedro Alves <palves@redhat.com>
10662 * infrun.c (signal_stop, signal_print, signal_program)
10663 (signal_catch, signal_pass): Now arrays instead of pointers.
10664 (update_signals_program_target, do_target_resume)
10665 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10666 * linux-nat.c (linux_nat_target::pass_signals)
10667 (linux_nat_target::create_inferior, linux_nat_target::attach):
10669 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10670 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10671 * procfs.c (procfs_target::pass_signals): Adjust.
10672 * record-full.c (record_full_target::resume): Adjust.
10673 * remote.c (remote_target::pass_signals)
10674 (remote_target::program_signals): Adjust.
10675 * target-debug.h (target_debug_print_signals): Now takes a
10676 gdb::array_view as parameter. Adjust.
10677 * target.h (target_ops) <pass_signals, program_signals>: Replace
10678 pointer and length parameters with gdb::array_view.
10679 (target_pass_signals, target_program_signals): Likewise.
10680 * target-delegates.c: Regenerate.
10682 2019-01-24 Pedro Alves <palves@redhat.com>
10684 * common/forward-scope-exit.h
10685 (forward_scope_exit::forward_scope_exit): Pass arguments to
10686 m_bind_function directly, instead of creating a std::bind and
10689 2019-01-24 Alan Hayward <alan.hayward@arm.com>
10691 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10692 for static members.
10693 (pass_in_v_vfp_candidate): Likewise.
10695 2019-01-23 Tom Tromey <tom@tromey.com>
10696 Pedro Alves <palves@redhat.com>
10698 * regcache.c (class regcache_invalidator): Remove.
10699 (regcache::raw_write): Use make_scope_exit.
10701 2019-01-23 Tom Tromey <tom@tromey.com>
10703 * ui-out.h (class ui_out_emit_type): Update comment.
10705 2019-01-23 Tom Tromey <tom@tromey.com>
10707 * infrun.c (fetch_inferior_event): Update comment.
10709 2019-01-23 Tom Tromey <tom@tromey.com>
10710 Pedro Alves <palves@redhat.com>
10712 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10714 (fetch_inferior_event): Use SCOPE_EXIT.
10717 2019-01-23 Tom Tromey <tom@tromey.com>
10718 Pedro Alves <palves@redhat.com>
10720 * infrun.c (disable_thread_events): Delete.
10721 (stop_all_threads): Use SCOPE_EXIT.
10723 2019-01-23 Tom Tromey <tom@tromey.com>
10724 Pedro Alves <palves@redhat.com>
10726 * symfile.c: Include forward-scope-exit.h.
10727 (clear_symtab_users_cleanup): Replace forward declaration with
10728 a FORWARD_SCOPE_EXIT.
10729 (syms_from_objfile_1): Use the forward_scope_exit and
10730 gdb::optional instead of cleanup_function.
10731 (reread_symbols): Use the forward_scope_exit instead of
10733 (clear_symtab_users_cleanup): Remove function.
10735 2019-01-23 Tom Tromey <tom@tromey.com>
10736 Pedro Alves <palves@redhat.com>
10738 * linux-nat.c: Include scope-exit.h.
10739 (cleanup_target_stop): Remove.
10740 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10743 2019-01-23 Tom Tromey <tom@tromey.com>
10744 Pedro Alves <palves@redhat.com>
10746 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10747 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10749 2019-01-23 Tom Tromey <tom@tromey.com>
10750 Andrew Burgess <andrew.burgess@embecosm.com>
10751 Pedro Alves <palves@redhat.com>
10753 * infrun.c (fetch_inferior_event): Use scope_exit.
10754 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10755 * top.c (execute_command): Use scope_exit.
10756 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10757 * utils.c (do_bpstat_clear_actions_cleanup)
10758 (make_bpstat_clear_actions_cleanup): Remove.
10760 2019-01-23 Tom Tromey <tom@tromey.com>
10761 Pedro Alves <palves@redhat.com>
10763 * infrun.c: Include "common/scope-exit.h"
10764 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10765 (wait_for_inferior): Use SCOPE_EXIT.
10766 (fetch_inferior_event): Use scope_exit.
10768 2019-01-23 Tom Tromey <tom@tromey.com>
10769 Pedro Alves <palves@redhat.com>
10771 * breakpoint.c (create_breakpoint): Remove cleanup.
10773 2019-01-23 Tom Tromey <tom@tromey.com>
10774 Andrew Burgess <andrew.burgess@embecosm.com>
10775 Pedro Alves <palves@redhat.com>
10777 2019-01-23 Pedro Alves <palves@redhat.com>
10779 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10781 2019-01-23 Pedro Alves <palves@redhat.com>
10782 Andrew Burgess <andrew.burgess@embecosm.com>
10784 * gdbthread.h: Include "common/forward-scope-exit.h".
10785 (scoped_finish_thread_state): Redefine custom class in terms of
10786 forward_scope_exit.
10788 2019-01-23 Pedro Alves <palves@redhat.com>
10789 Andrew Burgess <andrew.burgess@embecosm.com>
10791 * common/forward-scope-exit.h: New file.
10793 2019-01-23 Pedro Alves <palves@redhat.com>
10794 Andrew Burgess <andrew.burgess@embecosm.com>
10795 Tom Tromey <tom@tromey.com>
10797 * common/scope-exit.h: New file.
10799 2019-01-23 Pedro Alves <palves@redhat.com>
10801 * common/preprocessor.h (ESC): Rename to ...
10802 (ESC_PARENS): ... this.
10803 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10804 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10806 2019-01-23 Tom Tromey <tom@tromey.com>
10808 * language.h (class scoped_switch_to_sym_language_if_auto):
10809 Initialize m_lang in both cases.
10811 2019-01-23 Alan Hayward <alan.hayward@arm.com>
10813 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10816 2019-01-22 Tom Tromey <tom@tromey.com>
10818 * corelow.c: Do not include sys/file.h.
10820 2019-01-22 Tom Tromey <tom@tromey.com>
10822 * tui/tui-wingeneral.h: Include gdb_curses.h.
10824 2019-01-22 Tom Tromey <tom@tromey.com>
10826 * source-cache.h (class source_cache) <get_source_lines,
10827 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10829 2019-01-22 Tom Tromey <tom@tromey.com>
10831 * remote-fileio.h (struct remote_target): Declare.
10833 2019-01-22 Tom Tromey <tom@tromey.com>
10835 * python/py-arch.c: Do not include py-ref.h.
10836 * python/py-bpevent.c: Do not include py-ref.h.
10837 * python/py-cmd.c: Do not include py-ref.h.
10838 * python/py-continueevent.c: Do not include py-ref.h.
10839 * python/py-event.h: Do not include py-ref.h.
10840 * python/py-evtregistry.c: Do not include py-ref.h.
10841 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10842 * python/py-frame.c: Do not include py-ref.h.
10843 * python/py-framefilter.c: Do not include py-ref.h.
10844 * python/py-function.c: Do not include py-ref.h.
10845 * python/py-infevents.c: Do not include py-ref.h.
10846 * python/py-linetable.c: Do not include py-ref.h.
10847 * python/py-objfile.c: Do not include py-ref.h.
10848 * python/py-param.c: Do not include py-ref.h.
10849 * python/py-prettyprint.c: Do not include py-ref.h.
10850 * python/py-progspace.c: Do not include py-ref.h.
10851 * python/py-symbol.c: Do not include py-ref.h.
10852 * python/py-symtab.c: Do not include py-ref.h.
10853 * python/py-type.c: Do not include py-ref.h.
10854 * python/py-unwind.c: Do not include py-ref.h.
10855 * python/py-utils.c: Do not include py-ref.h.
10856 * python/py-value.c: Do not include py-ref.h.
10857 * python/py-varobj.c: Do not include py-ref.h.
10858 * python/py-xmethods.c: Do not include py-ref.h.
10859 * python/python.c: Do not include py-ref.h.
10860 * varobj.c: Do not include py-ref.h.
10862 2019-01-22 Tom Tromey <tom@tromey.com>
10864 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10865 keyword for bcache.
10867 2019-01-22 Tom Tromey <tom@tromey.com>
10869 * compile/compile-cplus-types.c: Remove a comment by #include.
10871 2019-01-22 Tom Tromey <tom@tromey.com>
10873 * compile/gcc-c-plugin.h: Include compile-internal.h.
10875 2019-01-22 Tom Tromey <tom@tromey.com>
10877 * stabsread.c (EXTERN): Do not define.
10878 (symnum, next_symbol_text_func, processing_gcc_compilation)
10879 (within_function, global_sym_chain, global_stabs)
10880 (previous_stab_code, this_object_header_files)
10881 (n_this_object_header_files)
10882 (n_allocated_this_object_header_files): Define.
10883 * stabsread.h (EXTERN): Never define. Use "extern".
10885 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10887 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10890 2019-01-21 Tom Tromey <tom@tromey.com>
10892 * ui-out.c: Fix includes.
10893 * tui/tui-source.c: Fix includes.
10894 * target.c: Fix includes.
10895 * remote.c: Fix includes.
10896 * regcache.c: Fix includes.
10897 * python/py-block.c: Fix includes.
10898 * printcmd.c: Fix includes.
10899 * or1k-tdep.c: Fix includes.
10900 * mi/mi-main.c: Fix includes.
10901 * m32r-tdep.c: Fix includes.
10902 * csky-tdep.c: Fix includes.
10903 * compile/compile-cplus-types.c: Fix includes.
10904 * cli/cli-interp.c: Fix includes.
10906 2019-01-21 Alan Hayward <alan.hayward@arm.com>
10908 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10911 2019-01-16 Tom Tromey <tom@tromey.com>
10913 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10915 (struct objfile) <msymbols_range>: Move from top level.
10916 <msymbols>: New method.
10917 (class objfile_msymbols): Remove.
10918 * symtab.c (default_collect_symbol_completion_matches_break_on):
10920 * symmisc.c (dump_msymbols): Update.
10921 * stabsread.c (scan_file_globals): Update.
10922 * objc-lang.c (info_selectors_command, info_classes_command)
10923 (find_methods): Update.
10924 * minsyms.c (find_solib_trampoline_target): Update.
10925 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10926 * coffread.c (coff_symfile_read): Update.
10927 * ada-lang.c (ada_lookup_simple_minsym)
10928 (ada_collect_symbol_completion_matches): Update.
10930 2019-01-16 Tom Tromey <tom@tromey.com>
10932 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10933 type. Remove no-argument constructor.
10934 <iterator::operator++>: Simplify.
10936 <end>: Use minimal_symbol_count.
10938 2019-01-16 Tom Tromey <tom@tromey.com>
10940 * objfiles.h (struct objfile) <psymtabs>: New method.
10941 (class objfile_psymtabs): Remove.
10942 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10944 <range>: New method.
10945 (require_partial_symbols): Change return type.
10946 * psymtab.c (require_partial_symbols)
10947 (psym_expand_symtabs_matching): Update.
10948 * mdebugread.c (parse_partial_symbols): Update.
10949 * dbxread.c (dbx_end_psymtab): Update.
10951 2019-01-15 Tom Tromey <tom@tromey.com>
10953 * symtab.c (lookup_objfile_from_block)
10954 (lookup_symbol_in_objfile_symtabs)
10955 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10956 (find_line_symtab, info_sources_command)
10957 (default_collect_symbol_completion_matches_break_on)
10958 (make_source_files_completion_list): Update.
10959 * symmisc.c (print_objfile_statistics, dump_objfile)
10960 (maintenance_print_symbols, maintenance_info_symtabs)
10961 (maintenance_check_symtabs, maintenance_info_line_tables):
10963 * source.c (select_source_symtab)
10964 (forget_cached_source_info_for_objfile): Update.
10965 * objfiles.h (class objfile_compunits): Remove.
10966 (struct objfile) <compunits_range>: New typedef.
10967 (compunits): New method.
10968 * objfiles.c (objfile_relocate1): Update.
10969 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10970 * maint.c (count_symtabs_and_blocks): Update.
10971 * linespec.c (iterate_over_all_matching_symtabs): Update.
10972 * cp-support.c (add_symbol_overload_list_qualified): Update.
10973 * coffread.c (coff_symtab_read): Update.
10974 * ada-lang.c (add_nonlocal_symbols)
10975 (ada_collect_symbol_completion_matches)
10976 (ada_add_global_exceptions): Update.
10978 2019-01-15 Tom Tromey <tom@tromey.com>
10980 * progspace.h (program_space) <objfiles_safe_range>: New
10982 <objfiles_safe>: New method.
10983 * objfiles.h (class all_objfiles_safe): Remove.
10984 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10985 * jit.c (jit_inferior_exit_hook): Update.
10987 2019-01-17 Tom Tromey <tom@tromey.com>
10989 * progspace.h (program_space) <objfiles_range>: New typedef.
10990 <objfiles>: New method.
10991 <objfiles_head>: Rename from objfiles.
10992 (object_files): Update.
10993 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10994 * guile/scm-pretty-print.c
10995 (ppscm_find_pretty_printer_from_objfiles): Update.
10996 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10997 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10999 * python/py-progspace.c (pspy_get_objfiles): Update.
11000 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11002 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11003 (objfpy_lookup_objfile_by_build_id): Update.
11004 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11005 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11007 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11008 (expand_symtab_containing_pc, lookup_objfile_from_block)
11009 (lookup_static_symbol, basic_lookup_transparent_type)
11010 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11011 (find_line_symtab, info_sources_command)
11012 (default_collect_symbol_completion_matches_break_on)
11013 (make_source_files_completion_list, find_main_name): Update.
11014 * symmisc.c (print_symbol_bcache_statistics)
11015 (print_objfile_statistics, maintenance_print_symbols)
11016 (maintenance_print_msymbols, maintenance_print_objfiles)
11017 (maintenance_info_symtabs, maintenance_check_symtabs)
11018 (maintenance_expand_symtabs, maintenance_info_line_tables):
11020 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11021 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11022 (map_overlay_command, unmap_overlay_command)
11023 (simple_overlay_update, expand_symtabs_matching)
11024 (map_symbol_filenames): Update.
11025 * symfile-debug.c (set_debug_symfile): Update.
11026 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11028 * source.c (select_source_symtab, forget_cached_source_info):
11030 * solib.c (solib_read_symbols): Update.
11031 * solib-spu.c (append_ocl_sos): Update.
11032 * psymtab.c (maintenance_print_psymbols)
11033 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11034 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11035 * printcmd.c (info_symbol_command): Update.
11036 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11038 * objfiles.h (class all_objfiles): Remove.
11039 * objfiles.c (have_partial_symbols, have_full_symbols)
11040 (have_minimal_symbols, qsort_cmp, update_section_map)
11041 (shared_objfile_contains_address_p)
11042 (default_iterate_over_objfiles_in_search_order): Update.
11043 * objc-lang.c (info_selectors_command, info_classes_command)
11044 (find_methods): Update.
11045 * minsyms.c (find_solib_trampoline_target): Update.
11046 * maint.c (maintenance_info_sections)
11047 (maintenance_translate_address, count_symtabs_and_blocks):
11049 * main.c (captured_main_1): Update.
11050 * linux-thread-db.c (try_thread_db_load_from_pdir)
11051 (has_libpthread): Update.
11052 * linespec.c (iterate_over_all_matching_symtabs)
11053 (search_minsyms_for_name): Update.
11054 * jit.c (jit_find_objf_with_entry_addr): Update.
11055 * hppa-tdep.c (find_unwind_entry)
11056 (hppa_lookup_stub_minimal_symbol): Update.
11057 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11059 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11060 (elf_gnu_ifunc_resolve_by_got): Update.
11061 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11062 * dwarf-index-write.c (save_gdb_index_command): Update.
11063 * cp-support.c (add_symbol_overload_list_qualified): Update.
11064 * breakpoint.c (create_overlay_event_breakpoint)
11065 (create_longjmp_master_breakpoint)
11066 (create_std_terminate_master_breakpoint)
11067 (create_exception_master_breakpoint): Update.
11068 * blockframe.c (find_pc_partial_function): Update.
11069 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11070 (ada_collect_symbol_completion_matches)
11071 (ada_add_global_exceptions): Update.
11073 2019-01-17 Tom Tromey <tom@tromey.com>
11075 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11077 (solib_target_parse_libraries): Change return type.
11078 (library_list_start_segment, library_list_start_section)
11079 (library_list_end_library, library_list_start_library); Update.
11080 (solib_target_free_library_list): Remove.
11081 (solib_target_parse_libraries): Remove cleanup. Change return
11083 (solib_target_current_sos): Update.
11085 2019-01-17 Tom Tromey <tromey@bapiya>
11087 * valprint.c: Replace "the the" with "the".
11088 * symtab.c: Replace "the the" with "the".
11089 * solib.c: Replace "the the" with "the".
11090 * solib-dsbt.c: Replace "the the" with "the".
11091 * linespec.c: Replace "the the" with "the".
11092 * dwarf2loc.h: Replace "the the" with "the".
11093 * amd64-windows-tdep.c: Replace "the the" with "the".
11094 * aarch64-tdep.c: Replace "the the" with "the".
11096 2019-01-16 Keith Seitz <keiths@redhat.com>
11099 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11100 <builder>: Rename to ..
11101 <m_builder>: ... this and make private.
11102 (dwarf2_cu::get_builder): New method. Change all users of
11103 `builder' to use this method.
11104 (dwarf2_start_symtab): Move to ...
11105 (dwarf2_cu::start_symtab): ... here. Update all callers
11106 (setup_type_unit_groups): Move to ...
11107 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11109 (dwarf2_cu::reset_builder): New method.
11110 (process_full_compunit, process_full_type_unit): Use
11111 dwarf2_cu::reset_builder.
11112 (follow_die_offset): Record the ancestor CU if it is different
11113 from the followed DIE's CU.
11114 (follow_die_sig_1): Likewise.
11116 2019-01-15 Tom Tromey <tom@tromey.com>
11118 * remote.c (class remote_state) <buf>: Now a char_vector.
11119 <buf_size>: Remove.
11120 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11122 (remote_target::getpkt_or_notif_sane_1)
11123 (remote_target::getpkt_sane)
11124 (remote_target::getpkt_or_notif_sane): Likewise.
11125 (class remote_target) <putpkt>: New overload.
11126 (remote_target::read_frame): Change type of "buf_p". Remove
11127 sizeof_p parameter.
11128 (packet_ok): New overload.
11129 (packet_check_result): New overload.
11132 2019-01-14 Tom Tromey <tom@tromey.com>
11134 * remote-notif.c (handle_notification, remote_notif_ack)
11135 (remote_notif_parse): Make "buf" const.
11136 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11138 (remote_notif_parse, remote_notif_ack, handle_notification):
11140 * remote.c (remote_notif_stop_parse): Make "buf" const.
11141 (remote_target::remote_parse_stop_reply): Make "buf" const.
11142 (remote_notif_stop_ack): Make "buf" const.
11144 2019-01-14 Tom Tromey <tom@tromey.com>
11146 * remote.c (remote_console_output): Make parameter const.
11148 2019-01-14 Tom Tromey <tom@tromey.com>
11150 * target-debug.h (target_debug_print_signals): Constify.
11151 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11152 * procfs.c (procfs_target::pass_signals): Update.
11153 * linux-nat.c (linux_nat_target::pass_signals): Update.
11154 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11155 * target-delegates.c: Rebuild.
11156 * remote.c (remote_target::program_signals): Update.
11157 (remote_target::pass_signals): Update.
11158 * target.c (target_pass_signals): Constify argument.
11159 (target_program_signals): Likewise.
11160 * target.h (struct target_ops) <pass_signals, program_signals>:
11162 (target_pass_signals, target_program_signals): Constify argument.
11164 2019-01-14 Tom Tromey <tom@tromey.com>
11167 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11169 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11171 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11173 * rs6000-tdep.c: Include reggroups.h.
11174 (IS_V_ALIAS_PSEUDOREG): Define.
11175 (rs6000_register_name): Return names for the "vX" aliases.
11176 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11177 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11178 aliases. Call default_register_reggroup_p for all other
11180 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11182 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11183 Handle "vX" aliases.
11184 (v_alias_pseudo_register_collect): New function.
11185 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11186 (rs6000_gdbarch_init): Initialize "vX" aliases as
11187 pseudo-registers. Restore registration of
11188 rs6000_pseudo_register_reggroup_p with
11189 set_tdesc_pseudo_register_reggroup_p.
11191 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11193 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11194 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11195 set_gdbarch_num_pseudo_regs.
11197 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11199 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11200 Remove arg prefixname, add do_set and do_show.
11201 Add member functions set_list and show_list.
11202 * cli/cli-style.c (class cli_style_option): Update accordingly.
11203 (style_set_list): Move to file scope.
11204 (style_show_list): Likewise.
11205 (set_style): Call help_list.
11206 (show_style): Call cmd_show_list.
11207 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11208 Update to use the new macro.
11210 2019-10-12 Joel Brobecker <brobecker@adacore.com>
11212 * ada-lang.c (_initialize_ada_language): Expand the help text
11213 for the "catch exception" command.
11215 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11217 * symtab.c (matching_obj_sections): Initialize obj,
11218 declare it closer to its usage.
11220 2019-01-10 Tom Tromey <tom@tromey.com>
11222 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11223 (basic_inf_threads_range): Remove.
11224 (inf_threads_range, inf_non_exited_threads_range)
11225 (safe_inf_threads_range): Use next_adapter.
11227 2019-01-10 Keith Seitz <keiths@redhat.com>
11231 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11232 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11234 2019-01-10 Keith Seitz <keiths@redhat.com>
11238 * dictionary.c (pending_to_vector): Remove.
11239 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11240 Remove _1 suffix, replacing functions of the same name. Update
11242 (dict_create_hashed, dict_create_hashed_expandable)
11243 (dict_create_linear, dict_create_linear_expandable, dict_free)
11244 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11245 Make functions static.
11247 2019-01-10 Keith Seitz <keiths@redhat.com>
11251 * dictionary.h (struct dictionary): Replace declaration with
11253 (dict_create_hashed, dict_create_hashed_expandable)
11254 (dict_create_linear, dict_create_linear_expandable)
11255 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11256 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11257 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11258 taking multidictionary argument.
11259 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11260 * block.h (struct block) <dict>: Change to multidictionary
11261 and rename `multidict'.
11262 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11263 symmisc.c: Update all dictionary references to multidictionary.
11265 2019-01-10 Keith Seitz <keiths@redhat.com>
11269 * dictionary.c: Include unordered_map.
11270 (pending_to_vector): New function.
11271 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11272 Rewrite the non-"_1" functions to take vector instead
11274 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11275 "new" _1 versions of the same name.
11276 (multidictionary): Define.
11277 (std::hash<enum language): New definition.
11278 (collate_pending_symbols_by_language, mdict_create_hashed)
11279 (mdict_create_hashed_expandable, mdict_create_linear)
11280 (mdict_create_linear_expandable, mdict_free)
11281 (find_language_dictionary, create_new_language_dictionary)
11282 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11283 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11284 (mdict_size, mdict_empty): New functions.
11285 * dictionary.h (mdict_iterator): Define.
11287 2019-01-10 Pedro Alves <palves@redhat.com>
11289 * breakpoint.c (read_uploaded_action)
11290 (create_tracepoint_from_upload): Adjust to use
11291 gdb::unique_xmalloc_ptr.
11292 * ctf.c (ctf_write_uploaded_tp):
11293 (SET_ARRAY_FIELD): Use emplace_back.
11294 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11295 * tracefile-tfile.c (tfile_write_uploaded_tp):
11296 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11297 gdb::unique_xmalloc_ptr.
11298 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11299 at_string, cond_string, cmd_strings>: Replace char pointers
11300 with gdb::unique_xmalloc_ptr.
11302 2019-01-10 Pedro Alves <palves@redhat.com>
11304 * solib-target.c (library_list_start_library): Don't xstrdup name.
11306 2019-01-10 Pedro Alves <palves@redhat.com>
11308 * mdebugread.c (parse_partial_symbols): Use
11309 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11311 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11313 * linux-fork.c (scoped_switch_fork_info)
11314 <~scoped_switch_fork_info>: Fix incorrect variable name.
11316 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11318 * linux-fork.c (scoped_switch_fork_info)
11319 <scoped_switch_fork_info>: Make explicit.
11320 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11322 2019-01-10 Tom Tromey <tom@tromey.com>
11324 * objfiles.h (objfile::reset_psymtabs): Update.
11325 * objfiles.c (objfile::objfile): Update.
11326 * psymtab.h (psymtab_storage::obstack): Update.
11327 (psymtab_storage::m_obstack): Use gdb::optional.
11328 (class psymtab_storage): Update comment. Remove objfile
11330 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11332 2019-01-10 Tom Tromey <tom@tromey.com>
11334 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11335 <free_psymtabs>: Now private.
11336 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11337 (allocate_psymtab): Use new method.
11339 2019-01-10 Tom Tromey <tom@tromey.com>
11341 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11342 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11343 * mdebugread.c (parse_partial_symbols): Use
11344 allocate_dependencies.
11345 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11346 allocate_dependencies.
11347 (process_psymtab_comp_unit_reader)
11348 (build_type_psymtab_dependencies): Likewise.
11349 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11351 2019-01-10 Tom Tromey <tom@tromey.com>
11353 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11354 PSYMBOL_SET_LANGUAGE.
11355 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11357 2019-01-10 Tom Tromey <tom@tromey.com>
11359 * psymtab.h (psymtab_storage::obstack): New method.
11360 <m_obstack>: Rename from obstack; now private.
11361 * psymtab.c (psymtab_storage): Update.
11362 * dwarf2read.c (create_addrmap_from_index)
11363 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11366 2019-01-10 Tom Tromey <tom@tromey.com>
11368 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11369 * objfiles.h (objfile::reset_psymtabs): New method.
11371 2019-01-10 Tom Tromey <tom@tromey.com>
11373 * symmisc.c (print_symbol_bcache_statistics): Update.
11374 (print_objfile_statistics): Update.
11375 * symfile.c (reread_symbols): Update.
11376 * psymtab.h (class psymtab_storage): New.
11377 * psymtab.c (psymtab_storage): New constructor.
11378 (~psymtab_storage): New destructor.
11379 (require_partial_symbols): Update.
11380 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11381 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11382 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11383 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11384 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11385 (start_psymtab_common, end_psymtab_common)
11386 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11387 (allocate_psymtab): Update.
11388 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11390 (dump_psymtab_addrmap, maintenance_print_psymbols)
11391 (maintenance_check_psymtabs): Update.
11392 (class objfile_psymtabs): Move to objfiles.h.
11393 * psympriv.h (discard_psymtab): Now inline.
11394 (psymtab_discarder::psymtab_discarder): Update.
11395 (psymtab_discarder::~psymtab_discarder): Update.
11396 (ALL_OBJFILE_PSYMTABS): Rewrite.
11397 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11398 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11400 <partial_symtabs>: New field.
11401 (class objfile_psymtabs): Move from psymtab.h. Update.
11402 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11404 (objfile::~objfile): Don't destroy psymbol_cache.
11405 * mdebugread.c (parse_partial_symbols): Update.
11406 * dwarf2read.c (create_addrmap_from_index)
11407 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11408 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11409 (add_partial_subprogram, dwarf2_ranges_read): Update.
11410 * dwarf-index-write.c (write_address_map)
11411 (write_one_signatured_type, recursively_write_psymbols)
11412 (class debug_names, class debug_names, write_psymtabs_to_index):
11415 2019-01-10 Tom Tromey <tom@tromey.com>
11417 * symtab.h (SYMBOL_SET_NAMES): Update.
11418 (symbol_set_names): Update.
11419 (MSYMBOL_SET_NAMES): Update.
11420 * symtab.c (symbol_set_names): Change argument to be an
11421 objfile_per_bfd_storage.
11422 * psymtab.c (add_psymbol_to_bcache): Update.
11423 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11425 2019-01-10 Tom Tromey <tom@tromey.com>
11427 * symtab.c (create_demangled_names_hash): Change argument to be an
11428 objfile_per_bfd_storage.
11429 (symbol_set_names): Update.
11431 2019-01-10 Tom Tromey <tom@tromey.com>
11433 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11435 * psymtab.c (init_psymbol_list): Do nothing if already called.
11436 * psympriv.h (init_psymbol_list): Add comment.
11437 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11439 * dbxread.c (dbx_symfile_read): Unconditionally call
11442 2019-01-10 Tom Tromey <tom@tromey.com>
11444 * xcoffread.c (scan_xcoff_symtab): Update.
11445 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11447 * mdebugread.c (parse_partial_symbols)
11448 (handle_psymbol_enumerators): Update.
11449 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11450 * dbxread.c (read_dbx_symtab): Update.
11451 * psympriv.h (psymbol_placement): New enum.
11452 (add_psymbol_to_list): Update.
11454 2019-01-10 Tom Tromey <tom@tromey.com>
11456 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11457 static_psymbols parameters.
11458 (scan_xcoff_symtab): Update.
11459 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11460 static_psymbols parameters.
11461 * psympriv.h (start_psymtab_common): Update.
11462 * mdebugread.c (parse_partial_symbols): Update.
11463 * dwarf2read.c (create_partial_symtab): Update.
11464 * dbxread.c (read_dbx_symtab): Update.
11465 (start_psymtab): Remove global_psymbols and static_psymbols
11468 2019-01-10 Tom Tromey <tom@tromey.com>
11470 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11471 * psymtab.c (allocate_psymtab): Add comment.
11472 * psympriv.h (allocate_psymtab): Add comment.
11473 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11475 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11477 2019-01-10 Tom Tromey <tom@tromey.com>
11479 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11481 * mipsread.c: Include mdebugread.h.
11482 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11484 * elfread.c: Include mdebugread.h.
11486 2019-01-09 Tom Tromey <tom@tromey.com>
11488 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11489 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11490 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11491 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11492 (psym_lookup_symbol, psym_find_last_source_symtab)
11493 (psym_forget_cached_source_info, psym_print_stats)
11494 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11495 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11496 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11497 (psym_find_compunit_symtab_by_address)
11498 (maintenance_print_psymbols, maintenance_info_psymtabs)
11499 (maintenance_check_psymtabs): Use ranged for.
11500 * psymtab.h (class objfile_psymtabs): New.
11501 (require_partial_symbols): Return objfile_psymtabs.
11502 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11504 2019-01-09 Tom Tromey <tom@tromey.com>
11506 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11507 (find_pc_mapped_section, list_overlays_command)
11508 (map_overlay_command, unmap_overlay_command)
11509 (simple_overlay_update): Use all_objfiles.
11510 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11511 * printcmd.c (info_symbol_command): Use all_objfiles.
11512 * objfiles.h (ALL_OBJSECTIONS): Remove.
11513 * maint.c (maintenance_translate_address): Use all_objfiles.
11514 * gcore.c (gcore_create_callback): Use all_objfiles.
11515 (objfile_find_memory_regions): Likewise.
11517 2019-01-09 Tom Tromey <tom@tromey.com>
11519 * symtab.c (find_line_symtab, info_sources_command)
11520 (make_source_files_completion_list): Use objfile_compunits.
11521 * source.c (select_source_symtab): Use objfile_compunits.
11522 * objfiles.h (struct objfile): Update comment.
11523 (ALL_OBJFILES): Remove.
11524 (ALL_FILETABS): Remove.
11525 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11528 2019-01-09 Tom Tromey <tom@tromey.com>
11530 * symmisc.c (print_objfile_statistics, dump_objfile)
11531 (maintenance_print_symbols): Use compunit_filetabs.
11532 * source.c (forget_cached_source_info_for_objfile): Use
11534 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11535 (ALL_FILETABS): Use compunit_filetabs.
11536 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11537 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11539 2019-01-09 Tom Tromey <tom@tromey.com>
11541 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11542 (compunit_filetabs): New.
11543 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11545 (info_sources_command, make_source_files_completion_list): Remove
11547 * symmisc.c (print_objfile_statistics, dump_objfile)
11548 (maintenance_print_symbols): Remove declaration.
11549 (maintenance_info_symtabs): Use compunit_filetabs.
11550 (maintenance_info_line_tables): Likewise.
11551 * source.c (select_source_symtab): Change local variable name.
11552 (forget_cached_source_info_for_objfile): Remove declaration.
11553 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11554 * objfiles.c (objfile_relocate1): Remove declaration.
11555 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11557 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11558 * coffread.c (coff_symtab_read): Remove declaration.
11559 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11562 2019-01-09 Tom Tromey <tom@tromey.com>
11564 * symtab.c (lookup_objfile_from_block)
11565 (find_pc_sect_compunit_symtab, search_symbols)
11566 (default_collect_symbol_completion_matches_break_on): Use
11568 * objfiles.h (ALL_COMPUNITS): Remove.
11569 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11570 * cp-support.c (add_symbol_overload_list_qualified): Use
11572 * ada-lang.c (ada_collect_symbol_completion_matches)
11573 (ada_add_global_exceptions): Use objfile_compunits.
11575 2019-01-09 Tom Tromey <tom@tromey.com>
11577 * source.c (select_source_symtab)
11578 (forget_cached_source_info_for_objfile): Remove declaration.
11579 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11581 * maint.c (count_symtabs_and_blocks): Remove declaration.
11582 * cp-support.c (add_symbol_overload_list_qualified): Remove
11584 * coffread.c (coff_symtab_read): Remove declaration.
11585 * symtab.c (lookup_symbol_in_objfile_symtabs)
11586 (basic_lookup_transparent_type_1): Use objfile_compunits.
11587 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11588 (info_sources_command, search_symbols)
11589 (default_collect_symbol_completion_matches_break_on)
11590 (make_source_files_completion_list): Remove declaration.
11591 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11592 (ada_collect_symbol_completion_matches)
11593 (ada_add_global_exceptions): Remove declaration.
11594 * linespec.c (iterate_over_all_matching_symtabs): Use
11596 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11597 (class objfile_compunits): New.
11598 (ALL_COMPUNITS): Use objfile_compunits.
11599 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11600 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11602 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11604 2019-01-09 Tom Tromey <tom@tromey.com>
11606 * symtab.c (search_symbols)
11607 (default_collect_symbol_completion_matches_break_on): Use
11609 * ada-lang.c (ada_lookup_simple_minsym)
11610 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11611 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11612 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11614 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11615 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11616 * objc-lang.c (find_methods): Use objfile_msymbols.
11617 (info_selectors_command, info_classes_command): Likewise.
11618 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11619 * objfiles.h (class objfile_msymbols): New.
11620 (ALL_OBJFILE_MSYMBOLS): Remove.
11621 (ALL_MSYMBOLS): Remove.
11623 2019-01-09 Tom Tromey <tom@tromey.com>
11625 * common/next-iterator.h (next_adapter): Add Iterator template
11627 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11628 (class all_objfiles_safe): New.
11629 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11630 * objfiles.c (put_objfile_before): Update comment.
11631 (add_separate_debug_objfile): Likewise.
11632 (free_all_objfiles): Use all_objfiles_safe.
11633 (objfile_purge_solibs): Likewise.
11635 2019-01-09 Tom Tromey <tom@tromey.com>
11637 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11638 (expand_symtab_containing_pc, lookup_static_symbol)
11639 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11640 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11642 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11643 * breakpoint.c (create_overlay_event_breakpoint)
11644 (create_longjmp_master_breakpoint)
11645 (create_std_terminate_master_breakpoint)
11646 (create_exception_master_breakpoint): Use all_objfiles.
11647 * linux-thread-db.c (try_thread_db_load_from_pdir)
11648 (has_libpthread): Use all_objfiles.
11649 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11650 * linespec.c (iterate_over_all_matching_symtabs)
11651 (search_minsyms_for_name): Use all_objfiles.
11652 * maint.c (maintenance_info_sections): Use all_objfiles.
11653 * main.c (captured_main_1): Use all_objfiles.
11654 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11655 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11656 * guile/scm-pretty-print.c
11657 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11658 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11659 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11660 (maintenance_print_msymbols): Use all_objfiles.
11661 * source.c (select_source_symtab): Use all_objfiles.
11662 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11663 * symfile.c (remove_symbol_file_command)
11664 (expand_symtabs_matching, map_symbol_filenames): Use
11666 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11668 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11669 * objc-lang.c (find_methods): Use all_objfiles.
11670 * objfiles.c (have_partial_symbols, have_full_symbols)
11671 (have_minimal_symbols, qsort_cmp)
11672 (default_iterate_over_objfiles_in_search_order): Use
11674 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11675 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11676 (maintenance_check_psymtabs): Use all_objfiles.
11677 (ALL_PSYMTABS): Remove.
11678 * compile/compile-object-run.c (do_module_cleanup): Use
11680 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11681 * cp-support.c (add_symbol_overload_list_qualified): Use
11683 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11685 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11686 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11688 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11689 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11690 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11692 * solib.c (solib_read_symbols): Use all_objfiles
11694 2019-01-09 Tom Tromey <tom@tromey.com>
11696 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11697 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11699 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11700 * symmisc.c (print_symbol_bcache_statistics)
11701 (print_objfile_statistics, maintenance_print_objfiles)
11702 (maintenance_info_symtabs, maintenance_check_symtabs)
11703 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11705 * source.c (forget_cached_source_info): Use all_objfiles.
11706 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11707 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11708 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11709 * objfiles.c (update_section_map): Use all_objfiles.
11710 (shared_objfile_contains_address_p): Likewise.
11711 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11712 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11714 2019-01-09 Tom Tromey <tom@tromey.com>
11716 * common/next-iterator.h: New file.
11717 * objfiles.h (class all_objfiles): New.
11718 (struct objfile_iterator): New.
11720 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11722 * NEWS: Move the description of the changed "frame", "select-frame",
11723 and "info frame" commands to the Changed commands section.
11725 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11727 * gdbtypes.c (check_stub_method_group): Remove handling of old
11729 * linespec.c (find_methods): Likewise.
11730 * stabsread.c (read_member_functions): Likewise.
11731 * valops.c (search_struct_method): Likewise.
11732 (value_struct_elt_for_reference): Likewise.
11733 * NEWS: Mention this change.
11735 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11737 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11738 print_source_lines.
11739 * source.c (print_source_lines_base): Update line number check.
11740 (print_source_lines): New function.
11741 (source_lines_range::source_lines_range): New function.
11742 * source.h (class source_lines_range): New class.
11743 (print_source_lines): New declaration.
11745 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11747 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11749 2019-01-08 Tom Tromey <tom@tromey.com>
11750 Simon Marchi <simon.marchi@ericsson.com>
11753 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11754 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11755 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11756 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11757 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11758 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11760 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11762 * source.c (select_source_symtab): Move header comment to
11763 declaration in source.h.
11764 (forget_cached_source_info_for_objfile): Likewise.
11765 (forget_cached_source_info): Likewise.
11766 (identify_source_line): Likewise.
11767 * source.h (identify_source_line): Move declaration from symtab.h
11768 and add comment from source.c
11769 (print_source_lines): Likewise.
11770 (forget_cached_source_info_for_objfile): Likewise.
11771 (forget_cached_source_info): Likewise.
11772 (select_source_symtab): Likewise.
11773 (enum print_source_lines_flag): Move definition from symtab.h.
11774 * symtab.h (identify_source_line): Move declaration to source.h.
11775 (print_source_lines): Likewise.
11776 (forget_cached_source_info_for_objfile): Likewise.
11777 (forget_cached_source_info): Likewise.
11778 (select_source_symtab): Likewise.
11779 (enum print_source_lines_flag): Move definition to source.h.
11780 * tui/tui-hooks.c: Add 'source.h' include.
11782 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11784 * source.c (print_source_lines_base): Handle requests to print
11785 reverse line number sequences, and guard against empty lines
11788 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11790 * source.c (print_source_lines_base): Fix skip of '\r' if next
11793 2019-01-06 Tom Tromey <tom@tromey.com>
11795 * c-exp.y (struct c_parse_state) <macro_original_text,
11796 expansion_obstack>: New member.
11797 (macro_original_text, expansion_obstack): Remove globals.
11798 (scan_macro_expansion, scanning_macro_expansion)
11799 (finished_macro_expansion): Update.
11800 (scan_macro_cleanup): Remove.
11801 (yylex, c_parse): Update.
11803 2019-01-06 Tom Tromey <tom@tromey.com>
11805 * c-exp.y (struct c_parse_state) <strings>: New member.
11806 (operator_stoken): Update.
11808 2019-01-06 Tom Tromey <tom@tromey.com>
11810 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11811 (union type_stack_elt) <typelist_val>: Now a pointer to
11813 (type_stack_cleanup): Don't declare.
11814 (push_typelist): Update.
11815 * parse.c (pop_typelist): Return a std::vector.
11816 (push_typelist): Take a std::vector.
11817 (follow_types): Update. Do not free args.
11818 (type_stack_cleanup): Remove.
11819 * c-exp.y (struct c_parse_state): New.
11820 (cpstate): New global.
11821 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11822 (nonempty_typelist): Update.
11823 (func_mod): Create a new vector.
11824 (c_parse): Create a c_parse_state.
11825 (check_parameter_typelist): Do not delete params.
11826 (function_method): Update. Do not delete type_list.
11828 2019-01-06 Tom Tromey <tom@tromey.com>
11831 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11833 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11834 (print_return_value): Likewise.
11836 2019-01-05 Tom Tromey <tom@tromey.com>
11838 * contrib/cleanup_check.py: Remove.
11839 * contrib/gcc-with-excheck: Remove.
11840 * contrib/exsummary.py: Remove.
11841 * contrib/excheck.py: Remove.
11843 2019-01-05 Joel Brobecker <brobecker@adacore.com>
11845 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11846 NULL. Initialize tpprev to NULL instead of assigning it
11847 to NULL on the next statement.
11848 * windows-nat.c (windows_delete_thread): Remove check for
11849 main_thread_id before printing thread exit notifications.
11850 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11851 Remove thread ID check against main_thread_id.
11852 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11853 windows_delete_thread.
11854 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11856 2019-01-04 Tom Tromey <tom@tromey.com>
11858 * compile/compile.c (_initialize_compile): Use upper case for
11859 metasyntactic variables.
11860 * symmisc.c (_initialize_symmisc): Use upper case for
11861 metasyntactic variables.
11862 * psymtab.c (_initialize_psymtab): Use upper case for
11863 metasyntactic variables.
11864 * demangle.c (demangle_command): Use upper case for metasyntactic
11866 (_initialize_demangler): Likewise.
11867 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11870 2019-01-03 Tom Tromey <tom@tromey.com>
11872 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11874 2019-01-03 Tom Tromey <tom@tromey.com>
11876 * python/py-symtab.c (salpy_str): Update.
11877 (struct salpy_sal_object) <symtab>: Now a PyObject.
11878 (salpy_dealloc): Update.
11879 (del_objfile_sal): Use gdbpy_ref.
11881 2019-01-03 Tom Tromey <tom@tromey.com>
11883 * python/py-type.c (convert_field): Use new_reference. Return
11885 (make_fielditem): Return gdbpy_ref.
11886 (typy_fields): Update.
11887 (typy_getitem): Update.
11888 (field_name): Return gdbpy_ref. Use new_reference.
11889 (typy_iterator_iternext): Update.
11891 2019-01-03 Tom Tromey <tom@tromey.com>
11893 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11895 2019-01-03 Tom Tromey <tom@tromey.com>
11897 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11898 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11899 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11900 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11901 (pspy_set_type_printers): Likewise.
11902 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11903 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11904 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11905 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11906 (objfpy_set_type_printers): Likewise.
11908 2019-01-03 Tom Tromey <tom@tromey.com>
11910 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11911 (gdbpy_print_stack): Use gdbpy_err_fetch.
11912 * python/python-internal.h (class gdbpy_err_fetch): New class.
11913 (class gdbpy_enter) <m_error_type, m_error_value,
11914 m_error_traceback>: Remove.
11915 <m_error>: New member.
11916 (gdbpy_exception_to_string): Don't declare.
11917 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11918 * python/py-value.c (convert_value_from_python): Use
11920 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11921 gdbpy_exception_to_string.
11922 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11923 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11926 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11928 * linux-nat.c (delete_lwp_cleanup): Delete.
11929 (struct lwp_deleter): New struct.
11930 (lwp_info_up): New typedef.
11931 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11934 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11936 * linux-fork.c (class scoped_switch_fork_info): New class.
11937 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11939 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11941 * valops.c (find_overload_match): Remove use of null_cleanup, and
11942 calls to do_cleanups.
11944 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11946 * compile/compile-cplus-types.c
11947 (compile_cplus_instance::decl_name): Handle changes to
11949 * cp-support.c (cp_func_name): Update header comment, update
11951 * cp-support.h (cp_func_name): Update return type in declaration.
11952 * valops.c (find_overload_match): Move temp_func local to top
11953 level of function and change its type. Use temp_func to hold and
11954 delete temporary string obtained from cp_func_name.
11956 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11958 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11959 gdb::char_vector, remove cleanup, and update uses of `msg`.
11961 2019-01-03 Jim Wilson <jimw@sifive.com>
11963 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11965 2019-01-02 Tom Tromey <tom@tromey.com>
11967 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11968 (tdesc_parse_xml): Remove cleanups.
11969 * target-descriptions.h (make_cleanup_free_target_description):
11971 (target_desc_deleter): New struct.
11972 (target_desc_up): New typedef.
11973 * target-descriptions.c (target_desc_deleter::operator()): Rename
11974 from free_target_description.
11975 (make_cleanup_free_target_description): Remove.
11977 2019-01-02 Tom Tromey <tom@tromey.com>
11979 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11980 constructor, destructor.
11981 (linespec_parser): Remove typedef.
11982 (~linespec_parser): Rename from linespec_parser_delete.
11983 (linespec_lex_to_end, linespec_complete_label)
11984 (linespec_complete): Update.
11985 (decode_line_full): Remove cleanups.
11986 (decode_line_1): Update.
11988 2019-01-02 Tom Tromey <tom@tromey.com>
11990 * python/python-internal.h (inferior_to_inferior_object): Change
11992 * python/py-exitedevent.c (create_exited_event_object): Update.
11993 * python/py-inferior.c (inferior_to_inferior_object): Return
11995 (python_new_inferior, python_inferior_deleted)
11996 (thread_to_thread_object, delete_thread_object)
11997 (build_inferior_list, gdbpy_selected_inferior): Update.
11998 * python/py-infthread.c (create_thread_object): Update. Also fail
11999 if inferior_to_inferior_object fails.
12001 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12003 * inferior.h (class inferior) <displaced_step_state>: New field.
12004 * infrun.h (struct displaced_step_state): Move here from
12005 infrun.c. Initialize fields, add constructor.
12006 <inf>: Remove field.
12007 <reset>: New method.
12008 * infrun.c (struct displaced_step_inferior_state): Move to
12010 (displaced_step_inferior_states): Remove.
12011 (get_displaced_stepping_state): Adust.
12012 (displaced_step_in_progress_any_inferior): Adjust.
12013 (displaced_step_in_progress_thread): Adjust.
12014 (displaced_step_in_progress): Adjust.
12015 (add_displaced_stepping_state): Remove.
12016 (get_displaced_step_closure_by_addr): Adjust.
12017 (remove_displaced_stepping_state): Remove.
12018 (infrun_inferior_exit): Call displaced_step_state.reset.
12019 (use_displaced_stepping): Don't check for NULL.
12020 (displaced_step_prepare_throw): Call
12021 get_displaced_stepping_state.
12022 (displaced_step_fixup): Don't check for NULL.
12023 (prepare_for_detach): Don't check for NULL.
12025 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12027 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12028 in case of call that did not complete.
12030 2019-01-02 Andrey Utkin <autkin@undo.io>
12032 * symfile.c (find_separate_debug_file): Fix search of debug files for
12035 2019-01-02 Tom Tromey <tom@tromey.com>
12037 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12039 * python/py-frame.c (frapy_older): Remove cast.
12040 (frapy_newer): Likewise.
12041 * python/py-breakpoint.c (local_setattro): Remove cast.
12042 * python/py-arch.c (archpy_name): Remove local variable.
12043 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12045 2019-01-02 Joel Brobecker <brobecker@adacore.com>
12047 * unittests/basic_string_view/element_access/char/empty.cc:
12048 Fix year range in copyright header.
12050 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12052 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12054 <operator==>: Update with for removed field.
12056 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12057 <isa_features>: ...this.
12058 <abi_features>: New field.
12059 (riscv_isa_flen): Update comment.
12060 (riscv_abi_xlen): New declaration.
12061 (riscv_abi_flen): New declaration.
12062 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12064 (riscv_abi_xlen): New function.
12065 (riscv_isa_flen): Update to get answer from isa_features.
12066 (riscv_abi_flen): New function.
12067 (riscv_has_fp_abi): Update to get answer from abi_features.
12068 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12070 (riscv_call_info) <xlen, flen>: Update comment.
12071 (riscv_call_arg_struct): Remove invalid assertions
12072 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12074 (riscv_gdbarch_init): Gather isa features and abi features
12075 separately, ensure both match on the gdbarch when reusing an old
12076 gdbarch. Relax an error check to allow 32-bit abi float to run on
12077 a target with 64-bit float hardware.
12079 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12081 * source.c (search_command_helper): Stop reverse search
12082 when line 1 has been searched.
12084 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12086 * record-full.c (record_full_base_target::close): Rewrite
12087 record_full_core_buf_list free logic.
12089 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12091 * break-catch-syscall.c (print_one_catch_syscall): xfree
12094 2019-01-01 Joel Brobecker <brobecker@adacore.com>
12096 * top.c (print_gdb_version): Update Copyright year in version
12099 2019-01-01 Joel Brobecker <brobecker@adacore.com>
12101 Update copyright year range in all GDB files.
12103 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
12105 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12107 For older changes see ChangeLog-2018.
12113 version-control: never