1 /* Read os9/os9k symbol tables and convert to internal format, for GDB.
2 Copyright 1986, 87, 88, 89, 90, 91, 92, 93, 94, 96, 1998
3 Free Software Foundation, Inc.
5 This file is part of GDB.
7 This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 2 of the License, or
10 (at your option) any later version.
12 This program is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with this program; if not, write to the Free Software
19 Foundation, Inc., 59 Temple Place - Suite 330,
20 Boston, MA 02111-1307, USA. */
22 /* This module provides three functions: os9k_symfile_init,
23 which initializes to read a symbol file; os9k_new_init, which
24 discards existing cached information when all symbols are being
25 discarded; and os9k_symfile_read, which reads a symbol table
28 os9k_symfile_read only does the minimum work necessary for letting the
29 user "name" things symbolically; it does not read the entire symtab.
30 Instead, it reads the external and static symbols and puts them in partial
31 symbol tables. When more extensive information is requested of a
32 file, the corresponding partial symbol table is mutated into a full
33 fledged symbol table by going back and reading the symbols
34 for real. os9k_psymtab_to_symtab() is the function that does this */
37 #include "gdb_string.h"
40 #if defined(USG) || defined(__CYGNUSCLIB__)
41 #include <sys/types.h>
49 #include "breakpoint.h"
52 #include "gdbcore.h" /* for bfd stuff */
53 #include "libaout.h" /* FIXME Secret internal BFD stuff for a.out */
57 #include "gdb-stabs.h"
59 #include "language.h" /* Needed inside partial-stab.h */
60 #include "complaints.h"
62 #include "stabsread.h"
64 extern void _initialize_os9kread
PARAMS ((void));
66 /* Each partial symbol table entry contains a pointer to private data for the
67 read_symtab() function to use when expanding a partial symbol table entry
68 to a full symbol table entry.
70 For dbxread this structure contains the offset within the file symbol table
71 of first local symbol for this file, and count of the section
72 of the symbol table devoted to this file's symbols (actually, the section
73 bracketed may contain more than just this file's symbols). It also contains
74 further information needed to locate the symbols if they are in an ELF file.
76 If ldsymcnt is 0, the only reason for this thing's existence is the
77 dependency list. Nothing else will happen when it is read in. */
79 #define LDSYMOFF(p) (((struct symloc *)((p)->read_symtab_private))->ldsymoff)
80 #define LDSYMCNT(p) (((struct symloc *)((p)->read_symtab_private))->ldsymnum)
88 /* Remember what we deduced to be the source language of this psymtab. */
89 static enum language psymtab_language
= language_unknown
;
91 /* keep partial symbol table file nested depth */
92 static int psymfile_depth
= 0;
94 /* keep symbol table file nested depth */
95 static int symfile_depth
= 0;
97 /* Nonzero means give verbose info on gdb action. From main.c. */
98 extern int info_verbose
;
100 extern int previous_stab_code
;
102 /* Name of last function encountered. Used in Solaris to approximate
103 object file boundaries. */
104 static char *last_function_name
;
106 /* Complaints about the symbols we have encountered. */
107 extern struct complaint lbrac_complaint
;
109 extern struct complaint unknown_symtype_complaint
;
111 extern struct complaint unknown_symchar_complaint
;
113 extern struct complaint lbrac_rbrac_complaint
;
115 extern struct complaint repeated_header_complaint
;
117 extern struct complaint repeated_header_name_complaint
;
120 static struct complaint lbrac_unmatched_complaint
=
121 {"unmatched Increment Block Entry before symtab pos %d", 0, 0};
123 static struct complaint lbrac_mismatch_complaint
=
124 {"IBE/IDE symbol mismatch at symtab pos %d", 0, 0};
127 /* Local function prototypes */
130 read_minimal_symbols
PARAMS ((struct objfile
*, struct section_offsets
*));
133 os9k_read_ofile_symtab
PARAMS ((struct partial_symtab
*));
136 os9k_psymtab_to_symtab
PARAMS ((struct partial_symtab
*));
139 os9k_psymtab_to_symtab_1
PARAMS ((struct partial_symtab
*));
142 read_os9k_psymtab
PARAMS ((struct section_offsets
*, struct objfile
*,
146 fill_sym
PARAMS ((FILE *, bfd
*));
149 os9k_symfile_init
PARAMS ((struct objfile
*));
152 os9k_new_init
PARAMS ((struct objfile
*));
155 os9k_symfile_read
PARAMS ((struct objfile
*, struct section_offsets
*, int));
158 os9k_symfile_finish
PARAMS ((struct objfile
*));
161 os9k_process_one_symbol
PARAMS ((int, int, CORE_ADDR
, char *,
162 struct section_offsets
*, struct objfile
*));
164 static struct partial_symtab
*
165 os9k_start_psymtab
PARAMS ((struct objfile
*, struct section_offsets
*, char *,
166 CORE_ADDR
, int, int, struct partial_symbol
**,
167 struct partial_symbol
**));
169 static struct partial_symtab
*
170 os9k_end_psymtab
PARAMS ((struct partial_symtab
*, char **, int, int, CORE_ADDR
,
171 struct partial_symtab
**, int));
174 record_minimal_symbol
PARAMS ((char *, CORE_ADDR
, int, struct objfile
*,
175 struct section_offsets
*));
177 #define HANDLE_RBRAC(val) \
178 if ((val) > pst->texthigh) pst->texthigh = (val);
180 #define SWAP_STBHDR(hdrp, abfd) \
182 (hdrp)->fmtno = bfd_get_16(abfd, (unsigned char *)&(hdrp)->fmtno); \
183 (hdrp)->crc = bfd_get_32(abfd, (unsigned char *)&(hdrp)->crc); \
184 (hdrp)->offset = bfd_get_32(abfd, (unsigned char *)&(hdrp)->offset); \
185 (hdrp)->nsym = bfd_get_32(abfd, (unsigned char *)&(hdrp)->nsym); \
187 #define SWAP_STBSYM(symp, abfd) \
189 (symp)->value = bfd_get_32(abfd, (unsigned char *)&(symp)->value); \
190 (symp)->type = bfd_get_16(abfd, (unsigned char *)&(symp)->type); \
191 (symp)->stroff = bfd_get_32(abfd, (unsigned char *)&(symp)->stroff); \
201 record_minimal_symbol (name
, address
, type
, objfile
, section_offsets
)
205 struct objfile
*objfile
;
206 struct section_offsets
*section_offsets
;
208 enum minimal_symbol_type ms_type
;
214 address
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
232 ms_type
= mst_unknown
;
236 prim_record_minimal_symbol (name
, address
, ms_type
, objfile
);
239 /* read and process .stb file and store in minimal symbol table */
240 typedef char mhhdr
[80];
257 #define STBSYMSIZE 10
260 read_minimal_symbols (objfile
, section_offsets
)
261 struct objfile
*objfile
;
262 struct section_offsets
*section_offsets
;
267 struct stbsymbol sym
;
269 char buf
[64], buf1
[128];
274 abfd
= objfile
->obfd
;
275 fread (&hdr
.comhdr
[0], sizeof (mhhdr
), 1, fp
);
290 fread (&hdr
.fmtno
, sizeof (hdr
.fmtno
), 1, fp
);
291 fread (&hdr
.crc
, sizeof (hdr
.crc
), 1, fp
);
292 fread (&hdr
.offset
, sizeof (hdr
.offset
), 1, fp
);
293 fread (&hdr
.nsym
, sizeof (hdr
.nsym
), 1, fp
);
294 SWAP_STBHDR (&hdr
, abfd
);
297 init_minimal_symbol_collection ();
299 for (i
= hdr
.nsym
; i
> 0; i
--)
301 fseek (fp
, (long) off
, 0);
302 fread (&sym
.value
, sizeof (sym
.value
), 1, fp
);
303 fread (&sym
.type
, sizeof (sym
.type
), 1, fp
);
304 fread (&sym
.stroff
, sizeof (sym
.stroff
), 1, fp
);
305 SWAP_STBSYM (&sym
, abfd
);
306 fseek (fp
, (long) sym
.stroff
, 0);
317 record_minimal_symbol (buf1
, sym
.value
, sym
.type
& 7, objfile
, section_offsets
);
320 install_minimal_symbols (objfile
);
324 /* Scan and build partial symbols for a symbol file.
325 We have been initialized by a call to os9k_symfile_init, which
326 put all the relevant info into a "struct os9k_symfile_info",
327 hung off the objfile structure.
329 SECTION_OFFSETS contains offsets relative to which the symbols in the
330 various sections are (depending where the sections were actually loaded).
331 MAINLINE is true if we are reading the main symbol
332 table (as opposed to a shared lib or dynamically loaded file). */
335 os9k_symfile_read (objfile
, section_offsets
, mainline
)
336 struct objfile
*objfile
;
337 struct section_offsets
*section_offsets
;
338 int mainline
; /* FIXME comments above */
341 struct cleanup
*back_to
;
343 sym_bfd
= objfile
->obfd
;
344 /* If we are reinitializing, or if we have never loaded syms yet, init */
345 if (mainline
|| objfile
->global_psymbols
.size
== 0 ||
346 objfile
->static_psymbols
.size
== 0)
347 init_psymbol_list (objfile
, DBX_SYMCOUNT (objfile
));
349 free_pending_blocks ();
350 back_to
= make_cleanup (really_free_pendings
, 0);
352 make_cleanup ((make_cleanup_func
) discard_minimal_symbols
, 0);
353 read_minimal_symbols (objfile
, section_offsets
);
355 /* Now that the symbol table data of the executable file are all in core,
356 process them and define symbols accordingly. */
357 read_os9k_psymtab (section_offsets
, objfile
,
358 DBX_TEXT_ADDR (objfile
),
359 DBX_TEXT_SIZE (objfile
));
361 do_cleanups (back_to
);
364 /* Initialize anything that needs initializing when a completely new
365 symbol file is specified (not just adding some symbols from another
366 file, e.g. a shared library). */
369 os9k_new_init (ignore
)
370 struct objfile
*ignore
;
372 stabsread_new_init ();
373 buildsym_new_init ();
376 init_header_files ();
380 /* os9k_symfile_init ()
381 It is passed a struct objfile which contains, among other things,
382 the BFD for the file whose symbols are being read, and a slot for a pointer
383 to "private data" which we fill with goodies.
385 Since BFD doesn't know how to read debug symbols in a format-independent
386 way (and may never do so...), we have to do it ourselves. We will never
387 be called unless this is an a.out (or very similar) file.
388 FIXME, there should be a cleaner peephole into the BFD environment here. */
391 os9k_symfile_init (objfile
)
392 struct objfile
*objfile
;
394 bfd
*sym_bfd
= objfile
->obfd
;
395 char *name
= bfd_get_filename (sym_bfd
);
396 char dbgname
[512], stbname
[512];
401 strcpy (dbgname
, name
);
402 strcat (dbgname
, ".dbg");
403 strcpy (stbname
, name
);
404 strcat (stbname
, ".stb");
406 if ((symfile
= fopen (dbgname
, "r")) == NULL
)
408 warning ("Symbol file %s not found", dbgname
);
410 objfile
->auxf2
= symfile
;
412 if ((minfile
= fopen (stbname
, "r")) == NULL
)
414 warning ("Symbol file %s not found", stbname
);
416 objfile
->auxf1
= minfile
;
418 /* Allocate struct to keep track of the symfile */
419 objfile
->sym_stab_info
= (struct dbx_symfile_info
*)
420 xmmalloc (objfile
->md
, sizeof (struct dbx_symfile_info
));
421 DBX_SYMFILE_INFO (objfile
)->stab_section_info
= NULL
;
423 text_sect
= bfd_get_section_by_name (sym_bfd
, ".text");
425 error ("Can't find .text section in file");
426 DBX_TEXT_ADDR (objfile
) = bfd_section_vma (sym_bfd
, text_sect
);
427 DBX_TEXT_SIZE (objfile
) = bfd_section_size (sym_bfd
, text_sect
);
429 DBX_SYMBOL_SIZE (objfile
) = 0; /* variable size symbol */
430 DBX_SYMCOUNT (objfile
) = 0; /* used to be bfd_get_symcount(sym_bfd) */
431 DBX_SYMTAB_OFFSET (objfile
) = 0; /* used to be SYMBOL_TABLE_OFFSET */
434 /* Perform any local cleanups required when we are done with a particular
435 objfile. I.E, we are in the process of discarding all symbol information
436 for an objfile, freeing up all memory held for it, and unlinking the
437 objfile struct from the global list of known objfiles. */
440 os9k_symfile_finish (objfile
)
441 struct objfile
*objfile
;
443 if (objfile
->sym_stab_info
!= NULL
)
445 mfree (objfile
->md
, objfile
->sym_stab_info
);
448 free_header_files ();
461 #define SYNC (int)0xefbefeca
463 #define SWAP_DBGHDR(hdrp, abfd) \
465 (hdrp)->sync = bfd_get_32(abfd, (unsigned char *)&(hdrp)->sync); \
466 (hdrp)->rev = bfd_get_16(abfd, (unsigned char *)&(hdrp)->rev); \
467 (hdrp)->crc = bfd_get_32(abfd, (unsigned char *)&(hdrp)->crc); \
468 (hdrp)->os = bfd_get_16(abfd, (unsigned char *)&(hdrp)->os); \
469 (hdrp)->cpu = bfd_get_16(abfd, (unsigned char *)&(hdrp)->cpu); \
472 #define N_SYM_CMPLR 0
473 #define N_SYM_SLINE 1
475 #define N_SYM_LBRAC 3
476 #define N_SYM_RBRAC 4
479 struct internal_symstruct
486 static struct internal_symstruct symbol
;
487 static struct internal_symstruct
*symbuf
= &symbol
;
488 static char strbuf
[4096];
489 static struct st_dbghdr dbghdr
;
490 static short cmplrid
;
492 #define VER_PRE_ULTRAC ((short)4)
493 #define VER_ULTRAC ((short)5)
496 fill_sym (dbg_file
, abfd
)
505 int nbytes
= fread (&si
, sizeof (si
), 1, dbg_file
);
509 perror_with_name ("reading .dbg file.");
512 symbuf
->n_strx
= NULL
;
513 symbuf
->n_type
= bfd_get_16 (abfd
, (unsigned char *) &si
);
514 symbuf
->n_type
= 0xf & symbuf
->n_type
;
515 switch (symbuf
->n_type
)
518 fread (&si
, sizeof (si
), 1, dbg_file
);
519 symbuf
->n_desc
= bfd_get_16 (abfd
, (unsigned char *) &si
);
520 cmplrid
= symbuf
->n_desc
& 0xff;
523 fread (&li
, sizeof (li
), 1, dbg_file
);
524 symbuf
->n_value
= bfd_get_32 (abfd
, (unsigned char *) &li
);
525 fread (&li
, sizeof (li
), 1, dbg_file
);
526 li
= bfd_get_32 (abfd
, (unsigned char *) &li
);
527 symbuf
->n_strx
= (char *) (li
>> 12);
528 symbuf
->n_desc
= li
& 0xfff;
531 fread (&li
, sizeof (li
), 1, dbg_file
);
532 symbuf
->n_value
= bfd_get_32 (abfd
, (unsigned char *) &li
);
536 ii
= getc (dbg_file
);
537 strbuf
[si
++] = (char) ii
;
539 while (ii
!= 0 || si
% 2 != 0);
540 symbuf
->n_strx
= strbuf
;
541 p
= (char *) strchr (strbuf
, ':');
544 if ((p
[1] == 'F' || p
[1] == 'f') && cmplrid
== VER_PRE_ULTRAC
)
546 fread (&si
, sizeof (si
), 1, dbg_file
);
547 nmask
= bfd_get_16 (abfd
, (unsigned char *) &si
);
548 for (ii
= 0; ii
< nmask
; ii
++)
549 fread (&si
, sizeof (si
), 1, dbg_file
);
553 fread (&li
, sizeof (li
), 1, dbg_file
);
554 symbuf
->n_value
= bfd_get_32 (abfd
, (unsigned char *) &li
);
557 fread (&li
, sizeof (li
), 1, dbg_file
);
558 symbuf
->n_value
= bfd_get_32 (abfd
, (unsigned char *) &li
);
566 /* Given pointers to an a.out symbol table in core containing dbx
567 style data, setup partial_symtab's describing each source file for
568 which debugging information is available.
569 SYMFILE_NAME is the name of the file we are reading from
570 and SECTION_OFFSETS is the set of offsets for the various sections
571 of the file (a set of zeros if the mainline program). */
574 read_os9k_psymtab (section_offsets
, objfile
, text_addr
, text_size
)
575 struct section_offsets
*section_offsets
;
576 struct objfile
*objfile
;
580 register struct internal_symstruct
*bufp
= 0; /* =0 avoids gcc -Wall glitch */
581 register char *namestring
;
582 int past_first_source_file
= 0;
583 CORE_ADDR last_o_file_start
= 0;
585 struct cleanup
*back_to
;
590 /* End of the text segment of the executable file. */
591 static CORE_ADDR end_of_text_addr
;
593 /* Current partial symtab */
594 static struct partial_symtab
*pst
= 0;
596 /* List of current psymtab's include files */
597 char **psymtab_include_list
;
598 int includes_allocated
;
601 /* Index within current psymtab dependency list */
602 struct partial_symtab
**dependency_list
;
603 int dependencies_used
, dependencies_allocated
;
605 includes_allocated
= 30;
607 psymtab_include_list
= (char **) alloca (includes_allocated
*
610 dependencies_allocated
= 30;
611 dependencies_used
= 0;
613 (struct partial_symtab
**) alloca (dependencies_allocated
*
614 sizeof (struct partial_symtab
*));
616 last_source_file
= NULL
;
618 #ifdef END_OF_TEXT_DEFAULT
619 end_of_text_addr
= END_OF_TEXT_DEFAULT
;
621 end_of_text_addr
= text_addr
+ section_offsets
->offsets
[SECT_OFF_TEXT
]
622 + text_size
; /* Relocate */
625 abfd
= objfile
->obfd
;
630 fread (&dbghdr
.sync
, sizeof (dbghdr
.sync
), 1, fp
);
631 fread (&dbghdr
.rev
, sizeof (dbghdr
.rev
), 1, fp
);
632 fread (&dbghdr
.crc
, sizeof (dbghdr
.crc
), 1, fp
);
633 fread (&dbghdr
.os
, sizeof (dbghdr
.os
), 1, fp
);
634 fread (&dbghdr
.cpu
, sizeof (dbghdr
.cpu
), 1, fp
);
635 SWAP_DBGHDR (&dbghdr
, abfd
);
643 /* Get the symbol for this run and pull out some info */
644 QUIT
; /* allow this to be interruptable */
645 cursymoffset
= ftell (objfile
->auxf2
);
646 ret
= fill_sym (objfile
->auxf2
, abfd
);
653 /* Special case to speed up readin. */
654 if (bufp
->n_type
== (short) N_SYM_SLINE
)
657 #define CUR_SYMBOL_VALUE bufp->n_value
660 switch (bufp
->n_type
)
668 CUR_SYMBOL_VALUE
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
669 if (psymfile_depth
== 1 && pst
)
671 os9k_end_psymtab (pst
, psymtab_include_list
, includes_used
,
672 symnum
, CUR_SYMBOL_VALUE
,
673 dependency_list
, dependencies_used
);
674 pst
= (struct partial_symtab
*) 0;
676 dependencies_used
= 0;
681 case N_SYM_SYM
: /* Typedef or automatic variable. */
682 namestring
= bufp
->n_strx
;
683 p
= (char *) strchr (namestring
, ':');
685 continue; /* Not a debugging symbol. */
687 /* Main processing section for debugging symbols which
688 the initial read through the symbol tables needs to worry
689 about. If we reach this point, the symbol which we are
690 considering is definitely one we are interested in.
691 p must also contain the (valid) index into the namestring
692 which indicates the debugging type symbol. */
699 enum language tmp_language
;
703 valu
= CUR_SYMBOL_VALUE
;
705 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
706 past_first_source_file
= 1;
708 p
= strchr (namestring
, ':');
712 n
= strlen (namestring
);
713 str
= alloca (n
+ 1);
714 strncpy (str
, namestring
, n
);
717 if (psymfile_depth
== 0)
720 pst
= os9k_start_psymtab (objfile
, section_offsets
,
724 objfile
->global_psymbols
.next
,
725 objfile
->static_psymbols
.next
);
728 { /* this is a include file */
729 tmp_language
= deduce_language_from_filename (str
);
730 if (tmp_language
!= language_unknown
731 && (tmp_language
!= language_c
732 || psymtab_language
!= language_cplus
))
733 psymtab_language
= tmp_language
;
736 if (pst && STREQ (str, pst->filename))
740 for (i = 0; i < includes_used; i++)
741 if (STREQ (str, psymtab_include_list[i]))
751 psymtab_include_list
[includes_used
++] = str
;
752 if (includes_used
>= includes_allocated
)
754 char **orig
= psymtab_include_list
;
756 psymtab_include_list
= (char **)
757 alloca ((includes_allocated
*= 2) * sizeof (char *));
758 memcpy ((PTR
) psymtab_include_list
, (PTR
) orig
,
759 includes_used
* sizeof (char *));
768 add_psymbol_to_list (namestring
, p
- namestring
,
769 VAR_NAMESPACE
, LOC_STATIC
,
770 &objfile
->static_psymbols
,
772 psymtab_language
, objfile
);
775 add_psymbol_to_list (namestring
, p
- namestring
,
776 VAR_NAMESPACE
, LOC_STATIC
,
777 &objfile
->global_psymbols
,
779 psymtab_language
, objfile
);
783 if (p
!= namestring
) /* a name is there, not just :T... */
785 add_psymbol_to_list (namestring
, p
- namestring
,
786 STRUCT_NAMESPACE
, LOC_TYPEDEF
,
787 &objfile
->static_psymbols
,
789 psymtab_language
, objfile
);
792 /* Also a typedef with the same name. */
793 add_psymbol_to_list (namestring
, p
- namestring
,
794 VAR_NAMESPACE
, LOC_TYPEDEF
,
795 &objfile
->static_psymbols
,
796 CUR_SYMBOL_VALUE
, 0, psymtab_language
,
800 /* The semantics of C++ state that "struct foo { ... }"
801 also defines a typedef for "foo". Unfortuantely, cfront
802 never makes the typedef when translating from C++ to C.
803 We make the typedef here so that "ptype foo" works as
804 expected for cfront translated code. */
805 else if (psymtab_language
== language_cplus
)
807 /* Also a typedef with the same name. */
808 add_psymbol_to_list (namestring
, p
- namestring
,
809 VAR_NAMESPACE
, LOC_TYPEDEF
,
810 &objfile
->static_psymbols
,
811 CUR_SYMBOL_VALUE
, 0, psymtab_language
,
817 if (p
!= namestring
) /* a name is there, not just :T... */
819 add_psymbol_to_list (namestring
, p
- namestring
,
820 VAR_NAMESPACE
, LOC_TYPEDEF
,
821 &objfile
->static_psymbols
,
823 psymtab_language
, objfile
);
826 /* If this is an enumerated type, we need to
827 add all the enum constants to the partial symbol
828 table. This does not cover enums without names, e.g.
829 "enum {a, b} c;" in C, but fortunately those are
830 rare. There is no way for GDB to find those from the
831 enum type without spending too much time on it. Thus
832 to solve this problem, the compiler needs to put out the
833 enum in a nameless type. GCC2 does this. */
835 /* We are looking for something of the form
836 <name> ":" ("t" | "T") [<number> "="] "e" <size>
837 {<constant> ":" <value> ","} ";". */
839 /* Skip over the colon and the 't' or 'T'. */
841 /* This type may be given a number. Also, numbers can come
842 in pairs like (0,26). Skip over it. */
843 while ((*p
>= '0' && *p
<= '9')
844 || *p
== '(' || *p
== ',' || *p
== ')'
850 /* We have found an enumerated type. skip size */
851 while (*p
>= '0' && *p
<= '9')
853 /* According to comments in read_enum_type
854 a comma could end it instead of a semicolon.
855 I don't know where that happens.
857 while (*p
&& *p
!= ';' && *p
!= ',')
861 /* Check for and handle cretinous dbx symbol name
864 p = next_symbol_text (objfile);
867 /* Point to the character after the name
868 of the enum constant. */
869 for (q
= p
; *q
&& *q
!= ':'; q
++)
871 /* Note that the value doesn't matter for
872 enum constants in psymtabs, just in symtabs. */
873 add_psymbol_to_list (p
, q
- p
,
874 VAR_NAMESPACE
, LOC_CONST
,
875 &objfile
->static_psymbols
, 0,
876 0, psymtab_language
, objfile
);
877 /* Point past the name. */
879 /* Skip over the value. */
880 while (*p
&& *p
!= ',')
882 /* Advance past the comma. */
889 /* Constant, e.g. from "const" in Pascal. */
890 add_psymbol_to_list (namestring
, p
- namestring
,
891 VAR_NAMESPACE
, LOC_CONST
,
892 &objfile
->static_psymbols
, CUR_SYMBOL_VALUE
,
893 0, psymtab_language
, objfile
);
897 CUR_SYMBOL_VALUE
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
898 if (pst
&& pst
->textlow
== 0)
899 pst
->textlow
= CUR_SYMBOL_VALUE
;
901 add_psymbol_to_list (namestring
, p
- namestring
,
902 VAR_NAMESPACE
, LOC_BLOCK
,
903 &objfile
->static_psymbols
, CUR_SYMBOL_VALUE
,
904 0, psymtab_language
, objfile
);
908 CUR_SYMBOL_VALUE
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
909 if (pst
&& pst
->textlow
== 0)
910 pst
->textlow
= CUR_SYMBOL_VALUE
;
912 add_psymbol_to_list (namestring
, p
- namestring
,
913 VAR_NAMESPACE
, LOC_BLOCK
,
914 &objfile
->global_psymbols
, CUR_SYMBOL_VALUE
,
915 0, psymtab_language
, objfile
);
924 /* It is a C++ nested symbol. We don't need to record it
925 (I don't think); if we try to look up foo::bar::baz,
926 then symbols for the symtab containing foo should get
928 /* Someone says sun cc puts out symbols like
929 /foo/baz/maclib::/usr/local/bin/maclib,
930 which would get here with a symbol type of ':'. */
934 /* Unexpected symbol descriptor. The second and subsequent stabs
935 of a continued stab can show up here. The question is
936 whether they ever can mimic a normal stab--it would be
937 nice if not, since we certainly don't want to spend the
938 time searching to the end of every string looking for
941 complain (&unknown_symchar_complaint
, p
[1]);
946 CUR_SYMBOL_VALUE
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
948 HANDLE_RBRAC (CUR_SYMBOL_VALUE
);
955 /* If we haven't found it yet, ignore it. It's probably some
956 new type we don't know about yet. */
957 complain (&unknown_symtype_complaint
,
958 local_hex_string ((unsigned long) bufp
->n_type
));
963 DBX_SYMCOUNT (objfile
) = symnum
;
965 /* If there's stuff to be cleaned up, clean it up. */
966 if (DBX_SYMCOUNT (objfile
) > 0
967 /*FIXME, does this have a bug at start address 0? */
969 && objfile
->ei
.entry_point
< bufp
->n_value
970 && objfile
->ei
.entry_point
>= last_o_file_start
)
972 objfile
->ei
.entry_file_lowpc
= last_o_file_start
;
973 objfile
->ei
.entry_file_highpc
= bufp
->n_value
;
978 os9k_end_psymtab (pst
, psymtab_include_list
, includes_used
,
979 symnum
, end_of_text_addr
,
980 dependency_list
, dependencies_used
);
983 do_cleanups (back_to);
987 /* Allocate and partially fill a partial symtab. It will be
988 completely filled at the end of the symbol list.
990 SYMFILE_NAME is the name of the symbol-file we are reading from, and ADDR
991 is the address relative to which its symbols are (incremental) or 0
995 static struct partial_symtab
*
996 os9k_start_psymtab (objfile
, section_offsets
,
997 filename
, textlow
, ldsymoff
, ldsymcnt
, global_syms
, static_syms
)
998 struct objfile
*objfile
;
999 struct section_offsets
*section_offsets
;
1004 struct partial_symbol
**global_syms
;
1005 struct partial_symbol
**static_syms
;
1007 struct partial_symtab
*result
=
1008 start_psymtab_common (objfile
, section_offsets
,
1009 filename
, textlow
, global_syms
, static_syms
);
1011 result
->read_symtab_private
= (char *)
1012 obstack_alloc (&objfile
->psymbol_obstack
, sizeof (struct symloc
));
1014 LDSYMOFF (result
) = ldsymoff
;
1015 LDSYMCNT (result
) = ldsymcnt
;
1016 result
->read_symtab
= os9k_psymtab_to_symtab
;
1018 /* Deduce the source language from the filename for this psymtab. */
1019 psymtab_language
= deduce_language_from_filename (filename
);
1023 /* Close off the current usage of PST.
1024 Returns PST or NULL if the partial symtab was empty and thrown away.
1025 FIXME: List variables and peculiarities of same. */
1027 static struct partial_symtab
*
1028 os9k_end_psymtab (pst
, include_list
, num_includes
, capping_symbol_cnt
,
1029 capping_text
, dependency_list
, number_dependencies
)
1030 struct partial_symtab
*pst
;
1031 char **include_list
;
1033 int capping_symbol_cnt
;
1034 CORE_ADDR capping_text
;
1035 struct partial_symtab
**dependency_list
;
1036 int number_dependencies
;
1037 /* struct partial_symbol *capping_global, *capping_static; */
1040 struct partial_symtab
*p1
;
1041 struct objfile
*objfile
= pst
->objfile
;
1043 if (capping_symbol_cnt
!= -1)
1044 LDSYMCNT (pst
) = capping_symbol_cnt
- LDSYMCNT (pst
);
1046 /* Under Solaris, the N_SO symbols always have a value of 0,
1047 instead of the usual address of the .o file. Therefore,
1048 we have to do some tricks to fill in texthigh and textlow.
1049 The first trick is in partial-stab.h: if we see a static
1050 or global function, and the textlow for the current pst
1051 is still 0, then we use that function's address for
1052 the textlow of the pst.
1054 Now, to fill in texthigh, we remember the last function seen
1055 in the .o file (also in partial-stab.h). Also, there's a hack in
1056 bfd/elf.c and gdb/elfread.c to pass the ELF st_size field
1057 to here via the misc_info field. Therefore, we can fill in
1058 a reliable texthigh by taking the address plus size of the
1059 last function in the file.
1061 Unfortunately, that does not cover the case where the last function
1062 in the file is static. See the paragraph below for more comments
1065 Finally, if we have a valid textlow for the current file, we run
1066 down the partial_symtab_list filling in previous texthighs that
1067 are still unknown. */
1069 if (pst
->texthigh
== 0 && last_function_name
)
1073 struct minimal_symbol
*minsym
;
1075 p
= strchr (last_function_name
, ':');
1077 p
= last_function_name
;
1078 n
= p
- last_function_name
;
1080 strncpy (p
, last_function_name
, n
);
1083 minsym
= lookup_minimal_symbol (p
, NULL
, objfile
);
1087 pst
->texthigh
= SYMBOL_VALUE_ADDRESS (minsym
) + (long) MSYMBOL_INFO (minsym
);
1091 /* This file ends with a static function, and it's
1092 difficult to imagine how hard it would be to track down
1093 the elf symbol. Luckily, most of the time no one will notice,
1094 since the next file will likely be compiled with -g, so
1095 the code below will copy the first fuction's start address
1096 back to our texthigh variable. (Also, if this file is the
1097 last one in a dynamically linked program, texthigh already
1098 has the right value.) If the next file isn't compiled
1099 with -g, then the last function in this file winds up owning
1100 all of the text space up to the next -g file, or the end (minus
1101 shared libraries). This only matters for single stepping,
1102 and even then it will still work, except that it will single
1103 step through all of the covered functions, instead of setting
1104 breakpoints around them as it usualy does. This makes it
1105 pretty slow, but at least it doesn't fail.
1107 We can fix this with a fairly big change to bfd, but we need
1108 to coordinate better with Cygnus if we want to do that. FIXME. */
1110 last_function_name
= NULL
;
1113 /* this test will be true if the last .o file is only data */
1114 if (pst
->textlow
== 0)
1115 pst
->textlow
= pst
->texthigh
;
1117 /* If we know our own starting text address, then walk through all other
1118 psymtabs for this objfile, and if any didn't know their ending text
1119 address, set it to our starting address. Take care to not set our
1120 own ending address to our starting address, nor to set addresses on
1121 `dependency' files that have both textlow and texthigh zero. */
1124 ALL_OBJFILE_PSYMTABS (objfile
, p1
)
1126 if (p1
->texthigh
== 0 && p1
->textlow
!= 0 && p1
!= pst
)
1128 p1
->texthigh
= pst
->textlow
;
1129 /* if this file has only data, then make textlow match texthigh */
1130 if (p1
->textlow
== 0)
1131 p1
->textlow
= p1
->texthigh
;
1136 /* End of kludge for patching Solaris textlow and texthigh. */
1138 pst
->n_global_syms
=
1139 objfile
->global_psymbols
.next
- (objfile
->global_psymbols
.list
+ pst
->globals_offset
);
1140 pst
->n_static_syms
=
1141 objfile
->static_psymbols
.next
- (objfile
->static_psymbols
.list
+ pst
->statics_offset
);
1143 pst
->number_of_dependencies
= number_dependencies
;
1144 if (number_dependencies
)
1146 pst
->dependencies
= (struct partial_symtab
**)
1147 obstack_alloc (&objfile
->psymbol_obstack
,
1148 number_dependencies
* sizeof (struct partial_symtab
*));
1149 memcpy (pst
->dependencies
, dependency_list
,
1150 number_dependencies
* sizeof (struct partial_symtab
*));
1153 pst
->dependencies
= 0;
1155 for (i
= 0; i
< num_includes
; i
++)
1157 struct partial_symtab
*subpst
=
1158 allocate_psymtab (include_list
[i
], objfile
);
1160 subpst
->section_offsets
= pst
->section_offsets
;
1161 subpst
->read_symtab_private
=
1162 (char *) obstack_alloc (&objfile
->psymbol_obstack
,
1163 sizeof (struct symloc
));
1167 subpst
->texthigh
= 0;
1169 /* We could save slight bits of space by only making one of these,
1170 shared by the entire set of include files. FIXME-someday. */
1171 subpst
->dependencies
= (struct partial_symtab
**)
1172 obstack_alloc (&objfile
->psymbol_obstack
,
1173 sizeof (struct partial_symtab
*));
1174 subpst
->dependencies
[0] = pst
;
1175 subpst
->number_of_dependencies
= 1;
1177 subpst
->globals_offset
=
1178 subpst
->n_global_syms
=
1179 subpst
->statics_offset
=
1180 subpst
->n_static_syms
= 0;
1184 subpst
->read_symtab
= pst
->read_symtab
;
1187 sort_pst_symbols (pst
);
1189 /* If there is already a psymtab or symtab for a file of this name,
1191 (If there is a symtab, more drastic things also happen.)
1192 This happens in VxWorks. */
1193 free_named_symtabs (pst
->filename
);
1195 if (num_includes
== 0
1196 && number_dependencies
== 0
1197 && pst
->n_global_syms
== 0
1198 && pst
->n_static_syms
== 0)
1200 /* Throw away this psymtab, it's empty. We can't deallocate it, since
1201 it is on the obstack, but we can forget to chain it on the list. */
1202 /* Indicate that psymtab was thrown away. */
1204 discard_psymtab (pst
);
1206 pst
= (struct partial_symtab
*) NULL
;
1212 os9k_psymtab_to_symtab_1 (pst
)
1213 struct partial_symtab
*pst
;
1215 struct cleanup
*old_chain
;
1223 fprintf_unfiltered (gdb_stderr
, "Psymtab for %s already read in. Shouldn't happen.\n",
1228 /* Read in all partial symtabs on which this one is dependent */
1229 for (i
= 0; i
< pst
->number_of_dependencies
; i
++)
1230 if (!pst
->dependencies
[i
]->readin
)
1232 /* Inform about additional files that need to be read in. */
1235 fputs_filtered (" ", gdb_stdout
);
1237 fputs_filtered ("and ", gdb_stdout
);
1239 printf_filtered ("%s...", pst
->dependencies
[i
]->filename
);
1240 wrap_here (""); /* Flush output */
1241 gdb_flush (gdb_stdout
);
1243 os9k_psymtab_to_symtab_1 (pst
->dependencies
[i
]);
1246 if (LDSYMCNT (pst
)) /* Otherwise it's a dummy */
1248 /* Init stuff necessary for reading in symbols */
1251 old_chain
= make_cleanup (really_free_pendings
, 0);
1253 /* Read in this file's symbols */
1254 os9k_read_ofile_symtab (pst
);
1255 sort_symtab_syms (pst
->symtab
);
1256 do_cleanups (old_chain
);
1262 /* Read in all of the symbols for a given psymtab for real.
1263 Be verbose about it if the user wants that. */
1266 os9k_psymtab_to_symtab (pst
)
1267 struct partial_symtab
*pst
;
1276 fprintf_unfiltered (gdb_stderr
, "Psymtab for %s already read in. Shouldn't happen.\n",
1281 if (LDSYMCNT (pst
) || pst
->number_of_dependencies
)
1283 /* Print the message now, before reading the string table,
1284 to avoid disconcerting pauses. */
1287 printf_filtered ("Reading in symbols for %s...", pst
->filename
);
1288 gdb_flush (gdb_stdout
);
1291 sym_bfd
= pst
->objfile
->obfd
;
1292 os9k_psymtab_to_symtab_1 (pst
);
1294 /* Match with global symbols. This only needs to be done once,
1295 after all of the symtabs and dependencies have been read in. */
1296 scan_file_globals (pst
->objfile
);
1298 /* Finish up the debug error message. */
1300 printf_filtered ("done.\n");
1304 /* Read in a defined section of a specific object file's symbols. */
1306 os9k_read_ofile_symtab (pst
)
1307 struct partial_symtab
*pst
;
1309 register struct internal_symstruct
*bufp
;
1311 unsigned max_symnum
;
1313 struct objfile
*objfile
;
1314 int sym_offset
; /* Offset to start of symbols to read */
1315 CORE_ADDR text_offset
; /* Start of text segment for symbols */
1316 int text_size
; /* Size of text segment for symbols */
1317 struct section_offsets
*section_offsets
;
1320 objfile
= pst
->objfile
;
1321 sym_offset
= LDSYMOFF (pst
);
1322 max_symnum
= LDSYMCNT (pst
);
1323 text_offset
= pst
->textlow
;
1324 text_size
= pst
->texthigh
- pst
->textlow
;
1325 section_offsets
= pst
->section_offsets
;
1327 current_objfile
= objfile
;
1328 subfile_stack
= NULL
;
1329 last_source_file
= NULL
;
1331 abfd
= objfile
->obfd
;
1332 dbg_file
= objfile
->auxf2
;
1335 /* It is necessary to actually read one symbol *before* the start
1336 of this symtab's symbols, because the GCC_COMPILED_FLAG_SYMBOL
1337 occurs before the N_SO symbol.
1338 Detecting this in read_dbx_symtab
1339 would slow down initial readin, so we look for it here instead. */
1340 if (!processing_acc_compilation
&& sym_offset
>= (int) symbol_size
)
1342 fseek (objefile
->auxf2
, sym_offset
, SEEK_CUR
);
1343 fill_sym (objfile
->auxf2
, abfd
);
1346 processing_gcc_compilation
= 0;
1347 if (bufp
->n_type
== N_TEXT
)
1349 if (STREQ (namestring
, GCC_COMPILED_FLAG_SYMBOL
))
1350 processing_gcc_compilation
= 1;
1351 else if (STREQ (namestring
, GCC2_COMPILED_FLAG_SYMBOL
))
1352 processing_gcc_compilation
= 2;
1355 /* Try to select a C++ demangling based on the compilation unit
1358 if (processing_gcc_compilation
)
1360 if (AUTO_DEMANGLING
)
1362 set_demangling_style (GNU_DEMANGLING_STYLE_STRING
);
1368 /* The N_SO starting this symtab is the first symbol, so we
1369 better not check the symbol before it. I'm not this can
1370 happen, but it doesn't hurt to check for it. */
1371 bfd_seek (symfile_bfd
, sym_offset
, SEEK_CUR
);
1372 processing_gcc_compilation
= 0;
1376 fseek (dbg_file
, (long) sym_offset
, 0);
1378 if (bufp->n_type != (unsigned char)N_SYM_SYM)
1379 error("First symbol in segment of executable not a source symbol");
1382 for (symnum
= 0; symnum
< max_symnum
; symnum
++)
1384 QUIT
; /* Allow this to be interruptable */
1385 fill_sym (dbg_file
, abfd
);
1387 type
= bufp
->n_type
;
1389 os9k_process_one_symbol ((int) type
, (int) bufp
->n_desc
,
1390 (CORE_ADDR
) bufp
->n_value
, bufp
->n_strx
, section_offsets
, objfile
);
1392 /* We skip checking for a new .o or -l file; that should never
1393 happen in this routine. */
1398 /* I don't think this code will ever be executed, because
1399 the GCC_COMPILED_FLAG_SYMBOL usually is right before
1400 the N_SO symbol which starts this source file.
1401 However, there is no reason not to accept
1402 the GCC_COMPILED_FLAG_SYMBOL anywhere. */
1404 if (STREQ (namestring
, GCC_COMPILED_FLAG_SYMBOL
))
1405 processing_gcc_compilation
= 1;
1406 else if (STREQ (namestring
, GCC2_COMPILED_FLAG_SYMBOL
))
1407 processing_gcc_compilation
= 2;
1409 if (AUTO_DEMANGLING
)
1411 set_demangling_style (GNU_DEMANGLING_STYLE_STRING
);
1414 else if (type
& N_EXT
|| type
== (unsigned char) N_TEXT
1415 || type
== (unsigned char) N_NBTEXT
1418 /* Global symbol: see if we came across a dbx defintion for
1419 a corresponding symbol. If so, store the value. Remove
1420 syms from the chain when their values are stored, but
1421 search the whole chain, as there may be several syms from
1422 different files with the same name. */
1423 /* This is probably not true. Since the files will be read
1424 in one at a time, each reference to a global symbol will
1425 be satisfied in each file as it appears. So we skip this
1432 current_objfile
= NULL
;
1434 /* In a Solaris elf file, this variable, which comes from the
1435 value of the N_SO symbol, will still be 0. Luckily, text_offset,
1436 which comes from pst->textlow is correct. */
1437 if (last_source_start_addr
== 0)
1438 last_source_start_addr
= text_offset
;
1439 pst
->symtab
= end_symtab (text_offset
+ text_size
, objfile
, SECT_OFF_TEXT
);
1444 /* This handles a single symbol from the symbol-file, building symbols
1445 into a GDB symtab. It takes these arguments and an implicit argument.
1447 TYPE is the type field of the ".stab" symbol entry.
1448 DESC is the desc field of the ".stab" entry.
1449 VALU is the value field of the ".stab" entry.
1450 NAME is the symbol name, in our address space.
1451 SECTION_OFFSETS is a set of amounts by which the sections of this object
1452 file were relocated when it was loaded into memory.
1453 All symbols that refer
1454 to memory locations need to be offset by these amounts.
1455 OBJFILE is the object file from which we are reading symbols.
1456 It is used in end_symtab. */
1459 os9k_process_one_symbol (type
, desc
, valu
, name
, section_offsets
, objfile
)
1463 struct section_offsets
*section_offsets
;
1464 struct objfile
*objfile
;
1466 register struct context_stack
*new;
1467 /* The stab type used for the definition of the last function.
1468 N_STSYM or N_GSYM for SunOS4 acc; N_FUN for other compilers. */
1469 static int function_stab_type
= 0;
1472 /* Something is wrong if we see real data before
1473 seeing a source file name. */
1474 if (last_source_file
== NULL
&& type
!= (unsigned char) N_SO
)
1476 /* Ignore any symbols which appear before an N_SO symbol.
1477 Currently no one puts symbols there, but we should deal
1478 gracefully with the case. A complain()t might be in order,
1479 but this should not be an error (). */
1487 /* On most machines, the block addresses are relative to the
1488 N_SO, the linker did not relocate them (sigh). */
1489 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
1490 new = push_context (desc
, valu
);
1494 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
1495 new = pop_context ();
1497 #if !defined (OS9K_VARIABLES_INSIDE_BLOCK)
1498 #define OS9K_VARIABLES_INSIDE_BLOCK(desc, gcc_p) 1
1501 if (!OS9K_VARIABLES_INSIDE_BLOCK (desc
, processing_gcc_compilation
))
1502 local_symbols
= new->locals
;
1504 if (context_stack_depth
> 1)
1506 /* This is not the outermost LBRAC...RBRAC pair in the function,
1507 its local symbols preceded it, and are the ones just recovered
1508 from the context stack. Define the block for them (but don't
1509 bother if the block contains no symbols. Should we complain
1510 on blocks without symbols? I can't think of any useful purpose
1512 if (local_symbols
!= NULL
)
1514 /* Muzzle a compiler bug that makes end < start. (which
1515 compilers? Is this ever harmful?). */
1516 if (new->start_addr
> valu
)
1518 complain (&lbrac_rbrac_complaint
);
1519 new->start_addr
= valu
;
1521 /* Make a block for the local symbols within. */
1522 finish_block (0, &local_symbols
, new->old_blocks
,
1523 new->start_addr
, valu
, objfile
);
1528 if (context_stack_depth
== 0)
1530 within_function
= 0;
1531 /* Make a block for the local symbols within. */
1532 finish_block (new->name
, &local_symbols
, new->old_blocks
,
1533 new->start_addr
, valu
, objfile
);
1537 /* attach local_symbols to the end of new->locals */
1539 new->locals
= local_symbols
;
1547 p
->next
= local_symbols
;
1552 if (OS9K_VARIABLES_INSIDE_BLOCK (desc
, processing_gcc_compilation
))
1553 /* Now pop locals of block just finished. */
1554 local_symbols
= new->locals
;
1559 /* This type of "symbol" really just records
1560 one line-number -- core-address correspondence.
1561 Enter it in the line list for this symbol table. */
1562 /* Relocate for dynamic loading and for ELF acc fn-relative syms. */
1563 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
1564 /* FIXME: loses if sizeof (char *) > sizeof (int) */
1565 record_line (current_subfile
, (int) name
, valu
);
1568 /* The following symbol types need to have the appropriate offset added
1569 to their value; then we process symbol definitions in the name. */
1576 char *p
= strchr (name
, ':');
1586 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
1587 n
= strrchr (name
, '/');
1600 if (symfile_depth
++ == 0)
1602 if (last_source_file
)
1604 end_symtab (valu
, objfile
, SECT_OFF_TEXT
);
1609 start_symtab (n
, dirn
, valu
);
1610 record_debugformat ("OS9");
1615 start_subfile (n
, dirn
!= NULL
? dirn
: current_subfile
->dirname
);
1621 valu
+= ANOFFSET (section_offsets
, SECT_OFF_TEXT
);
1622 function_stab_type
= type
;
1624 within_function
= 1;
1625 new = push_context (0, valu
);
1626 new->name
= define_symbol (valu
, name
, desc
, type
, objfile
);
1631 valu
+= ANOFFSET (section_offsets
, SECT_OFF_DATA
);
1632 define_symbol (valu
, name
, desc
, type
, objfile
);
1636 define_symbol (valu
, name
, desc
, type
, objfile
);
1643 if (--symfile_depth
!= 0)
1644 start_subfile (pop_subfile (), current_subfile
->dirname
);
1648 complain (&unknown_symtype_complaint
,
1649 local_hex_string ((unsigned long) type
));
1656 previous_stab_code
= type
;
1659 static struct sym_fns os9k_sym_fns
=
1661 bfd_target_os9k_flavour
,
1662 os9k_new_init
, /* sym_new_init: init anything gbl to entire symtab */
1663 os9k_symfile_init
, /* sym_init: read initial info, setup for sym_read() */
1664 os9k_symfile_read
, /* sym_read: read a symbol file into symtab */
1665 os9k_symfile_finish
, /* sym_finish: finished with file, cleanup */
1666 default_symfile_offsets
,
1667 /* sym_offsets: parse user's offsets to internal form */
1668 NULL
/* next: pointer to next struct sym_fns */
1672 _initialize_os9kread ()
1674 add_symtab_fns (&os9k_sym_fns
);