1 2020-07-26 Eli Zaretskii <eliz@gnu.org>
4 * ctf-create.c (EOVERFLOW): If not defined by system header,
5 redirect to ERANGE as a poor man's substitute.
6 * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
8 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
10 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
11 (ctf_dtd_delete): Likewise.
12 (ctf_dtd_lookup): Likewise.
13 (ctf_rollback): Likewise.
14 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
15 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
17 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
19 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
21 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
23 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
26 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
28 * ctf-impl.h (ctf_list_splice): New.
29 * ctf-util.h (ctf_list_splice): Likewise.
30 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
31 (ctf_link_sort_inputs): Likewise.
32 (ctf_link_deduplicating_count_inputs): Likewise.
33 (ctf_link_deduplicating_open_inputs): Likewise.
34 (ctf_link_deduplicating_close_inputs): Likewise.
35 (ctf_link_deduplicating_variables): Likewise.
36 (ctf_link_deduplicating_per_cu): Likewise.
37 (ctf_link_deduplicating): Likewise.
40 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
42 * ctf-link.c (ctf_link_one_input_archive_member): Check
43 CTF_LINK_OMIT_VARIABLES_SECTION.
45 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
47 * ctf-impl.h (ctf_type_id_key): New, the key in the
49 (ctf_dedup): New, core deduplicator state.
50 (ctf_file_t) <ctf_dedup>: New.
51 <ctf_dedup_atoms>: New.
52 <ctf_dedup_atoms_alloc>: New.
53 (ctf_hash_type_id_key): New prototype.
54 (ctf_hash_eq_type_id_key): Likewise.
55 (ctf_dedup_atoms_init): Likewise.
56 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
57 (ctf_dedup_atoms_init): Likewise.
58 * ctf-create.c (ctf_serialize): Adjusted.
59 (ctf_add_encoded): No longer static.
60 (ctf_add_reftype): Likewise.
61 * ctf-open.c (ctf_file_close): Destroy the
62 ctf_dedup_atoms_alloc.
63 * ctf-dedup.c: New file.
64 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
65 * configure.ac: Check for stpcpy.
66 * Makefile.am: Add it.
67 * Makefile.in: Regenerate.
68 * config.h.in: Regenerate.
69 * configure: Regenerate.
71 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
73 * configure.ac: Add --enable-libctf-hash-debugging.
74 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
75 * Makefile.in: Regenerated.
76 * configure: Likewise.
77 * config.h.in: Likewise.
78 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
79 (ctf_assert): Define to assert.
81 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
83 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
85 * ctf-impl.h: Include it.
87 (ctf_sha1_add): Likewise.
88 (ctf_sha1_fini): Likewise.
89 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
91 * Makefile.am: Add file.
92 * Makefile.in: Regenerate.
94 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
96 * libctf.ver (ctf_link_set_variable_filter): Add.
97 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
98 <ctf_link_variable_filter_arg>: Likewise.
99 * ctf-create.c (ctf_serialize): Adjust.
100 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
101 (ctf_link_one_variable): Call it if set.
103 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
105 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
106 conflicts, not the source type.
108 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
110 * ctf-impl.h (ctf_file_t): Improve comments.
111 <ctf_link_cu_mapping>: Split into...
112 <ctf_link_in_cu_mapping>: ... this...
113 <ctf_link_out_cu_mapping>: ... and this.
114 * ctf-create.c (ctf_serialize): Adjust.
115 * ctf-open.c (ctf_file_close): Likewise.
116 * ctf-link.c (ctf_create_per_cu): Look things up in the
117 in_cu_mapping instead of the cu_mapping.
118 (ctf_link_add_cu_mapping): The deduplicating link will define
119 what happens if many FROMs share a TO.
120 (ctf_link_add_cu_mapping): Create in_cu_mapping and
121 out_cu_mapping. Do not create ctf_link_outputs here any more, or
122 create per-CU dicts here: they are already created when needed.
123 (ctf_link_one_variable): Log a debug message if we skip a
124 variable due to its type being concealed in a CU-mapped link.
125 (This is probably too common a case to make into a warning.)
126 (ctf_link): Create empty per-CU dicts if requested.
128 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
130 * ctf-link.c (ctf_link_write): Close the fd.
132 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
134 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
135 * Makefile.in: Regenerated.
136 * ctf-impl.h (ctf_link_input_name): New.
137 (ctf_file_t) <ctf_link_flags>: New.
138 * ctf-create.c (ctf_serialize): Adjust accordingly.
139 * ctf-link.c: Define ctf_open as weak when PIC.
140 (ctf_arc_close_thunk): Remove unnecessary thunk.
141 (ctf_file_close_thunk): Likewise.
142 (ctf_link_input_name): New.
143 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
144 (ctf_link_input_close): Adjust accordingly.
145 (ctf_link_add_ctf_internal): New, split from...
146 (ctf_link_add_ctf): ... here. Return error if lazy loading of
147 CTF is not possible. Change to just call...
148 (ctf_link_add): ... this new function.
149 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
150 ctf_file_close_thunk.
151 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
152 <in_file_name>: ... this.
154 <share_mode>: Likewise (migrated to ctf_link_flags).
155 <done_main_member>: Rename to...
156 <done_parent>: ... this.
157 <main_input_fp>: Rename to...
158 <in_fp_parent>: ... this.
160 (ctf_link_one_type): Adjuwt accordingly. Transition to
161 ctf_err_warn, removing a TODO.
162 (ctf_link_one_variable): Note a case too common to warn about.
163 Report in the debug stream if a cu-mapped link prevents addition
164 of a conflicting variable.
165 (ctf_link_one_input_archive_member): Adjust.
166 (ctf_link_lazy_open): New, open a CTF archive for linking when
168 (ctf_link_close_one_input_archive): New, close it again.
169 (ctf_link_one_input_archive): Adjust for lazy opening, member
170 renames, and ctf_err_warn transition. Move the
171 empty_link_type_mapping call to...
172 (ctf_link): ... here. Adjut for renamings and thunk removal.
173 Don't spuriously fail if some input contains no CTF data.
174 (ctf_link_write): ctf_err_warn transition.
175 * libctf.ver: Remove not-yet-stable comment.
177 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
179 * ctf-impl.h (ctf_strerror): Delete.
180 * ctf-subr.c (ctf_strerror): Likewise.
181 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
184 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
186 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
187 (ctf_import_unref): New.
188 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
189 zero. Don't recurse back in if the refcount is already zero.
190 (ctf_import): Check ctf_parent_unreffed before deciding whether
191 to close a pre-existing parent. Set it to zero.
192 (ctf_import_unreffed): New, as above, setting
193 ctf_parent_unreffed to 1.
194 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
195 child: use direct assignment, and set unreffed on the new and
197 * ctf-link.c (ctf_create_per_cu): Import the parent using
200 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
202 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
203 (ctf_link_type_key): ... this, adjusting member prefixes to
205 (ctf_hash_type_mapping_key): Rename to...
206 (ctf_hash_type_key): ... this.
207 (ctf_hash_eq_type_mapping_key): Rename to...
208 (ctf_hash_eq_type_key): ... this.
209 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
210 (ctf_hash_type_key): ... this, and adjust for member name
212 (ctf_hash_eq_type_mapping_key): Rename to...
213 (ctf_hash_eq_type_key): ... this, and adjust for member name
215 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
216 need for out-of-memory checking in this code.
217 (ctf_type_mapping): Adjust.
219 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
221 configure.ac: Check for vasprintf.
222 configure: Regenerated.
223 config.h.in: Likewise.
225 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
227 * ctf-archive.c (ctf_arc_bufopen): Fix message.
229 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
231 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
233 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
234 if the input has no symtab, rather than dividing by
235 zero. Arrange to free it later via ctfi_free_ctfsect.
236 * ctf-archive.c (ctf_new_archive_internal): Do not
237 ctfi_free_strsect by default.
238 (ctf_arc_close): Possibly free it here.
240 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
242 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
243 (ctf_dump_format_type): improve slice formatting. Always print
244 the type size, even of slices.
245 (ctf_dump_member): Print slices (-> bitfields) differently from
246 non-slices. Failure to format a type is not an OOM.
248 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
250 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
251 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
252 (ctf_dump_objts): Likewise.
253 (ctf_dump_var): Likewise.
254 (ctf_dump_type): Do not emit a duplicate message. Move to
255 ctf_err_warning, and swallow all errors.
257 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
259 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
260 (ctf_decl_buf): Once it escapes, don't try to free it later.
262 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
264 * ctf-types.c (ctf_type_aname): Print arg types here...
265 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
266 in the type name here.
268 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
270 * ctf-impl.h (ctf_assert): New.
271 (ctf_err_warning_t): Likewise.
272 (ctf_file_t) <ctf_errs_warnings>: Likewise.
273 (ctf_err_warn): New prototype.
274 (ctf_assert_fail_internal): Likewise.
275 * ctf-inlines.h (ctf_assert_internal): Likewise.
276 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
277 * ctf-create.c (ctf_serialize): Copy it on serialization.
278 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
279 (ctf_errwarning_next): New iterator, free and pass back
280 errors/warnings in succession.
281 * libctf.ver (ctf_errwarning_next): Add.
283 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
285 * ctf-types.c (ctf_variable_iter): Fix error return.
287 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
289 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
291 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
293 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
295 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
297 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
299 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
300 ctf_dynhash_next_sorted.
301 <cu.ctn_h>: New, pointer to the dynhash under iteration.
302 <cu.ctn_s>: New, pointer to the dynset under iteration.
303 (ctf_hash_sort_f): Sorting function passed to...
304 (ctf_dynhash_next_sorted): ... this new function.
305 (ctf_dynhash_next): New.
306 (ctf_dynset_next): New.
307 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
308 (ctf_dynhash_cnext): New.
309 (ctf_dynset_cnext): New.
310 * ctf-hash.c (ctf_dynhash_next_sorted): New.
311 (ctf_dynhash_next): New.
312 (ctf_dynset_next): New.
313 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
315 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
317 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
319 * ctf-impl.h (ctf_next): New.
320 (ctf_get_dict): New prototype.
321 * ctf-lookup.c (ctf_get_dict): New, split out of...
322 (ctf_lookup_by_id): ... here.
323 * ctf-util.c (ctf_next_create): New.
324 (ctf_next_destroy): New.
325 (ctf_next_copy): New.
326 * ctf-types.c (includes): Add <assert.h>.
327 (ctf_member_next): New.
328 (ctf_enum_next): New.
329 (ctf_type_iter): Document the lack of iteration over parent
331 (ctf_type_next): New.
332 (ctf_variable_next): New.
333 * ctf-archive.c (ctf_archive_next): New.
334 * libctf.ver: Add new public functions.
336 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
338 * libctf.ver (ctf_ref): New.
339 * ctf-open.c (ctf_ref): Implement it.
341 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
343 * ctf-inlines.h (ctf_forwardable_kind): New.
344 * ctf-create.c (ctf_add_forward): Use it.
346 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
348 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
349 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
351 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
353 * ctf-hash.c (ctf_dynset_eq_string): New.
354 (ctf_dynset_create): New.
355 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
356 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
357 (key_to_internal): New.
358 (internal_to_key): New.
359 (ctf_dynset_insert): New.
360 (ctf_dynset_remove): New.
361 (ctf_dynset_destroy): New.
362 (ctf_dynset_lookup): New.
363 (ctf_dynset_exists): New.
364 (ctf_dynset_lookup_any): New.
365 (ctf_hash_insert_type): Coding style.
366 (ctf_hash_define_type): Likewise.
367 * ctf-impl.h (ctf_dynset_t): New.
368 (ctf_dynset_eq_string): New.
369 (ctf_dynset_create): New.
370 (ctf_dynset_insert): New.
371 (ctf_dynset_remove): New.
372 (ctf_dynset_destroy): New.
373 (ctf_dynset_lookup): New.
374 (ctf_dynset_exists): New.
375 (ctf_dynset_lookup_any): New.
376 * ctf-inlines.h (ctf_dynset_cinsert): New.
378 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
380 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
381 <value_free>: Likewise.
383 (ctf_dynhash_item_free): Indirect through the owner.
384 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
385 allocate space for the key_free and value_free fields fields
387 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
388 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
389 value_free if they will exist. Set the slot's owner, but only
391 (ctf_dynhash_remove): Adjust.
393 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
395 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
396 there is a key-freeing function and the key already exists.
398 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
400 * ctf-inlines.h: New file.
401 * ctf-impl.h: Include it.
402 (ctf_hash_iter_find_f): New typedef.
403 (ctf_dynhash_elements): New.
404 (ctf_dynhash_lookup_kv): New.
405 (ctf_dynhash_iter_find): New.
406 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
407 (ctf_traverse_find_cb_arg_t): New.
408 (ctf_hashtab_traverse_find): New.
409 (ctf_dynhash_iter_find): New.
410 (ctf_dynhash_elements): New.
412 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
414 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
416 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
418 * ctf-archive.c (ctf_archive_count): New.
419 * libctf.ver: New public function.
421 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
423 * ctf-types.c (ctf_member_count): New.
424 * libctf.ver: New public function.
426 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
428 * ctf-types.c (ctf_type_kind_forwarded): New.
430 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
432 * ctf-types.c (ctf_type_name_raw): New.
433 (ctf_type_aname_raw): Reimplement accordingly.
435 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
437 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
439 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
441 * ctf-impl.h (struct ctf_archive_internal)
442 <ctfi_unmap_on_close>: New.
443 (ctf_new_archive_internal): Adjust.
444 * ctf-archive.c (ctf_new_archive_internal): Likewise.
445 Initialize ctfi_unmap_on_close. Adjust error path.
446 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
447 (unmap_on_close is 0).
448 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
449 * ctf-open-bfd.c (ctf_fdopen): Adjust.
451 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
453 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
454 ints, floats or typedefs have no name. Fix comment typo.
456 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
458 * ctf-create.c (ctf_add_slice): Support slices of any kind that
459 resolves to an integral type.
460 * ctf-types.c (ctf_type_encoding): Resolve the type before
461 fishing its encoding out.
463 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
465 * ctf-create.c (ctf_create): Mark dirty.
467 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
469 * ctf-create.c (membcmp) Skip nameless members.
471 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
473 * ctf-create.c (ctf_add_member_offset): Support names of ""
474 as if they were the null pointer.
476 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
478 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
481 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
483 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
485 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
487 * ctf-create.c (ctf_serialize): Add cast.
488 (ctf_add_slice): Likewise.
490 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
492 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
493 * ctf-create.c (ctf_add_function): Check for unimplemented type
494 and populate at the same time. Populate one-by-one, not via
496 (ctf_serialize): Remove unnecessary cast.
497 * ctf-types.c (ctf_func_type_info): Likewise.
498 (ctf_func_type_args): Likewise. Fix comment typo.
500 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
502 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
503 (ctf_add_array): Support array contents of type zero.
504 (ctf_add_function): Support arguments and return types of
506 (ctf_add_typedef): Support typedefs to type zero.
507 (ctf_add_member_offset): Support members of type zero,
508 unless added at unspecified (naturally-aligned) offset.
510 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
512 * ctf-error.c: Include <stddef.h>, for offsetof.
513 (_ctf_errlist): Migrate to...
514 (_ctf_errlist_t): ... this.
515 (_ctf_erridx): New, indexes into _ctf_errlist_t.
517 (ctf_errmsg): Adjust accordingly.
518 * Makefile.am (BUILT_SOURCES): Note...
519 (ctf-error.h): ... this new rule.
520 * Makefile.in: Regenerate.
521 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
522 * .gitignore: New, ignore ctf-error.h.
524 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
526 * ctf-impl.h: Fix typos in comments.
528 2020-07-22 Nick Clifton <nickc@redhat.com>
530 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
531 same file descriptor.
533 2020-07-04 Nick Clifton <nickc@redhat.com>
535 Binutils 2.35 branch created.
537 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
539 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
541 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
542 * config.h.in: Regenerated.
543 * Makefile.in: Likewise.
544 * configure: Likewise.
546 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
548 * ctf-create.c: Include <unistd.h>.
549 * ctf-open-bfd.c: Likewise.
551 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
554 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
555 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
556 means this is declared.
557 (bswap_32): Likewise.
558 (bswap_64): Likewise.
559 (bswap_identity_64): Remove, unused.
560 * configure: Regenerated.
561 * config.h.in: Likewise.
563 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
566 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
567 (_libctf_unlikely_): Likewise.
568 (_libctf_unused): Likewise.
569 (_libctf_malloc_): Likewise.
571 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
574 * ctf-archive.c (search_nametbl): No longer global: declare...
575 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
576 (search_modent_by_name): Take and use ARG for the nametbl.
578 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
580 * ctf-impl.h (ctf_new_archive_internal): Declare.
581 (ctf_arc_bufopen): Remove.
582 (ctf_archive_internal) <ctfi_free_symsect>: New.
583 * ctf-archive.c (ctf_arc_close): Use it.
584 (ctf_arc_bufopen): Fuse into...
585 (ctf_new_archive_internal): ... this, moved across from...
586 * ctf-open-bfd.c: ... here.
587 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
588 * libctf.ver: Add it.
590 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
592 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
593 (ctf_dtd_delete): Remove correspondingly.
594 (ctf_rollback): Likewise.
596 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
598 * ctf-create.c (ctf_add_type_internal): Hand back existing types
601 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
603 * ctf-create.c (ctf_add_forward): Don't add forwards to
604 types that already exist.
606 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
608 * ctf-open.c (init_types): Only intern root-visible types.
609 * ctf-create.c (ctf_dtd_insert): Likewise.
610 (ctf_dtd_delete): Only remove root-visible types.
611 (ctf_rollback): Likewise.
612 (ctf_add_generic): Adjust.
613 (ctf_add_struct_sized): Adjust comment.
614 (ctf_add_union_sized): Likewise.
615 (ctf_add_enum): Likewise.
616 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
618 2020-03-11 John Baldwin <jhb@FreeBSD.org>
620 * swap.h (bswap_identity_64): Make static.
622 2020-01-18 Nick Clifton <nickc@redhat.com>
624 Binutils 2.34 branch created.
626 2020-01-05 Joel Brobecker <brobecker@adacore.com>
629 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
630 * configure, config.h.in: Regenerate.
632 2020-01-01 Alan Modra <amodra@gmail.com>
634 Update year range in copyright notice of all files.
636 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
638 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
640 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
642 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
643 * ctf-types.c (ctf_type_lname): Likewise.
645 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
647 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
648 ctf_import after the first for a given file.
650 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
652 * ctf-impl.h (ctf_str_append_noerr): Declare.
653 * ctf-util.c (ctf_str_append_noerr): Define in terms of
655 * ctf-dump.c (str_append): New, call it.
656 (ctf_dump_format_type): Use str_append, not ctf_str_append.
657 (ctf_dump_label): Likewise.
658 (ctf_dump_objts): Likewise.
659 (ctf_dump_funcs): Likewise.
660 (ctf_dump_var): Likewise.
661 (ctf_dump_member): Likewise.
662 (ctf_dump_type): Likewise.
663 (ctf_dump): Likewise.
665 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
667 * ctf-impl.h (ctf_alloc): Remove.
668 (ctf_free): Likewise.
669 (ctf_strdup): Likewise.
670 * ctf-subr.c (ctf_alloc): Remove.
671 (ctf_free): Likewise.
672 * ctf-util.c (ctf_strdup): Remove.
674 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
675 ctf_free; strdup, not ctf_strdup.
676 (ctf_dtd_delete): Likewise.
677 (ctf_dvd_delete): Likewise.
678 (ctf_add_generic): Likewise.
679 (ctf_add_function): Likewise.
680 (ctf_add_enumerator): Likewise.
681 (ctf_add_member_offset): Likewise.
682 (ctf_add_variable): Likewise.
684 (ctf_compress_write): Likewise.
685 (ctf_write_mem): Likewise.
686 * ctf-decl.c (ctf_decl_push): Likewise.
687 (ctf_decl_fini): Likewise.
688 (ctf_decl_sprintf): Likewise. Check for OOM.
689 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
690 ctf_free; strdup, not ctf_strdup.
691 (ctf_dump_free): Likewise.
692 (ctf_dump): Likewise.
693 * ctf-open.c (upgrade_types_v1): Likewise.
694 (init_types): Likewise.
695 (ctf_file_close): Likewise.
696 (ctf_bufopen_internal): Likewise. Check for OOM.
697 (ctf_parent_name_set): Likewise: report the OOM to the caller.
698 (ctf_cuname_set): Likewise.
699 (ctf_import): Likewise.
700 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
701 free, not ctf_free; strdup, not ctf_strdup.
702 (ctf_str_free_atom): Likewise.
703 (ctf_str_create_atoms): Likewise.
704 (ctf_str_add_ref_internal): Likewise.
705 (ctf_str_remove_ref): Likewise.
706 (ctf_str_write_strtab): Likewise.
708 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
710 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
711 work right for non-int/fps.
713 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
715 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
718 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
720 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
721 * ctf-open.c (ctf_file_close): Free it.
722 * ctf-create.c (ctf_serialize): Adjust.
723 (membcmp): When reporting a conflict due to an error, report the
725 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
726 (ctf_add_type_internal): ... this. Hand back types we are already
727 in the middle of adding immediately. Hand back structs/unions with
728 the same number of members immediately. Do not walk the dynamic
729 list. Call ctf_add_type_internal, not ctf_add_type. Handle
730 forwards promoted to other types and the inverse case identically.
731 Add structs to the mapping as soon as we intern them, before they
734 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
736 * ctf-impl.h (ctf_names_t): New.
737 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
738 (ctf_file_t) <ctf_structs>: Likewise.
739 <ctf_unions>: Likewise.
740 <ctf_enums>: Likewise.
741 <ctf_names>: Likewise.
742 <ctf_lookups>: Improve comment.
743 <ctf_ptrtab_len>: New.
744 <ctf_prov_strtab>: New.
745 <ctf_str_prov_offset>: New.
746 <ctf_dtbyname>: Remove, redundant to the names hashes.
747 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
748 (ctf_dtdef_t) <dtd_name>: Remove.
749 <dtd_data>: Note that the ctt_name is now populated.
750 (ctf_str_atom_t) <csa_offset>: This is now the strtab
751 offset for internal strings too.
752 <csa_external_offset>: New, the external strtab offset.
753 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
754 (ctf_name_table): New declaration.
755 (ctf_lookup_by_rawname): Likewise.
756 (ctf_lookup_by_rawhash): Likewise.
757 (ctf_set_ctl_hashes): Likewise.
758 (ctf_serialize): Likewise.
759 (ctf_dtd_insert): Adjust.
760 (ctf_simple_open_internal): Likewise.
761 (ctf_bufopen_internal): Likewise.
762 (ctf_list_empty_p): Likewise.
763 (ctf_str_remove_ref): Likewise.
764 (ctf_str_add): Returns uint32_t now.
765 (ctf_str_add_ref): Likewise.
766 (ctf_str_add_external): Now returns a boolean (int).
767 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
768 for strings in the appropriate range.
769 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
770 when adding the null string to the new strtab.
771 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
772 (ctf_str_add_ref_internal): Add make_provisional argument. If
773 make_provisional, populate the offset and fill in the
774 ctf_prov_strtab accordingly.
775 (ctf_str_add): Return the offset, not the string.
776 (ctf_str_add_ref): Likewise.
777 (ctf_str_add_external): Return a success integer.
778 (ctf_str_remove_ref): New, remove a single ref.
779 (ctf_str_count_strtab): Do not count the initial null string's
780 length or the existence or length of any unreferenced internal
782 (ctf_str_populate_sorttab): Skip atoms with no refs.
783 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
784 to the cts_len for the null string, since it is no longer done
785 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
786 Populate the csa_offset for both internal and external cases.
787 Flush the ctf_prov_strtab afterwards, and reset the
789 * ctf-create.c (ctf_grow_ptrtab): New.
790 (ctf_create): Call it. Initialize new fields rather than old
791 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
792 Set the ctl hashes and data model.
793 (ctf_update): Rename to...
794 (ctf_serialize): ... this. Leave a compatibility function behind.
795 Tell ctf_simple_open_internal that this is a writable dictionary.
796 Pass the new fields along from the old dictionary. Drop
797 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
798 Do not zero out the DTD's ctt_name.
799 (ctf_prefixed_name): Rename to...
800 (ctf_name_table): ... this. No longer return a prefixed name: return
801 the applicable name table instead.
802 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
803 kind we're adding. Migrate away from dtd_name.
804 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
806 (ctf_dtd_lookup_type_by_name): Remove.
807 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
808 No longer check ctf_dtnextid: check ctf_typemax instead.
809 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
810 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
811 ctf_name_table and the right name table, and migrate away from
812 dtd_name as in ctf_dtd_delete.
813 (ctf_add_generic): Pass in the kind explicitly and pass it to
814 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
815 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
816 Grow the ptrtab if needed.
817 (ctf_add_encoded): Pass in the kind.
818 (ctf_add_slice): Likewise.
819 (ctf_add_array): Likewise.
820 (ctf_add_function): Likewise.
821 (ctf_add_typedef): Likewise.
822 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
823 ctt_name rather than dtd_name.
824 (ctf_add_struct_sized): Pass in the kind. Use
825 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
826 ctf_dtd_lookup_type_by_name.
827 (ctf_add_union_sized): Likewise.
828 (ctf_add_enum): Likewise.
829 (ctf_add_enum_encoded): Likewise.
830 (ctf_add_forward): Likewise.
831 (ctf_add_type): Likewise.
832 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
833 being initialized until after the call.
834 (ctf_write_mem): Likewise.
835 (ctf_write): Likewise.
836 * ctf-archive.c (arc_write_one_ctf): Likewise.
837 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
838 ctf_hash_lookup_type.
839 (ctf_lookup_by_id): No longer check the readonly types if the
840 dictionary is writable.
841 * ctf-open.c (init_types): Assert that this dictionary is not
842 writable. Adjust to use the new name hashes, ctf_name_table,
843 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
844 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
845 if set. Drop out early when dictionary is writable. Split the
846 ctf_lookups initialization into...
847 (ctf_set_cth_hashes): ... this new function.
848 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
849 (ctf_simple_open): Adjust accordingly.
850 (ctf_bufopen): Likewise.
851 (ctf_file_close): Destroy the appropriate name hashes. No longer
852 destroy ctf_dtbyname, which is gone.
853 (ctf_getdatasect): Remove spurious "extern".
854 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
855 specified name table, given a kind.
856 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
857 (ctf_member_iter): Add support for iterating over the
859 (ctf_enum_iter): Likewise.
860 (ctf_variable_iter): Likewise.
861 (ctf_type_rvisit): Likewise.
862 (ctf_member_info): Add support for types in the dynamic type list.
863 (ctf_enum_name): Likewise.
864 (ctf_enum_value): Likewise.
865 (ctf_func_type_info): Likewise.
866 (ctf_func_type_args): Likewise.
867 * ctf-link.c (ctf_accumulate_archive_names): No longer call
869 (ctf_link_write): Likewise.
870 (ctf_link_intern_extern_string): Adjust for new
871 ctf_str_add_external return value.
872 (ctf_link_add_strtab): Likewise.
873 * ctf-util.c (ctf_list_empty_p): New.
875 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
877 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
879 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
881 (ctf_add_variable): Likewise for variables pointing to them.
882 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
883 type link failure, but do warn for others.
884 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
886 (ctf_dump_member): Likewise.
887 (ctf_dump_type): Likewise.
888 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
889 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
890 (ctf_dump_header): Likewise.
891 (ctf_dump_label): likewise.
892 (ctf_dump_objts): likewise.
893 (ctf_dump_funcs): likewise.
894 (ctf_dump_var): likewise.
895 (ctf_dump_str): Likewise.
897 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
899 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
901 (AM_INSTALL_LIBBFD): Likewise.
902 (dlopen): Note why this is necessary in a comment.
903 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
905 (SHARED_LDFLAGS): Likewise.
906 (BFD_LIBADD): Likewise, for libbfd.
907 (BFD_DEPENDENCIES): Likewise.
908 (VERSION_FLAGS): Initialize, using a version script if ld supports
909 one, or libtool -export-symbols-regex otherwise.
910 (AC_CONFIG_MACRO_DIR): Add ../BFD.
911 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
913 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
914 (noinst_LIBRARIES): Replace with...
915 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
916 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
917 libctf-nobfd.la as well.
918 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
919 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
920 (libctf_a_SOURCES): Rename to...
921 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
923 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
924 with ctf-open-bfd.c added.
925 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
926 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
927 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
928 * Makefile.am [INSTALL_LIBCTF]: Use it.
929 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
931 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
932 the unstable components).
933 * Makefile.in: Regenerated.
934 * config.h.in: Likewise.
935 * configure: Likewise.
937 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
939 * configure.ac (INSTALL_LIBCTF): New, controlled by
940 --enable-install-libctf.
941 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
942 * Makefile.in: Regenerated.
943 * configure: Regenerated.
945 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
947 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
948 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
950 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
952 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
954 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
956 * ctf-impl.h (includes): Include <sys/param.h> here.
958 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
960 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
961 (flip_objts): Likewise.
962 (flip_vars): Likewise.
963 (flip_types): Likewise.
965 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
967 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
968 freeing functions: if set, free the key and value if the slot
969 already exists. Always reassign the key.
970 (ctf_dynhash_insert): Adjust call appropriately.
971 (ctf_hash_insert_type): Likewise.
973 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
975 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
976 type kind. Allow forwards to unify with pre-existing structs/
979 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
981 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
982 <ctf_link_memb_name_changer>: Likewise.
983 <ctf_link_memb_name_changer_arg>: Likewise.
984 * ctf-create.c (ctf_update): Update accordingly.
985 * ctf-open.c (ctf_file_close): Likewise.
986 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
987 (ctf_link_add_cu_mapping): New.
988 (ctf_link_set_memb_name_changer): Likewise.
989 (ctf_change_parent_name): New.
990 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
991 allocated by the caller's ctf_link_memb_name_changer.
992 <ndynames>: Likewise.
993 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
994 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
995 ctf_change_parent_name. Free any resulting names.
997 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
999 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1000 (ctf_link_one_type): ... here, with parent-name setting added.
1001 (check_variable): New.
1002 (ctf_link_one_variable): Likewise.
1003 (ctf_link_one_input_archive_member): Call it.
1004 * ctf-error.c (_ctf_errlist): Updated with new errors.
1006 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1008 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1009 (struct ctf_link_type_mapping_key): New.
1010 (ctf_hash_type_mapping_key): Likewise.
1011 (ctf_hash_eq_type_mapping_key): Likewise.
1012 (ctf_add_type_mapping): Likewise.
1013 (ctf_type_mapping): Likewise.
1014 (ctf_dynhash_empty): Likewise.
1015 * ctf-open.c (ctf_file_close): Update accordingly.
1016 * ctf-create.c (ctf_update): Likewise.
1017 (ctf_add_type): Populate the mapping.
1018 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1019 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1020 (ctf_dynhash_insert): Fix comment typo.
1021 (ctf_dynhash_empty): New.
1022 * ctf-link.c (ctf_add_type_mapping): New.
1023 (ctf_type_mapping): Likewise.
1024 (empty_link_type_mapping): New.
1025 (ctf_link_one_input_archive): Call it.
1027 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1029 * ctf-link.c: New file, linking of the string and type sections.
1030 * Makefile.am (libctf_a_SOURCES): Add it.
1031 * Makefile.in: Regenerate.
1033 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1035 * ctf-create.c (ctf_update): Update accordingly.
1036 * ctf-open.c (ctf_file_close): Likewise.
1037 * ctf-error.c (_ctf_errlist): Updated with new errors.
1039 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1041 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1043 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1045 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1047 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1048 (ctf_dump_format_type): Add non-root-type { } notation.
1049 Add root flag to prototype.
1050 (ctf_dump_label): Adjust accordingly.
1051 (ctf_dump_objts): Likewise.
1052 (ctf_dump_var): Likewise.
1054 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1056 * ctf-create.c (ctf_compress_write): Fix double-free.
1058 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1060 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1062 (ctf_arc_write_fd): ... this new function.
1063 * ctf-create.c (ctf_write_mem): New.
1065 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1067 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1068 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1069 (ctf_str_add_ref): Name the last arg.
1070 (ctf_str_add_external) New.
1071 (ctf_str_add_strraw_explicit): Likewise.
1072 (ctf_simple_open_internal): Likewise.
1073 (ctf_bufopen_internal): Likewise.
1075 * ctf-string.c (ctf_strraw_explicit): Split from...
1076 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1077 (ctf_str_add_ref_internal): Return the atom, not the
1079 (ctf_str_add): Adjust accordingly.
1080 (ctf_str_add_ref): Likewise. Move up in the file.
1081 (ctf_str_add_external): New: update the csa_offset.
1082 (ctf_str_count_strtab): Only account for strings with no csa_offset
1083 in the internal strtab length.
1084 (ctf_str_write_strtab): If the csa_offset is set, update the
1085 string's refs without writing the string out, and update the
1086 ctf_syn_ext_strtab. Make OOM handling less ugly.
1087 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1088 (ctf_update): Handle failure to populate the strtab. Pass in the
1089 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1090 Call ctf_simple_open_internal, not ctf_simple_open.
1091 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1093 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1094 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1095 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1096 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1097 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1098 (ctf_simple_open_internal): ... this new function, which calls
1099 ctf_bufopen_internal.
1100 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1101 (ctf_bufopen_internal): ... this new function, which sets
1104 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1106 * ctf_types.c (ctf_type_iter_all): New.
1108 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1110 * ctf-open.c (init_symtab): Check for overflow against the right
1112 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1113 (upgrade_types_v1): Note that these sections are not checked.
1114 (flip_header): Endian-swap the header fields.
1115 (flip_ctf): Endian-swap the sections.
1116 (flip_objts): Update comment.
1117 (ctf_bufopen): Check header offsets and alignment for validity.
1119 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1121 * ctf-open-bfd.c: Add <assert.h>.
1122 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1123 techniques borrowed from bfd_elf_sym_name.
1124 (ctf_new_archive_internal): Improve comment.
1125 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1126 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1127 no symbol section, but not vice versa.
1129 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1131 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1132 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1133 * ctf-dump.c (dump_header): New function, dump the CTF header.
1134 (ctf_dump): Call it.
1135 (ctf_dump_header_strfield): New function.
1136 (ctf_dump_header_sectfield): Likewise.
1138 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1140 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1141 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1142 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1143 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1144 Print out ctf_cuname: only print out ctf_parname if set.
1145 (ctf_free_base): Removed, ctf_base is no longer freed: free
1146 ctf_dynbase instead.
1147 (ctf_set_version): Fix spacing.
1148 (upgrade_header): New, in-place header upgrading.
1149 (upgrade_types): Rename to...
1150 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1151 longer track old and new headers separately. No longer allow for
1152 header sizes explicitly: squeeze the headers out on upgrade (they
1153 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1154 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1155 (upgrade_types): New, also handle ctf_parmax updating.
1156 (flip_header): Flip ctf_cuname.
1157 (flip_types): Flip BUF explicitly rather than deriving BUF from
1159 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1160 required alignment of objtoff and funcoff. No longer store it in
1161 the ctf_buf unless that buf is derived unmodified from the input.
1162 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1163 that duplicate fields in ctf_file: move allocation of ctf_file
1164 further up instead. Call upgrade_header as needed. Move
1165 version-specific ctf_parmax initialization into upgrade_types. More
1166 concise error handling.
1167 (ctf_file_close): No longer test for null pointers before freeing.
1168 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1171 (ctf_cuname_set): New.
1172 * ctf-create.c (ctf_update): Populate ctf_cuname.
1173 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1175 (ctf_write): Likewise.
1176 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1177 Fix the compression length: fp->ctf_size never counted the CTF
1178 header. Simplify the compress call accordingly.
1180 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1182 * ctf-endian.h: Don't assume htole64 and le64toh are always
1183 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1184 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1185 not bswap_identity_64.
1187 2019-09-18 Alan Modra <amodra@gmail.com>
1189 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1191 2019-09-09 Phil Blundell <pb@pbcl.net>
1193 binutils 2.33 branch created.
1195 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1197 * ctf-types.c (ctf_type_aname_raw): New.
1198 (ctf_func_type_info): Likewise.
1199 (ctf_func_type_args): Likewise.
1200 * ctf-error.c (_ctf_errlist): Fix description.
1201 * ctf-lookup.c: Fix file description.
1203 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1205 * ctf-create.c (ctf_create): Fix off-by-one error.
1207 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1209 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1211 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1212 (struct ctf_str_atom): New, disambiguated single string.
1213 (struct ctf_str_atom_ref): New, points to some other location that
1214 references this string's offset.
1215 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1216 Remove member ctf_dtvstrlen: we no longer track the total strlen
1218 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1219 (ctf_str_free_atoms): Likewise.
1220 (ctf_str_add): Likewise.
1221 (ctf_str_add_ref): Likewise.
1222 (ctf_str_rollback): Likewise.
1223 (ctf_str_purge_refs): Likewise.
1224 (ctf_str_write_strtab): Likewise.
1225 (ctf_realloc): Declare new function in ctf-util.c.
1227 * ctf-open.c (ctf_bufopen): Create the atoms table.
1228 (ctf_file_close): Destroy it.
1229 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1230 special-case the position of the parname string. Construct the
1231 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1232 rest of each buffer element is constructed, not via open-coding:
1233 realloc the CTF buffer and append the strtab to it. No longer
1234 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1235 strtab construction.
1236 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1237 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1238 after buffer element construction instead.
1239 (ctf_copy_lmembers): Likewise.
1240 (ctf_copy_emembers): Likewise.
1241 (ctf_create): No longer maintain the ctf_dtvstrlen.
1242 (ctf_dtd_delete): Likewise.
1243 (ctf_dvd_delete): Likewise.
1244 (ctf_add_generic): Likewise.
1245 (ctf_add_enumerator): Likewise.
1246 (ctf_add_member_offset): Likewise.
1247 (ctf_add_variable): Likewise.
1248 (membadd): Likewise.
1249 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1250 if there are active ctf_str_num_refs.
1251 (ctf_strraw): Move to ctf-string.c.
1252 (ctf_strptr): Likewise.
1253 * ctf-string.c: New file, strtab manipulation.
1255 * Makefile.am (libctf_a_SOURCES): Add it.
1256 * Makefile.in: Regenerate.
1258 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1260 * ctf-impl.h (ctf_hash_iter_f): New.
1261 (ctf_dynhash_iter): New declaration.
1262 (ctf_dynhash_iter_remove): New declaration.
1263 * ctf-hash.c (ctf_dynhash_iter): Define.
1264 (ctf_dynhash_iter_remove): Likewise.
1265 (ctf_hashtab_traverse): New.
1266 (ctf_hashtab_traverse_remove): Likewise.
1267 (struct ctf_traverse_cb_arg): Likewise.
1268 (struct ctf_traverse_remove_cb_arg): Likewise.
1270 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1272 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1274 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1276 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1277 (ctf_dump_funcs): Likewise.
1279 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1281 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1282 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1283 little-endian CTF archive magic. Do not check the CTF version:
1284 ctf_simple_open does that in endian-safe ways. Do not dereference
1285 null pointers on open failure.
1287 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1289 * ctf-open.c (get_vbytes_common): Return the new slice size.
1290 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1291 Remember to copy in the CTF data when opening an uncompressed
1292 foreign-endian CTF file. Prune useless variable manipulation.
1294 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1296 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1299 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1301 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1304 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1306 * ctf-subr.c (_PAGESIZE): Remove.
1307 (ctf_data_alloc): Likewise.
1308 (ctf_data_free): Likewise.
1309 (ctf_data_protect): Likewise.
1310 * ctf-impl.h: Remove declarations.
1311 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1312 ctf_free, not ctf_data_free.
1313 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1314 the buffer again on compression error.
1315 * ctf-open.c (ctf_set_base): No longer track the size: call
1316 ctf_free, not ctf_data_free.
1317 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1318 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1320 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1322 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1324 (ctf_dvd_insert): Likewise.
1325 (ctf_add_generic): Likewise.
1326 (ctf_add_variable): Likewise.
1327 * ctf-impl.h: Adjust declarations.
1329 2019-06-14 Alan Modra <amodra@gmail.com>
1331 * configure: Regenerate.
1333 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1335 * ctf-decls.h: Include <libiberty.h>.
1336 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1338 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1340 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1341 (ctf_dump_objts): Likewise.
1342 (ctf_dump_funcs): Likewise.
1343 (ctf_dump_member): Likewise.
1344 (ctf_dump_str): Likewise.
1346 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1348 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1349 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1351 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1353 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1354 (ctf_arc_open_by_offset): Likewise.
1355 * ctf-create.c (ctf_add_type): Likewise.
1357 2019-06-04 Tom Tromey <tromey@adacore.com>
1359 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1360 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1362 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1364 * configure.ac: Check for O_CLOEXEC.
1365 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1366 * config.h.in: Regenerate.
1367 * configure: Likewise.
1369 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1371 * qsort_r.c: Rename to...
1372 * ctf-qsort_r.c: ... this.
1373 (_quicksort): Define to ctf_qsort_r.
1374 * ctf-decls.h (qsort_r): Remove.
1376 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1377 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1378 * Makefile.am (libctf_a_LIBADD): Remove.
1379 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1380 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1381 * ctf-create.c (ctf_update): Likewise.
1382 * configure.ac: Check for BSD versus GNU qsort_r signature.
1383 * Makefile.in: Regenerate.
1384 * config.h.in: Likewise.
1385 * configure: Likewise.
1387 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1389 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1391 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1393 * Makefile.am (ZLIB): New.
1394 (ZLIBINC): Likewise.
1395 (AM_CFLAGS): Use them.
1396 (libctf_a_LIBADD): New, for LIBOBJS.
1397 * configure.ac: Check for zlib, endian.h, and qsort_r.
1398 * ctf-endian.h: New, providing htole64 and le64toh.
1399 * swap.h: Code style fixes.
1400 (bswap_identity_64): New.
1401 * qsort_r.c: New, from gnulib (with one added #include).
1402 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1403 and unconditional definitions of MIN and MAX.
1404 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1405 (ctf_set_errno): Now returns unsigned long.
1406 * ctf-util.c (ctf_set_errno): Adjust here too.
1407 * ctf-archive.c: Use ctf-endian.h.
1408 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1409 cts_flags and cts_offset.
1410 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1411 * ctf-create.c: Provide a definition of roundup if not defined.
1412 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1413 (ctf_add_reftype): Do not check if type IDs are below zero.
1414 (ctf_add_slice): Likewise.
1415 (ctf_add_typedef): Likewise.
1416 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1417 when known error-free. Drop CTF_ERR usage for functions returning
1419 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1421 (ctf_add_variable): Likewise.
1422 (enumcmp): Likewise.
1423 (enumadd): Likewise.
1424 (membcmp): Likewise.
1425 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1426 when known error-free.
1427 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1428 returning int: use CTF_ERR for functions returning ctf_type_id.
1429 (ctf_dump_label): Likewise.
1430 (ctf_dump_objts): Likewise.
1431 * ctf-labels.c (ctf_label_topmost): Likewise.
1432 (ctf_label_iter): Likewise.
1433 (ctf_label_info): Likewise.
1434 * ctf-lookup.c (ctf_func_args): Likewise.
1435 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1436 (ctf_bufopen): Likewise. Use zlib types as needed.
1437 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1439 (ctf_enum_iter): Likewise.
1440 (ctf_type_size): Likewise.
1441 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1442 (ctf_type_kind_unsliced): Likewise.
1443 (ctf_type_kind): Likewise.
1444 (ctf_type_encoding): Likewise.
1445 (ctf_member_info): Likewise.
1446 (ctf_array_info): Likewise.
1447 (ctf_enum_value): Likewise.
1448 (ctf_type_rvisit): Likewise.
1449 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1451 (ctf_simple_open): Likewise.
1452 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1453 * Makefile.in: Regenerate.
1454 * aclocal.m4: Likewise.
1455 * config.h: Likewise.
1456 * configure: Likewise.
1458 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1460 * configure.in: Check for bfd_section_from_elf_index.
1461 * configure: Regenerate.
1462 * config.h.in [HAVE_BFD_ELF]: Likewise.
1463 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1464 abfd is potentially unused now.
1466 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1469 * Makefile.in: Regenerated.
1470 * config.h.in: Likewise.
1471 * aclocal.m4: Likewise.
1472 * configure: Likewise.
1474 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1478 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1480 * ctf-labels.c: New.
1482 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1484 * ctf-impl.h (_libctf_version): New declaration.
1485 * ctf-subr.c (_libctf_version): Define it.
1488 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1490 * ctf-create.c (enumcmp): New.
1491 (enumadd): Likewise.
1492 (membcmp): Likewise.
1493 (membadd): Likewise.
1494 (ctf_add_type): Likewise.
1496 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1498 * ctf-lookup.c (isqualifier): New.
1499 (ctf_lookup_by_name): Likewise.
1500 (struct ctf_lookup_var_key): Likewise.
1501 (ctf_lookup_var): Likewise.
1502 (ctf_lookup_variable): Likewise.
1503 (ctf_lookup_symbol_name): Likewise.
1504 (ctf_lookup_by_symbol): Likewise.
1505 (ctf_func_info): Likewise.
1506 (ctf_func_args): Likewise.
1508 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1510 * ctf-decl.c: New file.
1511 * ctf-types.c: Likewise.
1512 * ctf-impl.h: New declarations.
1514 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1516 * ctf-open-bfd.c: New file.
1517 * ctf-open.c (ctf_close): New.
1518 * ctf-impl.h: Include bfd.h.
1519 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1520 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1522 (ctf_bfdopen_ctfsect): New declaration.
1523 (_CTF_SECTION): likewise.
1525 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1527 * ctf-archive.c: New.
1528 * ctf-impl.h (ctf_archive_internal): New type.
1529 (ctf_arc_open_internal): New declaration.
1530 (ctf_arc_bufopen): Likewise.
1531 (ctf_arc_close_internal): Likewise.
1533 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1535 * ctf-open.c: New file.
1538 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1540 * ctf-create.c: New file.
1541 * ctf-lookup.c: New file.
1543 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1545 * ctf-impl.h: New definitions and declarations for type creation
1548 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1550 * ctf-hash.c: New file.
1551 * ctf-impl.h: New declarations.
1553 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1555 * ctf-error.c: New file.
1557 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1559 * ctf-util.c: New file.
1561 * ctf-impl.h: Include it, and add declarations.
1563 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1565 * ctf-impl.h: New file.
1566 * ctf-subr.c: New file.
1573 version-control: never