1 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
3 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
5 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
7 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
8 * ctf-types.c (ctf_type_lname): Likewise.
10 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
12 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
13 ctf_import after the first for a given file.
15 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
17 * ctf-impl.h (ctf_str_append_noerr): Declare.
18 * ctf-util.c (ctf_str_append_noerr): Define in terms of
20 * ctf-dump.c (str_append): New, call it.
21 (ctf_dump_format_type): Use str_append, not ctf_str_append.
22 (ctf_dump_label): Likewise.
23 (ctf_dump_objts): Likewise.
24 (ctf_dump_funcs): Likewise.
25 (ctf_dump_var): Likewise.
26 (ctf_dump_member): Likewise.
27 (ctf_dump_type): Likewise.
30 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
32 * ctf-impl.h (ctf_alloc): Remove.
34 (ctf_strdup): Likewise.
35 * ctf-subr.c (ctf_alloc): Remove.
37 * ctf-util.c (ctf_strdup): Remove.
39 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
40 ctf_free; strdup, not ctf_strdup.
41 (ctf_dtd_delete): Likewise.
42 (ctf_dvd_delete): Likewise.
43 (ctf_add_generic): Likewise.
44 (ctf_add_function): Likewise.
45 (ctf_add_enumerator): Likewise.
46 (ctf_add_member_offset): Likewise.
47 (ctf_add_variable): Likewise.
49 (ctf_compress_write): Likewise.
50 (ctf_write_mem): Likewise.
51 * ctf-decl.c (ctf_decl_push): Likewise.
52 (ctf_decl_fini): Likewise.
53 (ctf_decl_sprintf): Likewise. Check for OOM.
54 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
55 ctf_free; strdup, not ctf_strdup.
56 (ctf_dump_free): Likewise.
58 * ctf-open.c (upgrade_types_v1): Likewise.
59 (init_types): Likewise.
60 (ctf_file_close): Likewise.
61 (ctf_bufopen_internal): Likewise. Check for OOM.
62 (ctf_parent_name_set): Likewise: report the OOM to the caller.
63 (ctf_cuname_set): Likewise.
64 (ctf_import): Likewise.
65 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
66 free, not ctf_free; strdup, not ctf_strdup.
67 (ctf_str_free_atom): Likewise.
68 (ctf_str_create_atoms): Likewise.
69 (ctf_str_add_ref_internal): Likewise.
70 (ctf_str_remove_ref): Likewise.
71 (ctf_str_write_strtab): Likewise.
73 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
75 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
76 work right for non-int/fps.
78 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
80 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
83 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
85 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
86 * ctf-open.c (ctf_file_close): Free it.
87 * ctf-create.c (ctf_serialize): Adjust.
88 (membcmp): When reporting a conflict due to an error, report the
90 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
91 (ctf_add_type_internal): ... this. Hand back types we are already
92 in the middle of adding immediately. Hand back structs/unions with
93 the same number of members immediately. Do not walk the dynamic
94 list. Call ctf_add_type_internal, not ctf_add_type. Handle
95 forwards promoted to other types and the inverse case identically.
96 Add structs to the mapping as soon as we intern them, before they
99 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
101 * ctf-impl.h (ctf_names_t): New.
102 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
103 (ctf_file_t) <ctf_structs>: Likewise.
104 <ctf_unions>: Likewise.
105 <ctf_enums>: Likewise.
106 <ctf_names>: Likewise.
107 <ctf_lookups>: Improve comment.
108 <ctf_ptrtab_len>: New.
109 <ctf_prov_strtab>: New.
110 <ctf_str_prov_offset>: New.
111 <ctf_dtbyname>: Remove, redundant to the names hashes.
112 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
113 (ctf_dtdef_t) <dtd_name>: Remove.
114 <dtd_data>: Note that the ctt_name is now populated.
115 (ctf_str_atom_t) <csa_offset>: This is now the strtab
116 offset for internal strings too.
117 <csa_external_offset>: New, the external strtab offset.
118 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
119 (ctf_name_table): New declaration.
120 (ctf_lookup_by_rawname): Likewise.
121 (ctf_lookup_by_rawhash): Likewise.
122 (ctf_set_ctl_hashes): Likewise.
123 (ctf_serialize): Likewise.
124 (ctf_dtd_insert): Adjust.
125 (ctf_simple_open_internal): Likewise.
126 (ctf_bufopen_internal): Likewise.
127 (ctf_list_empty_p): Likewise.
128 (ctf_str_remove_ref): Likewise.
129 (ctf_str_add): Returns uint32_t now.
130 (ctf_str_add_ref): Likewise.
131 (ctf_str_add_external): Now returns a boolean (int).
132 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
133 for strings in the appropriate range.
134 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
135 when adding the null string to the new strtab.
136 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
137 (ctf_str_add_ref_internal): Add make_provisional argument. If
138 make_provisional, populate the offset and fill in the
139 ctf_prov_strtab accordingly.
140 (ctf_str_add): Return the offset, not the string.
141 (ctf_str_add_ref): Likewise.
142 (ctf_str_add_external): Return a success integer.
143 (ctf_str_remove_ref): New, remove a single ref.
144 (ctf_str_count_strtab): Do not count the initial null string's
145 length or the existence or length of any unreferenced internal
147 (ctf_str_populate_sorttab): Skip atoms with no refs.
148 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
149 to the cts_len for the null string, since it is no longer done
150 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
151 Populate the csa_offset for both internal and external cases.
152 Flush the ctf_prov_strtab afterwards, and reset the
154 * ctf-create.c (ctf_grow_ptrtab): New.
155 (ctf_create): Call it. Initialize new fields rather than old
156 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
157 Set the ctl hashes and data model.
158 (ctf_update): Rename to...
159 (ctf_serialize): ... this. Leave a compatibility function behind.
160 Tell ctf_simple_open_internal that this is a writable dictionary.
161 Pass the new fields along from the old dictionary. Drop
162 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
163 Do not zero out the DTD's ctt_name.
164 (ctf_prefixed_name): Rename to...
165 (ctf_name_table): ... this. No longer return a prefixed name: return
166 the applicable name table instead.
167 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
168 kind we're adding. Migrate away from dtd_name.
169 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
171 (ctf_dtd_lookup_type_by_name): Remove.
172 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
173 No longer check ctf_dtnextid: check ctf_typemax instead.
174 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
175 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
176 ctf_name_table and the right name table, and migrate away from
177 dtd_name as in ctf_dtd_delete.
178 (ctf_add_generic): Pass in the kind explicitly and pass it to
179 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
180 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
181 Grow the ptrtab if needed.
182 (ctf_add_encoded): Pass in the kind.
183 (ctf_add_slice): Likewise.
184 (ctf_add_array): Likewise.
185 (ctf_add_function): Likewise.
186 (ctf_add_typedef): Likewise.
187 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
188 ctt_name rather than dtd_name.
189 (ctf_add_struct_sized): Pass in the kind. Use
190 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
191 ctf_dtd_lookup_type_by_name.
192 (ctf_add_union_sized): Likewise.
193 (ctf_add_enum): Likewise.
194 (ctf_add_enum_encoded): Likewise.
195 (ctf_add_forward): Likewise.
196 (ctf_add_type): Likewise.
197 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
198 being initialized until after the call.
199 (ctf_write_mem): Likewise.
200 (ctf_write): Likewise.
201 * ctf-archive.c (arc_write_one_ctf): Likewise.
202 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
203 ctf_hash_lookup_type.
204 (ctf_lookup_by_id): No longer check the readonly types if the
205 dictionary is writable.
206 * ctf-open.c (init_types): Assert that this dictionary is not
207 writable. Adjust to use the new name hashes, ctf_name_table,
208 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
209 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
210 if set. Drop out early when dictionary is writable. Split the
211 ctf_lookups initialization into...
212 (ctf_set_cth_hashes): ... this new function.
213 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
214 (ctf_simple_open): Adjust accordingly.
215 (ctf_bufopen): Likewise.
216 (ctf_file_close): Destroy the appropriate name hashes. No longer
217 destroy ctf_dtbyname, which is gone.
218 (ctf_getdatasect): Remove spurious "extern".
219 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
220 specified name table, given a kind.
221 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
222 (ctf_member_iter): Add support for iterating over the
224 (ctf_enum_iter): Likewise.
225 (ctf_variable_iter): Likewise.
226 (ctf_type_rvisit): Likewise.
227 (ctf_member_info): Add support for types in the dynamic type list.
228 (ctf_enum_name): Likewise.
229 (ctf_enum_value): Likewise.
230 (ctf_func_type_info): Likewise.
231 (ctf_func_type_args): Likewise.
232 * ctf-link.c (ctf_accumulate_archive_names): No longer call
234 (ctf_link_write): Likewise.
235 (ctf_link_intern_extern_string): Adjust for new
236 ctf_str_add_external return value.
237 (ctf_link_add_strtab): Likewise.
238 * ctf-util.c (ctf_list_empty_p): New.
240 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
242 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
244 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
246 (ctf_add_variable): Likewise for variables pointing to them.
247 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
248 type link failure, but do warn for others.
249 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
251 (ctf_dump_member): Likewise.
252 (ctf_dump_type): Likewise.
253 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
254 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
255 (ctf_dump_header): Likewise.
256 (ctf_dump_label): likewise.
257 (ctf_dump_objts): likewise.
258 (ctf_dump_funcs): likewise.
259 (ctf_dump_var): likewise.
260 (ctf_dump_str): Likewise.
262 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
264 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
266 (AM_INSTALL_LIBBFD): Likewise.
267 (dlopen): Note why this is necessary in a comment.
268 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
270 (SHARED_LDFLAGS): Likewise.
271 (BFD_LIBADD): Likewise, for libbfd.
272 (BFD_DEPENDENCIES): Likewise.
273 (VERSION_FLAGS): Initialize, using a version script if ld supports
274 one, or libtool -export-symbols-regex otherwise.
275 (AC_CONFIG_MACRO_DIR): Add ../BFD.
276 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
278 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
279 (noinst_LIBRARIES): Replace with...
280 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
281 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
282 libctf-nobfd.la as well.
283 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
284 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
285 (libctf_a_SOURCES): Rename to...
286 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
288 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
289 with ctf-open-bfd.c added.
290 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
291 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
292 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
293 * Makefile.am [INSTALL_LIBCTF]: Use it.
294 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
296 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
297 the unstable components).
298 * Makefile.in: Regenerated.
299 * config.h.in: Likewise.
300 * configure: Likewise.
302 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
304 * configure.ac (INSTALL_LIBCTF): New, controlled by
305 --enable-install-libctf.
306 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
307 * Makefile.in: Regenerated.
308 * configure: Regenerated.
310 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
312 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
313 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
315 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
317 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
319 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
321 * ctf-impl.h (includes): Include <sys/param.h> here.
323 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
325 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
326 (flip_objts): Likewise.
327 (flip_vars): Likewise.
328 (flip_types): Likewise.
330 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
332 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
333 freeing functions: if set, free the key and value if the slot
334 already exists. Always reassign the key.
335 (ctf_dynhash_insert): Adjust call appropriately.
336 (ctf_hash_insert_type): Likewise.
338 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
340 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
341 type kind. Allow forwards to unify with pre-existing structs/
344 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
346 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
347 <ctf_link_memb_name_changer>: Likewise.
348 <ctf_link_memb_name_changer_arg>: Likewise.
349 * ctf-create.c (ctf_update): Update accordingly.
350 * ctf-open.c (ctf_file_close): Likewise.
351 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
352 (ctf_link_add_cu_mapping): New.
353 (ctf_link_set_memb_name_changer): Likewise.
354 (ctf_change_parent_name): New.
355 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
356 allocated by the caller's ctf_link_memb_name_changer.
357 <ndynames>: Likewise.
358 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
359 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
360 ctf_change_parent_name. Free any resulting names.
362 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
364 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
365 (ctf_link_one_type): ... here, with parent-name setting added.
366 (check_variable): New.
367 (ctf_link_one_variable): Likewise.
368 (ctf_link_one_input_archive_member): Call it.
369 * ctf-error.c (_ctf_errlist): Updated with new errors.
371 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
373 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
374 (struct ctf_link_type_mapping_key): New.
375 (ctf_hash_type_mapping_key): Likewise.
376 (ctf_hash_eq_type_mapping_key): Likewise.
377 (ctf_add_type_mapping): Likewise.
378 (ctf_type_mapping): Likewise.
379 (ctf_dynhash_empty): Likewise.
380 * ctf-open.c (ctf_file_close): Update accordingly.
381 * ctf-create.c (ctf_update): Likewise.
382 (ctf_add_type): Populate the mapping.
383 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
384 (ctf_hash_eq_type_mapping_key): Check the key for equality.
385 (ctf_dynhash_insert): Fix comment typo.
386 (ctf_dynhash_empty): New.
387 * ctf-link.c (ctf_add_type_mapping): New.
388 (ctf_type_mapping): Likewise.
389 (empty_link_type_mapping): New.
390 (ctf_link_one_input_archive): Call it.
392 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
394 * ctf-link.c: New file, linking of the string and type sections.
395 * Makefile.am (libctf_a_SOURCES): Add it.
396 * Makefile.in: Regenerate.
398 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
400 * ctf-create.c (ctf_update): Update accordingly.
401 * ctf-open.c (ctf_file_close): Likewise.
402 * ctf-error.c (_ctf_errlist): Updated with new errors.
404 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
406 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
408 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
410 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
412 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
413 (ctf_dump_format_type): Add non-root-type { } notation.
414 Add root flag to prototype.
415 (ctf_dump_label): Adjust accordingly.
416 (ctf_dump_objts): Likewise.
417 (ctf_dump_var): Likewise.
419 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
421 * ctf-create.c (ctf_compress_write): Fix double-free.
423 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
425 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
427 (ctf_arc_write_fd): ... this new function.
428 * ctf-create.c (ctf_write_mem): New.
430 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
432 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
433 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
434 (ctf_str_add_ref): Name the last arg.
435 (ctf_str_add_external) New.
436 (ctf_str_add_strraw_explicit): Likewise.
437 (ctf_simple_open_internal): Likewise.
438 (ctf_bufopen_internal): Likewise.
440 * ctf-string.c (ctf_strraw_explicit): Split from...
441 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
442 (ctf_str_add_ref_internal): Return the atom, not the
444 (ctf_str_add): Adjust accordingly.
445 (ctf_str_add_ref): Likewise. Move up in the file.
446 (ctf_str_add_external): New: update the csa_offset.
447 (ctf_str_count_strtab): Only account for strings with no csa_offset
448 in the internal strtab length.
449 (ctf_str_write_strtab): If the csa_offset is set, update the
450 string's refs without writing the string out, and update the
451 ctf_syn_ext_strtab. Make OOM handling less ugly.
452 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
453 (ctf_update): Handle failure to populate the strtab. Pass in the
454 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
455 Call ctf_simple_open_internal, not ctf_simple_open.
456 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
458 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
459 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
460 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
461 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
462 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
463 (ctf_simple_open_internal): ... this new function, which calls
464 ctf_bufopen_internal.
465 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
466 (ctf_bufopen_internal): ... this new function, which sets
469 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
471 * ctf_types.c (ctf_type_iter_all): New.
473 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
475 * ctf-open.c (init_symtab): Check for overflow against the right
477 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
478 (upgrade_types_v1): Note that these sections are not checked.
479 (flip_header): Endian-swap the header fields.
480 (flip_ctf): Endian-swap the sections.
481 (flip_objts): Update comment.
482 (ctf_bufopen): Check header offsets and alignment for validity.
484 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
486 * ctf-open-bfd.c: Add <assert.h>.
487 (ctf_bfdopen_ctfsect): Open string and symbol tables using
488 techniques borrowed from bfd_elf_sym_name.
489 (ctf_new_archive_internal): Improve comment.
490 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
491 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
492 no symbol section, but not vice versa.
494 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
496 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
497 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
498 * ctf-dump.c (dump_header): New function, dump the CTF header.
500 (ctf_dump_header_strfield): New function.
501 (ctf_dump_header_sectfield): Likewise.
503 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
505 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
506 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
507 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
508 ctf_base: do not assume that it is always sizeof (ctf_header_t).
509 Print out ctf_cuname: only print out ctf_parname if set.
510 (ctf_free_base): Removed, ctf_base is no longer freed: free
512 (ctf_set_version): Fix spacing.
513 (upgrade_header): New, in-place header upgrading.
514 (upgrade_types): Rename to...
515 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
516 longer track old and new headers separately. No longer allow for
517 header sizes explicitly: squeeze the headers out on upgrade (they
518 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
519 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
520 (upgrade_types): New, also handle ctf_parmax updating.
521 (flip_header): Flip ctf_cuname.
522 (flip_types): Flip BUF explicitly rather than deriving BUF from
524 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
525 required alignment of objtoff and funcoff. No longer store it in
526 the ctf_buf unless that buf is derived unmodified from the input.
527 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
528 that duplicate fields in ctf_file: move allocation of ctf_file
529 further up instead. Call upgrade_header as needed. Move
530 version-specific ctf_parmax initialization into upgrade_types. More
531 concise error handling.
532 (ctf_file_close): No longer test for null pointers before freeing.
533 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
536 (ctf_cuname_set): New.
537 * ctf-create.c (ctf_update): Populate ctf_cuname.
538 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
540 (ctf_write): Likewise.
541 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
542 Fix the compression length: fp->ctf_size never counted the CTF
543 header. Simplify the compress call accordingly.
545 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
547 * ctf-endian.h: Don't assume htole64 and le64toh are always
548 present if HAVE_ENDIAN_H; also check if htole64 is defined.
549 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
550 not bswap_identity_64.
552 2019-09-18 Alan Modra <amodra@gmail.com>
554 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
556 2019-09-09 Phil Blundell <pb@pbcl.net>
558 binutils 2.33 branch created.
560 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
562 * ctf-types.c (ctf_type_aname_raw): New.
563 (ctf_func_type_info): Likewise.
564 (ctf_func_type_args): Likewise.
565 * ctf-error.c (_ctf_errlist): Fix description.
566 * ctf-lookup.c: Fix file description.
568 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
570 * ctf-create.c (ctf_create): Fix off-by-one error.
572 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
574 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
576 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
577 (struct ctf_str_atom): New, disambiguated single string.
578 (struct ctf_str_atom_ref): New, points to some other location that
579 references this string's offset.
580 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
581 Remove member ctf_dtvstrlen: we no longer track the total strlen
583 (ctf_str_create_atoms): Declare new function in ctf-string.c.
584 (ctf_str_free_atoms): Likewise.
585 (ctf_str_add): Likewise.
586 (ctf_str_add_ref): Likewise.
587 (ctf_str_rollback): Likewise.
588 (ctf_str_purge_refs): Likewise.
589 (ctf_str_write_strtab): Likewise.
590 (ctf_realloc): Declare new function in ctf-util.c.
592 * ctf-open.c (ctf_bufopen): Create the atoms table.
593 (ctf_file_close): Destroy it.
594 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
595 special-case the position of the parname string. Construct the
596 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
597 rest of each buffer element is constructed, not via open-coding:
598 realloc the CTF buffer and append the strtab to it. No longer
599 maintain ctf_dtvstrlen. Sort the variable entry table later, after
601 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
602 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
603 after buffer element construction instead.
604 (ctf_copy_lmembers): Likewise.
605 (ctf_copy_emembers): Likewise.
606 (ctf_create): No longer maintain the ctf_dtvstrlen.
607 (ctf_dtd_delete): Likewise.
608 (ctf_dvd_delete): Likewise.
609 (ctf_add_generic): Likewise.
610 (ctf_add_enumerator): Likewise.
611 (ctf_add_member_offset): Likewise.
612 (ctf_add_variable): Likewise.
614 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
615 if there are active ctf_str_num_refs.
616 (ctf_strraw): Move to ctf-string.c.
617 (ctf_strptr): Likewise.
618 * ctf-string.c: New file, strtab manipulation.
620 * Makefile.am (libctf_a_SOURCES): Add it.
621 * Makefile.in: Regenerate.
623 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
625 * ctf-impl.h (ctf_hash_iter_f): New.
626 (ctf_dynhash_iter): New declaration.
627 (ctf_dynhash_iter_remove): New declaration.
628 * ctf-hash.c (ctf_dynhash_iter): Define.
629 (ctf_dynhash_iter_remove): Likewise.
630 (ctf_hashtab_traverse): New.
631 (ctf_hashtab_traverse_remove): Likewise.
632 (struct ctf_traverse_cb_arg): Likewise.
633 (struct ctf_traverse_remove_cb_arg): Likewise.
635 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
637 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
639 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
641 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
642 (ctf_dump_funcs): Likewise.
644 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
646 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
647 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
648 little-endian CTF archive magic. Do not check the CTF version:
649 ctf_simple_open does that in endian-safe ways. Do not dereference
650 null pointers on open failure.
652 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
654 * ctf-open.c (get_vbytes_common): Return the new slice size.
655 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
656 Remember to copy in the CTF data when opening an uncompressed
657 foreign-endian CTF file. Prune useless variable manipulation.
659 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
661 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
664 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
666 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
669 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
671 * ctf-subr.c (_PAGESIZE): Remove.
672 (ctf_data_alloc): Likewise.
673 (ctf_data_free): Likewise.
674 (ctf_data_protect): Likewise.
675 * ctf-impl.h: Remove declarations.
676 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
677 ctf_free, not ctf_data_free.
678 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
679 the buffer again on compression error.
680 * ctf-open.c (ctf_set_base): No longer track the size: call
681 ctf_free, not ctf_data_free.
682 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
683 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
685 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
687 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
689 (ctf_dvd_insert): Likewise.
690 (ctf_add_generic): Likewise.
691 (ctf_add_variable): Likewise.
692 * ctf-impl.h: Adjust declarations.
694 2019-06-14 Alan Modra <amodra@gmail.com>
696 * configure: Regenerate.
698 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
700 * ctf-decls.h: Include <libiberty.h>.
701 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
703 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
705 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
706 (ctf_dump_objts): Likewise.
707 (ctf_dump_funcs): Likewise.
708 (ctf_dump_member): Likewise.
709 (ctf_dump_str): Likewise.
711 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
713 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
714 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
716 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
718 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
719 (ctf_arc_open_by_offset): Likewise.
720 * ctf-create.c (ctf_add_type): Likewise.
722 2019-06-04 Tom Tromey <tromey@adacore.com>
724 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
725 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
727 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
729 * configure.ac: Check for O_CLOEXEC.
730 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
731 * config.h.in: Regenerate.
732 * configure: Likewise.
734 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
736 * qsort_r.c: Rename to...
737 * ctf-qsort_r.c: ... this.
738 (_quicksort): Define to ctf_qsort_r.
739 * ctf-decls.h (qsort_r): Remove.
741 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
742 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
743 * Makefile.am (libctf_a_LIBADD): Remove.
744 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
745 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
746 * ctf-create.c (ctf_update): Likewise.
747 * configure.ac: Check for BSD versus GNU qsort_r signature.
748 * Makefile.in: Regenerate.
749 * config.h.in: Likewise.
750 * configure: Likewise.
752 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
754 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
756 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
758 * Makefile.am (ZLIB): New.
760 (AM_CFLAGS): Use them.
761 (libctf_a_LIBADD): New, for LIBOBJS.
762 * configure.ac: Check for zlib, endian.h, and qsort_r.
763 * ctf-endian.h: New, providing htole64 and le64toh.
764 * swap.h: Code style fixes.
765 (bswap_identity_64): New.
766 * qsort_r.c: New, from gnulib (with one added #include).
767 * ctf-decls.h: New, providing a conditional qsort_r declaration,
768 and unconditional definitions of MIN and MAX.
769 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
770 (ctf_set_errno): Now returns unsigned long.
771 * ctf-util.c (ctf_set_errno): Adjust here too.
772 * ctf-archive.c: Use ctf-endian.h.
773 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
774 cts_flags and cts_offset.
775 (ctf_arc_write): Drop debugging dependent on the size of off_t.
776 * ctf-create.c: Provide a definition of roundup if not defined.
777 (ctf_create): Drop cts_type, cts_flags and cts_offset.
778 (ctf_add_reftype): Do not check if type IDs are below zero.
779 (ctf_add_slice): Likewise.
780 (ctf_add_typedef): Likewise.
781 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
782 when known error-free. Drop CTF_ERR usage for functions returning
784 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
786 (ctf_add_variable): Likewise.
790 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
791 when known error-free.
792 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
793 returning int: use CTF_ERR for functions returning ctf_type_id.
794 (ctf_dump_label): Likewise.
795 (ctf_dump_objts): Likewise.
796 * ctf-labels.c (ctf_label_topmost): Likewise.
797 (ctf_label_iter): Likewise.
798 (ctf_label_info): Likewise.
799 * ctf-lookup.c (ctf_func_args): Likewise.
800 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
801 (ctf_bufopen): Likewise. Use zlib types as needed.
802 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
804 (ctf_enum_iter): Likewise.
805 (ctf_type_size): Likewise.
806 (ctf_type_align): Likewise. Cast to size_t where appropriate.
807 (ctf_type_kind_unsliced): Likewise.
808 (ctf_type_kind): Likewise.
809 (ctf_type_encoding): Likewise.
810 (ctf_member_info): Likewise.
811 (ctf_array_info): Likewise.
812 (ctf_enum_value): Likewise.
813 (ctf_type_rvisit): Likewise.
814 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
816 (ctf_simple_open): Likewise.
817 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
818 * Makefile.in: Regenerate.
819 * aclocal.m4: Likewise.
820 * config.h: Likewise.
821 * configure: Likewise.
823 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
825 * configure.in: Check for bfd_section_from_elf_index.
826 * configure: Regenerate.
827 * config.h.in [HAVE_BFD_ELF]: Likewise.
828 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
829 abfd is potentially unused now.
831 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
834 * Makefile.in: Regenerated.
835 * config.h.in: Likewise.
836 * aclocal.m4: Likewise.
837 * configure: Likewise.
839 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
843 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
847 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
849 * ctf-impl.h (_libctf_version): New declaration.
850 * ctf-subr.c (_libctf_version): Define it.
853 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
855 * ctf-create.c (enumcmp): New.
859 (ctf_add_type): Likewise.
861 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
863 * ctf-lookup.c (isqualifier): New.
864 (ctf_lookup_by_name): Likewise.
865 (struct ctf_lookup_var_key): Likewise.
866 (ctf_lookup_var): Likewise.
867 (ctf_lookup_variable): Likewise.
868 (ctf_lookup_symbol_name): Likewise.
869 (ctf_lookup_by_symbol): Likewise.
870 (ctf_func_info): Likewise.
871 (ctf_func_args): Likewise.
873 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
875 * ctf-decl.c: New file.
876 * ctf-types.c: Likewise.
877 * ctf-impl.h: New declarations.
879 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
881 * ctf-open-bfd.c: New file.
882 * ctf-open.c (ctf_close): New.
883 * ctf-impl.h: Include bfd.h.
884 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
885 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
887 (ctf_bfdopen_ctfsect): New declaration.
888 (_CTF_SECTION): likewise.
890 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
892 * ctf-archive.c: New.
893 * ctf-impl.h (ctf_archive_internal): New type.
894 (ctf_arc_open_internal): New declaration.
895 (ctf_arc_bufopen): Likewise.
896 (ctf_arc_close_internal): Likewise.
898 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
900 * ctf-open.c: New file.
903 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
905 * ctf-create.c: New file.
906 * ctf-lookup.c: New file.
908 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
910 * ctf-impl.h: New definitions and declarations for type creation
913 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
915 * ctf-hash.c: New file.
916 * ctf-impl.h: New declarations.
918 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
920 * ctf-error.c: New file.
922 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
924 * ctf-util.c: New file.
926 * ctf-impl.h: Include it, and add declarations.
928 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
930 * ctf-impl.h: New file.
931 * ctf-subr.c: New file.
938 version-control: never