1 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
3 * ctf-create.c (ctf_dtd_insert): Set ENOMEM on the dict if out of memory.
4 (ctf_dvd_insert): Likewise.
5 (ctf_add_function): Report ECTF_RDONLY if this dict is not writable.
6 * ctf-subr.c (ctf_err_warn): Only debug-dump passed-in warnings if
7 the passed-in error code is nonzero: the error on the dict for
8 warnings may relate to a previous error.
10 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
12 * ctf-open.c (ctf_getsymsect): New.
13 (ctf_getstrsect): Likewise.
14 * libctf.ver: Add them.
16 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
18 * ctf-impl.h (struct ctf_archive_internal) <ctfi_dicts>: New, dicts
19 the archive machinery has opened and cached.
20 <ctfi_symdicts>: New, cache of dicts containing symbols looked up.
21 <ctfi_syms>: New, cache of types of symbols looked up.
22 * ctf-archive.c (ctf_arc_close): Free them on close.
23 (enosym): New, flag entry for 'symbol not present'.
24 (ctf_arc_import_parent): New, automatically import the parent from
25 ".ctf" if this is a child in an archive and ".ctf" is present.
26 (ctf_dict_open_sections): Use it.
27 (ctf_archive_iter_internal): Likewise.
28 (ctf_cached_dict_close): New, thunk around ctf_dict_close.
29 (ctf_dict_open_cached): New, open and cache a dict.
30 (ctf_arc_flush_caches): New, flush the caches.
31 (ctf_arc_lookup_symbol): New, look up a symbol in (all members of)
32 an archive, and cache the lookup.
33 (ctf_archive_iter): Note the new caching behaviour.
34 (ctf_archive_next): Use ctf_dict_open_cached.
35 * libctf.ver: Add ctf_arc_lookup_symbol and ctf_arc_flush_caches.
37 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
39 * ctf-dedup.c (ctf_dedup_rhash_type): Null out the names of nameless
40 type kinds, just in case the input has named them.
42 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
44 * ctf-dump.c (ctf_dump_header): Dump the new flags bits and the index
46 (ctf_dump_objts): Report indexed sections. Also dump functions. Use
47 ctf_symbol_next, not manual looping.
48 (ctf_dump_funcs): Delete.
49 (ctf_dump): Use ctf_dump_objts, not ctf_dump_funcs.
51 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
53 * ctf-impl.h (CTF_INDEX_PAD_THRESHOLD): New.
54 (_libctf_nonnull_): Likewise.
55 (ctf_in_flight_dynsym_t): New.
56 (ctf_dict_t) <ctf_funcidx_names>: Likewise.
57 <ctf_objtidx_names>: Likewise.
58 <ctf_nfuncidx>: Likewise.
59 <ctf_nobjtidx>: Likewise.
60 <ctf_funcidx_sxlate>: Likewise.
61 <ctf_objtidx_sxlate>: Likewise.
62 <ctf_objthash>: Likewise.
63 <ctf_funchash>: Likewise.
64 <ctf_dynsyms>: Likewise.
65 <ctf_dynsymidx>: Likewise.
66 <ctf_dynsymmax>: Likewise.
67 <ctf_in_flight_dynsym>: Likewise.
68 (struct ctf_next) <u.ctn_next>: Likewise.
69 (ctf_symtab_skippable): New prototype.
70 (ctf_add_funcobjt_sym): Likewise.
71 (ctf_dynhash_sort_by_name): Likewise.
72 (ctf_sym_to_elf64): Rename to...
73 (ctf_elf32_to_link_sym): ... this, and...
74 (ctf_elf64_to_link_sym): ... this.
75 * ctf-open.c (init_symtab): Check for lack of CTF_F_NEWFUNCINFO
76 flag, and presence of index sections. Refactor out
77 ctf_symtab_skippable and ctf_elf*_to_link_sym, and use them. Use
78 ctf_link_sym_t, not Elf64_Sym. Skip initializing objt or func
79 sxlate sections if corresponding index section is present. Adjust
80 for new func info section format.
81 (ctf_bufopen_internal): Add ctf_err_warn to corrupt-file error
82 handling. Report incorrect-length index sections. Always do an
83 init_symtab, even if there is no symtab section (there may be index
85 (flip_objts): Adjust comment: func and objt sections are actually
86 identical in structure now, no need to caveat.
87 (ctf_dict_close): Free newly-added data structures.
88 * ctf-create.c (ctf_create): Initialize them.
89 (ctf_symtab_skippable): New, refactored out of
90 init_symtab, with st_nameidx_set check added.
91 (ctf_add_funcobjt_sym): New, add a function or object symbol to the
92 ctf_objthash or ctf_funchash, by name.
93 (ctf_add_objt_sym): Call it.
94 (ctf_add_func_sym): Likewise.
95 (symtypetab_delete_nonstatic_vars): New, delete vars also present as
97 (CTF_SYMTYPETAB_EMIT_FUNCTION): New flag to symtypetab emitters:
98 this is a function emission, not a data object emission.
99 (CTF_SYMTYPETAB_EMIT_PAD): New flag to symtypetab emitters: emit
100 pads for symbols with no type (only set for unindexed sections).
101 (CTF_SYMTYPETAB_FORCE_INDEXED): New flag to symtypetab emitters:
103 (symtypetab_density): New, figure out section sizes.
104 (emit_symtypetab): New, emit a symtypetab.
105 (emit_symtypetab_index): New, emit a symtypetab index.
106 (ctf_serialize): Call them, emitting suitably sorted symtypetab
107 sections and indexes. Set suitable header flags. Copy over new
109 * ctf-hash.c (ctf_dynhash_sort_by_name): New, used to impose an
110 order on symtypetab index sections.
111 * ctf-link.c (ctf_add_type_mapping): Delete erroneous comment
112 relating to code that was never committed.
113 (ctf_link_one_variable): Improve variable name.
114 (check_sym): New, symtypetab analogue of check_variable.
115 (ctf_link_deduplicating_one_symtypetab): New.
116 (ctf_link_deduplicating_syms): Likewise.
117 (ctf_link_deduplicating): Call them.
118 (ctf_link_deduplicating_per_cu): Note that we don't call them in
120 (ctf_link_add_strtab): Set the error on the fp correctly.
121 (ctf_link_add_linker_symbol): New (no longer a do-nothing stub), add
122 a linker symbol to the in-flight list.
123 (ctf_link_shuffle_syms): New (no longer a do-nothing stub), turn the
124 in-flight list into a mapping we can use, now its names are
125 resolvable in the external strtab.
126 * ctf-string.c (ctf_str_rollback_atom): Don't roll back atoms with
127 external strtab offsets.
128 (ctf_str_rollback): Adjust comment.
129 (ctf_str_write_strtab): Migrate ctf_syn_ext_strtab population from
131 (ctf_str_add_external): ... to string addition time.
132 * ctf-lookup.c (ctf_lookup_var_key_t): Rename to...
133 (ctf_lookup_idx_key_t): ... this, now we use it for syms too.
134 <clik_names>: New member, a name table.
135 (ctf_lookup_var): Adjust accordingly.
136 (ctf_lookup_variable): Likewise.
137 (ctf_lookup_by_id): Shuffle further up in the file.
138 (ctf_symidx_sort_arg_cb): New, callback for...
139 (sort_symidx_by_name): ... this new function to sort a symidx
140 found to be unsorted (likely originating from the compiler).
141 (ctf_symidx_sort): New, sort a symidx.
142 (ctf_lookup_symbol_name): Support dynamic symbols with indexes
143 provided by the linker. Use ctf_link_sym_t, not Elf64_Sym.
144 Check the parent if a child lookup fails.
145 (ctf_lookup_by_symbol): Likewise. Work for function symbols too.
146 (ctf_symbol_next): New, iterate over symbols with types (without
148 (ctf_lookup_idx_name): New, bsearch for symbol names in indexes.
149 (ctf_try_lookup_indexed): New, attempt an indexed lookup.
150 (ctf_func_info): Reimplement in terms of ctf_lookup_by_symbol.
151 (ctf_func_args): Likewise.
152 (ctf_get_dict): Move...
153 * ctf-types.c (ctf_get_dict): ... here.
154 * ctf-util.c (ctf_sym_to_elf64): Re-express as...
155 (ctf_elf64_to_link_sym): ... this. Add new st_symidx field, and
156 st_nameidx_set (always 0, so st_nameidx can be ignored). Look in
157 the ELF strtab for names.
158 (ctf_elf32_to_link_sym): Likewise, for Elf32_Sym.
159 (ctf_next_destroy): Destroy ctf_next_t.u.ctn_next if need be.
160 * libctf.ver: Add ctf_symbol_next, ctf_add_objt_sym and
163 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
165 * ctf-link.c (ctf_link_shuffle_syms): Adjust.
166 (ctf_link_add_linker_symbol): New, unimplemented stub.
167 * libctf.ver: Add it.
168 * ctf-create.c (ctf_serialize): Set CTF_F_DYNSTR on newly-serialized
170 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Check for the flag: open the
171 symtab/strtab if not present, dynsym/dynstr otherwise.
172 * ctf-archive.c (ctf_arc_bufpreamble): New, get the preamble from
173 some arbitrary member of a CTF archive.
174 * ctf-impl.h (ctf_arc_bufpreamble): Declare it.
176 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
178 * ctf-archive.c (ctf_arc_open_by_offset): Rename to...
179 (ctf_dict_open_by_offset): ... this. Adjust callers.
180 (ctf_arc_open_by_name_internal): Rename to...
181 (ctf_dict_open_internal): ... this. Adjust callers.
182 (ctf_arc_open_by_name_sections): Rename to...
183 (ctf_dict_open_sections): ... this, keeping compatibility function.
184 (ctf_arc_open_by_name): Rename to...
185 (ctf_dict_open): ... this, keeping compatibility function.
186 * libctf.ver: New functions added.
187 * ctf-link.c (ctf_link_one_input_archive): Adjusted accordingly.
188 (ctf_link_deduplicating_open_inputs): Likewise.
190 2020-11-20 Nick Alcock <nick.alcock@oracle.com>
192 * ctf-impl.h: Rename ctf_file_t to ctf_dict_t: all declarations
194 (ctf_fileops): Rename to...
195 (ctf_dictops): ... this.
196 (ctf_dedup_t) <cd_id_to_file_t>: Rename to...
197 <cd_id_to_dict_t>: ... this.
198 (ctf_file_t): Fix outdated comment.
199 <ctf_fileops>: Rename to...
200 <ctf_dictops>: ... this.
201 (struct ctf_archive_internal) <ctfi_file>: Rename to...
202 <ctfi_dict>: ... this.
203 * ctf-archive.c: Rename ctf_file_t to ctf_dict_t.
204 Rename ctf_archive.ctfa_nfiles to ctfa_ndicts.
205 Rename ctf_file_close to ctf_dict_close. All users adjusted.
206 * ctf-create.c: Likewise. Refer to CTF dicts, not CTF containers.
207 (ctf_bundle_t) <ctb_file>: Rename to...
208 <ctb_dict): ... this.
209 * ctf-decl.c: Rename ctf_file_t to ctf_dict_t.
210 * ctf-dedup.c: Likewise. Rename ctf_file_close to
211 ctf_dict_close. Refer to CTF dicts, not CTF containers.
212 * ctf-dump.c: Likewise.
213 * ctf-error.c: Likewise.
214 * ctf-hash.c: Likewise.
215 * ctf-inlines.h: Likewise.
216 * ctf-labels.c: Likewise.
217 * ctf-link.c: Likewise.
218 * ctf-lookup.c: Likewise.
219 * ctf-open-bfd.c: Likewise.
220 * ctf-string.c: Likewise.
221 * ctf-subr.c: Likewise.
222 * ctf-types.c: Likewise.
223 * ctf-util.c: Likewise.
224 * ctf-open.c: Likewise.
225 (ctf_file_close): Rename to...
226 (ctf_dict_close): ...this.
227 (ctf_file_close): New trivial wrapper around ctf_dict_close, for
229 (ctf_parent_file): Rename to...
230 (ctf_parent_dict): ... this.
231 (ctf_parent_file): New trivial wrapper around ctf_parent_dict, for
233 * libctf.ver: Add ctf_dict_close and ctf_parent_dict.
235 2020-10-21 Tom Tromey <tromey@adacore.com>
237 * mkerrors.sed: Remove.
238 * ctf-error.c (_CTF_FIRST): New define.
239 (_CTF_ITEM): Define this, not _CTF_STR.
240 (_ctf_errlist, _ctf_erridx): Use _CTF_ERRORS.
241 (ERRSTRFIELD): Rewrite.
242 (ERRSTRFIELD1): Remove.
243 * Makefile.in: Rebuild.
244 * Makefile.am (BUILT_SOURCES): Remove.
245 (ctf-error.h): Remove.
247 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
249 * ctf-subr.c (open_errors): New list.
250 (ctf_err_warn): Calls with NULL fp append to open_errors. Add err
251 parameter, and use it to decorate the debug stream with errmsgs.
252 (ctf_err_warn_to_open): Splice errors from a CTF dict into the
254 (ctf_errwarning_next): Calls with NULL fp report from open_errors.
255 New err param to report iteration errors (including end-of-iteration)
257 (ctf_assert_fail_internal): Adjust ctf_err_warn call for new err
258 parameter: gettextize.
259 * ctf-impl.h (ctfo_get_vbytes): Add ctf_file_t parameter.
260 (LCTF_VBYTES): Adjust.
261 (ctf_err_warn_to_open): New.
262 (ctf_err_warn): Adjust.
263 (ctf_bundle): Used in only one place: move...
264 * ctf-create.c: ... here.
265 (enumcmp): Use ctf_err_warn, not ctf_dprintf, passing the err number
266 down as needed. Don't emit the errmsg. Gettextize.
268 (ctf_add_type_internal): Likewise.
269 (ctf_write_mem): Likewise.
270 (ctf_compress_write): Likewise. Report errors writing the header or
272 (ctf_write): Likewise.
273 * ctf-archive.c (ctf_arc_write_fd): Use ctf_err_warn, not
274 ctf_dprintf, and gettextize, as above.
275 (ctf_arc_write): Likewise.
276 (ctf_arc_bufopen): Likewise.
277 (ctf_arc_open_internal): Likewise.
278 * ctf-labels.c (ctf_label_iter): Likewise.
279 * ctf-open-bfd.c (ctf_bfdclose): Likewise.
280 (ctf_bfdopen): Likewise.
281 (ctf_bfdopen_ctfsect): Likewise.
282 (ctf_fdopen): Likewise.
283 * ctf-string.c (ctf_str_write_strtab): Likewise.
284 * ctf-types.c (ctf_type_resolve): Likewise.
285 * ctf-open.c (get_vbytes_common): Likewise. Pass down the ctf dict.
286 (get_vbytes_v1): Pass down the ctf dict.
287 (get_vbytes_v2): Likewise.
288 (flip_ctf): Likewise.
289 (flip_types): Likewise. Use ctf_err_warn, not ctf_dprintf, and
290 gettextize, as above.
291 (upgrade_types_v1): Adjust calls.
292 (init_types): Use ctf_err_warn, not ctf_dprintf, as above.
293 (ctf_bufopen_internal): Likewise. Adjust calls. Transplant errors
294 emitted into individual dicts into the open errors if this turns
295 out to be a failed open in the end.
296 * ctf-dump.c (ctf_dump_format_type): Adjust ctf_err_warn for new err
297 argument. Gettextize. Don't emit the errmsg.
298 (ctf_dump_funcs): Likewise. Collapse err label into its only case.
299 (ctf_dump_type): Likewise.
300 * ctf-link.c (ctf_create_per_cu): Adjust ctf_err_warn for new err
301 argument. Gettextize. Don't emit the errmsg.
302 (ctf_link_one_type): Likewise.
303 (ctf_link_lazy_open): Likewise.
304 (ctf_link_one_input_archive): Likewise.
305 (ctf_link_deduplicating_count_inputs): Likewise.
306 (ctf_link_deduplicating_open_inputs): Likewise.
307 (ctf_link_deduplicating_close_inputs): Likewise.
308 (ctf_link_deduplicating): Likewise.
309 (ctf_link): Likewise.
310 (ctf_link_deduplicating_per_cu): Likewise. Add some missed
311 ctf_set_errnos to obscure error cases.
312 * ctf-dedup.c (ctf_dedup_rhash_type): Adjust ctf_err_warn for new
313 err argument. Gettextize. Don't emit the errmsg.
314 (ctf_dedup_populate_mappings): Likewise.
315 (ctf_dedup_detect_name_ambiguity): Likewise.
316 (ctf_dedup_init): Likewise.
317 (ctf_dedup_multiple_input_dicts): Likewise.
318 (ctf_dedup_conflictify_unshared): Likewise.
319 (ctf_dedup): Likewise.
320 (ctf_dedup_rwalk_one_output_mapping): Likewise.
321 (ctf_dedup_id_to_target): Likewise.
322 (ctf_dedup_emit_type): Likewise.
323 (ctf_dedup_emit_struct_members): Likewise.
324 (ctf_dedup_populate_type_mapping): Likewise.
325 (ctf_dedup_populate_type_mappings): Likewise.
326 (ctf_dedup_emit): Likewise.
327 (ctf_dedup_hash_type): Likewise. Fix a bit of messed-up error
329 (ctf_dedup_rwalk_one_output_mapping): Likewise. Don't hide
330 unknown-type-kind messages (which signify file corruption).
332 2020-08-27 Nick Alcock <nick.alcock@oracle.com>
334 * configure.ac: Adjust package name to simply 'libctf': arbitrarily
335 declare this to be version 1.2.0.
336 * Makefile.am (AM_CPPFLAGS): Add @INCINTL@.
337 * Makefile.in: Regenerated.
338 * configure: Regenerated.
339 * ctf-intl.h: New file, lightly modified from opcodes/opintl.h.
340 * ctf-impl.h: Include it.
341 * ctf-error.r (_ctf_errlist_t): Mark strings as noop-translatable.
342 (ctf_errmsg): Actually translate them.
344 2020-07-26 Eli Zaretskii <eliz@gnu.org>
347 * ctf-create.c (EOVERFLOW): If not defined by system header,
348 redirect to ERANGE as a poor man's substitute.
349 * ctf-subr.c (ENOTSUP): If not defined, use ENOSYS instead.
351 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
353 * ctf-create.c (ctf_dtd_insert): Add uintptr_t casts.
354 (ctf_dtd_delete): Likewise.
355 (ctf_dtd_lookup): Likewise.
356 (ctf_rollback): Likewise.
357 * ctf-hash.c (ctf_hash_lookup_type): Likewise.
358 * ctf-types.c (ctf_lookup_by_rawhash): Likewise.
360 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
362 * ctf-lookup.c (ctf_lookup_by_name): Adjust.
364 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
366 * ctf-archive.c (ctf_arc_bufopen): Endian-swap the archive magic
369 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
371 * ctf-impl.h (ctf_list_splice): New.
372 * ctf-util.h (ctf_list_splice): Likewise.
373 * ctf-link.c (link_sort_inputs_cb_arg_t): Likewise.
374 (ctf_link_sort_inputs): Likewise.
375 (ctf_link_deduplicating_count_inputs): Likewise.
376 (ctf_link_deduplicating_open_inputs): Likewise.
377 (ctf_link_deduplicating_close_inputs): Likewise.
378 (ctf_link_deduplicating_variables): Likewise.
379 (ctf_link_deduplicating_per_cu): Likewise.
380 (ctf_link_deduplicating): Likewise.
383 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
385 * ctf-link.c (ctf_link_one_input_archive_member): Check
386 CTF_LINK_OMIT_VARIABLES_SECTION.
388 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
390 * ctf-impl.h (ctf_type_id_key): New, the key in the
392 (ctf_dedup): New, core deduplicator state.
393 (ctf_file_t) <ctf_dedup>: New.
394 <ctf_dedup_atoms>: New.
395 <ctf_dedup_atoms_alloc>: New.
396 (ctf_hash_type_id_key): New prototype.
397 (ctf_hash_eq_type_id_key): Likewise.
398 (ctf_dedup_atoms_init): Likewise.
399 * ctf-hash.c (ctf_hash_eq_type_id_key): New.
400 (ctf_dedup_atoms_init): Likewise.
401 * ctf-create.c (ctf_serialize): Adjusted.
402 (ctf_add_encoded): No longer static.
403 (ctf_add_reftype): Likewise.
404 * ctf-open.c (ctf_file_close): Destroy the
405 ctf_dedup_atoms_alloc.
406 * ctf-dedup.c: New file.
407 * ctf-decls.h [!HAVE_DECL_STPCPY]: Add prototype.
408 * configure.ac: Check for stpcpy.
409 * Makefile.am: Add it.
410 * Makefile.in: Regenerate.
411 * config.h.in: Regenerate.
412 * configure: Regenerate.
414 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
416 * configure.ac: Add --enable-libctf-hash-debugging.
417 * aclocal.m4: Pull in enable.m4, for GCC_ENABLE.
418 * Makefile.in: Regenerated.
419 * configure: Likewise.
420 * config.h.in: Likewise.
421 * ctf-impl.h [ENABLE_LIBCTF_HASH_DEBUGGING]
422 (ctf_assert): Define to assert.
424 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
426 * ctf-sha1.h: New, inline wrappers around sha1_init_ctx and
428 * ctf-impl.h: Include it.
429 (ctf_sha1_init): New.
430 (ctf_sha1_add): Likewise.
431 (ctf_sha1_fini): Likewise.
432 * ctf-sha1.c: New, non-inline wrapper around sha1_finish_ctx
434 * Makefile.am: Add file.
435 * Makefile.in: Regenerate.
437 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
439 * libctf.ver (ctf_link_set_variable_filter): Add.
440 * ctf-impl.h (ctf_file_t) <ctf_link_variable_filter>: New.
441 <ctf_link_variable_filter_arg>: Likewise.
442 * ctf-create.c (ctf_serialize): Adjust.
443 * ctf-link.c (ctf_link_set_variable_filter): New, set it.
444 (ctf_link_one_variable): Call it if set.
446 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
448 * ctf-link.c (ctf_link_one_variable): Check the dst_type for
449 conflicts, not the source type.
451 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
453 * ctf-impl.h (ctf_file_t): Improve comments.
454 <ctf_link_cu_mapping>: Split into...
455 <ctf_link_in_cu_mapping>: ... this...
456 <ctf_link_out_cu_mapping>: ... and this.
457 * ctf-create.c (ctf_serialize): Adjust.
458 * ctf-open.c (ctf_file_close): Likewise.
459 * ctf-link.c (ctf_create_per_cu): Look things up in the
460 in_cu_mapping instead of the cu_mapping.
461 (ctf_link_add_cu_mapping): The deduplicating link will define
462 what happens if many FROMs share a TO.
463 (ctf_link_add_cu_mapping): Create in_cu_mapping and
464 out_cu_mapping. Do not create ctf_link_outputs here any more, or
465 create per-CU dicts here: they are already created when needed.
466 (ctf_link_one_variable): Log a debug message if we skip a
467 variable due to its type being concealed in a CU-mapped link.
468 (This is probably too common a case to make into a warning.)
469 (ctf_link): Create empty per-CU dicts if requested.
471 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
473 * ctf-link.c (ctf_link_write): Close the fd.
475 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
477 * Makefile.am: Set -DNOBFD=1 in libctf-nobfd, and =0 elsewhere.
478 * Makefile.in: Regenerated.
479 * ctf-impl.h (ctf_link_input_name): New.
480 (ctf_file_t) <ctf_link_flags>: New.
481 * ctf-create.c (ctf_serialize): Adjust accordingly.
482 * ctf-link.c: Define ctf_open as weak when PIC.
483 (ctf_arc_close_thunk): Remove unnecessary thunk.
484 (ctf_file_close_thunk): Likewise.
485 (ctf_link_input_name): New.
486 (ctf_link_input_t): New value of the ctf_file_t.ctf_link_input.
487 (ctf_link_input_close): Adjust accordingly.
488 (ctf_link_add_ctf_internal): New, split from...
489 (ctf_link_add_ctf): ... here. Return error if lazy loading of
490 CTF is not possible. Change to just call...
491 (ctf_link_add): ... this new function.
492 (ctf_link_add_cu_mapping): Transition to ctf_err_warn. Drop the
493 ctf_file_close_thunk.
494 (ctf_link_in_member_cb_arg_t) <file_name> Rename to...
495 <in_file_name>: ... this.
497 <share_mode>: Likewise (migrated to ctf_link_flags).
498 <done_main_member>: Rename to...
499 <done_parent>: ... this.
500 <main_input_fp>: Rename to...
501 <in_fp_parent>: ... this.
503 (ctf_link_one_type): Adjuwt accordingly. Transition to
504 ctf_err_warn, removing a TODO.
505 (ctf_link_one_variable): Note a case too common to warn about.
506 Report in the debug stream if a cu-mapped link prevents addition
507 of a conflicting variable.
508 (ctf_link_one_input_archive_member): Adjust.
509 (ctf_link_lazy_open): New, open a CTF archive for linking when
511 (ctf_link_close_one_input_archive): New, close it again.
512 (ctf_link_one_input_archive): Adjust for lazy opening, member
513 renames, and ctf_err_warn transition. Move the
514 empty_link_type_mapping call to...
515 (ctf_link): ... here. Adjut for renamings and thunk removal.
516 Don't spuriously fail if some input contains no CTF data.
517 (ctf_link_write): ctf_err_warn transition.
518 * libctf.ver: Remove not-yet-stable comment.
520 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
522 * ctf-impl.h (ctf_strerror): Delete.
523 * ctf-subr.c (ctf_strerror): Likewise.
524 * ctf-error.c (ctf_errmsg): Stop using ctf_strerror: just use
527 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
529 * ctf-impl.c (ctf_file_t) <ctf_parent_unreffed>: New.
530 (ctf_import_unref): New.
531 * ctf-open.c (ctf_file_close) Drop the refcount all the way to
532 zero. Don't recurse back in if the refcount is already zero.
533 (ctf_import): Check ctf_parent_unreffed before deciding whether
534 to close a pre-existing parent. Set it to zero.
535 (ctf_import_unreffed): New, as above, setting
536 ctf_parent_unreffed to 1.
537 * ctf-create.c (ctf_serialize): Do not ctf_import into the new
538 child: use direct assignment, and set unreffed on the new and
540 * ctf-link.c (ctf_create_per_cu): Import the parent using
543 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
545 * ctf-impl.h (ctf_link_type_mapping_key): Rename to...
546 (ctf_link_type_key): ... this, adjusting member prefixes to
548 (ctf_hash_type_mapping_key): Rename to...
549 (ctf_hash_type_key): ... this.
550 (ctf_hash_eq_type_mapping_key): Rename to...
551 (ctf_hash_eq_type_key): ... this.
552 * ctf-hash.c (ctf_hash_type_mapping_key): Rename to...
553 (ctf_hash_type_key): ... this, and adjust for member name
555 (ctf_hash_eq_type_mapping_key): Rename to...
556 (ctf_hash_eq_type_key): ... this, and adjust for member name
558 * ctf-link.c (ctf_add_type_mapping): Adjust. Note the lack of
559 need for out-of-memory checking in this code.
560 (ctf_type_mapping): Adjust.
562 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
564 configure.ac: Check for vasprintf.
565 configure: Regenerated.
566 config.h.in: Likewise.
568 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
570 * ctf-archive.c (ctf_arc_bufopen): Fix message.
572 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
574 * ctf-impl.h (struct ctf_archive_internal) <ctfi_free_strsect>
576 * ctf-open-bfd.c (ctf_bfdopen_ctfsect): Explicitly open a strtab
577 if the input has no symtab, rather than dividing by
578 zero. Arrange to free it later via ctfi_free_ctfsect.
579 * ctf-archive.c (ctf_new_archive_internal): Do not
580 ctfi_free_strsect by default.
581 (ctf_arc_close): Possibly free it here.
583 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
585 * ctf-dump.c (ctf_is_slice): Delete, unnecessary.
586 (ctf_dump_format_type): improve slice formatting. Always print
587 the type size, even of slices.
588 (ctf_dump_member): Print slices (-> bitfields) differently from
589 non-slices. Failure to format a type is not an OOM.
591 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
593 * ctf-dump.c (ctf_dump_format_type): Emit a warning.
594 (ctf_dump_label): Swallow errors from ctf_dump_format_type.
595 (ctf_dump_objts): Likewise.
596 (ctf_dump_var): Likewise.
597 (ctf_dump_type): Do not emit a duplicate message. Move to
598 ctf_err_warning, and swallow all errors.
600 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
602 * ctf-decl.c (ctf_decl_fini): Free the cd_buf.
603 (ctf_decl_buf): Once it escapes, don't try to free it later.
605 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
607 * ctf-types.c (ctf_type_aname): Print arg types here...
608 * ctf-dump.c (ctf_dump_funcs): ... not here: but do substitute
609 in the type name here.
611 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
613 * ctf-impl.h (ctf_assert): New.
614 (ctf_err_warning_t): Likewise.
615 (ctf_file_t) <ctf_errs_warnings>: Likewise.
616 (ctf_err_warn): New prototype.
617 (ctf_assert_fail_internal): Likewise.
618 * ctf-inlines.h (ctf_assert_internal): Likewise.
619 * ctf-open.c (ctf_file_close): Free ctf_errs_warnings.
620 * ctf-create.c (ctf_serialize): Copy it on serialization.
621 * ctf-subr.c (ctf_err_warn): New, add an error/warning.
622 (ctf_errwarning_next): New iterator, free and pass back
623 errors/warnings in succession.
624 * libctf.ver (ctf_errwarning_next): Add.
626 2020-07-22 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
628 * ctf-types.c (ctf_variable_iter): Fix error return.
630 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
632 * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.
634 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
636 ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
638 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
640 * ctf-impl.h (ctf_next_hkv_t): New, kv-pairs passed to
642 (ctf_next_t) <u.ctn_sorted_hkv>: New, sorted kv-pairs for
643 ctf_dynhash_next_sorted.
644 <cu.ctn_h>: New, pointer to the dynhash under iteration.
645 <cu.ctn_s>: New, pointer to the dynset under iteration.
646 (ctf_hash_sort_f): Sorting function passed to...
647 (ctf_dynhash_next_sorted): ... this new function.
648 (ctf_dynhash_next): New.
649 (ctf_dynset_next): New.
650 * ctf-inlines.h (ctf_dynhash_cnext_sorted): New.
651 (ctf_dynhash_cnext): New.
652 (ctf_dynset_cnext): New.
653 * ctf-hash.c (ctf_dynhash_next_sorted): New.
654 (ctf_dynhash_next): New.
655 (ctf_dynset_next): New.
656 * ctf-util.c (ctf_next_destroy): Free the u.ctn_sorted_hkv if
658 (ctf_next_copy): Alloc-and-copy the u.ctn_sorted_hkv if needed.
660 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
662 * ctf-impl.h (ctf_next): New.
663 (ctf_get_dict): New prototype.
664 * ctf-lookup.c (ctf_get_dict): New, split out of...
665 (ctf_lookup_by_id): ... here.
666 * ctf-util.c (ctf_next_create): New.
667 (ctf_next_destroy): New.
668 (ctf_next_copy): New.
669 * ctf-types.c (includes): Add <assert.h>.
670 (ctf_member_next): New.
671 (ctf_enum_next): New.
672 (ctf_type_iter): Document the lack of iteration over parent
674 (ctf_type_next): New.
675 (ctf_variable_next): New.
676 * ctf-archive.c (ctf_archive_next): New.
677 * libctf.ver: Add new public functions.
679 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
681 * libctf.ver (ctf_ref): New.
682 * ctf-open.c (ctf_ref): Implement it.
684 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
686 * ctf-inlines.h (ctf_forwardable_kind): New.
687 * ctf-create.c (ctf_add_forward): Use it.
689 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
691 * ctf-impl.h (ctf_get_ctt_size): Move definition from here...
692 * ctf-inlines.h (ctf_get_ctt_size): ... to here.
694 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
696 * ctf-hash.c (ctf_dynset_eq_string): New.
697 (ctf_dynset_create): New.
698 (DYNSET_EMPTY_ENTRY_REPLACEMENT): New.
699 (DYNSET_DELETED_ENTRY_REPLACEMENT): New.
700 (key_to_internal): New.
701 (internal_to_key): New.
702 (ctf_dynset_insert): New.
703 (ctf_dynset_remove): New.
704 (ctf_dynset_destroy): New.
705 (ctf_dynset_lookup): New.
706 (ctf_dynset_exists): New.
707 (ctf_dynset_lookup_any): New.
708 (ctf_hash_insert_type): Coding style.
709 (ctf_hash_define_type): Likewise.
710 * ctf-impl.h (ctf_dynset_t): New.
711 (ctf_dynset_eq_string): New.
712 (ctf_dynset_create): New.
713 (ctf_dynset_insert): New.
714 (ctf_dynset_remove): New.
715 (ctf_dynset_destroy): New.
716 (ctf_dynset_lookup): New.
717 (ctf_dynset_exists): New.
718 (ctf_dynset_lookup_any): New.
719 * ctf-inlines.h (ctf_dynset_cinsert): New.
721 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
723 * ctf-hash.c (ctf_helem_t) <key_free>: Remove.
724 <value_free>: Likewise.
726 (ctf_dynhash_item_free): Indirect through the owner.
727 (ctf_dynhash_create): Only pass in ctf_dynhash_item_free and
728 allocate space for the key_free and value_free fields fields
730 (ctf_hashtab_insert): Likewise. Fix OOM errno value.
731 (ctf_dynhash_insert): Only access ctf_hashtab's key_free and
732 value_free if they will exist. Set the slot's owner, but only
734 (ctf_dynhash_remove): Adjust.
736 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
738 * ctf-hash.c (ctf_hashtab_insert): Free the key passed in if
739 there is a key-freeing function and the key already exists.
741 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
743 * ctf-inlines.h: New file.
744 * ctf-impl.h: Include it.
745 (ctf_hash_iter_find_f): New typedef.
746 (ctf_dynhash_elements): New.
747 (ctf_dynhash_lookup_kv): New.
748 (ctf_dynhash_iter_find): New.
749 * ctf-hash.c (ctf_dynhash_lookup_kv): New.
750 (ctf_traverse_find_cb_arg_t): New.
751 (ctf_hashtab_traverse_find): New.
752 (ctf_dynhash_iter_find): New.
753 (ctf_dynhash_elements): New.
755 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
757 * ctf-impl.h [!__GNUC__] (__extension__): Define to nothing.
759 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
761 * ctf-archive.c (ctf_archive_count): New.
762 * libctf.ver: New public function.
764 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
766 * ctf-types.c (ctf_member_count): New.
767 * libctf.ver: New public function.
769 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
771 * ctf-types.c (ctf_type_kind_forwarded): New.
773 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
775 * ctf-types.c (ctf_type_name_raw): New.
776 (ctf_type_aname_raw): Reimplement accordingly.
778 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
780 * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set.
782 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
784 * ctf-impl.h (struct ctf_archive_internal)
785 <ctfi_unmap_on_close>: New.
786 (ctf_new_archive_internal): Adjust.
787 * ctf-archive.c (ctf_new_archive_internal): Likewise.
788 Initialize ctfi_unmap_on_close. Adjust error path.
789 (ctf_arc_bufopen): Adjust ctf_new_archive_internal call
790 (unmap_on_close is 0).
791 (ctf_arc_close): Only unmap if ctfi_unmap_on_close.
792 * ctf-open-bfd.c (ctf_fdopen): Adjust.
794 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
796 * ctf-types.c (ctf_type_aname): Return ECTF_CORRUPT if
797 ints, floats or typedefs have no name. Fix comment typo.
799 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
801 * ctf-create.c (ctf_add_slice): Support slices of any kind that
802 resolves to an integral type.
803 * ctf-types.c (ctf_type_encoding): Resolve the type before
804 fishing its encoding out.
806 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
808 * ctf-create.c (ctf_create): Mark dirty.
810 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
812 * ctf-create.c (membcmp) Skip nameless members.
814 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
816 * ctf-create.c (ctf_add_member_offset): Support names of ""
817 as if they were the null pointer.
819 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
821 * ctf-open.c (init_types): Remove typeless CTF_K_FORWARD
824 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
826 * ctf-types.c (ctf_type_reference): Add support for dynamic slices.
828 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
830 * ctf-create.c (ctf_serialize): Add cast.
831 (ctf_add_slice): Likewise.
833 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
835 * ctf-impl.h (ctf_dtdef_t) <dtu_argv>: Fix type.
836 * ctf-create.c (ctf_add_function): Check for unimplemented type
837 and populate at the same time. Populate one-by-one, not via
839 (ctf_serialize): Remove unnecessary cast.
840 * ctf-types.c (ctf_func_type_info): Likewise.
841 (ctf_func_type_args): Likewise. Fix comment typo.
843 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
845 * ctf-create.c (ctf_add_reftype): Support refs to type zero.
846 (ctf_add_array): Support array contents of type zero.
847 (ctf_add_function): Support arguments and return types of
849 (ctf_add_typedef): Support typedefs to type zero.
850 (ctf_add_member_offset): Support members of type zero,
851 unless added at unspecified (naturally-aligned) offset.
853 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
855 * ctf-error.c: Include <stddef.h>, for offsetof.
856 (_ctf_errlist): Migrate to...
857 (_ctf_errlist_t): ... this.
858 (_ctf_erridx): New, indexes into _ctf_errlist_t.
860 (ctf_errmsg): Adjust accordingly.
861 * Makefile.am (BUILT_SOURCES): Note...
862 (ctf-error.h): ... this new rule.
863 * Makefile.in: Regenerate.
864 * mkerrors.sed: New, process ctf-api.h to generate ctf-error.h.
865 * .gitignore: New, ignore ctf-error.h.
867 2020-07-22 Nick Alcock <nick.alcock@oracle.com>
869 * ctf-impl.h: Fix typos in comments.
871 2020-07-22 Nick Clifton <nickc@redhat.com>
873 * ctf-archive.c (ctf_arc_write): Avoid calling close twice on the
874 same file descriptor.
876 2020-07-04 Nick Clifton <nickc@redhat.com>
878 Binutils 2.35 branch created.
880 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
882 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
884 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
885 * config.h.in: Regenerated.
886 * Makefile.in: Likewise.
887 * configure: Likewise.
889 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
891 * ctf-create.c: Include <unistd.h>.
892 * ctf-open-bfd.c: Likewise.
894 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
897 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
898 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
899 means this is declared.
900 (bswap_32): Likewise.
901 (bswap_64): Likewise.
902 (bswap_identity_64): Remove, unused.
903 * configure: Regenerated.
904 * config.h.in: Likewise.
906 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
909 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
910 (_libctf_unlikely_): Likewise.
911 (_libctf_unused): Likewise.
912 (_libctf_malloc_): Likewise.
914 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
917 * ctf-archive.c (search_nametbl): No longer global: declare...
918 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
919 (search_modent_by_name): Take and use ARG for the nametbl.
921 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
923 * ctf-impl.h (ctf_new_archive_internal): Declare.
924 (ctf_arc_bufopen): Remove.
925 (ctf_archive_internal) <ctfi_free_symsect>: New.
926 * ctf-archive.c (ctf_arc_close): Use it.
927 (ctf_arc_bufopen): Fuse into...
928 (ctf_new_archive_internal): ... this, moved across from...
929 * ctf-open-bfd.c: ... here.
930 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
931 * libctf.ver: Add it.
933 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
935 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
936 (ctf_dtd_delete): Remove correspondingly.
937 (ctf_rollback): Likewise.
939 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
941 * ctf-create.c (ctf_add_type_internal): Hand back existing types
944 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
946 * ctf-create.c (ctf_add_forward): Don't add forwards to
947 types that already exist.
949 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
951 * ctf-open.c (init_types): Only intern root-visible types.
952 * ctf-create.c (ctf_dtd_insert): Likewise.
953 (ctf_dtd_delete): Only remove root-visible types.
954 (ctf_rollback): Likewise.
955 (ctf_add_generic): Adjust.
956 (ctf_add_struct_sized): Adjust comment.
957 (ctf_add_union_sized): Likewise.
958 (ctf_add_enum): Likewise.
959 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
961 2020-03-11 John Baldwin <jhb@FreeBSD.org>
963 * swap.h (bswap_identity_64): Make static.
965 2020-01-18 Nick Clifton <nickc@redhat.com>
967 Binutils 2.34 branch created.
969 2020-01-05 Joel Brobecker <brobecker@adacore.com>
972 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
973 * configure, config.h.in: Regenerate.
975 2020-01-01 Alan Modra <amodra@gmail.com>
977 Update year range in copyright notice of all files.
979 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
981 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
983 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
985 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
986 * ctf-types.c (ctf_type_lname): Likewise.
988 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
990 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
991 ctf_import after the first for a given file.
993 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
995 * ctf-impl.h (ctf_str_append_noerr): Declare.
996 * ctf-util.c (ctf_str_append_noerr): Define in terms of
998 * ctf-dump.c (str_append): New, call it.
999 (ctf_dump_format_type): Use str_append, not ctf_str_append.
1000 (ctf_dump_label): Likewise.
1001 (ctf_dump_objts): Likewise.
1002 (ctf_dump_funcs): Likewise.
1003 (ctf_dump_var): Likewise.
1004 (ctf_dump_member): Likewise.
1005 (ctf_dump_type): Likewise.
1006 (ctf_dump): Likewise.
1008 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
1010 * ctf-impl.h (ctf_alloc): Remove.
1011 (ctf_free): Likewise.
1012 (ctf_strdup): Likewise.
1013 * ctf-subr.c (ctf_alloc): Remove.
1014 (ctf_free): Likewise.
1015 * ctf-util.c (ctf_strdup): Remove.
1017 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
1018 ctf_free; strdup, not ctf_strdup.
1019 (ctf_dtd_delete): Likewise.
1020 (ctf_dvd_delete): Likewise.
1021 (ctf_add_generic): Likewise.
1022 (ctf_add_function): Likewise.
1023 (ctf_add_enumerator): Likewise.
1024 (ctf_add_member_offset): Likewise.
1025 (ctf_add_variable): Likewise.
1026 (membadd): Likewise.
1027 (ctf_compress_write): Likewise.
1028 (ctf_write_mem): Likewise.
1029 * ctf-decl.c (ctf_decl_push): Likewise.
1030 (ctf_decl_fini): Likewise.
1031 (ctf_decl_sprintf): Likewise. Check for OOM.
1032 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
1033 ctf_free; strdup, not ctf_strdup.
1034 (ctf_dump_free): Likewise.
1035 (ctf_dump): Likewise.
1036 * ctf-open.c (upgrade_types_v1): Likewise.
1037 (init_types): Likewise.
1038 (ctf_file_close): Likewise.
1039 (ctf_bufopen_internal): Likewise. Check for OOM.
1040 (ctf_parent_name_set): Likewise: report the OOM to the caller.
1041 (ctf_cuname_set): Likewise.
1042 (ctf_import): Likewise.
1043 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
1044 free, not ctf_free; strdup, not ctf_strdup.
1045 (ctf_str_free_atom): Likewise.
1046 (ctf_str_create_atoms): Likewise.
1047 (ctf_str_add_ref_internal): Likewise.
1048 (ctf_str_remove_ref): Likewise.
1049 (ctf_str_write_strtab): Likewise.
1051 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1053 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
1054 work right for non-int/fps.
1056 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
1058 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
1061 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
1063 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
1064 * ctf-open.c (ctf_file_close): Free it.
1065 * ctf-create.c (ctf_serialize): Adjust.
1066 (membcmp): When reporting a conflict due to an error, report the
1068 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
1069 (ctf_add_type_internal): ... this. Hand back types we are already
1070 in the middle of adding immediately. Hand back structs/unions with
1071 the same number of members immediately. Do not walk the dynamic
1072 list. Call ctf_add_type_internal, not ctf_add_type. Handle
1073 forwards promoted to other types and the inverse case identically.
1074 Add structs to the mapping as soon as we intern them, before they
1077 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
1079 * ctf-impl.h (ctf_names_t): New.
1080 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
1081 (ctf_file_t) <ctf_structs>: Likewise.
1082 <ctf_unions>: Likewise.
1083 <ctf_enums>: Likewise.
1084 <ctf_names>: Likewise.
1085 <ctf_lookups>: Improve comment.
1086 <ctf_ptrtab_len>: New.
1087 <ctf_prov_strtab>: New.
1088 <ctf_str_prov_offset>: New.
1089 <ctf_dtbyname>: Remove, redundant to the names hashes.
1090 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
1091 (ctf_dtdef_t) <dtd_name>: Remove.
1092 <dtd_data>: Note that the ctt_name is now populated.
1093 (ctf_str_atom_t) <csa_offset>: This is now the strtab
1094 offset for internal strings too.
1095 <csa_external_offset>: New, the external strtab offset.
1096 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
1097 (ctf_name_table): New declaration.
1098 (ctf_lookup_by_rawname): Likewise.
1099 (ctf_lookup_by_rawhash): Likewise.
1100 (ctf_set_ctl_hashes): Likewise.
1101 (ctf_serialize): Likewise.
1102 (ctf_dtd_insert): Adjust.
1103 (ctf_simple_open_internal): Likewise.
1104 (ctf_bufopen_internal): Likewise.
1105 (ctf_list_empty_p): Likewise.
1106 (ctf_str_remove_ref): Likewise.
1107 (ctf_str_add): Returns uint32_t now.
1108 (ctf_str_add_ref): Likewise.
1109 (ctf_str_add_external): Now returns a boolean (int).
1110 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
1111 for strings in the appropriate range.
1112 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
1113 when adding the null string to the new strtab.
1114 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
1115 (ctf_str_add_ref_internal): Add make_provisional argument. If
1116 make_provisional, populate the offset and fill in the
1117 ctf_prov_strtab accordingly.
1118 (ctf_str_add): Return the offset, not the string.
1119 (ctf_str_add_ref): Likewise.
1120 (ctf_str_add_external): Return a success integer.
1121 (ctf_str_remove_ref): New, remove a single ref.
1122 (ctf_str_count_strtab): Do not count the initial null string's
1123 length or the existence or length of any unreferenced internal
1125 (ctf_str_populate_sorttab): Skip atoms with no refs.
1126 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
1127 to the cts_len for the null string, since it is no longer done
1128 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
1129 Populate the csa_offset for both internal and external cases.
1130 Flush the ctf_prov_strtab afterwards, and reset the
1131 ctf_str_prov_offset.
1132 * ctf-create.c (ctf_grow_ptrtab): New.
1133 (ctf_create): Call it. Initialize new fields rather than old
1134 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
1135 Set the ctl hashes and data model.
1136 (ctf_update): Rename to...
1137 (ctf_serialize): ... this. Leave a compatibility function behind.
1138 Tell ctf_simple_open_internal that this is a writable dictionary.
1139 Pass the new fields along from the old dictionary. Drop
1140 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
1141 Do not zero out the DTD's ctt_name.
1142 (ctf_prefixed_name): Rename to...
1143 (ctf_name_table): ... this. No longer return a prefixed name: return
1144 the applicable name table instead.
1145 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
1146 kind we're adding. Migrate away from dtd_name.
1147 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
1149 (ctf_dtd_lookup_type_by_name): Remove.
1150 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
1151 No longer check ctf_dtnextid: check ctf_typemax instead.
1152 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
1153 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
1154 ctf_name_table and the right name table, and migrate away from
1155 dtd_name as in ctf_dtd_delete.
1156 (ctf_add_generic): Pass in the kind explicitly and pass it to
1157 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
1158 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
1159 Grow the ptrtab if needed.
1160 (ctf_add_encoded): Pass in the kind.
1161 (ctf_add_slice): Likewise.
1162 (ctf_add_array): Likewise.
1163 (ctf_add_function): Likewise.
1164 (ctf_add_typedef): Likewise.
1165 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
1166 ctt_name rather than dtd_name.
1167 (ctf_add_struct_sized): Pass in the kind. Use
1168 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
1169 ctf_dtd_lookup_type_by_name.
1170 (ctf_add_union_sized): Likewise.
1171 (ctf_add_enum): Likewise.
1172 (ctf_add_enum_encoded): Likewise.
1173 (ctf_add_forward): Likewise.
1174 (ctf_add_type): Likewise.
1175 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
1176 being initialized until after the call.
1177 (ctf_write_mem): Likewise.
1178 (ctf_write): Likewise.
1179 * ctf-archive.c (arc_write_one_ctf): Likewise.
1180 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
1181 ctf_hash_lookup_type.
1182 (ctf_lookup_by_id): No longer check the readonly types if the
1183 dictionary is writable.
1184 * ctf-open.c (init_types): Assert that this dictionary is not
1185 writable. Adjust to use the new name hashes, ctf_name_table,
1186 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
1187 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
1188 if set. Drop out early when dictionary is writable. Split the
1189 ctf_lookups initialization into...
1190 (ctf_set_cth_hashes): ... this new function.
1191 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
1192 (ctf_simple_open): Adjust accordingly.
1193 (ctf_bufopen): Likewise.
1194 (ctf_file_close): Destroy the appropriate name hashes. No longer
1195 destroy ctf_dtbyname, which is gone.
1196 (ctf_getdatasect): Remove spurious "extern".
1197 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
1198 specified name table, given a kind.
1199 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
1200 (ctf_member_iter): Add support for iterating over the
1202 (ctf_enum_iter): Likewise.
1203 (ctf_variable_iter): Likewise.
1204 (ctf_type_rvisit): Likewise.
1205 (ctf_member_info): Add support for types in the dynamic type list.
1206 (ctf_enum_name): Likewise.
1207 (ctf_enum_value): Likewise.
1208 (ctf_func_type_info): Likewise.
1209 (ctf_func_type_args): Likewise.
1210 * ctf-link.c (ctf_accumulate_archive_names): No longer call
1212 (ctf_link_write): Likewise.
1213 (ctf_link_intern_extern_string): Adjust for new
1214 ctf_str_add_external return value.
1215 (ctf_link_add_strtab): Likewise.
1216 * ctf-util.c (ctf_list_empty_p): New.
1218 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
1220 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
1222 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
1224 (ctf_add_variable): Likewise for variables pointing to them.
1225 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
1226 type link failure, but do warn for others.
1227 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
1228 errors to be ENOMEM.
1229 (ctf_dump_member): Likewise.
1230 (ctf_dump_type): Likewise.
1231 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
1232 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
1233 (ctf_dump_header): Likewise.
1234 (ctf_dump_label): likewise.
1235 (ctf_dump_objts): likewise.
1236 (ctf_dump_funcs): likewise.
1237 (ctf_dump_var): likewise.
1238 (ctf_dump_str): Likewise.
1240 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
1242 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
1243 (LT_INIT): Likewise.
1244 (AM_INSTALL_LIBBFD): Likewise.
1245 (dlopen): Note why this is necessary in a comment.
1246 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
1248 (SHARED_LDFLAGS): Likewise.
1249 (BFD_LIBADD): Likewise, for libbfd.
1250 (BFD_DEPENDENCIES): Likewise.
1251 (VERSION_FLAGS): Initialize, using a version script if ld supports
1252 one, or libtool -export-symbols-regex otherwise.
1253 (AC_CONFIG_MACRO_DIR): Add ../BFD.
1254 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
1256 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
1257 (noinst_LIBRARIES): Replace with...
1258 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
1259 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
1260 libctf-nobfd.la as well.
1261 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
1262 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
1263 (libctf_a_SOURCES): Rename to...
1264 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
1266 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
1267 with ctf-open-bfd.c added.
1268 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
1269 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
1270 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
1271 * Makefile.am [INSTALL_LIBCTF]: Use it.
1272 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
1274 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
1275 the unstable components).
1276 * Makefile.in: Regenerated.
1277 * config.h.in: Likewise.
1278 * configure: Likewise.
1280 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1282 * configure.ac (INSTALL_LIBCTF): New, controlled by
1283 --enable-install-libctf.
1284 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
1285 * Makefile.in: Regenerated.
1286 * configure: Regenerated.
1288 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1290 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
1291 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
1293 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1295 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
1297 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1299 * ctf-impl.h (includes): Include <sys/param.h> here.
1301 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1303 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
1304 (flip_objts): Likewise.
1305 (flip_vars): Likewise.
1306 (flip_types): Likewise.
1308 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1310 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
1311 freeing functions: if set, free the key and value if the slot
1312 already exists. Always reassign the key.
1313 (ctf_dynhash_insert): Adjust call appropriately.
1314 (ctf_hash_insert_type): Likewise.
1316 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
1318 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
1319 type kind. Allow forwards to unify with pre-existing structs/
1322 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
1324 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
1325 <ctf_link_memb_name_changer>: Likewise.
1326 <ctf_link_memb_name_changer_arg>: Likewise.
1327 * ctf-create.c (ctf_update): Update accordingly.
1328 * ctf-open.c (ctf_file_close): Likewise.
1329 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
1330 (ctf_link_add_cu_mapping): New.
1331 (ctf_link_set_memb_name_changer): Likewise.
1332 (ctf_change_parent_name): New.
1333 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
1334 allocated by the caller's ctf_link_memb_name_changer.
1335 <ndynames>: Likewise.
1336 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
1337 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
1338 ctf_change_parent_name. Free any resulting names.
1340 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1342 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
1343 (ctf_link_one_type): ... here, with parent-name setting added.
1344 (check_variable): New.
1345 (ctf_link_one_variable): Likewise.
1346 (ctf_link_one_input_archive_member): Call it.
1347 * ctf-error.c (_ctf_errlist): Updated with new errors.
1349 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1351 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
1352 (struct ctf_link_type_mapping_key): New.
1353 (ctf_hash_type_mapping_key): Likewise.
1354 (ctf_hash_eq_type_mapping_key): Likewise.
1355 (ctf_add_type_mapping): Likewise.
1356 (ctf_type_mapping): Likewise.
1357 (ctf_dynhash_empty): Likewise.
1358 * ctf-open.c (ctf_file_close): Update accordingly.
1359 * ctf-create.c (ctf_update): Likewise.
1360 (ctf_add_type): Populate the mapping.
1361 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
1362 (ctf_hash_eq_type_mapping_key): Check the key for equality.
1363 (ctf_dynhash_insert): Fix comment typo.
1364 (ctf_dynhash_empty): New.
1365 * ctf-link.c (ctf_add_type_mapping): New.
1366 (ctf_type_mapping): Likewise.
1367 (empty_link_type_mapping): New.
1368 (ctf_link_one_input_archive): Call it.
1370 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1372 * ctf-link.c: New file, linking of the string and type sections.
1373 * Makefile.am (libctf_a_SOURCES): Add it.
1374 * Makefile.in: Regenerate.
1376 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
1378 * ctf-create.c (ctf_update): Update accordingly.
1379 * ctf-open.c (ctf_file_close): Likewise.
1380 * ctf-error.c (_ctf_errlist): Updated with new errors.
1382 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1384 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
1386 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1388 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
1390 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
1391 (ctf_dump_format_type): Add non-root-type { } notation.
1392 Add root flag to prototype.
1393 (ctf_dump_label): Adjust accordingly.
1394 (ctf_dump_objts): Likewise.
1395 (ctf_dump_var): Likewise.
1397 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1399 * ctf-create.c (ctf_compress_write): Fix double-free.
1401 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1403 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
1405 (ctf_arc_write_fd): ... this new function.
1406 * ctf-create.c (ctf_write_mem): New.
1408 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1410 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
1411 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
1412 (ctf_str_add_ref): Name the last arg.
1413 (ctf_str_add_external) New.
1414 (ctf_str_add_strraw_explicit): Likewise.
1415 (ctf_simple_open_internal): Likewise.
1416 (ctf_bufopen_internal): Likewise.
1418 * ctf-string.c (ctf_strraw_explicit): Split from...
1419 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
1420 (ctf_str_add_ref_internal): Return the atom, not the
1422 (ctf_str_add): Adjust accordingly.
1423 (ctf_str_add_ref): Likewise. Move up in the file.
1424 (ctf_str_add_external): New: update the csa_offset.
1425 (ctf_str_count_strtab): Only account for strings with no csa_offset
1426 in the internal strtab length.
1427 (ctf_str_write_strtab): If the csa_offset is set, update the
1428 string's refs without writing the string out, and update the
1429 ctf_syn_ext_strtab. Make OOM handling less ugly.
1430 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
1431 (ctf_update): Handle failure to populate the strtab. Pass in the
1432 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
1433 Call ctf_simple_open_internal, not ctf_simple_open.
1434 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
1436 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
1437 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
1438 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
1439 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
1440 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
1441 (ctf_simple_open_internal): ... this new function, which calls
1442 ctf_bufopen_internal.
1443 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
1444 (ctf_bufopen_internal): ... this new function, which sets
1447 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1449 * ctf_types.c (ctf_type_iter_all): New.
1451 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1453 * ctf-open.c (init_symtab): Check for overflow against the right
1455 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
1456 (upgrade_types_v1): Note that these sections are not checked.
1457 (flip_header): Endian-swap the header fields.
1458 (flip_ctf): Endian-swap the sections.
1459 (flip_objts): Update comment.
1460 (ctf_bufopen): Check header offsets and alignment for validity.
1462 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
1464 * ctf-open-bfd.c: Add <assert.h>.
1465 (ctf_bfdopen_ctfsect): Open string and symbol tables using
1466 techniques borrowed from bfd_elf_sym_name.
1467 (ctf_new_archive_internal): Improve comment.
1468 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
1469 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
1470 no symbol section, but not vice versa.
1472 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
1474 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
1475 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
1476 * ctf-dump.c (dump_header): New function, dump the CTF header.
1477 (ctf_dump): Call it.
1478 (ctf_dump_header_strfield): New function.
1479 (ctf_dump_header_sectfield): Likewise.
1481 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
1483 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
1484 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
1485 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
1486 ctf_base: do not assume that it is always sizeof (ctf_header_t).
1487 Print out ctf_cuname: only print out ctf_parname if set.
1488 (ctf_free_base): Removed, ctf_base is no longer freed: free
1489 ctf_dynbase instead.
1490 (ctf_set_version): Fix spacing.
1491 (upgrade_header): New, in-place header upgrading.
1492 (upgrade_types): Rename to...
1493 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
1494 longer track old and new headers separately. No longer allow for
1495 header sizes explicitly: squeeze the headers out on upgrade (they
1496 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
1497 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
1498 (upgrade_types): New, also handle ctf_parmax updating.
1499 (flip_header): Flip ctf_cuname.
1500 (flip_types): Flip BUF explicitly rather than deriving BUF from
1502 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
1503 required alignment of objtoff and funcoff. No longer store it in
1504 the ctf_buf unless that buf is derived unmodified from the input.
1505 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
1506 that duplicate fields in ctf_file: move allocation of ctf_file
1507 further up instead. Call upgrade_header as needed. Move
1508 version-specific ctf_parmax initialization into upgrade_types. More
1509 concise error handling.
1510 (ctf_file_close): No longer test for null pointers before freeing.
1511 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
1514 (ctf_cuname_set): New.
1515 * ctf-create.c (ctf_update): Populate ctf_cuname.
1516 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
1518 (ctf_write): Likewise.
1519 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
1520 Fix the compression length: fp->ctf_size never counted the CTF
1521 header. Simplify the compress call accordingly.
1523 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
1525 * ctf-endian.h: Don't assume htole64 and le64toh are always
1526 present if HAVE_ENDIAN_H; also check if htole64 is defined.
1527 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
1528 not bswap_identity_64.
1530 2019-09-18 Alan Modra <amodra@gmail.com>
1532 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
1534 2019-09-09 Phil Blundell <pb@pbcl.net>
1536 binutils 2.33 branch created.
1538 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
1540 * ctf-types.c (ctf_type_aname_raw): New.
1541 (ctf_func_type_info): Likewise.
1542 (ctf_func_type_args): Likewise.
1543 * ctf-error.c (_ctf_errlist): Fix description.
1544 * ctf-lookup.c: Fix file description.
1546 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1548 * ctf-create.c (ctf_create): Fix off-by-one error.
1550 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1552 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
1554 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
1555 (struct ctf_str_atom): New, disambiguated single string.
1556 (struct ctf_str_atom_ref): New, points to some other location that
1557 references this string's offset.
1558 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
1559 Remove member ctf_dtvstrlen: we no longer track the total strlen
1561 (ctf_str_create_atoms): Declare new function in ctf-string.c.
1562 (ctf_str_free_atoms): Likewise.
1563 (ctf_str_add): Likewise.
1564 (ctf_str_add_ref): Likewise.
1565 (ctf_str_rollback): Likewise.
1566 (ctf_str_purge_refs): Likewise.
1567 (ctf_str_write_strtab): Likewise.
1568 (ctf_realloc): Declare new function in ctf-util.c.
1570 * ctf-open.c (ctf_bufopen): Create the atoms table.
1571 (ctf_file_close): Destroy it.
1572 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
1573 special-case the position of the parname string. Construct the
1574 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
1575 rest of each buffer element is constructed, not via open-coding:
1576 realloc the CTF buffer and append the strtab to it. No longer
1577 maintain ctf_dtvstrlen. Sort the variable entry table later, after
1578 strtab construction.
1579 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
1580 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
1581 after buffer element construction instead.
1582 (ctf_copy_lmembers): Likewise.
1583 (ctf_copy_emembers): Likewise.
1584 (ctf_create): No longer maintain the ctf_dtvstrlen.
1585 (ctf_dtd_delete): Likewise.
1586 (ctf_dvd_delete): Likewise.
1587 (ctf_add_generic): Likewise.
1588 (ctf_add_enumerator): Likewise.
1589 (ctf_add_member_offset): Likewise.
1590 (ctf_add_variable): Likewise.
1591 (membadd): Likewise.
1592 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
1593 if there are active ctf_str_num_refs.
1594 (ctf_strraw): Move to ctf-string.c.
1595 (ctf_strptr): Likewise.
1596 * ctf-string.c: New file, strtab manipulation.
1598 * Makefile.am (libctf_a_SOURCES): Add it.
1599 * Makefile.in: Regenerate.
1601 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1603 * ctf-impl.h (ctf_hash_iter_f): New.
1604 (ctf_dynhash_iter): New declaration.
1605 (ctf_dynhash_iter_remove): New declaration.
1606 * ctf-hash.c (ctf_dynhash_iter): Define.
1607 (ctf_dynhash_iter_remove): Likewise.
1608 (ctf_hashtab_traverse): New.
1609 (ctf_hashtab_traverse_remove): Likewise.
1610 (struct ctf_traverse_cb_arg): Likewise.
1611 (struct ctf_traverse_remove_cb_arg): Likewise.
1613 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1615 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
1617 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
1619 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
1620 (ctf_dump_funcs): Likewise.
1622 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1624 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
1625 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
1626 little-endian CTF archive magic. Do not check the CTF version:
1627 ctf_simple_open does that in endian-safe ways. Do not dereference
1628 null pointers on open failure.
1630 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1632 * ctf-open.c (get_vbytes_common): Return the new slice size.
1633 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
1634 Remember to copy in the CTF data when opening an uncompressed
1635 foreign-endian CTF file. Prune useless variable manipulation.
1637 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1639 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
1642 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1644 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
1647 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1649 * ctf-subr.c (_PAGESIZE): Remove.
1650 (ctf_data_alloc): Likewise.
1651 (ctf_data_free): Likewise.
1652 (ctf_data_protect): Likewise.
1653 * ctf-impl.h: Remove declarations.
1654 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
1655 ctf_free, not ctf_data_free.
1656 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
1657 the buffer again on compression error.
1658 * ctf-open.c (ctf_set_base): No longer track the size: call
1659 ctf_free, not ctf_data_free.
1660 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
1661 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
1663 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
1665 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
1667 (ctf_dvd_insert): Likewise.
1668 (ctf_add_generic): Likewise.
1669 (ctf_add_variable): Likewise.
1670 * ctf-impl.h: Adjust declarations.
1672 2019-06-14 Alan Modra <amodra@gmail.com>
1674 * configure: Regenerate.
1676 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1678 * ctf-decls.h: Include <libiberty.h>.
1679 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
1681 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1683 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
1684 (ctf_dump_objts): Likewise.
1685 (ctf_dump_funcs): Likewise.
1686 (ctf_dump_member): Likewise.
1687 (ctf_dump_str): Likewise.
1689 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
1691 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
1692 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
1694 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
1696 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
1697 (ctf_arc_open_by_offset): Likewise.
1698 * ctf-create.c (ctf_add_type): Likewise.
1700 2019-06-04 Tom Tromey <tromey@adacore.com>
1702 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
1703 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
1705 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1707 * configure.ac: Check for O_CLOEXEC.
1708 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
1709 * config.h.in: Regenerate.
1710 * configure: Likewise.
1712 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
1714 * qsort_r.c: Rename to...
1715 * ctf-qsort_r.c: ... this.
1716 (_quicksort): Define to ctf_qsort_r.
1717 * ctf-decls.h (qsort_r): Remove.
1719 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
1720 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
1721 * Makefile.am (libctf_a_LIBADD): Remove.
1722 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
1723 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
1724 * ctf-create.c (ctf_update): Likewise.
1725 * configure.ac: Check for BSD versus GNU qsort_r signature.
1726 * Makefile.in: Regenerate.
1727 * config.h.in: Likewise.
1728 * configure: Likewise.
1730 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
1732 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
1734 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
1736 * Makefile.am (ZLIB): New.
1737 (ZLIBINC): Likewise.
1738 (AM_CFLAGS): Use them.
1739 (libctf_a_LIBADD): New, for LIBOBJS.
1740 * configure.ac: Check for zlib, endian.h, and qsort_r.
1741 * ctf-endian.h: New, providing htole64 and le64toh.
1742 * swap.h: Code style fixes.
1743 (bswap_identity_64): New.
1744 * qsort_r.c: New, from gnulib (with one added #include).
1745 * ctf-decls.h: New, providing a conditional qsort_r declaration,
1746 and unconditional definitions of MIN and MAX.
1747 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
1748 (ctf_set_errno): Now returns unsigned long.
1749 * ctf-util.c (ctf_set_errno): Adjust here too.
1750 * ctf-archive.c: Use ctf-endian.h.
1751 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
1752 cts_flags and cts_offset.
1753 (ctf_arc_write): Drop debugging dependent on the size of off_t.
1754 * ctf-create.c: Provide a definition of roundup if not defined.
1755 (ctf_create): Drop cts_type, cts_flags and cts_offset.
1756 (ctf_add_reftype): Do not check if type IDs are below zero.
1757 (ctf_add_slice): Likewise.
1758 (ctf_add_typedef): Likewise.
1759 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
1760 when known error-free. Drop CTF_ERR usage for functions returning
1762 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
1764 (ctf_add_variable): Likewise.
1765 (enumcmp): Likewise.
1766 (enumadd): Likewise.
1767 (membcmp): Likewise.
1768 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
1769 when known error-free.
1770 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
1771 returning int: use CTF_ERR for functions returning ctf_type_id.
1772 (ctf_dump_label): Likewise.
1773 (ctf_dump_objts): Likewise.
1774 * ctf-labels.c (ctf_label_topmost): Likewise.
1775 (ctf_label_iter): Likewise.
1776 (ctf_label_info): Likewise.
1777 * ctf-lookup.c (ctf_func_args): Likewise.
1778 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
1779 (ctf_bufopen): Likewise. Use zlib types as needed.
1780 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
1782 (ctf_enum_iter): Likewise.
1783 (ctf_type_size): Likewise.
1784 (ctf_type_align): Likewise. Cast to size_t where appropriate.
1785 (ctf_type_kind_unsliced): Likewise.
1786 (ctf_type_kind): Likewise.
1787 (ctf_type_encoding): Likewise.
1788 (ctf_member_info): Likewise.
1789 (ctf_array_info): Likewise.
1790 (ctf_enum_value): Likewise.
1791 (ctf_type_rvisit): Likewise.
1792 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
1794 (ctf_simple_open): Likewise.
1795 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
1796 * Makefile.in: Regenerate.
1797 * aclocal.m4: Likewise.
1798 * config.h: Likewise.
1799 * configure: Likewise.
1801 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1803 * configure.in: Check for bfd_section_from_elf_index.
1804 * configure: Regenerate.
1805 * config.h.in [HAVE_BFD_ELF]: Likewise.
1806 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
1807 abfd is potentially unused now.
1809 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1812 * Makefile.in: Regenerated.
1813 * config.h.in: Likewise.
1814 * aclocal.m4: Likewise.
1815 * configure: Likewise.
1817 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1821 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1823 * ctf-labels.c: New.
1825 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1827 * ctf-impl.h (_libctf_version): New declaration.
1828 * ctf-subr.c (_libctf_version): Define it.
1831 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1833 * ctf-create.c (enumcmp): New.
1834 (enumadd): Likewise.
1835 (membcmp): Likewise.
1836 (membadd): Likewise.
1837 (ctf_add_type): Likewise.
1839 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1841 * ctf-lookup.c (isqualifier): New.
1842 (ctf_lookup_by_name): Likewise.
1843 (struct ctf_lookup_var_key): Likewise.
1844 (ctf_lookup_var): Likewise.
1845 (ctf_lookup_variable): Likewise.
1846 (ctf_lookup_symbol_name): Likewise.
1847 (ctf_lookup_by_symbol): Likewise.
1848 (ctf_func_info): Likewise.
1849 (ctf_func_args): Likewise.
1851 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1853 * ctf-decl.c: New file.
1854 * ctf-types.c: Likewise.
1855 * ctf-impl.h: New declarations.
1857 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1859 * ctf-open-bfd.c: New file.
1860 * ctf-open.c (ctf_close): New.
1861 * ctf-impl.h: Include bfd.h.
1862 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
1863 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
1865 (ctf_bfdopen_ctfsect): New declaration.
1866 (_CTF_SECTION): likewise.
1868 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1870 * ctf-archive.c: New.
1871 * ctf-impl.h (ctf_archive_internal): New type.
1872 (ctf_arc_open_internal): New declaration.
1873 (ctf_arc_bufopen): Likewise.
1874 (ctf_arc_close_internal): Likewise.
1876 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1878 * ctf-open.c: New file.
1881 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1883 * ctf-create.c: New file.
1884 * ctf-lookup.c: New file.
1886 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1888 * ctf-impl.h: New definitions and declarations for type creation
1891 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1893 * ctf-hash.c: New file.
1894 * ctf-impl.h: New declarations.
1896 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1898 * ctf-error.c: New file.
1900 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1902 * ctf-util.c: New file.
1904 * ctf-impl.h: Include it, and add declarations.
1906 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1908 * ctf-impl.h: New file.
1909 * ctf-subr.c: New file.
1916 version-control: never