PR25961, buffer overflow in coff_swap_aux_in

[deliverable/binutils-gdb.git] / bfd / pef.c

diff --git a/bfd/pef.c b/bfd/pef.c
index 92a580907e440973bacac8c766d4ffd0c04c5ba6..4e749e1949789946e540420920be43a940d5118d 100644 (file)
--- a/bfd/pef.c
+++ b/bfd/pef.c
@@ -1,12 +1,11 @@
 /* PEF support for BFD.
 /* PEF support for BFD.

-   Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005
-   Free Software Foundation, Inc.
+   Copyright (C) 1999-2020 Free Software Foundation, Inc.

 
    This file is part of BFD, the Binary File Descriptor library.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 
    This file is part of BFD, the Binary File Descriptor library.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by

-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or

    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,
    (at your option) any later version.
 
    This program is distributed in the hope that it will be useful,


@@ -16,13 +15,18 @@
 
    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
 
    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software

-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02110-1301, USA.  */
+   Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
+   MA 02110-1301, USA.  */

 
 

+/* PEF (Preferred Executable Format) is the binary file format for late
+   classic Mac OS versions (before Darwin).  It is supported by both m68k
+   and PowerPc.  It is also called CFM (Code Fragment Manager).  */
+
+#include "sysdep.h"

 #include "safe-ctype.h"
 #include "pef.h"
 #include "pef-traceback.h"
 #include "bfd.h"
 #include "safe-ctype.h"
 #include "pef.h"
 #include "pef-traceback.h"
 #include "bfd.h"

-#include "sysdep.h"

 #include "libbfd.h"
 #include "libiberty.h"
 
 #include "libbfd.h"
 #include "libiberty.h"
 


@@ -30,36 +34,43 @@
 #define BFD_IO_FUNCS 0
 #endif
 
 #define BFD_IO_FUNCS 0
 #endif
 

-#define bfd_pef_close_and_cleanup                   _bfd_generic_close_and_cleanup
-#define bfd_pef_bfd_free_cached_info                _bfd_generic_bfd_free_cached_info
-#define bfd_pef_new_section_hook                    _bfd_generic_new_section_hook
-#define bfd_pef_bfd_is_local_label_name             bfd_generic_is_local_label_name
-#define bfd_pef_bfd_is_target_special_symbol ((bfd_boolean (*) (bfd *, asymbol *)) bfd_false)
-#define bfd_pef_get_lineno                          _bfd_nosymbols_get_lineno
-#define bfd_pef_find_nearest_line                   _bfd_nosymbols_find_nearest_line
-#define bfd_pef_bfd_make_debug_symbol               _bfd_nosymbols_bfd_make_debug_symbol
-#define bfd_pef_read_minisymbols                    _bfd_generic_read_minisymbols
-#define bfd_pef_minisymbol_to_symbol                _bfd_generic_minisymbol_to_symbol
-#define bfd_pef_get_reloc_upper_bound               _bfd_norelocs_get_reloc_upper_bound
-#define bfd_pef_canonicalize_reloc                  _bfd_norelocs_canonicalize_reloc
-#define bfd_pef_bfd_reloc_type_lookup               _bfd_norelocs_bfd_reloc_type_lookup
-#define bfd_pef_set_arch_mach                       _bfd_generic_set_arch_mach
-#define bfd_pef_get_section_contents                _bfd_generic_get_section_contents
-#define bfd_pef_set_section_contents                _bfd_generic_set_section_contents
+#define bfd_pef_close_and_cleanup                  _bfd_generic_close_and_cleanup
+#define bfd_pef_bfd_free_cached_info               _bfd_generic_bfd_free_cached_info
+#define bfd_pef_new_section_hook                   _bfd_generic_new_section_hook
+#define bfd_pef_bfd_is_local_label_name                    bfd_generic_is_local_label_name
+#define bfd_pef_bfd_is_target_special_symbol        _bfd_bool_bfd_asymbol_false
+#define bfd_pef_get_lineno                         _bfd_nosymbols_get_lineno
+#define bfd_pef_find_nearest_line                  _bfd_nosymbols_find_nearest_line
+#define bfd_pef_find_line                          _bfd_nosymbols_find_line
+#define bfd_pef_find_inliner_info                  _bfd_nosymbols_find_inliner_info
+#define bfd_pef_get_symbol_version_string          _bfd_nosymbols_get_symbol_version_string
+#define bfd_pef_bfd_make_debug_symbol              _bfd_nosymbols_bfd_make_debug_symbol
+#define bfd_pef_read_minisymbols                   _bfd_generic_read_minisymbols
+#define bfd_pef_minisymbol_to_symbol               _bfd_generic_minisymbol_to_symbol
+#define bfd_pef_set_arch_mach                      _bfd_generic_set_arch_mach
+#define bfd_pef_get_section_contents               _bfd_generic_get_section_contents
+#define bfd_pef_set_section_contents               _bfd_generic_set_section_contents

 #define bfd_pef_bfd_get_relocated_section_contents  bfd_generic_get_relocated_section_contents
 #define bfd_pef_bfd_get_relocated_section_contents  bfd_generic_get_relocated_section_contents

-#define bfd_pef_bfd_relax_section                   bfd_generic_relax_section
-#define bfd_pef_bfd_gc_sections                     bfd_generic_gc_sections
-#define bfd_pef_bfd_merge_sections                  bfd_generic_merge_sections
+#define bfd_pef_bfd_relax_section                  bfd_generic_relax_section
+#define bfd_pef_bfd_gc_sections                            bfd_generic_gc_sections
+#define bfd_pef_bfd_lookup_section_flags           bfd_generic_lookup_section_flags
+#define bfd_pef_bfd_merge_sections                 bfd_generic_merge_sections

 #define bfd_pef_bfd_is_group_section               bfd_generic_is_group_section
 #define bfd_pef_bfd_is_group_section               bfd_generic_is_group_section

-#define bfd_pef_bfd_discard_group                   bfd_generic_discard_group
-#define bfd_pef_section_already_linked             _bfd_generic_section_already_linked
-#define bfd_pef_bfd_link_hash_table_create          _bfd_generic_link_hash_table_create
-#define bfd_pef_bfd_link_hash_table_free            _bfd_generic_link_hash_table_free
-#define bfd_pef_bfd_link_add_symbols                _bfd_generic_link_add_symbols
-#define bfd_pef_bfd_link_just_syms                  _bfd_generic_link_just_syms
-#define bfd_pef_bfd_final_link                      _bfd_generic_final_link
-#define bfd_pef_bfd_link_split_section              _bfd_generic_link_split_section
-#define bfd_pef_get_section_contents_in_window      _bfd_generic_get_section_contents_in_window
+#define bfd_pef_bfd_group_name                     bfd_generic_group_name
+#define bfd_pef_bfd_discard_group                  bfd_generic_discard_group
+#define bfd_pef_section_already_linked             _bfd_generic_section_already_linked
+#define bfd_pef_bfd_define_common_symbol           bfd_generic_define_common_symbol
+#define bfd_pef_bfd_link_hide_symbol               _bfd_generic_link_hide_symbol
+#define bfd_pef_bfd_define_start_stop              bfd_generic_define_start_stop
+#define bfd_pef_bfd_link_hash_table_create         _bfd_generic_link_hash_table_create
+#define bfd_pef_bfd_link_add_symbols               _bfd_generic_link_add_symbols
+#define bfd_pef_bfd_link_just_syms                 _bfd_generic_link_just_syms
+#define bfd_pef_bfd_copy_link_hash_symbol_type \
+  _bfd_generic_copy_link_hash_symbol_type
+#define bfd_pef_bfd_final_link                     _bfd_generic_final_link
+#define bfd_pef_bfd_link_split_section             _bfd_generic_link_split_section
+#define bfd_pef_get_section_contents_in_window     _bfd_generic_get_section_contents_in_window
+#define bfd_pef_bfd_link_check_relocs              _bfd_generic_link_check_relocs

 
 static int
 bfd_pef_parse_traceback_table (bfd *abfd,
 
 static int
 bfd_pef_parse_traceback_table (bfd *abfd,


@@ -98,7 +109,7 @@ bfd_pef_parse_traceback_table (bfd *abfd,
   if (! (table.flags2 & TB_NAME_PRESENT))
     return -1;
 
   if (! (table.flags2 & TB_NAME_PRESENT))
     return -1;
 

-  if (! table.flags1 & TB_HAS_TBOFF)
+  if (! (table.flags1 & TB_HAS_TBOFF))

     return -1;
 
   offset = 8;
     return -1;
 
   offset = 8;


@@ -187,7 +198,7 @@ bfd_pef_parse_traceback_table (bfd *abfd,
     offset += 4;
 
   if (file != NULL)
     offset += 4;
 
   if (file != NULL)

-    fprintf (file, " [length = 0x%lx]", (long) offset);
+    fprintf (file, " [length = 0x%lx]", (unsigned long) offset);

 
   return offset;
 }
 
   return offset;
 }


@@ -208,18 +219,20 @@ bfd_pef_print_symbol (bfd *abfd,
     default:
       bfd_print_symbol_vandf (abfd, (void *) file, symbol);
       fprintf (file, " %-5s %s", symbol->section->name, symbol->name);
     default:
       bfd_print_symbol_vandf (abfd, (void *) file, symbol);
       fprintf (file, " %-5s %s", symbol->section->name, symbol->name);

-      if (strncmp (symbol->name, "__traceback_", strlen ("__traceback_")) == 0)
+      if (CONST_STRNEQ (symbol->name, "__traceback_"))

        {
        {

-         unsigned char *buf = alloca (symbol->udata.i);
+         unsigned char *buf;

          size_t offset = symbol->value + 4;
          size_t len = symbol->udata.i;
          size_t offset = symbol->value + 4;
          size_t len = symbol->udata.i;

-         int ret;

 
 

-         bfd_get_section_contents (abfd, symbol->section, buf, offset, len);
-         ret = bfd_pef_parse_traceback_table (abfd, symbol->section, buf,
-                                              len, 0, NULL, file);
-         if (ret < 0)
+         buf = bfd_malloc (len);
+         if (buf == NULL
+             || !bfd_get_section_contents (abfd, symbol->section, buf,
+                                           offset, len)
+             || bfd_pef_parse_traceback_table (abfd, symbol->section, buf,
+                                               len, 0, NULL, file) < 0)

            fprintf (file, " [ERROR]");
            fprintf (file, " [ERROR]");

+         free (buf);

        }
     }
 }
        }
     }
 }


@@ -361,7 +374,7 @@ bfd_pef_parse_imported_symbol (bfd *abfd ATTRIBUTE_UNUSED,
   BFD_ASSERT (len == 4);
 
   value = bfd_getb32 (buf);
   BFD_ASSERT (len == 4);
 
   value = bfd_getb32 (buf);

-  symbol->class = value >> 24;
+  symbol->symbol_class = value >> 24;

   symbol->name = value & 0x00ffffff;
 
   return 0;
   symbol->name = value & 0x00ffffff;
 
   return 0;


@@ -433,12 +446,15 @@ bfd_pef_print_loader_section (bfd *abfd, FILE *file)
     return -1;
 
   loaderlen = loadersec->size;
     return -1;
 
   loaderlen = loadersec->size;

-  loaderbuf = bfd_malloc (loaderlen);
+  if (loaderlen < 56)
+    return -1;
+  if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) != 0)
+    return -1;
+  loaderbuf = _bfd_malloc_and_read (abfd, loaderlen, loaderlen);
+  if (loaderbuf == NULL)
+    return -1;

 
 

-  if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) < 0
-      || bfd_bread ((void *) loaderbuf, loaderlen, abfd) != loaderlen
-      || loaderlen < 56
-      || bfd_pef_parse_loader_header (abfd, loaderbuf, 56, &header) < 0)
+  if (bfd_pef_parse_loader_header (abfd, loaderbuf, 56, &header) < 0)

     {
       free (loaderbuf);
       return -1;
     {
       free (loaderbuf);
       return -1;


@@ -464,14 +480,14 @@ bfd_pef_scan_start_address (bfd *abfd)
     goto end;
 
   loaderlen = loadersec->size;
     goto end;
 
   loaderlen = loadersec->size;

-  loaderbuf = bfd_malloc (loaderlen);
-  if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) < 0)
+  if (loaderlen < 56)

     goto error;
     goto error;

-  if (bfd_bread ((void *) loaderbuf, loaderlen, abfd) != loaderlen)
+  if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) != 0)

     goto error;
     goto error;

-
-  if (loaderlen < 56)
+  loaderbuf = _bfd_malloc_and_read (abfd, loaderlen, loaderlen);
+  if (loaderbuf == NULL)

     goto error;
     goto error;

+

   ret = bfd_pef_parse_loader_header (abfd, loaderbuf, 56, &header);
   if (ret < 0)
     goto error;
   ret = bfd_pef_parse_loader_header (abfd, loaderbuf, 56, &header);
   if (ret < 0)
     goto error;


@@ -480,7 +496,7 @@ bfd_pef_scan_start_address (bfd *abfd)
     goto end;
 
   for (section = abfd->sections; section != NULL; section = section->next)
     goto end;
 
   for (section = abfd->sections; section != NULL; section = section->next)

-    if ((section->index + 1) == header.main_section)
+    if ((long) (section->index + 1) == header.main_section)

       break;
 
   if (section == NULL)
       break;
 
   if (section == NULL)


@@ -500,10 +516,9 @@ bfd_pef_scan_start_address (bfd *abfd)
 }
 
 int
 }
 
 int

-bfd_pef_scan (abfd, header, mdata)
-     bfd *abfd;
-     bfd_pef_header *header;
-     bfd_pef_data_struct *mdata;
+bfd_pef_scan (bfd *abfd,
+             bfd_pef_header *header,
+             bfd_pef_data_struct *mdata)

 {
   unsigned int i;
   enum bfd_architecture cputype;
 {
   unsigned int i;
   enum bfd_architecture cputype;


@@ -514,8 +529,8 @@ bfd_pef_scan (abfd, header, mdata)
   bfd_pef_convert_architecture (header->architecture, &cputype, &cpusubtype);
   if (cputype == bfd_arch_unknown)
     {
   bfd_pef_convert_architecture (header->architecture, &cputype, &cpusubtype);
   if (cputype == bfd_arch_unknown)
     {

-      fprintf (stderr, "bfd_pef_scan: unknown architecture 0x%lx\n",
-              header->architecture);
+      _bfd_error_handler (_("bfd_pef_scan: unknown architecture 0x%lx"),
+                         header->architecture);

       return -1;
     }
   bfd_set_arch_mach (abfd, cputype, cpusubtype);
       return -1;
     }
   bfd_set_arch_mach (abfd, cputype, cpusubtype);


@@ -574,37 +589,31 @@ bfd_pef_read_header (bfd *abfd, bfd_pef_header *header)
   return 0;
 }
 
   return 0;
 }
 

-static const bfd_target *
+static bfd_cleanup

 bfd_pef_object_p (bfd *abfd)
 {
 bfd_pef_object_p (bfd *abfd)
 {

-  struct bfd_preserve preserve;

   bfd_pef_header header;
   bfd_pef_header header;

+  bfd_pef_data_struct *mdata;

 
 

-  preserve.marker = NULL;

   if (bfd_pef_read_header (abfd, &header) != 0)
     goto wrong;
 
   if (header.tag1 != BFD_PEF_TAG1 || header.tag2 != BFD_PEF_TAG2)
     goto wrong;
 
   if (bfd_pef_read_header (abfd, &header) != 0)
     goto wrong;
 
   if (header.tag1 != BFD_PEF_TAG1 || header.tag2 != BFD_PEF_TAG2)
     goto wrong;
 

-  preserve.marker = bfd_zalloc (abfd, sizeof (bfd_pef_data_struct));
-  if (preserve.marker == NULL
-      || !bfd_preserve_save (abfd, &preserve))
+  mdata = (bfd_pef_data_struct *) bfd_zalloc (abfd, sizeof (*mdata));
+  if (mdata == NULL)

     goto fail;
 
     goto fail;
 

-  if (bfd_pef_scan (abfd, &header,
-                   (bfd_pef_data_struct *) preserve.marker) != 0)
+  if (bfd_pef_scan (abfd, &header, mdata))

     goto wrong;
 
     goto wrong;
 

-  bfd_preserve_finish (abfd, &preserve);
-  return abfd->xvec;
+  return _bfd_no_cleanup;

 
  wrong:
   bfd_set_error (bfd_error_wrong_format);
 
  fail:
 
  wrong:
   bfd_set_error (bfd_error_wrong_format);
 
  fail:

-  if (preserve.marker != NULL)
-    bfd_preserve_restore (abfd, &preserve);

   return NULL;
 }
 
   return NULL;
 }
 


@@ -728,14 +737,11 @@ bfd_pef_parse_function_stubs (bfd *abfd,
                              asymbol **csym)
 {
   const char *const sprefix = "__stub_";
                              asymbol **csym)
 {
   const char *const sprefix = "__stub_";

-

   size_t codepos = 0;
   unsigned long count = 0;
   size_t codepos = 0;
   unsigned long count = 0;

-

   bfd_pef_loader_header header;
   bfd_pef_imported_library *libraries = NULL;
   bfd_pef_imported_symbol *imports = NULL;
   bfd_pef_loader_header header;
   bfd_pef_imported_library *libraries = NULL;
   bfd_pef_imported_symbol *imports = NULL;

-

   unsigned long i;
   int ret;
 
   unsigned long i;
   int ret;
 


@@ -750,6 +756,8 @@ bfd_pef_parse_function_stubs (bfd *abfd,
     (header.imported_library_count * sizeof (bfd_pef_imported_library));
   imports = bfd_malloc
     (header.total_imported_symbol_count * sizeof (bfd_pef_imported_symbol));
     (header.imported_library_count * sizeof (bfd_pef_imported_library));
   imports = bfd_malloc
     (header.total_imported_symbol_count * sizeof (bfd_pef_imported_symbol));

+  if (libraries == NULL || imports == NULL)
+    goto error;

 
   if (loaderlen < (56 + (header.imported_library_count * 24)))
     goto error;
 
   if (loaderlen < (56 + (header.imported_library_count * 24)))
     goto error;


@@ -781,8 +789,7 @@ bfd_pef_parse_function_stubs (bfd *abfd,
       asymbol sym;
       const char *symname;
       char *name;
       asymbol sym;
       const char *symname;
       char *name;

-      unsigned long index;
-      int ret;
+      unsigned long sym_index;

 
       if (csym && (csym[count] == NULL))
        break;
 
       if (csym && (csym[count] == NULL))
        break;


@@ -797,17 +804,17 @@ bfd_pef_parse_function_stubs (bfd *abfd,
          codepos += 4;
        }
 
          codepos += 4;
        }
 

-      if ((codepos + 4) > codelen)
+      if ((codepos + 24) > codelen)

        break;
 
        break;
 

-      ret = bfd_pef_parse_function_stub (abfd, codebuf + codepos, 24, &index);
+      ret = bfd_pef_parse_function_stub (abfd, codebuf + codepos, 24, &sym_index);

       if (ret < 0)
        {
          codepos += 24;
          continue;
        }
 
       if (ret < 0)
        {
          codepos += 24;
          continue;
        }
 

-      if (index >= header.total_imported_symbol_count)
+      if (sym_index >= header.total_imported_symbol_count)

        {
          codepos += 24;
          continue;
        {
          codepos += 24;
          continue;


@@ -817,12 +824,12 @@ bfd_pef_parse_function_stubs (bfd *abfd,
        size_t max, namelen;
        const char *s;
 
        size_t max, namelen;
        const char *s;
 

-       if (loaderlen < (header.loader_strings_offset + imports[index].name))
+       if (loaderlen < (header.loader_strings_offset + imports[sym_index].name))

          goto error;
 
          goto error;
 

-       max = loaderlen - (header.loader_strings_offset + imports[index].name);
+       max = loaderlen - (header.loader_strings_offset + imports[sym_index].name);

        symname = (char *) loaderbuf;
        symname = (char *) loaderbuf;

-       symname += header.loader_strings_offset + imports[index].name;
+       symname += header.loader_strings_offset + imports[sym_index].name;

        namelen = 0;
        for (s = symname; s < (symname + max); s++)
          {
        namelen = 0;
        for (s = symname; s < (symname + max); s++)
          {


@@ -894,10 +901,10 @@ bfd_pef_parse_symbols (bfd *abfd, asymbol **csym)
   if (codesec != NULL)
     {
       codelen = codesec->size;
   if (codesec != NULL)
     {
       codelen = codesec->size;

-      codebuf = bfd_malloc (codelen);
-      if (bfd_seek (abfd, codesec->filepos, SEEK_SET) < 0)
+      if (bfd_seek (abfd, codesec->filepos, SEEK_SET) != 0)

        goto end;
        goto end;

-      if (bfd_bread ((void *) codebuf, codelen, abfd) != codelen)
+      codebuf = _bfd_malloc_and_read (abfd, codelen, codelen);
+      if (codebuf == NULL)

        goto end;
     }
 
        goto end;
     }
 


@@ -905,10 +912,10 @@ bfd_pef_parse_symbols (bfd *abfd, asymbol **csym)
   if (loadersec != NULL)
     {
       loaderlen = loadersec->size;
   if (loadersec != NULL)
     {
       loaderlen = loadersec->size;

-      loaderbuf = bfd_malloc (loaderlen);
-      if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) < 0)
+      if (bfd_seek (abfd, loadersec->filepos, SEEK_SET) != 0)

        goto end;
        goto end;

-      if (bfd_bread ((void *) loaderbuf, loaderlen, abfd) != loaderlen)
+      loaderbuf = _bfd_malloc_and_read (abfd, loaderlen, loaderlen);
+      if (loaderbuf == NULL)

        goto end;
     }
 
        goto end;
     }
 


@@ -986,11 +993,7 @@ bfd_pef_canonicalize_symtab (bfd *abfd, asymbol **alocation)
   return ret;
 }
 
   return ret;
 }
 

-static asymbol *
-bfd_pef_make_empty_symbol (bfd *abfd)
-{
-  return bfd_alloc (abfd, sizeof (asymbol));
-}
+#define bfd_pef_make_empty_symbol _bfd_generic_make_empty_symbol

 
 static void
 bfd_pef_get_symbol_info (bfd *abfd ATTRIBUTE_UNUSED,
 
 static void
 bfd_pef_get_symbol_info (bfd *abfd ATTRIBUTE_UNUSED,


@@ -1001,7 +1004,8 @@ bfd_pef_get_symbol_info (bfd *abfd ATTRIBUTE_UNUSED,
 }
 
 static int
 }
 
 static int

-bfd_pef_sizeof_headers (bfd *abfd ATTRIBUTE_UNUSED, bfd_boolean exec ATTRIBUTE_UNUSED)
+bfd_pef_sizeof_headers (bfd *abfd ATTRIBUTE_UNUSED,
+                       struct bfd_link_info *info ATTRIBUTE_UNUSED)

 {
   return 0;
 }
 {
   return 0;
 }


@@ -1020,6 +1024,7 @@ const bfd_target pef_vec =
   0,                           /* Symbol_leading_char.  */
   ' ',                         /* AR_pad_char.  */
   16,                          /* AR_max_namelen.  */
   0,                           /* Symbol_leading_char.  */
   ' ',                         /* AR_pad_char.  */
   16,                          /* AR_max_namelen.  */

+  0,                           /* match priority.  */

   bfd_getb64, bfd_getb_signed_64, bfd_putb64,
   bfd_getb32, bfd_getb_signed_32, bfd_putb32,
   bfd_getb16, bfd_getb_signed_16, bfd_putb16,  /* Data.  */
   bfd_getb64, bfd_getb_signed_64, bfd_putb64,
   bfd_getb32, bfd_getb_signed_32, bfd_putb32,
   bfd_getb16, bfd_getb_signed_16, bfd_putb16,  /* Data.  */


@@ -1033,16 +1038,16 @@ const bfd_target pef_vec =
     _bfd_dummy_target,
   },
   {                            /* bfd_set_format.  */
     _bfd_dummy_target,
   },
   {                            /* bfd_set_format.  */

-    bfd_false,
+    _bfd_bool_bfd_false_error,

     bfd_pef_mkobject,
     bfd_pef_mkobject,

-    bfd_false,
-    bfd_false,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_false_error,

   },
   {                            /* bfd_write_contents.  */
   },
   {                            /* bfd_write_contents.  */

-    bfd_false,
-    bfd_true,
-    bfd_false,
-    bfd_false,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_true,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_false_error,

   },
 
   BFD_JUMP_TABLE_GENERIC (bfd_pef),
   },
 
   BFD_JUMP_TABLE_GENERIC (bfd_pef),


@@ -1050,7 +1055,7 @@ const bfd_target pef_vec =
   BFD_JUMP_TABLE_CORE (_bfd_nocore),
   BFD_JUMP_TABLE_ARCHIVE (_bfd_noarchive),
   BFD_JUMP_TABLE_SYMBOLS (bfd_pef),
   BFD_JUMP_TABLE_CORE (_bfd_nocore),
   BFD_JUMP_TABLE_ARCHIVE (_bfd_noarchive),
   BFD_JUMP_TABLE_SYMBOLS (bfd_pef),

-  BFD_JUMP_TABLE_RELOCS (bfd_pef),
+  BFD_JUMP_TABLE_RELOCS (_bfd_norelocs),

   BFD_JUMP_TABLE_WRITE (bfd_pef),
   BFD_JUMP_TABLE_LINK (bfd_pef),
   BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic),
   BFD_JUMP_TABLE_WRITE (bfd_pef),
   BFD_JUMP_TABLE_LINK (bfd_pef),
   BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic),


@@ -1060,22 +1065,22 @@ const bfd_target pef_vec =
   NULL
 };
 
   NULL
 };
 

-#define bfd_pef_xlib_close_and_cleanup              _bfd_generic_close_and_cleanup
-#define bfd_pef_xlib_bfd_free_cached_info           _bfd_generic_bfd_free_cached_info
-#define bfd_pef_xlib_new_section_hook               _bfd_generic_new_section_hook
-#define bfd_pef_xlib_get_section_contents           _bfd_generic_get_section_contents
-#define bfd_pef_xlib_set_section_contents           _bfd_generic_set_section_contents
+#define bfd_pef_xlib_close_and_cleanup             _bfd_generic_close_and_cleanup
+#define bfd_pef_xlib_bfd_free_cached_info          _bfd_generic_bfd_free_cached_info
+#define bfd_pef_xlib_new_section_hook              _bfd_generic_new_section_hook
+#define bfd_pef_xlib_get_section_contents          _bfd_generic_get_section_contents
+#define bfd_pef_xlib_set_section_contents          _bfd_generic_set_section_contents

 #define bfd_pef_xlib_get_section_contents_in_window _bfd_generic_get_section_contents_in_window
 #define bfd_pef_xlib_set_section_contents_in_window _bfd_generic_set_section_contents_in_window
 
 static int
 bfd_pef_xlib_read_header (bfd *abfd, bfd_pef_xlib_header *header)
 {
 #define bfd_pef_xlib_get_section_contents_in_window _bfd_generic_get_section_contents_in_window
 #define bfd_pef_xlib_set_section_contents_in_window _bfd_generic_set_section_contents_in_window
 
 static int
 bfd_pef_xlib_read_header (bfd *abfd, bfd_pef_xlib_header *header)
 {

-  unsigned char buf[76];
+  unsigned char buf[80];

 
   bfd_seek (abfd, 0, SEEK_SET);
 
 
   bfd_seek (abfd, 0, SEEK_SET);
 

-  if (bfd_bread ((void *) buf, 76, abfd) != 76)
+  if (bfd_bread ((void *) buf, sizeof buf, abfd) != sizeof buf)

     return -1;
 
   header->tag1 = bfd_getb32 (buf);
     return -1;
 
   header->tag1 = bfd_getb32 (buf);


@@ -1121,10 +1126,9 @@ bfd_pef_xlib_scan (bfd *abfd, bfd_pef_xlib_header *header)
   return 0;
 }
 
   return 0;
 }
 

-static const bfd_target *
+static bfd_cleanup

 bfd_pef_xlib_object_p (bfd *abfd)
 {
 bfd_pef_xlib_object_p (bfd *abfd)
 {

-  struct bfd_preserve preserve;

   bfd_pef_xlib_header header;
 
   if (bfd_pef_xlib_read_header (abfd, &header) != 0)
   bfd_pef_xlib_header header;
 
   if (bfd_pef_xlib_read_header (abfd, &header) != 0)


@@ -1141,21 +1145,13 @@ bfd_pef_xlib_object_p (bfd *abfd)
       return NULL;
     }
 
       return NULL;
     }
 

-  if (! bfd_preserve_save (abfd, &preserve))
-    {
-      bfd_set_error (bfd_error_wrong_format);
-      return NULL;
-    }
-

   if (bfd_pef_xlib_scan (abfd, &header) != 0)
     {
   if (bfd_pef_xlib_scan (abfd, &header) != 0)
     {

-      bfd_preserve_restore (abfd, &preserve);

       bfd_set_error (bfd_error_wrong_format);
       return NULL;
     }
 
       bfd_set_error (bfd_error_wrong_format);
       return NULL;
     }
 

-  bfd_preserve_finish (abfd, &preserve);
-  return abfd->xvec;
+  return _bfd_no_cleanup;

 }
 
 const bfd_target pef_xlib_vec =
 }
 
 const bfd_target pef_xlib_vec =


@@ -1172,6 +1168,7 @@ const bfd_target pef_xlib_vec =
   0,                           /* Symbol_leading_char.  */
   ' ',                         /* AR_pad_char.  */
   16,                          /* AR_max_namelen.  */
   0,                           /* Symbol_leading_char.  */
   ' ',                         /* AR_pad_char.  */
   16,                          /* AR_max_namelen.  */

+  0,                           /* match priority.  */

   bfd_getb64, bfd_getb_signed_64, bfd_putb64,
   bfd_getb32, bfd_getb_signed_32, bfd_putb32,
   bfd_getb16, bfd_getb_signed_16, bfd_putb16,  /* Data.  */
   bfd_getb64, bfd_getb_signed_64, bfd_putb64,
   bfd_getb32, bfd_getb_signed_32, bfd_putb32,
   bfd_getb16, bfd_getb_signed_16, bfd_putb16,  /* Data.  */


@@ -1185,16 +1182,16 @@ const bfd_target pef_xlib_vec =
     _bfd_dummy_target,
   },
   {                            /* bfd_set_format.  */
     _bfd_dummy_target,
   },
   {                            /* bfd_set_format.  */

-    bfd_false,
+    _bfd_bool_bfd_false_error,

     bfd_pef_mkobject,
     bfd_pef_mkobject,

-    bfd_false,
-    bfd_false,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_false_error,

   },
   {                            /* bfd_write_contents.  */
   },
   {                            /* bfd_write_contents.  */

-    bfd_false,
-    bfd_true,
-    bfd_false,
-    bfd_false,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_true,
+    _bfd_bool_bfd_false_error,
+    _bfd_bool_bfd_false_error,

   },
 
   BFD_JUMP_TABLE_GENERIC (bfd_pef_xlib),
   },
 
   BFD_JUMP_TABLE_GENERIC (bfd_pef_xlib),