Multi-target support

[deliverable/binutils-gdb.git] / gdb / windows-nat.c

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index d38ade5855b660585664e654dfb83ee16442e6f9..be5955d379fb4efcca6779b0aea1036d40657174 100644 (file)
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1,6 +1,6 @@
 /* Target-vector operations for controlling windows child processes, for GDB.
 
 /* Target-vector operations for controlling windows child processes, for GDB.
 

-   Copyright (C) 1995-2019 Free Software Foundation, Inc.
+   Copyright (C) 1995-2020 Free Software Foundation, Inc.

 
    Contributed by Cygnus Solutions, A Red Hat Company.
 
 
    Contributed by Cygnus Solutions, A Red Hat Company.
 


@@ -44,7 +44,6 @@
 #endif
 #include <algorithm>
 
 #endif
 #include <algorithm>
 

-#include "buildsym-legacy.h"

 #include "filenames.h"
 #include "symfile.h"
 #include "objfiles.h"
 #include "filenames.h"
 #include "symfile.h"
 #include "objfiles.h"


@@ -67,8 +66,9 @@
 #include "x86-nat.h"
 #include "complaints.h"
 #include "inf-child.h"
 #include "x86-nat.h"
 #include "complaints.h"
 #include "inf-child.h"

-#include "common/gdb_tilde_expand.h"
-#include "common/pathstuff.h"
+#include "gdbsupport/gdb_tilde_expand.h"
+#include "gdbsupport/pathstuff.h"
+#include "gdbsupport/gdb_wait.h"

 
 #define AdjustTokenPrivileges          dyn_AdjustTokenPrivileges
 #define DebugActiveProcessStop         dyn_DebugActiveProcessStop
 
 #define AdjustTokenPrivileges          dyn_AdjustTokenPrivileges
 #define DebugActiveProcessStop         dyn_DebugActiveProcessStop


@@ -148,7 +148,7 @@ static GetConsoleFontSize_ftype *GetConsoleFontSize;
 static int have_saved_context; /* True if we've saved context from a
                                   cygwin signal.  */
 #ifdef __CYGWIN__
 static int have_saved_context; /* True if we've saved context from a
                                   cygwin signal.  */
 #ifdef __CYGWIN__

-static CONTEXT saved_context;  /* Containes the saved context from a
+static CONTEXT saved_context;  /* Contains the saved context from a

                                   cygwin signal.  */
 #endif
 
                                   cygwin signal.  */
 #endif
 


@@ -225,7 +225,6 @@ typedef struct windows_thread_info_struct
     int suspended;
     int reload_context;
     CONTEXT context;
     int suspended;
     int reload_context;
     CONTEXT context;

-    STACKFRAME sf;

   }
 windows_thread_info;
 
   }
 windows_thread_info;
 


@@ -237,7 +236,6 @@ static DEBUG_EVENT current_event;   /* The current debug event from
                                           WaitForDebugEvent */
 static HANDLE current_process_handle;  /* Currently executing process */
 static windows_thread_info *current_thread;    /* Info on currently selected thread */
                                           WaitForDebugEvent */
 static HANDLE current_process_handle;  /* Currently executing process */
 static windows_thread_info *current_thread;    /* Info on currently selected thread */

-static DWORD main_thread_id;           /* Thread ID of the main thread */

 
 /* Counts of things.  */
 static int exception_count = 0;
 
 /* Counts of things.  */
 static int exception_count = 0;


@@ -246,16 +244,16 @@ static int saw_create;
 static int open_process_used = 0;
 
 /* User options.  */
 static int open_process_used = 0;
 
 /* User options.  */

-static int new_console = 0;
+static bool new_console = false;

 #ifdef __CYGWIN__
 #ifdef __CYGWIN__

-static int cygwin_exceptions = 0;
+static bool cygwin_exceptions = false;

 #endif
 #endif

-static int new_group = 1;
-static int debug_exec = 0;             /* show execution */
-static int debug_events = 0;           /* show events from kernel */
-static int debug_memory = 0;           /* show target memory accesses */
-static int debug_exceptions = 0;       /* show target exceptions */
-static int useshell = 0;               /* use shell for subprocesses */
+static bool new_group = true;
+static bool debug_exec = false;                /* show execution */
+static bool debug_events = false;      /* show events from kernel */
+static bool debug_memory = false;      /* show target memory accesses */
+static bool debug_exceptions = false;  /* show target exceptions */
+static bool useshell = false;          /* use shell for subprocesses */

 
 /* This vector maps GDB's idea of a register's number into an offset
    in the windows exception context vector.
 
 /* This vector maps GDB's idea of a register's number into an offset
    in the windows exception context vector.


@@ -352,6 +350,8 @@ struct windows_nat_target final : public x86_nat_target<inf_child_target>
   bool get_tib_address (ptid_t ptid, CORE_ADDR *addr) override;
 
   const char *thread_name (struct thread_info *) override;
   bool get_tib_address (ptid_t ptid, CORE_ADDR *addr) override;
 
   const char *thread_name (struct thread_info *) override;

+
+  int get_windows_debug_event (int pid, struct target_waitstatus *ourstatus);

 };
 
 static windows_nat_target the_windows_nat_target;
 };
 
 static windows_nat_target the_windows_nat_target;


@@ -460,9 +460,9 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, bool main_thread_p)
      the main thread silently (in reality, this thread is really
      more of a process to the user than a thread).  */
   if (main_thread_p)
      the main thread silently (in reality, this thread is really
      more of a process to the user than a thread).  */
   if (main_thread_p)

-    add_thread_silent (ptid);
+    add_thread_silent (&the_windows_nat_target, ptid);

   else
   else

-    add_thread (ptid);
+    add_thread (&the_windows_nat_target, ptid);

 
   /* Set the debug registers for the new thread if they are used.  */
   if (debug_registers_used)
 
   /* Set the debug registers for the new thread if they are used.  */
   if (debug_registers_used)


@@ -521,7 +521,7 @@ windows_delete_thread (ptid_t ptid, DWORD exit_code, bool main_thread_p)
 
      Note that no notification was printed when the main thread
      was created, and thus, unless in verbose mode, we should be
 
      Note that no notification was printed when the main thread
      was created, and thus, unless in verbose mode, we should be

-     symetrical, and avoid that notification for the main thread
+     symmetrical, and avoid that notification for the main thread

      here as well.  */
 
   if (info_verbose)
      here as well.  */
 
   if (info_verbose)


@@ -531,7 +531,7 @@ windows_delete_thread (ptid_t ptid, DWORD exit_code, bool main_thread_p)
                       target_pid_to_str (ptid).c_str (),
                       (unsigned) exit_code);
 
                       target_pid_to_str (ptid).c_str (),
                       (unsigned) exit_code);
 

-  delete_thread (find_thread_ptid (ptid));
+  delete_thread (find_thread_ptid (&the_windows_nat_target, ptid));

 
   for (th = &thread_head;
        th->next != NULL && th->next->id != id;
 
   for (th = &thread_head;
        th->next != NULL && th->next->id != id;


@@ -593,8 +593,8 @@ windows_fetch_one_register (struct regcache *regcache,
 void
 windows_nat_target::fetch_registers (struct regcache *regcache, int r)
 {
 void
 windows_nat_target::fetch_registers (struct regcache *regcache, int r)
 {

-  DWORD pid = regcache->ptid ().tid ();
-  windows_thread_info *th = thread_rec (pid, TRUE);
+  DWORD tid = regcache->ptid ().tid ();
+  windows_thread_info *th = thread_rec (tid, TRUE);

 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */
 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */


@@ -663,8 +663,8 @@ windows_store_one_register (const struct regcache *regcache,
 void
 windows_nat_target::store_registers (struct regcache *regcache, int r)
 {
 void
 windows_nat_target::store_registers (struct regcache *regcache, int r)
 {

-  DWORD pid = regcache->ptid ().tid ();
-  windows_thread_info *th = thread_rec (pid, TRUE);
+  DWORD tid = regcache->ptid ().tid ();
+  windows_thread_info *th = thread_rec (tid, TRUE);

 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */
 
   /* Check if TH exists.  Windows sometimes uses a non-existent
      thread id in its events.  */


@@ -678,19 +678,6 @@ windows_nat_target::store_registers (struct regcache *regcache, int r)
     windows_store_one_register (regcache, th, r);
 }
 
     windows_store_one_register (regcache, th, r);
 }
 

-/* Encapsulate the information required in a call to
-   symbol_file_add_args.  */
-struct safe_symbol_file_add_args
-{
-  char *name;
-  int from_tty;
-  section_addr_info *addrs;
-  int mainline;
-  int flags;
-  struct ui_file *err, *out;
-  struct objfile *ret;
-};
-

 /* Maintain a linked list of "so" information.  */
 struct lm_info_windows : public lm_info_base
 {
 /* Maintain a linked list of "so" information.  */
 struct lm_info_windows : public lm_info_base
 {


@@ -795,8 +782,7 @@ windows_make_so (const char *name, LPVOID load_addr)
         file header and the section alignment.  */
       cygwin_load_start = (CORE_ADDR) (uintptr_t) ((char *)
                                                   load_addr + 0x1000);
         file header and the section alignment.  */
       cygwin_load_start = (CORE_ADDR) (uintptr_t) ((char *)
                                                   load_addr + 0x1000);

-      cygwin_load_end = cygwin_load_start + bfd_section_size (abfd.get (),
-                                                             text);
+      cygwin_load_end = cygwin_load_start + bfd_section_size (text);

     }
 #endif
 
     }
 #endif
 


@@ -943,22 +929,28 @@ handle_unload_dll ()
 static void
 catch_errors (void (*func) ())
 {
 static void
 catch_errors (void (*func) ())
 {

-  TRY
+  try

     {
       func ();
     }
     {
       func ();
     }

-  CATCH (ex, RETURN_MASK_ALL)
+  catch (const gdb_exception &ex)

     {
       exception_print (gdb_stderr, ex);
     }
     {
       exception_print (gdb_stderr, ex);
     }

-  END_CATCH

 }
 
 /* Clear list of loaded DLLs.  */
 static void
 windows_clear_solib (void)
 {
 }
 
 /* Clear list of loaded DLLs.  */
 static void
 windows_clear_solib (void)
 {

-  solib_start.next = NULL;
+  struct so_list *so;
+
+  for (so = solib_start.next; so; so = solib_start.next)
+    {
+      solib_start.next = so->next;
+      windows_free_so (so);
+    }
+

   solib_end = &solib_start;
 }
 
   solib_end = &solib_start;
 }
 


@@ -1031,7 +1023,7 @@ handle_output_debug_string (struct target_waitstatus *ourstatus)
          ourstatus->kind = TARGET_WAITKIND_STOPPED;
          retval = strtoul (p, &p, 0);
          if (!retval)
          ourstatus->kind = TARGET_WAITKIND_STOPPED;
          retval = strtoul (p, &p, 0);
          if (!retval)

-           retval = main_thread_id;
+           retval = current_event.dwThreadId;

          else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0))
                   && ReadProcessMemory (current_process_handle, x,
                                         &saved_context,
          else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0))
                   && ReadProcessMemory (current_process_handle, x,
                                         &saved_context,


@@ -1096,14 +1088,16 @@ display_selector (HANDLE thread, DWORD sel)
          puts_filtered ("Code (Exec/Read, Conf");
          break;
        default:
          puts_filtered ("Code (Exec/Read, Conf");
          break;
        default:

-         printf_filtered ("Unknown type 0x%lx",info.HighWord.Bits.Type);
+         printf_filtered ("Unknown type 0x%lx",
+                          (unsigned long) info.HighWord.Bits.Type);

        }
       if ((info.HighWord.Bits.Type & 0x1) == 0)
        puts_filtered(", N.Acc");
       puts_filtered (")\n");
       if ((info.HighWord.Bits.Type & 0x10) == 0)
        puts_filtered("System selector ");
        }
       if ((info.HighWord.Bits.Type & 0x1) == 0)
        puts_filtered(", N.Acc");
       puts_filtered (")\n");
       if ((info.HighWord.Bits.Type & 0x10) == 0)
        puts_filtered("System selector ");

-      printf_filtered ("Priviledge level = %ld. ", info.HighWord.Bits.Dpl);
+      printf_filtered ("Priviledge level = %ld. ",
+                      (unsigned long) info.HighWord.Bits.Dpl);

       if (info.HighWord.Bits.Granularity)
        puts_filtered ("Page granular.\n");
       else
       if (info.HighWord.Bits.Granularity)
        puts_filtered ("Page granular.\n");
       else


@@ -1405,14 +1399,13 @@ fake_create_process (void)
        (unsigned) GetLastError ());
       /*  We can not debug anything in that case.  */
     }
        (unsigned) GetLastError ());
       /*  We can not debug anything in that case.  */
     }

-  main_thread_id = current_event.dwThreadId;

   current_thread
     = windows_add_thread (ptid_t (current_event.dwProcessId, 0,
                                  current_event.dwThreadId),
                          current_event.u.CreateThread.hThread,
                          current_event.u.CreateThread.lpThreadLocalBase,
                          true /* main_thread_p */);
   current_thread
     = windows_add_thread (ptid_t (current_event.dwProcessId, 0,
                                  current_event.dwThreadId),
                          current_event.u.CreateThread.hThread,
                          current_event.u.CreateThread.lpThreadLocalBase,
                          true /* main_thread_p */);

-  return main_thread_id;
+  return current_event.dwThreadId;

 }
 
 void
 }
 
 void


@@ -1464,8 +1457,8 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig)
 
   last_sig = GDB_SIGNAL_0;
 
 
   last_sig = GDB_SIGNAL_0;
 

-  DEBUG_EXEC (("gdb: windows_resume (pid=%d, tid=%ld, step=%d, sig=%d);\n",
-              ptid.pid (), ptid.tid (), step, sig));
+  DEBUG_EXEC (("gdb: windows_resume (pid=%d, tid=0x%x, step=%d, sig=%d);\n",
+              ptid.pid (), (unsigned) ptid.tid (), step, sig));

 
   /* Get context for currently selected thread.  */
   th = thread_rec (inferior_ptid.tid (), FALSE);
 
   /* Get context for currently selected thread.  */
   th = thread_rec (inferior_ptid.tid (), FALSE);


@@ -1533,9 +1526,10 @@ ctrl_c_handler (DWORD event_type)
 
 /* Get the next event from the child.  Returns a non-zero thread id if the event
    requires handling by WFI (or whatever).  */
 
 /* Get the next event from the child.  Returns a non-zero thread id if the event
    requires handling by WFI (or whatever).  */

-static int
-get_windows_debug_event (struct target_ops *ops,
-                        int pid, struct target_waitstatus *ourstatus)
+
+int
+windows_nat_target::get_windows_debug_event (int pid,
+                                            struct target_waitstatus *ourstatus)

 {
   BOOL debug_event;
   DWORD continue_status, event_code;
 {
   BOOL debug_event;
   DWORD continue_status, event_code;


@@ -1565,8 +1559,7 @@ get_windows_debug_event (struct target_ops *ops,
                     "CREATE_THREAD_DEBUG_EVENT"));
       if (saw_create != 1)
        {
                     "CREATE_THREAD_DEBUG_EVENT"));
       if (saw_create != 1)
        {

-         struct inferior *inf;
-         inf = find_inferior_pid (current_event.dwProcessId);
+         inferior *inf = find_inferior_pid (this, current_event.dwProcessId);

          if (!saw_create && inf->attach_flag)
            {
              /* Kludge around a Windows bug where first event is a create
          if (!saw_create && inf->attach_flag)
            {
              /* Kludge around a Windows bug where first event is a create


@@ -1610,7 +1603,6 @@ get_windows_debug_event (struct target_ops *ops,
        break;
 
       current_process_handle = current_event.u.CreateProcessInfo.hProcess;
        break;
 
       current_process_handle = current_event.u.CreateProcessInfo.hProcess;

-      main_thread_id = current_event.dwThreadId;

       /* Add the main thread.  */
       th = windows_add_thread
         (ptid_t (current_event.dwProcessId, 0,
       /* Add the main thread.  */
       th = windows_add_thread
         (ptid_t (current_event.dwProcessId, 0,


@@ -1636,11 +1628,26 @@ get_windows_debug_event (struct target_ops *ops,
       else if (saw_create == 1)
        {
          windows_delete_thread (ptid_t (current_event.dwProcessId, 0,
       else if (saw_create == 1)
        {
          windows_delete_thread (ptid_t (current_event.dwProcessId, 0,

-                                        main_thread_id),
+                                        current_event.dwThreadId),

                                 0, true /* main_thread_p */);
                                 0, true /* main_thread_p */);

-         ourstatus->kind = TARGET_WAITKIND_EXITED;
-         ourstatus->value.integer = current_event.u.ExitProcess.dwExitCode;
-         thread_id = main_thread_id;
+         DWORD exit_status = current_event.u.ExitProcess.dwExitCode;
+         /* If the exit status looks like a fatal exception, but we
+            don't recognize the exception's code, make the original
+            exit status value available, to avoid losing
+            information.  */
+         int exit_signal
+           = WIFSIGNALED (exit_status) ? WTERMSIG (exit_status) : -1;
+         if (exit_signal == -1)
+           {
+             ourstatus->kind = TARGET_WAITKIND_EXITED;
+             ourstatus->value.integer = exit_status;
+           }
+         else
+           {
+             ourstatus->kind = TARGET_WAITKIND_SIGNALLED;
+             ourstatus->value.sig = gdb_signal_from_host (exit_signal);
+           }
+         thread_id = current_event.dwThreadId;

        }
       break;
 
        }
       break;
 


@@ -1655,7 +1662,7 @@ get_windows_debug_event (struct target_ops *ops,
       catch_errors (handle_load_dll);
       ourstatus->kind = TARGET_WAITKIND_LOADED;
       ourstatus->value.integer = 0;
       catch_errors (handle_load_dll);
       ourstatus->kind = TARGET_WAITKIND_LOADED;
       ourstatus->value.integer = 0;

-      thread_id = main_thread_id;
+      thread_id = current_event.dwThreadId;

       break;
 
     case UNLOAD_DLL_DEBUG_EVENT:
       break;
 
     case UNLOAD_DLL_DEBUG_EVENT:


@@ -1668,7 +1675,7 @@ get_windows_debug_event (struct target_ops *ops,
       catch_errors (handle_unload_dll);
       ourstatus->kind = TARGET_WAITKIND_LOADED;
       ourstatus->value.integer = 0;
       catch_errors (handle_unload_dll);
       ourstatus->kind = TARGET_WAITKIND_LOADED;
       ourstatus->value.integer = 0;

-      thread_id = main_thread_id;
+      thread_id = current_event.dwThreadId;

       break;
 
     case EXCEPTION_DEBUG_EVENT:
       break;
 
     case EXCEPTION_DEBUG_EVENT:


@@ -1774,7 +1781,7 @@ windows_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
             the user tries to resume the execution in the inferior.
             This is a classic race that we should try to fix one day.  */
       SetConsoleCtrlHandler (&ctrl_c_handler, TRUE);
             the user tries to resume the execution in the inferior.
             This is a classic race that we should try to fix one day.  */
       SetConsoleCtrlHandler (&ctrl_c_handler, TRUE);

-      retval = get_windows_debug_event (this, pid, ourstatus);
+      retval = get_windows_debug_event (pid, ourstatus);

       SetConsoleCtrlHandler (&ctrl_c_handler, FALSE);
 
       if (retval)
       SetConsoleCtrlHandler (&ctrl_c_handler, FALSE);
 
       if (retval)


@@ -2001,13 +2008,14 @@ windows_nat_target::attach (const char *args, int from_tty)
 #endif
 
   if (!ok)
 #endif
 
   if (!ok)

-    error (_("Can't attach to process."));
+    error (_("Can't attach to process %u (error %u)"),
+          (unsigned) pid, (unsigned) GetLastError ());

 
   DebugSetProcessKillOnExit (FALSE);
 
   if (from_tty)
     {
 
   DebugSetProcessKillOnExit (FALSE);
 
   if (from_tty)
     {

-      char *exec_file = (char *) get_exec_file (0);
+      const char *exec_file = get_exec_file (0);

 
       if (exec_file)
        printf_unfiltered ("Attaching to program `%s', %s\n", exec_file,
 
       if (exec_file)
        printf_unfiltered ("Attaching to program `%s', %s\n", exec_file,


@@ -2727,7 +2735,7 @@ windows_nat_target::create_inferior (const char *exec_file,
        redirect_inferior_handles (allargs, allargs_copy,
                                   &fd_inp, &fd_out, &fd_err);
       if (errno)
        redirect_inferior_handles (allargs, allargs_copy,
                                   &fd_inp, &fd_out, &fd_err);
       if (errno)

-       warning (_("Error in redirection: %s."), strerror (errno));
+       warning (_("Error in redirection: %s."), safe_strerror (errno));

       else
        errno = e;
       allargs_len = strlen (allargs_copy);
       else
        errno = e;
       allargs_len = strlen (allargs_copy);