s/boolean/bfd_boolean/ s/true/TRUE/ s/false/FALSE/. Simplify

[deliverable/binutils-gdb.git] / bfd / coff-ia64.c

diff --git a/bfd/coff-ia64.c b/bfd/coff-ia64.c
index 5b10e3b88df1c13b8d5b40c4eb0b0a15c597e192..2b5b557ddbba74cc38466d6ed96b78b943baa09e 100644 (file)
--- a/bfd/coff-ia64.c
+++ b/bfd/coff-ia64.c
@@ -1,5 +1,5 @@
 /* BFD back-end for HP/Intel IA-64 COFF files.
-   Copyright 1999, 2000, 2001 Free Software Foundation, Inc.
+   Copyright 1999, 2000, 2001, 2002 Free Software Foundation, Inc.
    Contributed by David Mosberger <davidm@hpl.hp.com>
 
 This file is part of BFD, the Binary File Descriptor library.
@@ -49,72 +49,80 @@ static reloc_howto_type howto_table[] =
            (cache_ptr)->howto = howto_table + (dst)->r_type;
 
 #ifdef COFF_WITH_PE
-/* Return true if this relocation should
+/* Return TRUE if this relocation should
    appear in the output .reloc section.  */
 
-static boolean
+static bfd_boolean in_reloc_p PARAMS ((bfd *, reloc_howto_type *));
+
+static bfd_boolean
 in_reloc_p(abfd, howto)
      bfd * abfd ATTRIBUTE_UNUSED;
      reloc_howto_type *howto ATTRIBUTE_UNUSED;
 {
-  return 0;                    /* We don't do relocs for now...  */
+  return FALSE;                        /* We don't do relocs for now...  */
 }
 #endif
 
 #include "coffcode.h"
 
+static const bfd_target *ia64coff_object_p PARAMS ((bfd *));
+
 static const bfd_target *
 ia64coff_object_p (abfd)
      bfd *abfd;
 {
 #ifdef COFF_IMAGE_WITH_PE
-  /* We need to hack badly to handle a PE image correctly.  In PE
-     images created by the GNU linker, the offset to the COFF header
-     is always the size.  However, this is not the case in images
-     generated by other PE linkers.  The PE format stores a four byte
-     offset to the PE signature just before the COFF header at
-     location 0x3c of the file.  We pick up that offset, verify that
-     the PE signature is there, and then set ourselves up to read in
-     the COFF header.  */
   {
-    bfd_byte ext_offset[4];
+    struct external_PEI_DOS_hdr dos_hdr;
+    struct external_PEI_IMAGE_hdr image_hdr;
     file_ptr offset;
-    bfd_byte ext_signature[4];
-    unsigned long signature;
 
-    if (bfd_seek (abfd, 0x3c, SEEK_SET) != 0
-       || bfd_read (ext_offset, 1, 4, abfd) != 4)
+    if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0
+       || (bfd_bread (&dos_hdr, (bfd_size_type) sizeof (dos_hdr), abfd)
+           != sizeof (dos_hdr)))
       {
        if (bfd_get_error () != bfd_error_system_call)
          bfd_set_error (bfd_error_wrong_format);
        return NULL;
       }
-    offset = bfd_h_get_32 (abfd, ext_offset);
+
+    /* There are really two magic numbers involved; the magic number
+       that says this is a NT executable (PEI) and the magic number
+       that determines the architecture.  The former is DOSMAGIC,
+       stored in the e_magic field.  The latter is stored in the
+       f_magic field.  If the NT magic number isn't valid, the
+       architecture magic number could be mimicked by some other
+       field (specifically, the number of relocs in section 3).  Since
+       this routine can only be called correctly for a PEI file, check
+       the e_magic number here, and, if it doesn't match, clobber the
+       f_magic number so that we don't get a false match.  */
+    if (H_GET_16 (abfd, dos_hdr.e_magic) != DOSMAGIC)
+      {
+       bfd_set_error (bfd_error_wrong_format);
+       return NULL;
+      }
+
+    offset = H_GET_32 (abfd, dos_hdr.e_lfanew);
     if (bfd_seek (abfd, offset, SEEK_SET) != 0
-       || bfd_read (ext_signature, 1, 4, abfd) != 4)
+       || (bfd_bread (&image_hdr, (bfd_size_type) sizeof (image_hdr), abfd)
+           != sizeof (image_hdr)))
       {
        if (bfd_get_error () != bfd_error_system_call)
          bfd_set_error (bfd_error_wrong_format);
        return NULL;
       }
-    signature = bfd_h_get_32 (abfd, ext_signature);
 
-    if (signature != 0x4550)
+    if (H_GET_32 (abfd, image_hdr.nt_signature)
+       != 0x4550)
       {
        bfd_set_error (bfd_error_wrong_format);
        return NULL;
       }
 
     /* Here is the hack.  coff_object_p wants to read filhsz bytes to
-       pick up the COFF header.  We adjust so that that will work.  20
-       is the size of the COFF filehdr.  */
-
-    if (bfd_seek (abfd,
-                 (bfd_tell (abfd)
-                  - bfd_coff_filhsz (abfd)
-                  + 20),
-                 SEEK_SET)
-       != 0)
+       pick up the COFF header for PE, see "struct external_PEI_filehdr"
+       in include/coff/pe.h.  We adjust so that that will work. */
+    if (bfd_seek (abfd, offset - sizeof (dos_hdr), SEEK_SET) != 0)
       {
        if (bfd_get_error () != bfd_error_system_call)
          bfd_set_error (bfd_error_wrong_format);