bfd/
[deliverable/binutils-gdb.git] / bfd / elf-eh-frame.c
index 47588f4597530c58e0d5ff4f0515ec9474c2f5ca..9b88499e486fff0218f496adb37de3bcb6a0b32b 100644 (file)
@@ -42,6 +42,7 @@ struct cie
   union {
     struct elf_link_hash_entry *h;
     bfd_vma val;
+    unsigned int reloc_index;
   } personality;
   asection *output_sec;
   struct eh_cie_fde *cie_inf;
@@ -49,7 +50,6 @@ struct cie
   unsigned char lsda_encoding;
   unsigned char fde_encoding;
   unsigned char initial_insn_length;
-  unsigned char make_relative;
   unsigned char can_make_lsda_relative;
   unsigned char initial_instructions[50];
 };
@@ -283,7 +283,7 @@ extra_augmentation_string_bytes (struct eh_cie_fde *entry)
     {
       if (entry->add_augmentation_size)
        size++;
-      if (entry->add_fde_encoding)
+      if (entry->u.cie.add_fde_encoding)
        size++;
     }
   return size;
@@ -295,18 +295,10 @@ static INLINE unsigned int
 extra_augmentation_data_bytes (struct eh_cie_fde *entry)
 {
   unsigned int size = 0;
-  if (entry->cie)
-    {
-      if (entry->add_augmentation_size)
-       size++;
-      if (entry->add_fde_encoding)
-       size++;
-    }
-  else
-    {
-      if (entry->u.fde.cie_inf->add_augmentation_size)
-       size++;
-    }
+  if (entry->add_augmentation_size)
+    size++;
+  if (entry->cie && entry->u.cie.add_fde_encoding)
+    size++;
   return size;
 }
 
@@ -440,8 +432,7 @@ _bfd_elf_begin_eh_frame_parsing (struct bfd_link_info *info)
   struct eh_frame_hdr_info *hdr_info;
 
   hdr_info = &elf_hash_table (info)->eh_info;
-  if (!hdr_info->parsed_eh_frames && !info->relocatable)
-    hdr_info->cies = htab_try_create (1, cie_hash, cie_eq, free);
+  hdr_info->merge_cies = !info->relocatable;
 }
 
 /* Try to parse .eh_frame section SEC, which belongs to ABFD.  Store the
@@ -462,13 +453,8 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
   bfd_byte *last_fde;
   struct eh_cie_fde *this_inf;
   unsigned int hdr_length, hdr_id;
-  struct extended_cie
-    {
-      struct cie *cie;
-      struct eh_cie_fde *local_cie;
-    } *ecies = NULL, *ecie;
-  unsigned int ecie_count;
-  struct cie *cie, *local_cies = NULL, tmp_cie;
+  unsigned int cie_count;
+  struct cie *cie, *local_cies = NULL;
   struct elf_link_hash_table *htab;
   struct eh_frame_hdr_info *hdr_info;
   struct eh_frame_sec_info *sec_info = NULL;
@@ -547,16 +533,9 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
                          + (num_entries - 1) * sizeof (struct eh_cie_fde));
   REQUIRE (sec_info);
 
-  ecies = bfd_zmalloc (num_cies * sizeof (*ecies));
-  REQUIRE (ecies);
-
-  /* If we're not merging CIE entries (such as for a relocatable link),
-     we need to have a "struct cie" for each CIE in this section.  */
-  if (hdr_info->cies == NULL)
-    {
-      local_cies = bfd_zmalloc (num_cies * sizeof (*local_cies));
-      REQUIRE (local_cies);
-    }
+  /* We need to have a "struct cie" for each CIE in this section.  */
+  local_cies = bfd_zmalloc (num_cies * sizeof (*local_cies));
+  REQUIRE (local_cies);
 
 #define ENSURE_NO_RELOCS(buf)                          \
   REQUIRE (!(cookie->rel < cookie->relend              \
@@ -577,7 +556,7 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
    ? cookie->rel : NULL)
 
   buf = ehbuf;
-  ecie_count = 0;
+  cie_count = 0;
   gc_mark_hook = get_elf_backend_data (abfd)->gc_mark_hook;
   while ((bfd_size_type) (buf - ehbuf) != sec->size)
     {
@@ -621,16 +600,9 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
          /* CIE  */
          this_inf->cie = 1;
 
-         /* If we're merging CIEs, construct the struct cie in TMP_CIE;
-            we'll enter it into the global pool later.  Otherwise point
-            CIE to one of the section-local cie structures.  */
-         if (local_cies)
-           cie = local_cies + ecie_count;
-         else
-           {
-             cie = &tmp_cie;
-             memset (cie, 0, sizeof (*cie));
-           }
+         /* Point CIE to one of the section-local cie structures.  */
+         cie = local_cies + cie_count++;
+
          cie->cie_inf = this_inf;
          cie->length = hdr_length;
          cie->output_sec = sec->output_section;
@@ -706,64 +678,14 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
                        }
                      ENSURE_NO_RELOCS (buf);
                      /* Ensure we have a reloc here.  */
-                     if (GET_RELOC (buf) != NULL)
-                       {
-                         unsigned long r_symndx;
-
-#ifdef BFD64
-                         if (elf_elfheader (abfd)->e_ident[EI_CLASS]
-                             == ELFCLASS64)
-                           r_symndx = ELF64_R_SYM (cookie->rel->r_info);
-                         else
-#endif
-                           r_symndx = ELF32_R_SYM (cookie->rel->r_info);
-                         if (r_symndx >= cookie->locsymcount
-                             || ELF_ST_BIND (cookie->locsyms[r_symndx]
-                                             .st_info) != STB_LOCAL)
-                           {
-                             struct elf_link_hash_entry *h;
-
-                             r_symndx -= cookie->extsymoff;
-                             h = cookie->sym_hashes[r_symndx];
-
-                             while (h->root.type == bfd_link_hash_indirect
-                                    || h->root.type == bfd_link_hash_warning)
-                               h = (struct elf_link_hash_entry *)
-                                   h->root.u.i.link;
-
-                             cie->personality.h = h;
-                           }
-                         else
-                           {
-                             Elf_Internal_Sym *sym;
-                             asection *sym_sec;
-                             bfd_vma val;
-
-                             sym = &cookie->locsyms[r_symndx];
-                             sym_sec = (bfd_section_from_elf_index
-                                        (abfd, sym->st_shndx));
-                             if (sym_sec != NULL)
-                               {
-                                 if (sym_sec->kept_section != NULL)
-                                   sym_sec = sym_sec->kept_section;
-                                 if (sym_sec->output_section != NULL)
-                                   {
-                                     val = (sym->st_value
-                                            + sym_sec->output_offset
-                                            + sym_sec->output_section->vma);
-                                     cie->personality.val = val;
-                                     cie->local_personality = 1;
-                                   }
-                               }
-                           }
-
-                         /* Cope with MIPS-style composite relocations.  */
-                         do
-                           cookie->rel++;
-                         while (GET_RELOC (buf) != NULL);
-                       }
+                     REQUIRE (GET_RELOC (buf));
+                     cie->personality.reloc_index
+                       = cookie->rel - cookie->rels;
+                     /* Cope with MIPS-style composite relocations.  */
+                     do
+                       cookie->rel++;
+                     while (GET_RELOC (buf) != NULL);
                      REQUIRE (skip_bytes (&buf, end, per_width));
-                     REQUIRE (cie->local_personality || cie->personality.h);
                    }
                    break;
                  default:
@@ -780,7 +702,7 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
                  (abfd, info, sec)))
            {
              if ((cie->fde_encoding & 0xf0) == DW_EH_PE_absptr)
-               cie->make_relative = 1;
+               this_inf->make_relative = 1;
              /* If the CIE doesn't already have an 'R' entry, it's fairly
                 easy to add one, provided that there's no aligned data
                 after the augmentation string.  */
@@ -789,8 +711,8 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
                {
                  if (*cie->augmentation == 0)
                    this_inf->add_augmentation_size = 1;
-                 this_inf->add_fde_encoding = 1;
-                 cie->make_relative = 1;
+                 this_inf->u.cie.add_fde_encoding = 1;
+                 this_inf->make_relative = 1;
                }
            }
 
@@ -816,8 +738,9 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
          buf += initial_insn_length;
          ENSURE_NO_RELOCS (buf);
 
-         this_inf->make_relative = cie->make_relative;
-         this_inf->per_encoding_relative
+         if (hdr_info->merge_cies)
+           this_inf->u.cie.u.full_cie = cie;
+         this_inf->u.cie.per_encoding_relative
            = (cie->per_encoding & 0x70) == DW_EH_PE_pcrel;
        }
       else
@@ -826,15 +749,17 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
 
          /* Find the corresponding CIE.  */
          unsigned int cie_offset = this_inf->offset + 4 - hdr_id;
-         for (ecie = ecies; ecie < ecies + ecie_count; ++ecie)
-           if (cie_offset == ecie->local_cie->offset)
+         for (cie = local_cies; cie < local_cies + cie_count; cie++)
+           if (cie_offset == cie->cie_inf->offset)
              break;
 
          /* Ensure this FDE references one of the CIEs in this input
             section.  */
-         REQUIRE (ecie != ecies + ecie_count);
-         cie = ecie->cie;
-         this_inf->u.fde.cie_inf = ecie->local_cie;
+         REQUIRE (cie != local_cies + cie_count);
+         this_inf->u.fde.cie_inf = cie->cie_inf;
+         this_inf->make_relative = cie->cie_inf->make_relative;
+         this_inf->add_augmentation_size
+           = cie->cie_inf->add_augmentation_size;
 
          ENSURE_NO_RELOCS (buf);
          REQUIRE (GET_RELOC (buf));
@@ -900,7 +825,7 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
        }
       if (set_loc_count
          && ((cie->fde_encoding & 0xf0) == DW_EH_PE_pcrel
-             || cie->make_relative))
+             || this_inf->make_relative))
        {
          unsigned int cnt;
          bfd_byte *p;
@@ -922,37 +847,18 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
       this_inf->removed = 1;
       this_inf->fde_encoding = cie->fde_encoding;
       this_inf->lsda_encoding = cie->lsda_encoding;
-      if (this_inf->cie)
-       {
-         /* We have now finished constructing the struct cie.  */
-         if (hdr_info->cies != NULL)
-           {
-             /* See if we can merge this CIE with an earlier one.  */
-             void **loc;
-
-             cie_compute_hash (cie);
-             loc = htab_find_slot_with_hash (hdr_info->cies, cie,
-                                             cie->hash, INSERT);
-             REQUIRE (loc);
-             if (*loc == HTAB_EMPTY_ENTRY)
-               {
-                 *loc = malloc (sizeof (struct cie));
-                 REQUIRE (*loc);
-                 memcpy (*loc, cie, sizeof (struct cie));
-               }
-             cie = (struct cie *) *loc;
-           }
-         this_inf->u.cie.merged = cie->cie_inf;
-         ecies[ecie_count].cie = cie;
-         ecies[ecie_count++].local_cie = this_inf;
-       }
       sec_info->count++;
     }
   BFD_ASSERT (sec_info->count == num_entries);
-  BFD_ASSERT (ecie_count == num_cies);
+  BFD_ASSERT (cie_count == num_cies);
 
   elf_section_data (sec)->sec_info = sec_info;
   sec->sec_info_type = ELF_INFO_TYPE_EH_FRAME;
+  if (hdr_info->merge_cies)
+    {
+      sec_info->cies = local_cies;
+      local_cies = NULL;
+    }
   goto success;
 
  free_no_table:
@@ -965,8 +871,6 @@ _bfd_elf_parse_eh_frame (bfd *abfd, struct bfd_link_info *info,
  success:
   if (ehbuf)
     free (ehbuf);
-  if (ecies)
-    free (ecies);
   if (local_cies)
     free (local_cies);
 #undef REQUIRE
@@ -980,11 +884,6 @@ _bfd_elf_end_eh_frame_parsing (struct bfd_link_info *info)
   struct eh_frame_hdr_info *hdr_info;
 
   hdr_info = &elf_hash_table (info)->eh_info;
-  if (hdr_info->cies != NULL)
-    {
-      htab_delete (hdr_info->cies);
-      hdr_info->cies = NULL;
-    }
   hdr_info->parsed_eh_frames = TRUE;
 }
 
@@ -1016,7 +915,7 @@ _bfd_elf_gc_mark_fdes (struct bfd_link_info *info, asection *sec,
                       asection *eh_frame, elf_gc_mark_hook_fn gc_mark_hook,
                       struct elf_reloc_cookie *cookie)
 {
-  struct eh_cie_fde *fde, *cie, *merged;
+  struct eh_cie_fde *fde, *cie;
 
   for (fde = elf_fde_list (sec); fde; fde = fde->u.fde.next_for_section)
     {
@@ -1026,10 +925,9 @@ _bfd_elf_gc_mark_fdes (struct bfd_link_info *info, asection *sec,
       /* At this stage, all cie_inf fields point to local CIEs, so we
         can use the same cookie to refer to them.  */
       cie = fde->u.fde.cie_inf;
-      merged = cie->u.cie.merged;
-      if (!merged->u.cie.gc_mark)
+      if (!cie->u.cie.gc_mark)
        {
-         merged->u.cie.gc_mark = 1;
+         cie->u.cie.gc_mark = 1;
          if (!mark_entry (info, eh_frame, cie, gc_mark_hook, cookie))
            return FALSE;
        }
@@ -1037,6 +935,126 @@ _bfd_elf_gc_mark_fdes (struct bfd_link_info *info, asection *sec,
   return TRUE;
 }
 
+/* Input section SEC of ABFD is an .eh_frame section that contains the
+   CIE described by CIE_INF.  Return a version of CIE_INF that is going
+   to be kept in the output, adding CIE_INF to the output if necessary.
+
+   HDR_INFO is the .eh_frame_hdr information and COOKIE describes the
+   relocations in REL.  */
+
+static struct eh_cie_fde *
+find_merged_cie (bfd *abfd, asection *sec,
+                struct eh_frame_hdr_info *hdr_info,
+                struct elf_reloc_cookie *cookie,
+                struct eh_cie_fde *cie_inf)
+{
+  unsigned long r_symndx;
+  struct cie *cie, *new_cie;
+  Elf_Internal_Rela *rel;
+  void **loc;
+
+  /* Use CIE_INF if we have already decided to keep it.  */
+  if (!cie_inf->removed)
+    return cie_inf;
+
+  /* If we have merged CIE_INF with another CIE, use that CIE instead.  */
+  if (cie_inf->u.cie.merged)
+    return cie_inf->u.cie.u.merged_with;
+
+  cie = cie_inf->u.cie.u.full_cie;
+
+  /* Assume we will need to keep CIE_INF.  */
+  cie_inf->removed = 0;
+  cie_inf->u.cie.u.sec = sec;
+
+  /* If we are not merging CIEs, use CIE_INF.  */
+  if (cie == NULL)
+    return cie_inf;
+
+  if (cie->per_encoding != DW_EH_PE_omit)
+    {
+      /* Work out the address of personality routine, either as an absolute
+        value or as a symbol.  */
+      rel = cookie->rels + cie->personality.reloc_index;
+      memset (&cie->personality, 0, sizeof (cie->personality));
+#ifdef BFD64
+      if (elf_elfheader (abfd)->e_ident[EI_CLASS] == ELFCLASS64)
+       r_symndx = ELF64_R_SYM (rel->r_info);
+      else
+#endif
+       r_symndx = ELF32_R_SYM (rel->r_info);
+      if (r_symndx >= cookie->locsymcount
+         || ELF_ST_BIND (cookie->locsyms[r_symndx].st_info) != STB_LOCAL)
+       {
+         struct elf_link_hash_entry *h;
+
+         r_symndx -= cookie->extsymoff;
+         h = cookie->sym_hashes[r_symndx];
+
+         while (h->root.type == bfd_link_hash_indirect
+                || h->root.type == bfd_link_hash_warning)
+           h = (struct elf_link_hash_entry *) h->root.u.i.link;
+
+         cie->personality.h = h;
+       }
+      else
+       {
+         Elf_Internal_Sym *sym;
+         asection *sym_sec;
+
+         sym = &cookie->locsyms[r_symndx];
+         sym_sec = bfd_section_from_elf_index (abfd, sym->st_shndx);
+         if (sym_sec == NULL)
+           return cie_inf;
+
+         if (sym_sec->kept_section != NULL)
+           sym_sec = sym_sec->kept_section;
+         if (sym_sec->output_section == NULL)
+           return cie_inf;
+
+         cie->local_personality = 1;
+         cie->personality.val = (sym->st_value
+                                 + sym_sec->output_offset
+                                 + sym_sec->output_section->vma);
+       }
+    }
+
+  /* See if we can merge this CIE with an earlier one.  */
+  cie->output_sec = sec->output_section;
+  cie_compute_hash (cie);
+  if (hdr_info->cies == NULL)
+    {
+      hdr_info->cies = htab_try_create (1, cie_hash, cie_eq, free);
+      if (hdr_info->cies == NULL)
+       return cie_inf;
+    }
+  loc = htab_find_slot_with_hash (hdr_info->cies, cie, cie->hash, INSERT);
+  if (loc == NULL)
+    return cie_inf;
+
+  new_cie = (struct cie *) *loc;
+  if (new_cie == NULL)
+    {
+      /* Keep CIE_INF and record it in the hash table.  */
+      new_cie = malloc (sizeof (struct cie));
+      if (new_cie == NULL)
+       return cie_inf;
+
+      memcpy (new_cie, cie, sizeof (struct cie));
+      *loc = new_cie;
+    }
+  else
+    {
+      /* Merge CIE_INF with NEW_CIE->CIE_INF.  */
+      cie_inf->removed = 1;
+      cie_inf->u.cie.merged = 1;
+      cie_inf->u.cie.u.merged_with = new_cie->cie_inf;
+      if (cie_inf->u.cie.make_lsda_relative)
+       new_cie->cie_inf->u.cie.make_lsda_relative = 1;
+    }
+  return new_cie->cie_inf;
+}
+
 /* This function is called for each input file before the .eh_frame
    section is relocated.  It discards duplicate CIEs and FDEs for discarded
    functions.  The function returns TRUE iff any entries have been
@@ -1048,7 +1066,7 @@ _bfd_elf_discard_section_eh_frame
     bfd_boolean (*reloc_symbol_deleted_p) (bfd_vma, void *),
     struct elf_reloc_cookie *cookie)
 {
-  struct eh_cie_fde *ent, *cie, *merged;
+  struct eh_cie_fde *ent;
   struct eh_frame_sec_info *sec_info;
   struct eh_frame_hdr_info *hdr_info;
   unsigned int ptr_size, offset;
@@ -1059,7 +1077,11 @@ _bfd_elf_discard_section_eh_frame
 
   hdr_info = &elf_hash_table (info)->eh_info;
   for (ent = sec_info->entry; ent < sec_info->entry + sec_info->count; ++ent)
-    if (!ent->cie)
+    if (ent->size == 4)
+      /* There should only be one zero terminator, on the last input
+        file supplying .eh_frame (crtend.o).  Remove any others.  */
+      ent->removed = sec->map_head.s != NULL;
+    else if (!ent->cie)
       {
        cookie->rel = cookie->rels + ent->reloc_index;
        BFD_ASSERT (cookie->rel < cookie->relend
@@ -1068,7 +1090,7 @@ _bfd_elf_discard_section_eh_frame
          {
            if (info->shared
                && (((ent->fde_encoding & 0xf0) == DW_EH_PE_absptr
-                    && ent->u.fde.cie_inf->make_relative == 0)
+                    && ent->make_relative == 0)
                    || (ent->fde_encoding & 0xf0) == DW_EH_PE_aligned))
              {
                /* If a shared library uses absolute pointers
@@ -1082,30 +1104,17 @@ _bfd_elf_discard_section_eh_frame
              }
            ent->removed = 0;
            hdr_info->fde_count++;
-
-           cie = ent->u.fde.cie_inf;
-           if (cie->removed)
-             {
-               merged = cie->u.cie.merged;
-               if (!merged->removed)
-                 /* We have decided to keep the group representative.  */
-                 ent->u.fde.cie_inf = merged;
-               else if (merged->u.cie.merged != merged)
-                 /* We didn't keep the original group representative,
-                    but we did keep an alternative.  */
-                 ent->u.fde.cie_inf = merged->u.cie.merged;
-               else
-                 {
-                   /* Make the local CIE represent the merged group.  */
-                   merged->u.cie.merged = cie;
-                   cie->removed = 0;
-                   cie->u.cie.make_lsda_relative
-                     = merged->u.cie.make_lsda_relative;
-                 }
-             }
+           ent->u.fde.cie_inf = find_merged_cie (abfd, sec, hdr_info, cookie,
+                                                 ent->u.fde.cie_inf);
          }
       }
 
+  if (sec_info->cies)
+    {
+      free (sec_info->cies);
+      sec_info->cies = NULL;
+    }
+
   ptr_size = (get_elf_backend_data (sec->owner)
              ->elf_backend_eh_frame_address_size (sec->owner, sec));
   offset = 0;
@@ -1135,6 +1144,12 @@ _bfd_elf_discard_section_eh_frame_hdr (bfd *abfd, struct bfd_link_info *info)
   htab = elf_hash_table (info);
   hdr_info = &htab->eh_info;
 
+  if (hdr_info->cies != NULL)
+    {
+      htab_delete (hdr_info->cies);
+      hdr_info->cies = NULL;
+    }
+
   sec = hdr_info->hdr_sec;
   if (sec == NULL)
     return FALSE;
@@ -1218,8 +1233,6 @@ _bfd_elf_eh_frame_section_offset (bfd *output_bfd ATTRIBUTE_UNUSED,
 
   htab = elf_hash_table (info);
   hdr_info = &htab->eh_info;
-  if (hdr_info->offsets_adjusted)
-    offset += sec->output_offset;
 
   lo = 0;
   hi = sec_info->count;
@@ -1245,7 +1258,7 @@ _bfd_elf_eh_frame_section_offset (bfd *output_bfd ATTRIBUTE_UNUSED,
   /* If converting to DW_EH_PE_pcrel, there will be no need for run-time
      relocation against FDE's initial_location field.  */
   if (!sec_info->entry[mid].cie
-      && sec_info->entry[mid].u.fde.cie_inf->make_relative
+      && sec_info->entry[mid].make_relative
       && offset == sec_info->entry[mid].offset + 8)
     return (bfd_vma) -2;
 
@@ -1260,9 +1273,7 @@ _bfd_elf_eh_frame_section_offset (bfd *output_bfd ATTRIBUTE_UNUSED,
   /* If converting to DW_EH_PE_pcrel, there will be no need for run-time
      relocation against DW_CFA_set_loc's arguments.  */
   if (sec_info->entry[mid].set_loc
-      && (sec_info->entry[mid].cie
-         ? sec_info->entry[mid].make_relative
-         : sec_info->entry[mid].u.fde.cie_inf->make_relative)
+      && sec_info->entry[mid].make_relative
       && (offset >= sec_info->entry[mid].offset + 8
                    + sec_info->entry[mid].set_loc[1]))
     {
@@ -1274,8 +1285,6 @@ _bfd_elf_eh_frame_section_offset (bfd *output_bfd ATTRIBUTE_UNUSED,
          return (bfd_vma) -2;
     }
 
-  if (hdr_info->offsets_adjusted)
-    offset -= sec->output_offset;
   /* Any new augmentation bytes go before the first relocation.  */
   return (offset + sec_info->entry[mid].new_offset
          - sec_info->entry[mid].offset
@@ -1310,38 +1319,6 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
   htab = elf_hash_table (info);
   hdr_info = &htab->eh_info;
 
-  /* First convert all offsets to output section offsets, so that a
-     CIE offset is valid if the CIE is used by a FDE from some other
-     section.  This can happen when duplicate CIEs are deleted in
-     _bfd_elf_discard_section_eh_frame.  We do all sections here because
-     this function might not be called on sections in the same order as
-     _bfd_elf_discard_section_eh_frame.  */
-  if (!hdr_info->offsets_adjusted)
-    {
-      bfd *ibfd;
-      asection *eh;
-      struct eh_frame_sec_info *eh_inf;
-
-      for (ibfd = info->input_bfds; ibfd != NULL; ibfd = ibfd->link_next)
-       {
-         if (bfd_get_flavour (ibfd) != bfd_target_elf_flavour
-             || (ibfd->flags & DYNAMIC) != 0)
-           continue;
-
-         eh = bfd_get_section_by_name (ibfd, ".eh_frame");
-         if (eh == NULL || eh->sec_info_type != ELF_INFO_TYPE_EH_FRAME)
-           continue;
-
-         eh_inf = elf_section_data (eh)->sec_info;
-         for (ent = eh_inf->entry; ent < eh_inf->entry + eh_inf->count; ++ent)
-           {
-             ent->offset += eh->output_offset;
-             ent->new_offset += eh->output_offset;
-           }
-       }
-      hdr_info->offsets_adjusted = TRUE;
-    }
-
   if (hdr_info->table && hdr_info->array == NULL)
     hdr_info->array
       = bfd_malloc (hdr_info->fde_count * sizeof(*hdr_info->array));
@@ -1355,13 +1332,11 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
      not reordered  */
   for (ent = sec_info->entry + sec_info->count; ent-- != sec_info->entry;)
     if (!ent->removed && ent->new_offset > ent->offset)
-      memmove (contents + ent->new_offset - sec->output_offset,
-              contents + ent->offset - sec->output_offset, ent->size);
+      memmove (contents + ent->new_offset, contents + ent->offset, ent->size);
 
   for (ent = sec_info->entry; ent < sec_info->entry + sec_info->count; ++ent)
     if (!ent->removed && ent->new_offset < ent->offset)
-      memmove (contents + ent->new_offset - sec->output_offset,
-              contents + ent->offset - sec->output_offset, ent->size);
+      memmove (contents + ent->new_offset, contents + ent->offset, ent->size);
 
   for (ent = sec_info->entry; ent < sec_info->entry + sec_info->count; ++ent)
     {
@@ -1378,7 +1353,7 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
          continue;
        }
 
-      buf = contents + ent->new_offset - sec->output_offset;
+      buf = contents + ent->new_offset;
       end = buf + ent->size;
       new_size = size_of_output_cie_fde (ent, ptr_size);
 
@@ -1394,7 +1369,7 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
          /* CIE */
          if (ent->make_relative
              || ent->u.cie.make_lsda_relative
-             || ent->per_encoding_relative)
+             || ent->u.cie.per_encoding_relative)
            {
              char *aug;
              unsigned int action, extra_string, extra_data;
@@ -1404,7 +1379,7 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
                 DW_EH_PE_* value.  */
              action = ((ent->make_relative ? 1 : 0)
                        | (ent->u.cie.make_lsda_relative ? 2 : 0)
-                       | (ent->per_encoding_relative ? 4 : 0));
+                       | (ent->u.cie.per_encoding_relative ? 4 : 0));
              extra_string = extra_augmentation_string_bytes (ent);
              extra_data = extra_augmentation_data_bytes (ent);
 
@@ -1434,7 +1409,7 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
                  *aug++ = 'z';
                  *buf++ = extra_data - 1;
                }
-             if (ent->add_fde_encoding)
+             if (ent->u.cie.add_fde_encoding)
                {
                  BFD_ASSERT (action & 1);
                  *aug++ = 'R';
@@ -1459,7 +1434,7 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
                    per_width = get_DW_EH_PE_width (per_encoding, ptr_size);
                    BFD_ASSERT (per_width != 0);
                    BFD_ASSERT (((per_encoding & 0x70) == DW_EH_PE_pcrel)
-                               == ent->per_encoding_relative);
+                               == ent->u.cie.per_encoding_relative);
                    if ((per_encoding & 0xf0) == DW_EH_PE_aligned)
                      buf = (contents
                             + ((buf - contents + per_width - 1)
@@ -1504,7 +1479,8 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
          /* Skip length.  */
          cie = ent->u.fde.cie_inf;
          buf += 4;
-         value = ent->new_offset + 4 - cie->new_offset;
+         value = ((ent->new_offset + sec->output_offset + 4)
+                  - (cie->new_offset + cie->u.cie.u.sec->output_offset));
          bfd_put_32 (abfd, value, buf);
          buf += 4;
          width = get_DW_EH_PE_width (ent->fde_encoding, ptr_size);
@@ -1529,11 +1505,15 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
                  break;
                case DW_EH_PE_pcrel:
                  value += ent->offset - ent->new_offset;
-                 address += sec->output_section->vma + ent->offset + 8;
+                 address += (sec->output_section->vma
+                             + sec->output_offset
+                             + ent->offset + 8);
                  break;
                }
-             if (cie->make_relative)
-               value -= sec->output_section->vma + ent->new_offset + 8;
+             if (ent->make_relative)
+               value -= (sec->output_section->vma
+                         + sec->output_offset
+                         + ent->new_offset + 8);
              write_value (abfd, buf, value, width);
            }
 
@@ -1543,7 +1523,9 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
            {
              hdr_info->array[hdr_info->array_count].initial_loc = address;
              hdr_info->array[hdr_info->array_count++].fde
-               = sec->output_section->vma + ent->new_offset;
+               = (sec->output_section->vma
+                  + sec->output_offset
+                  + ent->new_offset);
            }
 
          if ((ent->lsda_encoding & 0xf0) == DW_EH_PE_pcrel
@@ -1558,12 +1540,13 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
                  if ((ent->lsda_encoding & 0xf0) == DW_EH_PE_pcrel)
                    value += ent->offset - ent->new_offset;
                  else if (cie->u.cie.make_lsda_relative)
-                   value -= (sec->output_section->vma + ent->new_offset + 8
-                             + ent->lsda_offset);
+                   value -= (sec->output_section->vma
+                             + sec->output_offset
+                             + ent->new_offset + 8 + ent->lsda_offset);
                  write_value (abfd, buf, value, width);
                }
            }
-         else if (cie->add_augmentation_size)
+         else if (ent->add_augmentation_size)
            {
              /* Skip the PC and length and insert a zero byte for the
                 augmentation size.  */
@@ -1595,9 +1578,10 @@ _bfd_elf_write_section_eh_frame (bfd *abfd,
 
                  if ((ent->fde_encoding & 0xf0) == DW_EH_PE_pcrel)
                    value += ent->offset + 8 - new_offset;
-                 if (cie->make_relative)
-                   value -= sec->output_section->vma + new_offset
-                            + ent->set_loc[cnt];
+                 if (ent->make_relative)
+                   value -= (sec->output_section->vma
+                             + sec->output_offset
+                             + new_offset + ent->set_loc[cnt]);
                  write_value (abfd, buf, value, width);
                }
            }
This page took 0.035006 seconds and 4 git commands to generate.