Properly handle dynamic reloc against normal symbol

[deliverable/binutils-gdb.git] / bfd / elf-ifunc.c

diff --git a/bfd/elf-ifunc.c b/bfd/elf-ifunc.c
index 1368a8e124bef760fc5c8f084c1c12881a4c57d7..1377fedfd3599a07b92adf475cbfe6eeb1815926 100644 (file)
--- a/bfd/elf-ifunc.c
+++ b/bfd/elf-ifunc.c
@@ -110,6 +110,7 @@ bfd_boolean
 _bfd_elf_allocate_ifunc_dyn_relocs (struct bfd_link_info *info,
                                    struct elf_link_hash_entry *h,
                                    struct elf_dyn_relocs **head,
+                                   bfd_boolean *readonly_dynrelocs_against_ifunc_p,
                                    unsigned int plt_entry_size,
                                    unsigned int plt_header_size,
                                    unsigned int got_entry_size)
@@ -119,6 +120,7 @@ _bfd_elf_allocate_ifunc_dyn_relocs (struct bfd_link_info *info,
   unsigned int sizeof_reloc;
   const struct elf_backend_data *bed;
   struct elf_link_hash_table *htab;
+  bfd_boolean readonly_dynrelocs_against_ifunc;
 
   /* When a shared library references a STT_GNU_IFUNC symbol defined
      in executable, the address of the resolved function may be used.
@@ -224,6 +226,8 @@ keep:
       || !h->non_got_ref)
     *head = NULL;
 
+  readonly_dynrelocs_against_ifunc = FALSE;
+
   /* Finally, allocate space.  */
   p = *head;
   if (p != NULL)
@@ -231,6 +235,12 @@ keep:
       bfd_size_type count = 0;
       do
        {
+         if (!readonly_dynrelocs_against_ifunc)
+           {
+             asection *s = p->sec->output_section;
+             if (s != NULL && (s->flags & SEC_READONLY) != 0)
+               readonly_dynrelocs_against_ifunc = TRUE;
+           }
          count += p->count;
          p = p->next;
        }
@@ -238,6 +248,9 @@ keep:
       htab->irelifunc->size += count * sizeof_reloc;
     }
 
+  if (readonly_dynrelocs_against_ifunc_p)
+    *readonly_dynrelocs_against_ifunc_p = readonly_dynrelocs_against_ifunc;
+
   /* For STT_GNU_IFUNC symbol, .got.plt has the real function address
      and .got has the PLT entry adddress.  We will load the GOT entry
      with the PLT entry in finish_dynamic_symbol if it is used.  For