static bfd_boolean nds32_elf_object_p (bfd *);
static void nds32_elf_final_write_processing (bfd *, bfd_boolean);
static bfd_boolean nds32_elf_set_private_flags (bfd *, flagword);
-static bfd_boolean nds32_elf_merge_private_bfd_data (bfd *, bfd *);
+static bfd_boolean nds32_elf_merge_private_bfd_data
+ (bfd *, struct bfd_link_info *);
static bfd_boolean nds32_elf_print_private_bfd_data (bfd *, void *);
static bfd_boolean nds32_elf_gc_sweep_hook
(bfd *, struct bfd_link_info *, asection *, const Elf_Internal_Rela *);
{
char *ptr = (char *) base;
int i, j;
- char *tmp = alloca (size);
+ char *tmp = xmalloc (size);
/* If i is less than j, i is inserted before j.
memmove (ptr + (j + 1) * size, ptr + j * size, (i - j) * size);
memcpy (ptr + j * size, tmp, size);
}
+ free (tmp);
}
/* Sort relocation by r_offset.
_bfd_elfcore_strndup (abfd, note->descdata + 28, 16);
elf_tdata (abfd)->core->command =
_bfd_elfcore_strndup (abfd, note->descdata + 44, 80);
+ break;
default:
return FALSE;
}
else
{
- (*_bfd_error_handler) (_("error: Can't find symbol: _SDA_BASE_."));
+ _bfd_error_handler (_("error: Can't find symbol: _SDA_BASE_."));
return bfd_reloc_dangerous;
}
}
/* Set the _ITB_BASE_. */
if (!nds32_elf_ex9_itb_base (info))
{
- (*_bfd_error_handler) (_("%B: error: Cannot set _ITB_BASE_"),
- output_bfd);
+ _bfd_error_handler (_("%B: error: Cannot set _ITB_BASE_"),
+ output_bfd);
bfd_set_error (bfd_error_bad_value);
}
}
if (table->target_optimize & NDS32_RELAX_JUMP_IFC_ON)
if (!nds32_elf_ifc_reloc ())
- (*_bfd_error_handler) (_("error: IFC relocation error."));
+ _bfd_error_handler (_("error: IFC relocation error."));
/* Relocation for .ex9.itable. */
if (table->target_optimize & NDS32_RELAX_EX9_ON
r_type = ELF32_R_TYPE (rel->r_info);
if (r_type >= R_NDS32_max)
{
- (*_bfd_error_handler) (_("%B: error: unknown relocation type %d."),
- input_bfd, r_type);
+ _bfd_error_handler (_("%B: error: unknown relocation type %d."),
+ input_bfd, r_type);
bfd_set_error (bfd_error_bad_value);
ret = FALSE;
continue;
case R_NDS32_25_ABS_RELA:
if (bfd_link_pic (info))
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%s: warning: cannot deal R_NDS32_25_ABS_RELA in shared "
"mode."), bfd_get_filename (input_bfd));
return FALSE;
if (relocation & align)
{
/* Incorrect alignment. */
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: warning: unaligned access to GOT entry."), input_bfd);
ret = FALSE;
r = bfd_reloc_dangerous;
r = nds32_elf_final_sda_base (output_bfd, info, &gp, FALSE);
if (r != bfd_reloc_ok)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: warning: relocate SDA_BASE failed."), input_bfd);
ret = FALSE;
goto check_reloc;
if (relocation & align)
{
/* Incorrect alignment. */
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B(%A): warning: unaligned small data access of type %d."),
input_bfd, input_section, r_type);
ret = FALSE;
switch (r)
{
case bfd_reloc_overflow:
- if (!((*info->callbacks->reloc_overflow)
- (info, (h ? &h->root : NULL), name, howto->name,
- (bfd_vma) 0, input_bfd, input_section, offset)))
- return FALSE;
+ (*info->callbacks->reloc_overflow)
+ (info, (h ? &h->root : NULL), name, howto->name,
+ (bfd_vma) 0, input_bfd, input_section, offset);
break;
case bfd_reloc_undefined:
- if (!((*info->callbacks->undefined_symbol)
- (info, name, input_bfd, input_section, offset, TRUE)))
- return FALSE;
+ (*info->callbacks->undefined_symbol)
+ (info, name, input_bfd, input_section, offset, TRUE);
break;
case bfd_reloc_outofrange:
errmsg = _("internal error: unknown error");
/* Fall through. */
-common_error:
- if (!((*info->callbacks->warning)
- (info, errmsg, name, input_bfd, input_section, offset)))
- return FALSE;
+ common_error:
+ (*info->callbacks->warning) (info, errmsg, name, input_bfd,
+ input_section, offset);
break;
}
}
break;
case DT_PLTGOT:
- /* name = ".got"; */
- s = htab->sgot->output_section;
+ s = htab->sgotplt;
goto get_vma;
case DT_JMPREL:
- s = htab->srelplt->output_section;
+ s = htab->srelplt;
get_vma:
- BFD_ASSERT (s != NULL);
- dyn.d_un.d_ptr = s->vma;
+ dyn.d_un.d_ptr = s->output_section->vma + s->output_offset;
bfd_elf32_swap_dyn_out (output_bfd, &dyn, dyncon);
break;
case DT_PLTRELSZ:
- s = htab->srelplt->output_section;
- BFD_ASSERT (s != NULL);
+ s = htab->srelplt;
dyn.d_un.d_val = s->size;
bfd_elf32_swap_dyn_out (output_bfd, &dyn, dyncon);
break;
about changing the DT_RELA entry. */
if (htab->srelplt != NULL)
{
- s = htab->srelplt->output_section;
+ s = htab->srelplt;
dyn.d_un.d_val -= s->size;
}
bfd_elf32_swap_dyn_out (output_bfd, &dyn, dyncon);
nds32_vec_size = (flag_t & 0x3);
else if (nds32_vec_size != (flag_t & 0x3))
{
- (*_bfd_error_handler) (_("%B: ISR vector size mismatch"
- " with previous modules, previous %u-byte, current %u-byte"),
- ibfd,
- nds32_vec_size == 1 ? 4 : nds32_vec_size == 2 ? 16 : 0xffffffff,
- (flag_t & 0x3) == 1 ? 4 : (flag_t & 0x3) == 2 ? 16 : 0xffffffff);
+ _bfd_error_handler
+ (_("%B: ISR vector size mismatch"
+ " with previous modules, previous %u-byte, current %u-byte"),
+ ibfd,
+ nds32_vec_size == 1 ? 4 : nds32_vec_size == 2 ? 16 : 0xffffffff,
+ (flag_t & 0x3) == 1 ? 4 : (flag_t & 0x3) == 2 ? 16 : 0xffffffff);
return FALSE;
}
else
object file when linking. */
static bfd_boolean
-nds32_elf_merge_private_bfd_data (bfd *ibfd, bfd *obfd)
+nds32_elf_merge_private_bfd_data (bfd *ibfd, struct bfd_link_info *info)
{
+ bfd *obfd = info->output_bfd;
flagword out_flags;
flagword in_flags;
flagword out_16regs;
if (bfd_little_endian (ibfd) != bfd_little_endian (obfd))
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: warning: Endian mismatch with previous modules."), ibfd);
bfd_set_error (bfd_error_bad_value);
in_version = elf_elfheader (ibfd)->e_flags & EF_NDS32_ELF_VERSION;
if (in_version == E_NDS32_ELF_VER_1_2)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: warning: Older version of object file encountered, "
"Please recompile with current tool chain."), ibfd);
}
/* Check flag compatibility. */
if ((in_flags & EF_NDS_ABI) != (out_flags & EF_NDS_ABI))
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: error: ABI mismatch with previous modules."), ibfd);
bfd_set_error (bfd_error_bad_value);
{
if (((in_flags & EF_NDS_ARCH) != E_N1_ARCH))
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: error: Instruction set mismatch with previous modules."), ibfd);
bfd_set_error (bfd_error_bad_value);
else
{
if (in_version != out_version)
- (*_bfd_error_handler) (_("%B: warning: Incompatible elf-versions %s and %s."),
- ibfd, nds32_elfver_strtab[out_version],
- nds32_elfver_strtab[in_version]);
+ _bfd_error_handler
+ (_("%B: warning: Incompatible elf-versions %s and %s."),
+ ibfd, nds32_elfver_strtab[out_version],
+ nds32_elfver_strtab[in_version]);
elf_elfheader (obfd)->e_flags = in_flags | out_flags
| (in_16regs & out_16regs) | (in_no_mac & out_no_mac)
if (blank_t2 && blank_t2->next
&& (blank_t2->offset > raddr
|| blank_t2->next->offset <= raddr))
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%B: %s\n"), abfd,
"Error: search_nds32_elf_blank reports wrong node");
if (hi_irelfn == irelend || lo_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL1 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (i1_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL2 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (hi_irelfn == irelend || lo_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL3 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_LO12S0_ORI_RELA, laddr + 4);
if (hi_irelfn == irelend || lo_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP1 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (i2_irelfn == irelend || cond_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP2 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (hi_irelfn == irelend || lo_irelfn == irelend || cond_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP3 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (hi_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL4 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (ptr_irel == irelend || em_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL4 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_25_PCREL_RELA, irel->r_addend);
if (cond_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL5 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (em_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL6 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_PTR_RESOLVED, irel->r_addend);
if (cond_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL6 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_PTR_RESOLVED, irel->r_addend);
if (cond_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGCALL6 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (hi_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP4 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (ptr_irel == irelend || em_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP4 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_25_PCREL_RELA, irel->r_addend);
if (cond_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP5 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (em_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP6 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
R_NDS32_15_PCREL_RELA, irel->r_addend);
if (cond_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LONGJUMP7 points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
if (hi_irelfn == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_LOADSTORE points to unrecognized"
"reloc at 0x%lx.", abfd, (long) irel->r_offset);
return FALSE;
success = 1;
break;
}
+ /* Fall through. */
case (N32_OP6_MEM << 8) | N32_MEM_LH:
case (N32_OP6_MEM << 8) | N32_MEM_SH:
case (N32_OP6_MEM << 8) | N32_MEM_LHS:
success = 1;
break;
}
+ /* Fall through. */
case (N32_OP6_MEM << 8) | N32_MEM_LW:
case (N32_OP6_MEM << 8) | N32_MEM_SW:
/* The range is +/-64k. */
success = 1;
break;
}
+ /* Fall through. */
default:
break;
}
if (re_irel == irelend)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
("%B: warning: R_NDS32_PTR points to unrecognized reloc at 0x%lx.",
abfd, (long) irel->r_offset);
return FALSE;
break;
case NDS32_RELAX_JUMP_IFC_ROUND:
if (!nds32_elf_ifc_finish (link_info))
- (*_bfd_error_handler) (_("error: Jump IFC Fail."));
+ _bfd_error_handler (_("error: Jump IFC Fail."));
if (table->target_optimize & NDS32_RELAX_EX9_ON)
{
pass++;
{
/* Do jump IFC optimization again. */
if (!nds32_elf_ifc_finish (link_info))
- (*_bfd_error_handler) (_("error: Jump IFC Fail."));
+ _bfd_error_handler (_("error: Jump IFC Fail."));
}
break;
default:
/* Set the _ITB_BASE_. */
if (!nds32_elf_ex9_itb_base (link_info))
{
- (*_bfd_error_handler) (_("%B: error: Cannot set _ITB_BASE_"), abfd);
+ _bfd_error_handler (_("%B: error: Cannot set _ITB_BASE_"), abfd);
bfd_set_error (bfd_error_bad_value);
}
}
Elf_Internal_Rela *tmp_rel;
/* Pad to alignment boundary. Only handle current section alignment. */
- sec_size_align = (sec->size + (~((-1) << sec->alignment_power)))
- & ((-1) << sec->alignment_power);
+ sec_size_align = (sec->size + (~((-1U) << sec->alignment_power)))
+ & ((-1U) << sec->alignment_power);
if ((sec_size_align - sec->size) & 0x2)
{
insn16 = NDS32_NOP16;
{
/* Begin of the region. */
if (begin_rel)
- (*_bfd_error_handler) (_("%B: Nested OMIT_FP in %A."), abfd, sec);
+ _bfd_error_handler (_("%B: Nested OMIT_FP in %A."), abfd, sec);
begin_rel = irel;
nds32_fag_init (&fag_head);
if (begin_rel == NULL)
{
- (*_bfd_error_handler) (_("%B: Unmatched OMIT_FP in %A."), abfd, sec);
+ _bfd_error_handler (_("%B: Unmatched OMIT_FP in %A."), abfd, sec);
continue;
}
switch (r)
{
case bfd_reloc_undefined:
- if (!((*link_info->callbacks->undefined_symbol)
- (link_info, bfd_asymbol_name (*(*parent)->sym_ptr_ptr),
- input_bfd, input_section, (*parent)->address, TRUE)))
- goto error_return;
+ (*link_info->callbacks->undefined_symbol)
+ (link_info, bfd_asymbol_name (*(*parent)->sym_ptr_ptr),
+ input_bfd, input_section, (*parent)->address, TRUE);
break;
case bfd_reloc_dangerous:
BFD_ASSERT (error_message != NULL);
- if (!((*link_info->callbacks->reloc_dangerous)
- (link_info, error_message, input_bfd, input_section,
- (*parent)->address)))
- goto error_return;
+ (*link_info->callbacks->reloc_dangerous)
+ (link_info, error_message,
+ input_bfd, input_section, (*parent)->address);
break;
case bfd_reloc_overflow:
- if (!((*link_info->callbacks->reloc_overflow)
- (link_info, NULL,
- bfd_asymbol_name (*(*parent)->sym_ptr_ptr),
- (*parent)->howto->name, (*parent)->addend,
- input_bfd, input_section, (*parent)->address)))
- goto error_return;
+ (*link_info->callbacks->reloc_overflow)
+ (link_info, NULL,
+ bfd_asymbol_name (*(*parent)->sym_ptr_ptr),
+ (*parent)->howto->name, (*parent)->addend,
+ input_bfd, input_section, (*parent)->address);
break;
case bfd_reloc_outofrange:
/* PR ld/13730:
sizeof (struct elf_nds32_code_hash_entry),
1023))
{
- (*_bfd_error_handler) (_("Linker: cannot init ex9 hash table error \n"));
+ _bfd_error_handler (_("Linker: cannot init ex9 hash table error \n"));
return FALSE;
}
return TRUE;
if (!nds32_get_section_contents
(fix_ptr->sec->owner, fix_ptr->sec,
&source_contents, TRUE))
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("Linker: error cannot fixed ex9 relocation \n"));
if (temp_ptr->order < 32)
insn_ex9 = INSN_EX9_IT_2;
else
{
if (!temp_ptr->next || temp_ptr->m_list != temp_ptr->next->m_list)
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("Linker: error cannot fixed ex9 relocation \n"));
else
temp_ptr = temp_ptr->next;
if (relocation & align)
{
/* Incorrect alignment. */
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%s: warning: unaligned small data access. "
"For entry: {%d, %d, %d}, addr = 0x%x, align = 0x%x."),
bfd_get_filename (abfd), irel->r_offset,
bfd_hash_lookup (&ex9_code_table, code, TRUE, TRUE);
if (entry == NULL)
{
- (*_bfd_error_handler)
+ _bfd_error_handler
(_("%P%F: failed creating ex9.it %s hash table: %E\n"), code);
return FALSE;
}
projects / deliverable / binutils-gdb.git / blobdiff