PR25993, read of freed memory

[deliverable/binutils-gdb.git] / bfd / elf32-rl78.c

diff --git a/bfd/elf32-rl78.c b/bfd/elf32-rl78.c
index 40f8c5881b1d151e933e058127b2c42951b8439c..633350faec42d7a07f3972d5f971aba6cbf7ebf9 100644 (file)
--- a/bfd/elf32-rl78.c
+++ b/bfd/elf32-rl78.c
@@ -2129,11 +2129,10 @@ rl78_elf_relax_section
          bfd_set_error (bfd_error_no_memory);
          goto error_return;
        }
-      shndx_buf = bfd_malloc (amt);
-      if (shndx_buf == NULL)
+      if (bfd_seek (abfd, shndx_hdr->sh_offset, SEEK_SET) != 0)
        goto error_return;
-      if (bfd_seek (abfd, shndx_hdr->sh_offset, SEEK_SET) != 0
-         || bfd_bread (shndx_buf, amt, abfd) != amt)
+      shndx_buf = _bfd_malloc_and_read (abfd, amt, amt);
+      if (shndx_buf == NULL)
        goto error_return;
       shndx_hdr->contents = shndx_buf;
     }