ubsan: or1k: left shift of negative value

[deliverable/binutils-gdb.git] / bfd / elfxx-x86.c

diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c
index e661ad30c121ce32a7c13d917d5091d38093ddad..d8165d17528006689572634db163274fdc004033 100644 (file)
--- a/bfd/elfxx-x86.c
+++ b/bfd/elfxx-x86.c
@@ -1238,7 +1238,7 @@ _bfd_x86_elf_size_dynamic_sections (bfd *output_bfd,
        {
          /* Strip these too.  */
        }
-      else if (htab->is_reloc_section (bfd_get_section_name (dynobj, s)))
+      else if (htab->is_reloc_section (bfd_section_name (s)))
        {
          if (s->size != 0
              && s != htab->elf.srelplt
@@ -1280,8 +1280,7 @@ _bfd_x86_elf_size_dynamic_sections (bfd *output_bfd,
         it is empty.  Update its section alignment now since it
         is non-empty.  */
       if (s == htab->elf.iplt)
-       bfd_set_section_alignment (s->owner, s,
-                                  htab->plt.iplt_alignment);
+       bfd_set_section_alignment (s, htab->plt.iplt_alignment);
 
       /* Allocate memory for the section contents.  We use bfd_zalloc
         here in case unused entries are not reclaimed before the
@@ -1381,7 +1380,8 @@ _bfd_x86_elf_size_dynamic_sections (bfd *output_bfd,
                {
                  info->callbacks->einfo
                    (_("%P%X: read-only segment has dynamic IFUNC relocations;"
-                      " recompile with -fPIC\n"));
+                      " recompile with %s\n"),
+                    bfd_link_dll (info) ? "-fPIC" : "-fPIE");
                  bfd_set_error (bfd_error_bad_value);
                  return FALSE;
                }
@@ -2170,17 +2170,18 @@ _bfd_x86_elf_get_synthetic_symtab (bfd *abfd,
                              bfd_vma);
   bfd_boolean (*valid_plt_reloc_p) (unsigned int);
 
+  dynrelbuf = NULL;
   if (count == 0)
-    return -1;
+    goto bad_return;
 
   dynrelbuf = (arelent **) bfd_malloc (relsize);
   if (dynrelbuf == NULL)
-    return -1;
+    goto bad_return;
 
   dynrelcount = bfd_canonicalize_dynamic_reloc (abfd, dynrelbuf,
                                                dynsyms);
   if (dynrelcount <= 0)
-    return -1;
+    goto bad_return;
 
   /* Sort the relocs by address.  */
   qsort (dynrelbuf, dynrelcount, sizeof (arelent *),
@@ -2623,7 +2624,7 @@ _bfd_x86_elf_link_setup_gnu_properties
          if (sec == NULL)
            info->callbacks->einfo (_("%F%P: failed to create GNU property section\n"));
 
-         if (!bfd_set_section_alignment (ebfd, sec, class_align))
+         if (!bfd_set_section_alignment (sec, class_align))
            {
 error_alignment:
              info->callbacks->einfo (_("%F%pA: failed to align section\n"),
@@ -2837,11 +2838,11 @@ error_alignment:
      instead of in create_dynamic_sections so that they are always
      properly aligned even if create_dynamic_sections isn't called.  */
   sec = htab->elf.sgot;
-  if (!bfd_set_section_alignment (dynobj, sec, got_align))
+  if (!bfd_set_section_alignment (sec, got_align))
     goto error_alignment;
 
   sec = htab->elf.sgotplt;
-  if (!bfd_set_section_alignment (dynobj, sec, got_align))
+  if (!bfd_set_section_alignment (sec, got_align))
     goto error_alignment;
 
   /* Create the ifunc sections here so that check_relocs can be
@@ -2879,8 +2880,7 @@ error_alignment:
            = bfd_log2 (htab->non_lazy_plt->plt_entry_size);
 
          sec = pltsec;
-         if (!bfd_set_section_alignment (sec->owner, sec,
-                                         plt_alignment))
+         if (!bfd_set_section_alignment (sec, plt_alignment))
            goto error_alignment;
 
          /* Create the GOT procedure linkage table.  */
@@ -2890,8 +2890,7 @@ error_alignment:
          if (sec == NULL)
            info->callbacks->einfo (_("%F%P: failed to create GOT PLT section\n"));
 
-         if (!bfd_set_section_alignment (dynobj, sec,
-                                         non_lazy_plt_alignment))
+         if (!bfd_set_section_alignment (sec, non_lazy_plt_alignment))
            goto error_alignment;
 
          htab->plt_got = sec;
@@ -2911,8 +2910,7 @@ error_alignment:
                  if (sec == NULL)
                    info->callbacks->einfo (_("%F%P: failed to create IBT-enabled PLT section\n"));
 
-                 if (!bfd_set_section_alignment (dynobj, sec,
-                                                 plt_alignment))
+                 if (!bfd_set_section_alignment (sec, plt_alignment))
                    goto error_alignment;
                }
              else if (htab->params->bndplt && ABI_64_P (dynobj))
@@ -2926,8 +2924,7 @@ error_alignment:
                  if (sec == NULL)
                    info->callbacks->einfo (_("%F%P: failed to create BND PLT section\n"));
 
-                 if (!bfd_set_section_alignment (dynobj, sec,
-                                                 non_lazy_plt_alignment))
+                 if (!bfd_set_section_alignment (sec, non_lazy_plt_alignment))
                    goto error_alignment;
                }
 
@@ -2947,7 +2944,7 @@ error_alignment:
          if (sec == NULL)
            info->callbacks->einfo (_("%F%P: failed to create PLT .eh_frame section\n"));
 
-         if (!bfd_set_section_alignment (dynobj, sec, class_align))
+         if (!bfd_set_section_alignment (sec, class_align))
            goto error_alignment;
 
          htab->plt_eh_frame = sec;
@@ -2960,7 +2957,7 @@ error_alignment:
              if (sec == NULL)
                info->callbacks->einfo (_("%F%P: failed to create GOT PLT .eh_frame section\n"));
 
-             if (!bfd_set_section_alignment (dynobj, sec, class_align))
+             if (!bfd_set_section_alignment (sec, class_align))
                goto error_alignment;
 
              htab->plt_got_eh_frame = sec;
@@ -2974,7 +2971,7 @@ error_alignment:
              if (sec == NULL)
                info->callbacks->einfo (_("%F%P: failed to create the second PLT .eh_frame section\n"));
 
-             if (!bfd_set_section_alignment (dynobj, sec, class_align))
+             if (!bfd_set_section_alignment (sec, class_align))
                goto error_alignment;
 
              htab->plt_second_eh_frame = sec;
@@ -2993,7 +2990,7 @@ error_alignment:
         section backwards, resulting in a warning and section lma not
         being set properly.  It later leads to a "File truncated"
         error.  */
-      if (!bfd_set_section_alignment (sec->owner, sec, 0))
+      if (!bfd_set_section_alignment (sec, 0))
        goto error_alignment;
 
       htab->plt.iplt_alignment = (normal_target