/* IBM RS/6000 "XCOFF" back-end for BFD.
Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2000,
- 2001
+ 2001, 2002
Free Software Foundation, Inc.
FIXME: Can someone provide a transliteration of this name into ASCII?
Using the following chars caused a compiler warning on HIUX (so I replaced
{
bfd_size_type size;
- if (bfd_seek (abfd, 0, SEEK_SET) != 0)
+ if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0)
return false;
/* Read the leading portion that old and new core dump structures have in
common. */
- if (bfd_read (core, CORE_COMMONSZ, 1, abfd) != CORE_COMMONSZ)
+ size = CORE_COMMONSZ;
+ if (bfd_bread (core, size, abfd) != size)
return false;
/* Read the trailing portion of the structure. */
- size = CORE_NEW (*core) ? sizeof (core->new) : sizeof (core->old)
- - CORE_COMMONSZ;
- return bfd_read ((char *) core + CORE_COMMONSZ, size, 1, abfd) == size;
+ if (CORE_NEW (*core))
+ size = sizeof (core->new);
+ else
+ size = sizeof (core->old);
+ size -= CORE_COMMONSZ;
+ return bfd_bread ((char *) core + CORE_COMMONSZ, size, abfd) == size;
}
static asection *
make_bfd_asection (abfd, name, flags, _raw_size, vma, filepos)
bfd *abfd;
- CONST char *name;
+ const char *name;
flagword flags;
bfd_size_type _raw_size;
bfd_vma vma;
/* Allocate core file header. */
size = CORE_NEW (core) ? sizeof (core.new) : sizeof (core.old);
- tmpptr = (char *) bfd_zalloc (abfd, size);
+ tmpptr = (char *) bfd_zalloc (abfd, (bfd_size_type) size);
if (!tmpptr)
return NULL;
if (!make_bfd_asection (abfd, ".stack",
SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
c_size, c_stackend - c_size, c_stack))
- return NULL;
+ goto fail;
/* .reg section for all registers. */
if (!make_bfd_asection (abfd, ".reg",
SEC_HAS_CONTENTS,
c_regsize, (bfd_vma) 0, c_regoff))
- return NULL;
+ goto fail;
/* .ldinfo section.
To actually find out how long this section is in this particular
if (!make_bfd_asection (abfd, ".ldinfo",
SEC_HAS_CONTENTS,
c_lsize, (bfd_vma) 0, c_loader))
- return NULL;
+ goto fail;
#ifndef CORE_VERSION_1
/* .data section if present.
(bfd_vma)
CDATA_ADDR (core.old.c_u.u_dsize),
c_stack + c_size))
- return NULL;
+ goto fail;
}
#endif
c_datasize,
(bfd_vma) CDATA_ADDR (c_datasize),
c_data))
- return NULL;
+ goto fail;
}
/* .data sections from loaded objects. */
while (1)
{
if (bfd_seek (abfd, c_loader, SEEK_SET) != 0)
- return NULL;
- if (bfd_read (&ldinfo, size, 1, abfd) != size)
- return NULL;
+ goto fail;
+ if (bfd_bread (&ldinfo, size, abfd) != size)
+ goto fail;
if (proc64)
{
if (!make_bfd_asection (abfd, ".data",
SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
ldi_datasize, ldi_dataorg, ldi_core))
- return NULL;
+ goto fail;
if (ldi_next == 0)
break;
bfd_size_type i;
if (bfd_seek (abfd, c_vmm, SEEK_SET) != 0)
- return NULL;
+ goto fail;
for (i = 0; i < c_vmregions; i++)
{
bfd_vma vminfo_addr;
size = CORE_NEW (core) ? sizeof (vminfo.new) : sizeof (vminfo.old);
- if (bfd_read (&vminfo, size, 1, abfd) != size)
- return NULL;
+ if (bfd_bread (&vminfo, size, abfd) != size)
+ goto fail;
if (CORE_NEW (core))
{
SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS,
vminfo_size, vminfo_addr,
vminfo_offset))
- return NULL;
+ goto fail;
}
}
}
#endif
return abfd->xvec; /* This is garbage for now. */
+
+ fail:
+ bfd_release (abfd, abfd->tdata.any);
+ abfd->tdata.any = NULL;
+ bfd_section_list_clear (abfd);
+ return NULL;
}
/* Return `true' if given core is from the given executable. */
return false;
alloc = 100;
- path = bfd_malloc (alloc);
+ path = bfd_malloc ((bfd_size_type) alloc);
if (path == NULL)
return false;
s = path;
while (1)
{
- if (bfd_read (s, 1, 1, core_bfd) != 1)
+ if (bfd_bread (s, (bfd_size_type) 1, core_bfd) != 1)
{
free (path);
return false;
char *n;
alloc *= 2;
- n = bfd_realloc (path, alloc);
+ n = bfd_realloc (path, (bfd_size_type) alloc);
if (n == NULL)
{
free (path);