Introduce scope_exit

[deliverable/binutils-gdb.git] / bfd / section.c

diff --git a/bfd/section.c b/bfd/section.c
index 752f291cb10a5690829db944435475fc48319752..64636334ac9316e31894fa2abf5218091f2253d5 100644 (file)
--- a/bfd/section.c
+++ b/bfd/section.c
@@ -1,5 +1,5 @@
 /* Object file "section" support for the BFD library.
-   Copyright (C) 1990-2018 Free Software Foundation, Inc.
+   Copyright (C) 1990-2019 Free Software Foundation, Inc.
    Written by Cygnus Support.
 
    This file is part of BFD, the Binary File Descriptor library.
@@ -820,21 +820,21 @@ _bfd_generic_new_section_hook (bfd *abfd, asection *newsect)
   return TRUE;
 }
 
-static unsigned int section_id = 0x10;  /* id 0 to 3 used by STD_SECTION.  */
+unsigned int _bfd_section_id = 0x10;  /* id 0 to 3 used by STD_SECTION.  */
 
 /* Initializes a new section.  NEWSECT->NAME is already set.  */
 
 static asection *
 bfd_section_init (bfd *abfd, asection *newsect)
 {
-  newsect->id = section_id;
+  newsect->id = _bfd_section_id;
   newsect->index = abfd->section_count;
   newsect->owner = abfd;
 
   if (! BFD_SEND (abfd, _new_section_hook, (abfd, newsect)))
     return NULL;
 
-  section_id++;
+  _bfd_section_id++;
   abfd->section_count++;
   bfd_section_list_append (abfd, newsect);
   return newsect;
@@ -1284,23 +1284,6 @@ bfd_make_section (bfd *abfd, const char *name)
   return bfd_make_section_with_flags (abfd, name, 0);
 }
 
-/*
-FUNCTION
-       bfd_get_next_section_id
-
-SYNOPSIS
-       int bfd_get_next_section_id (void);
-
-DESCRIPTION
-       Returns the id that the next section created will have.
-*/
-
-int
-bfd_get_next_section_id (void)
-{
-  return section_id;
-}
-
 /*
 FUNCTION
        bfd_set_section_flags
@@ -1474,16 +1457,20 @@ SYNOPSIS
 
 DESCRIPTION
        Sets the contents of the section @var{section} in BFD
-       @var{abfd} to the data starting in memory at @var{data}. The
-       data is written to the output section starting at offset
+       @var{abfd} to the data starting in memory at @var{location}.
+       The data is written to the output section starting at offset
        @var{offset} for @var{count} octets.
 
-       Normally <<TRUE>> is returned, else <<FALSE>>. Possible error
-       returns are:
+       Normally <<TRUE>> is returned, but <<FALSE>> is returned if
+       there was an error.  Possible error returns are:
        o <<bfd_error_no_contents>> -
        The output section does not have the <<SEC_HAS_CONTENTS>>
        attribute, so nothing can be written to it.
-       o and some more too
+       o <<bfd_error_bad_value>> -
+       The section is unable to contain all of the data.
+       o <<bfd_error_invalid_operation>> -
+       The BFD is not writeable.
+       o and some more too.
 
        This routine is front end to the back end function
        <<_bfd_set_section_contents>>.