Values API: split into private and public APIs
[babeltrace.git] / cli / babeltrace.c
index 2d273bd19e28d03bb0259323b74f30ed91b61e5f..8e17c2a10458ced2cd046bae543be6caab2f9a2e 100644 (file)
@@ -31,7 +31,6 @@
 
 #include <babeltrace/babeltrace.h>
 #include <babeltrace/common-internal.h>
-#include <babeltrace/values-internal.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <popt.h>
@@ -139,7 +138,7 @@ void set_signal_handler(void)
 static
 void init_static_data(void)
 {
-       loaded_plugins = g_ptr_array_new_with_free_func(bt_put);
+       loaded_plugins = g_ptr_array_new_with_free_func(bt_object_put_ref);
 }
 
 static
@@ -165,7 +164,7 @@ int create_the_query_executor(void)
 static
 void destroy_the_query_executor(void)
 {
-       BT_PUT(the_query_executor);
+       BT_OBJECT_PUT_REF_AND_RESET(the_query_executor);
 }
 
 static
@@ -254,7 +253,7 @@ error:
 
 end:
        destroy_the_query_executor();
-       bt_put(result);
+       bt_object_put_ref(result);
        return ret;
 }
 
@@ -285,7 +284,7 @@ struct bt_plugin *find_plugin(const char *name)
                }
        }
 
-       return bt_get(plugin);
+       return bt_object_get_ref(plugin);
 }
 
 static
@@ -308,7 +307,7 @@ struct bt_component_class *find_component_class(const char *plugin_name,
 
        comp_class = bt_plugin_get_component_class_by_name_and_type(plugin,
                        comp_class_name, comp_class_type);
-       BT_PUT(plugin);
+       BT_OBJECT_PUT_REF_AND_RESET(plugin);
 
 end:
        if (BT_LOG_ON_DEBUG) {
@@ -552,7 +551,7 @@ void print_value_rec(FILE *fp, struct bt_value *value, size_t indent)
 
 error:
        BT_LOGE("Error printing value of type %s.",
-               bt_value_type_string(bt_value_get_type(value)));
+               bt_common_value_type_string(bt_value_get_type(value)));
 }
 
 static
@@ -580,7 +579,8 @@ void print_bt_config_component(struct bt_config_component *bt_config_component)
        }
 
        fprintf(stderr, "      Parameters:\n");
-       print_value(stderr, bt_config_component->params, 8);
+       print_value(stderr,
+               bt_value_borrow_from_private(bt_config_component->params), 8);
 }
 
 static
@@ -592,7 +592,7 @@ void print_bt_config_components(GPtrArray *array)
                struct bt_config_component *cfg_component =
                                bt_config_get_component(array, i);
                print_bt_config_component(cfg_component);
-               BT_PUT(cfg_component);
+               BT_OBJECT_PUT_REF_AND_RESET(cfg_component);
        }
 }
 
@@ -608,7 +608,7 @@ void print_cfg_run(struct bt_config *cfg)
 {
        size_t i;
 
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Source component instances:\n");
        print_bt_config_components(cfg->cmd_data.run.sources);
 
@@ -639,19 +639,19 @@ void print_cfg_run(struct bt_config *cfg)
 static
 void print_cfg_list_plugins(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
 }
 
 static
 void print_cfg_help(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
 }
 
 static
 void print_cfg_print_ctf_metadata(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Path: %s\n",
                cfg->cmd_data.print_ctf_metadata.path->str);
 }
@@ -659,7 +659,7 @@ void print_cfg_print_ctf_metadata(struct bt_config *cfg)
 static
 void print_cfg_print_lttng_live_sessions(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  URL: %s\n",
                cfg->cmd_data.print_lttng_live_sessions.url->str);
 }
@@ -667,7 +667,7 @@ void print_cfg_print_lttng_live_sessions(struct bt_config *cfg)
 static
 void print_cfg_query(struct bt_config *cfg)
 {
-       print_plugin_paths(cfg->plugin_paths);
+       print_plugin_paths(bt_value_borrow_from_private(cfg->plugin_paths));
        fprintf(stderr, "  Object: `%s`\n", cfg->cmd_data.query.object->str);
        fprintf(stderr, "  Component class:\n");
        print_bt_config_component(cfg->cmd_data.query.cfg_component);
@@ -732,15 +732,15 @@ void add_to_loaded_plugins(struct bt_plugin_set *plugin_set)
                                bt_plugin_get_name(plugin),
                                bt_plugin_get_path(plugin),
                                bt_plugin_get_path(loaded_plugin));
-                       bt_put(loaded_plugin);
+                       bt_object_put_ref(loaded_plugin);
                } else {
                        /* Add to global array. */
                        BT_LOGD("Adding plugin to loaded plugins: plugin-path=\"%s\"",
                                bt_plugin_get_name(plugin));
-                       g_ptr_array_add(loaded_plugins, bt_get(plugin));
+                       g_ptr_array_add(loaded_plugins, bt_object_get_ref(plugin));
                }
 
-               bt_put(plugin);
+               bt_object_put_ref(plugin);
        }
 }
 
@@ -791,7 +791,7 @@ int load_dynamic_plugins(struct bt_value *plugin_paths)
                }
 
                add_to_loaded_plugins(plugin_set);
-               bt_put(plugin_set);
+               bt_object_put_ref(plugin_set);
        }
 end:
        return ret;
@@ -812,7 +812,7 @@ int load_static_plugins(void)
        }
 
        add_to_loaded_plugins(plugin_set);
-       bt_put(plugin_set);
+       bt_object_put_ref(plugin_set);
 end:
        return ret;
 }
@@ -920,8 +920,8 @@ int cmd_query(struct bt_config *cfg)
        }
 
        ret = query(comp_cls, cfg->cmd_data.query.object->str,
-               cfg->cmd_data.query.cfg_component->params, &results,
-               &fail_reason);
+               bt_value_borrow_from_private(cfg->cmd_data.query.cfg_component->params),
+               &results, &fail_reason);
        if (ret) {
                goto failed;
        }
@@ -954,8 +954,8 @@ failed:
        ret = -1;
 
 end:
-       bt_put(comp_cls);
-       bt_put(results);
+       bt_object_put_ref(comp_cls);
+       bt_object_put_ref(results);
        return ret;
 }
 
@@ -1013,7 +1013,7 @@ int cmd_help(struct bt_config *cfg)
                        goto end;
                }
 
-               bt_put(needed_comp_cls);
+               bt_object_put_ref(needed_comp_cls);
        }
 
        for (i = 0; i < bt_plugin_get_component_class_count(plugin); i++) {
@@ -1035,7 +1035,7 @@ int cmd_help(struct bt_config *cfg)
                        if (strcmp(cfg->cmd_data.help.cfg_component->comp_cls_name->str,
                                        comp_class_name) != 0 ||
                                        type != cfg->cmd_data.help.cfg_component->type) {
-                               bt_put(comp_cls);
+                               bt_object_put_ref(comp_cls);
                                continue;
                        }
                }
@@ -1054,11 +1054,11 @@ int cmd_help(struct bt_config *cfg)
                        printf("\n%s\n", comp_class_help);
                }
 
-               bt_put(comp_cls);
+               bt_object_put_ref(comp_cls);
        }
 
 end:
-       bt_put(plugin);
+       bt_object_put_ref(plugin);
        return ret;
 }
 
@@ -1069,7 +1069,7 @@ int cmd_list_plugins(struct bt_config *cfg)
        int plugins_count, component_classes_count = 0, i;
 
        printf("From the following plugin paths:\n\n");
-       print_value(stdout, cfg->plugin_paths, 2);
+       print_value(stdout, bt_value_borrow_from_private(cfg->plugin_paths), 2);
        printf("\n");
        plugins_count = loaded_plugins->len;
        if (plugins_count == 0) {
@@ -1131,7 +1131,7 @@ int cmd_list_plugins(struct bt_config *cfg)
                        }
 
                        printf("\n");
-                       bt_put(comp_class);
+                       bt_object_put_ref(comp_class);
                }
        }
 
@@ -1145,7 +1145,7 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
        int ret = 0;
        struct bt_component_class *comp_cls = NULL;
        struct bt_value *results = NULL;
-       struct bt_value *params = NULL;
+       struct bt_private_value *params = NULL;
        struct bt_value *map = NULL;
        struct bt_value *v = NULL;
        static const char * const plugin_name = "ctf";
@@ -1174,18 +1174,19 @@ int cmd_print_lttng_live_sessions(struct bt_config *cfg)
                goto error;
        }
 
-       params = bt_value_map_create();
+       params = bt_private_value_map_create();
        if (!params) {
                goto error;
        }
 
-       ret = bt_value_map_insert_string_entry(params, "url",
+       ret = bt_private_value_map_insert_string_entry(params, "url",
                cfg->cmd_data.print_lttng_live_sessions.url->str);
        if (ret) {
                goto error;
        }
 
-       ret = query(comp_cls, "sessions", params, &results, &fail_reason);
+       ret = query(comp_cls, "sessions", bt_value_borrow_from_private(params),
+               &results, &fail_reason);
        if (ret) {
                goto failed;
        }
@@ -1277,9 +1278,9 @@ error:
        ret = -1;
 
 end:
-       bt_put(results);
-       bt_put(params);
-       bt_put(comp_cls);
+       bt_object_put_ref(results);
+       bt_object_put_ref(params);
+       bt_object_put_ref(comp_cls);
 
        if (out_stream && out_stream != stdout) {
                int fclose_ret = fclose(out_stream);
@@ -1300,7 +1301,7 @@ int cmd_print_ctf_metadata(struct bt_config *cfg)
        int ret = 0;
        struct bt_component_class *comp_cls = NULL;
        struct bt_value *results = NULL;
-       struct bt_value *params = NULL;
+       struct bt_private_value *params = NULL;
        struct bt_value *metadata_text_value = NULL;
        const char *metadata_text = NULL;
        static const char * const plugin_name = "ctf";
@@ -1329,20 +1330,21 @@ int cmd_print_ctf_metadata(struct bt_config *cfg)
                goto end;
        }
 
-       params = bt_value_map_create();
+       params = bt_private_value_map_create();
        if (!params) {
                ret = -1;
                goto end;
        }
 
-       ret = bt_value_map_insert_string_entry(params, "path",
+       ret = bt_private_value_map_insert_string_entry(params, "path",
                cfg->cmd_data.print_ctf_metadata.path->str);
        if (ret) {
                ret = -1;
                goto end;
        }
 
-       ret = query(comp_cls, "metadata-info", params, &results, &fail_reason);
+       ret = query(comp_cls, "metadata-info",
+               bt_value_borrow_from_private(params), &results, &fail_reason);
        if (ret) {
                goto failed;
        }
@@ -1389,9 +1391,9 @@ failed:
 
 end:
        destroy_the_query_executor();
-       bt_put(results);
-       bt_put(params);
-       bt_put(comp_cls);
+       bt_object_put_ref(results);
+       bt_object_put_ref(params);
+       bt_object_put_ref(comp_cls);
 
        if (out_stream && out_stream != stdout) {
                int fclose_ret = fclose(out_stream);
@@ -1533,7 +1535,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
        struct bt_port *(*port_by_index_fn)(struct bt_component *, uint64_t);
        enum bt_graph_status status = BT_GRAPH_STATUS_ERROR;
        bool insert_trimmer = false;
-       struct bt_value *trimmer_params = NULL;
+       struct bt_private_value *trimmer_params = NULL;
        char *intersection_begin = NULL;
        char *intersection_end = NULL;
        struct bt_component *trimmer = NULL;
@@ -1569,17 +1571,17 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                        }
 
                        insert_trimmer = true;
-                       trimmer_params = bt_value_map_create();
+                       trimmer_params = bt_private_value_map_create();
                        if (!trimmer_params) {
                                goto error;
                        }
 
-                       status = bt_value_map_insert_string_entry(
+                       status = bt_private_value_map_insert_string_entry(
                                trimmer_params, "begin", intersection_begin);
                        if (status != BT_VALUE_STATUS_OK) {
                                goto error;
                        }
-                       status = bt_value_map_insert_string_entry(
+                       status = bt_private_value_map_insert_string_entry(
                                trimmer_params,
                                "end", intersection_end);
                        if (status != BT_VALUE_STATUS_OK) {
@@ -1643,7 +1645,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
 
                /* Skip port if it's already connected. */
                if (bt_port_is_connected(downstream_port)) {
-                       bt_put(downstream_port);
+                       bt_object_put_ref(downstream_port);
                        BT_LOGD("Skipping downstream port: already connected: "
                                "port-addr=%p, port-name=\"%s\"",
                                downstream_port,
@@ -1659,7 +1661,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                if (!bt_common_star_glob_match(
                                cfg_conn->downstream_port_glob->str, SIZE_MAX,
                                downstream_port_name, SIZE_MAX)) {
-                       bt_put(downstream_port);
+                       bt_object_put_ref(downstream_port);
                        continue;
                }
 
@@ -1690,7 +1692,8 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
 
                        ctx->connect_ports = false;
                        graph_status = bt_graph_add_component(ctx->graph,
-                               trimmer_class, trimmer_name, trimmer_params,
+                               trimmer_class, trimmer_name,
+                               bt_value_borrow_from_private(trimmer_params),
                                &trimmer);
                        free(trimmer_name);
                        if (graph_status != BT_GRAPH_STATUS_OK) {
@@ -1715,7 +1718,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                         * Replace the current downstream port by the trimmer's
                         * upstream port.
                         */
-                       BT_MOVE(downstream_port, trimmer_input);
+                       BT_OBJECT_MOVE_REF(downstream_port, trimmer_input);
                        downstream_port_name = bt_port_get_name(
                                downstream_port);
                        if (!downstream_port_name) {
@@ -1726,7 +1729,7 @@ int cmd_run_ctx_connect_upstream_port_to_downstream_component(
                /* We have a winner! */
                status = bt_graph_connect_ports(ctx->graph,
                        upstream_port, downstream_port, NULL);
-               BT_PUT(downstream_port);
+               BT_OBJECT_PUT_REF_AND_RESET(downstream_port);
                switch (status) {
                case BT_GRAPH_STATUS_OK:
                        break;
@@ -1822,11 +1825,11 @@ error:
 end:
        free(intersection_begin);
        free(intersection_end);
-       BT_PUT(trimmer_params);
-       BT_PUT(trimmer_class);
-       BT_PUT(trimmer);
-       BT_PUT(trimmer_input);
-       BT_PUT(trimmer_output);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_params);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_class);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_input);
+       BT_OBJECT_PUT_REF_AND_RESET(trimmer_output);
        return ret;
 }
 
@@ -1904,7 +1907,7 @@ error:
        ret = -1;
 
 end:
-       bt_put(upstream_comp);
+       bt_object_put_ref(upstream_comp);
        return ret;
 }
 
@@ -1946,7 +1949,7 @@ void graph_port_added_listener(struct bt_port *port, void *data)
        }
 
 end:
-       bt_put(comp);
+       bt_object_put_ref(comp);
        return;
 }
 
@@ -1978,8 +1981,8 @@ void graph_ports_connected_listener(struct bt_port *upstream_port,
                upstream_port, bt_port_get_name(upstream_port),
                downstream_comp, bt_component_get_name(downstream_comp),
                downstream_port, bt_port_get_name(downstream_port));
-       bt_put(upstream_comp);
-       bt_put(downstream_comp);
+       bt_object_put_ref(upstream_comp);
+       bt_object_put_ref(downstream_comp);
 }
 
 static
@@ -2013,7 +2016,7 @@ void cmd_run_ctx_destroy(struct cmd_run_ctx *ctx)
                ctx->intersections = NULL;
        }
 
-       BT_PUT(ctx->graph);
+       BT_OBJECT_PUT_REF_AND_RESET(ctx->graph);
        the_graph = NULL;
        ctx->cfg = NULL;
 }
@@ -2026,7 +2029,7 @@ int cmd_run_ctx_init(struct cmd_run_ctx *ctx, struct bt_config *cfg)
        ctx->cfg = cfg;
        ctx->connect_ports = false;
        ctx->components = g_hash_table_new_full(g_direct_hash, g_direct_equal,
-               NULL, bt_put);
+               NULL, bt_object_put_ref);
        if (!ctx->components) {
                goto error;
        }
@@ -2095,7 +2098,7 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
        enum bt_value_status value_status;
        const char *path = NULL;
        struct bt_value *component_path_value = NULL;
-       struct bt_value *query_params = NULL;
+       struct bt_private_value *query_params = NULL;
        struct bt_value *query_result = NULL;
        struct bt_value *trace_info = NULL;
        struct bt_value *intersection_range = NULL;
@@ -2109,7 +2112,8 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
        struct trace_range *trace_range = NULL;
        const char *fail_reason = NULL;
 
-       component_path_value = bt_value_map_borrow_entry_value(cfg_comp->params,
+       component_path_value = bt_value_map_borrow_entry_value(
+               bt_value_borrow_from_private(cfg_comp->params),
                "path");
        if (component_path_value && !bt_value_is_string(component_path_value)) {
                BT_LOGD("Cannot get path parameter: component-name=%s",
@@ -2126,14 +2130,14 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                goto error;
        }
 
-       query_params = bt_value_map_create();
+       query_params = bt_private_value_map_create();
        if (!query_params) {
                BT_LOGE_STR("Cannot create query parameters.");
                ret = -1;
                goto error;
        }
 
-       value_status = bt_value_map_insert_entry(query_params, "path",
+       value_status = bt_private_value_map_insert_entry(query_params, "path",
                component_path_value);
        if (value_status != BT_VALUE_STATUS_OK) {
                BT_LOGE_STR("Cannot insert path parameter in query parameter map.");
@@ -2141,7 +2145,8 @@ int set_stream_intersections(struct cmd_run_ctx *ctx,
                goto error;
        }
 
-       ret = query(comp_cls, "trace-info", query_params, &query_result,
+       ret = query(comp_cls, "trace-info",
+               bt_value_borrow_from_private(query_params), &query_result,
                &fail_reason);
        if (ret) {
                BT_LOGD("Component class does not support the `trace-info` query: %s: "
@@ -2336,8 +2341,8 @@ error:
                path ? path : "(unknown)",
                bt_common_color_reset());
 end:
-       bt_put(query_params);
-       bt_put(query_result);
+       bt_object_put_ref(query_params);
+       bt_object_put_ref(query_result);
        g_free(port_id);
        g_free(trace_range);
        return ret;
@@ -2378,7 +2383,8 @@ int cmd_run_ctx_create_components_from_config_components(
                }
 
                ret = bt_graph_add_component(ctx->graph, comp_cls,
-                       cfg_comp->instance_name->str, cfg_comp->params, &comp);
+                       cfg_comp->instance_name->str,
+                       bt_value_borrow_from_private(cfg_comp->params), &comp);
                if (ret) {
                        BT_LOGE("Cannot create component: plugin-name=\"%s\", "
                                "comp-cls-name=\"%s\", comp-cls-type=%d, "
@@ -2409,7 +2415,7 @@ int cmd_run_ctx_create_components_from_config_components(
                g_hash_table_insert(ctx->components,
                        GUINT_TO_POINTER(quark), comp);
                comp = NULL;
-               BT_PUT(comp_cls);
+               BT_OBJECT_PUT_REF_AND_RESET(comp_cls);
        }
 
        goto end;
@@ -2418,8 +2424,8 @@ error:
        ret = -1;
 
 end:
-       bt_put(comp);
-       bt_put(comp_cls);
+       bt_object_put_ref(comp);
+       bt_object_put_ref(comp_cls);
        return ret;
 }
 
@@ -2479,7 +2485,7 @@ int cmd_run_ctx_connect_comp_ports(struct cmd_run_ctx *ctx,
 
                BT_ASSERT(upstream_port);
                ret = cmd_run_ctx_connect_upstream_port(ctx, upstream_port);
-               bt_put(upstream_port);
+               bt_object_put_ref(upstream_port);
                if (ret) {
                        goto end;
                }
@@ -2853,7 +2859,8 @@ int main(int argc, const char **argv)
        print_cfg(cfg);
 
        if (cfg->command_needs_plugins) {
-               ret = load_all_plugins(cfg->plugin_paths);
+               ret = load_all_plugins(
+                       bt_value_borrow_from_private(cfg->plugin_paths));
                if (ret) {
                        BT_LOGE("Failed to load plugins: ret=%d", ret);
                        retcode = 1;
@@ -2894,7 +2901,7 @@ int main(int argc, const char **argv)
        retcode = ret ? 1 : 0;
 
 end:
-       BT_PUT(cfg);
+       BT_OBJECT_PUT_REF_AND_RESET(cfg);
        fini_static_data();
        return retcode;
 }
This page took 0.035089 seconds and 4 git commands to generate.