ir: freeze attributes when freezing an event
[babeltrace.git] / formats / ctf / ir / event.c
index c168854e244ad4f81d61df6e5e2009f5663a646c..1e9f2b853bb1478308eca087598f0610d15c7928 100644 (file)
 #include <babeltrace/ctf-ir/stream-class.h>
 #include <babeltrace/ctf-ir/stream-class-internal.h>
 #include <babeltrace/ctf-ir/trace-internal.h>
+#include <babeltrace/ctf-ir/validation-internal.h>
 #include <babeltrace/ctf-ir/utils.h>
+#include <babeltrace/ref.h>
 #include <babeltrace/ctf-ir/attributes-internal.h>
 #include <babeltrace/compiler.h>
 
 static
-void bt_ctf_event_class_destroy(struct bt_ctf_ref *ref);
+void bt_ctf_event_class_destroy(struct bt_object *obj);
 static
-void bt_ctf_event_destroy(struct bt_ctf_ref *ref);
+void bt_ctf_event_destroy(struct bt_object *obj);
 static
 int set_integer_field_value(struct bt_ctf_field *field, uint64_t value);
 
 struct bt_ctf_event_class *bt_ctf_event_class_create(const char *name)
 {
        int ret;
-       struct bt_object *obj = NULL;
+       struct bt_value *obj = NULL;
        struct bt_ctf_event_class *event_class = NULL;
 
        if (bt_ctf_validate_identifier(name)) {
@@ -61,7 +63,7 @@ struct bt_ctf_event_class *bt_ctf_event_class_create(const char *name)
                goto error;
        }
 
-       bt_ctf_ref_init(&event_class->ref_count);
+       bt_object_init(event_class, bt_ctf_event_class_destroy);
        event_class->fields = bt_ctf_field_type_structure_create();
        if (!event_class->fields) {
                goto error;
@@ -72,7 +74,7 @@ struct bt_ctf_event_class *bt_ctf_event_class_create(const char *name)
                goto error;
        }
 
-       obj = bt_object_integer_create_init(-1);
+       obj = bt_value_integer_create_init(-1);
        if (!obj) {
                goto error;
        }
@@ -83,9 +85,9 @@ struct bt_ctf_event_class *bt_ctf_event_class_create(const char *name)
                goto error;
        }
 
-       BT_OBJECT_PUT(obj);
+       BT_PUT(obj);
 
-       obj = bt_object_string_create_init(name);
+       obj = bt_value_string_create_init(name);
        if (!obj) {
                goto error;
        }
@@ -96,23 +98,19 @@ struct bt_ctf_event_class *bt_ctf_event_class_create(const char *name)
                goto error;
        }
 
-       BT_OBJECT_PUT(obj);
+       BT_PUT(obj);
 
        return event_class;
 
 error:
-       if (event_class) {
-               bt_ctf_event_class_put(event_class);
-       }
-
-       BT_OBJECT_PUT(obj);
-
-       return NULL;
+        BT_PUT(event_class);
+       BT_PUT(obj);
+       return event_class;
 }
 
 const char *bt_ctf_event_class_get_name(struct bt_ctf_event_class *event_class)
 {
-       struct bt_object *obj = NULL;
+       struct bt_value *obj = NULL;
        const char *name = NULL;
 
        if (!event_class) {
@@ -125,19 +123,18 @@ const char *bt_ctf_event_class_get_name(struct bt_ctf_event_class *event_class)
                goto end;
        }
 
-       if (bt_object_string_get(obj, &name)) {
+       if (bt_value_string_get(obj, &name)) {
                name = NULL;
        }
 
 end:
-       BT_OBJECT_PUT(obj);
-
+       BT_PUT(obj);
        return name;
 }
 
 int64_t bt_ctf_event_class_get_id(struct bt_ctf_event_class *event_class)
 {
-       struct bt_object *obj = NULL;
+       struct bt_value *obj = NULL;
        int64_t ret = 0;
 
        if (!event_class) {
@@ -151,7 +148,7 @@ int64_t bt_ctf_event_class_get_id(struct bt_ctf_event_class *event_class)
                goto end;
        }
 
-       if (bt_object_integer_get(obj, &ret)) {
+       if (bt_value_integer_get(obj, &ret)) {
                ret = -1;
        }
 
@@ -162,8 +159,7 @@ int64_t bt_ctf_event_class_get_id(struct bt_ctf_event_class *event_class)
        }
 
 end:
-       BT_OBJECT_PUT(obj);
-
+       BT_PUT(obj);
        return ret;
 }
 
@@ -171,14 +167,17 @@ int bt_ctf_event_class_set_id(struct bt_ctf_event_class *event_class,
                uint32_t id)
 {
        int ret = 0;
-       struct bt_object *obj = NULL;
+       struct bt_value *obj = NULL;
+       struct bt_ctf_stream_class *stream_class = NULL;
+
 
        if (!event_class) {
                ret = -1;
                goto end;
        }
 
-       if (event_class->stream_class) {
+       stream_class = bt_ctf_event_class_get_stream_class(event_class);
+       if (stream_class) {
                /*
                 * We don't allow changing the id if the event class has already
                 * been added to a stream class.
@@ -193,20 +192,20 @@ int bt_ctf_event_class_set_id(struct bt_ctf_event_class *event_class,
                goto end;
        }
 
-       if (bt_object_integer_set(obj, id)) {
+       if (bt_value_integer_set(obj, id)) {
                ret = -1;
                goto end;
        }
 
 end:
-       BT_OBJECT_PUT(obj);
-
+       BT_PUT(obj);
+       BT_PUT(stream_class);
        return ret;
 }
 
 int bt_ctf_event_class_set_attribute(
                struct bt_ctf_event_class *event_class, const char *name,
-               struct bt_object *value)
+               struct bt_value *value)
 {
        int ret = 0;
 
@@ -216,12 +215,12 @@ int bt_ctf_event_class_set_attribute(
        }
 
        if (!strcmp(name, "id") || !strcmp(name, "loglevel")) {
-               if (!bt_object_is_integer(value)) {
+               if (!bt_value_is_integer(value)) {
                        ret = -1;
                        goto end;
                }
        } else if (!strcmp(name, "name") || !strcmp(name, "model.emf.uri")) {
-               if (!bt_object_is_string(value)) {
+               if (!bt_value_is_string(value)) {
                        ret = -1;
                        goto end;
                }
@@ -235,7 +234,7 @@ int bt_ctf_event_class_set_attribute(
        if (!strcmp(name, "id")) {
                int64_t val;
 
-               ret = bt_object_integer_get(value, &val);
+               ret = bt_value_integer_get(value, &val);
 
                if (ret) {
                        goto end;
@@ -287,11 +286,11 @@ end:
        return ret;
 }
 
-struct bt_object *
+struct bt_value *
 bt_ctf_event_class_get_attribute_value(struct bt_ctf_event_class *event_class,
                int index)
 {
-       struct bt_object *ret;
+       struct bt_value *ret;
 
        if (!event_class) {
                ret = NULL;
@@ -304,11 +303,11 @@ end:
        return ret;
 }
 
-struct bt_object *
+struct bt_value *
 bt_ctf_event_class_get_attribute_value_by_name(
                struct bt_ctf_event_class *event_class, const char *name)
 {
-       struct bt_object *ret;
+       struct bt_value *ret;
 
        if (!event_class || !name) {
                ret = NULL;
@@ -326,16 +325,7 @@ end:
 struct bt_ctf_stream_class *bt_ctf_event_class_get_stream_class(
                struct bt_ctf_event_class *event_class)
 {
-       struct bt_ctf_stream_class *stream_class = NULL;
-
-       if (!event_class) {
-               goto end;
-       }
-
-       stream_class = event_class->stream_class;
-       bt_ctf_stream_class_get(stream_class);
-end:
-       return stream_class;
+       return (struct bt_ctf_stream_class *) bt_object_get_parent(event_class);
 }
 
 struct bt_ctf_field_type *bt_ctf_event_class_get_payload_type(
@@ -347,7 +337,7 @@ struct bt_ctf_field_type *bt_ctf_event_class_get_payload_type(
                goto end;
        }
 
-       bt_ctf_field_type_get(event_class->fields);
+       bt_get(event_class->fields);
        payload = event_class->fields;
 end:
        return payload;
@@ -364,8 +354,8 @@ int bt_ctf_event_class_set_payload_type(struct bt_ctf_event_class *event_class,
                goto end;
        }
 
-       bt_ctf_field_type_get(payload);
-       bt_ctf_field_type_put(event_class->fields);
+       bt_get(payload);
+       bt_put(event_class->fields);
        event_class->fields = payload;
 end:
        return ret;
@@ -478,7 +468,7 @@ struct bt_ctf_field_type *bt_ctf_event_class_get_context_type(
                goto end;
        }
 
-       bt_ctf_field_type_get(event_class->context);
+       bt_get(event_class->context);
        context_type = event_class->context;
 end:
        return context_type;
@@ -500,8 +490,8 @@ int bt_ctf_event_class_set_context_type(
                goto end;
        }
 
-       bt_ctf_field_type_get(context);
-       bt_ctf_field_type_put(event_class->context);
+       bt_get(context);
+       bt_put(event_class->context);
        event_class->context = context;
 end:
        return ret;
@@ -510,20 +500,12 @@ end:
 
 void bt_ctf_event_class_get(struct bt_ctf_event_class *event_class)
 {
-       if (!event_class) {
-               return;
-       }
-
-       bt_ctf_ref_get(&event_class->ref_count);
+       bt_get(event_class);
 }
 
 void bt_ctf_event_class_put(struct bt_ctf_event_class *event_class)
 {
-       if (!event_class) {
-               return;
-       }
-
-       bt_ctf_ref_put(&event_class->ref_count, bt_ctf_event_class_destroy);
+       bt_put(event_class);
 }
 
 BT_HIDDEN
@@ -531,9 +513,9 @@ int bt_ctf_event_class_set_stream_id(struct bt_ctf_event_class *event_class,
                uint32_t stream_id)
 {
        int ret = 0;
-       struct bt_object *obj;
+       struct bt_value *obj;
 
-       obj = bt_object_integer_create_init(stream_id);
+       obj = bt_value_integer_create_init(stream_id);
 
        if (!obj) {
                ret = -1;
@@ -543,70 +525,196 @@ int bt_ctf_event_class_set_stream_id(struct bt_ctf_event_class *event_class,
        ret = bt_ctf_attributes_set_field_value(event_class->attributes,
                "stream_id", obj);
 
-end:
-       BT_OBJECT_PUT(obj);
+       if (event_class->frozen) {
+               bt_ctf_attributes_freeze(event_class->attributes);
+       }
 
+end:
+       BT_PUT(obj);
        return ret;
 }
 
 struct bt_ctf_event *bt_ctf_event_create(struct bt_ctf_event_class *event_class)
 {
+       int ret;
+       enum bt_ctf_validation_flag validation_flags =
+               BT_CTF_VALIDATION_FLAG_STREAM |
+               BT_CTF_VALIDATION_FLAG_EVENT;
        struct bt_ctf_event *event = NULL;
+       struct bt_ctf_trace *trace = NULL;
+       struct bt_ctf_stream_class *stream_class = NULL;
+       struct bt_ctf_field_type *packet_header_type = NULL;
+       struct bt_ctf_field_type *packet_context_type = NULL;
+       struct bt_ctf_field_type *event_header_type = NULL;
+       struct bt_ctf_field_type *stream_event_ctx_type = NULL;
+       struct bt_ctf_field_type *event_context_type = NULL;
+       struct bt_ctf_field_type *event_payload_type = NULL;
+       struct bt_ctf_field *event_header = NULL;
+       struct bt_ctf_field *event_context = NULL;
+       struct bt_ctf_field *event_payload = NULL;
+       struct bt_value *environment = NULL;
+       struct bt_ctf_validation_output validation_output = { 0 };
+       int trace_valid = 0;
 
        if (!event_class) {
-               goto end;
+               goto error;
        }
 
+       stream_class = bt_ctf_event_class_get_stream_class(event_class);
+
        /*
-        * The event class does not keep ownership of the stream class to
-        * which it as been added. Therefore, it can't assume it has been
-        * set. However, we disallow the creation of an event if its
-        * associated stream class has been reclaimed.
+        * We disallow the creation of an event if its event class has not been
+        * associated to a stream class.
         */
-       if (!event_class->stream_class) {
-               goto end;
+       if (!stream_class) {
+               goto error;
        }
-       assert(event_class->stream_class->event_header_type);
+
+       /* A stream class should always have an existing event header type */
+       assert(stream_class->event_header_type);
+
+       /* The event class was frozen when added to its stream class */
+       assert(event_class->frozen);
+
+       /* Validate the trace (if any), the stream class, and the event class */
+       trace = bt_ctf_stream_class_get_trace(stream_class);
+       if (trace) {
+               packet_header_type = bt_ctf_trace_get_packet_header_type(trace);
+               trace_valid = trace->valid;
+               assert(trace_valid);
+               environment = trace->environment;
+       }
+
+       packet_context_type = bt_ctf_stream_class_get_packet_context_type(
+               stream_class);
+       event_header_type = bt_ctf_stream_class_get_event_header_type(
+               stream_class);
+       stream_event_ctx_type = bt_ctf_stream_class_get_event_context_type(
+               stream_class);
+       event_context_type = bt_ctf_event_class_get_context_type(event_class);
+       event_payload_type = bt_ctf_event_class_get_payload_type(event_class);
+       ret = bt_ctf_validate_class_types(environment, packet_header_type,
+               packet_context_type, event_header_type, stream_event_ctx_type,
+               event_context_type, event_payload_type, trace_valid,
+               stream_class->valid, event_class->valid,
+               &validation_output, validation_flags);
+       BT_PUT(packet_header_type);
+       BT_PUT(packet_context_type);
+       BT_PUT(event_header_type);
+       BT_PUT(stream_event_ctx_type);
+       BT_PUT(event_context_type);
+       BT_PUT(event_payload_type);
+
+       if (ret) {
+               /*
+                * This means something went wrong during the validation
+                * process, not that the objects are invalid.
+                */
+               goto error;
+       }
+
+       if ((validation_output.valid_flags & validation_flags) !=
+                       validation_flags) {
+               /* Invalid trace/stream class/event class */
+               goto error;
+       }
+
+       /*
+        * At this point we know the trace (if associated to the stream
+        * class), the stream class, and the event class, with their
+        * current types, are valid. We may proceed with creating
+        * the event.
+        */
        event = g_new0(struct bt_ctf_event, 1);
        if (!event) {
-               goto end;
+               goto error;
        }
 
-       bt_ctf_ref_init(&event->ref_count);
-       bt_ctf_event_class_get(event_class);
-       bt_ctf_event_class_freeze(event_class);
-       event->event_class = event_class;
+       bt_object_init(event, bt_ctf_event_destroy);
+
+       /*
+        * event does not share a common ancestor with the event class; it has
+        * to guarantee its existence by holding a reference. This reference
+        * shall be released once the event is associated to a stream since,
+        * from that point, the event and its class will share the same
+        * lifetime.
+        */
+       event->event_class = bt_get(event_class);
+       event_header =
+               bt_ctf_field_create(validation_output.event_header_type);
 
-       event->event_header = bt_ctf_field_create(
-               event_class->stream_class->event_header_type);
-       if (!event->event_header) {
-               goto error_destroy;
+       if (!event_header) {
+               goto error;
        }
-       if (event_class->context) {
-               event->context_payload = bt_ctf_field_create(
-                       event_class->context);
-               if (!event->context_payload) {
-                       goto error_destroy;
+
+       if (validation_output.event_context_type) {
+               event_context = bt_ctf_field_create(
+                       validation_output.event_context_type);
+               if (!event_context) {
+                       goto error;
                }
        }
-       event->fields_payload = bt_ctf_field_create(event_class->fields);
-       if (!event->fields_payload) {
-               goto error_destroy;
+
+       if (validation_output.event_payload_type) {
+               event_payload = bt_ctf_field_create(
+                       validation_output.event_payload_type);
+               if (!event_payload) {
+                       goto error;
+               }
        }
 
+       /*
+        * At this point all the fields are created, potentially from
+        * validated copies of field types, so that the field types and
+        * fields can be replaced in the trace, stream class,
+        * event class, and created event.
+        */
+       bt_ctf_validation_replace_types(trace, stream_class,
+               event_class, &validation_output, validation_flags);
+       BT_MOVE(event->event_header, event_header);
+       BT_MOVE(event->context_payload, event_context);
+       BT_MOVE(event->fields_payload, event_payload);
+
+       /*
+        * Put what was not moved in bt_ctf_validation_replace_types().
+        */
+       bt_ctf_validation_output_put_types(&validation_output);
+
        /*
         * Freeze the stream class since the event header must not be changed
         * anymore.
         */
-       bt_ctf_stream_class_freeze(event_class->stream_class);
-end:
+       bt_ctf_stream_class_freeze(stream_class);
+
+       /*
+        * Mark stream class, and event class as valid since
+        * they're all frozen now.
+        */
+       stream_class->valid = 1;
+       event_class->valid = 1;
+
+       /* Put stuff we borrowed from the event class */
+       BT_PUT(stream_class);
+       BT_PUT(trace);
+
        return event;
-error_destroy:
-       if (event) {
-               bt_ctf_event_destroy(&event->ref_count);
-       }
 
-       return NULL;
+error:
+       bt_ctf_validation_output_put_types(&validation_output);
+       BT_PUT(event);
+       BT_PUT(stream_class);
+       BT_PUT(trace);
+       BT_PUT(event_header);
+       BT_PUT(event_context);
+       BT_PUT(event_payload);
+       assert(!packet_header_type);
+       assert(!packet_context_type);
+       assert(!event_header_type);
+       assert(!stream_event_ctx_type);
+       assert(!event_context_type);
+       assert(!event_payload_type);
+
+       return event;
 }
 
 struct bt_ctf_event_class *bt_ctf_event_get_class(struct bt_ctf_event *event)
@@ -618,25 +726,14 @@ struct bt_ctf_event_class *bt_ctf_event_get_class(struct bt_ctf_event *event)
        }
 
        event_class = event->event_class;
-       bt_ctf_event_class_get(event_class);
+       bt_get(event_class);
 end:
        return event_class;
 }
 
 struct bt_ctf_stream *bt_ctf_event_get_stream(struct bt_ctf_event *event)
 {
-       struct bt_ctf_stream *stream = NULL;
-
-       if (!event) {
-               goto end;
-       }
-
-       stream = event->stream;
-       if (stream) {
-               bt_ctf_stream_get(stream);
-       }
-end:
-       return stream;
+       return (struct bt_ctf_stream *) bt_object_get_parent(event);
 }
 
 struct bt_ctf_clock *bt_ctf_event_get_clock(struct bt_ctf_event *event)
@@ -665,9 +762,9 @@ struct bt_ctf_clock *bt_ctf_event_get_clock(struct bt_ctf_event *event)
        }
 
 error_put_stream_class:
-       bt_ctf_stream_class_put(stream_class);
+       bt_put(stream_class);
 error_put_event_class:
-       bt_ctf_event_class_put(event_class);
+       bt_put(event_class);
 end:
        return clock;
 }
@@ -690,20 +787,66 @@ int bt_ctf_event_set_payload(struct bt_ctf_event *event,
                struct bt_ctf_field_type *payload_type;
 
                payload_type = bt_ctf_field_get_type(payload);
-               if (payload_type == event->event_class->fields) {
-                       bt_ctf_field_put(event->fields_payload);
-                       bt_ctf_field_get(payload);
+
+               if (bt_ctf_field_type_compare(payload_type,
+                               event->event_class->fields) == 0) {
+                       bt_put(event->fields_payload);
+                       bt_get(payload);
                        event->fields_payload = payload;
                } else {
                        ret = -1;
                }
 
-               bt_ctf_field_type_put(payload_type);
+               bt_put(payload_type);
        }
 end:
        return ret;
 }
 
+struct bt_ctf_field *bt_ctf_event_get_payload_field(struct bt_ctf_event *event)
+{
+       struct bt_ctf_field *payload = NULL;
+
+       if (!event || !event->fields_payload) {
+               goto end;
+       }
+
+       payload = event->fields_payload;
+       bt_get(payload);
+end:
+       return payload;
+}
+
+int bt_ctf_event_set_payload_field(struct bt_ctf_event *event,
+               struct bt_ctf_field *payload)
+{
+       int ret = 0;
+       struct bt_ctf_field_type *payload_type = NULL;
+
+       if (!event || !payload) {
+               ret = -1;
+               goto end;
+       }
+
+       payload_type = bt_ctf_field_get_type(payload);
+       if (!payload_type) {
+               ret = -1;
+               goto end;
+       }
+
+       if (bt_ctf_field_type_get_type_id(payload_type) != CTF_TYPE_STRUCT) {
+               ret = -1;
+               goto end;
+       }
+
+       bt_get(payload);
+       bt_put(event->fields_payload);
+       event->fields_payload = payload;
+
+end:
+       bt_put(payload_type);
+       return ret;
+}
 
 struct bt_ctf_field *bt_ctf_event_get_payload(struct bt_ctf_event *event,
                const char *name)
@@ -719,7 +862,7 @@ struct bt_ctf_field *bt_ctf_event_get_payload(struct bt_ctf_event *event,
                        name);
        } else {
                field = event->fields_payload;
-               bt_ctf_field_get(field);
+               bt_get(field);
        }
 end:
        return field;
@@ -740,7 +883,7 @@ end:
        return field;
 }
 
-struct bt_ctf_field *bt_ctf_event_get_event_header(
+struct bt_ctf_field *bt_ctf_event_get_header(
                struct bt_ctf_event *event)
 {
        struct bt_ctf_field *header = NULL;
@@ -750,45 +893,42 @@ struct bt_ctf_field *bt_ctf_event_get_event_header(
        }
 
        header = event->event_header;
-       bt_ctf_field_get(header);
+       bt_get(header);
 end:
        return header;
 }
 
-int bt_ctf_event_set_event_header(struct bt_ctf_event *event,
+int bt_ctf_event_set_header(struct bt_ctf_event *event,
                struct bt_ctf_field *header)
 {
        int ret = 0;
        struct bt_ctf_field_type *field_type = NULL;
+       struct bt_ctf_stream_class *stream_class = NULL;
 
        if (!event || !header) {
                ret = -1;
                goto end;
        }
 
-       /* Could be NULL since an event class doesn't own a stream class */
-       if (!event->event_class->stream_class) {
-               ret = -1;
-               goto end;
-       }
-
+       stream_class = (struct bt_ctf_stream_class *) bt_object_get_parent(
+               event->event_class);
        /*
         * Ensure the provided header's type matches the one registered to the
         * stream class.
         */
        field_type = bt_ctf_field_get_type(header);
-       if (field_type != event->event_class->stream_class->event_header_type) {
+       if (bt_ctf_field_type_compare(field_type,
+                       stream_class->event_header_type)) {
                ret = -1;
                goto end;
        }
 
-       bt_ctf_field_get(header);
-       bt_ctf_field_put(event->event_header);
+       bt_get(header);
+       bt_put(event->event_header);
        event->event_header = header;
 end:
-       if (field_type) {
-               bt_ctf_field_type_put(field_type);
-       }
+       bt_put(stream_class);
+       bt_put(field_type);
        return ret;
 }
 
@@ -802,7 +942,7 @@ struct bt_ctf_field *bt_ctf_event_get_event_context(
        }
 
        context = event->context_payload;
-       bt_ctf_field_get(context);
+       bt_get(context);
 end:
        return context;
 }
@@ -819,88 +959,59 @@ int bt_ctf_event_set_event_context(struct bt_ctf_event *event,
        }
 
        field_type = bt_ctf_field_get_type(context);
-       if (field_type != event->event_class->context) {
+       if (bt_ctf_field_type_compare(field_type,
+                       event->event_class->context)) {
                ret = -1;
                goto end;
        }
 
-       bt_ctf_field_get(context);
-       bt_ctf_field_put(event->context_payload);
+       bt_get(context);
+       bt_put(event->context_payload);
        event->context_payload = context;
 end:
-       if (field_type) {
-               bt_ctf_field_type_put(field_type);
-       }
+       bt_put(field_type);
        return ret;
 }
 
 void bt_ctf_event_get(struct bt_ctf_event *event)
 {
-       if (!event) {
-               return;
-       }
-
-       bt_ctf_ref_get(&event->ref_count);
+       bt_get(event);
 }
 
 void bt_ctf_event_put(struct bt_ctf_event *event)
 {
-       if (!event) {
-               return;
-       }
-
-       bt_ctf_ref_put(&event->ref_count, bt_ctf_event_destroy);
+       bt_put(event);
 }
 
 static
-void bt_ctf_event_class_destroy(struct bt_ctf_ref *ref)
+void bt_ctf_event_class_destroy(struct bt_object *obj)
 {
        struct bt_ctf_event_class *event_class;
 
-       if (!ref) {
-               return;
-       }
-
-       /*
-        * Don't call put() on the stream class. See comment in
-        * bt_ctf_event_class_set_stream_class for explanation.
-        */
-       event_class = container_of(ref, struct bt_ctf_event_class, ref_count);
-       if (event_class->attributes) {
-               bt_ctf_attributes_destroy(event_class->attributes);
-       }
-       if (event_class->context) {
-               bt_ctf_field_type_put(event_class->context);
-       }
-       if (event_class->fields) {
-               bt_ctf_field_type_put(event_class->fields);
-       }
+       event_class = container_of(obj, struct bt_ctf_event_class, base);
+       bt_ctf_attributes_destroy(event_class->attributes);
+       bt_put(event_class->context);
+       bt_put(event_class->fields);
        g_free(event_class);
 }
 
 static
-void bt_ctf_event_destroy(struct bt_ctf_ref *ref)
+void bt_ctf_event_destroy(struct bt_object *obj)
 {
        struct bt_ctf_event *event;
 
-       if (!ref) {
-               return;
-       }
-
-       event = container_of(ref, struct bt_ctf_event,
-               ref_count);
-       if (event->event_class) {
-               bt_ctf_event_class_put(event->event_class);
-       }
-       if (event->event_header) {
-               bt_ctf_field_put(event->event_header);
-       }
-       if (event->context_payload) {
-               bt_ctf_field_put(event->context_payload);
-       }
-       if (event->fields_payload) {
-               bt_ctf_field_put(event->fields_payload);
+       event = container_of(obj, struct bt_ctf_event, base);
+       if (!event->base.parent) {
+               /*
+                * Event was keeping a reference to its class since it shared no
+                * common ancestor with it to guarantee they would both have the
+                * same lifetime.
+                */
+               bt_put(event->event_class);
        }
+       bt_put(event->event_header);
+       bt_put(event->context_payload);
+       bt_put(event->fields_payload);
        g_free(event);
 }
 
@@ -943,7 +1054,7 @@ int set_integer_field_value(struct bt_ctf_field* field, uint64_t value)
                }
        }
 end:
-       bt_ctf_field_type_put(field_type);
+       bt_put(field_type);
        return ret;
 }
 
@@ -957,36 +1068,6 @@ void bt_ctf_event_class_freeze(struct bt_ctf_event_class *event_class)
        bt_ctf_attributes_freeze(event_class->attributes);
 }
 
-BT_HIDDEN
-int bt_ctf_event_class_set_stream_class(struct bt_ctf_event_class *event_class,
-               struct bt_ctf_stream_class *stream_class)
-{
-       int ret = 0;
-
-       if (!event_class) {
-               ret = -1;
-               goto end;
-       }
-
-       /* Allow a NULL stream_class to unset the current stream_class */
-       if (stream_class && event_class->stream_class) {
-               ret = -1;
-               goto end;
-       }
-
-       event_class->stream_class = stream_class;
-       /*
-        * We don't get() the stream_class since doing so would introduce
-        * a circular ownership between event classes and stream classes.
-        *
-        * A stream class will always unset itself from its events before
-        * being destroyed. This ensures that a user won't get a pointer
-        * to a stale stream class instance from an event class.
-        */
-end:
-       return ret;
-}
-
 BT_HIDDEN
 int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
                struct metadata_context *context)
@@ -994,7 +1075,7 @@ int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
        int i;
        int count;
        int ret = 0;
-       struct bt_object *attr_value = NULL;
+       struct bt_value *attr_value = NULL;
 
        assert(event_class);
        assert(context);
@@ -1022,12 +1103,12 @@ int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
                        goto end;
                }
 
-               switch (bt_object_get_type(attr_value)) {
-               case BT_OBJECT_TYPE_INTEGER:
+               switch (bt_value_get_type(attr_value)) {
+               case BT_VALUE_TYPE_INTEGER:
                {
                        int64_t value;
 
-                       ret = bt_object_integer_get(attr_value, &value);
+                       ret = bt_value_integer_get(attr_value, &value);
 
                        if (ret) {
                                goto end;
@@ -1038,11 +1119,11 @@ int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
                        break;
                }
 
-               case BT_OBJECT_TYPE_STRING:
+               case BT_VALUE_TYPE_STRING:
                {
                        const char *value;
 
-                       ret = bt_object_string_get(attr_value, &value);
+                       ret = bt_value_string_get(attr_value, &value);
 
                        if (ret) {
                                goto end;
@@ -1059,7 +1140,7 @@ int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
                        break;
                }
 
-               BT_OBJECT_PUT(attr_value);
+               BT_PUT(attr_value);
        }
 
        if (event_class->context) {
@@ -1084,7 +1165,7 @@ int bt_ctf_event_class_serialize(struct bt_ctf_event_class *event_class,
        g_string_append(context->string, "};\n\n");
 end:
        context->current_indentation_level = 0;
-       BT_OBJECT_PUT(attr_value);
+       BT_PUT(attr_value);
        return ret;
 }
 
@@ -1096,6 +1177,9 @@ void bt_ctf_event_class_set_native_byte_order(
                return;
        }
 
+       assert(byte_order == 0 || byte_order == LITTLE_ENDIAN ||
+               byte_order == BIG_ENDIAN);
+
        bt_ctf_field_type_set_native_byte_order(event_class->context,
                byte_order);
        bt_ctf_field_type_set_native_byte_order(event_class->fields,
@@ -1182,13 +1266,13 @@ int bt_ctf_event_populate_event_header(struct bt_ctf_event *event)
                assert(timestamp_field_type);
                mapped_clock = bt_ctf_field_type_integer_get_mapped_clock(
                        timestamp_field_type);
-               bt_ctf_field_type_put(timestamp_field_type);
+               bt_put(timestamp_field_type);
                if (mapped_clock) {
-                       uint64_t timestamp = bt_ctf_clock_get_time(
-                               mapped_clock);
+                       int64_t timestamp;
 
-                       bt_ctf_clock_put(mapped_clock);
-                       if (timestamp == (uint64_t) -1ULL) {
+                       ret = bt_ctf_clock_get_time(mapped_clock, &timestamp);
+                       bt_put(mapped_clock);
+                       if (ret) {
                                goto end;
                        }
 
@@ -1200,34 +1284,8 @@ int bt_ctf_event_populate_event_header(struct bt_ctf_event *event)
                }
        }
 end:
-       if (id_field) {
-               bt_ctf_field_put(id_field);
-       }
-       if (timestamp_field) {
-               bt_ctf_field_put(timestamp_field);
-       }
-       return ret;
-}
-
-BT_HIDDEN
-int bt_ctf_event_set_stream(struct bt_ctf_event *event,
-               struct bt_ctf_stream *stream)
-{
-       int ret = 0;
-
-       if (!event) {
-               ret = -1;
-               goto end;
-       }
-
-       if (event->stream && stream) {
-               /* Already attached to a stream */
-               ret = -1;
-               goto end;
-       }
-
-       event->stream = stream;
-end:
+       bt_put(id_field);
+       bt_put(timestamp_field);
        return ret;
 }
 
@@ -1244,10 +1302,8 @@ struct bt_ctf_event *bt_ctf_event_copy(struct bt_ctf_event *event)
                goto error;
        }
 
-       bt_ctf_ref_init(&copy->ref_count);
-       copy->event_class = event->event_class;
-       bt_ctf_event_class_get(copy->event_class);
-       copy->stream = event->stream;
+       bt_object_init(copy, bt_ctf_event_destroy);
+       copy->event_class = bt_get(event->event_class);
 
        if (event->event_header) {
                copy->event_header = bt_ctf_field_copy(event->event_header);
@@ -1277,24 +1333,6 @@ struct bt_ctf_event *bt_ctf_event_copy(struct bt_ctf_event *event)
        return copy;
 
 error:
-       if (copy) {
-               if (copy->event_class) {
-                       bt_ctf_event_class_put(copy->event_class);
-               }
-
-               if (copy->event_header) {
-                       bt_ctf_field_put(copy->event_header);
-               }
-
-               if (copy->context_payload) {
-                       bt_ctf_field_put(copy->context_payload);
-               }
-
-               if (copy->fields_payload) {
-                       bt_ctf_field_put(copy->fields_payload);
-               }
-       }
-
-       g_free(copy);
-       return NULL;
+       BT_PUT(copy);
+       return copy;
 }
This page took 0.036654 seconds and 4 git commands to generate.