9p: get rid of v9fs_direct_file_write()
[deliverable/linux.git] / fs / 9p / vfs_file.c
index b40133796b8734d32cf5376b12d1e01672af85db..1e4619693721b7d0401cd0f095e817261e12579e 100644 (file)
@@ -36,6 +36,7 @@
 #include <linux/utsname.h>
 #include <asm/uaccess.h>
 #include <linux/idr.h>
+#include <linux/uio.h>
 #include <net/9p/9p.h>
 #include <net/9p/client.h>
 
@@ -452,47 +453,6 @@ v9fs_file_read(struct file *filp, char __user *udata, size_t count,
        return ret;
 }
 
-ssize_t
-v9fs_file_write_internal(struct inode *inode, struct p9_fid *fid,
-                        const char __user *data, size_t count,
-                        loff_t *offset, int invalidate)
-{
-       int n;
-       loff_t i_size;
-       size_t total = 0;
-       loff_t origin = *offset;
-       unsigned long pg_start, pg_end;
-
-       p9_debug(P9_DEBUG_VFS, "data %p count %d offset %x\n",
-                data, (int)count, (int)*offset);
-
-       do {
-               n = p9_client_write(fid, NULL, data+total, origin+total, count);
-               if (n <= 0)
-                       break;
-               count -= n;
-               total += n;
-       } while (count > 0);
-
-       if (invalidate && (total > 0)) {
-               pg_start = origin >> PAGE_CACHE_SHIFT;
-               pg_end = (origin + total - 1) >> PAGE_CACHE_SHIFT;
-               if (inode->i_mapping && inode->i_mapping->nrpages)
-                       invalidate_inode_pages2_range(inode->i_mapping,
-                                                     pg_start, pg_end);
-               *offset += total;
-               i_size = i_size_read(inode);
-               if (*offset > i_size) {
-                       inode_add_bytes(inode, *offset - i_size);
-                       i_size_write(inode, *offset);
-               }
-       }
-       if (n < 0)
-               return n;
-
-       return total;
-}
-
 /**
  * v9fs_file_write - write to a file
  * @filp: file pointer to write
@@ -507,27 +467,44 @@ v9fs_file_write(struct file *filp, const char __user * data,
 {
        ssize_t retval = 0;
        loff_t origin = *offset;
+       struct iovec iov = {.iov_base = (void __user *)data, .iov_len = count};
+       struct iov_iter from;
+       int err = 0;
 
+       iov_iter_init(&from, WRITE, &iov, 1, count);
 
        retval = generic_write_checks(filp, &origin, &count, 0);
        if (retval)
-               goto out;
+               return retval;
+
+       iov_iter_truncate(&from, count);
+
+       p9_debug(P9_DEBUG_VFS, "data %p count %d offset %x\n",
+                data, (int)count, (int)*offset);
 
-       retval = -EINVAL;
-       if ((ssize_t) count < 0)
-               goto out;
        retval = 0;
        if (!count)
-               goto out;
+               return 0;
 
-       retval = v9fs_file_write_internal(file_inode(filp),
-                                       filp->private_data,
-                                       data, count, &origin, 1);
-       /* update offset on successful write */
-       if (retval > 0)
-               *offset = origin;
-out:
-       return retval;
+       retval = p9_client_write(filp->private_data, origin, &from, &err);
+       if (retval > 0) {
+               struct inode *inode = file_inode(filp);
+               loff_t i_size;
+               unsigned long pg_start, pg_end;
+               pg_start = origin >> PAGE_CACHE_SHIFT;
+               pg_end = (origin + retval - 1) >> PAGE_CACHE_SHIFT;
+               if (inode->i_mapping && inode->i_mapping->nrpages)
+                       invalidate_inode_pages2_range(inode->i_mapping,
+                                                     pg_start, pg_end);
+               *offset += retval;
+               i_size = i_size_read(inode);
+               if (*offset > i_size) {
+                       inode_add_bytes(inode, *offset - i_size);
+                       i_size_write(inode, *offset);
+               }
+               return retval;
+       }
+       return err;
 }
 
 
@@ -711,77 +688,6 @@ v9fs_mmap_file_read(struct file *filp, char __user *data, size_t count,
        return v9fs_file_read(filp, data, count, offset);
 }
 
-static ssize_t
-v9fs_direct_write(struct file *filp, const char __user * data,
-                 size_t count, loff_t *offsetp)
-{
-       loff_t offset;
-       ssize_t retval;
-       struct inode *inode;
-       struct address_space *mapping;
-
-       offset = *offsetp;
-       mapping = filp->f_mapping;
-       inode = mapping->host;
-       if (!count)
-               return 0;
-
-       mutex_lock(&inode->i_mutex);
-       retval = filemap_write_and_wait_range(mapping, offset,
-                                             offset + count - 1);
-       if (retval)
-               goto err_out;
-       /*
-        * After a write we want buffered reads to be sure to go to disk to get
-        * the new data.  We invalidate clean cached page from the region we're
-        * about to write.  We do this *before* the write so that if we fail
-        * here we fall back to buffered write
-        */
-       if (mapping->nrpages) {
-               pgoff_t pg_start = offset >> PAGE_CACHE_SHIFT;
-               pgoff_t pg_end   = (offset + count - 1) >> PAGE_CACHE_SHIFT;
-
-               retval = invalidate_inode_pages2_range(mapping,
-                                                       pg_start, pg_end);
-               /*
-                * If a page can not be invalidated, fall back
-                * to buffered write.
-                */
-               if (retval) {
-                       if (retval == -EBUSY)
-                               goto buff_write;
-                       goto err_out;
-               }
-       }
-       retval = v9fs_file_write(filp, data, count, offsetp);
-err_out:
-       mutex_unlock(&inode->i_mutex);
-       return retval;
-
-buff_write:
-       mutex_unlock(&inode->i_mutex);
-       return new_sync_write(filp, data, count, offsetp);
-}
-
-/**
- * v9fs_cached_file_write - write to a file
- * @filp: file pointer to write
- * @data: data buffer to write data from
- * @count: size of buffer
- * @offset: offset at which to write data
- *
- */
-static ssize_t
-v9fs_cached_file_write(struct file *filp, const char __user * data,
-                      size_t count, loff_t *offset)
-{
-
-       if (filp->f_flags & O_DIRECT)
-               return v9fs_direct_write(filp, data, count, offset);
-       return new_sync_write(filp, data, count, offset);
-}
-
-
 /**
  * v9fs_mmap_file_write - write to a file
  * @filp: file pointer to write
@@ -844,7 +750,7 @@ static const struct vm_operations_struct v9fs_mmap_file_vm_ops = {
 const struct file_operations v9fs_cached_file_operations = {
        .llseek = generic_file_llseek,
        .read = v9fs_cached_file_read,
-       .write = v9fs_cached_file_write,
+       .write = new_sync_write,
        .read_iter = generic_file_read_iter,
        .write_iter = generic_file_write_iter,
        .open = v9fs_file_open,
@@ -857,7 +763,7 @@ const struct file_operations v9fs_cached_file_operations = {
 const struct file_operations v9fs_cached_file_operations_dotl = {
        .llseek = generic_file_llseek,
        .read = v9fs_cached_file_read,
-       .write = v9fs_cached_file_write,
+       .write = new_sync_write,
        .read_iter = generic_file_read_iter,
        .write_iter = generic_file_write_iter,
        .open = v9fs_file_open,
This page took 0.02705 seconds and 5 git commands to generate.