Btrfs: Update on disk i_size only after pending ordered extents are done
[deliverable/linux.git] / fs / btrfs / file.c
index 8e210616d7021d36c9e59f526a2b89b3e5b09e53..3e4e5c227c0c33e72d93b0b9fdde24bb151870c7 100644 (file)
@@ -34,9 +34,9 @@
 #include "disk-io.h"
 #include "transaction.h"
 #include "btrfs_inode.h"
-#include "ordered-data.h"
 #include "ioctl.h"
 #include "print-tree.h"
+#include "compat.h"
 
 
 static int btrfs_copy_from_user(loff_t pos, int num_pages, int write_bytes,
@@ -175,6 +175,7 @@ static int noinline insert_inline_extent(struct btrfs_trans_handle *trans,
                        leaf = path->nodes[0];
                        ei = btrfs_item_ptr(leaf, path->slots[0],
                                            struct btrfs_file_extent_item);
+                       inode->i_blocks += (offset + size - found_end) >> 9;
                }
                if (found_end < offset) {
                        ptr = btrfs_file_extent_inline_start(ei) + found_size;
@@ -184,6 +185,7 @@ static int noinline insert_inline_extent(struct btrfs_trans_handle *trans,
 insert:
                btrfs_release_path(root, path);
                datasize = offset + size - key.offset;
+               inode->i_blocks += datasize >> 9;
                datasize = btrfs_file_extent_calc_inline_size(datasize);
                ret = btrfs_insert_empty_item(trans, root, path, &key,
                                              datasize);
@@ -249,14 +251,12 @@ static int noinline dirty_and_release_pages(struct btrfs_trans_handle *trans,
        end_of_last_block = start_pos + num_bytes - 1;
 
        lock_extent(io_tree, start_pos, end_of_last_block, GFP_NOFS);
-       mutex_lock(&root->fs_info->fs_mutex);
        trans = btrfs_start_transaction(root, 1);
        if (!trans) {
                err = -ENOMEM;
                goto out_unlock;
        }
        btrfs_set_trans_block_group(trans, inode);
-       inode->i_blocks += num_bytes >> 9;
        hint_byte = 0;
 
        if ((end_of_last_block & 4095) == 0) {
@@ -265,16 +265,16 @@ static int noinline dirty_and_release_pages(struct btrfs_trans_handle *trans,
        set_extent_uptodate(io_tree, start_pos, end_of_last_block, GFP_NOFS);
 
        /* FIXME...EIEIO, ENOSPC and more */
-
        /* insert any holes we need to create */
-       if (inode->i_size < start_pos) {
+       if (isize < start_pos) {
                u64 last_pos_in_file;
                u64 hole_size;
                u64 mask = root->sectorsize - 1;
                last_pos_in_file = (isize + mask) & ~mask;
-               hole_size = (end_pos - last_pos_in_file + mask) & ~mask;
-
-               if (last_pos_in_file < start_pos) {
+               hole_size = (start_pos - last_pos_in_file + mask) & ~mask;
+               if (hole_size > 0) {
+                       btrfs_wait_ordered_range(inode, last_pos_in_file,
+                                                last_pos_in_file + hole_size);
                        err = btrfs_drop_extents(trans, root, inode,
                                                 last_pos_in_file,
                                                 last_pos_in_file + hole_size,
@@ -286,7 +286,7 @@ static int noinline dirty_and_release_pages(struct btrfs_trans_handle *trans,
                        err = btrfs_insert_file_extent(trans, root,
                                                       inode->i_ino,
                                                       last_pos_in_file,
-                                                      0, 0, hole_size);
+                                                      0, 0, hole_size, 0);
                        btrfs_drop_extent_cache(inode, last_pos_in_file,
                                        last_pos_in_file + hole_size -1);
                        btrfs_check_file(root, inode);
@@ -301,29 +301,21 @@ static int noinline dirty_and_release_pages(struct btrfs_trans_handle *trans,
         */
        inline_size = end_pos;
        if (isize >= BTRFS_MAX_INLINE_DATA_SIZE(root) ||
-           inline_size > 8192 ||
+           inline_size > root->fs_info->max_inline ||
+           (inline_size & (root->sectorsize -1)) == 0 ||
            inline_size >= BTRFS_MAX_INLINE_DATA_SIZE(root)) {
-               u64 last_end;
-               u64 existing_delalloc = 0;
-
+               /* check for reserved extents on each page, we don't want
+                * to reset the delalloc bit on things that already have
+                * extents reserved.
+                */
+               set_extent_delalloc(io_tree, start_pos,
+                                   end_of_last_block, GFP_NOFS);
                for (i = 0; i < num_pages; i++) {
                        struct page *p = pages[i];
                        SetPageUptodate(p);
+                       ClearPageChecked(p);
                        set_page_dirty(p);
                }
-               last_end = (u64)(pages[num_pages -1]->index) <<
-                               PAGE_CACHE_SHIFT;
-               last_end += PAGE_CACHE_SIZE - 1;
-               if (start_pos < isize) {
-                       u64 delalloc_start = start_pos;
-                       existing_delalloc = count_range_bits(io_tree,
-                                            &delalloc_start,
-                                            end_of_last_block, (u64)-1,
-                                            EXTENT_DELALLOC);
-               }
-               set_extent_delalloc(io_tree, start_pos, end_of_last_block,
-                                GFP_NOFS);
-               btrfs_add_ordered_inode(inode);
        } else {
                u64 aligned_end;
                /* step one, delete the existing extents in this range */
@@ -346,9 +338,8 @@ static int noinline dirty_and_release_pages(struct btrfs_trans_handle *trans,
                btrfs_update_inode(trans, root, inode);
        }
 failed:
-       err = btrfs_end_transaction(trans, root);
+       err = btrfs_end_transaction_throttle(trans, root);
 out_unlock:
-       mutex_unlock(&root->fs_info->fs_mutex);
        unlock_extent(io_tree, start_pos, end_of_last_block, GFP_NOFS);
        return err;
 }
@@ -356,16 +347,65 @@ out_unlock:
 int btrfs_drop_extent_cache(struct inode *inode, u64 start, u64 end)
 {
        struct extent_map *em;
+       struct extent_map *split = NULL;
+       struct extent_map *split2 = NULL;
        struct extent_map_tree *em_tree = &BTRFS_I(inode)->extent_tree;
+       struct extent_map *tmp;
+       u64 len = end - start + 1;
+       u64 next_start;
+       int ret;
+       int testend = 1;
 
+       WARN_ON(end < start);
+       if (end == (u64)-1) {
+               len = (u64)-1;
+               testend = 0;
+       }
        while(1) {
+               if (!split)
+                       split = alloc_extent_map(GFP_NOFS);
+               if (!split2)
+                       split2 = alloc_extent_map(GFP_NOFS);
+
                spin_lock(&em_tree->lock);
-               em = lookup_extent_mapping(em_tree, start, end);
+               em = lookup_extent_mapping(em_tree, start, len);
                if (!em) {
                        spin_unlock(&em_tree->lock);
                        break;
                }
+               tmp = rb_entry(&em->rb_node, struct extent_map, rb_node);
+               next_start = tmp->start;
                remove_extent_mapping(em_tree, em);
+
+               if (em->block_start < EXTENT_MAP_LAST_BYTE &&
+                   em->start < start) {
+                       split->start = em->start;
+                       split->len = start - em->start;
+                       split->block_start = em->block_start;
+                       split->bdev = em->bdev;
+                       split->flags = em->flags;
+                       ret = add_extent_mapping(em_tree, split);
+                       BUG_ON(ret);
+                       free_extent_map(split);
+                       split = split2;
+                       split2 = NULL;
+               }
+               if (em->block_start < EXTENT_MAP_LAST_BYTE &&
+                   testend && em->start + em->len > start + len) {
+                       u64 diff = start + len - em->start;
+
+                       split->start = start + len;
+                       split->len = em->start + em->len - (start + len);
+                       split->bdev = em->bdev;
+                       split->flags = em->flags;
+
+                       split->block_start = em->block_start + diff;
+
+                       ret = add_extent_mapping(em_tree, split);
+                       BUG_ON(ret);
+                       free_extent_map(split);
+                       split = NULL;
+               }
                spin_unlock(&em_tree->lock);
 
                /* once for us */
@@ -373,6 +413,10 @@ int btrfs_drop_extent_cache(struct inode *inode, u64 start, u64 end)
                /* once for the tree*/
                free_extent_map(em);
        }
+       if (split)
+               free_extent_map(split);
+       if (split2)
+               free_extent_map(split2);
        return 0;
 }
 
@@ -411,7 +455,7 @@ int btrfs_check_file(struct btrfs_root *root, struct inode *inode)
                if (found_key.type != BTRFS_EXTENT_DATA_KEY)
                        goto out;
 
-               if (found_key.offset != last_offset) {
+               if (found_key.offset < last_offset) {
                        WARN_ON(1);
                        btrfs_print_leaf(root, leaf);
                        printk("inode %lu found offset %Lu expected %Lu\n",
@@ -436,7 +480,7 @@ int btrfs_check_file(struct btrfs_root *root, struct inode *inode)
                last_offset = extent_end;
                path->slots[0]++;
        }
-       if (last_offset < inode->i_size) {
+       if (0 && last_offset < inode->i_size) {
                WARN_ON(1);
                btrfs_print_leaf(root, leaf);
                printk("inode %lu found offset %Lu size %Lu\n", inode->i_ino,
@@ -508,11 +552,12 @@ next_slot:
                slot = path->slots[0];
                ret = 0;
                btrfs_item_key_to_cpu(leaf, &key, slot);
-
-               if (key.offset >= end || key.objectid != inode->i_ino) {
+               if (btrfs_key_type(&key) == BTRFS_EXTENT_DATA_KEY &&
+                   key.offset >= end) {
                        goto out;
                }
-               if (btrfs_key_type(&key) > BTRFS_EXTENT_DATA_KEY) {
+               if (btrfs_key_type(&key) > BTRFS_EXTENT_DATA_KEY ||
+                   key.objectid != inode->i_ino) {
                        goto out;
                }
                if (recow) {
@@ -590,8 +635,7 @@ next_slot:
                                }
                        }
                        bookend = 1;
-                       if (found_inline && start <= key.offset &&
-                           inline_limit < extent_end)
+                       if (found_inline && start <= key.offset)
                                keep = 1;
                }
                /* truncate existing extent */
@@ -609,8 +653,7 @@ next_slot:
                                                                      extent);
                                if (btrfs_file_extent_disk_bytenr(leaf,
                                                                  extent)) {
-                                       inode->i_blocks -=
-                                               (old_num - new_num) >> 9;
+                                       dec_i_blocks(inode, old_num - new_num);
                                }
                                btrfs_set_file_extent_num_bytes(leaf, extent,
                                                                new_num);
@@ -621,6 +664,8 @@ next_slot:
                                u32 new_size;
                                new_size = btrfs_file_extent_calc_inline_size(
                                                   inline_limit - key.offset);
+                               dec_i_blocks(inode, (extent_end - key.offset) -
+                                       (inline_limit - key.offset));
                                btrfs_truncate_item(trans, root, path,
                                                    new_size, 1);
                        }
@@ -654,7 +699,7 @@ next_slot:
                        btrfs_release_path(root, path);
                        extent = NULL;
                        if (found_extent && disk_bytenr != 0) {
-                               inode->i_blocks -= extent_num_bytes >> 9;
+                               dec_i_blocks(inode, extent_num_bytes);
                                ret = btrfs_free_extent(trans, root,
                                                disk_bytenr,
                                                disk_num_bytes,
@@ -671,11 +716,12 @@ next_slot:
                        if (!bookend)
                                continue;
                }
-               if (bookend && found_inline && start <= key.offset &&
-                   inline_limit < extent_end && key.offset <= inline_limit) {
+               if (bookend && found_inline && start <= key.offset) {
                        u32 new_size;
                        new_size = btrfs_file_extent_calc_inline_size(
-                                                  extent_end - inline_limit);
+                                                  extent_end - end);
+                       dec_i_blocks(inode, (extent_end - key.offset) -
+                                       (extent_end - end));
                        btrfs_truncate_item(trans, root, path, new_size, 0);
                }
                /* create bookend, splitting the extent in two */
@@ -720,6 +766,7 @@ next_slot:
        }
 out:
        btrfs_free_path(path);
+       btrfs_check_file(root, inode);
        return ret;
 }
 
@@ -736,23 +783,55 @@ static int prepare_pages(struct btrfs_root *root, struct file *file,
        struct inode *inode = fdentry(file)->d_inode;
        int err = 0;
        u64 start_pos;
+       u64 last_pos;
 
        start_pos = pos & ~((u64)root->sectorsize - 1);
+       last_pos = ((u64)index + num_pages) << PAGE_CACHE_SHIFT;
 
        memset(pages, 0, num_pages * sizeof(struct page *));
-
+again:
        for (i = 0; i < num_pages; i++) {
                pages[i] = grab_cache_page(inode->i_mapping, index + i);
                if (!pages[i]) {
                        err = -ENOMEM;
                        BUG_ON(1);
                }
+               wait_on_page_writeback(pages[i]);
+       }
+       if (start_pos < inode->i_size) {
+               struct btrfs_ordered_extent *ordered;
+               lock_extent(&BTRFS_I(inode)->io_tree,
+                           start_pos, last_pos - 1, GFP_NOFS);
+               ordered = btrfs_lookup_first_ordered_extent(inode, last_pos -1);
+               if (ordered &&
+                   ordered->file_offset + ordered->len > start_pos &&
+                   ordered->file_offset < last_pos) {
+                       btrfs_put_ordered_extent(ordered);
+                       unlock_extent(&BTRFS_I(inode)->io_tree,
+                                     start_pos, last_pos - 1, GFP_NOFS);
+                       for (i = 0; i < num_pages; i++) {
+                               unlock_page(pages[i]);
+                               page_cache_release(pages[i]);
+                       }
+                       btrfs_wait_ordered_range(inode, start_pos,
+                                                last_pos - start_pos);
+                       goto again;
+               }
+               if (ordered)
+                       btrfs_put_ordered_extent(ordered);
+
+               clear_extent_bits(&BTRFS_I(inode)->io_tree, start_pos,
+                                 last_pos - 1, EXTENT_DIRTY | EXTENT_DELALLOC,
+                                 GFP_NOFS);
+               unlock_extent(&BTRFS_I(inode)->io_tree,
+                             start_pos, last_pos - 1, GFP_NOFS);
+       }
+       for (i = 0; i < num_pages; i++) {
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18)
                ClearPageDirty(pages[i]);
 #else
                cancel_dirty_page(pages[i], PAGE_CACHE_SIZE);
 #endif
-               wait_on_page_writeback(pages[i]);
                set_page_extent_mapped(pages[i]);
                WARN_ON(!PageLocked(pages[i]));
        }
@@ -779,8 +858,6 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf,
                     PAGE_CACHE_SIZE / (sizeof(struct page *)));
        pinned[0] = NULL;
        pinned[1] = NULL;
-       if (file->f_flags & O_DIRECT)
-               return -EINVAL;
 
        pos = *ppos;
        start_pos = pos;
@@ -792,7 +869,11 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf,
                goto out_nolock;
        if (count == 0)
                goto out_nolock;
+#ifdef REMOVE_SUID_PATH
+       err = remove_suid(&file->f_path);
+#else
        err = remove_suid(fdentry(file));
+#endif
        if (err)
                goto out_nolock;
        file_update_time(file);
@@ -803,6 +884,14 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf,
        first_index = pos >> PAGE_CACHE_SHIFT;
        last_index = (pos + count) >> PAGE_CACHE_SHIFT;
 
+       /*
+        * if this is a nodatasum mount, force summing off for the inode
+        * all the time.  That way a later mount with summing on won't
+        * get confused
+        */
+       if (btrfs_test_opt(root, NODATASUM))
+               btrfs_set_flag(inode, NODATASUM);
+
        /*
         * there are lots of better ways to do this, but this code
         * makes sure the first and last page in the file range are
@@ -840,9 +929,7 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf,
                WARN_ON(num_pages > nrptrs);
                memset(pages, 0, sizeof(pages));
 
-               mutex_lock(&root->fs_info->fs_mutex);
                ret = btrfs_check_free_space(root, write_bytes, 0);
-               mutex_unlock(&root->fs_info->fs_mutex);
                if (ret)
                        goto out;
 
@@ -873,7 +960,6 @@ static ssize_t btrfs_file_write(struct file *file, const char __user *buf,
                balance_dirty_pages_ratelimited_nr(inode->i_mapping, num_pages);
                if (num_pages < (root->leafsize >> PAGE_CACHE_SHIFT) + 1)
                        btrfs_btree_balance_dirty(root, 1);
-               btrfs_throttle(root);
                cond_resched();
        }
 out:
@@ -892,11 +978,33 @@ out_nolock:
                                      start_pos, num_written);
                if (err < 0)
                        num_written = err;
+       } else if (num_written > 0 && (file->f_flags & O_DIRECT)) {
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,22)
+               do_sync_file_range(file, start_pos,
+                                     start_pos + num_written - 1,
+                                     SYNC_FILE_RANGE_WRITE |
+                                     SYNC_FILE_RANGE_WAIT_AFTER);
+#else
+               do_sync_mapping_range(inode->i_mapping, start_pos,
+                                     start_pos + num_written - 1,
+                                     SYNC_FILE_RANGE_WRITE |
+                                     SYNC_FILE_RANGE_WAIT_AFTER);
+#endif
+               invalidate_mapping_pages(inode->i_mapping,
+                     start_pos >> PAGE_CACHE_SHIFT,
+                    (start_pos + num_written - 1) >> PAGE_CACHE_SHIFT);
        }
        current->backing_dev_info = NULL;
        return num_written ? num_written : err;
 }
 
+int btrfs_release_file(struct inode * inode, struct file * filp)
+{
+       if (filp->private_data)
+               btrfs_ioctl_trans_end(filp);
+       return 0;
+}
+
 static int btrfs_sync_file(struct file *file,
                           struct dentry *dentry, int datasync)
 {
@@ -909,9 +1017,9 @@ static int btrfs_sync_file(struct file *file,
         * check the transaction that last modified this inode
         * and see if its already been committed
         */
-       mutex_lock(&root->fs_info->fs_mutex);
        if (!BTRFS_I(inode)->last_trans)
                goto out;
+
        mutex_lock(&root->fs_info->trans_mutex);
        if (BTRFS_I(inode)->last_trans <=
            root->fs_info->last_trans_committed) {
@@ -924,6 +1032,9 @@ static int btrfs_sync_file(struct file *file,
        /*
         * ok we haven't committed the transaction yet, lets do a commit
         */
+       if (file->private_data)
+               btrfs_ioctl_trans_end(file);
+
        trans = btrfs_start_transaction(root, 1);
        if (!trans) {
                ret = -ENOMEM;
@@ -931,7 +1042,6 @@ static int btrfs_sync_file(struct file *file,
        }
        ret = btrfs_commit_transaction(trans, root);
 out:
-       mutex_unlock(&root->fs_info->fs_mutex);
        return ret > 0 ? EIO : ret;
 }
 
@@ -963,6 +1073,7 @@ struct file_operations btrfs_file_operations = {
        .write          = btrfs_file_write,
        .mmap           = btrfs_file_mmap,
        .open           = generic_file_open,
+       .release        = btrfs_release_file,
        .fsync          = btrfs_sync_file,
        .unlocked_ioctl = btrfs_ioctl,
 #ifdef CONFIG_COMPAT
This page took 0.031953 seconds and 5 git commands to generate.