+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (tui_refill_source_window)
+ (tui_set_is_exec_point_at): Don't declare.
+ * tui/tui-winsource.c (tui_update_source_windows_with_addr)
+ (tui_source_window_base::refill): Rename from
+ tui_refill_source_window.
+ (tui_source_window_base::do_scroll_horizontal): Update.
+ (tui_source_window_base::set_is_exec_point_at): Rename from
+ tui_set_is_exec_point_at.
+ (tui_update_all_breakpoint_info): Update.
+ * tui/tui-stack.c (tui_show_frame_info): Update.
+ * tui/tui-layout.c (show_data): Add cast.
+ * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
+ * tui/tui-data.h (struct tui_source_window_base) <refill,
+ set_is_exec_point_at>: New methods.
+ (tui_source_windows, tui_add_to_source_windows): Update types.
+ (tui_add_to_source_windows): Remove redundant declaration.
+ * tui/tui-data.c (source_windows): Store tui_source_window_base.
+ (tui_source_windows): Change return type.
+ (tui_clear_source_windows_detail): Update.
+ (tui_add_to_source_windows): Change type of parameter.
+ (tui_free_all_source_wins_content): Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.c (tui_win_info::refresh)
+ (tui_source_window_base::refresh): New methods.
+ (tui_refresh_all): Call the refresh method.
+ * tui/tui-data.h (struct tui_win_info)
+ (struct tui_source_window_base) <refresh>: New method.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui.h (tui_is_window_visible): Return bool.
+ * tui/tui.c (tui_is_window_visible): Return bool.
+ * tui/tui-wingeneral.c (tui_make_window, make_visible)
+ (tui_make_visible, tui_make_invisible)
+ (tui_win_info::make_visible)
+ (tui_source_window_base::make_visible, make_all_visible)
+ (tui_make_all_visible, tui_make_all_invisible): Update.
+ * tui/tui-windata.c (tui_delete_data_content_windows): Update.
+ * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
+ bool.
+ (struct tui_win_info, struct tui_source_window_base)
+ (struct tui_cmd_window) <make_visible>: Change parameter to bool.
+ * tui/tui-data.c (tui_init_generic_part): Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.c (tui_win_info::make_visible)
+ (tui_source_window_base::make_visible): New methods.
+ (make_all_visible): Make method call.
+ * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
+ (struct tui_source_window_base, struct tui_cmd_window): Override
+ make_visible.
+ (tui_win_is_source_type): Don't declare.
+ * tui/tui-data.c (tui_win_is_source_type): Remove.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
+ NULL check.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
+ Inline constructor. Add initializers for members.
+ * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
+ constructors; now inline in class.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-regs.c (tui_show_registers): Update.
+ * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
+ bool.
+ * tui/tui-data.c (tui_data_window::clear_detail)
+ (tui_data_window): Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-windata.c (tui_display_all_data)
+ (tui_display_data_from_line, tui_display_data_from)
+ (tui_check_data_values, tui_data_window::do_scroll_vertical):
+ Update.
+ * tui/tui-regs.c (tui_last_regs_line_no)
+ (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
+ (tui_show_registers, tui_show_register_group)
+ (tui_display_registers_from, tui_display_reg_element_at_line)
+ (tui_display_registers_from_line, tui_check_register_values)
+ (tui_reg_next, tui_reg_prev): Update.
+ * tui/tui-layout.c (tui_set_layout, show_data): Update.
+ * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
+ tui_data_window.
+ (struct tui_win_info) <detail>: Remove. Add new fields from
+ tui_data_info.
+ (TUI_DATA_WIN): Add cast.
+ * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
+ (~tui_data_window): Simplify.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (show_source_disasm_command)
+ (show_source_or_disasm_and_command): Update.
+ * tui/tui-io.c (update_cmdwin_start_line)
+ (tui_redisplay_readline): Update.
+ * tui/tui-data.h (struct tui_command_info): Remove.
+ (struct tui_win_info) <detail>: Remove command_info member.
+ (struct tui_data_window) <start_line>: New member, from
+ tui_command_info.
+ (TUI_CMD_WIN): Add casts.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.c (tui_update_source_window)
+ (tui_refill_source_window)
+ (tui_source_window_base::do_scroll_horizontal)
+ (tui_update_breakpoint_info, tui_set_exec_info_content)
+ (tui_show_exec_info_content, tui_erase_exec_info_content)
+ (tui_clear_exec_info_content): Update.
+ * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
+ Update.
+ * tui/tui-win.c (make_invisible_and_set_new_height)
+ (make_visible_with_new_height): Update.
+ * tui/tui-source.c (tui_set_source_content)
+ (tui_show_symtab_source): Update.
+ * tui/tui-layout.c (extract_display_start_addr)
+ (show_source_disasm_command, show_data)
+ (make_source_or_disasm_window)
+ (show_source_or_disasm_and_command): Update.
+ * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
+ (tui_disasm_window::do_scroll_vertical): Remove shadowing
+ "gdbarch".
+ * tui/tui-data.h (struct tui_source_info): Remove. Move contents
+ to tui_source_window_base.
+ (struct tui_win_info) <detail>: Remove source_info member.
+ (struct tui_source_window_base) <has_locator>: Inline.
+ Move contents from tui_source_info; rename has_locator member to
+ m_has_locator.
+ (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
+ * tui/tui-data.c (tui_source_window_base::has_locator): Move to
+ header file.
+ (tui_source_window_base::clear_detail, ~tui_source_window_base):
+ Simplify.
+ (tui_free_all_source_wins_content): Cast to
+ tui_source_window_base.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (make_invisible_and_set_new_height)
+ (make_visible_with_new_height): Call has_locator method.
+ * tui/tui-layout.c (show_source_disasm_command, show_data)
+ (show_source_or_disasm_and_command): Update for bool change.
+ * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
+ (tui_win_info) <has_locator>: New method.
+ (struct tui_source_window_base) <has_locator>: New method.
+ (tui_win_has_locator): Don't declare.
+ * tui/tui-data.c (tui_source_window_base::has_locator): Rename
+ from tui_win_has_locator.
+ (tui_source_window_base): Use false, not FALSE.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (tui_clear_win_detail): Don't declare.
+ * tui/tui-data.c (tui_clear_source_windows_detail): Call the
+ clear_detail method directly.
+ (tui_clear_win_detail): Remove.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
+ "this", not TUI_DISASM_WIN.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
+ declare.
+ * tui/tui-winsource.c
+ (tui_source_window_base::do_scroll_horizontal): Rename from
+ tui_horizontal_source_scroll.
+ * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
+ * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
+ from tui_vertical_data_scroll.
+ * tui/tui-win.h (tui_scroll): Don't declare.
+ * tui/tui-win.c (tui_win_info::forward_scroll)
+ (tui_win_info::backward_scroll, tui_win_info::left_scroll)
+ (tui_win_info::right_scroll): Rename and update.
+ (tui_scroll_forward_command, tui_scroll_backward_command)
+ (tui_scroll_left_command, tui_scroll_right_command): Update.
+ (tui_scroll): Remove.
+ * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
+ * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
+ from tui_vertical_source_scroll.
+ * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
+ * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
+ from tui_vertical_disassem_scroll.
+ * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
+ do_scroll_horizontal>: New methods.
+ <forward_scroll, backward_scroll, left_scroll, right_scroll>:
+ Likewise.
+ (struct tui_source_window_base): Add do_scroll_horizontal.
+ (struct tui_source_window, struct tui_disasm_window): Add
+ do_scroll_vertical.
+ (struct tui_data_window, struct tui_cmd_window): Add
+ do_scroll_horizontal and do_scroll_vertical.
+ * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_source_window_base): New struct.
+ (struct tui_source_window): Derive from tui_source_window_base.
+ (struct tui_disasm_window): New struct.
+ * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
+ from tui_source_window::clear_detail.
+ (tui_source_window_base): Rename from tui_source_window.
+ (~tui_source_window_base): Rename from ~tui_source_window.
+ (tui_alloc_win_info): Create a tui_disasm_window.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_source_window)
+ (struct tui_data_window): Declare destructors.
+ * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
+ destructors.
+ (tui_win_info): Simplify.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.c (tui_display_main)
+ (tui_update_source_windows_with_addr)
+ (tui_update_all_breakpoint_info): Update.
+ * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
+ (new_height_ok, parse_scrolling_args): Update.
+ * tui/tui-stack.c (tui_show_frame_info): Update.
+ * tui/tui-data.h (struct tui_list): Remove.
+ (tui_source_windows): Return a reference to a std::vector.
+ * tui/tui-data.c (source_windows): Now a std::vector.
+ (tui_source_windows): Change return type.
+ (tui_clear_source_windows): Rewrite.
+ (tui_clear_source_windows_detail, tui_add_to_source_windows)
+ (tui_free_all_source_wins_content): Rewrite.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
+ (struct tui_data_window, struct tui_cmd_window): Declare
+ clear_detail method.
+ * tui/tui-data.c (tui_source_window::clear_detail)
+ (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
+ methods.
+ (tui_clear_win_detail): Simplify.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (make_source_window, make_disasm_window)
+ (make_source_or_disasm_window): Remove win_info_ptr parameter.
+ Return the new window.
+ (show_source_disasm_command, show_data)
+ (show_source_or_disasm_and_command): Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (make_command_window): Remove win_info_ptr
+ parameter. Return the new window.
+ (show_source_disasm_command): Update and remove NULL check.
+ (show_source_or_disasm_and_command): Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-layout.c (init_and_make_win): Remove NULL check.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_win_info): Make constructor
+ protected. Make destructor virtual. Add initializers.
+ (tui_source_window, tui_data_window, tui_cmd_window): New
+ classes.
+ * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
+ constructor. Add "type" parameter.
+ (tui_source_window, tui_data_window, tui_cmd_window): New
+ constructors.
+ (tui_alloc_win_info): Instantiate the appropriate subclass.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-win.c (tui_resize_all): Use delete.
+ * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
+ destructor.
+ (tui_free_window): Don't declare.
+ * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
+ Update.
+
+2019-06-25 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (struct tui_win_info): Add constructor.
+ * tui/tui-data.c (tui_alloc_win_info): Use new.
+ (tui_free_window): Use delete.
+
+2019-06-22 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
+ declare.
+ * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
+
+2019-06-22 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
+ declare.
+ * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
+
+2019-06-22 Tom de Vries <tdevries@suse.de>
+
+ * dwarf2read.c (create_addrmap_from_aranges)
+ (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
+ instead of '%zu'.
+
+2019-06-21 Simon Marchi <simon.marchi@efficios.com>
+
+ * dwarf2read.h (dwarf2_section_info_def): Remove.
+ (DEF_VEC_O (dwarf2_section_info_def)): Remove.
+ * dwarf2read.c (struct dwo_sections) <types>: Change type to
+ std::vector<dwarf2_section_info>.
+ (struct dwo_file) <~dwo_file>: Remove.
+ (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
+ types field.
+ (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
+ (dwarf2_read_debug_names): Likewise.
+ (create_debug_types_hash_table): Change parameter type to
+ array_view, adjust code accordingly.
+ (dwarf2_locate_dwo_sections): Adjust to std::vector.
+ (partial_die_info::fixup): Likewise.
+ (determine_prefix): Likewise.
+ * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
+
+2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
+ gdb_bfd_ref_ptr.
+ <~dwo_file>: Remove call to gdb_bfd_unref.
+ (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
+ gdb_bfd_ref_ptr::get.
+
+2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
+ type to htab_up.
+ * dwarf2read.c (struct dwo_file): Initialize fields.
+ <~dwo_file>: New.
+ (free_dwo_file): Remove, move content to ~dwo_file.
+ (struct dwo_file_deleter): Remove.
+ (dwo_file_up>: Remove custom deleter.
+ (free_dwo_files): Remove.
+ (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
+ dwo_files.
+ (process_skeletonless_type_units): Call unique_ptr::get.
+ (allocate_dwo_file_hash_table): Add deleter to created hash
+ table. Change return type to htab_up.
+ (lookup_dwo_file_slot): Don't memset dwo_file, call
+ unique_ptr::get.
+ (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
+ (create_dwo_unit_in_dwp_v2): Likewise.
+ (open_and_init_dwo_file): Likewise.
+ (free_dwo_file_from_slot): Remove.
+
+2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
+
+ * dwarf2read.h (struct dwarf2_section_info) <readin,
+ is_virtual>: Change type to bool.
+ * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
+ true instead of 1.
+
+2019-06-19 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (tui_init_content_element): Don't declare.
+
+2019-06-19 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.h (tui_init_win_info): Don't declare.
+
+2019-06-19 Tom de Vries <tdevries@suse.de>
+
+ * dwarf2read.h (abstract_to_concrete): Change type to
+ std::unordered_map<sect_offset, std::vector<sect_offset>,
+ gdb::hash_enum<sect_offset>>.
+
+2019-06-19 Tom Tromey <tromey@adacore.com>
+
+ * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
+ EVAL_AVOID_SIDE_EFFECTS specially.
+
+2019-06-19 Tom Tromey <tromey@adacore.com>
+
+ * source-cache.c (highlighter): New global.
+ (source_cache::get_source_lines): Create a highlighter on demand.
+
+2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * defs.h (deprecated_interactive_hook): Delete declaration.
+ * interps.c (clear_interpreter_hooks): Remove use of
+ deprecated_interactive_hook.
+ * top.c (deprecated_interactive_hook): Delete definition.
+ * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
+
+2019-06-18 Tom de Vries <tdevries@suse.de>
+
+ PR gdb/24515
+ * dwarf2read.h (abstract_to_concrete): Change type from
+ std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
+ std::unordered_map<sect_offset, std::vector<sect_offset>>.
+ * dwarf2read.c (read_variable): Update.
+ (dwarf2_fetch_die_loc_sect_off): Update.
+
+2019-06-17 Tom de Vries <tdevries@suse.de>
+
+ PR gdb/24617
+ * common/pathstuff.c (child_path): Make sure parent_len > 0 before
+ accessing parent[parent_len - 1].
+
+2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
+
+ PR gdb/24364
+ * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
+ call dtrace_process_dof with NULL dof.
+
+2019-06-16 Tom de Vries <tdevries@suse.de>
+
+ PR gdb/24445
+ * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
+
+2019-06-16 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
+ (make_all_visible): Use address of member.
+
+2019-06-16 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.c (tui_clear_win_detail, init_win_info)
+ (tui_free_window, free_content, free_content_elements): Remove
+ unnecessary cast.
+ * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
+ cast.
+ * tui/tui-regs.c (tui_show_register_group)
+ (tui_display_registers_from, tui_display_reg_element_at_line):
+ Remove unnecessary cast.
+
+2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * linux-nat.c (normal_mask): Delete.
+ (_initialize_linux_nat): Don't initialise normal_mask.
+
+2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
+
+ PR gdb/24445
+ * dwarf-index-write.h (write_psymtabs_to_index): Add
+ dwz_basename parameter.
+ * dwarf-index-write.c (write_gdbindex): Move file writing to
+ write_gdbindex_1. Change return type void.
+ (assert_file_size): Move up, remove filename parameter.
+ (write_gdbindex_1): New function.
+ (write_debug_names): Change return type to void, call
+ assert_file_size.
+ (struct index_wip_file): New struct.
+ (write_psymtabs_to_index): Add dwz_basename parameter. Move
+ file logic to index_wip_file. Write index for dwz file if
+ needed.
+ (save_gdb_index_command): Pass basename of dwz file, if present.
+ * dwarf-index-cache.c (index_cache::store): Obtain and pass
+ build-id of dwz file, if present.
+ * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
+ (dwarf2_get_dwz_file): Likewise.
+ * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
+ (dwarf2_get_dwz_file): Likewise.
+
+2019-06-16 Tom Tromey <tom@tromey.com>
+
+ * coffread.c (process_coff_symbol): Use xstrdup.
+ * value.c (create_internalvar): Use xstrdup.
+
+2019-06-16 Tom Tromey <tom@tromey.com>
+
+ * valops.c (value_cast, value_slice): Remove unnecessary cast.
+ * breakpoint.c (stopin_command, stopat_command)
+ (until_break_command, decode_location_default): Remove unnecessary
+ cast.
+ * utils.c (subset_compare): Remove unnecessary cast.
+ * ada-lang.c (ada_update_initial_language): Remove unnecessary
+ cast.
+ * linespec.c (decode_line_with_last_displayed): Remove unnecessary
+ cast.
+ * infcmd.c (path_command): Remove unnecessary cast.
+ * coffread.c (decode_type): Remove unnecessary cast.
+ * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
+ * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
+ * tui/tui-stack.c (tui_show_locator_content)
+ (tui_show_frame_info): Remove unnecessary cast.
+ * tui/tui-win.c (tui_scroll_forward_command)
+ (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
+ (parse_scrolling_args): Remove unnecessary cast.
+ * tui/tui-data.c (init_win_info, tui_del_window)
+ (tui_free_window, tui_del_data_windows, tui_free_data_content)
+ (free_content_elements): Remove unnecessary cast.
+ * tui/tui-windata.c (tui_first_data_item_displayed): Remove
+ unnecessary cast.
+ * tui/tui-source.c (tui_set_source_content)
+ (tui_vertical_source_scroll): Remove unnecessary cast.
+ * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
+ cast.
+ * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
+ * tui/tui-regs.c (tui_display_registers_from)
+ (tui_display_register): Remove unnecessary cast.
+ * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
+ (tui_unhighlight_win, tui_highlight_win, tui_make_window)
+ (make_visible): Remove unnecessary cast.
+ * tui/tui-winsource.c (tui_erase_source_content)
+ (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
+ unnecessary cast.
+ * ax-gdb.c (agent_command_1): Remove unnecessary cast.
+ * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
+ * stabsread.c (read_type, read_array_type, read_range_type):
+ Remove unnecessary cast.
+ * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
+ (parse_symbol, parse_type, upgrade_type, parse_external)
+ (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
+ unnecessary cast.
+ * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
+
+2019-06-16 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-data.c (tui_alloc_generic_win_info)
+ (tui_alloc_win_info, tui_add_content_elements): Remove NULL
+ checks.
+
+2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
+ Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * f-typeprint.c (f_print_type): Don't return early for not
+ associated or not allocated types.
+ (f_type_print_varspec_suffix): Add print_rank parameter and print
+ ranks of array types in case they dangling.
+ (f_type_print_base): Add print_rank parameter.
+
+2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * NEWS: Mention new MI commands.
+ * break-catch-throw.c (enum exception_event_kind): Move to
+ breakpoint.h.
+ (print_mention_exception_catchpoint): Output text as a single
+ message.
+ (catch_exception_command_1): Rename to...
+ (catch_exception_event): ...this, make non-static, update header
+ command, and change some parameter types.
+ (catch_catch_command): Update for changes to
+ catch_exception_command_1.
+ (catch_throw_command): Likewise.
+ (catch_rethrow_command): Likewise.
+ * breakpoint.c (enum exception_event_kind): Delete.
+ * breakpoint.h (enum exception_event_kind): Moved here from
+ break-catch-throw.c.
+ (catch_exception_event): Declare.
+ * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
+ (mi_cmd_catch_throw): New function.
+ (mi_cmd_catch_rethrow): New function.
+ (mi_cmd_catch_catch): New function.
+ * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
+ 'catch-catch' entries.
+ * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
+ (mi_cmd_catch_rethrow): Declare.
+ (mi_cmd_catch_catch): Declare.
+
+2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * annotate.c (annotate_source_line): Change return type to void,
+ update implementation to match.
+ * annotate.h (annotate_source_line): Change return type to void,
+ update header comment.
+ * stack.c (print_frame_info): Don't change what frame information
+ is printed based on whether annotations are on or not.
+
+2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * annotate.c: Add 'source.h' and 'objfiles.h' includes.
+ (annotate_source): Make static.
+ (annotate_source_line): Moved from source.c and renamed from
+ identify_source_line. Update the return type.
+ * annotate.h (annotate_source): Delete declaration.
+ (annotate_source_line): Declaration moved from source.h, and
+ renamed from identify_source_line. Return type updated.
+ * source.c (identify_source_line): Moved to annotate.c and renamed
+ to annotate_source_line.
+ (info_line_command): Remove check of annotation_level.
+ * source.h (identify_source_line): Move declaration to annotate.h
+ and rename to annotate_source_line.
+ * stack.c: Add 'annotate.h' include.
+ (print_frame_info): Remove check of annotation_level before
+ calling annotate_source_line.
+
+2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * source-cache.c (source_cache::get_plain_source_lines): Use
+ open_source_file_with_line_charpos instead of just
+ open_source_file, remove call to find_source_lines.
+ (source_cache::get_source_lines): Likewise.
+ * source.c (find_source_lines): Make static.
+ (get_filename_and_charpos): Renamed into...
+ (open_source_file_with_line_charpos): ..this along with changes to
+ return a scoped_fd, and some other minor clean ups.
+ (identify_source_line): Use open_source_file_with_line_charpos.
+ (search_command_helper): Use open_source_file_with_line_charpos
+ instead of just open_source_file, remove call to
+ find_source_lines.
+ * source.h (open_source_file_with_line_charpos): Declare new
+ function.
+ (find_source_lines): Delete declaration.
+
+2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * source.c (get_filename_and_charpos): Remove fullname
+ parameter.
+ (identify_source_line): Update call to get_filename_and_charpos.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ PR gdb/24502:
+ * ui-style.h (skip_ansi_escape): Update comment.
+ * ui-file.h (class no_terminal_escape_file): New class.
+ * ui-file.c (no_terminal_escape_file::write)
+ (no_terminal_escape_file::puts): New methods.
+ * cli/cli-logging.c (handle_redirections): Use
+ no_terminal_escape_file.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ * NEWS: Move convenience variable news above Python news.
+
+2019-06-14 Tom Tromey <tom@tromey.com>
+
+ * gnulib: Move directory to top-level.
+ * configure.ac: Don't configure gnulib.
+ * configure: Rebuild.
+ * common/common-defs.h: Use new path to gnulib.
+ * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
+ (GNULIB_H): Remove.
+ (INCGNU): Look in new gnulib location.
+ (HFILES_NO_SRCDIR): Remove gnulib files.
+ (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
+ (generated_files): Remove GNULIB_H.
+ ($(LIBGNU), all-lib): Remove targets.
+ (distclean): Don't mention GNULIB_BUILDDIR.
+ ($(GNULIB_BUILDDIR)/Makefile): Remove target.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ * symfile.c (add_symbol_file_command): Remove obsolete comment.
+ Warn if symbol file does not provide any symbols.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ * source.c (find_and_open_source): Respect basenames_may_differ.
+
+2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * annotate.c (annotate_breakpoints_invalid): Make use of
+ scoped_restore_terminal_state.
+ (annotate_frames_invalid): Likewise.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
+ allow assignment to an internalvar.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ * ada-lex.l: Allow "_" in attribute names.
+
+2019-06-14 Tom Tromey <tromey@adacore.com>
+
+ PR gdb/24653:
+ * regcache.c (registers_changed): Don't call alloca.
+ * top.c (execute_command): Don't call alloca.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
+ 'expression'. When parsing an expression, error out if there's
+ junk after "unlimited".
+ (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
+ (do_set_command): Adjust calls to is_unlimited_literal.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * compile/compile.c (make_compile_options_def_group): Add braces
+ around array_view initializer.
+ * thread.c (make_thread_apply_all_options_def_group)
+ (make_thread_apply_all_options_def_group): Likewise.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * NEWS (New commands): Mention "maint test-options
+ require-delimiter", "maint test-options unknown-is-error", "maint
+ test-options unknown-is-operand" and "maint show
+ test-options-completion-result".
+ (New command options, command completion): New section.
+ (Completion improvements): New section.
+ Mention that you can abbreviate "unlimited".
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
+ * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
+ * unittests/cli-utils-selftests.c (test_parse_flags)
+ (test_parse_flags_qcs): Delete.
+ (test_cli_utils): Don't call deleted functions.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * thread.c: Include "cli/cli-option.h".
+ (tp_array_compar_ascending): Global.
+ (tp_array_compar): Delete function.
+ (tp_array_compar_ascending, tp_array_compar_descending): New
+ functions.
+ (ascending_option_def, qcs_flag_option_def)
+ (thr_qcs_flags_option_defs)
+ (make_thread_apply_all_options_def_group)
+ (make_thread_apply_options_def_group): New.
+ (thread_apply_all_command): Use gdb::option::process_options.
+ (thread_apply_command_completer)
+ (thread_apply_all_command_completer): New.
+ (thread_apply_command): Use gdb::option::process_options.
+ (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
+ with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
+ to generate help text of "thread apply". Adjust "taas"'s help.
+ * tid-parse.c (tid_range_parser::in_thread_range): New method.
+ * tid-parse.h (tid_range_parser::in_thread_range): New method.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * thread.c (thread_apply_command): Check for invalid TID with
+ isdigit instead of !isalpha.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
+ (validate_flags_qcs): New.
+ * cli/cli-utils.h (struct qcs_flags): Change field types to int.
+ (validate_flags_qcs): Declare.
+ * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
+ (make_frame_apply_options_def_group): New.
+ (frame_apply_command_count): Process options with
+ gdb::option::process_options.
+ (frame_apply_completer): New.
+ (frame_apply_level_completer, frame_apply_all_completer)
+ (frame_apply_completer): New.
+ (_initialize_stack): Update help of "frame apply", "frame apply
+ level", "frame apply all" and "faas" to mention supported options
+ and install command completers.
+ * stack.h (frame_apply_all_completer): Declare.
+ * thread.c: Include "stack.h".
+ (tfaas_command): Add "--".
+ (_initialize_thread): Update help "tfaas" to mention supported
+ options and install command completer.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * completer.c (complete_nested_command_line): New.
+ (gdb_completion_word_break_characters_throw): Add assertion.
+ * completer.h (complete_nested_command_line): Declare.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * stack.c (parse_backtrace_qualifiers): New.
+ (backtrace_command): Use it.
+ (backtrace_command_completer): Complete on qualifiers.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * frame.c: Include "cli/cli-option.h.
+ (user_set_backtrace_options): New.
+ (backtrace_past_main, backtrace_past_entry, backtrace_limit):
+ Delete.
+ (get_prev_frame): Adjust.
+ (boolean_option_def, uinteger_option_def)
+ (set_backtrace_option_defs): New.
+ (_initialize_frame): Adjust and use
+ gdb::option::add_setshow_cmds_for_options to install "set
+ backtrace past-main" and "set backtrace past-entry".
+ * frame.h: Include "cli/cli-option.h".
+ (struct frame_print_options): Forward declare.
+ (print_frame_arguments_all, print_frame_arguments_scalars)
+ (print_frame_arguments_none): Declare.
+ (print_entry_values): Delete declaration.
+ (struct frame_print_options, user_frame_print_options): New.
+ (struct set_backtrace_options): New.
+ (set_backtrace_option_defs, user_set_backtrace_options): Declare.
+ * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
+ (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
+ (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
+ (list_args_or_locals): Add frame_print_options parameter.
+ (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
+ * python/py-framefilter.c (enumerate_args): Pass down
+ USER_FRAME_PRINT_OPTIONS.
+ * stack.c: Include "cli/cli-option.h".
+ (print_frame_arguments_all, print_frame_arguments_scalars)
+ (print_frame_arguments_none): Declare.
+ (print_raw_frame_arguments, print_entry_values): Delete.
+ (user_frame_print_options): New.
+ (boolean_option_def, enum_option_def, frame_print_option_defs):
+ New.
+ (struct backtrace_cmd_options): New.
+ (bt_flag_option_def): New.
+ (backtrace_command_option_defs): New.
+ (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
+ (print_frame_arg, read_frame_arg, print_frame_args)
+ (print_frame_info, print_frame): Add frame_print_options parameter
+ and use it.
+ (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
+ (backtrace_command_1): Add frame_print_options and
+ backtrace_cmd_options parameters and use them.
+ (make_backtrace_options_def_group): New.
+ (backtrace_command): Process command options with
+ gdb::option::process_options.
+ (backtrace_command_completer): New.
+ (_initialize_stack): Extend "backtrace"'s help to mention
+ supported options. Install completer for "backtrace".
+ Install some settings commands with add_setshow_cmds_for_options.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
+ and that "set/show print raw frame-arguments" are now deprecated.
+
+ * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
+ command.
+ * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
+ * stack.c (_initialize_stack): Install "set/show print
+ raw-frame-arguments", and deprecate "set/show print raw
+ frame-arguments".
+ * valprint.c (_initialize_valprint): Deprecate "set/show print
+ raw".
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * compile/compile.c (struct compile_options): New.
+ (compile_flag_option_def, compile_command_option_defs)
+ (make_compile_options_def_group): New.
+ (compile_file_command): Handle options with
+ gdb::option::process_options.
+ (compile_file_command_completer): New function.
+ (compile_code_command): Handle options with
+ gdb::option::process_options.
+ (compile_code_command_completer): New function.
+ (_initialize_compiler): Install completers for "compile code" and
+ "compile file". Mention available options in "compile code" and
+ "compile code"'s help.
+ * completer.c (advance_to_completion_word): New, factored out from
+ ...
+ (advance_to_expression_complete_word_point): ... this.
+ (advance_to_filename_complete_word_point): New.
+ * completer.h (advance_to_filename_complete_word_point): New
+ declaration.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * compile/compile.c: Include "cli/cli-option.h".
+ (compile_print_value): Scope data pointer is now a
+ value_print_options pointer; adjust.
+ (compile_print_command): Process options. Scope data pointer is
+ now a value_print_options pointer; adjust.
+ (_initialize_compile): Update "compile print"'s help to include
+ supported options. Install a completer for "compile print".
+ * cp-valprint.c (show_vtblprint, show_objectprint)
+ (show_static_field_print): Delete.
+ (_initialize_cp_valprint): Don't install "set print
+ static-members", "set print vtbl", "set print object" here.
+ * printcmd.c: Include "cli/cli-option.h" and
+ "common/gdb_optional.h".
+ (print_command_parse_format): Rework to fill in a
+ value_print_options instead of a format_data.
+ (print_value): Change parameter type from format_data pointer to
+ value_print_options reference. Adjust.
+ (print_command_1): Process options. Adjust to pass down a
+ value_print_options.
+ (print_command_completer): New.
+ (_initialize_printcmd): Install print_command_completer as
+ handle_brkchars completer for the "print" command. Update
+ "print"'s help to include supported options.
+ * valprint.c: Include "cli/cli-option.h".
+ (show_vtblprint, show_objectprint, show_static_field_print): Moved
+ here from cp-valprint.c.
+ (boolean_option_def, uinteger_option_def)
+ (value_print_option_defs, make_value_print_options_def_group):
+ New. Use gdb::option::add_setshow_cmds_for_options to install
+ "set print elements", "set print null-stop", "set print repeats",
+ "set print pretty", "set print union", "set print array", "set
+ print address", "set print symbol", "set print array-indexes".
+ * valprint.h: Include <string> and "cli/cli-option.h".
+ (make_value_print_options_def_group): Declare.
+ (print_value): Change parameter type from format_data pointer to
+ value_print_options reference.
+ (print_command_completer): Declare.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
+ (COMMON_SFILES): Add maint-test-settings.c.
+ * cli/cli-decode.c (boolean_enums): New global, factored out from
+ ...
+ (add_setshow_boolean_cmd): ... here.
+ * cli/cli-decode.h (boolean_enums): Declare.
+ * cli/cli-option.c: New file.
+ * cli/cli-option.h: New file.
+ * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
+ factored out from ...
+ (parse_cli_boolean_value(const char *)): ... this.
+ (is_unlimited_literal): Change parameter type to pointer to
+ pointer. Adjust and advance ARG pointer.
+ (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
+ (parse_cli_var_enum): New, factored out from ...
+ (do_set_command): ... this. Adjust.
+ * cli/cli-setshow.h (parse_cli_boolean_value)
+ (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
+ (parse_cli_var_enum): Declare.
+ * cli/cli-utils.c: Include "cli/cli-option.h".
+ (get_ulongest): New.
+ * cli/cli-utils.h (get_ulongest): Declare.
+ (check_for_argument): New overloads.
+ * maint-test-options.c: New file.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-utils.c (number_or_range_parser::get_number): Do not
+ parse a range if "-" is at the end of the string.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-setshow.c (parse_auto_binary_operation)
+ (parse_cli_boolean_value): Don't allow "o".
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
+ * NEWS: Mention maint test-settings KIND.
+ * maint-test-settings.c: New file.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
+ completer.
+ (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
+ "set" completers.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
+ after item.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * ax-gdb.c (agent_command_1): Remove skip_spaces call.
+ * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
+ call.
+ * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
+ * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
+ calls.
+ (check_for_argument): Skip spaces after argument.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * thread.c (thread_apply_command): Adjust TID parsing.
+ * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
+ detected before end of string.
+ (tid_is_in_list): Error out if LIST is invalid.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * completer.c (complete_line_internal_1): Rewind completion word
+ point.
+ (completion_tracker::advance_custom_word_point_by): Change
+ parameter type to int.
+ * completer.h (completion_tracker::advance_custom_word_point_by):
+ Likewise.
+
+2019-06-13 Pedro Alves <palves@redhat.com>
+
+ * completer.c (advance_to_completion_word): Handle delimiters.
+
2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
* dwarf2read.c (add_partial_symbol): Skip nameless modules.
2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
- * MAINTAINERS (Write After Approval): Add myself.
+ * MAINTAINERS (Write After Approval): Add myself.
2019-05-17 Tom de Vries <tdevries@suse.de>
2019-03-26 Alan Hayward <alan.hayward@arm.com>
- * ppc-linux-nat.c: Add include.
+ * ppc-linux-nat.c: Add include.
2019-03-26 Alan Hayward <alan.hayward@arm.com>
- * NEWS: Mention AArch64 Pointer Authentication.
+ * NEWS: Mention AArch64 Pointer Authentication.
2019-03-26 Alan Hayward <alan.hayward@arm.com>
- * arm-linux-nat.c: Add include.
+ * arm-linux-nat.c: Add include.
2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>