2009-11-17 Daniel Jacobowitz <dan@codesourcery.com>

[deliverable/binutils-gdb.git] / gdb / bfd-target.c

diff --git a/gdb/bfd-target.c b/gdb/bfd-target.c
index 2b7894e28e19db96488fe4aa8356102ab44a1de8..0e553d25893fe4b881837d1c50b7e869094bc1e9 100644 (file)
--- a/gdb/bfd-target.c
+++ b/gdb/bfd-target.c
@@ -22,6 +22,19 @@
 #include "bfd-target.h"
 #include "exec.h"
 
+/* The object that is stored in the target_ops->to_data field has this
+   type.  */
+struct target_bfd_data
+{
+  /* The BFD we're wrapping.  */
+  struct bfd *bfd;
+
+  /* The section table build from the ALLOC sections in BFD.  Note
+     that we can't rely on extracting the BFD from a random section in
+     the table, since the table can be legitimately empty.  */
+  struct target_section_table table;
+};
+
 static LONGEST
 target_bfd_xfer_partial (struct target_ops *ops,
                         enum target_object object,
@@ -33,10 +46,11 @@ target_bfd_xfer_partial (struct target_ops *ops,
     {
     case TARGET_OBJECT_MEMORY:
       {
-       struct target_section_table *table = ops->to_data;
-       return section_table_xfer_memory_partial (readbuf, writebuf, offset, len,
-                                                 table->sections,
-                                                 table->sections_end,
+       struct target_bfd_data *data = ops->to_data;
+       return section_table_xfer_memory_partial (readbuf, writebuf,
+                                                 offset, len,
+                                                 data->table.sections,
+                                                 data->table.sections_end,
                                                  NULL);
       }
     default:
@@ -47,20 +61,18 @@ target_bfd_xfer_partial (struct target_ops *ops,
 static struct target_section_table *
 target_bfd_get_section_table (struct target_ops *ops)
 {
-  return ops->to_data;
+  struct target_bfd_data *data = ops->to_data;
+  return &data->table;
 }
 
 static void
 target_bfd_xclose (struct target_ops *t, int quitting)
 {
-  struct target_section_table *table = t->to_data;
-
-  /* If the target sections table is empty, the bfd had already been
-     closed.  */
-  if (table->sections != table->sections_end)
-    bfd_close (table->sections->bfd);
-  xfree (table->sections);
-  xfree (table);
+  struct target_bfd_data *data = t->to_data;
+
+  bfd_close (data->bfd);
+  xfree (data->table.sections);
+  xfree (data);
   xfree (t);
 }
 
@@ -68,16 +80,11 @@ struct target_ops *
 target_bfd_reopen (struct bfd *bfd)
 {
   struct target_ops *t;
-  struct target_section_table *table;
-
-  table = XZALLOC (struct target_section_table);
-  build_section_table (bfd, &table->sections, &table->sections_end);
+  struct target_bfd_data *data;
 
-  /* No use keeping the bfd open if there are no target sections we
-     care about.  This way, we avoid keeping the bfd pointer stored
-     somewhere so that target_bfd_xclose could use it.  */
-  if (table->sections == table->sections_end)
-    bfd_close (bfd);
+  data = XZALLOC (struct target_bfd_data);
+  data->bfd = bfd;
+  build_section_table (bfd, &data->table.sections, &data->table.sections_end);
 
   t = XZALLOC (struct target_ops);
   t->to_shortname = "bfd";
@@ -86,7 +93,7 @@ target_bfd_reopen (struct bfd *bfd)
   t->to_get_section_table = target_bfd_get_section_table;
   t->to_xfer_partial = target_bfd_xfer_partial;
   t->to_xclose = target_bfd_xclose;
-  t->to_data = table;
+  t->to_data = data;
 
   return t;
 }