/* Very simple "bfd" target, for GDB, the GNU debugger.
- Copyright (C) 2003, 2005, 2007, 2008, 2009 Free Software Foundation, Inc.
+ Copyright (C) 2003-2013 Free Software Foundation, Inc.
This file is part of GDB.
#include "target.h"
#include "bfd-target.h"
#include "exec.h"
+#include "gdb_bfd.h"
+
+/* The object that is stored in the target_ops->to_data field has this
+ type. */
+struct target_bfd_data
+{
+ /* The BFD we're wrapping. */
+ struct bfd *bfd;
+
+ /* The section table build from the ALLOC sections in BFD. Note
+ that we can't rely on extracting the BFD from a random section in
+ the table, since the table can be legitimately empty. */
+ struct target_section_table table;
+};
static LONGEST
target_bfd_xfer_partial (struct target_ops *ops,
{
case TARGET_OBJECT_MEMORY:
{
- struct target_section_table *table = ops->to_data;
- return section_table_xfer_memory_partial (readbuf, writebuf, offset, len,
- table->sections,
- table->sections_end,
+ struct target_bfd_data *data = ops->to_data;
+ return section_table_xfer_memory_partial (readbuf, writebuf,
+ offset, len,
+ data->table.sections,
+ data->table.sections_end,
NULL);
}
default:
static struct target_section_table *
target_bfd_get_section_table (struct target_ops *ops)
{
- return ops->to_data;
+ struct target_bfd_data *data = ops->to_data;
+ return &data->table;
}
static void
-target_bfd_xclose (struct target_ops *t, int quitting)
+target_bfd_xclose (struct target_ops *t)
{
- struct target_section_table *table = t->to_data;
-
- /* If the target sections table is empty, the bfd had already been
- closed. */
- if (table->sections != table->sections_end)
- bfd_close (table->sections->bfd);
- xfree (table->sections);
- xfree (table);
+ struct target_bfd_data *data = t->to_data;
+
+ gdb_bfd_unref (data->bfd);
+ xfree (data->table.sections);
+ xfree (data);
xfree (t);
}
struct target_ops *
-target_bfd_reopen (struct bfd *bfd)
+target_bfd_reopen (struct bfd *abfd)
{
struct target_ops *t;
- struct target_section_table *table;
-
- table = XZALLOC (struct target_section_table);
- build_section_table (bfd, &table->sections, &table->sections_end);
+ struct target_bfd_data *data;
- /* No use keeping the bfd open if there are no target sections we
- care about. This way, we avoid keeping the bfd pointer stored
- somewhere so that target_bfd_xclose could use it. */
- if (table->sections == table->sections_end)
- bfd_close (bfd);
+ data = XZALLOC (struct target_bfd_data);
+ data->bfd = abfd;
+ gdb_bfd_ref (abfd);
+ build_section_table (abfd, &data->table.sections, &data->table.sections_end);
t = XZALLOC (struct target_ops);
t->to_shortname = "bfd";
t->to_get_section_table = target_bfd_get_section_table;
t->to_xfer_partial = target_bfd_xfer_partial;
t->to_xclose = target_bfd_xclose;
- t->to_data = table;
+ t->to_data = data;
return t;
}