/* Core dump and executable file functions below target vector, for GDB.
- Copyright (C) 1986, 1987, 1989, 1991, 1992, 1993, 1994, 1995, 1996, 1997,
- 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006, 2007, 2008
- Free Software Foundation, Inc.
+ Copyright (C) 1986-2020 Free Software Foundation, Inc.
This file is part of GDB.
#include "defs.h"
#include "arch-utils.h"
-#include "gdb_string.h"
-#include <errno.h>
#include <signal.h>
#include <fcntl.h>
-#ifdef HAVE_SYS_FILE_H
-#include <sys/file.h> /* needed for F_OK and friends */
-#endif
#include "frame.h" /* required by inferior.h */
#include "inferior.h"
+#include "infrun.h"
#include "symtab.h"
#include "command.h"
#include "bfd.h"
#include "target.h"
+#include "process-stratum-target.h"
#include "gdbcore.h"
#include "gdbthread.h"
#include "regcache.h"
#include "regset.h"
#include "symfile.h"
#include "exec.h"
-#include "readline/readline.h"
-#include "gdb_assert.h"
-#include "exceptions.h"
+#include "readline/tilde.h"
#include "solib.h"
#include "filenames.h"
-
+#include "progspace.h"
+#include "objfiles.h"
+#include "gdb_bfd.h"
+#include "completer.h"
+#include "gdbsupport/filestuff.h"
+#include "build-id.h"
+#include "gdbsupport/pathstuff.h"
#ifndef O_LARGEFILE
#define O_LARGEFILE 0
#endif
-/* List of all available core_fns. On gdb startup, each core file
- register reader calls deprecated_add_core_fns() to register
- information on each core format it is prepared to read. */
-
-static struct core_fns *core_file_fns = NULL;
+static core_fns *sniff_core_bfd (gdbarch *core_gdbarch,
+ bfd *abfd);
-/* The core_fns for a core file handler that is prepared to read the core
- file currently open on core_bfd. */
+/* The core file target. */
-static struct core_fns *core_vec = NULL;
+static const target_info core_target_info = {
+ "core",
+ N_("Local core dump file"),
+ N_("Use a core file as a target.\n\
+Specify the filename of the core file.")
+};
-/* FIXME: kettenis/20031023: Eventually this variable should
- disappear. */
-
-struct gdbarch *core_gdbarch = NULL;
-
-static void core_files_info (struct target_ops *);
-
-static struct core_fns *sniff_core_bfd (bfd *);
+class core_target final : public process_stratum_target
+{
+public:
+ core_target ();
+ ~core_target () override;
+
+ const target_info &info () const override
+ { return core_target_info; }
+
+ void close () override;
+ void detach (inferior *, int) override;
+ void fetch_registers (struct regcache *, int) override;
+
+ enum target_xfer_status xfer_partial (enum target_object object,
+ const char *annex,
+ gdb_byte *readbuf,
+ const gdb_byte *writebuf,
+ ULONGEST offset, ULONGEST len,
+ ULONGEST *xfered_len) override;
+ void files_info () override;
+
+ bool thread_alive (ptid_t ptid) override;
+ const struct target_desc *read_description () override;
+
+ std::string pid_to_str (ptid_t) override;
+
+ const char *thread_name (struct thread_info *) override;
+
+ bool has_all_memory () override { return false; }
+ bool has_memory () override;
+ bool has_stack () override;
+ bool has_registers () override;
+ bool has_execution (inferior *inf) override { return false; }
+
+ bool info_proc (const char *, enum info_proc_what) override;
+
+ /* A few helpers. */
+
+ /* Getter, see variable definition. */
+ struct gdbarch *core_gdbarch ()
+ {
+ return m_core_gdbarch;
+ }
+
+ /* See definition. */
+ void get_core_register_section (struct regcache *regcache,
+ const struct regset *regset,
+ const char *name,
+ int section_min_size,
+ int which,
+ const char *human_name,
+ bool required);
+
+private: /* per-core data */
+
+ /* The core's section table. Note that these target sections are
+ *not* mapped in the current address spaces' set of target
+ sections --- those should come only from pure executable or
+ shared library bfds. The core bfd sections are an implementation
+ detail of the core target, just like ptrace is for unix child
+ targets. */
+ target_section_table m_core_section_table {};
+
+ /* The core_fns for a core file handler that is prepared to read the
+ core file currently open on core_bfd. */
+ core_fns *m_core_vec = NULL;
+
+ /* FIXME: kettenis/20031023: Eventually this field should
+ disappear. */
+ struct gdbarch *m_core_gdbarch = NULL;
+};
+
+core_target::core_target ()
+{
+ m_core_gdbarch = gdbarch_from_bfd (core_bfd);
-static int gdb_check_format (bfd *);
+ /* Find a suitable core file handler to munch on core_bfd */
+ m_core_vec = sniff_core_bfd (m_core_gdbarch, core_bfd);
-static void core_open (char *, int);
+ /* Find the data section */
+ if (build_section_table (core_bfd,
+ &m_core_section_table.sections,
+ &m_core_section_table.sections_end))
+ error (_("\"%s\": Can't find sections: %s"),
+ bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
+}
-static void core_detach (struct target_ops *ops, char *, int);
+core_target::~core_target ()
+{
+ xfree (m_core_section_table.sections);
+}
-static void core_close (int);
+/* List of all available core_fns. On gdb startup, each core file
+ register reader calls deprecated_add_core_fns() to register
+ information on each core format it is prepared to read. */
-static void core_close_cleanup (void *ignore);
+static struct core_fns *core_file_fns = NULL;
-static void get_core_registers (struct regcache *, int);
+static int gdb_check_format (bfd *);
static void add_to_thread_list (bfd *, asection *, void *);
-static int core_file_thread_alive (ptid_t tid);
-
-static void init_core_ops (void);
-
-void _initialize_corelow (void);
-
-struct target_ops core_ops;
-
/* An arbitrary identifier for the core inferior. */
#define CORELOW_PID 1
-/* Link a new core_fns into the global core_file_fns list. Called on gdb
- startup by the _initialize routine in each core file register reader, to
- register information about each format the the reader is prepared to
- handle. */
+/* Link a new core_fns into the global core_file_fns list. Called on
+ gdb startup by the _initialize routine in each core file register
+ reader, to register information about each format the reader is
+ prepared to handle. */
void
deprecated_add_core_fns (struct core_fns *cf)
/* The default function that core file handlers can use to examine a
core file BFD and decide whether or not to accept the job of
- reading the core file. */
+ reading the core file. */
int
default_core_sniffer (struct core_fns *our_fns, bfd *abfd)
}
/* Walk through the list of core functions to find a set that can
- handle the core file open on ABFD. Default to the first one in the
- list if nothing matches. Returns pointer to set that is
- selected. */
+ handle the core file open on ABFD. Returns pointer to set that is
+ selected. */
static struct core_fns *
-sniff_core_bfd (bfd *abfd)
+sniff_core_bfd (struct gdbarch *core_gdbarch, bfd *abfd)
{
struct core_fns *cf;
struct core_fns *yummy = NULL;
- int matches = 0;;
+ int matches = 0;
- /* Don't sniff if we have support for register sets in CORE_GDBARCH. */
- if (core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch))
+ /* Don't sniff if we have support for register sets in
+ CORE_GDBARCH. */
+ if (core_gdbarch && gdbarch_iterate_over_regset_sections_p (core_gdbarch))
return NULL;
for (cf = core_file_fns; cf != NULL; cf = cf->next)
bfd_get_filename (abfd), matches);
}
else if (matches == 0)
- {
- warning (_("\"%s\": no core file handler recognizes format, using default"),
- bfd_get_filename (abfd));
- }
- if (yummy == NULL)
- {
- yummy = core_file_fns;
- }
+ error (_("\"%s\": no core file handler recognizes format"),
+ bfd_get_filename (abfd));
+
return (yummy);
}
/* The default is to reject every core file format we see. Either
BFD has to recognize it, or we have to provide a function in the
- core file handler that recognizes it. */
+ core file handler that recognizes it. */
int
default_check_format (bfd *abfd)
return (0);
}
-/* Attempt to recognize core file formats that BFD rejects. */
+/* Attempt to recognize core file formats that BFD rejects. */
static int
gdb_check_format (bfd *abfd)
return (0);
}
-/* Discard all vestiges of any previous core file and mark data and stack
- spaces as empty. */
+/* Close the core target. */
-static void
-core_close (int quitting)
+void
+core_target::close ()
{
- char *name;
-
if (core_bfd)
{
- inferior_ptid = null_ptid; /* Avoid confusion from thread stuff */
- delete_inferior_silent (CORELOW_PID);
+ inferior_ptid = null_ptid; /* Avoid confusion from thread
+ stuff. */
+ exit_inferior_silent (current_inferior ());
- /* Clear out solib state while the bfd is still open. See
- comments in clear_solib in solib.c. */
+ /* Clear out solib state while the bfd is still open. See
+ comments in clear_solib in solib.c. */
clear_solib ();
- name = bfd_get_filename (core_bfd);
- if (!bfd_close (core_bfd))
- warning (_("cannot close \"%s\": %s"),
- name, bfd_errmsg (bfd_get_error ()));
- xfree (name);
- core_bfd = NULL;
- if (core_ops.to_sections)
- {
- xfree (core_ops.to_sections);
- core_ops.to_sections = NULL;
- core_ops.to_sections_end = NULL;
- }
+ current_program_space->cbfd.reset (nullptr);
}
- core_vec = NULL;
- core_gdbarch = NULL;
-}
-static void
-core_close_cleanup (void *ignore)
-{
- core_close (0/*ignored*/);
+ /* Core targets are heap-allocated (see core_target_open), so here
+ we delete ourselves. */
+ delete this;
}
-/* Look for sections whose names start with `.reg/' so that we can extract the
- list of threads in a core file. */
+/* Look for sections whose names start with `.reg/' so that we can
+ extract the list of threads in a core file. */
static void
add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg)
{
ptid_t ptid;
- int thread_id;
+ int core_tid;
+ int pid, lwpid;
asection *reg_sect = (asection *) reg_sect_arg;
+ bool fake_pid_p = false;
+ struct inferior *inf;
- if (strncmp (bfd_section_name (abfd, asect), ".reg/", 5) != 0)
+ if (!startswith (bfd_section_name (asect), ".reg/"))
return;
- thread_id = atoi (bfd_section_name (abfd, asect) + 5);
+ core_tid = atoi (bfd_section_name (asect) + 5);
+
+ pid = bfd_core_file_pid (core_bfd);
+ if (pid == 0)
+ {
+ fake_pid_p = true;
+ pid = CORELOW_PID;
+ }
+
+ lwpid = core_tid;
+
+ inf = current_inferior ();
+ if (inf->pid == 0)
+ {
+ inferior_appeared (inf, pid);
+ inf->fake_pid_p = fake_pid_p;
+ }
- ptid = ptid_build (ptid_get_pid (inferior_ptid), thread_id, 0);
+ ptid = ptid_t (pid, lwpid, 0);
- if (ptid_get_lwp (inferior_ptid) == 0)
- /* The main thread has already been added before getting here, and
- this is the first time we hear about a thread id. Assume this
- is the main thread. */
- thread_change_ptid (inferior_ptid, ptid);
- else
- /* Nope, really a new thread. */
- add_thread (ptid);
+ add_thread (inf->process_target (), ptid);
/* Warning, Will Robinson, looking at BFD private data! */
if (reg_sect != NULL
- && asect->filepos == reg_sect->filepos) /* Did we find .reg? */
- inferior_ptid = ptid; /* Yes, make it current */
+ && asect->filepos == reg_sect->filepos) /* Did we find .reg? */
+ inferior_ptid = ptid; /* Yes, make it current. */
}
-/* This routine opens and sets up the core file bfd. */
+/* Issue a message saying we have no core to debug, if FROM_TTY. */
static void
-core_open (char *filename, int from_tty)
+maybe_say_no_core_file_now (int from_tty)
+{
+ if (from_tty)
+ printf_filtered (_("No core file now.\n"));
+}
+
+/* Backward compatibility with old way of specifying core files. */
+
+void
+core_file_command (const char *filename, int from_tty)
+{
+ dont_repeat (); /* Either way, seems bogus. */
+
+ if (filename == NULL)
+ {
+ if (core_bfd != NULL)
+ {
+ target_detach (current_inferior (), from_tty);
+ gdb_assert (core_bfd == NULL);
+ }
+ else
+ maybe_say_no_core_file_now (from_tty);
+ }
+ else
+ core_target_open (filename, from_tty);
+}
+
+/* Locate (and load) an executable file (and symbols) given the core file
+ BFD ABFD. */
+
+static void
+locate_exec_from_corefile_build_id (bfd *abfd, int from_tty)
+{
+ const bfd_build_id *build_id = build_id_bfd_get (abfd);
+ if (build_id == nullptr)
+ return;
+
+ gdb_bfd_ref_ptr execbfd
+ = build_id_to_exec_bfd (build_id->size, build_id->data);
+
+ if (execbfd != nullptr)
+ {
+ exec_file_attach (bfd_get_filename (execbfd.get ()), from_tty);
+ symbol_file_add_main (bfd_get_filename (execbfd.get ()),
+ symfile_add_flag (from_tty ? SYMFILE_VERBOSE : 0));
+ }
+}
+
+/* See gdbcore.h. */
+
+void
+core_target_open (const char *arg, int from_tty)
{
const char *p;
int siggy;
- struct cleanup *old_chain;
- char *temp;
- bfd *temp_bfd;
int scratch_chan;
int flags;
- int corelow_pid = CORELOW_PID;
target_preopen (from_tty);
- if (!filename)
+ if (!arg)
{
if (core_bfd)
- error (_("No core file specified. (Use `detach' to stop debugging a core file.)"));
+ error (_("No core file specified. (Use `detach' "
+ "to stop debugging a core file.)"));
else
error (_("No core file specified."));
}
- filename = tilde_expand (filename);
- if (!IS_ABSOLUTE_PATH(filename))
- {
- temp = concat (current_directory, "/", filename, (char *)NULL);
- xfree (filename);
- filename = temp;
- }
-
- old_chain = make_cleanup (xfree, filename);
+ gdb::unique_xmalloc_ptr<char> filename (tilde_expand (arg));
+ if (!IS_ABSOLUTE_PATH (filename.get ()))
+ filename = gdb_abspath (filename.get ());
flags = O_BINARY | O_LARGEFILE;
if (write_files)
flags |= O_RDWR;
else
flags |= O_RDONLY;
- scratch_chan = open (filename, flags, 0);
+ scratch_chan = gdb_open_cloexec (filename.get (), flags, 0);
if (scratch_chan < 0)
- perror_with_name (filename);
+ perror_with_name (filename.get ());
- temp_bfd = bfd_fopen (filename, gnutarget,
- write_files ? FOPEN_RUB : FOPEN_RB,
- scratch_chan);
+ gdb_bfd_ref_ptr temp_bfd (gdb_bfd_fopen (filename.get (), gnutarget,
+ write_files ? FOPEN_RUB : FOPEN_RB,
+ scratch_chan));
if (temp_bfd == NULL)
- perror_with_name (filename);
+ perror_with_name (filename.get ());
- if (!bfd_check_format (temp_bfd, bfd_core) &&
- !gdb_check_format (temp_bfd))
+ if (!bfd_check_format (temp_bfd.get (), bfd_core)
+ && !gdb_check_format (temp_bfd.get ()))
{
/* Do it after the err msg */
- /* FIXME: should be checking for errors from bfd_close (for one thing,
- on error it does not free all the storage associated with the
- bfd). */
- make_cleanup_bfd_close (temp_bfd);
+ /* FIXME: should be checking for errors from bfd_close (for one
+ thing, on error it does not free all the storage associated
+ with the bfd). */
error (_("\"%s\" is not a core dump: %s"),
- filename, bfd_errmsg (bfd_get_error ()));
+ filename.get (), bfd_errmsg (bfd_get_error ()));
}
- /* Looks semi-reasonable. Toss the old core file and work on the new. */
+ current_program_space->cbfd = std::move (temp_bfd);
- discard_cleanups (old_chain); /* Don't free filename any more */
- unpush_target (&core_ops);
- core_bfd = temp_bfd;
- old_chain = make_cleanup (core_close_cleanup, 0 /*ignore*/);
+ core_target *target = new core_target ();
- /* FIXME: kettenis/20031023: This is very dangerous. The
- CORE_GDBARCH that results from this call may very well be
- different from CURRENT_GDBARCH. However, its methods may only
- work if it is selected as the current architecture, because they
- rely on swapped data (see gdbarch.c). We should get rid of that
- swapped data. */
- core_gdbarch = gdbarch_from_bfd (core_bfd);
-
- /* Find a suitable core file handler to munch on core_bfd */
- core_vec = sniff_core_bfd (core_bfd);
+ /* Own the target until it is successfully pushed. */
+ target_ops_up target_holder (target);
validate_files ();
- /* Find the data section */
- if (build_section_table (core_bfd, &core_ops.to_sections,
- &core_ops.to_sections_end))
- error (_("\"%s\": Can't find sections: %s"),
- bfd_get_filename (core_bfd), bfd_errmsg (bfd_get_error ()));
-
/* If we have no exec file, try to set the architecture from the
core file. We don't do this unconditionally since an exec file
typically contains more information that helps us determine the
if (!exec_bfd)
set_gdbarch_from_file (core_bfd);
- push_target (&core_ops);
- discard_cleanups (old_chain);
+ push_target (std::move (target_holder));
- add_inferior_silent (corelow_pid);
+ inferior_ptid = null_ptid;
- /* Do this before acknowledging the inferior, so if
- post_create_inferior throws (can happen easilly if you're loading
- a core file with the wrong exec), we aren't left with threads
- from the previous inferior. */
- init_thread_list ();
-
- /* Set INFERIOR_PTID early, so an upper layer can rely on it being
- set while in the target_find_new_threads call below. */
- inferior_ptid = pid_to_ptid (corelow_pid);
-
- /* Assume ST --- Add a main task. We'll later detect when we go
- from ST to MT. */
- add_thread_silent (inferior_ptid);
-
- /* This is done first, before anything has a chance to query the
- inferior for information such as symbols. */
- post_create_inferior (&core_ops, from_tty);
+ /* Need to flush the register cache (and the frame cache) from a
+ previous debug session. If inferior_ptid ends up the same as the
+ last debug session --- e.g., b foo; run; gcore core1; step; gcore
+ core2; core core1; core core2 --- then there's potential for
+ get_current_regcache to return the cached regcache of the
+ previous session, and the frame cache being stale. */
+ registers_changed ();
/* Build up thread list from BFD sections, and possibly set the
current thread to the .reg/NN section matching the .reg
- section. */
+ section. */
bfd_map_over_sections (core_bfd, add_to_thread_list,
bfd_get_section_by_name (core_bfd, ".reg"));
+ if (inferior_ptid == null_ptid)
+ {
+ /* Either we found no .reg/NN section, and hence we have a
+ non-threaded core (single-threaded, from gdb's perspective),
+ or for some reason add_to_thread_list couldn't determine
+ which was the "main" thread. The latter case shouldn't
+ usually happen, but we're dealing with input here, which can
+ always be broken in different ways. */
+ thread_info *thread = first_thread_of_inferior (current_inferior ());
+
+ if (thread == NULL)
+ {
+ inferior_appeared (current_inferior (), CORELOW_PID);
+ inferior_ptid = ptid_t (CORELOW_PID);
+ add_thread_silent (target, inferior_ptid);
+ }
+ else
+ switch_to_thread (thread);
+ }
+
+ if (exec_bfd == nullptr)
+ locate_exec_from_corefile_build_id (core_bfd, from_tty);
+
+ post_create_inferior (target, from_tty);
+
/* Now go through the target stack looking for threads since there
may be a thread_stratum target loaded on top of target core by
now. The layer above should claim threads found in the BFD
sections. */
- target_find_new_threads ();
+ try
+ {
+ target_update_thread_list ();
+ }
+
+ catch (const gdb_exception_error &except)
+ {
+ exception_print (gdb_stderr, except);
+ }
p = bfd_core_file_failing_command (core_bfd);
if (p)
printf_filtered (_("Core was generated by `%s'.\n"), p);
+ /* Clearing any previous state of convenience variables. */
+ clear_exit_convenience_vars ();
+
siggy = bfd_core_file_failing_signal (core_bfd);
if (siggy > 0)
- /* NOTE: target_signal_from_host() converts a target signal value
- into gdb's internal signal value. Unfortunately gdb's internal
- value is called ``target_signal'' and this function got the
- name ..._from_host(). */
- printf_filtered (_("Program terminated with signal %d, %s.\n"), siggy,
- target_signal_to_string (
- gdbarch_target_signal_from_host (core_gdbarch, siggy)));
+ {
+ gdbarch *core_gdbarch = target->core_gdbarch ();
+
+ /* If we don't have a CORE_GDBARCH to work with, assume a native
+ core (map gdb_signal from host signals). If we do have
+ CORE_GDBARCH to work with, but no gdb_signal_from_target
+ implementation for that gdbarch, as a fallback measure,
+ assume the host signal mapping. It'll be correct for native
+ cores, but most likely incorrect for cross-cores. */
+ enum gdb_signal sig = (core_gdbarch != NULL
+ && gdbarch_gdb_signal_from_target_p (core_gdbarch)
+ ? gdbarch_gdb_signal_from_target (core_gdbarch,
+ siggy)
+ : gdb_signal_from_host (siggy));
+
+ printf_filtered (_("Program terminated with signal %s, %s.\n"),
+ gdb_signal_to_name (sig), gdb_signal_to_string (sig));
+
+ /* Set the value of the internal variable $_exitsignal,
+ which holds the signal uncaught by the inferior. */
+ set_internalvar_integer (lookup_internalvar ("_exitsignal"),
+ siggy);
+ }
/* Fetch all registers from core file. */
target_fetch_registers (get_current_regcache (), -1);
/* Now, set up the frame cache, and print the top of stack. */
reinit_frame_cache ();
- print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC);
+ print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1);
+
+ /* Current thread should be NUM 1 but the user does not know that.
+ If a program is single threaded gdb in general does not mention
+ anything about threads. That is why the test is >= 2. */
+ if (thread_count (target) >= 2)
+ {
+ try
+ {
+ thread_command (NULL, from_tty);
+ }
+ catch (const gdb_exception_error &except)
+ {
+ exception_print (gdb_stderr, except);
+ }
+ }
}
-static void
-core_detach (struct target_ops *ops, char *args, int from_tty)
+void
+core_target::detach (inferior *inf, int from_tty)
{
- if (args)
- error (_("Too many arguments"));
- unpush_target (ops);
+ /* Note that 'this' is dangling after this call. unpush_target
+ closes the target, and our close implementation deletes
+ 'this'. */
+ unpush_target (this);
+
+ /* Clear the register cache and the frame cache. */
+ registers_changed ();
reinit_frame_cache ();
- if (from_tty)
- printf_filtered (_("No core file now.\n"));
+ maybe_say_no_core_file_now (from_tty);
}
-
/* Try to retrieve registers from a section in core_bfd, and supply
- them to core_vec->core_read_registers, as the register set numbered
- WHICH.
+ them to m_core_vec->core_read_registers, as the register set
+ numbered WHICH.
- If inferior_ptid's lwp member is zero, do the single-threaded
- thing: look for a section named NAME. If inferior_ptid's lwp
+ If ptid's lwp member is zero, do the single-threaded
+ thing: look for a section named NAME. If ptid's lwp
member is non-zero, do the multi-threaded thing: look for a section
named "NAME/LWP", where LWP is the shortest ASCII decimal
- representation of inferior_ptid's lwp member.
+ representation of ptid's lwp member.
HUMAN_NAME is a human-readable name for the kind of registers the
NAME section contains, for use in error messages.
- If REQUIRED is non-zero, print an error if the core file doesn't
- have a section by the appropriate name. Otherwise, just do nothing. */
+ If REQUIRED is true, print an error if the core file doesn't have a
+ section by the appropriate name. Otherwise, just do nothing. */
-static void
-get_core_register_section (struct regcache *regcache,
- char *name,
- int which,
- char *human_name,
- int required)
+void
+core_target::get_core_register_section (struct regcache *regcache,
+ const struct regset *regset,
+ const char *name,
+ int section_min_size,
+ int which,
+ const char *human_name,
+ bool required)
{
- static char *section_name = NULL;
struct bfd_section *section;
bfd_size_type size;
char *contents;
+ bool variable_size_section = (regset != NULL
+ && regset->flags & REGSET_VARIABLE_SIZE);
- xfree (section_name);
- if (ptid_get_lwp (inferior_ptid))
- section_name = xstrprintf ("%s/%ld", name, ptid_get_lwp (inferior_ptid));
- else
- section_name = xstrdup (name);
+ thread_section_name section_name (name, regcache->ptid ());
- section = bfd_get_section_by_name (core_bfd, section_name);
+ section = bfd_get_section_by_name (core_bfd, section_name.c_str ());
if (! section)
{
if (required)
- warning (_("Couldn't find %s registers in core file."), human_name);
+ warning (_("Couldn't find %s registers in core file."),
+ human_name);
+ return;
+ }
+
+ size = bfd_section_size (section);
+ if (size < section_min_size)
+ {
+ warning (_("Section `%s' in core file too small."),
+ section_name.c_str ());
return;
}
+ if (size != section_min_size && !variable_size_section)
+ {
+ warning (_("Unexpected size of section `%s' in core file."),
+ section_name.c_str ());
+ }
- size = bfd_section_size (core_bfd, section);
- contents = alloca (size);
+ contents = (char *) alloca (size);
if (! bfd_get_section_contents (core_bfd, section, contents,
(file_ptr) 0, size))
{
warning (_("Couldn't read %s registers from `%s' section in core file."),
- human_name, name);
+ human_name, section_name.c_str ());
return;
}
- if (core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch))
+ if (regset != NULL)
{
- const struct regset *regset;
-
- regset = gdbarch_regset_from_core_section (core_gdbarch, name, size);
- if (regset == NULL)
- {
- if (required)
- warning (_("Couldn't recognize %s registers in core file."),
- human_name);
- return;
- }
-
regset->supply_regset (regset, regcache, -1, contents, size);
return;
}
- gdb_assert (core_vec);
- core_vec->core_read_registers (regcache, contents, size, which,
- ((CORE_ADDR)
- bfd_section_vma (core_bfd, section)));
+ gdb_assert (m_core_vec != nullptr);
+ m_core_vec->core_read_registers (regcache, contents, size, which,
+ (CORE_ADDR) bfd_section_vma (section));
}
+/* Data passed to gdbarch_iterate_over_regset_sections's callback. */
+struct get_core_registers_cb_data
+{
+ core_target *target;
+ struct regcache *regcache;
+};
+
+/* Callback for get_core_registers that handles a single core file
+ register note section. */
+
+static void
+get_core_registers_cb (const char *sect_name, int supply_size, int collect_size,
+ const struct regset *regset,
+ const char *human_name, void *cb_data)
+{
+ auto *data = (get_core_registers_cb_data *) cb_data;
+ bool required = false;
+ bool variable_size_section = (regset != NULL
+ && regset->flags & REGSET_VARIABLE_SIZE);
+
+ if (!variable_size_section)
+ gdb_assert (supply_size == collect_size);
+
+ if (strcmp (sect_name, ".reg") == 0)
+ {
+ required = true;
+ if (human_name == NULL)
+ human_name = "general-purpose";
+ }
+ else if (strcmp (sect_name, ".reg2") == 0)
+ {
+ if (human_name == NULL)
+ human_name = "floating-point";
+ }
+
+ /* The 'which' parameter is only used when no regset is provided.
+ Thus we just set it to -1. */
+ data->target->get_core_register_section (data->regcache, regset, sect_name,
+ supply_size, -1, human_name,
+ required);
+}
/* Get the registers out of a core file. This is the machine-
independent part. Fetch_core_registers is the machine-dependent
- part, typically implemented in the xm-file for each architecture. */
+ part, typically implemented in the xm-file for each
+ architecture. */
/* We just get all the registers, so we don't use regno. */
-static void
-get_core_registers (struct regcache *regcache, int regno)
+void
+core_target::fetch_registers (struct regcache *regcache, int regno)
{
int i;
+ struct gdbarch *gdbarch;
- if (!(core_gdbarch && gdbarch_regset_from_core_section_p (core_gdbarch))
- && (core_vec == NULL || core_vec->core_read_registers == NULL))
+ if (!(m_core_gdbarch != nullptr
+ && gdbarch_iterate_over_regset_sections_p (m_core_gdbarch))
+ && (m_core_vec == NULL || m_core_vec->core_read_registers == NULL))
{
fprintf_filtered (gdb_stderr,
"Can't fetch registers from this type of core file\n");
return;
}
- get_core_register_section (regcache,
- ".reg", 0, "general-purpose", 1);
- get_core_register_section (regcache,
- ".reg2", 2, "floating-point", 0);
- get_core_register_section (regcache,
- ".reg-xfp", 3, "extended floating-point", 0);
- get_core_register_section (regcache,
- ".reg-ppc-vmx", 3, "ppc Altivec", 0);
- get_core_register_section (regcache,
- ".reg-ppc-vsx", 4, "POWER7 VSX", 0);
-
- /* Supply dummy value for all registers not found in the core. */
- for (i = 0; i < gdbarch_num_regs (get_regcache_arch (regcache)); i++)
- if (!regcache_valid_p (regcache, i))
- regcache_raw_supply (regcache, i, NULL);
+ gdbarch = regcache->arch ();
+ if (gdbarch_iterate_over_regset_sections_p (gdbarch))
+ {
+ get_core_registers_cb_data data = { this, regcache };
+ gdbarch_iterate_over_regset_sections (gdbarch,
+ get_core_registers_cb,
+ (void *) &data, NULL);
+ }
+ else
+ {
+ get_core_register_section (regcache, NULL,
+ ".reg", 0, 0, "general-purpose", 1);
+ get_core_register_section (regcache, NULL,
+ ".reg2", 0, 2, "floating-point", 0);
+ }
+
+ /* Mark all registers not found in the core as unavailable. */
+ for (i = 0; i < gdbarch_num_regs (regcache->arch ()); i++)
+ if (regcache->get_register_status (i) == REG_UNKNOWN)
+ regcache->raw_supply (i, NULL);
}
-static void
-core_files_info (struct target_ops *t)
+void
+core_target::files_info ()
{
- print_section_info (t, core_bfd);
+ print_section_info (&m_core_section_table, core_bfd);
}
\f
-static LONGEST
-core_xfer_partial (struct target_ops *ops, enum target_object object,
- const char *annex, gdb_byte *readbuf,
- const gdb_byte *writebuf, ULONGEST offset, LONGEST len)
+enum target_xfer_status
+core_target::xfer_partial (enum target_object object, const char *annex,
+ gdb_byte *readbuf, const gdb_byte *writebuf,
+ ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
{
switch (object)
{
case TARGET_OBJECT_MEMORY:
- if (readbuf)
- return (*ops->deprecated_xfer_memory) (offset, readbuf,
- len, 0/*read*/, NULL, ops);
- if (writebuf)
- return (*ops->deprecated_xfer_memory) (offset, (gdb_byte *) writebuf,
- len, 1/*write*/, NULL, ops);
- return -1;
+ return (section_table_xfer_memory_partial
+ (readbuf, writebuf,
+ offset, len, xfered_len,
+ m_core_section_table.sections,
+ m_core_section_table.sections_end,
+ NULL));
case TARGET_OBJECT_AUXV:
if (readbuf)
struct bfd_section *section;
bfd_size_type size;
- char *contents;
section = bfd_get_section_by_name (core_bfd, ".auxv");
if (section == NULL)
- return -1;
+ return TARGET_XFER_E_IO;
- size = bfd_section_size (core_bfd, section);
+ size = bfd_section_size (section);
if (offset >= size)
- return 0;
+ return TARGET_XFER_EOF;
size -= offset;
if (size > len)
size = len;
- if (size > 0
- && !bfd_get_section_contents (core_bfd, section, readbuf,
- (file_ptr) offset, size))
+
+ if (size == 0)
+ return TARGET_XFER_EOF;
+ if (!bfd_get_section_contents (core_bfd, section, readbuf,
+ (file_ptr) offset, size))
{
warning (_("Couldn't read NT_AUXV note in core file."));
- return -1;
+ return TARGET_XFER_E_IO;
}
- return size;
+ *xfered_len = (ULONGEST) size;
+ return TARGET_XFER_OK;
}
- return -1;
+ return TARGET_XFER_E_IO;
case TARGET_OBJECT_WCOOKIE:
if (readbuf)
{
/* When the StackGhost cookie is stored in core file, BFD
- represents this with a fake section called ".wcookie". */
+ represents this with a fake section called
+ ".wcookie". */
struct bfd_section *section;
bfd_size_type size;
- char *contents;
section = bfd_get_section_by_name (core_bfd, ".wcookie");
if (section == NULL)
- return -1;
+ return TARGET_XFER_E_IO;
- size = bfd_section_size (core_bfd, section);
+ size = bfd_section_size (section);
if (offset >= size)
- return 0;
+ return TARGET_XFER_EOF;
size -= offset;
if (size > len)
size = len;
- if (size > 0
- && !bfd_get_section_contents (core_bfd, section, readbuf,
- (file_ptr) offset, size))
+
+ if (size == 0)
+ return TARGET_XFER_EOF;
+ if (!bfd_get_section_contents (core_bfd, section, readbuf,
+ (file_ptr) offset, size))
{
warning (_("Couldn't read StackGhost cookie in core file."));
- return -1;
+ return TARGET_XFER_E_IO;
}
- return size;
+ *xfered_len = (ULONGEST) size;
+ return TARGET_XFER_OK;
+
}
- return -1;
+ return TARGET_XFER_E_IO;
case TARGET_OBJECT_LIBRARIES:
- if (core_gdbarch
- && gdbarch_core_xfer_shared_libraries_p (core_gdbarch))
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_shared_libraries_p (m_core_gdbarch))
{
if (writebuf)
- return -1;
- return
- gdbarch_core_xfer_shared_libraries (core_gdbarch,
- readbuf, offset, len);
+ return TARGET_XFER_E_IO;
+ else
+ {
+ *xfered_len = gdbarch_core_xfer_shared_libraries (m_core_gdbarch,
+ readbuf,
+ offset, len);
+
+ if (*xfered_len == 0)
+ return TARGET_XFER_EOF;
+ else
+ return TARGET_XFER_OK;
+ }
}
/* FALL THROUGH */
+ case TARGET_OBJECT_LIBRARIES_AIX:
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_shared_libraries_aix_p (m_core_gdbarch))
+ {
+ if (writebuf)
+ return TARGET_XFER_E_IO;
+ else
+ {
+ *xfered_len
+ = gdbarch_core_xfer_shared_libraries_aix (m_core_gdbarch,
+ readbuf, offset,
+ len);
+
+ if (*xfered_len == 0)
+ return TARGET_XFER_EOF;
+ else
+ return TARGET_XFER_OK;
+ }
+ }
+ /* FALL THROUGH */
+
+ case TARGET_OBJECT_SIGNAL_INFO:
+ if (readbuf)
+ {
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_xfer_siginfo_p (m_core_gdbarch))
+ {
+ LONGEST l = gdbarch_core_xfer_siginfo (m_core_gdbarch, readbuf,
+ offset, len);
+
+ if (l >= 0)
+ {
+ *xfered_len = l;
+ if (l == 0)
+ return TARGET_XFER_EOF;
+ else
+ return TARGET_XFER_OK;
+ }
+ }
+ }
+ return TARGET_XFER_E_IO;
+
default:
- if (ops->beneath != NULL)
- return ops->beneath->to_xfer_partial (ops->beneath, object, annex,
- readbuf, writebuf, offset, len);
- return -1;
+ return this->beneath ()->xfer_partial (object, annex, readbuf,
+ writebuf, offset, len,
+ xfered_len);
}
}
\f
-/* If mourn is being called in all the right places, this could be say
- `gdb internal error' (since generic_mourn calls breakpoint_init_inferior). */
-
-static int
-ignore (struct bp_target_info *bp_tgt)
-{
- return 0;
-}
-
/* Okay, let's be honest: threads gleaned from a core file aren't
exactly lively, are they? On the other hand, if we don't claim
to appear in an "info thread" command, which is quite a useful
behaviour.
*/
-static int
-core_file_thread_alive (ptid_t tid)
+bool
+core_target::thread_alive (ptid_t ptid)
{
- return 1;
+ return true;
}
/* Ask the current architecture what it knows about this core file.
That will be used, in turn, to pick a better architecture. This
wrapper could be avoided if targets got a chance to specialize
- core_ops. */
+ core_target. */
-static const struct target_desc *
-core_read_description (struct target_ops *target)
+const struct target_desc *
+core_target::read_description ()
{
- if (gdbarch_core_read_description_p (current_gdbarch))
- return gdbarch_core_read_description (current_gdbarch, target, core_bfd);
+ if (m_core_gdbarch && gdbarch_core_read_description_p (m_core_gdbarch))
+ {
+ const struct target_desc *result;
- return NULL;
+ result = gdbarch_core_read_description (m_core_gdbarch, this, core_bfd);
+ if (result != NULL)
+ return result;
+ }
+
+ return this->beneath ()->read_description ();
}
-static char *
-core_pid_to_str (ptid_t ptid)
+std::string
+core_target::pid_to_str (ptid_t ptid)
{
- static char buf[64];
+ struct inferior *inf;
+ int pid;
+
+ /* The preferred way is to have a gdbarch/OS specific
+ implementation. */
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_pid_to_str_p (m_core_gdbarch))
+ return gdbarch_core_pid_to_str (m_core_gdbarch, ptid);
+
+ /* Otherwise, if we don't have one, we'll just fallback to
+ "process", with normal_pid_to_str. */
+
+ /* Try the LWPID field first. */
+ pid = ptid.lwp ();
+ if (pid != 0)
+ return normal_pid_to_str (ptid_t (pid));
+
+ /* Otherwise, this isn't a "threaded" core -- use the PID field, but
+ only if it isn't a fake PID. */
+ inf = find_inferior_ptid (this, ptid);
+ if (inf != NULL && !inf->fake_pid_p)
+ return normal_pid_to_str (ptid);
+
+ /* No luck. We simply don't have a valid PID to print. */
+ return "<main task>";
+}
- if (ptid_get_lwp (ptid) == 0)
- xsnprintf (buf, sizeof buf, "<main task>");
- else
- xsnprintf (buf, sizeof buf, "Thread %ld", ptid_get_lwp (ptid));
+const char *
+core_target::thread_name (struct thread_info *thr)
+{
+ if (m_core_gdbarch != nullptr
+ && gdbarch_core_thread_name_p (m_core_gdbarch))
+ return gdbarch_core_thread_name (m_core_gdbarch, thr);
+ return NULL;
+}
- return buf;
+bool
+core_target::has_memory ()
+{
+ return (core_bfd != NULL);
}
-/* Fill in core_ops with its defined operations and properties. */
+bool
+core_target::has_stack ()
+{
+ return (core_bfd != NULL);
+}
-static void
-init_core_ops (void)
+bool
+core_target::has_registers ()
{
- core_ops.to_shortname = "core";
- core_ops.to_longname = "Local core dump file";
- core_ops.to_doc =
- "Use a core file as a target. Specify the filename of the core file.";
- core_ops.to_open = core_open;
- core_ops.to_close = core_close;
- core_ops.to_attach = find_default_attach;
- core_ops.to_detach = core_detach;
- core_ops.to_fetch_registers = get_core_registers;
- core_ops.to_xfer_partial = core_xfer_partial;
- core_ops.deprecated_xfer_memory = xfer_memory;
- core_ops.to_files_info = core_files_info;
- core_ops.to_insert_breakpoint = ignore;
- core_ops.to_remove_breakpoint = ignore;
- core_ops.to_create_inferior = find_default_create_inferior;
- core_ops.to_thread_alive = core_file_thread_alive;
- core_ops.to_read_description = core_read_description;
- core_ops.to_pid_to_str = core_pid_to_str;
- core_ops.to_stratum = core_stratum;
- core_ops.to_has_memory = 1;
- core_ops.to_has_stack = 1;
- core_ops.to_has_registers = 1;
- core_ops.to_magic = OPS_MAGIC;
+ return (core_bfd != NULL);
}
-/* non-zero if we should not do the add_target call in
- _initialize_corelow; not initialized (i.e., bss) so that
- the target can initialize it (i.e., data) if appropriate.
- This needs to be set at compile time because we don't know
- for sure whether the target's initialize routine is called
- before us or after us. */
-int coreops_suppress_target;
+/* Implement the to_info_proc method. */
+
+bool
+core_target::info_proc (const char *args, enum info_proc_what request)
+{
+ struct gdbarch *gdbarch = get_current_arch ();
+
+ /* Since this is the core file target, call the 'core_info_proc'
+ method on gdbarch, not 'info_proc'. */
+ if (gdbarch_core_info_proc_p (gdbarch))
+ gdbarch_core_info_proc (gdbarch, args, request);
+
+ return true;
+}
void
_initialize_corelow (void)
{
- init_core_ops ();
-
- if (!coreops_suppress_target)
- add_target (&core_ops);
+ add_target (core_target_info, core_target_open, filename_completer);
}
projects / deliverable / binutils-gdb.git / blobdiff