import gdb-1999-05-25 snapshot
[deliverable/binutils-gdb.git] / gdb / mdebugread.c
index 3fe4f962c88bc2ae9c1720a7bd749bf1dd5fd41a..12b84553b0f1340dc1b2050b8e5074ba35010bbe 100644 (file)
@@ -1,5 +1,5 @@
 /* Read a symbol table in ECOFF format (Third-Eye).
-   Copyright 1986, 1987, 1989, 1990, 1991, 1992, 1993, 1994, 1995, 1996
+   Copyright 1986, 87, 89, 90, 91, 92, 93, 94, 95, 96, 97, 1998
    Free Software Foundation, Inc.
    Original version contributed by Alessandro Forin (af@cs.cmu.edu) at
    CMU.  Major work by Per Bothner, John Gilmore and Ian Lance Taylor
@@ -56,6 +56,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
 
 #ifndef MIPS_EFI_SYMBOL_NAME
 #define MIPS_EFI_SYMBOL_NAME "__GDB_EFI_INFO__"
+extern void ecoff_relocate_efi PARAMS ((struct symbol *, CORE_ADDR));
 #include "coff/sym.h"
 #include "coff/symconst.h"
 typedef struct mips_extra_func_info {
@@ -71,8 +72,6 @@ typedef struct mips_extra_func_info {
 #include <sys/types.h>
 #endif
 
-#include <sys/param.h>
-#include <sys/file.h>
 #include "gdb_stat.h"
 #include "gdb_string.h"
 
@@ -89,10 +88,20 @@ typedef struct mips_extra_func_info {
 #include "expression.h"
 #include "language.h"          /* Needed inside partial-stab.h */
 
+extern void _initialize_mdebugread PARAMS ((void));
+
 /* Provide a default mapping from a ecoff register number to a gdb REGNUM.  */
 #ifndef ECOFF_REG_TO_REGNUM
 #define ECOFF_REG_TO_REGNUM(num) (num)
 #endif
+
+/* Provide a way to test if we have both ECOFF and ELF symbol tables.  
+   We use this define in order to know whether we should override a 
+   symbol's ECOFF section with its ELF section.  This is necessary in 
+   case the symbol's ELF section could not be represented in ECOFF.  */
+#define ECOFF_IN_ELF(bfd) (bfd_get_flavour (bfd) == bfd_target_elf_flavour \
+                          && bfd_get_section_by_name (bfd, ".mdebug") != NULL)
+
 \f
 /* We put a pointer to this structure in the read_symtab_private field
    of the psymtab.  */
@@ -119,6 +128,20 @@ struct symloc
 #define DEBUG_SWAP(p) (PST_PRIVATE(p)->debug_swap)
 #define DEBUG_INFO(p) (PST_PRIVATE(p)->debug_info)
 #define PENDING_LIST(p) (PST_PRIVATE(p)->pending_list)
+
+#define SC_IS_TEXT(sc) ((sc) == scText \
+                  || (sc) == scRConst \
+                  || (sc) == scInit \
+                  || (sc) == scFini)
+#define SC_IS_DATA(sc) ((sc) == scData \
+                  || (sc) == scSData \
+                  || (sc) == scRData \
+                  || (sc) == scPData \
+                  || (sc) == scXData)
+#define SC_IS_COMMON(sc) ((sc) == scCommon || (sc) == scSCommon)
+#define SC_IS_BSS(sc) ((sc) == scBss || (sc) == scSBss)
+#define SC_IS_UNDEF(sc) ((sc) == scUndefined || (sc) == scSUndefined)
+                                      
 \f
 /* Things we import explicitly from other modules */
 
@@ -255,8 +278,8 @@ static int cur_sdx;
 /* Note how much "debuggable" this image is.  We would like
    to see at least one FDR with full symbols */
 
-static max_gdbinfo;
-static max_glevel;
+static int max_gdbinfo;
+static int max_glevel;
 
 /* When examining .o files, report on undefined symbols */
 
@@ -305,6 +328,24 @@ static int found_ecoff_debugging_info;
 
 /* Forward declarations */
 
+static void
+add_pending PARAMS ((FDR *, char *, struct type *));
+
+static struct mdebug_pending *
+is_pending_symbol PARAMS ((FDR *, char *));
+
+static void
+pop_parse_stack PARAMS ((void));
+
+static void
+push_parse_stack PARAMS ((void));
+
+static char *
+fdr_name PARAMS ((FDR *));
+
+static void
+mdebug_psymtab_to_symtab PARAMS ((struct partial_symtab *));
+
 static int
 upgrade_type PARAMS ((int, struct type **, int, union aux_ext *, int, char *));
 
@@ -704,6 +745,7 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
   switch (sh->sc)
     {
     case scText:
+    case scRConst:
       /* Do not relocate relative values.
         The value of a stEnd symbol is the displacement from the
         corresponding start symbol value.
@@ -742,7 +784,7 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
       class = LOC_STATIC;
       b = top_stack->cur_block;
       s = new_symbol (name);
-      if (sh->sc == scCommon || sh->sc == scSCommon)
+      if (SC_IS_COMMON(sh->sc))
        {
          /* It is a FORTRAN common block.  At least for SGI Fortran the
             address is not in the symbol; we need to fix it later in
@@ -773,7 +815,8 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
       add_symbol (s, b);
 
       /* Type could be missing if file is compiled without debugging info.  */
-      if (sh->sc == scUndefined || sh->sc == scNil || sh->index == indexNil)
+      if (SC_IS_UNDEF(sh->sc)
+         || sh->sc == scNil || sh->index == indexNil)
        SYMBOL_TYPE (s) = nodebug_var_symbol_type;
       else
        SYMBOL_TYPE (s) = parse_type (cur_fd, ax, sh->index, 0, bigend, name);
@@ -832,10 +875,26 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
       SYMBOL_NAMESPACE (s) = VAR_NAMESPACE;
       SYMBOL_CLASS (s) = LOC_BLOCK;
       /* Type of the return value */
-      if (sh->sc == scUndefined || sh->sc == scNil)
+      if (SC_IS_UNDEF(sh->sc) || sh->sc == scNil)
        t = mdebug_type_int;
       else
-       t = parse_type (cur_fd, ax, sh->index + 1, 0, bigend, name);
+       {
+         t = parse_type (cur_fd, ax, sh->index + 1, 0, bigend, name);
+         if (STREQ(name, "malloc") && t->code == TYPE_CODE_VOID)
+           {
+             /* I don't know why, but, at least under Alpha GNU/Linux,
+                when linking against a malloc without debugging
+                symbols, its read as a function returning void---this
+                is bad because it means we cannot call functions with
+                string arguments interactively; i.e., "call
+                printf("howdy\n")" would fail with the error message
+                "program has no memory available".  To avoid this, we
+                patch up the type and make it void*
+                instead. (davidm@azstarnet.com)
+                */
+             t = make_pointer_type (t, NULL);
+           }
+       }
       b = top_stack->cur_block;
       if (sh->st == stProc)
        {
@@ -865,7 +924,7 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
       add_block (b, top_stack->cur_st);
 
       /* Not if we only have partial info */
-      if (sh->sc == scUndefined || sh->sc == scNil)
+      if (SC_IS_UNDEF(sh->sc) || sh->sc == scNil)
        break;
 
       push_parse_stack ();
@@ -899,7 +958,7 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
        goto structured_common;
 
     case stBlock:              /* Either a lexical block, or some type */
-       if (sh->sc != scInfo && sh->sc != scCommon && sh->sc != scSCommon)
+       if (sh->sc != scInfo && !SC_IS_COMMON(sh->sc))
          goto case_stBlock_code;       /* Lexical block */
 
        type_code = TYPE_CODE_UNDEF;    /* We have a type.  */
@@ -930,23 +989,28 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
 
              case stMember:
                if (nfields == 0 && type_code == TYPE_CODE_UNDEF)
-                 /* If the type of the member is Nil (or Void),
-                    without qualifiers, assume the tag is an
-                    enumeration.
-                    Alpha cc -migrate enums are recognized by a zero
-                    index and a zero symbol value.  */
-                 if (tsym.index == indexNil
-                     || (tsym.index == 0 && sh->value == 0))
-                   type_code = TYPE_CODE_ENUM;
-                 else
-                   {
-                     (*debug_swap->swap_tir_in) (bigend,
-                                                 &ax[tsym.index].a_ti,
-                                                 &tir);
-                     if ((tir.bt == btNil || tir.bt == btVoid)
-                         && tir.tq0 == tqNil)
-                       type_code = TYPE_CODE_ENUM;
-                   }
+                 {
+                   /* If the type of the member is Nil (or Void),
+                      without qualifiers, assume the tag is an
+                      enumeration.
+                      Alpha cc -migrate enums are recognized by a zero
+                      index and a zero symbol value.
+                      DU 4.0 cc enums are recognized by a member type of
+                      btEnum without qualifiers and a zero symbol value.  */
+                   if (tsym.index == indexNil
+                       || (tsym.index == 0 && sh->value == 0))
+                     type_code = TYPE_CODE_ENUM;
+                   else
+                     {
+                       (*debug_swap->swap_tir_in) (bigend,
+                                                   &ax[tsym.index].a_ti,
+                                                   &tir);
+                       if ((tir.bt == btNil || tir.bt == btVoid
+                            || (tir.bt == btEnum && sh->value == 0))
+                           && tir.tq0 == tqNil)
+                         type_code = TYPE_CODE_ENUM;
+                     }
+                 }
                nfields++;
                if (tsym.value > max_value)
                  max_value = tsym.value;
@@ -1029,10 +1093,12 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
           here.) */
 
        if (type_code == TYPE_CODE_UNDEF)
-         if (nfields > 1 && max_value == 0)
-           type_code = TYPE_CODE_UNION;
-         else
-           type_code = TYPE_CODE_STRUCT;
+         {
+           if (nfields > 1 && max_value == 0)
+             type_code = TYPE_CODE_UNION;
+           else
+             type_code = TYPE_CODE_STRUCT;
+         }
 
        /* Create a new type or use the pending type.  */
        pend = is_pending_symbol (cur_fdr, ext_sh);
@@ -1089,16 +1155,18 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
                if (tsym.st != stMember)
                  break;
 
-               f->bitpos = tsym.value;
-               f->type = t;
-               f->name = debug_info->ss + cur_fdr->issBase + tsym.iss;
-               f->bitsize = 0;
+               FIELD_BITPOS (*f) = tsym.value;
+               FIELD_TYPE (*f) = t;
+               FIELD_NAME (*f) = debug_info->ss + cur_fdr->issBase + tsym.iss;
+               FIELD_BITSIZE (*f) = 0;
 
                enum_sym = ((struct symbol *)
                            obstack_alloc (&current_objfile->symbol_obstack,
                                           sizeof (struct symbol)));
                memset ((PTR) enum_sym, 0, sizeof (struct symbol));
-               SYMBOL_NAME (enum_sym) = f->name;
+               SYMBOL_NAME (enum_sym) =
+                 obsavestring (f->name, strlen (f->name),
+                               &current_objfile->symbol_obstack);
                SYMBOL_CLASS (enum_sym) = LOC_CONST;
                SYMBOL_TYPE (enum_sym) = t;
                SYMBOL_NAMESPACE (enum_sym) = VAR_NAMESPACE;
@@ -1167,7 +1235,7 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
       break;
 
     case stEnd:                /* end (of anything) */
-      if (sh->sc == scInfo || sh->sc == scCommon || sh->sc == scSCommon)
+      if (sh->sc == scInfo || SC_IS_COMMON(sh->sc))
        {
          /* Finished with type */
          top_stack->cur_type = 0;
@@ -1277,11 +1345,11 @@ parse_symbol (sh, ax, ext_sh, bigend, section_offsets)
 
     case stMember:             /* member of struct or union */
       f = &TYPE_FIELDS (top_stack->cur_type)[top_stack->cur_field++];
-      f->name = name;
-      f->bitpos = sh->value;
+      FIELD_NAME (*f) = name;
+      FIELD_BITPOS (*f) = sh->value;
       bitsize = 0;
-      f->type = parse_type (cur_fd, ax, sh->index, &bitsize, bigend, name);
-      f->bitsize = bitsize;
+      FIELD_TYPE (*f) = parse_type (cur_fd, ax, sh->index, &bitsize, bigend, name);
+      FIELD_BITSIZE (*f) = bitsize;
       break;
 
     case stIndirect:           /* forward declaration on Irix5 */
@@ -1856,14 +1924,13 @@ upgrade_type (fd, tpp, tq, ax, bigend, sym_name)
    to look for the function which contains the MIPS_EFI_SYMBOL_NAME symbol
    in question, or NULL to use top_stack->cur_block.  */
 
-static void parse_procedure PARAMS ((PDR *, struct symtab *, CORE_ADDR,
+static void parse_procedure PARAMS ((PDR *, struct symtab *,
                                     struct partial_symtab *));
 
 static void
-parse_procedure (pr, search_symtab, lowest_pdr_addr, pst)
+parse_procedure (pr, search_symtab, pst)
      PDR *pr;
      struct symtab *search_symtab;
-     CORE_ADDR lowest_pdr_addr;
      struct partial_symtab *pst;
 {
   struct symbol *s, *i;
@@ -1969,7 +2036,18 @@ parse_procedure (pr, search_symtab, lowest_pdr_addr, pst)
       e = (struct mips_extra_func_info *) SYMBOL_VALUE (i);
       e->pdr = *pr;
       e->pdr.isym = (long) s;
-      e->pdr.adr += pst->textlow - lowest_pdr_addr;
+
+      /* GDB expects the absolute function start address for the
+        procedure descriptor in e->pdr.adr.
+        As the address in the procedure descriptor is usually relative,
+        we would have to relocate e->pdr.adr with cur_fdr->adr and
+        ANOFFSET (pst->section_offsets, SECT_OFF_TEXT).
+        Unfortunately cur_fdr->adr and e->pdr.adr are both absolute
+        in shared libraries on some systems, and on other systems
+        e->pdr.adr is sometimes offset by a bogus value.
+        To work around these problems, we replace e->pdr.adr with
+        the start address of the function.  */
+      e->pdr.adr = BLOCK_START (b);
 
       /* Correct incorrect setjmp procedure descriptor from the library
         to make backtrace through setjmp work.  */
@@ -2046,7 +2124,7 @@ parse_external (es, bigend, section_offsets)
     }
 
   /* Reading .o files */
-  if (es->asym.sc == scUndefined || es->asym.sc == scNil)
+  if (SC_IS_UNDEF(es->asym.sc) || es->asym.sc == scNil)
     {
       char *what;
       switch (es->asym.st)
@@ -2099,7 +2177,7 @@ parse_external (es, bigend, section_offsets)
     case stLabel:
       /* Global common symbols are resolved by the runtime loader,
         ignore them.  */
-      if (es->asym.sc == scCommon || es->asym.sc == scSCommon)
+      if (SC_IS_COMMON(es->asym.sc))
        break;
 
       /* Note that the case of a symbol with indexNil must be handled
@@ -2217,7 +2295,7 @@ parse_partial_symbols (objfile, section_offsets)
   EXTR *ext_in_end;
   SYMR sh;
   struct partial_symtab *pst;
-
+  int textlow_not_set = 1;
   int past_first_source_file = 0;
 
   /* List of current psymtab's include files */
@@ -2327,104 +2405,140 @@ parse_partial_symbols (objfile, section_offsets)
       fdr_to_pst[f_idx].n_globals = 0;
     }
 
-  /* Pass 2 over external syms: fill in external symbols */
-  ext_in = ext_block;
-  ext_in_end = ext_in + hdr->iextMax;
-  for (; ext_in < ext_in_end; ext_in++)
-    {
-      enum minimal_symbol_type ms_type = mst_text;
-      CORE_ADDR svalue = ext_in->asym.value;
+  /* ECOFF in ELF:
+
+     For ECOFF in ELF, we skip the creation of the minimal symbols.
+     The ECOFF symbols should be a subset of the Elf symbols, and the 
+     section information of the elf symbols will be more accurate.
+     FIXME!  What about Irix 5's native linker?
+
+     By default, Elf sections which don't exist in ECOFF 
+     get put in ECOFF's absolute section by the gnu linker.
+     Since absolute sections don't get relocated, we 
+     end up calculating an address different from that of 
+     the symbol's minimal symbol (created earlier from the
+     Elf symtab).  
+
+     To fix this, either :
+     1) don't create the duplicate symbol
+        (assumes ECOFF symtab is a subset of the ELF symtab;
+        assumes no side-effects result from ignoring ECOFF symbol)
+     2) create it, only if lookup for existing symbol in ELF's minimal 
+        symbols fails
+        (inefficient; 
+        assumes no side-effects result from ignoring ECOFF symbol)
+     3) create it, but lookup ELF's minimal symbol and use it's section
+        during relocation, then modify "uniqify" phase to merge and 
+        eliminate the duplicate symbol
+        (highly inefficient)
+
+     I've implemented #1 here...
+     Skip the creation of the minimal symbols based on the ECOFF 
+     symbol table. */
+
+    /* Pass 2 over external syms: fill in external symbols */
+    ext_in = ext_block;
+    ext_in_end = ext_in + hdr->iextMax;
+    for (; ext_in < ext_in_end; ext_in++)
+      {
+       enum minimal_symbol_type ms_type = mst_text;
+       CORE_ADDR svalue = ext_in->asym.value;
 
-      /* The Irix 5 native tools seem to sometimes generate bogus
-        external symbols.  */
-      if (ext_in->ifd < -1 || ext_in->ifd >= hdr->ifdMax)
-       {
-         complain (&bad_ext_ifd_complaint, ext_in->ifd, hdr->ifdMax);
-         continue;
-       }
-      if (ext_in->asym.iss < 0 || ext_in->asym.iss >= hdr->issExtMax)
-       {
-         complain (&bad_ext_iss_complaint, ext_in->asym.iss,
-                   hdr->issExtMax);
-         continue;
-       }
+       /* The Irix 5 native tools seem to sometimes generate bogus
+          external symbols.  */
+       if (ext_in->ifd < -1 || ext_in->ifd >= hdr->ifdMax)
+         {
+           complain (&bad_ext_ifd_complaint, ext_in->ifd, hdr->ifdMax);
+           continue;
+         }
+       if (ext_in->asym.iss < 0 || ext_in->asym.iss >= hdr->issExtMax)
+         {
+           complain (&bad_ext_iss_complaint, ext_in->asym.iss,
+                       hdr->issExtMax);
+           continue;
+         }
 
-      extern_tab[fdr_to_pst[ext_in->ifd].globals_offset
-                + fdr_to_pst[ext_in->ifd].n_globals++] = *ext_in;
+       extern_tab[fdr_to_pst[ext_in->ifd].globals_offset
+                  + fdr_to_pst[ext_in->ifd].n_globals++] = *ext_in;
 
-      if (ext_in->asym.sc == scUndefined || ext_in->asym.sc == scNil)
-       continue;
 
-      name = debug_info->ssext + ext_in->asym.iss;
-      switch (ext_in->asym.st)
-       {
-       case stProc:
-         svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
-         break;
-       case stStaticProc:
-         ms_type = mst_file_text;
-         svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
-         break;
-       case stGlobal:
-          if (ext_in->asym.sc == scCommon || ext_in->asym.sc == scSCommon)
-           {
-             /* The value of a common symbol is its size, not its address.
-                Ignore it.  */
+       if (SC_IS_UNDEF(ext_in->asym.sc) || ext_in->asym.sc == scNil)
+         continue;
+
+    
+       /* Pass 3 over files, over local syms: fill in static symbols */
+       name = debug_info->ssext + ext_in->asym.iss;
+
+       /* Process ECOFF Symbol Types and Storage Classes */
+       switch (ext_in->asym.st)
+         {
+         case stProc:
+           /* Beginnning of Procedure */
+           svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
+           break;
+         case stStaticProc:
+           /* Load time only static procs */
+           ms_type = mst_file_text;
+           svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
+           break;
+         case stGlobal:
+           /* External symbol */
+           if (SC_IS_COMMON (ext_in->asym.sc))
+             {
+               /* The value of a common symbol is its size, not its address.
+                  Ignore it.  */
+               continue;
+             }
+           else if (SC_IS_DATA (ext_in->asym.sc))
+             {
+               ms_type = mst_data;
+               svalue += ANOFFSET (section_offsets, SECT_OFF_DATA);
+             }
+           else if (SC_IS_BSS (ext_in->asym.sc))
+             {
+               ms_type = mst_bss;
+               svalue += ANOFFSET (section_offsets, SECT_OFF_BSS);
+             }
+           else
+             ms_type = mst_abs;
+           break;
+         case stLabel:
+           /* Label */
+           if (SC_IS_TEXT (ext_in->asym.sc))
+             {
+               ms_type = mst_file_text;
+               svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
+             }
+           else if (SC_IS_DATA (ext_in->asym.sc))
+             {
+               ms_type = mst_file_data;
+               svalue += ANOFFSET (section_offsets, SECT_OFF_DATA);
+             }
+           else if (SC_IS_BSS (ext_in->asym.sc))
+             {
+               ms_type = mst_file_bss;
+               svalue += ANOFFSET (section_offsets, SECT_OFF_BSS);
+             }
+           else
+             ms_type = mst_abs;
+           break;
+         case stLocal:
+         case stNil:
+           /* The alpha has the section start addresses in stLocal symbols
+                whose name starts with a `.'. Skip those but complain for all
+                other stLocal symbols.
+                Irix6 puts the section start addresses in stNil symbols, skip
+                those too.*/
+           if (name[0] == '.')
              continue;
-           }
-          else if (ext_in->asym.sc == scData
-             || ext_in->asym.sc == scSData
-             || ext_in->asym.sc == scRData
-             || ext_in->asym.sc == scPData
-             || ext_in->asym.sc == scXData)
-           {
-             ms_type = mst_data;
-             svalue += ANOFFSET (section_offsets, SECT_OFF_DATA);
-           }
-         else
-           {
-             ms_type = mst_bss;
-             svalue += ANOFFSET (section_offsets, SECT_OFF_BSS);
-           }
-         break;
-       case stLabel:
-          if (ext_in->asym.sc == scAbs)
-           ms_type = mst_abs;
-          else if (ext_in->asym.sc == scText
-                  || ext_in->asym.sc == scInit
-                  || ext_in->asym.sc == scFini)
-           {
-             ms_type = mst_file_text;
-             svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
-           }
-          else if (ext_in->asym.sc == scData
-                  || ext_in->asym.sc == scSData
-                  || ext_in->asym.sc == scRData
-                  || ext_in->asym.sc == scPData
-                  || ext_in->asym.sc == scXData)
-           {
-             ms_type = mst_file_data;
-             svalue += ANOFFSET (section_offsets, SECT_OFF_DATA);
-           }
-         else
-           {
-             ms_type = mst_file_bss;
-             svalue += ANOFFSET (section_offsets, SECT_OFF_BSS);
-           }
-         break;
-       case stLocal:
-         /* The alpha has the section start addresses in stLocal symbols
-            whose name starts with a `.'. Skip those but complain for all
-            other stLocal symbols.  */
-         if (name[0] == '.')
-           continue;
-         /* Fall through.  */
-       default:
-         ms_type = mst_unknown;
-         complain (&unknown_ext_complaint, name);
-       }
-      prim_record_minimal_symbol (name, svalue, ms_type, objfile);
-    }
+           /* Fall through.  */
+         default:
+           ms_type = mst_unknown;
+           complain (&unknown_ext_complaint, name);
+         }
+        if (!ECOFF_IN_ELF(cur_bfd))
+         prim_record_minimal_symbol (name, svalue, ms_type, objfile);
+      }
 
   /* Pass 3 over files, over local syms: fill in static symbols */
   for (f_idx = 0; f_idx < hdr->ifdMax; f_idx++)
@@ -2532,7 +2646,7 @@ parse_partial_symbols (objfile, section_offsets)
                {
                  if (sh.st == stProc || sh.st == stStaticProc)
                    {
-                     long procaddr;
+                     CORE_ADDR procaddr;
                      long isym;
        
                      sh.value += ANOFFSET (section_offsets, SECT_OFF_TEXT);
@@ -2544,6 +2658,7 @@ parse_partial_symbols (objfile, section_offsets)
                                                               mst_file_text,
                                                               NULL,
                                                               SECT_OFF_TEXT,
+                                                              NULL,
                                                               objfile);
                        }
                      procaddr = sh.value;
@@ -2559,7 +2674,7 @@ parse_partial_symbols (objfile, section_offsets)
                                      &sh);
                      if (sh.st == stEnd)
                        {
-                         long high = procaddr + sh.value;
+                         CORE_ADDR high = procaddr + sh.value;
 
                          /* Kludge for Irix 5.2 zero fh->adr.  */
                          if (!relocatable
@@ -2574,6 +2689,7 @@ parse_partial_symbols (objfile, section_offsets)
                      switch (sh.sc)
                        {
                        case scUndefined:
+                       case scSUndefined:
                        case scNil:
                        case scAbs:
                          break;
@@ -2590,10 +2706,13 @@ parse_partial_symbols (objfile, section_offsets)
                                                               mst_file_data,
                                                               NULL,
                                                               SECT_OFF_DATA,
+                                                              NULL,
                                                               objfile);
                          break;
 
                        default:
+                         /* FIXME!  Shouldn't this use cases for bss, 
+                            then have the default be abs? */
                          namestring = debug_info->ss + fh->issBase + sh.iss;
                          sh.value += ANOFFSET (section_offsets, SECT_OFF_BSS);
                          prim_record_minimal_symbol_and_info (namestring,
@@ -2601,22 +2720,64 @@ parse_partial_symbols (objfile, section_offsets)
                                                               mst_file_bss,
                                                               NULL,
                                                               SECT_OFF_BSS,
+                                                              NULL,
                                                               objfile);
                          break;
                        }
                    }
                  continue;
                }
+             /* Handle stabs continuation */
+             {
+               char *stabstring = debug_info->ss + fh->issBase + sh.iss;
+               int len = strlen (stabstring);
+               while (stabstring[len-1] == '\\')
+                 {
+                   SYMR sh2;
+                   char *stabstring1 = stabstring;
+                   char *stabstring2;
+                   int len2;
+
+                   /* Ignore continuation char from 1st string */
+                   len--;
+
+                   /* Read next stabstring */
+                   cur_sdx++;
+                   (*swap_sym_in) (cur_bfd,
+                                   (((char *) debug_info->external_sym)
+                                    + (fh->isymBase + cur_sdx) 
+                                    * external_sym_size),
+                                   &sh2);
+                   stabstring2 = debug_info->ss + fh->issBase + sh2.iss;
+                   len2 = strlen (stabstring2);
+
+                   /* Concatinate stabstring2 with stabstring1 */
+                   if (stabstring
+                       && stabstring != debug_info->ss + fh->issBase + sh.iss)
+                     stabstring = xrealloc (stabstring, len + len2 + 1);
+                   else
+                     stabstring = xmalloc (len + len2 + 1);
+                   strcpy (stabstring, stabstring1);
+                   strcpy (stabstring + len, stabstring2);
+                   len += len2;
+                 }
+
 #define SET_NAMESTRING() \
-  namestring = debug_info->ss + fh->issBase + sh.iss
+  namestring = stabstring
 #define CUR_SYMBOL_TYPE type_code
 #define CUR_SYMBOL_VALUE sh.value
 #define START_PSYMTAB(ofile,secoff,fname,low,symoff,global_syms,static_syms)\
   pst = save_pst
-#define END_PSYMTAB(pst,ilist,ninc,c_off,c_text,dep_list,n_deps) (void)0
+#define END_PSYMTAB(pst,ilist,ninc,c_off,c_text,dep_list,n_deps,textlow_not_set) (void)0
 #define HANDLE_RBRAC(val) \
   if ((val) > save_pst->texthigh) save_pst->texthigh = (val);
 #include "partial-stab.h"
+
+               if (stabstring 
+                   && stabstring != debug_info->ss + fh->issBase + sh.iss)
+                 free (stabstring);
+             }
+           /* end - Handle continuation */
            }
        }
       else
@@ -2639,7 +2800,7 @@ parse_partial_symbols (objfile, section_offsets)
                }
 
              /* Non absolute static symbols go into the minimal table.  */
-             if (sh.sc == scUndefined || sh.sc == scNil
+             if (SC_IS_UNDEF(sh.sc) || sh.sc == scNil
                  || (sh.index == indexNil
                      && (sh.st != stStatic || sh.sc == scAbs)))
                {
@@ -2653,6 +2814,7 @@ parse_partial_symbols (objfile, section_offsets)
              switch (sh.sc)
                {
                case scText:
+               case scRConst:
                  /* The value of a stEnd symbol is the displacement from the
                     corresponding start symbol value, do not relocate it.  */
                  if (sh.st != stEnd)
@@ -2673,14 +2835,15 @@ parse_partial_symbols (objfile, section_offsets)
 
              switch (sh.st)
                {
-                 long high;
-                 long procaddr;
+                 CORE_ADDR high;
+                 CORE_ADDR procaddr;
                  int new_sdx;
 
                case stStaticProc:
                  prim_record_minimal_symbol_and_info (name, sh.value,
                                                       mst_file_text, NULL,
-                                                      SECT_OFF_TEXT, objfile);
+                                                      SECT_OFF_TEXT, NULL,
+                                                      objfile);
 
                  /* FALLTHROUGH */
 
@@ -2700,12 +2863,12 @@ parse_partial_symbols (objfile, section_offsets)
                    add_psymbol_to_list (name, strlen (name),
                                         VAR_NAMESPACE, LOC_BLOCK,
                                         &objfile->global_psymbols,
-                                        sh.value, 0, psymtab_language, objfile);
+                                        0, sh.value, psymtab_language, objfile);
                  else
                    add_psymbol_to_list (name, strlen (name),
                                         VAR_NAMESPACE, LOC_BLOCK,
                                         &objfile->static_psymbols,
-                                        sh.value, 0, psymtab_language, objfile);
+                                        0, sh.value, psymtab_language, objfile);
 
                  /* Skip over procedure to next one. */
                  if (sh.index >= hdr->iauxMax)
@@ -2749,19 +2912,17 @@ parse_partial_symbols (objfile, section_offsets)
                  continue;
 
                case stStatic:  /* Variable */
-                 if (sh.sc == scData
-                     || sh.sc == scSData
-                     || sh.sc == scRData
-                     || sh.sc == scPData
-                     || sh.sc == scXData)
+                 if (SC_IS_DATA (sh.sc))
                    prim_record_minimal_symbol_and_info (name, sh.value,
                                                         mst_file_data, NULL,
                                                         SECT_OFF_DATA,
+                                                        NULL,
                                                         objfile);
                  else
                    prim_record_minimal_symbol_and_info (name, sh.value,
                                                         mst_file_bss, NULL,
                                                         SECT_OFF_BSS,
+                                                        NULL,
                                                         objfile);
                  class = LOC_STATIC;
                  break;
@@ -2789,14 +2950,14 @@ parse_partial_symbols (objfile, section_offsets)
                  /* Do not create a partial symbol for cc unnamed aggregates
                     and gcc empty aggregates. */
                  if ((sh.sc == scInfo
-                      || sh.sc == scCommon || sh.sc == scSCommon)
+                      || SC_IS_COMMON(sh.sc))
                      && sh.iss != 0
                      && sh.index != cur_sdx + 2)
                    {
                      add_psymbol_to_list (name, strlen (name),
                                           STRUCT_NAMESPACE, LOC_TYPEDEF,
                                           &objfile->static_psymbols,
-                                          sh.value, 0,
+                                          0, (CORE_ADDR) 0,
                                           psymtab_language, objfile);
                    }
                  handle_psymbol_enumerators (objfile, fh, sh.st, sh.value);
@@ -2834,8 +2995,8 @@ parse_partial_symbols (objfile, section_offsets)
              /* Use this gdb symbol */
              add_psymbol_to_list (name, strlen (name),
                                   VAR_NAMESPACE, class,
-                                  &objfile->static_psymbols, sh.value,
-                                  0, psymtab_language, objfile);
+                                  &objfile->static_psymbols,
+                                  0, sh.value, psymtab_language, objfile);
            skip:
              cur_sdx++;        /* Go to next file symbol */
            }
@@ -2857,13 +3018,14 @@ parse_partial_symbols (objfile, section_offsets)
              psh = &ext_ptr->asym;
 
              /* Do not add undefined symbols to the partial symbol table.  */
-             if (psh->sc == scUndefined || psh->sc == scNil)
+             if (SC_IS_UNDEF(psh->sc) || psh->sc == scNil)
                continue;
 
              svalue = psh->value;
              switch (psh->sc)
                {
                case scText:
+               case scRConst:
                  svalue += ANOFFSET (section_offsets, SECT_OFF_TEXT);
                  break;
                case scData:
@@ -2901,7 +3063,7 @@ parse_partial_symbols (objfile, section_offsets)
                case stGlobal:
                  /* Global common symbols are resolved by the runtime loader,
                     ignore them.  */
-                 if (psh->sc == scCommon || psh->sc == scSCommon)
+                 if (SC_IS_COMMON(psh->sc))
                    continue;
 
                  class = LOC_STATIC;
@@ -2921,7 +3083,7 @@ parse_partial_symbols (objfile, section_offsets)
       fdr_to_pst[f_idx].pst = end_psymtab (save_pst,
                                           psymtab_include_list, includes_used,
                                           -1, save_pst->texthigh,
-                                          dependency_list, dependencies_used);
+                                          dependency_list, dependencies_used, textlow_not_set);
       includes_used = 0;
       dependencies_used = 0;
 
@@ -3046,7 +3208,9 @@ handle_psymbol_enumerators (objfile, fh, stype, svalue)
         and its auxiliary index is indexNil or its auxiliary entry
         is a plain btNil or btVoid.
         Alpha cc -migrate enums are recognized by a zero index and
-        a zero symbol value.  */
+        a zero symbol value.
+        DU 4.0 cc enums are recognized by a member type of btEnum without
+        qualifiers and a zero symbol value.  */
       (*swap_sym_in) (cur_bfd, ext_sym, &sh);
       if (sh.st != stMember)
        return;
@@ -3058,7 +3222,10 @@ handle_psymbol_enumerators (objfile, fh, stype, svalue)
                                  &(debug_info->external_aux
                                    + fh->iauxBase + sh.index)->a_ti,
                                  &tir);
-      if ((tir.bt != btNil && tir.bt != btVoid) || tir.tq0 != tqNil)
+      if ((tir.bt != btNil
+          && tir.bt != btVoid
+          && (tir.bt != btEnum || svalue != 0))
+         || tir.tq0 != tqNil)
        return;
       break;
 
@@ -3080,7 +3247,7 @@ handle_psymbol_enumerators (objfile, fh, stype, svalue)
       add_psymbol_to_list (name, strlen (name),
                           VAR_NAMESPACE, LOC_CONST,
                           &objfile->static_psymbols, 0,
-                          0, psymtab_language, objfile);
+                          (CORE_ADDR) 0, psymtab_language, objfile);
       ext_sym += external_sym_size;
     }
 }
@@ -3219,7 +3386,8 @@ psymtab_to_symtab_1 (pst, filename)
                          &sh);
          name = debug_info->ss + fh->issBase + sh.iss;
          valu = sh.value;
-         if (ECOFF_IS_STAB (&sh))
+         /* XXX This is a hack.  It will go away!  */
+         if (ECOFF_IS_STAB (&sh) || (name[0] == '#'))
            {
              int type_code = ECOFF_UNMARK_STAB (sh.index);
 
@@ -3231,6 +3399,12 @@ psymtab_to_symtab_1 (pst, filename)
                  process_one_symbol (type_code, 0, valu, name,
                                      pst->section_offsets, pst->objfile);
                }
+             /* Similarly a hack.  */
+             else if (name[0] == '#')
+               {
+                 process_one_symbol (N_SLINE, 0, valu, name,
+                                     pst->section_offsets, pst->objfile);
+               }
              if (type_code == N_FUN)
                {
                  /* Make up special symbol to contain
@@ -3319,7 +3493,7 @@ psymtab_to_symtab_1 (pst, filename)
          pdr_in = pr_block;
          pdr_in_end = pdr_in + fh->cpd;
          for (; pdr_in < pdr_in_end; pdr_in++)
-           parse_procedure (pdr_in, st, lowest_pdr_addr, pst);
+           parse_procedure (pdr_in, st, pst);
 
          do_cleanups (old_chain);
        }
@@ -3433,7 +3607,7 @@ psymtab_to_symtab_1 (pst, filename)
              pdr_in = pr_block;
              pdr_in_end = pdr_in + fh->cpd;
              for (; pdr_in < pdr_in_end; pdr_in++)
-               parse_procedure (pdr_in, 0, lowest_pdr_addr, pst);
+               parse_procedure (pdr_in, 0, pst);
 
              do_cleanups (old_chain);
            }
@@ -3607,7 +3781,7 @@ cross_ref (fd, ax, tpp, type_code, pname, bigend, sym_name)
        || (sh.st != stBlock && sh.st != stTypedef && sh.st != stIndirect
           && sh.st != stStruct && sh.st != stUnion
           && sh.st != stEnum))
-      && (sh.st != stBlock || (sh.sc != scCommon && sh.sc != scSCommon)))
+      && (sh.st != stBlock || !SC_IS_COMMON(sh.sc)))
     {
       /* File indirect entry is corrupt.  */
       *pname = "<illegal>";
@@ -3946,7 +4120,8 @@ new_symtab (name, maxsyms, maxlines, objfile)
     BLOCKVECTOR_BLOCK (BLOCKVECTOR (s), GLOBAL_BLOCK);
 
   s->free_code = free_linetable;
-
+  s->debugformat = obsavestring ("ECOFF", 5,
+                                &objfile -> symbol_obstack);
   return (s);
 }
 
@@ -4083,7 +4258,8 @@ new_symbol (name)
                                     sizeof (struct symbol)));
 
   memset ((PTR) s, 0, sizeof (*s));
-  SYMBOL_NAME (s) = name;
+  SYMBOL_NAME (s) = obsavestring (name, strlen (name),
+                                 &current_objfile->symbol_obstack);
   SYMBOL_LANGUAGE (s) = psymtab_language;
   SYMBOL_INIT_DEMANGLED_NAME (s, &current_objfile->symbol_obstack);
   return s;
@@ -4142,7 +4318,10 @@ elfmdebug_build_psymtabs (objfile, swap, sec, section_offsets)
 
 /* FIXME: This function is called only by mips-tdep.c.  It needs to be
    here because it calls functions defined in this file, but perhaps
-   this could be handled in a better way.  */
+   this could be handled in a better way.  Only compile it in when
+   tm-mips.h is included. */
+
+#ifdef TM_MIPS_H
 
 void
 fixup_sigtramp ()
@@ -4244,6 +4423,8 @@ fixup_sigtramp ()
   BLOCK_SYM (b, BLOCK_NSYMS (b)++) = s;
 }
 
+#endif /* TM_MIPS_H */
+
 void
 _initialize_mdebugread ()
 {
This page took 0.050198 seconds and 4 git commands to generate.