/* Memory attributes support, for GDB.
- Copyright (C) 2001-2013 Free Software Foundation, Inc.
+ Copyright (C) 2001-2020 Free Software Foundation, Inc.
This file is part of GDB.
#include "gdbcmd.h"
#include "memattr.h"
#include "target.h"
+#include "target-dcache.h"
#include "value.h"
#include "language.h"
-#include "vec.h"
-#include <string.h>
#include "breakpoint.h"
#include "cli/cli-utils.h"
+#include <algorithm>
+#include "gdbarch.h"
-const struct mem_attrib default_mem_attrib =
-{
- MEM_RW, /* mode */
- MEM_WIDTH_UNSPECIFIED,
- 0, /* hwbreak */
- 0, /* cache */
- 0, /* verify */
- -1 /* Flash blocksize not specified. */
-};
-
-const struct mem_attrib unknown_mem_attrib =
-{
- MEM_NONE, /* mode */
- MEM_WIDTH_UNSPECIFIED,
- 0, /* hwbreak */
- 0, /* cache */
- 0, /* verify */
- -1 /* Flash blocksize not specified. */
-};
-
-
-VEC(mem_region_s) *mem_region_list, *target_mem_region_list;
+static std::vector<mem_region> user_mem_region_list, target_mem_region_list;
+static std::vector<mem_region> *mem_region_list = &target_mem_region_list;
static int mem_number = 0;
/* If this flag is set, the memory region list should be automatically
updated from the target. If it is clear, the list is user-controlled
and should be left alone. */
-static int mem_use_target = 1;
+
+static bool
+mem_use_target ()
+{
+ return mem_region_list == &target_mem_region_list;
+}
/* If this flag is set, we have tried to fetch the target memory regions
since the last time it was invalidated. If that list is still
empty, then the target can't supply memory regions. */
-static int target_mem_regions_valid;
+static bool target_mem_regions_valid;
/* If this flag is set, gdb will assume that memory ranges not
specified by the memory map have type MEM_NONE, and will
emit errors on all accesses to that memory. */
-static int inaccessible_by_default = 1;
+static bool inaccessible_by_default = true;
static void
show_inaccessible_by_default (struct ui_file *file, int from_tty,
"will be treated as RAM.\n"));
}
-
-/* Predicate function which returns true if LHS should sort before RHS
- in a list of memory regions, useful for VEC_lower_bound. */
-
-static int
-mem_region_lessthan (const struct mem_region *lhs,
- const struct mem_region *rhs)
-{
- return lhs->lo < rhs->lo;
-}
-
-/* A helper function suitable for qsort, used to sort a
- VEC(mem_region_s) by starting address. */
-
-int
-mem_region_cmp (const void *untyped_lhs, const void *untyped_rhs)
-{
- const struct mem_region *lhs = untyped_lhs;
- const struct mem_region *rhs = untyped_rhs;
-
- if (lhs->lo < rhs->lo)
- return -1;
- else if (lhs->lo == rhs->lo)
- return 0;
- else
- return 1;
-}
-
-/* Allocate a new memory region, with default settings. */
-
-void
-mem_region_init (struct mem_region *new)
-{
- memset (new, 0, sizeof (struct mem_region));
- new->enabled_p = 1;
- new->attrib = default_mem_attrib;
-}
-
/* This function should be called before any command which would
modify the memory region list. It will handle switching from
a target-provided list to a local list, if necessary. */
static void
require_user_regions (int from_tty)
{
- struct mem_region *m;
- int ix, length;
-
/* If we're already using a user-provided list, nothing to do. */
- if (!mem_use_target)
+ if (!mem_use_target ())
return;
/* Switch to a user-provided list (possibly a copy of the current
one). */
- mem_use_target = 0;
+ mem_region_list = &user_mem_region_list;
/* If we don't have a target-provided region list yet, then
no need to warn. */
- if (mem_region_list == NULL)
+ if (target_mem_region_list.empty ())
return;
/* Otherwise, let the user know how to get back. */
warning (_("Switching to manual control of memory regions; use "
"\"mem auto\" to fetch regions from the target again."));
- /* And create a new list for the user to modify. */
- length = VEC_length (mem_region_s, target_mem_region_list);
- mem_region_list = VEC_alloc (mem_region_s, length);
- for (ix = 0; VEC_iterate (mem_region_s, target_mem_region_list, ix, m); ix++)
- VEC_quick_push (mem_region_s, mem_region_list, m);
+ /* And create a new list (copy of the target-supplied regions) for the user
+ to modify. */
+ user_mem_region_list = target_mem_region_list;
}
/* This function should be called before any command which would
static void
require_target_regions (void)
{
- if (mem_use_target && !target_mem_regions_valid)
+ if (mem_use_target () && !target_mem_regions_valid)
{
- target_mem_regions_valid = 1;
+ target_mem_regions_valid = true;
target_mem_region_list = target_memory_map ();
- mem_region_list = target_mem_region_list;
}
}
+/* Create a new user-defined memory region. */
+
static void
-create_mem_region (CORE_ADDR lo, CORE_ADDR hi,
- const struct mem_attrib *attrib)
+create_user_mem_region (CORE_ADDR lo, CORE_ADDR hi,
+ const mem_attrib &attrib)
{
- struct mem_region new;
- int i, ix;
-
/* lo == hi is a useless empty region. */
if (lo >= hi && hi != 0)
{
return;
}
- mem_region_init (&new);
- new.lo = lo;
- new.hi = hi;
+ mem_region newobj (lo, hi, attrib);
- ix = VEC_lower_bound (mem_region_s, mem_region_list, &new,
- mem_region_lessthan);
+ auto it = std::lower_bound (user_mem_region_list.begin (),
+ user_mem_region_list.end (),
+ newobj);
+ int ix = std::distance (user_mem_region_list.begin (), it);
/* Check for an overlapping memory region. We only need to check
- in the vicinity - at most one before and one after the
+ in the vincinity - at most one before and one after the
insertion point. */
- for (i = ix - 1; i < ix + 1; i++)
+ for (int i = ix - 1; i < ix + 1; i++)
{
- struct mem_region *n;
-
if (i < 0)
continue;
- if (i >= VEC_length (mem_region_s, mem_region_list))
+ if (i >= user_mem_region_list.size ())
continue;
- n = VEC_index (mem_region_s, mem_region_list, i);
+ mem_region &n = user_mem_region_list[i];
- if ((lo >= n->lo && (lo < n->hi || n->hi == 0))
- || (hi > n->lo && (hi <= n->hi || n->hi == 0))
- || (lo <= n->lo && ((hi >= n->hi && n->hi != 0) || hi == 0)))
+ if ((lo >= n.lo && (lo < n.hi || n.hi == 0))
+ || (hi > n.lo && (hi <= n.hi || n.hi == 0))
+ || (lo <= n.lo && ((hi >= n.hi && n.hi != 0) || hi == 0)))
{
printf_unfiltered (_("overlapping memory region\n"));
return;
}
}
- new.number = ++mem_number;
- new.attrib = *attrib;
- VEC_safe_insert (mem_region_s, mem_region_list, ix, &new);
+ newobj.number = ++mem_number;
+ user_mem_region_list.insert (it, newobj);
}
-/*
- * Look up the memory region cooresponding to ADDR.
- */
+/* Look up the memory region corresponding to ADDR. */
+
struct mem_region *
lookup_mem_region (CORE_ADDR addr)
{
- static struct mem_region region;
- struct mem_region *m;
+ static struct mem_region region (0, 0);
CORE_ADDR lo;
CORE_ADDR hi;
- int ix;
require_target_regions ();
lo = 0;
hi = 0;
- /* Either find memory range containing ADDRESS, or set LO and HI
+ /* Either find memory range containing ADDR, or set LO and HI
to the nearest boundaries of an existing memory range.
If we ever want to support a huge list of memory regions, this
check should be replaced with a binary search (probably using
VEC_lower_bound). */
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
+ for (mem_region &m : *mem_region_list)
{
- if (m->enabled_p == 1)
+ if (m.enabled_p == 1)
{
/* If the address is in the memory region, return that
memory range. */
- if (addr >= m->lo && (addr < m->hi || m->hi == 0))
- return m;
+ if (addr >= m.lo && (addr < m.hi || m.hi == 0))
+ return &m;
/* This (correctly) won't match if m->hi == 0, representing
the top of the address space, because CORE_ADDR is unsigned;
no value of LO is less than zero. */
- if (addr >= m->hi && lo < m->hi)
- lo = m->hi;
+ if (addr >= m.hi && lo < m.hi)
+ lo = m.hi;
/* This will never set HI to zero; if we're here and ADDR
is at or below M, and the region starts at zero, then ADDR
would have been in the region. */
- if (addr <= m->lo && (hi == 0 || hi > m->lo))
- hi = m->lo;
+ if (addr <= m.lo && (hi == 0 || hi > m.lo))
+ hi = m.lo;
}
}
/* When no memory map is defined at all, we always return
'default_mem_attrib', so that we do not make all memory
inaccessible for targets that don't provide a memory map. */
- if (inaccessible_by_default && !VEC_empty (mem_region_s, mem_region_list))
- region.attrib = unknown_mem_attrib;
+ if (inaccessible_by_default && !mem_region_list->empty ())
+ region.attrib = mem_attrib::unknown ();
else
- region.attrib = default_mem_attrib;
+ region.attrib = mem_attrib ();
return ®ion;
}
if (!target_mem_regions_valid)
return;
- target_mem_regions_valid = 0;
- VEC_free (mem_region_s, target_mem_region_list);
- if (mem_use_target)
- mem_region_list = NULL;
+ target_mem_regions_valid = false;
+ target_mem_region_list.clear ();
}
-/* Clear memory region list. */
+/* Clear user-defined memory region list. */
static void
-mem_clear (void)
+user_mem_clear (void)
{
- VEC_free (mem_region_s, mem_region_list);
+ user_mem_region_list.clear ();
}
\f
static void
-mem_command (char *args, int from_tty)
+mem_command (const char *args, int from_tty)
{
CORE_ADDR lo, hi;
- char *tok;
- struct mem_attrib attrib;
if (!args)
error_no_arg (_("No mem"));
/* For "mem auto", switch back to using a target provided list. */
if (strcmp (args, "auto") == 0)
{
- if (mem_use_target)
+ if (mem_use_target ())
return;
- if (mem_region_list != target_mem_region_list)
- {
- mem_clear ();
- mem_region_list = target_mem_region_list;
- }
+ user_mem_clear ();
+ mem_region_list = &target_mem_region_list;
- mem_use_target = 1;
return;
}
require_user_regions (from_tty);
- tok = strtok (args, " \t");
- if (!tok)
+ std::string tok = extract_arg (&args);
+ if (tok == "")
error (_("no lo address"));
- lo = parse_and_eval_address (tok);
+ lo = parse_and_eval_address (tok.c_str ());
- tok = strtok (NULL, " \t");
- if (!tok)
+ tok = extract_arg (&args);
+ if (tok == "")
error (_("no hi address"));
- hi = parse_and_eval_address (tok);
+ hi = parse_and_eval_address (tok.c_str ());
- attrib = default_mem_attrib;
- while ((tok = strtok (NULL, " \t")) != NULL)
+ mem_attrib attrib;
+ while ((tok = extract_arg (&args)) != "")
{
- if (strcmp (tok, "rw") == 0)
+ if (tok == "rw")
attrib.mode = MEM_RW;
- else if (strcmp (tok, "ro") == 0)
+ else if (tok == "ro")
attrib.mode = MEM_RO;
- else if (strcmp (tok, "wo") == 0)
+ else if (tok == "wo")
attrib.mode = MEM_WO;
- else if (strcmp (tok, "8") == 0)
+ else if (tok == "8")
attrib.width = MEM_WIDTH_8;
- else if (strcmp (tok, "16") == 0)
+ else if (tok == "16")
{
if ((lo % 2 != 0) || (hi % 2 != 0))
error (_("region bounds not 16 bit aligned"));
attrib.width = MEM_WIDTH_16;
}
- else if (strcmp (tok, "32") == 0)
+ else if (tok == "32")
{
if ((lo % 4 != 0) || (hi % 4 != 0))
error (_("region bounds not 32 bit aligned"));
attrib.width = MEM_WIDTH_32;
}
- else if (strcmp (tok, "64") == 0)
+ else if (tok == "64")
{
if ((lo % 8 != 0) || (hi % 8 != 0))
error (_("region bounds not 64 bit aligned"));
}
#if 0
- else if (strcmp (tok, "hwbreak") == 0)
+ else if (tok == "hwbreak")
attrib.hwbreak = 1;
- else if (strcmp (tok, "swbreak") == 0)
+ else if (tok == "swbreak")
attrib.hwbreak = 0;
#endif
- else if (strcmp (tok, "cache") == 0)
+ else if (tok == "cache")
attrib.cache = 1;
- else if (strcmp (tok, "nocache") == 0)
+ else if (tok == "nocache")
attrib.cache = 0;
#if 0
- else if (strcmp (tok, "verify") == 0)
+ else if (tok == "verify")
attrib.verify = 1;
- else if (strcmp (tok, "noverify") == 0)
+ else if (tok == "noverify")
attrib.verify = 0;
#endif
else
- error (_("unknown attribute: %s"), tok);
+ error (_("unknown attribute: %s"), tok.c_str ());
}
- create_mem_region (lo, hi, &attrib);
+ create_user_mem_region (lo, hi, attrib);
}
\f
static void
-mem_info_command (char *args, int from_tty)
+info_mem_command (const char *args, int from_tty)
{
- struct mem_region *m;
- struct mem_attrib *attrib;
- int ix;
-
- if (mem_use_target)
+ if (mem_use_target ())
printf_filtered (_("Using memory regions provided by the target.\n"));
else
printf_filtered (_("Using user-defined memory regions.\n"));
require_target_regions ();
- if (!mem_region_list)
+ if (mem_region_list->empty ())
{
printf_unfiltered (_("There are no memory regions defined.\n"));
return;
printf_filtered ("Attrs ");
printf_filtered ("\n");
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
+ for (const mem_region &m : *mem_region_list)
{
- char *tmp;
+ const char *tmp;
printf_filtered ("%-3d %-3c\t",
- m->number,
- m->enabled_p ? 'y' : 'n');
+ m.number,
+ m.enabled_p ? 'y' : 'n');
if (gdbarch_addr_bit (target_gdbarch ()) <= 32)
- tmp = hex_string_custom ((unsigned long) m->lo, 8);
+ tmp = hex_string_custom (m.lo, 8);
else
- tmp = hex_string_custom ((unsigned long) m->lo, 16);
+ tmp = hex_string_custom (m.lo, 16);
printf_filtered ("%s ", tmp);
if (gdbarch_addr_bit (target_gdbarch ()) <= 32)
{
- if (m->hi == 0)
+ if (m.hi == 0)
tmp = "0x100000000";
else
- tmp = hex_string_custom ((unsigned long) m->hi, 8);
+ tmp = hex_string_custom (m.hi, 8);
}
else
{
- if (m->hi == 0)
+ if (m.hi == 0)
tmp = "0x10000000000000000";
else
- tmp = hex_string_custom ((unsigned long) m->hi, 16);
+ tmp = hex_string_custom (m.hi, 16);
}
printf_filtered ("%s ", tmp);
* time, we may want to consider printing tokens only if they
* are different from the default attribute. */
- attrib = &m->attrib;
- switch (attrib->mode)
+ switch (m.attrib.mode)
{
case MEM_RW:
printf_filtered ("rw ");
printf_filtered ("wo ");
break;
case MEM_FLASH:
- printf_filtered ("flash blocksize 0x%x ", attrib->blocksize);
+ printf_filtered ("flash blocksize 0x%x ", m.attrib.blocksize);
break;
}
- switch (attrib->width)
+ switch (m.attrib.width)
{
case MEM_WIDTH_8:
printf_filtered ("8 ");
printf_filtered ("swbreak");
#endif
- if (attrib->cache)
+ if (m.attrib.cache)
printf_filtered ("cache ");
else
printf_filtered ("nocache ");
#endif
printf_filtered ("\n");
-
- gdb_flush (gdb_stdout);
}
}
\f
static void
mem_enable (int num)
{
- struct mem_region *m;
- int ix;
-
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
- if (m->number == num)
+ for (mem_region &m : *mem_region_list)
+ if (m.number == num)
{
- m->enabled_p = 1;
+ m.enabled_p = 1;
return;
}
printf_unfiltered (_("No memory region number %d.\n"), num);
}
static void
-mem_enable_command (char *args, int from_tty)
+enable_mem_command (const char *args, int from_tty)
{
- int num;
- struct mem_region *m;
- int ix;
-
require_user_regions (from_tty);
target_dcache_invalidate ();
if (args == NULL || *args == '\0')
{ /* Enable all mem regions. */
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
- m->enabled_p = 1;
+ for (mem_region &m : *mem_region_list)
+ m.enabled_p = 1;
}
else
{
- struct get_number_or_range_state state;
-
- init_number_or_range (&state, args);
- while (!state.finished)
+ number_or_range_parser parser (args);
+ while (!parser.finished ())
{
- num = get_number_or_range (&state);
+ int num = parser.get_number ();
mem_enable (num);
}
}
static void
mem_disable (int num)
{
- struct mem_region *m;
- int ix;
-
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
- if (m->number == num)
+ for (mem_region &m : *mem_region_list)
+ if (m.number == num)
{
- m->enabled_p = 0;
+ m.enabled_p = 0;
return;
}
printf_unfiltered (_("No memory region number %d.\n"), num);
}
static void
-mem_disable_command (char *args, int from_tty)
+disable_mem_command (const char *args, int from_tty)
{
- int num;
- struct mem_region *m;
- int ix;
-
require_user_regions (from_tty);
target_dcache_invalidate ();
if (args == NULL || *args == '\0')
{
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
- m->enabled_p = 0;
+ for (mem_region &m : *mem_region_list)
+ m.enabled_p = false;
}
else
{
- struct get_number_or_range_state state;
-
- init_number_or_range (&state, args);
- while (!state.finished)
+ number_or_range_parser parser (args);
+ while (!parser.finished ())
{
- num = get_number_or_range (&state);
+ int num = parser.get_number ();
mem_disable (num);
}
}
static void
mem_delete (int num)
{
- struct mem_region *m;
- int ix;
-
if (!mem_region_list)
{
printf_unfiltered (_("No memory region number %d.\n"), num);
return;
}
- for (ix = 0; VEC_iterate (mem_region_s, mem_region_list, ix, m); ix++)
- if (m->number == num)
- break;
-
- if (m == NULL)
+ auto it = std::remove_if (mem_region_list->begin (), mem_region_list->end (),
+ [num] (const mem_region &m)
{
- printf_unfiltered (_("No memory region number %d.\n"), num);
- return;
- }
+ return m.number == num;
+ });
- VEC_ordered_remove (mem_region_s, mem_region_list, ix);
+ if (it != mem_region_list->end ())
+ mem_region_list->erase (it);
+ else
+ printf_unfiltered (_("No memory region number %d.\n"), num);
}
static void
-mem_delete_command (char *args, int from_tty)
+delete_mem_command (const char *args, int from_tty)
{
- int num;
- struct get_number_or_range_state state;
-
require_user_regions (from_tty);
target_dcache_invalidate ();
if (args == NULL || *args == '\0')
{
if (query (_("Delete all memory regions? ")))
- mem_clear ();
+ user_mem_clear ();
dont_repeat ();
return;
}
- init_number_or_range (&state, args);
- while (!state.finished)
+ number_or_range_parser parser (args);
+ while (!parser.finished ())
{
- num = get_number_or_range (&state);
+ int num = parser.get_number ();
mem_delete (num);
}
}
static void
-dummy_cmd (char *args, int from_tty)
+dummy_cmd (const char *args, int from_tty)
{
}
-\f
-extern initialize_file_ftype _initialize_mem; /* -Wmissing-prototype */
static struct cmd_list_element *mem_set_cmdlist;
static struct cmd_list_element *mem_show_cmdlist;
_initialize_mem (void)
{
add_com ("mem", class_vars, mem_command, _("\
-Define attributes for memory region or reset memory region handling to\n\
-target-based.\n\
+Define attributes for memory region or reset memory region handling to "
+"target-based.\n\
Usage: mem auto\n\
- mem <lo addr> <hi addr> [<mode> <width> <cache>],\n\
-where <mode> may be rw (read/write), ro (read-only) or wo (write-only),\n\
- <width> may be 8, 16, 32, or 64, and\n\
- <cache> may be cache or nocache"));
+ mem LOW HIGH [MODE WIDTH CACHE],\n\
+where MODE may be rw (read/write), ro (read-only) or wo (write-only),\n\
+ WIDTH may be 8, 16, 32, or 64, and\n\
+ CACHE may be cache or nocache"));
- add_cmd ("mem", class_vars, mem_enable_command, _("\
+ add_cmd ("mem", class_vars, enable_mem_command, _("\
Enable memory region.\n\
-Arguments are the code numbers of the memory regions to enable.\n\
-Usage: enable mem <code number>...\n\
-Do \"info mem\" to see current list of code numbers."), &enablelist);
+Arguments are the IDs of the memory regions to enable.\n\
+Usage: enable mem [ID]...\n\
+Do \"info mem\" to see current list of IDs."), &enablelist);
- add_cmd ("mem", class_vars, mem_disable_command, _("\
+ add_cmd ("mem", class_vars, disable_mem_command, _("\
Disable memory region.\n\
-Arguments are the code numbers of the memory regions to disable.\n\
-Usage: disable mem <code number>...\n\
-Do \"info mem\" to see current list of code numbers."), &disablelist);
+Arguments are the IDs of the memory regions to disable.\n\
+Usage: disable mem [ID]...\n\
+Do \"info mem\" to see current list of IDs."), &disablelist);
- add_cmd ("mem", class_vars, mem_delete_command, _("\
+ add_cmd ("mem", class_vars, delete_mem_command, _("\
Delete memory region.\n\
-Arguments are the code numbers of the memory regions to delete.\n\
-Usage: delete mem <code number>...\n\
-Do \"info mem\" to see current list of code numbers."), &deletelist);
+Arguments are the IDs of the memory regions to delete.\n\
+Usage: delete mem [ID]...\n\
+Do \"info mem\" to see current list of IDs."), &deletelist);
- add_info ("mem", mem_info_command,
- _("Memory region attributes"));
+ add_info ("mem", info_mem_command,
+ _("Memory region attributes."));
add_prefix_cmd ("mem", class_vars, dummy_cmd, _("\
-Memory regions settings"),
+Memory regions settings."),
&mem_set_cmdlist, "set mem ",
0/* allow-unknown */, &setlist);
add_prefix_cmd ("mem", class_vars, dummy_cmd, _("\
-Memory regions settings"),
+Memory regions settings."),
&mem_show_cmdlist, "show mem ",
0/* allow-unknown */, &showlist);