/* Python pretty-printing
- Copyright (C) 2008-2017 Free Software Foundation, Inc.
+ Copyright (C) 2008-2019 Free Software Foundation, Inc.
This file is part of GDB.
will return None. On error, it will set the Python error and
return NULL. */
-static PyObject *
+static gdbpy_ref<>
search_pp_list (PyObject *list, PyObject *value)
{
Py_ssize_t pp_list_size, list_index;
/* Skip if disabled. */
if (PyObject_HasAttr (function, gdbpy_enabled_cst))
{
- gdbpy_ref attr (PyObject_GetAttr (function, gdbpy_enabled_cst));
+ gdbpy_ref<> attr (PyObject_GetAttr (function, gdbpy_enabled_cst));
int cmp;
if (attr == NULL)
continue;
}
- gdbpy_ref printer (PyObject_CallFunctionObjArgs (function, value, NULL));
+ gdbpy_ref<> printer (PyObject_CallFunctionObjArgs (function, value,
+ NULL));
if (printer == NULL)
return NULL;
else if (printer != Py_None)
- return printer.release ();
+ return printer;
}
- Py_RETURN_NONE;
+ return gdbpy_ref<>::new_reference (Py_None);
}
/* Subroutine of find_pretty_printer to simplify it.
ALL_OBJFILES (obj)
{
- PyObject *objf = objfile_to_objfile_object (obj);
- if (!objf)
+ gdbpy_ref<> objf = objfile_to_objfile_object (obj);
+ if (objf == NULL)
{
/* Ignore the error and continue. */
PyErr_Clear ();
continue;
}
- gdbpy_ref pp_list (objfpy_get_printers (objf, NULL));
- gdbpy_ref function (search_pp_list (pp_list.get (), value));
+ gdbpy_ref<> pp_list (objfpy_get_printers (objf.get (), NULL));
+ gdbpy_ref<> function (search_pp_list (pp_list.get (), value));
/* If there is an error in any objfile list, abort the search and exit. */
if (function == NULL)
The result is Py_None, suitably inc-ref'd, if no pretty-printer was found.
Otherwise the result is the pretty-printer function, suitably inc-ref'd. */
-static PyObject *
+static gdbpy_ref<>
find_pretty_printer_from_progspace (PyObject *value)
{
- PyObject *obj = pspace_to_pspace_object (current_program_space);
+ gdbpy_ref<> obj = pspace_to_pspace_object (current_program_space);
- if (!obj)
+ if (obj == NULL)
return NULL;
- gdbpy_ref pp_list (pspy_get_printers (obj, NULL));
+ gdbpy_ref<> pp_list (pspy_get_printers (obj.get (), NULL));
return search_pp_list (pp_list.get (), value);
}
The result is Py_None, suitably inc-ref'd, if no pretty-printer was found.
Otherwise the result is the pretty-printer function, suitably inc-ref'd. */
-static PyObject *
+static gdbpy_ref<>
find_pretty_printer_from_gdb (PyObject *value)
{
/* Fetch the global pretty printer list. */
if (gdb_python_module == NULL
|| ! PyObject_HasAttrString (gdb_python_module, "pretty_printers"))
- Py_RETURN_NONE;
- gdbpy_ref pp_list (PyObject_GetAttrString (gdb_python_module,
- "pretty_printers"));
+ return gdbpy_ref<>::new_reference (Py_None);
+ gdbpy_ref<> pp_list (PyObject_GetAttrString (gdb_python_module,
+ "pretty_printers"));
if (pp_list == NULL || ! PyList_Check (pp_list.get ()))
- Py_RETURN_NONE;
+ return gdbpy_ref<>::new_reference (Py_None);
return search_pp_list (pp_list.get (), value);
}
pretty-printer exists, return None. If one exists, return a new
reference. On error, set the Python error and return NULL. */
-static PyObject *
+static gdbpy_ref<>
find_pretty_printer (PyObject *value)
{
/* Look at the pretty-printer list for each objfile
in the current program-space. */
- gdbpy_ref function (find_pretty_printer_from_objfiles (value));
+ gdbpy_ref<> function (find_pretty_printer_from_objfiles (value));
if (function == NULL || function != Py_None)
- return function.release ();
+ return function;
/* Look at the pretty-printer list for the current program-space. */
- function.reset (find_pretty_printer_from_progspace (value));
+ function = find_pretty_printer_from_progspace (value);
if (function == NULL || function != Py_None)
- return function.release ();
+ return function;
/* Look at the pretty-printer list in the gdb module. */
return find_pretty_printer_from_gdb (value);
is returned. On error, *OUT_VALUE is set to NULL, NULL is
returned, with a python exception set. */
-static PyObject *
+static gdbpy_ref<>
pretty_print_one_value (PyObject *printer, struct value **out_value)
{
- PyObject *result = NULL;
+ gdbpy_ref<> result;
*out_value = NULL;
TRY
{
- result = PyObject_CallMethodObjArgs (printer, gdbpy_to_string_cst, NULL);
- if (result)
+ if (!PyObject_HasAttr (printer, gdbpy_to_string_cst))
+ result = gdbpy_ref<>::new_reference (Py_None);
+ else
{
- if (! gdbpy_is_string (result) && ! gdbpy_is_lazy_string (result)
- && result != Py_None)
+ result.reset (PyObject_CallMethodObjArgs (printer, gdbpy_to_string_cst,
+ NULL));
+ if (result != NULL)
{
- *out_value = convert_value_from_python (result);
- if (PyErr_Occurred ())
- *out_value = NULL;
- Py_DECREF (result);
- result = NULL;
+ if (! gdbpy_is_string (result.get ())
+ && ! gdbpy_is_lazy_string (result.get ())
+ && result != Py_None)
+ {
+ *out_value = convert_value_from_python (result.get ());
+ if (PyErr_Occurred ())
+ *out_value = NULL;
+ result = NULL;
+ }
}
}
}
if (! PyObject_HasAttr (printer, gdbpy_display_hint_cst))
return NULL;
- gdbpy_ref hint (PyObject_CallMethodObjArgs (printer, gdbpy_display_hint_cst,
- NULL));
+ gdbpy_ref<> hint (PyObject_CallMethodObjArgs (printer, gdbpy_display_hint_cst,
+ NULL));
if (hint != NULL)
{
if (gdbpy_is_string (hint.get ()))
{
if (PyErr_ExceptionMatches (gdbpy_gdb_memory_error))
{
- struct cleanup *cleanup;
PyObject *type, *value, *trace;
PyErr_Fetch (&type, &value, &trace);
- cleanup = make_cleanup_py_decref (type);
- make_cleanup_py_decref (value);
- make_cleanup_py_decref (trace);
+
+ gdbpy_ref<> type_ref (type);
+ gdbpy_ref<> value_ref (value);
+ gdbpy_ref<> trace_ref (trace);
gdb::unique_xmalloc_ptr<char>
msg (gdbpy_exception_to_string (type, value));
else
fprintf_filtered (stream, _("<error reading variable: %s>"),
msg.get ());
-
- do_cleanups (cleanup);
}
else
gdbpy_print_stack ();
struct gdbarch *gdbarch)
{
struct value *replacement = NULL;
- PyObject *py_str = NULL;
enum string_repr_result result = string_repr_ok;
- py_str = pretty_print_one_value (printer, &replacement);
- if (py_str)
+ gdbpy_ref<> py_str = pretty_print_one_value (printer, &replacement);
+ if (py_str != NULL)
{
- struct cleanup *cleanup = make_cleanup_py_decref (py_str);
-
if (py_str == Py_None)
result = string_repr_none;
- else if (gdbpy_is_lazy_string (py_str))
+ else if (gdbpy_is_lazy_string (py_str.get ()))
{
CORE_ADDR addr;
long length;
gdb::unique_xmalloc_ptr<char> encoding;
struct value_print_options local_opts = *options;
- gdbpy_extract_lazy_string (py_str, &addr, &type,
+ gdbpy_extract_lazy_string (py_str.get (), &addr, &type,
&length, &encoding);
local_opts.addressprint = 0;
}
else
{
- PyObject *string;
-
- string = python_string_to_target_python_string (py_str);
- if (string)
+ gdbpy_ref<> string
+ = python_string_to_target_python_string (py_str.get ());
+ if (string != NULL)
{
char *output;
long length;
struct type *type;
- make_cleanup_py_decref (string);
#ifdef IS_PY3K
- output = PyBytes_AS_STRING (string);
- length = PyBytes_GET_SIZE (string);
+ output = PyBytes_AS_STRING (string.get ());
+ length = PyBytes_GET_SIZE (string.get ());
#else
- output = PyString_AsString (string);
- length = PyString_Size (string);
+ output = PyString_AsString (string.get ());
+ length = PyString_Size (string.get ());
#endif
type = builtin_type (gdbarch)->builtin_char;
print_stack_unless_memory_error (stream);
}
}
-
- do_cleanups (cleanup);
}
else if (replacement)
{
}
#ifndef IS_PY3K
-static void
-py_restore_tstate (void *p)
-{
- PyFrameObject *frame = (PyFrameObject *) p;
- PyThreadState *tstate = PyThreadState_GET ();
-
- tstate->frame = frame;
-}
/* Create a dummy PyFrameObject, needed to work around
a Python-2.4 bug with generators. */
-static PyObject *
-push_dummy_python_frame (void)
+class dummy_python_frame
{
- PyObject *empty_string, *null_tuple, *globals;
- PyCodeObject *code;
- PyFrameObject *frame;
- PyThreadState *tstate;
+ public:
- empty_string = PyString_FromString ("");
- if (!empty_string)
- return NULL;
+ dummy_python_frame ();
- null_tuple = PyTuple_New (0);
- if (!null_tuple)
- {
- Py_DECREF (empty_string);
- return NULL;
- }
+ ~dummy_python_frame ()
+ {
+ if (m_valid)
+ m_tstate->frame = m_saved_frame;
+ }
- code = PyCode_New (0, /* argcount */
- 0, /* nlocals */
- 0, /* stacksize */
- 0, /* flags */
- empty_string, /* code */
- null_tuple, /* consts */
- null_tuple, /* names */
- null_tuple, /* varnames */
-#if PYTHON_API_VERSION >= 1010
- null_tuple, /* freevars */
- null_tuple, /* cellvars */
-#endif
- empty_string, /* filename */
- empty_string, /* name */
- 1, /* firstlineno */
- empty_string /* lnotab */
- );
+ bool failed () const
+ {
+ return !m_valid;
+ }
- Py_DECREF (empty_string);
- Py_DECREF (null_tuple);
+ private:
- if (!code)
- return NULL;
+ bool m_valid;
+ PyFrameObject *m_saved_frame;
+ gdbpy_ref<> m_frame;
+ PyThreadState *m_tstate;
+};
- globals = PyDict_New ();
- if (!globals)
- {
- Py_DECREF (code);
- return NULL;
- }
+dummy_python_frame::dummy_python_frame ()
+: m_valid (false),
+ m_saved_frame (NULL),
+ m_tstate (NULL)
+{
+ PyCodeObject *code;
+ PyFrameObject *frame;
- tstate = PyThreadState_GET ();
+ gdbpy_ref<> empty_string (PyString_FromString (""));
+ if (empty_string == NULL)
+ return;
- frame = PyFrame_New (tstate, code, globals, NULL);
+ gdbpy_ref<> null_tuple (PyTuple_New (0));
+ if (null_tuple == NULL)
+ return;
- Py_DECREF (globals);
- Py_DECREF (code);
+ code = PyCode_New (0, /* argcount */
+ 0, /* locals */
+ 0, /* stacksize */
+ 0, /* flags */
+ empty_string.get (), /* code */
+ null_tuple.get (), /* consts */
+ null_tuple.get (), /* names */
+ null_tuple.get (), /* varnames */
+#if PYTHON_API_VERSION >= 1010
+ null_tuple.get (), /* freevars */
+ null_tuple.get (), /* cellvars */
+#endif
+ empty_string.get (), /* filename */
+ empty_string.get (), /* name */
+ 1, /* firstlineno */
+ empty_string.get () /* lnotab */
+ );
+ if (code == NULL)
+ return;
+ gdbpy_ref<> code_holder ((PyObject *) code);
- if (!frame)
- return NULL;
+ gdbpy_ref<> globals (PyDict_New ());
+ if (globals == NULL)
+ return;
+
+ m_tstate = PyThreadState_GET ();
+ frame = PyFrame_New (m_tstate, code, globals.get (), NULL);
+ if (frame == NULL)
+ return;
- tstate->frame = frame;
- make_cleanup (py_restore_tstate, frame->f_back);
- return (PyObject *) frame;
+ m_frame.reset ((PyObject *) frame);
+ m_tstate->frame = frame;
+ m_saved_frame = frame->f_back;
+ m_valid = true;
}
#endif
{
int is_map, is_array, done_flag, pretty;
unsigned int i;
- PyObject *children, *iter;
-#ifndef IS_PY3K
- PyObject *frame;
-#endif
- struct cleanup *cleanups;
if (! PyObject_HasAttr (printer, gdbpy_children_cst))
return;
is_map = hint && ! strcmp (hint, "map");
is_array = hint && ! strcmp (hint, "array");
- children = PyObject_CallMethodObjArgs (printer, gdbpy_children_cst,
- NULL);
- if (! children)
+ gdbpy_ref<> children (PyObject_CallMethodObjArgs (printer, gdbpy_children_cst,
+ NULL));
+ if (children == NULL)
{
print_stack_unless_memory_error (stream);
return;
}
- cleanups = make_cleanup_py_decref (children);
-
- iter = PyObject_GetIter (children);
- if (!iter)
+ gdbpy_ref<> iter (PyObject_GetIter (children.get ()));
+ if (iter == NULL)
{
print_stack_unless_memory_error (stream);
- goto done;
+ return;
}
- make_cleanup_py_decref (iter);
/* Use the prettyformat_arrays option if we are printing an array,
and the pretty option otherwise. */
where it insists on having a non-NULL tstate->frame when
a generator is called. */
#ifndef IS_PY3K
- frame = push_dummy_python_frame ();
- if (!frame)
+ dummy_python_frame frame;
+ if (frame.failed ())
{
gdbpy_print_stack ();
- goto done;
+ return;
}
- make_cleanup_py_decref (frame);
#endif
done_flag = 0;
for (i = 0; i < options->print_max; ++i)
{
- PyObject *py_v, *item = PyIter_Next (iter);
+ PyObject *py_v;
const char *name;
- struct cleanup *inner_cleanup;
- if (! item)
+ gdbpy_ref<> item (PyIter_Next (iter.get ()));
+ if (item == NULL)
{
if (PyErr_Occurred ())
print_stack_unless_memory_error (stream);
break;
}
- if (! PyTuple_Check (item) || PyTuple_Size (item) != 2)
+ if (! PyTuple_Check (item.get ()) || PyTuple_Size (item.get ()) != 2)
{
PyErr_SetString (PyExc_TypeError,
_("Result of children iterator not a tuple"
" of two elements."));
gdbpy_print_stack ();
- Py_DECREF (item);
continue;
}
- if (! PyArg_ParseTuple (item, "sO", &name, &py_v))
+ if (! PyArg_ParseTuple (item.get (), "sO", &name, &py_v))
{
/* The user won't necessarily get a stack trace here, so provide
more context. */
fprintf_unfiltered (gdb_stderr,
_("Bad result from children iterator.\n"));
gdbpy_print_stack ();
- Py_DECREF (item);
continue;
}
- inner_cleanup = make_cleanup_py_decref (item);
/* Print initial "{". For other elements, there are three
cases:
if (is_map && i % 2 == 0)
fputs_filtered ("] = ", stream);
-
- do_cleanups (inner_cleanup);
}
if (i)
}
fputs_filtered ("}", stream);
}
-
- done:
- do_cleanups (cleanups);
}
enum ext_lang_rc
struct gdbarch *gdbarch = get_type_arch (type);
struct value *value;
enum string_repr_result print_result;
- const gdb_byte *valaddr = value_contents_for_printing (val);
+
+ if (value_lazy (val))
+ value_fetch_lazy (val);
/* No pretty-printer support for unavailable values. */
if (!value_bytes_available (val, embedded_offset, TYPE_LENGTH (type)))
/* Instantiate the printer. */
value = value_from_component (val, type, embedded_offset);
- gdbpy_ref val_obj (value_to_value_object (value));
+ gdbpy_ref<> val_obj (value_to_value_object (value));
if (val_obj == NULL)
{
print_stack_unless_memory_error (stream);
}
/* Find the constructor. */
- gdbpy_ref printer (find_pretty_printer (val_obj.get ()));
+ gdbpy_ref<> printer (find_pretty_printer (val_obj.get ()));
if (printer == NULL)
{
print_stack_unless_memory_error (stream);
set to the replacement value and this function returns NULL. On
error, *REPLACEMENT is set to NULL and this function also returns
NULL. */
-PyObject *
+gdbpy_ref<>
apply_varobj_pretty_printer (PyObject *printer_obj,
struct value **replacement,
struct ui_file *stream)
{
- PyObject *py_str = NULL;
-
*replacement = NULL;
- py_str = pretty_print_one_value (printer_obj, replacement);
+ gdbpy_ref<> py_str = pretty_print_one_value (printer_obj, replacement);
if (*replacement == NULL && py_str == NULL)
print_stack_unless_memory_error (stream);
reference to the object if successful; returns NULL if not. VALUE
is the value for which a printer tests to determine if it
can pretty-print the value. */
-PyObject *
+gdbpy_ref<>
gdbpy_get_varobj_pretty_printer (struct value *value)
{
TRY
}
END_CATCH
- gdbpy_ref val_obj (value_to_value_object (value));
+ gdbpy_ref<> val_obj (value_to_value_object (value));
if (val_obj == NULL)
return NULL;
gdbpy_default_visualizer (PyObject *self, PyObject *args)
{
PyObject *val_obj;
- PyObject *cons;
struct value *value;
if (! PyArg_ParseTuple (args, "O", &val_obj))
return NULL;
}
- cons = find_pretty_printer (val_obj);
- return cons;
+ return find_pretty_printer (val_obj).release ();
}
projects / deliverable / binutils-gdb.git / blobdiff