Change inferior thread list to be a thread map
[deliverable/binutils-gdb.git] / gdb / tui / tui-win.c
index 8963da2b485469eb5e28995fd85d9d590995aef0..ac3690a7f456e90e15f5ca32872e0ad07a34e086 100644 (file)
 #include "breakpoint.h"
 #include "frame.h"
 #include "cli/cli-cmds.h"
+#include "cli/cli-style.h"
 #include "top.h"
 #include "source.h"
 #include "event-loop.h"
+#include "gdbcmd.h"
 
 #include "tui/tui.h"
 #include "tui/tui-io.h"
 #include "gdb_curses.h"
 #include <ctype.h>
 #include "readline/readline.h"
+#include "gdbsupport/gdb_string_view.h"
 
 #include <signal.h>
 
-/*******************************
-** Static Local Decls
-********************************/
-static enum tui_status tui_adjust_win_heights (struct tui_win_info *, 
-                                              int);
-static int new_height_ok (struct tui_win_info *, int);
 static void tui_set_tab_width_command (const char *, int);
 static void tui_refresh_all_command (const char *, int);
 static void tui_all_windows_info (const char *, int);
@@ -71,16 +68,9 @@ static void parse_scrolling_args (const char *,
                                  int *);
 
 
-/***************************************
-** DEFINITIONS
-***************************************/
 #define WIN_HEIGHT_USAGE    "Usage: winheight WINDOW-NAME [+ | -] NUM-LINES\n"
 #define FOCUS_USAGE         "Usage: focus [WINDOW-NAME | next | prev]\n"
 
-/***************************************
-** PUBLIC FUNCTIONS
-***************************************/
-
 #ifndef ACS_LRCORNER
 #  define ACS_LRCORNER '+'
 #endif
@@ -342,7 +332,8 @@ tui_get_cmd_list (void)
 
 /* The set_func hook of "set tui ..." commands that affect the window
    borders on the TUI display.  */
-void
+
+static void
 tui_set_var_cmd (const char *null_args,
                 int from_tty, struct cmd_list_element *c)
 {
@@ -350,6 +341,22 @@ tui_set_var_cmd (const char *null_args,
     tui_rehighlight_all ();
 }
 
+\f
+
+/* True if TUI resizes should print a message.  This is used by the
+   test suite.  */
+
+static bool resize_message;
+
+static void
+show_tui_resize_message (struct ui_file *file, int from_tty,
+                        struct cmd_list_element *c, const char *value)
+{
+  fprintf_filtered (file, _("TUI resize messaging is %s.\n"), value);
+}
+
+\f
+
 /* Generic window name completion function.  Complete window name pointed
    to by TEXT and WORD.  If INCLUDE_NEXT_PREV_P is true then the special
    window names 'next' and 'prev' will also be considered as possible
@@ -526,130 +533,28 @@ tui_resize_all (void)
   height_diff = screenheight - tui_term_height ();
   if (height_diff || width_diff)
     {
-      enum tui_layout_type cur_layout = tui_current_layout ();
       struct tui_win_info *win_with_focus = tui_win_with_focus ();
-      struct tui_win_info *first_win;
-      struct tui_win_info *second_win;
-      tui_source_window_base *src_win;
-      struct tui_locator_window *locator = tui_locator_win_info_ptr ();
-      int new_height, split_diff, cmd_split_diff, num_wins_displayed = 2;
 
 #ifdef HAVE_RESIZE_TERM
       resize_term (screenheight, screenwidth);
 #endif      
       /* Turn keypad off while we resize.  */
       if (win_with_focus != TUI_CMD_WIN)
-       keypad (TUI_CMD_WIN->handle, FALSE);
+       keypad (TUI_CMD_WIN->handle.get (), FALSE);
       tui_update_gdb_sizes ();
       tui_set_term_height_to (screenheight);
       tui_set_term_width_to (screenwidth);
-      if (cur_layout == SRC_DISASSEM_COMMAND 
-         || cur_layout == SRC_DATA_COMMAND
-         || cur_layout == DISASSEM_DATA_COMMAND)
-       num_wins_displayed++;
-      split_diff = height_diff / num_wins_displayed;
-      cmd_split_diff = split_diff;
-      if (height_diff % num_wins_displayed)
-       {
-         if (height_diff < 0)
-           cmd_split_diff--;
-         else
-           cmd_split_diff++;
-       }
-      /* Now adjust each window.  */
+
       /* erase + clearok are used instead of a straightforward clear as
          AIX 5.3 does not define clear.  */
       erase ();
       clearok (curscr, TRUE);
-      switch (cur_layout)
-       {
-       case SRC_COMMAND:
-       case DISASSEM_COMMAND:
-         src_win = *(tui_source_windows ().begin ());
-         /* Check for invalid heights.  */
-         if (height_diff == 0)
-           new_height = src_win->height;
-         else if ((src_win->height + split_diff) >=
-                  (screenheight - MIN_CMD_WIN_HEIGHT - 1))
-           new_height = screenheight - MIN_CMD_WIN_HEIGHT - 1;
-         else if ((src_win->height + split_diff) <= 0)
-           new_height = MIN_WIN_HEIGHT;
-         else
-           new_height = src_win->height + split_diff;
-
-         src_win->resize (new_height, screenwidth, 0, 0);
-
-         locator->resize (1, screenwidth, 0, new_height);
-
-         new_height = screenheight - (new_height + 1);
-         TUI_CMD_WIN->resize (new_height, screenwidth,
-                              0, locator->origin.y + 1);
-         break;
-       default:
-         if (cur_layout == SRC_DISASSEM_COMMAND)
-           {
-             src_win = TUI_SRC_WIN;
-             first_win = src_win;
-             second_win = TUI_DISASM_WIN;
-           }
-         else
-           {
-             first_win = TUI_DATA_WIN;
-             src_win = *(tui_source_windows ().begin ());
-             second_win = src_win;
-           }
-         /* Change the first window's height/width.  */
-         /* Check for invalid heights.  */
-         if (height_diff == 0)
-           new_height = first_win->height;
-         else if ((first_win->height +
-                   second_win->height + (split_diff * 2)) >=
-                  (screenheight - MIN_CMD_WIN_HEIGHT - 1))
-           new_height = (screenheight - MIN_CMD_WIN_HEIGHT - 1) / 2;
-         else if ((first_win->height + split_diff) <= 0)
-           new_height = MIN_WIN_HEIGHT;
-         else
-           new_height = first_win->height + split_diff;
-
-         first_win->resize (new_height, screenwidth, 0, 0);
-
-         /* Change the second window's height/width.  */
-         /* Check for invalid heights.  */
-         if (height_diff == 0)
-           new_height = second_win->height;
-         else if ((first_win->height +
-                   second_win->height + (split_diff * 2)) >=
-                  (screenheight - MIN_CMD_WIN_HEIGHT - 1))
-           {
-             new_height = screenheight - MIN_CMD_WIN_HEIGHT - 1;
-             if (new_height % 2)
-               new_height = (new_height / 2) + 1;
-             else
-               new_height /= 2;
-           }
-         else if ((second_win->height + split_diff) <= 0)
-           new_height = MIN_WIN_HEIGHT;
-         else
-           new_height = second_win->height + split_diff;
-
-         second_win->resize (new_height, screenwidth,
-                             0, first_win->height - 1);
-
-         locator->resize (1, screenwidth,
-                          0, second_win->origin.y + new_height);
-
-         /* Change the command window's height/width.  */
-         new_height = screenheight - (locator->origin.y + 1);
-         TUI_CMD_WIN->resize (new_height, screenwidth,
-                              0, locator->origin.y + 1);
-         break;
-       }
-
+      tui_apply_current_layout ();
       tui_delete_invisible_windows ();
       /* Turn keypad back on, unless focus is in the command
         window.  */
       if (win_with_focus != TUI_CMD_WIN)
-       keypad (TUI_CMD_WIN->handle, TRUE);
+       keypad (TUI_CMD_WIN->handle.get (), TRUE);
     }
 }
 
@@ -687,6 +592,13 @@ tui_async_resize_screen (gdb_client_data arg)
       tui_resize_all ();
       tui_refresh_all_win ();
       tui_update_gdb_sizes ();
+      if (resize_message)
+       {
+         static int count;
+         printf_unfiltered ("@@ resize done %d, size = %dx%d\n", count,
+                            tui_term_width (), tui_term_height ());
+         ++count;
+       }
       tui_redisplay_readline ();
     }
 }
@@ -720,11 +632,6 @@ tui_initialize_win (void)
 }
 
 
-/*************************
-** STATIC LOCAL FUNCTIONS
-**************************/
-
-
 static void
 tui_scroll_forward_command (const char *arg, int from_tty)
 {
@@ -783,6 +690,24 @@ tui_scroll_right_command (const char *arg, int from_tty)
 }
 
 
+/* Answer the window represented by name.  */
+static struct tui_win_info *
+tui_partial_win_by_name (gdb::string_view name)
+{
+  if (name != NULL)
+    {
+      for (tui_win_info *item : all_tui_windows ())
+       {
+         const char *cur_name = item->name ();
+
+         if (startswith (cur_name, name))
+           return item;
+       }
+    }
+
+  return NULL;
+}
+
 /* Set focus to the window named by 'arg'.  */
 static void
 tui_set_focus_command (const char *arg, int from_tty)
@@ -791,40 +716,38 @@ tui_set_focus_command (const char *arg, int from_tty)
 
   if (arg != NULL)
     {
-      char *buf_ptr = xstrdup (arg);
-      int i;
       struct tui_win_info *win_info = NULL;
 
-      for (i = 0; (i < strlen (buf_ptr)); i++)
-       buf_ptr[i] = tolower (arg[i]);
-
-      if (subset_compare (buf_ptr, "next"))
+      if (subset_compare (arg, "next"))
        win_info = tui_next_win (tui_win_with_focus ());
-      else if (subset_compare (buf_ptr, "prev"))
+      else if (subset_compare (arg, "prev"))
        win_info = tui_prev_win (tui_win_with_focus ());
       else
-       win_info = tui_partial_win_by_name (buf_ptr);
+       win_info = tui_partial_win_by_name (arg);
 
-      if (win_info == NULL || !win_info->is_visible ())
-       warning (_("Invalid window specified. \n\
-The window name specified must be valid and visible.\n"));
-      else
-       {
-         tui_set_win_focus_to (win_info);
-         keypad (TUI_CMD_WIN->handle, (win_info != TUI_CMD_WIN));
-       }
+      if (win_info == NULL)
+       error (_("Unrecognized window name \"%s\""), arg);
+      if (!win_info->is_visible ())
+       error (_("Window \"%s\" is not visible"), arg);
 
-      xfree (buf_ptr);
+      tui_set_win_focus_to (win_info);
+      keypad (TUI_CMD_WIN->handle.get (), win_info != TUI_CMD_WIN);
       printf_filtered (_("Focus set to %s window.\n"),
                       tui_win_with_focus ()->name ());
     }
   else
-    warning (_("Incorrect Number of Arguments.\n%s"), FOCUS_USAGE);
+    error (_("Incorrect Number of Arguments.\n%s"), FOCUS_USAGE);
 }
 
 static void
 tui_all_windows_info (const char *arg, int from_tty)
 {
+  if (!tui_active)
+    {
+      printf_filtered (_("The TUI is not active.\n"));
+      return;
+    }
+
   struct tui_win_info *win_with_focus = tui_win_with_focus ();
   struct ui_out *uiout = current_uiout;
 
@@ -906,6 +829,29 @@ tui_show_tab_width (struct ui_file *file, int from_tty,
 
 }
 
+/* See tui-win.h.  */
+
+bool compact_source = false;
+
+/* Callback for "set tui compact-source".  */
+
+static void
+tui_set_compact_source (const char *ignore, int from_tty,
+                       struct cmd_list_element *c)
+{
+  if (TUI_SRC_WIN != nullptr)
+    TUI_SRC_WIN->refill ();
+}
+
+/* Callback for "show tui compact-source".  */
+
+static void
+tui_show_compact_source (struct ui_file *file, int from_tty,
+                        struct cmd_list_element *c, const char *value)
+{
+  printf_filtered (_("TUI source window compactness is %s.\n"), value);
+}
+
 /* Set the tab width of the specified window.  */
 static void
 tui_set_tab_width_command (const char *arg, int from_tty)
@@ -938,240 +884,64 @@ tui_set_win_height_command (const char *arg, int from_tty)
   tui_enable ();
   if (arg != NULL)
     {
-      std::string copy = arg;
-      char *buf = &copy[0];
-      char *buf_ptr = buf;
-      char *wname = NULL;
-      int new_height, i;
+      const char *buf = arg;
+      const char *buf_ptr = buf;
+      int new_height;
       struct tui_win_info *win_info;
 
-      wname = buf_ptr;
       buf_ptr = strchr (buf_ptr, ' ');
       if (buf_ptr != NULL)
        {
-         *buf_ptr = (char) 0;
-
          /* Validate the window name.  */
-         for (i = 0; i < strlen (wname); i++)
-           wname[i] = tolower (wname[i]);
+         gdb::string_view wname (buf, buf_ptr - buf);
          win_info = tui_partial_win_by_name (wname);
 
-         if (win_info == NULL || !win_info->is_visible ())
-           warning (_("Invalid window specified. \n\
-The window name specified must be valid and visible.\n"));
-         else
-           {
-             /* Process the size.  */
-             while (*(++buf_ptr) == ' ')
-               ;
+         if (win_info == NULL)
+           error (_("Unrecognized window name \"%s\""), arg);
+         if (!win_info->is_visible ())
+           error (_("Window \"%s\" is not visible"), arg);
 
-             if (*buf_ptr != (char) 0)
-               {
-                 int negate = FALSE;
-                 int fixed_size = TRUE;
-                 int input_no;;
-
-                 if (*buf_ptr == '+' || *buf_ptr == '-')
-                   {
-                     if (*buf_ptr == '-')
-                       negate = TRUE;
-                     fixed_size = FALSE;
-                     buf_ptr++;
-                   }
-                 input_no = atoi (buf_ptr);
-                 if (input_no > 0)
-                   {
-                     if (negate)
-                       input_no *= (-1);
-                     if (fixed_size)
-                       new_height = input_no;
-                     else
-                       new_height = win_info->height + input_no;
-
-                     /* Now change the window's height, and adjust
-                        all other windows around it.  */
-                     if (tui_adjust_win_heights (win_info,
-                                               new_height) == TUI_FAILURE)
-                       warning (_("Invalid window height specified.\n%s"),
-                                WIN_HEIGHT_USAGE);
-                     else
-                        tui_update_gdb_sizes ();
-                   }
-                 else
-                   warning (_("Invalid window height specified.\n%s"),
-                            WIN_HEIGHT_USAGE);
-               }
-           }
-       }
-      else
-       printf_filtered (WIN_HEIGHT_USAGE);
-    }
-  else
-    printf_filtered (WIN_HEIGHT_USAGE);
-}
+         /* Process the size.  */
+         buf_ptr = skip_spaces (buf_ptr);
 
-/* Function to adjust all window heights around the primary.   */
-static enum tui_status
-tui_adjust_win_heights (struct tui_win_info *primary_win_info,
-                       int new_height)
-{
-  enum tui_status status = TUI_FAILURE;
-
-  if (new_height_ok (primary_win_info, new_height))
-    {
-      status = TUI_SUCCESS;
-      if (new_height != primary_win_info->height)
-       {
-         int diff;
-         struct tui_win_info *win_info;
-         struct tui_locator_window *locator = tui_locator_win_info_ptr ();
-         enum tui_layout_type cur_layout = tui_current_layout ();
-         int width = tui_term_width ();
-
-         diff = (new_height - primary_win_info->height) * (-1);
-         if (cur_layout == SRC_COMMAND 
-             || cur_layout == DISASSEM_COMMAND)
+         if (*buf_ptr != '\0')
            {
-             struct tui_win_info *src_win_info;
+             bool negate = false;
+             bool fixed_size = true;
+             int input_no;;
 
-             primary_win_info->resize (new_height, width,
-                                       0, primary_win_info->origin.y);
-             if (primary_win_info->type == CMD_WIN)
+             if (*buf_ptr == '+' || *buf_ptr == '-')
                {
-                 win_info = *(tui_source_windows ().begin ());
-                 src_win_info = win_info;
+                 if (*buf_ptr == '-')
+                   negate = true;
+                 fixed_size = false;
+                 buf_ptr++;
                }
-             else
-               {
-                 win_info = tui_win_list[CMD_WIN];
-                 src_win_info = primary_win_info;
-               }
-             win_info->resize (win_info->height + diff, width,
-                               0, win_info->origin.y);
-             TUI_CMD_WIN->origin.y = locator->origin.y + 1;
-             if ((src_win_info->type == SRC_WIN
-                  || src_win_info->type == DISASSEM_WIN))
+             input_no = atoi (buf_ptr);
+             if (input_no > 0)
                {
-                 tui_source_window_base *src_base
-                   = (tui_source_window_base *) src_win_info;
-                 if (src_base->content.empty ())
-                   src_base->erase_source_content ();
-               }
-           }
-         else
-           {
-             struct tui_win_info *first_win;
-             struct tui_source_window_base *second_win;
-             tui_source_window_base *src1;
+                 if (negate)
+                   input_no *= (-1);
+                 if (fixed_size)
+                   new_height = input_no;
+                 else
+                   new_height = win_info->height + input_no;
 
-             if (cur_layout == SRC_DISASSEM_COMMAND)
-               {
-                 src1 = TUI_SRC_WIN;
-                 first_win = src1;
-                 second_win = TUI_DISASM_WIN;
+                 /* Now change the window's height, and adjust
+                    all other windows around it.  */
+                 tui_adjust_window_height (win_info, new_height);
+                 tui_update_gdb_sizes ();
                }
              else
-               {
-                 src1 = nullptr;
-                 first_win = TUI_DATA_WIN;
-                 second_win = *(tui_source_windows ().begin ());
-               }
-             if (primary_win_info == TUI_CMD_WIN)
-               { /* Split the change in height accross the 1st & 2nd
-                    windows, adjusting them as well.  */
-                 /* Subtract the locator.  */
-                 int first_split_diff = diff / 2;
-                 int second_split_diff = first_split_diff;
-
-                 if (diff % 2)
-                   {
-                     if (first_win->height >
-                         second_win->height)
-                       if (diff < 0)
-                         first_split_diff--;
-                       else
-                         first_split_diff++;
-                     else
-                       {
-                         if (diff < 0)
-                           second_split_diff--;
-                         else
-                           second_split_diff++;
-                       }
-                   }
-                 /* Make sure that the minimum hieghts are
-                    honored.  */
-                 while ((first_win->height + first_split_diff) < 3)
-                   {
-                     first_split_diff++;
-                     second_split_diff--;
-                   }
-                 while ((second_win->height + second_split_diff) < 3)
-                   {
-                     second_split_diff++;
-                     first_split_diff--;
-                   }
-                 first_win->resize (first_win->height + first_split_diff,
-                                    width,
-                                    0, first_win->origin.y);
-                 second_win->resize (second_win->height + second_split_diff,
-                                     width,
-                                     0, first_win->height - 1);
-                 locator->resize (1, width,
-                                  0, (second_win->origin.y
-                                      + second_win->height + 1));
-
-                 TUI_CMD_WIN->resize (new_height, width,
-                                      0, locator->origin.y + 1);
-               }
-             else
-               {
-                 if ((TUI_CMD_WIN->height + diff) < 1)
-                   { /* If there is no way to increase the command
-                        window take real estate from the 1st or 2nd
-                        window.  */
-                     if ((TUI_CMD_WIN->height + diff) < 1)
-                       {
-                         int i;
-
-                         for (i = TUI_CMD_WIN->height + diff;
-                              (i < 1); i++)
-                           if (primary_win_info == first_win)
-                             second_win->height--;
-                           else
-                             first_win->height--;
-                       }
-                   }
-                 if (primary_win_info == first_win)
-                   first_win->resize (new_height, width, 0, 0);
-                 else
-                   first_win->resize (first_win->height, width, 0, 0);
-                 second_win->origin.y = first_win->height - 1;
-                 if (primary_win_info == second_win)
-                   second_win->resize (new_height, width,
-                                       0, first_win->height - 1);
-                 else
-                   second_win->resize (second_win->height, width,
-                                       0, first_win->height - 1);
-                 locator->resize (1, width,
-                                  0, (second_win->origin.y
-                                      + second_win->height + 1));
-                 TUI_CMD_WIN->origin.y = locator->origin.y + 1;
-                 if ((TUI_CMD_WIN->height + diff) < 1)
-                   TUI_CMD_WIN->resize (1, width, 0, locator->origin.y + 1);
-                 else
-                   TUI_CMD_WIN->resize (TUI_CMD_WIN->height + diff, width,
-                                        0, locator->origin.y + 1);
-               }
-             if (src1 != nullptr && src1->content.empty ())
-               src1->erase_source_content ();
-             if (second_win->content.empty ())
-               second_win->erase_source_content ();
+               warning (_("Invalid window height specified.\n%s"),
+                        WIN_HEIGHT_USAGE);
            }
        }
+      else
+       printf_filtered (WIN_HEIGHT_USAGE);
     }
-
-  return status;
+  else
+    printf_filtered (WIN_HEIGHT_USAGE);
 }
 
 /* See tui-data.h.  */
@@ -1182,112 +952,6 @@ tui_win_info::max_height () const
   return tui_term_height () - 2;
 }
 
-static int
-new_height_ok (struct tui_win_info *primary_win_info, 
-              int new_height)
-{
-  int ok = (new_height < tui_term_height ());
-
-  if (ok)
-    {
-      int diff;
-      enum tui_layout_type cur_layout = tui_current_layout ();
-
-      diff = (new_height - primary_win_info->height) * (-1);
-      if (cur_layout == SRC_COMMAND || cur_layout == DISASSEM_COMMAND)
-       {
-         ok = (new_height <= primary_win_info->max_height ()
-               && new_height >= MIN_CMD_WIN_HEIGHT);
-         if (ok)
-           {                   /* Check the total height.  */
-             struct tui_win_info *win_info;
-
-             if (primary_win_info == TUI_CMD_WIN)
-               win_info = *(tui_source_windows ().begin ());
-             else
-               win_info = TUI_CMD_WIN;
-             ok = ((new_height +
-                    (win_info->height + diff)) <= tui_term_height ());
-           }
-       }
-      else
-       {
-         int cur_total_height, total_height, min_height = 0;
-         struct tui_win_info *first_win;
-         struct tui_win_info *second_win;
-
-         if (cur_layout == SRC_DISASSEM_COMMAND)
-           {
-             first_win = TUI_SRC_WIN;
-             second_win = TUI_DISASM_WIN;
-           }
-         else
-           {
-             first_win = TUI_DATA_WIN;
-             second_win = *(tui_source_windows ().begin ());
-           }
-         /* We could simply add all the heights to obtain the same
-            result but below is more explicit since we subtract 1 for
-            the line that the first and second windows share, and add
-            one for the locator.  */
-         total_height = cur_total_height =
-           (first_win->height + second_win->height - 1)
-           + TUI_CMD_WIN->height + 1;  /* Locator. */
-         if (primary_win_info == TUI_CMD_WIN)
-           {
-             /* Locator included since first & second win share a line.  */
-             ok = ((first_win->height +
-                    second_win->height + diff) >=
-                   (MIN_WIN_HEIGHT * 2) 
-                   && new_height >= MIN_CMD_WIN_HEIGHT);
-             if (ok)
-               {
-                 total_height = new_height + 
-                   (first_win->height +
-                    second_win->height + diff);
-                 min_height = MIN_CMD_WIN_HEIGHT;
-               }
-           }
-         else
-           {
-             min_height = MIN_WIN_HEIGHT;
-
-             /* First see if we can increase/decrease the command
-                window.  And make sure that the command window is at
-                least 1 line.  */
-             ok = ((TUI_CMD_WIN->height + diff) > 0);
-             if (!ok)
-               { /* Looks like we have to increase/decrease one of
-                    the other windows.  */
-                 if (primary_win_info == first_win)
-                   ok = (second_win->height + diff) >= min_height;
-                 else
-                   ok = (first_win->height + diff) >= min_height;
-               }
-             if (ok)
-               {
-                 if (primary_win_info == first_win)
-                   total_height = new_height +
-                     second_win->height +
-                     TUI_CMD_WIN->height + diff;
-                 else
-                   total_height = new_height +
-                     first_win->height +
-                     TUI_CMD_WIN->height + diff;
-               }
-           }
-         /* Now make sure that the proposed total height doesn't
-            exceed the old total height.  */
-         if (ok)
-           ok = (new_height >= min_height 
-                 && total_height <= cur_total_height);
-       }
-    }
-
-  return ok;
-}
-
-
 static void
 parse_scrolling_args (const char *arg, 
                      struct tui_win_info **win_to_scroll,
@@ -1314,7 +978,7 @@ parse_scrolling_args (const char *arg,
          buf_ptr = strchr (buf_ptr, ' ');
          if (buf_ptr != NULL)
            {
-             *buf_ptr = (char) 0;
+             *buf_ptr = '\0';
              if (num_to_scroll)
                *num_to_scroll = atoi (num_str);
              buf_ptr++;
@@ -1328,29 +992,19 @@ parse_scrolling_args (const char *arg,
        {
          const char *wname;
 
-         if (*buf_ptr == ' ')
-           while (*(++buf_ptr) == ' ')
-             ;
+         wname = skip_spaces (buf_ptr);
 
-         if (*buf_ptr != (char) 0)
+         if (*wname != '\0')
            {
-             /* Validate the window name.  */
-             for (char *p = buf_ptr; *p != '\0'; p++)
-               *p = tolower (*p);
-
-             wname = buf_ptr;
+             *win_to_scroll = tui_partial_win_by_name (wname);
+
+             if (*win_to_scroll == NULL)
+               error (_("Unrecognized window `%s'"), wname);
+             if (!(*win_to_scroll)->is_visible ())
+               error (_("Window is not visible"));
+             else if (*win_to_scroll == TUI_CMD_WIN)
+               *win_to_scroll = *(tui_source_windows ().begin ());
            }
-         else
-           wname = "?";
-         
-         *win_to_scroll = tui_partial_win_by_name (wname);
-
-         if (*win_to_scroll == NULL)
-           error (_("Unrecognized window `%s'"), wname);
-         if (!(*win_to_scroll)->is_visible ())
-           error (_("Window is not visible"));
-         else if (*win_to_scroll == TUI_CMD_WIN)
-           *win_to_scroll = *(tui_source_windows ().begin ());
        }
     }
 }
@@ -1471,4 +1125,27 @@ Show the tab witdh, in characters, for the TUI."), _("\
 This variable controls how many spaces are used to display a tab character."),
                             tui_set_tab_width, tui_show_tab_width,
                             &tui_setlist, &tui_showlist);
+
+  add_setshow_boolean_cmd ("tui-resize-message", class_maintenance,
+                          &resize_message, _("\
+Set TUI resize messaging."), _("\
+Show TUI resize messaging."), _("\
+When enabled GDB will print a message when the terminal is resized."),
+                          nullptr,
+                          show_tui_resize_message,
+                          &maintenance_set_cmdlist,
+                          &maintenance_show_cmdlist);
+
+  add_setshow_boolean_cmd ("compact-source", class_tui,
+                          &compact_source, _("\
+Set whether the TUI source window is compact."), _("\
+Show whether the TUI source window is compact."), _("\
+This variable controls whether the TUI source window is shown\n\
+in a compact form.  The compact form puts the source closer to\n\
+the line numbers and uses less horizontal space."),
+                          tui_set_compact_source, tui_show_compact_source,
+                          &tui_setlist, &tui_showlist);
+
+  tui_border_style.changed.attach (tui_rehighlight_all);
+  tui_active_border_style.changed.attach (tui_rehighlight_all);
 }
This page took 0.043524 seconds and 4 git commands to generate.