-/* Copyright (C) 2008-2013 Free Software Foundation, Inc.
+/* Copyright (C) 2008-2020 Free Software Foundation, Inc.
This file is part of GDB.
#include "complaints.h"
#include "solib.h"
#include "solib-target.h"
+#include "gdbcore.h"
struct cmd_list_element *info_w32_cmdlist;
sizeof (thread_information_64) / sizeof (uint64_t);
static const int FULL_TIB_SIZE = 0x1000;
-static int maint_display_all_tib = 0;
+static bool maint_display_all_tib = false;
/* Define Thread Local Base pointer type. */
static struct type *last_tlb_type = NULL;
struct type *dword_ptr_type, *dword32_type, *void_ptr_type;
struct type *peb_ldr_type, *peb_ldr_ptr_type;
- struct type *peb_type, *peb_ptr_type, *list_type, *list_ptr_type;
+ struct type *peb_type, *peb_ptr_type, *list_type;
struct type *module_list_ptr_type;
struct type *tib_type, *seh_type, *tib_ptr_type, *seh_ptr_type;
list_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
TYPE_NAME (list_type) = xstrdup ("list");
- list_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
- TYPE_LENGTH (void_ptr_type), NULL);
-
module_list_ptr_type = void_ptr_type;
append_composite_type_field (list_type, "forward_list",
TYPE_NAME (seh_type) = xstrdup ("seh");
seh_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
- TYPE_LENGTH (void_ptr_type), NULL);
+ TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
+ NULL);
TYPE_TARGET_TYPE (seh_ptr_type) = seh_type;
append_composite_type_field (seh_type, "next_seh", seh_ptr_type);
append_composite_type_field (peb_ldr_type, "entry_in_progress",
void_ptr_type);
peb_ldr_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
- TYPE_LENGTH (void_ptr_type), NULL);
+ TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
+ NULL);
TYPE_TARGET_TYPE (peb_ldr_ptr_type) = peb_ldr_type;
append_composite_type_field (peb_type, "process_heap", void_ptr_type);
append_composite_type_field (peb_type, "fast_peb_lock", void_ptr_type);
peb_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
- TYPE_LENGTH (void_ptr_type), NULL);
+ TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
+ NULL);
TYPE_TARGET_TYPE (peb_ptr_type) = peb_type;
append_composite_type_field (tib_type, "last_error_number", dword_ptr_type);
tib_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
- TYPE_LENGTH (void_ptr_type), NULL);
+ TYPE_LENGTH (void_ptr_type) * TARGET_CHAR_BIT,
+ NULL);
TYPE_TARGET_TYPE (tib_ptr_type) = tib_type;
last_tlb_type = tib_ptr_type;
static struct value *
tlb_make_value (struct gdbarch *gdbarch, struct internalvar *var, void *ignore)
{
- if (target_has_stack && !ptid_equal (inferior_ptid, null_ptid))
+ if (target_has_stack && inferior_ptid != null_ptid)
{
struct type *type = windows_get_tlb_type (gdbarch);
return allocate_computed_value (type, &tlb_value_funcs, NULL);
max = tib_size / size;
}
- tib = alloca (tib_size);
+ tib = (gdb_byte *) alloca (tib_size);
if (target_get_tib_address (ptid, &thread_local_base) == 0)
{
printf_filtered (_("Unable to get thread local base for %s\n"),
- target_pid_to_str (ptid));
+ target_pid_to_str (ptid).c_str ());
return -1;
}
- if (target_read (¤t_target, TARGET_OBJECT_MEMORY,
+ if (target_read (current_top_target (), TARGET_OBJECT_MEMORY,
NULL, tib, thread_local_base, tib_size) != tib_size)
{
printf_filtered (_("Unable to read thread information "
"block for %s at address %s\n"),
- target_pid_to_str (ptid),
- paddress (target_gdbarch (), thread_local_base));
+ target_pid_to_str (ptid).c_str (),
+ paddress (target_gdbarch (), thread_local_base));
return -1;
}
printf_filtered (_("Thread Information Block %s at %s\n"),
- target_pid_to_str (ptid),
+ target_pid_to_str (ptid).c_str (),
paddress (target_gdbarch (), thread_local_base));
index = (gdb_byte *) tib;
return 1;
}
-/* Display thread information block of a thread specified by ARGS.
- If ARGS is empty, display thread information block of current_thread
- if current_thread is non NULL.
- Otherwise ARGS is parsed and converted to a integer that should
- be the windows ThreadID (not the internal GDB thread ID). */
+/* Display thread information block of the current thread. */
static void
-display_tib (char * args, int from_tty)
+display_tib (const char * args, int from_tty)
{
- if (args)
- {
- struct thread_info *tp;
- int gdb_id = value_as_long (parse_and_eval (args));
-
- tp = find_thread_id (gdb_id);
-
- if (!tp)
- error (_("Thread ID %d not known."), gdb_id);
-
- if (!target_thread_alive (tp->ptid))
- error (_("Thread ID %d has terminated."), gdb_id);
-
- display_one_tib (tp->ptid);
- }
- else if (!ptid_equal (inferior_ptid, null_ptid))
+ if (inferior_ptid != null_ptid)
display_one_tib (inferior_ptid);
}
windows_xfer_shared_library (const char* so_name, CORE_ADDR load_addr,
struct gdbarch *gdbarch, struct obstack *obstack)
{
- char *p;
- struct bfd * dll;
CORE_ADDR text_offset;
obstack_grow_str (obstack, "<library name=\"");
- p = xml_escape_text (so_name);
- obstack_grow_str (obstack, p);
- xfree (p);
+ std::string p = xml_escape_text (so_name);
+ obstack_grow_str (obstack, p.c_str ());
obstack_grow_str (obstack, "\"><segment address=\"");
- dll = gdb_bfd_open_maybe_remote (so_name);
+ gdb_bfd_ref_ptr dll (gdb_bfd_open (so_name, gnutarget, -1));
/* The following calls are OK even if dll is NULL.
The default value 0x1000 is returned by pe_text_section_offset
in that case. */
- text_offset = pe_text_section_offset (dll);
- gdb_bfd_unref (dll);
+ text_offset = pe_text_section_offset (dll.get ());
obstack_grow_str (obstack, paddress (gdbarch, load_addr + text_offset));
obstack_grow_str (obstack, "\"/></library>");
}
void *cb_data, struct objfile *current_objfile)
{
int stop;
- struct objfile *objfile;
if (current_objfile)
{
return;
}
- ALL_OBJFILES (objfile)
+ for (objfile *objfile : current_program_space->objfiles ())
{
if (objfile != current_objfile)
{
}
static void
-info_w32_command (char *args, int from_tty)
+info_w32_command (const char *args, int from_tty)
{
help_list (info_w32_cmdlist, "info w32 ", class_info, gdb_stdout);
}
void
windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
+ set_gdbarch_wchar_bit (gdbarch, 16);
+ set_gdbarch_wchar_signed (gdbarch, 0);
+
/* Canonical paths on this target look like
`c:\Program Files\Foo App\mydll.dll', for example. */
set_gdbarch_has_dos_based_file_system (gdbarch, 1);
set_solib_ops (gdbarch, &solib_target_so_ops);
}
-/* Provide a prototype to silence -Wmissing-prototypes. */
-extern initialize_file_ftype _initialize_windows_tdep;
-
/* Implementation of `tlb' variable. */
static const struct internalvar_funcs tlb_funcs =