Fix ARC TLS support.
[deliverable/binutils-gdb.git] / gdb / xcoffread.c
index 2fba510acf836be768bba11320aa5f45b7c8d272..c67094980a9ff02e8b97e2bf8dc8cb92b3131401 100644 (file)
@@ -1,5 +1,5 @@
 /* Read AIX xcoff symbol tables and convert to internal format, for GDB.
-   Copyright (C) 1986-2013 Free Software Foundation, Inc.
+   Copyright (C) 1986-2016 Free Software Foundation, Inc.
    Derived from coffread.c, dbxread.c, and a lot of hacking.
    Contributed by IBM Corporation.
 
@@ -24,8 +24,6 @@
 #include <sys/types.h>
 #include <fcntl.h>
 #include <ctype.h>
-#include <string.h>
-
 #ifdef HAVE_SYS_FILE_H
 #include <sys/file.h>
 #endif
@@ -121,11 +119,6 @@ static CORE_ADDR first_object_file_end;
 
 #define        INITIAL_STABVECTOR_LENGTH       40
 
-/* Nonzero if within a function (so symbols should be local,
-   if nothing says specifically).  */
-
-int within_function;
-
 /* Size of a COFF symbol.  I think it is always 18, so I'm not sure
    there is any reason not to just use a #define, but might as well
    ask BFD for the size and store it here, I guess.  */
@@ -166,11 +159,14 @@ static const struct dwarf2_debug_sections dwarf2_xcoff_names = {
   { ".dwabrev", NULL },
   { ".dwline", NULL },
   { ".dwloc", NULL },
-  { NULL, NULL }, /* debug_macinfo */
-  { NULL, NULL }, /* debug_macro */
+  /* AIX XCOFF defines one, named DWARF section for macro debug information.
+     XLC does not generate debug_macinfo for DWARF4 and below.
+     The section is assigned to debug_macro for DWARF5 and above. */
+  { NULL, NULL },
+  { ".dwmac", NULL },
   { ".dwstr", NULL },
   { ".dwrnges", NULL },
-  { NULL, NULL }, /* debug_types */
+  { ".dwpbtyp", NULL },
   { NULL, NULL }, /* debug_addr */
   { ".dwframe", NULL },
   { NULL, NULL }, /* eh_frame */
@@ -442,8 +438,7 @@ arrange_linetable (struct linetable *oldLineTb)
 #define NUM_OF_FUNCTIONS 20
 
   fentry_size = NUM_OF_FUNCTIONS;
-  fentry = (struct linetable_entry *)
-    xmalloc (fentry_size * sizeof (struct linetable_entry));
+  fentry = XNEWVEC (struct linetable_entry, fentry_size);
 
   for (function_count = 0, ii = 0; ii < oldLineTb->nitems; ++ii)
     {
@@ -591,18 +586,14 @@ allocate_include_entry (void)
 {
   if (inclTable == NULL)
     {
-      inclTable = (InclTable *)
-       xmalloc (sizeof (InclTable) * INITIAL_INCLUDE_TABLE_LENGTH);
-      memset (inclTable,
-             '\0', sizeof (InclTable) * INITIAL_INCLUDE_TABLE_LENGTH);
+      inclTable = XCNEWVEC (InclTable, INITIAL_INCLUDE_TABLE_LENGTH);
       inclLength = INITIAL_INCLUDE_TABLE_LENGTH;
       inclIndx = 0;
     }
   else if (inclIndx >= inclLength)
     {
       inclLength += INITIAL_INCLUDE_TABLE_LENGTH;
-      inclTable = (InclTable *)
-       xrealloc (inclTable, sizeof (InclTable) * inclLength);
+      inclTable = XRESIZEVEC (InclTable, inclTable, inclLength);
       memset (inclTable + inclLength - INITIAL_INCLUDE_TABLE_LENGTH,
              '\0', sizeof (InclTable) * INITIAL_INCLUDE_TABLE_LENGTH);
     }
@@ -686,8 +677,7 @@ process_linenos (CORE_ADDR start, CORE_ADDR end)
            {
              /* Have a new subfile for the include file.  */
 
-             tmpSubfile = inclTable[ii].subfile =
-               (struct subfile *) xmalloc (sizeof (struct subfile));
+             tmpSubfile = inclTable[ii].subfile = XNEW (struct subfile);
 
              memset (tmpSubfile, '\0', sizeof (struct subfile));
              firstLine = &(inclTable[ii].funStartLine);
@@ -771,7 +761,7 @@ process_linenos (CORE_ADDR start, CORE_ADDR end)
             fool it.  */
 
 #if 0
-         start_subfile (inclTable[ii].name, (char *) 0);
+         start_subfile (inclTable[ii].name);
 #else
          {
            /* Pick a fake name that will produce the same results as this
@@ -781,7 +771,7 @@ process_linenos (CORE_ADDR start, CORE_ADDR end)
 
            if (fakename == NULL)
              fakename = " ?";
-           start_subfile (fakename, (char *) 0);
+           start_subfile (fakename);
            xfree (current_subfile->name);
          }
          current_subfile->name = xstrdup (inclTable[ii].name);
@@ -803,7 +793,7 @@ process_linenos (CORE_ADDR start, CORE_ADDR end)
 
          current_subfile->line_vector_length =
            current_subfile->line_vector->nitems;
-         start_subfile (pop_subfile (), (char *) 0);
+         start_subfile (pop_subfile ());
        }
     }
 
@@ -811,9 +801,6 @@ return_after_cleanup:
 
   /* We don't want to keep alloc/free'ing the global include file table.  */
   inclIndx = 0;
-
-  /* Start with a fresh subfile structure for the next file.  */
-  memset (&main_subfile, '\0', sizeof (struct subfile));
 }
 
 static void
@@ -948,7 +935,6 @@ record_minimal_symbol (const char *name, CORE_ADDR address,
   if (name[0] == '.')
     ++name;
 
-  address += ANOFFSET (objfile->section_offsets, section);
   prim_record_minimal_symbol_and_info (name, address, ms_type,
                                       secnum_to_section (n_scnum, objfile),
                                       objfile);
@@ -1039,7 +1025,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
 
   /* fcn_cs_saved is global because process_xcoff_symbol needs it.  */
   union internal_auxent fcn_aux_saved = main_aux;
-  struct context_stack *new;
+  struct context_stack *newobj;
 
   char *filestring = " _start_ ";      /* Name of the current file.  */
 
@@ -1056,7 +1042,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
   last_csect_name = 0;
 
   start_stabs ();
-  start_symtab (filestring, (char *) NULL, file_start_addr);
+  start_symtab (objfile, filestring, (char *) NULL, file_start_addr);
   record_debugformat (debugfmt);
   symnum = ((struct symloc *) pst->read_symtab_private)->first_symnum;
   max_symnum =
@@ -1096,7 +1082,8 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
              {
                char *p;
 
-               p = obstack_alloc (&objfile->objfile_obstack, E_SYMNMLEN + 1);
+               p = (char *) obstack_alloc (&objfile->objfile_obstack,
+                                           E_SYMNMLEN + 1);
                strncpy (p, cs->c_name, E_SYMNMLEN);
                p[E_SYMNMLEN] = '\0';
                cs->c_name = p;
@@ -1142,13 +1129,13 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
        {
          if (get_last_source_file ())
            {
-             pst->symtab = end_symtab (cur_src_end_addr, objfile,
-                                       SECT_OFF_TEXT (objfile));
+             pst->compunit_symtab = end_symtab (cur_src_end_addr,
+                                                SECT_OFF_TEXT (objfile));
              end_stabs ();
            }
 
          start_stabs ();
-         start_symtab ("_globals_", (char *) NULL, (CORE_ADDR) 0);
+         start_symtab (objfile, "_globals_", (char *) NULL, (CORE_ADDR) 0);
          record_debugformat (debugfmt);
          cur_src_end_addr = first_object_file_end;
          /* Done with all files, everything from here on is globals.  */
@@ -1200,13 +1187,13 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
                        {
                          complete_symtab (filestring, file_start_addr);
                          cur_src_end_addr = file_end_addr;
-                         end_symtab (file_end_addr, objfile,
-                                     SECT_OFF_TEXT (objfile));
+                         end_symtab (file_end_addr, SECT_OFF_TEXT (objfile));
                          end_stabs ();
                          start_stabs ();
                          /* Give all csects for this source file the same
                             name.  */
-                         start_symtab (filestring, NULL, (CORE_ADDR) 0);
+                         start_symtab (objfile, filestring, NULL,
+                                       (CORE_ADDR) 0);
                          record_debugformat (debugfmt);
                        }
 
@@ -1322,7 +1309,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
 
          complete_symtab (filestring, file_start_addr);
          cur_src_end_addr = file_end_addr;
-         end_symtab (file_end_addr, objfile, SECT_OFF_TEXT (objfile));
+         end_symtab (file_end_addr, SECT_OFF_TEXT (objfile));
          end_stabs ();
 
          /* XCOFF, according to the AIX 3.2 documentation, puts the
@@ -1341,7 +1328,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
            filestring = cs->c_name;
 
          start_stabs ();
-         start_symtab (filestring, (char *) NULL, (CORE_ADDR) 0);
+         start_symtab (objfile, filestring, (char *) NULL, (CORE_ADDR) 0);
          record_debugformat (debugfmt);
          last_csect_name = 0;
 
@@ -1366,13 +1353,13 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
 
              within_function = 1;
 
-             new = push_context (0, fcn_start_addr + off);
+             newobj = push_context (0, fcn_start_addr + off);
 
-             new->name = define_symbol
+             newobj->name = define_symbol
                (fcn_cs_saved.c_value + off,
                 fcn_stab_saved.c_name, 0, 0, objfile);
-             if (new->name != NULL)
-               SYMBOL_SECTION (new->name) = SECT_OFF_TEXT (objfile);
+             if (newobj->name != NULL)
+               SYMBOL_SECTION (newobj->name) = SECT_OFF_TEXT (objfile);
            }
          else if (strcmp (cs->c_name, ".ef") == 0)
            {
@@ -1390,22 +1377,21 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
                  within_function = 0;
                  break;
                }
-             new = pop_context ();
+             newobj = pop_context ();
              /* Stack must be empty now.  */
-             if (context_stack_depth > 0 || new == NULL)
+             if (context_stack_depth > 0 || newobj == NULL)
                {
                  ef_complaint (cs->c_symnum);
                  within_function = 0;
                  break;
                }
 
-             finish_block (new->name, &local_symbols, new->old_blocks,
-                           new->start_addr,
+             finish_block (newobj->name, &local_symbols, newobj->old_blocks,
+                           NULL, newobj->start_addr,
                            (fcn_cs_saved.c_value
                             + fcn_aux_saved.x_sym.x_misc.x_fsize
                             + ANOFFSET (objfile->section_offsets,
-                                        SECT_OFF_TEXT (objfile))),
-                           objfile);
+                                        SECT_OFF_TEXT (objfile))));
              within_function = 0;
            }
          break;
@@ -1471,7 +1457,7 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
          if (strcmp (cs->c_name, ".bb") == 0)
            {
              depth++;
-             new = push_context (depth,
+             newobj = push_context (depth,
                                  (cs->c_value
                                   + ANOFFSET (objfile->section_offsets,
                                               SECT_OFF_TEXT (objfile))));
@@ -1483,8 +1469,8 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
                  eb_complaint (cs->c_symnum);
                  break;
                }
-             new = pop_context ();
-             if (depth-- != new->depth)
+             newobj = pop_context ();
+             if (depth-- != newobj->depth)
                {
                  eb_complaint (cs->c_symnum);
                  break;
@@ -1492,14 +1478,14 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
              if (local_symbols && context_stack_depth > 0)
                {
                  /* Make a block for the local symbols within.  */
-                 finish_block (new->name, &local_symbols, new->old_blocks,
-                               new->start_addr,
+                 finish_block (newobj->name, &local_symbols,
+                               newobj->old_blocks, NULL,
+                               newobj->start_addr,
                                (cs->c_value
                                 + ANOFFSET (objfile->section_offsets,
-                                            SECT_OFF_TEXT (objfile))),
-                               objfile);
+                                            SECT_OFF_TEXT (objfile))));
                }
-             local_symbols = new->locals;
+             local_symbols = newobj->locals;
            }
          break;
 
@@ -1511,24 +1497,23 @@ read_xcoff_symtab (struct objfile *objfile, struct partial_symtab *pst)
 
   if (get_last_source_file ())
     {
-      struct symtab *s;
+      struct compunit_symtab *cust;
 
       complete_symtab (filestring, file_start_addr);
       cur_src_end_addr = file_end_addr;
-      s = end_symtab (file_end_addr, objfile, SECT_OFF_TEXT (objfile));
+      cust = end_symtab (file_end_addr, SECT_OFF_TEXT (objfile));
       /* When reading symbols for the last C_FILE of the objfile, try
-         to make sure that we set pst->symtab to the symtab for the
+         to make sure that we set pst->compunit_symtab to the symtab for the
          file, not to the _globals_ symtab.  I'm not sure whether this
          actually works right or when/if it comes up.  */
-      if (pst->symtab == NULL)
-       pst->symtab = s;
+      if (pst->compunit_symtab == NULL)
+       pst->compunit_symtab = cust;
       end_stabs ();
     }
 }
 
 #define        SYMBOL_DUP(SYMBOL1, SYMBOL2)    \
-  (SYMBOL2) = (struct symbol *)                \
-       obstack_alloc (&objfile->objfile_obstack, sizeof (struct symbol)); \
+  (SYMBOL2) = XOBNEW (&objfile->objfile_obstack, struct symbol); \
   *(SYMBOL2) = *(SYMBOL1);
 
 
@@ -1567,7 +1552,7 @@ process_xcoff_symbol (struct coff_symbol *cs, struct objfile *objfile)
   if (name[0] == '.')
     ++name;
 
-  initialize_symbol (sym);
+  initialize_objfile_symbol (sym);
 
   /* default assumptions */
   SYMBOL_VALUE_ADDRESS (sym) = cs->c_value + off;
@@ -1580,7 +1565,8 @@ process_xcoff_symbol (struct coff_symbol *cs, struct objfile *objfile)
          will be patched with the type from its stab entry later on in
          patch_block_stabs (), unless the file was compiled without -g.  */
 
-      SYMBOL_SET_LINKAGE_NAME (sym, SYMNAME_ALLOC (name, symname_alloced));
+      SYMBOL_SET_LINKAGE_NAME (sym, ((const char *)
+                                    SYMNAME_ALLOC (name, symname_alloced)));
       SYMBOL_TYPE (sym) = objfile_type (objfile)->nodebug_text_symbol;
 
       SYMBOL_ACLASS_INDEX (sym) = LOC_BLOCK;
@@ -2029,14 +2015,14 @@ xcoff_start_psymtab (struct objfile *objfile,
                     struct partial_symbol **static_syms)
 {
   struct partial_symtab *result =
-    start_psymtab_common (objfile, objfile->section_offsets,
+    start_psymtab_common (objfile,
                          filename,
                          /* We fill in textlow later.  */
                          0,
                          global_syms, static_syms);
 
-  result->read_symtab_private = obstack_alloc (&objfile->objfile_obstack,
-                                              sizeof (struct symloc));
+  result->read_symtab_private =
+    XOBNEW (&objfile->objfile_obstack, struct symloc);
   ((struct symloc *) result->read_symtab_private)->first_symnum = first_symnum;
   result->read_symtab = xcoff_read_symtab;
 
@@ -2070,17 +2056,15 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
   ((struct symloc *) pst->read_symtab_private)->lineno_off =
     first_fun_line_offset;
   first_fun_line_offset = 0;
-  pst->n_global_syms = objfile->global_psymbols.next
-    - (objfile->global_psymbols.list + pst->globals_offset);
-  pst->n_static_syms = objfile->static_psymbols.next
-    - (objfile->static_psymbols.list + pst->statics_offset);
+
+  end_psymtab_common (objfile, pst);
 
   pst->number_of_dependencies = number_dependencies;
   if (number_dependencies)
     {
-      pst->dependencies = (struct partial_symtab **)
-       obstack_alloc (&objfile->objfile_obstack,
-                   number_dependencies * sizeof (struct partial_symtab *));
+      pst->dependencies = XOBNEWVEC (&objfile->objfile_obstack,
+                                    struct partial_symtab *,
+                                    number_dependencies);
       memcpy (pst->dependencies, dependency_list,
              number_dependencies * sizeof (struct partial_symtab *));
     }
@@ -2092,7 +2076,6 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
       struct partial_symtab *subpst =
        allocate_psymtab (include_list[i], objfile);
 
-      subpst->section_offsets = pst->section_offsets;
       subpst->read_symtab_private = obstack_alloc (&objfile->objfile_obstack,
                                                   sizeof (struct symloc));
       ((struct symloc *) subpst->read_symtab_private)->first_symnum = 0;
@@ -2102,9 +2085,8 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
 
       /* We could save slight bits of space by only making one of these,
          shared by the entire set of include files.  FIXME-someday.  */
-      subpst->dependencies = (struct partial_symtab **)
-       obstack_alloc (&objfile->objfile_obstack,
-                      sizeof (struct partial_symtab *));
+      subpst->dependencies =
+         XOBNEW (&objfile->objfile_obstack, struct partial_symtab *);
       subpst->dependencies[0] = pst;
       subpst->number_of_dependencies = 1;
 
@@ -2114,12 +2096,10 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
        subpst->n_static_syms = 0;
 
       subpst->readin = 0;
-      subpst->symtab = 0;
+      subpst->compunit_symtab = NULL;
       subpst->read_symtab = pst->read_symtab;
     }
 
-  sort_pst_symbols (objfile, pst);
-
   if (num_includes == 0
       && number_dependencies == 0
       && pst->n_global_syms == 0
@@ -2133,7 +2113,7 @@ xcoff_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
       discard_psymtab (objfile, pst);
 
       /* Indicate that psymtab was thrown away.  */
-      pst = (struct partial_symtab *) NULL;
+      pst = NULL;
     }
   return pst;
 }
@@ -2158,7 +2138,8 @@ swap_sym (struct internal_syment *symbol, union internal_auxent *aux,
             into the minimal symbols.  */
          char *p;
 
-         p = obstack_alloc (&objfile->objfile_obstack, E_SYMNMLEN + 1);
+         p = (char *) obstack_alloc (&objfile->objfile_obstack,
+                                     E_SYMNMLEN + 1);
          strncpy (p, symbol->n_name, E_SYMNMLEN);
          p[E_SYMNMLEN] = '\0';
          *name = p;
@@ -2400,13 +2381,12 @@ scan_xcoff_symtab (struct objfile *objfile)
                    if (first_fun_line_offset == 0 && symbol.n_numaux > 1)
                      first_fun_line_offset =
                        main_aux[0].x_sym.x_fcnary.x_fcn.x_lnnoptr;
-                     {
-                       record_minimal_symbol
-                         (namestring, symbol.n_value,
-                          sclass == C_HIDEXT ? mst_file_text : mst_text,
-                          symbol.n_scnum, objfile);
-                       misc_func_recorded = 1;
-                     }
+
+                   record_minimal_symbol
+                     (namestring, symbol.n_value,
+                      sclass == C_HIDEXT ? mst_file_text : mst_text,
+                      symbol.n_scnum, objfile);
+                   misc_func_recorded = 1;
                    break;
 
                  case XMC_GL:
@@ -2649,7 +2629,7 @@ scan_xcoff_symtab (struct objfile *objfile)
        case C_DECL:
        case C_STSYM:
          {
-           char *p;
+           const char *p;
 
            swap_sym (&symbol, &main_aux[0], &namestring, &sraw_symbol,
                      &ssymnum, objfile);
@@ -2678,7 +2658,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                add_psymbol_to_list (namestring, p - namestring, 1,
                                     VAR_DOMAIN, LOC_STATIC,
                                     &objfile->static_psymbols,
-                                    0, symbol.n_value,
+                                    symbol.n_value,
                                     psymtab_language, objfile);
                continue;
 
@@ -2690,7 +2670,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                add_psymbol_to_list (namestring, p - namestring, 1,
                                     VAR_DOMAIN, LOC_STATIC,
                                     &objfile->global_psymbols,
-                                    0, symbol.n_value,
+                                    symbol.n_value,
                                     psymtab_language, objfile);
                continue;
 
@@ -2708,16 +2688,14 @@ scan_xcoff_symtab (struct objfile *objfile)
                    add_psymbol_to_list (namestring, p - namestring, 1,
                                         STRUCT_DOMAIN, LOC_TYPEDEF,
                                         &objfile->static_psymbols,
-                                        symbol.n_value, 0,
-                                        psymtab_language, objfile);
+                                        0, psymtab_language, objfile);
                    if (p[2] == 't')
                      {
                        /* Also a typedef with the same name.  */
                        add_psymbol_to_list (namestring, p - namestring, 1,
                                             VAR_DOMAIN, LOC_TYPEDEF,
                                             &objfile->static_psymbols,
-                                            symbol.n_value, 0,
-                                            psymtab_language, objfile);
+                                            0, psymtab_language, objfile);
                        p += 1;
                      }
                  }
@@ -2729,8 +2707,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                    add_psymbol_to_list (namestring, p - namestring, 1,
                                         VAR_DOMAIN, LOC_TYPEDEF,
                                         &objfile->static_psymbols,
-                                        symbol.n_value, 0,
-                                        psymtab_language, objfile);
+                                        0, psymtab_language, objfile);
                  }
              check_enum:
                /* If this is an enumerated type, we need to
@@ -2776,7 +2753,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                       Accept either.  */
                    while (*p && *p != ';' && *p != ',')
                      {
-                       char *q;
+                       const char *q;
 
                        /* Check for and handle cretinous dbx symbol name
                           continuation!  */
@@ -2791,7 +2768,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                           enum constants in psymtabs, just in symtabs.  */
                        add_psymbol_to_list (p, q - p, 1,
                                             VAR_DOMAIN, LOC_CONST,
-                                            &objfile->static_psymbols, 0,
+                                            &objfile->static_psymbols,
                                             0, psymtab_language, objfile);
                        /* Point past the name.  */
                        p = q;
@@ -2809,7 +2786,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                /* Constant, e.g. from "const" in Pascal.  */
                add_psymbol_to_list (namestring, p - namestring, 1,
                                     VAR_DOMAIN, LOC_CONST,
-                                    &objfile->static_psymbols, symbol.n_value,
+                                    &objfile->static_psymbols,
                                     0, psymtab_language, objfile);
                continue;
 
@@ -2817,7 +2794,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                if (! pst)
                  {
                    int name_len = p - namestring;
-                   char *name = xmalloc (name_len + 1);
+                   char *name = (char *) xmalloc (name_len + 1);
 
                    memcpy (name, namestring, name_len);
                    name[name_len] = '\0';
@@ -2829,7 +2806,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                add_psymbol_to_list (namestring, p - namestring, 1,
                                     VAR_DOMAIN, LOC_BLOCK,
                                     &objfile->static_psymbols,
-                                    0, symbol.n_value,
+                                    symbol.n_value,
                                     psymtab_language, objfile);
                continue;
 
@@ -2840,7 +2817,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                if (! pst)
                  {
                    int name_len = p - namestring;
-                   char *name = xmalloc (name_len + 1);
+                   char *name = (char *) xmalloc (name_len + 1);
 
                    memcpy (name, namestring, name_len);
                    name[name_len] = '\0';
@@ -2852,7 +2829,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                   loader-generated definitions.  Keeping the global
                   symbols leads to "in psymbols but not in symbols"
                   errors.  */
-               if (strncmp (namestring, "@FIX", 4) == 0)
+               if (startswith (namestring, "@FIX"))
                  continue;
 
                symbol.n_value += ANOFFSET (objfile->section_offsets,
@@ -2860,7 +2837,7 @@ scan_xcoff_symtab (struct objfile *objfile)
                add_psymbol_to_list (namestring, p - namestring, 1,
                                     VAR_DOMAIN, LOC_BLOCK,
                                     &objfile->global_psymbols,
-                                    0, symbol.n_value,
+                                    symbol.n_value,
                                     psymtab_language, objfile);
                continue;
 
@@ -2991,7 +2968,9 @@ xcoff_initial_scan (struct objfile *objfile, int symfile_flags)
            length = bfd_section_size (abfd, secp);
            if (length)
              {
-               debugsec = obstack_alloc (&objfile->objfile_obstack, length);
+               debugsec
+                 = (bfd_byte *) obstack_alloc (&objfile->objfile_obstack,
+                                               length);
 
                if (!bfd_get_full_section_contents (abfd, secp, &debugsec))
                  {
@@ -3011,7 +2990,7 @@ xcoff_initial_scan (struct objfile *objfile, int symfile_flags)
     error (_("Error reading symbols from %s: %s"),
           name, bfd_errmsg (bfd_get_error ()));
   size = coff_data (abfd)->local_symesz * num_symbols;
-  info->symtbl = obstack_alloc (&objfile->objfile_obstack, size);
+  info->symtbl = (char *) obstack_alloc (&objfile->objfile_obstack, size);
   info->symtbl_num_syms = num_symbols;
 
   val = bfd_bread (info->symtbl, size, abfd);
This page took 0.033586 seconds and 4 git commands to generate.