Add -Wshadow to the gcc command line options used when compiling the binutils.
[deliverable/binutils-gdb.git] / gold / merge.cc
index abe625ed873a23edb8449922aaaf23ecd3f6cfd2..654f3495fee34a3ee727e1a0ad518706b5197797 100644 (file)
@@ -1,6 +1,6 @@
 // merge.cc -- handle section merging for gold
 
-// Copyright 2006, 2007 Free Software Foundation, Inc.
+// Copyright 2006, 2007, 2008 Free Software Foundation, Inc.
 // Written by Ian Lance Taylor <iant@google.com>.
 
 // This file is part of gold.
 namespace gold
 {
 
-// For each object with merge sections, we store an Object_merge_map.
-// This is used to map locations in input sections to a merged output
-// section.  The output section itself is not recorded here--it can be
-// found in the map_to_output_ field of the Object.
-
-class Object_merge_map
-{
- public:
-  Object_merge_map()
-    : first_shnum_(-1U), first_map_(),
-      second_shnum_(-1U), second_map_(),
-      section_merge_maps_()
-  { }
-
-  ~Object_merge_map();
-
-  // Add a mapping for MERGE_MAP, for the bytes from OFFSET to OFFSET
-  // + LENGTH in the input section SHNDX to OUTPUT_OFFSET in the
-  // output section.  An OUTPUT_OFFSET of -1 means that the bytes are
-  // discarded.
-  void
-  add_mapping(const Merge_map*, unsigned int shndx, section_offset_type offset,
-             section_size_type length, section_offset_type output_offset);
-
-  // Get the output offset for an input address in MERGE_MAP.  The
-  // input address is at offset OFFSET in section SHNDX.  This sets
-  // *OUTPUT_OFFSET to the offset in the output section; this will be
-  // -1 if the bytes are not being copied to the output.  This returns
-  // true if the mapping is known, false otherwise.
-  bool
-  get_output_offset(const Merge_map*, unsigned int shndx,
-                   section_offset_type offset,
-                   section_offset_type *output_offset);
-
- private:
-  // Map input section offsets to a length and an output section
-  // offset.  An output section offset of -1 means that this part of
-  // the input section is being discarded.
-  struct Input_merge_entry
-  {
-    // The offset in the input section.
-    section_offset_type input_offset;
-    // The length.
-    section_size_type length;
-    // The offset in the output section.
-    section_offset_type output_offset;
-  };
-
-  // A less-than comparison routine for Input_merge_entry.
-  struct Input_merge_compare
-  {
-    bool
-    operator()(const Input_merge_entry& i1, const Input_merge_entry& i2) const
-    { return i1.input_offset < i2.input_offset; }
-  };
-
-  // A list of entries for a particular section.
-  struct Input_merge_map
-  {
-    // The Merge_map for this section.
-    const Merge_map* merge_map;
-    // The list of mappings.
-    std::vector<Input_merge_entry> entries;
-    // Whether the ENTRIES field is sorted by input_offset.
-    bool sorted;
-
-    Input_merge_map()
-      : merge_map(NULL), entries(), sorted(true)
-    { }
-  };
-
-  // Map input section indices to merge maps.
-  typedef std::map<unsigned int, Input_merge_map*> Section_merge_maps;
-
-  // Return a pointer to the Input_merge_map to use for the input
-  // section SHNDX, or NULL.
-  Input_merge_map*
-  get_input_merge_map(unsigned int shndx);
-
-  // Get or make the the Input_merge_map to use for the section SHNDX
-  // with MERGE_MAP.
-  Input_merge_map*
-  get_or_make_input_merge_map(const Merge_map* merge_map, unsigned int shndx);
-
-  // Any given object file will normally only have a couple of input
-  // sections with mergeable contents.  So we keep the first two input
-  // section numbers inline, and push any further ones into a map.  A
-  // value of -1U in first_shnum_ or second_shnum_ means that we don't
-  // have a corresponding entry.
-  unsigned int first_shnum_;
-  Input_merge_map first_map_;
-  unsigned int second_shnum_;
-  Input_merge_map second_map_;
-  Section_merge_maps section_merge_maps_;
-};
+// Class Object_merge_map.
 
 // Destructor.
 
@@ -162,7 +68,7 @@ Object_merge_map::get_or_make_input_merge_map(const Merge_map* merge_map,
   if (map != NULL)
     {
       // For a given input section in a given object, every mapping
-      // must be donw with the same Merge_map.
+      // must be done with the same Merge_map.
       gold_assert(map->merge_map == merge_map);
       return map;
     }
@@ -234,14 +140,15 @@ Object_merge_map::add_mapping(const Merge_map* merge_map, unsigned int shndx,
 
 // Get the output offset for an input address.
 
-inline bool
+bool
 Object_merge_map::get_output_offset(const Merge_map* merge_map,
                                    unsigned int shndx,
                                    section_offset_type input_offset,
                                    section_offset_type *output_offset)
 {
   Input_merge_map* map = this->get_input_merge_map(shndx);
-  if (map == NULL || map->merge_map != merge_map)
+  if (map == NULL
+      || (merge_map != NULL && map->merge_map != merge_map))
     return false;
 
   if (!map->sorted)
@@ -274,11 +181,60 @@ Object_merge_map::get_output_offset(const Merge_map* merge_map,
   return true;
 }
 
+// Return whether this is the merge map for section SHNDX.
+
+inline bool
+Object_merge_map::is_merge_section_for(const Merge_map* merge_map,
+                                      unsigned int shndx)
+{
+  Input_merge_map* map = this->get_input_merge_map(shndx);
+  return map != NULL && map->merge_map == merge_map;
+}
+
+// Initialize a mapping from input offsets to output addresses.
+
+template<int size>
+void
+Object_merge_map::initialize_input_to_output_map(
+    unsigned int shndx,
+    typename elfcpp::Elf_types<size>::Elf_Addr starting_address,
+    Unordered_map<section_offset_type,
+                 typename elfcpp::Elf_types<size>::Elf_Addr>* initialize_map)
+{
+  Input_merge_map* map = this->get_input_merge_map(shndx);
+  gold_assert(map != NULL);
+
+  gold_assert(initialize_map->empty());
+  // We know how many entries we are going to add.
+  // reserve_unordered_map takes an expected count of buckets, not a
+  // count of elements, so double it to try to reduce collisions.
+  reserve_unordered_map(initialize_map, map->entries.size() * 2);
+
+  for (Input_merge_map::Entries::const_iterator p = map->entries.begin();
+       p != map->entries.end();
+       ++p)
+    {
+      section_offset_type output_offset = p->output_offset;
+      if (output_offset != -1)
+       output_offset += starting_address;
+      else
+       {
+         // If we see a relocation against an address we have chosen
+         // to discard, we relocate to zero.  FIXME: We could also
+         // issue a warning in this case; that would require
+         // reporting this somehow and checking it in the routines in
+         // reloc.h.
+         output_offset = 0;
+       }
+      initialize_map->insert(std::make_pair(p->input_offset, output_offset));
+    }
+}
+
 // Class Merge_map.
 
 // Add a mapping for the bytes from OFFSET to OFFSET + LENGTH in input
-// section SHNDX in object OBJECT to an OUTPUT_OFFSET in a merged
-// output section.
+// section SHNDX in object OBJECT to an OUTPUT_OFFSET in merged data
+// in an output section.
 
 void
 Merge_map::add_mapping(Relobj* object, unsigned int shndx,
@@ -297,10 +253,11 @@ Merge_map::add_mapping(Relobj* object, unsigned int shndx,
 
 // Return the output offset for an input address.  The input address
 // is at offset OFFSET in section SHNDX in OBJECT.  This sets
-// *OUTPUT_OFFSET to the offset in the output section.  This returns
-// true if the mapping is known, false otherwise.
+// *OUTPUT_OFFSET to the offset in the merged data in the output
+// section.  This returns true if the mapping is known, false
+// otherwise.
 
-inline bool
+bool
 Merge_map::get_output_offset(const Relobj* object, unsigned int shndx,
                             section_offset_type offset,
                             section_offset_type* output_offset) const
@@ -312,6 +269,17 @@ Merge_map::get_output_offset(const Relobj* object, unsigned int shndx,
                                             output_offset);
 }
 
+// Return whether this is the merge section for SHNDX in OBJECT.
+
+bool
+Merge_map::is_merge_section_for(const Relobj* object, unsigned int shndx) const
+{
+  Object_merge_map* object_merge_map = object->merge_map();
+  if (object_merge_map == NULL)
+    return false;
+  return object_merge_map->is_merge_section_for(this, shndx);
+}
+
 // Class Output_merge_base.
 
 // Return the output offset for an input offset.  The input address is
@@ -321,10 +289,19 @@ Merge_map::get_output_offset(const Relobj* object, unsigned int shndx,
 bool
 Output_merge_base::do_output_offset(const Relobj* object,
                                    unsigned int shndx,
-                                   section_offset_type offset,
+                                   section_offset_type off,
                                    section_offset_type* poutput) const
 {
-  return this->merge_map_.get_output_offset(object, shndx, offset, poutput);
+  return this->merge_map_.get_output_offset(object, shndx, off, poutput);
+}
+
+// Return whether this is the merge section for SHNDX in OBJECT.
+
+bool
+Output_merge_base::do_is_merge_section_for(const Relobj* object,
+                                          unsigned int shndx) const
+{
+  return this->merge_map_.is_merge_section_for(object, shndx);
 }
 
 // Class Output_merge_data.
@@ -377,10 +354,10 @@ Output_merge_data::Merge_data_eq::operator()(Merge_data_key k1,
 void
 Output_merge_data::add_constant(const unsigned char* p)
 {
-  section_size_type entsize = convert_to_section_size_type(this->entsize());
-  section_size_type addralign =
+  section_size_type ent_size = convert_to_section_size_type(this->entsize());
+  section_size_type addr_align =
     convert_to_section_size_type(this->addralign());
-  section_size_type addsize = std::max(entsize, addralign);
+  section_size_type addsize = std::max(ent_size, addr_align);
   if (this->len_ + addsize > this->alc_)
     {
       if (this->alc_ == 0)
@@ -392,9 +369,9 @@ Output_merge_data::add_constant(const unsigned char* p)
        gold_nomem();
     }
 
-  memcpy(this->p_ + this->len_, p, entsize);
-  if (addsize > entsize)
-    memset(this->p_ + this->len_ + entsize, 0, addsize - entsize);
+  memcpy(this->p_ + this->len_, p, ent_size);
+  if (addsize > ent_size)
+    memset(this->p_ + this->len_ + ent_size, 0, addsize - ent_size);
   this->len_ += addsize;
 }
 
@@ -409,14 +386,14 @@ Output_merge_data::do_add_input_section(Relobj* object, unsigned int shndx)
   section_size_type len;
   const unsigned char* p = object->section_contents(shndx, &len, false);
 
-  section_size_type entsize = convert_to_section_size_type(this->entsize());
+  section_size_type ent_size = convert_to_section_size_type(this->entsize());
 
-  if (len % entsize != 0)
+  if (len % ent_size != 0)
     return false;
 
-  this->input_count_ += len / entsize;
+  this->input_count_ += len / ent_size;
 
-  for (section_size_type i = 0; i < len; i += entsize, p += entsize)
+  for (section_size_type i = 0; i < len; i += ent_size, p += ent_size)
     {
       // Add the constant to the section contents.  If we find that it
       // is already in the hash table, we will remove it again.
@@ -429,12 +406,12 @@ Output_merge_data::do_add_input_section(Relobj* object, unsigned int shndx)
       if (!ins.second)
        {
          // Key was already present.  Remove the copy we just added.
-         this->len_ -= entsize;
+         this->len_ -= ent_size;
          k = *ins.first;
        }
 
       // Record the offset of this constant in the output section.
-      this->add_mapping(object, shndx, i, entsize, k);
+      this->add_mapping(object, shndx, i, ent_size, k);
     }
 
   return true;
@@ -494,7 +471,7 @@ Output_merge_string<Char_type>::do_add_input_section(Relobj* object,
   const unsigned char* pdata = object->section_contents(shndx, &len, false);
 
   const Char_type* p = reinterpret_cast<const Char_type*>(pdata);
-  const Char_type* pend = p + len;
+  const Char_type* pend = p + len / sizeof(Char_type);
 
   if (len % sizeof(Char_type) != 0)
     {
@@ -514,8 +491,10 @@ Output_merge_string<Char_type>::do_add_input_section(Relobj* object,
        {
          if (pl >= pend)
            {
-             object->error(_("entry in mergeable string section "
-                             "not null terminated"));
+             gold_warning(_("%s: last entry in mergeable string section '%s' "
+                            "not null terminated"),
+                          object->name().c_str(),
+                          object->section_name(shndx).c_str());
              break;
            }
        }
@@ -552,12 +531,14 @@ Output_merge_string<Char_type>::finalize_merged_data()
        p != this->merged_strings_.end();
        ++p)
     {
-      section_offset_type offset =
+      section_offset_type soffset =
        this->stringpool_.get_offset_from_key(p->stringpool_key);
-      this->add_mapping(p->object, p->shndx, p->offset, p->length, offset);
+      this->add_mapping(p->object, p->shndx, p->offset, p->length, soffset);
     }
 
-  // Save some memory.
+  // Save some memory.  This also ensures that this function will work
+  // if called twice, as may happen if Layout::set_segment_offsets
+  // finds a better alignment.
   this->merged_strings_.clear();
 
   return this->stringpool_.get_strtab_size();
@@ -645,4 +626,22 @@ class Output_merge_string<uint16_t>;
 template
 class Output_merge_string<uint32_t>;
 
+#if defined(HAVE_TARGET_32_LITTLE) || defined(HAVE_TARGET_32_BIG)
+template
+void
+Object_merge_map::initialize_input_to_output_map<32>(
+    unsigned int shndx,
+    elfcpp::Elf_types<32>::Elf_Addr starting_address,
+    Unordered_map<section_offset_type, elfcpp::Elf_types<32>::Elf_Addr>*);
+#endif
+
+#if defined(HAVE_TARGET_64_LITTLE) || defined(HAVE_TARGET_64_BIG)
+template
+void
+Object_merge_map::initialize_input_to_output_map<64>(
+    unsigned int shndx,
+    elfcpp::Elf_types<64>::Elf_Addr starting_address,
+    Unordered_map<section_offset_type, elfcpp::Elf_types<64>::Elf_Addr>*);
+#endif
+
 } // End namespace gold.
This page took 0.047959 seconds and 4 git commands to generate.