static int send_channel_streams(int sock,
struct ust_app_channel *uchan)
{
- int ret, fds[2];
- struct ltt_ust_stream *stream;
+ int ret, fd;
struct lttcomm_consumer_msg lum;
- struct cds_lfht_iter iter;
- struct cds_lfht_node *node;
+ struct ltt_ust_stream *stream;
DBG("Sending streams of channel %s to UST consumer", uchan->name);
perror("send consumer channel");
goto error;
}
- fds[0] = uchan->obj->shm_fd;
- fds[1] = uchan->obj->wait_fd;
- ret = lttcomm_send_fds_unix_sock(sock, fds, 2);
+ fd = uchan->obj->shm_fd;
+ ret = lttcomm_send_fds_unix_sock(sock, &fd, 1);
if (ret < 0) {
perror("send consumer channel ancillary data");
goto error;
}
-
- rcu_read_lock();
- hashtable_get_first(uchan->streams, &iter);
- while ((node = hashtable_iter_get_node(&iter)) != NULL) {
- stream = caa_container_of(node, struct ltt_ust_stream, node);
-
+ cds_list_for_each_entry(stream, &uchan->streams.head, list) {
int fds[2];
if (!stream->obj->shm_fd) {
- goto next;
+ continue;
}
-
lum.cmd_type = LTTNG_CONSUMER_ADD_STREAM;
lum.u.stream.channel_key = uchan->obj->shm_fd;
lum.u.stream.stream_key = stream->obj->shm_fd;
perror("send consumer stream ancillary data");
goto error;
}
-
-next:
- hashtable_get_next(uchan->streams, &iter);
}
- rcu_read_unlock();
DBG("consumer channel streams sent");
DBG("Sending metadata stream fd");
if (usess->metadata->obj->shm_fd != 0) {
+ int fd;
int fds[2];
/* Send metadata channel fd */
lum.cmd_type = LTTNG_CONSUMER_ADD_CHANNEL;
lum.u.channel.channel_key = usess->metadata->obj->shm_fd;
lum.u.channel.max_sb_size = usess->metadata->attr.subbuf_size;
- lum.u.channel.mmap_len = 0; /* for kernel */
+ lum.u.channel.mmap_len = usess->metadata->obj->memory_map_size;
DBG("Sending metadata channel %d to consumer", lum.u.channel.channel_key);
ret = lttcomm_send_unix_sock(sock, &lum, sizeof(lum));
if (ret < 0) {
perror("send consumer channel");
goto error;
}
- fds[0] = usess->metadata->obj->shm_fd;
- fds[1] = usess->metadata->obj->wait_fd;
- ret = lttcomm_send_fds_unix_sock(sock, fds, 2);
+ fd = usess->metadata->obj->shm_fd;
+ ret = lttcomm_send_fds_unix_sock(sock, &fd, 1);
if (ret < 0) {
perror("send consumer metadata channel");
goto error;
ret = send_channel_streams(sock, uchan);
if (ret < 0) {
+ rcu_read_unlock();
goto error;
}
hashtable_get_next(usess->channels, &iter);