bt2: make bt_bt2_trace_{,class}_add_destruction_listener return a status

[babeltrace.git] / src / bindings / python / bt2 / bt2 / native_bt_trace_class.i

diff --git a/src/bindings/python/bt2/bt2/native_bt_trace_class.i b/src/bindings/python/bt2/bt2/native_bt_trace_class.i
index 57166bc9a3e944e1ae1cf11057175d1862263930..60c3e7d82ce085d350ed1e4e455ef0db825cb731 100644 (file)
--- a/src/bindings/python/bt2/bt2/native_bt_trace_class.i
+++ b/src/bindings/python/bt2/bt2/native_bt_trace_class.i
@@ -41,7 +41,7 @@ trace_class_destroyed_listener(const bt_trace_class *trace_class, void *py_calla
        }
 
        py_res = PyObject_CallFunction(py_callable, "(O)", py_trace_class_ptr);
-       if (py_res != NULL) {
+       if (py_res) {
                BT_ASSERT(py_res == Py_None);
        } else {
                loge_exception();
@@ -51,25 +51,24 @@ trace_class_destroyed_listener(const bt_trace_class *trace_class, void *py_calla
        Py_XDECREF(py_res);
 }
 
-uint64_t bt_bt2_trace_class_add_destruction_listener(bt_trace_class *trace_class,
-       PyObject *py_callable)
+int bt_bt2_trace_class_add_destruction_listener(
+               bt_trace_class *trace_class, PyObject *py_callable,
+               uint64_t *id)
 {
-       uint64_t id = UINT64_C(-1);
        bt_trace_class_add_listener_status status;
 
        BT_ASSERT(trace_class);
        BT_ASSERT(py_callable);
        status = bt_trace_class_add_destruction_listener(
-               trace_class, trace_class_destroyed_listener, py_callable, &id);
-       if (status != __BT_FUNC_STATUS_OK) {
-               BT_LOGF_STR("Failed to add trace class destruction listener.");
-               abort();
+               trace_class, trace_class_destroyed_listener, py_callable, id);
+       if (status == __BT_FUNC_STATUS_OK) {
+               Py_INCREF(py_callable);
        }
 
-       Py_INCREF(py_callable);
-       return id;
+       return status;
 }
 %}
 
-uint64_t bt_bt2_trace_class_add_destruction_listener(bt_trace_class *trace_class,
-       PyObject *py_callable);
+int bt_bt2_trace_class_add_destruction_listener(
+               bt_trace_class *trace_class, PyObject *py_callable,
+               uint64_t *id);