#include <assert.h>
#include <common/error.h>
#include <common/macros.h>
-#include <common/snapshot.h>
-#include <common/payload.h>
#include <common/payload-view.h>
+#include <common/payload.h>
+#include <common/snapshot.h>
+#include <inttypes.h>
#include <lttng/action/action-internal.h>
+#include <lttng/action/rate-policy-internal.h>
+#include <lttng/action/rate-policy.h>
#include <lttng/action/snapshot-session-internal.h>
#include <lttng/action/snapshot-session.h>
-#include <lttng/snapshot.h>
#include <lttng/snapshot-internal.h>
-#include <inttypes.h>
+#include <lttng/snapshot.h>
#define IS_SNAPSHOT_SESSION_ACTION(action) \
(lttng_action_get_type(action) == LTTNG_ACTION_TYPE_SNAPSHOT_SESSION)
* Owned by this.
*/
struct lttng_snapshot_output *output;
+ struct lttng_rate_policy *policy;
};
struct lttng_action_snapshot_session_comm {
/* All string lengths include the trailing \0. */
uint32_t session_name_len;
uint32_t snapshot_output_len;
+ uint32_t rate_policy_len;
/*
* Variable data (all strings are null-terminated):
*
* - session name string
* - snapshot output object
- *
+ * - policy object
*/
char data[];
} LTTNG_PACKED;
+static const struct lttng_rate_policy *
+lttng_action_snapshot_session_internal_get_rate_policy(
+ const struct lttng_action *action);
+
static struct lttng_action_snapshot_session *
action_snapshot_session_from_action(struct lttng_action *action)
{
goto end;
}
- is_equal = true;
+ is_equal = lttng_rate_policy_is_equal(a->policy, b->policy);
end:
return is_equal;
}
assert(payload);
size_before_comm = payload->buffer.size;
- size_before_comm = size_before_comm + sizeof(comm);
action_snapshot_session = action_snapshot_session_from_action(action);
comm.session_name_len =
goto end;
}
- /* Adjust action length in header. */
comm_in_payload = (typeof(comm_in_payload))(
payload->buffer.data + size_before_comm);
+ /* Adjust action length in header. */
comm_in_payload->snapshot_output_len =
payload->buffer.size - size_before_output;
}
+ /* Serialize the rate policy. */
+ {
+ const size_t size_before_output = payload->buffer.size;
+ struct lttng_action_snapshot_session_comm *comm_in_payload;
+
+ ret = lttng_rate_policy_serialize(
+ action_snapshot_session->policy, payload);
+ if (ret) {
+ ret = -1;
+ goto end;
+ }
+
+ comm_in_payload = (typeof(comm_in_payload))(
+ payload->buffer.data + size_before_comm);
+ /* Adjust rate policy length in header. */
+ comm_in_payload->rate_policy_len =
+ payload->buffer.size - size_before_output;
+ }
+
end:
return ret;
}
free(action_snapshot_session->session_name);
lttng_snapshot_output_destroy(action_snapshot_session->output);
+ lttng_rate_policy_destroy(action_snapshot_session->policy);
free(action_snapshot_session);
end:
struct lttng_action **p_action)
{
ssize_t consumed_len;
- const struct lttng_action_snapshot_session_comm *comm;
const char *variable_data;
struct lttng_action *action;
enum lttng_action_status status;
struct lttng_snapshot_output *snapshot_output = NULL;
+ struct lttng_rate_policy *policy = NULL;
+ const struct lttng_action_snapshot_session_comm *comm;
+ const struct lttng_payload_view snapshot_session_comm_view =
+ lttng_payload_view_from_view(
+ view, 0, sizeof(*comm));
action = lttng_action_snapshot_session_create();
if (!action) {
goto error;
}
- comm = (typeof(comm)) view->buffer.data;
+ if (!lttng_payload_view_is_valid(&snapshot_session_comm_view)) {
+ /* Payload not large enough to contain the header. */
+ goto error;
+ }
+
+ comm = (typeof(comm)) snapshot_session_comm_view.buffer.data;
variable_data = (const char *) &comm->data;
consumed_len = sizeof(struct lttng_action_snapshot_session_comm);
lttng_payload_view_from_view(view, consumed_len,
comm->snapshot_output_len);
- if (!snapshot_output_buffer_view.buffer.data) {
+ if (!lttng_payload_view_is_valid(&snapshot_output_buffer_view)) {
ERR("Failed to create buffer view for snapshot output.");
goto error;
}
variable_data += comm->snapshot_output_len;
consumed_len += comm->snapshot_output_len;
+
+ /* Rate policy. */
+ if (comm->rate_policy_len <= 0) {
+ ERR("Rate policy should be present.");
+ goto error;
+ }
+ {
+ ssize_t rate_policy_consumed_len;
+ struct lttng_payload_view policy_view =
+ lttng_payload_view_from_view(view, consumed_len,
+ comm->rate_policy_len);
+
+ if (!lttng_payload_view_is_valid(&policy_view)) {
+ ERR("Failed to create buffer view for rate policy.");
+ goto error;
+ }
+
+ rate_policy_consumed_len =
+ lttng_rate_policy_create_from_payload(
+ &policy_view, &policy);
+ if (rate_policy_consumed_len < 0) {
+ goto error;
+ }
+
+ if (rate_policy_consumed_len != comm->rate_policy_len) {
+ ERR("Failed to deserialize rate policy object: "
+ "consumed-len: %zd, expected-len: %" PRIu32,
+ rate_policy_consumed_len,
+ comm->rate_policy_len);
+ goto error;
+ }
+
+ status = lttng_action_snapshot_session_set_rate_policy(
+ action, policy);
+ if (status != LTTNG_ACTION_STATUS_OK) {
+ goto error;
+ }
+ }
+
+ variable_data += comm->rate_policy_len;
+ consumed_len += comm->rate_policy_len;
+
*p_action = action;
action = NULL;
consumed_len = -1;
end:
+ lttng_rate_policy_destroy(policy);
lttng_action_snapshot_session_destroy(action);
lttng_snapshot_output_destroy(snapshot_output);
struct lttng_action *lttng_action_snapshot_session_create(void)
{
- struct lttng_action *action;
+ struct lttng_action *action = NULL;
+ struct lttng_rate_policy *policy = NULL;
+ enum lttng_action_status status;
+
+ /* Create a every N = 1 rate policy. */
+ policy = lttng_rate_policy_every_n_create(1);
+ if (!policy) {
+ goto end;
+ }
action = zmalloc(sizeof(struct lttng_action_snapshot_session));
if (!action) {
lttng_action_snapshot_session_validate,
lttng_action_snapshot_session_serialize,
lttng_action_snapshot_session_is_equal,
- lttng_action_snapshot_session_destroy);
+ lttng_action_snapshot_session_destroy,
+ lttng_action_snapshot_session_internal_get_rate_policy,
+ lttng_action_generic_add_error_query_results);
+
+ status = lttng_action_snapshot_session_set_rate_policy(action, policy);
+ if (status != LTTNG_ACTION_STATUS_OK) {
+ free(action);
+ action = NULL;
+ goto end;
+ }
end:
+ lttng_rate_policy_destroy(policy);
return action;
}
end:
return status;
}
+
+enum lttng_action_status lttng_action_snapshot_session_set_rate_policy(
+ struct lttng_action *action,
+ const struct lttng_rate_policy *policy)
+{
+ enum lttng_action_status status;
+ struct lttng_action_snapshot_session *snapshot_session_action;
+ struct lttng_rate_policy *copy = NULL;
+
+ if (!action || !policy || !IS_SNAPSHOT_SESSION_ACTION(action)) {
+ status = LTTNG_ACTION_STATUS_INVALID;
+ goto end;
+ }
+
+ copy = lttng_rate_policy_copy(policy);
+ if (!copy) {
+ status = LTTNG_ACTION_STATUS_ERROR;
+ goto end;
+ }
+
+ snapshot_session_action = action_snapshot_session_from_action(action);
+
+ /* Free the previous rate policy .*/
+ lttng_rate_policy_destroy(snapshot_session_action->policy);
+
+ /* Assign the policy. */
+ snapshot_session_action->policy = copy;
+ status = LTTNG_ACTION_STATUS_OK;
+ copy = NULL;
+
+end:
+ lttng_rate_policy_destroy(copy);
+ return status;
+}
+
+enum lttng_action_status lttng_action_snapshot_session_get_rate_policy(
+ const struct lttng_action *action,
+ const struct lttng_rate_policy **policy)
+{
+ enum lttng_action_status status;
+ const struct lttng_action_snapshot_session *snapshot_session_action;
+
+ if (!action || !policy || !IS_SNAPSHOT_SESSION_ACTION(action)) {
+ status = LTTNG_ACTION_STATUS_INVALID;
+ goto end;
+ }
+
+ snapshot_session_action =
+ action_snapshot_session_from_action_const(action);
+
+ *policy = snapshot_session_action->policy;
+ status = LTTNG_ACTION_STATUS_OK;
+end:
+ return status;
+}
+
+static const struct lttng_rate_policy *
+lttng_action_snapshot_session_internal_get_rate_policy(
+ const struct lttng_action *action)
+{
+ const struct lttng_action_snapshot_session *_action;
+ _action = action_snapshot_session_from_action_const(action);
+
+ return _action->policy;
+}