ctf: allocate some structures with new
[babeltrace.git] / src / plugins / ctf / lttng-live / lttng-live.cpp
index be6d7ba97adfacb0907c3493db9943e8d56c582a..0d9a70447c80c893ac18239fecbd9e98a4445220 100644 (file)
@@ -8,28 +8,25 @@
  * Babeltrace CTF LTTng-live Client Component
  */
 
+#include <glib.h>
+#include <inttypes.h>
+#include <unistd.h>
+
+#include <babeltrace2/babeltrace.h>
+
 #define BT_COMP_LOG_SELF_COMP self_comp
 #define BT_LOG_OUTPUT_LEVEL   log_level
 #define BT_LOG_TAG            "PLUGIN/SRC.CTF.LTTNG-LIVE"
 #include "logging/comp-logging.h"
 
-#include <inttypes.h>
-#include <stdbool.h>
-#include <unistd.h>
-
-#include <glib.h>
-
 #include "common/assert.h"
-#include <babeltrace2/babeltrace.h>
-#include "compat/compiler.h"
-#include <babeltrace2/types.h>
 
 #include "plugins/common/muxing/muxing.h"
 #include "plugins/common/param-validation/param-validation.h"
 
 #include "data-stream.hpp"
-#include "metadata.hpp"
 #include "lttng-live.hpp"
+#include "metadata.hpp"
 
 #define MAX_QUERY_SIZE                     (256 * 1024)
 #define URL_PARAM                          "url"
@@ -156,24 +153,20 @@ static void lttng_live_destroy_trace(struct lttng_live_trace *trace)
     BT_TRACE_CLASS_PUT_REF_AND_RESET(trace->trace_class);
 
     lttng_live_metadata_fini(trace);
-    g_free(trace);
+    delete trace;
 }
 
 static struct lttng_live_trace *lttng_live_create_trace(struct lttng_live_session *session,
                                                         uint64_t trace_id)
 {
-    struct lttng_live_trace *trace = NULL;
     bt_logging_level log_level = session->log_level;
     bt_self_component *self_comp = session->self_comp;
 
     BT_COMP_LOGD("Creating live trace: "
                  "session-id=%" PRIu64 ", trace-id=%" PRIu64,
                  session->id, trace_id);
-    trace = g_new0(struct lttng_live_trace, 1);
-    if (!trace) {
-        BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Failed to allocate live trace");
-        goto error;
-    }
+
+    lttng_live_trace *trace = new lttng_live_trace;
     trace->log_level = session->log_level;
     trace->self_comp = session->self_comp;
     trace->session = session;
@@ -186,11 +179,6 @@ static struct lttng_live_trace *lttng_live_create_trace(struct lttng_live_sessio
     trace->metadata_stream_state = LTTNG_LIVE_METADATA_STREAM_STATE_NEEDED;
     g_ptr_array_add(session->traces, trace);
 
-    goto end;
-error:
-    g_free(trace);
-    trace = NULL;
-end:
     return trace;
 }
 
@@ -215,8 +203,6 @@ end:
 int lttng_live_add_session(struct lttng_live_msg_iter *lttng_live_msg_iter, uint64_t session_id,
                            const char *hostname, const char *session_name)
 {
-    int ret = 0;
-    struct lttng_live_session *session;
     bt_logging_level log_level = lttng_live_msg_iter->log_level;
     bt_self_component *self_comp = lttng_live_msg_iter->self_comp;
 
@@ -224,12 +210,7 @@ int lttng_live_add_session(struct lttng_live_msg_iter *lttng_live_msg_iter, uint
                  "session-id=%" PRIu64 ", hostname=\"%s\" session-name=\"%s\"",
                  session_id, hostname, session_name);
 
-    session = g_new0(struct lttng_live_session, 1);
-    if (!session) {
-        BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Failed to allocate live session");
-        goto error;
-    }
-
+    lttng_live_session *session = new lttng_live_session;
     session->log_level = lttng_live_msg_iter->log_level;
     session->self_comp = lttng_live_msg_iter->self_comp;
     session->id = session_id;
@@ -244,12 +225,8 @@ int lttng_live_add_session(struct lttng_live_msg_iter *lttng_live_msg_iter, uint
     BT_ASSERT(session->session_name);
 
     g_ptr_array_add(lttng_live_msg_iter->sessions, session);
-    goto end;
-error:
-    g_free(session);
-    ret = -1;
-end:
-    return ret;
+
+    return 0;
 }
 
 static void lttng_live_destroy_session(struct lttng_live_session *session)
@@ -283,10 +260,12 @@ static void lttng_live_destroy_session(struct lttng_live_session *session)
     if (session->hostname) {
         g_string_free(session->hostname, TRUE);
     }
+
     if (session->session_name) {
         g_string_free(session->session_name, TRUE);
     }
-    g_free(session);
+
+    delete session;
 
 end:
     return;
@@ -312,7 +291,7 @@ static void lttng_live_msg_iter_destroy(struct lttng_live_msg_iter *lttng_live_m
     BT_ASSERT(lttng_live_msg_iter->active_stream_iter == 0);
     lttng_live_msg_iter->lttng_live_comp->has_msg_iter = false;
 
-    g_free(lttng_live_msg_iter);
+    delete lttng_live_msg_iter;
 
 end:
     return;
@@ -720,8 +699,7 @@ end:
     return ret;
 }
 
-static int live_get_msg_ts_ns(struct lttng_live_stream_iterator *stream_iter,
-                              struct lttng_live_msg_iter *lttng_live_msg_iter,
+static int live_get_msg_ts_ns(struct lttng_live_msg_iter *lttng_live_msg_iter,
                               const bt_message *msg, int64_t last_msg_ts_ns, int64_t *ts_ns)
 {
     const bt_clock_snapshot *clock_snapshot = NULL;
@@ -1113,7 +1091,7 @@ handle_late_message(struct lttng_live_msg_iter *lttng_live_msg_iter,
      * by this component. We CANNOT send it as is.
      *
      * The only expected scenario in which that could happen is the
-     * following, everything else is a bug in this component, relay deamon,
+     * following, everything else is a bug in this component, relay daemon,
      * or CTF parser.
      *
      * Expected scenario: The CTF message iterator emitted discarded
@@ -1280,10 +1258,10 @@ next_stream_iterator_for_trace(struct lttng_live_msg_iter *lttng_live_msg_iter,
 
             /*
              * Get the timestamp in nanoseconds from origin of this
-             * messsage.
+             * message.
              */
-            live_get_msg_ts_ns(stream_iter, lttng_live_msg_iter, msg,
-                               lttng_live_msg_iter->last_msg_ts_ns, &curr_msg_ts_ns);
+            live_get_msg_ts_ns(lttng_live_msg_iter, msg, lttng_live_msg_iter->last_msg_ts_ns,
+                               &curr_msg_ts_ns);
 
             /*
              * Check if the message of the current live stream
@@ -1688,7 +1666,7 @@ lttng_live_msg_iter_next(bt_self_message_iterator *self_msg_it, bt_message_array
 
         /*
          * Insert the next message to the message batch. This will set
-         * stream iterator current messsage to NULL so that next time
+         * stream iterator current message to NULL so that next time
          * we fetch the next message of that stream iterator
          */
         BT_MESSAGE_MOVE_REF(msgs[*count], youngest_stream_iter->current_msg);
@@ -1708,7 +1686,7 @@ return_status:
         /*
          * If we gathered messages, return _OK even if the graph was
          * interrupted. This allows for the components downstream to at
-         * least get the thoses messages. If the graph was indeed
+         * least get the those messages. If the graph was indeed
          * interrupted there should not be another _next() call as the
          * application will tear down the graph. This component class
          * doesn't support restarting after an interruption.
@@ -1753,15 +1731,7 @@ static struct lttng_live_msg_iter *
 lttng_live_msg_iter_create(struct lttng_live_component *lttng_live_comp,
                            bt_self_message_iterator *self_msg_it)
 {
-    bt_self_component *self_comp = lttng_live_comp->self_comp;
-    bt_logging_level log_level = lttng_live_comp->log_level;
-
-    struct lttng_live_msg_iter *lttng_live_msg_iter = g_new0(struct lttng_live_msg_iter, 1);
-    if (!lttng_live_msg_iter) {
-        BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Failed to allocate lttng_live_msg_iter");
-        goto end;
-    }
-
+    lttng_live_msg_iter *lttng_live_msg_iter = new struct lttng_live_msg_iter;
     lttng_live_msg_iter->log_level = lttng_live_comp->log_level;
     lttng_live_msg_iter->self_comp = lttng_live_comp->self_comp;
     lttng_live_msg_iter->lttng_live_comp = lttng_live_comp;
@@ -1775,14 +1745,12 @@ lttng_live_msg_iter_create(struct lttng_live_component *lttng_live_comp,
         g_ptr_array_new_with_free_func((GDestroyNotify) lttng_live_destroy_session);
     BT_ASSERT(lttng_live_msg_iter->sessions);
 
-end:
     return lttng_live_msg_iter;
 }
 
 bt_message_iterator_class_initialize_method_status
 lttng_live_msg_iter_init(bt_self_message_iterator *self_msg_it,
-                         bt_self_message_iterator_configuration *config,
-                         bt_self_component_port_output *self_port)
+                         bt_self_message_iterator_configuration *, bt_self_component_port_output *)
 {
     bt_message_iterator_class_initialize_method_status status;
     struct lttng_live_component *lttng_live;
@@ -1958,7 +1926,7 @@ lttng_live_query_support_info(const bt_value *params, const bt_value **result,
     const bt_value *input_type_value;
     const bt_value *input_value;
     double weight = 0;
-    struct bt_common_lttng_live_url_parts parts = {0};
+    struct bt_common_lttng_live_url_parts parts = {};
 
     /* Used by the logging macros */
     __attribute__((unused)) bt_self_component *self_comp = NULL;
@@ -2054,10 +2022,12 @@ static void lttng_live_component_destroy_data(struct lttng_live_component *lttng
     if (!lttng_live) {
         return;
     }
+
     if (lttng_live->params.url) {
         g_string_free(lttng_live->params.url, TRUE);
     }
-    g_free(lttng_live);
+
+    delete lttng_live;
 }
 
 void lttng_live_component_finalize(bt_self_component_source *component)
@@ -2128,11 +2098,7 @@ lttng_live_component_create(const bt_value *params, bt_logging_level log_level,
         goto error;
     }
 
-    lttng_live = g_new0(struct lttng_live_component, 1);
-    if (!lttng_live) {
-        status = BT_COMPONENT_CLASS_INITIALIZE_METHOD_STATUS_MEMORY_ERROR;
-        goto end;
-    }
+    lttng_live = new lttng_live_component;
     lttng_live->log_level = log_level;
     lttng_live->self_comp = self_comp;
     lttng_live->max_query_size = MAX_QUERY_SIZE;
@@ -2173,8 +2139,7 @@ end:
 
 bt_component_class_initialize_method_status
 lttng_live_component_init(bt_self_component_source *self_comp_src,
-                          bt_self_component_source_configuration *config, const bt_value *params,
-                          __attribute__((unused)) void *init_method_data)
+                          bt_self_component_source_configuration *, const bt_value *params, void *)
 {
     struct lttng_live_component *lttng_live;
     bt_component_class_initialize_method_status ret;
This page took 0.029412 seconds and 4 git commands to generate.