X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=bfd%2Fhpux-core.c;h=2ecd4f17d5916f780a7e7940fa3b03bf88e76a6a;hb=0490dd41ae89e66efd8b3cee122c189a481269de;hp=5199014307874e8e99bebdc88a24451804368015;hpb=261b8d0859fcd2ee7a43e1b3d2db6b2496bd6d61;p=deliverable%2Fbinutils-gdb.git diff --git a/bfd/hpux-core.c b/bfd/hpux-core.c index 5199014307..2ecd4f17d5 100644 --- a/bfd/hpux-core.c +++ b/bfd/hpux-core.c @@ -1,6 +1,5 @@ /* BFD back-end for HP/UX core files. - Copyright 1993, 1994, 1996, 1998, 1999, 2001, 2002, 2003, 2004, 2005, 2006, - 2007, 2008 Free Software Foundation, Inc. + Copyright (C) 1993-2020 Free Software Foundation, Inc. Written by Stu Grossman, Cygnus Support. Converted to back-end form by Ian Lance Taylor, Cygnus SUpport @@ -29,7 +28,7 @@ #include "bfd.h" #include "libbfd.h" -#if defined (HOST_HPPAHPUX) || defined (HOST_HP300HPUX) || defined (HOST_HPPAMPEIX) +#if defined (HOST_HPPAHPUX) || defined (HOST_HPPAMPEIX) /* FIXME: sys/core.h doesn't exist for HPUX version 7. HPUX version 5, 6, and 7 core files seem to be standard trad-core.c type core @@ -81,7 +80,7 @@ it won't be encountered in core-dumps from older HP-UX's) is harmless. */ #if !defined(CORE_ANON_SHMEM) -#define CORE_ANON_SHMEM 0x00000200 /* anonymous shared memory */ +#define CORE_ANON_SHMEM 0x00000200 /* anonymous shared memory */ #endif /* These are stored in the bfd's tdata */ @@ -92,7 +91,7 @@ struct hpux_core_struct { int sig; - int lwpid; /* Kernel thread ID. */ + int lwpid; /* Kernel thread ID. */ unsigned long user_tid; /* User thread ID. */ char cmd[MAXCOMLEN + 1]; }; @@ -106,16 +105,16 @@ struct hpux_core_struct #define hpux_core_core_file_pid _bfd_nocore_core_file_pid static asection *make_bfd_asection (bfd *, const char *, flagword, - bfd_size_type, bfd_vma, unsigned int); -static const bfd_target *hpux_core_core_file_p (bfd *); + bfd_size_type, bfd_vma, unsigned int); +static bfd_cleanup hpux_core_core_file_p (bfd *); static char *hpux_core_core_file_failing_command (bfd *); static int hpux_core_core_file_failing_signal (bfd *); static void swap_abort (void); static asection * make_bfd_asection (bfd *abfd, const char *name, flagword flags, - bfd_size_type size, bfd_vma vma, - unsigned int alignment_power) + bfd_size_type size, bfd_vma vma, + unsigned int alignment_power) { asection *asect; char *newname; @@ -143,8 +142,8 @@ make_bfd_asection (bfd *abfd, const char *name, flagword flags, static int thread_section_p (bfd *abfd ATTRIBUTE_UNUSED, - asection *sect, - void *obj ATTRIBUTE_UNUSED) + asection *sect, + void *obj ATTRIBUTE_UNUSED) { return CONST_STRNEQ (sect->name, ".reg/"); } @@ -158,7 +157,7 @@ thread_section_p (bfd *abfd ATTRIBUTE_UNUSED, in which the core file is generated by some non-hpux application. (I am just guessing here!) */ -static const bfd_target * +static bfd_cleanup hpux_core_core_file_p (bfd *abfd) { int good_sections = 0; @@ -184,7 +183,7 @@ hpux_core_core_file_p (bfd *abfd) case CORE_FORMAT: /* Just skip this. */ bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR); - good_sections++; + good_sections++; break; case CORE_EXEC: { @@ -193,7 +192,7 @@ hpux_core_core_file_p (bfd *abfd) abfd) != core_header.len) break; strncpy (core_command (abfd), proc_exec.cmd, MAXCOMLEN + 1); - good_sections++; + good_sections++; } break; case CORE_PROC: @@ -201,54 +200,54 @@ hpux_core_core_file_p (bfd *abfd) struct proc_info proc_info; char secname[100]; /* Of arbitrary size, but plenty large. */ - /* We need to read this section, 'cause we need to determine - whether the core-dumped app was threaded before we create - any .reg sections. */ + /* We need to read this section, 'cause we need to determine + whether the core-dumped app was threaded before we create + any .reg sections. */ if (bfd_bread (&proc_info, (bfd_size_type) core_header.len, abfd) != core_header.len) break; - /* However, we also want to create those sections with the - file positioned at the start of the record, it seems. */ - if (bfd_seek (abfd, -((file_ptr) core_header.len), SEEK_CUR) != 0) - break; + /* However, we also want to create those sections with the + file positioned at the start of the record, it seems. */ + if (bfd_seek (abfd, -((file_ptr) core_header.len), SEEK_CUR) != 0) + break; #if defined(PROC_INFO_HAS_THREAD_ID) - core_kernel_thread_id (abfd) = proc_info.lwpid; - core_user_thread_id (abfd) = proc_info.user_tid; + core_kernel_thread_id (abfd) = proc_info.lwpid; + core_user_thread_id (abfd) = proc_info.user_tid; #else - core_kernel_thread_id (abfd) = 0; - core_user_thread_id (abfd) = 0; + core_kernel_thread_id (abfd) = 0; + core_user_thread_id (abfd) = 0; #endif - /* If the program was unthreaded, then we'll just create a - .reg section. - - If the program was threaded, then we'll create .reg/XXXXX - section for each thread, where XXXXX is a printable - representation of the kernel thread id. We'll also - create a .reg section for the thread that was running - and signalled at the time of the core-dump (i.e., this - is effectively an alias, needed to keep GDB happy.) - - Note that we use `.reg/XXXXX' as opposed to '.regXXXXX' - because GDB expects that .reg2 will be the floating- - point registers. */ - if (core_kernel_thread_id (abfd) == 0) - { - if (!make_bfd_asection (abfd, ".reg", + /* If the program was unthreaded, then we'll just create a + .reg section. + + If the program was threaded, then we'll create .reg/XXXXX + section for each thread, where XXXXX is a printable + representation of the kernel thread id. We'll also + create a .reg section for the thread that was running + and signalled at the time of the core-dump (i.e., this + is effectively an alias, needed to keep GDB happy.) + + Note that we use `.reg/XXXXX' as opposed to '.regXXXXX' + because GDB expects that .reg2 will be the floating- + point registers. */ + if (core_kernel_thread_id (abfd) == 0) + { + if (!make_bfd_asection (abfd, ".reg", SEC_HAS_CONTENTS, core_header.len, (bfd_vma) offsetof (struct proc_info, hw_regs), 2)) goto fail; - } - else - { - /* There are threads. Is this the one that caused the - core-dump? We'll claim it was the running thread. */ - if (proc_info.sig != -1) - { + } + else + { + /* There are threads. Is this the one that caused the + core-dump? We'll claim it was the running thread. */ + if (proc_info.sig != -1) + { if (!make_bfd_asection (abfd, ".reg", SEC_HAS_CONTENTS, core_header.len, @@ -256,21 +255,21 @@ hpux_core_core_file_p (bfd *abfd) hw_regs), 2)) goto fail; - } - /* We always make one of these sections, for every thread. */ - sprintf (secname, ".reg/%d", core_kernel_thread_id (abfd)); - if (!make_bfd_asection (abfd, secname, + } + /* We always make one of these sections, for every thread. */ + sprintf (secname, ".reg/%d", core_kernel_thread_id (abfd)); + if (!make_bfd_asection (abfd, secname, SEC_HAS_CONTENTS, core_header.len, (bfd_vma) offsetof (struct proc_info, hw_regs), 2)) goto fail; - } + } core_signal (abfd) = proc_info.sig; - if (bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR) != 0) - break; - good_sections++; + if (bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR) != 0) + break; + good_sections++; } break; @@ -287,20 +286,20 @@ hpux_core_core_file_p (bfd *abfd) goto fail; bfd_seek (abfd, (file_ptr) core_header.len, SEEK_CUR); - good_sections++; + good_sections++; break; case CORE_NONE: - /* Let's not punt if we encounter a section of unknown - type. Rather, let's make a note of it. If we later - see that there were also "good" sections, then we'll - declare that this a core file, but we'll also warn that - it may be incompatible with this gdb. - */ + /* Let's not punt if we encounter a section of unknown + type. Rather, let's make a note of it. If we later + see that there were also "good" sections, then we'll + declare that this a core file, but we'll also warn that + it may be incompatible with this gdb. + */ unknown_sections++; - break; + break; - default: + default: goto fail; /*unrecognized core file type */ } } @@ -319,15 +318,15 @@ hpux_core_core_file_p (bfd *abfd) asection *reg_sect; if (asect != NULL) - { - reg_sect = make_bfd_asection (abfd, ".reg", asect->flags, - asect->size, asect->vma, - asect->alignment_power); - if (reg_sect == NULL) - goto fail; - - reg_sect->filepos = asect->filepos; - } + { + reg_sect = make_bfd_asection (abfd, ".reg", asect->flags, + asect->size, asect->vma, + asect->alignment_power); + if (reg_sect == NULL) + goto fail; + + reg_sect->filepos = asect->filepos; + } } /* Were there sections of unknown type? If so, yet there were @@ -337,11 +336,13 @@ hpux_core_core_file_p (bfd *abfd) built. */ if ((unknown_sections > 0) && (good_sections > 0)) - (*_bfd_error_handler) - ("%s appears to be a core file,\nbut contains unknown sections. It may have been created on an incompatible\nversion of HP-UX. As a result, some information may be unavailable.\n", - abfd->filename); + _bfd_error_handler + ("%pB appears to be a core file,\nbut contains unknown sections." + " It may have been created on an incompatible\nversion of HP-UX." + " As a result, some information may be unavailable.\n", + abfd); - return abfd->xvec; + return _bfd_no_cleanup; fail: bfd_release (abfd, core_hdr (abfd)); @@ -377,7 +378,7 @@ swap_abort (void) #define NO_PUT64 ((void (*) (bfd_uint64_t, void *)) swap_abort) #define NO_GETS64 ((bfd_int64_t (*) (const void *)) swap_abort) -const bfd_target hpux_core_vec = +const bfd_target core_hpux_vec = { "hpux-core", bfd_target_unknown_flavour, @@ -387,9 +388,10 @@ const bfd_target hpux_core_vec = HAS_LINENO | HAS_DEBUG | HAS_SYMS | HAS_LOCALS | WP_TEXT | D_PAGED), (SEC_HAS_CONTENTS | SEC_ALLOC | SEC_LOAD | SEC_RELOC), /* section flags */ - 0, /* symbol prefix */ - ' ', /* ar_pad_char */ - 16, /* ar_max_namelen */ + 0, /* symbol prefix */ + ' ', /* ar_pad_char */ + 16, /* ar_max_namelen */ + 0, /* match priority. */ NO_GET64, NO_GETS64, NO_PUT64, /* 64 bit data */ NO_GET, NO_GETS, NO_PUT, /* 32 bit data */ NO_GET, NO_GETS, NO_PUT, /* 16 bit data */ @@ -404,12 +406,16 @@ const bfd_target hpux_core_vec = hpux_core_core_file_p /* a core file */ }, { /* bfd_set_format */ - bfd_false, bfd_false, - bfd_false, bfd_false + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error }, { /* bfd_write_contents */ - bfd_false, bfd_false, - bfd_false, bfd_false + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error, + _bfd_bool_bfd_false_error }, BFD_JUMP_TABLE_GENERIC (_bfd_generic), @@ -424,5 +430,5 @@ const bfd_target hpux_core_vec = NULL, - (PTR) 0 /* backend_data */ + NULL /* backend_data */ };