X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=binutils%2Fbucomm.c;h=9e6a02843e6c7ba11545f69a6a31e927d177a9b0;hb=refs%2Fheads%2Fconcurrent-displaced-stepping-2020-04-01;hp=cfc7d4e4e2991b4518e455a88fb578ac59ca6384;hpb=485be063485746449d56642a4ed73b18dce247a4;p=deliverable%2Fbinutils-gdb.git diff --git a/binutils/bucomm.c b/binutils/bucomm.c index cfc7d4e4e2..9e6a02843e 100644 --- a/binutils/bucomm.c +++ b/binutils/bucomm.c @@ -1,13 +1,11 @@ /* bucomm.c -- Bin Utils COMmon code. - Copyright 1991, 1992, 1993, 1994, 1995, 1997, 1998, 2000, 2001, 2002, - 2003, 2006 - Free Software Foundation, Inc. + Copyright (C) 1991-2020 Free Software Foundation, Inc. This file is part of GNU Binutils. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or + the Free Software Foundation; either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, @@ -23,27 +21,20 @@ /* We might put this in a library someday so it could be dynamically loaded, but for now it's not necessary. */ +#include "sysdep.h" #include "bfd.h" -#include "bfdver.h" #include "libiberty.h" -#include "bucomm.h" #include "filenames.h" -#include "libbfd.h" -#include #include /* ctime, maybe time_t */ #include +#include "bucomm.h" #ifndef HAVE_TIME_T_IN_TIME_H #ifndef HAVE_TIME_T_IN_TYPES_H typedef long time_t; #endif #endif - -static const char * endian_string (enum bfd_endian); -static int display_target_list (void); -static int display_info_table (int, int); -static int display_target_tables (void); /* Error reporting. */ @@ -52,14 +43,73 @@ char *program_name; void bfd_nonfatal (const char *string) { - const char *errmsg = bfd_errmsg (bfd_get_error ()); + const char *errmsg; + enum bfd_error err = bfd_get_error (); + if (err == bfd_error_no_error) + errmsg = _("cause of error unknown"); + else + errmsg = bfd_errmsg (err); + fflush (stdout); if (string) fprintf (stderr, "%s: %s: %s\n", program_name, string, errmsg); else fprintf (stderr, "%s: %s\n", program_name, errmsg); } +/* Issue a non fatal error message. FILENAME, or if NULL then BFD, + are used to indicate the problematic file. SECTION, if non NULL, + is used to provide a section name. If FORMAT is non-null, then it + is used to print additional information via vfprintf. Finally the + bfd error message is printed. In summary, error messages are of + one of the following forms: + + PROGRAM: file: bfd-error-message + PROGRAM: file[section]: bfd-error-message + PROGRAM: file: printf-message: bfd-error-message + PROGRAM: file[section]: printf-message: bfd-error-message. */ + +void +bfd_nonfatal_message (const char *filename, + const bfd *abfd, + const asection *section, + const char *format, ...) +{ + const char *errmsg; + const char *section_name; + va_list args; + enum bfd_error err = bfd_get_error (); + + if (err == bfd_error_no_error) + errmsg = _("cause of error unknown"); + else + errmsg = bfd_errmsg (err); + fflush (stdout); + section_name = NULL; + va_start (args, format); + fprintf (stderr, "%s", program_name); + + if (abfd) + { + if (!filename) + filename = bfd_get_archive_filename (abfd); + if (section) + section_name = bfd_section_name (section); + } + if (section_name) + fprintf (stderr, ": %s[%s]", filename, section_name); + else + fprintf (stderr, ": %s", filename); + + if (format) + { + fprintf (stderr, ": "); + vfprintf (stderr, format, args); + } + fprintf (stderr, ": %s\n", errmsg); + va_end (args); +} + void bfd_fatal (const char *string) { @@ -70,30 +120,33 @@ bfd_fatal (const char *string) void report (const char * format, va_list args) { + fflush (stdout); fprintf (stderr, "%s: ", program_name); vfprintf (stderr, format, args); putc ('\n', stderr); } void -fatal VPARAMS ((const char *format, ...)) +fatal (const char *format, ...) { - VA_OPEN (args, format); - VA_FIXEDARG (args, const char *, format); + va_list args; + + va_start (args, format); report (format, args); - VA_CLOSE (args); + va_end (args); xexit (1); } void -non_fatal VPARAMS ((const char *format, ...)) +non_fatal (const char *format, ...) { - VA_OPEN (args, format); - VA_FIXEDARG (args, const char *, format); + va_list args; + + va_start (args, format); report (format, args); - VA_CLOSE (args); + va_end (args); } /* Set the default BFD target based on the configured target. Doing @@ -119,6 +172,7 @@ set_default_bfd_target (void) void list_matching_formats (char **p) { + fflush (stdout); fprintf (stderr, _("%s: Matching formats:"), program_name); while (*p) fprintf (stderr, " %s", *p++); @@ -131,13 +185,14 @@ void list_supported_targets (const char *name, FILE *f) { int t; - const char **targ_names = bfd_target_list (); + const char **targ_names; if (name == NULL) fprintf (f, _("Supported targets:")); else fprintf (f, _("%s: supported targets:"), name); + targ_names = bfd_target_list (); for (t = 0; targ_names[t] != NULL; t++) fprintf (f, " %s", targ_names[t]); fprintf (f, "\n"); @@ -149,209 +204,230 @@ list_supported_targets (const char *name, FILE *f) void list_supported_architectures (const char *name, FILE *f) { - const char **arch; + const char ** arch; + const char ** arches; if (name == NULL) fprintf (f, _("Supported architectures:")); else fprintf (f, _("%s: supported architectures:"), name); - for (arch = bfd_arch_list (); *arch; arch++) + for (arch = arches = bfd_arch_list (); *arch; arch++) fprintf (f, " %s", *arch); fprintf (f, "\n"); + free (arches); } -/* The length of the longest architecture name + 1. */ -#define LONGEST_ARCH sizeof ("powerpc:common") - static const char * endian_string (enum bfd_endian endian) { switch (endian) { - case BFD_ENDIAN_BIG: return "big endian"; - case BFD_ENDIAN_LITTLE: return "little endian"; - default: return "endianness unknown"; + case BFD_ENDIAN_BIG: return _("big endian"); + case BFD_ENDIAN_LITTLE: return _("little endian"); + default: return _("endianness unknown"); } } +/* Data passed to do_display_target and other target iterators. */ + +struct display_target { + /* Temp file. */ + char *filename; + /* Return status. */ + int error; + /* Number of targets. */ + int count; + /* Size of info in bytes. */ + size_t alloc; + /* Per-target info. */ + struct { + /* Target name. */ + const char *name; + /* Non-zero if target/arch combination supported. */ + unsigned char arch[bfd_arch_last - bfd_arch_obscure - 1]; + } *info; +}; + /* List the targets that BFD is configured to support, each followed - by its endianness and the architectures it supports. */ + by its endianness and the architectures it supports. Also build + info about target/archs. */ static int -display_target_list (void) +do_display_target (const bfd_target *targ, void *data) { - char *dummy_name; - int t; - int ret = 1; + struct display_target *param = (struct display_target *) data; + bfd *abfd; + size_t amt; - dummy_name = make_temp_file (NULL); - for (t = 0; bfd_target_vector[t]; t++) + param->count += 1; + amt = param->count * sizeof (*param->info); + if (param->alloc < amt) { - const bfd_target *p = bfd_target_vector[t]; - bfd *abfd = bfd_openw (dummy_name, p->name); - enum bfd_architecture a; - - printf ("%s\n (header %s, data %s)\n", p->name, - endian_string (p->header_byteorder), - endian_string (p->byteorder)); + size_t size = ((param->count < 64 ? 64 : param->count) + * sizeof (*param->info) * 2); + param->info = xrealloc (param->info, size); + memset ((char *) param->info + param->alloc, 0, size - param->alloc); + param->alloc = size; + } + param->info[param->count - 1].name = targ->name; - if (abfd == NULL) - { - bfd_nonfatal (dummy_name); - ret = 0; - continue; - } + printf (_("%s\n (header %s, data %s)\n"), targ->name, + endian_string (targ->header_byteorder), + endian_string (targ->byteorder)); - if (! bfd_set_format (abfd, bfd_object)) + abfd = bfd_openw (param->filename, targ->name); + if (abfd == NULL) + { + bfd_nonfatal (param->filename); + param->error = 1; + } + else if (!bfd_set_format (abfd, bfd_object)) + { + if (bfd_get_error () != bfd_error_invalid_operation) { - if (bfd_get_error () != bfd_error_invalid_operation) - { - bfd_nonfatal (p->name); - ret = 0; - } - bfd_close_all_done (abfd); - continue; + bfd_nonfatal (targ->name); + param->error = 1; } + } + else + { + enum bfd_architecture a; for (a = bfd_arch_obscure + 1; a < bfd_arch_last; a++) - if (bfd_set_arch_mach (abfd, (enum bfd_architecture) a, 0)) - printf (" %s\n", - bfd_printable_arch_mach ((enum bfd_architecture) a, 0)); - bfd_close_all_done (abfd); + if (bfd_set_arch_mach (abfd, a, 0)) + { + printf (" %s\n", bfd_printable_arch_mach (a, 0)); + param->info[param->count - 1].arch[a - bfd_arch_obscure - 1] = 1; + } } - unlink (dummy_name); - free (dummy_name); + if (abfd != NULL) + bfd_close_all_done (abfd); - return ret; + return param->error; +} + +static void +display_target_list (struct display_target *arg) +{ + arg->filename = make_temp_file (NULL); + arg->error = 0; + arg->count = 0; + arg->alloc = 0; + arg->info = NULL; + + bfd_iterate_over_targets (do_display_target, arg); + + unlink (arg->filename); + free (arg->filename); } -/* Print a table showing which architectures are supported for entries - FIRST through LAST-1 of bfd_target_vector (targets across, - architectures down). */ +/* Calculate how many targets we can print across the page. */ static int -display_info_table (int first, int last) +do_info_size (int targ, int width, const struct display_target *arg) { - int t; - int ret = 1; - char *dummy_name; - enum bfd_architecture a; - - /* Print heading of target names. */ - printf ("\n%*s", (int) LONGEST_ARCH, " "); - for (t = first; t < last && bfd_target_vector[t]; t++) - printf ("%s ", bfd_target_vector[t]->name); - putchar ('\n'); - - dummy_name = make_temp_file (NULL); - for (a = bfd_arch_obscure + 1; a < bfd_arch_last; a++) - if (strcmp (bfd_printable_arch_mach (a, 0), "UNKNOWN!") != 0) - { - printf ("%*s ", (int) LONGEST_ARCH - 1, - bfd_printable_arch_mach (a, 0)); - for (t = first; t < last && bfd_target_vector[t]; t++) - { - const bfd_target *p = bfd_target_vector[t]; - bfd_boolean ok = TRUE; - bfd *abfd = bfd_openw (dummy_name, p->name); - - if (abfd == NULL) - { - bfd_nonfatal (p->name); - ret = 0; - ok = FALSE; - } - - if (ok) - { - if (! bfd_set_format (abfd, bfd_object)) - { - if (bfd_get_error () != bfd_error_invalid_operation) - { - bfd_nonfatal (p->name); - ret = 0; - } - ok = FALSE; - } - } - - if (ok) - { - if (! bfd_set_arch_mach (abfd, a, 0)) - ok = FALSE; - } - - if (ok) - printf ("%s ", p->name); - else - { - int l = strlen (p->name); - while (l--) - putchar ('-'); - putchar (' '); - } - if (abfd != NULL) - bfd_close_all_done (abfd); - } - putchar ('\n'); - } - unlink (dummy_name); - free (dummy_name); + while (targ < arg->count) + { + width -= strlen (arg->info[targ].name) + 1; + if (width < 0) + return targ; + ++targ; + } + return targ; +} - return ret; +/* Print header of target names. */ + +static void +do_info_header (int targ, int stop_targ, const struct display_target *arg) +{ + while (targ != stop_targ) + printf ("%s ", arg->info[targ++].name); +} + +/* Print a table row. */ + +static void +do_info_row (int targ, int stop_targ, enum bfd_architecture a, + const struct display_target *arg) +{ + while (targ != stop_targ) + { + if (arg->info[targ].arch[a - bfd_arch_obscure - 1]) + fputs (arg->info[targ].name, stdout); + else + { + int l = strlen (arg->info[targ].name); + while (l--) + putchar ('-'); + } + ++targ; + if (targ != stop_targ) + putchar (' '); + } } /* Print tables of all the target-architecture combinations that BFD has been configured to support. */ -static int -display_target_tables (void) +static void +display_target_tables (const struct display_target *arg) { - int t; - int columns; - int ret = 1; - char *colum; - - columns = 0; - colum = getenv ("COLUMNS"); - if (colum != NULL) - columns = atoi (colum); - if (columns == 0) - columns = 80; - - t = 0; - while (bfd_target_vector[t] != NULL) + const char *columns; + int width, start_targ, stop_targ; + enum bfd_architecture arch; + int longest_arch = 0; + + for (arch = bfd_arch_obscure + 1; arch < bfd_arch_last; arch++) { - int oldt = t, wid; + const char *s = bfd_printable_arch_mach (arch, 0); + int len = strlen (s); + if (len > longest_arch) + longest_arch = len; + } - wid = LONGEST_ARCH + strlen (bfd_target_vector[t]->name) + 1; - ++t; - while (wid < columns && bfd_target_vector[t] != NULL) - { - int newwid; + width = 0; + columns = getenv ("COLUMNS"); + if (columns != NULL) + width = atoi (columns); + if (width == 0) + width = 80; + + for (start_targ = 0; start_targ < arg->count; start_targ = stop_targ) + { + stop_targ = do_info_size (start_targ, width - longest_arch - 1, arg); - newwid = wid + strlen (bfd_target_vector[t]->name) + 1; - if (newwid >= columns) - break; - wid = newwid; - ++t; + printf ("\n%*s", longest_arch + 1, " "); + do_info_header (start_targ, stop_targ, arg); + putchar ('\n'); + + for (arch = bfd_arch_obscure + 1; arch < bfd_arch_last; arch++) + { + if (strcmp (bfd_printable_arch_mach (arch, 0), "UNKNOWN!") != 0) + { + printf ("%*s ", longest_arch, + bfd_printable_arch_mach (arch, 0)); + + do_info_row (start_targ, stop_targ, arch, arg); + putchar ('\n'); + } } - if (! display_info_table (oldt, t)) - ret = 0; } - - return ret; } int display_info (void) { + struct display_target arg; + printf (_("BFD header file version %s\n"), BFD_VERSION_STRING); - if (! display_target_list () || ! display_target_tables ()) - return 1; - else - return 0; + + display_target_list (&arg); + if (!arg.error) + display_target_tables (&arg); + + return arg.error; } /* Display the archive header for an element as if it were an ls -l listing: @@ -359,7 +435,7 @@ display_info (void) Mode User\tGroup\tSize\tDate Name */ void -print_arelt_descr (FILE *file, bfd *abfd, bfd_boolean verbose) +print_arelt_descr (FILE *file, bfd *abfd, bfd_boolean verbose, bfd_boolean offsets) { struct stat buf; @@ -371,20 +447,36 @@ print_arelt_descr (FILE *file, bfd *abfd, bfd_boolean verbose) char timebuf[40]; time_t when = buf.st_mtime; const char *ctime_result = (const char *) ctime (&when); + bfd_size_type size; - /* POSIX format: skip weekday and seconds from ctime output. */ - sprintf (timebuf, "%.12s %.4s", ctime_result + 4, ctime_result + 20); + /* PR binutils/17605: Check for corrupt time values. */ + if (ctime_result == NULL) + sprintf (timebuf, _("