X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=formats%2Fctf%2Fir%2Fstream.c;h=c0b4e979a9ff9195b21e323bc7402110cafe335e;hb=92cbbcc5ffb90362b3616beea9a615a55c768b37;hp=4339010e1846f1b8a7fbbcbbac9a01b8e24e0a79;hpb=1579cde5dcbded3ca1c58880a8dc1226cb2ae54b;p=babeltrace.git

diff --git a/formats/ctf/ir/stream.c b/formats/ctf/ir/stream.c
index 4339010e..c0b4e979 100644
--- a/formats/ctf/ir/stream.c
+++ b/formats/ctf/ir/stream.c
@@ -26,8 +26,9 @@
  * SOFTWARE.
  */
 
-#include <babeltrace/ctf-ir/clock.h>
-#include <babeltrace/ctf-ir/clock-internal.h>
+#include <babeltrace/ctf-ir/clock-class.h>
+#include <babeltrace/ctf-writer/clock.h>
+#include <babeltrace/ctf-writer/clock-internal.h>
 #include <babeltrace/ctf-writer/event.h>
 #include <babeltrace/ctf-ir/event-internal.h>
 #include <babeltrace/ctf-ir/field-types-internal.h>
@@ -35,6 +36,8 @@
 #include <babeltrace/ctf-ir/stream.h>
 #include <babeltrace/ctf-ir/stream-internal.h>
 #include <babeltrace/ctf-ir/stream-class-internal.h>
+#include <babeltrace/ctf-ir/trace-internal.h>
+#include <babeltrace/ctf-writer/writer-internal.h>
 #include <babeltrace/ref.h>
 #include <babeltrace/ctf-writer/functor-internal.h>
 #include <babeltrace/compiler.h>
@@ -46,6 +49,45 @@ void bt_ctf_stream_destroy(struct bt_object *obj);
 static
 int set_structure_field_integer(struct bt_ctf_field *, char *, uint64_t);
 
+static
+int set_integer_field_value(struct bt_ctf_field* field, uint64_t value)
+{
+	int ret = 0;
+	struct bt_ctf_field_type *field_type = NULL;
+
+	if (!field) {
+		ret = -1;
+		goto end;
+	}
+
+	field_type = bt_ctf_field_get_type(field);
+	assert(field_type);
+
+	if (bt_ctf_field_type_get_type_id(field_type) !=
+			BT_CTF_TYPE_ID_INTEGER) {
+		/* Not an integer and the value is unset, error. */
+		ret = -1;
+		goto end;
+	}
+
+	if (bt_ctf_field_type_integer_get_signed(field_type)) {
+		ret = bt_ctf_field_signed_integer_set_value(field, (int64_t) value);
+		if (ret) {
+			/* Value is out of range, error. */
+			goto end;
+		}
+	} else {
+		ret = bt_ctf_field_unsigned_integer_set_value(field, value);
+		if (ret) {
+			/* Value is out of range, error. */
+			goto end;
+		}
+	}
+end:
+	bt_put(field_type);
+	return ret;
+}
+
 static
 int set_packet_header_magic(struct bt_ctf_stream *stream)
 {
@@ -59,7 +101,7 @@ int set_packet_header_magic(struct bt_ctf_stream *stream)
 		goto end;
 	}
 
-	if (!bt_ctf_field_validate(magic_field)) {
+	if (bt_ctf_field_is_set(magic_field)) {
 		/* Value already set. Not an error, skip. */
 		goto end;
 	}
@@ -111,7 +153,7 @@ int set_packet_header_uuid(struct bt_ctf_stream *stream)
 		goto end;
 	}
 
-	if (!bt_ctf_field_validate(uuid_field)) {
+	if (bt_ctf_field_is_set(uuid_field)) {
 		/* Value already set. Not an error, skip. */
 		goto end;
 	}
@@ -184,7 +226,7 @@ int set_packet_header_stream_id(struct bt_ctf_stream *stream)
 		goto end;
 	}
 
-	if (!bt_ctf_field_validate(stream_id_field)) {
+	if (bt_ctf_field_is_set(stream_id_field)) {
 		/* Value already set. Not an error, skip. */
 		goto end;
 	}
@@ -252,21 +294,71 @@ void release_event(struct bt_ctf_event *event)
 	}
 }
 
-BT_HIDDEN
+static
+int create_stream_file(struct bt_ctf_writer *writer,
+		struct bt_ctf_stream *stream)
+{
+	int fd;
+	GString *filename = g_string_new(stream->stream_class->name->str);
+
+	if (stream->stream_class->name->len == 0) {
+		int64_t ret;
+
+		ret = bt_ctf_stream_class_get_id(stream->stream_class);
+		if (ret < 0) {
+			fd = -1;
+			goto error;
+		}
+
+		g_string_printf(filename, "stream_%" PRId64, ret);
+	}
+
+	g_string_append_printf(filename, "_%" PRIu32, stream->id);
+	fd = openat(writer->trace_dir_fd, filename->str,
+		O_RDWR | O_CREAT | O_TRUNC,
+		S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP);
+error:
+	g_string_free(filename, TRUE);
+	return fd;
+}
+
+static
+int set_stream_fd(struct bt_ctf_stream *stream, int fd)
+{
+	int ret = 0;
+
+	if (stream->pos.fd != -1) {
+		ret = -1;
+		goto end;
+	}
+
+	ctf_init_pos(&stream->pos, NULL, fd, O_RDWR);
+	stream->pos.fd = fd;
+end:
+	return ret;
+}
+
 struct bt_ctf_stream *bt_ctf_stream_create(
-	struct bt_ctf_stream_class *stream_class,
-	struct bt_ctf_trace *trace)
+		struct bt_ctf_stream_class *stream_class,
+		const char *name)
 {
 	int ret;
 	struct bt_ctf_stream *stream = NULL;
+	struct bt_ctf_trace *trace = NULL;
+	struct bt_ctf_writer *writer = NULL;
 
-	if (!stream_class || !trace) {
-		goto end;
+	if (!stream_class) {
+		goto error;
+	}
+
+	trace = bt_ctf_stream_class_get_trace(stream_class);
+	if (!trace) {
+		goto error;
 	}
 
 	stream = g_new0(struct bt_ctf_stream, 1);
 	if (!stream) {
-		goto end;
+		goto error;
 	}
 
 	bt_object_init(stream, bt_ctf_stream_destroy);
@@ -275,70 +367,99 @@ struct bt_ctf_stream *bt_ctf_stream_create(
 	 * reachable; it needs its parent to remain valid.
 	 */
 	bt_object_set_parent(stream, trace);
-	stream->packet_context = bt_ctf_field_create(
-		stream_class->packet_context_type);
-	if (!stream->packet_context) {
-		goto error;
-	}
-
-	/* Initialize events_discarded */
-	ret = set_structure_field_integer(stream->packet_context,
-		"events_discarded", 0);
-	if (ret) {
-		goto error;
-	}
-
-	stream->pos.fd = -1;
 	stream->id = stream_class->next_stream_id++;
 	stream->stream_class = stream_class;
-	stream->events = g_ptr_array_new_with_free_func(
-		(GDestroyNotify) release_event);
-	if (!stream->events) {
-		goto error;
-	}
+	stream->pos.fd = -1;
 
-	/* A trace is not allowed to have a NULL packet header */
-	assert(trace->packet_header_type);
-	stream->packet_header = bt_ctf_field_create(trace->packet_header_type);
-	if (!stream->packet_header) {
-		goto error;
+	if (name) {
+		stream->name = g_string_new(name);
+		if (!stream->name) {
+			goto error;
+		}
 	}
-	/*
-	 * Attempt to populate the default trace packet header fields
-	 * (magic, uuid and stream_id). This will _not_ fail shall the
-	 * fields not be found or be of an incompatible type; they will
-	 * simply not be populated automatically. The user will have to
-	 * make sure to set the trace packet header fields himself before
-	 * flushing.
-	 */
-	ret = set_packet_header(stream);
-	if (ret) {
-		goto error;
+
+	if (trace->is_created_by_writer) {
+		int fd;
+		writer = (struct bt_ctf_writer *)
+			bt_object_get_parent(trace);
+
+		assert(writer);
+		if (stream_class->packet_context_type) {
+			stream->packet_context = bt_ctf_field_create(
+				stream_class->packet_context_type);
+			if (!stream->packet_context) {
+				goto error;
+			}
+
+			/* Initialize events_discarded */
+			ret = set_structure_field_integer(stream->packet_context,
+				"events_discarded", 0);
+			if (ret) {
+				goto error;
+			}
+		}
+
+		stream->events = g_ptr_array_new_with_free_func(
+			(GDestroyNotify) release_event);
+		if (!stream->events) {
+			goto error;
+		}
+
+		/* A trace is not allowed to have a NULL packet header */
+		assert(trace->packet_header_type);
+		stream->packet_header =
+			bt_ctf_field_create(trace->packet_header_type);
+		if (!stream->packet_header) {
+			goto error;
+		}
+
+		/*
+		 * Attempt to populate the default trace packet header fields
+		 * (magic, uuid and stream_id). This will _not_ fail shall the
+		 * fields not be found or be of an incompatible type; they will
+		 * simply not be populated automatically. The user will have to
+		 * make sure to set the trace packet header fields himself
+		 * before flushing.
+		 */
+		ret = set_packet_header(stream);
+		if (ret) {
+			goto error;
+		}
+
+		/* Create file associated with this stream */
+		fd = create_stream_file(writer, stream);
+		if (fd < 0) {
+			goto error;
+		}
+
+		ret = set_stream_fd(stream, fd);
+		if (ret) {
+			goto error;
+		}
+
+		/* Freeze the writer */
+		bt_ctf_writer_freeze(writer);
+	} else {
+		/* Non-writer stream indicated by a negative FD */
+		ret = set_stream_fd(stream, -1);
+		if (ret) {
+			goto error;
+		}
 	}
-end:
+
+	/* Add this stream to the trace's streams */
+	g_ptr_array_add(trace->streams, stream);
+
+	BT_PUT(trace);
+	BT_PUT(writer);
 	return stream;
 error:
 	BT_PUT(stream);
-	bt_put(trace);
+	BT_PUT(trace);
+	BT_PUT(writer);
 	return stream;
 }
 
-BT_HIDDEN
-int bt_ctf_stream_set_fd(struct bt_ctf_stream *stream, int fd)
-{
-	int ret = 0;
-
-	if (stream->pos.fd != -1) {
-		ret = -1;
-		goto end;
-	}
-
-	ctf_init_pos(&stream->pos, NULL, fd, O_RDWR);
-	stream->pos.fd = fd;
-end:
-	return ret;
-}
-
 struct bt_ctf_stream_class *bt_ctf_stream_get_class(
 		struct bt_ctf_stream *stream)
 {
@@ -474,6 +595,86 @@ end:
 	bt_put(events_discarded_field_type);
 }
 
+static int auto_populate_event_header(struct bt_ctf_stream *stream,
+		struct bt_ctf_event *event)
+{
+	int ret = 0;
+	struct bt_ctf_field *id_field = NULL, *timestamp_field = NULL;
+	struct bt_ctf_clock_class *mapped_clock_class = NULL;
+
+	if (!event || event->frozen) {
+		ret = -1;
+		goto end;
+	}
+
+	/*
+	 * The condition to automatically set the ID are:
+	 *
+	 * 1. The event header field "id" exists and is an integer
+	 *    field.
+	 * 2. The event header field "id" is NOT set.
+	 */
+	id_field = bt_ctf_field_structure_get_field(event->event_header, "id");
+	if (id_field && !bt_ctf_field_is_set(id_field)) {
+		ret = set_integer_field_value(id_field,
+			(uint64_t) bt_ctf_event_class_get_id(
+					event->event_class));
+		if (ret) {
+			goto end;
+		}
+	}
+
+	/*
+	 * The conditions to automatically set the timestamp are:
+	 *
+	 * 1. The event header field "timestamp" exists and is an
+	 *    integer field.
+	 * 2. This stream's class has a registered clock (set with
+	 *    bt_ctf_stream_class_set_clock()).
+	 * 3. The event header field "timestamp" has its type mapped to
+	 *    a clock class which is also the clock class of this
+	 *    stream's class's registered clock.
+	 * 4. The event header field "timestamp" is NOT set.
+	 */
+	timestamp_field = bt_ctf_field_structure_get_field(event->event_header,
+			"timestamp");
+	if (timestamp_field && !bt_ctf_field_is_set(timestamp_field) &&
+			stream->stream_class->clock) {
+		struct bt_ctf_clock_class *stream_class_clock_class =
+			stream->stream_class->clock->clock_class;
+		struct bt_ctf_field_type *timestamp_field_type =
+			bt_ctf_field_get_type(timestamp_field);
+
+		assert(timestamp_field_type);
+		mapped_clock_class =
+			bt_ctf_field_type_integer_get_mapped_clock_class(
+				timestamp_field_type);
+		BT_PUT(timestamp_field_type);
+		if (mapped_clock_class == stream_class_clock_class) {
+			uint64_t timestamp;
+
+			ret = bt_ctf_clock_get_value(
+				stream->stream_class->clock,
+				&timestamp);
+			if (ret) {
+				goto end;
+			}
+
+			ret = set_integer_field_value(timestamp_field,
+					timestamp);
+			if (ret) {
+				goto end;
+			}
+		}
+	}
+
+end:
+	bt_put(id_field);
+	bt_put(timestamp_field);
+	bt_put(mapped_clock_class);
+	return ret;
+}
+
 int bt_ctf_stream_append_event(struct bt_ctf_stream *stream,
 		struct bt_ctf_event *event)
 {
@@ -484,16 +685,29 @@ int bt_ctf_stream_append_event(struct bt_ctf_stream *stream,
 		goto end;
 	}
 
+	/*
+	 * The event is not supposed to have a parent stream at this
+	 * point. The only other way an event can have a parent stream
+	 * is if it was assigned when setting a packet to the event,
+	 * in which case the packet's stream is not a writer stream,
+	 * and thus the user is trying to append an event which belongs
+	 * to another stream.
+	 */
+	if (event->base.parent) {
+		ret = -1;
+		goto end;
+	}
+
 	bt_object_set_parent(event, stream);
-	ret = bt_ctf_event_populate_event_header(event);
+	ret = auto_populate_event_header(stream, event);
 	if (ret) {
-		goto end;
+		goto error;
 	}
 
 	/* Make sure the various scopes of the event are set */
 	ret = bt_ctf_event_validate(event);
 	if (ret) {
-		goto end;
+		goto error;
 	}
 
 	/* Save the new event and freeze it */
@@ -507,14 +721,17 @@ int bt_ctf_stream_append_event(struct bt_ctf_stream *stream,
 	 * longer needed.
 	 */
 	bt_put(event->event_class);
+
 end:
-	if (ret) {
-		/*
-		 * Orphan the event; we were not succesful in associating it to
-		 * a stream.
-		 */
-		bt_object_set_parent(event, NULL);
-	}
+	return ret;
+
+error:
+	/*
+	 * Orphan the event; we were not successful in associating it to
+	 * a stream.
+	 */
+	bt_object_set_parent(event, NULL);
+
 	return ret;
 }
 
@@ -541,7 +758,7 @@ int bt_ctf_stream_set_packet_context(struct bt_ctf_stream *stream,
 	int ret = 0;
 	struct bt_ctf_field_type *field_type;
 
-	if (!stream || !field || stream->pos.fd < 0) {
+	if (!stream || stream->pos.fd < 0) {
 		ret = -1;
 		goto end;
 	}
@@ -554,9 +771,8 @@ int bt_ctf_stream_set_packet_context(struct bt_ctf_stream *stream,
 	}
 
 	bt_put(field_type);
-	bt_get(field);
 	bt_put(stream->packet_context);
-	stream->packet_context = field;
+	stream->packet_context = bt_get(field);
 end:
 	return ret;
 }
@@ -585,7 +801,7 @@ int bt_ctf_stream_set_packet_header(struct bt_ctf_stream *stream,
 	struct bt_ctf_trace *trace = NULL;
 	struct bt_ctf_field_type *field_type = NULL;
 
-	if (!stream || !field || stream->pos.fd < 0) {
+	if (!stream || stream->pos.fd < 0) {
 		ret = -1;
 		goto end;
 	}
@@ -597,9 +813,8 @@ int bt_ctf_stream_set_packet_header(struct bt_ctf_stream *stream,
 		goto end;
 	}
 
-	bt_get(field);
 	bt_put(stream->packet_header);
-	stream->packet_header = field;
+	stream->packet_header = bt_get(field);
 end:
 	BT_PUT(trace);
 	bt_put(field_type);
@@ -657,6 +872,8 @@ int bt_ctf_stream_flush(struct bt_ctf_stream *stream)
 	uint64_t timestamp_begin, timestamp_end, events_discarded;
 	struct bt_ctf_field *integer = NULL;
 	struct ctf_stream_pos packet_context_pos;
+	bool empty_packet;
+	uint64_t packet_size_bits;
 
 	if (!stream || stream->pos.fd < 0) {
 		/*
@@ -667,14 +884,17 @@ int bt_ctf_stream_flush(struct bt_ctf_stream *stream)
 		goto end;
 	}
 
-	if (!stream->events->len) {
+	if (!stream->packet_context && stream->flushed_packet_count > 0) {
+		/*
+		 * A stream without a packet context, and thus without
+		 * content and packet size members, can't have more than
+		 * one packet.
+		 */
+		ret = -1;
 		goto end;
 	}
 
-	ret = bt_ctf_field_validate(stream->packet_header);
-	if (ret) {
-		goto end;
-	}
+	empty_packet = (stream->events->len == 0);
 
 	/* mmap the next packet */
 	ctf_packet_seek(&stream->pos.parent, 0, SEEK_CUR);
@@ -684,66 +904,68 @@ int bt_ctf_stream_flush(struct bt_ctf_stream *stream)
 		goto end;
 	}
 
-	/* Set the default context attributes if present and unset. */
-	if (!get_event_header_timestamp(
-		((struct bt_ctf_event *) g_ptr_array_index(
-		stream->events, 0))->event_header, &timestamp_begin)) {
+	if (stream->packet_context) {
+		/* Set the default context attributes if present and unset. */
+		if (!empty_packet && !get_event_header_timestamp(
+			((struct bt_ctf_event *) g_ptr_array_index(
+				stream->events, 0))->event_header, &timestamp_begin)) {
+			ret = set_structure_field_integer(stream->packet_context,
+				"timestamp_begin", timestamp_begin);
+			if (ret) {
+				goto end;
+			}
+		}
+
+		if (!empty_packet && !get_event_header_timestamp(
+			((struct bt_ctf_event *) g_ptr_array_index(
+				stream->events, stream->events->len - 1))->event_header,
+				&timestamp_end)) {
+
+			ret = set_structure_field_integer(stream->packet_context,
+				"timestamp_end", timestamp_end);
+			if (ret) {
+				goto end;
+			}
+		}
 		ret = set_structure_field_integer(stream->packet_context,
-			"timestamp_begin", timestamp_begin);
+			"content_size", UINT64_MAX);
 		if (ret) {
 			goto end;
 		}
-	}
-
-	if (!get_event_header_timestamp(
-		((struct bt_ctf_event *) g_ptr_array_index(
-		stream->events, stream->events->len - 1))->event_header,
-		&timestamp_end)) {
 
 		ret = set_structure_field_integer(stream->packet_context,
-			"timestamp_end", timestamp_end);
+			"packet_size", UINT64_MAX);
 		if (ret) {
 			goto end;
 		}
-	}
-	ret = set_structure_field_integer(stream->packet_context,
-		"content_size", UINT64_MAX);
-	if (ret) {
-		goto end;
-	}
-
-	ret = set_structure_field_integer(stream->packet_context,
-		"packet_size", UINT64_MAX);
-	if (ret) {
-		goto end;
-	}
 
-	/* Write packet context */
-	memcpy(&packet_context_pos, &stream->pos,
-	       sizeof(struct ctf_stream_pos));
-	ret = bt_ctf_field_serialize(stream->packet_context,
-		&stream->pos);
-	if (ret) {
-		goto end;
-	}
+		/* Write packet context */
+		memcpy(&packet_context_pos, &stream->pos,
+			sizeof(struct ctf_stream_pos));
+		ret = bt_ctf_field_serialize(stream->packet_context,
+			&stream->pos);
+		if (ret) {
+			goto end;
+		}
 
-	ret = bt_ctf_stream_get_discarded_events_count(stream,
-		&events_discarded);
-	if (ret) {
-		goto end;
-	}
+		ret = bt_ctf_stream_get_discarded_events_count(stream,
+			&events_discarded);
+		if (ret) {
+			goto end;
+		}
 
-	/* Unset the packet context's fields. */
-	ret = bt_ctf_field_reset(stream->packet_context);
-	if (ret) {
-		goto end;
-	}
+		/* Unset the packet context's fields. */
+		ret = bt_ctf_field_reset(stream->packet_context);
+		if (ret) {
+			goto end;
+		}
 
-	/* Set the previous number of discarded events. */
-	ret = set_structure_field_integer(stream->packet_context,
-		"events_discarded", events_discarded);
-	if (ret) {
-		goto end;
+		/* Set the previous number of discarded events. */
+		ret = set_structure_field_integer(stream->packet_context,
+			"events_discarded", events_discarded);
+		if (ret) {
+			goto end;
+		}
 	}
 
 	for (i = 0; i < stream->events->len; i++) {
@@ -778,33 +1000,41 @@ int bt_ctf_stream_flush(struct bt_ctf_stream *stream)
 		}
 	}
 
-	/*
-	 * Update the packet total size and content size and overwrite the
-	 * packet context.
-	 * Copy base_mma as the packet may have been remapped (e.g. when a
-	 * packet is resized).
-	 */
-	packet_context_pos.base_mma = stream->pos.base_mma;
-	ret = set_structure_field_integer(stream->packet_context,
-		"content_size", stream->pos.offset);
-	if (ret) {
-		goto end;
-	}
+	/* Rounded-up in case content_size is not byte-aligned. */
+	packet_size_bits = (stream->pos.offset + (CHAR_BIT - 1)) &
+		~(CHAR_BIT - 1);
+	stream->pos.packet_size = packet_size_bits;
 
-	ret = set_structure_field_integer(stream->packet_context,
-		"packet_size", stream->pos.packet_size);
-	if (ret) {
-		goto end;
-	}
+	if (stream->packet_context) {
+		/*
+		 * Update the packet total size and content size and overwrite
+		 * the packet context.
+		 * Copy base_mma as the packet may have been remapped (e.g. when
+		 * a packet is resized).
+		 */
+		packet_context_pos.base_mma = stream->pos.base_mma;
+		ret = set_structure_field_integer(stream->packet_context,
+			"content_size", stream->pos.offset);
+		if (ret) {
+			goto end;
+		}
 
-	ret = bt_ctf_field_serialize(stream->packet_context,
-		&packet_context_pos);
-	if (ret) {
-		goto end;
+		ret = set_structure_field_integer(stream->packet_context,
+			"packet_size", packet_size_bits);
+		if (ret) {
+			goto end;
+		}
+
+		ret = bt_ctf_field_serialize(stream->packet_context,
+			&packet_context_pos);
+		if (ret) {
+			goto end;
+		}
 	}
 
 	g_ptr_array_set_size(stream->events, 0);
 	stream->flushed_packet_count++;
+	stream->size += packet_size_bits / CHAR_BIT;
 end:
 	bt_put(integer);
 	return ret;
@@ -827,16 +1057,36 @@ void bt_ctf_stream_destroy(struct bt_object *obj)
 
 	stream = container_of(obj, struct bt_ctf_stream, base);
 	ctf_fini_pos(&stream->pos);
-	if (stream->pos.fd >= 0 && close(stream->pos.fd)) {
-		perror("close");
+	if (stream->pos.fd >= 0) {
+		int ret;
+
+		/*
+		 * Truncate the file's size to the minimum required to fit the
+		 * last packet as we might have grown it too much on the last
+		 * mmap.
+		 */
+		do {
+			ret = ftruncate(stream->pos.fd, stream->size);
+		} while (ret == -1 && errno == EINTR);
+		if (ret) {
+			perror("ftruncate");
+		}
+
+		if (close(stream->pos.fd)) {
+			perror("close");
+		}
 	}
 
 	if (stream->events) {
 		g_ptr_array_free(stream->events, TRUE);
 	}
+
+	if (stream->name) {
+		g_string_free(stream->name, TRUE);
+	}
+
 	bt_put(stream->packet_header);
 	bt_put(stream->packet_context);
-	bt_put(stream->event_context);
 	g_free(stream);
 }
 
@@ -860,7 +1110,7 @@ int set_structure_field_integer(struct bt_ctf_field *structure, char *name,
 	}
 
 	/* Make sure the payload has not already been set. */
-	if (!bt_ctf_field_validate(integer)) {
+	if (bt_ctf_field_is_set(integer)) {
 		/* Payload already set, not an error */
 		goto end;
 	}
@@ -889,3 +1139,31 @@ end:
 	bt_put(field_type);
 	return ret;
 }
+
+const char *bt_ctf_stream_get_name(struct bt_ctf_stream *stream)
+{
+	const char *name = NULL;
+
+	if (!stream) {
+		goto end;
+	}
+
+	name = stream->name ? stream->name->str : NULL;
+
+end:
+	return name;
+}
+
+int bt_ctf_stream_is_writer(struct bt_ctf_stream *stream)
+{
+	int ret = -1;
+
+	if (!stream) {
+		goto end;
+	}
+
+	ret = (stream->pos.fd >= 0);
+
+end:
+	return ret;
+}