X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fada-valprint.c;h=d516a4d134e8e3e8853581d4c6e174c799f84e28;hb=db2534b704e5f1227decd2a0cfe62bff1d2bee65;hp=8095eede72192c1d29795e7d4cdd2fe7be3b1ce4;hpb=f12f6bad7d4e8de1d1f4c9c1811757571149c8f1;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c index 8095eede72..d516a4d134 100644 --- a/gdb/ada-valprint.c +++ b/gdb/ada-valprint.c @@ -1,6 +1,6 @@ /* Support for printing Ada values for GDB, the GNU debugger. - Copyright (C) 1986-2017 Free Software Foundation, Inc. + Copyright (C) 1986-2021 Free Software Foundation, Inc. This file is part of GDB. @@ -19,35 +19,31 @@ #include "defs.h" #include -#include "symtab.h" #include "gdbtypes.h" #include "expression.h" #include "value.h" -#include "demangle.h" #include "valprint.h" #include "language.h" #include "annotate.h" #include "ada-lang.h" -#include "c-lang.h" -#include "infcall.h" -#include "objfiles.h" +#include "target-float.h" +#include "cli/cli-style.h" +#include "gdbarch.h" -static int print_field_values (struct type *, const gdb_byte *, - int, +static int print_field_values (struct value *, struct value *, struct ui_file *, int, - struct value *, const struct value_print_options *, - int, struct type *, int, - const struct language_defn *); + int, const struct language_defn *); + /* Make TYPE unsigned if its range of values includes no negatives. */ static void adjust_type_signedness (struct type *type) { - if (type != NULL && TYPE_CODE (type) == TYPE_CODE_RANGE - && TYPE_LOW_BOUND (type) >= 0) - TYPE_UNSIGNED (type) = 1; + if (type != NULL && type->code () == TYPE_CODE_RANGE + && type->bounds ()->low.const_val () >= 0) + type->set_is_unsigned (true); } /* Assuming TYPE is a simple array type, prints its lower bound on STREAM, @@ -75,27 +71,30 @@ print_optional_low_bound (struct ui_file *stream, struct type *type, if (low_bound > high_bound) return 0; - index_type = TYPE_INDEX_TYPE (type); + index_type = type->index_type (); - while (TYPE_CODE (index_type) == TYPE_CODE_RANGE) + while (index_type->code () == TYPE_CODE_RANGE) { /* We need to know what the base type is, in order to do the - appropriate check below. Otherwise, if this is a subrange - of an enumerated type, where the underlying value of the - first element is typically 0, we might test the low bound - against the wrong value. */ + appropriate check below. Otherwise, if this is a subrange + of an enumerated type, where the underlying value of the + first element is typically 0, we might test the low bound + against the wrong value. */ index_type = TYPE_TARGET_TYPE (index_type); } - switch (TYPE_CODE (index_type)) + /* Don't print the lower bound if it's the default one. */ + switch (index_type->code ()) { case TYPE_CODE_BOOL: + case TYPE_CODE_CHAR: if (low_bound == 0) return 0; break; case TYPE_CODE_ENUM: - if (low_bound == TYPE_FIELD_ENUMVAL (index_type, 0)) + if (low_bound == 0) return 0; + low_bound = TYPE_FIELD_ENUMVAL (index_type, low_bound); break; case TYPE_CODE_UNDEF: index_type = NULL; @@ -112,17 +111,15 @@ print_optional_low_bound (struct ui_file *stream, struct type *type, } /* Version of val_print_array_elements for GNAT-style packed arrays. - Prints elements of packed array of type TYPE at bit offset - BITOFFSET from VALADDR on STREAM. Formats according to OPTIONS and - separates with commas. RECURSE is the recursion (nesting) level. - TYPE must have been decoded (as by ada_coerce_to_simple_array). */ + Prints elements of packed array of type TYPE from VALADDR on + STREAM. Formats according to OPTIONS and separates with commas. + RECURSE is the recursion (nesting) level. TYPE must have been + decoded (as by ada_coerce_to_simple_array). */ static void val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, - int offset, - int bitoffset, struct ui_file *stream, + int offset, struct ui_file *stream, int recurse, - struct value *val, const struct value_print_options *options) { unsigned int i; @@ -134,17 +131,28 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, LONGEST low = 0; elttype = TYPE_TARGET_TYPE (type); - index_type = TYPE_INDEX_TYPE (type); + index_type = type->index_type (); { LONGEST high; - if (get_discrete_bounds (index_type, &low, &high) < 0) + if (!get_discrete_bounds (index_type, &low, &high)) len = 1; + else if (low > high) + { + /* The array length should normally be HIGH_POS - LOW_POS + 1. + But in Ada we allow LOW_POS to be greater than HIGH_POS for + empty arrays. In that situation, the array length is just zero, + not negative! */ + len = 0; + } else len = high - low + 1; } + if (index_type->code () == TYPE_CODE_RANGE) + index_type = TYPE_TARGET_TYPE (index_type); + i = 0; annotate_array_section_begin (i, elttype); @@ -165,6 +173,11 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, fprintf_filtered (stream, ", "); } } + else if (options->prettyformat_arrays) + { + fprintf_filtered (stream, "\n"); + print_spaces_filtered (2 + 2 * recurse, stream); + } wrap_here (n_spaces (2 + 2 * recurse)); maybe_print_array_index (index_type, i + low, stream, options); @@ -196,11 +209,10 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, struct value_print_options opts = *options; opts.deref_ref = 0; - val_print (elttype, - value_embedded_offset (v0), 0, stream, - recurse + 1, v0, &opts, current_language); + common_val_print (v0, stream, recurse + 1, &opts, current_language); annotate_elt_rep (i - i0); - fprintf_filtered (stream, _(" "), i - i0); + fprintf_filtered (stream, _(" %p[%p]"), + metadata_style.style ().ptr (), i - i0, nullptr); annotate_elt_rep_end (); } @@ -227,9 +239,8 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, maybe_print_array_index (index_type, j + low, stream, options); } - val_print (elttype, - value_embedded_offset (v0), 0, stream, - recurse + 1, v0, &opts, current_language); + common_val_print (v0, stream, recurse + 1, &opts, + current_language); annotate_elt (); } } @@ -244,12 +255,6 @@ val_print_packed_array_elements (struct type *type, const gdb_byte *valaddr, value_free_to_mark (mark); } -static struct type * -printable_val_type (struct type *type, const gdb_byte *valaddr) -{ - return ada_to_fixed_type (ada_aligned_type (type), valaddr, 0, NULL, 1); -} - /* Print the character C on STREAM as part of the contents of a literal string whose delimiter is QUOTER. TYPE_LEN is the length in bytes of the character. */ @@ -286,7 +291,7 @@ char_at (const gdb_byte *string, int i, int type_len, return string[i]; else return (int) extract_unsigned_integer (string + type_len * i, - type_len, byte_order); + type_len, byte_order); } /* Print a floating-point value of type TYPE, pointed to in GDB by @@ -369,11 +374,11 @@ ada_print_scalar (struct type *type, LONGEST val, struct ui_file *stream) type = ada_check_typedef (type); - switch (TYPE_CODE (type)) + switch (type->code ()) { case TYPE_CODE_ENUM: - len = TYPE_NFIELDS (type); + len = type->num_fields (); for (i = 0; i < len; i++) { if (TYPE_FIELD_ENUMVAL (type, i) == val) @@ -383,7 +388,8 @@ ada_print_scalar (struct type *type, LONGEST val, struct ui_file *stream) } if (i < len) { - fputs_filtered (ada_enum_name (TYPE_FIELD_NAME (type, i)), stream); + fputs_styled (ada_enum_name (TYPE_FIELD_NAME (type, i)), + variable_name_style.style (), stream); } else { @@ -392,7 +398,7 @@ ada_print_scalar (struct type *type, LONGEST val, struct ui_file *stream) break; case TYPE_CODE_INT: - print_longest (stream, TYPE_UNSIGNED (type) ? 'u' : 'd', 0, val); + print_longest (stream, type->is_unsigned () ? 'u' : 'd', 0, val); break; case TYPE_CODE_CHAR: @@ -428,7 +434,6 @@ ada_print_scalar (struct type *type, LONGEST val, struct ui_file *stream) default: error (_("Invalid type code in symbol table.")); } - gdb_flush (stream); } /* Print the character string STRING, printing at most LENGTH characters. @@ -442,7 +447,7 @@ printstr (struct ui_file *stream, struct type *elttype, const gdb_byte *string, unsigned int length, int force_ellipses, int type_len, const struct value_print_options *options) { - enum bfd_endian byte_order = gdbarch_byte_order (get_type_arch (elttype)); + enum bfd_endian byte_order = type_byte_order (elttype); unsigned int i; unsigned int things_printed = 0; int in_quotes = 0; @@ -457,7 +462,7 @@ printstr (struct ui_file *stream, struct type *elttype, const gdb_byte *string, for (i = 0; i < length && things_printed < options->print_max; i += 1) { /* Position of the character we are examining - to see whether it is repeated. */ + to see whether it is repeated. */ unsigned int rep1; /* Number of repetitions we have detected so far. */ unsigned int reps; @@ -491,7 +496,8 @@ printstr (struct ui_file *stream, struct type *elttype, const gdb_byte *string, ada_emit_char (char_at (string, i, type_len, byte_order), elttype, stream, '\'', type_len); fputs_filtered ("'", stream); - fprintf_filtered (stream, _(" "), reps); + fprintf_filtered (stream, _(" %p[%p]"), + metadata_style.style ().ptr (), reps, nullptr); i = rep1 - 1; things_printed += options->repeat_count_threshold; need_comma = 1; @@ -528,39 +534,33 @@ ada_printstr (struct ui_file *stream, struct type *type, } static int -print_variant_part (struct type *type, int field_num, - const gdb_byte *valaddr, int offset, +print_variant_part (struct value *value, int field_num, + struct value *outer_value, struct ui_file *stream, int recurse, - struct value *val, const struct value_print_options *options, int comma_needed, - struct type *outer_type, int outer_offset, const struct language_defn *language) { - struct type *var_type = TYPE_FIELD_TYPE (type, field_num); - int which = ada_which_variant_applies (var_type, outer_type, - valaddr + outer_offset); + struct type *type = value_type (value); + struct type *var_type = type->field (field_num).type (); + int which = ada_which_variant_applies (var_type, outer_value); if (which < 0) return 0; - else - return print_field_values - (TYPE_FIELD_TYPE (var_type, which), - valaddr, - offset + TYPE_FIELD_BITPOS (type, field_num) / HOST_CHAR_BIT - + TYPE_FIELD_BITPOS (var_type, which) / HOST_CHAR_BIT, - stream, recurse, val, options, - comma_needed, outer_type, outer_offset, language); + + struct value *variant_field = value_field (value, field_num); + struct value *active_component = value_field (variant_field, which); + return print_field_values (active_component, outer_value, stream, recurse, + options, comma_needed, language); } -/* Print out fields of value at VALADDR + OFFSET having structure type TYPE. +/* Print out fields of VALUE. - TYPE, VALADDR, OFFSET, STREAM, RECURSE, and OPTIONS have the same - meanings as in ada_print_value and ada_val_print. + STREAM, RECURSE, and OPTIONS have the same meanings as in + ada_print_value and ada_value_print. - OUTER_TYPE and OUTER_OFFSET give type and address of enclosing - record (used to get discriminant values when printing variant - parts). + OUTER_VALUE gives the enclosing record (used to get discriminant + values when printing variant parts). COMMA_NEEDED is 1 if fields have been printed at the current recursion level, so that a comma is needed before any field printed by this @@ -569,17 +569,16 @@ print_variant_part (struct type *type, int field_num, Returns 1 if COMMA_NEEDED or any fields were printed. */ static int -print_field_values (struct type *type, const gdb_byte *valaddr, - int offset, struct ui_file *stream, int recurse, - struct value *val, +print_field_values (struct value *value, struct value *outer_value, + struct ui_file *stream, int recurse, const struct value_print_options *options, int comma_needed, - struct type *outer_type, int outer_offset, const struct language_defn *language) { int i, len; - len = TYPE_NFIELDS (type); + struct type *type = value_type (value); + len = type->num_fields (); for (i = 0; i < len; i += 1) { @@ -588,22 +587,19 @@ print_field_values (struct type *type, const gdb_byte *valaddr, if (ada_is_wrapper_field (type, i)) { + struct value *field_val = ada_value_primitive_field (value, 0, + i, type); comma_needed = - print_field_values (TYPE_FIELD_TYPE (type, i), - valaddr, - (offset - + TYPE_FIELD_BITPOS (type, i) / HOST_CHAR_BIT), - stream, recurse, val, options, - comma_needed, type, offset, language); + print_field_values (field_val, field_val, + stream, recurse, options, + comma_needed, language); continue; } else if (ada_is_variant_part (type, i)) { comma_needed = - print_variant_part (type, i, valaddr, - offset, stream, recurse, val, - options, comma_needed, - outer_type, outer_offset, language); + print_variant_part (value, i, outer_value, stream, recurse, + options, comma_needed, language); continue; } @@ -621,7 +617,7 @@ print_field_values (struct type *type, const gdb_byte *valaddr, wrap_here (n_spaces (2 + 2 * recurse)); } - annotate_field_begin (TYPE_FIELD_TYPE (type, i)); + annotate_field_begin (type->field (i).type ()); fprintf_filtered (stream, "%.*s", ada_name_prefix_len (TYPE_FIELD_NAME (type, i)), TYPE_FIELD_NAME (type, i)); @@ -635,7 +631,8 @@ print_field_values (struct type *type, const gdb_byte *valaddr, order problems. */ if (HAVE_CPLUS_STRUCT (type) && TYPE_FIELD_IGNORE (type, i)) { - fputs_filtered (_(""), stream); + fputs_styled (_(""), + metadata_style.style (), stream); } else { @@ -644,18 +641,15 @@ print_field_values (struct type *type, const gdb_byte *valaddr, int bit_size = TYPE_FIELD_BITSIZE (type, i); struct value_print_options opts; - adjust_type_signedness (TYPE_FIELD_TYPE (type, i)); + adjust_type_signedness (type->field (i).type ()); v = ada_value_primitive_packed_val - (NULL, valaddr, - offset + bit_pos / HOST_CHAR_BIT, + (value, nullptr, + bit_pos / HOST_CHAR_BIT, bit_pos % HOST_CHAR_BIT, - bit_size, TYPE_FIELD_TYPE (type, i)); + bit_size, type->field (i).type ()); opts = *options; opts.deref_ref = 0; - val_print (TYPE_FIELD_TYPE (type, i), - value_embedded_offset (v), 0, - stream, recurse + 1, v, - &opts, language); + common_val_print (v, stream, recurse + 1, &opts, language); } } else @@ -663,9 +657,9 @@ print_field_values (struct type *type, const gdb_byte *valaddr, struct value_print_options opts = *options; opts.deref_ref = 0; - val_print (TYPE_FIELD_TYPE (type, i), - (offset + TYPE_FIELD_BITPOS (type, i) / HOST_CHAR_BIT), - 0, stream, recurse + 1, val, &opts, language); + + struct value *v = value_field (value, i); + common_val_print (v, stream, recurse + 1, &opts, language); } annotate_field_end (); } @@ -678,12 +672,11 @@ print_field_values (struct type *type, const gdb_byte *valaddr, static void ada_val_print_string (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, + int offset_aligned, struct ui_file *stream, int recurse, - struct value *original_value, const struct value_print_options *options) { - enum bfd_endian byte_order = gdbarch_byte_order (get_type_arch (type)); + enum bfd_endian byte_order = type_byte_order (type); struct type *elttype = TYPE_TARGET_TYPE (type); unsigned int eltlen; unsigned int len; @@ -698,9 +691,6 @@ ada_val_print_string (struct type *type, const gdb_byte *valaddr, eltlen = TYPE_LENGTH (elttype); len = TYPE_LENGTH (type) / eltlen; - if (options->prettyformat_arrays) - print_spaces_filtered (2 + 2 * recurse, stream); - /* If requested, look for the first null char and only print elements up to it. */ if (options->stop_print_at_null) @@ -721,65 +711,31 @@ ada_val_print_string (struct type *type, const gdb_byte *valaddr, eltlen, options); } -/* Implement Ada val_print-ing for GNAT arrays (Eg. fat pointers, - thin pointers, etc). */ +/* Implement Ada value_print'ing for the case where TYPE is a + TYPE_CODE_PTR. */ static void -ada_val_print_gnat_array (struct type *type, const gdb_byte *valaddr, - int offset, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) +ada_value_print_ptr (struct value *val, + struct ui_file *stream, int recurse, + const struct value_print_options *options) { - struct value *mark = value_mark (); - struct value *val; - - val = value_from_contents_and_address (type, valaddr + offset, address); - /* If this is a reference, coerce it now. This helps taking care - of the case where ADDRESS is meaningless because original_value - was not an lval. */ - val = coerce_ref (val); - if (TYPE_CODE (type) == TYPE_CODE_TYPEDEF) /* array access type. */ - val = ada_coerce_to_simple_array_ptr (val); - else - val = ada_coerce_to_simple_array (val); - if (val == NULL) + if (!options->format + && TYPE_TARGET_TYPE (value_type (val))->code () == TYPE_CODE_INT + && TYPE_LENGTH (TYPE_TARGET_TYPE (value_type (val))) == 0) { - gdb_assert (TYPE_CODE (type) == TYPE_CODE_TYPEDEF); - fprintf_filtered (stream, "0x0"); + fputs_filtered ("null", stream); + return; } - else - val_print (value_type (val), - value_embedded_offset (val), value_address (val), - stream, recurse, val, options, language); - value_free_to_mark (mark); -} -/* Implement Ada val_print'ing for the case where TYPE is - a TYPE_CODE_PTR. */ - -static void -ada_val_print_ptr (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) -{ - val_print (type, offset, address, stream, recurse, - original_value, options, language_def (language_c)); + common_val_print (val, stream, recurse, options, language_def (language_c)); + struct type *type = ada_check_typedef (value_type (val)); if (ada_is_tag_type (type)) { - struct value *val = - value_from_contents_and_address (type, - valaddr + offset_aligned, - address + offset_aligned); - const char *name = ada_tag_name (val); + gdb::unique_xmalloc_ptr name = ada_tag_name (val); if (name != NULL) - fprintf_filtered (stream, " (%s)", name); + fprintf_filtered (stream, " (%s)", name.get ()); } } @@ -787,43 +743,25 @@ ada_val_print_ptr (struct type *type, const gdb_byte *valaddr, a TYPE_CODE_INT or TYPE_CODE_RANGE. */ static void -ada_val_print_num (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) +ada_value_print_num (struct value *val, struct ui_file *stream, int recurse, + const struct value_print_options *options) { - if (ada_is_fixed_point_type (type)) - { - LONGEST v = unpack_long (type, valaddr + offset_aligned); + struct type *type = ada_check_typedef (value_type (val)); + const gdb_byte *valaddr = value_contents_for_printing (val); - fprintf_filtered (stream, TYPE_LENGTH (type) < 4 ? "%.11g" : "%.17g", - (double) ada_fixed_to_float (type, v)); - return; - } - else if (TYPE_CODE (type) == TYPE_CODE_RANGE) + if (type->code () == TYPE_CODE_RANGE + && (TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_ENUM + || TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_BOOL + || TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_CHAR)) { + /* For enum-valued ranges, we want to recurse, because we'll end + up printing the constant's name rather than its numeric + value. Character and fixed-point types are also printed + differently, so recuse for those as well. */ struct type *target_type = TYPE_TARGET_TYPE (type); - - if (TYPE_LENGTH (type) != TYPE_LENGTH (target_type)) - { - /* Obscure case of range type that has different length from - its base type. Perform a conversion, or we will get a - nonsense value. Actually, we could use the same - code regardless of lengths; I'm just avoiding a cast. */ - struct value *v1 - = value_from_contents_and_address (type, valaddr + offset, 0); - struct value *v = value_cast (target_type, v1); - - val_print (target_type, - value_embedded_offset (v), 0, stream, - recurse + 1, v, options, language); - } - else - val_print (TYPE_TARGET_TYPE (type), offset, - address, stream, recurse, original_value, - options, language); + val = value_cast (target_type, val); + common_val_print (val, stream, recurse + 1, options, + language_def (language_ada)); return; } else @@ -836,8 +774,7 @@ ada_val_print_num (struct type *type, const gdb_byte *valaddr, struct value_print_options opts = *options; opts.format = format; - val_print_scalar_formatted (type, offset_aligned, - original_value, &opts, 0, stream); + value_print_scalar_formatted (val, &opts, 0, stream); } else if (ada_is_system_address_type (type)) { @@ -847,10 +784,9 @@ ada_val_print_num (struct type *type, const gdb_byte *valaddr, so we have to work-around this deficiency by handling System.Address values as a special case. */ - struct gdbarch *gdbarch = get_type_arch (type); + struct gdbarch *gdbarch = type->arch (); struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr; - CORE_ADDR addr = extract_typed_address (valaddr + offset_aligned, - ptr_type); + CORE_ADDR addr = extract_typed_address (valaddr, ptr_type); fprintf_filtered (stream, "("); type_print (type, "", stream, -1); @@ -859,14 +795,13 @@ ada_val_print_num (struct type *type, const gdb_byte *valaddr, } else { - val_print_scalar_formatted (type, offset_aligned, - original_value, options, 0, stream); + value_print_scalar_formatted (val, options, 0, stream); if (ada_is_character_type (type)) { LONGEST c; fputs_filtered (" ", stream); - c = unpack_long (type, valaddr + offset_aligned); + c = unpack_long (type, valaddr); ada_printchar (c, type, stream); } } @@ -878,12 +813,8 @@ ada_val_print_num (struct type *type, const gdb_byte *valaddr, a TYPE_CODE_ENUM. */ static void -ada_val_print_enum (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) +ada_val_print_enum (struct value *value, struct ui_file *stream, int recurse, + const struct value_print_options *options) { int i; unsigned int len; @@ -891,12 +822,15 @@ ada_val_print_enum (struct type *type, const gdb_byte *valaddr, if (options->format) { - val_print_scalar_formatted (type, offset_aligned, - original_value, options, 0, stream); + value_print_scalar_formatted (value, options, 0, stream); return; } - len = TYPE_NFIELDS (type); + struct type *type = ada_check_typedef (value_type (value)); + const gdb_byte *valaddr = value_contents_for_printing (value); + int offset_aligned = ada_aligned_value_addr (type, valaddr) - valaddr; + + len = type->num_fields (); val = unpack_long (type, valaddr + offset_aligned); for (i = 0; i < len; i++) { @@ -910,47 +844,26 @@ ada_val_print_enum (struct type *type, const gdb_byte *valaddr, const char *name = ada_enum_name (TYPE_FIELD_NAME (type, i)); if (name[0] == '\'') - fprintf_filtered (stream, "%ld %s", (long) val, name); + fprintf_filtered (stream, "%ld %ps", (long) val, + styled_string (variable_name_style.style (), + name)); else - fputs_filtered (name, stream); + fputs_styled (name, variable_name_style.style (), stream); } else print_longest (stream, 'd', 0, val); } -/* Implement Ada val_print'ing for the case where TYPE is - a TYPE_CODE_FLT. */ - -static void -ada_val_print_flt (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) -{ - if (options->format) - { - val_print (type, offset, address, stream, recurse, - original_value, options, language_def (language_c)); - return; - } - - ada_print_floating (valaddr + offset, type, stream); -} - -/* Implement Ada val_print'ing for the case where TYPE is - a TYPE_CODE_STRUCT or TYPE_CODE_UNION. */ +/* Implement Ada val_print'ing for the case where the type is + TYPE_CODE_STRUCT or TYPE_CODE_UNION. */ static void -ada_val_print_struct_union - (struct type *type, const gdb_byte *valaddr, int offset, - int offset_aligned, CORE_ADDR address, struct ui_file *stream, - int recurse, struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) +ada_val_print_struct_union (struct value *value, + struct ui_file *stream, + int recurse, + const struct value_print_options *options) { - if (ada_is_bogus_array_descriptor (type)) + if (ada_is_bogus_array_descriptor (value_type (value))) { fprintf_filtered (stream, "(...?)"); return; @@ -958,9 +871,8 @@ ada_val_print_struct_union fprintf_filtered (stream, "("); - if (print_field_values (type, valaddr, offset_aligned, - stream, recurse, original_value, options, - 0, type, offset_aligned, language) != 0 + if (print_field_values (value, value, stream, recurse, options, + 0, language_def (language_ada)) != 0 && options->prettyformat) { fprintf_filtered (stream, "\n"); @@ -970,36 +882,41 @@ ada_val_print_struct_union fprintf_filtered (stream, ")"); } -/* Implement Ada val_print'ing for the case where TYPE is - a TYPE_CODE_ARRAY. */ +/* Implement Ada value_print'ing for the case where TYPE is a + TYPE_CODE_ARRAY. */ static void -ada_val_print_array (struct type *type, const gdb_byte *valaddr, - int offset, int offset_aligned, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options) +ada_value_print_array (struct value *val, struct ui_file *stream, int recurse, + const struct value_print_options *options) { + struct type *type = ada_check_typedef (value_type (val)); + /* For an array of characters, print with string syntax. */ if (ada_is_string_type (type) && (options->format == 0 || options->format == 's')) { - ada_val_print_string (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, + const gdb_byte *valaddr = value_contents_for_printing (val); + int offset_aligned = ada_aligned_value_addr (type, valaddr) - valaddr; + + ada_val_print_string (type, valaddr, offset_aligned, stream, recurse, options); return; } fprintf_filtered (stream, "("); print_optional_low_bound (stream, type, options); - if (TYPE_FIELD_BITSIZE (type, 0) > 0) - val_print_packed_array_elements (type, valaddr, offset_aligned, - 0, stream, recurse, - original_value, options); + + if (value_entirely_optimized_out (val)) + val_print_optimized_out (val, stream); + else if (TYPE_FIELD_BITSIZE (type, 0) > 0) + { + const gdb_byte *valaddr = value_contents_for_printing (val); + int offset_aligned = ada_aligned_value_addr (type, valaddr) - valaddr; + val_print_packed_array_elements (type, valaddr, offset_aligned, + stream, recurse, options); + } else - val_print_array_elements (type, offset_aligned, address, - stream, recurse, original_value, - options, 0); + value_print_array_elements (val, stream, recurse, options, 0); fprintf_filtered (stream, ")"); } @@ -1011,8 +928,7 @@ ada_val_print_ref (struct type *type, const gdb_byte *valaddr, int offset, int offset_aligned, CORE_ADDR address, struct ui_file *stream, int recurse, struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) + const struct value_print_options *options) { /* For references, the debugger is expected to print the value as an address if DEREF_REF is null. But printing an address in place @@ -1023,9 +939,10 @@ ada_val_print_ref (struct type *type, const gdb_byte *valaddr, struct value *deref_val; CORE_ADDR deref_val_int; - if (TYPE_CODE (elttype) == TYPE_CODE_UNDEF) + if (elttype->code () == TYPE_CODE_UNDEF) { - fputs_filtered ("", stream); + fputs_styled ("", metadata_style.style (), + stream); return; } @@ -1036,7 +953,7 @@ ada_val_print_ref (struct type *type, const gdb_byte *valaddr, deref_val = ada_tag_value_at_base_address (deref_val); common_val_print (deref_val, stream, recurse + 1, options, - language); + language_def (language_ada)); return; } @@ -1062,118 +979,121 @@ ada_val_print_ref (struct type *type, const gdb_byte *valaddr, if (value_lazy (deref_val)) value_fetch_lazy (deref_val); - val_print (value_type (deref_val), - value_embedded_offset (deref_val), - value_address (deref_val), stream, recurse + 1, - deref_val, options, language); + common_val_print (deref_val, stream, recurse + 1, + options, language_def (language_ada)); } -/* See the comment on ada_val_print. This function differs in that it - does not catch evaluation errors (leaving that to ada_val_print). */ +/* See the comment on ada_value_print. This function differs in that + it does not catch evaluation errors (leaving that to + ada_value_print). */ static void -ada_val_print_1 (struct type *type, - int offset, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *original_value, - const struct value_print_options *options, - const struct language_defn *language) +ada_value_print_1 (struct value *val, struct ui_file *stream, int recurse, + const struct value_print_options *options) { - int offset_aligned; - const gdb_byte *valaddr = value_contents_for_printing (original_value); - - type = ada_check_typedef (type); + struct type *type = ada_check_typedef (value_type (val)); if (ada_is_array_descriptor_type (type) || (ada_is_constrained_packed_array_type (type) - && TYPE_CODE (type) != TYPE_CODE_PTR)) + && type->code () != TYPE_CODE_PTR)) { - ada_val_print_gnat_array (type, valaddr, offset, address, - stream, recurse, original_value, - options, language); - return; + /* If this is a reference, coerce it now. This helps taking + care of the case where ADDRESS is meaningless because + original_value was not an lval. */ + val = coerce_ref (val); + val = ada_get_decoded_value (val); + if (val == nullptr) + { + gdb_assert (type->code () == TYPE_CODE_TYPEDEF); + fprintf_filtered (stream, "0x0"); + return; + } } + else + val = ada_to_fixed_value (val); - offset_aligned = offset + ada_aligned_value_addr (type, valaddr) - valaddr; - type = printable_val_type (type, valaddr + offset_aligned); - type = resolve_dynamic_type (type, valaddr + offset_aligned, - address + offset_aligned); + type = value_type (val); + struct type *saved_type = type; - switch (TYPE_CODE (type)) + const gdb_byte *valaddr = value_contents_for_printing (val); + CORE_ADDR address = value_address (val); + gdb::array_view view + = gdb::make_array_view (valaddr, TYPE_LENGTH (type)); + type = ada_check_typedef (resolve_dynamic_type (type, view, address)); + if (type != saved_type) + { + val = value_copy (val); + deprecated_set_value_type (val, type); + } + + if (is_fixed_point_type (type)) + type = type->fixed_point_type_base_type (); + + switch (type->code ()) { default: - val_print (type, offset, address, stream, recurse, - original_value, options, language_def (language_c)); + common_val_print (val, stream, recurse, options, + language_def (language_c)); break; case TYPE_CODE_PTR: - ada_val_print_ptr (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options, language); + ada_value_print_ptr (val, stream, recurse, options); break; case TYPE_CODE_INT: case TYPE_CODE_RANGE: - ada_val_print_num (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options, language); + ada_value_print_num (val, stream, recurse, options); break; case TYPE_CODE_ENUM: - ada_val_print_enum (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options, language); + ada_val_print_enum (val, stream, recurse, options); break; case TYPE_CODE_FLT: - ada_val_print_flt (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options, language); + if (options->format) + { + common_val_print (val, stream, recurse, options, + language_def (language_c)); + break; + } + + ada_print_floating (valaddr, type, stream); break; case TYPE_CODE_UNION: case TYPE_CODE_STRUCT: - ada_val_print_struct_union (type, valaddr, offset, offset_aligned, - address, stream, recurse, - original_value, options, language); + ada_val_print_struct_union (val, stream, recurse, options); break; case TYPE_CODE_ARRAY: - ada_val_print_array (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options); + ada_value_print_array (val, stream, recurse, options); return; case TYPE_CODE_REF: - ada_val_print_ref (type, valaddr, offset, offset_aligned, - address, stream, recurse, original_value, - options, language); + ada_val_print_ref (type, valaddr, 0, 0, + address, stream, recurse, val, + options); break; } } -/* See val_print for a description of the various parameters of this - function; they are identical. */ +/* See ada-lang.h. */ void -ada_val_print (struct type *type, - int embedded_offset, CORE_ADDR address, - struct ui_file *stream, int recurse, - struct value *val, - const struct value_print_options *options) +ada_value_print_inner (struct value *val, struct ui_file *stream, + int recurse, + const struct value_print_options *options) { - - /* XXX: this catches QUIT/ctrl-c as well. Isn't that busted? */ - TRY + try { - ada_val_print_1 (type, embedded_offset, address, - stream, recurse, val, options, - current_language); + ada_value_print_1 (val, stream, recurse, options); } - CATCH (except, RETURN_MASK_ALL) + catch (const gdb_exception_error &except) { + fprintf_styled (stream, metadata_style.style (), + _(""), + except.what ()); } - END_CATCH } void @@ -1181,18 +1101,20 @@ ada_value_print (struct value *val0, struct ui_file *stream, const struct value_print_options *options) { struct value *val = ada_to_fixed_value (val0); - CORE_ADDR address = value_address (val); - struct type *type = ada_check_typedef (value_enclosing_type (val)); + struct type *type = ada_check_typedef (value_type (val)); struct value_print_options opts; - /* If it is a pointer, indicate what it points to. */ - if (TYPE_CODE (type) == TYPE_CODE_PTR) + /* If it is a pointer, indicate what it points to; but not for + "void *" pointers. */ + if (type->code () == TYPE_CODE_PTR + && !(TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_INT + && TYPE_LENGTH (TYPE_TARGET_TYPE (type)) == 0)) { /* Hack: don't print (char *) for char strings. Their - type is indicated by the quoted string anyway. */ + type is indicated by the quoted string anyway. */ if (TYPE_LENGTH (TYPE_TARGET_TYPE (type)) != sizeof (char) - || TYPE_CODE (TYPE_TARGET_TYPE (type)) != TYPE_CODE_INT - || TYPE_UNSIGNED (TYPE_TARGET_TYPE (type))) + || TYPE_TARGET_TYPE (type)->code () != TYPE_CODE_INT + || TYPE_TARGET_TYPE (type)->is_unsigned ()) { fprintf_filtered (stream, "("); type_print (type, "", stream, -1); @@ -1204,8 +1126,8 @@ ada_value_print (struct value *val0, struct ui_file *stream, /* We do not print the type description unless TYPE is an array access type (this is encoded by the compiler as a typedef to a fat pointer - hence the check against TYPE_CODE_TYPEDEF). */ - if (TYPE_CODE (type) == TYPE_CODE_TYPEDEF) - { + if (type->code () == TYPE_CODE_TYPEDEF) + { fprintf_filtered (stream, "("); type_print (type, "", stream, -1); fprintf_filtered (stream, ") "); @@ -1221,7 +1143,5 @@ ada_value_print (struct value *val0, struct ui_file *stream, opts = *options; opts.deref_ref = 1; - val_print (type, - value_embedded_offset (val), address, - stream, 0, val, &opts, current_language); + common_val_print (val, stream, 0, &opts, current_language); }