X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fbuildsym.c;h=c08c476a0d4a559b9a9091be8a7c8a7002866a36;hb=8e4979ac1ea78147ecbcbf81af5e946873dda079;hp=e9ca175d3ab1bf92054ada9beb8152e4732648ab;hpb=0f552c5fc6ed8ddf060a01c97cbef7c0c890ffe4;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/buildsym.c b/gdb/buildsym.c index e9ca175d3a..c08c476a0d 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -1,303 +1,148 @@ -/* Build symbol tables in GDB's internal format. - Copyright 1986, 1987, 1988, 1989, 1990, 1991, 1992 - Free Software Foundation, Inc. +/* Support routines for building symbol tables in GDB's internal format. + Copyright (C) 1986-2020 Free Software Foundation, Inc. -This file is part of GDB. + This file is part of GDB. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. -You should have received a copy of the GNU General Public License -along with this program; if not, write to the Free Software -Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ - -/* This module provides subroutines used for creating and adding to - the symbol table. These routines are called from various symbol- - file-reading routines. - - They originated in dbxread.c of gdb-4.2, and were split out to - make xcoffread.c more maintainable by sharing code. */ + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ #include "defs.h" -#include "obstack.h" +#include "buildsym-legacy.h" +#include "bfd.h" +#include "gdb_obstack.h" #include "symtab.h" -#include "gdbtypes.h" -#include "breakpoint.h" -#include "gdbcore.h" /* for bfd stuff for symfile.h */ -#include "symfile.h" /* Needed for "struct complaint" */ +#include "symfile.h" #include "objfiles.h" -#include "aout/stab_gnu.h" /* We always use GNU stabs, not native */ -#include -#include - -/* Ask buildsym.h to define the vars it normally declares `extern'. */ -#define EXTERN /**/ -#include "buildsym.h" /* Our own declarations */ -#undef EXTERN - -static void -patch_block_stabs PARAMS ((struct pending *, struct pending_stabs *, - struct objfile *)); - -static void -read_huge_number PARAMS ((char **, int, long *, int *)); - -struct type * -dbx_alloc_type PARAMS ((int [2], struct objfile *)); - -static int -compare_line_numbers PARAMS ((const void *, const void *)); - -static struct blockvector * -make_blockvector PARAMS ((struct objfile *)); - -static void -fix_common_block PARAMS ((struct symbol *, int)); - -static void -cleanup_undefined_types PARAMS ((void)); - -static struct type * -read_range_type PARAMS ((char **, int [2], struct objfile *)); - -static struct type * -read_sun_builtin_type PARAMS ((char **, int [2], struct objfile *)); - -static struct type * -read_sun_floating_type PARAMS ((char **, int [2], struct objfile *)); - -static struct type * -read_enum_type PARAMS ((char **, struct type *, struct objfile *)); - -static struct type * -read_struct_type PARAMS ((char **, struct type *, struct objfile *)); - -static struct type * -read_array_type PARAMS ((char **, struct type *, struct objfile *)); - -static struct type ** -read_args PARAMS ((char **, int, struct objfile *)); - - - -static const char vptr_name[] = { '_','v','p','t','r',CPLUS_MARKER,'\0' }; -static const char vb_name[] = { '_','v','b',CPLUS_MARKER,'\0' }; - -/* Define this as 1 if a pcc declaration of a char or short argument - gives the correct address. Otherwise assume pcc gives the - address of the corresponding int, which is not the same on a - big-endian machine. */ - -#ifndef BELIEVE_PCC_PROMOTION -#define BELIEVE_PCC_PROMOTION 0 -#endif - -/* During some calls to read_type (and thus to read_range_type), this - contains the name of the type being defined. Range types are only - used in C as basic types. We use the name to distinguish the otherwise - identical basic types "int" and "long" and their unsigned versions. - FIXME, this should disappear with better type management. */ - -static char *long_kludge_name; - -/* Make a list of forward references which haven't been defined. */ -static struct type **undef_types; -static int undef_types_allocated, undef_types_length; +#include "gdbtypes.h" +#include "complaints.h" +#include "expression.h" /* For "enum exp_opcode" used by... */ +#include "filenames.h" /* For DOSish file names. */ +#include "macrotab.h" +#include "demangle.h" /* Needed by SYMBOL_INIT_DEMANGLED_NAME. */ +#include "block.h" +#include "cp-support.h" +#include "dictionary.h" +#include "addrmap.h" +#include + +/* For cleanup_undefined_stabs_types and finish_global_stabs (somewhat + questionable--see comment where we call them). */ + +#include "stabsread.h" + +/* List of blocks already made (lexical contexts already closed). + This is used at the end to make the blockvector. */ + +struct pending_block + { + struct pending_block *next; + struct block *block; + }; -/* Initial sizes of data structures. These are realloc'd larger if needed, - and realloc'd down to the size actually used, when completed. */ +/* Initial sizes of data structures. These are realloc'd larger if + needed, and realloc'd down to the size actually used, when + completed. */ -#define INITIAL_CONTEXT_STACK_SIZE 10 -#define INITIAL_TYPE_VECTOR_LENGTH 160 #define INITIAL_LINE_VECTOR_LENGTH 1000 -/* Complaints about the symbols we have encountered. */ -struct complaint innerblock_complaint = - {"inner block not inside outer block in %s", 0, 0}; - -struct complaint blockvector_complaint = - {"block at %x out of order", 0, 0}; - -#if 0 -struct complaint dbx_class_complaint = - {"encountered DBX-style class variable debugging information.\n\ -You seem to have compiled your program with \ -\"g++ -g0\" instead of \"g++ -g\".\n\ -Therefore GDB will not know about your class variables", 0, 0}; -#endif - -struct complaint invalid_cpp_abbrev_complaint = - {"invalid C++ abbreviation `%s'", 0, 0}; - -struct complaint invalid_cpp_type_complaint = - {"C++ abbreviated type name unknown at symtab pos %d", 0, 0}; - -struct complaint member_fn_complaint = - {"member function type missing, got '%c'", 0, 0}; - -struct complaint const_vol_complaint = - {"const/volatile indicator missing, got '%c'", 0, 0}; - -struct complaint error_type_complaint = - {"debug info mismatch between compiler and debugger", 0, 0}; - -struct complaint invalid_member_complaint = - {"invalid (minimal) member type data format at symtab pos %d.", 0, 0}; - -struct complaint range_type_base_complaint = - {"base type %d of range type is not defined", 0, 0}; - -struct complaint reg_value_complaint = - {"register number too large in symbol %s", 0, 0}; - -int -hashname (name) - char *name; +buildsym_compunit::buildsym_compunit (struct objfile *objfile_, + const char *name, + const char *comp_dir_, + enum language language_, + CORE_ADDR last_addr) + : m_objfile (objfile_), + m_last_source_file (name == nullptr ? nullptr : xstrdup (name)), + m_comp_dir (comp_dir_ == nullptr ? nullptr : xstrdup (comp_dir_)), + m_language (language_), + m_last_source_start_addr (last_addr) { - register char *p = name; - register int total = p[0]; - register int c; - - c = p[1]; - total += c << 2; - if (c) - { - c = p[2]; - total += c << 4; - if (c) - total += p[3] << 6; - } - - /* Ensure result is positive. */ - if (total < 0) total += (1000 << 6); - return total % HASHSIZE; + /* Allocate the compunit symtab now. The caller needs it to allocate + non-primary symtabs. It is also needed by get_macro_table. */ + m_compunit_symtab = allocate_compunit_symtab (m_objfile, name); + + /* Build the subfile for NAME (the main source file) so that we can record + a pointer to it for later. + IMPORTANT: Do not allocate a struct symtab for NAME here. + It can happen that the debug info provides a different path to NAME than + DIRNAME,NAME. We cope with this in watch_main_source_file_lossage but + that only works if the main_subfile doesn't have a symtab yet. */ + start_subfile (name); + /* Save this so that we don't have to go looking for it at the end + of the subfiles list. */ + m_main_subfile = m_current_subfile; } - -/* Look up a dbx type-number pair. Return the address of the slot - where the type for that number-pair is stored. - The number-pair is in TYPENUMS. - - This can be used for finding the type associated with that pair - or for associating a new type with the pair. */ - -struct type ** -dbx_lookup_type (typenums) - int typenums[2]; +buildsym_compunit::~buildsym_compunit () { - register int filenum = typenums[0], index = typenums[1]; - unsigned old_len; + struct subfile *subfile, *nextsub; - if (filenum == -1) /* -1,-1 is for temporary types. */ - return 0; + if (m_pending_macros != nullptr) + free_macro_table (m_pending_macros); - if (filenum < 0 || filenum >= n_this_object_header_files) - error ("Invalid symbol data: type number (%d,%d) out of range at symtab pos %d.", - filenum, index, symnum); - - if (filenum == 0) + for (subfile = m_subfiles; + subfile != NULL; + subfile = nextsub) { - /* Type is defined outside of header files. - Find it in this object file's type vector. */ - if (index >= type_vector_length) - { - old_len = type_vector_length; - if (old_len == 0) { - type_vector_length = INITIAL_TYPE_VECTOR_LENGTH; - type_vector = (struct type **) - malloc (type_vector_length * sizeof (struct type *)); - } - while (index >= type_vector_length) - type_vector_length *= 2; - type_vector = (struct type **) - xrealloc ((char *) type_vector, - (type_vector_length * sizeof (struct type *))); - (void) memset (&type_vector[old_len], 0, - (type_vector_length - old_len) * sizeof (struct type *)); - } - return &type_vector[index]; + nextsub = subfile->next; + xfree (subfile->name); + xfree (subfile->line_vector); + xfree (subfile); } - else - { - register int real_filenum = this_object_header_files[filenum]; - register struct header_file *f; - int f_orig_length; - if (real_filenum >= n_header_files) - abort (); + struct pending *next, *next1; - f = &header_files[real_filenum]; + for (next = m_file_symbols; next != NULL; next = next1) + { + next1 = next->next; + xfree ((void *) next); + } - f_orig_length = f->length; - if (index >= f_orig_length) - { - while (index >= f->length) - f->length *= 2; - f->vector = (struct type **) - xrealloc ((char *) f->vector, f->length * sizeof (struct type *)); - (void) memset (&f->vector[f_orig_length], 0, - (f->length - f_orig_length) * sizeof (struct type *)); - } - return &f->vector[index]; + for (next = m_global_symbols; next != NULL; next = next1) + { + next1 = next->next; + xfree ((void *) next); } } -/* Make sure there is a type allocated for type numbers TYPENUMS - and return the type object. - This can create an empty (zeroed) type object. - TYPENUMS may be (-1, -1) to return a new type object that is not - put into the type vector, and so may not be referred to by number. */ - -struct type * -dbx_alloc_type (typenums, objfile) - int typenums[2]; - struct objfile *objfile; +struct macro_table * +buildsym_compunit::get_macro_table () { - register struct type **type_addr; - - if (typenums[0] == -1) - return alloc_type (objfile); - - type_addr = dbx_lookup_type (typenums); - - /* If we are referring to a type not known at all yet, - allocate an empty type for it. - We will fill it in later if we find out how. */ - if (*type_addr == 0) - *type_addr = alloc_type (objfile); - - return *type_addr; + if (m_pending_macros == nullptr) + m_pending_macros = new_macro_table (&m_objfile->per_bfd->storage_obstack, + &m_objfile->per_bfd->string_cache, + m_compunit_symtab); + return m_pending_macros; } - -/* maintain the lists of symbols and blocks */ + +/* Maintain the lists of symbols and blocks. */ /* Add a symbol to one of the lists of symbols. */ + void -add_symbol_to_list (symbol, listhead) - struct symbol *symbol; - struct pending **listhead; +add_symbol_to_list (struct symbol *symbol, struct pending **listhead) { - /* We keep PENDINGSIZE symbols in each link of the list. - If we don't have a link with room in it, add a new link. */ - if (*listhead == 0 || (*listhead)->nsyms == PENDINGSIZE) - { - register struct pending *link; - if (free_pendings) - { - link = free_pendings; - free_pendings = link->next; - } - else - link = (struct pending *) xmalloc (sizeof (struct pending)); + struct pending *link; + + /* If this is an alias for another symbol, don't add it. */ + if (symbol->linkage_name () && symbol->linkage_name ()[0] == '#') + return; + /* We keep PENDINGSIZE symbols in each link of the list. If we + don't have a link with room in it, add a new link. */ + if (*listhead == NULL || (*listhead)->nsyms == PENDINGSIZE) + { + link = XNEW (struct pending); link->next = *listhead; *listhead = link; link->nsyms = 0; @@ -306,3206 +151,1094 @@ add_symbol_to_list (symbol, listhead) (*listhead)->symbol[(*listhead)->nsyms++] = symbol; } -/* Find a symbol on a pending list. */ +/* Find a symbol named NAME on a LIST. NAME need not be + '\0'-terminated; LENGTH is the length of the name. */ + struct symbol * -find_symbol_in_list (list, name, length) - struct pending *list; - char *name; - int length; +find_symbol_in_list (struct pending *list, char *name, int length) { int j; + const char *pp; - while (list) { - for (j = list->nsyms; --j >= 0; ) { - char *pp = SYMBOL_NAME (list->symbol[j]); - if (*pp == *name && strncmp (pp, name, length) == 0 && pp[length] == '\0') - return list->symbol[j]; + while (list != NULL) + { + for (j = list->nsyms; --j >= 0;) + { + pp = list->symbol[j]->linkage_name (); + if (*pp == *name && strncmp (pp, name, length) == 0 + && pp[length] == '\0') + { + return (list->symbol[j]); + } + } + list = list->next; } - list = list->next; - } - return NULL; + return (NULL); } -/* At end of reading syms, or in case of quit, - really free as many `struct pending's as we can easily find. */ +/* Record BLOCK on the list of all blocks in the file. Put it after + OPBLOCK, or at the beginning if opblock is NULL. This puts the + block in the list after all its subblocks. */ -/* ARGSUSED */ void -really_free_pendings (foo) - int foo; +buildsym_compunit::record_pending_block (struct block *block, + struct pending_block *opblock) { - struct pending *next, *next1; -#if 0 - struct pending_block *bnext, *bnext1; -#endif + struct pending_block *pblock; - for (next = free_pendings; next; next = next1) - { - next1 = next->next; - free ((PTR)next); - } - free_pendings = 0; - -#if 0 /* Now we make the links in the symbol_obstack, so don't free them. */ - for (bnext = pending_blocks; bnext; bnext = bnext1) - { - bnext1 = bnext->next; - free ((PTR)bnext); - } -#endif - pending_blocks = 0; - - for (next = file_symbols; next; next = next1) + pblock = XOBNEW (&m_pending_block_obstack, struct pending_block); + pblock->block = block; + if (opblock) { - next1 = next->next; - free ((PTR)next); + pblock->next = opblock->next; + opblock->next = pblock; } - file_symbols = 0; - - for (next = global_symbols; next; next = next1) + else { - next1 = next->next; - free ((PTR)next); + pblock->next = m_pending_blocks; + m_pending_blocks = pblock; } - global_symbols = 0; } -/* Take one of the lists of symbols and make a block from it. - Keep the order the symbols have in the list (reversed from the input file). - Put the block on the list of pending blocks. */ - -void -finish_block (symbol, listhead, old_blocks, start, end, objfile) - struct symbol *symbol; - struct pending **listhead; - struct pending_block *old_blocks; - CORE_ADDR start, end; - struct objfile *objfile; +/* Take one of the lists of symbols and make a block from it. Keep + the order the symbols have in the list (reversed from the input + file). Put the block on the list of pending blocks. */ + +struct block * +buildsym_compunit::finish_block_internal + (struct symbol *symbol, + struct pending **listhead, + struct pending_block *old_blocks, + const struct dynamic_prop *static_link, + CORE_ADDR start, CORE_ADDR end, + int is_global, int expandable) { - register struct pending *next, *next1; - register struct block *block; - register struct pending_block *pblock; + struct gdbarch *gdbarch = get_objfile_arch (m_objfile); + struct pending *next, *next1; + struct block *block; + struct pending_block *pblock; struct pending_block *opblock; - register int i; - - /* Count the length of the list of symbols. */ - - for (next = *listhead, i = 0; - next; - i += next->nsyms, next = next->next) - /*EMPTY*/; - block = (struct block *) obstack_alloc (&objfile -> symbol_obstack, - (sizeof (struct block) + ((i - 1) * sizeof (struct symbol *)))); + block = (is_global + ? allocate_global_block (&m_objfile->objfile_obstack) + : allocate_block (&m_objfile->objfile_obstack)); - /* Copy the symbols into the block. */ - - BLOCK_NSYMS (block) = i; - for (next = *listhead; next; next = next->next) + if (symbol) + { + BLOCK_MULTIDICT (block) + = mdict_create_linear (&m_objfile->objfile_obstack, *listhead); + } + else { - register int j; - for (j = next->nsyms - 1; j >= 0; j--) - BLOCK_SYM (block, --i) = next->symbol[j]; + if (expandable) + { + BLOCK_MULTIDICT (block) = mdict_create_hashed_expandable (m_language); + mdict_add_pending (BLOCK_MULTIDICT (block), *listhead); + } + else + { + BLOCK_MULTIDICT (block) = + mdict_create_hashed (&m_objfile->objfile_obstack, *listhead); + } } BLOCK_START (block) = start; BLOCK_END (block) = end; - BLOCK_SUPERBLOCK (block) = 0; /* Filled in when containing block is made */ - BLOCK_GCC_COMPILED (block) = processing_gcc_compilation; /* Put the block in as the value of the symbol that names it. */ if (symbol) { + struct type *ftype = SYMBOL_TYPE (symbol); + struct mdict_iterator miter; SYMBOL_BLOCK_VALUE (symbol) = block; BLOCK_FUNCTION (block) = symbol; + + if (TYPE_NFIELDS (ftype) <= 0) + { + /* No parameter type information is recorded with the + function's type. Set that from the type of the + parameter symbols. */ + int nparams = 0, iparams; + struct symbol *sym; + + /* Here we want to directly access the dictionary, because + we haven't fully initialized the block yet. */ + ALL_DICT_SYMBOLS (BLOCK_MULTIDICT (block), miter, sym) + { + if (SYMBOL_IS_ARGUMENT (sym)) + nparams++; + } + if (nparams > 0) + { + TYPE_NFIELDS (ftype) = nparams; + TYPE_FIELDS (ftype) = (struct field *) + TYPE_ALLOC (ftype, nparams * sizeof (struct field)); + + iparams = 0; + /* Here we want to directly access the dictionary, because + we haven't fully initialized the block yet. */ + ALL_DICT_SYMBOLS (BLOCK_MULTIDICT (block), miter, sym) + { + if (iparams == nparams) + break; + + if (SYMBOL_IS_ARGUMENT (sym)) + { + TYPE_FIELD_TYPE (ftype, iparams) = SYMBOL_TYPE (sym); + TYPE_FIELD_ARTIFICIAL (ftype, iparams) = 0; + iparams++; + } + } + } + } } else - BLOCK_FUNCTION (block) = 0; + { + BLOCK_FUNCTION (block) = NULL; + } + + if (static_link != NULL) + objfile_register_static_link (m_objfile, block, static_link); - /* Now "free" the links of the list, and empty the list. */ + /* Now free the links of the list, and empty the list. */ for (next = *listhead; next; next = next1) { next1 = next->next; - next->next = free_pendings; - free_pendings = next; + xfree (next); } - *listhead = 0; + *listhead = NULL; - /* Install this block as the superblock - of all blocks made since the start of this scope - that don't have superblocks yet. */ + /* Check to be sure that the blocks have an end address that is + greater than starting address. */ - opblock = 0; - for (pblock = pending_blocks; pblock != old_blocks; pblock = pblock->next) + if (BLOCK_END (block) < BLOCK_START (block)) { - if (BLOCK_SUPERBLOCK (pblock->block) == 0) { -#if 1 - /* Check to be sure the blocks are nested as we receive them. - If the compiler/assembler/linker work, this just burns a small - amount of time. */ - if (BLOCK_START (pblock->block) < BLOCK_START (block) - || BLOCK_END (pblock->block) > BLOCK_END (block)) { - complain(&innerblock_complaint, symbol? SYMBOL_NAME (symbol): - "(don't know)"); - BLOCK_START (pblock->block) = BLOCK_START (block); - BLOCK_END (pblock->block) = BLOCK_END (block); + if (symbol) + { + complaint (_("block end address less than block " + "start address in %s (patched it)"), + symbol->print_name ()); } -#endif - BLOCK_SUPERBLOCK (pblock->block) = block; - } - opblock = pblock; + else + { + complaint (_("block end address %s less than block " + "start address %s (patched it)"), + paddress (gdbarch, BLOCK_END (block)), + paddress (gdbarch, BLOCK_START (block))); + } + /* Better than nothing. */ + BLOCK_END (block) = BLOCK_START (block); } - /* Record this block on the list of all blocks in the file. - Put it after opblock, or at the beginning if opblock is 0. - This puts the block in the list after all its subblocks. */ + /* Install this block as the superblock of all blocks made since the + start of this scope that don't have superblocks yet. */ - /* Allocate in the symbol_obstack to save time. - It wastes a little space. */ - pblock = (struct pending_block *) - obstack_alloc (&objfile -> symbol_obstack, - sizeof (struct pending_block)); - pblock->block = block; - if (opblock) + opblock = NULL; + for (pblock = m_pending_blocks; + pblock && pblock != old_blocks; + pblock = pblock->next) { - pblock->next = opblock->next; - opblock->next = pblock; + if (BLOCK_SUPERBLOCK (pblock->block) == NULL) + { + /* Check to be sure the blocks are nested as we receive + them. If the compiler/assembler/linker work, this just + burns a small amount of time. + + Skip blocks which correspond to a function; they're not + physically nested inside this other blocks, only + lexically nested. */ + if (BLOCK_FUNCTION (pblock->block) == NULL + && (BLOCK_START (pblock->block) < BLOCK_START (block) + || BLOCK_END (pblock->block) > BLOCK_END (block))) + { + if (symbol) + { + complaint (_("inner block not inside outer block in %s"), + symbol->print_name ()); + } + else + { + complaint (_("inner block (%s-%s) not " + "inside outer block (%s-%s)"), + paddress (gdbarch, BLOCK_START (pblock->block)), + paddress (gdbarch, BLOCK_END (pblock->block)), + paddress (gdbarch, BLOCK_START (block)), + paddress (gdbarch, BLOCK_END (block))); + } + if (BLOCK_START (pblock->block) < BLOCK_START (block)) + BLOCK_START (pblock->block) = BLOCK_START (block); + if (BLOCK_END (pblock->block) > BLOCK_END (block)) + BLOCK_END (pblock->block) = BLOCK_END (block); + } + BLOCK_SUPERBLOCK (pblock->block) = block; + } + opblock = pblock; } + + block_set_using (block, + (is_global + ? m_global_using_directives + : m_local_using_directives), + &m_objfile->objfile_obstack); + if (is_global) + m_global_using_directives = NULL; else - { - pblock->next = pending_blocks; - pending_blocks = pblock; - } + m_local_using_directives = NULL; + + record_pending_block (block, opblock); + + return block; } -static struct blockvector * -make_blockvector (objfile) - struct objfile *objfile; +struct block * +buildsym_compunit::finish_block (struct symbol *symbol, + struct pending_block *old_blocks, + const struct dynamic_prop *static_link, + CORE_ADDR start, CORE_ADDR end) { - register struct pending_block *next; - register struct blockvector *blockvector; - register int i; + return finish_block_internal (symbol, &m_local_symbols, + old_blocks, static_link, start, end, 0, 0); +} + +/* Record that the range of addresses from START to END_INCLUSIVE + (inclusive, like it says) belongs to BLOCK. BLOCK's start and end + addresses must be set already. You must apply this function to all + BLOCK's children before applying it to BLOCK. + + If a call to this function complicates the picture beyond that + already provided by BLOCK_START and BLOCK_END, then we create an + address map for the block. */ +void +buildsym_compunit::record_block_range (struct block *block, + CORE_ADDR start, + CORE_ADDR end_inclusive) +{ + /* If this is any different from the range recorded in the block's + own BLOCK_START and BLOCK_END, then note that the address map has + become interesting. Note that even if this block doesn't have + any "interesting" ranges, some later block might, so we still + need to record this block in the addrmap. */ + if (start != BLOCK_START (block) + || end_inclusive + 1 != BLOCK_END (block)) + m_pending_addrmap_interesting = true; + + if (m_pending_addrmap == nullptr) + m_pending_addrmap = addrmap_create_mutable (&m_pending_addrmap_obstack); + + addrmap_set_empty (m_pending_addrmap, start, end_inclusive, block); +} + +struct blockvector * +buildsym_compunit::make_blockvector () +{ + struct pending_block *next; + struct blockvector *blockvector; + int i; /* Count the length of the list of blocks. */ - for (next = pending_blocks, i = 0; next; next = next->next, i++); + for (next = m_pending_blocks, i = 0; next; next = next->next, i++) + { + } blockvector = (struct blockvector *) - obstack_alloc (&objfile -> symbol_obstack, + obstack_alloc (&m_objfile->objfile_obstack, (sizeof (struct blockvector) + (i - 1) * sizeof (struct block *))); - /* Copy the blocks into the blockvector. - This is done in reverse order, which happens to put - the blocks into the proper order (ascending starting address). - finish_block has hair to insert each block into the list - after its subblocks in order to make sure this is true. */ + /* Copy the blocks into the blockvector. This is done in reverse + order, which happens to put the blocks into the proper order + (ascending starting address). finish_block has hair to insert + each block into the list after its subblocks in order to make + sure this is true. */ BLOCKVECTOR_NBLOCKS (blockvector) = i; - for (next = pending_blocks; next; next = next->next) { - BLOCKVECTOR_BLOCK (blockvector, --i) = next->block; - } - -#if 0 /* Now we make the links in the obstack, so don't free them. */ - /* Now free the links of the list, and empty the list. */ - - for (next = pending_blocks; next; next = next1) + for (next = m_pending_blocks; next; next = next->next) { - next1 = next->next; - free (next); + BLOCKVECTOR_BLOCK (blockvector, --i) = next->block; } -#endif - pending_blocks = 0; -#if 1 /* FIXME, shut this off after a while to speed up symbol reading. */ - /* Some compilers output blocks in the wrong order, but we depend - on their being in the right order so we can binary search. - Check the order and moan about it. FIXME. */ + free_pending_blocks (); + + /* If we needed an address map for this symtab, record it in the + blockvector. */ + if (m_pending_addrmap != nullptr && m_pending_addrmap_interesting) + BLOCKVECTOR_MAP (blockvector) + = addrmap_create_fixed (m_pending_addrmap, &m_objfile->objfile_obstack); + else + BLOCKVECTOR_MAP (blockvector) = 0; + + /* Some compilers output blocks in the wrong order, but we depend on + their being in the right order so we can binary search. Check the + order and moan about it. + Note: Remember that the first two blocks are the global and static + blocks. We could special case that fact and begin checking at block 2. + To avoid making that assumption we do not. */ if (BLOCKVECTOR_NBLOCKS (blockvector) > 1) - for (i = 1; i < BLOCKVECTOR_NBLOCKS (blockvector); i++) { - if (BLOCK_START(BLOCKVECTOR_BLOCK (blockvector, i-1)) - > BLOCK_START(BLOCKVECTOR_BLOCK (blockvector, i))) { - complain (&blockvector_complaint, - (char *) BLOCK_START(BLOCKVECTOR_BLOCK (blockvector, i))); - } + { + for (i = 1; i < BLOCKVECTOR_NBLOCKS (blockvector); i++) + { + if (BLOCK_START (BLOCKVECTOR_BLOCK (blockvector, i - 1)) + > BLOCK_START (BLOCKVECTOR_BLOCK (blockvector, i))) + { + CORE_ADDR start + = BLOCK_START (BLOCKVECTOR_BLOCK (blockvector, i)); + + complaint (_("block at %s out of order"), + hex_string ((LONGEST) start)); + } + } } -#endif - return blockvector; + return (blockvector); } -/* Start recording information about source code that came from an included - (or otherwise merged-in) source file with a different name. */ +/* Start recording information about source code that came from an + included (or otherwise merged-in) source file with a different + name. NAME is the name of the file (cannot be NULL). */ void -start_subfile (name, dirname) - char *name; - char *dirname; +buildsym_compunit::start_subfile (const char *name) { - register struct subfile *subfile; + const char *subfile_dirname; + struct subfile *subfile; - /* See if this subfile is already known as a subfile of the - current main source file. */ + subfile_dirname = m_comp_dir.get (); - for (subfile = subfiles; subfile; subfile = subfile->next) + /* See if this subfile is already registered. */ + + for (subfile = m_subfiles; subfile; subfile = subfile->next) { - if (!strcmp (subfile->name, name)) + char *subfile_name; + + /* If NAME is an absolute path, and this subfile is not, then + attempt to create an absolute path to compare. */ + if (IS_ABSOLUTE_PATH (name) + && !IS_ABSOLUTE_PATH (subfile->name) + && subfile_dirname != NULL) + subfile_name = concat (subfile_dirname, SLASH_STRING, + subfile->name, (char *) NULL); + else + subfile_name = subfile->name; + + if (FILENAME_CMP (subfile_name, name) == 0) { - current_subfile = subfile; + m_current_subfile = subfile; + if (subfile_name != subfile->name) + xfree (subfile_name); return; } + if (subfile_name != subfile->name) + xfree (subfile_name); } - /* This subfile is not known. Add an entry for it. - Make an entry for this subfile in the list of all subfiles - of the current main source file. */ + /* This subfile is not known. Add an entry for it. */ - subfile = (struct subfile *) xmalloc (sizeof (struct subfile)); - subfile->next = subfiles; - subfiles = subfile; - current_subfile = subfile; + subfile = XNEW (struct subfile); + memset (subfile, 0, sizeof (struct subfile)); + subfile->buildsym_compunit = this; + + subfile->next = m_subfiles; + m_subfiles = subfile; + + m_current_subfile = subfile; + + subfile->name = xstrdup (name); - /* Save its name and compilation directory name */ - subfile->name = strdup (name); - if (dirname == NULL) - subfile->dirname = NULL; - else - subfile->dirname = strdup (dirname); - /* Initialize line-number recording for this subfile. */ - subfile->line_vector = 0; + subfile->line_vector = NULL; + + /* Default the source language to whatever can be deduced from the + filename. If nothing can be deduced (such as for a C/C++ include + file with a ".h" extension), then inherit whatever language the + previous subfile had. This kludgery is necessary because there + is no standard way in some object formats to record the source + language. Also, when symtabs are allocated we try to deduce a + language then as well, but it is too late for us to use that + information while reading symbols, since symtabs aren't allocated + until after all the symbols have been processed for a given + source file. */ + + subfile->language = deduce_language_from_filename (subfile->name); + if (subfile->language == language_unknown + && subfile->next != NULL) + { + subfile->language = subfile->next->language; + } + + /* If the filename of this subfile ends in .C, then change the + language of any pending subfiles from C to C++. We also accept + any other C++ suffixes accepted by deduce_language_from_filename. */ + /* Likewise for f2c. */ + + if (subfile->name) + { + struct subfile *s; + enum language sublang = deduce_language_from_filename (subfile->name); + + if (sublang == language_cplus || sublang == language_fortran) + for (s = m_subfiles; s != NULL; s = s->next) + if (s->language == language_c) + s->language = sublang; + } + + /* And patch up this file if necessary. */ + if (subfile->language == language_c + && subfile->next != NULL + && (subfile->next->language == language_cplus + || subfile->next->language == language_fortran)) + { + subfile->language = subfile->next->language; + } } - -/* Handle the N_BINCL and N_EINCL symbol types - that act like N_SOL for switching source files - (different subfiles, as we call them) within one object file, - but using a stack rather than in an arbitrary order. */ + +/* For stabs readers, the first N_SO symbol is assumed to be the + source file name, and the subfile struct is initialized using that + assumption. If another N_SO symbol is later seen, immediately + following the first one, then the first one is assumed to be the + directory name and the second one is really the source file name. + + So we have to patch up the subfile struct by moving the old name + value to dirname and remembering the new name. Some sanity + checking is performed to ensure that the state of the subfile + struct is reasonable and that the old name we are assuming to be a + directory name actually is (by checking for a trailing '/'). */ void -push_subfile () +buildsym_compunit::patch_subfile_names (struct subfile *subfile, + const char *name) { - register struct subfile_stack *tem - = (struct subfile_stack *) xmalloc (sizeof (struct subfile_stack)); - - tem->next = subfile_stack; - subfile_stack = tem; - if (current_subfile == 0 || current_subfile->name == 0) - abort (); - tem->name = current_subfile->name; + if (subfile != NULL + && m_comp_dir == NULL + && subfile->name != NULL + && IS_DIR_SEPARATOR (subfile->name[strlen (subfile->name) - 1])) + { + m_comp_dir.reset (subfile->name); + subfile->name = xstrdup (name); + set_last_source_file (name); + + /* Default the source language to whatever can be deduced from + the filename. If nothing can be deduced (such as for a C/C++ + include file with a ".h" extension), then inherit whatever + language the previous subfile had. This kludgery is + necessary because there is no standard way in some object + formats to record the source language. Also, when symtabs + are allocated we try to deduce a language then as well, but + it is too late for us to use that information while reading + symbols, since symtabs aren't allocated until after all the + symbols have been processed for a given source file. */ + + subfile->language = deduce_language_from_filename (subfile->name); + if (subfile->language == language_unknown + && subfile->next != NULL) + { + subfile->language = subfile->next->language; + } + } } + +/* Handle the N_BINCL and N_EINCL symbol types that act like N_SOL for + switching source files (different subfiles, as we call them) within + one object file, but using a stack rather than in an arbitrary + order. */ -char * -pop_subfile () +void +buildsym_compunit::push_subfile () { - register char *name; - register struct subfile_stack *link = subfile_stack; - - if (link == 0) - abort (); - - name = link->name; - subfile_stack = link->next; - free ((PTR)link); + gdb_assert (m_current_subfile != NULL); + gdb_assert (m_current_subfile->name != NULL); + m_subfile_stack.push_back (m_current_subfile->name); +} +const char * +buildsym_compunit::pop_subfile () +{ + gdb_assert (!m_subfile_stack.empty ()); + const char *name = m_subfile_stack.back (); + m_subfile_stack.pop_back (); return name; } -/* Manage the vector of line numbers for each subfile. */ +/* Add a linetable entry for line number LINE and address PC to the + line vector for SUBFILE. */ void -record_line (subfile, line, pc) - register struct subfile *subfile; - int line; - CORE_ADDR pc; +buildsym_compunit::record_line (struct subfile *subfile, int line, + CORE_ADDR pc, bool is_stmt) { struct linetable_entry *e; - /* Ignore the dummy line number in libg.o */ - - if (line == 0xffff) - return; /* Make sure line vector exists and is big enough. */ - if (!subfile->line_vector) { - subfile->line_vector_length = INITIAL_LINE_VECTOR_LENGTH; - subfile->line_vector = (struct linetable *) + if (!subfile->line_vector) + { + subfile->line_vector_length = INITIAL_LINE_VECTOR_LENGTH; + subfile->line_vector = (struct linetable *) xmalloc (sizeof (struct linetable) - + subfile->line_vector_length * sizeof (struct linetable_entry)); - subfile->line_vector->nitems = 0; - } + + subfile->line_vector_length * sizeof (struct linetable_entry)); + subfile->line_vector->nitems = 0; + m_have_line_numbers = true; + } - if (subfile->line_vector->nitems + 1 >= subfile->line_vector_length) + if (subfile->line_vector->nitems >= subfile->line_vector_length) { subfile->line_vector_length *= 2; subfile->line_vector = (struct linetable *) - xrealloc ((char *) subfile->line_vector, (sizeof (struct linetable) - + subfile->line_vector_length * sizeof (struct linetable_entry))); + xrealloc ((char *) subfile->line_vector, + (sizeof (struct linetable) + + (subfile->line_vector_length + * sizeof (struct linetable_entry)))); + } + + /* Normally, we treat lines as unsorted. But the end of sequence + marker is special. We sort line markers at the same PC by line + number, so end of sequence markers (which have line == 0) appear + first. This is right if the marker ends the previous function, + and there is no padding before the next function. But it is + wrong if the previous line was empty and we are now marking a + switch to a different subfile. We must leave the end of sequence + marker at the end of this group of lines, not sort the empty line + to after the marker. The easiest way to accomplish this is to + delete any empty lines from our table, if they are followed by + end of sequence markers. All we lose is the ability to set + breakpoints at some lines which contain no instructions + anyway. */ + if (line == 0) + { + while (subfile->line_vector->nitems > 0) + { + e = subfile->line_vector->item + subfile->line_vector->nitems - 1; + if (e->pc != pc) + break; + subfile->line_vector->nitems--; + } } e = subfile->line_vector->item + subfile->line_vector->nitems++; - e->line = line; e->pc = pc; -} - - -/* Needed in order to sort line tables from IBM xcoff files. Sigh! */ - -static int -compare_line_numbers (ln1p, ln2p) - const PTR ln1p; - const PTR ln2p; -{ - return (((struct linetable_entry *) ln1p) -> line - - ((struct linetable_entry *) ln2p) -> line); + e->line = line; + e->is_stmt = is_stmt ? 1 : 0; + e->pc = pc; } -/* Start a new symtab for a new source file. - This is called when a dbx symbol of type N_SO is seen; - it indicates the start of data for one original source file. */ +/* Subroutine of end_symtab to simplify it. Look for a subfile that + matches the main source file's basename. If there is only one, and + if the main source file doesn't have any symbol or line number + information, then copy this file's symtab and line_vector to the + main source file's subfile and discard the other subfile. This can + happen because of a compiler bug or from the user playing games + with #line or from things like a distributed build system that + manipulates the debug info. This can also happen from an innocent + symlink in the paths, we don't canonicalize paths here. */ void -start_symtab (name, dirname, start_addr) - char *name; - char *dirname; - CORE_ADDR start_addr; +buildsym_compunit::watch_main_source_file_lossage () { + struct subfile *mainsub, *subfile; - last_source_file = name; - last_source_start_addr = start_addr; - file_symbols = 0; - global_symbols = 0; - global_stabs = 0; /* AIX COFF */ - within_function = 0; - - /* Context stack is initially empty. Allocate first one with room for - 10 levels; reuse it forever afterward. */ - if (context_stack == 0) { - context_stack_size = INITIAL_CONTEXT_STACK_SIZE; - context_stack = (struct context_stack *) - xmalloc (context_stack_size * sizeof (struct context_stack)); - } - context_stack_depth = 0; + /* Get the main source file. */ + mainsub = m_main_subfile; - /* Leave FILENUM of 0 free for builtin types and this file's types. */ - n_this_object_header_files = 1; + /* If the main source file doesn't have any line number or symbol + info, look for an alias in another subfile. */ - type_vector_length = 0; - type_vector = (struct type **) 0; + if (mainsub->line_vector == NULL + && mainsub->symtab == NULL) + { + const char *mainbase = lbasename (mainsub->name); + int nr_matches = 0; + struct subfile *prevsub; + struct subfile *mainsub_alias = NULL; + struct subfile *prev_mainsub_alias = NULL; - /* Initialize the list of sub source files with one entry - for this file (the top-level source file). */ + prevsub = NULL; + for (subfile = m_subfiles; + subfile != NULL; + subfile = subfile->next) + { + if (subfile == mainsub) + continue; + if (filename_cmp (lbasename (subfile->name), mainbase) == 0) + { + ++nr_matches; + mainsub_alias = subfile; + prev_mainsub_alias = prevsub; + } + prevsub = subfile; + } - subfiles = 0; - current_subfile = 0; - start_subfile (name, dirname); -} + if (nr_matches == 1) + { + gdb_assert (mainsub_alias != NULL && mainsub_alias != mainsub); -/* for all the stabs in a given stab vector, build appropriate types - and fix their symbols in given symbol vector. */ + /* Found a match for the main source file. + Copy its line_vector and symtab to the main subfile + and then discard it. */ -static void -patch_block_stabs (symbols, stabs, objfile) - struct pending *symbols; - struct pending_stabs *stabs; - struct objfile *objfile; -{ - int ii; + mainsub->line_vector = mainsub_alias->line_vector; + mainsub->line_vector_length = mainsub_alias->line_vector_length; + mainsub->symtab = mainsub_alias->symtab; - if (stabs) - { - - /* for all the stab entries, find their corresponding symbols and - patch their types! */ - - for (ii = 0; ii < stabs->count; ++ii) - { - char *name = stabs->stab[ii]; - char *pp = (char*) strchr (name, ':'); - struct symbol *sym = find_symbol_in_list (symbols, name, pp-name); - if (!sym) - { -#ifndef IBM6000_TARGET - printf ("ERROR! stab symbol not found!\n"); /* FIXME */ -#endif - } + if (prev_mainsub_alias == NULL) + m_subfiles = mainsub_alias->next; else - { - pp += 2; - if (*(pp-1) == 'F' || *(pp-1) == 'f') - { - SYMBOL_TYPE (sym) = - lookup_function_type (read_type (&pp, objfile)); - } - else - { - SYMBOL_TYPE (sym) = read_type (&pp, objfile); - } - } + prev_mainsub_alias->next = mainsub_alias->next; + xfree (mainsub_alias->name); + xfree (mainsub_alias); } } } -/* Finish the symbol definitions for one main source file, - close off all the lexical contexts for that file - (creating struct block's for them), then make the struct symtab - for that file and put it in the list of all such. +/* Implementation of the first part of end_symtab. It allows modifying + STATIC_BLOCK before it gets finalized by end_symtab_from_static_block. + If the returned value is NULL there is no blockvector created for + this symtab (you still must call end_symtab_from_static_block). - END_ADDR is the address of the end of the file's text. */ + END_ADDR is the same as for end_symtab: the address of the end of the + file's text. -struct symtab * -end_symtab (end_addr, sort_pending, sort_linevec, objfile) - CORE_ADDR end_addr; - int sort_pending; - int sort_linevec; - struct objfile *objfile; -{ - register struct symtab *symtab; - register struct blockvector *blockvector; - register struct subfile *subfile; - struct subfile *nextsub; + If EXPANDABLE is non-zero the STATIC_BLOCK dictionary is made + expandable. - /* Finish the lexical context of the last function in the file; - pop the context stack. */ + If REQUIRED is non-zero, then a symtab is created even if it does + not contain any symbols. */ - if (context_stack_depth > 0) +struct block * +buildsym_compunit::end_symtab_get_static_block (CORE_ADDR end_addr, + int expandable, int required) +{ + /* Finish the lexical context of the last function in the file; pop + the context stack. */ + + if (!m_context_stack.empty ()) { - register struct context_stack *cstk; - context_stack_depth--; - cstk = &context_stack[context_stack_depth]; + struct context_stack cstk = pop_context (); + /* Make a block for the local symbols within. */ - finish_block (cstk->name, &local_symbols, cstk->old_blocks, - cstk->start_addr, end_addr, objfile); + finish_block (cstk.name, cstk.old_blocks, NULL, + cstk.start_addr, end_addr); - /* Debug: if context stack still has something in it, we are in - trouble. */ - if (context_stack_depth > 0) - abort (); - } - - /* It is unfortunate that in aixcoff, pending blocks might not be ordered - in this stage. Especially, blocks for static functions will show up at - the end. We need to sort them, so tools like `find_pc_function' and - `find_pc_block' can work reliably. */ - if (sort_pending && pending_blocks) { - /* FIXME! Remove this horrid bubble sort and use qsort!!! */ - int swapped; - do { - struct pending_block *pb, *pbnext; - - pb = pending_blocks, pbnext = pb->next; - swapped = 0; - - while ( pbnext ) { - - /* swap blocks if unordered! */ - - if (BLOCK_START(pb->block) < BLOCK_START(pbnext->block)) { - struct block *tmp = pb->block; - pb->block = pbnext->block; - pbnext->block = tmp; - swapped = 1; - } - pb = pbnext; - pbnext = pbnext->next; - } - } while (swapped); - } - - /* Cleanup any undefined types that have been left hanging around - (this needs to be done before the finish_blocks so that - file_symbols is still good). */ - cleanup_undefined_types (); - - if (global_stabs) { - patch_block_stabs (global_symbols, global_stabs, objfile); - free ((PTR)global_stabs); - global_stabs = 0; - } - - if (pending_blocks == 0 - && file_symbols == 0 - && global_symbols == 0) { - /* Ignore symtabs that have no functions with real debugging info */ - blockvector = NULL; - } else { - /* Define the STATIC_BLOCK and GLOBAL_BLOCK, and build the blockvector. */ - finish_block (0, &file_symbols, 0, last_source_start_addr, end_addr, objfile); - finish_block (0, &global_symbols, 0, last_source_start_addr, end_addr, objfile); - blockvector = make_blockvector (objfile); - } - -#ifdef PROCESS_LINENUMBER_HOOK - PROCESS_LINENUMBER_HOOK (); /* Needed for aixcoff. */ -#endif - - /* Now create the symtab objects proper, one for each subfile. */ - /* (The main file is the last one on the chain.) */ - - for (subfile = subfiles; subfile; subfile = nextsub) - { - int linetablesize; - /* If we have blocks of symbols, make a symtab. - Otherwise, just ignore this file and any line number info in it. */ - symtab = 0; - if (blockvector) { - if (subfile->line_vector) { - /* First, shrink the linetable to make more memory. */ - linetablesize = sizeof (struct linetable) + - subfile->line_vector->nitems * sizeof (struct linetable_entry); - subfile->line_vector = (struct linetable *) - xrealloc ((char *) subfile->line_vector, linetablesize); - - if (sort_linevec) - qsort (subfile->line_vector->item, subfile->line_vector->nitems, - sizeof (struct linetable_entry), compare_line_numbers); - } - - /* Now, allocate a symbol table. */ - symtab = allocate_symtab (subfile->name, objfile); - - /* Fill in its components. */ - symtab->blockvector = blockvector; - if (subfile->line_vector) - { - /* Reallocate the line table on the symbol obstack */ - symtab->linetable = (struct linetable *) - obstack_alloc (&objfile -> symbol_obstack, linetablesize); - memcpy (symtab->linetable, subfile->line_vector, linetablesize); - } - else - { - symtab->linetable = NULL; - } - symtab->dirname = subfile->dirname; - symtab->free_code = free_linetable; - symtab->free_ptr = 0; - -#ifdef IBM6000_TARGET - /* In case we need to duplicate symbol tables (to represent include - files), and in case our system needs relocation, we want to - relocate the main symbol table node only (for the main file, - not for the include files). */ - - symtab->nonreloc = TRUE; -#endif - } - if (subfile->line_vector) - free ((PTR)subfile->line_vector); - - nextsub = subfile->next; - free ((PTR)subfile); - } - -#ifdef IBM6000_TARGET - /* all include symbol tables are non-relocatable, except the main source - file's. */ - if (symtab) - symtab->nonreloc = FALSE; -#endif - - if (type_vector) - free ((char *) type_vector); - type_vector = 0; - type_vector_length = 0; - - last_source_file = 0; - current_subfile = 0; - previous_stab_code = 0; - - return symtab; -} - - -/* Push a context block. Args are an identifying nesting level (checkable - when you pop it), and the starting PC address of this context. */ - -struct context_stack * -push_context (desc, valu) - int desc; - CORE_ADDR valu; -{ - register struct context_stack *new; - - if (context_stack_depth == context_stack_size) - { - context_stack_size *= 2; - context_stack = (struct context_stack *) - xrealloc ((char *) context_stack, - (context_stack_size * sizeof (struct context_stack))); - } - - new = &context_stack[context_stack_depth++]; - new->depth = desc; - new->locals = local_symbols; - new->old_blocks = pending_blocks; - new->start_addr = valu; - new->name = 0; - - local_symbols = 0; - - return new; -} - -/* Initialize anything that needs initializing when starting to read - a fresh piece of a symbol file, e.g. reading in the stuff corresponding - to a psymtab. */ - -void -buildsym_init () -{ - free_pendings = 0; - file_symbols = 0; - global_symbols = 0; - pending_blocks = 0; -} - -/* Initialize anything that needs initializing when a completely new - symbol file is specified (not just adding some symbols from another - file, e.g. a shared library). */ - -void -buildsym_new_init () -{ - /* Empty the hash table of global syms looking for values. */ - (void) memset (global_sym_chain, 0, sizeof global_sym_chain); - - buildsym_init (); -} - -/* Scan through all of the global symbols defined in the object file, - assigning values to the debugging symbols that need to be assigned - to. Get these symbols from the minimal symbol table. */ - -void -scan_file_globals (objfile) - struct objfile *objfile; -{ - int hash; - struct minimal_symbol *msymbol; - struct symbol *sym, *prev; - - if (objfile->msymbols == 0) /* Beware the null file. */ - return; - - for (msymbol = objfile -> msymbols; msymbol -> name != NULL; msymbol++) - { - QUIT; - - prev = (struct symbol *) 0; - - /* Get the hash index and check all the symbols - under that hash index. */ - - hash = hashname (msymbol -> name); - - for (sym = global_sym_chain[hash]; sym;) - { - if (*(msymbol -> name) == SYMBOL_NAME (sym)[0] - && !strcmp(msymbol -> name + 1, SYMBOL_NAME (sym) + 1)) - { - /* Splice this symbol out of the hash chain and - assign the value we have to it. */ - if (prev) - SYMBOL_VALUE_CHAIN (prev) = SYMBOL_VALUE_CHAIN (sym); - else - global_sym_chain[hash] = SYMBOL_VALUE_CHAIN (sym); - - /* Check to see whether we need to fix up a common block. */ - /* Note: this code might be executed several times for - the same symbol if there are multiple references. */ - if (SYMBOL_CLASS (sym) == LOC_BLOCK) - fix_common_block (sym, msymbol -> address); - else - SYMBOL_VALUE_ADDRESS (sym) = msymbol -> address; - - if (prev) - sym = SYMBOL_VALUE_CHAIN (prev); - else - sym = global_sym_chain[hash]; - } - else - { - prev = sym; - sym = SYMBOL_VALUE_CHAIN (sym); - } - } - } -} - - -/* Read a number by which a type is referred to in dbx data, - or perhaps read a pair (FILENUM, TYPENUM) in parentheses. - Just a single number N is equivalent to (0,N). - Return the two numbers by storing them in the vector TYPENUMS. - TYPENUMS will then be used as an argument to dbx_lookup_type. */ - -void -read_type_number (pp, typenums) - register char **pp; - register int *typenums; -{ - if (**pp == '(') - { - (*pp)++; - typenums[0] = read_number (pp, ','); - typenums[1] = read_number (pp, ')'); - } - else - { - typenums[0] = 0; - typenums[1] = read_number (pp, 0); - } -} - -/* To handle GNU C++ typename abbreviation, we need to be able to - fill in a type's name as soon as space for that type is allocated. - `type_synonym_name' is the name of the type being allocated. - It is cleared as soon as it is used (lest all allocated types - get this name). */ -static char *type_synonym_name; - -/* ARGSUSED */ -struct symbol * -define_symbol (valu, string, desc, type, objfile) - unsigned int valu; - char *string; - int desc; - int type; - struct objfile *objfile; -{ - register struct symbol *sym; - char *p = (char *) strchr (string, ':'); - int deftype; - int synonym = 0; - register int i; - struct type *temptype; - - /* We would like to eliminate nameless symbols, but keep their types. - E.g. stab entry ":t10=*2" should produce a type 10, which is a pointer - to type 2, but, should not creat a symbol to address that type. Since - the symbol will be nameless, there is no way any user can refer to it. */ - - int nameless; - - /* Ignore syms with empty names. */ - if (string[0] == 0) - return 0; - - /* Ignore old-style symbols from cc -go */ - if (p == 0) - return 0; - - /* If a nameless stab entry, all we need is the type, not the symbol. - e.g. ":t10=*2" */ - nameless = (p == string); - - sym = (struct symbol *)obstack_alloc (&objfile -> symbol_obstack, sizeof (struct symbol)); - - if (processing_gcc_compilation) { - /* GCC 2.x puts the line number in desc. SunOS apparently puts in the - number of bytes occupied by a type or object, which we ignore. */ - SYMBOL_LINE(sym) = desc; - } else { - SYMBOL_LINE(sym) = 0; /* unknown */ - } - - if (string[0] == CPLUS_MARKER) - { - /* Special GNU C++ names. */ - switch (string[1]) - { - case 't': - SYMBOL_NAME (sym) = obsavestring ("this", strlen ("this"), - &objfile -> symbol_obstack); - break; - case 'v': /* $vtbl_ptr_type */ - /* Was: SYMBOL_NAME (sym) = "vptr"; */ - goto normal; - case 'e': - SYMBOL_NAME (sym) = obsavestring ("eh_throw", strlen ("eh_throw"), - &objfile -> symbol_obstack); - break; - - case '_': - /* This was an anonymous type that was never fixed up. */ - goto normal; - - default: - abort (); - } - } - else - { - normal: - SYMBOL_NAME (sym) - = (char *) obstack_alloc (&objfile -> symbol_obstack, ((p - string) + 1)); - /* Open-coded bcopy--saves function call time. */ - { - register char *p1 = string; - register char *p2 = SYMBOL_NAME (sym); - while (p1 != p) - *p2++ = *p1++; - *p2++ = '\0'; - } - } - p++; - /* Determine the type of name being defined. */ - /* The Acorn RISC machine's compiler can put out locals that don't - start with "234=" or "(3,4)=", so assume anything other than the - deftypes we know how to handle is a local. */ - /* (Peter Watkins @ Computervision) - Handle Sun-style local fortran array types 'ar...' . - (gnu@cygnus.com) -- this strchr() handles them properly? - (tiemann@cygnus.com) -- 'C' is for catch. */ - -#ifdef IBM6000_TARGET - - /* 'R' is for register parameters. */ - - if (!strchr ("cfFGpPrStTvVXCR", *p)) -#else - - if (!strchr ("cfFGpPrStTvVXC", *p)) -#endif - deftype = 'l'; - else - deftype = *p++; - - /* c is a special case, not followed by a type-number. - SYMBOL:c=iVALUE for an integer constant symbol. - SYMBOL:c=rVALUE for a floating constant symbol. - SYMBOL:c=eTYPE,INTVALUE for an enum constant symbol. - e.g. "b:c=e6,0" for "const b = blob1" - (where type 6 is defined by "blobs:t6=eblob1:0,blob2:1,;"). */ - if (deftype == 'c') - { - if (*p++ != '=') - error ("Invalid symbol data at symtab pos %d.", symnum); - switch (*p++) - { - case 'r': - { - double d = atof (p); - char *dbl_valu; - - SYMBOL_TYPE (sym) = lookup_fundamental_type (objfile, - FT_DBL_PREC_FLOAT); - dbl_valu = (char *) - obstack_alloc (&objfile -> type_obstack, - sizeof (double)); - memcpy (dbl_valu, &d, sizeof (double)); - SWAP_TARGET_AND_HOST (dbl_valu, sizeof (double)); - SYMBOL_VALUE_BYTES (sym) = dbl_valu; - SYMBOL_CLASS (sym) = LOC_CONST_BYTES; - } - break; - case 'i': - { - SYMBOL_TYPE (sym) = lookup_fundamental_type (objfile, - FT_INTEGER); - SYMBOL_VALUE (sym) = atoi (p); - SYMBOL_CLASS (sym) = LOC_CONST; - } - break; - case 'e': - /* SYMBOL:c=eTYPE,INTVALUE for an enum constant symbol. - e.g. "b:c=e6,0" for "const b = blob1" - (where type 6 is defined by "blobs:t6=eblob1:0,blob2:1,;"). */ - { - int typenums[2]; - - read_type_number (&p, typenums); - if (*p++ != ',') - error ("Invalid symbol data: no comma in enum const symbol"); - - SYMBOL_TYPE (sym) = *dbx_lookup_type (typenums); - SYMBOL_VALUE (sym) = atoi (p); - SYMBOL_CLASS (sym) = LOC_CONST; - } - break; - default: - error ("Invalid symbol data at symtab pos %d.", symnum); - } - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &file_symbols); - return sym; - } - - /* Now usually comes a number that says which data type, - and possibly more stuff to define the type - (all of which is handled by read_type) */ - - if (deftype == 'p' && *p == 'F') - /* pF is a two-letter code that means a function parameter in Fortran. - The type-number specifies the type of the return value. - Translate it into a pointer-to-function type. */ - { - p++; - SYMBOL_TYPE (sym) - = lookup_pointer_type (lookup_function_type (read_type (&p, objfile))); - } - -#ifdef IBM6000_TARGET - else if (deftype == 'R') - SYMBOL_TYPE (sym) = read_type (&p, objfile); -#endif - - else - { - struct type *type_read; - synonym = *p == 't'; - - if (synonym) + if (!m_context_stack.empty ()) { - p += 1; - type_synonym_name = obsavestring (SYMBOL_NAME (sym), - strlen (SYMBOL_NAME (sym)), - &objfile -> symbol_obstack); + /* This is said to happen with SCO. The old coffread.c + code simply emptied the context stack, so we do the + same. FIXME: Find out why it is happening. This is not + believed to happen in most cases (even for coffread.c); + it used to be an abort(). */ + complaint (_("Context stack not empty in end_symtab")); + m_context_stack.clear (); } - - /* Here we save the name of the symbol for read_range_type, which - ends up reading in the basic types. In stabs, unfortunately there - is no distinction between "int" and "long" types except their - names. Until we work out a saner type policy (eliminating most - builtin types and using the names specified in the files), we - save away the name so that far away from here in read_range_type, - we can examine it to decide between "int" and "long". FIXME. */ - long_kludge_name = SYMBOL_NAME (sym); - - type_read = read_type (&p, objfile); - - if ((deftype == 'F' || deftype == 'f') && *p == ';') { - /* Sun acc puts declared types of aguments here. We don't care - about their actual types (FIXME -- we should remember the whole - function prototype), but the list - may define some new types that we have to remember, so we must - scan them now. */ - while (*p == ';') { - p++; - read_type (&p, objfile); - } - } - - if ((deftype == 'F' || deftype == 'f') - && TYPE_CODE (type_read) != TYPE_CODE_FUNC) - { -#if 0 -/* This code doesn't work -- it needs to realloc and can't. */ -/* Attempt to set up to record a function prototype... */ - struct type *new = (struct type *) - obstack_alloc (&objfile -> type_obstack, - sizeof (struct type)); - - /* Generate a template for the type of this function. The - types of the arguments will be added as we read the symbol - table. */ - *new = *lookup_function_type (type_read); - SYMBOL_TYPE(sym) = new; - TYPE_OBJFILE (new) = objfile; - in_function_type = new; -#else - SYMBOL_TYPE (sym) = lookup_function_type (type_read); -#endif - } - else - SYMBOL_TYPE (sym) = type_read; } - switch (deftype) - { - case 'C': - /* The name of a caught exception. */ - SYMBOL_CLASS (sym) = LOC_LABEL; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - SYMBOL_VALUE_ADDRESS (sym) = valu; - add_symbol_to_list (sym, &local_symbols); - break; - - case 'f': - SYMBOL_CLASS (sym) = LOC_BLOCK; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &file_symbols); - break; - - case 'F': - SYMBOL_CLASS (sym) = LOC_BLOCK; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &global_symbols); - break; - - case 'G': - /* For a class G (global) symbol, it appears that the - value is not correct. It is necessary to search for the - corresponding linker definition to find the value. - These definitions appear at the end of the namelist. */ - i = hashname (SYMBOL_NAME (sym)); - SYMBOL_VALUE_CHAIN (sym) = global_sym_chain[i]; - global_sym_chain[i] = sym; - SYMBOL_CLASS (sym) = LOC_STATIC; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &global_symbols); - break; - - /* This case is faked by a conditional above, - when there is no code letter in the dbx data. - Dbx data never actually contains 'l'. */ - case 'l': - SYMBOL_CLASS (sym) = LOC_LOCAL; - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &local_symbols); - break; - - case 'p': - /* Normally this is a parameter, a LOC_ARG. On the i960, it - can also be a LOC_LOCAL_ARG depending on symbol type. */ -#ifndef DBX_PARM_SYMBOL_CLASS -#define DBX_PARM_SYMBOL_CLASS(type) LOC_ARG -#endif - SYMBOL_CLASS (sym) = DBX_PARM_SYMBOL_CLASS (type); - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; -#if 0 - /* This doesn't work yet. */ - add_param_to_type (&in_function_type, sym); -#endif - add_symbol_to_list (sym, &local_symbols); - - /* If it's gcc-compiled, if it says `short', believe it. */ - if (processing_gcc_compilation || BELIEVE_PCC_PROMOTION) - break; - -#if defined(BELIEVE_PCC_PROMOTION_TYPE) - /* This macro is defined on machines (e.g. sparc) where - we should believe the type of a PCC 'short' argument, - but shouldn't believe the address (the address is - the address of the corresponding int). Note that - this is only different from the BELIEVE_PCC_PROMOTION - case on big-endian machines. - - My guess is that this correction, as opposed to changing - the parameter to an 'int' (as done below, for PCC - on most machines), is the right thing to do - on all machines, but I don't want to risk breaking - something that already works. On most PCC machines, - the sparc problem doesn't come up because the calling - function has to zero the top bytes (not knowing whether - the called function wants an int or a short), so there - is no practical difference between an int and a short - (except perhaps what happens when the GDB user types - "print short_arg = 0x10000;"). - - Hacked for SunOS 4.1 by gnu@cygnus.com. In 4.1, the compiler - actually produces the correct address (we don't need to fix it - up). I made this code adapt so that it will offset the symbol - if it was pointing at an int-aligned location and not - otherwise. This way you can use the same gdb for 4.0.x and - 4.1 systems. - - If the parameter is shorter than an int, and is integral - (e.g. char, short, or unsigned equivalent), and is claimed to - be passed on an integer boundary, don't believe it! Offset the - parameter's address to the tail-end of that integer. */ - - temptype = lookup_fundamental_type (objfile, FT_INTEGER); - if (TYPE_LENGTH (SYMBOL_TYPE (sym)) < TYPE_LENGTH (temptype) - && TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_INT - && 0 == SYMBOL_VALUE (sym) % TYPE_LENGTH (temptype)) - { - SYMBOL_VALUE (sym) += TYPE_LENGTH (temptype) - - TYPE_LENGTH (SYMBOL_TYPE (sym)); - } - break; - -#else /* no BELIEVE_PCC_PROMOTION_TYPE. */ + /* Reordered executables may have out of order pending blocks; if + OBJF_REORDERED is true, then sort the pending blocks. */ - /* If PCC says a parameter is a short or a char, - it is really an int. */ - temptype = lookup_fundamental_type (objfile, FT_INTEGER); - if (TYPE_LENGTH (SYMBOL_TYPE (sym)) < TYPE_LENGTH (temptype) - && TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_INT) - { - SYMBOL_TYPE (sym) = TYPE_UNSIGNED (SYMBOL_TYPE (sym)) - ? lookup_fundamental_type (objfile, FT_UNSIGNED_INTEGER) - : temptype; - } - break; - -#endif /* no BELIEVE_PCC_PROMOTION_TYPE. */ - - case 'P': - /* Parameter which is in a register. */ - - /* acc seems to use P to delare the types of functions that - are called by this file. gdb is not prepared to deal - with this extra information. */ - if (processing_acc_compilation) - break; - - SYMBOL_CLASS (sym) = LOC_REGPARM; - SYMBOL_VALUE (sym) = STAB_REG_TO_REGNUM (valu); - if (SYMBOL_VALUE (sym) >= NUM_REGS) - { - complain (®_value_complaint, SYMBOL_NAME (sym)); - SYMBOL_VALUE (sym) = SP_REGNUM; /* Known safe, though useless */ - } - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &local_symbols); - break; - -#ifdef IBM6000_TARGET - case 'R': -#endif - case 'r': - /* Register variable (either global or local). */ - SYMBOL_CLASS (sym) = LOC_REGISTER; - SYMBOL_VALUE (sym) = STAB_REG_TO_REGNUM (valu); - if (SYMBOL_VALUE (sym) >= NUM_REGS) - { - complain (®_value_complaint, SYMBOL_NAME (sym)); - SYMBOL_VALUE (sym) = SP_REGNUM; /* Known safe, though useless */ - } - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - if (within_function) - add_symbol_to_list (sym, &local_symbols); - else - add_symbol_to_list (sym, &file_symbols); - break; - - case 'S': - /* Static symbol at top level of file */ - SYMBOL_CLASS (sym) = LOC_STATIC; - SYMBOL_VALUE_ADDRESS (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &file_symbols); - break; - - case 't': - /* For a nameless type, we don't want a create a symbol, thus we - did not use `sym'. Return without further processing. */ - if (nameless) return NULL; - - SYMBOL_CLASS (sym) = LOC_TYPEDEF; - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - /* C++ vagaries: we may have a type which is derived from - a base type which did not have its name defined when the - derived class was output. We fill in the derived class's - base part member's name here in that case. */ - if (TYPE_NAME (SYMBOL_TYPE (sym)) != NULL) - if ((TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_STRUCT - || TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_UNION) - && TYPE_N_BASECLASSES (SYMBOL_TYPE (sym))) - { - int j; - for (j = TYPE_N_BASECLASSES (SYMBOL_TYPE (sym)) - 1; j >= 0; j--) - if (TYPE_BASECLASS_NAME (SYMBOL_TYPE (sym), j) == 0) - TYPE_BASECLASS_NAME (SYMBOL_TYPE (sym), j) = - type_name_no_tag (TYPE_BASECLASS (SYMBOL_TYPE (sym), j)); - } - - add_symbol_to_list (sym, &file_symbols); - break; - - case 'T': - /* For a nameless type, we don't want a create a symbol, thus we - did not use `sym'. Return without further processing. */ - if (nameless) return NULL; - - SYMBOL_CLASS (sym) = LOC_TYPEDEF; - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = STRUCT_NAMESPACE; - if (TYPE_NAME (SYMBOL_TYPE (sym)) == 0) - TYPE_NAME (SYMBOL_TYPE (sym)) - = obconcat (&objfile -> type_obstack, "", - (TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_ENUM - ? "enum " - : (TYPE_CODE (SYMBOL_TYPE (sym)) == TYPE_CODE_STRUCT - ? "struct " : "union ")), - SYMBOL_NAME (sym)); - add_symbol_to_list (sym, &file_symbols); - - if (synonym) - { - register struct symbol *typedef_sym = (struct symbol *) - obstack_alloc (&objfile -> type_obstack, - sizeof (struct symbol)); - SYMBOL_NAME (typedef_sym) = SYMBOL_NAME (sym); - SYMBOL_TYPE (typedef_sym) = SYMBOL_TYPE (sym); - - SYMBOL_CLASS (typedef_sym) = LOC_TYPEDEF; - SYMBOL_VALUE (typedef_sym) = valu; - SYMBOL_NAMESPACE (typedef_sym) = VAR_NAMESPACE; - add_symbol_to_list (typedef_sym, &file_symbols); - } - break; - - case 'V': - /* Static symbol of local scope */ - SYMBOL_CLASS (sym) = LOC_STATIC; - SYMBOL_VALUE_ADDRESS (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &local_symbols); - break; - - case 'v': - /* Reference parameter */ - SYMBOL_CLASS (sym) = LOC_REF_ARG; - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &local_symbols); - break; - - case 'X': - /* This is used by Sun FORTRAN for "function result value". - Sun claims ("dbx and dbxtool interfaces", 2nd ed) - that Pascal uses it too, but when I tried it Pascal used - "x:3" (local symbol) instead. */ - SYMBOL_CLASS (sym) = LOC_LOCAL; - SYMBOL_VALUE (sym) = valu; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - add_symbol_to_list (sym, &local_symbols); - break; - - default: - error ("Invalid symbol data: unknown symbol-type code `%c' at symtab pos %d.", deftype, symnum); - } - return sym; -} - -/* What about types defined as forward references inside of a small lexical - scope? */ -/* Add a type to the list of undefined types to be checked through - once this file has been read in. */ -void -add_undefined_type (type) - struct type *type; -{ - if (undef_types_length == undef_types_allocated) + if ((m_objfile->flags & OBJF_REORDERED) && m_pending_blocks) { - undef_types_allocated *= 2; - undef_types = (struct type **) - xrealloc ((char *) undef_types, - undef_types_allocated * sizeof (struct type *)); - } - undef_types[undef_types_length++] = type; -} - -/* Go through each undefined type, see if it's still undefined, and fix it - up if possible. We have two kinds of undefined types: - - TYPE_CODE_ARRAY: Array whose target type wasn't defined yet. - Fix: update array length using the element bounds - and the target type's length. - TYPE_CODE_STRUCT, TYPE_CODE_UNION: Structure whose fields were not - yet defined at the time a pointer to it was made. - Fix: Do a full lookup on the struct/union tag. */ -static void -cleanup_undefined_types () -{ - struct type **type; + struct pending_block *pb; - for (type = undef_types; type < undef_types + undef_types_length; type++) { - switch (TYPE_CODE (*type)) { + std::vector barray; - case TYPE_CODE_STRUCT: - case TYPE_CODE_UNION: - case TYPE_CODE_ENUM: - { - /* Reasonable test to see if it's been defined since. */ - if (TYPE_NFIELDS (*type) == 0) - { - struct pending *ppt; - int i; - /* Name of the type, without "struct" or "union" */ - char *typename = TYPE_NAME (*type); - - if (!strncmp (typename, "struct ", 7)) - typename += 7; - if (!strncmp (typename, "union ", 6)) - typename += 6; - if (!strncmp (typename, "enum ", 5)) - typename += 5; - - for (ppt = file_symbols; ppt; ppt = ppt->next) - for (i = 0; i < ppt->nsyms; i++) - { - struct symbol *sym = ppt->symbol[i]; - - if (SYMBOL_CLASS (sym) == LOC_TYPEDEF - && SYMBOL_NAMESPACE (sym) == STRUCT_NAMESPACE - && (TYPE_CODE (SYMBOL_TYPE (sym)) == - TYPE_CODE (*type)) - && !strcmp (SYMBOL_NAME (sym), typename)) - memcpy (*type, SYMBOL_TYPE (sym), sizeof (struct type)); - } - } - else - /* It has been defined; don't mark it as a stub. */ - TYPE_FLAGS (*type) &= ~TYPE_FLAG_STUB; - } - break; + for (pb = m_pending_blocks; pb != NULL; pb = pb->next) + barray.push_back (pb->block); - case TYPE_CODE_ARRAY: - { - struct type *range_type; - int lower, upper; - - if (TYPE_LENGTH (*type) != 0) /* Better be unknown */ - goto badtype; - if (TYPE_NFIELDS (*type) != 1) - goto badtype; - range_type = TYPE_FIELD_TYPE (*type, 0); - if (TYPE_CODE (range_type) != TYPE_CODE_RANGE) - goto badtype; - - /* Now recompute the length of the array type, based on its - number of elements and the target type's length. */ - lower = TYPE_FIELD_BITPOS (range_type, 0); - upper = TYPE_FIELD_BITPOS (range_type, 1); - TYPE_LENGTH (*type) = (upper - lower + 1) - * TYPE_LENGTH (TYPE_TARGET_TYPE (*type)); - } - break; + /* Sort blocks by start address in descending order. Blocks with the + same start address must remain in the original order to preserve + inline function caller/callee relationships. */ + std::stable_sort (barray.begin (), barray.end (), + [] (const block *a, const block *b) + { + return BLOCK_START (a) > BLOCK_START (b); + }); - default: - badtype: - error ("GDB internal error. cleanup_undefined_types with bad\ - type %d.", TYPE_CODE (*type)); - break; + int i = 0; + for (pb = m_pending_blocks; pb != NULL; pb = pb->next) + pb->block = barray[i++]; } - } - undef_types_length = 0; -} - -/* Skip rest of this symbol and return an error type. - - General notes on error recovery: error_type always skips to the - end of the symbol (modulo cretinous dbx symbol name continuation). - Thus code like this: - - if (*(*pp)++ != ';') - return error_type (pp); - is wrong because if *pp starts out pointing at '\0' (typically as the - result of an earlier error), it will be incremented to point to the - start of the next symbol, which might produce strange results, at least - if you run off the end of the string table. Instead use - - if (**pp != ';') - return error_type (pp); - ++*pp; - - or + /* Cleanup any undefined types that have been left hanging around + (this needs to be done before the finish_blocks so that + file_symbols is still good). - if (**pp != ';') - foo = error_type (pp); - else - ++*pp; + Both cleanup_undefined_stabs_types and finish_global_stabs are stabs + specific, but harmless for other symbol readers, since on gdb + startup or when finished reading stabs, the state is set so these + are no-ops. FIXME: Is this handled right in case of QUIT? Can + we make this cleaner? */ - And in case it isn't obvious, the point of all this hair is so the compiler - can define new types and new syntaxes, and old versions of the - debugger will be able to read the new symbol tables. */ + cleanup_undefined_stabs_types (m_objfile); + finish_global_stabs (m_objfile); -struct type * -error_type (pp) - char **pp; -{ - complain (&error_type_complaint, 0); - while (1) + if (!required + && m_pending_blocks == NULL + && m_file_symbols == NULL + && m_global_symbols == NULL + && !m_have_line_numbers + && m_pending_macros == NULL + && m_global_using_directives == NULL) { - /* Skip to end of symbol. */ - while (**pp != '\0') - (*pp)++; - - /* Check for and handle cretinous dbx symbol name continuation! */ - if ((*pp)[-1] == '\\') - *pp = next_symbol_text (); - else - break; - } - return builtin_type_error; -} - -/* Read a dbx type reference or definition; - return the type that is meant. - This can be just a number, in which case it references - a type already defined and placed in type_vector. - Or the number can be followed by an =, in which case - it means to define a new type according to the text that - follows the =. */ - -struct type * -read_type (pp, objfile) - register char **pp; - struct objfile *objfile; -{ - register struct type *type = 0; - struct type *type1; - int typenums[2]; - int xtypenums[2]; - - /* Read type number if present. The type number may be omitted. - for instance in a two-dimensional array declared with type - "ar1;1;10;ar1;1;10;4". */ - if ((**pp >= '0' && **pp <= '9') - || **pp == '(') - { - read_type_number (pp, typenums); - - /* Type is not being defined here. Either it already exists, - or this is a forward reference to it. dbx_alloc_type handles - both cases. */ - if (**pp != '=') - return dbx_alloc_type (typenums, objfile); - - /* Type is being defined here. */ -#if 0 /* Callers aren't prepared for a NULL result! FIXME -- metin! */ - { - struct type *tt; - - /* if such a type already exists, this is an unnecessary duplication - of the stab string, which is common in (RS/6000) xlc generated - objects. In that case, simply return NULL and let the caller take - care of it. */ - - tt = *dbx_lookup_type (typenums); - if (tt && tt->length && tt->code) - return NULL; - } -#endif - - *pp += 2; + /* Ignore symtabs that have no functions with real debugging info. */ + return NULL; } else { - /* 'typenums=' not present, type is anonymous. Read and return - the definition, but don't put it in the type vector. */ - typenums[0] = typenums[1] = -1; - *pp += 1; + /* Define the STATIC_BLOCK. */ + return finish_block_internal (NULL, get_file_symbols (), NULL, NULL, + m_last_source_start_addr, + end_addr, 0, expandable); } - - switch ((*pp)[-1]) - { - case 'x': - { - enum type_code code; - - /* Used to index through file_symbols. */ - struct pending *ppt; - int i; - - /* Name including "struct", etc. */ - char *type_name; - - /* Name without "struct", etc. */ - char *type_name_only; - - { - char *prefix; - char *from, *to; - - /* Set the type code according to the following letter. */ - switch ((*pp)[0]) - { - case 's': - code = TYPE_CODE_STRUCT; - prefix = "struct "; - break; - case 'u': - code = TYPE_CODE_UNION; - prefix = "union "; - break; - case 'e': - code = TYPE_CODE_ENUM; - prefix = "enum "; - break; - default: - return error_type (pp); - } - - to = type_name = (char *) - obstack_alloc (&objfile -> type_obstack, - (strlen (prefix) + - ((char *) strchr (*pp, ':') - (*pp)) + 1)); - - /* Copy the prefix. */ - from = prefix; - while (*to++ = *from++) - ; - to--; - - type_name_only = to; - - /* Copy the name. */ - from = *pp + 1; - while ((*to++ = *from++) != ':') - ; - *--to = '\0'; - - /* Set the pointer ahead of the name which we just read. */ - *pp = from; - -#if 0 - /* The following hack is clearly wrong, because it doesn't - check whether we are in a baseclass. I tried to reproduce - the case that it is trying to fix, but I couldn't get - g++ to put out a cross reference to a basetype. Perhaps - it doesn't do it anymore. */ - /* Note: for C++, the cross reference may be to a base type which - has not yet been seen. In this case, we skip to the comma, - which will mark the end of the base class name. (The ':' - at the end of the base class name will be skipped as well.) - But sometimes (ie. when the cross ref is the last thing on - the line) there will be no ','. */ - from = (char *) strchr (*pp, ','); - if (from) - *pp = from; -#endif /* 0 */ - } - - /* Now check to see whether the type has already been declared. */ - /* This is necessary at least in the case where the - program says something like - struct foo bar[5]; - The compiler puts out a cross-reference; we better find - set the length of the structure correctly so we can - set the length of the array. */ - for (ppt = file_symbols; ppt; ppt = ppt->next) - for (i = 0; i < ppt->nsyms; i++) - { - struct symbol *sym = ppt->symbol[i]; - - if (SYMBOL_CLASS (sym) == LOC_TYPEDEF - && SYMBOL_NAMESPACE (sym) == STRUCT_NAMESPACE - && (TYPE_CODE (SYMBOL_TYPE (sym)) == code) - && !strcmp (SYMBOL_NAME (sym), type_name_only)) - { - obstack_free (&objfile -> type_obstack, type_name); - type = SYMBOL_TYPE (sym); - return type; - } - } - - /* Didn't find the type to which this refers, so we must - be dealing with a forward reference. Allocate a type - structure for it, and keep track of it so we can - fill in the rest of the fields when we get the full - type. */ - type = dbx_alloc_type (typenums, objfile); - TYPE_CODE (type) = code; - TYPE_NAME (type) = type_name; - INIT_CPLUS_SPECIFIC(type); - TYPE_FLAGS (type) |= TYPE_FLAG_STUB; - - add_undefined_type (type); - return type; - } - - case '-': /* RS/6000 built-in type */ - (*pp)--; - type = builtin_type (pp); /* (in xcoffread.c) */ - goto after_digits; - - case '0': - case '1': - case '2': - case '3': - case '4': - case '5': - case '6': - case '7': - case '8': - case '9': - case '(': - (*pp)--; - read_type_number (pp, xtypenums); - type = *dbx_lookup_type (xtypenums); - /* fall through */ - - after_digits: - if (type == 0) - type = lookup_fundamental_type (objfile, FT_VOID); - if (typenums[0] != -1) - *dbx_lookup_type (typenums) = type; - break; - - /* In the following types, we must be sure to overwrite any existing - type that the typenums refer to, rather than allocating a new one - and making the typenums point to the new one. This is because there - may already be pointers to the existing type (if it had been - forward-referenced), and we must change it to a pointer, function, - reference, or whatever, *in-place*. */ - - case '*': - type1 = read_type (pp, objfile); - type = make_pointer_type (type1, dbx_lookup_type (typenums)); - break; - - case '&': /* Reference to another type */ - type1 = read_type (pp, objfile); - type = make_reference_type (type1, dbx_lookup_type (typenums)); - break; - - case 'f': /* Function returning another type */ - type1 = read_type (pp, objfile); - type = make_function_type (type1, dbx_lookup_type (typenums)); - break; - -/* FIXME -- we should be doing smash_to_XXX types here. */ - case '@': /* Member (class & variable) type */ - { - struct type *domain = read_type (pp, objfile); - struct type *memtype; - - if (**pp != ',') - /* Invalid member type data format. */ - return error_type (pp); - ++*pp; - - memtype = read_type (pp, objfile); - type = dbx_alloc_type (typenums, objfile); - smash_to_member_type (type, domain, memtype); - } - break; - - case '#': /* Method (class & fn) type */ - if ((*pp)[0] == '#') - { - /* We'll get the parameter types from the name. */ - struct type *return_type; - - *pp += 1; - return_type = read_type (pp, objfile); - if (*(*pp)++ != ';') - complain (&invalid_member_complaint, (char *) symnum); - type = allocate_stub_method (return_type); - if (typenums[0] != -1) - *dbx_lookup_type (typenums) = type; - } - else - { - struct type *domain = read_type (pp, objfile); - struct type *return_type; - struct type **args; - - if (*(*pp)++ != ',') - error ("invalid member type data format, at symtab pos %d.", - symnum); - - return_type = read_type (pp, objfile); - args = read_args (pp, ';', objfile); - type = dbx_alloc_type (typenums, objfile); - smash_to_method_type (type, domain, return_type, args); - } - break; - - case 'r': /* Range type */ - type = read_range_type (pp, typenums, objfile); - if (typenums[0] != -1) - *dbx_lookup_type (typenums) = type; - break; - - case 'b': /* Sun ACC builtin int type */ - type = read_sun_builtin_type (pp, typenums, objfile); - if (typenums[0] != -1) - *dbx_lookup_type (typenums) = type; - break; - - case 'R': /* Sun ACC builtin float type */ - type = read_sun_floating_type (pp, typenums, objfile); - if (typenums[0] != -1) - *dbx_lookup_type (typenums) = type; - break; - - case 'e': /* Enumeration type */ - type = dbx_alloc_type (typenums, objfile); - type = read_enum_type (pp, type, objfile); - *dbx_lookup_type (typenums) = type; - break; - - case 's': /* Struct type */ - type = dbx_alloc_type (typenums, objfile); - if (!TYPE_NAME (type)) - TYPE_NAME (type) = type_synonym_name; - type_synonym_name = 0; - type = read_struct_type (pp, type, objfile); - break; - - case 'u': /* Union type */ - type = dbx_alloc_type (typenums, objfile); - if (!TYPE_NAME (type)) - TYPE_NAME (type) = type_synonym_name; - type_synonym_name = 0; - type = read_struct_type (pp, type, objfile); - TYPE_CODE (type) = TYPE_CODE_UNION; - break; - - case 'a': /* Array type */ - if (**pp != 'r') - return error_type (pp); - ++*pp; - - type = dbx_alloc_type (typenums, objfile); - type = read_array_type (pp, type, objfile); - break; - - default: - --*pp; /* Go back to the symbol in error */ - /* Particularly important if it was \0! */ - return error_type (pp); - } - - if (type == 0) - abort (); - - return type; } - -/* This page contains subroutines of read_type. */ -/* Read the description of a structure (or union type) - and return an object describing the type. */ +/* Subroutine of end_symtab_from_static_block to simplify it. + Handle the "have blockvector" case. + See end_symtab_from_static_block for a description of the arguments. */ -static struct type * -read_struct_type (pp, type, objfile) - char **pp; - register struct type *type; - struct objfile *objfile; +struct compunit_symtab * +buildsym_compunit::end_symtab_with_blockvector (struct block *static_block, + int section, int expandable) { - /* Total number of methods defined in this class. - If the class defines two `f' methods, and one `g' method, - then this will have the value 3. */ - int total_length = 0; - - struct nextfield - { - struct nextfield *next; - int visibility; /* 0=public, 1=protected, 2=public */ - struct field field; - }; - - struct next_fnfield - { - struct next_fnfield *next; - struct fn_field fn_field; - }; - - struct next_fnfieldlist - { - struct next_fnfieldlist *next; - struct fn_fieldlist fn_fieldlist; - }; - - register struct nextfield *list = 0; - struct nextfield *new; - register char *p; - int nfields = 0; - int non_public_fields = 0; - register int n; - - register struct next_fnfieldlist *mainlist = 0; - int nfn_fields = 0; - - TYPE_CODE (type) = TYPE_CODE_STRUCT; - INIT_CPLUS_SPECIFIC(type); - - /* First comes the total size in bytes. */ - - TYPE_LENGTH (type) = read_number (pp, 0); - - /* C++: Now, if the class is a derived class, then the next character - will be a '!', followed by the number of base classes derived from. - Each element in the list contains visibility information, - the offset of this base class in the derived structure, - and then the base type. */ - if (**pp == '!') - { - int i, n_baseclasses, offset; - struct type *baseclass; - int via_public; - - /* Nonzero if it is a virtual baseclass, i.e., - - struct A{}; - struct B{}; - struct C : public B, public virtual A {}; - - B is a baseclass of C; A is a virtual baseclass for C. This is a C++ - 2.0 language feature. */ - int via_virtual; + struct compunit_symtab *cu = m_compunit_symtab; + struct blockvector *blockvector; + struct subfile *subfile; + CORE_ADDR end_addr; - *pp += 1; - - ALLOCATE_CPLUS_STRUCT_TYPE(type); - - n_baseclasses = read_number (pp, ','); - TYPE_FIELD_VIRTUAL_BITS (type) = - (B_TYPE *) obstack_alloc (&objfile -> type_obstack, - B_BYTES (n_baseclasses)); - B_CLRALL (TYPE_FIELD_VIRTUAL_BITS (type), n_baseclasses); - - for (i = 0; i < n_baseclasses; i++) - { - if (**pp == '\\') - *pp = next_symbol_text (); + gdb_assert (static_block != NULL); + gdb_assert (m_subfiles != NULL); - switch (**pp) - { - case '0': - via_virtual = 0; - break; - case '1': - via_virtual = 1; - break; - default: - /* Bad visibility format. */ - return error_type (pp); - } - ++*pp; - - switch (**pp) - { - case '0': - via_public = 0; - non_public_fields++; - break; - case '2': - via_public = 2; - break; - default: - /* Bad visibility format. */ - return error_type (pp); - } - if (via_virtual) - SET_TYPE_FIELD_VIRTUAL (type, i); - ++*pp; - - /* Offset of the portion of the object corresponding to - this baseclass. Always zero in the absence of - multiple inheritance. */ - offset = read_number (pp, ','); - baseclass = read_type (pp, objfile); - *pp += 1; /* skip trailing ';' */ - - /* Make this baseclass visible for structure-printing purposes. */ - new = (struct nextfield *) alloca (sizeof (struct nextfield)); - new->next = list; - list = new; - list->visibility = via_public; - list->field.type = baseclass; - list->field.name = type_name_no_tag (baseclass); - list->field.bitpos = offset; - list->field.bitsize = 0; /* this should be an unpacked field! */ - nfields++; - } - TYPE_N_BASECLASSES (type) = n_baseclasses; - } + end_addr = BLOCK_END (static_block); - /* Now come the fields, as NAME:?TYPENUM,BITPOS,BITSIZE; for each one. - At the end, we see a semicolon instead of a field. + /* Create the GLOBAL_BLOCK and build the blockvector. */ + finish_block_internal (NULL, get_global_symbols (), NULL, NULL, + m_last_source_start_addr, end_addr, + 1, expandable); + blockvector = make_blockvector (); - In C++, this may wind up being NAME:?TYPENUM:PHYSNAME; for - a static field. + /* Read the line table if it has to be read separately. + This is only used by xcoffread.c. */ + if (m_objfile->sf->sym_read_linetable != NULL) + m_objfile->sf->sym_read_linetable (m_objfile); - The `?' is a placeholder for one of '/2' (public visibility), - '/1' (protected visibility), '/0' (private visibility), or nothing - (C style symbol table, public visibility). */ + /* Handle the case where the debug info specifies a different path + for the main source file. It can cause us to lose track of its + line number information. */ + watch_main_source_file_lossage (); - /* We better set p right now, in case there are no fields at all... */ - p = *pp; + /* Now create the symtab objects proper, if not already done, + one for each subfile. */ - while (**pp != ';') + for (subfile = m_subfiles; + subfile != NULL; + subfile = subfile->next) { - /* Check for and handle cretinous dbx symbol name continuation! */ - if (**pp == '\\') *pp = next_symbol_text (); + int linetablesize = 0; - /* Get space to record the next field's data. */ - new = (struct nextfield *) alloca (sizeof (struct nextfield)); - new->next = list; - list = new; - - /* Get the field name. */ - p = *pp; - if (*p == CPLUS_MARKER) + if (subfile->line_vector) { - /* Special GNU C++ name. */ - if (*++p == 'v') - { - const char *prefix; - char *name = 0; - struct type *context; - - switch (*++p) - { - case 'f': - prefix = vptr_name; - break; - case 'b': - prefix = vb_name; - break; - default: - complain (&invalid_cpp_abbrev_complaint, *pp); - prefix = "INVALID_C++_ABBREV"; - break; - } - *pp = p + 1; - context = read_type (pp, objfile); - name = type_name_no_tag (context); - if (name == 0) - { - complain (&invalid_cpp_type_complaint, (char *) symnum); - name = "FOO"; - } - list->field.name = obconcat (&objfile -> type_obstack, - prefix, name, ""); - p = ++(*pp); - if (p[-1] != ':') - complain (&invalid_cpp_abbrev_complaint, *pp); - list->field.type = read_type (pp, objfile); - (*pp)++; /* Skip the comma. */ - list->field.bitpos = read_number (pp, ';'); - /* This field is unpacked. */ - list->field.bitsize = 0; - list->visibility = 0; /* private */ - non_public_fields++; - } - /* GNU C++ anonymous type. */ - else if (*p == '_') - break; - else - complain (&invalid_cpp_abbrev_complaint, *pp); + linetablesize = sizeof (struct linetable) + + subfile->line_vector->nitems * sizeof (struct linetable_entry); - nfields++; - continue; + const auto lte_is_less_than + = [] (const linetable_entry &ln1, + const linetable_entry &ln2) -> bool + { + return (ln1.pc < ln2.pc); + }; + + /* Like the pending blocks, the line table may be scrambled in + reordered executables. Sort it if OBJF_REORDERED is true. It + is important to preserve the order of lines at the same + address, as this maintains the inline function caller/callee + relationships, this is why std::stable_sort is used. */ + if (m_objfile->flags & OBJF_REORDERED) + std::stable_sort (subfile->line_vector->item, + subfile->line_vector->item + + subfile->line_vector->nitems, + lte_is_less_than); } - while (*p != ':') p++; - list->field.name = obsavestring (*pp, p - *pp, - &objfile -> type_obstack); - - /* C++: Check to see if we have hit the methods yet. */ - if (p[1] == ':') - break; + /* Allocate a symbol table if necessary. */ + if (subfile->symtab == NULL) + subfile->symtab = allocate_symtab (cu, subfile->name); + struct symtab *symtab = subfile->symtab; - *pp = p + 1; + /* Fill in its components. */ - /* This means we have a visibility for a field coming. */ - if (**pp == '/') - { - switch (*++*pp) - { - case '0': - list->visibility = 0; /* private */ - non_public_fields++; - *pp += 1; - break; - - case '1': - list->visibility = 1; /* protected */ - non_public_fields++; - *pp += 1; - break; - - case '2': - list->visibility = 2; /* public */ - *pp += 1; - break; - } - } - else /* normal dbx-style format. */ - list->visibility = 2; /* public */ - - list->field.type = read_type (pp, objfile); - if (**pp == ':') - { - /* Static class member. */ - list->field.bitpos = (long)-1; - p = ++(*pp); - while (*p != ';') p++; - list->field.bitsize = (long) savestring (*pp, p - *pp); - *pp = p + 1; - nfields++; - continue; - } - else if (**pp != ',') - /* Bad structure-type format. */ - return error_type (pp); - - (*pp)++; /* Skip the comma. */ - list->field.bitpos = read_number (pp, ','); - list->field.bitsize = read_number (pp, ';'); - -#if 0 - /* FIXME-tiemann: Can't the compiler put out something which - lets us distinguish these? (or maybe just not put out anything - for the field). What is the story here? What does the compiler - really do? Also, patch gdb.texinfo for this case; I document - it as a possible problem there. Search for "DBX-style". */ - - /* This is wrong because this is identical to the symbols - produced for GCC 0-size arrays. For example: - typedef union { - int num; - char str[0]; - } foo; - The code which dumped core in such circumstances should be - fixed not to dump core. */ - - /* g++ -g0 can put out bitpos & bitsize zero for a static - field. This does not give us any way of getting its - class, so we can't know its name. But we can just - ignore the field so we don't dump core and other nasty - stuff. */ - if (list->field.bitpos == 0 - && list->field.bitsize == 0) + if (subfile->line_vector) { - complain (&dbx_class_complaint, 0); - /* Ignore this field. */ - list = list->next; + /* Reallocate the line table on the symbol obstack. */ + SYMTAB_LINETABLE (symtab) = (struct linetable *) + obstack_alloc (&m_objfile->objfile_obstack, linetablesize); + memcpy (SYMTAB_LINETABLE (symtab), subfile->line_vector, + linetablesize); } else -#endif /* 0 */ { - /* Detect an unpacked field and mark it as such. - dbx gives a bit size for all fields. - Note that forward refs cannot be packed, - and treat enums as if they had the width of ints. */ - if (TYPE_CODE (list->field.type) != TYPE_CODE_INT - && TYPE_CODE (list->field.type) != TYPE_CODE_ENUM) - list->field.bitsize = 0; - if ((list->field.bitsize == 8 * TYPE_LENGTH (list->field.type) - || (TYPE_CODE (list->field.type) == TYPE_CODE_ENUM - && (list->field.bitsize - == 8 * TYPE_LENGTH (lookup_fundamental_type (objfile, FT_INTEGER))) - ) - ) - && - list->field.bitpos % 8 == 0) - list->field.bitsize = 0; - nfields++; + SYMTAB_LINETABLE (symtab) = NULL; } - } - if (p[1] == ':') - /* chill the list of fields: the last entry (at the head) - is a partially constructed entry which we now scrub. */ - list = list->next; - - /* Now create the vector of fields, and record how big it is. - We need this info to record proper virtual function table information - for this class's virtual functions. */ - - TYPE_NFIELDS (type) = nfields; - TYPE_FIELDS (type) = (struct field *) - obstack_alloc (&objfile -> type_obstack, sizeof (struct field) * nfields); - - if (non_public_fields) - { - ALLOCATE_CPLUS_STRUCT_TYPE (type); - - TYPE_FIELD_PRIVATE_BITS (type) = - (B_TYPE *) obstack_alloc (&objfile -> type_obstack, - B_BYTES (nfields)); - B_CLRALL (TYPE_FIELD_PRIVATE_BITS (type), nfields); - - TYPE_FIELD_PROTECTED_BITS (type) = - (B_TYPE *) obstack_alloc (&objfile -> type_obstack, - B_BYTES (nfields)); - B_CLRALL (TYPE_FIELD_PROTECTED_BITS (type), nfields); + /* Use whatever language we have been using for this + subfile, not the one that was deduced in allocate_symtab + from the filename. We already did our own deducing when + we created the subfile, and we may have altered our + opinion of what language it is from things we found in + the symbols. */ + symtab->language = subfile->language; } - /* Copy the saved-up fields into the field vector. */ + /* Make sure the symtab of main_subfile is the first in its list. */ + { + struct symtab *main_symtab, *prev_symtab; - for (n = nfields; list; list = list->next) - { - n -= 1; - TYPE_FIELD (type, n) = list->field; - if (list->visibility == 0) - SET_TYPE_FIELD_PRIVATE (type, n); - else if (list->visibility == 1) - SET_TYPE_FIELD_PROTECTED (type, n); - } + main_symtab = m_main_subfile->symtab; + prev_symtab = NULL; + for (symtab *symtab : compunit_filetabs (cu)) + { + if (symtab == main_symtab) + { + if (prev_symtab != NULL) + { + prev_symtab->next = main_symtab->next; + main_symtab->next = COMPUNIT_FILETABS (cu); + COMPUNIT_FILETABS (cu) = main_symtab; + } + break; + } + prev_symtab = symtab; + } + gdb_assert (main_symtab == COMPUNIT_FILETABS (cu)); + } - /* Now come the method fields, as NAME::methods - where each method is of the form TYPENUM,ARGS,...:PHYSNAME; - At the end, we see a semicolon instead of a field. + /* Fill out the compunit symtab. */ - For the case of overloaded operators, the format is - op$::*.methods, where $ is the CPLUS_MARKER (usually '$'), - `*' holds the place for an operator name (such as `+=') - and `.' marks the end of the operator name. */ - if (p[1] == ':') + if (m_comp_dir != NULL) { - /* Now, read in the methods. To simplify matters, we - "unread" the name that has been read, so that we can - start from the top. */ - - ALLOCATE_CPLUS_STRUCT_TYPE (type); - /* For each list of method lists... */ - do - { - int i; - struct next_fnfield *sublist = 0; - struct type *look_ahead_type = NULL; - int length = 0; - struct next_fnfieldlist *new_mainlist = - (struct next_fnfieldlist *)alloca (sizeof (struct next_fnfieldlist)); - char *main_fn_name; - - p = *pp; - - /* read in the name. */ - while (*p != ':') p++; - if ((*pp)[0] == 'o' && (*pp)[1] == 'p' && (*pp)[2] == CPLUS_MARKER) - { - /* This is a completely wierd case. In order to stuff in the - names that might contain colons (the usual name delimiter), - Mike Tiemann defined a different name format which is - signalled if the identifier is "op$". In that case, the - format is "op$::XXXX." where XXXX is the name. This is - used for names like "+" or "=". YUUUUUUUK! FIXME! */ - /* This lets the user type "break operator+". - We could just put in "+" as the name, but that wouldn't - work for "*". */ - static char opname[32] = {'o', 'p', CPLUS_MARKER}; - char *o = opname + 3; - - /* Skip past '::'. */ - *pp = p + 2; - if (**pp == '\\') *pp = next_symbol_text (); - p = *pp; - while (*p != '.') - *o++ = *p++; - main_fn_name = savestring (opname, o - opname); - /* Skip past '.' */ - *pp = p + 1; - } - else - { - main_fn_name = savestring (*pp, p - *pp); - /* Skip past '::'. */ - *pp = p + 2; - } - new_mainlist->fn_fieldlist.name = main_fn_name; - - do - { - struct next_fnfield *new_sublist = - (struct next_fnfield *)alloca (sizeof (struct next_fnfield)); - - /* Check for and handle cretinous dbx symbol name continuation! */ - if (look_ahead_type == NULL) /* Normal case. */ - { - if (**pp == '\\') *pp = next_symbol_text (); - - new_sublist->fn_field.type = read_type (pp, objfile); - if (**pp != ':') - /* Invalid symtab info for method. */ - return error_type (pp); - } - else - { /* g++ version 1 kludge */ - new_sublist->fn_field.type = look_ahead_type; - look_ahead_type = NULL; - } - - *pp += 1; - p = *pp; - while (*p != ';') p++; - - /* If this is just a stub, then we don't have the - real name here. */ - if (TYPE_FLAGS (new_sublist->fn_field.type) & TYPE_FLAG_STUB) - new_sublist->fn_field.is_stub = 1; - new_sublist->fn_field.physname = savestring (*pp, p - *pp); - *pp = p + 1; - - /* Set this method's visibility fields. */ - switch (*(*pp)++ - '0') - { - case 0: - new_sublist->fn_field.is_private = 1; - break; - case 1: - new_sublist->fn_field.is_protected = 1; - break; - } - - if (**pp == '\\') *pp = next_symbol_text (); - switch (**pp) - { - case 'A': /* Normal functions. */ - new_sublist->fn_field.is_const = 0; - new_sublist->fn_field.is_volatile = 0; - (*pp)++; - break; - case 'B': /* `const' member functions. */ - new_sublist->fn_field.is_const = 1; - new_sublist->fn_field.is_volatile = 0; - (*pp)++; - break; - case 'C': /* `volatile' member function. */ - new_sublist->fn_field.is_const = 0; - new_sublist->fn_field.is_volatile = 1; - (*pp)++; - break; - case 'D': /* `const volatile' member function. */ - new_sublist->fn_field.is_const = 1; - new_sublist->fn_field.is_volatile = 1; - (*pp)++; - break; - case '*': /* File compiled with g++ version 1 -- no info */ - case '?': - case '.': - break; - default: - complain (&const_vol_complaint, (char *) (long) **pp); - break; - } - - switch (*(*pp)++) - { - case '*': - /* virtual member function, followed by index. */ - /* The sign bit is set to distinguish pointers-to-methods - from virtual function indicies. Since the array is - in words, the quantity must be shifted left by 1 - on 16 bit machine, and by 2 on 32 bit machine, forcing - the sign bit out, and usable as a valid index into - the array. Remove the sign bit here. */ - new_sublist->fn_field.voffset = - (0x7fffffff & read_number (pp, ';')) + 2; - - if (**pp == '\\') *pp = next_symbol_text (); - - if (**pp == ';' || **pp == '\0') - /* Must be g++ version 1. */ - new_sublist->fn_field.fcontext = 0; - else - { - /* Figure out from whence this virtual function came. - It may belong to virtual function table of - one of its baseclasses. */ - look_ahead_type = read_type (pp, objfile); - if (**pp == ':') - { /* g++ version 1 overloaded methods. */ } - else - { - new_sublist->fn_field.fcontext = look_ahead_type; - if (**pp != ';') - return error_type (pp); - else - ++*pp; - look_ahead_type = NULL; - } - } - break; - - case '?': - /* static member function. */ - new_sublist->fn_field.voffset = VOFFSET_STATIC; - if (strncmp (new_sublist->fn_field.physname, - main_fn_name, strlen (main_fn_name))) - new_sublist->fn_field.is_stub = 1; - break; - - default: - /* error */ - complain (&member_fn_complaint, (char *) (long) (*pp)[-1]); - /* Fall through into normal member function. */ - - case '.': - /* normal member function. */ - new_sublist->fn_field.voffset = 0; - new_sublist->fn_field.fcontext = 0; - break; - } - - new_sublist->next = sublist; - sublist = new_sublist; - length++; - if (**pp == '\\') *pp = next_symbol_text (); - } - while (**pp != ';' && **pp != '\0'); - - *pp += 1; - - new_mainlist->fn_fieldlist.fn_fields = - (struct fn_field *) obstack_alloc (&objfile -> type_obstack, - sizeof (struct fn_field) * length); - for (i = length; (i--, sublist); sublist = sublist->next) - new_mainlist->fn_fieldlist.fn_fields[i] = sublist->fn_field; - - new_mainlist->fn_fieldlist.length = length; - new_mainlist->next = mainlist; - mainlist = new_mainlist; - nfn_fields++; - total_length += length; - if (**pp == '\\') *pp = next_symbol_text (); - } - while (**pp != ';'); + /* Reallocate the dirname on the symbol obstack. */ + const char *comp_dir = m_comp_dir.get (); + COMPUNIT_DIRNAME (cu) = obstack_strdup (&m_objfile->objfile_obstack, + comp_dir); } - *pp += 1; - + /* Save the debug format string (if any) in the symtab. */ + COMPUNIT_DEBUGFORMAT (cu) = m_debugformat; - if (nfn_fields) - { - TYPE_FN_FIELDLISTS (type) = (struct fn_fieldlist *) - obstack_alloc (&objfile -> type_obstack, - sizeof (struct fn_fieldlist) * nfn_fields); - TYPE_NFN_FIELDS (type) = nfn_fields; - TYPE_NFN_FIELDS_TOTAL (type) = total_length; - } + /* Similarly for the producer. */ + COMPUNIT_PRODUCER (cu) = m_producer; + COMPUNIT_BLOCKVECTOR (cu) = blockvector; { - int i; - for (i = 0; i < TYPE_N_BASECLASSES (type); ++i) - TYPE_NFN_FIELDS_TOTAL (type) += - TYPE_NFN_FIELDS_TOTAL (TYPE_BASECLASS (type, i)); - } + struct block *b = BLOCKVECTOR_BLOCK (blockvector, GLOBAL_BLOCK); - for (n = nfn_fields; mainlist; mainlist = mainlist->next) { - --n; /* Circumvent Sun3 compiler bug */ - TYPE_FN_FIELDLISTS (type)[n] = mainlist->fn_fieldlist; + set_block_compunit_symtab (b, cu); } - if (**pp == '~') - { - *pp += 1; - - if (**pp == '=' || **pp == '+' || **pp == '-') - { - /* Obsolete flags that used to indicate the presence - of constructors and/or destructors. */ - *pp += 1; - } - - /* Read either a '%' or the final ';'. */ - if (*(*pp)++ == '%') - { - /* We'd like to be able to derive the vtable pointer field - from the type information, but when it's inherited, that's - hard. A reason it's hard is because we may read in the - info about a derived class before we read in info about - the base class that provides the vtable pointer field. - Once the base info has been read, we could fill in the info - for the derived classes, but for the fact that by then, - we don't remember who needs what. */ - -#if 0 - int predicted_fieldno = -1; -#endif - - /* Now we must record the virtual function table pointer's - field information. */ + COMPUNIT_BLOCK_LINE_SECTION (cu) = section; - struct type *t; - int i; + COMPUNIT_MACRO_TABLE (cu) = release_macros (); + /* Default any symbols without a specified symtab to the primary symtab. */ + { + int block_i; -#if 0 - { - /* In version 2, we derive the vfield ourselves. */ - for (n = 0; n < nfields; n++) - { - if (! strncmp (TYPE_FIELD_NAME (type, n), vptr_name, - sizeof (vptr_name) -1)) - { - predicted_fieldno = n; - break; - } - } - if (predicted_fieldno < 0) - for (n = 0; n < TYPE_N_BASECLASSES (type); n++) - if (! TYPE_FIELD_VIRTUAL (type, n) - && TYPE_VPTR_FIELDNO (TYPE_BASECLASS (type, n)) >= 0) - { - predicted_fieldno = TYPE_VPTR_FIELDNO (TYPE_BASECLASS (type, n)); - break; - } - } -#endif - - t = read_type (pp, objfile); - p = (*pp)++; - while (*p != '\0' && *p != ';') - p++; - if (*p == '\0') - /* Premature end of symbol. */ - return error_type (pp); - - TYPE_VPTR_BASETYPE (type) = t; - if (type == t) - { - if (TYPE_FIELD_NAME (t, TYPE_N_BASECLASSES (t)) == 0) - { - /* FIXME-tiemann: what's this? */ -#if 0 - TYPE_VPTR_FIELDNO (type) = i = TYPE_N_BASECLASSES (t); -#else - error_type (pp); -#endif - } - else for (i = TYPE_NFIELDS (t) - 1; i >= TYPE_N_BASECLASSES (t); --i) - if (! strncmp (TYPE_FIELD_NAME (t, i), vptr_name, - sizeof (vptr_name) -1)) - { - TYPE_VPTR_FIELDNO (type) = i; - break; - } - if (i < 0) - /* Virtual function table field not found. */ - return error_type (pp); - } - else - TYPE_VPTR_FIELDNO (type) = TYPE_VPTR_FIELDNO (t); + /* The main source file's symtab. */ + struct symtab *symtab = COMPUNIT_FILETABS (cu); -#if 0 - if (TYPE_VPTR_FIELDNO (type) != predicted_fieldno) - error ("TYPE_VPTR_FIELDNO miscalculated"); -#endif + for (block_i = 0; block_i < BLOCKVECTOR_NBLOCKS (blockvector); block_i++) + { + struct block *block = BLOCKVECTOR_BLOCK (blockvector, block_i); + struct symbol *sym; + struct mdict_iterator miter; + + /* Inlined functions may have symbols not in the global or + static symbol lists. */ + if (BLOCK_FUNCTION (block) != NULL) + if (symbol_symtab (BLOCK_FUNCTION (block)) == NULL) + symbol_set_symtab (BLOCK_FUNCTION (block), symtab); + + /* Note that we only want to fix up symbols from the local + blocks, not blocks coming from included symtabs. That is why + we use ALL_DICT_SYMBOLS here and not ALL_BLOCK_SYMBOLS. */ + ALL_DICT_SYMBOLS (BLOCK_MULTIDICT (block), miter, sym) + if (symbol_symtab (sym) == NULL) + symbol_set_symtab (sym, symtab); + } + } - *pp = p + 1; - } - } + add_compunit_symtab_to_objfile (cu); - return type; + return cu; } -/* Read a definition of an array type, - and create and return a suitable type object. - Also creates a range type which represents the bounds of that - array. */ -static struct type * -read_array_type (pp, type, objfile) - register char **pp; - register struct type *type; - struct objfile *objfile; -{ - struct type *index_type, *element_type, *range_type; - int lower, upper; - int adjustable = 0; +/* Implementation of the second part of end_symtab. Pass STATIC_BLOCK + as value returned by end_symtab_get_static_block. - /* Format of an array type: - "ar;lower;upper;". Put code in - to handle this. + SECTION is the same as for end_symtab: the section number + (in objfile->section_offsets) of the blockvector and linetable. - Fortran adjustable arrays use Adigits or Tdigits for lower or upper; - for these, produce a type like float[][]. */ + If EXPANDABLE is non-zero the GLOBAL_BLOCK dictionary is made + expandable. */ - index_type = read_type (pp, objfile); - if (**pp != ';') - /* Improper format of array type decl. */ - return error_type (pp); - ++*pp; - - if (!(**pp >= '0' && **pp <= '9')) - { - *pp += 1; - adjustable = 1; - } - lower = read_number (pp, ';'); +struct compunit_symtab * +buildsym_compunit::end_symtab_from_static_block (struct block *static_block, + int section, int expandable) +{ + struct compunit_symtab *cu; - if (!(**pp >= '0' && **pp <= '9')) + if (static_block == NULL) { - *pp += 1; - adjustable = 1; - } - upper = read_number (pp, ';'); - - element_type = read_type (pp, objfile); + /* Handle the "no blockvector" case. + When this happens there is nothing to record, so there's nothing + to do: memory will be freed up later. - if (adjustable) - { - lower = 0; - upper = -1; + Note: We won't be adding a compunit to the objfile's list of + compunits, so there's nothing to unchain. However, since each symtab + is added to the objfile's obstack we can't free that space. + We could do better, but this is believed to be a sufficiently rare + event. */ + cu = NULL; } + else + cu = end_symtab_with_blockvector (static_block, section, expandable); - { - /* Create range type. */ - range_type = (struct type *) - obstack_alloc (&objfile -> type_obstack, sizeof (struct type)); - (void) memset (range_type, 0, sizeof (struct type)); - TYPE_OBJFILE (range_type) = objfile; - TYPE_CODE (range_type) = TYPE_CODE_RANGE; - TYPE_TARGET_TYPE (range_type) = index_type; - - /* This should never be needed. */ - TYPE_LENGTH (range_type) = sizeof (int); - - TYPE_NFIELDS (range_type) = 2; - TYPE_FIELDS (range_type) = - (struct field *) obstack_alloc (&objfile -> type_obstack, - 2 * sizeof (struct field)); - TYPE_FIELD_BITPOS (range_type, 0) = lower; - TYPE_FIELD_BITPOS (range_type, 1) = upper; - } - - TYPE_CODE (type) = TYPE_CODE_ARRAY; - TYPE_TARGET_TYPE (type) = element_type; - TYPE_LENGTH (type) = (upper - lower + 1) * TYPE_LENGTH (element_type); - TYPE_NFIELDS (type) = 1; - TYPE_FIELDS (type) = - (struct field *) obstack_alloc (&objfile -> type_obstack, - sizeof (struct field)); - TYPE_FIELD_TYPE (type, 0) = range_type; - - /* If we have an array whose element type is not yet known, but whose - bounds *are* known, record it to be adjusted at the end of the file. */ - if (TYPE_LENGTH (element_type) == 0 && !adjustable) - add_undefined_type (type); - - return type; + return cu; } - -/* Read a definition of an enumeration type, - and create and return a suitable type object. - Also defines the symbols that represent the values of the type. */ - -static struct type * -read_enum_type (pp, type, objfile) - register char **pp; - register struct type *type; - struct objfile *objfile; +/* Finish the symbol definitions for one main source file, close off + all the lexical contexts for that file (creating struct block's for + them), then make the struct symtab for that file and put it in the + list of all such. + + END_ADDR is the address of the end of the file's text. SECTION is + the section number (in objfile->section_offsets) of the blockvector + and linetable. + + Note that it is possible for end_symtab() to return NULL. In + particular, for the DWARF case at least, it will return NULL when + it finds a compilation unit that has exactly one DIE, a + TAG_compile_unit DIE. This can happen when we link in an object + file that was compiled from an empty source file. Returning NULL + is probably not the correct thing to do, because then gdb will + never know about this empty file (FIXME). + + If you need to modify STATIC_BLOCK before it is finalized you should + call end_symtab_get_static_block and end_symtab_from_static_block + yourself. */ + +struct compunit_symtab * +buildsym_compunit::end_symtab (CORE_ADDR end_addr, int section) { - register char *p; - char *name; - register long n; - register struct symbol *sym; - int nsyms = 0; - struct pending **symlist; - struct pending *osyms, *syms; - int o_nsyms; - -#if 0 - /* FIXME! The stabs produced by Sun CC merrily define things that ought - to be file-scope, between N_FN entries, using N_LSYM. What's a mother - to do? For now, force all enum values to file scope. */ - if (within_function) - symlist = &local_symbols; - else -#endif - symlist = &file_symbols; - osyms = *symlist; - o_nsyms = osyms ? osyms->nsyms : 0; - - /* Read the value-names and their values. - The input syntax is NAME:VALUE,NAME:VALUE, and so on. - A semicolon or comma instead of a NAME means the end. */ - while (**pp && **pp != ';' && **pp != ',') - { - /* Check for and handle cretinous dbx symbol name continuation! */ - if (**pp == '\\') *pp = next_symbol_text (); - - p = *pp; - while (*p != ':') p++; - name = obsavestring (*pp, p - *pp, &objfile -> symbol_obstack); - *pp = p + 1; - n = read_number (pp, ','); - - sym = (struct symbol *) obstack_alloc (&objfile -> symbol_obstack, sizeof (struct symbol)); - (void) memset (sym, 0, sizeof (struct symbol)); - SYMBOL_NAME (sym) = name; - SYMBOL_CLASS (sym) = LOC_CONST; - SYMBOL_NAMESPACE (sym) = VAR_NAMESPACE; - SYMBOL_VALUE (sym) = n; - add_symbol_to_list (sym, symlist); - nsyms++; - } - - if (**pp == ';') - (*pp)++; /* Skip the semicolon. */ - - /* Now fill in the fields of the type-structure. */ - - TYPE_LENGTH (type) = sizeof (int); - TYPE_CODE (type) = TYPE_CODE_ENUM; - TYPE_NFIELDS (type) = nsyms; - TYPE_FIELDS (type) = (struct field *) - obstack_alloc (&objfile -> type_obstack, - sizeof (struct field) * nsyms); + struct block *static_block; - /* Find the symbols for the values and put them into the type. - The symbols can be found in the symlist that we put them on - to cause them to be defined. osyms contains the old value - of that symlist; everything up to there was defined by us. */ - /* Note that we preserve the order of the enum constants, so - that in something like "enum {FOO, LAST_THING=FOO}" we print - FOO, not LAST_THING. */ - - for (syms = *symlist, n = 0; syms; syms = syms->next) - { - int j = 0; - if (syms == osyms) - j = o_nsyms; - for (; j < syms->nsyms; j++,n++) - { - struct symbol *xsym = syms->symbol[j]; - SYMBOL_TYPE (xsym) = type; - TYPE_FIELD_NAME (type, n) = SYMBOL_NAME (xsym); - TYPE_FIELD_VALUE (type, n) = 0; - TYPE_FIELD_BITPOS (type, n) = SYMBOL_VALUE (xsym); - TYPE_FIELD_BITSIZE (type, n) = 0; - } - if (syms == osyms) - break; - } - -#if 0 - /* This screws up perfectly good C programs with enums. FIXME. */ - /* Is this Modula-2's BOOLEAN type? Flag it as such if so. */ - if(TYPE_NFIELDS(type) == 2 && - ((!strcmp(TYPE_FIELD_NAME(type,0),"TRUE") && - !strcmp(TYPE_FIELD_NAME(type,1),"FALSE")) || - (!strcmp(TYPE_FIELD_NAME(type,1),"TRUE") && - !strcmp(TYPE_FIELD_NAME(type,0),"FALSE")))) - TYPE_CODE(type) = TYPE_CODE_BOOL; -#endif - - return type; + static_block = end_symtab_get_static_block (end_addr, 0, 0); + return end_symtab_from_static_block (static_block, section, 0); } -/* this is for the initial typedefs in every file (for int, long, etc) */ -static struct type * -read_sun_builtin_type (pp, typenums, objfile) - char **pp; - int typenums[2]; - struct objfile *objfile; -{ - int nbits; - int signed_type; - - switch (**pp) { - case 's': - signed_type = 1; - break; - case 'u': - signed_type = 0; - break; - default: - return error_type (pp); - } - (*pp)++; - - /* For some odd reason, all forms of char put a c here. This is strange - because no other type has this honor. We can safely ignore this because - we actually determine 'char'acterness by the number of bits specified in - the descriptor. */ - - if (**pp == 'c') - (*pp)++; - - /* The first number appears to be the number of bytes occupied - by this type, except that unsigned short is 4 instead of 2. - Since this information is redundant with the third number, - we will ignore it. */ - read_number (pp, ';'); - - /* The second number is always 0, so ignore it too. */ - read_number (pp, ';'); - - /* The third number is the number of bits for this type. */ - nbits = read_number (pp, 0); - - /* FIXME. Here we should just be able to make a type of the right - number of bits and signedness. FIXME. */ - - if (nbits == TARGET_LONG_LONG_BIT) - return (lookup_fundamental_type (objfile, - signed_type? FT_LONG_LONG: FT_UNSIGNED_LONG_LONG)); - - if (nbits == TARGET_INT_BIT) { - /* FIXME -- the only way to distinguish `int' from `long' - is to look at its name! */ - if (signed_type) { - if (long_kludge_name && long_kludge_name[0] == 'l' /* long */) - return lookup_fundamental_type (objfile, FT_LONG); - else - return lookup_fundamental_type (objfile, FT_INTEGER); - } else { - if (long_kludge_name - && ((long_kludge_name[0] == 'u' /* unsigned */ && - long_kludge_name[9] == 'l' /* long */) - || (long_kludge_name[0] == 'l' /* long unsigned */))) - return lookup_fundamental_type (objfile, FT_UNSIGNED_LONG); - else - return lookup_fundamental_type (objfile, FT_UNSIGNED_INTEGER); - } - } - - if (nbits == TARGET_SHORT_BIT) - return (lookup_fundamental_type (objfile, - signed_type? FT_SHORT: FT_UNSIGNED_SHORT)); - - if (nbits == TARGET_CHAR_BIT) - return (lookup_fundamental_type (objfile, - signed_type? FT_CHAR: FT_UNSIGNED_CHAR)); - - if (nbits == 0) - return lookup_fundamental_type (objfile, FT_VOID); - - return error_type (pp); -} +/* Same as end_symtab except create a symtab that can be later added to. */ -static struct type * -read_sun_floating_type (pp, typenums, objfile) - char **pp; - int typenums[2]; - struct objfile *objfile; +struct compunit_symtab * +buildsym_compunit::end_expandable_symtab (CORE_ADDR end_addr, int section) { - int nbytes; - - /* The first number has more details about the type, for example - FN_COMPLEX. See the sun stab.h. */ - read_number (pp, ';'); - - /* The second number is the number of bytes occupied by this type */ - nbytes = read_number (pp, ';'); + struct block *static_block; - if (**pp != 0) - return error_type (pp); - - if (nbytes == TARGET_FLOAT_BIT / TARGET_CHAR_BIT) - return lookup_fundamental_type (objfile, FT_FLOAT); - - if (nbytes == TARGET_DOUBLE_BIT / TARGET_CHAR_BIT) - return lookup_fundamental_type (objfile, FT_DBL_PREC_FLOAT); - - if (nbytes == TARGET_LONG_DOUBLE_BIT / TARGET_CHAR_BIT) - return lookup_fundamental_type (objfile, FT_EXT_PREC_FLOAT); - - return error_type (pp); + static_block = end_symtab_get_static_block (end_addr, 1, 0); + return end_symtab_from_static_block (static_block, section, 1); } -/* Read a number from the string pointed to by *PP. - The value of *PP is advanced over the number. - If END is nonzero, the character that ends the - number must match END, or an error happens; - and that character is skipped if it does match. - If END is zero, *PP is left pointing to that character. - - If the number fits in a long, set *VALUE and set *BITS to 0. - If not, set *BITS to be the number of bits in the number. - - If encounter garbage, set *BITS to -1. */ +/* Subroutine of augment_type_symtab to simplify it. + Attach the main source file's symtab to all symbols in PENDING_LIST that + don't have one. */ static void -read_huge_number (pp, end, valu, bits) - char **pp; - int end; - long *valu; - int *bits; +set_missing_symtab (struct pending *pending_list, + struct compunit_symtab *cu) { - char *p = *pp; - int sign = 1; - long n = 0; - int radix = 10; - char overflow = 0; - int nbits = 0; - int c; - long upper_limit; - - if (*p == '-') - { - sign = -1; - p++; - } - - /* Leading zero means octal. GCC uses this to output values larger - than an int (because that would be hard in decimal). */ - if (*p == '0') - { - radix = 8; - p++; - } - - upper_limit = LONG_MAX / radix; - while ((c = *p++) >= '0' && c <= ('0' + radix)) - { - if (n <= upper_limit) - { - n *= radix; - n += c - '0'; /* FIXME this overflows anyway */ - } - else - overflow = 1; - - /* This depends on large values being output in octal, which is - what GCC does. */ - if (radix == 8) - { - if (nbits == 0) - { - if (c == '0') - /* Ignore leading zeroes. */ - ; - else if (c == '1') - nbits = 1; - else if (c == '2' || c == '3') - nbits = 2; - else - nbits = 3; - } - else - nbits += 3; - } - } - if (end) - { - if (c && c != end) - { - if (bits != NULL) - *bits = -1; - return; - } - } - else - --p; + struct pending *pending; + int i; - *pp = p; - if (overflow) + for (pending = pending_list; pending != NULL; pending = pending->next) { - if (nbits == 0) + for (i = 0; i < pending->nsyms; ++i) { - /* Large decimal constants are an error (because it is hard to - count how many bits are in them). */ - if (bits != NULL) - *bits = -1; - return; + if (symbol_symtab (pending->symbol[i]) == NULL) + symbol_set_symtab (pending->symbol[i], COMPUNIT_FILETABS (cu)); } - - /* -0x7f is the same as 0x80. So deal with it by adding one to - the number of bits. */ - if (sign == -1) - ++nbits; - if (bits) - *bits = nbits; - } - else - { - if (valu) - *valu = n * sign; - if (bits) - *bits = 0; } } -static struct type * -read_range_type (pp, typenums, objfile) - char **pp; - int typenums[2]; - struct objfile *objfile; -{ - int rangenums[2]; - long n2, n3; - int n2bits, n3bits; - int self_subrange; - struct type *result_type; - - /* First comes a type we are a subrange of. - In C it is usually 0, 1 or the type being defined. */ - read_type_number (pp, rangenums); - self_subrange = (rangenums[0] == typenums[0] && - rangenums[1] == typenums[1]); - - /* A semicolon should now follow; skip it. */ - if (**pp == ';') - (*pp)++; - - /* The remaining two operands are usually lower and upper bounds - of the range. But in some special cases they mean something else. */ - read_huge_number (pp, ';', &n2, &n2bits); - read_huge_number (pp, ';', &n3, &n3bits); - - if (n2bits == -1 || n3bits == -1) - return error_type (pp); - - /* If limits are huge, must be large integral type. */ - if (n2bits != 0 || n3bits != 0) - { - char got_signed = 0; - char got_unsigned = 0; - /* Number of bits in the type. */ - int nbits; +/* Same as end_symtab, but for the case where we're adding more symbols + to an existing symtab that is known to contain only type information. + This is the case for DWARF4 Type Units. */ - /* Range from 0 to is an unsigned large integral type. */ - if ((n2bits == 0 && n2 == 0) && n3bits != 0) - { - got_unsigned = 1; - nbits = n3bits; - } - /* Range from to -1 is a large signed - integral type. */ - else if (n2bits != 0 && n3bits != 0 && n2bits == n3bits + 1) - { - got_signed = 1; - nbits = n2bits; - } - - /* Check for "long long". */ - if (got_signed && nbits == TARGET_LONG_LONG_BIT) - return (lookup_fundamental_type (objfile, FT_LONG_LONG)); - if (got_unsigned && nbits == TARGET_LONG_LONG_BIT) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_LONG_LONG)); - - if (got_signed || got_unsigned) - { - result_type = (struct type *) - obstack_alloc (&objfile -> type_obstack, - sizeof (struct type)); - (void) memset (result_type, 0, sizeof (struct type)); - TYPE_OBJFILE (result_type) = objfile; - TYPE_LENGTH (result_type) = nbits / TARGET_CHAR_BIT; - TYPE_CODE (result_type) = TYPE_CODE_INT; - if (got_unsigned) - TYPE_FLAGS (result_type) |= TYPE_FLAG_UNSIGNED; - return result_type; - } - else - return error_type (pp); - } - - /* A type defined as a subrange of itself, with bounds both 0, is void. */ - if (self_subrange && n2 == 0 && n3 == 0) - return (lookup_fundamental_type (objfile, FT_VOID)); - - /* If n3 is zero and n2 is not, we want a floating type, - and n2 is the width in bytes. - - Fortran programs appear to use this for complex types also, - and they give no way to distinguish between double and single-complex! - We don't have complex types, so we would lose on all fortran files! - So return type `double' for all of those. It won't work right - for the complex values, but at least it makes the file loadable. +void +buildsym_compunit::augment_type_symtab () +{ + struct compunit_symtab *cust = m_compunit_symtab; + const struct blockvector *blockvector = COMPUNIT_BLOCKVECTOR (cust); - FIXME, we may be able to distinguish these by their names. FIXME. */ + if (!m_context_stack.empty ()) + complaint (_("Context stack not empty in augment_type_symtab")); + if (m_pending_blocks != NULL) + complaint (_("Blocks in a type symtab")); + if (m_pending_macros != NULL) + complaint (_("Macro in a type symtab")); + if (m_have_line_numbers) + complaint (_("Line numbers recorded in a type symtab")); - if (n3 == 0 && n2 > 0) + if (m_file_symbols != NULL) { - if (n2 == sizeof (float)) - return (lookup_fundamental_type (objfile, FT_FLOAT)); - return (lookup_fundamental_type (objfile, FT_DBL_PREC_FLOAT)); - } + struct block *block = BLOCKVECTOR_BLOCK (blockvector, STATIC_BLOCK); - /* If the upper bound is -1, it must really be an unsigned int. */ + /* First mark any symbols without a specified symtab as belonging + to the primary symtab. */ + set_missing_symtab (m_file_symbols, cust); - else if (n2 == 0 && n3 == -1) - { - /* FIXME -- the only way to distinguish `unsigned int' from `unsigned - long' is to look at its name! */ - if ( - long_kludge_name && ((long_kludge_name[0] == 'u' /* unsigned */ && - long_kludge_name[9] == 'l' /* long */) - || (long_kludge_name[0] == 'l' /* long unsigned */))) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_LONG)); - else - return (lookup_fundamental_type (objfile, FT_UNSIGNED_INTEGER)); + mdict_add_pending (BLOCK_MULTIDICT (block), m_file_symbols); } - /* Special case: char is defined (Who knows why) as a subrange of - itself with range 0-127. */ - else if (self_subrange && n2 == 0 && n3 == 127) - return (lookup_fundamental_type (objfile, FT_CHAR)); - - /* Assumptions made here: Subrange of self is equivalent to subrange - of int. FIXME: Host and target type-sizes assumed the same. */ - /* FIXME: This is the *only* place in GDB that depends on comparing - some type to a builtin type with ==. Fix it! */ - else if (n2 == 0 - && (self_subrange || - *dbx_lookup_type (rangenums) == lookup_fundamental_type (objfile, FT_INTEGER))) - { - /* an unsigned type */ -#ifdef LONG_LONG - if (n3 == - sizeof (long long)) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_LONG_LONG)); -#endif - /* FIXME -- the only way to distinguish `unsigned int' from `unsigned - long' is to look at its name! */ - if (n3 == (unsigned long)~0L && - long_kludge_name && ((long_kludge_name[0] == 'u' /* unsigned */ && - long_kludge_name[9] == 'l' /* long */) - || (long_kludge_name[0] == 'l' /* long unsigned */))) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_LONG)); - if (n3 == (unsigned int)~0L) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_INTEGER)); - if (n3 == (unsigned short)~0L) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_SHORT)); - if (n3 == (unsigned char)~0L) - return (lookup_fundamental_type (objfile, FT_UNSIGNED_CHAR)); - } -#ifdef LONG_LONG - else if (n3 == 0 && n2 == -sizeof (long long)) - return (lookup_fundamental_type (objfile, FT_LONG_LONG)); -#endif - else if (n2 == -n3 -1) + if (m_global_symbols != NULL) { - /* a signed type */ - /* FIXME -- the only way to distinguish `int' from `long' is to look - at its name! */ - if ((n3 ==(long)(((unsigned long)1 << (8 * sizeof (long) - 1)) - 1)) && - long_kludge_name && long_kludge_name[0] == 'l' /* long */) - return (lookup_fundamental_type (objfile, FT_LONG)); - if (n3 == (long)(((unsigned long)1 << (8 * sizeof (int) - 1)) - 1)) - return (lookup_fundamental_type (objfile, FT_INTEGER)); - if (n3 == ( 1 << (8 * sizeof (short) - 1)) - 1) - return (lookup_fundamental_type (objfile, FT_SHORT)); - if (n3 == ( 1 << (8 * sizeof (char) - 1)) - 1) - return (lookup_fundamental_type (objfile, FT_SIGNED_CHAR)); - } - - /* We have a real range type on our hands. Allocate space and - return a real pointer. */ - - /* At this point I don't have the faintest idea how to deal with - a self_subrange type; I'm going to assume that this is used - as an idiom, and that all of them are special cases. So . . . */ - if (self_subrange) - return error_type (pp); - - result_type = (struct type *) - obstack_alloc (&objfile -> type_obstack, sizeof (struct type)); - (void) memset (result_type, 0, sizeof (struct type)); - TYPE_OBJFILE (result_type) = objfile; - - TYPE_CODE (result_type) = TYPE_CODE_RANGE; + struct block *block = BLOCKVECTOR_BLOCK (blockvector, GLOBAL_BLOCK); - TYPE_TARGET_TYPE (result_type) = *dbx_lookup_type(rangenums); - if (TYPE_TARGET_TYPE (result_type) == 0) { - complain (&range_type_base_complaint, (char *) rangenums[1]); - TYPE_TARGET_TYPE (result_type) = lookup_fundamental_type (objfile, FT_INTEGER); - } - - TYPE_NFIELDS (result_type) = 2; - TYPE_FIELDS (result_type) = - (struct field *) obstack_alloc (&objfile -> type_obstack, - 2 * sizeof (struct field)); - (void) memset (TYPE_FIELDS (result_type), 0, 2 * sizeof (struct field)); - TYPE_FIELD_BITPOS (result_type, 0) = n2; - TYPE_FIELD_BITPOS (result_type, 1) = n3; - - TYPE_LENGTH (result_type) = TYPE_LENGTH (TYPE_TARGET_TYPE (result_type)); - - return result_type; -} - -/* Read a number from the string pointed to by *PP. - The value of *PP is advanced over the number. - If END is nonzero, the character that ends the - number must match END, or an error happens; - and that character is skipped if it does match. - If END is zero, *PP is left pointing to that character. */ - -long -read_number (pp, end) - char **pp; - int end; -{ - register char *p = *pp; - register long n = 0; - register int c; - int sign = 1; + /* First mark any symbols without a specified symtab as belonging + to the primary symtab. */ + set_missing_symtab (m_global_symbols, cust); - /* Handle an optional leading minus sign. */ - - if (*p == '-') - { - sign = -1; - p++; - } - - /* Read the digits, as far as they go. */ - - while ((c = *p++) >= '0' && c <= '9') - { - n *= 10; - n += c - '0'; - } - if (end) - { - if (c && c != end) - error ("Invalid symbol data: invalid character \\%03o at symbol pos %d.", c, symnum); + mdict_add_pending (BLOCK_MULTIDICT (block), + m_global_symbols); } - else - --p; - - *pp = p; - return n * sign; } -/* Read in an argument list. This is a list of types, separated by commas - and terminated with END. Return the list of types read in, or (struct type - **)-1 if there is an error. */ -static struct type ** -read_args (pp, end, objfile) - char **pp; - int end; - struct objfile *objfile; -{ - /* FIXME! Remove this arbitrary limit! */ - struct type *types[1024], **rval; /* allow for fns of 1023 parameters */ - int n = 0; +/* Push a context block. Args are an identifying nesting level + (checkable when you pop it), and the starting PC address of this + context. */ - while (**pp != end) - { - if (**pp != ',') - /* Invalid argument list: no ','. */ - return (struct type **)-1; - *pp += 1; +struct context_stack * +buildsym_compunit::push_context (int desc, CORE_ADDR valu) +{ + m_context_stack.emplace_back (); + struct context_stack *newobj = &m_context_stack.back (); - /* Check for and handle cretinous dbx symbol name continuation! */ - if (**pp == '\\') - *pp = next_symbol_text (); + newobj->depth = desc; + newobj->locals = m_local_symbols; + newobj->old_blocks = m_pending_blocks; + newobj->start_addr = valu; + newobj->local_using_directives = m_local_using_directives; + newobj->name = NULL; - types[n++] = read_type (pp, objfile); - } - *pp += 1; /* get past `end' (the ':' character) */ + m_local_symbols = NULL; + m_local_using_directives = NULL; - if (n == 1) - { - rval = (struct type **) xmalloc (2 * sizeof (struct type *)); - } - else if (TYPE_CODE (types[n-1]) != TYPE_CODE_VOID) - { - rval = (struct type **) xmalloc ((n + 1) * sizeof (struct type *)); - (void) memset (rval + n, 0, sizeof (struct type *)); - } - else - { - rval = (struct type **) xmalloc (n * sizeof (struct type *)); - } - memcpy (rval, types, n * sizeof (struct type *)); - return rval; + return newobj; } -/* Add a common block's start address to the offset of each symbol - declared to be in it (by being between a BCOMM/ECOMM pair that uses - the common block name). */ +/* Pop a context block. Returns the address of the context block just + popped. */ -static void -fix_common_block (sym, valu) - struct symbol *sym; - int valu; -{ - struct pending *next = (struct pending *) SYMBOL_NAMESPACE (sym); - for ( ; next; next = next->next) - { - register int j; - for (j = next->nsyms - 1; j >= 0; j--) - SYMBOL_VALUE_ADDRESS (next->symbol[j]) += valu; - } -} - -/* Initializer for this module */ -void -_initialize_buildsym () +struct context_stack +buildsym_compunit::pop_context () { - undef_types_allocated = 20; - undef_types_length = 0; - undef_types = (struct type **) xmalloc (undef_types_allocated * - sizeof (struct type *)); + gdb_assert (!m_context_stack.empty ()); + struct context_stack result = m_context_stack.back (); + m_context_stack.pop_back (); + return result; }