X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fjv-lang.c;h=c6700c9241568e6e1167d39f1e0b0e5edb9db930;hb=d416eeec97f1a62875b49332e62cae67ebcb7e92;hp=8ada2e7fbceba75513bcfde6e93ad74440e2d2b2;hpb=65b07ddca8832033e0e102c3a2a0d9f9f5922a9d;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/jv-lang.c b/gdb/jv-lang.c index 8ada2e7fbc..c6700c9241 100644 --- a/gdb/jv-lang.c +++ b/gdb/jv-lang.c @@ -1,21 +1,24 @@ /* Java language support routines for GDB, the GNU debugger. - Copyright 1997, 1998 Free Software Foundation, Inc. -This file is part of GDB. + Copyright 1997, 1998, 1999, 2000, 2003, 2004, 2005 Free Software + Foundation, Inc. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + This file is part of GDB. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. -You should have received a copy of the GNU General Public License -along with this program; if not, write to the Free Software -Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ #include "defs.h" #include "symtab.h" @@ -32,6 +35,9 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "c-lang.h" #include "jv-lang.h" #include "gdbcore.h" +#include "block.h" +#include "demangle.h" +#include "dictionary.h" #include struct type *java_int_type; @@ -44,7 +50,21 @@ struct type *java_float_type; struct type *java_double_type; struct type *java_void_type; -static void java_emit_char PARAMS ((int c, GDB_FILE *stream, int quoter)); +/* Local functions */ + +extern void _initialize_java_language (void); + +static int java_demangled_signature_length (char *); +static void java_demangled_signature_copy (char *, char *); + +static struct symtab *get_java_class_symtab (void); +static char *get_java_utf8_name (struct obstack *obstack, struct value *name); +static int java_class_is_primitive (struct value *clas); +static struct value *java_value_string (char *ptr, int len); + +static void java_emit_char (int c, struct ui_file * stream, int quoter); + +static char *java_class_name_from_physname (const char *physname); /* This objfile contains symtabs that have been dynamically created to record dynamically loaded Java classes and dynamically @@ -52,20 +72,20 @@ static void java_emit_char PARAMS ((int c, GDB_FILE *stream, int quoter)); static struct objfile *dynamics_objfile = NULL; -static struct type *java_link_class_type PARAMS ((struct type *, value_ptr)); +static struct type *java_link_class_type (struct type *, struct value *); + +/* FIXME: carlton/2003-02-04: This is the main or only caller of + allocate_objfile with first argument NULL; as a result, this code + breaks every so often. Somebody should write a test case that + exercises GDB in various ways (e.g. something involving loading a + dynamic library) after this code has been called. */ static struct objfile * -get_dynamics_objfile () +get_dynamics_objfile (void) { if (dynamics_objfile == NULL) { - -/* CHECK WITH STU -- edie. Params 3 and 4 are USER_LOADED and IS_SOLIB. - USER_LOADED - used by run_command to remove old objfile entries which - are no longer valid - IS_SOLIB - 1 if the object file is a shared library */ - - dynamics_objfile = allocate_objfile (NULL, 0, 0, 0); + dynamics_objfile = allocate_objfile (NULL, 0); } return dynamics_objfile; } @@ -75,98 +95,82 @@ get_dynamics_objfile () static struct symtab *class_symtab = NULL; -/* Maximum number of class in class_symtab before relocation is needed. */ - -static int class_symtab_space; +static void free_class_block (struct symtab *symtab); -struct symtab * -get_java_class_symtab () +static struct symtab * +get_java_class_symtab (void) { if (class_symtab == NULL) { - struct objfile *objfile = get_dynamics_objfile(); + struct objfile *objfile = get_dynamics_objfile (); struct blockvector *bv; struct block *bl; class_symtab = allocate_symtab ("", objfile); class_symtab->language = language_java; bv = (struct blockvector *) - obstack_alloc (&objfile->symbol_obstack, sizeof (struct blockvector)); + obstack_alloc (&objfile->objfile_obstack, + sizeof (struct blockvector) + sizeof (struct block *)); BLOCKVECTOR_NBLOCKS (bv) = 1; BLOCKVECTOR (class_symtab) = bv; /* Allocate dummy STATIC_BLOCK. */ - bl = (struct block *) - obstack_alloc (&objfile->symbol_obstack, sizeof (struct block)); - BLOCK_NSYMS (bl) = 0; - BLOCK_START (bl) = 0; - BLOCK_END (bl) = 0; - BLOCK_FUNCTION (bl) = NULL; - BLOCK_SUPERBLOCK (bl) = NULL; - BLOCK_GCC_COMPILED (bl) = 0; + bl = allocate_block (&objfile->objfile_obstack); + BLOCK_DICT (bl) = dict_create_linear (&objfile->objfile_obstack, + NULL); BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK) = bl; - /* Allocate GLOBAL_BLOCK. This has to be relocatable. */ - class_symtab_space = 128; - bl = (struct block *) - mmalloc (objfile->md, - sizeof (struct block) - + ((class_symtab_space - 1) * sizeof (struct symbol *))); - *bl = *BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK); + /* Allocate GLOBAL_BLOCK. */ + bl = allocate_block (&objfile->objfile_obstack); + BLOCK_DICT (bl) = dict_create_hashed_expandable (); BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK) = bl; - class_symtab->free_ptr = (char *) bl; + class_symtab->free_func = free_class_block; } return class_symtab; } static void -add_class_symtab_symbol (sym) - struct symbol *sym; +add_class_symtab_symbol (struct symbol *sym) { struct symtab *symtab = get_java_class_symtab (); struct blockvector *bv = BLOCKVECTOR (symtab); - struct block *bl = BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK); - if (BLOCK_NSYMS (bl) >= class_symtab_space) - { - /* Need to re-allocate. */ - class_symtab_space *= 2; - bl = (struct block *) - mrealloc (symtab->objfile->md, bl, - sizeof (struct block) - + ((class_symtab_space - 1) * sizeof (struct symbol *))); - class_symtab->free_ptr = (char *) bl; - BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK) = bl; - } - - BLOCK_SYM (bl, BLOCK_NSYMS (bl)) = sym; - BLOCK_NSYMS (bl) = BLOCK_NSYMS (bl) + 1; + dict_add_symbol (BLOCK_DICT (BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK)), sym); } -struct symbol * -add_class_symbol (type, addr) - struct type *type; - CORE_ADDR addr; +static struct symbol *add_class_symbol (struct type *type, CORE_ADDR addr); + +static struct symbol * +add_class_symbol (struct type *type, CORE_ADDR addr) { struct symbol *sym; sym = (struct symbol *) - obstack_alloc (&dynamics_objfile->symbol_obstack, sizeof (struct symbol)); + obstack_alloc (&dynamics_objfile->objfile_obstack, sizeof (struct symbol)); memset (sym, 0, sizeof (struct symbol)); SYMBOL_LANGUAGE (sym) = language_java; - SYMBOL_NAME (sym) = TYPE_TAG_NAME (type); + DEPRECATED_SYMBOL_NAME (sym) = TYPE_TAG_NAME (type); SYMBOL_CLASS (sym) = LOC_TYPEDEF; - /* SYMBOL_VALUE (sym) = valu;*/ + /* SYMBOL_VALUE (sym) = valu; */ SYMBOL_TYPE (sym) = type; - SYMBOL_NAMESPACE (sym) = STRUCT_NAMESPACE; + SYMBOL_DOMAIN (sym) = STRUCT_DOMAIN; SYMBOL_VALUE_ADDRESS (sym) = addr; return sym; } + +/* Free the dynamic symbols block. */ +static void +free_class_block (struct symtab *symtab) +{ + struct blockvector *bv = BLOCKVECTOR (symtab); + struct block *bl = BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK); + + dict_free (BLOCK_DICT (bl)); +} #endif struct type * -java_lookup_class (name) - char *name; +java_lookup_class (char *name) { struct symbol *sym; - sym = lookup_symbol (name, expression_context_block, STRUCT_NAMESPACE, + sym = lookup_symbol (name, expression_context_block, STRUCT_DOMAIN, (int *) 0, (struct symtab **) NULL); if (sym != NULL) return SYMBOL_TYPE (sym); @@ -175,7 +179,8 @@ java_lookup_class (name) if (called from parser) { call lookup_class (or similar) in inferior; - if not found: + if not + found: return NULL; addr = found in inferior; } @@ -185,7 +190,7 @@ java_lookup_class (name) type = alloc_type (objfile); TYPE_CODE (type) = TYPE_CODE_STRUCT; INIT_CPLUS_SPECIFIC (type); - TYPE_TAG_NAME (type) = obsavestring (name, strlen(name), &objfile->type_obstack); + TYPE_TAG_NAME (type) = obsavestring (name, strlen (name), &objfile->objfile_obstack); TYPE_FLAGS (type) |= TYPE_FLAG_STUB; TYPE ? = addr; return type; @@ -199,100 +204,88 @@ java_lookup_class (name) a name given by NAME (which has type Utf8Const*). */ char * -get_java_utf8_name (obstack, name) - struct obstack *obstack; - value_ptr name; +get_java_utf8_name (struct obstack *obstack, struct value *name) { char *chrs; - value_ptr temp = name; + struct value *temp = name; int name_length; CORE_ADDR data_addr; temp = value_struct_elt (&temp, NULL, "length", NULL, "structure"); name_length = (int) value_as_long (temp); - data_addr = VALUE_ADDRESS (temp) + VALUE_OFFSET (temp) - + TYPE_LENGTH (VALUE_TYPE (temp)); - chrs = obstack_alloc (obstack, name_length+1); - chrs [name_length] = '\0'; - read_memory_section (data_addr, chrs, name_length, NULL); + data_addr = VALUE_ADDRESS (temp) + value_offset (temp) + + TYPE_LENGTH (value_type (temp)); + chrs = obstack_alloc (obstack, name_length + 1); + chrs[name_length] = '\0'; + read_memory (data_addr, (gdb_byte *) chrs, name_length); return chrs; } -value_ptr -java_class_from_object (obj_val) - value_ptr obj_val; +struct value * +java_class_from_object (struct value *obj_val) { - /* This is all rather inefficient, since the offsets of dtable and + /* This is all rather inefficient, since the offsets of vtable and class are fixed. FIXME */ - value_ptr dtable_val; + struct value *vtable_val; - if (TYPE_CODE (VALUE_TYPE (obj_val)) == TYPE_CODE_PTR - && TYPE_LENGTH (TYPE_TARGET_TYPE (VALUE_TYPE (obj_val))) == 0) - { - struct symbol *sym; - sym = lookup_symbol ("Hjava_lang_Object", NULL, STRUCT_NAMESPACE, - (int *) 0, (struct symtab **) NULL); - if (sym != NULL) - obj_val = value_at (VALUE_TYPE (sym), - value_as_pointer (obj_val), NULL); - } + if (TYPE_CODE (value_type (obj_val)) == TYPE_CODE_PTR + && TYPE_LENGTH (TYPE_TARGET_TYPE (value_type (obj_val))) == 0) + obj_val = value_at (get_java_object_type (), + value_as_address (obj_val)); - dtable_val = value_struct_elt (&obj_val, NULL, "dtable", NULL, "structure"); - return value_struct_elt (&dtable_val, NULL, "class", NULL, "structure"); + vtable_val = value_struct_elt (&obj_val, NULL, "vtable", NULL, "structure"); + return value_struct_elt (&vtable_val, NULL, "class", NULL, "structure"); } /* Check if CLASS_IS_PRIMITIVE(value of clas): */ -int -java_class_is_primitive (clas) - value_ptr clas; +static int +java_class_is_primitive (struct value *clas) { - value_ptr dtable = value_struct_elt (&clas, NULL, "dtable", NULL, "struct"); - CORE_ADDR i = value_as_pointer (dtable); + struct value *vtable = value_struct_elt (&clas, NULL, "vtable", NULL, "struct"); + CORE_ADDR i = value_as_address (vtable); return (int) (i & 0x7fffffff) == (int) 0x7fffffff; } -/* Read a Kaffe Class object, and generated a gdb (TYPE_CODE_STRUCT) type. */ +/* Read a GCJ Class object, and generated a gdb (TYPE_CODE_STRUCT) type. */ struct type * -type_from_class (clas) - value_ptr clas; +type_from_class (struct value *clas) { struct type *type; char *name; - value_ptr temp; + struct value *temp; struct objfile *objfile; - value_ptr utf8_name; + struct value *utf8_name; char *nptr; CORE_ADDR addr; struct block *bl; - int i; + struct dict_iterator iter; int is_array = 0; - type = check_typedef (VALUE_TYPE (clas)); + type = check_typedef (value_type (clas)); if (TYPE_CODE (type) == TYPE_CODE_PTR) { if (value_logical_not (clas)) return NULL; clas = value_ind (clas); } - addr = VALUE_ADDRESS (clas) + VALUE_OFFSET (clas); + addr = VALUE_ADDRESS (clas) + value_offset (clas); #if 0 get_java_class_symtab (); bl = BLOCKVECTOR_BLOCK (BLOCKVECTOR (class_symtab), GLOBAL_BLOCK); - for (i = BLOCK_NSYMS (bl); --i >= 0; ) + ALL_BLOCK_SYMBOLS (block, iter, sym) { - struct symbol *sym = BLOCK_SYM (bl, i); if (SYMBOL_VALUE_ADDRESS (sym) == addr) return SYMBOL_TYPE (sym); } #endif - objfile = get_dynamics_objfile(); + objfile = get_dynamics_objfile (); if (java_class_is_primitive (clas)) { - value_ptr sig; + struct value *sig; temp = clas; - sig = value_struct_elt (&temp, NULL, "msize", NULL, "structure"); + sig = value_struct_elt (&temp, NULL, "method_count", NULL, "structure"); return java_primitive_type (value_as_long (sig)); } @@ -300,8 +293,8 @@ type_from_class (clas) /* if clasloader non-null, prepend loader address. FIXME */ temp = clas; utf8_name = value_struct_elt (&temp, NULL, "name", NULL, "structure"); - name = get_java_utf8_name (&objfile->type_obstack, utf8_name); - for (nptr = name; *nptr != 0; nptr++) + name = get_java_utf8_name (&objfile->objfile_obstack, utf8_name); + for (nptr = name; *nptr != 0; nptr++) { if (*nptr == '/') *nptr = '.'; @@ -317,11 +310,17 @@ type_from_class (clas) if (name[0] == '[') { + char *signature = name; + int namelen = java_demangled_signature_length (signature); + if (namelen > strlen (name)) + name = obstack_alloc (&objfile->objfile_obstack, namelen + 1); + java_demangled_signature_copy (name, signature); + name[namelen] = '\0'; is_array = 1; temp = clas; /* Set array element type. */ temp = value_struct_elt (&temp, NULL, "methods", NULL, "structure"); - VALUE_TYPE (temp) = lookup_pointer_type (VALUE_TYPE (clas)); + deprecated_set_value_type (temp, lookup_pointer_type (value_type (clas))); TYPE_TARGET_TYPE (type) = type_from_class (temp); } @@ -332,23 +331,24 @@ type_from_class (clas) return java_link_class_type (type, clas); } -/* Fill in class TYPE with data from the CLAS value. */ +/* Fill in class TYPE with data from the CLAS value. */ struct type * -java_link_class_type (type, clas) - struct type *type; - value_ptr clas; +java_link_class_type (struct type *type, struct value *clas) { - value_ptr temp; + struct value *temp; char *unqualified_name; char *name = TYPE_TAG_NAME (type); int ninterfaces, nfields, nmethods; int type_is_object = 0; struct fn_field *fn_fields; struct fn_fieldlist *fn_fieldlists; - value_ptr fields, field, method, methods; + struct value *fields; + struct value *methods; + struct value *method = NULL; + struct value *field = NULL; int i, j; - struct objfile *objfile = get_dynamics_objfile(); + struct objfile *objfile = get_dynamics_objfile (); struct type *tsuper; unqualified_name = strrchr (name, '.'); @@ -375,9 +375,9 @@ java_link_class_type (type, clas) #endif TYPE_N_BASECLASSES (type) = (tsuper == NULL ? 0 : 1) + ninterfaces; temp = clas; - nfields = value_as_long (value_struct_elt (&temp, NULL, "nfields", NULL, "structure")); + nfields = value_as_long (value_struct_elt (&temp, NULL, "field_count", NULL, "structure")); nfields += TYPE_N_BASECLASSES (type); - nfields++; /* Add one for dummy "class" field. */ + nfields++; /* Add one for dummy "class" field. */ TYPE_NFIELDS (type) = nfields; TYPE_FIELDS (type) = (struct field *) TYPE_ALLOC (type, sizeof (struct field) * nfields); @@ -407,27 +407,28 @@ java_link_class_type (type, clas) SET_TYPE_FIELD_PRIVATE (type, 0); } - - if (name[0] == '[' && tsuper != NULL) + i = strlen (name); + if (i > 2 && name[i - 1] == ']' && tsuper != NULL) { - TYPE_LENGTH (type) = TYPE_LENGTH (tsuper) + 4; /* size with "length" */ + /* FIXME */ + TYPE_LENGTH (type) = TYPE_LENGTH (tsuper) + 4; /* size with "length" */ } else { temp = clas; - temp = value_struct_elt (&temp, NULL, "bfsize", NULL, "structure"); + temp = value_struct_elt (&temp, NULL, "size_in_bytes", NULL, "structure"); TYPE_LENGTH (type) = value_as_long (temp); } fields = NULL; - nfields--; /* First set up dummy "class" field. */ + nfields--; /* First set up dummy "class" field. */ SET_FIELD_PHYSADDR (TYPE_FIELD (type, nfields), - VALUE_ADDRESS (clas) + VALUE_OFFSET (clas)); + VALUE_ADDRESS (clas) + value_offset (clas)); TYPE_FIELD_NAME (type, nfields) = "class"; - TYPE_FIELD_TYPE (type, nfields) = VALUE_TYPE (clas); + TYPE_FIELD_TYPE (type, nfields) = value_type (clas); SET_TYPE_FIELD_PRIVATE (type, nfields); - - for (i = TYPE_N_BASECLASSES (type); i < nfields; i++) + + for (i = TYPE_N_BASECLASSES (type); i < nfields; i++) { int accflags; int boffset; @@ -438,40 +439,40 @@ java_link_class_type (type, clas) field = value_ind (fields); } else - { /* Re-use field value for next field. */ - VALUE_ADDRESS (field) += TYPE_LENGTH (VALUE_TYPE (field)); - VALUE_LAZY (field) = 1; + { /* Re-use field value for next field. */ + VALUE_ADDRESS (field) += TYPE_LENGTH (value_type (field)); + set_value_lazy (field, 1); } temp = field; temp = value_struct_elt (&temp, NULL, "name", NULL, "structure"); TYPE_FIELD_NAME (type, i) = - get_java_utf8_name (&objfile->type_obstack, temp); + get_java_utf8_name (&objfile->objfile_obstack, temp); temp = field; accflags = value_as_long (value_struct_elt (&temp, NULL, "accflags", NULL, "structure")); temp = field; temp = value_struct_elt (&temp, NULL, "info", NULL, "structure"); boffset = value_as_long (value_struct_elt (&temp, NULL, "boffset", - NULL, "structure")); - if (accflags & 0x0001) /* public access */ + NULL, "structure")); + if (accflags & 0x0001) /* public access */ { /* ??? */ } - if (accflags & 0x0002) /* private access */ + if (accflags & 0x0002) /* private access */ { SET_TYPE_FIELD_PRIVATE (type, i); } - if (accflags & 0x0004) /* protected access */ + if (accflags & 0x0004) /* protected access */ { SET_TYPE_FIELD_PROTECTED (type, i); } - if (accflags & 0x0008) /* ACC_STATIC */ - SET_FIELD_PHYSADDR(TYPE_FIELD(type, i), boffset); + if (accflags & 0x0008) /* ACC_STATIC */ + SET_FIELD_PHYSADDR (TYPE_FIELD (type, i), boffset); else TYPE_FIELD_BITPOS (type, i) = 8 * boffset; - if (accflags & 0x8000) /* FIELD_UNRESOLVED_FLAG */ + if (accflags & 0x8000) /* FIELD_UNRESOLVED_FLAG */ { - TYPE_FIELD_TYPE (type, i) = get_java_object_type (); /* FIXME */ + TYPE_FIELD_TYPE (type, i) = get_java_object_type (); /* FIXME */ } else { @@ -486,18 +487,18 @@ java_link_class_type (type, clas) } temp = clas; - nmethods = value_as_long (value_struct_elt (&temp, NULL, "nmethods", + nmethods = value_as_long (value_struct_elt (&temp, NULL, "method_count", NULL, "structure")); TYPE_NFN_FIELDS_TOTAL (type) = nmethods; j = nmethods * sizeof (struct fn_field); - fn_fields = (struct fn_field*) - obstack_alloc (&dynamics_objfile->symbol_obstack, j); + fn_fields = (struct fn_field *) + obstack_alloc (&dynamics_objfile->objfile_obstack, j); memset (fn_fields, 0, j); - fn_fieldlists = (struct fn_fieldlist*) + fn_fieldlists = (struct fn_fieldlist *) alloca (nmethods * sizeof (struct fn_fieldlist)); methods = NULL; - for (i = 0; i < nmethods; i++) + for (i = 0; i < nmethods; i++) { char *mname; int k; @@ -508,15 +509,15 @@ java_link_class_type (type, clas) method = value_ind (methods); } else - { /* Re-use method value for next method. */ - VALUE_ADDRESS (method) += TYPE_LENGTH (VALUE_TYPE (method)); - VALUE_LAZY (method) = 1; + { /* Re-use method value for next method. */ + VALUE_ADDRESS (method) += TYPE_LENGTH (value_type (method)); + set_value_lazy (method, 1); } /* Get method name. */ temp = method; temp = value_struct_elt (&temp, NULL, "name", NULL, "structure"); - mname = get_java_utf8_name (&objfile->type_obstack, temp); + mname = get_java_utf8_name (&objfile->objfile_obstack, temp); if (strcmp (mname, "") == 0) mname = unqualified_name; @@ -526,11 +527,11 @@ java_link_class_type (type, clas) * is worth it. Note that we do maintain the order of methods * in the inferior's Method table (as long as that is grouped * by method name), which I think is desirable. --PB */ - for (k = 0, j = TYPE_NFN_FIELDS (type); ; ) + for (k = 0, j = TYPE_NFN_FIELDS (type);;) { if (--j < 0) - { /* No match - new method name. */ - j = TYPE_NFN_FIELDS(type)++; + { /* No match - new method name. */ + j = TYPE_NFN_FIELDS (type)++; fn_fieldlists[j].name = mname; fn_fieldlists[j].length = 1; fn_fieldlists[j].fn_fields = &fn_fields[i]; @@ -538,16 +539,17 @@ java_link_class_type (type, clas) break; } if (strcmp (mname, fn_fieldlists[j].name) == 0) - { /* Found an existing method with the same name. */ + { /* Found an existing method with the same name. */ int l; if (mname != unqualified_name) - obstack_free (&objfile->type_obstack, mname); + obstack_free (&objfile->objfile_obstack, mname); mname = fn_fieldlists[j].name; fn_fieldlists[j].length++; - k = i - k; /* Index of new slot. */ + k = i - k; /* Index of new slot. */ /* Shift intervening fn_fields (between k and i) down. */ - for (l = i; l > k; l--) fn_fields[l] = fn_fields[l-1]; - for (l = TYPE_NFN_FIELDS (type); --l > j; ) + for (l = i; l > k; l--) + fn_fields[l] = fn_fields[l - 1]; + for (l = TYPE_NFN_FIELDS (type); --l > j;) fn_fieldlists[l].fn_fields++; break; } @@ -555,29 +557,47 @@ java_link_class_type (type, clas) } fn_fields[k].physname = ""; fn_fields[k].is_stub = 1; - fn_fields[k].type = make_function_type (java_void_type, NULL); /* FIXME*/ + fn_fields[k].type = make_function_type (java_void_type, NULL); /* FIXME */ TYPE_CODE (fn_fields[k].type) = TYPE_CODE_METHOD; } - j = TYPE_NFN_FIELDS(type) * sizeof (struct fn_fieldlist); - TYPE_FN_FIELDLISTS (type) = (struct fn_fieldlist*) - obstack_alloc (&dynamics_objfile->symbol_obstack, j); + j = TYPE_NFN_FIELDS (type) * sizeof (struct fn_fieldlist); + TYPE_FN_FIELDLISTS (type) = (struct fn_fieldlist *) + obstack_alloc (&dynamics_objfile->objfile_obstack, j); memcpy (TYPE_FN_FIELDLISTS (type), fn_fieldlists, j); - + return type; } static struct type *java_object_type; struct type * -get_java_object_type () +get_java_object_type (void) { + if (java_object_type == NULL) + { + struct symbol *sym; + sym = lookup_symbol ("java.lang.Object", NULL, STRUCT_DOMAIN, + (int *) 0, (struct symtab **) NULL); + if (sym == NULL) + error (_("cannot find java.lang.Object")); + java_object_type = SYMBOL_TYPE (sym); + } return java_object_type; } int -is_object_type (type) - struct type *type; +get_java_object_header_size (void) +{ + struct type *objtype = get_java_object_type (); + if (objtype == NULL) + return (2 * TARGET_PTR_BIT / TARGET_CHAR_BIT); + else + return TYPE_LENGTH (objtype); +} + +int +is_object_type (struct type *type) { CHECK_TYPEDEF (type); if (TYPE_CODE (type) == TYPE_CODE_PTR) @@ -591,8 +611,8 @@ is_object_type (type) name = TYPE_TAG_NAME (ttype); if (name != NULL && strcmp (name, "java.lang.Object") == 0) return 1; - name = TYPE_NFIELDS (ttype) > 0 ? TYPE_FIELD_NAME (ttype, 0) : (char*)0; - if (name != NULL && strcmp (name, "dtable") == 0) + name = TYPE_NFIELDS (ttype) > 0 ? TYPE_FIELD_NAME (ttype, 0) : (char *) 0; + if (name != NULL && strcmp (name, "vtable") == 0) { if (java_object_type == NULL) java_object_type = type; @@ -602,34 +622,103 @@ is_object_type (type) return 0; } -struct type* -java_primitive_type (signature) - int signature; +struct type * +java_primitive_type (int signature) { switch (signature) { - case 'B': return java_byte_type; - case 'S': return java_short_type; - case 'I': return java_int_type; - case 'J': return java_long_type; - case 'Z': return java_boolean_type; - case 'C': return java_char_type; - case 'F': return java_float_type; - case 'D': return java_double_type; - case 'V': return java_void_type; + case 'B': + return java_byte_type; + case 'S': + return java_short_type; + case 'I': + return java_int_type; + case 'J': + return java_long_type; + case 'Z': + return java_boolean_type; + case 'C': + return java_char_type; + case 'F': + return java_float_type; + case 'D': + return java_double_type; + case 'V': + return java_void_type; } - error ("unknown signature '%c' for primitive type", (char) signature); + error (_("unknown signature '%c' for primitive type"), (char) signature); } -/* Return the demangled name of the Java type signature string SIGNATURE, - as a freshly allocated copy. */ +/* If name[0 .. namelen-1] is the name of a primitive Java type, + return that type. Otherwise, return NULL. */ -char * -java_demangle_type_signature (signature) - char *signature; +struct type * +java_primitive_type_from_name (char *name, int namelen) +{ + switch (name[0]) + { + case 'b': + if (namelen == 4 && memcmp (name, "byte", 4) == 0) + return java_byte_type; + if (namelen == 7 && memcmp (name, "boolean", 7) == 0) + return java_boolean_type; + break; + case 'c': + if (namelen == 4 && memcmp (name, "char", 4) == 0) + return java_char_type; + case 'd': + if (namelen == 6 && memcmp (name, "double", 6) == 0) + return java_double_type; + break; + case 'f': + if (namelen == 5 && memcmp (name, "float", 5) == 0) + return java_float_type; + break; + case 'i': + if (namelen == 3 && memcmp (name, "int", 3) == 0) + return java_int_type; + break; + case 'l': + if (namelen == 4 && memcmp (name, "long", 4) == 0) + return java_long_type; + break; + case 's': + if (namelen == 5 && memcmp (name, "short", 5) == 0) + return java_short_type; + break; + case 'v': + if (namelen == 4 && memcmp (name, "void", 4) == 0) + return java_void_type; + break; + } + return NULL; +} + +/* Return the length (in bytes) of demangled name of the Java type + signature string SIGNATURE. */ + +static int +java_demangled_signature_length (char *signature) +{ + int array = 0; + for (; *signature == '['; signature++) + array += 2; /* Two chars for "[]". */ + switch (signature[0]) + { + case 'L': + /* Subtract 2 for 'L' and ';'. */ + return strlen (signature) - 2 + array; + default: + return strlen (TYPE_NAME (java_primitive_type (signature[0]))) + array; + } +} + +/* Demangle the Java type signature SIGNATURE, leaving the result in RESULT. */ + +static void +java_demangled_signature_copy (char *result, char *signature) { int array = 0; - char *result; char *ptr; int i; while (*signature == '[') @@ -640,11 +729,10 @@ java_demangle_type_signature (signature) switch (signature[0]) { case 'L': - /* Substract 2 for 'L' and ';', but add 1 for final nul. */ - result = xmalloc (strlen (signature) - 1 + 2 * array); + /* Subtract 2 for 'L' and ';', but add 1 for final nul. */ signature++; ptr = result; - for ( ; *signature != ';' && *signature != '\0'; signature++) + for (; *signature != ';' && *signature != '\0'; signature++) { if (*signature == '/') *ptr++ = '.'; @@ -655,7 +743,6 @@ java_demangle_type_signature (signature) default: ptr = TYPE_NAME (java_primitive_type (signature[0])); i = strlen (ptr); - result = xmalloc (i + 1 + 2 * array); strcpy (result, ptr); ptr = result + i; break; @@ -665,38 +752,33 @@ java_demangle_type_signature (signature) *ptr++ = '['; *ptr++ = ']'; } - *ptr = '\0'; - return result; } -struct type * -java_lookup_type (signature) - char *signature; +/* Return the demangled name of the Java type signature string SIGNATURE, + as a freshly allocated copy. */ + +char * +java_demangle_type_signature (char *signature) { - switch (signature[0]) - { - case 'L': - case '[': - error ("java_lookup_type not fully inmplemented"); - default: - return java_primitive_type (signature[0]); - } + int length = java_demangled_signature_length (signature); + char *result = xmalloc (length + 1); + java_demangled_signature_copy (result, signature); + result[length] = '\0'; + return result; } /* Return the type of TYPE followed by DIMS pairs of [ ]. If DIMS == 0, TYPE is returned. */ struct type * -java_array_type (type, dims) - struct type *type; - int dims; +java_array_type (struct type *type, int dims) { struct type *range_type; while (dims-- > 0) { range_type = create_range_type (NULL, builtin_type_int, 0, 0); - + /* FIXME This is bogus! Java arrays are not gdb arrays! */ type = create_array_type (NULL, type, range_type); } @@ -705,12 +787,10 @@ java_array_type (type, dims) /* Create a Java string in the inferior from a (Utf8) literal. */ -value_ptr -java_value_string (ptr, len) - char *ptr; - int len; +static struct value * +java_value_string (char *ptr, int len) { - error ("not implemented - java_value_string"); /* FIXME */ + error (_("not implemented - java_value_string")); /* FIXME */ } /* Print the character C on STREAM as part of the contents of a literal @@ -718,10 +798,7 @@ java_value_string (ptr, len) characters and strings is language specific. */ static void -java_emit_char (c, stream, quoter) - int c; - GDB_FILE *stream; - int quoter; +java_emit_char (int c, struct ui_file *stream, int quoter) { switch (c) { @@ -753,18 +830,16 @@ java_emit_char (c, stream, quoter) } } -static value_ptr -evaluate_subexp_java (expect_type, exp, pos, noside) - struct type *expect_type; - register struct expression *exp; - register int *pos; - enum noside noside; +static struct value * +evaluate_subexp_java (struct type *expect_type, struct expression *exp, + int *pos, enum noside noside) { int pc = *pos; int i; char *name; enum exp_opcode op = exp->elts[*pos].opcode; - value_ptr arg1, arg2; + struct value *arg1; + struct value *arg2; struct type *type; switch (op) { @@ -772,10 +847,12 @@ evaluate_subexp_java (expect_type, exp, pos, noside) if (noside == EVAL_SKIP) goto standard; (*pos)++; - arg1 = evaluate_subexp_standard (expect_type, exp, pos, EVAL_NORMAL); - if (is_object_type (VALUE_TYPE (arg1))) + arg1 = evaluate_subexp_java (NULL_TYPE, exp, pos, EVAL_NORMAL); + if (is_object_type (value_type (arg1))) { - struct type *type = type_from_class (java_class_from_object (arg1)); + struct type *type; + + type = type_from_class (java_class_from_object (arg1)); arg1 = value_cast (lookup_pointer_type (type), arg1); } if (noside == EVAL_SKIP) @@ -789,47 +866,47 @@ evaluate_subexp_java (expect_type, exp, pos, noside) if (noside == EVAL_SKIP) goto nosideret; /* If the user attempts to subscript something that is not an - array or pointer type (like a plain int variable for example), - then report this as an error. */ - - COERCE_REF (arg1); - type = check_typedef (VALUE_TYPE (arg1)); - name = TYPE_NAME (type); + array or pointer type (like a plain int variable for example), + then report this as an error. */ + + arg1 = coerce_ref (arg1); + type = check_typedef (value_type (arg1)); if (TYPE_CODE (type) == TYPE_CODE_PTR) + type = check_typedef (TYPE_TARGET_TYPE (type)); + name = TYPE_NAME (type); + if (name == NULL) + name = TYPE_TAG_NAME (type); + i = name == NULL ? 0 : strlen (name); + if (TYPE_CODE (type) == TYPE_CODE_STRUCT + && i > 2 && name[i - 1] == ']') { - type = check_typedef (TYPE_TARGET_TYPE (type)); - if (TYPE_CODE (type) == TYPE_CODE_STRUCT - && TYPE_TAG_NAME (type) != NULL - && TYPE_TAG_NAME (type)[0] == '[') - { - CORE_ADDR address; - long length, index; - struct type *el_type; - char buf4[4]; - - value_ptr clas = java_class_from_object(arg1); - value_ptr temp = clas; - /* Get CLASS_ELEMENT_TYPE of the array type. */ - temp = value_struct_elt (&temp, NULL, "methods", - NULL, "structure"); - VALUE_TYPE (temp) = VALUE_TYPE (clas); - el_type = type_from_class (temp); - if (TYPE_CODE (el_type) == TYPE_CODE_STRUCT) - el_type = lookup_pointer_type (el_type); - - if (noside == EVAL_AVOID_SIDE_EFFECTS) - return value_zero (el_type, VALUE_LVAL (arg1)); - address = value_as_pointer (arg1); - address += JAVA_OBJECT_SIZE; - read_memory (address, buf4, 4); - length = (long) extract_signed_integer (buf4, 4); - index = (long) value_as_long (arg2); - if (index >= length || index < 0) - error ("array index (%ld) out of bounds (length: %ld)", - index, length); - address = (address + 4) + index * TYPE_LENGTH (el_type); - return value_at (el_type, address, NULL); - } + CORE_ADDR address; + long length, index; + struct type *el_type; + gdb_byte buf4[4]; + + struct value *clas = java_class_from_object (arg1); + struct value *temp = clas; + /* Get CLASS_ELEMENT_TYPE of the array type. */ + temp = value_struct_elt (&temp, NULL, "methods", + NULL, "structure"); + deprecated_set_value_type (temp, value_type (clas)); + el_type = type_from_class (temp); + if (TYPE_CODE (el_type) == TYPE_CODE_STRUCT) + el_type = lookup_pointer_type (el_type); + + if (noside == EVAL_AVOID_SIDE_EFFECTS) + return value_zero (el_type, VALUE_LVAL (arg1)); + address = value_as_address (arg1); + address += JAVA_OBJECT_SIZE; + read_memory (address, buf4, 4); + length = (long) extract_signed_integer (buf4, 4); + index = (long) value_as_long (arg2); + if (index >= length || index < 0) + error (_("array index (%ld) out of bounds (length: %ld)"), + index, length); + address = (address + 4) + index * TYPE_LENGTH (el_type); + return value_at (el_type, address); } else if (TYPE_CODE (type) == TYPE_CODE_ARRAY) { @@ -838,12 +915,10 @@ evaluate_subexp_java (expect_type, exp, pos, noside) else return value_subscript (arg1, arg2); } - if (name == NULL) - name == TYPE_TAG_NAME (type); if (name) - error ("cannot subscript something of type `%s'", name); + error (_("cannot subscript something of type `%s'"), name); else - error ("cannot subscript requested type"); + error (_("cannot subscript requested type")); case OP_STRING: (*pos)++; @@ -856,7 +931,7 @@ evaluate_subexp_java (expect_type, exp, pos, noside) case STRUCTOP_STRUCT: arg1 = evaluate_subexp_standard (expect_type, exp, pos, noside); /* Convert object field (such as TYPE.class) to reference. */ - if (TYPE_CODE (VALUE_TYPE (arg1)) == TYPE_CODE_STRUCT) + if (TYPE_CODE (value_type (arg1)) == TYPE_CODE_STRUCT) arg1 = value_addr (arg1); return arg1; default: @@ -864,79 +939,162 @@ evaluate_subexp_java (expect_type, exp, pos, noside) } standard: return evaluate_subexp_standard (expect_type, exp, pos, noside); - nosideret: +nosideret: return value_from_longest (builtin_type_long, (LONGEST) 1); } static struct type * -java_create_fundamental_type (objfile, typeid) - struct objfile *objfile; - int typeid; +java_create_fundamental_type (struct objfile *objfile, int typeid) { switch (typeid) { - case FT_VOID: return java_void_type; - case FT_BOOLEAN: return java_boolean_type; - case FT_CHAR: return java_char_type; - case FT_FLOAT: return java_float_type; - case FT_DBL_PREC_FLOAT: return java_double_type; - case FT_BYTE: case FT_SIGNED_CHAR: return java_byte_type; - case FT_SHORT: case FT_SIGNED_SHORT: return java_short_type; - case FT_INTEGER: case FT_SIGNED_INTEGER: return java_int_type; - case FT_LONG: case FT_SIGNED_LONG: return java_long_type; + case FT_VOID: + return java_void_type; + case FT_BOOLEAN: + return java_boolean_type; + case FT_CHAR: + return java_char_type; + case FT_FLOAT: + return java_float_type; + case FT_DBL_PREC_FLOAT: + return java_double_type; + case FT_BYTE: + case FT_SIGNED_CHAR: + return java_byte_type; + case FT_SHORT: + case FT_SIGNED_SHORT: + return java_short_type; + case FT_INTEGER: + case FT_SIGNED_INTEGER: + return java_int_type; + case FT_LONG: + case FT_SIGNED_LONG: + return java_long_type; } return c_create_fundamental_type (objfile, typeid); } +static char *java_demangle (const char *mangled, int options) +{ + return cplus_demangle (mangled, options | DMGL_JAVA); +} + +/* Find the member function name of the demangled name NAME. NAME + must be a method name including arguments, in order to correctly + locate the last component. + + This function return a pointer to the first dot before the + member function name, or NULL if the name was not of the + expected form. */ + +static const char * +java_find_last_component (const char *name) +{ + const char *p; + + /* Find argument list. */ + p = strchr (name, '('); + + if (p == NULL) + return NULL; + + /* Back up and find first dot prior to argument list. */ + while (p > name && *p != '.') + p--; + + if (p == name) + return NULL; + + return p; +} + +/* Return the name of the class containing method PHYSNAME. */ + +static char * +java_class_name_from_physname (const char *physname) +{ + char *ret = NULL; + const char *end; + int depth = 0; + char *demangled_name = java_demangle (physname, DMGL_PARAMS | DMGL_ANSI); + + if (demangled_name == NULL) + return NULL; + + end = java_find_last_component (demangled_name); + if (end != NULL) + { + ret = xmalloc (end - demangled_name + 1); + memcpy (ret, demangled_name, end - demangled_name); + ret[end - demangled_name] = '\0'; + } + + xfree (demangled_name); + return ret; +} + /* Table mapping opcodes into strings for printing operators and precedences of the operators. */ const struct op_print java_op_print_tab[] = - { - {",", BINOP_COMMA, PREC_COMMA, 0}, - {"=", BINOP_ASSIGN, PREC_ASSIGN, 1}, - {"||", BINOP_LOGICAL_OR, PREC_LOGICAL_OR, 0}, - {"&&", BINOP_LOGICAL_AND, PREC_LOGICAL_AND, 0}, - {"|", BINOP_BITWISE_IOR, PREC_BITWISE_IOR, 0}, - {"^", BINOP_BITWISE_XOR, PREC_BITWISE_XOR, 0}, - {"&", BINOP_BITWISE_AND, PREC_BITWISE_AND, 0}, - {"==", BINOP_EQUAL, PREC_EQUAL, 0}, - {"!=", BINOP_NOTEQUAL, PREC_EQUAL, 0}, - {"<=", BINOP_LEQ, PREC_ORDER, 0}, - {">=", BINOP_GEQ, PREC_ORDER, 0}, - {">", BINOP_GTR, PREC_ORDER, 0}, - {"<", BINOP_LESS, PREC_ORDER, 0}, - {">>", BINOP_RSH, PREC_SHIFT, 0}, - {"<<", BINOP_LSH, PREC_SHIFT, 0}, +{ + {",", BINOP_COMMA, PREC_COMMA, 0}, + {"=", BINOP_ASSIGN, PREC_ASSIGN, 1}, + {"||", BINOP_LOGICAL_OR, PREC_LOGICAL_OR, 0}, + {"&&", BINOP_LOGICAL_AND, PREC_LOGICAL_AND, 0}, + {"|", BINOP_BITWISE_IOR, PREC_BITWISE_IOR, 0}, + {"^", BINOP_BITWISE_XOR, PREC_BITWISE_XOR, 0}, + {"&", BINOP_BITWISE_AND, PREC_BITWISE_AND, 0}, + {"==", BINOP_EQUAL, PREC_EQUAL, 0}, + {"!=", BINOP_NOTEQUAL, PREC_EQUAL, 0}, + {"<=", BINOP_LEQ, PREC_ORDER, 0}, + {">=", BINOP_GEQ, PREC_ORDER, 0}, + {">", BINOP_GTR, PREC_ORDER, 0}, + {"<", BINOP_LESS, PREC_ORDER, 0}, + {">>", BINOP_RSH, PREC_SHIFT, 0}, + {"<<", BINOP_LSH, PREC_SHIFT, 0}, #if 0 - {">>>", BINOP_???, PREC_SHIFT, 0}, + {">>>", BINOP_ ? ? ?, PREC_SHIFT, 0}, #endif - {"+", BINOP_ADD, PREC_ADD, 0}, - {"-", BINOP_SUB, PREC_ADD, 0}, - {"*", BINOP_MUL, PREC_MUL, 0}, - {"/", BINOP_DIV, PREC_MUL, 0}, - {"%", BINOP_REM, PREC_MUL, 0}, - {"-", UNOP_NEG, PREC_PREFIX, 0}, - {"!", UNOP_LOGICAL_NOT, PREC_PREFIX, 0}, - {"~", UNOP_COMPLEMENT, PREC_PREFIX, 0}, - {"*", UNOP_IND, PREC_PREFIX, 0}, + {"+", BINOP_ADD, PREC_ADD, 0}, + {"-", BINOP_SUB, PREC_ADD, 0}, + {"*", BINOP_MUL, PREC_MUL, 0}, + {"/", BINOP_DIV, PREC_MUL, 0}, + {"%", BINOP_REM, PREC_MUL, 0}, + {"-", UNOP_NEG, PREC_PREFIX, 0}, + {"!", UNOP_LOGICAL_NOT, PREC_PREFIX, 0}, + {"~", UNOP_COMPLEMENT, PREC_PREFIX, 0}, + {"*", UNOP_IND, PREC_PREFIX, 0}, #if 0 - {"instanceof", ???, ???, 0}, + {"instanceof", ? ? ?, ? ? ?, 0}, #endif - {"++", UNOP_PREINCREMENT, PREC_PREFIX, 0}, - {"--", UNOP_PREDECREMENT, PREC_PREFIX, 0}, - {NULL, 0, 0, 0} + {"++", UNOP_PREINCREMENT, PREC_PREFIX, 0}, + {"--", UNOP_PREDECREMENT, PREC_PREFIX, 0}, + {NULL, 0, 0, 0} }; -const struct language_defn java_language_defn = { - "java", /* Language name */ +const struct exp_descriptor exp_descriptor_java = +{ + print_subexp_standard, + operator_length_standard, + op_name_standard, + dump_subexp_body_standard, + evaluate_subexp_java +}; + +const struct language_defn java_language_defn = +{ + "java", /* Language name */ language_java, - c_builtin_types, + NULL, range_check_off, type_check_off, + case_sensitive_on, + array_row_major, + &exp_descriptor_java, java_parse, java_error, - evaluate_subexp_java, + null_post_parser, c_printchar, /* Print a character constant */ c_printstr, /* Function to print string constant */ java_emit_char, /* Function to print a single character */ @@ -944,30 +1102,34 @@ const struct language_defn java_language_defn = { java_print_type, /* Print a type using appropriate syntax */ java_val_print, /* Print a value using appropriate syntax */ java_value_print, /* Print a top-level value */ - {"", "", "", ""}, /* Binary format info */ - {"0%lo", "0", "o", ""}, /* Octal format info */ - {"%ld", "", "d", ""}, /* Decimal format info */ - {"0x%lx", "0x", "x", ""}, /* Hex format info */ + NULL, /* Language specific skip_trampoline */ + value_of_this, /* value_of_this */ + basic_lookup_symbol_nonlocal, /* lookup_symbol_nonlocal */ + basic_lookup_transparent_type,/* lookup_transparent_type */ + java_demangle, /* Language specific symbol demangler */ + java_class_name_from_physname,/* Language specific class name */ java_op_print_tab, /* expression operators for printing */ 0, /* not c-style arrays */ 0, /* String lower bound */ - &builtin_type_char, /* Type of string elements */ + NULL, + default_word_break_characters, + c_language_arch_info, LANG_MAGIC }; void -_initialize_java_language () +_initialize_java_language (void) { - java_int_type = init_type (TYPE_CODE_INT, 4, 0, "int", NULL); - java_short_type = init_type (TYPE_CODE_INT, 2, 0, "short", NULL); - java_long_type = init_type (TYPE_CODE_INT, 8, 0, "long", NULL); - java_byte_type = init_type (TYPE_CODE_INT, 1, 0, "byte", NULL); - java_boolean_type= init_type (TYPE_CODE_BOOL, 1, 0, "boolean", NULL); - java_char_type = init_type (TYPE_CODE_CHAR, 2, 0, "char", NULL); - java_float_type = init_type (TYPE_CODE_FLT, 4, 0, "float", NULL); - java_double_type = init_type (TYPE_CODE_FLT, 8, 0, "double", NULL); - java_void_type = init_type (TYPE_CODE_VOID, 1, 0, "void", NULL); + java_int_type = init_type (TYPE_CODE_INT, 4, 0, "int", NULL); + java_short_type = init_type (TYPE_CODE_INT, 2, 0, "short", NULL); + java_long_type = init_type (TYPE_CODE_INT, 8, 0, "long", NULL); + java_byte_type = init_type (TYPE_CODE_INT, 1, 0, "byte", NULL); + java_boolean_type = init_type (TYPE_CODE_BOOL, 1, 0, "boolean", NULL); + java_char_type = init_type (TYPE_CODE_CHAR, 2, TYPE_FLAG_UNSIGNED, "char", NULL); + java_float_type = init_type (TYPE_CODE_FLT, 4, 0, "float", NULL); + java_double_type = init_type (TYPE_CODE_FLT, 8, 0, "double", NULL); + java_void_type = init_type (TYPE_CODE_VOID, 1, 0, "void", NULL); add_language (&java_language_defn); } @@ -976,11 +1138,13 @@ _initialize_java_language () We should use make_run_cleanup to have this be called. But will that mess up values in value histry? FIXME */ -void java_rerun_cleanup () +extern void java_rerun_cleanup (void); +void +java_rerun_cleanup (void) { if (class_symtab != NULL) { - free_symtab (class_symtab); /* ??? */ + free_symtab (class_symtab); /* ??? */ class_symtab = NULL; } if (dynamics_objfile != NULL)