X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fmonitor.c;h=0ed6f3de2d77017951609f98aac18d321202dc10;hb=264b62058b585d4bee3ef4ffa804fce7400df80e;hp=d1a48f27dd6ba2f18f65f03332ded7a20703a4ae;hpb=2cd58942b9bf50ccde261085d8a2b3e7ced88e5e;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/monitor.c b/gdb/monitor.c index d1a48f27dd..0ed6f3de2d 100644 --- a/gdb/monitor.c +++ b/gdb/monitor.c @@ -1,6 +1,8 @@ /* Remote debugging interface for boot monitors, for GDB. - Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, - 2000, 2001 Free Software Foundation, Inc. + + Copyright (C) 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, + 2000, 2001, 2002, 2006, 2007 Free Software Foundation, Inc. + Contributed by Cygnus Support. Written by Rob Savoye for Cygnus. Resurrected from the ashes by Stu Grossman. @@ -18,8 +20,8 @@ You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place - Suite 330, - Boston, MA 02111-1307, USA. */ + Foundation, Inc., 51 Franklin Street, Fifth Floor, + Boston, MA 02110-1301, USA. */ /* This file was derived from various remote-* modules. It is a collection of generic support functions so GDB can talk directly to a ROM based @@ -41,6 +43,7 @@ #include "defs.h" #include "gdbcore.h" #include "target.h" +#include "exceptions.h" #include #include #include "gdb_string.h" @@ -57,51 +60,14 @@ static char *dev_name; static struct target_ops *targ_ops; -static void monitor_vsprintf (char *sndbuf, char *pattern, va_list args); - -static int readchar (int timeout); - -static void monitor_fetch_register (int regno); -static void monitor_store_register (int regno); - -static void monitor_printable_string (char *newstr, char *oldstr, int len); -static void monitor_error (char *function, char *message, CORE_ADDR memaddr, int len, char *string, int final_char); -static void monitor_detach (char *args, int from_tty); -static void monitor_resume (ptid_t ptid, int step, enum target_signal sig); -static void monitor_interrupt (int signo); -static void monitor_interrupt_twice (int signo); static void monitor_interrupt_query (void); -static void monitor_wait_cleanup (void *old_timeout); - -static ptid_t monitor_wait (ptid_t ptid, struct target_waitstatus *status); -static void monitor_fetch_registers (int regno); -static void monitor_store_registers (int regno); -static void monitor_prepare_to_store (void); -static int monitor_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, - int write, - struct mem_attrib *attrib, - struct target_ops *target); -static void monitor_files_info (struct target_ops *ops); -static int monitor_insert_breakpoint (CORE_ADDR addr, char *shadow); -static int monitor_remove_breakpoint (CORE_ADDR addr, char *shadow); -static void monitor_kill (void); -static void monitor_load (char *file, int from_tty); -static void monitor_mourn_inferior (void); +static void monitor_interrupt_twice (int); static void monitor_stop (void); - -static int monitor_read_memory (CORE_ADDR addr, char *myaddr, int len); -static int monitor_write_memory (CORE_ADDR addr, char *myaddr, int len); -static int monitor_write_memory_bytes (CORE_ADDR addr, char *myaddr, int len); -static int monitor_write_memory_block (CORE_ADDR memaddr, - char *myaddr, int len); -static int monitor_expect_regexp (struct re_pattern_buffer *pat, - char *buf, int buflen); static void monitor_dump_regs (void); + #if 0 static int from_hex (int a); -static unsigned long get_hex_word (void); #endif -static void parse_register_dump (char *, int); static struct monitor_ops *current_monitor; @@ -151,7 +117,7 @@ static void monitor_debug (const char *fmt, ...) ATTR_FORMAT(printf, 1, 2); static int monitor_debug_p = 0; /* NOTE: This file alternates between monitor_debug_p and remote_debug - when determining if debug information is printed. Perhaphs this + when determining if debug information is printed. Perhaps this could be simplified. */ static void @@ -242,9 +208,9 @@ monitor_error (char *function, char *message, monitor_printable_string (safe_string, string, real_len); if (final_char) - error ("%s (0x%s): %s: %s%c", function, paddr_nz (memaddr), message, safe_string, final_char); + error (_("%s (0x%s): %s: %s%c"), function, paddr_nz (memaddr), message, safe_string, final_char); else - error ("%s (0x%s): %s: %s", function, paddr_nz (memaddr), message, safe_string); + error (_("%s (0x%s): %s: %s"), function, paddr_nz (memaddr), message, safe_string); } /* Convert hex digit A to a number. */ @@ -259,7 +225,7 @@ fromhex (int a) else if (a >= 'A' && a <= 'F') return a - 'A' + 10; else - error ("Invalid hex digit %d", a); + error (_("Invalid hex digit %d"), a); } /* monitor_vsprintf - similar to vsprintf but handles 64-bit addresses @@ -343,7 +309,7 @@ monitor_printf_noecho (char *pattern,...) len = strlen (sndbuf); if (len + 1 > sizeof sndbuf) - internal_error (__FILE__, __LINE__, "failed internal consistency check"); + internal_error (__FILE__, __LINE__, _("failed internal consistency check")); if (monitor_debug_p) { @@ -371,7 +337,7 @@ monitor_printf (char *pattern,...) len = strlen (sndbuf); if (len + 1 > sizeof sndbuf) - internal_error (__FILE__, __LINE__, "failed internal consistency check"); + internal_error (__FILE__, __LINE__, _("failed internal consistency check")); if (monitor_debug_p) { @@ -426,9 +392,9 @@ monitor_readchar (void) return c; if (c == SERIAL_TIMEOUT) - error ("Timeout reading from remote system."); + error (_("Timeout reading from remote system.")); - perror_with_name ("remote-monitor"); + perror_with_name (_("remote-monitor")); } @@ -497,13 +463,13 @@ readchar (int timeout) if (in_monitor_wait) /* Watchdog went off */ { target_mourn_inferior (); - error ("GDB serial timeout has expired. Target detached.\n"); + error (_("GDB serial timeout has expired. Target detached.")); } else #endif - error ("Timeout reading from remote system."); + error (_("Timeout reading from remote system.")); - perror_with_name ("remote-monitor"); + perror_with_name (_("remote-monitor")); } /* Scan input from the remote system, until STRING is found. If BUF is non- @@ -519,7 +485,6 @@ monitor_expect (char *string, char *buf, int buflen) char *p = string; int obuflen = buflen; int c; - extern struct target_ops *targ_ops; if (monitor_debug_p) { @@ -567,12 +532,6 @@ monitor_expect (char *string, char *buf, int buflen) return 0; } } - else if ((c == '\021' || c == '\023') && - (STREQ (targ_ops->to_shortname, "m32r") - || STREQ (targ_ops->to_shortname, "mon2000"))) - { /* m32r monitor emits random DC1/DC3 chars */ - continue; - } else { /* We got a character that doesn't match the string. We need to @@ -721,7 +680,7 @@ compile_pattern (char *pattern, struct re_pattern_buffer *compiled_pattern, re_set_syntax (tmp); if (val) - error ("compile_pattern: Can't compile pattern string `%s': %s!", pattern, val); + error (_("compile_pattern: Can't compile pattern string `%s': %s!"), pattern, val); if (fastmap) re_compile_fastmap (compiled_pattern); @@ -737,14 +696,14 @@ monitor_open (char *args, struct monitor_ops *mon_ops, int from_tty) char **p; if (mon_ops->magic != MONITOR_OPS_MAGIC) - error ("Magic number of monitor_ops struct wrong."); + error (_("Magic number of monitor_ops struct wrong.")); targ_ops = mon_ops->target; name = targ_ops->to_shortname; if (!args) - error ("Use `target %s DEVICE-NAME' to use a serial port, or \n\ -`target %s HOST-NAME:PORT-NUMBER' to use a network connection.", name, name); + error (_("Use `target %s DEVICE-NAME' to use a serial port, or \n\ +`target %s HOST-NAME:PORT-NUMBER' to use a network connection."), name, name); target_preopen (from_tty); @@ -843,7 +802,7 @@ monitor_open (char *args, struct monitor_ops *mon_ops, int from_tty) } if (from_tty) - printf_unfiltered ("Remote target %s connected to %s\n", name, dev_name); + printf_unfiltered (_("Remote target %s connected to %s\n"), name, dev_name); push_target (targ_ops); @@ -853,7 +812,7 @@ monitor_open (char *args, struct monitor_ops *mon_ops, int from_tty) monitor_printf (current_monitor->line_term); - start_remote (); + start_remote (from_tty); } /* Close out all files and local state before this target loses @@ -883,7 +842,7 @@ monitor_detach (char *args, int from_tty) { pop_target (); /* calls monitor_close to do the real work */ if (from_tty) - printf_unfiltered ("Ending remote %s debugging\n", target_shortname); + printf_unfiltered (_("Ending remote %s debugging\n"), target_shortname); } /* Convert VALSTR into the target byte-ordered value of REGNO and store it. */ @@ -892,7 +851,7 @@ char * monitor_supply_register (int regno, char *valstr) { ULONGEST val; - unsigned char regbuf[MAX_REGISTER_RAW_SIZE]; + unsigned char regbuf[MAX_REGISTER_SIZE]; char *p; val = 0; @@ -921,14 +880,14 @@ monitor_supply_register (int regno, char *valstr) monitor_debug ("Supplying Register %d %s\n", regno, valstr); if (val == 0 && valstr == p) - error ("monitor_supply_register (%d): bad value from monitor: %s.", + error (_("monitor_supply_register (%d): bad value from monitor: %s."), regno, valstr); /* supply register stores in target byte order, so swap here */ - store_unsigned_integer (regbuf, REGISTER_RAW_SIZE (regno), val); + store_unsigned_integer (regbuf, register_size (current_gdbarch, regno), val); - supply_register (regno, regbuf); + regcache_raw_supply (current_regcache, regno, regbuf); return p; } @@ -1034,7 +993,7 @@ monitor_interrupt_query (void) Give up (and stop debugging it)? ")) { target_mourn_inferior (); - return_to_top_level (RETURN_QUIT); + deprecated_throw_reason (RETURN_QUIT); } target_terminal_inferior (); @@ -1050,12 +1009,11 @@ monitor_wait_cleanup (void *old_timeout) -void +static void monitor_wait_filter (char *buf, int bufmax, int *ext_resp_len, - struct target_waitstatus *status -) + struct target_waitstatus *status) { int resp_len; do @@ -1172,22 +1130,25 @@ monitor_wait (ptid_t ptid, struct target_waitstatus *status) static void monitor_fetch_register (int regno) { - char *name; + const char *name; char *zerobuf; char *regbuf; int i; - regbuf = alloca (MAX_REGISTER_RAW_SIZE * 2 + 1); - zerobuf = alloca (MAX_REGISTER_RAW_SIZE); - memset (zerobuf, 0, MAX_REGISTER_RAW_SIZE); + regbuf = alloca (MAX_REGISTER_SIZE * 2 + 1); + zerobuf = alloca (MAX_REGISTER_SIZE); + memset (zerobuf, 0, MAX_REGISTER_SIZE); - name = current_monitor->regnames[regno]; + if (current_monitor->regname != NULL) + name = current_monitor->regname (regno); + else + name = current_monitor->regnames[regno]; monitor_debug ("MON fetchreg %d '%s'\n", regno, name ? name : "(null name)"); if (!name || (*name == '\0')) { monitor_debug ("No register known for %d\n", regno); - supply_register (regno, zerobuf); + regcache_raw_supply (current_regcache, regno, zerobuf); return; } @@ -1222,7 +1183,7 @@ monitor_fetch_register (int regno) if ((c == '0') && ((c = readchar (timeout)) == 'x')) ; else - error ("Bad value returned from monitor while fetching register %x.", + error (_("Bad value returned from monitor while fetching register %x."), regno); } @@ -1230,7 +1191,7 @@ monitor_fetch_register (int regno) spaces, but stop reading if something else is seen. Some monitors like to drop leading zeros. */ - for (i = 0; i < REGISTER_RAW_SIZE (regno) * 2; i++) + for (i = 0; i < register_size (current_gdbarch, regno) * 2; i++) { int c; c = readchar (timeout); @@ -1302,7 +1263,7 @@ monitor_dump_regs (void) parse_register_dump (buf, resp_len); } else - internal_error (__FILE__, __LINE__, "failed internal consistency check"); /* Need some way to read registers */ + internal_error (__FILE__, __LINE__, _("failed internal consistency check")); /* Need some way to read registers */ } static void @@ -1331,10 +1292,14 @@ monitor_fetch_registers (int regno) static void monitor_store_register (int regno) { - char *name; + const char *name; ULONGEST val; - - name = current_monitor->regnames[regno]; + + if (current_monitor->regname != NULL) + name = current_monitor->regname (regno); + else + name = current_monitor->regnames[regno]; + if (!name || (*name == '\0')) { monitor_debug ("MON Cannot store unknown register\n"); @@ -1343,7 +1308,7 @@ monitor_store_register (int regno) val = read_register (regno); monitor_debug ("MON storeg %d %s\n", regno, - phex (val, REGISTER_RAW_SIZE (regno))); + phex (val, register_size (current_gdbarch, regno))); /* send the register deposit command */ @@ -1409,7 +1374,7 @@ monitor_prepare_to_store (void) static void monitor_files_info (struct target_ops *ops) { - printf_unfiltered ("\tAttached to %s at %d baud.\n", dev_name, baud_rate); + printf_unfiltered (_("\tAttached to %s at %d baud.\n"), dev_name, baud_rate); } static int @@ -1514,33 +1479,6 @@ monitor_write_memory (CORE_ADDR memaddr, char *myaddr, int len) } -static int -monitor_write_even_block (CORE_ADDR memaddr, char *myaddr, int len) -{ - unsigned int val; - int written = 0;; - /* Enter the sub mode */ - monitor_printf (current_monitor->setmem.cmdl, memaddr); - monitor_expect_prompt (NULL, 0); - - while (len) - { - val = extract_unsigned_integer (myaddr, 4); /* REALLY */ - monitor_printf ("%x\r", val); - myaddr += 4; - memaddr += 4; - written += 4; - monitor_debug (" @ %s\n", paddr (memaddr)); - /* If we wanted to, here we could validate the address */ - monitor_expect_prompt (NULL, 0); - } - /* Now exit the sub mode */ - monitor_printf (current_monitor->getreg.term_cmd); - monitor_expect_prompt (NULL, 0); - return written; -} - - static int monitor_write_memory_bytes (CORE_ADDR memaddr, char *myaddr, int len) { @@ -1692,17 +1630,6 @@ monitor_write_memory_block (CORE_ADDR memaddr, char *myaddr, int len) { return monitor_write_memory_longlongs (memaddr, myaddr, len); } -#endif -#if 0 - if (len > 4) - { - int sublen; - written = monitor_write_even_block (memaddr, myaddr, len); - /* Adjust calling parameters by written amount */ - memaddr += written; - myaddr += written; - len -= written; - } #endif written = monitor_write_memory_bytes (memaddr, myaddr, len); return written; @@ -1972,7 +1899,7 @@ monitor_read_memory (CORE_ADDR memaddr, char *myaddr, int len) c = *p; } if (fetched == 0) - error ("Failed to read via monitor"); + error (_("Failed to read via monitor")); if (monitor_debug_p || remote_debug) fprintf_unfiltered (gdb_stdlog, "\n"); return fetched; /* Return the number of bytes actually read */ @@ -2018,9 +1945,8 @@ monitor_read_memory (CORE_ADDR memaddr, char *myaddr, int len) unused. */ static int -monitor_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write, - struct mem_attrib *attrib ATTRIBUTE_UNUSED, - struct target_ops *target ATTRIBUTE_UNUSED) +monitor_xfer_memory (CORE_ADDR memaddr, gdb_byte *myaddr, int len, int write, + struct mem_attrib *attrib, struct target_ops *target) { int res; @@ -2045,18 +1971,18 @@ monitor_kill (void) return; /* ignore attempts to kill target system */ } -/* All we actually do is set the PC to the start address of exec_bfd, and start - the program at that point. */ +/* All we actually do is set the PC to the start address of exec_bfd. */ static void -monitor_create_inferior (char *exec_file, char *args, char **env) +monitor_create_inferior (char *exec_file, char *args, char **env, + int from_tty) { if (args && (*args != '\000')) - error ("Args are not supported by the monitor."); + error (_("Args are not supported by the monitor.")); first_time = 1; clear_proceed_status (); - proceed (bfd_get_start_address (exec_bfd), TARGET_SIGNAL_0, 0); + write_pc (bfd_get_start_address (exec_bfd)); } /* Clean up when a program exits. @@ -2074,50 +2000,50 @@ monitor_mourn_inferior (void) /* Tell the monitor to add a breakpoint. */ static int -monitor_insert_breakpoint (CORE_ADDR addr, char *shadow) +monitor_insert_breakpoint (struct bp_target_info *bp_tgt) { + CORE_ADDR addr = bp_tgt->placed_address; int i; - unsigned char *bp; + const unsigned char *bp; int bplen; monitor_debug ("MON inst bkpt %s\n", paddr (addr)); if (current_monitor->set_break == NULL) - error ("No set_break defined for this monitor"); + error (_("No set_break defined for this monitor")); if (current_monitor->flags & MO_ADDR_BITS_REMOVE) addr = ADDR_BITS_REMOVE (addr); /* Determine appropriate breakpoint size for this address. */ - bp = memory_breakpoint_from_pc (&addr, &bplen); + bp = gdbarch_breakpoint_from_pc (current_gdbarch, &addr, &bplen); + bp_tgt->placed_address = addr; + bp_tgt->placed_size = bplen; for (i = 0; i < current_monitor->num_breakpoints; i++) { if (breakaddr[i] == 0) { breakaddr[i] = addr; - monitor_read_memory (addr, shadow, bplen); monitor_printf (current_monitor->set_break, addr); monitor_expect_prompt (NULL, 0); return 0; } } - error ("Too many breakpoints (> %d) for monitor.", current_monitor->num_breakpoints); + error (_("Too many breakpoints (> %d) for monitor."), current_monitor->num_breakpoints); } /* Tell the monitor to remove a breakpoint. */ static int -monitor_remove_breakpoint (CORE_ADDR addr, char *shadow) +monitor_remove_breakpoint (struct bp_target_info *bp_tgt) { + CORE_ADDR addr = bp_tgt->placed_address; int i; monitor_debug ("MON rmbkpt %s\n", paddr (addr)); if (current_monitor->clr_break == NULL) - error ("No clr_break defined for this monitor"); - - if (current_monitor->flags & MO_ADDR_BITS_REMOVE) - addr = ADDR_BITS_REMOVE (addr); + error (_("No clr_break defined for this monitor")); for (i = 0; i < current_monitor->num_breakpoints; i++) { @@ -2202,20 +2128,23 @@ monitor_load (char *file, int from_tty) monitor_expect_prompt (NULL, 0); } -/* Finally, make the PC point at the start address */ - + /* Finally, make the PC point at the start address */ if (exec_bfd) write_pc (bfd_get_start_address (exec_bfd)); - inferior_ptid = null_ptid ; /* No process now */ - -/* This is necessary because many things were based on the PC at the time that - we attached to the monitor, which is no longer valid now that we have loaded - new code (and just changed the PC). Another way to do this might be to call - normal_stop, except that the stack may not be valid, and things would get - horribly confused... */ - - clear_symtab_users (); + /* There used to be code here which would clear inferior_ptid and + call clear_symtab_users. None of that should be necessary: + monitor targets should behave like remote protocol targets, and + since generic_load does none of those things, this function + shouldn't either. + + Furthermore, clearing inferior_ptid is *incorrect*. After doing + a load, we still have a valid connection to the monitor, with a + live processor state to fiddle with. The user can type + `continue' or `jump *start' and make the program run. If they do + these things, however, GDB will be talking to a running program + while inferior_ptid is null_ptid; this makes things like + reinit_frame_cache very confused. */ } static void @@ -2241,7 +2170,7 @@ monitor_rcmd (char *command, char buf[1000]; if (monitor_desc == NULL) - error ("monitor target not open."); + error (_("monitor target not open.")); p = current_monitor->prompt; @@ -2268,7 +2197,7 @@ from_hex (int a) if (a >= 'A' && a <= 'F') return a - 'A' + 10; - error ("Reply contains invalid hex digit 0x%x", a); + error (_("Reply contains invalid hex digit 0x%x"), a); } #endif @@ -2283,68 +2212,29 @@ static struct target_ops monitor_ops; static void init_base_monitor_ops (void) { - monitor_ops.to_shortname = NULL; - monitor_ops.to_longname = NULL; - monitor_ops.to_doc = NULL; - monitor_ops.to_open = NULL; monitor_ops.to_close = monitor_close; - monitor_ops.to_attach = NULL; - monitor_ops.to_post_attach = NULL; - monitor_ops.to_require_attach = NULL; monitor_ops.to_detach = monitor_detach; - monitor_ops.to_require_detach = NULL; monitor_ops.to_resume = monitor_resume; monitor_ops.to_wait = monitor_wait; - monitor_ops.to_post_wait = NULL; monitor_ops.to_fetch_registers = monitor_fetch_registers; monitor_ops.to_store_registers = monitor_store_registers; monitor_ops.to_prepare_to_store = monitor_prepare_to_store; - monitor_ops.to_xfer_memory = monitor_xfer_memory; + monitor_ops.deprecated_xfer_memory = monitor_xfer_memory; monitor_ops.to_files_info = monitor_files_info; monitor_ops.to_insert_breakpoint = monitor_insert_breakpoint; monitor_ops.to_remove_breakpoint = monitor_remove_breakpoint; - monitor_ops.to_terminal_init = 0; - monitor_ops.to_terminal_inferior = 0; - monitor_ops.to_terminal_ours_for_output = 0; - monitor_ops.to_terminal_ours = 0; - monitor_ops.to_terminal_info = 0; monitor_ops.to_kill = monitor_kill; monitor_ops.to_load = monitor_load; - monitor_ops.to_lookup_symbol = 0; monitor_ops.to_create_inferior = monitor_create_inferior; - monitor_ops.to_post_startup_inferior = NULL; - monitor_ops.to_acknowledge_created_inferior = NULL; - monitor_ops.to_clone_and_follow_inferior = NULL; - monitor_ops.to_post_follow_inferior_by_clone = NULL; - monitor_ops.to_insert_fork_catchpoint = NULL; - monitor_ops.to_remove_fork_catchpoint = NULL; - monitor_ops.to_insert_vfork_catchpoint = NULL; - monitor_ops.to_remove_vfork_catchpoint = NULL; - monitor_ops.to_has_forked = NULL; - monitor_ops.to_has_vforked = NULL; - monitor_ops.to_can_follow_vfork_prior_to_exec = NULL; - monitor_ops.to_post_follow_vfork = NULL; - monitor_ops.to_insert_exec_catchpoint = NULL; - monitor_ops.to_remove_exec_catchpoint = NULL; - monitor_ops.to_has_execd = NULL; - monitor_ops.to_reported_exec_events_per_exec_call = NULL; - monitor_ops.to_has_exited = NULL; monitor_ops.to_mourn_inferior = monitor_mourn_inferior; - monitor_ops.to_can_run = 0; - monitor_ops.to_notice_signals = 0; - monitor_ops.to_thread_alive = 0; monitor_ops.to_stop = monitor_stop; monitor_ops.to_rcmd = monitor_rcmd; - monitor_ops.to_pid_to_exec_file = NULL; monitor_ops.to_stratum = process_stratum; - monitor_ops.DONT_USE = 0; monitor_ops.to_has_all_memory = 1; monitor_ops.to_has_memory = 1; monitor_ops.to_has_stack = 1; monitor_ops.to_has_registers = 1; monitor_ops.to_has_execution = 1; - monitor_ops.to_sections = 0; - monitor_ops.to_sections_end = 0; monitor_ops.to_magic = OPS_MAGIC; } /* init_base_monitor_ops */ @@ -2361,22 +2251,26 @@ init_monitor_ops (struct target_ops *ops) /* Define additional commands that are usually only used by monitors. */ +extern initialize_file_ftype _initialize_remote_monitors; /* -Wmissing-prototypes */ + void _initialize_remote_monitors (void) { init_base_monitor_ops (); - add_show_from_set (add_set_cmd ("hash", no_class, var_boolean, - (char *) &hashmark, - "Set display of activity while downloading a file.\n\ -When enabled, a hashmark \'#\' is displayed.", - &setlist), - &showlist); - - add_show_from_set - (add_set_cmd ("monitor", no_class, var_zinteger, - (char *) &monitor_debug_p, - "Set debugging of remote monitor communication.\n\ + add_setshow_boolean_cmd ("hash", no_class, &hashmark, _("\ +Set display of activity while downloading a file."), _("\ +Show display of activity while downloading a file."), _("\ +When enabled, a hashmark \'#\' is displayed."), + NULL, + NULL, /* FIXME: i18n: */ + &setlist, &showlist); + + add_setshow_zinteger_cmd ("monitor", no_class, &monitor_debug_p, _("\ +Set debugging of remote monitor communication."), _("\ +Show debugging of remote monitor communication."), _("\ When enabled, communication between GDB and the remote monitor\n\ -is displayed.", &setdebuglist), - &showdebuglist); +is displayed."), + NULL, + NULL, /* FIXME: i18n: */ + &setdebuglist, &showdebuglist); }