X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fobjfiles.c;h=b881645d43dc4fbff6a91cbb0c91aa386163733e;hb=35df450089f1876a8645a5ebf443a7c76367fcce;hp=8f141b315bec21604351ce97ad7bcb09b0399d31;hpb=fe898f56a1df2d8a610899df50e38d1590f3e57a;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 8f141b315b..b881645d43 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -1,7 +1,7 @@ /* GDB routines for manipulating objfiles. - Copyright 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, - 2001, 2002, 2003 Free Software Foundation, Inc. + Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, + 2002, 2003, 2004, 2007, 2008, 2009, 2010 Free Software Foundation, Inc. Contributed by Cygnus Support, using pieces from other GDB modules. @@ -9,7 +9,7 @@ This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or + the Free Software Foundation; either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, @@ -18,9 +18,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place - Suite 330, - Boston, MA 02111-1307, USA. */ + along with this program. If not, see . */ /* This file contains support routines for creating, manipulating, and destroying objfile structures. */ @@ -33,7 +31,11 @@ #include "gdb-stabs.h" #include "target.h" #include "bcache.h" +#include "mdebugread.h" +#include "expression.h" +#include "parser-defs.h" +#include "gdb_assert.h" #include #include "gdb_stat.h" #include @@ -43,48 +45,83 @@ #include "breakpoint.h" #include "block.h" +#include "dictionary.h" +#include "source.h" +#include "addrmap.h" +#include "arch-utils.h" +#include "exec.h" +#include "observer.h" +#include "complaints.h" +#include "psymtab.h" +#include "solist.h" /* Prototypes for local functions */ -#if defined(USE_MMALLOC) && defined(HAVE_MMAP) +static void objfile_alloc_data (struct objfile *objfile); +static void objfile_free_data (struct objfile *objfile); -#include "mmalloc.h" +/* Externally visible variables that are owned by this module. + See declarations in objfile.h for more info. */ -static int open_existing_mapped_file (char *, long, int); +struct objfile *current_objfile; /* For symbol file being read in */ +struct objfile *rt_common_objfile; /* For runtime common symbols */ -static int open_mapped_file (char *filename, long mtime, int flags); +struct objfile_pspace_info +{ + int objfiles_changed_p; + struct obj_section **sections; + int num_sections; +}; -static void *map_to_file (int); +/* Per-program-space data key. */ +static const struct program_space_data *objfiles_pspace_data; -#endif /* defined(USE_MMALLOC) && defined(HAVE_MMAP) */ +static void +objfiles_pspace_data_cleanup (struct program_space *pspace, void *arg) +{ + struct objfile_pspace_info *info; -static void add_to_objfile_sections (bfd *, sec_ptr, void *); + info = program_space_data (pspace, objfiles_pspace_data); + if (info != NULL) + { + xfree (info->sections); + xfree (info); + } +} -/* Externally visible variables that are owned by this module. - See declarations in objfile.h for more info. */ +/* Get the current svr4 data. If none is found yet, add it now. This + function always returns a valid object. */ -struct objfile *object_files; /* Linked list of all objfiles */ -struct objfile *current_objfile; /* For symbol file being read in */ -struct objfile *symfile_objfile; /* Main symbol table loaded from */ -struct objfile *rt_common_objfile; /* For runtime common symbols */ +static struct objfile_pspace_info * +get_objfile_pspace_data (struct program_space *pspace) +{ + struct objfile_pspace_info *info; + + info = program_space_data (pspace, objfiles_pspace_data); + if (info == NULL) + { + info = XZALLOC (struct objfile_pspace_info); + set_program_space_data (pspace, objfiles_pspace_data, info); + } + + return info; +} -int mapped_symbol_files; /* Try to use mapped symbol files */ +/* Records whether any objfiles appeared or disappeared since we last updated + address to obj section map. */ /* Locate all mappable sections of a BFD file. objfile_p_char is a char * to get it through bfd_map_over_sections; we cast it back to its proper type. */ -#ifndef TARGET_KEEP_SECTION -#define TARGET_KEEP_SECTION(ASECT) 0 -#endif - /* Called via bfd_map_over_sections to build up the section table that the objfile references. The objfile contains pointers to the start of the table (objfile->sections) and to the first location after the end of the table (objfile->sections_end). */ static void -add_to_objfile_sections (bfd *abfd, sec_ptr asect, void *objfile_p_char) +add_to_objfile_sections (struct bfd *abfd, struct bfd_section *asect, + void *objfile_p_char) { struct objfile *objfile = (struct objfile *) objfile_p_char; struct obj_section section; @@ -92,19 +129,17 @@ add_to_objfile_sections (bfd *abfd, sec_ptr asect, void *objfile_p_char) aflag = bfd_get_section_flags (abfd, asect); - if (!(aflag & SEC_ALLOC) && !(TARGET_KEEP_SECTION (asect))) + if (!(aflag & SEC_ALLOC)) return; if (0 == bfd_section_size (abfd, asect)) return; - section.offset = 0; section.objfile = objfile; section.the_bfd_section = asect; section.ovly_mapped = 0; - section.addr = bfd_section_vma (abfd, asect); - section.endaddr = section.addr + bfd_section_size (abfd, asect); - obstack_grow (&objfile->psymbol_obstack, (char *) §ion, sizeof (section)); - objfile->sections_end = (struct obj_section *) (((unsigned long) objfile->sections_end) + 1); + obstack_grow (&objfile->objfile_obstack, (char *) §ion, sizeof (section)); + objfile->sections_end + = (struct obj_section *) (((size_t) objfile->sections_end) + 1); } /* Builds a section table for OBJFILE. @@ -129,14 +164,14 @@ build_objfile_section_table (struct objfile *objfile) /* objfile->sections can be already set when reading a mapped symbol file. I believe that we do need to rebuild the section table in this case (we rebuild other things derived from the bfd), but we - can't free the old one (it's in the psymbol_obstack). So we just + can't free the old one (it's in the objfile_obstack). So we just waste some memory. */ objfile->sections_end = 0; - bfd_map_over_sections (objfile->obfd, add_to_objfile_sections, (char *) objfile); - objfile->sections = (struct obj_section *) - obstack_finish (&objfile->psymbol_obstack); - objfile->sections_end = objfile->sections + (unsigned long) objfile->sections_end; + bfd_map_over_sections (objfile->obfd, + add_to_objfile_sections, (void *) objfile); + objfile->sections = obstack_finish (&objfile->objfile_obstack); + objfile->sections_end = objfile->sections + (size_t) objfile->sections_end; return (0); } @@ -146,10 +181,8 @@ build_objfile_section_table (struct objfile *objfile) new objfile struct. The FLAGS word contains various bits (OBJF_*) that can be taken as - requests for specific operations, like trying to open a mapped - version of the objfile (OBJF_MAPPED). Other bits like - OBJF_SHARED are simply copied through to the new objfile flags - member. */ + requests for specific operations. Other bits like OBJF_SHARED are + simply copied through to the new objfile flags member. */ /* NOTE: carlton/2003-02-04: This function is called with args NULL, 0 by jv-lang.c, to create an artificial objfile used to hold @@ -163,178 +196,58 @@ build_objfile_section_table (struct objfile *objfile) struct objfile * allocate_objfile (bfd *abfd, int flags) { - struct objfile *objfile = NULL; - struct objfile *last_one = NULL; - - if (mapped_symbol_files) - flags |= OBJF_MAPPED; - -#if defined(USE_MMALLOC) && defined(HAVE_MMAP) - if (abfd != NULL) - { - - /* If we can support mapped symbol files, try to open/reopen the - mapped file that corresponds to the file from which we wish to - read symbols. If the objfile is to be mapped, we must malloc - the structure itself using the mmap version, and arrange that - all memory allocation for the objfile uses the mmap routines. - If we are reusing an existing mapped file, from which we get - our objfile pointer, we have to make sure that we update the - pointers to the alloc/free functions in the obstack, in case - these functions have moved within the current gdb. */ - - int fd; - - fd = open_mapped_file (bfd_get_filename (abfd), bfd_get_mtime (abfd), - flags); - if (fd >= 0) - { - void *md; - - if ((md = map_to_file (fd)) == NULL) - { - close (fd); - } - else if ((objfile = (struct objfile *) mmalloc_getkey (md, 0)) != NULL) - { - /* Update memory corruption handler function addresses. */ - init_malloc (md); - objfile->md = md; - objfile->mmfd = fd; - /* Update pointers to functions to *our* copies */ - if (objfile->demangled_names_hash) - htab_set_functions_ex - (objfile->demangled_names_hash, htab_hash_string, - (int (*) (const void *, const void *)) streq, NULL, - objfile->md, xmcalloc, xmfree); - obstack_chunkfun (&objfile->psymbol_cache.cache, xmmalloc); - obstack_freefun (&objfile->psymbol_cache.cache, xmfree); - obstack_chunkfun (&objfile->macro_cache.cache, xmmalloc); - obstack_freefun (&objfile->macro_cache.cache, xmfree); - obstack_chunkfun (&objfile->psymbol_obstack, xmmalloc); - obstack_freefun (&objfile->psymbol_obstack, xmfree); - obstack_chunkfun (&objfile->symbol_obstack, xmmalloc); - obstack_freefun (&objfile->symbol_obstack, xmfree); - obstack_chunkfun (&objfile->type_obstack, xmmalloc); - obstack_freefun (&objfile->type_obstack, xmfree); - /* If already in objfile list, unlink it. */ - unlink_objfile (objfile); - /* Forget things specific to a particular gdb, may have changed. */ - objfile->sf = NULL; - } - else - { - - /* Set up to detect internal memory corruption. MUST be - done before the first malloc. See comments in - init_malloc() and mmcheck(). */ - - init_malloc (md); - - objfile = (struct objfile *) - xmmalloc (md, sizeof (struct objfile)); - memset (objfile, 0, sizeof (struct objfile)); - objfile->md = md; - objfile->mmfd = fd; - objfile->flags |= OBJF_MAPPED; - mmalloc_setkey (objfile->md, 0, objfile); - obstack_specify_allocation_with_arg (&objfile->psymbol_cache.cache, - 0, 0, xmmalloc, xmfree, - objfile->md); - obstack_specify_allocation_with_arg (&objfile->macro_cache.cache, - 0, 0, xmmalloc, xmfree, - objfile->md); - obstack_specify_allocation_with_arg (&objfile->psymbol_obstack, - 0, 0, xmmalloc, xmfree, - objfile->md); - obstack_specify_allocation_with_arg (&objfile->symbol_obstack, - 0, 0, xmmalloc, xmfree, - objfile->md); - obstack_specify_allocation_with_arg (&objfile->type_obstack, - 0, 0, xmmalloc, xmfree, - objfile->md); - } - } - - if ((flags & OBJF_MAPPED) && (objfile == NULL)) - { - warning ("symbol table for '%s' will not be mapped", - bfd_get_filename (abfd)); - flags &= ~OBJF_MAPPED; - } - } -#else /* !defined(USE_MMALLOC) || !defined(HAVE_MMAP) */ - - if (flags & OBJF_MAPPED) - { - warning ("mapped symbol tables are not supported on this machine; missing or broken mmap()."); - - /* Turn off the global flag so we don't try to do mapped symbol tables - any more, which shuts up gdb unless the user specifically gives the - "mapped" keyword again. */ - - mapped_symbol_files = 0; - flags &= ~OBJF_MAPPED; - } - -#endif /* defined(USE_MMALLOC) && defined(HAVE_MMAP) */ + struct objfile *objfile; - /* If we don't support mapped symbol files, didn't ask for the file to be - mapped, or failed to open the mapped file for some reason, then revert - back to an unmapped objfile. */ + objfile = (struct objfile *) xzalloc (sizeof (struct objfile)); + objfile->psymbol_cache = psymbol_bcache_init (); + objfile->macro_cache = bcache_xmalloc (NULL, NULL); + objfile->filename_cache = bcache_xmalloc (NULL, NULL); + /* We could use obstack_specify_allocation here instead, but + gdb_obstack.h specifies the alloc/dealloc functions. */ + obstack_init (&objfile->objfile_obstack); + terminate_minimal_symbol_table (objfile); - if (objfile == NULL) - { - objfile = (struct objfile *) xmalloc (sizeof (struct objfile)); - memset (objfile, 0, sizeof (struct objfile)); - objfile->md = NULL; - objfile->psymbol_cache = bcache_xmalloc (); - objfile->macro_cache = bcache_xmalloc (); - obstack_specify_allocation (&objfile->psymbol_obstack, 0, 0, xmalloc, - xfree); - obstack_specify_allocation (&objfile->symbol_obstack, 0, 0, xmalloc, - xfree); - obstack_specify_allocation (&objfile->type_obstack, 0, 0, xmalloc, - xfree); - flags &= ~OBJF_MAPPED; - - terminate_minimal_symbol_table (objfile); - } + objfile_alloc_data (objfile); /* Update the per-objfile information that comes from the bfd, ensuring that any data that is reference is saved in the per-objfile data region. */ - objfile->obfd = abfd; - if (objfile->name != NULL) - { - xmfree (objfile->md, objfile->name); - } + objfile->obfd = gdb_bfd_ref (abfd); if (abfd != NULL) { - objfile->name = mstrsave (objfile->md, bfd_get_filename (abfd)); + /* Look up the gdbarch associated with the BFD. */ + objfile->gdbarch = gdbarch_from_bfd (abfd); + + objfile->name = xstrdup (bfd_get_filename (abfd)); objfile->mtime = bfd_get_mtime (abfd); /* Build section table. */ if (build_objfile_section_table (objfile)) { - error ("Can't find the file sections in `%s': %s", + error (_("Can't find the file sections in `%s': %s"), objfile->name, bfd_errmsg (bfd_get_error ())); } } else { - objfile->name = "<>"; + objfile->name = xstrdup ("<>"); } + objfile->pspace = current_program_space; + /* Initialize the section indexes for this objfile, so that we can later detect if they are used w/o being properly assigned to. */ - objfile->sect_index_text = -1; - objfile->sect_index_data = -1; - objfile->sect_index_bss = -1; - objfile->sect_index_rodata = -1; + objfile->sect_index_text = -1; + objfile->sect_index_data = -1; + objfile->sect_index_bss = -1; + objfile->sect_index_rodata = -1; + + /* We don't yet have a C++-specific namespace symtab. */ + + objfile->cp_namespace_symtab = NULL; /* Add this file onto the tail of the linked list of other such files. */ @@ -343,6 +256,8 @@ allocate_objfile (bfd *abfd, int flags) object_files = objfile; else { + struct objfile *last_one; + for (last_one = object_files; last_one->next; last_one = last_one->next); @@ -352,20 +267,102 @@ allocate_objfile (bfd *abfd, int flags) /* Save passed in flag bits. */ objfile->flags |= flags; - return (objfile); + /* Rebuild section map next time we need it. */ + get_objfile_pspace_data (objfile->pspace)->objfiles_changed_p = 1; + + return objfile; +} + +/* Retrieve the gdbarch associated with OBJFILE. */ +struct gdbarch * +get_objfile_arch (struct objfile *objfile) +{ + return objfile->gdbarch; +} + +/* Initialize entry point information for this objfile. */ + +void +init_entry_point_info (struct objfile *objfile) +{ + /* Save startup file's range of PC addresses to help blockframe.c + decide where the bottom of the stack is. */ + + if (bfd_get_file_flags (objfile->obfd) & EXEC_P) + { + /* Executable file -- record its entry point so we'll recognize + the startup file because it contains the entry point. */ + objfile->ei.entry_point = bfd_get_start_address (objfile->obfd); + objfile->ei.entry_point_p = 1; + } + else if (bfd_get_file_flags (objfile->obfd) & DYNAMIC + && bfd_get_start_address (objfile->obfd) != 0) + { + /* Some shared libraries may have entry points set and be + runnable. There's no clear way to indicate this, so just check + for values other than zero. */ + objfile->ei.entry_point = bfd_get_start_address (objfile->obfd); + objfile->ei.entry_point_p = 1; + } + else + { + /* Examination of non-executable.o files. Short-circuit this stuff. */ + objfile->ei.entry_point_p = 0; + } +} + +/* If there is a valid and known entry point, function fills *ENTRY_P with it + and returns non-zero; otherwise it returns zero. */ + +int +entry_point_address_query (CORE_ADDR *entry_p) +{ + struct gdbarch *gdbarch; + CORE_ADDR entry_point; + + if (symfile_objfile == NULL || !symfile_objfile->ei.entry_point_p) + return 0; + + gdbarch = get_objfile_arch (symfile_objfile); + + entry_point = symfile_objfile->ei.entry_point; + + /* Make certain that the address points at real code, and not a + function descriptor. */ + entry_point = gdbarch_convert_from_func_ptr_addr (gdbarch, entry_point, + ¤t_target); + + /* Remove any ISA markers, so that this matches entries in the + symbol table. */ + entry_point = gdbarch_addr_bits_remove (gdbarch, entry_point); + + *entry_p = entry_point; + return 1; } +/* Get current entry point address. Call error if it is not known. */ + +CORE_ADDR +entry_point_address (void) +{ + CORE_ADDR retval; + + if (!entry_point_address_query (&retval)) + error (_("Entry point address is not known.")); + + return retval; +} /* Create the terminating entry of OBJFILE's minimal symbol table. If OBJFILE->msymbols is zero, allocate a single entry from - OBJFILE->symbol_obstack; otherwise, just initialize + OBJFILE->objfile_obstack; otherwise, just initialize OBJFILE->msymbols[OBJFILE->minimal_symbol_count]. */ void terminate_minimal_symbol_table (struct objfile *objfile) { if (! objfile->msymbols) objfile->msymbols = ((struct minimal_symbol *) - obstack_alloc (&objfile->symbol_obstack, + obstack_alloc (&objfile->objfile_obstack, sizeof (objfile->msymbols[0]))); { @@ -373,14 +370,51 @@ terminate_minimal_symbol_table (struct objfile *objfile) = &objfile->msymbols[objfile->minimal_symbol_count]; memset (m, 0, sizeof (*m)); - SYMBOL_NAME (m) = NULL; - SYMBOL_VALUE_ADDRESS (m) = 0; - MSYMBOL_INFO (m) = NULL; + /* Don't rely on these enumeration values being 0's. */ MSYMBOL_TYPE (m) = mst_unknown; - SYMBOL_INIT_LANGUAGE_SPECIFIC (m, language_unknown); + SYMBOL_SET_LANGUAGE (m, language_unknown); } } +/* Iterator on PARENT and every separate debug objfile of PARENT. + The usage pattern is: + for (objfile = parent; + objfile; + objfile = objfile_separate_debug_iterate (parent, objfile)) + ... +*/ + +struct objfile * +objfile_separate_debug_iterate (const struct objfile *parent, + const struct objfile *objfile) +{ + struct objfile *res; + + /* If any, return the first child. */ + res = objfile->separate_debug_objfile; + if (res) + return res; + + /* Common case where there is no separate debug objfile. */ + if (objfile == parent) + return NULL; + + /* Return the brother if any. Note that we don't iterate on brothers of + the parents. */ + res = objfile->separate_debug_objfile_link; + if (res) + return res; + + for (res = objfile->separate_debug_objfile_backlink; + res != parent; + res = res->separate_debug_objfile_backlink) + { + gdb_assert (res != NULL); + if (res->separate_debug_objfile_link) + return res->separate_debug_objfile_link; + } + return NULL; +} /* Put one object file before a specified on in the global list. This can be used to make sure an object file is destroyed before @@ -403,7 +437,7 @@ put_objfile_before (struct objfile *objfile, struct objfile *before_this) } internal_error (__FILE__, __LINE__, - "put_objfile_before: before objfile not in list"); + _("put_objfile_before: before objfile not in list")); } /* Put OBJFILE at the front of the list. */ @@ -455,13 +489,48 @@ unlink_objfile (struct objfile *objfile) } internal_error (__FILE__, __LINE__, - "unlink_objfile: objfile already unlinked"); + _("unlink_objfile: objfile already unlinked")); +} + +/* Add OBJFILE as a separate debug objfile of PARENT. */ + +void +add_separate_debug_objfile (struct objfile *objfile, struct objfile *parent) +{ + gdb_assert (objfile && parent); + + /* Must not be already in a list. */ + gdb_assert (objfile->separate_debug_objfile_backlink == NULL); + gdb_assert (objfile->separate_debug_objfile_link == NULL); + + objfile->separate_debug_objfile_backlink = parent; + objfile->separate_debug_objfile_link = parent->separate_debug_objfile; + parent->separate_debug_objfile = objfile; + + /* Put the separate debug object before the normal one, this is so that + usage of the ALL_OBJFILES_SAFE macro will stay safe. */ + put_objfile_before (objfile, parent); } +/* Free all separate debug objfile of OBJFILE, but don't free OBJFILE + itself. */ + +void +free_objfile_separate_debug (struct objfile *objfile) +{ + struct objfile *child; + + for (child = objfile->separate_debug_objfile; child;) + { + struct objfile *next_child = child->separate_debug_objfile_link; + free_objfile (child); + child = next_child; + } +} /* Destroy an objfile and all the symtabs and psymtabs under it. Note - that as much as possible is allocated on the symbol_obstack and - psymbol_obstack, so that the memory can be efficiently freed. + that as much as possible is allocated on the objfile_obstack + so that the memory can be efficiently freed. Things which we do NOT free because they are not in malloc'd memory or not in memory specific to the objfile include: @@ -478,18 +547,44 @@ unlink_objfile (struct objfile *objfile) void free_objfile (struct objfile *objfile) { - if (objfile->separate_debug_objfile) - { - free_objfile (objfile->separate_debug_objfile); - } - + /* Free all separate debug objfiles. */ + free_objfile_separate_debug (objfile); + if (objfile->separate_debug_objfile_backlink) { /* We freed the separate debug file, make sure the base objfile doesn't reference it. */ - objfile->separate_debug_objfile_backlink->separate_debug_objfile = NULL; + struct objfile *child; + + child = objfile->separate_debug_objfile_backlink->separate_debug_objfile; + + if (child == objfile) + { + /* OBJFILE is the first child. */ + objfile->separate_debug_objfile_backlink->separate_debug_objfile = + objfile->separate_debug_objfile_link; + } + else + { + /* Find OBJFILE in the list. */ + while (1) + { + if (child->separate_debug_objfile_link == objfile) + { + child->separate_debug_objfile_link = + objfile->separate_debug_objfile_link; + break; + } + child = child->separate_debug_objfile_link; + gdb_assert (child); + } + } } + /* Remove any references to this objfile in the global value + lists. */ + preserve_values (objfile); + /* First do any symbol file specific actions required when we are finished with a particular symbol file. Note that if the objfile is using reusable symbol information (via mmalloc) then each of @@ -502,23 +597,17 @@ free_objfile (struct objfile *objfile) (*objfile->sf->sym_finish) (objfile); } - /* We always close the bfd. */ + /* Discard any data modules have associated with the objfile. */ + objfile_free_data (objfile); - if (objfile->obfd != NULL) - { - char *name = bfd_get_filename (objfile->obfd); - if (!bfd_close (objfile->obfd)) - warning ("cannot close \"%s\": %s", - name, bfd_errmsg (bfd_get_error ())); - xfree (name); - } + gdb_bfd_unref (objfile->obfd); /* Remove it from the chain of all objfiles. */ unlink_objfile (objfile); - /* If we are going to free the runtime common objfile, mark it - as unallocated. */ + if (objfile == symfile_objfile) + symfile_objfile = NULL; if (objfile == rt_common_objfile) rt_common_objfile = NULL; @@ -530,55 +619,49 @@ free_objfile (struct objfile *objfile) is unknown, but we play it safe for now and keep each action until it is shown to be no longer needed. */ - /* I *think* all our callers call clear_symtab_users. If so, no need - to call this here. */ + /* Not all our callers call clear_symtab_users (objfile_purge_solibs, + for example), so we need to call this here. */ clear_pc_function_cache (); - /* The last thing we do is free the objfile struct itself for the - non-reusable case, or detach from the mapped file for the - reusable case. Note that the mmalloc_detach or the xmfree() is - the last thing we can do with this objfile. */ + /* Clear globals which might have pointed into a removed objfile. + FIXME: It's not clear which of these are supposed to persist + between expressions and which ought to be reset each time. */ + expression_context_block = NULL; + innermost_block = NULL; -#if defined(USE_MMALLOC) && defined(HAVE_MMAP) - - if (objfile->flags & OBJF_MAPPED) - { - /* Remember the fd so we can close it. We can't close it before - doing the detach, and after the detach the objfile is gone. */ - int mmfd; - - mmfd = objfile->mmfd; - mmalloc_detach (objfile->md); - objfile = NULL; - close (mmfd); - } + /* Check to see if the current_source_symtab belongs to this objfile, + and if so, call clear_current_source_symtab_and_line. */ -#endif /* defined(USE_MMALLOC) && defined(HAVE_MMAP) */ + { + struct symtab_and_line cursal = get_current_source_symtab_and_line (); + struct symtab *s; - /* If we still have an objfile, then either we don't support reusable - objfiles or this one was not reusable. So free it normally. */ + ALL_OBJFILE_SYMTABS (objfile, s) + { + if (s == cursal.symtab) + clear_current_source_symtab_and_line (); + } + } - if (objfile != NULL) - { - if (objfile->name != NULL) - { - xmfree (objfile->md, objfile->name); - } - if (objfile->global_psymbols.list) - xmfree (objfile->md, objfile->global_psymbols.list); - if (objfile->static_psymbols.list) - xmfree (objfile->md, objfile->static_psymbols.list); - /* Free the obstacks for non-reusable objfiles */ - bcache_xfree (objfile->psymbol_cache); - bcache_xfree (objfile->macro_cache); - if (objfile->demangled_names_hash) - htab_delete (objfile->demangled_names_hash); - obstack_free (&objfile->psymbol_obstack, 0); - obstack_free (&objfile->symbol_obstack, 0); - obstack_free (&objfile->type_obstack, 0); - xmfree (objfile->md, objfile); - objfile = NULL; - } + /* The last thing we do is free the objfile struct itself. */ + + xfree (objfile->name); + if (objfile->global_psymbols.list) + xfree (objfile->global_psymbols.list); + if (objfile->static_psymbols.list) + xfree (objfile->static_psymbols.list); + /* Free the obstacks for non-reusable objfiles */ + psymbol_bcache_free (objfile->psymbol_cache); + bcache_xfree (objfile->macro_cache); + bcache_xfree (objfile->filename_cache); + if (objfile->demangled_names_hash) + htab_delete (objfile->demangled_names_hash); + obstack_free (&objfile->objfile_obstack, 0); + + /* Rebuild section map next time we need it. */ + get_objfile_pspace_data (objfile->pspace)->objfiles_changed_p = 1; + + xfree (objfile); } static void @@ -599,35 +682,65 @@ void free_all_objfiles (void) { struct objfile *objfile, *temp; + struct so_list *so; + + /* Any objfile referencewould become stale. */ + for (so = master_so_list (); so; so = so->next) + gdb_assert (so->objfile == NULL); ALL_OBJFILES_SAFE (objfile, temp) { free_objfile (objfile); } - clear_symtab_users (); + clear_symtab_users (0); } +/* A helper function for objfile_relocate1 that relocates a single + symbol. */ + +static void +relocate_one_symbol (struct symbol *sym, struct objfile *objfile, + struct section_offsets *delta) +{ + fixup_symbol_section (sym, objfile); + + /* The RS6000 code from which this was taken skipped + any symbols in STRUCT_DOMAIN or UNDEF_DOMAIN. + But I'm leaving out that test, on the theory that + they can't possibly pass the tests below. */ + if ((SYMBOL_CLASS (sym) == LOC_LABEL + || SYMBOL_CLASS (sym) == LOC_STATIC) + && SYMBOL_SECTION (sym) >= 0) + { + SYMBOL_VALUE_ADDRESS (sym) += ANOFFSET (delta, SYMBOL_SECTION (sym)); + } +} + /* Relocate OBJFILE to NEW_OFFSETS. There should be OBJFILE->NUM_SECTIONS - entries in new_offsets. */ -void -objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) + entries in new_offsets. SEPARATE_DEBUG_OBJFILE is not touched here. + Return non-zero iff any change happened. */ + +static int +objfile_relocate1 (struct objfile *objfile, + struct section_offsets *new_offsets) { + struct obj_section *s; struct section_offsets *delta = - (struct section_offsets *) alloca (SIZEOF_SECTION_OFFSETS); + ((struct section_offsets *) + alloca (SIZEOF_N_SECTION_OFFSETS (objfile->num_sections))); - { - int i; - int something_changed = 0; - for (i = 0; i < objfile->num_sections; ++i) - { - delta->offsets[i] = - ANOFFSET (new_offsets, i) - ANOFFSET (objfile->section_offsets, i); - if (ANOFFSET (delta, i) != 0) - something_changed = 1; - } - if (!something_changed) - return; - } + int i; + int something_changed = 0; + + for (i = 0; i < objfile->num_sections; ++i) + { + delta->offsets[i] = + ANOFFSET (new_offsets, i) - ANOFFSET (objfile->section_offsets, i); + if (ANOFFSET (delta, i) != 0) + something_changed = 1; + } + if (!something_changed) + return 0; /* OK, get all the symtabs. */ { @@ -652,81 +765,46 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) continue; bv = BLOCKVECTOR (s); + if (BLOCKVECTOR_MAP (bv)) + addrmap_relocate (BLOCKVECTOR_MAP (bv), + ANOFFSET (delta, s->block_line_section)); + for (i = 0; i < BLOCKVECTOR_NBLOCKS (bv); ++i) { struct block *b; struct symbol *sym; - int j; + struct dict_iterator iter; b = BLOCKVECTOR_BLOCK (bv, i); BLOCK_START (b) += ANOFFSET (delta, s->block_line_section); BLOCK_END (b) += ANOFFSET (delta, s->block_line_section); - ALL_BLOCK_SYMBOLS (b, j, sym) + ALL_BLOCK_SYMBOLS (b, iter, sym) { - fixup_symbol_section (sym, objfile); - - /* The RS6000 code from which this was taken skipped - any symbols in STRUCT_NAMESPACE or UNDEF_NAMESPACE. - But I'm leaving out that test, on the theory that - they can't possibly pass the tests below. */ - if ((SYMBOL_CLASS (sym) == LOC_LABEL - || SYMBOL_CLASS (sym) == LOC_STATIC - || SYMBOL_CLASS (sym) == LOC_INDIRECT) - && SYMBOL_SECTION (sym) >= 0) - { - SYMBOL_VALUE_ADDRESS (sym) += - ANOFFSET (delta, SYMBOL_SECTION (sym)); - } -#ifdef MIPS_EFI_SYMBOL_NAME - /* Relocate Extra Function Info for ecoff. */ - - else if (SYMBOL_CLASS (sym) == LOC_CONST - && SYMBOL_NAMESPACE (sym) == LABEL_NAMESPACE - && strcmp (SYMBOL_NAME (sym), MIPS_EFI_SYMBOL_NAME) == 0) - ecoff_relocate_efi (sym, ANOFFSET (delta, - s->block_line_section)); -#endif + relocate_one_symbol (sym, objfile, delta); } } } } + /* Relocate isolated symbols. */ { - struct partial_symtab *p; + struct symbol *iter; - ALL_OBJFILE_PSYMTABS (objfile, p) - { - p->textlow += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - p->texthigh += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - } + for (iter = objfile->template_symbols; iter; iter = iter->hash_next) + relocate_one_symbol (iter, objfile, delta); } - { - struct partial_symbol **psym; + if (objfile->psymtabs_addrmap) + addrmap_relocate (objfile->psymtabs_addrmap, + ANOFFSET (delta, SECT_OFF_TEXT (objfile))); - for (psym = objfile->global_psymbols.list; - psym < objfile->global_psymbols.next; - psym++) - { - fixup_psymbol_section (*psym, objfile); - if (SYMBOL_SECTION (*psym) >= 0) - SYMBOL_VALUE_ADDRESS (*psym) += ANOFFSET (delta, - SYMBOL_SECTION (*psym)); - } - for (psym = objfile->static_psymbols.list; - psym < objfile->static_psymbols.next; - psym++) - { - fixup_psymbol_section (*psym, objfile); - if (SYMBOL_SECTION (*psym) >= 0) - SYMBOL_VALUE_ADDRESS (*psym) += ANOFFSET (delta, - SYMBOL_SECTION (*psym)); - } - } + if (objfile->sf) + objfile->sf->qf->relocate (objfile, new_offsets, delta); { struct minimal_symbol *msym; + ALL_OBJFILE_MSYMBOLS (objfile, msym) if (SYMBOL_SECTION (msym) >= 0) SYMBOL_VALUE_ADDRESS (msym) += ANOFFSET (delta, SYMBOL_SECTION (msym)); @@ -735,13 +813,7 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) to be out of order. */ msymbols_sort (objfile); - { - int i; - for (i = 0; i < objfile->num_sections; ++i) - (objfile->section_offsets)->offsets[i] = ANOFFSET (new_offsets, i); - } - - if (objfile->ei.entry_point != ~(CORE_ADDR) 0) + if (objfile->ei.entry_point_p) { /* Relocate ei.entry_point with its section offset, use SECT_OFF_TEXT only as a fallback. */ @@ -754,42 +826,111 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) } { - struct obj_section *s; - bfd *abfd; - - abfd = objfile->obfd; + int i; - ALL_OBJFILE_OSECTIONS (objfile, s) - { - int idx = s->the_bfd_section->index; - - s->addr += ANOFFSET (delta, idx); - s->endaddr += ANOFFSET (delta, idx); - } + for (i = 0; i < objfile->num_sections; ++i) + (objfile->section_offsets)->offsets[i] = ANOFFSET (new_offsets, i); } - if (objfile->ei.entry_func_lowpc != INVALID_ENTRY_LOWPC) - { - objfile->ei.entry_func_lowpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - objfile->ei.entry_func_highpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - } + /* Rebuild section map next time we need it. */ + get_objfile_pspace_data (objfile->pspace)->objfiles_changed_p = 1; - if (objfile->ei.entry_file_lowpc != INVALID_ENTRY_LOWPC) + /* Update the table in exec_ops, used to read memory. */ + ALL_OBJFILE_OSECTIONS (objfile, s) { - objfile->ei.entry_file_lowpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - objfile->ei.entry_file_highpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); + int idx = s->the_bfd_section->index; + + exec_set_section_address (bfd_get_filename (objfile->obfd), idx, + obj_section_addr (s)); } - if (objfile->ei.main_func_lowpc != INVALID_ENTRY_LOWPC) + /* Data changed. */ + return 1; +} + +/* Relocate OBJFILE to NEW_OFFSETS. There should be OBJFILE->NUM_SECTIONS + entries in new_offsets. Process also OBJFILE's SEPARATE_DEBUG_OBJFILEs. + + The number and ordering of sections does differ between the two objfiles. + Only their names match. Also the file offsets will differ (objfile being + possibly prelinked but separate_debug_objfile is probably not prelinked) but + the in-memory absolute address as specified by NEW_OFFSETS must match both + files. */ + +void +objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) +{ + struct objfile *debug_objfile; + int changed = 0; + + changed |= objfile_relocate1 (objfile, new_offsets); + + for (debug_objfile = objfile->separate_debug_objfile; + debug_objfile; + debug_objfile = objfile_separate_debug_iterate (objfile, debug_objfile)) { - objfile->ei.main_func_lowpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); - objfile->ei.main_func_highpc += ANOFFSET (delta, SECT_OFF_TEXT (objfile)); + struct section_addr_info *objfile_addrs; + struct section_offsets *new_debug_offsets; + struct cleanup *my_cleanups; + + objfile_addrs = build_section_addr_info_from_objfile (objfile); + my_cleanups = make_cleanup (xfree, objfile_addrs); + + /* Here OBJFILE_ADDRS contain the correct absolute addresses, the + relative ones must be already created according to debug_objfile. */ + + addr_info_make_relative (objfile_addrs, debug_objfile->obfd); + + gdb_assert (debug_objfile->num_sections + == bfd_count_sections (debug_objfile->obfd)); + new_debug_offsets = + xmalloc (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections)); + make_cleanup (xfree, new_debug_offsets); + relative_addr_info_to_section_offsets (new_debug_offsets, + debug_objfile->num_sections, + objfile_addrs); + + changed |= objfile_relocate1 (debug_objfile, new_debug_offsets); + + do_cleanups (my_cleanups); } /* Relocate breakpoints as necessary, after things are relocated. */ - breakpoint_re_set (); + if (changed) + breakpoint_re_set (); } +/* Return non-zero if OBJFILE has partial symbols. */ + +int +objfile_has_partial_symbols (struct objfile *objfile) +{ + return objfile->sf ? objfile->sf->qf->has_symbols (objfile) : 0; +} + +/* Return non-zero if OBJFILE has full symbols. */ + +int +objfile_has_full_symbols (struct objfile *objfile) +{ + return objfile->symtabs != NULL; +} + +/* Return non-zero if OBJFILE has full or partial symbols, either directly + or through a separate debug file. */ + +int +objfile_has_symbols (struct objfile *objfile) +{ + struct objfile *o; + + for (o = objfile; o; o = objfile_separate_debug_iterate (objfile, o)) + if (objfile_has_partial_symbols (o) || objfile_has_full_symbols (o)) + return 1; + return 0; +} + + /* Many places in gdb want to test just to see if we have any partial symbols available. This function returns zero if none are currently available, nonzero otherwise. */ @@ -801,10 +942,8 @@ have_partial_symbols (void) ALL_OBJFILES (ofp) { - if (ofp->psymtabs != NULL) - { - return 1; - } + if (objfile_has_partial_symbols (ofp)) + return 1; } return 0; } @@ -820,10 +959,8 @@ have_full_symbols (void) ALL_OBJFILES (ofp) { - if (ofp->symtabs != NULL) - { - return 1; - } + if (objfile_has_full_symbols (ofp)) + return 1; } return 0; } @@ -869,195 +1006,346 @@ have_minimal_symbols (void) return 0; } -#if defined(USE_MMALLOC) && defined(HAVE_MMAP) - -/* Given the name of a mapped symbol file in SYMSFILENAME, and the timestamp - of the corresponding symbol file in MTIME, try to open an existing file - with the name SYMSFILENAME and verify it is more recent than the base - file by checking it's timestamp against MTIME. +/* Qsort comparison function. */ - If SYMSFILENAME does not exist (or can't be stat'd), simply returns -1. +static int +qsort_cmp (const void *a, const void *b) +{ + const struct obj_section *sect1 = *(const struct obj_section **) a; + const struct obj_section *sect2 = *(const struct obj_section **) b; + const CORE_ADDR sect1_addr = obj_section_addr (sect1); + const CORE_ADDR sect2_addr = obj_section_addr (sect2); + + if (sect1_addr < sect2_addr) + return -1; + else if (sect1_addr > sect2_addr) + return 1; + else + { + /* Sections are at the same address. This could happen if + A) we have an objfile and a separate debuginfo. + B) we are confused, and have added sections without proper relocation, + or something like that. */ - If SYMSFILENAME does exist, but is out of date, we check to see if the - user has specified creation of a mapped file. If so, we don't issue - any warning message because we will be creating a new mapped file anyway, - overwriting the old one. If not, then we issue a warning message so that - the user will know why we aren't using this existing mapped symbol file. - In either case, we return -1. + const struct objfile *const objfile1 = sect1->objfile; + const struct objfile *const objfile2 = sect2->objfile; - If SYMSFILENAME does exist and is not out of date, but can't be opened for - some reason, then prints an appropriate system error message and returns -1. + if (objfile1->separate_debug_objfile == objfile2 + || objfile2->separate_debug_objfile == objfile1) + { + /* Case A. The ordering doesn't matter: separate debuginfo files + will be filtered out later. */ - Otherwise, returns the open file descriptor. */ + return 0; + } -static int -open_existing_mapped_file (char *symsfilename, long mtime, int flags) -{ - int fd = -1; - struct stat sbuf; + /* Case B. Maintain stable sort order, so bugs in GDB are easier to + triage. This section could be slow (since we iterate over all + objfiles in each call to qsort_cmp), but this shouldn't happen + very often (GDB is already in a confused state; one hopes this + doesn't happen at all). If you discover that significant time is + spent in the loops below, do 'set complaints 100' and examine the + resulting complaints. */ - if (stat (symsfilename, &sbuf) == 0) - { - if (sbuf.st_mtime < mtime) + if (objfile1 == objfile2) { - if (!(flags & OBJF_MAPPED)) - { - warning ("mapped symbol file `%s' is out of date, ignored it", - symsfilename); - } + /* Both sections came from the same objfile. We are really confused. + Sort on sequence order of sections within the objfile. */ + + const struct obj_section *osect; + + ALL_OBJFILE_OSECTIONS (objfile1, osect) + if (osect == sect1) + return -1; + else if (osect == sect2) + return 1; + + /* We should have found one of the sections before getting here. */ + gdb_assert_not_reached ("section not found"); } - else if ((fd = open (symsfilename, O_RDWR)) < 0) + else { - if (error_pre_print) - { - printf_unfiltered (error_pre_print); - } - print_sys_errmsg (symsfilename, errno); + /* Sort on sequence number of the objfile in the chain. */ + + const struct objfile *objfile; + + ALL_OBJFILES (objfile) + if (objfile == objfile1) + return -1; + else if (objfile == objfile2) + return 1; + + /* We should have found one of the objfiles before getting here. */ + gdb_assert_not_reached ("objfile not found"); } } - return (fd); + + /* Unreachable. */ + gdb_assert_not_reached ("unexpected code path"); + return 0; } -/* Look for a mapped symbol file that corresponds to FILENAME and is more - recent than MTIME. If MAPPED is nonzero, the user has asked that gdb - use a mapped symbol file for this file, so create a new one if one does - not currently exist. - - If found, then return an open file descriptor for the file, otherwise - return -1. - - This routine is responsible for implementing the policy that generates - the name of the mapped symbol file from the name of a file containing - symbols that gdb would like to read. Currently this policy is to append - ".syms" to the name of the file. - - This routine is also responsible for implementing the policy that - determines where the mapped symbol file is found (the search path). - This policy is that when reading an existing mapped file, a file of - the correct name in the current directory takes precedence over a - file of the correct name in the same directory as the symbol file. - When creating a new mapped file, it is always created in the current - directory. This helps to minimize the chances of a user unknowingly - creating big mapped files in places like /bin and /usr/local/bin, and - allows a local copy to override a manually installed global copy (in - /bin for example). */ +/* Select "better" obj_section to keep. We prefer the one that came from + the real object, rather than the one from separate debuginfo. + Most of the time the two sections are exactly identical, but with + prelinking the .rel.dyn section in the real object may have different + size. */ + +static struct obj_section * +preferred_obj_section (struct obj_section *a, struct obj_section *b) +{ + gdb_assert (obj_section_addr (a) == obj_section_addr (b)); + gdb_assert ((a->objfile->separate_debug_objfile == b->objfile) + || (b->objfile->separate_debug_objfile == a->objfile)); + gdb_assert ((a->objfile->separate_debug_objfile_backlink == b->objfile) + || (b->objfile->separate_debug_objfile_backlink == a->objfile)); + + if (a->objfile->separate_debug_objfile != NULL) + return a; + return b; +} + +/* Return 1 if SECTION should be inserted into the section map. + We want to insert only non-overlay and non-TLS section. */ static int -open_mapped_file (char *filename, long mtime, int flags) +insert_section_p (const struct bfd *abfd, + const struct bfd_section *section) { - int fd; - char *symsfilename; + const bfd_vma lma = bfd_section_lma (abfd, section); - /* First try to open an existing file in the current directory, and - then try the directory where the symbol file is located. */ + if (lma != 0 && lma != bfd_section_vma (abfd, section) + && (bfd_get_file_flags (abfd) & BFD_IN_MEMORY) == 0) + /* This is an overlay section. IN_MEMORY check is needed to avoid + discarding sections from the "system supplied DSO" (aka vdso) + on some Linux systems (e.g. Fedora 11). */ + return 0; + if ((bfd_get_section_flags (abfd, section) & SEC_THREAD_LOCAL) != 0) + /* This is a TLS section. */ + return 0; - symsfilename = concat ("./", lbasename (filename), ".syms", (char *) NULL); - if ((fd = open_existing_mapped_file (symsfilename, mtime, flags)) < 0) - { - xfree (symsfilename); - symsfilename = concat (filename, ".syms", (char *) NULL); - fd = open_existing_mapped_file (symsfilename, mtime, flags); - } + return 1; +} - /* If we don't have an open file by now, then either the file does not - already exist, or the base file has changed since it was created. In - either case, if the user has specified use of a mapped file, then - create a new mapped file, truncating any existing one. If we can't - create one, print a system error message saying why we can't. +/* Filter out overlapping sections where one section came from the real + objfile, and the other from a separate debuginfo file. + Return the size of table after redundant sections have been eliminated. */ - By default the file is rw for everyone, with the user's umask taking - care of turning off the permissions the user wants off. */ +static int +filter_debuginfo_sections (struct obj_section **map, int map_size) +{ + int i, j; - if ((fd < 0) && (flags & OBJF_MAPPED)) + for (i = 0, j = 0; i < map_size - 1; i++) { - xfree (symsfilename); - symsfilename = concat ("./", lbasename (filename), ".syms", - (char *) NULL); - if ((fd = open (symsfilename, O_RDWR | O_CREAT | O_TRUNC, 0666)) < 0) + struct obj_section *const sect1 = map[i]; + struct obj_section *const sect2 = map[i + 1]; + const struct objfile *const objfile1 = sect1->objfile; + const struct objfile *const objfile2 = sect2->objfile; + const CORE_ADDR sect1_addr = obj_section_addr (sect1); + const CORE_ADDR sect2_addr = obj_section_addr (sect2); + + if (sect1_addr == sect2_addr + && (objfile1->separate_debug_objfile == objfile2 + || objfile2->separate_debug_objfile == objfile1)) { - if (error_pre_print) - { - printf_unfiltered (error_pre_print); - } - print_sys_errmsg (symsfilename, errno); + map[j++] = preferred_obj_section (sect1, sect2); + ++i; } + else + map[j++] = sect1; + } + + if (i < map_size) + { + gdb_assert (i == map_size - 1); + map[j++] = map[i]; } - xfree (symsfilename); - return (fd); + /* The map should not have shrunk to less than half the original size. */ + gdb_assert (map_size / 2 <= j); + + return j; } -static void * -map_to_file (int fd) +/* Filter out overlapping sections, issuing a warning if any are found. + Overlapping sections could really be overlay sections which we didn't + classify as such in insert_section_p, or we could be dealing with a + corrupt binary. */ + +static int +filter_overlapping_sections (struct obj_section **map, int map_size) { - void *md; - CORE_ADDR mapto; + int i, j; - md = mmalloc_attach (fd, 0); - if (md != NULL) + for (i = 0, j = 0; i < map_size - 1; ) { - mapto = (CORE_ADDR) mmalloc_getkey (md, 1); - md = mmalloc_detach (md); - if (md != NULL) - { - /* FIXME: should figure out why detach failed */ - md = NULL; - } - else if (mapto != (CORE_ADDR) NULL) - { - /* This mapping file needs to be remapped at "mapto" */ - md = mmalloc_attach (fd, mapto); - } - else + int k; + + map[j++] = map[i]; + for (k = i + 1; k < map_size; k++) { - /* This is a freshly created mapping file. */ - mapto = (CORE_ADDR) mmalloc_findbase (20 * 1024 * 1024); - if (mapto != 0) + struct obj_section *const sect1 = map[i]; + struct obj_section *const sect2 = map[k]; + const CORE_ADDR sect1_addr = obj_section_addr (sect1); + const CORE_ADDR sect2_addr = obj_section_addr (sect2); + const CORE_ADDR sect1_endaddr = obj_section_endaddr (sect1); + + gdb_assert (sect1_addr <= sect2_addr); + + if (sect1_endaddr <= sect2_addr) + break; + else { - /* To avoid reusing the freshly created mapping file, at the - address selected by mmap, we must truncate it before trying - to do an attach at the address we want. */ - ftruncate (fd, 0); - md = mmalloc_attach (fd, mapto); - if (md != NULL) - { - mmalloc_setkey (md, 1, mapto); - } + /* We have an overlap. Report it. */ + + struct objfile *const objf1 = sect1->objfile; + struct objfile *const objf2 = sect2->objfile; + + const struct bfd *const abfd1 = objf1->obfd; + const struct bfd *const abfd2 = objf2->obfd; + + const struct bfd_section *const bfds1 = sect1->the_bfd_section; + const struct bfd_section *const bfds2 = sect2->the_bfd_section; + + const CORE_ADDR sect2_endaddr = obj_section_endaddr (sect2); + + struct gdbarch *const gdbarch = get_objfile_arch (objf1); + + complaint (&symfile_complaints, + _("unexpected overlap between:\n" + " (A) section `%s' from `%s' [%s, %s)\n" + " (B) section `%s' from `%s' [%s, %s).\n" + "Will ignore section B"), + bfd_section_name (abfd1, bfds1), objf1->name, + paddress (gdbarch, sect1_addr), + paddress (gdbarch, sect1_endaddr), + bfd_section_name (abfd2, bfds2), objf2->name, + paddress (gdbarch, sect2_addr), + paddress (gdbarch, sect2_endaddr)); } } + i = k; } - return (md); + + if (i < map_size) + { + gdb_assert (i == map_size - 1); + map[j++] = map[i]; + } + + return j; } -#endif /* defined(USE_MMALLOC) && defined(HAVE_MMAP) */ -/* Returns a section whose range includes PC and SECTION, - or NULL if none found. Note the distinction between the return type, - struct obj_section (which is defined in gdb), and the input type - struct sec (which is a bfd-defined data type). The obj_section - contains a pointer to the bfd struct sec section. */ +/* Update PMAP, PMAP_SIZE with sections from all objfiles, excluding any + TLS, overlay and overlapping sections. */ -struct obj_section * -find_pc_sect_section (CORE_ADDR pc, struct sec *section) +static void +update_section_map (struct program_space *pspace, + struct obj_section ***pmap, int *pmap_size) { - struct obj_section *s; + int alloc_size, map_size, i; + struct obj_section *s, **map; struct objfile *objfile; - ALL_OBJSECTIONS (objfile, s) - if ((section == 0 || section == s->the_bfd_section) && - s->addr <= pc && pc < s->endaddr) - return (s); + gdb_assert (get_objfile_pspace_data (pspace)->objfiles_changed_p != 0); + + map = *pmap; + xfree (map); + + alloc_size = 0; + ALL_PSPACE_OBJFILES (pspace, objfile) + ALL_OBJFILE_OSECTIONS (objfile, s) + if (insert_section_p (objfile->obfd, s->the_bfd_section)) + alloc_size += 1; + + /* This happens on detach/attach (e.g. in gdb.base/attach.exp). */ + if (alloc_size == 0) + { + *pmap = NULL; + *pmap_size = 0; + return; + } + + map = xmalloc (alloc_size * sizeof (*map)); + + i = 0; + ALL_PSPACE_OBJFILES (pspace, objfile) + ALL_OBJFILE_OSECTIONS (objfile, s) + if (insert_section_p (objfile->obfd, s->the_bfd_section)) + map[i++] = s; + + qsort (map, alloc_size, sizeof (*map), qsort_cmp); + map_size = filter_debuginfo_sections(map, alloc_size); + map_size = filter_overlapping_sections(map, map_size); - return (NULL); + if (map_size < alloc_size) + /* Some sections were eliminated. Trim excess space. */ + map = xrealloc (map, map_size * sizeof (*map)); + else + gdb_assert (alloc_size == map_size); + + *pmap = map; + *pmap_size = map_size; +} + +/* Bsearch comparison function. */ + +static int +bsearch_cmp (const void *key, const void *elt) +{ + const CORE_ADDR pc = *(CORE_ADDR *) key; + const struct obj_section *section = *(const struct obj_section **) elt; + + if (pc < obj_section_addr (section)) + return -1; + if (pc < obj_section_endaddr (section)) + return 0; + return 1; } -/* Returns a section whose range includes PC or NULL if none found. - Backward compatibility, no section. */ +/* Returns a section whose range includes PC or NULL if none found. */ struct obj_section * find_pc_section (CORE_ADDR pc) { - return find_pc_sect_section (pc, find_pc_mapped_section (pc)); + struct objfile_pspace_info *pspace_info; + struct obj_section *s, **sp; + + /* Check for mapped overlay section first. */ + s = find_pc_mapped_section (pc); + if (s) + return s; + + pspace_info = get_objfile_pspace_data (current_program_space); + if (pspace_info->objfiles_changed_p != 0) + { + update_section_map (current_program_space, + &pspace_info->sections, + &pspace_info->num_sections); + + /* Don't need updates to section map until objfiles are added, + removed or relocated. */ + pspace_info->objfiles_changed_p = 0; + } + + /* The C standard (ISO/IEC 9899:TC2) requires the BASE argument to + bsearch be non-NULL. */ + if (pspace_info->sections == NULL) + { + gdb_assert (pspace_info->num_sections == 0); + return NULL; + } + + sp = (struct obj_section **) bsearch (&pc, + pspace_info->sections, + pspace_info->num_sections, + sizeof (*pspace_info->sections), + bsearch_cmp); + if (sp != NULL) + return *sp; + return NULL; } @@ -1075,24 +1363,205 @@ in_plt_section (CORE_ADDR pc, char *name) retval = (s != NULL && s->the_bfd_section->name != NULL - && STREQ (s->the_bfd_section->name, ".plt")); + && strcmp (s->the_bfd_section->name, ".plt") == 0); return (retval); } + + +/* Keep a registry of per-objfile data-pointers required by other GDB + modules. */ + +struct objfile_data +{ + unsigned index; + void (*save) (struct objfile *, void *); + void (*free) (struct objfile *, void *); +}; + +struct objfile_data_registration +{ + struct objfile_data *data; + struct objfile_data_registration *next; +}; + +struct objfile_data_registry +{ + struct objfile_data_registration *registrations; + unsigned num_registrations; +}; + +static struct objfile_data_registry objfile_data_registry = { NULL, 0 }; + +const struct objfile_data * +register_objfile_data_with_cleanup (void (*save) (struct objfile *, void *), + void (*free) (struct objfile *, void *)) +{ + struct objfile_data_registration **curr; + + /* Append new registration. */ + for (curr = &objfile_data_registry.registrations; + *curr != NULL; curr = &(*curr)->next); + + *curr = XMALLOC (struct objfile_data_registration); + (*curr)->next = NULL; + (*curr)->data = XMALLOC (struct objfile_data); + (*curr)->data->index = objfile_data_registry.num_registrations++; + (*curr)->data->save = save; + (*curr)->data->free = free; + + return (*curr)->data; +} + +const struct objfile_data * +register_objfile_data (void) +{ + return register_objfile_data_with_cleanup (NULL, NULL); +} + +static void +objfile_alloc_data (struct objfile *objfile) +{ + gdb_assert (objfile->data == NULL); + objfile->num_data = objfile_data_registry.num_registrations; + objfile->data = XCALLOC (objfile->num_data, void *); +} + +static void +objfile_free_data (struct objfile *objfile) +{ + gdb_assert (objfile->data != NULL); + clear_objfile_data (objfile); + xfree (objfile->data); + objfile->data = NULL; +} + +void +clear_objfile_data (struct objfile *objfile) +{ + struct objfile_data_registration *registration; + int i; + + gdb_assert (objfile->data != NULL); + + /* Process all the save handlers. */ + + for (registration = objfile_data_registry.registrations, i = 0; + i < objfile->num_data; + registration = registration->next, i++) + if (objfile->data[i] != NULL && registration->data->save != NULL) + registration->data->save (objfile, objfile->data[i]); + + /* Now process all the free handlers. */ + + for (registration = objfile_data_registry.registrations, i = 0; + i < objfile->num_data; + registration = registration->next, i++) + if (objfile->data[i] != NULL && registration->data->free != NULL) + registration->data->free (objfile, objfile->data[i]); + + memset (objfile->data, 0, objfile->num_data * sizeof (void *)); +} -/* Return nonzero if NAME is in the import list of OBJFILE. Else - return zero. */ +void +set_objfile_data (struct objfile *objfile, const struct objfile_data *data, + void *value) +{ + gdb_assert (data->index < objfile->num_data); + objfile->data[data->index] = value; +} + +void * +objfile_data (struct objfile *objfile, const struct objfile_data *data) +{ + gdb_assert (data->index < objfile->num_data); + return objfile->data[data->index]; +} + +/* Set objfiles_changed_p so section map will be rebuilt next time it + is used. Called by reread_symbols. */ + +void +objfiles_changed (void) +{ + /* Rebuild section map next time we need it. */ + get_objfile_pspace_data (current_program_space)->objfiles_changed_p = 1; +} + +/* Close ABFD, and warn if that fails. */ int -is_in_import_list (char *name, struct objfile *objfile) +gdb_bfd_close_or_warn (struct bfd *abfd) { - register int i; + int ret; + char *name = bfd_get_filename (abfd); - if (!objfile || !name || !*name) - return 0; + ret = bfd_close (abfd); - for (i = 0; i < objfile->import_list_size; i++) - if (objfile->import_list[i] && STREQ (name, objfile->import_list[i])) - return 1; - return 0; + if (!ret) + warning (_("cannot close \"%s\": %s"), + name, bfd_errmsg (bfd_get_error ())); + + return ret; +} + +/* Add reference to ABFD. Returns ABFD. */ +struct bfd * +gdb_bfd_ref (struct bfd *abfd) +{ + int *p_refcount; + + if (abfd == NULL) + return NULL; + + p_refcount = bfd_usrdata (abfd); + + if (p_refcount != NULL) + { + *p_refcount += 1; + return abfd; + } + + p_refcount = xmalloc (sizeof (*p_refcount)); + *p_refcount = 1; + bfd_usrdata (abfd) = p_refcount; + + return abfd; } +/* Unreference and possibly close ABFD. */ +void +gdb_bfd_unref (struct bfd *abfd) +{ + int *p_refcount; + char *name; + + if (abfd == NULL) + return; + + p_refcount = bfd_usrdata (abfd); + + /* Valid range for p_refcount: a pointer to int counter, which has a + value of 1 (single owner) or 2 (shared). */ + gdb_assert (*p_refcount == 1 || *p_refcount == 2); + + *p_refcount -= 1; + if (*p_refcount > 0) + return; + + xfree (p_refcount); + bfd_usrdata (abfd) = NULL; /* Paranoia. */ + + name = bfd_get_filename (abfd); + gdb_bfd_close_or_warn (abfd); + xfree (name); +} + +/* Provide a prototype to silence -Wmissing-prototypes. */ +extern initialize_file_ftype _initialize_objfiles; + +void +_initialize_objfiles (void) +{ + objfiles_pspace_data + = register_program_space_data_with_cleanup (objfiles_pspace_data_cleanup); +}