X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=gdb%2Fsolib-target.c;h=ba056478c061f22deb9dc692c2f324ce430c8a2f;hb=refs%2Fheads%2Fconcurrent-displaced-stepping-2020-04-01;hp=f14363a4d9812517f8aedb7dbd3e34315eb77817;hpb=8847cac2f7ce6ff2c13fa611660c2dfc59c78272;p=deliverable%2Fbinutils-gdb.git diff --git a/gdb/solib-target.c b/gdb/solib-target.c index f14363a4d9..ba056478c0 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -1,6 +1,6 @@ /* Definitions for targets which report shared library events. - Copyright (C) 2007-2015 Free Software Foundation, Inc. + Copyright (C) 2007-2020 Free Software Foundation, Inc. This file is part of GDB. @@ -23,38 +23,37 @@ #include "symtab.h" #include "symfile.h" #include "target.h" -#include "vec.h" #include "solib-target.h" +#include /* Private data for each loaded library. */ -struct lm_info +struct lm_info_target : public lm_info_base { /* The library's name. The name is normally kept in the struct so_list; it is only here during XML parsing. */ - char *name; + std::string name; /* The target can either specify segment bases or section bases, not both. */ /* The base addresses for each independently relocatable segment of this shared library. */ - VEC(CORE_ADDR) *segment_bases; + std::vector segment_bases; /* The base addresses for each independently allocatable, relocatable section of this shared library. */ - VEC(CORE_ADDR) *section_bases; + std::vector section_bases; /* The cached offsets for each section of this shared library, determined from SEGMENT_BASES, or SECTION_BASES. */ - struct section_offsets *offsets; + section_offsets offsets; }; -typedef struct lm_info *lm_info_p; -DEF_VEC_P(lm_info_p); +typedef std::vector> lm_info_vector; #if !defined(HAVE_LIBEXPAT) -static VEC(lm_info_p) * +static lm_info_vector solib_target_parse_libraries (const char *library) { static int have_warned; @@ -66,7 +65,7 @@ solib_target_parse_libraries (const char *library) "at compile time")); } - return NULL; + return lm_info_vector (); } #else /* HAVE_LIBEXPAT */ @@ -78,35 +77,39 @@ solib_target_parse_libraries (const char *library) static void library_list_start_segment (struct gdb_xml_parser *parser, const struct gdb_xml_element *element, - void *user_data, VEC(gdb_xml_value_s) *attributes) + void *user_data, + std::vector &attributes) { - VEC(lm_info_p) **list = user_data; - struct lm_info *last = VEC_last (lm_info_p, *list); - ULONGEST *address_p = xml_find_attribute (attributes, "address")->value; + lm_info_vector *list = (lm_info_vector *) user_data; + lm_info_target *last = list->back ().get (); + ULONGEST *address_p + = (ULONGEST *) xml_find_attribute (attributes, "address")->value.get (); CORE_ADDR address = (CORE_ADDR) *address_p; - if (last->section_bases != NULL) + if (!last->section_bases.empty ()) gdb_xml_error (parser, _("Library list with both segments and sections")); - VEC_safe_push (CORE_ADDR, last->segment_bases, address); + last->segment_bases.push_back (address); } static void library_list_start_section (struct gdb_xml_parser *parser, const struct gdb_xml_element *element, - void *user_data, VEC(gdb_xml_value_s) *attributes) + void *user_data, + std::vector &attributes) { - VEC(lm_info_p) **list = user_data; - struct lm_info *last = VEC_last (lm_info_p, *list); - ULONGEST *address_p = xml_find_attribute (attributes, "address")->value; + lm_info_vector *list = (lm_info_vector *) user_data; + lm_info_target *last = list->back ().get (); + ULONGEST *address_p + = (ULONGEST *) xml_find_attribute (attributes, "address")->value.get (); CORE_ADDR address = (CORE_ADDR) *address_p; - if (last->segment_bases != NULL) + if (!last->segment_bases.empty ()) gdb_xml_error (parser, _("Library list with both segments and sections")); - VEC_safe_push (CORE_ADDR, last->section_bases, address); + last->section_bases.push_back (address); } /* Handle the start of a element. */ @@ -114,14 +117,15 @@ library_list_start_section (struct gdb_xml_parser *parser, static void library_list_start_library (struct gdb_xml_parser *parser, const struct gdb_xml_element *element, - void *user_data, VEC(gdb_xml_value_s) *attributes) + void *user_data, + std::vector &attributes) { - VEC(lm_info_p) **list = user_data; - struct lm_info *item = XCNEW (struct lm_info); - const char *name = xml_find_attribute (attributes, "name")->value; + lm_info_vector *list = (lm_info_vector *) user_data; + lm_info_target *item = new lm_info_target; + item->name + = (const char *) xml_find_attribute (attributes, "name")->value.get (); - item->name = xstrdup (name); - VEC_safe_push (lm_info_p, *list, item); + list->emplace_back (item); } static void @@ -129,13 +133,11 @@ library_list_end_library (struct gdb_xml_parser *parser, const struct gdb_xml_element *element, void *user_data, const char *body_text) { - VEC(lm_info_p) **list = user_data; - struct lm_info *lm_info = VEC_last (lm_info_p, *list); + lm_info_vector *list = (lm_info_vector *) user_data; + lm_info_target *lm_info = list->back ().get (); - if (lm_info->segment_bases == NULL - && lm_info->section_bases == NULL) - gdb_xml_error (parser, - _("No segment or section bases defined")); + if (lm_info->segment_bases.empty () && lm_info->section_bases.empty ()) + gdb_xml_error (parser, _("No segment or section bases defined")); } @@ -144,42 +146,23 @@ library_list_end_library (struct gdb_xml_parser *parser, static void library_list_start_list (struct gdb_xml_parser *parser, const struct gdb_xml_element *element, - void *user_data, VEC(gdb_xml_value_s) *attributes) + void *user_data, + std::vector &attributes) { struct gdb_xml_value *version = xml_find_attribute (attributes, "version"); /* #FIXED attribute may be omitted, Expat returns NULL in such case. */ if (version != NULL) { - const char *string = version->value; + const char *string = (const char *) version->value.get (); if (strcmp (string, "1.0") != 0) gdb_xml_error (parser, _("Library list has unsupported version \"%s\""), - version); + string); } } -/* Discard the constructed library list. */ - -static void -solib_target_free_library_list (void *p) -{ - VEC(lm_info_p) **result = p; - struct lm_info *info; - int ix; - - for (ix = 0; VEC_iterate (lm_info_p, *result, ix, info); ix++) - { - xfree (info->name); - VEC_free (CORE_ADDR, info->segment_bases); - VEC_free (CORE_ADDR, info->section_bases); - xfree (info); - } - VEC_free (lm_info_p, *result); - *result = NULL; -} - /* The allowed elements and attributes for an XML library list. The root element is a . */ @@ -226,23 +209,20 @@ static const struct gdb_xml_element library_list_elements[] = { { NULL, NULL, NULL, GDB_XML_EF_NONE, NULL, NULL } }; -static VEC(lm_info_p) * +static lm_info_vector solib_target_parse_libraries (const char *library) { - VEC(lm_info_p) *result = NULL; - struct cleanup *back_to = make_cleanup (solib_target_free_library_list, - &result); + lm_info_vector result; if (gdb_xml_parse_quick (_("target library list"), "library-list.dtd", library_list_elements, library, &result) == 0) { - /* Parsed successfully, keep the result. */ - discard_cleanups (back_to); + /* Parsed successfully. */ return result; } - do_cleanups (back_to); - return NULL; + result.clear (); + return result; } #endif @@ -250,45 +230,36 @@ static struct so_list * solib_target_current_sos (void) { struct so_list *new_solib, *start = NULL, *last = NULL; - char *library_document; - struct cleanup *old_chain; - VEC(lm_info_p) *library_list; - struct lm_info *info; - int ix; /* Fetch the list of shared libraries. */ - library_document = target_read_stralloc (¤t_target, - TARGET_OBJECT_LIBRARIES, - NULL); - if (library_document == NULL) + gdb::optional library_document + = target_read_stralloc (current_top_target (), TARGET_OBJECT_LIBRARIES, + NULL); + if (!library_document) return NULL; - /* solib_target_parse_libraries may throw, so we use a cleanup. */ - old_chain = make_cleanup (xfree, library_document); - /* Parse the list. */ - library_list = solib_target_parse_libraries (library_document); + lm_info_vector library_list + = solib_target_parse_libraries (library_document->data ()); - /* library_document string is not needed behind this point. */ - do_cleanups (old_chain); - - if (library_list == NULL) + if (library_list.empty ()) return NULL; /* Build a struct so_list for each entry on the list. */ - for (ix = 0; VEC_iterate (lm_info_p, library_list, ix, info); ix++) + for (auto &&info : library_list) { new_solib = XCNEW (struct so_list); - strncpy (new_solib->so_name, info->name, SO_NAME_MAX_PATH_SIZE - 1); + strncpy (new_solib->so_name, info->name.c_str (), + SO_NAME_MAX_PATH_SIZE - 1); new_solib->so_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0'; - strncpy (new_solib->so_original_name, info->name, + strncpy (new_solib->so_original_name, info->name.c_str (), SO_NAME_MAX_PATH_SIZE - 1); new_solib->so_original_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0'; - new_solib->lm_info = info; /* We no longer need this copy of the name. */ - xfree (info->name); - info->name = NULL; + info->name.clear (); + + new_solib->lm_info = info.release (); /* Add it to the list. */ if (!start) @@ -300,18 +271,9 @@ solib_target_current_sos (void) } } - /* Free the library list, but not its members. */ - VEC_free (lm_info_p, library_list); - return start; } -static void -solib_target_special_symbol_handling (void) -{ - /* Nothing needed. */ -} - static void solib_target_solib_create_inferior_hook (int from_tty) { @@ -327,10 +289,11 @@ solib_target_clear_solib (void) static void solib_target_free_so (struct so_list *so) { - gdb_assert (so->lm_info->name == NULL); - xfree (so->lm_info->offsets); - VEC_free (CORE_ADDR, so->lm_info->segment_bases); - xfree (so->lm_info); + lm_info_target *li = (lm_info_target *) so->lm_info; + + gdb_assert (li->name.empty ()); + + delete li; } static void @@ -338,30 +301,29 @@ solib_target_relocate_section_addresses (struct so_list *so, struct target_section *sec) { CORE_ADDR offset; + lm_info_target *li = (lm_info_target *) so->lm_info; /* Build the offset table only once per object file. We can not do it any earlier, since we need to open the file first. */ - if (so->lm_info->offsets == NULL) + if (li->offsets.empty ()) { int num_sections = gdb_bfd_count_sections (so->abfd); - so->lm_info->offsets = xzalloc (SIZEOF_N_SECTION_OFFSETS (num_sections)); + li->offsets.assign (num_sections, 0); - if (so->lm_info->section_bases) + if (!li->section_bases.empty ()) { int i; asection *sect; - int num_section_bases - = VEC_length (CORE_ADDR, so->lm_info->section_bases); int num_alloc_sections = 0; for (i = 0, sect = so->abfd->sections; sect != NULL; i++, sect = sect->next) - if ((bfd_get_section_flags (so->abfd, sect) & SEC_ALLOC)) + if ((bfd_section_flags (sect) & SEC_ALLOC)) num_alloc_sections++; - if (num_alloc_sections != num_section_bases) + if (num_alloc_sections != li->section_bases.size ()) warning (_("\ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), so->so_name); @@ -369,10 +331,6 @@ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), { int bases_index = 0; int found_range = 0; - CORE_ADDR *section_bases; - - section_bases = VEC_address (CORE_ADDR, - so->lm_info->section_bases); so->addr_low = ~(CORE_ADDR) 0; so->addr_high = 0; @@ -380,14 +338,14 @@ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), sect != NULL; i++, sect = sect->next) { - if (!(bfd_get_section_flags (so->abfd, sect) & SEC_ALLOC)) + if (!(bfd_section_flags (sect) & SEC_ALLOC)) continue; - if (bfd_section_size (so->abfd, sect) > 0) + if (bfd_section_size (sect) > 0) { CORE_ADDR low, high; - low = section_bases[i]; - high = low + bfd_section_size (so->abfd, sect) - 1; + low = li->section_bases[i]; + high = low + bfd_section_size (sect) - 1; if (low < so->addr_low) so->addr_low = low; @@ -396,8 +354,7 @@ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), gdb_assert (so->addr_low <= so->addr_high); found_range = 1; } - so->lm_info->offsets->offsets[i] - = section_bases[bases_index]; + li->offsets[i] = li->section_bases[bases_index]; bases_index++; } if (!found_range) @@ -405,11 +362,11 @@ Could not relocate shared library \"%s\": wrong number of ALLOC sections"), gdb_assert (so->addr_low <= so->addr_high); } } - else if (so->lm_info->segment_bases) + else if (!li->segment_bases.empty ()) { - struct symfile_segment_data *data; + symfile_segment_data_up data + = get_symfile_segment_data (so->abfd); - data = get_symfile_segment_data (so->abfd); if (data == NULL) warning (_("\ Could not relocate shared library \"%s\": no segments"), so->so_name); @@ -417,58 +374,51 @@ Could not relocate shared library \"%s\": no segments"), so->so_name); { ULONGEST orig_delta; int i; - int num_bases; - CORE_ADDR *segment_bases; - num_bases = VEC_length (CORE_ADDR, so->lm_info->segment_bases); - segment_bases = VEC_address (CORE_ADDR, - so->lm_info->segment_bases); - - if (!symfile_map_offsets_to_segments (so->abfd, data, - so->lm_info->offsets, - num_bases, segment_bases)) + if (!symfile_map_offsets_to_segments (so->abfd, data.get (), + li->offsets, + li->segment_bases.size (), + li->segment_bases.data ())) warning (_("\ Could not relocate shared library \"%s\": bad offsets"), so->so_name); /* Find the range of addresses to report for this library in "info sharedlibrary". Report any consecutive segments which were relocated as a single unit. */ - gdb_assert (num_bases > 0); - orig_delta = segment_bases[0] - data->segment_bases[0]; + gdb_assert (li->segment_bases.size () > 0); + orig_delta = li->segment_bases[0] - data->segments[0].base; - for (i = 1; i < data->num_segments; i++) + for (i = 1; i < data->segments.size (); i++) { /* If we have run out of offsets, assume all remaining segments have the same offset. */ - if (i >= num_bases) + if (i >= li->segment_bases.size ()) continue; /* If this segment does not have the same offset, do not include it in the library's range. */ - if (segment_bases[i] - data->segment_bases[i] != orig_delta) + if (li->segment_bases[i] - data->segments[i].base + != orig_delta) break; } - so->addr_low = segment_bases[0]; - so->addr_high = (data->segment_bases[i - 1] - + data->segment_sizes[i - 1] + so->addr_low = li->segment_bases[0]; + so->addr_high = (data->segments[i - 1].base + + data->segments[i - 1].size + orig_delta); gdb_assert (so->addr_low <= so->addr_high); - - free_symfile_segment_data (data); } } } - offset = so->lm_info->offsets->offsets[gdb_bfd_section_index - (sec->the_bfd_section->owner, - sec->the_bfd_section)]; + offset = li->offsets[gdb_bfd_section_index (sec->the_bfd_section->owner, + sec->the_bfd_section)]; sec->addr += offset; sec->endaddr += offset; } static int -solib_target_open_symbol_file_object (void *from_ttyp) +solib_target_open_symbol_file_object (int from_tty) { /* We can't locate the main symbol file based on the target's knowledge; the user has to specify it. */ @@ -486,11 +436,9 @@ solib_target_in_dynsym_resolve_code (CORE_ADDR pc) struct target_so_ops solib_target_so_ops; -/* -Wmissing-prototypes */ -extern initialize_file_ftype _initialize_solib_target; - +void _initialize_solib_target (); void -_initialize_solib_target (void) +_initialize_solib_target () { solib_target_so_ops.relocate_section_addresses = solib_target_relocate_section_addresses; @@ -498,8 +446,6 @@ _initialize_solib_target (void) solib_target_so_ops.clear_solib = solib_target_clear_solib; solib_target_so_ops.solib_create_inferior_hook = solib_target_solib_create_inferior_hook; - solib_target_so_ops.special_symbol_handling - = solib_target_special_symbol_handling; solib_target_so_ops.current_sos = solib_target_current_sos; solib_target_so_ops.open_symbol_file_object = solib_target_open_symbol_file_object;