X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=plugins%2Futils%2Ftrimmer%2Ftrimmer.c;h=4806dc6ffdedff932b3769f6785eda6e1aae0242;hb=f6ccaed94e575af57fe6bf38154771bee4871a2a;hp=352b0cffa3405d2cdab76985548c00e249cb9f33;hpb=4fde0f03fe680be7f1086adf2f5357ea517c8caa;p=babeltrace.git

diff --git a/plugins/utils/trimmer/trimmer.c b/plugins/utils/trimmer/trimmer.c
index 352b0cff..4806dc6f 100644
--- a/plugins/utils/trimmer/trimmer.c
+++ b/plugins/utils/trimmer/trimmer.c
@@ -30,19 +30,11 @@
 #include "logging.h"
 
 #include <babeltrace/compat/utc-internal.h>
-#include <babeltrace/plugin/plugin-dev.h>
-#include <babeltrace/graph/component.h>
-#include <babeltrace/graph/private-component.h>
-#include <babeltrace/graph/component-filter.h>
-#include <babeltrace/graph/notification.h>
-#include <babeltrace/graph/notification-iterator.h>
-#include <babeltrace/graph/private-notification-iterator.h>
-#include <babeltrace/graph/private-component-filter.h>
-#include <babeltrace/graph/notification-event.h>
+#include <babeltrace/babeltrace.h>
 #include <plugins-common.h>
 #include "trimmer.h"
 #include "iterator.h"
-#include <assert.h>
+#include <babeltrace/assert-internal.h>
 
 static
 void destroy_trimmer_data(struct trimmer *trimmer)
@@ -80,12 +72,25 @@ void finalize_trimmer(struct bt_private_component *component)
  *   ss
  */
 static
-int timestamp_from_arg(const char *arg, struct trimmer *trimmer,
-		struct trimmer_bound *result_bound, bt_bool gmt)
+int timestamp_from_param(const char *param_name, struct bt_value *param,
+		struct trimmer *trimmer, struct trimmer_bound *result_bound,
+		bt_bool gmt)
 {
 	int ret;
 	int64_t value;
 	unsigned int year, month, day, hh, mm, ss, ns;
+	const char *arg;
+
+	if (bt_value_is_integer(param)) {
+		(void) bt_value_integer_get(param, &value);
+		goto set;
+	} else if (!bt_value_is_string(param)) {
+		BT_LOGE("`%s` parameter must be an integer or a string value.",
+			param_name);
+		goto error;
+	}
+
+	(void) bt_value_string_get(param, &arg);
 
 	/* YYYY-MM-DD hh:mm:ss.ns */
 	ret = sscanf(arg, "%u-%u-%u %u:%u:%u.%u",
@@ -271,6 +276,7 @@ int timestamp_from_arg(const char *arg, struct trimmer *trimmer,
 		goto set;
 	}
 
+error:
 	/* Not found. */
 	return -1;
 
@@ -292,7 +298,7 @@ enum bt_component_status init_from_params(struct trimmer *trimmer,
 	bt_bool gmt = BT_FALSE;
 	enum bt_component_status ret = BT_COMPONENT_STATUS_OK;
 
-	assert(params);
+	BT_ASSERT(params);
 
         value = bt_value_map_get(params, "clock-gmt");
 	if (value) {
@@ -304,42 +310,35 @@ enum bt_component_status init_from_params(struct trimmer *trimmer,
 			BT_LOGE_STR("Failed to retrieve clock-gmt value. Expecting a boolean");
 		}
 	}
-	bt_put(value);
 	if (ret != BT_COMPONENT_STATUS_OK) {
 		goto end;
 	}
 
+	BT_PUT(value);
         value = bt_value_map_get(params, "begin");
 	if (value) {
-		enum bt_value_status value_ret;
-		const char *str;
-
-		value_ret = bt_value_string_get(value, &str);
-		if (value_ret || timestamp_from_arg(str,
+		if (timestamp_from_param("begin", value,
 				trimmer, &trimmer->begin, gmt)) {
+			BT_LOGE_STR("Failed to convert `begin` parameter to a timestamp.");
 			ret = BT_COMPONENT_STATUS_INVALID;
-			BT_LOGE_STR("Failed to retrieve begin value. Expecting a timestamp string");
+			goto end;
 		}
 	}
-	bt_put(value);
-	if (ret != BT_COMPONENT_STATUS_OK) {
-		goto end;
-	}
 
+	BT_PUT(value);
         value = bt_value_map_get(params, "end");
 	if (value) {
-		enum bt_value_status value_ret;
-		const char *str;
-
-		value_ret = bt_value_string_get(value, &str);
-		if (value_ret || timestamp_from_arg(str,
+		if (timestamp_from_param("end", value,
 				trimmer, &trimmer->end, gmt)) {
+			BT_LOGE_STR("Failed to convert `end` parameter to a timestamp.");
 			ret = BT_COMPONENT_STATUS_INVALID;
-			BT_LOGE_STR("Failed to retrieve end value. Expecting a timestamp string");
+			goto end;
 		}
 	}
-	bt_put(value);
+
 end:
+	bt_put(value);
+
 	if (trimmer->begin.set && trimmer->end.set) {
 		if (trimmer->begin.value > trimmer->end.value) {
 			BT_LOGE_STR("Unexpected: time range begin value is above end value");